Datasets:

labofsahil

/

github-event-dataset-2013

like 0

Follow

Sahil 2

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/8132667","id":8132667,"diff_hunk":"@@ -140,7 +140,6 @@ Evme.BackgroundImage = new function Evme_BackgroundImage() {\n ')\"></div>' +\n '<div class=\"content\">' +\n '<b class=\"rightbutton\"></b>' +\n- '<span class=\"separator\"></span>' +","path":"apps/homescreen/everything.me/modules/BackgroundImage/BackgroundImage.js","position":4,"original_position":4,"commit_id":"17b57873e0ae56dd341b738c46bbabea37d029fd","original_commit_id":"17b57873e0ae56dd341b738c46bbabea37d029fd","user":{"login":"ranbena","id":486954,"avatar_url":"https://2.gravatar.com/avatar/eba21d4c1a3927d9b282814c8679a230?d=https%3A%2F%2Fidenticons.github.com%2F0619e0892692ada9c4cda5498bcd9eb6.png&r=x","gravatar_id":"eba21d4c1a3927d9b282814c8679a230","url":"https://api.github.com/users/ranbena","html_url":"https://github.com/ranbena","followers_url":"https://api.github.com/users/ranbena/followers","following_url":"https://api.github.com/users/ranbena/following{/other_user}","gists_url":"https://api.github.com/users/ranbena/gists{/gist_id}","starred_url":"https://api.github.com/users/ranbena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranbena/subscriptions","organizations_url":"https://api.github.com/users/ranbena/orgs","repos_url":"https://api.github.com/users/ranbena/repos","events_url":"https://api.github.com/users/ranbena/events{/privacy}","received_events_url":"https://api.github.com/users/ranbena/received_events","type":"User","site_admin":false},"body":"@evyatron I removed this element. Not needed.","created_at":"2013-12-05T15:43:15Z","updated_at":"2013-12-05T15:43:15Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/14171#discussion_r8132667","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/14171","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/8132667"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/14171#discussion_r8132667"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/14171"}}}}

{"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1433,"stargazers":1433,"forks":1187,"fork":false,"size":748674,"owner":"mozilla-b2g","private":false,"open_issues":938,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-12-05T07:34:44-08:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Ran Ben Aharon","company":"Everything.me","blog":"http://ranbena.com","location":"Israel","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla-b2g/gaia/pull/14171#discussion_r8132667"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/4750592","id":4750592,"body":"proposition: create eg `attachments-1000.tar.gz` instead of `smsDb-1000/Attachments.tar.gz`. This archive would contain the smsDb-1000 directory. I find this is cleaner that archives extract their content inside a subdirectory.\r\n\r\nThe command to create it is `tar cvzf attachments-1000.tar.gz \"$ATTACHMENT_DIR/\"`","diff_hunk":"@@ -131,7 +131,18 @@ for app in $APPS; do\n ;;\n \n sms)\n+ ATTACHMENT_DIR=$SCRIPT_DIR/smsDb-$SMS_COUNT\n+ UNZIPPED=$(ls -l $ATTACHMENT_DIR | grep \"Attachments.tar.gz\")\n+ if [ -z \"$UNZIPPED\" ]; then\n+ # zip with: tar --remove-files -cvzf $ATTACHMENT_DIR/Attachments.tar.gz $ATTACHMENT_DIR/*","path":"test_media/reference-workload/makeReferenceWorkload.sh","position":7,"original_position":7,"commit_id":"7b4949262f5fa5782b497fb64c4bf469358a8666","original_commit_id":"7b4949262f5fa5782b497fb64c4bf469358a8666","user":{"login":"julienw","id":454175,"avatar_url":"https://secure.gravatar.com/avatar/a2b625f331361a7110da59a907d79e95?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"a2b625f331361a7110da59a907d79e95","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User"},"created_at":"2013-06-18T15:18:33Z","updated_at":"2013-06-18T15:18:33Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/10446#discussion_r4750592","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/10446","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/4750592"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/10446#discussion_r4750592"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/10446"}}}}

{"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1201,"stargazers":1201,"forks":807,"fork":false,"size":23624,"owner":"mozilla-b2g","private":false,"open_issues":56,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-06-18T08:03:41-07:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Julien Wajsberg","company":"Mozilla","blog":"http://everlong.org/","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla-b2g/gaia/pull/10446#discussion_r4750592"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/3073386","id":3073386,"body":"Have you tested this without applying the video patch? It seems like this might be something we should land independently. Should this patch go on v1-train, for example?","path":"apps/system/js/window_manager.js","position":7,"original_position":7,"commit_id":"5b6209138bec1519d2c795288f94e5fbc2f967e9","original_commit_id":"5b6209138bec1519d2c795288f94e5fbc2f967e9","user":{"login":"davidflanagan","id":516914,"avatar_url":"https://secure.gravatar.com/avatar/a7cc58f54d25826ac0568490237b959d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"a7cc58f54d25826ac0568490237b959d","url":"https://api.github.com/users/davidflanagan","html_url":"https://github.com/davidflanagan","followers_url":"https://api.github.com/users/davidflanagan/followers","following_url":"https://api.github.com/users/davidflanagan/following","gists_url":"https://api.github.com/users/davidflanagan/gists{/gist_id}","starred_url":"https://api.github.com/users/davidflanagan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidflanagan/subscriptions","organizations_url":"https://api.github.com/users/davidflanagan/orgs","repos_url":"https://api.github.com/users/davidflanagan/repos","events_url":"https://api.github.com/users/davidflanagan/events{/privacy}","received_events_url":"https://api.github.com/users/davidflanagan/received_events","type":"User"},"created_at":"2013-02-20T00:44:50Z","updated_at":"2013-02-20T00:44:50Z","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/3073386"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/8160#discussion_r3073386"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/8160"}}}}

{"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1031,"stargazers":1031,"forks":555,"fork":false,"size":12940,"owner":"mozilla-b2g","private":false,"open_issues":410,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-02-19T11:38:28-08:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"name":"David Flanagan","blog":"http://davidflanagan.com","type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla-b2g/gaia/pull/8160#discussion_r3073386"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/6106183","id":6106183,"body":"remove the space within `! rowLimit`.","diff_hunk":"@@ -238,117 +240,231 @@ const IMERender = (function() {\n }\n };\n \n+ var toggleCandidatePanel = function(expand) {\n+ var candidatePanel = document.getElementById('keyboard-candidate-panel');\n+ var candidatePanelToggleButton =\n+ document.getElementById('keyboard-candidate-panel-toggle-button');\n+\n+ var unitWidth = Math.floor(document.getElementById('keyboard').clientWidth /\n+ numberOfCandidatesPerRow);\n+\n+ candidatePanel.scrollTop = candidatePanel.scrollLeft = 0;\n+\n+ if (expand) {\n+ IMERender.ime.classList.remove('candidate-panel');\n+ IMERender.ime.classList.add('full-candidate-panel');\n+ candidatePanelToggleButton.style.width = (unitWidth - 8) + 'px';\n+ } else {\n+ IMERender.ime.classList.remove('full-candidate-panel');\n+ IMERender.ime.classList.add('candidate-panel');\n+ candidatePanelToggleButton.style.width = unitWidth + 'px';\n+ }\n+ };\n+\n // Show candidates\n // Each candidate is a string or an array of two strings\n var showCandidates = function(candidates, noWindowHeightUpdate) {\n // TODO: Save the element\n var candidatePanel = document.getElementById('keyboard-candidate-panel');\n+ var candidatePanelToggleButton =\n+ document.getElementById('keyboard-candidate-panel-toggle-button');\n \n if (candidatePanel) {\n+ candidatePanel.dataset.candidateIndicator = 0;\n+\n candidatePanel.innerHTML = '';\n candidatePanel.scrollTop = candidatePanel.scrollLeft = 0;\n \n- // If there were too many candidate\n- delete candidatePanel.dataset.truncated;\n- if (candidates.length > 74) {\n- candidates = candidates.slice(0, 74);\n- candidatePanel.dataset.truncated = true;\n- }\n+ var docFragment = document.createDocumentFragment();\n \n- // Make sure all of the candidates are defined\n- candidates = candidates.filter(function(c) { return !!c });\n-\n- candidates.forEach(function buildCandidateEntry(candidate) {\n- // Each candidate gets its own div\n- var div = document.createElement('div');\n- // Size the div based on the # of candidates (-2% for margins)\n- div.style.width = (100 / candidates.length - 2) + '%';\n- candidatePanel.appendChild(div);\n-\n- var text, data, correction = false;\n- if (typeof candidate === 'string') {\n- if (candidate[0] === '*') { // it is an autocorrection candidate\n- candidate = candidate.substring(1);\n- correction = true;\n- }\n- data = text = candidate;\n- }\n- else {\n- text = candidate[0];\n- data = candidate[1];\n- }\n+ if (inputMethodName == 'latin') {\n+ candidates.forEach(function buildCandidateEntry(candidate) {\n+ // Make sure all of the candidates are defined\n+ if (! candidate) return;\n \n- var span = fitText(div, text);\n- span.dataset.selection = true;\n- span.dataset.data = data;\n- if (correction)\n- span.classList.add('autocorrect');\n-\n- // Put the text in a span and make it fit in the container\n- function fitText(container, text) {\n- container.textContent = '';\n- if (!text)\n- return;\n- var span = document.createElement('span');\n- span.textContent = text;\n- container.appendChild(span);\n-\n- // Measure the width of the element, and return the scale that\n- // we can use to make it fit in the container. The return values\n- // are restricted to a set that matches the standard font sizes\n- // we use in Gaia.\n- //\n- // Note that this only works if the element is display:inline\n- function getScale(element, container) {\n- var elementWidth = element.getBoundingClientRect().width;\n- var s = container.clientWidth / elementWidth;\n- if (s >= 1)\n- return 1; // 10pt font \"Body Large\"\n- if (s >= .8)\n- return .8; // 8pt font \"Body\"\n- if (s >= .7)\n- return .7; // 7pt font \"Body Medium\"\n- if (s >= .65)\n- return .65; // 6.5pt font \"Body Small\"\n- if (s >= .6)\n- return .6; // 6pt font \"Body Mini\"\n- return s; // Something smaller than 6pt.\n- }\n+ // Each candidate gets its own div\n+ var div = document.createElement('div');\n+ // Size the div based on the # of candidates (-2% for margins)\n+ div.style.width = (100 / candidates.length - 2) + '%';\n+ docFragment.appendChild(div);\n \n- var limit = .6; // Dont use a scale smaller than this\n- var scale = getScale(span, container);\n-\n- // If the text does not fit within the scaling limit,\n- // reduce the length of the text by replacing characters in\n- // the middle with ...\n- if (scale < limit) {\n- var charactersReplaced = text.length % 2;\n- while (scale < limit && charactersReplaced < text.length - 2) {\n- charactersReplaced += 2;\n- var halflen = (text.length - charactersReplaced) / 2;\n- span.textContent = text.substring(0, halflen) +\n- '…' +\n- text.substring(text.length - halflen);\n- scale = getScale(span, container);\n+ var text, data, correction = false;\n+ if (typeof candidate === 'string') {\n+ if (candidate[0] === '*') { // it is an autocorrection candidate\n+ candidate = candidate.substring(1);\n+ correction = true;\n }\n- }\n-\n- // The scaling and centering we do only works if the span\n- // is display:block or inline-block\n- span.style.display = 'inline-block';\n- if (scale < 1) {\n- span.style.width = (100 / scale) + '%';\n- span.style.transformOrigin = 'left';\n- span.style.transform = 'scale(' + scale + ')';\n+ data = text = candidate;\n }\n else {\n- span.style.width = '100%';\n+ text = candidate[0];\n+ data = candidate[1];\n }\n \n- return span;\n+ var span = fitText(div, text);\n+ span.dataset.selection = true;\n+ span.dataset.data = data;\n+ if (correction)\n+ span.classList.add('autocorrect');\n+\n+ // Put the text in a span and make it fit in the container\n+ function fitText(container, text) {\n+ container.textContent = '';\n+ if (!text)\n+ return;\n+ var span = document.createElement('span');\n+ span.textContent = text;\n+ container.appendChild(span);\n+\n+ // Measure the width of the element, and return the scale that\n+ // we can use to make it fit in the container. The return values\n+ // are restricted to a set that matches the standard font sizes\n+ // we use in Gaia.\n+ //\n+ // Note that this only works if the element is display:inline\n+ function getScale(element, container) {\n+ var elementWidth = element.getBoundingClientRect().width;\n+ var s = container.clientWidth / elementWidth;\n+ if (s >= 1)\n+ return 1; // 10pt font \"Body Large\"\n+ if (s >= .8)\n+ return .8; // 8pt font \"Body\"\n+ if (s >= .7)\n+ return .7; // 7pt font \"Body Medium\"\n+ if (s >= .65)\n+ return .65; // 6.5pt font \"Body Small\"\n+ if (s >= .6)\n+ return .6; // 6pt font \"Body Mini\"\n+ return s; // Something smaller than 6pt.\n+ }\n+\n+ var limit = .6; // Dont use a scale smaller than this\n+ var scale = getScale(span, container);\n+\n+ // If the text does not fit within the scaling limit,\n+ // reduce the length of the text by replacing characters in\n+ // the middle with ...\n+ if (scale < limit) {\n+ var charactersReplaced = text.length % 2;\n+ while (scale < limit && charactersReplaced < text.length - 2) {\n+ charactersReplaced += 2;\n+ var halflen = (text.length - charactersReplaced) / 2;\n+ span.textContent = text.substring(0, halflen) +\n+ '…' +\n+ text.substring(text.length - halflen);\n+ scale = getScale(span, container);\n+ }\n+ }\n+\n+ // The scaling and centering we do only works if the span\n+ // is display:block or inline-block\n+ span.style.display = 'inline-block';\n+ if (scale < 1) {\n+ span.style.width = (100 / scale) + '%';\n+ span.style.transformOrigin = 'left';\n+ span.style.transform = 'scale(' + scale + ')';\n+ }\n+ else {\n+ span.style.width = '100%';\n+ }\n+\n+ return span;\n+ }\n+ });\n+ } else {\n+ candidatePanelToggleButton.style.display = 'none';\n+ docFragment = _layoutCandidates(candidates, 1, true);\n+ }\n+\n+ candidatePanel.appendChild(docFragment);\n+ }\n+ };\n+\n+ var showMoreCandidates = function(candidates, rowLimit) {\n+ if (! rowLimit) rowLimit = -1;","path":"apps/keyboard/js/render.js","position":244,"original_position":244,"commit_id":"e4906fb2ea9a8bd426459686d811c2b0af4857e0","original_commit_id":"e4906fb2ea9a8bd426459686d811c2b0af4857e0","user":{"login":"yxl","id":1262683,"avatar_url":"https://0.gravatar.com/avatar/b0245f4f45df30088776455a615604e6?d=https%3A%2F%2Fidenticons.github.com%2Fa73a1e361bd80d18d53cf1e0b582eb9b.png","gravatar_id":"b0245f4f45df30088776455a615604e6","url":"https://api.github.com/users/yxl","html_url":"https://github.com/yxl","followers_url":"https://api.github.com/users/yxl/followers","following_url":"https://api.github.com/users/yxl/following{/other_user}","gists_url":"https://api.github.com/users/yxl/gists{/gist_id}","starred_url":"https://api.github.com/users/yxl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yxl/subscriptions","organizations_url":"https://api.github.com/users/yxl/orgs","repos_url":"https://api.github.com/users/yxl/repos","events_url":"https://api.github.com/users/yxl/events{/privacy}","received_events_url":"https://api.github.com/users/yxl/received_events","type":"User"},"created_at":"2013-09-02T07:51:08Z","updated_at":"2013-09-02T07:51:08Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/11689#discussion_r6106183","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/11689","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/6106183"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/11689#discussion_r6106183"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/11689"}}}}

{"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1330,"stargazers":1330,"forks":971,"fork":false,"size":33488,"owner":"mozilla-b2g","private":false,"open_issues":780,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-09-01T19:40:56-07:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Yuan Xulei","company":"Mozilla Online","location":"Beijing, China","email":"[email protected]"},"url":"https://github.com/mozilla-b2g/gaia/pull/11689#discussion_r6106183"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/7437471","id":7437471,"diff_hunk":"@@ -2,20 +2,5 @@\n b2g = true\n online = true\n \n-[test_everythingme_launch_app.py]","path":"tests/python/gaia-ui-tests/gaiatest/tests/functional/everythingme/manifest.ini","position":4,"original_position":4,"commit_id":"aaa471084396adc0579bcda93cb1ddb924917b33","original_commit_id":"aaa471084396adc0579bcda93cb1ddb924917b33","user":{"login":"zacc","id":966053,"avatar_url":"https://0.gravatar.com/avatar/20ce4017c94c8c73dfa5937eaec3360b?d=https%3A%2F%2Fidenticons.github.com%2F58df9410e616db9356963f90593a0ab5.png&r=x","gravatar_id":"20ce4017c94c8c73dfa5937eaec3360b","url":"https://api.github.com/users/zacc","html_url":"https://github.com/zacc","followers_url":"https://api.github.com/users/zacc/followers","following_url":"https://api.github.com/users/zacc/following{/other_user}","gists_url":"https://api.github.com/users/zacc/gists{/gist_id}","starred_url":"https://api.github.com/users/zacc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zacc/subscriptions","organizations_url":"https://api.github.com/users/zacc/orgs","repos_url":"https://api.github.com/users/zacc/repos","events_url":"https://api.github.com/users/zacc/events{/privacy}","received_events_url":"https://api.github.com/users/zacc/received_events","type":"User","site_admin":false},"body":"Can you please re-add all of these other test files into this mainfest. They're really important!","created_at":"2013-11-05T17:13:18Z","updated_at":"2013-11-05T17:13:18Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/13353#discussion_r7437471","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/13353","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/7437471"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/13353#discussion_r7437471"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/13353"}}}}

{"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1408,"stargazers":1408,"forks":1102,"fork":false,"size":695078,"owner":"mozilla-b2g","private":false,"open_issues":857,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-11-05T08:21:19-08:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Zac","company":"Mozilla","location":"UK","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla-b2g/gaia/pull/13353#discussion_r7437471"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/6400035","id":6400035,"body":"Remove this","diff_hunk":"@@ -42,6 +46,24 @@ var FtuLauncher = {\n // Monitor appopen event\n // to unlock lockscreen if we are running FTU at first time\n window.addEventListener('appopen', this);\n+\n+ // Large devices will post ftudone message back\n+ // to prevent stopImmediatePropagation and make home button work\n+ window.navigator.mozSetMessageHandler('connection', function(request) {\n+ if (request.keyword !== 'ftudone') {\n+ return;\n+ }\n+\n+ var port = request.port;\n+ port.onmessage = function(evt) {\n+ var message = evt.data;\n+ console.log('got home !!!');","path":"apps/system/js/ftu_launcher.js","position":33,"original_position":33,"commit_id":"e3248cac38d75034019e10e71b17fc4026e59fec","original_commit_id":"e3248cac38d75034019e10e71b17fc4026e59fec","user":{"login":"alivedise","id":546519,"avatar_url":"https://1.gravatar.com/avatar/2200ce74246a04126cf04cfa39ff0c37?d=https%3A%2F%2Fidenticons.github.com%2F6ea87b4a42d4dfa60bd489c8fa95d658.png","gravatar_id":"2200ce74246a04126cf04cfa39ff0c37","url":"https://api.github.com/users/alivedise","html_url":"https://github.com/alivedise","followers_url":"https://api.github.com/users/alivedise/followers","following_url":"https://api.github.com/users/alivedise/following{/other_user}","gists_url":"https://api.github.com/users/alivedise/gists{/gist_id}","starred_url":"https://api.github.com/users/alivedise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alivedise/subscriptions","organizations_url":"https://api.github.com/users/alivedise/orgs","repos_url":"https://api.github.com/users/alivedise/repos","events_url":"https://api.github.com/users/alivedise/events{/privacy}","received_events_url":"https://api.github.com/users/alivedise/received_events","type":"User"},"created_at":"2013-09-17T09:36:27Z","updated_at":"2013-09-17T09:36:27Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/12213#discussion_r6400035","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/12213","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/6400035"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/12213#discussion_r6400035"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/12213"}}}}

{"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1342,"stargazers":1342,"forks":992,"fork":false,"size":623673,"owner":"mozilla-b2g","private":false,"open_issues":837,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-09-17T01:14:51-07:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Alive.Kuo","company":"Mozilla","blog":"alivedise.github.com","location":"Taiwan","email":"[email protected]"},"url":"https://github.com/mozilla-b2g/gaia/pull/12213#discussion_r6400035"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/8196973","id":8196973,"diff_hunk":"@@ -634,17 +638,8 @@ def manager(self):\n if not self.is_android_build:\n raise Exception('Device manager is only available for devices.')\n \n- dm_type = os.environ.get('DM_TRANS', 'adb')\n- if dm_type == 'adb':\n- self._manager = mozdevice.DeviceManagerADB()\n- elif dm_type == 'sut':\n- host = os.environ.get('TEST_DEVICE')\n- if not host:\n- raise Exception('Must specify host with SUT!')\n- self._manager = mozdevice.DeviceManagerSUT(host=host)\n else:\n- raise Exception('Unknown device manager type: %s' % dm_type)\n- return self._manager\n+ raise Exception('Must add device manager to GaiaDevice.')","path":"tests/python/gaia-ui-tests/gaiatest/gaia_test.py","position":46,"original_position":46,"commit_id":"dc585f36d215d2ddc6753ecbd239d5016278518e","original_commit_id":"dc585f36d215d2ddc6753ecbd239d5016278518e","user":{"login":"malini","id":24374,"avatar_url":"https://2.gravatar.com/avatar/833e9d43a7026d2553055e610ebb3e13?d=https%3A%2F%2Fidenticons.github.com%2F567ed37f3e011ed702bbf9d2631a1565.png&r=x","gravatar_id":"833e9d43a7026d2553055e610ebb3e13","url":"https://api.github.com/users/malini","html_url":"https://github.com/malini","followers_url":"https://api.github.com/users/malini/followers","following_url":"https://api.github.com/users/malini/following{/other_user}","gists_url":"https://api.github.com/users/malini/gists{/gist_id}","starred_url":"https://api.github.com/users/malini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malini/subscriptions","organizations_url":"https://api.github.com/users/malini/orgs","repos_url":"https://api.github.com/users/malini/repos","events_url":"https://api.github.com/users/malini/events{/privacy}","received_events_url":"https://api.github.com/users/malini/received_events","type":"User","site_admin":false},"body":"I've moved B2G specific device-manager code to a mixin contained in the marionette client (https://bugzilla.mozilla.org/attachment.cgi?id=8339508&action=diff#a/testing/marionette/client/marionette/runner/mixins/b2g.py_sec2) which will check for adb/sut and set up the device manager or retrieve a previously created instance of it. I modified GaiaDevice with an add_device_manager function to accept this new device_manager instance if it will be interacting with a device. An example of that in use is in this PR:\r\nhttps://github.com/malini/gaia/blob/dc585f36d215d2ddc6753ecbd239d5016278518e/tests/python/gaia-ui-tests/gaiatest/gaia_test.py#L761","created_at":"2013-12-09T13:52:05Z","updated_at":"2013-12-09T13:52:05Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/14476#discussion_r8196973","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/14476","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/8196973"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/14476#discussion_r8196973"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/14476"}}}}

{"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1436,"stargazers":1436,"forks":1203,"fork":false,"size":748529,"owner":"mozilla-b2g","private":false,"open_issues":960,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-12-09T03:12:12-08:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Malini Das","company":"Mozilla Corporation","blog":"nakubu.com","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla-b2g/gaia/pull/14476#discussion_r8196973"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/4697131","id":4697131,"body":"Please add the style to settings.css, then we don't need to create a new CSS file.","diff_hunk":"@@ -26,6 +26,7 @@\n <link rel=\"stylesheet\" type=\"text/css\" href=\"style/apps.css\"/>\n <link rel=\"stylesheet\" type=\"text/css\" href=\"style/phone_lock.css\"/>\n <link rel=\"stylesheet\" type=\"text/css\" href=\"style/simcard.css\"/>\n+ <link rel=\"stylesheet\" type=\"text/css\" href=\"style/hotspot.css\"/>","path":"apps/settings/index.html","position":4,"original_position":4,"commit_id":"d8231eaa4dc1bdc2349752f5893e0ee7e0a58594","original_commit_id":"d8231eaa4dc1bdc2349752f5893e0ee7e0a58594","user":{"login":"crh0716","id":2899280,"avatar_url":"https://secure.gravatar.com/avatar/ab20989d946f4bd31c590b5a6ef73f7a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"ab20989d946f4bd31c590b5a6ef73f7a","url":"https://api.github.com/users/crh0716","html_url":"https://github.com/crh0716","followers_url":"https://api.github.com/users/crh0716/followers","following_url":"https://api.github.com/users/crh0716/following{/other_user}","gists_url":"https://api.github.com/users/crh0716/gists{/gist_id}","starred_url":"https://api.github.com/users/crh0716/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crh0716/subscriptions","organizations_url":"https://api.github.com/users/crh0716/orgs","repos_url":"https://api.github.com/users/crh0716/repos","events_url":"https://api.github.com/users/crh0716/events{/privacy}","received_events_url":"https://api.github.com/users/crh0716/received_events","type":"User"},"created_at":"2013-06-14T08:11:09Z","updated_at":"2013-06-14T08:11:09Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/10370#discussion_r4697131","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/10370","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/4697131"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/10370#discussion_r4697131"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/10370"}}}}

{"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1197,"stargazers":1197,"forks":800,"fork":false,"size":23048,"owner":"mozilla-b2g","private":false,"open_issues":51,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-06-14T00:49:26-07:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Arthur Chen","location":"","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla-b2g/gaia/pull/10370#discussion_r4697131"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/7961020","id":7961020,"diff_hunk":"@@ -289,6 +289,25 @@ var Compose = (function() {\n return content;\n },\n \n+ /** Render draft from data store\n+ * @param {Number} ThreadId for the specific thread. Potentially null.\n+ *\n+ */\n+\n+ getDraft: function(id) {\n+ // If no drafts for thread, no need to render\n+ if (!Drafts.has(id)) {\n+ return;\n+ }\n+ // Clear out the composer if we're actually going to add content\n+ Compose.clear();\n+ // Draft messages are accessed as a pseudo-array\n+ Drafts.byId(id).forEach(function(message) {\n+ // Content is an array\n+ message.content.forEach(Compose.append, Compose);\n+ });\n+ },","path":"apps/sms/js/compose.js","position":32,"original_position":30,"commit_id":"6563ee1a3ddb8495e53806643c15f4e7433f7961","original_commit_id":"308da94e2987985670169dd370d5aac2bcd637d5","user":{"login":"Protonk","id":390863,"avatar_url":"https://2.gravatar.com/avatar/3899f9d5384ca31420024d8cc2e2f633?d=https%3A%2F%2Fidenticons.github.com%2Ff6bf2a763779d1f361da82214a0dd195.png&r=x","gravatar_id":"3899f9d5384ca31420024d8cc2e2f633","url":"https://api.github.com/users/Protonk","html_url":"https://github.com/Protonk","followers_url":"https://api.github.com/users/Protonk/followers","following_url":"https://api.github.com/users/Protonk/following{/other_user}","gists_url":"https://api.github.com/users/Protonk/gists{/gist_id}","starred_url":"https://api.github.com/users/Protonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Protonk/subscriptions","organizations_url":"https://api.github.com/users/Protonk/orgs","repos_url":"https://api.github.com/users/Protonk/repos","events_url":"https://api.github.com/users/Protonk/events{/privacy}","received_events_url":"https://api.github.com/users/Protonk/received_events","type":"User","site_admin":false},"body":"I'm also not sure. It doesn't seem to belong anywhere else (message manager is about messages, thread ui is long enough as it is), but nothing else in compose has knowledge of threads, and that feels a little wonky. Agree about get -> from.","created_at":"2013-11-27T16:04:17Z","updated_at":"2013-11-27T16:04:17Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/14083#discussion_r7961020","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/14083","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/7961020"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/14083#discussion_r7961020"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/14083"}}}}

{"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1425,"stargazers":1425,"forks":1156,"fork":false,"size":740986,"owner":"mozilla-b2g","private":false,"open_issues":897,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-11-27T07:47:10-08:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Adam Hyland","company":"Bocoup","blog":"shiftcommandawesome.com","location":"Boston","email":"[email protected]"},"url":"https://github.com/mozilla-b2g/gaia/pull/14083#discussion_r7961020"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/8554913","id":8554913,"diff_hunk":"@@ -67,10 +66,9 @@ evme-appsmore-loading=Loading…\n \n evme-alert-app-install-confirm=Add {{name}} to Home Screen?\n evme-alert-app-install-exists={{name}} was already added to Home Screen\n-evme-alert-offline-collections-more=Connect to the internet to add more collections\n-evme-alert-save-collection=Add as Collection?","path":"apps/homescreen/locales/homescreen.en-US.properties","position":22,"original_position":22,"commit_id":"282ab799c34cbd03b0bd6b1d7fc2f3128af71018","original_commit_id":"282ab799c34cbd03b0bd6b1d7fc2f3128af71018","user":{"login":"amirnissim","id":1098126,"avatar_url":"https://gravatar.com/avatar/664f74088cd1b999c4885c383a8f2b6b?d=https%3A%2F%2Fidenticons.github.com%2Ffde92e8fbb7dfc988fbe8d4050e9b7ec.png&r=x","gravatar_id":"664f74088cd1b999c4885c383a8f2b6b","url":"https://api.github.com/users/amirnissim","html_url":"https://github.com/amirnissim","followers_url":"https://api.github.com/users/amirnissim/followers","following_url":"https://api.github.com/users/amirnissim/following{/other_user}","gists_url":"https://api.github.com/users/amirnissim/gists{/gist_id}","starred_url":"https://api.github.com/users/amirnissim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirnissim/subscriptions","organizations_url":"https://api.github.com/users/amirnissim/orgs","repos_url":"https://api.github.com/users/amirnissim/repos","events_url":"https://api.github.com/users/amirnissim/events{/privacy}","received_events_url":"https://api.github.com/users/amirnissim/received_events","type":"User","site_admin":false},"body":"not in use","created_at":"2013-12-26T11:56:29Z","updated_at":"2013-12-26T11:56:29Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/14969#discussion_r8554913","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/14969","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/8554913"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/14969#discussion_r8554913"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/14969"}}}}

{"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1444,"stargazers":1444,"forks":1243,"fork":false,"size":758277,"owner":"mozilla-b2g","private":false,"open_issues":986,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-12-25T06:15:31-08:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Amir Nissim","blog":"http://amirnissim.github.com","location":"Tel Aviv","email":"[email protected]"},"url":"https://github.com/mozilla-b2g/gaia/pull/14969#discussion_r8554913"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/8295452","id":8295452,"diff_hunk":"@@ -432,34 +514,123 @@ function HandoverManager() {\n * it is enabled and the action is queued. If Bluetooth is already enabled,\n * performs the action directly.\n */\n- function doAction(action) {\n- if (!self.bluetooth.enabled) {\n- debug('Bluetooth: not yet enabled');\n- self.actionQueue.push(action);\n- if (self.settingsNotified == false) {\n- self.settings.createLock().set({'bluetooth.enabled': true});\n- self.settingsNotified = true;\n+ this.doAction = function doAction(action) {\n+ if (!this.bluetooth.enabled) {\n+ this.debug('Bluetooth: not yet enabled');\n+ this.actionQueue.push(action);\n+ if (this.settingsNotified == false) {\n+ this.settings.createLock().set({'bluetooth.enabled': true});\n+ this.settingsNotified = true;\n }\n } else {\n- action.callback.apply(null, action.args);\n+ action.callback.apply(this, action.args);\n }\n- }\n+ };\n+\n+ this.getBluetoothMAC = function getBluetoothMAC(ndef) {\n+ var handover = NdefHandoverCodec.parse(ndef);\n+ if (handover == null) {\n+ // Bad handover message. Just ignore.\n+ this.debug('Bad handover messsage');\n+ return null;\n+ }\n+ var btsspRecord = NdefHandoverCodec.searchForBluetoothAC(handover);\n+ if (btsspRecord == null) {\n+ // There is no Bluetooth Alternative Carrier record in the\n+ // Handover Select message. Since we cannot handle WiFi Direct,\n+ // just ignore.\n+ this.debug('No BT AC');\n+ return null;\n+ }\n+ var btssp = NdefHandoverCodec.parseBluetoothSSP(btsspRecord);\n+ return btssp.mac;\n+ };\n \n- function doPairing(mac) {\n- debug('doPairing: ' + mac);\n- if (self.defaultAdapter == null) {\n+ this.doPairing = function doPairing(mac, onsuccess, onerror) {","path":"apps/system/js/nfc_handover.js","position":241,"original_position":241,"commit_id":"b2fe6263ce77427a9331319729b10827da2b0298","original_commit_id":"b2fe6263ce77427a9331319729b10827da2b0298","user":{"login":"ian-liu","id":1704655,"avatar_url":"https://gravatar.com/avatar/97614f2541c088277e57085f31cdf546?d=https%3A%2F%2Fidenticons.github.com%2Fcb925432e139e11fadca600103f1af75.png&r=x","gravatar_id":"97614f2541c088277e57085f31cdf546","url":"https://api.github.com/users/ian-liu","html_url":"https://github.com/ian-liu","followers_url":"https://api.github.com/users/ian-liu/followers","following_url":"https://api.github.com/users/ian-liu/following{/other_user}","gists_url":"https://api.github.com/users/ian-liu/gists{/gist_id}","starred_url":"https://api.github.com/users/ian-liu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ian-liu/subscriptions","organizations_url":"https://api.github.com/users/ian-liu/orgs","repos_url":"https://api.github.com/users/ian-liu/repos","events_url":"https://api.github.com/users/ian-liu/events{/privacy}","received_events_url":"https://api.github.com/users/ian-liu/received_events","type":"User","site_admin":false},"body":"Again here. :/","created_at":"2013-12-12T10:05:02Z","updated_at":"2013-12-12T10:05:02Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/14122#discussion_r8295452","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/14122","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/8295452"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/14122#discussion_r8295452"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/14122"}}}}

{"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1436,"stargazers":1436,"forks":1209,"fork":false,"size":737521,"owner":"mozilla-b2g","private":false,"open_issues":951,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-12-12T01:10:50-08:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Ian Liu","company":"Mozilla Taiwan","location":"Taipei, Taiwan","email":"[email protected]"},"url":"https://github.com/mozilla-b2g/gaia/pull/14122#discussion_r8295452"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mozilla-b2g/marionette-js-client/pulls/comments/5807517","id":5807517,"body":"see the full context- this marionette method is gone","diff_hunk":"@@ -105,29 +112,22 @@\n * @param {Function} callback callback when script completes.\n */\n scriptWith: function scriptWith(script, callback) {\n- this.client.executeScript(script, [this], callback);\n+ return this.client.executeScript(script, [this], callback);\n },\n \n /**\n * Checks to see if two elements are equal\n *\n * @method equals\n- * @param {String|Marionette.Element} element element to test.\n- * @param {Function} callback called with boolean.\n- * @return {Object} self.\n+ * @param {Marionette.Element} element element to test.\n+ * @return {Boolean} true when equal.\n */\n- equals: function equals(element, callback) {\n-\n- if (element instanceof this.constructor) {\n- element = element.id;\n+ equals: function equals(element) {\n+ if (!(element instanceof Element)) {\n+ throw new Error('must pass an element');\n }\n \n- var cmd = {\n- type: 'elementsEqual',\n- elements: [this.id, element]\n- };\n- this.client._sendCommand(cmd, 'value', callback);","path":"lib/marionette/element.js","position":56,"original_position":56,"commit_id":"d939bfdd40c0c46d87d737bcedd824a78d358a28","original_commit_id":"d939bfdd40c0c46d87d737bcedd824a78d358a28","user":{"login":"lightsofapollo","id":322957,"avatar_url":"https://0.gravatar.com/avatar/52c6593cac3e4b93da1714af0760146b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"52c6593cac3e4b93da1714af0760146b","url":"https://api.github.com/users/lightsofapollo","html_url":"https://github.com/lightsofapollo","followers_url":"https://api.github.com/users/lightsofapollo/followers","following_url":"https://api.github.com/users/lightsofapollo/following{/other_user}","gists_url":"https://api.github.com/users/lightsofapollo/gists{/gist_id}","starred_url":"https://api.github.com/users/lightsofapollo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightsofapollo/subscriptions","organizations_url":"https://api.github.com/users/lightsofapollo/orgs","repos_url":"https://api.github.com/users/lightsofapollo/repos","events_url":"https://api.github.com/users/lightsofapollo/events{/privacy}","received_events_url":"https://api.github.com/users/lightsofapollo/received_events","type":"User"},"created_at":"2013-08-16T04:20:00Z","updated_at":"2013-08-16T04:20:00Z","html_url":"https://github.com/mozilla-b2g/marionette-js-client/pull/50#discussion_r5807517","pull_request_url":"https://api.github.com/repos/mozilla-b2g/marionette-js-client/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-js-client/pulls/comments/5807517"},"html":{"href":"https://github.com/mozilla-b2g/marionette-js-client/pull/50#discussion_r5807517"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/marionette-js-client/pulls/50"}}}}

{"repository":{"description":"Marionette JS Client","homepage":"http://mozilla-b2g.github.com/marionette-js-client/","watchers":10,"stargazers":10,"forks":14,"fork":false,"size":888,"owner":"mozilla-b2g","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-04-19T22:55:42-07:00","pushed_at":"2013-08-09T09:41:26-07:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"James Lal","company":"Mozilla","blog":"http://lightsofapollo.github.com/blog/","location":"Santa Clara, CA","email":"[email protected]"},"url":"https://github.com/mozilla-b2g/marionette-js-client/pull/50#discussion_r5807517"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/7594016","id":7594016,"diff_hunk":"@@ -54,7 +54,6 @@ Evme.Config = Evme.__config = {\n }\n },\n 'maxHistoryEntries': '10',\n- 'emptyCollectionIcon': '/everything.me/images/empty-collection.png',","path":"apps/homescreen/everything.me/config/config.js","position":4,"original_position":4,"commit_id":"3dfce7ceed7b361af85c19af7a96b0d9cdf034d0","original_commit_id":"3dfce7ceed7b361af85c19af7a96b0d9cdf034d0","user":{"login":"amirnissim","id":1098126,"avatar_url":"https://0.gravatar.com/avatar/664f74088cd1b999c4885c383a8f2b6b?d=https%3A%2F%2Fidenticons.github.com%2Ffde92e8fbb7dfc988fbe8d4050e9b7ec.png&r=x","gravatar_id":"664f74088cd1b999c4885c383a8f2b6b","url":"https://api.github.com/users/amirnissim","html_url":"https://github.com/amirnissim","followers_url":"https://api.github.com/users/amirnissim/followers","following_url":"https://api.github.com/users/amirnissim/following{/other_user}","gists_url":"https://api.github.com/users/amirnissim/gists{/gist_id}","starred_url":"https://api.github.com/users/amirnissim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amirnissim/subscriptions","organizations_url":"https://api.github.com/users/amirnissim/orgs","repos_url":"https://api.github.com/users/amirnissim/repos","events_url":"https://api.github.com/users/amirnissim/events{/privacy}","received_events_url":"https://api.github.com/users/amirnissim/received_events","type":"User","site_admin":false},"body":"cleanup","created_at":"2013-11-12T15:01:18Z","updated_at":"2013-11-12T15:01:18Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/13619#discussion_r7594016","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/13619","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/7594016"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/13619#discussion_r7594016"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/13619"}}}}

{"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1412,"stargazers":1412,"forks":1122,"fork":false,"size":699062,"owner":"mozilla-b2g","private":false,"open_issues":878,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-11-12T06:40:28-08:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Amir Nissim","blog":"http://amirnissim.github.com","location":"Tel Aviv","email":"[email protected]"},"url":"https://github.com/mozilla-b2g/gaia/pull/13619#discussion_r7594016"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/4518026","id":4518026,"body":"strange name for this function","diff_hunk":"@@ -1,6 +1,18 @@\n 'use strict';\n \n var MockConfigManager = function(config) {\n+ config = config || {};\n+\n+ Date.prototype.toJSON = function() {\n+ return {'__date__': this.toISOString()};\n+ };\n+ function settingsReviver(k, v) {","path":"apps/costcontrol/test/unit/mock_config_manager.js","position":9,"original_position":9,"commit_id":"1e69671499f255e9aaecb02ae048c4d09e3cd0b2","original_commit_id":"1e69671499f255e9aaecb02ae048c4d09e3cd0b2","user":{"login":"jmcanterafonseca","id":694782,"avatar_url":"https://secure.gravatar.com/avatar/fd0e9eda3bafe4df58adf9fe0f218e04?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"fd0e9eda3bafe4df58adf9fe0f218e04","url":"https://api.github.com/users/jmcanterafonseca","html_url":"https://github.com/jmcanterafonseca","followers_url":"https://api.github.com/users/jmcanterafonseca/followers","following_url":"https://api.github.com/users/jmcanterafonseca/following{/other_user}","gists_url":"https://api.github.com/users/jmcanterafonseca/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcanterafonseca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcanterafonseca/subscriptions","organizations_url":"https://api.github.com/users/jmcanterafonseca/orgs","repos_url":"https://api.github.com/users/jmcanterafonseca/repos","events_url":"https://api.github.com/users/jmcanterafonseca/events{/privacy}","received_events_url":"https://api.github.com/users/jmcanterafonseca/received_events","type":"User"},"created_at":"2013-06-04T08:52:42Z","updated_at":"2013-06-04T08:52:42Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/10166#discussion_r4518026","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/10166","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/4518026"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/10166#discussion_r4518026"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/10166"}}}}

{"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1187,"stargazers":1187,"forks":777,"fork":false,"size":21812,"owner":"mozilla-b2g","private":false,"open_issues":4,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-06-04T01:09:25-07:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Jose M. Cantera","company":"Telefonica I+D","location":"Boecillo","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla-b2g/gaia/pull/10166#discussion_r4518026"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/6679906","id":6679906,"body":"Let's swipe this line with the above one so the view event binding can be wrote together, just like line 756~758.","diff_hunk":"@@ -1137,6 +1159,7 @@ var ListView = {\n this.view.addEventListener('click', this);\n this.view.addEventListener('input', this);\n this.searchInput.addEventListener('focus', this);\n+ this.view.addEventListener('touchend', this);","path":"apps/music/js/music.js","position":50,"original_position":50,"commit_id":"307045341446857567dce09dea7d824aed21dd84","original_commit_id":"307045341446857567dce09dea7d824aed21dd84","user":{"login":"dominickuo","id":1704508,"avatar_url":"https://1.gravatar.com/avatar/e333342f0afd23d7212e0cbaa6e00e3c?d=https%3A%2F%2Fidenticons.github.com%2F4351ca5b5f8117bdc83012bf5ac46971.png","gravatar_id":"e333342f0afd23d7212e0cbaa6e00e3c","url":"https://api.github.com/users/dominickuo","html_url":"https://github.com/dominickuo","followers_url":"https://api.github.com/users/dominickuo/followers","following_url":"https://api.github.com/users/dominickuo/following{/other_user}","gists_url":"https://api.github.com/users/dominickuo/gists{/gist_id}","starred_url":"https://api.github.com/users/dominickuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dominickuo/subscriptions","organizations_url":"https://api.github.com/users/dominickuo/orgs","repos_url":"https://api.github.com/users/dominickuo/repos","events_url":"https://api.github.com/users/dominickuo/events{/privacy}","received_events_url":"https://api.github.com/users/dominickuo/received_events","type":"User"},"created_at":"2013-10-01T07:42:30Z","updated_at":"2013-10-01T07:42:30Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/12257#discussion_r6679906","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/12257","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/6679906"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/12257#discussion_r6679906"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/12257"}}}}

{"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1353,"stargazers":1353,"forks":1015,"fork":false,"size":680349,"owner":"mozilla-b2g","private":false,"open_issues":858,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-09-30T23:56:34-07:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Dominic Kuo","company":"Mozilla","location":"Taipei, Taiwan","email":"[email protected]"},"url":"https://github.com/mozilla-b2g/gaia/pull/12257#discussion_r6679906"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/7243089","id":7243089,"diff_hunk":"@@ -536,4 +536,290 @@\n this.iframe.style.display = 'block';\n };\n \n+ // If receive something, there are two states:\n+ //\n+ // 1. We're under the right app\n+ // 2. We're under another app, should invoke the right app first\n+ //\n+ // But we now focus on the visual effects, so opening another app\n+ // and open the content in the current app should be handled in other\n+ // components.\n+ //\n+ // This function require a right appFrame to apply all effects on it.\n+ AppWindow.prototype._shirnkingReceivingEffects =\n+ function aw_shirnkingReceivingEffects(appFrame) {\n+\n+ var self = this;\n+\n+ // Hide it before we move it.\n+ var originalDisplay = appFrame.style.display;\n+ appFrame.style.display = 'none';\n+\n+ // 1. Make it on top and tilted.\n+ this._shirnkingTilt(appFrame);\n+ this._shirnkingSendingSlideTo('TOP', appFrame);\n+ appFrame.style.display = originalDisplay;\n+ appFrame.style.transition = 'all 0.5s ease';\n+ var doCancelTransition = function doCancelTransition(evt) {\n+ appFrame.removeEventListener('transitionend', doCancelTransition);\n+ appFrame.style.transition = '';\n+ };\n+\n+ // 2. Slide to the BOTTOM.\n+ // 3. Tilt it back and isplay as normal apps.\n+ this._shirnkingSendingSlideTo('BOTTOM', appFrame, function doTiltBack() {\n+ // Only cancel the effects after the second transformation.\n+ appFrame.addEventListener('transitionend', doCancelTransition);\n+ self._shirnkingTiltBack(appFrame);\n+ });\n+ };\n+\n+ // The callback should receive nothing.\n+ // It would be triggered after the appFrame reach the destination.\n+ // The callback is optional.\n+ AppWindow.prototype._shirnkingSendingSlideTo =\n+ function aw_shirnkingSendingSlideTo(y, appFrame, callback) {\n+ if ('TOP' === y) {\n+ y = appFrame.parentElement.clientHeight;\n+ } else if ('BOTTOM' == y) {\n+ y = 0;\n+ }\n+ if (y < 0)\n+ y = 0;\n+\n+ var cbDone = function cbDone(evt) {\n+ appFrame.removeEventListener('transitionend', cbDone);\n+ if ('undefined' !== typeof callback)\n+ callback();\n+ };\n+ appFrame.addEventListener('transitionend', cbDone);\n+ appFrame.style.transform = 'rotateX(0.8deg)' +\n+ 'translateY(-' + y + 'px)';\n+ };\n+\n+ AppWindow.prototype._shirnkingSlidingCover =\n+ function shirnkingSlidingCover() {\n+ var cover = document.createElement('div');\n+ cover.id = 'nfc-cover';\n+ cover.style.width = '100%';\n+ cover.style.height = '100%';\n+ cover.style.position = 'relative';\n+ cover.style.zIndex = '2';\n+ cover.addEventListener('touchstart', this._handleShirnkingSendingStart);\n+ cover.addEventListener('touchmove', this._handleShirnkingSendingSlide);\n+ cover.addEventListener('touchend', this._handleShirnkingSendingOut);\n+ return cover;\n+ };\n+\n+ AppWindow.prototype._shirnkingDisableSlidingCover =\n+ function aw_shirnkingDisableSlidingCover(cover) {\n+ cover.removeEventListener('touchstart',\n+ this._handleShirnkingSendingStart);\n+ cover.removeEventListener('touchmove', this._handleShirnkingSendingSlide);\n+ cover.removeEventListener('touchend', this._handleShirnkingSendingOut);\n+ return cover;\n+ };\n+\n+ // Make the app frame tilted and overlay it with a cover.\n+ AppWindow.prototype._shirnkingTilt =\n+ function aw_shirnkingTilt(appFrame) {\n+ var wrapper = appFrame.parentElement;\n+ wrapper.style.perspective = '1rem';\n+ wrapper.style.backgroundColor = 'dimgray';\n+ appFrame.style.transition = 'all 0.5s ease';\n+ appFrame.style.transformOrigin = '50% 100% 0';\n+ appFrame.style.transform = 'rotateX(1.0deg)';\n+ wrapper.insertBefore(this._shirnkingSlidingCover(),\n+ wrapper.firstElementChild);\n+\n+ // Add a little bouncing back animation.\n+ var bounceBack = function bounceBack(evt) {\n+ appFrame.style.transition = 'all 0.3s ease';\n+ appFrame.style.transform = 'rotateX(0.8deg)';\n+\n+ var bounceBackEnd = function bounceBackEnd(evt) {\n+ appFrame.style.transition = 'all 0.5s ease';\n+ appFrame.removeEventListener('transitionend', bounceBackEnd);\n+ };\n+ appFrame.removeEventListener('transitionend', bounceBack);\n+ appFrame.addEventListener('transitionend', bounceBackEnd);\n+ };\n+ appFrame.addEventListener('transitionend', bounceBack);\n+ };\n+\n+ // Restore the app frame. It depends on another stateful method\n+ // because we must update some states after restoring the frame.\n+ AppWindow.prototype._shirnkingTiltBack =\n+ function aw_shirnkingTiltBack(appFrame) {\n+ appFrame.addEventListener('transitionend',\n+ this._handleShirnkingCleanEffects);\n+ appFrame.style.transform = 'rotateX(0.0deg)';\n+ };\n+\n+ // TODO: How to check the sending is successful or not?\n+ AppWindow.prototype._shirnkingSendingCheck =\n+ function aw_shirnkingSendingCheck(appFrame, cover) {\n+ // DEBUG\n+ // Now use the dummy false condition.\n+ var DUMMY_CHECK = true;\n+ if (false === DUMMY_CHECK) {\n+ this._shirnkingSendingSlideTo('BOTTOM', appFrame);\n+\n+ // Don't remove the cover to allow user try it again.\n+ } else {\n+ // If success, do nothing on visual effects.\n+ // TODO: But it need to share the object by the app.\n+\n+ // DEBUG\n+ //NFCDisableSlidingCover(this.cover).remove();\n+ //NFCTiltBack(this.currentAppFrame);\n+\n+ // DEBUG: beacuse current the receiving effects would\n+ // not remove the cover element.\n+ this._shirnkingDisableSlidingCover(cover).remove();\n+ this._shirnkingReceivingEffects(appFrame);\n+ }\n+ };\n+\n+ AppWindow.prototype._setupShirnkingEffects =\n+ function aw_setupShirnkingEffects() {\n+ // Lint disallow we to set non-primitive members\n+ // in definition.\n+ this._shirnkingEffects = {\n+ THRESHOLD: 50,\n+ SUSPEND_INTERVAL: 100,\n+ overThreshold: false,\n+ toward: 'TOP',\n+ suspended: false,\n+ delaySlidingID: null,\n+ coverElement: null,\n+ currentAppFrame: null,\n+ tilted: false,\n+ touchState: {\n+ initY: -1,\n+ prevY: -1\n+ }\n+ };\n+\n+ var self = this; // For methods.\n+\n+ // The 'this.frame' is actually the 'div', not the iframe.\n+ // Here we will use 'wrapper' and 'currentAppFrame' to manipulate them.\n+ this._shirnkingEffects.currentAppFrame = this.frame.firstElementChild;\n+\n+ // Define these stateful functions with a specific state\n+ // (the 'shirnkingEffects'), and prevent them to lose the\n+ // 'this' when they're callbacks.\n+\n+ // One of the only two exposed methods of these shirnking effects.\n+ // The outside users should only know the start and stop method.\n+ this.shirnkingStart =\n+ (function aw_shirnkingStart() {\n+ if (this.tilted)\n+ return;\n+ self._shirnkingTilt(this.currentAppFrame);\n+ this.tilted = true;\n+ }).bind(this._shirnkingEffects);\n+\n+ this.shirnkingStop =\n+ (function aw_shirnkingStart(instant) {\n+ if (!this.tilted)\n+ return;\n+ if (instant)\n+ this.currentAppFrame.style.transition = '';\n+ self._shirnkingTiltBack(this.currentAppFrame);\n+ }).bind(this._shirnkingEffects);\n+\n+ // Getter. If the app frame now is shirnking.\n+ this.shirnking =\n+ (function aw_shirnking() {\n+ return this.tilted;\n+ }).bind(this._shirnkingEffects);\n+\n+ // Start the sending movement.\n+ this._handleShirnkingSendingStart =\n+ (function aw_handleShirnkingSendingStart(evt) {\n+ // Stop the touch event to affect the inner elements.\n+ evt.stopImmediatePropagation();\n+ return false;\n+ }).bind(this._shirnkingEffects);\n+\n+ // Sending is in progress.\n+ this._handleShirnkingSendingSlide =\n+ (function aw_handleShirnkingSendingSlide(evt) {\n+\n+ var pgy = evt.touches[0].pageY;\n+ var slideY = this.currentAppFrame.parentElement.clientHeight - pgy;\n+ if ('undefined' === typeof this.touchState.initY) {\n+ this.touchState.initY = slideY;\n+ }\n+ if ('undefined' === typeof this.touchState.prevY) {\n+ this.touchState.prevY = slideY;\n+ }\n+ // User is dragging it back or not.\n+ this.toward = (this.touchState.prevY < slideY) ? 'TOP' : 'BOTTOM';\n+\n+ // Don't set new sliding callback if we're suspended.\n+ if (this.suspended)\n+ return;\n+\n+ var handleDelaySliding = (function aw_handleDelaySliding() {\n+ self._shirnkingSendingSlideTo(slideY, this.currentAppFrame);\n+ this.suspended = false;\n+ }).bind(this);\n+\n+ this.delaySlidingID = setTimeout(handleDelaySliding,\n+ this.SUSPEND_INTERVAL);\n+ this.suspended = true;\n+\n+ self._shirnkingSendingSlideTo(slideY, this.currentAppFrame);\n+ this.touchState.prevY = slideY;\n+ this.overThreshold = (slideY > this.THRESHOLD) ? true : false;\n+ }).bind(this._shirnkingEffects);\n+\n+ // Sending was finished.\n+ this._handleShirnkingSendingOut =\n+ (function aw_handleShirnkingSendingOut(evt) {\n+ // Clear the last sliding timeout callback to force\n+ // it slide to TOP or BOTTOM.\n+ clearTimeout(this.delaySlidingID);\n+\n+ if (this.overThreshold && 'TOP' === this.toward) {\n+ var cover = this.currentAppFrame.parentElement\n+ .querySelector('#nfc-cover');\n+ self._shirnkingSendingSlideTo('TOP', this.currentAppFrame,\n+ (function doCheck() {\n+ self._shirnkingSendingCheck(this.currentAppFrame, cover);\n+ }).bind(this)\n+ );\n+ } else {\n+ // Fallback to the bottom if user cancel it.\n+ self._shirnkingSendingSlideTo('BOTTOM', this.currentAppFrame,\n+ (function resumeSending() {\n+ // Resume the sending timeout state.\n+ this.suspended = false;\n+ }).bind(this)\n+ );\n+ }\n+ }).bind(this._shirnkingEffects);\n+\n+ // Must clear and restore the app frame after transition end\n+ // to make it come back with animation.\n+ this._handleShirnkingCleanEffects =\n+ (function aw_handleShirnkingCleanEffects(evt) {\n+ var wrapper = this.currentAppFrame.parentElement;\n+ this.currentAppFrame.style.transition = '';\n+ this.currentAppFrame.style.transform = '';\n+ this.currentAppFrame.style.transformOrigin = '50% 50% 0';\n+ this.tilted = false;\n+ // After trasitionend, clean this handler.\n+ this.currentAppFrame.removeEventListener('transitionend',\n+ self._handleShirnkingCleanEffects);\n+ wrapper.style.backgroundColor = '';\n+ wrapper.style.perspective = '';\n+ var cover = wrapper.querySelector('#nfc-cover');\n+ self._shirnkingDisableSlidingCover(cover).remove();\n+ }).bind(this._shirnkingEffects);\n+ };","path":"apps/system/js/window.js","position":313,"original_position":313,"commit_id":"9603cf7ff5504fb0659b6c0bc2f104b95984920d","original_commit_id":"9603cf7ff5504fb0659b6c0bc2f104b95984920d","user":{"login":"alivedise","id":546519,"avatar_url":"https://1.gravatar.com/avatar/2200ce74246a04126cf04cfa39ff0c37?d=https%3A%2F%2Fidenticons.github.com%2F6ea87b4a42d4dfa60bd489c8fa95d658.png&r=x","gravatar_id":"2200ce74246a04126cf04cfa39ff0c37","url":"https://api.github.com/users/alivedise","html_url":"https://github.com/alivedise","followers_url":"https://api.github.com/users/alivedise/followers","following_url":"https://api.github.com/users/alivedise/following{/other_user}","gists_url":"https://api.github.com/users/alivedise/gists{/gist_id}","starred_url":"https://api.github.com/users/alivedise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alivedise/subscriptions","organizations_url":"https://api.github.com/users/alivedise/orgs","repos_url":"https://api.github.com/users/alivedise/repos","events_url":"https://api.github.com/users/alivedise/events{/privacy}","received_events_url":"https://api.github.com/users/alivedise/received_events","type":"User","site_admin":false},"body":"```js\r\nvar ShrinkingUI = {\r\n //...\r\n};\r\n\r\nIf (ENABLE_SHRINKING)\r\n AppWindow.addMixin(ShrinkingUI);\r\n```","created_at":"2013-10-28T09:35:21Z","updated_at":"2013-10-28T09:35:21Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/13127#discussion_r7243089","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/13127","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/7243089"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/13127#discussion_r7243089"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/13127"}}}}

{"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1397,"stargazers":1397,"forks":1082,"fork":false,"size":756848,"owner":"mozilla-b2g","private":false,"open_issues":842,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-10-28T02:28:32-07:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Alive.Kuo","company":"Mozilla","blog":"alivedise.github.com","location":"Taiwan","email":"[email protected]"},"url":"https://github.com/mozilla-b2g/gaia/pull/13127#discussion_r7243089"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/6080685","id":6080685,"body":"What does these do?","diff_hunk":"@@ -70,6 +84,32 @@ SettingsListener.observe(\n }\n );\n \n+// Use a setting in order to be \"called\" by settings app\n+navigator.mozSettings.addObserver(\n+ 'clear.remote-windows.data',\n+ function clearRemoteWindowsData(setting) {\n+ var shouldClear = setting.settingValue;\n+ if (!shouldClear)\n+ return;\n+\n+ // Delete all storage and cookies from our content processes\n+ var request = navigator.mozApps.getSelf();\n+ request.onsuccess = function() {\n+ request.result.clearBrowserData();\n+ };\n+\n+ // Reset the setting value to false\n+ var lock = navigator.mozSettings.createLock();\n+ lock.set({'clear.remote-windows.data': false});","path":"apps/system/js/bootstrap.js","position":50,"original_position":50,"commit_id":"4f0d84290c366cb4c14ec5c366a3f3c9fa2982a4","original_commit_id":"4f0d84290c366cb4c14ec5c366a3f3c9fa2982a4","user":{"login":"timdream","id":93093,"avatar_url":"https://1.gravatar.com/avatar/2becaf1073957bdad2f06e183731131d?d=https%3A%2F%2Fidenticons.github.com%2Fa26ef4a0c4c94d82d22e9fae28638ec2.png","gravatar_id":"2becaf1073957bdad2f06e183731131d","url":"https://api.github.com/users/timdream","html_url":"https://github.com/timdream","followers_url":"https://api.github.com/users/timdream/followers","following_url":"https://api.github.com/users/timdream/following{/other_user}","gists_url":"https://api.github.com/users/timdream/gists{/gist_id}","starred_url":"https://api.github.com/users/timdream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timdream/subscriptions","organizations_url":"https://api.github.com/users/timdream/orgs","repos_url":"https://api.github.com/users/timdream/repos","events_url":"https://api.github.com/users/timdream/events{/privacy}","received_events_url":"https://api.github.com/users/timdream/received_events","type":"User"},"created_at":"2013-08-30T07:20:25Z","updated_at":"2013-08-30T07:20:25Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/11854#discussion_r6080685","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/11854","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/6080685"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/11854#discussion_r6080685"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/11854"}}}}

{"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1328,"stargazers":1328,"forks":970,"fork":false,"size":580933,"owner":"mozilla-b2g","private":false,"open_issues":768,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-08-30T00:05:12-07:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Timothy Guan-tin Chien","company":"Mozilla Corporation","blog":"http://timdream.org/","location":"Taipei, Taiwan","email":"[email protected]"},"url":"https://github.com/mozilla-b2g/gaia/pull/11854#discussion_r6080685"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/peerlibrary/peerlibrary/pulls/comments/6785963","id":6785963,"diff_hunk":"@@ -9,13 +9,36 @@\n <template name=\"presentation\">\n <div class=\"landing\">\n </div>\n- <div class=\"presentation\">\n+ <div class=\"pitch\">\n+ <div class=\"down-arrow\"><img src=\"img/down_arrow.png\" alt=\"scroll down\"/></div>","path":"client/templates/index.html","position":6,"original_position":6,"commit_id":"6fb4c8c1d0c68e6fd0e48eadd6524c34f8840458","original_commit_id":"aa552d3cad75794631b27927240b1372cf026d99","user":{"login":"mitar","id":585279,"avatar_url":"https://0.gravatar.com/avatar/e236829c38fb78c4d7f7ff1dd826197e?d=https%3A%2F%2Fidenticons.github.com%2F3b22842af1b2990bed06349231fccdc1.png","gravatar_id":"e236829c38fb78c4d7f7ff1dd826197e","url":"https://api.github.com/users/mitar","html_url":"https://github.com/mitar","followers_url":"https://api.github.com/users/mitar/followers","following_url":"https://api.github.com/users/mitar/following{/other_user}","gists_url":"https://api.github.com/users/mitar/gists{/gist_id}","starred_url":"https://api.github.com/users/mitar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitar/subscriptions","organizations_url":"https://api.github.com/users/mitar/orgs","repos_url":"https://api.github.com/users/mitar/repos","events_url":"https://api.github.com/users/mitar/events{/privacy}","received_events_url":"https://api.github.com/users/mitar/received_events","type":"User"},"body":"`<img src=\"/img/down_arrow.png\" ... />`","created_at":"2013-10-06T06:03:32Z","updated_at":"2013-10-06T06:03:32Z","html_url":"https://github.com/peerlibrary/peerlibrary/pull/148#discussion_r6785963","pull_request_url":"https://api.github.com/repos/peerlibrary/peerlibrary/pulls/148","_links":{"self":{"href":"https://api.github.com/repos/peerlibrary/peerlibrary/pulls/comments/6785963"},"html":{"href":"https://github.com/peerlibrary/peerlibrary/pull/148#discussion_r6785963"},"pull_request":{"href":"https://api.github.com/repos/peerlibrary/peerlibrary/pulls/148"}}}}

{"repository":{"description":"Enriching the experience of open access scholarly literature","homepage":"http://peerlibrary.org/","watchers":42,"stargazers":42,"forks":8,"fork":false,"size":4059,"owner":"peerlibrary","private":false,"open_issues":123,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"CoffeeScript","created_at":"2013-03-14T00:26:54-07:00","pushed_at":"2013-10-05T22:48:44-07:00","master_branch":"master","organization":"peerlibrary"},"actor_attributes":{"type":"User","name":"Mitar","blog":"http://mitar.tnode.com","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/peerlibrary/peerlibrary/pull/148#discussion_r6785963"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/projectkudu/kudu/pulls/comments/3994118","id":3994118,"body":"Yea it's fine. I guess it's only a problem if you expected the timer to run past this operation.","diff_hunk":"@@ -124,14 +127,35 @@ internal ChangeSet Sync(DropboxHandler.DropboxInfo deploymentInfo, string branch\n return changeSet;\n }\n \n- private void ApplyChanges(DropboxHandler.DropboxInfo deploymentInfo)\n+ private void UpdateStatusFile(object state)\n+ {\n+ string changeset = (string)state;\n+ IDeploymentStatusFile statusFile =_status.Open(changeset);\n+ statusFile.UpdateProgress(String.Format(CultureInfo.CurrentUICulture,\n+ _failedCount == 0 ? Resources.Dropbox_SynchronizingProgress : Resources.Dropbox_SynchronizingProgressWithFailure,\n+ ((_successCount + _failedCount) * 100) / _totals,\n+ _totals,\n+ _failedCount));\n+ }\n+\n+ private async Task ApplyChanges(DropboxHandler.DropboxInfo deploymentInfo)\n {\n DropboxDeployInfo info = deploymentInfo.DeployInfo;\n- Semaphore sem = new Semaphore(MaxConcurrentRequests, MaxConcurrentRequests);\n+ _totals = info.Deltas.Count;\n+\n+ using (new Timer(UpdateStatusFile, state: deploymentInfo.TargetChangeset.Id, dueTime: TimeSpan.FromSeconds(5), period: TimeSpan.FromSeconds(5)))","path":"Kudu.Services/FetchHelpers/DropboxHelper.cs","position":75,"original_position":75,"commit_id":"b0e807a2bb9eea671de1a544d3f11d7eb55f1934","original_commit_id":"b0e807a2bb9eea671de1a544d3f11d7eb55f1934","user":{"login":"davidfowl","id":95136,"avatar_url":"https://secure.gravatar.com/avatar/1fe64ebb176498be5f73ab51986c6b7b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"1fe64ebb176498be5f73ab51986c6b7b","url":"https://api.github.com/users/davidfowl","html_url":"https://github.com/davidfowl","followers_url":"https://api.github.com/users/davidfowl/followers","following_url":"https://api.github.com/users/davidfowl/following","gists_url":"https://api.github.com/users/davidfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfowl/subscriptions","organizations_url":"https://api.github.com/users/davidfowl/orgs","repos_url":"https://api.github.com/users/davidfowl/repos","events_url":"https://api.github.com/users/davidfowl/events{/privacy}","received_events_url":"https://api.github.com/users/davidfowl/received_events","type":"User"},"created_at":"2013-04-29T06:27:07Z","updated_at":"2013-04-29T06:27:07Z","html_url":"https://github.com/projectkudu/kudu/pull/578#discussion_r3994118","pull_request_url":"https://api.github.com/repos/projectkudu/kudu/pulls/578","_links":{"self":{"href":"https://api.github.com/repos/projectkudu/kudu/pulls/comments/3994118"},"html":{"href":"https://github.com/projectkudu/kudu/pull/578#discussion_r3994118"},"pull_request":{"href":"https://api.github.com/repos/projectkudu/kudu/pulls/578"}}}}

{"repository":{"description":"Kudu is the engine behind git deployments in Azure Web Sites. It can also run outside of Azure.","homepage":"","watchers":367,"stargazers":367,"forks":77,"fork":false,"size":1780,"owner":"projectkudu","private":false,"open_issues":34,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C#","created_at":"2011-06-22T22:36:20-07:00","pushed_at":"2013-04-28T15:04:56-07:00","master_branch":"master","organization":"projectkudu"},"actor_attributes":{"type":"User","name":"David Fowler","company":"Microsoft","blog":"http://weblogs.asp.net/davidfowler","location":"Bellevue, WA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/projectkudu/kudu/pull/578#discussion_r3994118"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/projectkudu/kudu/pulls/comments/4300251","id":4300251,"body":"Once of the Semaphore's is meant to allow at most 5 items to download files in parallel. The RateLimiter semaphore is a Mutex for the lack of a better async construct to lock the file count. There isn't a way to do what it does (increment and compare) without using a lock","diff_hunk":"@@ -208,11 +208,12 @@ private void UpdateStatusFile(object state)\n await sem.WaitAsync();","path":"Kudu.Services/FetchHelpers/DropboxHelper.cs","position":1,"original_position":1,"commit_id":"dd2f7afd9ed3df25e8ea429ce3a22284ef64f423","original_commit_id":"dd2f7afd9ed3df25e8ea429ce3a22284ef64f423","user":{"login":"pranavkm","id":174281,"avatar_url":"https://secure.gravatar.com/avatar/f1f18d37365af0796a784d1ed055684e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"f1f18d37365af0796a784d1ed055684e","url":"https://api.github.com/users/pranavkm","html_url":"https://github.com/pranavkm","followers_url":"https://api.github.com/users/pranavkm/followers","following_url":"https://api.github.com/users/pranavkm/following{/other_user}","gists_url":"https://api.github.com/users/pranavkm/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavkm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavkm/subscriptions","organizations_url":"https://api.github.com/users/pranavkm/orgs","repos_url":"https://api.github.com/users/pranavkm/repos","events_url":"https://api.github.com/users/pranavkm/events{/privacy}","received_events_url":"https://api.github.com/users/pranavkm/received_events","type":"User"},"created_at":"2013-05-20T16:31:53Z","updated_at":"2013-05-20T16:31:53Z","html_url":"https://github.com/projectkudu/kudu/pull/615#discussion_r4300251","pull_request_url":"https://api.github.com/repos/projectkudu/kudu/pulls/615","_links":{"self":{"href":"https://api.github.com/repos/projectkudu/kudu/pulls/comments/4300251"},"html":{"href":"https://github.com/projectkudu/kudu/pull/615#discussion_r4300251"},"pull_request":{"href":"https://api.github.com/repos/projectkudu/kudu/pulls/615"}}}}

{"repository":{"description":"Kudu is the engine behind git deployments in Azure Web Sites. It can also run outside of Azure.","homepage":"","watchers":374,"stargazers":374,"forks":77,"fork":false,"size":2032,"owner":"projectkudu","private":false,"open_issues":34,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C#","created_at":"2011-06-22T22:36:20-07:00","pushed_at":"2013-05-19T22:00:14-07:00","master_branch":"master","organization":"projectkudu"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/projectkudu/kudu/pull/615#discussion_r4300251"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/robolectric/robolectric/pulls/comments/7397999","id":7397999,"diff_hunk":"@@ -177,4 +188,33 @@ public long getKeepAliveDuration(HttpResponse httpResponse, HttpContext httpCont\n \n requestDirector.execute(null, new HttpGet(uri), null);\n }\n+\n+ private static class LifeCycleActivity extends Activity {","path":"src/test/java/org/robolectric/RobolectricTest.java","position":30,"original_position":30,"commit_id":"f6cd0127874d5fe4edb17ee34737be17ce635f5c","original_commit_id":"f6cd0127874d5fe4edb17ee34737be17ce635f5c","user":{"login":"seadowg","id":556280,"avatar_url":"https://1.gravatar.com/avatar/b87152c4f0f695bc98280b32e8350a99?d=https%3A%2F%2Fidenticons.github.com%2F7ce5ffe938ab6fbc5d2e301529088a42.png&r=x","gravatar_id":"b87152c4f0f695bc98280b32e8350a99","url":"https://api.github.com/users/seadowg","html_url":"https://github.com/seadowg","followers_url":"https://api.github.com/users/seadowg/followers","following_url":"https://api.github.com/users/seadowg/following{/other_user}","gists_url":"https://api.github.com/users/seadowg/gists{/gist_id}","starred_url":"https://api.github.com/users/seadowg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seadowg/subscriptions","organizations_url":"https://api.github.com/users/seadowg/orgs","repos_url":"https://api.github.com/users/seadowg/repos","events_url":"https://api.github.com/users/seadowg/events{/privacy}","received_events_url":"https://api.github.com/users/seadowg/received_events","type":"User","site_admin":false},"body":"I can check `isResumed()` and we know about the whole window token not existing until `visible()` is called but I needed a way to check that `start()` and `create ()`. This class allows you to verify all of the creation methods are called.","created_at":"2013-11-04T11:43:01Z","updated_at":"2013-11-04T11:43:01Z","html_url":"https://github.com/robolectric/robolectric/pull/807#discussion_r7397999","pull_request_url":"https://api.github.com/repos/robolectric/robolectric/pulls/807","_links":{"self":{"href":"https://api.github.com/repos/robolectric/robolectric/pulls/comments/7397999"},"html":{"href":"https://github.com/robolectric/robolectric/pull/807#discussion_r7397999"},"pull_request":{"href":"https://api.github.com/repos/robolectric/robolectric/pulls/807"}}}}

{"repository":{"description":"Android Unit Testing Framework","homepage":"http://robolectric.org/","watchers":906,"stargazers":906,"forks":406,"fork":true,"size":37897,"owner":"robolectric","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2010-08-27T17:28:25-07:00","pushed_at":"2013-11-01T13:15:20-07:00","master_branch":"master","organization":"robolectric"},"actor_attributes":{"type":"User","name":"Callum Stott","company":"Pivotal Labs","blog":"http://www.seadowg.com","location":"London, United Kingdom","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/robolectric/robolectric/pull/807#discussion_r7397999"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/swcarpentry/site/pulls/comments/8585975","id":8585975,"diff_hunk":"@@ -0,0 +1,211 @@\n+---\n+layout: blog\n+root: ../../..\n+author: Greg Wilson\n+title: \"Tools, Conversations, and Cultures\"\n+date: 2013-12-31\n+time: \"18:00:00\"\n+category: [\"Opinion\"]\n+---\n+<!-- start excerpt -->\n+<p>\n+ <a href=\"http://pgbovine.net/\">Philip Guo</a> is best known these days for\n+ <a href=\"http://pgbovine.net/PhD-memoir.htm\"><em>The Ph.D. Grind</em></a>,\n+ but I first met him through his <a href=\"http://pythontutor.com/\">Online Python Tutor</a>.\n+ He helped teach a <a href=\"http://pgbovine.net/teaching-librarians-programming.htm\">bootcamp for librarians</a> last August,\n+ and recently wrote a <a href=\"http://pgbovine.net/two-cultures-of-computing.htm\">blog post</a>\n+ about the two cultures of computing that he encountered there.\n+ On one side he sees users who treat software as a tool for getting things done;\n+ on the other,\n+ he sees programmers who hold conversations with their software.\n+ The former use stand-alone GUIs backed by binary file formats (like Word and Excel),\n+ while the latter use command-line interfaces and text (like the shell, LaTeX, and Python).\n+ He writes:\n+</p>\n+<!-- end excerpt -->\n+<blockquote>\n+ <p>\n+ The 35 students all came from user culture,\n+ whereas the 6 instructors all came from programmer culture.\n+ Not only did the students need to learn new technical skills,\n+ but they also had to get accustomed to the ways of programmer culture.\n+ And some instructors&mdash;who had been living firmly in that culture for decades&mdash;had a hard time relating to the students,\n+ despite their most sincere efforts.\n+ </p>\n+ <p>\n+ As a result,\n+ it was sometimes hard to motivate students to learn programming-related skills,\n+ since they felt like they could accomplish similar things with the tools that they already knew.\n+ And it's not just this one isolated event:\n+ when I've witnessed programmers teaching beginners in several other contexts,\n+ this same <em>Two Cultures</em> schism keeps cropping up again and again.\n+ </p>\n+</blockquote>\n+<p>\n+ Philip then enumerates some examples that will be familiar to most Software Carpentry instructors:\n+</p>\n+<table class=\"table table-striped\">\n+ <tr>\n+ <td>Typing \"widgets\" into Spotlight</td><td>vs.</td><td><code>find . -name '*.py' | xargs grep widgets</code></td>\n+ </tr>\n+ <tr>\n+ <td>Rich text editing in Word</td><td>vs.</td><td>ASCII editors that don't even do <em>italics</em></td>\n+ </tr>\n+ <tr>\n+ <td>\"Create chart\" in Excel</td><td>vs.</td><td>writing 15 lines of matplotlib after installing the right libraries</td>\n+ </tr>\n+ <tr>\n+ <td>Copy-rename-email</td><td>vs.</td><td>\"hours of jargon-filled confusion and typo-laden frustration\" to learn Git</td>\n+ </tr>\n+ <tr>\n+ <td>\"Track changes\" in Word</td><td>vs.</td><td>typing backslash-gibberish in LaTeX so that you can use version control</td>\n+ </tr>\n+</table>\n+<p>\n+ Looking at this list,\n+ it actually <em>is</em> easier for users to do\n+ the things they're currently doing\n+ with the tools they're currently using.\n+ The conversational approach only pays off at scale,\n+ and even then only after investing a lot of time [<a href=\"#1\">1</a>].\n+</p>\n+<p>\n+</p>\n+<blockquote>\n+ <p>\n+ Okay, so as an experienced programmer, what can you do to help beginners learn?\n+ </p>\n+ <p>\n+ I think the most important first step is to acknowledge that students are often coming from\n+ a vastly different culture than the one you inhabit,\n+ and that programmer culture just seems weird to them.\n+ </p>\n+ <p>...</p>\n+ <p>\n+ You need to gently introduce students to why these tools will eventually make them more productive in the long run,\n+ even though there is a steep learning curve at the outset.\n+ Start slow,\n+ be supportive along the way,\n+ and don't disparage the GUI-based tools that they are accustomed to using,\n+ no matter how limited you think those tools are...\n+ </p>\n+</blockquote>\n+<p>\n+ In the short run he's right:\n+ given the tools we have,\n+ all we can do is keep Glass's Law in mind [<a href=\"#2\">2</a>]\n+ and teach what's most rewarding first [<a href=\"#3\">3</a>].\n+ But Philip's \"two cultures\" aren't a reflection of some deep physical law.\n+ The split is an artifact of history,\n+ and there are lots of systems that deliver the best of both worlds.\n+ High-end computer animation tools like <a href=\"http://www.sidefx.com/\">Houdini</a>\n+ and <a href=\"http://www.autodesk.com/products/autodesk-maya/overview\">Maya</a>\n+ let people mix graphical interaction with textual scripting,\n+ and while hard-core programmers may sneer at Microsoft's office suite,\n+ it's amazing what can be built by combining Excel's direct manipulation of data\n+ with scripting in Visual Basic.\n+</p>\n+<p>\n+ Unfortunately,\n+ the key word in the preceding sentence is \"sneer\".\n+ When personal computers started offering human-friendly interfaces in the early 1980s,\n+ \"real\" programmers reacted with self-righteous envy [<a href=\"#4\">4</a>].\n+ That attitude became part of programming culture,\n+ and is one reason why programming has stagnated over the last 30 years\n+ [<a href=\"#5\">5</a>,<a href=\"#6\">6</a>].\n+ We create rich interfaces for everyone else,\n+ but refuse to use them ourselves;\n+ we insist that everything must be text,\n+ then wonder why people who <em>know</em> that you can style text and draw pictures in documents\n+ won't believe us when we say we know better.\n+ We're so convinced that we're right,\n+ and that <em>they</em> should join <em>us</em>,\n+ that we can't see how much <em>we</em> could learn from <em>them</em>.\n+</p>\n+<p>\n+ Ten years ago,\n+ I <a href=\"http://queue.acm.org/detail.cfm?id=1039534\">confidently predicted</a>\n+ predicted that programmers were finally about to see the light:\n+</p>\n+<blockquote>\n+ <p>\n+ We could still be writing and viewing programs a byte at a time in 2010...\n+ But do you really believe that will happen?\n+ Do you really believe that ours will be the only documents that aren't marked up,\n+ that can't contain heterogeneous content,\n+ that aren't processed by extensible frameworks?\n+ </p>\n+</blockquote>\n+<p>\n+ For once in my life,\n+ I was an optimist.\n+ You still can't embed a diagram directly in the source code of your program&mdash;the\n+ closest you can get is something like an image in an IPython Notebook,\n+ but there's no semantic connection between the two.\n+ (Hell,\n+ most version control systems still can't diff and merge standard vector formats like SVG.)\n+ And most of us are still piping lines of text from tool to tool,\n+ even though Microsoft's PowerShell showed us years ago","path":"blog/2013/12/tools-conversations-and-cultures.html","position":148,"original_position":148,"commit_id":"89a4d83b6c29ad14a1848b75617cbdc4d9bc04b3","original_commit_id":"89a4d83b6c29ad14a1848b75617cbdc4d9bc04b3","user":{"login":"pgbovine","id":235800,"avatar_url":"https://gravatar.com/avatar/6264a10fa779f0643400f7fcf2c32dd4?d=https%3A%2F%2Fidenticons.github.com%2Fd5821091fe4613f09b9df42a969b56fd.png&r=x","gravatar_id":"6264a10fa779f0643400f7fcf2c32dd4","url":"https://api.github.com/users/pgbovine","html_url":"https://github.com/pgbovine","followers_url":"https://api.github.com/users/pgbovine/followers","following_url":"https://api.github.com/users/pgbovine/following{/other_user}","gists_url":"https://api.github.com/users/pgbovine/gists{/gist_id}","starred_url":"https://api.github.com/users/pgbovine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgbovine/subscriptions","organizations_url":"https://api.github.com/users/pgbovine/orgs","repos_url":"https://api.github.com/users/pgbovine/repos","events_url":"https://api.github.com/users/pgbovine/events{/privacy}","received_events_url":"https://api.github.com/users/pgbovine/received_events","type":"User","site_admin":false},"body":"great! maybe add a link to a good PowerShell tutorial? i've also been fascinated by PowerShell but never had a chance to use it, since I don't work in a Windows ecosystem. I did see some folks at Microsoft use it briefly, though.","created_at":"2013-12-30T15:31:18Z","updated_at":"2013-12-30T15:31:18Z","html_url":"https://github.com/swcarpentry/site/pull/275#discussion_r8585975","pull_request_url":"https://api.github.com/repos/swcarpentry/site/pulls/275","_links":{"self":{"href":"https://api.github.com/repos/swcarpentry/site/pulls/comments/8585975"},"html":{"href":"https://github.com/swcarpentry/site/pull/275#discussion_r8585975"},"pull_request":{"href":"https://api.github.com/repos/swcarpentry/site/pulls/275"}}}}

{"repository":{"description":"Software Carpentry web site.","watchers":11,"stargazers":11,"forks":33,"fork":false,"size":70311,"owner":"swcarpentry","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"TeX","created_at":"2013-07-13T17:49:11-07:00","pushed_at":"2013-12-29T15:32:35-08:00","master_branch":"master","organization":"swcarpentry"},"actor_attributes":{"type":"User","name":"Philip Guo","blog":"http://www.pgbovine.net/","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/swcarpentry/site/pull/275#discussion_r8585975"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/swcarpentry/site/pulls/comments/6934531","id":6934531,"diff_hunk":"@@ -0,0 +1,192 @@\n+---\n+layout: blog\n+root: ../../..\n+author: Greg Wilson\n+title: \"Curriculum Design\"\n+date: 2013-10-14\n+time: \"09:00:00\"\n+category: [\"Teaching\", \"Lectures\"]\n+---\n+<!-- start excerpt -->\n+<p>\n+ I spoke with three different people about curriculum design last week,\n+ so this seems like a good time to summarize what I know about doing that properly,\n+ how we've actually been doing it for Software Carpentry,\n+ why the two are different,\n+ and what we hope to do in future.\n+ To set the stage,\n+ I need to talk about the medical program at McMaster University in Ontario.\n+</p>\n+<!-- end excerpt -->\n+<p>\n+ McMaster is one of Canada's younger universities,\n+ and prides itself on its practical bent.\n+ When it set out to create a medical school in the 1980s\n+ it surveyed hundreds of practicing physicians to find out\n+ what they remembered and used five years or more afer leaving school,\n+ then put that, and <em>only</em> that, into the curriculum.\n+ The idea was that if doctors who'd had time to settle into their practices\n+ weren't actually using something,\n+ there was no point teaching it in the first place.\n+</p>\n+<p>\n+ This evidence-based approach to curriculum design is sensible,\n+ practical,\n+ has solid theoretical and empirical foundations,\n+ and has been used successfully by a wide variety of organizations.\n+ It therefore elicited sneers and protests from other schools and the provincial medical association,\n+ primarily because the resulting program was only three years long rather than four.\n+ McMaster pressed ahead,\n+ though,\n+ and studies of their graduates have repeatedly shown that\n+ they are just as good at their jobs as anyone else.\n+</p>\n+<p>\n+ In a sane world,\n+ this would have led other universities to re-design their programs.\n+ In our world,\n+ though,\n+ that hasn't happened.\n+ The curriculum of most Ontario medical schools,\n+ and indeed of most other university programs,\n+ are still \"designed\" according to the following syllogism:\n+</p>\n+<ol>\n+ <li>I was taught that X is important.</li>\n+ <li>So it's important that I teach X to the next generation.</li>\n+</ol>\n+<p>\n+ \"Important to whom?\" is occasionally asked,\n+ but rarely answered except through anecdotes.\n+ Some universities do track the careers students pursue after graduation,\n+ but as far as I can tell,\n+ they never look at what knowledge and skills students actually use in those jobs.\n+ Meanwhile,\n+ university faculty aren't exposed to programs designed this way,\n+ so they don't think to look for that information\n+ when it's their turn to update their department's courses.\n+ As for funding agencies,\n+ good luck getting them to care about anything related to training...\n+</p>\n+<p>\n+ So here's how we should design the curriculum for\n+ a two-day Software Carpentry bootcamp:\n+</p>\n+<ol>\n+ <li>Identify a double dozen scientists who are computationally competent.</li>\n+ <li>Observe them at work for at least a couple of days, taking careful note of what they do.</li>\n+ <li>Categorize those observations.</li>\n+ <li>Sort by frequency to find the handful of tasks they spend most of their time on, and teach that stuff first.</li>\n+</ol>\n+<p>\n+ Step 2 is the most important of these.\n+ If you ask people to tell you what they do,\n+ they over-report the relatively rare activities that gave them trouble\n+ or required them to stop and think,\n+ and under-report the routine tasks that actually consume most of their time.\n+ The only way to get an accurate profile of where their time actually goes is\n+ to have a third party observe it.\n+ The \"couple of days\" part is important too:\n+ if you watch someone for an hour,\n+ all you see is them being self-conscious.\n+ You have to watch for an extended period so that you fade into the background,\n+ and also to get a representative sample of actual tasks.\n+</p>\n+<p>\n+ We've never done this for Software Carpentry,\n+ primarily because we've never found someone willing to back the necessary study.\n+ It wouldn't take a lot&mdash;two dozen subjects for two days each,\n+ an equal amount of time to categorize and re-categorize the observations,\n+ plus setup and travel,\n+ works out to about six months of full-time effort&mdash;but\n+ time and again,\n+ people have thought they think they can skip this step\n+ and magically land on the right result anyway.\n+ (Ironically,\n+ some of these people would describe themselves as data scientists,\n+ and could explain at length why basing decisions on personal experience\n+ and \"it's obvious to me\"\n+ is a bad idea...)\n+</p>\n+<p>\n+ What we've done as a substitute is much less rigorous,\n+ but has still led to major changes in what we do.\n+ Since May 2012,\n+ I've asked roughly 40 alumni of past bootcamps\n+ what practices they've actually adopted\n+ from those we've taught.\n+ Here's what I've learned:\n+</p>\n+<ul>\n+ <li>\n+ Most now use the shell at least some of the time\n+ (and those who don't have started using the \"history\" command\n+ of whatever tool they <em>do</em> use,\n+ which I'll take as a win).\n+ </li>\n+ <li>\n+ Most have also started breaking their programs up into small functions,\n+ regardless of what programming language they're using.\n+ </li>\n+ <li>\n+ There's no point trying to teach object-oriented programming to most of our attendees:\n+ it's just too much abstraction in one gulp.\n+ </li>\n+ <li>\n+ Only a third to a half have started using version control.\n+ Back when we were teaching Subversion,\n+ the main obstacle was setting up a server.\n+ Now that we're teaching Git on GitHub,\n+ the main obstacle is simply confusion,\n+ but that's <em>good</em> news:\n+ we can cut and clarify what we teach in response.\n+ </li>\n+ <li>\n+ Only a handful of our learners have actually started writing unit tests,\n+ but most of those who do have adopted something like test-driven development.\n+ (Basically,\n+ they either take testing to heart or leave it on the shelf completely.)\n+ My current hypothesis is that\n+ the kind of unit testing done in commercial software&mdash;the kind I've been teaching&mdash;isn't\n+ appropriate to most small-scale scientific coding,\n+ but I need to talk to a lot more people to firm this up\n+ and figure out what to do about it.\n+ </li>\n+ <li>\n+ Similarly,\n+ people either love or hate the databases portion of the class.\n+ They almost all <em>enjoy</em> a quick introduction to regular expressions,\n+ but only if the lesson uses an interactive tool like <a href=\"http://regexpal.com\">regexpal</a>.\n+ </li>\n+ <li>\n+ They don't care about software development process:\n+ my standard lecture comparing traditional (design-first) with agile\n+ goes over really well with undergrads in computer science and software engineering,\n+ but falls completely flat with most scientists.\n+ </li>\n+</ul>\n+<p>\n+ I had hoped to put some statistical meat on these anecdotal bones by now,\n+ but the graduate intern we hired in May to do assessment\n+ left after a few weeks for a full-time job,\n+ and the volunteer who replaced her\n+ has been busy doing his own PhD research,\n+ teaching for us,\n+ and shepherding a formal research proposal\n+ through his university's ethics board.\n+ As sooon as that gets the green light,\n+ I want to contact several hundred people and ask them\n+ which of the things we taught them have become part of their daily routine\n+ and what else they've learned on their own that we, or someone, should have taught them.\n+</p>\n+<p>\n+ What I really want to do,\n+ though,\n+ is persuade scientists to practice what they preach.\n+ We complain loud and long about idiots who think that\n+ paying attention to evidence is nothing more than a matter of personal taste\n+ when it comes to climate change, evolution, and a host of other subjects;\n+ we have no right to act the same way when it comes to education.\n+ If we're going to ask our students to do their best when they come into our classrooms,\n+ we have an obligation to do our best as well.","path":"blog/2013/10/curriculum-design.html","position":191,"original_position":191,"commit_id":"45baf16305425686ab2e488fde6ad41ca096cc01","original_commit_id":"45baf16305425686ab2e488fde6ad41ca096cc01","user":{"login":"ahmadia","id":512293,"avatar_url":"https://1.gravatar.com/avatar/821b8bf222958f83097ac40befc9edd7?d=https%3A%2F%2Fidenticons.github.com%2Fc91bbb76e45ea5f430c4a0ba4dd7c044.png","gravatar_id":"821b8bf222958f83097ac40befc9edd7","url":"https://api.github.com/users/ahmadia","html_url":"https://github.com/ahmadia","followers_url":"https://api.github.com/users/ahmadia/followers","following_url":"https://api.github.com/users/ahmadia/following{/other_user}","gists_url":"https://api.github.com/users/ahmadia/gists{/gist_id}","starred_url":"https://api.github.com/users/ahmadia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahmadia/subscriptions","organizations_url":"https://api.github.com/users/ahmadia/orgs","repos_url":"https://api.github.com/users/ahmadia/repos","events_url":"https://api.github.com/users/ahmadia/events{/privacy}","received_events_url":"https://api.github.com/users/ahmadia/received_events","type":"User","site_admin":false},"body":"great statement, perhaps tie it back in with a strong statement about evidence-based teaching?","created_at":"2013-10-13T14:11:48Z","updated_at":"2013-10-13T14:11:48Z","html_url":"https://github.com/swcarpentry/site/pull/164#discussion_r6934531","pull_request_url":"https://api.github.com/repos/swcarpentry/site/pulls/164","_links":{"self":{"href":"https://api.github.com/repos/swcarpentry/site/pulls/comments/6934531"},"html":{"href":"https://github.com/swcarpentry/site/pull/164#discussion_r6934531"},"pull_request":{"href":"https://api.github.com/repos/swcarpentry/site/pulls/164"}}}}

{"repository":{"description":"Software Carpentry web site.","watchers":4,"stargazers":4,"forks":24,"fork":false,"size":65506,"owner":"swcarpentry","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"CSS","created_at":"2013-07-13T17:49:11-07:00","pushed_at":"2013-10-11T03:23:00-07:00","master_branch":"master","organization":"swcarpentry"},"actor_attributes":{"type":"User","name":"Aron Ahmadia","company":"U.S. Army Engineer Research and Development Center","blog":"http://aron.ahmadia.net","location":"Alexandria, VA","email":"[email protected]"},"url":"https://github.com/swcarpentry/site/pull/164#discussion_r6934531"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/swcarpentry/website/pulls/comments/4286925","id":4286925,"body":"I'd change these to \"Day 1 - Morning\" and \"Day 1 - Afternoon\" to avoid confusion with \"1 AM\" and \"1 PM\".","diff_hunk":"@@ -0,0 +1,203 @@\n+{% extends \"_blog.html\" %}\n+{% block file_metadata %}\n+<meta name=\"post_id\" content=\"5443\" />\n+<meta name=\"author_id\" content=\"wilson.g\" />\n+<meta name=\"title\" content=\"Where We Are (More or Less)\" />\n+<meta name=\"post_date\" content=\"2013-05-16\" />\n+<meta name=\"category\" content=\"opinion\" />\n+{% endblock file_metadata %}\n+{% block content %}\n+<p>\n+ Software Carpentry's aim is to teach scientists basic computing concepts and skills\n+ so that they can get more done in less time and with less pain.\n+ As context, Bob Bixby recently wrote that:\n+</p>\n+<blockquote>\n+ Three orders of magnitude in machine speed\n+ and three orders of magnitude in algorithmic speed\n+ add up to six orders of magnitude in solving power.\n+ A model that might have taken a year to solve 10 years ago\n+ can now solve in less than 30 seconds.\n+</blockquote>\n+<p>\n+ A million-fold speedup is pretty impressive,\n+ but faster hardware and better algorithms are only two sides to the triangle.\n+ The third is development time,\n+ and while it has improved since 1987,\n+ the speedup is measured in small percentages,\n+ not orders of magnitude.\n+ For most scientists,\n+ getting the code to do the right thing\n+ is now a bigger bottleneck than its running time.\n+</p>\n+<p>\n+ That's where we come in.\n+ We teach scientists\n+ (usually grad students, since they have both need and time)\n+ what they ought to know\n+ before they tackle anything with \"peta\" or \"cloud\" in its name.\n+ Our hope is that if we give people basic skills,\n+ they'll be better able to take advantage of more sophisticated things.\n+</p>\n+<p>\n+ Between January 2012 and July 2013,\n+ over 100 volunteers will have run 92 two-day workshops for over 3000 scientists.\n+ A typical two-day curriculum is:\n+</p>\n+<ul>\n+ <li>\n+ <strong>Day 1 a.m.</strong>:","path":"blog/2013/05/where-we-are.html","position":49,"original_position":49,"commit_id":"f522ef1f591f76a3718513302d256195b4d791bb","original_commit_id":"f522ef1f591f76a3718513302d256195b4d791bb","user":{"login":"jiffyclub","id":920492,"avatar_url":"https://secure.gravatar.com/avatar/3994f17d0e03f2587d9fd2b7e5187fa8?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"3994f17d0e03f2587d9fd2b7e5187fa8","url":"https://api.github.com/users/jiffyclub","html_url":"https://github.com/jiffyclub","followers_url":"https://api.github.com/users/jiffyclub/followers","following_url":"https://api.github.com/users/jiffyclub/following{/other_user}","gists_url":"https://api.github.com/users/jiffyclub/gists{/gist_id}","starred_url":"https://api.github.com/users/jiffyclub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiffyclub/subscriptions","organizations_url":"https://api.github.com/users/jiffyclub/orgs","repos_url":"https://api.github.com/users/jiffyclub/repos","events_url":"https://api.github.com/users/jiffyclub/events{/privacy}","received_events_url":"https://api.github.com/users/jiffyclub/received_events","type":"User"},"created_at":"2013-05-18T01:24:02Z","updated_at":"2013-05-18T01:24:02Z","html_url":"https://github.com/swcarpentry/website/pull/546#discussion_r4286925","pull_request_url":"https://api.github.com/repos/swcarpentry/website/pulls/546","_links":{"self":{"href":"https://api.github.com/repos/swcarpentry/website/pulls/comments/4286925"},"html":{"href":"https://github.com/swcarpentry/website/pull/546#discussion_r4286925"},"pull_request":{"href":"https://api.github.com/repos/swcarpentry/website/pulls/546"}}}}

{"repository":{"description":"Source files for software-carpentry.org","homepage":"http://software-carpentry.org","watchers":24,"stargazers":24,"forks":32,"fork":false,"size":1084,"owner":"swcarpentry","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-12-08T08:22:30-08:00","pushed_at":"2013-05-17T18:20:30-07:00","master_branch":"master","organization":"swcarpentry"},"actor_attributes":{"type":"User","name":"Matt Davis","blog":"penandpants.com","email":"[email protected]"},"url":"https://github.com/swcarpentry/website/pull/546#discussion_r4286925"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/swiftmailer/swiftmailer/pulls/comments/7704710","id":7704710,"diff_hunk":"@@ -159,12 +155,12 @@ public function getReplacementsFor($address)\n {\n if ($this->_replacements instanceof Swift_Plugins_Decorator_Replacements) {\n return $this->_replacements->getReplacementsFor($address);\n- } else {\n- return isset($this->_replacements[$address])\n- ? $this->_replacements[$address]\n- : null\n- ;\n }\n+\n+ return isset($this->_replacements[$address]) ?: $this->_replacements[$address];","path":"lib/classes/Swift/Plugins/DecoratorPlugin.php","position":42,"original_position":42,"commit_id":"25f1f11d8397271cd4bfb36d922cf530547fc10f","original_commit_id":"25f1f11d8397271cd4bfb36d922cf530547fc10f","user":{"login":"cordoval","id":328359,"avatar_url":"https://1.gravatar.com/avatar/ab2a6b877dd41427c660a3d6a170cc71?d=https%3A%2F%2Fidenticons.github.com%2Fbaab6a6fd290d8efddc3f5e0fa0fdcf1.png&r=x","gravatar_id":"ab2a6b877dd41427c660a3d6a170cc71","url":"https://api.github.com/users/cordoval","html_url":"https://github.com/cordoval","followers_url":"https://api.github.com/users/cordoval/followers","following_url":"https://api.github.com/users/cordoval/following{/other_user}","gists_url":"https://api.github.com/users/cordoval/gists{/gist_id}","starred_url":"https://api.github.com/users/cordoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cordoval/subscriptions","organizations_url":"https://api.github.com/users/cordoval/orgs","repos_url":"https://api.github.com/users/cordoval/repos","events_url":"https://api.github.com/users/cordoval/events{/privacy}","received_events_url":"https://api.github.com/users/cordoval/received_events","type":"User","site_admin":false},"body":"what about my other question on travis?","created_at":"2013-11-15T22:31:24Z","updated_at":"2013-11-15T22:31:24Z","html_url":"https://github.com/swiftmailer/swiftmailer/pull/389#discussion_r7704710","pull_request_url":"https://api.github.com/repos/swiftmailer/swiftmailer/pulls/389","_links":{"self":{"href":"https://api.github.com/repos/swiftmailer/swiftmailer/pulls/comments/7704710"},"html":{"href":"https://github.com/swiftmailer/swiftmailer/pull/389#discussion_r7704710"},"pull_request":{"href":"https://api.github.com/repos/swiftmailer/swiftmailer/pulls/389"}}}}

{"repository":{"description":"Comprehensive mailing tools for PHP","homepage":"http://swiftmailer.org/","watchers":822,"stargazers":822,"forks":228,"fork":false,"size":14395,"owner":"swiftmailer","private":false,"open_issues":181,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"PHP","created_at":"2008-12-19T00:31:03-08:00","pushed_at":"2013-10-04T05:57:44-07:00","integrate_branch":"4.1","master_branch":"master","organization":"swiftmailer"},"actor_attributes":{"type":"User","name":"Luis Cordova","company":"","blog":"http://www.craftitonline.com","location":"","email":"[email protected]"},"url":"https://github.com/swiftmailer/swiftmailer/pull/389#discussion_r7704710"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/symfony-cmf/symfony-cmf-docs/pulls/comments/5109960","id":5109960,"body":"I cannot figure out what this should be.","diff_hunk":"@@ -260,6 +303,29 @@ Configuration\n ssi:\n token: a unique security key # a random one is generated by default\n \n+ .. code-block:: xml\n+\n+ <!-- app/config/config.xml -->\n+ <cmf_block:config>\n+ <caches>\n+ <ssi>\n+ ???","path":"bundles/block/cache.rst","position":124,"original_position":124,"commit_id":"9795d6887aa86c24ab5afb9542dea23c197916ab","original_commit_id":"9795d6887aa86c24ab5afb9542dea23c197916ab","user":{"login":"rmsint","id":1230229,"avatar_url":"https://secure.gravatar.com/avatar/451f18eb7ad71135e34d425336e4840e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"451f18eb7ad71135e34d425336e4840e","url":"https://api.github.com/users/rmsint","html_url":"https://github.com/rmsint","followers_url":"https://api.github.com/users/rmsint/followers","following_url":"https://api.github.com/users/rmsint/following{/other_user}","gists_url":"https://api.github.com/users/rmsint/gists{/gist_id}","starred_url":"https://api.github.com/users/rmsint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmsint/subscriptions","organizations_url":"https://api.github.com/users/rmsint/orgs","repos_url":"https://api.github.com/users/rmsint/repos","events_url":"https://api.github.com/users/rmsint/events{/privacy}","received_events_url":"https://api.github.com/users/rmsint/received_events","type":"User"},"created_at":"2013-07-10T08:27:41Z","updated_at":"2013-07-10T08:27:41Z","html_url":"https://github.com/symfony-cmf/symfony-cmf-docs/pull/181#discussion_r5109960","pull_request_url":"https://api.github.com/repos/symfony-cmf/symfony-cmf-docs/pulls/181","_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/symfony-cmf-docs/pulls/comments/5109960"},"html":{"href":"https://github.com/symfony-cmf/symfony-cmf-docs/pull/181#discussion_r5109960"},"pull_request":{"href":"https://api.github.com/repos/symfony-cmf/symfony-cmf-docs/pulls/181"}}}}

{"repository":{"description":"The documentation for the symfony content management framework","homepage":"http://cmf.symfony.com","watchers":30,"stargazers":30,"forks":45,"fork":false,"size":864,"owner":"symfony-cmf","private":false,"open_issues":17,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-01-19T04:37:25-08:00","pushed_at":"2013-07-09T10:18:44-07:00","master_branch":"master","organization":"symfony-cmf"},"actor_attributes":{"type":"User","name":"Roel Sint","company":"Beeldspraak","location":"Rotterdam","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/symfony-cmf/symfony-cmf-docs/pull/181#discussion_r5109960"}

PullRequestReviewCommentEvent

{"comment":{"original_position":33,"original_commit_id":"d3541d5bff047dbf505896e8cc5abb14f6c4b6fd","updated_at":"2013-01-30T12:05:58Z","id":2825323,"body":"Yeah, that would be simpler","position":33,"created_at":"2013-01-30T12:05:58Z","url":"https://api.github.com/repos/symfony-cmf/TreeBrowserBundle/pulls/comments/2825323","commit_id":"d3541d5bff047dbf505896e8cc5abb14f6c4b6fd","user":{"starred_url":"https://api.github.com/users/dantleech/starred{/owner}{/repo}","id":530801,"organizations_url":"https://api.github.com/users/dantleech/orgs","following_url":"https://api.github.com/users/dantleech/following","received_events_url":"https://api.github.com/users/dantleech/received_events","gravatar_id":"c465efe6980caacfdb43780d7bd5b0dc","events_url":"https://api.github.com/users/dantleech/events{/privacy}","login":"dantleech","subscriptions_url":"https://api.github.com/users/dantleech/subscriptions","url":"https://api.github.com/users/dantleech","followers_url":"https://api.github.com/users/dantleech/followers","avatar_url":"https://secure.gravatar.com/avatar/c465efe6980caacfdb43780d7bd5b0dc?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gists_url":"https://api.github.com/users/dantleech/gists{/gist_id}","repos_url":"https://api.github.com/users/dantleech/repos","type":"User"},"path":"Model/PhpcrNode.php","_links":{"pull_request":{"href":"https://api.github.com/repos/symfony-cmf/TreeBrowserBundle/pulls/23"},"html":{"href":"https://github.com/symfony-cmf/TreeBrowserBundle/pull/23#discussion_r2825323"},"self":{"href":"https://api.github.com/repos/symfony-cmf/TreeBrowserBundle/pulls/comments/2825323"}}}}

{"repository":{"description":"Integrates with the TreeBundle to enable browsing a PHPCR repository.","owner":"symfony-cmf","has_issues":true,"has_downloads":true,"language":"JavaScript","pushed_at":"2013-01-28T01:20:37-08:00","forks":4,"watchers":8,"has_wiki":true,"stargazers":8,"fork":false,"size":164,"homepage":"http://cmf.symfony.com","open_issues":6,"private":false,"created_at":"2012-05-05T03:23:20-07:00","organization":"symfony-cmf"},"actor_attributes":{"name":"dantleech","type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/symfony-cmf/TreeBrowserBundle/pull/23#discussion_r2825323"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/symfony-cmf/symfony-cmf-docs/pulls/comments/3637529","id":3637529,"body":"it's yaml code, use `.. code-block:: yaml`","diff_hunk":"@@ -37,4 +37,81 @@ The controller to get the feed items can also be changed:\n \n .. note::\n \n- The `Symfony CMF Sandbox <https://github.com/symfony-cmf/cmf-sandbox>`_ contains an example of the RssBlock.\n\\ No newline at end of file\n+ The `Symfony CMF Sandbox <https://github.com/symfony-cmf/cmf-sandbox>`_ contains an example of the RssBlock.\n+\n+SlideshowBlock\n+--------\n+\n+The ``SlideshowBlock`` is just a special kind of ``ContainerBlock``, a container for the slides of a slideshow. The\n+BlockBundle also comes with a ``SlideshowItemBlock`` which represents a very simple kind of slide, a ``SlideshowItem``,\n+which contains an image and a label. However you are free to use whatever block you want as an item for a slideshow.\n+You can also mix different sorts of slides in the same slideshow.\n+\n+Create your first slideshow\n+`````````````\n+\n+.. code-block:: php\n+\n+ // create slideshow\n+ $mySlideshow = new SlideshowBlock();\n+ $mySlideshow->setName('slideshow');\n+ $mySlideshow->setParentDocument($parentPage);\n+ $mySlideshow->setTitle('My first Slideshow');\n+ $documentManager->persist($mySlideshow);\n+\n+ // add first slide to slideshow\n+ $mySlideshowItem = new SlideshowItemBlock();\n+ $mySlideshowItem->setName('first_item');\n+ $mySlideshowItem->setLabel('label of first item');\n+ $mySlideshowItem->setParentDocument($mySlideshow);\n+ $manager->persist($mySlideshowItem);\n+\n+ $file = new File();\n+ $file->setFileContentFromFilesystem('path/to/my/image.jpg');\n+ $image = new Image();\n+ $image->setFile($file);\n+ $mySlideshowItem->setImage($image);\n+\n+Render the slideshow\n+`````````````\n+\n+Rendering your slideshow is as easy as just rendering the according block in your template. Note that your document\n+needs to have a ``SlideshowBlock`` with the name used here:\n+\n+.. code-block:: php\n+\n+ {{ sonata_block_render({\n+ 'name': 'slideshow'\n+ }) }}\n+\n+Use the admin class\n+`````````````\n+\n+The BlockBundle comes with admin classes for managing slideshows and slideshow items directly in SonataAdmin. All you\n+need to do to administrate slideshows in your project is to add the following line to your sonata admin configuration:\n+\n+.. code-block:: php","path":"bundles/block/types.rst","position":59,"original_position":59,"commit_id":"21a7dc2f4e42ea527a3722f8f9edff17e8236574","original_commit_id":"21a7dc2f4e42ea527a3722f8f9edff17e8236574","user":{"login":"WouterJ","id":749025,"avatar_url":"https://secure.gravatar.com/avatar/331582449435f5efa35be870ab76f1a9?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"331582449435f5efa35be870ab76f1a9","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User"},"created_at":"2013-04-03T14:26:10Z","updated_at":"2013-04-03T14:26:10Z","html_url":"https://github.com/symfony-cmf/symfony-cmf-docs/pull/104#discussion_r3637529","pull_request_url":"https://api.github.com/repos/symfony-cmf/symfony-cmf-docs/pulls/104","_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/symfony-cmf-docs/pulls/comments/3637529"},"html":{"href":"https://github.com/symfony-cmf/symfony-cmf-docs/pull/104#discussion_r3637529"},"pull_request":{"href":"https://api.github.com/repos/symfony-cmf/symfony-cmf-docs/pulls/104"}}}}

{"repository":{"description":"The documentation for the symfony content management framework","homepage":"http://cmf.symfony.com","watchers":24,"stargazers":24,"forks":38,"fork":false,"size":500,"owner":"symfony-cmf","private":false,"open_issues":7,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-01-19T04:37:25-08:00","pushed_at":"2013-03-27T06:16:11-07:00","master_branch":"master","organization":"symfony-cmf"},"actor_attributes":{"type":"User","name":"Wouter J","blog":"http://wouterj.nl","location":"Netherlands","email":"[email protected]"},"url":"https://github.com/symfony-cmf/symfony-cmf-docs/pull/104#discussion_r3637529"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/symfony-cmf/symfony-cmf-docs/pulls/comments/5179031","id":5179031,"body":"`</config>`","diff_hunk":"@@ -23,37 +23,328 @@ Configuration\n \n # app/config/config.yml\n cmf_core:\n- document_manager_name: default\n- role: IS_AUTHENTICATED_ANONYMOUSLY # used by the publish workflow checker\n+ document_manager_name: null # used for the twig functions to fetch documents\n+ publish_workflow:\n+ enabled: true\n+ view_non_published_role: ROLE_CAN_VIEW_NON_PUBLISHED\n+ request_listener: true\n \n .. code-block:: xml\n \n <!-- app/config/config.xml -->\n- <!-- role: used by the publish workflow checker -->\n <config xmlns=\"http://symfony.com/schema/dic/core\"\n- document-manager-name=\"default\"\n- role=\"IS_AUTHENTICATED_ANONYMOUSLY\"\n- />\n+ document-manager-name=\"null\">\n+ <publish-workflow\n+ enabled=\"true\"\n+ view-non-published-role=\"ROLE_CAN_VIEW_NON_PUBLISHED\"\n+ request-listener=\"true\"\n+ />\n+ <config/>","path":"bundles/core.rst","position":26,"original_position":26,"commit_id":"df62e7f1fccb51a094d5d8c2045f7c047c7dbe1b","original_commit_id":"df62e7f1fccb51a094d5d8c2045f7c047c7dbe1b","user":{"login":"WouterJ","id":749025,"avatar_url":"https://secure.gravatar.com/avatar/331582449435f5efa35be870ab76f1a9?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"331582449435f5efa35be870ab76f1a9","url":"https://api.github.com/users/WouterJ","html_url":"https://github.com/WouterJ","followers_url":"https://api.github.com/users/WouterJ/followers","following_url":"https://api.github.com/users/WouterJ/following{/other_user}","gists_url":"https://api.github.com/users/WouterJ/gists{/gist_id}","starred_url":"https://api.github.com/users/WouterJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WouterJ/subscriptions","organizations_url":"https://api.github.com/users/WouterJ/orgs","repos_url":"https://api.github.com/users/WouterJ/repos","events_url":"https://api.github.com/users/WouterJ/events{/privacy}","received_events_url":"https://api.github.com/users/WouterJ/received_events","type":"User"},"created_at":"2013-07-13T10:01:29Z","updated_at":"2013-07-13T10:01:29Z","html_url":"https://github.com/symfony-cmf/symfony-cmf-docs/pull/171#discussion_r5179031","pull_request_url":"https://api.github.com/repos/symfony-cmf/symfony-cmf-docs/pulls/171","_links":{"self":{"href":"https://api.github.com/repos/symfony-cmf/symfony-cmf-docs/pulls/comments/5179031"},"html":{"href":"https://github.com/symfony-cmf/symfony-cmf-docs/pull/171#discussion_r5179031"},"pull_request":{"href":"https://api.github.com/repos/symfony-cmf/symfony-cmf-docs/pulls/171"}}}}

{"repository":{"description":"The documentation for the symfony content management framework","homepage":"http://cmf.symfony.com","watchers":30,"stargazers":30,"forks":46,"fork":false,"size":836,"owner":"symfony-cmf","private":false,"open_issues":13,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-01-19T04:37:25-08:00","pushed_at":"2013-07-13T02:56:44-07:00","master_branch":"master","organization":"symfony-cmf"},"actor_attributes":{"type":"User","name":"Wouter J","blog":"http://wouterj.nl","location":"Netherlands","email":"[email protected]"},"url":"https://github.com/symfony-cmf/symfony-cmf-docs/pull/171#discussion_r5179031"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/SpringSource/spring-integration/pulls/comments/4392959","id":4392959,"body":"Hmmm... I have done that but I was thinking someone might configure their advice chain like this...\r\n\r\n\t<util:list id=\"adviceList\">\r\n\t\t<bean ... />\r\n\t\t<bean ... />\r\n\t</util:list>\r\n\r\nBut, I can see some benefit of allowing them to configure like so...\r\n\r\n @ ServiceActivator(adviceChain = {\"advice1\", \"advice2\"}\r\n\r\nSo, I changed it to an array but if one of more the beans is a collection or array, it is expanded in-line.\r\n\r\nWDYT?\r\n","diff_hunk":"@@ -46,4 +47,8 @@\n \n \tString outputChannel() default \"\";\n \n+\tString adviceChain() default \"\";","path":"spring-integration-core/src/main/java/org/springframework/integration/annotation/Filter.java","position":null,"original_position":22,"commit_id":"b01bd04d919db3b21f4866520e641b21ad090f22","original_commit_id":"42ab98d4eded3300adf09d8e68455c595c9cac03","user":{"login":"garyrussell","id":483832,"avatar_url":"https://secure.gravatar.com/avatar/9f30ba7b0ff0c1b76b07010960dde60d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"9f30ba7b0ff0c1b76b07010960dde60d","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User"},"created_at":"2013-05-25T18:01:52Z","updated_at":"2013-05-25T18:01:52Z","html_url":"https://github.com/SpringSource/spring-integration/pull/811#discussion_r4392959","pull_request_url":"https://api.github.com/repos/SpringSource/spring-integration/pulls/811","_links":{"self":{"href":"https://api.github.com/repos/SpringSource/spring-integration/pulls/comments/4392959"},"html":{"href":"https://github.com/SpringSource/spring-integration/pull/811#discussion_r4392959"},"pull_request":{"href":"https://api.github.com/repos/SpringSource/spring-integration/pulls/811"}}}}

{"repository":{"description":"Spring Integration provides an extension of the Spring programming model to support the well-known Enterprise Integration Patterns (EIP)","homepage":"http://www.springsource.org/spring-integration","watchers":180,"stargazers":180,"forks":116,"fork":false,"size":22588,"owner":"SpringSource","private":false,"open_issues":8,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2011-07-22T14:47:27-07:00","pushed_at":"2013-05-24T13:43:19-07:00","master_branch":"master","organization":"SpringSource"},"actor_attributes":{"type":"User","name":"Gary Russell","company":"Pivotal","blog":"http://gprussell.net/blog/","location":"USA North East","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/SpringSource/spring-integration/pull/811#discussion_r4392959"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/WindowsAzure/azure-sdk-tools/pulls/comments/3951484","id":3951484,"body":"What do you think about having this method as part of `IStorageTableManagement`? Then in PowerShell cmdlet code you would just call `Channel.ListTablesByName`.\r\n\r\nIn my new code I am trying to minimize the amount of the code o write in PowerShell cmdlet so the code more modular and reusable","diff_hunk":"@@ -0,0 +1,176 @@\n+// ----------------------------------------------------------------------------------\n+//\n+// Copyright Microsoft Corporation\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+// http://www.apache.org/licenses/LICENSE-2.0\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+// ----------------------------------------------------------------------------------\n+\n+namespace Microsoft.WindowsAzure.Management.Storage.Table.Cmdlet\n+{\n+ using Microsoft.WindowsAzure.Management.Storage.Common;\n+ using Microsoft.WindowsAzure.Management.Storage.Model.Contract;\n+ using Microsoft.WindowsAzure.Management.Storage.Model.ResourceModel;\n+ using Microsoft.WindowsAzure.Storage.Table;\n+ using System;\n+ using System.Collections.Generic;\n+ using System.Management.Automation;\n+ using System.Security.Permissions;\n+\n+ /// <summary>\n+ /// list azure tables\n+ /// </summary>\n+ [Cmdlet(VerbsCommon.Get, StorageNouns.Table, DefaultParameterSetName = NameParameterSet),\n+ OutputType(typeof(AzureStorageTable))]\n+ public class GetAzureStorageTableCommand : StorageCloudTableCmdletBase\n+ {\n+ /// <summary>\n+ /// default parameter set name\n+ /// </summary>\n+ private const string NameParameterSet = \"TableName\";\n+\n+ /// <summary>\n+ /// prefix parameter set name\n+ /// </summary>\n+ private const string PrefixParameterSet = \"TablePrefix\";\n+\n+ [Alias(\"N\", \"Table\")]\n+ [Parameter(Position = 0, HelpMessage = \"Table name\",\n+ ValueFromPipeline = true,\n+ ValueFromPipelineByPropertyName = true,\n+ ParameterSetName = NameParameterSet)]\n+ public string Name { get; set; }\n+\n+ [Parameter(HelpMessage = \"Table Prefix\",\n+ ParameterSetName = PrefixParameterSet, Mandatory = true)]\n+ [ValidateNotNullOrEmpty]\n+ public string Prefix { get; set; }\n+\n+ /// <summary>\n+ /// Initializes a new instance of the GetAzureStorageTableCommand class.\n+ /// </summary>\n+ public GetAzureStorageTableCommand()\n+ : this(null)\n+ {\n+ }\n+\n+ /// <summary>\n+ /// Initializes a new instance of the GetAzureStorageTableCommand class.\n+ /// </summary>\n+ /// <param name=\"channel\">IStorageTableManagement channel</param>\n+ public GetAzureStorageTableCommand(IStorageTableManagement channel)\n+ {\n+ Channel = channel;\n+ }\n+\n+ /// <summary>\n+ /// list azure tables by table name\n+ /// </summary>\n+ /// <param name=\"name\">table name</param>\n+ /// <returns>An enumerable collection of CloudTable object</returns>\n+ internal IEnumerable<CloudTable> ListTablesByName(string name)","path":"WindowsAzurePowershell/src/Management.Storage/Table/Cmdlet/GetStorageAzureTable.cs","position":77,"original_position":77,"commit_id":"ba8deeb7593c2a9e066bf38f426c4b4bceb7895e","original_commit_id":"ba8deeb7593c2a9e066bf38f426c4b4bceb7895e","user":{"login":"ogail","id":1034045,"avatar_url":"https://secure.gravatar.com/avatar/845e2279db97207146d9a29a8223e939?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"845e2279db97207146d9a29a8223e939","url":"https://api.github.com/users/ogail","html_url":"https://github.com/ogail","followers_url":"https://api.github.com/users/ogail/followers","following_url":"https://api.github.com/users/ogail/following","gists_url":"https://api.github.com/users/ogail/gists{/gist_id}","starred_url":"https://api.github.com/users/ogail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogail/subscriptions","organizations_url":"https://api.github.com/users/ogail/orgs","repos_url":"https://api.github.com/users/ogail/repos","events_url":"https://api.github.com/users/ogail/events{/privacy}","received_events_url":"https://api.github.com/users/ogail/received_events","type":"User"},"created_at":"2013-04-25T05:10:32Z","updated_at":"2013-04-25T05:10:32Z","html_url":"https://github.com/WindowsAzure/azure-sdk-tools/pull/1397#discussion_r3951484","pull_request_url":"https://api.github.com/repos/WindowsAzure/azure-sdk-tools/pulls/1397","_links":{"self":{"href":"https://api.github.com/repos/WindowsAzure/azure-sdk-tools/pulls/comments/3951484"},"html":{"href":"https://github.com/WindowsAzure/azure-sdk-tools/pull/1397#discussion_r3951484"},"pull_request":{"href":"https://api.github.com/repos/WindowsAzure/azure-sdk-tools/pulls/1397"}}}}

{"repository":{"description":"Windows Azure Powershell","homepage":"http://www.windowsazure.com/en-us/develop/overview/","watchers":203,"stargazers":203,"forks":72,"fork":false,"size":78513,"owner":"WindowsAzure","private":false,"open_issues":329,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"VHDL","created_at":"2011-12-08T10:36:46-08:00","pushed_at":"2013-04-24T11:00:24-07:00","master_branch":"master","organization":"WindowsAzure"},"actor_attributes":{"type":"User","name":"Abdelrahman Elogeel","company":"Microsoft","blog":"http://www.linkedin.com/in/elogeel","location":"Redmond, WA, USA","email":"[email protected]"},"url":"https://github.com/WindowsAzure/azure-sdk-tools/pull/1397#discussion_r3951484"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/WindowsAzure/azure-sdk-tools-xplat/pulls/comments/5592956","id":5592956,"body":"Removed this one and the one for delete as well.","diff_hunk":"@@ -1616,32 +1525,24 @@ exports.init = function (cli) {\n });\n \n mobile.command('restart [servicename]')\n- .usage('[options] [servicename]')\n+ .usage('[servicename] [options]')","path":"lib/commands/mobile._js","position":null,"original_position":414,"commit_id":"0a12bfb5cde13a1ac11512da8617fb0d85d6004b","original_commit_id":"a74891ee333574e01d0aecbc8f189d6ac52a3fb5","user":{"login":"phvannor","id":3979343,"avatar_url":"https://secure.gravatar.com/avatar/3a35c1bc6cbfe2a4e0b7bf555e459dd5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"3a35c1bc6cbfe2a4e0b7bf555e459dd5","url":"https://api.github.com/users/phvannor","html_url":"https://github.com/phvannor","followers_url":"https://api.github.com/users/phvannor/followers","following_url":"https://api.github.com/users/phvannor/following{/other_user}","gists_url":"https://api.github.com/users/phvannor/gists{/gist_id}","starred_url":"https://api.github.com/users/phvannor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phvannor/subscriptions","organizations_url":"https://api.github.com/users/phvannor/orgs","repos_url":"https://api.github.com/users/phvannor/repos","events_url":"https://api.github.com/users/phvannor/events{/privacy}","received_events_url":"https://api.github.com/users/phvannor/received_events","type":"User"},"created_at":"2013-08-05T23:11:58Z","updated_at":"2013-08-05T23:11:58Z","html_url":"https://github.com/WindowsAzure/azure-sdk-tools-xplat/pull/844#discussion_r5592956","pull_request_url":"https://api.github.com/repos/WindowsAzure/azure-sdk-tools-xplat/pulls/844","_links":{"self":{"href":"https://api.github.com/repos/WindowsAzure/azure-sdk-tools-xplat/pulls/comments/5592956"},"html":{"href":"https://github.com/WindowsAzure/azure-sdk-tools-xplat/pull/844#discussion_r5592956"},"pull_request":{"href":"https://api.github.com/repos/WindowsAzure/azure-sdk-tools-xplat/pulls/844"}}}}

{"repository":{"description":"Windows Azure Cross Platform Command Line","homepage":"","watchers":41,"stargazers":41,"forks":39,"fork":false,"size":15224,"owner":"WindowsAzure","private":false,"open_issues":208,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-11-02T06:43:50-07:00","pushed_at":"2013-08-05T14:05:43-07:00","master_branch":"master","organization":"WindowsAzure"},"actor_attributes":{"type":"User","name":"Phillip Van Nortwick","company":"Microsoft","location":"Remond, WA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/WindowsAzure/azure-sdk-tools-xplat/pull/844#discussion_r5592956"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/WindowsAzure/azure-sdk-tools/pulls/comments/6872774","id":6872774,"diff_hunk":"@@ -6,6 +6,10 @@\n <assemblyIdentity name=\"Microsoft.WindowsAzure.Storage\" publicKeyToken=\"31bf3856ad364e35\" culture=\"neutral\" />\n <bindingRedirect oldVersion=\"0.0.0.0-2.1.0.2\" newVersion=\"2.1.0.2\" />\n </dependentAssembly>\n+ <dependentAssembly>","path":"WindowsAzurePowershell/src/Commands.ScenarioTest/app.config","position":4,"original_position":4,"commit_id":"d5f33c9d410c1043f6f711732ef570f517e34d06","original_commit_id":"d5f33c9d410c1043f6f711732ef570f517e34d06","user":{"login":"christav","id":1987321,"avatar_url":"https://1.gravatar.com/avatar/96fa4bf8b014a9c86e2264fced4d3e7b?d=https%3A%2F%2Fidenticons.github.com%2F90b6e012efb4d0c45398eb2ba109f17c.png","gravatar_id":"96fa4bf8b014a9c86e2264fced4d3e7b","url":"https://api.github.com/users/christav","html_url":"https://github.com/christav","followers_url":"https://api.github.com/users/christav/followers","following_url":"https://api.github.com/users/christav/following{/other_user}","gists_url":"https://api.github.com/users/christav/gists{/gist_id}","starred_url":"https://api.github.com/users/christav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christav/subscriptions","organizations_url":"https://api.github.com/users/christav/orgs","repos_url":"https://api.github.com/users/christav/repos","events_url":"https://api.github.com/users/christav/events{/privacy}","received_events_url":"https://api.github.com/users/christav/received_events","type":"User","site_admin":false},"body":"We're going to take the app.config files back out.","created_at":"2013-10-09T22:17:53Z","updated_at":"2013-10-09T22:17:53Z","html_url":"https://github.com/WindowsAzure/azure-sdk-tools/pull/1938#discussion_r6872774","pull_request_url":"https://api.github.com/repos/WindowsAzure/azure-sdk-tools/pulls/1938","_links":{"self":{"href":"https://api.github.com/repos/WindowsAzure/azure-sdk-tools/pulls/comments/6872774"},"html":{"href":"https://github.com/WindowsAzure/azure-sdk-tools/pull/1938#discussion_r6872774"},"pull_request":{"href":"https://api.github.com/repos/WindowsAzure/azure-sdk-tools/pulls/1938"}}}}

{"repository":{"description":"Windows Azure Powershell","homepage":"http://www.windowsazure.com/en-us/develop/overview/","watchers":229,"stargazers":229,"forks":116,"fork":false,"size":66239,"owner":"WindowsAzure","private":false,"open_issues":5,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"VHDL","created_at":"2011-12-08T10:36:46-08:00","pushed_at":"2013-10-09T14:26:35-07:00","master_branch":"master","organization":"WindowsAzure"},"actor_attributes":{"type":"User","name":"Chris Tavares","company":"Microsoft","location":"Redmond, WA","email":"[email protected]"},"url":"https://github.com/WindowsAzure/azure-sdk-tools/pull/1938#discussion_r6872774"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/WindowsAzure/azure-sdk-for-node/pulls/comments/4624500","id":4624500,"body":"Variables containing a collection should have plural names.","diff_hunk":"@@ -178,6 +178,113 @@ HDInsightService.prototype.convertCreationObject = function (clusterCreationObje\n return payload;\r\n };\r\n \r\n+function transformResponse (cloudService) {\r\n+ if (!_.isArray(cloudService)) {\r\n+ cloudService = [ cloudService ];\r\n+ }\r\n+ var clusters = [];\r\n+ for (var i = 0; i < cloudService.length; i++) {\r\n+ if (cloudService[i].Name &&\r\n+ cloudService[i].Name.indexOf('hdinsight') === 0) {\r\n+ if (cloudService[i].Resources && cloudService[i].Resources.Resource) {\r\n+ if (!_.isArray(cloudService[i].Resources.Resource)) {\r\n+ cloudService[i].Resources.Resource = [ cloudService[i].Resources.Resource ];\r\n+ }\r\n+\r\n+ var resource = cloudService[i].Resources.Resource;\r","path":"lib/services/serviceManagement/hdinsightservice.js","position":17,"original_position":17,"commit_id":"2f22c92773993a54c4e4bf10bdc6548ff11ef937","original_commit_id":"2f22c92773993a54c4e4bf10bdc6548ff11ef937","user":{"login":"christav","id":1987321,"avatar_url":"https://secure.gravatar.com/avatar/96fa4bf8b014a9c86e2264fced4d3e7b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"96fa4bf8b014a9c86e2264fced4d3e7b","url":"https://api.github.com/users/christav","html_url":"https://github.com/christav","followers_url":"https://api.github.com/users/christav/followers","following_url":"https://api.github.com/users/christav/following{/other_user}","gists_url":"https://api.github.com/users/christav/gists{/gist_id}","starred_url":"https://api.github.com/users/christav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christav/subscriptions","organizations_url":"https://api.github.com/users/christav/orgs","repos_url":"https://api.github.com/users/christav/repos","events_url":"https://api.github.com/users/christav/events{/privacy}","received_events_url":"https://api.github.com/users/christav/received_events","type":"User"},"created_at":"2013-06-10T23:54:25Z","updated_at":"2013-06-10T23:54:25Z","html_url":"https://github.com/WindowsAzure/azure-sdk-for-node/pull/827#discussion_r4624500","pull_request_url":"https://api.github.com/repos/WindowsAzure/azure-sdk-for-node/pulls/827","_links":{"self":{"href":"https://api.github.com/repos/WindowsAzure/azure-sdk-for-node/pulls/comments/4624500"},"html":{"href":"https://github.com/WindowsAzure/azure-sdk-for-node/pull/827#discussion_r4624500"},"pull_request":{"href":"https://api.github.com/repos/WindowsAzure/azure-sdk-for-node/pulls/827"}}}}

{"repository":{"description":"Windows Azure SDK for Node.js","homepage":"http://www.windowsazure.com/en-us/develop/nodejs/","watchers":421,"stargazers":421,"forks":94,"fork":false,"size":1052,"owner":"WindowsAzure","private":false,"open_issues":82,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2011-12-09T15:38:42-08:00","pushed_at":"2013-06-10T09:46:59-07:00","master_branch":"master","organization":"WindowsAzure"},"actor_attributes":{"type":"User","name":"Chris Tavares","company":"Microsoft","location":"Redmond, WA","email":"[email protected]"},"url":"https://github.com/WindowsAzure/azure-sdk-for-node/pull/827#discussion_r4624500"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/WindowsAzure/azure-sdk-for-node/pulls/comments/3906634","id":3906634,"body":"do we need to do the same for service bus ? Why not add simply support for connection strings and avoid keep growing the env variables ?","diff_hunk":"@@ -87,6 +87,7 @@ util.inherits(ServiceClient, events.EventEmitter);\n ServiceClient.EnvironmentVariables = {\n AZURE_STORAGE_ACCOUNT: 'AZURE_STORAGE_ACCOUNT',\n AZURE_STORAGE_ACCESS_KEY: 'AZURE_STORAGE_ACCESS_KEY',\n+ AZURE_STORAGE_DNS_SUFFIX: 'AZURE_STORAGE_DNS_SUFFIX',","path":"lib/services/core/serviceclient.js","position":4,"original_position":4,"commit_id":"073bed7f50b55567dfa3c93c8c0b7656383dc709","original_commit_id":"073bed7f50b55567dfa3c93c8c0b7656383dc709","user":{"login":"andrerod","id":457481,"avatar_url":"https://secure.gravatar.com/avatar/3d0ac77bd3d221c17a66637e55e18a8e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"3d0ac77bd3d221c17a66637e55e18a8e","url":"https://api.github.com/users/andrerod","html_url":"https://github.com/andrerod","followers_url":"https://api.github.com/users/andrerod/followers","following_url":"https://api.github.com/users/andrerod/following","gists_url":"https://api.github.com/users/andrerod/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerod/subscriptions","organizations_url":"https://api.github.com/users/andrerod/orgs","repos_url":"https://api.github.com/users/andrerod/repos","events_url":"https://api.github.com/users/andrerod/events{/privacy}","received_events_url":"https://api.github.com/users/andrerod/received_events","type":"User"},"created_at":"2013-04-22T22:52:11Z","updated_at":"2013-04-22T22:52:11Z","html_url":"https://github.com/WindowsAzure/azure-sdk-for-node/pull/728#discussion_r3906634","pull_request_url":"https://api.github.com/repos/WindowsAzure/azure-sdk-for-node/pulls/728","_links":{"self":{"href":"https://api.github.com/repos/WindowsAzure/azure-sdk-for-node/pulls/comments/3906634"},"html":{"href":"https://github.com/WindowsAzure/azure-sdk-for-node/pull/728#discussion_r3906634"},"pull_request":{"href":"https://api.github.com/repos/WindowsAzure/azure-sdk-for-node/pulls/728"}}}}

{"repository":{"description":"Windows Azure SDK for Node.js","homepage":"http://www.windowsazure.com/en-us/develop/nodejs/","watchers":407,"stargazers":407,"forks":86,"fork":false,"size":832,"owner":"WindowsAzure","private":false,"open_issues":98,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2011-12-09T15:38:42-08:00","pushed_at":"2013-04-22T15:09:00-07:00","master_branch":"master","organization":"WindowsAzure"},"actor_attributes":{"type":"User","name":"André Rodrigues","company":"Microsoft","location":"Redmond","email":"[email protected]"},"url":"https://github.com/WindowsAzure/azure-sdk-for-node/pull/728#discussion_r3906634"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/WindowsAzure/azure-sdk-for-java-samples/pulls/comments/3088715","id":3088715,"body":"java // and /* */ for comment have their reason and user scenario. use // for few line comment and use /* for multiple line.\r\nmixed them in one project should be fine. use /* for all one line comment may not be convenient","path":"MediaServicesEncryptionSample/src/test/java/ext/microsoft/windowsazure/MediaServicesEncryptionSample.java","position":45,"original_position":45,"commit_id":"bd45d847b3ac01ae2c4b0fb2ba667f15047f7b6e","original_commit_id":"bd45d847b3ac01ae2c4b0fb2ba667f15047f7b6e","user":{"login":"xuezhai","id":1117852,"avatar_url":"https://secure.gravatar.com/avatar/cd912cd741a9c0fd906d1a4d714e1d0f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"cd912cd741a9c0fd906d1a4d714e1d0f","url":"https://api.github.com/users/xuezhai","html_url":"https://github.com/xuezhai","followers_url":"https://api.github.com/users/xuezhai/followers","following_url":"https://api.github.com/users/xuezhai/following","gists_url":"https://api.github.com/users/xuezhai/gists{/gist_id}","starred_url":"https://api.github.com/users/xuezhai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuezhai/subscriptions","organizations_url":"https://api.github.com/users/xuezhai/orgs","repos_url":"https://api.github.com/users/xuezhai/repos","events_url":"https://api.github.com/users/xuezhai/events{/privacy}","received_events_url":"https://api.github.com/users/xuezhai/received_events","type":"User"},"created_at":"2013-02-20T21:04:02Z","updated_at":"2013-02-20T21:04:02Z","_links":{"self":{"href":"https://api.github.com/repos/WindowsAzure/azure-sdk-for-java-samples/pulls/comments/3088715"},"html":{"href":"https://github.com/WindowsAzure/azure-sdk-for-java-samples/pull/4#discussion_r3088715"},"pull_request":{"href":"https://api.github.com/repos/WindowsAzure/azure-sdk-for-java-samples/pulls/4"}}}}

{"repository":{"description":"Code samples for articles on windowsazure.com","watchers":3,"stargazers":3,"forks":5,"fork":false,"size":3144,"owner":"WindowsAzure","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2012-07-09T09:54:54-07:00","pushed_at":"2013-02-20T11:43:00-08:00","master_branch":"master","organization":"WindowsAzure"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/WindowsAzure/azure-sdk-for-java-samples/pull/4#discussion_r3088715"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/comments/7203765","id":7203765,"diff_hunk":"@@ -0,0 +1,231 @@\n+---\n+name: Titanium.UI.iOS.CollisionBehavior\n+summary: Dynamic behavior to support collisions between items and boundaries.\n+description: |\n+ The following APIs are supported on iOS 7 and later.\n+\n+ A collision behavior specifies the behavior when items collide with each other and boundaries.\n+ To define a collision behavior:\n+\n+ 1. Use the <Titanium.UI.iOS.createCollisionBehavior> method to create and define the behavior.\n+ 2. Use the [addItem](Titanium.UI.iOS.CollisionBehavior.addItem) method to add items to the behavior.\n+ 3. Use the [addBoundary](Titanium.UI.iOS.CollisionBehavior.addBoundary) method to add custom\n+ boundaries for the item to collide with. By default, the behavior uses the Animator\n+ object's reference view as the boundary.\n+ 4. Add the behavior to an [Animator object](Titanium.UI.iOS.Animator).\n+ \n+extends: Titanium.Proxy\n+since: \"3.2\"\n+platforms: [iphone, ipad]\n+osver: {ios: {min: \"7.0\"}}\n+\n+properties:\n+ - name: boundaryIdentifiers\n+ summary: Boundary identfiers added to this behavior.\n+ type: Array<BoundaryIdentifier>\n+ permission: read-only\n+\n+ - name: collisionMode\n+ summary: Specifies the collision behavior.\n+ description: |\n+ Set to either:\n+\n+ * <Titanium.UI.iOS.COLLISION_MODE_ITEM> for collisions with items.\n+ * <Titanium.UI.iOS.COLLISION_MODE_BOUNDARY> for collisions with boundaries.\n+ * <Titanium.UI.iOS.COLLISION_MODE_ALL> for collisions with either boundaries or items.\n+\n+ type: Number\n+ default: <Titanium.UI.iOS.COLLISION_MODE_ALL>\n+\n+ - name: items\n+ summary: Items added to this behavior.\n+ type: Array<Titanium.UI.View>\n+ permission: read-only\n+\n+ - name: referenceInsets\n+ summary: Insets to apply when using the animator's reference view as the boundary.\n+ description: The `treatReferenceAsBoundary` needs to be set to `true` to use this property.\n+ type: ReferenceInsets\n+ default: All insets are zero.\n+\n+ - name: treatReferenceAsBoundary\n+ summary: Use the animator's reference view as the boundary.","path":"apidoc/Titanium/UI/iOS/CollisionBehavior.yml","position":52,"original_position":52,"commit_id":"dc9de131011b8735607365f04bc7511e285a6bb6","original_commit_id":"dc9de131011b8735607365f04bc7511e285a6bb6","user":{"login":"tstatler","id":408952,"avatar_url":"https://2.gravatar.com/avatar/26c291f8d6dd1e77925eecdc4d3589c4?d=https%3A%2F%2Fidenticons.github.com%2F0390cde51158466e7ef99c967521c859.png&r=x","gravatar_id":"26c291f8d6dd1e77925eecdc4d3589c4","url":"https://api.github.com/users/tstatler","html_url":"https://github.com/tstatler","followers_url":"https://api.github.com/users/tstatler/followers","following_url":"https://api.github.com/users/tstatler/following{/other_user}","gists_url":"https://api.github.com/users/tstatler/gists{/gist_id}","starred_url":"https://api.github.com/users/tstatler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tstatler/subscriptions","organizations_url":"https://api.github.com/users/tstatler/orgs","repos_url":"https://api.github.com/users/tstatler/repos","events_url":"https://api.github.com/users/tstatler/events{/privacy}","received_events_url":"https://api.github.com/users/tstatler/received_events","type":"User","site_admin":false},"body":"Link \"reference view\" text back to relevant section?","created_at":"2013-10-24T22:30:08Z","updated_at":"2013-10-24T22:30:08Z","html_url":"https://github.com/appcelerator/titanium_mobile/pull/4827#discussion_r7203765","pull_request_url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/4827","_links":{"self":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/comments/7203765"},"html":{"href":"https://github.com/appcelerator/titanium_mobile/pull/4827#discussion_r7203765"},"pull_request":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/4827"}}}}

{"repository":{"description":"Appcelerator Titanium Mobile","homepage":"http://www.appcelerator.com","watchers":1568,"stargazers":1568,"forks":739,"fork":false,"size":420322,"owner":"appcelerator","private":false,"open_issues":103,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Objective-C","created_at":"2009-06-15T15:54:37-07:00","pushed_at":"2013-10-24T12:04:51-07:00","integrate_branch":"master","master_branch":"master","organization":"appcelerator"},"actor_attributes":{"type":"User","name":"Tim Statler","company":"","location":"","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/appcelerator/titanium_mobile/pull/4827#discussion_r7203765"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/fedora-infra/python-fedora/pulls/comments/8537244","id":8537244,"diff_hunk":"@@ -5,7 +5,7 @@\n import warnings\n \n warnings.warn('fedora.tg.client has moved to fedora.client. This location'\n- ' will disappear in 0.4', DeprecationWarning, stacklevel=2)\n+ ' will disappear in 0.4', DeprecationWarning, stacklevel=2)\n \n # pylint: disable-msg=W0401,W0614\n from fedora.client import *","path":"fedora/tg/client.py","position":8,"original_position":8,"commit_id":"755da26427f9125a9b4b9c719fb1327130fae092","original_commit_id":"755da26427f9125a9b4b9c719fb1327130fae092","user":{"login":"abadger","id":209242,"avatar_url":"https://gravatar.com/avatar/7a9c1d88f484c9806bceca0d6d91e948?d=https%3A%2F%2Fidenticons.github.com%2Faa03b4fbd250c9a07e45662b66fe71c3.png&r=x","gravatar_id":"7a9c1d88f484c9806bceca0d6d91e948","url":"https://api.github.com/users/abadger","html_url":"https://github.com/abadger","followers_url":"https://api.github.com/users/abadger/followers","following_url":"https://api.github.com/users/abadger/following{/other_user}","gists_url":"https://api.github.com/users/abadger/gists{/gist_id}","starred_url":"https://api.github.com/users/abadger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abadger/subscriptions","organizations_url":"https://api.github.com/users/abadger/orgs","repos_url":"https://api.github.com/users/abadger/repos","events_url":"https://api.github.com/users/abadger/events{/privacy}","received_events_url":"https://api.github.com/users/abadger/received_events","type":"User","site_admin":false},"body":"Changes to this file ok'd","created_at":"2013-12-24T00:21:16Z","updated_at":"2013-12-24T00:21:16Z","html_url":"https://github.com/fedora-infra/python-fedora/pull/71#discussion_r8537244","pull_request_url":"https://api.github.com/repos/fedora-infra/python-fedora/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/fedora-infra/python-fedora/pulls/comments/8537244"},"html":{"href":"https://github.com/fedora-infra/python-fedora/pull/71#discussion_r8537244"},"pull_request":{"href":"https://api.github.com/repos/fedora-infra/python-fedora/pulls/71"}}}}

{"repository":{"description":"A Python library for interacting with, and connecting to, Fedora services.","homepage":"","watchers":8,"stargazers":8,"forks":7,"fork":false,"size":4131,"owner":"fedora-infra","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2013-01-19T12:48:42-08:00","pushed_at":"2013-12-22T19:59:58-08:00","master_branch":"develop","organization":"fedora-infra"},"actor_attributes":{"type":"User","name":"Toshio Kuratomi","company":"Red Hat","blog":"http://anonbadger.wordpress.com/","location":"Granite Bay, CA","email":"[email protected]"},"url":"https://github.com/fedora-infra/python-fedora/pull/71#discussion_r8537244"}

PullRequestReviewCommentEvent

{"comment":{"original_position":120,"user":{"repos_url":"https://api.github.com/users/abadger/repos","received_events_url":"https://api.github.com/users/abadger/received_events","subscriptions_url":"https://api.github.com/users/abadger/subscriptions","following_url":"https://api.github.com/users/abadger/following","type":"User","avatar_url":"https://secure.gravatar.com/avatar/7a9c1d88f484c9806bceca0d6d91e948?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","id":209242,"login":"abadger","organizations_url":"https://api.github.com/users/abadger/orgs","gists_url":"https://api.github.com/users/abadger/gists{/gist_id}","gravatar_id":"7a9c1d88f484c9806bceca0d6d91e948","followers_url":"https://api.github.com/users/abadger/followers","starred_url":"https://api.github.com/users/abadger/starred{/owner}{/repo}","events_url":"https://api.github.com/users/abadger/events{/privacy}","url":"https://api.github.com/users/abadger"},"path":"fedmsg_meta_fedora_infrastructure/askbot.py","position":120,"_links":{"self":{"href":"https://api.github.com/repos/fedora-infra/fedmsg_meta_fedora_infrastructure/pulls/comments/2879647"},"html":{"href":"https://github.com/fedora-infra/fedmsg_meta_fedora_infrastructure/pull/1#discussion_r2879647"},"pull_request":{"href":"https://api.github.com/repos/fedora-infra/fedmsg_meta_fedora_infrastructure/pulls/1"}},"created_at":"2013-02-04T17:34:30Z","id":2879647,"updated_at":"2013-02-04T17:34:30Z","original_commit_id":"1e722d1cb4fc9e16503ad4789a7334872a1c8fc5","body":"Just wondering -- you want to add the tags for the thread only if there are no tags on the msg?","commit_id":"1e722d1cb4fc9e16503ad4789a7334872a1c8fc5","url":"https://api.github.com/repos/fedora-infra/fedmsg_meta_fedora_infrastructure/pulls/comments/2879647"}}

{"repository":{"forks":1,"owner":"fedora-infra","has_wiki":false,"open_issues":1,"watchers":1,"created_at":"2012-11-27T06:33:35-08:00","fork":false,"size":268,"description":"fedmsg metadata providers for Fedora Infrastructure's deployment","stargazers":1,"has_issues":true,"has_downloads":true,"master_branch":"develop","organization":"fedora-infra","private":false,"language":"Python","pushed_at":"2013-02-04T06:47:40-08:00"},"actor_attributes":{"type":"User","email":"[email protected]","name":"Toshio Kuratomi","blog":"http://anonbadger.wordpress.com/","location":"Granite Bay, CA","company":"Red Hat"},"url":"https://github.com/fedora-infra/fedmsg_meta_fedora_infrastructure/pull/1#discussion_r2879647"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/griddynamics/jagger/pulls/comments/4337211","id":4337211,"body":"i suggest a hashmap, which is configurable from spring","diff_hunk":"@@ -104,30 +109,38 @@ public JRDataSource getDataSource() {\n plotDTO.setLatencyPlot(new JCommonDrawableRenderer(chartLatency));\n \n throughputPlots.put(scenarioName, plotDTO);\n+\n+ resultData.clear();\n }\n }\n return throughputPlots.values();\n }\n \n- private XYDataset getThroughputData(String scenarioName) {\n- List<WorkloadTaskData> all = getResultData(scenarioName);\n+ private String getClockForPlot(List<WorkloadTaskData> resultData) {\n+ String clock = resultData.iterator().next().getClock();\n+ for (ClockTranslatorForPlots cc : ClockTranslatorForPlots.values()) {","path":"chassis/core/src/main/java/com/griddynamics/jagger/engine/e1/reporting/WorkloadScalabilityPlotsReporter.java","position":42,"original_position":42,"commit_id":"061b674f11d2d4d26a790aa31eb2e83af725e4ad","original_commit_id":"061b674f11d2d4d26a790aa31eb2e83af725e4ad","user":{"login":"nmusienko","id":2776742,"avatar_url":"https://secure.gravatar.com/avatar/5c679a91402672e7de556db5f02fb829?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"5c679a91402672e7de556db5f02fb829","url":"https://api.github.com/users/nmusienko","html_url":"https://github.com/nmusienko","followers_url":"https://api.github.com/users/nmusienko/followers","following_url":"https://api.github.com/users/nmusienko/following{/other_user}","gists_url":"https://api.github.com/users/nmusienko/gists{/gist_id}","starred_url":"https://api.github.com/users/nmusienko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmusienko/subscriptions","organizations_url":"https://api.github.com/users/nmusienko/orgs","repos_url":"https://api.github.com/users/nmusienko/repos","events_url":"https://api.github.com/users/nmusienko/events{/privacy}","received_events_url":"https://api.github.com/users/nmusienko/received_events","type":"User"},"created_at":"2013-05-22T12:40:52Z","updated_at":"2013-05-22T12:40:52Z","html_url":"https://github.com/griddynamics/jagger/pull/157#discussion_r4337211","pull_request_url":"https://api.github.com/repos/griddynamics/jagger/pulls/157","_links":{"self":{"href":"https://api.github.com/repos/griddynamics/jagger/pulls/comments/4337211"},"html":{"href":"https://github.com/griddynamics/jagger/pull/157#discussion_r4337211"},"pull_request":{"href":"https://api.github.com/repos/griddynamics/jagger/pulls/157"}}}}

{"repository":{"description":"Jagger","homepage":"https://jagger.griddynamics.net","watchers":24,"stargazers":24,"forks":16,"fork":false,"size":111403,"owner":"griddynamics","private":false,"open_issues":9,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2012-02-13T06:47:01-08:00","pushed_at":"2013-05-22T04:28:44-07:00","master_branch":"master","organization":"griddynamics"},"actor_attributes":{"type":"User","name":"Nikolay Musienko","email":"[email protected]"},"url":"https://github.com/griddynamics/jagger/pull/157#discussion_r4337211"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/griddynamics/OpenGenesis/pulls/comments/3451141","id":3451141,"body":"Unfortunately it's not. The same selector is specified in jquery css.","diff_hunk":"@@ -1896,6 +1896,13 @@ table.settings td.restart-required {\n line-height: 1.5em;\n }\n \n+/* Fix jquery-ui datepicker 'Now' button to not look 'grayed' */\n+.ui-datepicker .ui-datepicker-buttonpane button.ui-datepicker-current {","path":"ui/src/main/resources/genesis/assets/css/style.css","position":5,"original_position":5,"commit_id":"83fdd31430635a4b0cf664e57e170db465bd0424","original_commit_id":"83fdd31430635a4b0cf664e57e170db465bd0424","user":{"login":"ddurnev","id":937537,"avatar_url":"https://secure.gravatar.com/avatar/f5e6a9db8363e0adae31ef7462b69f7b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"f5e6a9db8363e0adae31ef7462b69f7b","url":"https://api.github.com/users/ddurnev","html_url":"https://github.com/ddurnev","followers_url":"https://api.github.com/users/ddurnev/followers","following_url":"https://api.github.com/users/ddurnev/following","gists_url":"https://api.github.com/users/ddurnev/gists{/gist_id}","starred_url":"https://api.github.com/users/ddurnev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddurnev/subscriptions","organizations_url":"https://api.github.com/users/ddurnev/orgs","repos_url":"https://api.github.com/users/ddurnev/repos","events_url":"https://api.github.com/users/ddurnev/events{/privacy}","received_events_url":"https://api.github.com/users/ddurnev/received_events","type":"User"},"created_at":"2013-03-20T14:22:25Z","updated_at":"2013-03-20T14:22:25Z","html_url":"https://github.com/griddynamics/OpenGenesis/pull/891#discussion_r3451141","pull_request_url":"https://api.github.com/repos/griddynamics/OpenGenesis/pulls/891","_links":{"self":{"href":"https://api.github.com/repos/griddynamics/OpenGenesis/pulls/comments/3451141"},"html":{"href":"https://github.com/griddynamics/OpenGenesis/pull/891#discussion_r3451141"},"pull_request":{"href":"https://api.github.com/repos/griddynamics/OpenGenesis/pulls/891"}}}}

{"repository":{"description":"","homepage":"","watchers":11,"stargazers":11,"forks":7,"fork":false,"size":1156,"owner":"griddynamics","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Scala","created_at":"2012-03-20T01:38:18-07:00","pushed_at":"2013-03-20T04:36:38-07:00","master_branch":"master","organization":"griddynamics"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/griddynamics/OpenGenesis/pull/891#discussion_r3451141"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/groupbuddies/bookinc/pulls/comments/7503671","id":7503671,"diff_hunk":"@@ -0,0 +1,34 @@\n+require_relative 'book_states'\n+\n+module BookLoan\n+ def self.included(base)\n+ if defined?(ActiveRecord::Base) && base.ancestors.include?(ActiveRecord::Base)\n+ BookStates.all.each do |state_name|\n+ base.send(:scope, state_name.to_sym, -> { base.where(state: state_name) })","path":"app/models/book_loan.rb","position":7,"original_position":7,"commit_id":"c8d417e55c37067147c280de71fc210461d06db5","original_commit_id":"c8d417e55c37067147c280de71fc210461d06db5","user":{"login":"gabrielpoca","id":934580,"avatar_url":"https://0.gravatar.com/avatar/2c4b850cf6a0a3be7a18c7840bc12435?d=https%3A%2F%2Fidenticons.github.com%2F60ce6b48d6403e954407a7009c12e9f2.png&r=x","gravatar_id":"2c4b850cf6a0a3be7a18c7840bc12435","url":"https://api.github.com/users/gabrielpoca","html_url":"https://github.com/gabrielpoca","followers_url":"https://api.github.com/users/gabrielpoca/followers","following_url":"https://api.github.com/users/gabrielpoca/following{/other_user}","gists_url":"https://api.github.com/users/gabrielpoca/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielpoca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielpoca/subscriptions","organizations_url":"https://api.github.com/users/gabrielpoca/orgs","repos_url":"https://api.github.com/users/gabrielpoca/repos","events_url":"https://api.github.com/users/gabrielpoca/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielpoca/received_events","type":"User","site_admin":false},"body":"tanto faz, é o sideshow que está a iniciar isto, se ambos são aceitaveis ele escolhe xD","created_at":"2013-11-07T17:50:44Z","updated_at":"2013-11-07T17:50:44Z","html_url":"https://github.com/groupbuddies/bookinc/pull/2#discussion_r7503671","pull_request_url":"https://api.github.com/repos/groupbuddies/bookinc/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/groupbuddies/bookinc/pulls/comments/7503671"},"html":{"href":"https://github.com/groupbuddies/bookinc/pull/2#discussion_r7503671"},"pull_request":{"href":"https://api.github.com/repos/groupbuddies/bookinc/pulls/2"}}}}

{"repository":{"description":"Companies book shelf management","homepage":"","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":452,"owner":"groupbuddies","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"created_at":"2013-10-11T04:26:04-07:00","pushed_at":"2013-11-07T07:28:16-08:00","master_branch":"master","organization":"groupbuddies"},"actor_attributes":{"type":"User","name":"Gabriel Poça","blog":"gabrielpoca.com","location":"Braga","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/groupbuddies/bookinc/pull/2#discussion_r7503671"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/4614497","id":4614497,"body":"There could be if called on two threads, and both fail to match in cache, then both add.\r\n\r\nIt may of course never happen","diff_hunk":"@@ -6195,31 +6210,33 @@ class CNamedGroupStore: public CInterface, implements INamedGroupStore\n SocketEndpoint ep(pe2->query().queryProp(\"@ip\"));\n epa.append(ep);\n }\n+ ret.setown(createIGroup(epa));\n+ {\n+ CriticalBlock block(cachesect);\n+ cache.append(*new CNamedGroupCacheEntry(ret, gname, groupdir));","path":"dali/base/dadfs.cpp","position":127,"original_position":126,"commit_id":"ebb55e017549b227908e19f9b467fd32dabbe55e","original_commit_id":"27d299622e5ad19c7ca89f3047f6a70260ab46ca","user":{"login":"ghalliday","id":902490,"avatar_url":"https://secure.gravatar.com/avatar/402dddc31c0e131326457e9ffd436352?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"402dddc31c0e131326457e9ffd436352","url":"https://api.github.com/users/ghalliday","html_url":"https://github.com/ghalliday","followers_url":"https://api.github.com/users/ghalliday/followers","following_url":"https://api.github.com/users/ghalliday/following{/other_user}","gists_url":"https://api.github.com/users/ghalliday/gists{/gist_id}","starred_url":"https://api.github.com/users/ghalliday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghalliday/subscriptions","organizations_url":"https://api.github.com/users/ghalliday/orgs","repos_url":"https://api.github.com/users/ghalliday/repos","events_url":"https://api.github.com/users/ghalliday/events{/privacy}","received_events_url":"https://api.github.com/users/ghalliday/received_events","type":"User"},"created_at":"2013-06-10T15:45:57Z","updated_at":"2013-06-10T15:45:57Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/4479#discussion_r4614497","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/4479","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/4614497"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/4479#discussion_r4614497"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/4479"}}}}

{"repository":{"description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","homepage":"track.hpccsystems.com","watchers":210,"stargazers":210,"forks":61,"fork":false,"size":46592,"owner":"hpcc-systems","private":false,"open_issues":420,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2011-07-11T07:29:51-07:00","pushed_at":"2013-06-07T03:23:14-07:00","master_branch":"master","organization":"hpcc-systems"},"actor_attributes":{"type":"User","name":"Gavin Halliday","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/hpcc-systems/HPCC-Platform/pull/4479#discussion_r4614497"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/5472783","id":5472783,"body":">This will call releaseRoxieRow on all the NULL rows - better to avoid.\r\n\r\nThere will be no NULL rows in inRows, clearRows() will only clear up to the # rows added..\r\n\r\n>Should appendRows() be a member of CThorExpandingRowArray?\r\n\r\nmaybe","diff_hunk":"@@ -1542,6 +1540,194 @@ ISharedSmartBuffer *createSharedSmartMemBuffer(CActivityBase *activity, unsigned\n return new CSharedWriteAheadMem(activity, outputs, rowIf, buffSize);\n }\n \n+\n+class CRowMultiWriterReader : public CSimpleInterface, implements IRowMultiWriterReader\n+{\n+ rowidx_t granularity, writerGranularity, rowPos, limit, rowsToRead;\n+ CThorSpillableRowArray rows;\n+ const void **readRows;\n+ CActivityBase &activity;\n+ IRowInterfaces *rowIf;\n+ bool readerBlocked, eos, eow;\n+ Semaphore emptySem, fullSem;\n+ unsigned numWriters, writersComplete, writersBlocked;\n+\n+ class CAWriter : public CSimpleInterface, implements IRowWriter\n+ {\n+ CRowMultiWriterReader &owner;\n+ CThorExpandingRowArray rows;\n+ public:\n+ IMPLEMENT_IINTERFACE_USING(CSimpleInterface);\n+\n+ CAWriter(CRowMultiWriterReader &_owner) : owner(_owner), rows(_owner.activity, _owner.rowIf)\n+ {\n+ }\n+ ~CAWriter()\n+ {\n+ flush();\n+ owner.writerStopped();\n+ }\n+ // IRowWriter impl.\n+ virtual void putRow(const void *row)\n+ {\n+ if (rows.ordinality() >= owner.writerGranularity)\n+ owner.addRows(rows);\n+ rows.append(row);\n+ }\n+ virtual void flush()\n+ {\n+ if (rows.ordinality())\n+ owner.addRows(rows);\n+ }\n+ };\n+\n+ void addRows(CThorExpandingRowArray &inRows)\n+ {\n+ loop\n+ {\n+ {\n+ CThorArrayLockBlock block(rows);\n+ if (rows.numCommitted() < limit)\n+ {\n+ // NB: allowed to go over limit, by as much as inRows.ordinality()-1\n+ rowidx_t num = inRows.ordinality();\n+ for (rowidx_t r=0; r<num; r++)\n+ rows.append(inRows.getClear(r));\n+ inRows.clearRows();","path":"thorlcr/thorutil/thbuf.cpp","position":66,"original_position":66,"commit_id":"f8002cd2e6e6cef997f2feced128282c9f91fe00","original_commit_id":"f8002cd2e6e6cef997f2feced128282c9f91fe00","user":{"login":"jakesmith","id":902700,"avatar_url":"https://secure.gravatar.com/avatar/8eff4f840b1605e58ce34b0c3b5eea5a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"8eff4f840b1605e58ce34b0c3b5eea5a","url":"https://api.github.com/users/jakesmith","html_url":"https://github.com/jakesmith","followers_url":"https://api.github.com/users/jakesmith/followers","following_url":"https://api.github.com/users/jakesmith/following{/other_user}","gists_url":"https://api.github.com/users/jakesmith/gists{/gist_id}","starred_url":"https://api.github.com/users/jakesmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakesmith/subscriptions","organizations_url":"https://api.github.com/users/jakesmith/orgs","repos_url":"https://api.github.com/users/jakesmith/repos","events_url":"https://api.github.com/users/jakesmith/events{/privacy}","received_events_url":"https://api.github.com/users/jakesmith/received_events","type":"User"},"created_at":"2013-07-30T10:20:25Z","updated_at":"2013-07-30T10:20:25Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/4692#discussion_r5472783","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/4692","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/5472783"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/4692#discussion_r5472783"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/4692"}}}}

{"repository":{"description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","homepage":"track.hpccsystems.com","watchers":210,"stargazers":210,"forks":64,"fork":false,"size":134295,"owner":"hpcc-systems","private":false,"open_issues":0,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2011-07-11T07:29:51-07:00","pushed_at":"2013-07-30T03:16:38-07:00","master_branch":"master","organization":"hpcc-systems"},"actor_attributes":{"type":"User","name":"Jake Smith","company":"LexisNexis","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/hpcc-systems/HPCC-Platform/pull/4692#discussion_r5472783"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/openstack-ja/openstack-manuals/pulls/comments/5087162","id":5087162,"body":"> Puppet モジュールと Chef レシピをまとめるよい単語はないでしょうか？\r\nいろいろと考えてみたのですが、私ではいい言葉が思いつきませんでした。\r\n元木さんの案で意味的に理解できると思いますので、そのまま柄わせて使わせていただきました。","diff_hunk":"@@ -0,0 +1,1534 @@\n+#\n+# Translators:\n+# Akihiro MOTOKI <[email protected]>, 2013\n+# Akira Yoshiyama <[email protected]>, 2013\n+# thatsdone <[email protected]>, 2013\n+# thatsdone <[email protected]>, 2013\n+# masayukig <[email protected]>, 2013\n+# *はたらくpokotan* <>, 2013\n+# Tsutomu Takekawa <[email protected]>, 2013\n+# doki701 <[email protected]>, 2013\n+# Tomoyuki KATO <[email protected]>, 2012-2013\n+# tmak <[email protected]>, 2013\n+# daisy.ycguo <[email protected]>, 2013\n+# Shirayuki/しらゆき Shira <[email protected]>, 2013\n+msgid \"\"\n+msgstr \"\"\n+\"Project-Id-Version: OpenStack Manuals\\n\"\n+\"POT-Creation-Date: 2013-05-08 15:45+0800\\n\"\n+\"PO-Revision-Date: 2013-06-21 08:33+0000\\n\"\n+\"Last-Translator: Tsutomu Takekawa <[email protected]>\\n\"\n+\"Language-Team: Japanese (http://www.transifex.com/projects/p/openstack/\"\n+\"language/ja/)\\n\"\n+\"MIME-Version: 1.0\\n\"\n+\"Content-Type: text/plain; charset=UTF-8\\n\"\n+\"Content-Transfer-Encoding: 8bit\\n\"\n+\"Language: ja\\n\"\n+\"Plural-Forms: nplurals=1; plural=0;\\n\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_arch_scaling.xml:51\n+#: doc/src/docbkx/openstack-ops/src/ch_arch_scaling.xml:58\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:522\n+msgid \"1\"\n+msgstr \"1\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_arch_scaling.xml:65\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:529\n+msgid \"2\"\n+msgstr \"2\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_arch_scaling.xml:72\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:543\n+msgid \"4\"\n+msgstr \"4\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:17\n+msgid \"Maintenance, Failures, and Debugging\"\n+msgstr \"メンテナンス、故障およびデバッグ\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:18\n+msgid \"\"\n+\"Downtime, whether planned or unscheduled, is a certainty when running a \"\n+\"cloud. This chapter aims to provide useful information for dealing \"\n+\"proactively, or reactively with these occurrences.\"\n+msgstr \"\"\n+\"停止時間（計画的なものと予定外のものの両方）はクラウドを運用するときに確実\"\n+\"に発生します。本章は、プロアクティブまたはリアクティブに、これらの出来事に対処\"\n+\"するために有用な情報を提供することを目的としています。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:24\n+msgid \"Cloud Controller and Storage Proxy Failures and Maintenance\"\n+msgstr \"クラウドコントローラーとストレージプロキシの故障とメンテナンス\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:26\n+msgid \"\"\n+\"The cloud controller and storage proxy are very similar to each other when \"\n+\"it comes to expected and unexpected downtime. One of each server type \"\n+\"typically runs in the cloud, which makes them very noticeable when they are \"\n+\"not running.\"\n+msgstr \"\"\n+\"想定内の場合も想定外の場合も停止時間が発生した場合の挙動が、\"\n+\"クラウドコントローラーとストレージプロキシは互いに似ています。\"\n+\"クラウドコントローラーとストレージプロキシはそれぞれクラウドで一つ実行されるので、\"\n+\"動作していない場合、非常に目立ちます。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:31\n+msgid \"\"\n+\"For the cloud controller, the good news is if your cloud is using the \"\n+\"FlatDHCP multi-host HA network mode, existing instances and volumes continue \"\n+\"to operate while the cloud controller is offline. However for the storage \"\n+\"proxy, no storage traffic is possible until it is back up and running.\"\n+msgstr \"\"\n+\"クラウドコントローラーの場合、良いニュースとしては、クラウドが FlatDHCP マルチホスト HA ネットワークモードを使用していれば、既存\"\n+\"のインスタンスとボリュームはクラウドコントローラーがオフラインの間も動作を継\"\n+\"続するという点があります。しかしながら、\"\n+\"ストレージプロキシの場合には、サーバーが元に戻され動作状態になるまで、ストレージとの通\"\n+\"信ができません。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:39\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:115\n+msgid \"Planned Maintenance\"\n+msgstr \"計画メンテナンス\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:40\n+msgid \"\"\n+\"One way to plan for cloud controller or storage proxy maintenance is to \"\n+\"simply do it off-hours, such as at 1 or 2 A.M.. This strategy impacts fewer \"\n+\"users. If your cloud controller or storage proxy is too important to have \"\n+\"unavailable at any point in time, you must look into High Availability \"\n+\"options.\"\n+msgstr \"\"\n+\"クラウドコントローラーやストレージプロキシのメンテナンスを計画する一つの方法\"\n+\"は、単に午前 1 時や 2 時のような利用の少ない時間帯に実行することです。この戦略はあまり多\"\n+\"くのユーザーに影響を与えません。クラウドコントローラーやストレージプロキシが、\"\n+\"いかなる時間帯においても、サービスが利用できないことによる影響が大きければ、高可用性オプション\"\n+\"について検討する必要があります。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:49\n+msgid \"Rebooting a cloud controller or Storage Proxy\"\n+msgstr \"クラウドコントローラーとストレージプロキシの再起動\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:51\n+msgid \"\"\n+\"All in all, just issue the \\\"reboot\\\" command. The operating system cleanly \"\n+\"shuts services down and then automatically reboots. If you want to be very \"\n+\"thorough, run your backup jobs just before you reboot.\"\n+msgstr \"\"\n+\"多くの場合、\\\"reboot\\\" コマンドを発行するだけです。オペレーティングシステム\"\n+\"が正常にサービスをシャットダウンし、自動的に再起動します。万全を期した\"\n+\"い場合、再起動する前にバックアップジョブを実行してください。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:59\n+msgid \"After a Cloud Controller or Storage Proxy Reboots\"\n+msgstr \"クラウドコントローラーまたはストレージプロキシの再起動後\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:61\n+msgid \"\"\n+\"After a cloud controller reboots, ensure that all required services were \"\n+\"successfully started:\"\n+msgstr \"\"\n+\"クラウドコントローラーを再起動した後、すべての必要なサービスが正常に起動した\"\n+\"ことを確認します:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:68\n+msgid \"Also check that all services are functioning:\"\n+msgstr \"また、すべてのサービスが正しく機能していることを確認します:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:73\n+msgid \"\"\n+\"For the storage proxy, ensure that the Object Storage service has resumed:\"\n+msgstr \"\"\n+\"ストレージプロキシの場合、Object Storage サービスが再開していること\"\n+\"を確認します:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:76\n+msgid \"Also check that it is functioning:\"\n+msgstr \"また、正しく機能していることを確認します:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:81\n+msgid \"Total Cloud Controller Failure\"\n+msgstr \"全体的なクラウドコントローラーの故障\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:82\n+msgid \"\"\n+\"Unfortunately, this is a rough situation. The cloud controller is a integral \"\n+\"part of your cloud. If you have only one controller, many services are \"\n+\"missing.\"\n+msgstr \"\"\n+\"残念ながら、これは大まかな状況です。クラウドコントローラーはクラウドの不可欠\"\n+\"な部分です。コントローラーが一つだけならば、多くのサービスが失われます。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:86\n+msgid \"\"\n+\"To avoid this situation, create a highly available cloud controller cluster. \"\n+\"This is outside the scope of this document, but you can read more in the \"\n+\"draft <link title=\\\"OpenStack High Availability Guide\\\" href=\\\"http://docs.\"\n+\"openstack.org/trunk/openstack-ha/content/ch-intro.html\\\">OpenStack High \"\n+\"Availability Guide</link> (http://docs.openstack.org/trunk/openstack-ha/\"\n+\"content/ch-intro.html).\"\n+msgstr \"\"\n+\"この状況を避けるために、高可用なクラウドコントローラークラスターを作成しま\"\n+\"す。このことは、このドキュメントの範囲外ですが、ドラフト版の <link title=\\\"OpenStack \"\n+\"High Availability Guide\\\" href=\\\"http://docs.openstack.org/trunk/openstack-\"\n+\"ha/content/ch-intro.html\\\">OpenStack High Availability Guide</link> が http://\"\n+\"docs.openstack.org/trunk/openstack-ha/content/ch-intro.html にあり\"\n+\"ます。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:94\n+msgid \"\"\n+\"The next best way is to use a configuration management tool such as Puppet \"\n+\"to automatically build a cloud controller. This should not take more than 15 \"\n+\"minutes if you have a spare server available. After the controller rebuilds, \"\n+\"restore any backups taken (see the <emphasis role=\\\"bold\\\">Backup and \"\n+\"Recovery</emphasis> chapter).\"\n+msgstr \"\"\n+\"次に最も優れている方法は、クラウドコントローラーを自動的に構築するために \"\n+\"Puppet のような構成管理ツールを使用することです。利用可能な予備サーバーがあれ\"\n+\"ば、15 分もかかりません。コントローラーを再構築後、取得したすべてのバックアップ\"\n+\"を復元します (<emphasis role=\\\"bold\\\">バックアップとリカバリー</emphasis> \"\n+\"の章を参照してください)。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:101\n+msgid \"\"\n+\"Also, in practice, sometimes the nova-compute services on the compute nodes \"\n+\"do not reconnect cleanly to rabbitmq hosted on the controller when it comes \"\n+\"back up after a long reboot and a restart on the nova services on the \"\n+\"compute nodes is required.\"\n+msgstr \"\"\n+\"実際には、コンピュートノードの nova-compute サービスがときどき、コントロー\"\n+\"ラー上で動作している rabbitmq に正しく再接続されない場合があります。\"\n+\"時間のかかるリブートから戻ってきた場合や、コンピュートノードの\"\n+\"nova サービスを再起動する必要がある場合です。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:110\n+msgid \"Compute Node Failures and Maintenance\"\n+msgstr \"コンピュートノードの故障とメンテナンス\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:111\n+msgid \"\"\n+\"Sometimes a compute node either crashes unexpectedly or requires a reboot \"\n+\"for maintenance reasons.\"\n+msgstr \"\"\n+\"コンピュートノードは、予期せずクラッシュしたり、メンテナンスの\"\n+\"ために再起動が必要になったりすることがときどきあります。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:116\n+msgid \"\"\n+\"If you need to reboot a compute node due to planned maintenance (such as a \"\n+\"software or hardware upgrade), first ensure that all hosted instances have \"\n+\"been moved off of the node. If your cloud is utilizing shared storage, use \"\n+\"the <code>nova live-migration</code> command. First, get a list of instances \"\n+\"that need to be moved:\"\n+msgstr \"\"\n+\"(ソフトウェアやハードウェアのアップグレードのように) 計画されたメンテナンスの\"\n+\"ために、コンピュートノードを再起動する必要があれば、まずホストしている全インスタ\"\n+\"ンスがノード外に移動していることを確認します。クラウドが共有ストレージを利用\"\n+\"していれば、<code>nova live-migration</code> コマンドを使用します。初めに、\"\n+\"移動させる必要があるインスタンスの一覧を取得します:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:124\n+msgid \"Next, migrate them one by one:\"\n+msgstr \"次に、それらを一つずつマイグレーションします\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:126\n+msgid \"\"\n+\"If you are not using shared storage, you can use the <code>--block-migrate</\"\n+\"code> option:\"\n+msgstr \"\"\n+\"共有ストレージを使用していない場合、<code>--block-migrate</code> オプションを\"\n+\"使用できます:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:129\n+msgid \"\"\n+\"After you have migrated all instances, ensure the <code>nova-compute</code> \"\n+\"service has stopped:\"\n+msgstr \"\"\n+\"すべてのインスタンスをマイグレーションした後、<code>nova-compute</code> サー\"\n+\"ビスが停止していることを確認します:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:133\n+msgid \"\"\n+\"If you use a configuration management system, such as Puppet, that ensures \"\n+\"the <code>nova-compute</code> service is always running, you can temporarily \"\n+\"move the init files:\"\n+msgstr \"\"\n+\"Puppet などの構成管理システムを使って、<code>nova-compute</code> サービスが確実に実行されているようにしている場合\"\n+\"、init ファイルを一時的に移動します。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:140\n+msgid \"\"\n+\"Next, shut your compute node down, perform your maintenance, and turn the \"\n+\"node back on. You can re-enable the <code>nova-compute</code> service by \"\n+\"undoing the previous commands:\"\n+msgstr \"\"\n+\"続けて、コンピュートノードを停止し、メンテナンスを実行し、ノードを元に戻します。\"\n+\"先のコマンドを逆に実行することにより、<code>nova-compute</code> サービスを再\"\n+\"び有効化できます:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:146\n+msgid \"Then start the <code>nova-compute</code> service:\"\n+msgstr \"そして <code>nova-compute</code> サービスを起動します:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:149\n+msgid \"\"\n+\"You can now optionally migrate the instances back to their original compute \"\n+\"node.\"\n+msgstr \"\"\n+\"インスタンスを元のコンピュートノードにマイグレーションすること\"\n+\"もできます。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:154\n+msgid \"After a Compute Node Reboots\"\n+msgstr \"Compute ノードの再起動後\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:155\n+msgid \"\"\n+\"When you reboot a compute node, first verify that it booted successfully. \"\n+\"This includes ensuring the <code>nova-compute</code> service is running:\"\n+msgstr \"\"\n+\"コンピュートノードを再起動した場合、まず正常に起動したことを確認します。これには \"\n+\"<code>nova-compute</code> サービスが実行していることを確認することが含まれま\"\n+\"す:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:161\n+msgid \"Also ensure that it has successfully connected to the AMQP server:\"\n+msgstr \"AMQP サーバーに正常に接続できることも確認します:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:165\n+msgid \"\"\n+\"After the compute node is successfully running, you must deal with the \"\n+\"instances that are hosted on that compute node as none of them is running. \"\n+\"Depending on your SLA with your users or customers, you might have to start \"\n+\"each instance and ensure they start correctly.\"\n+msgstr \"\"\n+\"コンピュートノードが正常に実行された後、そのコンピュートノードでホストされているインスタンスはどれも動作していないので、その\"\n+\"コンピュートノードにおいてホストされているインスタンスを処理する必要があります。\"\n+\"ユーザーや顧客に対する SLA によっては、各インスタンスを開始し、正常に起動して\"\n+\"いることを確認する必要がある場合もあるでしょう。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:174\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_user_facing.xml:485\n+msgid \"Instances\"\n+msgstr \"インスタンス\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:175\n+msgid \"\"\n+\"You can create a list of instances that are hosted on the compute node by \"\n+\"performing the following command:\"\n+msgstr \"\"\n+\"以下のコマンドを実行することにより、コンピュートノードにおいてホストされているイ\"\n+\"ンスタンスの一覧を作成できます:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:179\n+msgid \"\"\n+\"After you have the list, you can use the nova command to start each instance:\"\n+msgstr \"\"\n+\"一覧を取得した後、各インスタンスを起動するために nova コマンドを使用できます:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:183\n+msgid \"\"\n+\"Any time an instance shuts down unexpectedly, it might have problems on \"\n+\"boot. For example, the instance might require an <code>fsck</code> on the \"\n+\"root partition. If this happens, the user can use the Dashboard VNC console \"\n+\"to fix this.\"\n+msgstr \"\"\n+\"予期せずシャットダウンしたときは、ブートに問題があるかもしれません。たと\"\n+\"えば、インスタンスがルートパーティションにおいて <code>fsck</code> を実行する\"\n+\"必要があるかもしれません。もしこうなっても、これを修復するためにダッシュボー\"\n+\"ド VNC コンソールを使用できます。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:189\n+msgid \"\"\n+\"If an instance does not boot, meaning <code>virsh list</code> never shows \"\n+\"the instance as even attempting to boot, do the following on the compute \"\n+\"node:\"\n+msgstr \"\"\n+\"インスタンスがブートしなければ、つまりブートしようとしても <code>virsh list</\"\n+\"code> がインスタンスを表示しなければ、コンピュートノードにおいて以下のとおり実行\"\n+\"します:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:194\n+msgid \"\"\n+\"Try executing the <code>nova reboot</code> command again. You should see an \"\n+\"error message about why the instance was not able to boot\"\n+msgstr \"\"\n+\"再び <code>nova reboot</code> コマンドを実行してみてください。インスタンスが\"\n+\"なぜブートできないかについて、エラーメッセージを確認すべきです。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:197\n+msgid \"\"\n+\"In most cases, the error is due to something in libvirt's XML file (<code>/\"\n+\"etc/libvirt/qemu/instance-xxxxxxxx.xml</code>) that no longer exists. You \"\n+\"can enforce recreation of the XML file as well as rebooting the instance by \"\n+\"running:\"\n+msgstr \"\"\n+\"多くの場合、libvirt の XML ファイル (<code>/etc/\"\n+\"libvirt/qemu/instance-xxxxxxxx.xml</code>) の何かがすでに存在しないことで、エラーが発生する。次のとおり実\"\n+\"行することにより、インスタンスを再起動するのと同時に、強制的に XML ファイルを\"\n+\"再作成できます:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:207\n+msgid \"Inspecting and Recovering Data from Failed Instances\"\n+msgstr \"故障したインスタンスからの検査とデータ復旧\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:209\n+msgid \"\"\n+\"In some scenarios, instances are running but are inaccessible through SSH \"\n+\"and do not respond to any command. VNC console could be displaying a boot \"\n+\"failure or kernel panic error messages. This could be an indication of a \"\n+\"file system corruption on the VM itself. If you need to recover files or \"\n+\"inspect the content of the instance, qemu-nbd can be used to mount the disk.\"\n+msgstr \"\"\n+\"いくつかのシナリオでは、インスタンスが実行中であるにも関わらず、SSH 経由でア\"\n+\"クセスできず、あらゆるコマンドに反応がありません。VNC コンソールがブート失敗\"\n+\"やカーネルパニックのエラーメッセージを表示している可能性があります。これは仮\"\n+\"想マシン自身においてファイルシステム破損の意味する可能性があります。ファイル\"\n+\"を復旧したりインスタンスの中身を調査したりする必要があれば、qemu-nbd を使ってディスクをマウント\"\n+\"できます。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:218\n+msgid \"\"\n+\"If you access or view the user's content and data, get their approval first!\"\n+msgstr \"\"\n+\"ユーザーのコンテンツやデータにアクセスしたり表示したりする場合は、まず承認をもらっ\"\n+\"てください!\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:221\n+msgid \"\"\n+\"To access the instance's disk (/var/lib/nova/instances/instance-xxxxxx/\"\n+\"disk), the following steps must be followed:\"\n+msgstr \"\"\n+\"インスタンスのディスク (/var/lib/nova/instances/instance-xxxxxx/disk) にアク\"\n+\"セスするには、以下の手順に従う必要があります:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:226\n+msgid \"Suspend the instance using the virsh command\"\n+msgstr \"virsh コマンドを使用してインスタンスをサスペンドします。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:230\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:271\n+msgid \"Connect the qemu-nbd device to the disk\"\n+msgstr \"qemu-nbd デバイスをディスクに接続します。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:234\n+msgid \"Mount the qemu-nbd device\"\n+msgstr \"qemu-nbd デバイスをマウントします。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:237\n+msgid \"Unmount the device after inspecting\"\n+msgstr \"デバイスを調査後、アンマウントします。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:240\n+msgid \"Disconnect the qemu-nbd device\"\n+msgstr \"qemu-nbd デバイスを切断します。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:243\n+msgid \"Resume the instance\"\n+msgstr \"インスタンスを再開します。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:246\n+msgid \"\"\n+\"If you do not follow the steps from 4-6, OpenStack Compute cannot manage the \"\n+\"instance any longer. It fails to respond to any command issued by OpenStack \"\n+\"Compute and it is marked as shutdown.\"\n+msgstr \"\"\n+\"手順 4-6 を省略すると、OpenStack Compute がインスタンスを管理できなくなりま\"\n+\"す。OpenStack Compute により発行されるすべてのコマンドに対する応答が失敗し、\"\n+\"シャットダウンしているように見えます。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:250\n+msgid \"\"\n+\"Once you mount the disk file, you should be able access it and treat it as \"\n+\"normal directories with files and a directory structure. However, we do not \"\n+\"recommend that you edit or touch any files because this could change the \"\n+\"acls and make the instance unbootable if it is not already.\"\n+msgstr \"\"\n+\"ディスクファイルをマウントすると、それにアクセスでき、ファイルとディレクトリ\"\n+\"構造を持つ通常のディレクトリのように取り扱えます。しかしながら、\"\n+\"どのファイルの編集も操作もしないことをお薦めします。なぜなら、それにより ACL が変更されたり、\"\n+\"起動できるインスタンスが起動できなくなってします場合があるからです。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:258\n+msgid \"\"\n+\"Suspend the instance using the virsh command - taking note of the internal \"\n+\"ID.\"\n+msgstr \"\"\n+\"virsh コマンドを使用してインスタンスを一時停止します - 内部 ID を記録します。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:282\n+msgid \"Mount the qemu-nbd device.\"\n+msgstr \"qemu-nbd デバイスをマウントします。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:283\n+msgid \"\"\n+\"The qemu-nbd device tries to export the instance disk's different partitions \"\n+\"as separate devices. For example if vda as the disk and vda1 as the root \"\n+\"partition, qemu-nbd exports the device as /dev/nbd0 and /dev/nbd0p1 \"\n+\"respectively.\"\n+msgstr \"\"\n+\"qemu-nbd デバイスはインスタンスのディスクの個々のパーティションを別々のデ\"\n+\"バイスとしてエクスポートしようとします。たとえば、ディスクが vda で、ルート\"\n+\"パーティションが vda1 の場合、qemu-nbd はそれぞれ /dev/nbd0 と /dev/\"\n+\"nbd0p1 としてデバイスをエクスポートします。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:293\n+msgid \"\"\n+\"To examine the secondary or ephemeral disk, use an alternate mount point if \"\n+\"you want both primary and secondary drives mounted at the same time.\"\n+msgstr \"\"\n+\"セカンダリディスクや一時ディスクを調査する際に、プライマリディスクとセカン\"\n+\"ダリディスクを同時にマウントしたければ、別のマウントポイントを使用してください。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:324\n+msgid \"\"\n+\"Once you have completed the inspection, umount the mount point and release \"\n+\"the qemu-nbd device\"\n+msgstr \"\"\n+\"調査を完了すると、マウントポイントをアンマウントし、qemu-nbd デバイスを解放し\"\n+\"ます。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:332\n+msgid \"Resume the instance using virsh\"\n+msgstr \"virsh を使用してインスタンスを再開します。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:347\n+msgid \"Volumes\"\n+msgstr \"ボリューム\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:348\n+msgid \"\"\n+\"If the affected instances also had attached volumes, first generate a list \"\n+\"of instance and volume UUIDs:\"\n+msgstr \"\"\n+\"影響のあったインスタンスがボリュームを接続していれば、まずインスタンスとボ\"\n+\"リュームの UUID 一覧を生成します:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:355\n+msgid \"You should see a result like the following:\"\n+msgstr \"以下のような結果を確認できます:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:362\n+msgid \"Next, manually detach and reattach the volumes:\"\n+msgstr \"次に、ボリュームを手動で切断し、再接続します:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:366\n+msgid \"\"\n+\"Where X is the proper mount point. Make sure that the instance has \"\n+\"successfully booted and is at a login screen before doing the above.\"\n+msgstr \"\"\n+\"ここで、X には適切なマウントポイントを指定します。上記を実行する前に、インスタ\"\n+\"ンスが正常に起動し、ログイン画面になっていることを確認します。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:372\n+msgid \"Total Compute Node Failure\"\n+msgstr \"コンピュートノード全体の故障\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:373\n+msgid \"\"\n+\"If a compute node fails and won't be fixed for a few hours or ever, you can \"\n+\"relaunch all instances that are hosted on the failed node if you use shared \"\n+\"storage for <code>/var/lib/nova/instances</code>.\"\n+msgstr \"\"\n+\"コンピュートノードが故障し、2〜3時間もしくはそれ以上たっても復旧できないと見込まれる場合、<code>/var/lib/nova/\"\n+\"instances</code> に共有ストレージを使用していれば、故障したノードで\"\n+\"動作していたインスタンスをすべて再スタートすることができます。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:377\n+msgid \"\"\n+\"To do this, generate a list of instance UUIDs that are hosted on the failed \"\n+\"node by running the following query on the nova database:\"\n+msgstr \"\"\n+\"これを実行するために、nova データベースにおいて以下のクエリーを実行することにより、\"\n+\"故障したノードにおいてホストされているインスタンスの UUID の一覧を生成しま\"\n+\"す:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:381\n+msgid \"\"\n+\"Next, tell Nova that all instances that used to be hosted on c01.example.com \"\n+\"are now hosted on c02.example.com:\"\n+msgstr \"\"\n+\"次に、c01.example.com においてホストされていたすべてのインスタンスが、今度は \"\n+\"c02.example.com でホストされることを Nova に教えます:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:385\n+msgid \"\"\n+\"After that, use the nova command to reboot all instances that were on c01.\"\n+\"example.com while regenerating their XML files at the same time:\"\n+msgstr \"\"\n+\"その後、nova コマンドを使って、c01.example.com にあったすべてのインスタンスを再起動します。\"\n+\"起動する際にインスタンスの XML ファイルを再生成します:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:389\n+msgid \"\"\n+\"Finally, re-attach volumes using the same method described in <emphasis role=\"\n+\"\\\"bold\\\">After a compute node Reboots</emphasis>.\"\n+msgstr \"\"\n+\"最後に、<emphasis role=\\\"bold\\\">Compute ノードの再起動後</emphasis> に説明さ\"\n+\"れているのと同じ方法を用いて、ボリュームを再接続します。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:395\n+msgid \"/var/lib/nova/instances\"\n+msgstr \"/var/lib/nova/instances\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:396\n+msgid \"\"\n+\"It's worth mentioning this directory in the context of failed compute nodes. \"\n+\"This directory contains the libvirt KVM file-based disk images for the \"\n+\"instances that are hosted on that compute node. If you are not running your \"\n+\"cloud in a shared storage environment, this directory is unique across all \"\n+\"compute nodes.\"\n+msgstr \"\"\n+\"コンピュートノードの故障の話題に関連して、このディレクトリについては説明しておく価値が\"\n+\"あるでしょう。このディレクトリには、コンピュートノードにホストされているインスタンス用\"\n+\"の libvirt KVM のファイル形式のディスクイメージが置かれます。共有ストレージ\"\n+\"環境でクラウドを実行していなければ、このディレクトリはコンピュートノード全体\"\n+\"で一つしかありません。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:403\n+msgid \"<code>/var/lib/nova/instances</code> contains two types of directories.\"\n+msgstr \"\"\n+\"<code>/var/lib/nova/instances</code> には 2 種類のディレクトリがあります。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:406\n+msgid \"\"\n+\"The first is the <code>_base</code> directory. This contains all of the \"\n+\"cached base images from glance for each unique image that has been launched \"\n+\"on that compute node. Files ending in <code>_20</code> (or a different \"\n+\"number) are the ephemeral base images.\"\n+msgstr \"\"\n+\"一つ目は <code>_base</code> ディレクトリです。ここには、そのコンピュートノードで\"\n+\"起動されたそれぞれのイメージに関して、glance から取得したすべてのベースイメージ\"\n+\"のキャッシュが置かれます。<code>_20</code> (または他の番号) で終わるファイル\"\n+\"は一時ディスクのベースイメージです。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:412\n+msgid \"\"\n+\"The other directories are titled <code>instance-xxxxxxxx</code>. These \"\n+\"directories correspond to instances running on that compute node. The files \"\n+\"inside are related to one of the files in the <code>_base</code> directory. \"\n+\"They're essentially differential-based files containing only the changes \"\n+\"made from the original <code>_base</code> directory.\"\n+msgstr \"\"\n+\"もう一つのディレクトリは <code>instance-xxxxxxxx</code> という名前です。これらの\"\n+\"ディレクトリはコンピュートノードにおいて実行中のインスタンスと対応します。中\"\n+\"にあるファイルは <code>_base</code> ディレクトリにあるファイルのどれかと関連\"\n+\"があります。これらは基本的に、元々の <code>_base</code> ディレクトリからの変更点\"\n+\"のみ含む、差分ベースのファイルです。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:420\n+msgid \"\"\n+\"All files and directories in <code>/var/lib/nova/instances</code> are \"\n+\"uniquely named. The files in _base are uniquely titled for the glance image \"\n+\"that they are based on and the directory names <code>instance-xxxxxxxx</\"\n+\"code> are uniquely titled for that particular instance. For example, if you \"\n+\"copy all data from <code>/var/lib/nova/instances</code> on one compute node \"\n+\"to another, you do not overwrite any files or cause any damage to images \"\n+\"that have the same unique name, because they are essentially the same file.\"\n+msgstr \"\"\n+\"<code>/var/lib/nova/instances</code> にあるすべてのファイルとディレクトリは一\"\n+\"意に名前が付けられています。_base にあるファイルは元となった glance イメー\"\n+\"ジに対して一意に名前が付けられています。また、<code>instance-xxxxxxxx</code> \"\n+\"という名前が付けられたディレクトリは特定のインスタンスに対して一意にタイトル\"\n+\"が付けられています。たとえば、あるコンピュートノードにある <code>/var/lib/nova/\"\n+\"instances</code> のすべてのデータを他のノードにコピーしたとしても、\"\n+\"ファイルを上書きすることはありませんし、また同じ一意な名前を持つイメージにダメージを与えることもありません。\"\n+\"同じ一意な名前を持つものは本質的に同じファイルだからです。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:432\n+msgid \"\"\n+\"Although this method is not documented or supported, you can use it when \"\n+\"your compute node is permanently offline but you have instances locally \"\n+\"stored on it.\"\n+msgstr \"\"\n+\"この方法はドキュメントに書かれておらず、サポートされていない方法ですが、\"\n+\"コンピュートノードが完全にオフラインになってしまったが、インスタンスがローカルに保存されている\"\n+\"ときに、この方法を使用できます。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:440\n+msgid \"Storage Node Failures and Maintenance\"\n+msgstr \"ストレージノードの故障とメンテナンス\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:441\n+msgid \"\"\n+\"Due to the Object Storage's high redundancy, dealing with object storage \"\n+\"node issues is a lot easier than dealing with compute node issues.\"\n+msgstr \"\"\n+\"オブジェクトストレージの高い冗長性のため、オブジェクトストレージのノードに関\"\n+\"する問題を処理することは、コンピュートノードに関する問題を処理するよりも簡単で\"\n+\"す。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:446\n+msgid \"Rebooting a Storage Node\"\n+msgstr \"ストレージノードの再起動\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:447\n+msgid \"\"\n+\"If a storage node requires a reboot, simply reboot it. Requests for data \"\n+\"hosted on that node are redirected to other copies while the server is \"\n+\"rebooting.\"\n+msgstr \"\"\n+\"ストレージノードの再起動が必要ならば、単に再起動します。そのノードにホストさ\"\n+\"れているデータに対する要求は、サーバーが再起動している間、他のコピーに転送さ\"\n+\"れます。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:454\n+msgid \"Shutting Down a Storage Node\"\n+msgstr \"ストレージノードのシャットダウン\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:455\n+msgid \"\"\n+\"If you need to shut down a storage node for an extended period of time (1+ \"\n+\"days), consider removing the node from the storage ring. For example:\"\n+msgstr \"\"\n+\"ストレージノードを少し長い間 (1 日以上) シャットダウンする必要があれば、ノー\"\n+\"ドをストレージリングから削除することを検討します。例:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:464\n+msgid \"Next, redistribute the ring files to the other nodes:\"\n+msgstr \"次に、ring ファイルを他のノードに再配布します:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:470\n+msgid \"\"\n+\"These actions effectively take the storage node out of the storage cluster.\"\n+msgstr \"\"\n+\"これらの操作はストレージノードをストレージクラスターから効率的に外せます。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:472\n+msgid \"\"\n+\"When the node is able to rejoin the cluster, just add it back to the ring. \"\n+\"The exact syntax to add a node to your Swift cluster using <code>swift-ring-\"\n+\"builder</code> heavily depends on the original options used when you \"\n+\"originally created your cluster. Please refer back to those commands.\"\n+msgstr \"\"\n+\"ノードがクラスターに参加できるようになったら、ただリングに再度追加するだけです。<code>swift-ring-\"\n+\"builder</code> を使用して Swift クラスターにノードを追加するための構文は、\"\n+\"元々クラスターを作成したときに使用した元々のオプションに強く依存します。作成時に使用したコマンドをもう一度見てください。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:482\n+msgid \"Replacing a Swift Disk\"\n+msgstr \"Swift ディスクの交換\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:483\n+msgid \"\"\n+\"If a hard drive fails in a Object Storage node, replacing it is relatively \"\n+\"easy. This assumes that your Object Storage environment is configured \"\n+\"correctly where the data that is stored on the failed drive is also \"\n+\"replicated to other drives in the Object Storage environment.\"\n+msgstr \"\"\n+\"Object Storage ノードのハードディスクが故障した場合、その交換は比較的簡単で\"\n+\"す。Object Storage 環境が正しく設定され、\"\n+\"故障したディスクに保存されているデータが Object Storage 環\"\n+\"境内の他のディスクにも複製されていることを前提にしています。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:489\n+msgid \"This example assumes that <code>/dev/sdb</code> has failed.\"\n+msgstr \"この例では、<code>/dev/sdb</code> が故障したと仮定します。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:491\n+msgid \"First, unmount the disk:\"\n+msgstr \"まず、ディスクをアンマウントします:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:493\n+msgid \"\"\n+\"Next, physically remove the disk from the server and replace it with a \"\n+\"working disk.\"\n+msgstr \"\"\n+\"次に、ディスクを物理的にサーバーから取り外し、正常なディスクと入れ替えます。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:495\n+msgid \"Ensure that the operating system has recognized the new disk:\"\n+msgstr \"\"\n+\"オペレーティングシステムが新しいディスクを認識していることを確認します:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:498\n+msgid \"You should see a message about /dev/sdb.\"\n+msgstr \"/dev/sdb に関するメッセージを確認したほうがいいです。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:499\n+msgid \"\"\n+\"Because it is recommended to not use partitions on a swift disk, simply \"\n+\"format the disk as a whole:\"\n+msgstr \"\"\n+\"Swift ディスクではパーティションを使用しないことが推奨されるので、単にディスク\"\n+\"全体をフォーマットします:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:502\n+msgid \"Finally, mount the disk:\"\n+msgstr \"最後に、ディスクをマウントします:\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:504\n+msgid \"\"\n+\"Swift should notice the new disk and that no data exists. It then begins \"\n+\"replicating the data to the disk from the other existing replicas.\"\n+msgstr \"\"\n+\"Swift は新しいディスクと通知します。また、データが存在しないことを通知しま\"\n+\"す。そうすると、他の既存の複製からディスクにデータを複製しはじめます。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:511\n+msgid \"Handling a Complete Failure\"\n+msgstr \"完全な故障の対処\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:512\n+msgid \"\"\n+\"A common way of dealing with the recovery from a full system failure, such \"\n+\"as a power outage of a data center is to assign each service a priority, and \"\n+\"restore in order.\"\n+msgstr \"\"\n+\"データセンターの電力消失のような、完全なシステム故障から復旧する一般的な方法\"\n+\"は、各サービスに優先度を付け、順番に復旧することです。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:517\n+msgid \"Example Service Restoration Priority List\"\n+msgstr \"サービス復旧優先度一覧の例\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:524\n+msgid \"Internal network connectivity\"\n+msgstr \"内部ネットワーク接続性\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:531\n+msgid \"Backing storage services\"\n+msgstr \"バッキングストレージサービス\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:536\n+msgid \"3\"\n+msgstr \"3\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:538\n+msgid \"Public network connectivity for user Virtual Machines\"\n+msgstr \"ユーザーの仮想マシンに対するパブリックネットワーク接続性\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:545\n+msgid \"Nova-compute, nova-network, cinder hosts\"\n+msgstr \"nova-compute, nova-network, cinder ホスト\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:550\n+msgid \"5\"\n+msgstr \"5\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:552\n+msgid \"User virtual machines\"\n+msgstr \"ユーザーの仮想マシン\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:556\n+msgid \"10\"\n+msgstr \"10\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:558\n+msgid \"Message Queue and Database services\"\n+msgstr \"メッセージキューとデータベースのサービス\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:563\n+msgid \"15\"\n+msgstr \"15\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:565\n+msgid \"Keystone services\"\n+msgstr \"Keystone サービス\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:569\n+msgid \"20\"\n+msgstr \"20\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:571\n+msgid \"cinder-scheduler\"\n+msgstr \"cinder-scheduler\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:575\n+msgid \"21\"\n+msgstr \"21\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:577\n+msgid \"Image Catalogue and Delivery services\"\n+msgstr \"イメージカタログとイメージ配信のサービス\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:582\n+msgid \"22\"\n+msgstr \"22\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:584\n+msgid \"nova-scheduler services\"\n+msgstr \"nova-scheduler サービス\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:588\n+msgid \"98\"\n+msgstr \"98\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:590\n+msgid \"Cinder-api\"\n+msgstr \"cinder-api\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:594\n+msgid \"99\"\n+msgstr \"99\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:596\n+msgid \"Nova-api services\"\n+msgstr \"nova-api サービス\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:600\n+msgid \"100\"\n+msgstr \"100\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:602\n+msgid \"Dashboard node\"\n+msgstr \"ダッシュボードサービス\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:606\n+msgid \"\"\n+\"Use this example priority list to ensure that user affected services are \"\n+\"restored as soon as possible, but not before a stable environment is in \"\n+\"place. Of course, despite being listed as a single line item, each step \"\n+\"requires significant work. For example, just after starting the database, \"\n+\"you should check its integrity or, after starting the Nova services, you \"\n+\"should verify that the hypervisor matches the database and fix any \"\n+\"mismatches.\"\n+msgstr \"\"\n+\"この例にある優先度一覧を使用すると、きちんと安定した状態になる前であっても、\"\n+\"できる限り早くユーザーに影響するサービスを復旧させることができます。\"\n+\"もちろん、1 行の項目として一覧化されていますが、各ステップは多大な作業が必要\"\n+\"です。たとえば、データベースを開始した後、その完全性を確認すべきです。また\"\n+\"、Nova サービスを開始した後、ハイパーバイザーがデータベースに一致しているかを確認し、\"\n+\"不一致があれば修正すべきです。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:618\n+msgid \"Configuration Management\"\n+msgstr \"構成管理\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:619\n+msgid \"\"\n+\"Maintaining an OpenStack cloud requires that you manage multiple physical \"\n+\"servers, and this number might grow over time. Because managing nodes \"\n+\"manually is error-prone, we strongly recommend that you use a configuration \"\n+\"management tool. These tools automate the process of ensuring that all of \"\n+\"your nodes are configured properly and encourage you to maintain your \"\n+\"configuration information (such as packages and configuration options) in a \"\n+\"version controlled repository.\"\n+msgstr \"\"\n+\"OpenStack クラウドをメンテナンスするには、複数の物理サーバーを管理す\"\n+\"ることが必要です。そして、この数は日々増えていきます。ノードを手動で管理する\"\n+\"ことはエラーを起こしやすいので、構成管理ツールを使用することを強く推奨しま\"\n+\"す。これらのツールはすべてのノードが適切に設定されていることを保証するプロ\"\n+\"セスを自動化します。また、これらを使うことで、(パッケージや\"\n+\"設定オプションといった) 構成情報のバージョン管理されたリポジトリでの管理が行いやすくなります。\"\n+\n+#: doc/src/docbkx/openstack-ops/src/ch_ops_maintenance.xml:628\n+msgid \"\"\n+\"Several configuration management tools are available, and this guide does \"\n+\"not recommend a specific one. The two most popular ones in the OpenStack \"\n+\"community are <link href=\\\"https://puppetlabs.com/\\\">Puppet</link> (https://\"\n+\"puppetlabs.com/) with available <link title=\\\"Optimization Overview\\\" href=\"\n+\"\\\"http://github.com/puppetlabs/puppetlabs-openstack\\\">OpenStack Puppet \"\n+\"modules</link> (http://github.com/puppetlabs/puppetlabs-openstack) and <link \"\n+\"href=\\\"http://www.opscode.com/chef/\\\">Chef</link> (http://opscode.com/chef) \"\n+\"with available <link href=\\\"https://github.com/opscode/openstack-chef-repo\"\n+\"\\\">OpenStack Chef recipes</link> (https://github.com/opscode/openstack-chef-\"\n+\"repo). Other newer configuration tools include <link href=\\\"https://juju.\"\n+\"ubuntu.com/\\\">Juju</link> (https://juju.ubuntu.com/) <link href=\\\"http://\"\n+\"ansible.cc\\\">Ansible</link> (http://ansible.cc) and <link href=\\\"http://\"\n+\"saltstack.com/\\\">Salt</link> (http://saltstack.com), and more mature \"\n+\"configuration management tools include <link href=\\\"http://cfengine.com/\"\n+\"\\\">CFEngine</link> (http://cfengine.com) and <link href=\\\"http://bcfg2.org/\"\n+\"\\\">Bcfg2</link> (http://bcfg2.org).\"\n+msgstr \"\"\n+\"いくつかの構成管理ツールがあります。このガイドでは特定のものを推奨しませ\"\n+\"ん。OpenStack コミュニティで人気があるものは <link href=\\\"https://puppetlabs.com/\\\">Puppet</link> (https://puppetlabs.com/) と \"\n+\"<link href=\\\"http://www.opscode.com/chef/\\\">Chef</link> (http://opscode.com/chef) の 2 つで、\"\n+\"OpenStack 用の設定集がそれぞれ <link title=\"\n+\"\\\"Optimization Overview\\\" href=\\\"http://github.com/puppetlabs/puppetlabs-\"\n+\"openstack\\\">OpenStack Puppet modules</link> (http://github.com/puppetlabs/\"\n+\"puppetlabs-openstack) と <link href=\\\"https://github.\"\n+\"com/opscode/openstack-chef-repo\\\">OpenStack Chef recipes</link> (https://\"\n+\"github.com/opscode/openstack-chef-repo) にあります。比較的新\"","path":"doc/src/docbkx/openstack-ops/locale/chap/ch_ops_maintenance.xml.ja.po","position":941,"original_position":941,"commit_id":"27d7fdf8a61931ca2a4318dbce191bd3a7f55990","original_commit_id":"27d7fdf8a61931ca2a4318dbce191bd3a7f55990","user":{"login":"katomo","id":4470316,"avatar_url":"https://secure.gravatar.com/avatar/f8245968345e08ee42c10b1110916211?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"f8245968345e08ee42c10b1110916211","url":"https://api.github.com/users/katomo","html_url":"https://github.com/katomo","followers_url":"https://api.github.com/users/katomo/followers","following_url":"https://api.github.com/users/katomo/following{/other_user}","gists_url":"https://api.github.com/users/katomo/gists{/gist_id}","starred_url":"https://api.github.com/users/katomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katomo/subscriptions","organizations_url":"https://api.github.com/users/katomo/orgs","repos_url":"https://api.github.com/users/katomo/repos","events_url":"https://api.github.com/users/katomo/events{/privacy}","received_events_url":"https://api.github.com/users/katomo/received_events","type":"User"},"created_at":"2013-07-09T10:59:39Z","updated_at":"2013-07-09T10:59:39Z","html_url":"https://github.com/openstack-ja/openstack-manuals/pull/29#discussion_r5087162","pull_request_url":"https://api.github.com/repos/openstack-ja/openstack-manuals/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/openstack-ja/openstack-manuals/pulls/comments/5087162"},"html":{"href":"https://github.com/openstack-ja/openstack-manuals/pull/29#discussion_r5087162"},"pull_request":{"href":"https://api.github.com/repos/openstack-ja/openstack-manuals/pulls/29"}}}}

{"repository":{"description":"","homepage":"http://openstack.org","watchers":3,"stargazers":3,"forks":2,"fork":true,"size":512,"owner":"openstack-ja","private":false,"open_issues":38,"has_issues":true,"has_downloads":false,"has_wiki":true,"language":"JavaScript","created_at":"2013-04-15T18:13:11-07:00","pushed_at":"2013-07-09T03:49:15-07:00","master_branch":"master","organization":"openstack-ja"},"actor_attributes":{"type":"User","name":"KATO Tomoyuki","location":"Japan","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/openstack-ja/openstack-manuals/pull/29#discussion_r5087162"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/projecthydra/hydra-editor/pulls/comments/7110463","id":7110463,"diff_hunk":"@@ -1,25 +1,31 @@\n module RecordsControllerBehavior\n+ extend ActiveSupport::Concern\n+ \n+ included do\n+ before_filter :load_and_authorize_record, only: [:edit, :update]\n+ end\n+\n def new\n authorize! :create, ActiveFedora::Base\n unless has_valid_type?\n- render 'choose_type'\n+ render 'records/choose_type'\n return\n end\n \n @record = params[:type].constantize.new\n initialize_fields\n+ render 'records/new'\n end\n \n def edit\n- @record = ActiveFedora::Base.find(params[:id], cast: true)\n- authorize! :edit, @record\n initialize_fields\n+ render 'records/edit'\n end\n \n def create\n authorize! :create, ActiveFedora::Base\n unless has_valid_type?\n- redirect_to hydra_editor.new_record_path, :flash=> {error: \"Lost the type\"}","path":"app/controllers/concerns/records_controller_behavior.rb","position":31,"original_position":31,"commit_id":"562fddd152d3f2bc6bdd3319499df790a35a9fd8","original_commit_id":"562fddd152d3f2bc6bdd3319499df790a35a9fd8","user":{"login":"jcoyne","id":92044,"avatar_url":"https://1.gravatar.com/avatar/9d5a28f7f32c760abcf49ad155683181?d=https%3A%2F%2Fidenticons.github.com%2F08f835f4cac61f448a8c001529a36510.png","gravatar_id":"9d5a28f7f32c760abcf49ad155683181","url":"https://api.github.com/users/jcoyne","html_url":"https://github.com/jcoyne","followers_url":"https://api.github.com/users/jcoyne/followers","following_url":"https://api.github.com/users/jcoyne/following{/other_user}","gists_url":"https://api.github.com/users/jcoyne/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoyne/subscriptions","organizations_url":"https://api.github.com/users/jcoyne/orgs","repos_url":"https://api.github.com/users/jcoyne/repos","events_url":"https://api.github.com/users/jcoyne/events{/privacy}","received_events_url":"https://api.github.com/users/jcoyne/received_events","type":"User","site_admin":false},"body":"I really don't like this change. Instead can we do something like: \r\n\r\n```ruby\r\nrespond_to?(:hydra_editor) ? hydra_editor.new_record_path : new_rcord_path\r\n```","created_at":"2013-10-21T22:10:07Z","updated_at":"2013-10-21T22:10:07Z","html_url":"https://github.com/projecthydra/hydra-editor/pull/13#discussion_r7110463","pull_request_url":"https://api.github.com/repos/projecthydra/hydra-editor/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/projecthydra/hydra-editor/pulls/comments/7110463"},"html":{"href":"https://github.com/projecthydra/hydra-editor/pull/13#discussion_r7110463"},"pull_request":{"href":"https://api.github.com/repos/projecthydra/hydra-editor/pulls/13"}}}}

{"repository":{"description":"A basic editor for hydra objects.","watchers":2,"stargazers":2,"forks":2,"fork":false,"size":318,"owner":"projecthydra","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-04-15T08:18:49-07:00","pushed_at":"2013-10-18T14:42:59-07:00","master_branch":"master","organization":"projecthydra"},"actor_attributes":{"type":"User","name":"Justin Coyne","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/projecthydra/hydra-editor/pull/13#discussion_r7110463"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/renderedtext/semaphore-docs/pulls/comments/8541646","id":8541646,"diff_hunk":"@@ -53,7 +53,9 @@\n <pre>CI=true\n SEMAPHORE=true\n BRANCH_NAME=#{current_branch_name}\n+REVISION","path":"_site/available-environment-variables/index.html","position":4,"original_position":4,"commit_id":"e9871acf8c18f0294e205fe8c29cf020a9344dad","original_commit_id":"e9871acf8c18f0294e205fe8c29cf020a9344dad","user":{"login":"markoa","id":8651,"avatar_url":"https://gravatar.com/avatar/4062b608b628a89adeb54ec61e464c32?d=https%3A%2F%2Fidenticons.github.com%2F281683d0650eb208fa2138978a675665.png&r=x","gravatar_id":"4062b608b628a89adeb54ec61e464c32","url":"https://api.github.com/users/markoa","html_url":"https://github.com/markoa","followers_url":"https://api.github.com/users/markoa/followers","following_url":"https://api.github.com/users/markoa/following{/other_user}","gists_url":"https://api.github.com/users/markoa/gists{/gist_id}","starred_url":"https://api.github.com/users/markoa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markoa/subscriptions","organizations_url":"https://api.github.com/users/markoa/orgs","repos_url":"https://api.github.com/users/markoa/repos","events_url":"https://api.github.com/users/markoa/events{/privacy}","received_events_url":"https://api.github.com/users/markoa/received_events","type":"User","site_admin":false},"body":"@rastkojokic no\r\n\r\n@darkofabijan no\r\n\r\nLet's merge the few that are \"only for deployment\" into a separate list below this one.","created_at":"2013-12-24T10:14:18Z","updated_at":"2013-12-24T10:14:18Z","html_url":"https://github.com/renderedtext/semaphore-docs/pull/22#discussion_r8541646","pull_request_url":"https://api.github.com/repos/renderedtext/semaphore-docs/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/renderedtext/semaphore-docs/pulls/comments/8541646"},"html":{"href":"https://github.com/renderedtext/semaphore-docs/pull/22#discussion_r8541646"},"pull_request":{"href":"https://api.github.com/repos/renderedtext/semaphore-docs/pulls/22"}}}}

{"repository":{"description":"Documentation site for Semaphore.","homepage":"http://docs.semaphoreapp.com","watchers":2,"stargazers":2,"forks":4,"fork":false,"size":5953,"owner":"renderedtext","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"CSS","created_at":"2012-02-20T05:33:04-08:00","pushed_at":"2013-12-24T02:10:55-08:00","master_branch":"master","organization":"renderedtext"},"actor_attributes":{"type":"User","name":"Marko Anastasov","company":"Rendered Text","blog":"http://renderedtext.com","location":"Novi Sad, Serbia","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/renderedtext/semaphore-docs/pull/22#discussion_r8541646"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/sakaiproject/3akai-ux/pulls/comments/4401226","id":4401226,"body":"Removed the `ev` and `data`","diff_hunk":"@@ -319,9 +342,26 @@ define(['jquery', 'oae.core', 'jquery.autosuggest'], function($, oae) {\n ////////////////////\n \n /**\n+ * Initializes the default state:\n+ * - Cache the group data\n+ * - Cache the visibility setting\n+ * - Render the visibility overview\n+ * - Get and render the members\n+ *\n+ * @param {Object} ev Standard event object coming from the `oae.context.send.manageaccess` or `oae.context.send.manageaccess-add` events.\n+ * @param {Object} data The context data object\n+ */\n+ var initDefaultPanel = function(ev, data) {","path":"node_modules/oae-core/manageaccess/js/manageaccess.js","position":354,"original_position":354,"commit_id":"ac1471cdf2a31fd58033b79bdd84a20d6549d0ae","original_commit_id":"ac1471cdf2a31fd58033b79bdd84a20d6549d0ae","user":{"login":"nicolaasmatthijs","id":109850,"avatar_url":"https://secure.gravatar.com/avatar/8d128e44d86f7ea45534291c2c36599a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"8d128e44d86f7ea45534291c2c36599a","url":"https://api.github.com/users/nicolaasmatthijs","html_url":"https://github.com/nicolaasmatthijs","followers_url":"https://api.github.com/users/nicolaasmatthijs/followers","following_url":"https://api.github.com/users/nicolaasmatthijs/following{/other_user}","gists_url":"https://api.github.com/users/nicolaasmatthijs/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaasmatthijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaasmatthijs/subscriptions","organizations_url":"https://api.github.com/users/nicolaasmatthijs/orgs","repos_url":"https://api.github.com/users/nicolaasmatthijs/repos","events_url":"https://api.github.com/users/nicolaasmatthijs/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaasmatthijs/received_events","type":"User"},"created_at":"2013-05-27T14:14:58Z","updated_at":"2013-05-27T14:14:58Z","html_url":"https://github.com/sakaiproject/3akai-ux/pull/2842#discussion_r4401226","pull_request_url":"https://api.github.com/repos/sakaiproject/3akai-ux/pulls/2842","_links":{"self":{"href":"https://api.github.com/repos/sakaiproject/3akai-ux/pulls/comments/4401226"},"html":{"href":"https://github.com/sakaiproject/3akai-ux/pull/2842#discussion_r4401226"},"pull_request":{"href":"https://api.github.com/repos/sakaiproject/3akai-ux/pulls/2842"}}}}

{"repository":{"description":"Front-end development for Sakai 3","homepage":"3akai.sakaiproject.org/dev","watchers":115,"stargazers":115,"forks":200,"fork":false,"size":22712,"owner":"sakaiproject","private":false,"open_issues":26,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2010-07-07T05:48:50-07:00","pushed_at":"2013-05-27T03:14:08-07:00","master_branch":"master","organization":"sakaiproject"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/sakaiproject/3akai-ux/pull/2842#discussion_r4401226"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments/4724744","id":4724744,"body":"Thanks, I'll integrate your concern. Any other suggestions?","diff_hunk":"@@ -43,11 +41,22 @@ For a more detailed discussion, read these :doc:`detailed documents\n \n .. note::\n \n- Do *not* ever merge the main branch into yours. If GitHub indicates that\n+ Do *not* ever merge the main branch into yours. If GitHub indicates that\n the Pull Request can no longer be merged automatically, rebase onto master::\n \n- git fetch origin/master\n- git rebase origin/master\n+ git checkout master\n+ git pull upstream master\n+ git checkout transform-speedups\n+ git rebase master\n+\n+ If any conflicts occur, fix the according files and continue::\n+\n+ git add conflict-file1 conflict-file2\n+ git rebase --continue\n+\n+ Finally, you must push your rebased branch::\n+\n+ git push -f origin transform-speedups","path":"CONTRIBUTING.txt","position":64,"original_position":64,"commit_id":"b5fbca3f00d2697f63690179f8b91891217a69e3","original_commit_id":"b5fbca3f00d2697f63690179f8b91891217a69e3","user":{"login":"ahojnnes","id":134307,"avatar_url":"https://secure.gravatar.com/avatar/d41d8cd98f00b204e9800998ecf8427e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"d41d8cd98f00b204e9800998ecf8427e","url":"https://api.github.com/users/ahojnnes","html_url":"https://github.com/ahojnnes","followers_url":"https://api.github.com/users/ahojnnes/followers","following_url":"https://api.github.com/users/ahojnnes/following{/other_user}","gists_url":"https://api.github.com/users/ahojnnes/gists{/gist_id}","starred_url":"https://api.github.com/users/ahojnnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahojnnes/subscriptions","organizations_url":"https://api.github.com/users/ahojnnes/orgs","repos_url":"https://api.github.com/users/ahojnnes/repos","events_url":"https://api.github.com/users/ahojnnes/events{/privacy}","received_events_url":"https://api.github.com/users/ahojnnes/received_events","type":"User"},"created_at":"2013-06-17T14:15:27Z","updated_at":"2013-06-17T14:15:27Z","html_url":"https://github.com/scikit-image/scikit-image/pull/593#discussion_r4724744","pull_request_url":"https://api.github.com/repos/scikit-image/scikit-image/pulls/593","_links":{"self":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/comments/4724744"},"html":{"href":"https://github.com/scikit-image/scikit-image/pull/593#discussion_r4724744"},"pull_request":{"href":"https://api.github.com/repos/scikit-image/scikit-image/pulls/593"}}}}

{"repository":{"description":"Image Processing SciKit (Toolbox for SciPy)","homepage":"http://scikit-image.org","watchers":213,"stargazers":213,"forks":124,"fork":false,"size":1396,"owner":"scikit-image","private":false,"open_issues":11,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-07-07T15:07:20-07:00","pushed_at":"2013-06-12T14:27:23-07:00","master_branch":"master","organization":"scikit-image"},"actor_attributes":{"type":"User","name":"Johannes Schönberger","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/scikit-image/scikit-image/pull/593#discussion_r4724744"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/7186921","id":7186921,"diff_hunk":"@@ -95,10 +113,17 @@ def assert_warns(warning_class, func, *args, **kw):\n raise AssertionError(\"First warning for %s is not a \"\n \"%s( is %s)\"\n % (func.__name__, warning_class, w[0]))\n+ msg = str(w[0].message)\n+ if msg != message:\n+ raise AssertionError(\"The message received ('%s') for <%s> is \"\n+ \"not the one you expected ('%s')\"\n+ % (msg, func.__name__, message\n+ ))","path":"sklearn/utils/testing.py","position":64,"original_position":42,"commit_id":"f1ba804cbe11916d5096873bad3207f39a708c50","original_commit_id":"b630d7325ee3533aef735f2e77c80d9c20f5cf0b","user":{"login":"ogrisel","id":89061,"avatar_url":"https://1.gravatar.com/avatar/aee56554ec30edfd680e1c937ed4e54d?d=https%3A%2F%2Fidenticons.github.com%2F99e8ff48f7f4a7ec3618f0a0efe1af07.png&r=x","gravatar_id":"aee56554ec30edfd680e1c937ed4e54d","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"body":"You mean, you think we should use this variant that checks the warning message content as well as the type extensively? I agree.","created_at":"2013-10-24T13:04:46Z","updated_at":"2013-10-24T13:04:46Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/2541#discussion_r7186921","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/2541","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/7186921"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/2541#discussion_r7186921"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/2541"}}}}

{"repository":{"description":"scikit-learn: machine learning in Python","homepage":"http://scikit-learn.org","watchers":1842,"stargazers":1842,"forks":960,"fork":false,"size":76575,"owner":"scikit-learn","private":false,"open_issues":394,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2010-08-17T02:43:38-07:00","pushed_at":"2013-10-23T04:12:04-07:00","integrate_branch":"gael","master_branch":"master","organization":"scikit-learn"},"actor_attributes":{"type":"User","name":"Olivier Grisel","blog":"http://ogrisel.com","location":"Paris, France","email":"[email protected]"},"url":"https://github.com/scikit-learn/scikit-learn/pull/2541#discussion_r7186921"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/6258130","id":6258130,"body":"You have already done this in `_parallel_predict_regression `.","diff_hunk":"@@ -0,0 +1,882 @@\n+\"\"\"Bagging meta-estimator.\"\"\"\n+\n+# Author: Gilles Louppe <[email protected]>\n+# License: BSD 3 clause\n+\n+from __future__ import division\n+\n+import itertools\n+import numbers\n+import numpy as np\n+from warnings import warn\n+from abc import ABCMeta, abstractmethod\n+from inspect import getargspec\n+\n+from ..base import ClassifierMixin, RegressorMixin\n+from ..externals.joblib import Parallel, delayed, cpu_count\n+from ..externals.six import with_metaclass\n+from ..externals.six.moves import zip\n+from ..metrics import r2_score, accuracy_score\n+from ..tree import DecisionTreeClassifier, DecisionTreeRegressor\n+from ..utils import check_random_state, check_arrays, column_or_1d\n+from ..utils.fixes import bincount, unique\n+from ..utils.random import sample_without_replacement\n+\n+from .base import BaseEnsemble\n+\n+__all__ = [\"BaggingClassifier\",\n+ \"BaggingRegressor\"]\n+\n+MAX_INT = np.iinfo(np.int32).max\n+\n+\n+def _parallel_build_estimators(n_estimators, ensemble, X, y, sample_weight,\n+ seeds, verbose):\n+ \"\"\"Private function used to build a batch of estimators within a job.\"\"\"\n+ # Retrieve settings\n+ n_samples, n_features = X.shape\n+ max_samples = ensemble.max_samples\n+ max_features = ensemble.max_features\n+\n+ if (not isinstance(max_samples, (numbers.Integral, np.integer)) and\n+ (0.0 < max_samples <= 1.0)):\n+ max_samples = int(max_samples * n_samples)\n+\n+ if (not isinstance(max_features, (numbers.Integral, np.integer)) and\n+ (0.0 < max_features <= 1.0)):\n+ max_features = int(max_features * n_features)\n+\n+ bootstrap = ensemble.bootstrap\n+ bootstrap_features = ensemble.bootstrap_features\n+ support_sample_weight = (\"sample_weight\" in\n+ getargspec(ensemble.base_estimator_.fit)[0])\n+\n+ # Build estimators\n+ estimators = []\n+ estimators_samples = []\n+ estimators_features = []\n+\n+ for i in range(n_estimators):\n+ if verbose > 1:\n+ print(\"building estimator %d of %d\" % (i + 1, n_estimators))\n+\n+ random_state = check_random_state(seeds[i])\n+ seed = check_random_state(random_state.randint(MAX_INT))\n+ estimator = ensemble._make_estimator(append=False)\n+\n+ try: # Not all estimator accept a random_state\n+ estimator.set_params(random_state=seed)\n+ except ValueError:\n+ pass\n+\n+ # Draw features\n+ if bootstrap_features:\n+ features = random_state.randint(0, n_features, max_features)\n+ else:\n+ features = sample_without_replacement(n_features,\n+ max_features,\n+ random_state=random_state)\n+\n+ # Draw samples, using sample weights, and then fit\n+ if support_sample_weight:\n+ if sample_weight is None:\n+ curr_sample_weight = np.ones((n_samples,))\n+ else:\n+ curr_sample_weight = sample_weight.copy()\n+\n+ if bootstrap:\n+ indices = random_state.randint(0, n_samples, max_samples)\n+ sample_counts = bincount(indices, minlength=n_samples)\n+ curr_sample_weight *= sample_counts\n+\n+ else:\n+ not_indices = sample_without_replacement(\n+ n_samples,\n+ n_samples - max_samples,\n+ random_state=random_state)\n+\n+ curr_sample_weight[not_indices] = 0\n+\n+ estimator.fit(X[:, features], y, sample_weight=curr_sample_weight)\n+ samples = curr_sample_weight > 0.\n+\n+ # Draw samples, using a mask, and then fit\n+ else:\n+ if bootstrap:\n+ indices = random_state.randint(0, n_samples, max_samples)\n+ else:\n+ indices = sample_without_replacement(n_samples,\n+ max_samples,\n+ random_state=random_state)\n+\n+ sample_counts = bincount(indices, minlength=n_samples)\n+\n+ estimator.fit((X[indices])[:, features], y[indices])\n+ samples = sample_counts > 0.\n+\n+ estimators.append(estimator)\n+ estimators_samples.append(samples)\n+ estimators_features.append(features)\n+\n+ return estimators, estimators_samples, estimators_features\n+\n+\n+def _parallel_predict_proba(estimators, estimators_features, X, n_classes):\n+ \"\"\"Private function used to compute (proba-)predictions within a job.\"\"\"\n+ n_samples = X.shape[0]\n+ proba = np.zeros((n_samples, n_classes))\n+\n+ for estimator, features in zip(estimators, estimators_features):\n+ try:\n+ proba_estimator = estimator.predict_proba(X[:, features])\n+\n+ if n_classes == len(estimator.classes_):\n+ proba += proba_estimator\n+\n+ else:\n+ for j, c in enumerate(estimator.classes_):\n+ proba[:, c] += proba_estimator[:, j]\n+\n+ except (AttributeError, NotImplementedError):\n+ # Resort to voting\n+ predictions = estimator.predict(X[:, features])\n+\n+ for i in range(n_samples):\n+ proba[i, predictions[i]] += 1\n+\n+ return proba\n+\n+\n+def _parallel_predict_log_proba(estimators, estimators_features, X, n_classes):\n+ \"\"\"Private function used to compute log probabilities within a job.\"\"\"\n+ n_samples = X.shape[0]\n+ log_proba = np.empty((n_samples, n_classes))\n+ log_proba.fill(-np.inf)\n+ all_classes = np.arange(n_classes, dtype=np.int)\n+\n+ for estimator, features in zip(estimators, estimators_features):\n+ log_proba_estimator = estimator.predict_log_proba(X[:, features])\n+\n+ if n_classes == len(estimator.classes_):\n+ log_proba = np.logaddexp(log_proba, log_proba_estimator)\n+\n+ else:\n+ for j, c in enumerate(estimator.classes_):\n+ log_proba[:, c] = np.logaddexp(log_proba[:, c],\n+ log_proba_estimator[:, j])\n+\n+ missing = np.setdiff1d(all_classes, estimator.classes_)\n+\n+ for c in missing:\n+ log_proba[:, c] = np.logaddexp(log_proba[:, c], -np.inf)\n+\n+ return log_proba\n+\n+\n+def _parallel_decision_function(estimators, estimators_features, X, n_classes):\n+ \"\"\"Private function used to compute (proba-)predictions within a job.\"\"\"\n+ decisions = estimators[0].decision_function(X[:, estimators_features[0]])\n+\n+ for estimator, features in zip(estimators[1:],\n+ estimators_features[1:]):\n+ decisions += estimator.decision_function(X[:, features])","path":"sklearn/ensemble/bagging.py","position":182,"original_position":182,"commit_id":"880b47b87b17a061ef81e1f586bd0fc5cc66510c","original_commit_id":"6f3911faa2d8781cfc2f2c6a15c3a24f61d1c812","user":{"login":"arjoly","id":1274722,"avatar_url":"https://1.gravatar.com/avatar/9fb38ab677ea6f73bb07faa43b0677f9?d=https%3A%2F%2Fidenticons.github.com%2F6019fbf51a935cfabfa53d5b72c38615.png","gravatar_id":"9fb38ab677ea6f73bb07faa43b0677f9","url":"https://api.github.com/users/arjoly","html_url":"https://github.com/arjoly","followers_url":"https://api.github.com/users/arjoly/followers","following_url":"https://api.github.com/users/arjoly/following{/other_user}","gists_url":"https://api.github.com/users/arjoly/gists{/gist_id}","starred_url":"https://api.github.com/users/arjoly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arjoly/subscriptions","organizations_url":"https://api.github.com/users/arjoly/orgs","repos_url":"https://api.github.com/users/arjoly/repos","events_url":"https://api.github.com/users/arjoly/events{/privacy}","received_events_url":"https://api.github.com/users/arjoly/received_events","type":"User"},"created_at":"2013-09-10T06:14:39Z","updated_at":"2013-09-10T06:14:39Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/2375#discussion_r6258130","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/2375","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/6258130"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/2375#discussion_r6258130"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/2375"}}}}

{"repository":{"description":"scikit-learn: machine learning in Python","homepage":"http://scikit-learn.org","watchers":1637,"stargazers":1637,"forks":846,"fork":false,"size":15916,"owner":"scikit-learn","private":false,"open_issues":378,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2010-08-17T02:43:38-07:00","pushed_at":"2013-09-09T14:46:51-07:00","integrate_branch":"gael","master_branch":"master","organization":"scikit-learn"},"actor_attributes":{"type":"User","name":"Arnaud Joly","blog":"www.ajoly.org","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/scikit-learn/scikit-learn/pull/2375#discussion_r6258130"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/6068254","id":6068254,"body":"It's a pattern that shows up in gene expression data. I could modify the microarray example to show the difference in the kinds of biclusters found when the data is first log-transformed.","diff_hunk":"@@ -84,6 +87,77 @@ diagonal and checkerboard bicluster structures.\n \n .. currentmodule:: sklearn.cluster.bicluster\n \n+.. _cheng_church:\n+\n+Cheng and Church\n+================\n+\n+:class:`ChengChurch` tries to find biclusters with a low mean squared\n+residue (MSR). For a matrix :math:`A` with shape :math:`m \\times n`,\n+the residue of an entry is the difference between its actual value and\n+its value as predicted by the row, column, and overall mean of the\n+matrix:\n+\n+.. math::\n+ a_{ij} - a_{iJ} - a_{Ij} + a_{I J}\n+\n+where\n+\n+.. math::\n+ a_{iJ} = \\frac{1}{n} \\sum_{j} a_{ij}\n+\n+ a_{Ij} = \\frac{1}{m} \\sum_{i} a_{ij}\n+\n+ a_{I J} = \\frac{1}{mn} \\sum_{i, j} a_{ij}\n+\n+are the row, column, and overall means of :math:`A`. Then the mean\n+squared residue of :math:`A` is:\n+\n+.. math::\n+ \\frac{1}{mn} \\sum \\left (a_{ij} - a_{iJ} - a_{Ij} + a_{I J} \\right)^2\n+\n+The mean squared residue achieves its minimum of 0 when all the rows\n+and all the columns of a bicluster are shifted versions of each other.\n+Constant biclusters, biclusters with constant rows or columns, or\n+biclusters with identical rows or columns are special cases of this\n+condition, all of which have an MSR of 0. As a corollary, additive\n+scaling of the entire bicluster does not affect the MSR score of any\n+of its biclusters: :math:`A` and :math:`A+c`, where :math:`c` is any\n+constant, have the same MSR.\n+\n+For this reason, Cheng and Church may be useful to find shift-pattern\n+biclusters. It may instead find scale-pattern biclusters after\n+applying a log transformation to the data, which converts\n+multiplicative scaling into additive scaling. In other words, if","path":"doc/modules/biclustering.rst","position":58,"original_position":58,"commit_id":"0f666af27ac49f5e42594a63699d753669e9bc21","original_commit_id":"498f6d028e8862b7050de3a521d8ff4880869e88","user":{"login":"kemaleren","id":694043,"avatar_url":"https://1.gravatar.com/avatar/67f82df9575be2838c5535282a2626e0?d=https%3A%2F%2Fidenticons.github.com%2Fbd240f4f2f29965be5c92ef04441a026.png","gravatar_id":"67f82df9575be2838c5535282a2626e0","url":"https://api.github.com/users/kemaleren","html_url":"https://github.com/kemaleren","followers_url":"https://api.github.com/users/kemaleren/followers","following_url":"https://api.github.com/users/kemaleren/following{/other_user}","gists_url":"https://api.github.com/users/kemaleren/gists{/gist_id}","starred_url":"https://api.github.com/users/kemaleren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kemaleren/subscriptions","organizations_url":"https://api.github.com/users/kemaleren/orgs","repos_url":"https://api.github.com/users/kemaleren/repos","events_url":"https://api.github.com/users/kemaleren/events{/privacy}","received_events_url":"https://api.github.com/users/kemaleren/received_events","type":"User"},"created_at":"2013-08-29T18:01:14Z","updated_at":"2013-08-29T18:01:14Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/2172#discussion_r6068254","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/2172","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/6068254"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/2172#discussion_r6068254"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/2172"}}}}

{"repository":{"description":"scikit-learn: machine learning in Python","homepage":"http://scikit-learn.org","watchers":1598,"stargazers":1598,"forks":824,"fork":false,"size":71002,"owner":"scikit-learn","private":false,"open_issues":373,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2010-08-17T02:43:38-07:00","pushed_at":"2013-08-28T09:23:18-07:00","integrate_branch":"gael","master_branch":"master","organization":"scikit-learn"},"actor_attributes":{"type":"User","name":"Kemal Eren","company":"","blog":"kemaleren.com","location":"","email":"[email protected]"},"url":"https://github.com/scikit-learn/scikit-learn/pull/2172#discussion_r6068254"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/4376466","id":4376466,"body":"Same here, I think you can use `copy=False`.","diff_hunk":"@@ -168,16 +169,15 @@ def predict_proba(self, X):\n if weights is None:\n weights = np.ones_like(pred_labels)\n \n- probabilities = np.zeros((X.shape[0], self.classes_.size))\n+ votes = np.zeros((X.shape[0], self.classes_.size))\n \n # a simple ':' index doesn't work right\n all_rows = np.arange(X.shape[0])\n \n for i, idx in enumerate(pred_labels.T): # loop is O(n_neighbors)\n- probabilities[all_rows, idx] += weights[:, i]\n+ votes[all_rows, idx] += weights[:, i]\n \n- # normalize 'votes' into real [0,1] probabilities\n- probabilities = (probabilities.T / probabilities.sum(axis=1)).T\n+ probabilities = normalize_proba(votes, copy=True)","path":"sklearn/neighbors/classification.py","position":24,"original_position":24,"commit_id":"71f231196f9e3a9d2fdbdf43c02f8ac1c4cdaf6e","original_commit_id":"71f231196f9e3a9d2fdbdf43c02f8ac1c4cdaf6e","user":{"login":"glouppe","id":477771,"avatar_url":"https://secure.gravatar.com/avatar/ce5c9f91125ac19e79cc826a13e5dc1e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"ce5c9f91125ac19e79cc826a13e5dc1e","url":"https://api.github.com/users/glouppe","html_url":"https://github.com/glouppe","followers_url":"https://api.github.com/users/glouppe/followers","following_url":"https://api.github.com/users/glouppe/following{/other_user}","gists_url":"https://api.github.com/users/glouppe/gists{/gist_id}","starred_url":"https://api.github.com/users/glouppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glouppe/subscriptions","organizations_url":"https://api.github.com/users/glouppe/orgs","repos_url":"https://api.github.com/users/glouppe/repos","events_url":"https://api.github.com/users/glouppe/events{/privacy}","received_events_url":"https://api.github.com/users/glouppe/received_events","type":"User"},"created_at":"2013-05-24T07:03:27Z","updated_at":"2013-05-24T07:03:27Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/1878#discussion_r4376466","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/1878","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/4376466"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/1878#discussion_r4376466"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/1878"}}}}

{"repository":{"description":"scikit-learn: machine learning in Python","homepage":"http://scikit-learn.org","watchers":1266,"stargazers":1266,"forks":648,"fork":false,"size":10053,"owner":"scikit-learn","private":false,"open_issues":334,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2010-08-17T02:43:38-07:00","pushed_at":"2013-05-23T23:50:13-07:00","integrate_branch":"gael","master_branch":"master","organization":"scikit-learn"},"actor_attributes":{"type":"User","name":"Gilles Louppe","blog":"http://www.montefiore.ulg.ac.be/~glouppe","location":"Liège, Belgium","email":"[email protected]"},"url":"https://github.com/scikit-learn/scikit-learn/pull/1878#discussion_r4376466"}

PullRequestReviewCommentEvent

{"comment":{"commit_id":"07e6834ff0a102be7594c41e466c69eb7d3b4a59","original_position":9,"position":null,"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/2869602"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/522"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/522#discussion_r2869602"}},"user":{"subscriptions_url":"https://api.github.com/users/amueller/subscriptions","login":"amueller","received_events_url":"https://api.github.com/users/amueller/received_events","type":"User","avatar_url":"https://secure.gravatar.com/avatar/8ffe68e4b19092aab184e4aa09ca4bff?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","starred_url":"https://api.github.com/users/amueller/starred{/owner}{/repo}","followers_url":"https://api.github.com/users/amueller/followers","url":"https://api.github.com/users/amueller","events_url":"https://api.github.com/users/amueller/events{/privacy}","organizations_url":"https://api.github.com/users/amueller/orgs","repos_url":"https://api.github.com/users/amueller/repos","id":449558,"following_url":"https://api.github.com/users/amueller/following","gravatar_id":"8ffe68e4b19092aab184e4aa09ca4bff","gists_url":"https://api.github.com/users/amueller/gists{/gist_id}"},"body":"On 02/02/2013 08:55 PM, Noel Dawe wrote:\n>\n> In examples/ensemble/plot_adaboost_twoclass.py:\n>\n> > @@ -0,0 +1,100 @@\n> > +\"\"\"\n> > +==================\n> > +Two-class AdaBoost\n> > +==================\n> > +\n> > +This example fits an AdaBoosted decision stump on a non-linearly separable\n> > +classification dataset composed of two \"Gaussian quantiles\" clusters\n> > +(see :func:`sklearn.datasets.make_gaussian_quantiles`) and plots the decision\n> > +boundary, class probabilities, and two-class decision scores.\n>\n> You're right. Showing both the class B probabilities and decision \n> score is redundant. The example now only shows the decision boundary \n> and scores.\n>\n>\nCould you please also add a sentence on what one can see from this plot?\nI am not sure I understand it.","path":"examples/ensemble/plot_adaboost_twoclass.py","updated_at":"2013-02-02T20:32:10Z","original_commit_id":"e7ad4fd12056d6a2be06b8ddf0daf234d9af52fa","url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/2869602","id":2869602,"created_at":"2013-02-02T20:32:10Z"}}

{"repository":{"open_issues":270,"owner":"scikit-learn","has_issues":true,"integrate_branch":"gael","homepage":"http://scikit-learn.org","watchers":985,"created_at":"2010-08-17T02:43:38-07:00","description":"scikit-learn: machine learning in Python","stargazers":985,"has_downloads":true,"organization":"scikit-learn","fork":false,"size":9069,"language":"C","pushed_at":"2013-02-02T08:24:11-08:00","forks":477,"private":false,"has_wiki":true},"actor_attributes":{"name":"Andreas Mueller","type":"User","location":"#scikit-learn","company":"University of Bonn","blog":"http://peekaboo-vision.blogspot.com/","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/scikit-learn/scikit-learn/pull/522#discussion_r2869602"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/4071309","id":4071309,"body":"Slight rendering problem here: ``:math:`i`th``\r\nYou either need a space after `:math:'i'` but this will give `i th` with the space in between.\r\nElse try a backslash `\\` after the `:math:'i'`\r\nCurrently it makes a \r\n\r\n\r\nHave a look if the backslash fixes the problem :)","diff_hunk":"@@ -297,6 +297,14 @@ misclassification error (Zero-one loss) as shown in the Figure below.\n :align: center\n :scale: 75\n \n+The x-axis is a difference measure between an observed :math:`y_i` and a modeled :math:`f(x_i)`.\n+For example, if :math:`y_i = 1` and :math:`f(x_i) = 1`, then the :math:`i`th observation","path":"doc/modules/sgd.rst","position":5,"original_position":5,"commit_id":"2638f6a6112232a0846d31b437015c4f58552e5c","original_commit_id":"2638f6a6112232a0846d31b437015c4f58552e5c","user":{"login":"jaquesgrobler","id":1378870,"avatar_url":"https://secure.gravatar.com/avatar/9986b6dcf7da93f80edd7050f38196c1?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"9986b6dcf7da93f80edd7050f38196c1","url":"https://api.github.com/users/jaquesgrobler","html_url":"https://github.com/jaquesgrobler","followers_url":"https://api.github.com/users/jaquesgrobler/followers","following_url":"https://api.github.com/users/jaquesgrobler/following","gists_url":"https://api.github.com/users/jaquesgrobler/gists{/gist_id}","starred_url":"https://api.github.com/users/jaquesgrobler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaquesgrobler/subscriptions","organizations_url":"https://api.github.com/users/jaquesgrobler/orgs","repos_url":"https://api.github.com/users/jaquesgrobler/repos","events_url":"https://api.github.com/users/jaquesgrobler/events{/privacy}","received_events_url":"https://api.github.com/users/jaquesgrobler/received_events","type":"User"},"created_at":"2013-05-03T09:51:56Z","updated_at":"2013-05-03T09:51:56Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/1919#discussion_r4071309","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/1919","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/4071309"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/1919#discussion_r4071309"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/1919"}}}}

{"repository":{"description":"scikit-learn: machine learning in Python","homepage":"http://scikit-learn.org","watchers":1215,"stargazers":1215,"forks":622,"fork":false,"size":9721,"owner":"scikit-learn","private":false,"open_issues":317,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2010-08-17T02:43:38-07:00","pushed_at":"2013-05-02T07:00:43-07:00","integrate_branch":"gael","master_branch":"master","organization":"scikit-learn"},"actor_attributes":{"type":"User","name":"Jaques Grobler","company":"INRIA","blog":"https://github.com/jaquesgrobler/scikit-learn/wiki/Jaques-Grobler","location":"Paris, France","email":"[email protected]"},"url":"https://github.com/scikit-learn/scikit-learn/pull/1919#discussion_r4071309"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/3189017","id":3189017,"body":"Aboute the speed there is the webscale kmeans paper: http://www.eecs.tufts.edu/~dsculley/papers/fastkmeans.pdf","diff_hunk":"@@ -182,12 +182,28 @@ Mini Batch K-Means\n ------------------\n \n The :class:`MiniBatchKMeans` is a variant of the :class:`KMeans` algorithm\n-using mini-batches, random subset of the dataset, to compute the centroids.\n-\n-Although the :class:`MiniBatchKMeans` converge faster than the KMeans\n-version, the quality of the results, measured by the inertia, the sum of\n-the distance of each points to the nearest centroid, is not as good as\n-the :class:`KMeans` algorithm.\n+which uses mini-batches to reduce the computation time. Mini-batches are\n+randomly chosen subsets of data, which are recomputed in each training\n+iteration. These mini-batches drastically reduce the amount of computation\n+required to converge to a local solution. In contrast to other algorithms\n+that reduce the convergence time of k-means, mini-batch k-means produces\n+results that are generally only slightly worse than the standard algorithm.\n+\n+The algorithm iterates between two major steps, similar to vanilla k-means.\n+In the first step, `b` samples are drawn randomly from the dataset, to form\n+a mini-batch. These are then assigned to the nearest centroid. In the second\n+step, the centroids are updated. In contrast to k-means, this is done on a\n+per-sample basis. For each sample in the mini-batch, the assigned centroid\n+is updated by taking a gradient step based on the sample and the previous\n+centroid. The learning rate for this updating reduces over time. These steps\n+are performed until convergence or a predetermined number of iterations is\n+reached.\n+\n+This algorithm attempts to reduce the same objective function as the k-means\n+algorithm. Although :class:`MiniBatchKMeans` converges faster than\n+:class:`KMeans` versions, the results are generally of a slightly poorer","path":"doc/modules/clustering.rst","position":29,"original_position":29,"commit_id":"5d2cba06ced87bf5f06d3cfaee84c2fecc62ed24","original_commit_id":"5d2cba06ced87bf5f06d3cfaee84c2fecc62ed24","user":{"login":"ogrisel","id":89061,"avatar_url":"https://secure.gravatar.com/avatar/aee56554ec30edfd680e1c937ed4e54d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"aee56554ec30edfd680e1c937ed4e54d","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User"},"created_at":"2013-02-28T14:20:25Z","updated_at":"2013-02-28T14:20:25Z","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/3189017"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/1718#discussion_r3189017"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/1718"}}}}

{"repository":{"description":"scikit-learn: machine learning in Python","homepage":"http://scikit-learn.org","watchers":1041,"stargazers":1041,"forks":514,"fork":false,"size":9353,"owner":"scikit-learn","private":false,"open_issues":275,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2010-08-17T02:43:38-07:00","pushed_at":"2013-02-26T16:00:37-08:00","integrate_branch":"gael","master_branch":"master","organization":"scikit-learn"},"actor_attributes":{"type":"User","name":"Olivier Grisel","blog":"http://twitter.com/ogrisel","location":"Paris, France","email":"[email protected]"},"url":"https://github.com/scikit-learn/scikit-learn/pull/1718#discussion_r3189017"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/5341600","id":5341600,"body":"doesn't really give any benefit here, right?","diff_hunk":"@@ -0,0 +1,105 @@\n+\"\"\"\n+===============================\n+Gradient Boosting OOB estimates\n+===============================\n+\n+Out-of-bag estimates can be used to estimate the \"optimal\" number of\n+boosting iterations. To compute OOB estimates the ``subsample``\n+argument has to be smaller than 1.\n+The argument ``oob_improvement_[i]`` holds the improvement in loss for the i-th\n+iteration.\n+\n+The generated plot shows the cumulative sum of the negative OOB improvements\n+as a function of the boosting iteration. This function should track the\n+loss on the test set.\n+\"\"\"\n+print(__doc__)\n+\n+# Author: Peter Prettenhofer <[email protected]>\n+#\n+# License: BSD 3 clause\n+\n+import numpy as np\n+import pylab as pl\n+\n+from sklearn import ensemble\n+from sklearn.cross_validation import KFold\n+\n+###############################################################################\n+# Generate data (adapted from G. Ridgeway's gbm example)\n+\n+n = 1000\n+rs = np.random.RandomState(13)","path":"examples/ensemble/plot_gradient_boosting_oob.py","position":34,"original_position":32,"commit_id":"e6c9e2a4af8783e577f23c66a43d513766fdd4cf","original_commit_id":"69b8652ca67a885517d15b23e84d4759c87c69c0","user":{"login":"amueller","id":449558,"avatar_url":"https://secure.gravatar.com/avatar/8ffe68e4b19092aab184e4aa09ca4bff?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"8ffe68e4b19092aab184e4aa09ca4bff","url":"https://api.github.com/users/amueller","html_url":"https://github.com/amueller","followers_url":"https://api.github.com/users/amueller/followers","following_url":"https://api.github.com/users/amueller/following{/other_user}","gists_url":"https://api.github.com/users/amueller/gists{/gist_id}","starred_url":"https://api.github.com/users/amueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amueller/subscriptions","organizations_url":"https://api.github.com/users/amueller/orgs","repos_url":"https://api.github.com/users/amueller/repos","events_url":"https://api.github.com/users/amueller/events{/privacy}","received_events_url":"https://api.github.com/users/amueller/received_events","type":"User"},"created_at":"2013-07-23T10:35:24Z","updated_at":"2013-07-23T10:35:24Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/2188#discussion_r5341600","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/2188","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/5341600"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/2188#discussion_r5341600"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/2188"}}}}

{"repository":{"description":"scikit-learn: machine learning in Python","homepage":"http://scikit-learn.org","watchers":1467,"stargazers":1467,"forks":746,"fork":false,"size":54536,"owner":"scikit-learn","private":false,"open_issues":391,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2010-08-17T02:43:38-07:00","pushed_at":"2013-07-22T08:59:37-07:00","integrate_branch":"gael","master_branch":"master","organization":"scikit-learn"},"actor_attributes":{"type":"User","name":"Andreas Mueller","company":"University of Bonn","blog":"http://peekaboo-vision.blogspot.com/","location":"#scikit-learn","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/scikit-learn/scikit-learn/pull/2188#discussion_r5341600"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/3847760","id":3847760,"body":"The only differences between this class and `LinearModel` seem to be the `ravel` and constraining the `X` validation a bit more. I don't understand why this case needs to be distinguished, what cases require `ravel`, or why this class cannot merely wrap `LinearModel` to make the minor differences more apparent. Or is it more to do with this being a `Mixin` and that an `ABC`?","diff_hunk":"@@ -166,6 +166,42 @@ def _set_intercept(self, X_mean, y_mean, X_std):\n self.intercept_ = 0.\n \n \n+class LinearRegressorMixin(RegressorMixin):\n+ \"\"\"Mixin for linear regressors.\n+\n+ Handles prediction for sparse and dense X.\n+ \"\"\"\n+ def decision_function(self,X):\n+ \"\"\"Predict using the linear model\n+\n+ Parameters\n+ ----------\n+ X : {array-like, sparse matrix}, shape = [n_samples, n_features]\n+\n+ Returns\n+ -------\n+ array, shape = [n_samples]\n+ Predicted target values per element in X.\n+ \"\"\"\n+ X = atleast2d_or_csr(X)\n+ scores = safe_sparse_dot(X, self.coef_.T, dense_output=True) + self.intercept_\n+ return scores.ravel()","path":"sklearn/linear_model/base.py","position":23,"original_position":23,"commit_id":"4e0297cb6b26dfdeb0d2a530f2a5aa1b68e8472e","original_commit_id":"e803f4155b8d93ee7ece7920ca5b3eb66b2d7806","user":{"login":"jnothman","id":78827,"avatar_url":"https://secure.gravatar.com/avatar/1a0a8c8019690e0debb7d75816e89dc5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"1a0a8c8019690e0debb7d75816e89dc5","url":"https://api.github.com/users/jnothman","html_url":"https://github.com/jnothman","followers_url":"https://api.github.com/users/jnothman/followers","following_url":"https://api.github.com/users/jnothman/following","gists_url":"https://api.github.com/users/jnothman/gists{/gist_id}","starred_url":"https://api.github.com/users/jnothman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnothman/subscriptions","organizations_url":"https://api.github.com/users/jnothman/orgs","repos_url":"https://api.github.com/users/jnothman/repos","events_url":"https://api.github.com/users/jnothman/events{/privacy}","received_events_url":"https://api.github.com/users/jnothman/received_events","type":"User"},"created_at":"2013-04-18T06:51:29Z","updated_at":"2013-04-18T06:51:29Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/1867#discussion_r3847760","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/1867","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/3847760"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/1867#discussion_r3847760"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/1867"}}}}

{"repository":{"description":"scikit-learn: machine learning in Python","homepage":"http://scikit-learn.org","watchers":1167,"stargazers":1167,"forks":599,"fork":false,"size":9693,"owner":"scikit-learn","private":false,"open_issues":298,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2010-08-17T02:43:38-07:00","pushed_at":"2013-04-17T07:35:18-07:00","integrate_branch":"gael","master_branch":"master","organization":"scikit-learn"},"actor_attributes":{"type":"User","blog":"http://www.joelnothman.com","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/scikit-learn/scikit-learn/pull/1867#discussion_r3847760"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments/7984228","id":7984228,"diff_hunk":"@@ -74,6 +74,7 @@ HttpStatusCode mapPostIndividualContextEntityAttributes(std::string entityId, Ap\n ContextAttribute* caP = new ContextAttribute(ucContextElementResponse->contextElement.contextAttributeVector.get(caIx));\n \n car->contextAttributeVector.push_back(caP);\n+ car->statusCode.fill(&ucContextElementResponse->statusCode);","path":"src/lib/convenienceMap/mapPostIndividualContextEntityAttributes.cpp","position":null,"original_position":4,"commit_id":"3ec3786342047231a441cf96e93ea7ce6aa084dd","original_commit_id":"729755bd682ba14af440f7fd8bbfabecfbeb2c48","user":{"login":"fgalan","id":1534240,"avatar_url":"https://0.gravatar.com/avatar/1936b0d16210811a2aa8de96295f0693?d=https%3A%2F%2Fidenticons.github.com%2F85e6a070e15f4ef503f07baf6d6ddba1.png&r=x","gravatar_id":"1936b0d16210811a2aa8de96295f0693","url":"https://api.github.com/users/fgalan","html_url":"https://github.com/fgalan","followers_url":"https://api.github.com/users/fgalan/followers","following_url":"https://api.github.com/users/fgalan/following{/other_user}","gists_url":"https://api.github.com/users/fgalan/gists{/gist_id}","starred_url":"https://api.github.com/users/fgalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgalan/subscriptions","organizations_url":"https://api.github.com/users/fgalan/orgs","repos_url":"https://api.github.com/users/fgalan/repos","events_url":"https://api.github.com/users/fgalan/events{/privacy}","received_events_url":"https://api.github.com/users/fgalan/received_events","type":"User","site_admin":false},"body":"Fixed in 3ec3786","created_at":"2013-11-28T12:59:59Z","updated_at":"2013-11-28T12:59:59Z","html_url":"https://github.com/telefonicaid/fiware-orion/pull/125#discussion_r7984228","pull_request_url":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/125","_links":{"self":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/comments/7984228"},"html":{"href":"https://github.com/telefonicaid/fiware-orion/pull/125#discussion_r7984228"},"pull_request":{"href":"https://api.github.com/repos/telefonicaid/fiware-orion/pulls/125"}}}}

{"repository":{"description":"FI-WARE Orion Context Broker","homepage":"http://catalogue.fi-ware.eu/enablers/publishsubscribe-context-broker-orion-context-broker","watchers":2,"stargazers":2,"forks":0,"fork":false,"size":2752,"owner":"telefonicaid","private":false,"open_issues":56,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2013-09-13T04:55:25-07:00","pushed_at":"2013-11-28T04:59:47-08:00","master_branch":"develop","organization":"telefonicaid"},"actor_attributes":{"type":"User","name":"Fermín Galán Márquez","company":"Telefónica I+D","location":"Madrid, Spain","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/telefonicaid/fiware-orion/pull/125#discussion_r7984228"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/topazproject/topaz/pulls/comments/3039851","id":3039851,"body":"```ruby\r\nirb(main):004:0> a\r\n=> [\"hallo\", [...]]\r\nirb(main):005:0> File.join a\r\nArgumentError: recursive array\r\n from (irb):5:in `join'\r\n from (irb):5\r\n from /usr/bin/irb:12:in `<main>'\r\n```","path":"topaz/objects/fileobject.py","position":5,"original_position":5,"commit_id":"621b46b7be3abc8318ef30c0396617a9dd822722","original_commit_id":"621b46b7be3abc8318ef30c0396617a9dd822722","user":{"login":"timfel","id":46235,"avatar_url":"https://secure.gravatar.com/avatar/36fee2e65c9c0ed678fe3b7d862ed271?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"36fee2e65c9c0ed678fe3b7d862ed271","url":"https://api.github.com/users/timfel","followers_url":"https://api.github.com/users/timfel/followers","following_url":"https://api.github.com/users/timfel/following","gists_url":"https://api.github.com/users/timfel/gists{/gist_id}","starred_url":"https://api.github.com/users/timfel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timfel/subscriptions","organizations_url":"https://api.github.com/users/timfel/orgs","repos_url":"https://api.github.com/users/timfel/repos","events_url":"https://api.github.com/users/timfel/events{/privacy}","received_events_url":"https://api.github.com/users/timfel/received_events","type":"User"},"created_at":"2013-02-16T18:14:41Z","updated_at":"2013-02-16T18:14:41Z","_links":{"self":{"href":"https://api.github.com/repos/topazproject/topaz/pulls/comments/3039851"},"html":{"href":"https://github.com/topazproject/topaz/pull/382#discussion_r3039851"},"pull_request":{"href":"https://api.github.com/repos/topazproject/topaz/pulls/382"}}}}

{"repository":{"description":"A high performance ruby, written in RPython","homepage":"topazruby.com","watchers":576,"stargazers":576,"forks":37,"fork":false,"size":2932,"owner":"topazproject","private":false,"open_issues":38,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-04-08T11:34:50-07:00","pushed_at":"2013-02-16T08:24:57-08:00","master_branch":"master","organization":"topazproject"},"actor_attributes":{"name":"Tim Felgentreff","location":"Potsdam, Germany","email":"[email protected]","type":"User"},"url":"https://github.com/topazproject/topaz/pull/382#discussion_r3039851"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/ANamelessBand/Liberta/pulls/comments/8019772","id":8019772,"diff_hunk":"@@ -1,91 +1,126 @@\n-class WebsiteController < ApplicationController\n- NAMESPACE = '/'\n-\n- before do\n- set_active_navigation_link(NavigationLink.news_id)\n- end\n-\n- not_found do\n- @title = \"404: Droid not found\"\n- erb :'not_found.html'\n- end\n-\n- get /(^\\/$|^\\/news$)/ do\n- @title = \"Libertà\"\n-\n- @last_five_news = News.all.reverse.take(5)\n- @last_added = Print.all.sort{ |x, y| y.date_added <=> x.date_added }.take(5)\n-\n- erb :'index.html'\n- end\n-\n- get '/login' do\n- @title = \"Вход\"\n- erb :'login.html'\n- end\n-\n- post '/login' do\n- username = params[:username]\n- password = params[:password]\n-\n- @user = User.find(username: username)\n- redirect '/login' if @user.nil?\n-\n- # Auth logic here, currently we skip it\n- session[:user] = @user.id\n- redirect '/'\n- end\n-\n- get '/logout' do\n- session[:user] = nil\n- redirect '/'\n- end\n-\n- get '/notification/:id' do\n- @notification = Notification.find(id: params[:id])\n- @notification.is_read = true\n- @notification.save\n-\n- @title = \"Грешка\"\n- erb \"You should not be here. Please go home\"\n- end\n-\n- def set_data(clas, id)\n- @contributor = clas.find id: id\n- @title = @contributor.name\n- end\n-\n- get '/authors/:id/all' do\n- @breadcrumbs << NavigationLink.new(0, \"/authors/#{params[:id]}\", \"Автор\")\n- @breadcrumbs << NavigationLink.new(0, \"/authors/#{params[:id]}/all\", \"Всички публикации\")\n- set_data Author, params[:id]\n- erb :'contributor_all.html'\n- end\n-\n- get '/authors/:id' do\n- @breadcrumbs << NavigationLink.new(0, \"/authors/#{params[:id]}\", \"Автор\")\n- set_data Author, params[:id]\n- erb :'contributor.html'\n- end\n-\n- get '/publishers/:id/all' do\n- @breadcrumbs << NavigationLink.new(0, \"/publishers/#{params[:id]}\", \"Издател\")\n- @breadcrumbs << NavigationLink.new(0, \"/publishers/#{params[:id]}/all\", \"Всички публикации\")\n- set_data Publisher, params[:id]\n- erb :'contributor_all.html'\n- end\n-\n- get '/publishers/:id' do\n- @breadcrumbs << NavigationLink.new(0, \"/publishers/#{params[:id]}/all\", \"Издател\")\n- set_data Publisher, params[:id]\n- erb :'contributor.html'\n- end\n-\n- post '/add-news' do\n- title = params[:news_title]\n- content = params[:news_content]\n- date = Date.today\n- News.create title: title, content: content, date_of_publication: date\n- redirect '/'\n+module Liberta\n+ class WebsiteController < ApplicationController\n+ NAMESPACE = '/'\n+\n+ helpers WebsiteHelpers\n+\n+ before do\n+ set_active_navigation_link NavigationLink.news_id\n+ end\n+\n+ not_found do\n+ @title = '404: Droid not found'\n+ erb :'not_found.html'\n+ end\n+\n+ get %r{/$|/news$} do","path":"controllers/website_controller.rb","position":105,"original_position":105,"commit_id":"9079f80b661d2f834d2ca1a2bd404e5bcf3f7f71","original_commit_id":"9079f80b661d2f834d2ca1a2bd404e5bcf3f7f71","user":{"login":"GeorgeSG","id":2514425,"avatar_url":"https://1.gravatar.com/avatar/7a73fe0f654aac671c847d1e771f2039?d=https%3A%2F%2Fidenticons.github.com%2Fa506cf55b3dc1cdb6e52f6328973bc78.png&r=x","gravatar_id":"7a73fe0f654aac671c847d1e771f2039","url":"https://api.github.com/users/GeorgeSG","html_url":"https://github.com/GeorgeSG","followers_url":"https://api.github.com/users/GeorgeSG/followers","following_url":"https://api.github.com/users/GeorgeSG/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeSG/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeSG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeSG/subscriptions","organizations_url":"https://api.github.com/users/GeorgeSG/orgs","repos_url":"https://api.github.com/users/GeorgeSG/repos","events_url":"https://api.github.com/users/GeorgeSG/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeSG/received_events","type":"User","site_admin":false},"body":"Uhmm what happened here :D can't we do\r\n[NAMESPACE, '/news'].each do |page|\r\n get page do...","created_at":"2013-12-02T08:49:44Z","updated_at":"2013-12-02T08:49:44Z","html_url":"https://github.com/ANamelessBand/Liberta/pull/31#discussion_r8019772","pull_request_url":"https://api.github.com/repos/ANamelessBand/Liberta/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/ANamelessBand/Liberta/pulls/comments/8019772"},"html":{"href":"https://github.com/ANamelessBand/Liberta/pull/31#discussion_r8019772"},"pull_request":{"href":"https://api.github.com/repos/ANamelessBand/Liberta/pulls/31"}}}}

{"repository":{"description":"Liberta - A website for managing small to medium-sized libraries. Started thanks to HackFMI","homepage":"","watchers":2,"stargazers":2,"forks":0,"fork":false,"size":2248,"owner":"ANamelessBand","private":false,"open_issues":20,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"CSS","created_at":"2013-10-25T09:43:08-07:00","pushed_at":"2013-12-01T15:30:16-08:00","master_branch":"master","organization":"ANamelessBand"},"actor_attributes":{"type":"User","name":"Georgi Gardev","blog":"http://gardev.com","email":"[email protected]"},"url":"https://github.com/ANamelessBand/Liberta/pull/31#discussion_r8019772"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/FriendsOfCake/crud/pulls/comments/6175151","id":6175151,"body":"Meh.\r\n\r\nThere is a \"official\" way of doing it [apparently](http://stackoverflow.com/a/13441390/2564943), but I rather leave it out for the same reason the SO answer has.","diff_hunk":"@@ -286,11 +286,11 @@ public function setFlash($type) {\n *\n * If no reliable detection can be made, no validation will be made\n *\n- * @param NULL|Model $model\n+ * @param Model $model","path":"Controller/Crud/CrudAction.php","position":32,"original_position":32,"commit_id":"03941b6b8d6ea63742149b8d8f5502eddc7ad796","original_commit_id":"03941b6b8d6ea63742149b8d8f5502eddc7ad796","user":{"login":"Phally","id":112639,"avatar_url":"https://1.gravatar.com/avatar/46cc8d2c215ae1ff7c3aed3fe32129cb?d=https%3A%2F%2Fidenticons.github.com%2F58fff7f4b597735aa2b4ab51ac868a1b.png","gravatar_id":"46cc8d2c215ae1ff7c3aed3fe32129cb","url":"https://api.github.com/users/Phally","html_url":"https://github.com/Phally","followers_url":"https://api.github.com/users/Phally/followers","following_url":"https://api.github.com/users/Phally/following{/other_user}","gists_url":"https://api.github.com/users/Phally/gists{/gist_id}","starred_url":"https://api.github.com/users/Phally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phally/subscriptions","organizations_url":"https://api.github.com/users/Phally/orgs","repos_url":"https://api.github.com/users/Phally/repos","events_url":"https://api.github.com/users/Phally/events{/privacy}","received_events_url":"https://api.github.com/users/Phally/received_events","type":"User"},"created_at":"2013-09-05T07:18:37Z","updated_at":"2013-09-05T07:18:37Z","html_url":"https://github.com/FriendsOfCake/crud/pull/100#discussion_r6175151","pull_request_url":"https://api.github.com/repos/FriendsOfCake/crud/pulls/100","_links":{"self":{"href":"https://api.github.com/repos/FriendsOfCake/crud/pulls/comments/6175151"},"html":{"href":"https://github.com/FriendsOfCake/crud/pull/100#discussion_r6175151"},"pull_request":{"href":"https://api.github.com/repos/FriendsOfCake/crud/pulls/100"}}}}

{"repository":{"description":"CakePHP Application development on steroids - rapid prototyping / scaffolding & production ready code - XML / JSON APIs and more","homepage":"http://FriendsOfCake.com/crud","watchers":41,"stargazers":41,"forks":12,"fork":false,"size":1984,"owner":"FriendsOfCake","private":false,"open_issues":5,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"PHP","created_at":"2013-06-05T01:21:11-07:00","pushed_at":"2013-09-04T17:34:06-07:00","master_branch":"develop","organization":"FriendsOfCake"},"actor_attributes":{"type":"User","name":"Frank de Graaf","company":"FdeG","blog":"http://www.phally.com","location":"Netherlands","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/FriendsOfCake/crud/pull/100#discussion_r6175151"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/LaunchAcademy/gitrelay/pulls/comments/7893846","id":7893846,"diff_hunk":"@@ -2,18 +2,19 @@ Fun Fact: The number 28 is the sum of its divisors. << MASTERKEVIN WAS HERE.\n \n poop\n \n-░░░░░▄▄▄▄▀▀▀▀▀▀▀▀▄▄▄▄▄▄░░░░░░░ \n-░░░░░█░░░░▒▒▒▒▒▒▒▒▒▒▒▒░░▀▀▄░░░░ \n-░░░░█░░░▒▒▒▒▒▒░░░░░░░░▒▒▒░░█░░░ \n-░░░█░░░░░░▄██▀▄▄░░░░░▄▄▄░░░░█░░ \n-░▄▀▒▄▄▄▒░█▀▀▀▀▄▄█░░░██▄▄█░░░░█░ \n-█░▒█▒▄░▀▄▄▄▀░░░░░░░░█░░░▒▒▒▒▒░█ \n-█░▒█░█▀▄▄░░░░░█▀░░░░▀▄░░▄▀▀▀▄▒█ \n-░█░▀▄░█▄░█▀▄▄░▀░▀▀░▄▄▀░░░░█░░█░ \n-░░█░░░▀▄▀█▄▄░█▀▀▀▄▄▄▄▀▀█▀██░█░░ \n-░░░█░░░░██░░▀█▄▄▄█▄▄█▄████░█░░░ \n-░░░░█░░░░▀▀▄░█░░░█░█▀██████░█░░ \n-░░░░░▀▄░░░░░▀▀▄▄▄█▄█▄█▄█▄▀░░█░░ \n-░░░░░░░▀▄▄░▒▒▒▒░░░░░░░░░░▒░░░█░ \n-░░░░░░░░░░▀▀▄▄░▒▒▒▒▒▒▒▒▒▒░░░░█░ \n-░░░░░░░░░░░░░░▀▄▄▄▄▄░░░░░░░░█░░ \n\\ No newline at end of file\n+░░░░░▄▄▄▄▀▀▀▀▀▀▀▀▄▄▄▄▄▄░░░░░░░\n+░░░░░█░░░░▒▒▒▒▒▒▒▒▒▒▒▒░░▀▀▄░░░░\n+░░░░█░░░▒▒▒▒▒▒░░░░░░░░▒▒▒░░█░░░\n+░░░█░░░░░░▄██▀▄▄░░░░░▄▄▄░░░░█░░\n+░▄▀▒▄▄▄▒░█▀▀▀▀▄▄█░░░██▄▄█░░░░█░\n+█░▒█▒▄░▀▄▄▄▀░░░░░░░░█░░░▒▒▒▒▒░█\n+█░▒█░█▀▄▄░░░░░█▀░░░░▀▄░░▄▀▀▀▄▒█\n+░█░▀▄░█▄░█▀▄▄░▀░▀▀░▄▄▀░░░░█░░█░\n+░░█░░░▀▄▀█▄▄░█▀▀▀▄▄▄▄▀▀█▀██░█░░\n+░░░█░░░░██░░▀█▄▄▄█▄▄█▄████░█░░░\n+░░░░█░░░░▀▀▄░█░░░█░█▀██████░█░░","path":"alnoor.txt","position":30,"original_position":30,"commit_id":"469b0d6c5ba0950b924a59cca47975e60631b122","original_commit_id":"469b0d6c5ba0950b924a59cca47975e60631b122","user":{"login":"jzgit","id":401557,"avatar_url":"https://0.gravatar.com/avatar/7df56f12b3e83c0564cccf1ff2227dc2?d=https%3A%2F%2Fidenticons.github.com%2Fa7dd7d27da94021926beb84a2851a2a4.png&r=x","gravatar_id":"7df56f12b3e83c0564cccf1ff2227dc2","url":"https://api.github.com/users/jzgit","html_url":"https://github.com/jzgit","followers_url":"https://api.github.com/users/jzgit/followers","following_url":"https://api.github.com/users/jzgit/following{/other_user}","gists_url":"https://api.github.com/users/jzgit/gists{/gist_id}","starred_url":"https://api.github.com/users/jzgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzgit/subscriptions","organizations_url":"https://api.github.com/users/jzgit/orgs","repos_url":"https://api.github.com/users/jzgit/repos","events_url":"https://api.github.com/users/jzgit/events{/privacy}","received_events_url":"https://api.github.com/users/jzgit/received_events","type":"User","site_admin":false},"body":"inline code\r\n\r\n```ruby\r\n def no!\r\n puts \"NO!\"\r\n end\r\n````","created_at":"2013-11-25T15:41:32Z","updated_at":"2013-11-25T15:41:32Z","html_url":"https://github.com/LaunchAcademy/gitrelay/pull/1#discussion_r7893846","pull_request_url":"https://api.github.com/repos/LaunchAcademy/gitrelay/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/LaunchAcademy/gitrelay/pulls/comments/7893846"},"html":{"href":"https://github.com/LaunchAcademy/gitrelay/pull/1#discussion_r7893846"},"pull_request":{"href":"https://api.github.com/repos/LaunchAcademy/gitrelay/pulls/1"}}}}

{"repository":{"description":"","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":140,"owner":"LaunchAcademy","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"created_at":"2013-11-25T06:37:29-08:00","pushed_at":"2013-11-25T07:37:42-08:00","master_branch":"master","organization":"LaunchAcademy"},"actor_attributes":{"type":"User","name":"Jason Zopf","company":"LaunchAcademy","location":"Boston","email":"[email protected]"},"url":"https://github.com/LaunchAcademy/gitrelay/pull/1#discussion_r7893846"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments/7533184","id":7533184,"diff_hunk":"@@ -212,7 +212,7 @@ - (id)initWithEnabled:(RACSignal *)enabledSignal signalBlock:(RACSignal * (^)(id\n \t\n \t_enabled = [[[[[self.immediateEnabled\n \t\tdeliverOn:RACScheduler.mainThreadScheduler]\n-\t\tstartWith:@YES]\n+\t\tstartWith:self.immediateEnabled.first]","path":"ReactiveCocoaFramework/ReactiveCocoa/RACCommand.m","position":5,"original_position":5,"commit_id":"472780a6db335f71ff79a7d302bcfc0cc22d2882","original_commit_id":"c56e780a194f32e9b1b4690a77434101ef2ab491","user":{"login":"jspahrsummers","id":432536,"avatar_url":"https://1.gravatar.com/avatar/cac992bb300ed4f3ed5c2a6049e552f9?d=https%3A%2F%2Fidenticons.github.com%2F109cfb1cc6c3edc0afdcf6a670eb0f33.png&r=x","gravatar_id":"cac992bb300ed4f3ed5c2a6049e552f9","url":"https://api.github.com/users/jspahrsummers","html_url":"https://github.com/jspahrsummers","followers_url":"https://api.github.com/users/jspahrsummers/followers","following_url":"https://api.github.com/users/jspahrsummers/following{/other_user}","gists_url":"https://api.github.com/users/jspahrsummers/gists{/gist_id}","starred_url":"https://api.github.com/users/jspahrsummers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspahrsummers/subscriptions","organizations_url":"https://api.github.com/users/jspahrsummers/orgs","repos_url":"https://api.github.com/users/jspahrsummers/repos","events_url":"https://api.github.com/users/jspahrsummers/events{/privacy}","received_events_url":"https://api.github.com/users/jspahrsummers/received_events","type":"User","site_admin":true},"body":"This is kinda gross to me. How about splitting `immediateEnabled` with `take:1` and `skip:1`, then only delivering the second to the main thread?","created_at":"2013-11-08T17:43:34Z","updated_at":"2013-11-08T17:43:34Z","html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/922#discussion_r7533184","pull_request_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/922","_links":{"self":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments/7533184"},"html":{"href":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/922#discussion_r7533184"},"pull_request":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/922"}}}}

{"repository":{"description":"A framework for composing and transforming streams of values","homepage":"","watchers":2657,"stargazers":2657,"forks":243,"fork":false,"size":15551,"owner":"ReactiveCocoa","private":false,"open_issues":32,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Objective-C","created_at":"2012-03-02T14:11:24-08:00","pushed_at":"2013-11-07T13:03:44-08:00","master_branch":"master","organization":"ReactiveCocoa"},"actor_attributes":{"type":"User","name":"Justin Spahr-Summers","company":"GitHub","blog":"jspahrsummers.github.com","location":"Seattle, WA","email":"[email protected]"},"url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/922#discussion_r7533184"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments/4505862","id":4505862,"body":"If the `[disposable addDisposable:]` call at the end of this method is moved above this check, this can be turned into an early return for readability.","diff_hunk":"@@ -226,54 +192,121 @@ - (void)didSubscribeWithDisposable:(RACDisposable *)disposable {\n \n #pragma mark API\n \n-+ (instancetype)propertyWithTarget:(id)target keyPath:(NSString *)keyPath {\n-\tRACObservablePropertySubject *property = [[self alloc] init];\n-\tif (property == nil) return nil;\n++ (instancetype)bindingWithTarget:(NSObject *)target keyPath:(NSString *)keyPath {\n+\tNSCParameterAssert(keyPath.rac_keyPathComponents.count > 0);\n+\tRACObservablePropertyBinding *binding = [[self alloc] init];\n+\tif (binding == nil || target == nil) return nil;\n \t\n-\tproperty->_target = target;\n-\tproperty->_keyPath = [keyPath copy];\n+\tbinding->_target = target;\n+\tbinding->_keyPath = [keyPath copy];\n \t\n-\t@weakify(property);\n-\n-\tproperty->_exposedSignal = [[RACSignal createSignal:^(id<RACSubscriber> subscriber) {\n-\t\t@strongify(property);\n-\t\t[subscriber sendNext:[property.target valueForKeyPath:keyPath]];\n-\t\treturn [[property.target rac_signalForKeyPath:property.keyPath observer:property] subscribe:subscriber];\n-\t}] setNameWithFormat:@\"+propertyWithTarget: %@ keyPath: %@\", [target rac_description], keyPath];\n-\n-\tproperty->_exposedSubscriber = [RACSubscriber subscriberWithNext:^(id x) {\n-\t\t@strongify(property);\n-\t\t[property.target setValue:x forKeyPath:property.keyPath];\n+\t@weakify(binding);\n+\t__block BOOL ignoreNextUpdate = NO;\n+\t__block NSUInteger stackDepth = 0;\n+\tRACSubject *updatesSubject = [RACSubject subject];\n+\t\n+\t[target rac_addObserver:binding forKeyPath:keyPath willBlock:^(BOOL triggeredByLastKeyPathComponent){\n+\t\tif (!triggeredByLastKeyPathComponent) return;\n+\t\t++stackDepth;\n+\t} didBlock:^(BOOL triggeredByLastKeyPathComponent, id value){\n+\t\tif (!triggeredByLastKeyPathComponent) {\n+\t\t\t[updatesSubject sendNext:value];\n+\t\t\treturn;\n+\t\t}\n+\t\tif (stackDepth > 0) --stackDepth;\n+\t\tif (stackDepth == 0 && ignoreNextUpdate) {\n+\t\t\tignoreNextUpdate = NO;\n+\t\t\treturn;\n+\t\t}\n+\t\t[updatesSubject sendNext:value];\n+\t}];\n+\t\n+\tbinding->_exposedSignal = [RACSignal createSignal:^(id<RACSubscriber> subscriber) {\n+\t\t@strongify(binding);\n+\t\t[subscriber sendNext:[binding.target valueForKeyPath:binding.keyPath]];\n+\t\treturn [updatesSubject subscribe:subscriber];\n+\t}];\n+\t\n+\tNSString *keyPathByDeletingLastKeyPathComponent = keyPath.rac_keyPathByDeletingLastKeyPathComponent;\n+\tNSString *lastKeyPathComponent = keyPath.rac_keyPathComponents.lastObject;\n+\t\n+\tbinding->_exposedSubscriber = [RACSubscriber subscriberWithNext:^(id x) {\n+\t\t@strongify(binding);\n+\t\tNSObject *object = (keyPath.rac_keyPathComponents.count > 1 ? [binding.target valueForKeyPath:keyPathByDeletingLastKeyPathComponent] : binding.target);\n+\t\tif (object == nil) return;\n+\t\tignoreNextUpdate = YES;\n+\t\t[object setValue:x forKey:lastKeyPathComponent];\n \t} error:^(NSError *error) {\n-\t\t@strongify(property);\n-\t\tNSCAssert(NO, @\"Received error in RACObservablePropertySubject for key path \\\"%@\\\" on %@: %@\", property.keyPath, property.target, error);\n+\t\t@strongify(binding);\n+\t\tNSCAssert(NO, @\"Received error in -[RACObservablePropertySubject binding] for key path \\\"%@\\\" on %@: %@\", binding.keyPath, binding.target, error);\n \t\t\n \t\t// Log the error if we're running with assertions disabled.\n-\t\tNSLog(@\"Received error in binding for key path \\\"%@\\\" on %@: %@\", property.keyPath, property.target, error);\n+\t\tNSLog(@\"Received error in -[RACObservablePropertySubject binding] for key path \\\"%@\\\" on %@: %@\", binding.keyPath, binding.target, error);\n \t} completed:nil];\n-\n+\t\n \t[target rac_addDeallocDisposable:[RACDisposable disposableWithBlock:^{\n-\t\t@strongify(property);\n-\t\tproperty.target = nil;\n+\t\t@strongify(binding);\n+\t\tbinding.target = nil;\n \t}]];\n \t\n-\treturn property;\n-}\n-\n-- (RACBinding *)binding {\n-\treturn [RACKVOBinding bindingWithTarget:self.target keyPath:self.keyPath];\n+\treturn binding;\n }\n \n @end\n \n-@implementation RACObservablePropertySubject (RACBind)\n-\n-- (id)objectForKeyedSubscript:(id)key {\n-\treturn [self valueForKey:key];\n-}\n+@implementation NSObject (RACObservablePropertyObserving)\n \n-- (void)setObject:(id)obj forKeyedSubscript:(id)key {\n-\t[[self valueForKey:key] bindTo:obj];\n+- (RACDisposable *)rac_addObserver:(NSObject *)observer forKeyPath:(NSString *)keyPath willBlock:(void (^)(BOOL))willBlock didBlock:(void (^)(BOOL, id))didBlock {\n+\tNSCParameterAssert(keyPath.rac_keyPathComponents.count > 0);\n+\tNSUInteger keyPathComponentsCount = keyPath.rac_keyPathComponents.count;\n+\tNSString *firstKeyPathComponent = keyPath.rac_keyPathComponents[0];\n+\tNSString *keyPathByDeletingFirstKeyPathComponent = keyPath.rac_keyPathByDeletingFirstKeyPathComponent;\n+\t\n+\t__unsafe_unretained NSObject *unsafeObserver = observer;\n+\tRACCompoundDisposable *disposable = [RACCompoundDisposable compoundDisposable];\n+\t__block RACCompoundDisposable *childDisposable = nil;\n+\t\n+\tRACKVOTrampoline *trampoline = [self rac_addObserver:observer forKeyPath:firstKeyPathComponent options:NSKeyValueObservingOptionPrior | NSKeyValueObservingOptionInitial | NSKeyValueObservingOptionNew block:^(id target, id observer, NSDictionary *change) {\n+\t\t\n+\t\tif (keyPathComponentsCount > 1) {","path":"ReactiveCocoaFramework/ReactiveCocoa/RACObservablePropertySubject.m","position":364,"original_position":364,"commit_id":"737d9672a2712c1545f940615e8c8ddd2faeacdb","original_commit_id":"737d9672a2712c1545f940615e8c8ddd2faeacdb","user":{"login":"jspahrsummers","id":432536,"avatar_url":"https://secure.gravatar.com/avatar/cac992bb300ed4f3ed5c2a6049e552f9?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"cac992bb300ed4f3ed5c2a6049e552f9","url":"https://api.github.com/users/jspahrsummers","html_url":"https://github.com/jspahrsummers","followers_url":"https://api.github.com/users/jspahrsummers/followers","following_url":"https://api.github.com/users/jspahrsummers/following{/other_user}","gists_url":"https://api.github.com/users/jspahrsummers/gists{/gist_id}","starred_url":"https://api.github.com/users/jspahrsummers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspahrsummers/subscriptions","organizations_url":"https://api.github.com/users/jspahrsummers/orgs","repos_url":"https://api.github.com/users/jspahrsummers/repos","events_url":"https://api.github.com/users/jspahrsummers/events{/privacy}","received_events_url":"https://api.github.com/users/jspahrsummers/received_events","type":"User"},"created_at":"2013-06-03T18:20:42Z","updated_at":"2013-06-03T18:20:42Z","html_url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/519#discussion_r4505862","pull_request_url":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/519","_links":{"self":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/comments/4505862"},"html":{"href":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/519#discussion_r4505862"},"pull_request":{"href":"https://api.github.com/repos/ReactiveCocoa/ReactiveCocoa/pulls/519"}}}}

{"repository":{"description":"A framework for composing and transforming streams of values","homepage":"","watchers":1678,"stargazers":1678,"forks":147,"fork":false,"size":1912,"owner":"ReactiveCocoa","private":false,"open_issues":37,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Objective-C","created_at":"2012-03-02T14:11:24-08:00","pushed_at":"2013-06-03T11:15:44-07:00","master_branch":"2.0-development","organization":"ReactiveCocoa"},"actor_attributes":{"type":"User","name":"Justin Spahr-Summers","company":"GitHub","blog":"jspahrsummers.github.com","location":"Seattle, WA","email":"[email protected]"},"url":"https://github.com/ReactiveCocoa/ReactiveCocoa/pull/519#discussion_r4505862"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/SimpleFinance/chef-polyglot/pulls/comments/5476597","id":5476597,"body":";)","diff_hunk":"@@ -1,6 +1,8 @@\n #!/usr/bin/env ruby\n site 'http://community.opscode.com/api/v1'\n \n+cookbook 'golang',\n+ :git => '[email protected]:SimpleFinance/chef-golang.git'","path":"Cheffile","position":5,"original_position":5,"commit_id":"5841e7fe6c32b2dff6b2d84ce6dd041855725c91","original_commit_id":"5841e7fe6c32b2dff6b2d84ce6dd041855725c91","user":{"login":"whilp","id":189851,"avatar_url":"https://secure.gravatar.com/avatar/69a97644bbdc536d2d0982598c98adc6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"69a97644bbdc536d2d0982598c98adc6","url":"https://api.github.com/users/whilp","html_url":"https://github.com/whilp","followers_url":"https://api.github.com/users/whilp/followers","following_url":"https://api.github.com/users/whilp/following{/other_user}","gists_url":"https://api.github.com/users/whilp/gists{/gist_id}","starred_url":"https://api.github.com/users/whilp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whilp/subscriptions","organizations_url":"https://api.github.com/users/whilp/orgs","repos_url":"https://api.github.com/users/whilp/repos","events_url":"https://api.github.com/users/whilp/events{/privacy}","received_events_url":"https://api.github.com/users/whilp/received_events","type":"User"},"created_at":"2013-07-30T13:44:18Z","updated_at":"2013-07-30T13:44:18Z","html_url":"https://github.com/SimpleFinance/chef-polyglot/pull/7#discussion_r5476597","pull_request_url":"https://api.github.com/repos/SimpleFinance/chef-polyglot/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/SimpleFinance/chef-polyglot/pulls/comments/5476597"},"html":{"href":"https://github.com/SimpleFinance/chef-polyglot/pull/7#discussion_r5476597"},"pull_request":{"href":"https://api.github.com/repos/SimpleFinance/chef-polyglot/pulls/7"}}}}

{"repository":{"description":"Deploys sane default setup for various languages","watchers":3,"stargazers":3,"forks":0,"fork":false,"size":87,"owner":"SimpleFinance","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-04-22T14:28:22-07:00","pushed_at":"2013-07-29T21:20:59-07:00","master_branch":"master","organization":"SimpleFinance"},"actor_attributes":{"type":"User","name":"Will Maier","company":"Simple","blog":"http://wcm.aier.us/","location":"Wisconsin, USA","email":"[email protected]"},"url":"https://github.com/SimpleFinance/chef-polyglot/pull/7#discussion_r5476597"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls/comments/3155114","id":3155114,"body":"The code in here is basically duplicate code from the scapy test template code, this means that if we ever decide to change the test template format (for example to include something more details), you will not inherit this automatically, but you will have to change this part of code to reflect that.","diff_hunk":"@@ -7,126 +7,149 @@\n # A simple ICMP-8 ping test.\n #\n # @authors: Isis Lovecruft, <[email protected]>\n-# @version: 0.0.2-pre-alpha\n # @license: copyright (c) 2012 Isis Lovecruft\n # see attached LICENCE file\n-#\n \n import os\n-import sys\n \n+from twisted.internet import defer\n from twisted.python import usage\n-from twisted.internet import reactor, defer\n-from ooni import nettest\n-from ooni.utils import log, net, Storage, txscapy\n+from ooni import nettest, config\n+from ooni.utils import log, net, randomStr\n \n try:\n- from scapy.all import IP, ICMP\n- from scapy.all import sr1\n- from ooni.lib import txscapy\n- from ooni.lib.txscapy import txsr, txsend\n- from ooni.templates.scapyt import BaseScapyTest\n-except:\n+ from scapy.all import IP, ICMP, sr1\n+ from ooni.utils import txscapy\n+except Exception, e:\n log.msg(\"This test requires scapy, see www.secdev.org/projects/scapy\")\n+ log.exception(e)\n \n-class UsageOptions(usage.Options):\n+class EchoOptions(usage.Options):\n+ \"\"\"\n+ Options for EchoTest.\n+ \"\"\"\n optParameters = [\n ['dst', 'd', None, 'Host IP to ping'],\n- ['file', 'f', None, 'File of list of IPs to ping'],\n- ['interface', 'i', None, 'Network interface to use'],\n+ ['receive', 'r', True, 'Receive response packets'],\n ['count', 'c', 1, 'Number of packets to send', int],\n- ['size', 's', 56, 'Number of bytes to send in ICMP data field', int],\n- ['ttl', 'l', 25, 'Set the IP Time to Live', int],\n- ['timeout', 't', 2, 'Seconds until timeout if no response', int],\n- ['pcap', 'p', None, 'Save pcap to this file'],\n- ['receive', 'r', True, 'Receive response packets']]\n+ ['icmp_type', 'i', 8, 'ICMP-type to send', int],\n+ ['payload_size', 'p', 56, 'Bytes to send in ICMP data field', int],\n+ ['ttl', 't', 25, 'Set the IP Time to Live', int]]\n \n class EchoTest(nettest.NetTestCase):\n \"\"\"\n- xxx fill me in\n+ Basic ping test. This takes an input file containing one IP or hostname\n+ per line.\n \"\"\"\n name = 'echo'\n author = 'Isis Lovecruft <[email protected]>'\n description = 'A simple ping test to see if a host is reachable.'\n- version = '0.0.2'\n- requiresRoot = True\n+ version = '0.0.4'\n \n- usageOptions = UsageOptions\n- #requiredOptions = ['dst']\n+ requiresRoot = True\n+ usageOptions = EchoOptions\n+ inputFile = ['file', 'f', None, 'File of list of IPs to ping']\n \n def setUp(self, *a, **kw):\n+ \"\"\"\n+ Send an ICMP-8 packet to a host IP, and process the response.\n+\n+ @param dst:\n+ A single host to ping.\n+ @param file:\n+ A file of hosts to ping, one per line.\n+ @param receive:\n+ Whether or not to receive replies. Defaults to True.\n+ \"\"\"\n self.destinations = {}\n \n if self.localOptions:\n for key, value in self.localOptions.items():\n- log.debug(\"setting self.%s = %s\" % (key, value))\n setattr(self, key, value)\n \n- self.timeout *= 1000 ## convert to milliseconds\n+ if hasattr(config.advanced, 'default_timeout'):\n+ self.timeout = config.advanced.default_timeout\n+ else:\n+ self.timeout = 4\n \n- if not self.interface:\n+ if config.advanced.interface:\n+ self.interface = config.advanced.interface\n+ else:\n+ log.warn(\"No network interface specified in ooniprobe.conf!\")\n try:\n iface = txscapy.getDefaultIface()\n- except Exception, e:\n- log.msg(\"No network interface specified!\")\n- log.err(e)\n+ except Exception, ex:\n+ log.err(ex.message)\n else:\n- log.msg(\"Using system default interface: %s\" % iface)\n self.interface = iface\n+ log.msg(\"Using system default interface: %s\" % iface)\n \n- if self.pcap:\n- try:\n- self.pcapfile = open(self.pcap, 'a+')\n- except:\n- log.msg(\"Unable to write to pcap file %s\" % self.pcap)\n- else:\n- self.pcap = net.capturePacket(self.pcapfile)\n-\n- if not self.dst:\n- if self.file:\n- self.dstProcessor(self.file)\n- for key, value in self.destinations.items():\n- for label, data in value.items():\n- if not 'ans' in data:\n- self.dst = label\n- else:\n- self.addDest(self.dst)\n- log.debug(\"self.dst is now: %s\" % self.dst)\n-\n- log.debug(\"Initialization of %s test completed.\" % self.name)\n-\n- def addDest(self, dest):\n- d = dest.strip()\n- self.destinations[d] = {'dst_ip': d}\n-\n- def dstProcessor(self, inputfile):\n- from ipaddr import IPAddress\n+ self.payload = randomStr(self.payload_size)\n \n+ def inputProcessor(self, inputfile=None):\n if os.path.isfile(inputfile):\n with open(inputfile) as f:\n for line in f.readlines():\n if line.startswith('#'):\n continue\n- self.addDest(line)\n+ yield line.strip().rsplit(':', 1)[0] ## xxx not ipv6 safe\n+\n+ def icmp_constructor(self, dst=None):\n+ \"\"\"Construct a list of ICMP packets to send out.\"\"\"\n+ dst_ip = dst if dst is not None else self.input\n+\n+ packet_list = []\n+ for x in xrange(self.count):\n+ p = IP(dst=dst_ip, ttl=self.ttl)/ICMP(type=self.icmp_type)\n+ p.add_payload(self.payload)\n+ packet_list.append(p)\n+ return packet_list\n \n def test_icmp(self):\n- def process_response(echo_reply, dest):\n- ans, unans = echo_reply\n- if ans:\n- log.msg(\"Recieved echo reply from %s: %s\" % (dest, ans))\n- else:\n- log.msg(\"No reply was received from %s. Possible censorship event.\" % dest)\n- log.debug(\"Unanswered packets: %s\" % unans)\n- self.report[dest] = echo_reply\n-\n- for label, data in self.destinations.items():\n- reply = sr1(IP(dst=lebal)/ICMP())\n- process = process_reponse(reply, label)\n-\n- #(ans, unans) = ping\n- #self.destinations[self.dst].update({'ans': ans,\n- # 'unans': unans,\n- # 'response_packet': ping})\n- #return ping\n-\n- #return reply\n+ \"\"\"\n+ Send the list of ICMP packets.\n+\n+ TODO: add end summary progress report for % answered, etc.\n+ \"\"\"\n+ def nicely(thing):\n+ \"\"\"Log packets prettierly.\"\"\"\n+ return [x.summary() for x in thing]\n+\n+ def process_answered(answered, sent):","path":"nettests/experimental/bridge_reachability/echo.py","position":192,"original_position":192,"commit_id":"c498ac0e04e4e872938926eedfbd8296ad500365","original_commit_id":"c498ac0e04e4e872938926eedfbd8296ad500365","user":{"login":"hellais","id":424620,"avatar_url":"https://secure.gravatar.com/avatar/9c1ad1eeb401a1144362393b89ffbda0?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"9c1ad1eeb401a1144362393b89ffbda0","url":"https://api.github.com/users/hellais","html_url":"https://github.com/hellais","followers_url":"https://api.github.com/users/hellais/followers","following_url":"https://api.github.com/users/hellais/following","gists_url":"https://api.github.com/users/hellais/gists{/gist_id}","starred_url":"https://api.github.com/users/hellais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellais/subscriptions","organizations_url":"https://api.github.com/users/hellais/orgs","repos_url":"https://api.github.com/users/hellais/repos","events_url":"https://api.github.com/users/hellais/events{/privacy}","received_events_url":"https://api.github.com/users/hellais/received_events","type":"User"},"created_at":"2013-02-26T16:03:49Z","updated_at":"2013-02-26T16:03:49Z","_links":{"self":{"href":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls/comments/3155114"},"html":{"href":"https://github.com/TheTorProject/ooni-probe/pull/49#discussion_r3155114"},"pull_request":{"href":"https://api.github.com/repos/TheTorProject/ooni-probe/pulls/49"}}}}

{"repository":{"description":"github copy of OONI-probe https://gitweb.torproject.org/ooni-probe.git","homepage":"http://ooni.nu/","watchers":56,"stargazers":56,"forks":17,"fork":false,"size":588,"owner":"TheTorProject","private":false,"open_issues":8,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-04-05T13:59:23-07:00","pushed_at":"2013-02-26T07:13:47-08:00","master_branch":"master","organization":"TheTorProject"},"actor_attributes":{"type":"User","name":"Arturo Filastò","blog":"http://arturo.filasto.net/","location":"Internetz","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/TheTorProject/ooni-probe/pull/49#discussion_r3155114"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/couchbaselabs/TouchDB-Android/pulls/comments/3210127","id":3210127,"body":"Its probably safe. Simplest thing to do is apply the patch and run the\r\nunit tests.\r\n\r\nmarty\r\n\r\n\r\nOn Fri, Mar 1, 2013 at 2:59 PM, Chris Anderson <[email protected]>wrote:\r\n\r\n> In TouchDB-Android/src/com/couchbase/touchdb/replicator/TDReplicator.java:\r\n>\r\n> > @@ -105,7 +105,9 @@ public void databaseClosing() {\r\n> > }\r\n> >\r\n> > public String toString() {\r\n>\r\n> are there other places this string representation matters? eg for\r\n> calculating revision ids or anything? If there's not, then I'm happy to\r\n> merge this.\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub<https://github.com/couchbaselabs/TouchDB-Android/pull/87/files#r3210086>\r\n> .\r\n>","diff_hunk":"@@ -105,7 +105,9 @@ public void databaseClosing() {\n }\n \n public String toString() {","path":"TouchDB-Android/src/com/couchbase/touchdb/replicator/TDReplicator.java","position":3,"original_position":3,"commit_id":"39431f330ac9e0d4cfb03a0f154267914c16fd4a","original_commit_id":"39431f330ac9e0d4cfb03a0f154267914c16fd4a","user":{"login":"mschoch","id":298143,"avatar_url":"https://secure.gravatar.com/avatar/16cdfb0c4af5297e261cb36e30fa5c20?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"16cdfb0c4af5297e261cb36e30fa5c20","url":"https://api.github.com/users/mschoch","html_url":"https://github.com/mschoch","followers_url":"https://api.github.com/users/mschoch/followers","following_url":"https://api.github.com/users/mschoch/following","gists_url":"https://api.github.com/users/mschoch/gists{/gist_id}","starred_url":"https://api.github.com/users/mschoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mschoch/subscriptions","organizations_url":"https://api.github.com/users/mschoch/orgs","repos_url":"https://api.github.com/users/mschoch/repos","events_url":"https://api.github.com/users/mschoch/events{/privacy}","received_events_url":"https://api.github.com/users/mschoch/received_events","type":"User"},"created_at":"2013-03-01T20:02:02Z","updated_at":"2013-03-01T20:02:02Z","_links":{"self":{"href":"https://api.github.com/repos/couchbaselabs/TouchDB-Android/pulls/comments/3210127"},"html":{"href":"https://github.com/couchbaselabs/TouchDB-Android/pull/87#discussion_r3210127"},"pull_request":{"href":"https://api.github.com/repos/couchbaselabs/TouchDB-Android/pulls/87"}}}}

{"repository":{"description":"CouchDB-compatible mobile database; Android version","homepage":"","watchers":168,"stargazers":168,"forks":42,"fork":false,"size":216,"owner":"couchbaselabs","private":false,"open_issues":39,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2012-01-10T20:05:47-08:00","pushed_at":"2012-08-24T05:21:12-07:00","master_branch":"master","organization":"couchbaselabs"},"actor_attributes":{"type":"User","name":"Marty Schoch","blog":"http://hexeditreality.com","email":"[email protected]"},"url":"https://github.com/couchbaselabs/TouchDB-Android/pull/87#discussion_r3210127"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/modcloth-labs/travis-buddy/pulls/comments/5147364","id":5147364,"body":"`s/muxt/must/`","diff_hunk":"@@ -246,6 +246,36 @@ describe 'upload-go-artifacts' do\n )\n end\n end\n+\n+ describe 'when the public option is passed' do\n+ def command\n+ 'upload-go-artifacts --public'\n+ end\n+\n+ it 'muxt not pass the --private flag' do","path":"runtests","position":10,"original_position":10,"commit_id":"502ec0a31655bb38dffdfd8f35b2ede5b39a98d7","original_commit_id":"502ec0a31655bb38dffdfd8f35b2ede5b39a98d7","user":{"login":"meatballhat","id":45143,"avatar_url":"https://secure.gravatar.com/avatar/9c0d0b4d099eea3e6cd9d0e205b6a83e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"9c0d0b4d099eea3e6cd9d0e205b6a83e","url":"https://api.github.com/users/meatballhat","html_url":"https://github.com/meatballhat","followers_url":"https://api.github.com/users/meatballhat/followers","following_url":"https://api.github.com/users/meatballhat/following{/other_user}","gists_url":"https://api.github.com/users/meatballhat/gists{/gist_id}","starred_url":"https://api.github.com/users/meatballhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meatballhat/subscriptions","organizations_url":"https://api.github.com/users/meatballhat/orgs","repos_url":"https://api.github.com/users/meatballhat/repos","events_url":"https://api.github.com/users/meatballhat/events{/privacy}","received_events_url":"https://api.github.com/users/meatballhat/received_events","type":"User"},"created_at":"2013-07-11T17:58:12Z","updated_at":"2013-07-11T17:58:12Z","html_url":"https://github.com/modcloth-labs/travis-buddy/pull/4#discussion_r5147364","pull_request_url":"https://api.github.com/repos/modcloth-labs/travis-buddy/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/modcloth-labs/travis-buddy/pulls/comments/5147364"},"html":{"href":"https://github.com/modcloth-labs/travis-buddy/pull/4#discussion_r5147364"},"pull_request":{"href":"https://api.github.com/repos/modcloth-labs/travis-buddy/pulls/4"}}}}

{"repository":{"description":"It's like your buddy over on Travis CI.","homepage":"","watchers":4,"stargazers":4,"forks":0,"fork":false,"size":636,"owner":"modcloth-labs","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Shell","created_at":"2013-05-08T18:59:10-07:00","pushed_at":"2013-07-11T10:34:06-07:00","master_branch":"master","organization":"modcloth-labs"},"actor_attributes":{"type":"User","name":"Dan Buch","company":"ModCloth","blog":"http://meatballhat.com","location":"Pittsburgh, PA","email":"[email protected]"},"url":"https://github.com/modcloth-labs/travis-buddy/pull/4#discussion_r5147364"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/modcloth-labs/travis-buddy/pulls/comments/5566264","id":5566264,"body":":scream_cat: good catch! Might be time to add tests...","diff_hunk":"@@ -669,20 +681,23 @@ function download-artifact() {\n exit 3\n fi\n \n- if [ -z \"$TRAVIS_BUDDY_KEY\" ] && [[ \"$5\" == '--decrypt' ]] ; then\n+ if [ -z \"$TRAVIS_BUDDY_KEY\" ] && [[ \"$4$5\" =~ --decrypt ]] ; then\n log 'Missing $TRAVIS_BUDDY_KEY'\n usage\n exit 4\n fi\n \n- local s3_bucket=\"${S3_BUCKET:-\"modcloth-public-travis-artifacts\"}\"\n+ assert_has_env_var 'ARTIFACTS_S3_BUCKET' \\\n+ \"Can't fetch files from S3 without \\$ARTIFACTS_S3_BUCKET\"\n+\n+ local s3_bucket=\"${ARTIFACTS_S3_BUCKET}\"\n \n local osname=\"${OSNAME:-\"$(uname | tr '[:upper:]' '[:lower:]')\"}\"\n local archname=\"${ARCHNAME:-\"$(uname -m)\"}\"\n local app=\"$1\"\n local rev=\"$2\"\n local dest_dir=\"$3\"\n- if [[ \"$4\" == '--go' ]] ; then\n+ if [[ \"$4$5\" =~ --go ]] ; then\n osname=\"${GOOS:-\"$(go env GOOS)\"}\"\n archname=\"${GOARCH:-\"$(go env GOARCH)\"}\"\n shift","path":"tb","position":56,"original_position":56,"commit_id":"fadcb63f6f62e8848d73b976f896ccc8903f0f91","original_commit_id":"fadcb63f6f62e8848d73b976f896ccc8903f0f91","user":{"login":"meatballhat","id":45143,"avatar_url":"https://secure.gravatar.com/avatar/9c0d0b4d099eea3e6cd9d0e205b6a83e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"9c0d0b4d099eea3e6cd9d0e205b6a83e","url":"https://api.github.com/users/meatballhat","html_url":"https://github.com/meatballhat","followers_url":"https://api.github.com/users/meatballhat/followers","following_url":"https://api.github.com/users/meatballhat/following{/other_user}","gists_url":"https://api.github.com/users/meatballhat/gists{/gist_id}","starred_url":"https://api.github.com/users/meatballhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meatballhat/subscriptions","organizations_url":"https://api.github.com/users/meatballhat/orgs","repos_url":"https://api.github.com/users/meatballhat/repos","events_url":"https://api.github.com/users/meatballhat/events{/privacy}","received_events_url":"https://api.github.com/users/meatballhat/received_events","type":"User"},"created_at":"2013-08-03T04:26:28Z","updated_at":"2013-08-03T04:26:28Z","html_url":"https://github.com/modcloth-labs/travis-buddy/pull/7#discussion_r5566264","pull_request_url":"https://api.github.com/repos/modcloth-labs/travis-buddy/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/modcloth-labs/travis-buddy/pulls/comments/5566264"},"html":{"href":"https://github.com/modcloth-labs/travis-buddy/pull/7#discussion_r5566264"},"pull_request":{"href":"https://api.github.com/repos/modcloth-labs/travis-buddy/pulls/7"}}}}

{"repository":{"description":"It's like your buddy over on Travis CI.","homepage":"","watchers":6,"stargazers":6,"forks":0,"fork":false,"size":548,"owner":"modcloth-labs","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Shell","created_at":"2013-05-08T18:59:10-07:00","pushed_at":"2013-08-02T20:38:14-07:00","master_branch":"master","organization":"modcloth-labs"},"actor_attributes":{"type":"User","name":"Dan Buch","company":"ModCloth","blog":"http://meatballhat.com","location":"Pittsburgh, PA","email":"[email protected]"},"url":"https://github.com/modcloth-labs/travis-buddy/pull/7#discussion_r5566264"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/plataformatec/devise/pulls/comments/6756468","id":6756468,"body":"I know this is already merged... But, doesn't exist a more elegant solution to this issue?","diff_hunk":"@@ -258,6 +258,10 @@ def sign_in_and_redirect(resource_or_scope, *args)\n end\n \n def expire_session_data_after_sign_in!\n+ # session.keys will return an empty array if the session is not yet loaded.\n+ # This is a bug in both Rack and Rails.\n+ # A call to #empty? forces the session to be loaded.\n+ session.empty?","path":"lib/devise/controllers/helpers.rb","position":7,"original_position":7,"commit_id":"2351d0215a50554be24870f40b0318b38df91186","original_commit_id":"2351d0215a50554be24870f40b0318b38df91186","user":{"login":"kelvinst","id":2791965,"avatar_url":"https://0.gravatar.com/avatar/38fca5c1e9dec5ac71360fb8a42d1856?d=https%3A%2F%2Fidenticons.github.com%2F3fa8508ed27918572cff248d6586d9f7.png","gravatar_id":"38fca5c1e9dec5ac71360fb8a42d1856","url":"https://api.github.com/users/kelvinst","html_url":"https://github.com/kelvinst","followers_url":"https://api.github.com/users/kelvinst/followers","following_url":"https://api.github.com/users/kelvinst/following{/other_user}","gists_url":"https://api.github.com/users/kelvinst/gists{/gist_id}","starred_url":"https://api.github.com/users/kelvinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelvinst/subscriptions","organizations_url":"https://api.github.com/users/kelvinst/orgs","repos_url":"https://api.github.com/users/kelvinst/repos","events_url":"https://api.github.com/users/kelvinst/events{/privacy}","received_events_url":"https://api.github.com/users/kelvinst/received_events","type":"User"},"created_at":"2013-10-03T22:34:44Z","updated_at":"2013-10-03T22:34:44Z","html_url":"https://github.com/plataformatec/devise/pull/2663#discussion_r6756468","pull_request_url":"https://api.github.com/repos/plataformatec/devise/pulls/2663","_links":{"self":{"href":"https://api.github.com/repos/plataformatec/devise/pulls/comments/6756468"},"html":{"href":"https://github.com/plataformatec/devise/pull/2663#discussion_r6756468"},"pull_request":{"href":"https://api.github.com/repos/plataformatec/devise/pulls/2663"}}}}

{"repository":{"description":"Flexible authentication solution for Rails with Warden.","homepage":"http://blog.plataformatec.com.br/tag/devise/","watchers":9276,"stargazers":9276,"forks":1776,"fork":false,"size":27183,"owner":"plataformatec","private":false,"open_issues":13,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2009-09-16T05:15:12-07:00","pushed_at":"2013-10-03T08:40:04-07:00","integrate_branch":"master","master_branch":"master","organization":"plataformatec"},"actor_attributes":{"type":"User","name":"Kelvin Raffael Stinghen","company":"Senior Sistemas","blog":"","location":"Blumenau - SC - Brazil","email":"[email protected]"},"url":"https://github.com/plataformatec/devise/pull/2663#discussion_r6756468"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/playframework/Play20/pulls/comments/4855692","id":4855692,"body":"Does this work? It doesn't look right to me. Please write tests to ensure that it's being invoked in the right execution context (you can look at the current thread name).","diff_hunk":"@@ -0,0 +1,28 @@\n+## Using a separated execution context\n+\n+You may want to use a separated execution context to avoid blocking threads in the default thread pool.\n+\n+The only things you have to do is to use the SlickController trait with a SlickAction : \n+\n+```scala\n+object Application extends Controller with SlickController { \n+ def list(page: Int, orderBy: Int, filter: String) = SlickAction {\n+ ...\n+ }\n+}\n+```\n+\n+Then you can configure the slick thread pool in your application.conf file : \n+\n+```\n+slick {","path":"documentation/manual/scalaGuide/main/slick/Using-a-separated-execution-context.md","position":18,"original_position":18,"commit_id":"c30e43d11348ce3b337bf79a30cfebad2dd933c6","original_commit_id":"c30e43d11348ce3b337bf79a30cfebad2dd933c6","user":{"login":"jroper","id":105833,"avatar_url":"https://secure.gravatar.com/avatar/dd48848f9904bdce25eb2a2824842f50?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"dd48848f9904bdce25eb2a2824842f50","url":"https://api.github.com/users/jroper","html_url":"https://github.com/jroper","followers_url":"https://api.github.com/users/jroper/followers","following_url":"https://api.github.com/users/jroper/following{/other_user}","gists_url":"https://api.github.com/users/jroper/gists{/gist_id}","starred_url":"https://api.github.com/users/jroper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jroper/subscriptions","organizations_url":"https://api.github.com/users/jroper/orgs","repos_url":"https://api.github.com/users/jroper/repos","events_url":"https://api.github.com/users/jroper/events{/privacy}","received_events_url":"https://api.github.com/users/jroper/received_events","type":"User"},"created_at":"2013-06-24T22:59:54Z","updated_at":"2013-06-24T22:59:54Z","html_url":"https://github.com/playframework/Play20/pull/1230#discussion_r4855692","pull_request_url":"https://api.github.com/repos/playframework/Play20/pulls/1230","_links":{"self":{"href":"https://api.github.com/repos/playframework/Play20/pulls/comments/4855692"},"html":{"href":"https://github.com/playframework/Play20/pull/1230#discussion_r4855692"},"pull_request":{"href":"https://api.github.com/repos/playframework/Play20/pulls/1230"}}}}

{"repository":{"description":"Play framework 2.x","homepage":"http://www.playframework.org/","watchers":3267,"stargazers":3267,"forks":1020,"fork":false,"size":4852,"owner":"playframework","private":false,"open_issues":236,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Scala","created_at":"2011-09-07T02:24:08-07:00","pushed_at":"2013-06-23T20:56:49-07:00","master_branch":"master","organization":"playframework"},"actor_attributes":{"type":"User","name":"James Roper","company":"Typesafe","blog":"http://jazzy.id.au","location":"Sydney, Australia","email":"[email protected]"},"url":"https://github.com/playframework/Play20/pull/1230#discussion_r4855692"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/playframework/playframework/pulls/comments/7265434","id":7265434,"diff_hunk":"@@ -183,8 +184,23 @@ public void onThrowable(Throwable t) {\n private int timeout = 0;\n private Boolean followRedirects = null;\n \n- public WSRequestHolder(String url) {\n- this.url = url;\n+ public WSRequestHolder(String url) throws MalformedURLException {","path":"framework/src/play-java/src/main/java/play/libs/WS.java","position":23,"original_position":23,"commit_id":"322f18f0a911c4868843df6f58cedf3daf9ca4cd","original_commit_id":"322f18f0a911c4868843df6f58cedf3daf9ca4cd","user":{"login":"jroper","id":105833,"avatar_url":"https://2.gravatar.com/avatar/dd48848f9904bdce25eb2a2824842f50?d=https%3A%2F%2Fidenticons.github.com%2F4b9d5cf9d20c0934dc772bbf5addebce.png&r=x","gravatar_id":"dd48848f9904bdce25eb2a2824842f50","url":"https://api.github.com/users/jroper","html_url":"https://github.com/jroper","followers_url":"https://api.github.com/users/jroper/followers","following_url":"https://api.github.com/users/jroper/following{/other_user}","gists_url":"https://api.github.com/users/jroper/gists{/gist_id}","starred_url":"https://api.github.com/users/jroper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jroper/subscriptions","organizations_url":"https://api.github.com/users/jroper/orgs","repos_url":"https://api.github.com/users/jroper/repos","events_url":"https://api.github.com/users/jroper/events{/privacy}","received_events_url":"https://api.github.com/users/jroper/received_events","type":"User","site_admin":false},"body":"Could we wrap this in a RuntimeException?","created_at":"2013-10-28T22:10:29Z","updated_at":"2013-10-28T22:10:29Z","html_url":"https://github.com/playframework/playframework/pull/1933#discussion_r7265434","pull_request_url":"https://api.github.com/repos/playframework/playframework/pulls/1933","_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/7265434"},"html":{"href":"https://github.com/playframework/playframework/pull/1933#discussion_r7265434"},"pull_request":{"href":"https://api.github.com/repos/playframework/playframework/pulls/1933"}}}}

{"repository":{"description":"Play Framework","homepage":"http://www.playframework.com/","watchers":3799,"stargazers":3799,"forks":1268,"fork":false,"size":112787,"owner":"playframework","private":false,"open_issues":171,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Scala","created_at":"2011-09-07T02:24:08-07:00","pushed_at":"2013-10-28T15:07:33-07:00","master_branch":"master","organization":"playframework"},"actor_attributes":{"type":"User","name":"James Roper","company":"Typesafe","blog":"http://jazzy.id.au","location":"Sydney, Australia","email":"[email protected]"},"url":"https://github.com/playframework/playframework/pull/1933#discussion_r7265434"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/playframework/playframework/pulls/comments/8293158","id":8293158,"diff_hunk":"@@ -9,27 +9,49 @@ import play.api.http.MimeTypes\n import org.apache.commons.lang3.StringEscapeUtils\n \n /**\n- * Appendable content using a StringBuilder.\n- * @param buffer StringBuilder to use\n+ * Appendable content using a StringBuilder. Either specify elements or text, not both.\n+ *\n+ * Using an Either[TraversableOnce[A], String] impacts performance in an already\n+ * contentious part of code, so it has been done with both parameters instead.\n+ *\n+ * @param elements Sub elements to traverse when creating the resultant string\n+ * @param text Formatted content\n * @tparam A self-type\n */\n-abstract class BufferedContent[A <: BufferedContent[A]](private val buffer: StringBuilder) extends Appendable[A] with Content with play.mvc.Content { this: A =>\n+abstract class BufferedContent[A <: BufferedContent[A]](protected val elements: TraversableOnce[A], protected val text: String) extends Appendable[A] with Content with play.mvc.Content { this: A =>\n+ protected def buildString(builder: StringBuilder) {","path":"framework/src/play/src/main/scala/play/api/templates/Templates.scala","position":17,"original_position":17,"commit_id":"5c8346e3f8e2a1f2413f3443ca2542ab5ea112e1","original_commit_id":"5c8346e3f8e2a1f2413f3443ca2542ab5ea112e1","user":{"login":"huntc","id":694893,"avatar_url":"https://gravatar.com/avatar/7338f0ed645a19ff563c655d847e51d8?d=https%3A%2F%2Fidenticons.github.com%2F1026681d98a3347b4b1ea292a702fa6d.png&r=x","gravatar_id":"7338f0ed645a19ff563c655d847e51d8","url":"https://api.github.com/users/huntc","html_url":"https://github.com/huntc","followers_url":"https://api.github.com/users/huntc/followers","following_url":"https://api.github.com/users/huntc/following{/other_user}","gists_url":"https://api.github.com/users/huntc/gists{/gist_id}","starred_url":"https://api.github.com/users/huntc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huntc/subscriptions","organizations_url":"https://api.github.com/users/huntc/orgs","repos_url":"https://api.github.com/users/huntc/repos","events_url":"https://api.github.com/users/huntc/events{/privacy}","received_events_url":"https://api.github.com/users/huntc/received_events","type":"User","site_admin":false},"body":"Feels like we should be using an `Either[TraversableOnce[A], String]` instead right?","created_at":"2013-12-12T07:46:46Z","updated_at":"2013-12-12T07:46:46Z","html_url":"https://github.com/playframework/playframework/pull/2151#discussion_r8293158","pull_request_url":"https://api.github.com/repos/playframework/playframework/pulls/2151","_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/8293158"},"html":{"href":"https://github.com/playframework/playframework/pull/2151#discussion_r8293158"},"pull_request":{"href":"https://api.github.com/repos/playframework/playframework/pulls/2151"}}}}

{"repository":{"description":"Play Framework","homepage":"http://www.playframework.com/","watchers":3984,"stargazers":3984,"forks":1374,"fork":false,"size":114835,"owner":"playframework","private":false,"open_issues":196,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Scala","created_at":"2011-09-07T02:24:08-07:00","pushed_at":"2013-12-11T23:18:30-08:00","master_branch":"master","organization":"playframework"},"actor_attributes":{"type":"User","name":"Christopher Hunt","company":"Typesafe","blog":"http://christopherhunt-software.blogspot.com/","location":"Bulli, NSW, Australia","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/playframework/playframework/pull/2151#discussion_r8293158"}

PullRequestReviewCommentEvent

{"comment":{"commit_id":"b89a2fb4fa2c794703673e5ff6780d4391012939","user":{"received_events_url":"https://api.github.com/users/nrporter/received_events","subscriptions_url":"https://api.github.com/users/nrporter/subscriptions","gravatar_id":"c05cdedf7f650f454021a8384770e170","gists_url":"https://api.github.com/users/nrporter/gists{/gist_id}","type":"User","id":562951,"repos_url":"https://api.github.com/users/nrporter/repos","organizations_url":"https://api.github.com/users/nrporter/orgs","events_url":"https://api.github.com/users/nrporter/events{/privacy}","url":"https://api.github.com/users/nrporter","avatar_url":"https://secure.gravatar.com/avatar/c05cdedf7f650f454021a8384770e170?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","following_url":"https://api.github.com/users/nrporter/following","followers_url":"https://api.github.com/users/nrporter/followers","login":"nrporter","starred_url":"https://api.github.com/users/nrporter/starred{/owner}{/repo}"},"path":"webapp/writing_center/classinfo.html","id":2666273,"updated_at":"2013-01-16T15:08:56Z","url":"https://api.github.com/repos/plymouthstate/plymouth-webapp/pulls/comments/2666273","original_commit_id":"b89a2fb4fa2c794703673e5ff6780d4391012939","created_at":"2013-01-16T15:08:56Z","position":2,"body":"PSU\\Template?","_links":{"pull_request":{"href":"https://api.github.com/repos/plymouthstate/plymouth-webapp/pulls/465"},"html":{"href":"https://github.com/plymouthstate/plymouth-webapp/pull/465#discussion_r2666273"},"self":{"href":"https://api.github.com/repos/plymouthstate/plymouth-webapp/pulls/comments/2666273"}},"original_position":2}}

{"repository":{"watchers":11,"owner":"plymouthstate","has_wiki":false,"pushed_at":"2013-01-09T08:09:12-08:00","description":"Plymouth State University Webapp","stargazers":11,"forks":14,"organization":"plymouthstate","language":"PHP","fork":false,"size":280,"created_at":"2012-01-26T13:52:48-08:00","open_issues":44,"has_issues":true,"has_downloads":true,"private":false,"homepage":""},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/plymouthstate/plymouth-webapp/pull/465#discussion_r2666273"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/testing-cabal/testtools/pulls/comments/3294753","id":3294753,"body":"Whether it is a docstring or a comment doesn't matter so much. Being able to quickly understand what it's for and what I can expect it to return is what matters. Currently, I have to sit down with pen & paper to figure that out. ","diff_hunk":"@@ -446,6 +447,75 @@ def makeResult(self):\n return TestResultDecorator(TestResult())\n \n \n+class TestStreamResultContract(object):\n+\n+ def _make_result(self):\n+ raise NotImplementedError(self._make_result)\n+\n+ def test_startTestRun(self):\n+ result = self._make_result()\n+ result.startTestRun()\n+ result.stopTestRun()\n+\n+ def test_files(self):\n+ result = self._make_result()\n+ result.startTestRun()\n+ self.addCleanup(result.stopTestRun)\n+ now = datetime.datetime.now(utc)\n+ inputs = list(dict(\n+ eof=True,\n+ mime_type=\"text/plain\",\n+ route_code=_u(\"1234\"),\n+ test_id=_u(\"foo\"),\n+ timestamp=now,\n+ ).items())\n+ param_dicts = self._permute(inputs)\n+ for kwargs in param_dicts:\n+ result.status(file_name=_u(\"foo\"), file_bytes=_b(\"\"), **kwargs)\n+ result.status(file_name=_u(\"foo\"), file_bytes=_b(\"bar\"), **kwargs)\n+\n+ def test_test_status(self):\n+ result = self._make_result()\n+ result.startTestRun()\n+ self.addCleanup(result.stopTestRun)\n+ now = datetime.datetime.now(utc)\n+ args = [[_u(\"foo\"), s] for s in ['exists', 'inprogress', 'xfail',\n+ 'uxsuccess', 'success', 'fail', 'skip']]\n+ inputs = list(dict(\n+ runnable=False,\n+ test_tags=set(['quux']),\n+ route_code=_u(\"1234\"),\n+ timestamp=now,\n+ ).items())\n+ param_dicts = self._permute(inputs)\n+ for kwargs in param_dicts:\n+ for arg in args:\n+ result.status(test_id=arg[0], test_status=arg[1], **kwargs)\n+\n+ def _permute(self, inputs):\n+ param_dicts = [{}]\n+ # Build a full set of combinations\n+ def permutations(size, inputs):\n+ # For each possible start point, return the permutations one size\n+ # smaller from the rest of the list combined with that start point.","path":"testtools/tests/test_testresult.py","position":64,"original_position":62,"commit_id":"be409a612826422d4a1e9e42e92b7ed784cbea2a","original_commit_id":"db742ae19ef412e77a861a819df286fe86018669","user":{"login":"jml","id":125674,"avatar_url":"https://secure.gravatar.com/avatar/1327ce755b24b956995d68accae3eab2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"1327ce755b24b956995d68accae3eab2","url":"https://api.github.com/users/jml","html_url":"https://github.com/jml","followers_url":"https://api.github.com/users/jml/followers","following_url":"https://api.github.com/users/jml/following","gists_url":"https://api.github.com/users/jml/gists{/gist_id}","starred_url":"https://api.github.com/users/jml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jml/subscriptions","organizations_url":"https://api.github.com/users/jml/orgs","repos_url":"https://api.github.com/users/jml/repos","events_url":"https://api.github.com/users/jml/events{/privacy}","received_events_url":"https://api.github.com/users/jml/received_events","type":"User"},"created_at":"2013-03-08T08:45:35Z","updated_at":"2013-03-08T08:45:35Z","html_url":"https://github.com/testing-cabal/testtools/pull/20#discussion_r3294753","pull_request_url":"https://api.github.com/repos/testing-cabal/testtools/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/testing-cabal/testtools/pulls/comments/3294753"},"html":{"href":"https://github.com/testing-cabal/testtools/pull/20#discussion_r3294753"},"pull_request":{"href":"https://api.github.com/repos/testing-cabal/testtools/pulls/20"}}}}

{"repository":{"description":"Testtools - tasteful testing for python","watchers":2,"stargazers":2,"forks":5,"fork":false,"size":292,"owner":"testing-cabal","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-01-24T10:59:21-08:00","pushed_at":"2013-03-07T00:28:58-08:00","master_branch":"master","organization":"testing-cabal"},"actor_attributes":{"type":"User","name":"Jonathan Lange","blog":"http://mumak.net","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/testing-cabal/testtools/pull/20#discussion_r3294753"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/zendframework/zf2/pulls/comments/7676035","id":7676035,"diff_hunk":"@@ -85,6 +85,36 @@ public function add($input, $name = null)\n }\n \n /**\n+ * Replace a named input\n+ *\n+ * @param string $name\n+ * @return InputFilterInterface","path":"library/Zend/InputFilter/BaseInputFilter.php","position":null,"original_position":7,"commit_id":"633141ec3d3692ab6c72265e851727561d98cb21","original_commit_id":"2e5001ec049516db4eafd7999932da4b2db27624","user":{"login":"saltoledo","id":5914184,"avatar_url":"https://0.gravatar.com/avatar/8983779cc6cfa1244e5e86b13c19a206?d=https%3A%2F%2Fidenticons.github.com%2F113904336dd74f3f55eb4e26d560dcc8.png&r=x","gravatar_id":"8983779cc6cfa1244e5e86b13c19a206","url":"https://api.github.com/users/saltoledo","html_url":"https://github.com/saltoledo","followers_url":"https://api.github.com/users/saltoledo/followers","following_url":"https://api.github.com/users/saltoledo/following{/other_user}","gists_url":"https://api.github.com/users/saltoledo/gists{/gist_id}","starred_url":"https://api.github.com/users/saltoledo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltoledo/subscriptions","organizations_url":"https://api.github.com/users/saltoledo/orgs","repos_url":"https://api.github.com/users/saltoledo/repos","events_url":"https://api.github.com/users/saltoledo/events{/privacy}","received_events_url":"https://api.github.com/users/saltoledo/received_events","type":"User","site_admin":false},"body":"I just copied the comments from another method, the other methods in this file are using \"@return InputFilterInterface\". Anyway, this DocBlock was incomplete, I made it a bit more complete.","created_at":"2013-11-14T22:36:28Z","updated_at":"2013-11-14T22:36:28Z","html_url":"https://github.com/zendframework/zf2/pull/5479#discussion_r7676035","pull_request_url":"https://api.github.com/repos/zendframework/zf2/pulls/5479","_links":{"self":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/comments/7676035"},"html":{"href":"https://github.com/zendframework/zf2/pull/5479#discussion_r7676035"},"pull_request":{"href":"https://api.github.com/repos/zendframework/zf2/pulls/5479"}}}}

{"repository":{"description":"Official Zend Framework 2 git repository","homepage":"http://framework.zend.com/","watchers":4398,"stargazers":4398,"forks":2448,"fork":false,"size":170759,"owner":"zendframework","private":false,"open_issues":420,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2010-06-03T19:42:05-07:00","pushed_at":"2013-11-13T06:06:12-08:00","master_branch":"master","organization":"zendframework"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/zendframework/zf2/pull/5479#discussion_r7676035"}

PullRequestReviewCommentEvent

{"comment":{"position":29,"commit_id":"a2704d116210b8398f531c229d969df86e584ea9","_links":{"html":{"href":"https://github.com/DHBW-Karlsruhe/businesshorizon2/pull/25#discussion_r2701260"},"self":{"href":"https://api.github.com/repos/DHBW-Karlsruhe/businesshorizon2/pulls/comments/2701260"},"pull_request":{"href":"https://api.github.com/repos/DHBW-Karlsruhe/businesshorizon2/pulls/25"}},"created_at":"2013-01-18T20:12:13Z","updated_at":"2013-01-18T20:12:13Z","original_position":29,"id":2701260,"url":"https://api.github.com/repos/DHBW-Karlsruhe/businesshorizon2/pulls/comments/2701260","original_commit_id":"a2704d116210b8398f531c229d969df86e584ea9","path":"src/main/java/dhbw/ka/mwi/businesshorizon2/models/Project.java","body":"@Madrawn \r\nSehe ich das richtig, dass hier die Methoden mitten zwischen den Felddeklarationen stehen??? Bitte sauber trennen, erst Felder deklarieren, dann Methoden!","user":{"following_url":"https://api.github.com/users/florian-stier/following","received_events_url":"https://api.github.com/users/florian-stier/received_events","repos_url":"https://api.github.com/users/florian-stier/repos","avatar_url":"https://secure.gravatar.com/avatar/b90ceb1743d74c409f4b6631b805816c?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","subscriptions_url":"https://api.github.com/users/florian-stier/subscriptions","organizations_url":"https://api.github.com/users/florian-stier/orgs","id":2901750,"url":"https://api.github.com/users/florian-stier","starred_url":"https://api.github.com/users/florian-stier/starred{/owner}{/repo}","gravatar_id":"b90ceb1743d74c409f4b6631b805816c","type":"User","login":"florian-stier","followers_url":"https://api.github.com/users/florian-stier/followers","gists_url":"https://api.github.com/users/florian-stier/gists{/gist_id}","events_url":"https://api.github.com/users/florian-stier/events{/privacy}"}}}

{"repository":{"pushed_at":"2013-01-18T12:07:12-08:00","forks":0,"owner":"DHBW-Karlsruhe","has_wiki":true,"created_at":"2012-12-12T11:38:20-08:00","organization":"DHBW-Karlsruhe","description":"","open_issues":1,"has_issues":true,"watchers":0,"fork":false,"size":2136,"stargazers":0,"has_downloads":true,"language":"Java","private":false},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/DHBW-Karlsruhe/businesshorizon2/pull/25#discussion_r2701260"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/HumbleSoftware/taxi/pulls/comments/6505280","id":6505280,"body":"So this would become `this.passengerViews.push(passengerView);`","diff_hunk":"@@ -57,78 +56,48 @@ taxi.DriverListView = Backbone.View.extend({\n \n taxi.DriverView = Backbone.View.extend({\n className : 'taxi-driver',\n- contexts : {},\n+ $passengerViews : $(),\n initialize : function (options) {\n- this.runner = options.runner;\n+ this.passenger = options.passenger;\n },\n- destroy : function () {\n- var\n- runners = this.model.get('passengers'),\n- afterEach = this.model.get('afterEach'),\n- contexts = this.contexts;\n- if (afterEach) {\n- _.each(runners, function (runner) {\n- try {\n- afterEach.call(contexts[runner.key]);\n- } catch (e) {\n- console.error(e);\n- }\n- });\n- }\n+ remove : function () {\n+ _.invoke(this.$passengerViews, 'remove');\n+ return Backbone.View.prototype.remove.apply(this, arguments);\n },\n render : function () {\n var\n- data = this.getRenderData(),\n- html = taxi.templates.driver(data);\n+ html = taxi.templates.driver(this.getRenderData());\n this.$el.html(html);\n- this.$runners = this.$el.find('.taxi-driver-runners');\n- this.renderRunners();\n+ this.$passengers = this.$('.taxi-driver-passengers');\n+ this.renderPassengers();\n return this;\n },\n- renderRunners : function () {\n+ renderPassengers : function () {\n var\n- runner = this.runner,\n- runners = this.model.get('passengers');\n- if (runner) {\n- this.renderRunner(_.find(runners, function (config) {\n- return config.key === runner;\n+ passenger = this.passenger,\n+ passengers = this.model.get('passengers');\n+ if (passenger) {\n+ this.renderPassenger(_.find(passengers, function (config) {\n+ return config.key === passenger;\n }));\n } else {\n- _.each(runners, this.renderRunner, this);\n+ _.each(passengers, this.renderPassenger, this);\n }\n },\n- renderRunner : function (runner) {\n+ renderPassenger : function (passenger) {\n var\n key = this.model.get('key'),\n- $runners = this.$runners,\n beforeEach = this.model.get('beforeEach'),\n- contexts = this.contexts,\n- context = {},\n- $html = $(taxi.templates.runner({\n- 'runner' : runner,\n- 'driver_key' : key\n- })),\n- $container = $html.find('.taxi-runner-container'),\n- options = {\n- $container : $container\n- };\n-\n- try {\n- if (beforeEach) {\n- beforeEach.call(context, options);\n- }\n- if (runner.callback) {\n- runner.callback.call(context, options);\n- }\n- } catch (e) {\n- $container\n- .addClass('taxi-error')\n- .text(e.stack || e.toString());\n- console.error(e);\n- }\n+ afterEach = this.model.get('afterEach'),\n+ passengerView = new taxi.PassengerView({\n+ model : passenger,\n+ driverKey : key,\n+ before : beforeEach,\n+ after : afterEach\n+ });\n \n- $runners.append($html);\n- contexts[runner.key] = context;\n+ this.$passengerViews.append(passengerView);","path":"taxi.js","position":121,"original_position":121,"commit_id":"791503c465fc601fc24eddf856ee8107d4f86400","original_commit_id":"791503c465fc601fc24eddf856ee8107d4f86400","user":{"login":"cesutherland","id":348406,"avatar_url":"https://0.gravatar.com/avatar/127ab310e5fbe04964f5d908d8cfcaac?d=https%3A%2F%2Fidenticons.github.com%2F369fb0fa630d82c441e8246f7782c6c9.png","gravatar_id":"127ab310e5fbe04964f5d908d8cfcaac","url":"https://api.github.com/users/cesutherland","html_url":"https://github.com/cesutherland","followers_url":"https://api.github.com/users/cesutherland/followers","following_url":"https://api.github.com/users/cesutherland/following{/other_user}","gists_url":"https://api.github.com/users/cesutherland/gists{/gist_id}","starred_url":"https://api.github.com/users/cesutherland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesutherland/subscriptions","organizations_url":"https://api.github.com/users/cesutherland/orgs","repos_url":"https://api.github.com/users/cesutherland/repos","events_url":"https://api.github.com/users/cesutherland/events{/privacy}","received_events_url":"https://api.github.com/users/cesutherland/received_events","type":"User"},"created_at":"2013-09-22T14:03:57Z","updated_at":"2013-09-22T14:03:57Z","html_url":"https://github.com/HumbleSoftware/taxi/pull/8#discussion_r6505280","pull_request_url":"https://api.github.com/repos/HumbleSoftware/taxi/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/HumbleSoftware/taxi/pulls/comments/6505280"},"html":{"href":"https://github.com/HumbleSoftware/taxi/pull/8#discussion_r6505280"},"pull_request":{"href":"https://api.github.com/repos/HumbleSoftware/taxi/pulls/8"}}}}

{"repository":{"description":"A component UI driver.","homepage":"","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":1100,"owner":"HumbleSoftware","private":false,"open_issues":7,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-11-18T13:36:23-08:00","pushed_at":"2013-09-21T14:34:40-07:00","master_branch":"master","organization":"HumbleSoftware"},"actor_attributes":{"type":"User","name":"Carl Sutherland","company":"Humble Software Development","blog":"http://www.humblesoftware.com","location":"West Philly","email":"[email protected]"},"url":"https://github.com/HumbleSoftware/taxi/pull/8#discussion_r6505280"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/SageSalesLogix/argos-saleslogix/pulls/comments/3423171","id":3423171,"body":"Unnecessary spaces.","diff_hunk":"@@ -250,12 +250,13 @@ define('Mobile/SalesLogix/Views/OpportunityProduct/Edit', [\n property: 'Opportunity',\n type: 'lookup',\n textProperty: 'Description',\n- view: 'opportunity_related'\n+ view: 'opportunity_related',\n+ validator: validator.exists\n },\n {\n name: 'ProductId',\n property: 'ProductId',\n- type: 'hidden'\n+ type: 'hidden' ","path":"src/Views/OpportunityProduct/Edit.js","position":21,"original_position":21,"commit_id":"4454cbdb90cd03e3fa75e60a17fea1b572669daa","original_commit_id":"4454cbdb90cd03e3fa75e60a17fea1b572669daa","user":{"login":"jbest84","id":354553,"avatar_url":"https://secure.gravatar.com/avatar/629d297e4a6339b907a80132f6ee7b8a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"629d297e4a6339b907a80132f6ee7b8a","url":"https://api.github.com/users/jbest84","html_url":"https://github.com/jbest84","followers_url":"https://api.github.com/users/jbest84/followers","following_url":"https://api.github.com/users/jbest84/following","gists_url":"https://api.github.com/users/jbest84/gists{/gist_id}","starred_url":"https://api.github.com/users/jbest84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbest84/subscriptions","organizations_url":"https://api.github.com/users/jbest84/orgs","repos_url":"https://api.github.com/users/jbest84/repos","events_url":"https://api.github.com/users/jbest84/events{/privacy}","received_events_url":"https://api.github.com/users/jbest84/received_events","type":"User"},"created_at":"2013-03-18T23:35:03Z","updated_at":"2013-03-18T23:35:03Z","html_url":"https://github.com/SageSalesLogix/argos-saleslogix/pull/61#discussion_r3423171","pull_request_url":"https://api.github.com/repos/SageSalesLogix/argos-saleslogix/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/SageSalesLogix/argos-saleslogix/pulls/comments/3423171"},"html":{"href":"https://github.com/SageSalesLogix/argos-saleslogix/pull/61#discussion_r3423171"},"pull_request":{"href":"https://api.github.com/repos/SageSalesLogix/argos-saleslogix/pulls/61"}}}}

{"repository":{"description":"SalesLogix-specific HTML/CSS/JavaScript mobile SData client based on argos-sdk","homepage":"","watchers":37,"stargazers":37,"forks":10,"fork":false,"size":7775,"owner":"SageSalesLogix","private":false,"open_issues":25,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2010-06-28T16:33:54-07:00","pushed_at":"2013-03-18T16:27:32-07:00","master_branch":"2.1","organization":"SageSalesLogix"},"actor_attributes":{"type":"User","name":"Jason Best","company":"Sage","blog":"http://twitter.com/#!/jbest84","location":"Phoenix","email":"[email protected]"},"url":"https://github.com/SageSalesLogix/argos-saleslogix/pull/61#discussion_r3423171"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/TheLastCrusade/SoundStream/pulls/comments/5620140","id":5620140,"body":"Ahhh yeah. I'll make the necessary changes.","diff_hunk":"@@ -1,9 +1,13 @@\n # SoundStream\n \n-**SoundStream** is an open-source Android app that provides a platform to crowdsource music playlist creation among friends.\n+**SoundStream** is an open-source Android app that provides a platform to crowdsource music playlist creation among friends. *SoundStream Beta* is now available for free on the Google Play Store! *link to app will go in this line*\n+\n+This product is currently in beta, so please keep an eye out for bugs! If you come across a scenario which you think may be a bug, please [create a new issue](https://github.com/TheLastCrusade/SoundStream/issues/new) or email us at [email protected].\n+\n+If you have other questions, we'll be adding to our [wiki](https://github.com/TheLastCrusade/SoundStream/wiki) over time. You can suggest feature requests and see what we've got coming down the pipeline! ","path":"README.md","position":8,"original_position":8,"commit_id":"28f6877182ae74cb774e718386f626ef0b5c033e","original_commit_id":"28f6877182ae74cb774e718386f626ef0b5c033e","user":{"login":"dgreenhalgh","id":940735,"avatar_url":"https://secure.gravatar.com/avatar/e6c3b29d605483753f2d0d9168b7485b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"e6c3b29d605483753f2d0d9168b7485b","url":"https://api.github.com/users/dgreenhalgh","html_url":"https://github.com/dgreenhalgh","followers_url":"https://api.github.com/users/dgreenhalgh/followers","following_url":"https://api.github.com/users/dgreenhalgh/following{/other_user}","gists_url":"https://api.github.com/users/dgreenhalgh/gists{/gist_id}","starred_url":"https://api.github.com/users/dgreenhalgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgreenhalgh/subscriptions","organizations_url":"https://api.github.com/users/dgreenhalgh/orgs","repos_url":"https://api.github.com/users/dgreenhalgh/repos","events_url":"https://api.github.com/users/dgreenhalgh/events{/privacy}","received_events_url":"https://api.github.com/users/dgreenhalgh/received_events","type":"User"},"created_at":"2013-08-06T23:43:34Z","updated_at":"2013-08-06T23:43:34Z","html_url":"https://github.com/TheLastCrusade/SoundStream/pull/260#discussion_r5620140","pull_request_url":"https://api.github.com/repos/TheLastCrusade/SoundStream/pulls/260","_links":{"self":{"href":"https://api.github.com/repos/TheLastCrusade/SoundStream/pulls/comments/5620140"},"html":{"href":"https://github.com/TheLastCrusade/SoundStream/pull/260#discussion_r5620140"},"pull_request":{"href":"https://api.github.com/repos/TheLastCrusade/SoundStream/pulls/260"}}}}

{"repository":{"description":"","watchers":1,"stargazers":1,"forks":6,"fork":false,"size":8871,"owner":"TheLastCrusade","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2013-01-13T14:52:39-08:00","pushed_at":"2013-08-04T20:45:56-07:00","master_branch":"master","organization":"TheLastCrusade"},"actor_attributes":{"type":"User","name":"David Greenhalgh","company":"","blog":"facebook.com/david.greenhalgh","location":"Atlanta, GA","email":"[email protected]"},"url":"https://github.com/TheLastCrusade/SoundStream/pull/260#discussion_r5620140"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/TheLastCrusade/SoundStream/pulls/comments/6032241","id":6032241,"body":"Yea they do. We should give them a name so we know what index we're using. \n\nDavid Greenhalgh <[email protected]> wrote:\n\n> + */\n> +public class InstructionsDialog {\n> + private Activity activity;\n> + private static final int[] MESSAGEIDS = {R.string.welcome, R.string.welcome_connection, \n> + R.string.welcome_music, R.string.welcome_network };\n> + \n> + public InstructionsDialog(Activity activity){\n> + this.activity = activity;\n> + }\n> + public void show(){\n> + showInstructions(0);\n> + }\n> + \n> + private void showInstructions(final int messageIndex){\n> + String positiveString = messageIndex < MESSAGEIDS.length-1? \"Next\" : \"Done\";\n> + String negativeString = messageIndex > 0 ? \"Back\" : \"Skip\";\n\nDo ones and zeroes count as magic numbers in this case when they're used for indexing?\n\n---\nReply to this email directly or view it on GitHub:\nhttps://github.com/TheLastCrusade/SoundStream/pull/305/files#r6032122","diff_hunk":"@@ -0,0 +1,68 @@\n+/*\n+ * Copyright 2013 The Last Crusade [email protected]\n+ * \n+ * This file is part of SoundStream.\n+ * \n+ * SoundStream is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU General Public License as published by\n+ * the Free Software Foundation, either version 3 of the License, or\n+ * (at your option) any later version.\n+ * \n+ * SoundStream is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+ * GNU General Public License for more details.\n+ * \n+ * You should have received a copy of the GNU General Public License\n+ * along with SoundStream. If not, see <http://www.gnu.org/licenses/>.\n+ */\n+package com.thelastcrusade.soundstream.components;\n+\n+import android.app.Activity;\n+import android.app.AlertDialog;\n+import android.content.DialogInterface;\n+\n+import com.thelastcrusade.soundstream.R;\n+\n+/**\n+ * @author Elizabeth\n+ *\n+ */\n+public class InstructionsDialog {\n+ private Activity activity;\n+ private static final int[] MESSAGEIDS = {R.string.welcome, R.string.welcome_connection, \n+ R.string.welcome_music, R.string.welcome_network };\n+ \n+ public InstructionsDialog(Activity activity){\n+ this.activity = activity;\n+ }\n+ public void show(){\n+ showInstructions(0);\n+ }\n+ \n+ private void showInstructions(final int messageIndex){\n+ String positiveString = messageIndex < MESSAGEIDS.length-1? \"Next\" : \"Done\";\n+ String negativeString = messageIndex > 0 ? \"Back\" : \"Skip\";","path":"SoundStream/src/com/thelastcrusade/soundstream/components/InstructionsDialog.java","position":45,"original_position":45,"commit_id":"c04e5b6686ca559d94923f5ceaafd8f8543ae92c","original_commit_id":"c04e5b6686ca559d94923f5ceaafd8f8543ae92c","user":{"login":"theJenix","id":1337080,"avatar_url":"https://1.gravatar.com/avatar/1627164c751140dc48189f473a59e289?d=https%3A%2F%2Fidenticons.github.com%2Fe1c65816b41652a2c69122755b60dfa3.png","gravatar_id":"1627164c751140dc48189f473a59e289","url":"https://api.github.com/users/theJenix","html_url":"https://github.com/theJenix","followers_url":"https://api.github.com/users/theJenix/followers","following_url":"https://api.github.com/users/theJenix/following{/other_user}","gists_url":"https://api.github.com/users/theJenix/gists{/gist_id}","starred_url":"https://api.github.com/users/theJenix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theJenix/subscriptions","organizations_url":"https://api.github.com/users/theJenix/orgs","repos_url":"https://api.github.com/users/theJenix/repos","events_url":"https://api.github.com/users/theJenix/events{/privacy}","received_events_url":"https://api.github.com/users/theJenix/received_events","type":"User"},"created_at":"2013-08-28T12:57:23Z","updated_at":"2013-08-28T12:57:23Z","html_url":"https://github.com/TheLastCrusade/SoundStream/pull/305#discussion_r6032241","pull_request_url":"https://api.github.com/repos/TheLastCrusade/SoundStream/pulls/305","_links":{"self":{"href":"https://api.github.com/repos/TheLastCrusade/SoundStream/pulls/comments/6032241"},"html":{"href":"https://github.com/TheLastCrusade/SoundStream/pull/305#discussion_r6032241"},"pull_request":{"href":"https://api.github.com/repos/TheLastCrusade/SoundStream/pulls/305"}}}}

{"repository":{"description":"","watchers":2,"stargazers":2,"forks":6,"fork":false,"size":9010,"owner":"TheLastCrusade","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2013-01-13T14:52:39-08:00","pushed_at":"2013-08-25T15:37:38-07:00","master_branch":"master","organization":"TheLastCrusade"},"actor_attributes":{"type":"User","name":"Jesse Rosalia","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/TheLastCrusade/SoundStream/pull/305#discussion_r6032241"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/comments/6450283","id":6450283,"body":"This should be in a finally block.","diff_hunk":"@@ -83,6 +88,32 @@ private void handleDownloadMmsAction(DownloadItem item) {\n else downloadMms(item);\n }\n \n+ private void handleMmsPendingApnDownloads(MasterSecret masterSecret) {\n+ if (!MmsDownloadHelper.isMmsConnectionParametersAvailable(context, null, false))\n+ return;\n+\n+ MmsDatabase mmsDatabase = DatabaseFactory.getMmsDatabase(context);\n+ MmsDatabase.Reader stalledMmsReader = mmsDatabase.getNotificationsWithDownloadState(masterSecret,\n+ MmsDatabase.Status.DOWNLOAD_APN_UNAVAILABLE);\n+ try {\n+ while (stalledMmsReader.getNext() != null) {\n+ NotificationMmsMessageRecord stalledMmsRecord = (NotificationMmsMessageRecord) stalledMmsReader.getCurrent();\n+\n+ Intent intent = new Intent(SendReceiveService.DOWNLOAD_MMS_ACTION, null, context, SendReceiveService.class);\n+ intent.putExtra(\"content_location\", new String(stalledMmsRecord.getContentLocation()));\n+ intent.putExtra(\"message_id\", stalledMmsRecord.getId());\n+ intent.putExtra(\"transaction_id\", stalledMmsRecord.getTransactionId());\n+ intent.putExtra(\"thread_id\", stalledMmsRecord.getThreadId());\n+ intent.putExtra(\"automatic\", true);\n+ context.startService(intent);\n+ }\n+ } catch (CursorIndexOutOfBoundsException e) {\n+ Log.w(\"MmsDownloader\", \"Error reading stalled MMS from database: \" + e);\n+ }\n+\n+ stalledMmsReader.close();","path":"src/org/thoughtcrime/securesms/service/MmsDownloader.java","position":73,"original_position":73,"commit_id":"414bebd3ec9527329d06ba682427465372ef9598","original_commit_id":"414bebd3ec9527329d06ba682427465372ef9598","user":{"login":"moxie0","id":512439,"avatar_url":"https://0.gravatar.com/avatar/3039ee38b82701f3d0dd0fbb901a754f?d=https%3A%2F%2Fidenticons.github.com%2F8452197a8efc12c29a3aade130199261.png","gravatar_id":"3039ee38b82701f3d0dd0fbb901a754f","url":"https://api.github.com/users/moxie0","html_url":"https://github.com/moxie0","followers_url":"https://api.github.com/users/moxie0/followers","following_url":"https://api.github.com/users/moxie0/following{/other_user}","gists_url":"https://api.github.com/users/moxie0/gists{/gist_id}","starred_url":"https://api.github.com/users/moxie0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxie0/subscriptions","organizations_url":"https://api.github.com/users/moxie0/orgs","repos_url":"https://api.github.com/users/moxie0/repos","events_url":"https://api.github.com/users/moxie0/events{/privacy}","received_events_url":"https://api.github.com/users/moxie0/received_events","type":"User"},"created_at":"2013-09-18T23:43:14Z","updated_at":"2013-09-18T23:43:14Z","html_url":"https://github.com/WhisperSystems/TextSecure/pull/351#discussion_r6450283","pull_request_url":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/351","_links":{"self":{"href":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/comments/6450283"},"html":{"href":"https://github.com/WhisperSystems/TextSecure/pull/351#discussion_r6450283"},"pull_request":{"href":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/351"}}}}

{"repository":{"description":"A secure text messaging application for Android.","homepage":"","watchers":975,"stargazers":975,"forks":267,"fork":false,"size":10397,"owner":"WhisperSystems","private":false,"open_issues":103,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2011-12-15T12:01:12-08:00","pushed_at":"2013-09-17T15:00:02-07:00","master_branch":"master","organization":"WhisperSystems"},"actor_attributes":{"type":"User","name":"Moxie Marlinspike","blog":"http://www.thoughtcrime.org","location":"San Francisco","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/WhisperSystems/TextSecure/pull/351#discussion_r6450283"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/comments/6225245","id":6225245,"body":"This indentation seems weird","diff_hunk":"@@ -230,10 +231,10 @@ public void onChange(boolean selfChange) {\n }\n \n private void initializeSenderReceiverService() {\n- Intent smsSenderIntent = new Intent(SendReceiveService.SEND_SMS_ACTION, null, this,\n- SendReceiveService.class);\n- Intent mmsSenderIntent = new Intent(SendReceiveService.SEND_MMS_ACTION, null, this,\n- SendReceiveService.class);\n+ Intent smsSenderIntent = new Intent(SendReceiveService.SEND_SMS_ACTION, null, this,\n+ SendReceiveService.class);\n+ Intent mmsSenderIntent = new Intent(SendReceiveService.SEND_MMS_ACTION, null, this,\n+ SendReceiveService.class);","path":"src/org/thoughtcrime/securesms/ConversationListActivity.java","position":32,"original_position":32,"commit_id":"2174cbbe55b2b7db27a71a8f5f4942dd033fbe7a","original_commit_id":"2174cbbe55b2b7db27a71a8f5f4942dd033fbe7a","user":{"login":"moxie0","id":512439,"avatar_url":"https://2.gravatar.com/avatar/3039ee38b82701f3d0dd0fbb901a754f?d=https%3A%2F%2Fidenticons.github.com%2F8452197a8efc12c29a3aade130199261.png","gravatar_id":"3039ee38b82701f3d0dd0fbb901a754f","url":"https://api.github.com/users/moxie0","html_url":"https://github.com/moxie0","followers_url":"https://api.github.com/users/moxie0/followers","following_url":"https://api.github.com/users/moxie0/following{/other_user}","gists_url":"https://api.github.com/users/moxie0/gists{/gist_id}","starred_url":"https://api.github.com/users/moxie0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxie0/subscriptions","organizations_url":"https://api.github.com/users/moxie0/orgs","repos_url":"https://api.github.com/users/moxie0/repos","events_url":"https://api.github.com/users/moxie0/events{/privacy}","received_events_url":"https://api.github.com/users/moxie0/received_events","type":"User"},"created_at":"2013-09-07T17:58:24Z","updated_at":"2013-09-07T17:58:24Z","html_url":"https://github.com/WhisperSystems/TextSecure/pull/334#discussion_r6225245","pull_request_url":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/334","_links":{"self":{"href":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/comments/6225245"},"html":{"href":"https://github.com/WhisperSystems/TextSecure/pull/334#discussion_r6225245"},"pull_request":{"href":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/334"}}}}

{"repository":{"description":"A secure text messaging application for Android.","homepage":"","watchers":964,"stargazers":964,"forks":262,"fork":false,"size":2596,"owner":"WhisperSystems","private":false,"open_issues":98,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2011-12-15T12:01:12-08:00","pushed_at":"2013-09-06T23:05:44-07:00","master_branch":"master","organization":"WhisperSystems"},"actor_attributes":{"type":"User","name":"Moxie Marlinspike","blog":"http://www.thoughtcrime.org","location":"San Francisco","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/WhisperSystems/TextSecure/pull/334#discussion_r6225245"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/bellotastudios/gradecraft-development/pulls/comments/6442609","id":6442609,"body":"Ah, I wasn't paying attention to the context. A text box does not make sense for score levels. Maybe a select field? That might be easier if the slider isn't amenable to dynamic step levels.","diff_hunk":"@@ -85,12 +85,29 @@ $(document).ready(function(){\n \t$('#navbar').affix();\n \n $('.slider').each(function(i,slider) {\n- $slider = $(slider)\n+ $slider = $(slider);\n+ var scoreValues = $slider.data(\"scorelevelvals\");\n+ var scoreNames = $slider.data(\"scorelevelnames\");\n $slider.slider({\n- max: $slider.attr('max')\n+ min: 0,\n+ max: $slider.attr('max'),\n+ step: Math.pow(10,Math.floor(Math.log($slider.attr('max')*.1)/Math.LN10)),","path":"app/assets/javascripts/application.js","position":12,"original_position":12,"commit_id":"ccc786793ea147471a12a693c4f27b6dd035a82f","original_commit_id":"ccc786793ea147471a12a693c4f27b6dd035a82f","user":{"login":"allspiritseve","id":161156,"avatar_url":"https://1.gravatar.com/avatar/0d292b1cb6d82f0208573cd428e1e94d?d=https%3A%2F%2Fidenticons.github.com%2F43c6295663fc6c1db9951336027baaa8.png","gravatar_id":"0d292b1cb6d82f0208573cd428e1e94d","url":"https://api.github.com/users/allspiritseve","html_url":"https://github.com/allspiritseve","followers_url":"https://api.github.com/users/allspiritseve/followers","following_url":"https://api.github.com/users/allspiritseve/following{/other_user}","gists_url":"https://api.github.com/users/allspiritseve/gists{/gist_id}","starred_url":"https://api.github.com/users/allspiritseve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allspiritseve/subscriptions","organizations_url":"https://api.github.com/users/allspiritseve/orgs","repos_url":"https://api.github.com/users/allspiritseve/repos","events_url":"https://api.github.com/users/allspiritseve/events{/privacy}","received_events_url":"https://api.github.com/users/allspiritseve/received_events","type":"User"},"created_at":"2013-09-18T18:43:55Z","updated_at":"2013-09-18T18:43:55Z","html_url":"https://github.com/bellotastudios/gradecraft-development/pull/367#discussion_r6442609","pull_request_url":"https://api.github.com/repos/bellotastudios/gradecraft-development/pulls/367","_links":{"self":{"href":"https://api.github.com/repos/bellotastudios/gradecraft-development/pulls/comments/6442609"},"html":{"href":"https://github.com/bellotastudios/gradecraft-development/pull/367#discussion_r6442609"},"pull_request":{"href":"https://api.github.com/repos/bellotastudios/gradecraft-development/pulls/367"}}}}

{"repository":{"description":"Gradecraft is a gamified gradebook, intended to help motivate students to be more engaged in their own learning.","homepage":"","watchers":6,"stargazers":6,"forks":0,"fork":false,"size":44338,"owner":"bellotastudios","private":false,"open_issues":32,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-02-08T19:44:54-08:00","pushed_at":"2013-09-18T11:23:46-07:00","master_branch":"master","organization":"bellotastudios"},"actor_attributes":{"type":"User","name":"Cory Kaufman-Schofield","blog":"http://corykaufman.com","location":"Ann Arbor, MI","email":"[email protected]"},"url":"https://github.com/bellotastudios/gradecraft-development/pull/367#discussion_r6442609"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/clearstorydata/tachyon/pulls/comments/5332767","id":5332767,"body":"Is there any reasonable way to make sure that the thrift version specified here and in the pom stay in sync?","diff_hunk":"@@ -11,4 +11,17 @@ bin=`cd \"$( dirname \"$0\" )\"; pwd`\n \n rm -rf $bin/../src/main/java/tachyon/thrift\n \n-thrift --gen java -out $bin/../src/main/java/. $bin/../src/thrift/tachyon.thrift\n+thrift_version=0.7.0","path":"bin/thrift-gen.sh","position":5,"original_position":5,"commit_id":"6c34a9d7bbcc8714fd1430e5b760db961361fe2f","original_commit_id":"6c34a9d7bbcc8714fd1430e5b760db961361fe2f","user":{"login":"markhamstra","id":424186,"avatar_url":"https://secure.gravatar.com/avatar/aaa2e907159f6919c4a4c8039d46752f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"aaa2e907159f6919c4a4c8039d46752f","url":"https://api.github.com/users/markhamstra","html_url":"https://github.com/markhamstra","followers_url":"https://api.github.com/users/markhamstra/followers","following_url":"https://api.github.com/users/markhamstra/following{/other_user}","gists_url":"https://api.github.com/users/markhamstra/gists{/gist_id}","starred_url":"https://api.github.com/users/markhamstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markhamstra/subscriptions","organizations_url":"https://api.github.com/users/markhamstra/orgs","repos_url":"https://api.github.com/users/markhamstra/repos","events_url":"https://api.github.com/users/markhamstra/events{/privacy}","received_events_url":"https://api.github.com/users/markhamstra/received_events","type":"User"},"created_at":"2013-07-22T22:31:12Z","updated_at":"2013-07-22T22:31:12Z","html_url":"https://github.com/clearstorydata/tachyon/pull/3#discussion_r5332767","pull_request_url":"https://api.github.com/repos/clearstorydata/tachyon/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/clearstorydata/tachyon/pulls/comments/5332767"},"html":{"href":"https://github.com/clearstorydata/tachyon/pull/3#discussion_r5332767"},"pull_request":{"href":"https://api.github.com/repos/clearstorydata/tachyon/pulls/3"}}}}

{"repository":{"description":"Tachyon","homepage":"http://tachyon-project.org/","watchers":0,"stargazers":0,"forks":1,"fork":true,"size":1508,"owner":"clearstorydata","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2013-04-24T16:03:13-07:00","pushed_at":"2013-07-22T14:02:50-07:00","master_branch":"master","organization":"clearstorydata"},"actor_attributes":{"type":"User","name":"Mark Hamstra","company":"","blog":"","location":"San Francisco, CA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/clearstorydata/tachyon/pull/3#discussion_r5332767"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/gentoo-science/sci/pulls/comments/5397825","id":5397825,"body":"Please take a look into the distutils-r1.eclass.\r\n\r\n + distutils_install_for_testing.py \\\r\n + install --root=\"${T}/test-${EPYTHON}\" \\\r\n + --no-compile || die \"install test failed\"\r\n\r\nthis complete block is covered by distutils_install_for_testing()","diff_hunk":"@@ -0,0 +1,51 @@\n+# Copyright 1999-2013 Gentoo Foundation\n+# Distributed under the terms of the GNU General Public License v2\n+# $Header: /var/cvsroot/gentoo-x86/sci-libs/scikits_image/scikits_image-0.8.2.ebuild,v 1.3 2013/06/18 04:33:25 patrick Exp $\n+\n+EAPI=5\n+\n+# pyamg missing py3 support\n+#PYTHON_COMPAT=( python{2_6,2_7,3_2,3_3} )\n+PYTHON_COMPAT=( python{2_6,2_7} )\n+\n+inherit distutils-r1 git-2\n+\n+MYPN=\"${PN/scikits_/scikit-}\"\n+\n+DESCRIPTION=\"Image processing routines for SciPy\"\n+HOMEPAGE=\"http://scikit-image.org/\"\n+EGIT_REPO_URI=\"https://github.com/scikit-image/scikit-image.git\"\n+\n+LICENSE=\"BSD\"\n+SLOT=\"0\"\n+KEYWORDS=\"~amd64 ~x86 ~amd64-linux ~x86-linux\"\n+IUSE=\"doc freeimage gtk qt4 test\"\n+\n+RDEPEND=\"\n+\tsci-libs/scikits[${PYTHON_USEDEP}]\n+\tsci-libs/scipy[sparse,${PYTHON_USEDEP}]\n+\tfreeimage? ( media-libs/freeimage )\n+\tgtk? ( dev-python/pygtk[$(python_gen_usedep 'python2*')] )\n+\tqt4? ( dev-python/PyQt4[${PYTHON_USEDEP}] )\"\n+DEPEND=\"\n+\t>=dev-python/cython-0.15[${PYTHON_USEDEP}]\n+\t>=dev-python/numpy-1.6[${PYTHON_USEDEP}]\n+\tdev-python/setuptools[${PYTHON_USEDEP}]\n+\ttest? (\n+\t\tdev-python/matplotlib[${PYTHON_USEDEP}]\n+\t\tdev-python/nose[${PYTHON_USEDEP}]\n+\t\tdev-python/pyamg[${PYTHON_USEDEP}]\n+\t\tsci-libs/scipy[${PYTHON_USEDEP}] )\"\n+\n+S=\"${WORKDIR}/${MYPN}-${PV}\"\n+\n+DOCS=( CONTRIBUTORS.txt DEPENDS.txt RELEASE.txt TASKS.txt )\n+\n+python_test() {\n+\tdistutils_install_for_testing.py \\\n+\t\tinstall --root=\"${T}/test-${EPYTHON}\" \\\n+\t\t--no-compile || die \"install test failed\"","path":"sci-libs/scikits_image/scikits_image-9999.ebuild","position":47,"original_position":47,"commit_id":"0e443c69961b2c22f60785c0cefdae8f62a4d087","original_commit_id":"0e443c69961b2c22f60785c0cefdae8f62a4d087","user":{"login":"jlec","id":79732,"avatar_url":"https://secure.gravatar.com/avatar/7758ef94cb25d494941ca9a52e1243de?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"7758ef94cb25d494941ca9a52e1243de","url":"https://api.github.com/users/jlec","html_url":"https://github.com/jlec","followers_url":"https://api.github.com/users/jlec/followers","following_url":"https://api.github.com/users/jlec/following{/other_user}","gists_url":"https://api.github.com/users/jlec/gists{/gist_id}","starred_url":"https://api.github.com/users/jlec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlec/subscriptions","organizations_url":"https://api.github.com/users/jlec/orgs","repos_url":"https://api.github.com/users/jlec/repos","events_url":"https://api.github.com/users/jlec/events{/privacy}","received_events_url":"https://api.github.com/users/jlec/received_events","type":"User"},"created_at":"2013-07-25T13:48:24Z","updated_at":"2013-07-25T13:48:24Z","html_url":"https://github.com/gentoo-science/sci/pull/94#discussion_r5397825","pull_request_url":"https://api.github.com/repos/gentoo-science/sci/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/gentoo-science/sci/pulls/comments/5397825"},"html":{"href":"https://github.com/gentoo-science/sci/pull/94#discussion_r5397825"},"pull_request":{"href":"https://api.github.com/repos/gentoo-science/sci/pulls/94"}}}}

{"repository":{"description":"Gentoo Science Overlay","homepage":"","watchers":26,"stargazers":26,"forks":27,"fork":false,"size":16994,"owner":"gentoo-science","private":false,"open_issues":17,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Shell","created_at":"2012-02-19T06:28:58-08:00","pushed_at":"2013-07-24T16:09:21-07:00","master_branch":"master","organization":"gentoo-science"},"actor_attributes":{"type":"User","name":"Justin","company":"Gentoo Linux","blog":"j-schmitz.net","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/gentoo-science/sci/pull/94#discussion_r5397825"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/comments/3737608","id":3737608,"body":"You have added these as an enum. In the schema alternate hash functions are done as a choice of different elements. Admittedly at the moment the only valid choice is HashSHA1 - see https://www.openmicroscopy.org/Schemas/Documentation/Generated/OME-2012-06/ome_xsd.html#Plane_HashSHA1 \r\n\r\nThis makes sense from a schema point of view as it can check the value matches the right type.","diff_hunk":"@@ -649,6 +650,15 @@\n \t\t<entry name=\"Companion/MIAS\"/>\n \t\t<!-- Note: Other and Unknown are not needed use text/plain or application/octet-stream -->\n \t</enum>\n+\t<enum id=\"ome.model.enums.ChecksumAlgorithm\">\n+\t\t<!-- names suffixed by bit width for clarity -->\n+\t\t<entry name=\"Adler-32\"/>\n+\t\t<entry name=\"CRC-32\"/>\n+\t\t<entry name=\"MD5-128\"/>\n+\t\t<entry name=\"Murmur3-32\"/>\n+\t\t<entry name=\"Murmur3-128\"/>\n+\t\t<entry name=\"SHA1-160\"/>\n+\t</enum>","path":"components/model/resources/mappings/acquisition.ome.xml","position":31,"original_position":31,"commit_id":"3491c0e10fa502bb2d1f476a06660e735c44cc76","original_commit_id":"3491c0e10fa502bb2d1f476a06660e735c44cc76","user":{"login":"qidane","id":9480,"avatar_url":"https://secure.gravatar.com/avatar/79ef5dbf329c38535fdc921eb753a3eb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"79ef5dbf329c38535fdc921eb753a3eb","url":"https://api.github.com/users/qidane","html_url":"https://github.com/qidane","followers_url":"https://api.github.com/users/qidane/followers","following_url":"https://api.github.com/users/qidane/following","gists_url":"https://api.github.com/users/qidane/gists{/gist_id}","starred_url":"https://api.github.com/users/qidane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qidane/subscriptions","organizations_url":"https://api.github.com/users/qidane/orgs","repos_url":"https://api.github.com/users/qidane/repos","events_url":"https://api.github.com/users/qidane/events{/privacy}","received_events_url":"https://api.github.com/users/qidane/received_events","type":"User"},"created_at":"2013-04-10T16:44:24Z","updated_at":"2013-04-10T16:44:24Z","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/995#discussion_r3737608","pull_request_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/995","_links":{"self":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/comments/3737608"},"html":{"href":"https://github.com/openmicroscopy/openmicroscopy/pull/995#discussion_r3737608"},"pull_request":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/995"}}}}

{"repository":{"description":"OME (Open Microscopy Environment) develops open-source software and data format standards for the storage and manipulation of biological light microscopy data. A joint project between universities, research establishments and industry in Europe and the USA, OME has over 20 active researchers with strong links to the microscopy community. Funded by private and public research grants, OME has been a major force on the international microscopy stage since 2000.","homepage":"http://www.openmicroscopy.org","watchers":45,"stargazers":45,"forks":40,"fork":false,"size":45384,"owner":"openmicroscopy","private":false,"open_issues":25,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2011-08-18T07:26:02-07:00","pushed_at":"2013-04-10T04:19:12-07:00","master_branch":"develop","organization":"openmicroscopy"},"actor_attributes":{"type":"User","name":"Andrew Patterson","company":"Open Microscopy Environment","blog":"qidane.livejournal.com","location":"St Andrew, Scotland","email":"[email protected]"},"url":"https://github.com/openmicroscopy/openmicroscopy/pull/995#discussion_r3737608"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/waveaccounting/wabot/pulls/comments/3980968","id":3980968,"body":"Good work, but can we please keep keys out of source control?","diff_hunk":"@@ -0,0 +1,65 @@\n+# Description:\n+# Deploys jenkins builds to wave environments.\n+#\n+# Commands:\n+# hubot deploy <artifact_name> to <environment>\n+\n+module.exports = (robot) ->\n+ robot.respond /deploy (.*) to ([\\w-]+)\\s*(?:(?:summary?) (.*))?/i, (msg) ->\n+ unless isDevOpsRoom(msg)\n+ return\n+\n+ artifactName = msg.match[1].trim()\n+ environment = msg.match[2].trim()\n+ deployMessage = msg.match[3]?.trim()\n+\n+ unless deployMessage\n+ msg.send \"(facepalm) don't be lazy.. you need to supply a deploy summary.\"\n+ msg.send \"Usage: deploy <artifact_name> to <environment> summary <message>\"\n+ return\n+\n+ unless environment in getAvailableEnvironments()\n+ msg.send \"Sorry, I don't know where `#{environment}` is. Is it nice?\"\n+ return\n+\n+ data = JSON.stringify({user: msg.message.user.name, message: \"#{msg.message.user.name} deploy #{artifactName} to #{environment}.\"})\n+ msg.send \"Attempting to lock: #{environment}\"\n+ msg.http(\"#{process.env.HUBOT_GATEKEEPER_URL}/locks/#{environment}/\")\n+ .headers\n+ 'Content-type': \"application/json\",\n+ 'Accept': 'application/json',\n+ 'Authorization': \"#{process.env.GATEKEEPER_TOKEN}\"\n+ .post(data) (err, res, body) ->\n+ if res.statusCode == 200\n+ msg.send \"Locked #{environment}\"\n+ msg.send \"Starting deploy...\"\n+ # send http request to jenkins\n+ req = msg.http(\"https://ci.waveapps.com/jenkins/job/accounting_deploy/buildWithParameters?artifact_name=#{artifactName}&environment=#{environment}&deploy_message=#{deployMessage}&token=riptideIsTheShit\")\n+ auth = new Buffer(\"wabot:72fbbf624145a23b5387b0d343a46c78\").toString('base64')","path":"scripts/deploy.coffee","position":38,"original_position":38,"commit_id":"821c3ac272a61c38f7a6d67845384387314e9ea6","original_commit_id":"821c3ac272a61c38f7a6d67845384387314e9ea6","user":{"login":"swalberg","id":221368,"avatar_url":"https://secure.gravatar.com/avatar/d6d946d00d772be4698fa7bd754dc1c4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"d6d946d00d772be4698fa7bd754dc1c4","url":"https://api.github.com/users/swalberg","html_url":"https://github.com/swalberg","followers_url":"https://api.github.com/users/swalberg/followers","following_url":"https://api.github.com/users/swalberg/following","gists_url":"https://api.github.com/users/swalberg/gists{/gist_id}","starred_url":"https://api.github.com/users/swalberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swalberg/subscriptions","organizations_url":"https://api.github.com/users/swalberg/orgs","repos_url":"https://api.github.com/users/swalberg/repos","events_url":"https://api.github.com/users/swalberg/events{/privacy}","received_events_url":"https://api.github.com/users/swalberg/received_events","type":"User"},"created_at":"2013-04-26T17:25:07Z","updated_at":"2013-04-26T17:25:07Z","html_url":"https://github.com/waveaccounting/wabot/pull/7#discussion_r3980968","pull_request_url":"https://api.github.com/repos/waveaccounting/wabot/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/waveaccounting/wabot/pulls/comments/3980968"},"html":{"href":"https://github.com/waveaccounting/wabot/pull/7#discussion_r3980968"},"pull_request":{"href":"https://api.github.com/repos/waveaccounting/wabot/pulls/7"}}}}

{"repository":{"description":"Wave Accounting's Hipchat Hubot (pronounced wah-bot)","homepage":"","watchers":1,"stargazers":1,"forks":0,"fork":false,"size":216,"owner":"waveaccounting","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"CoffeeScript","created_at":"2012-01-11T08:21:42-08:00","pushed_at":"2013-04-26T10:17:27-07:00","master_branch":"master","organization":"waveaccounting"},"actor_attributes":{"type":"User","name":"Sean Walberg","blog":"http://ertw.com/blog/","email":"[email protected]"},"url":"https://github.com/waveaccounting/wabot/pull/7#discussion_r3980968"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments/8354086","id":8354086,"diff_hunk":"@@ -421,7 +429,13 @@ class VariantContextConverter extends Serializable {\n }\n \n if (g.hasExtendedAttribute(\"MQ\")) {\n- builder.setRmsMappingQuality(getAttributeAsInt(g, \"MQ\"))\n+ val mq: Option[Int] = g.getExtendedAttribute(\"MQ\") match {\n+ case (d: java.lang.Double) => Some(d.toInt)","path":"adam-commands/src/main/scala/edu/berkeley/cs/amplab/adam/commands/VariantContextConverter.scala","position":35,"original_position":34,"commit_id":"f6f1056b2066560fec262d00b4c018addd437b85","original_commit_id":"3def2751479a44612cdd4f18e847c71ebf8dfe41","user":{"login":"arahuja","id":455755,"avatar_url":"https://gravatar.com/avatar/986d1d6acfebde8f7d6e46aaf3d39acc?d=https%3A%2F%2Fidenticons.github.com%2Fb6308ab6a2d5fdbb55563ee707e97ca9.png&r=x","gravatar_id":"986d1d6acfebde8f7d6e46aaf3d39acc","url":"https://api.github.com/users/arahuja","html_url":"https://github.com/arahuja","followers_url":"https://api.github.com/users/arahuja/followers","following_url":"https://api.github.com/users/arahuja/following{/other_user}","gists_url":"https://api.github.com/users/arahuja/gists{/gist_id}","starred_url":"https://api.github.com/users/arahuja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arahuja/subscriptions","organizations_url":"https://api.github.com/users/arahuja/orgs","repos_url":"https://api.github.com/users/arahuja/repos","events_url":"https://api.github.com/users/arahuja/events{/privacy}","received_events_url":"https://api.github.com/users/arahuja/received_events","type":"User","site_admin":false},"body":"Yes, looks good.","created_at":"2013-12-15T06:23:06Z","updated_at":"2013-12-15T06:23:06Z","html_url":"https://github.com/bigdatagenomics/adam/pull/31#discussion_r8354086","pull_request_url":"https://api.github.com/repos/bigdatagenomics/adam/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/comments/8354086"},"html":{"href":"https://github.com/bigdatagenomics/adam/pull/31#discussion_r8354086"},"pull_request":{"href":"https://api.github.com/repos/bigdatagenomics/adam/pulls/31"}}}}

{"repository":{"description":"A genomics processing engine and specialized file format built using Apache Avro, Apache Spark and Parquet. Apache 2 licensed.","homepage":"","watchers":14,"stargazers":14,"forks":5,"fork":false,"size":1795,"owner":"bigdatagenomics","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Scala","created_at":"2013-11-19T15:47:57-08:00","pushed_at":"2013-12-13T14:50:29-08:00","master_branch":"master","organization":"bigdatagenomics"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/bigdatagenomics/adam/pull/31#discussion_r8354086"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/comments/8290915","id":8290915,"diff_hunk":"@@ -0,0 +1,32 @@\n+[#ftl]","path":"software/messaging/src/test/resources/brooklyn/entity/messaging/storm/storm.yaml","position":1,"original_position":1,"commit_id":"851f28c12eaee0d75e3f643d01313ed6c73fdbd2","original_commit_id":"851f28c12eaee0d75e3f643d01313ed6c73fdbd2","user":{"login":"ahgittin","id":496540,"avatar_url":"https://gravatar.com/avatar/b2cc5103505bf11a36c99c961929db5b?d=https%3A%2F%2Fidenticons.github.com%2F8e1723d9d2addd17229de05f978fc8fc.png&r=x","gravatar_id":"b2cc5103505bf11a36c99c961929db5b","url":"https://api.github.com/users/ahgittin","html_url":"https://github.com/ahgittin","followers_url":"https://api.github.com/users/ahgittin/followers","following_url":"https://api.github.com/users/ahgittin/following{/other_user}","gists_url":"https://api.github.com/users/ahgittin/gists{/gist_id}","starred_url":"https://api.github.com/users/ahgittin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahgittin/subscriptions","organizations_url":"https://api.github.com/users/ahgittin/orgs","repos_url":"https://api.github.com/users/ahgittin/repos","events_url":"https://api.github.com/users/ahgittin/events{/privacy}","received_events_url":"https://api.github.com/users/ahgittin/received_events","type":"User","site_admin":false},"body":"This file (in `src/test/resources`) is the same as the one in `src/main/resources`. Should probably delete this one?","created_at":"2013-12-12T03:50:35Z","updated_at":"2013-12-12T03:50:35Z","html_url":"https://github.com/brooklyncentral/brooklyn/pull/1047#discussion_r8290915","pull_request_url":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/1047","_links":{"self":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/comments/8290915"},"html":{"href":"https://github.com/brooklyncentral/brooklyn/pull/1047#discussion_r8290915"},"pull_request":{"href":"https://api.github.com/repos/brooklyncentral/brooklyn/pulls/1047"}}}}

{"repository":{"description":"Brooklyn Multi-Cloud Application Management Project","homepage":"http://brooklyncentral.github.com","watchers":51,"stargazers":51,"forks":23,"fork":false,"size":224773,"owner":"brooklyncentral","private":false,"open_issues":0,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2012-03-30T06:23:26-07:00","pushed_at":"2013-12-11T19:32:26-08:00","master_branch":"master","organization":"brooklyncentral"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/brooklyncentral/brooklyn/pull/1047#discussion_r8290915"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/discoverygarden/delftdora/pulls/comments/8104839","id":8104839,"diff_hunk":"@@ -288,11 +308,11 @@ function delftdora_process_object($object) {\n $db_object->ingested_pid = $object->id;\n \n db_merge('delftdora_ingested_pids')\n- ->key(array('ingested_pid' => $object->id))\n- ->fields(array(\n- 'processed' => NULL,\n- ))\n- ->execute();\n+ ->key(array('ingested_pid' => $object->id))\n+ ->fields(array(\n+ 'processed' => NULL,\n+ ))\n+ ->execute();","path":"delftdora.module","position":73,"original_position":73,"commit_id":"24e3a648199640179432b1aa9f63401bc8be8b5e","original_commit_id":"24e3a648199640179432b1aa9f63401bc8be8b5e","user":{"login":"adam-vessey","id":607975,"avatar_url":"https://0.gravatar.com/avatar/d3687afe988a5b9fd8d41775e99274b3?d=https%3A%2F%2Fidenticons.github.com%2Fcbb39d78f3a828a5e06955dd0704b3bb.png&r=x","gravatar_id":"d3687afe988a5b9fd8d41775e99274b3","url":"https://api.github.com/users/adam-vessey","html_url":"https://github.com/adam-vessey","followers_url":"https://api.github.com/users/adam-vessey/followers","following_url":"https://api.github.com/users/adam-vessey/following{/other_user}","gists_url":"https://api.github.com/users/adam-vessey/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-vessey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-vessey/subscriptions","organizations_url":"https://api.github.com/users/adam-vessey/orgs","repos_url":"https://api.github.com/users/adam-vessey/repos","events_url":"https://api.github.com/users/adam-vessey/events{/privacy}","received_events_url":"https://api.github.com/users/adam-vessey/received_events","type":"User","site_admin":false},"body":"Should be indented at two spaces.","created_at":"2013-12-04T18:36:42Z","updated_at":"2013-12-04T18:36:42Z","html_url":"https://github.com/discoverygarden/delftdora/pull/6#discussion_r8104839","pull_request_url":"https://api.github.com/repos/discoverygarden/delftdora/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/discoverygarden/delftdora/pulls/comments/8104839"},"html":{"href":"https://github.com/discoverygarden/delftdora/pull/6#discussion_r8104839"},"pull_request":{"href":"https://api.github.com/repos/discoverygarden/delftdora/pulls/6"}}}}

{"repository":{"description":"","watchers":0,"stargazers":0,"forks":6,"fork":false,"size":177,"owner":"discoverygarden","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2013-04-02T09:43:17-07:00","pushed_at":"2013-11-21T10:43:10-08:00","master_branch":"7.x","organization":"discoverygarden"},"actor_attributes":{"type":"User","name":"Adam","company":"discoverygarden Inc.","location":"Canada","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/discoverygarden/delftdora/pull/6#discussion_r8104839"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/discoverygarden/delftdora/pulls/comments/8104817","id":8104817,"diff_hunk":"@@ -383,8 +403,7 @@ function delftdora_batch_modify($pid) {\n file_delete($disseminator_file);\n if (empty($output)) {\n $return = FALSE;\n- watchdog('delft', 'Error running batchModify for @pid with @disseminator',\n- array('@pid' => $pid, '@disseminator' => $bm_model['sdef'] . '/' . $bm_model['method'])\n+ watchdog('delft', 'Error running batchModify for @pid with @disseminator', array('@pid' => $pid, '@disseminator' => $bm_model['sdef'] . '/' . $bm_model['method'])","path":"delftdora.module","position":117,"original_position":117,"commit_id":"24e3a648199640179432b1aa9f63401bc8be8b5e","original_commit_id":"24e3a648199640179432b1aa9f63401bc8be8b5e","user":{"login":"adam-vessey","id":607975,"avatar_url":"https://2.gravatar.com/avatar/d3687afe988a5b9fd8d41775e99274b3?d=https%3A%2F%2Fidenticons.github.com%2Fcbb39d78f3a828a5e06955dd0704b3bb.png&r=x","gravatar_id":"d3687afe988a5b9fd8d41775e99274b3","url":"https://api.github.com/users/adam-vessey","html_url":"https://github.com/adam-vessey","followers_url":"https://api.github.com/users/adam-vessey/followers","following_url":"https://api.github.com/users/adam-vessey/following{/other_user}","gists_url":"https://api.github.com/users/adam-vessey/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-vessey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-vessey/subscriptions","organizations_url":"https://api.github.com/users/adam-vessey/orgs","repos_url":"https://api.github.com/users/adam-vessey/repos","events_url":"https://api.github.com/users/adam-vessey/events{/privacy}","received_events_url":"https://api.github.com/users/adam-vessey/received_events","type":"User","site_admin":false},"body":"Should probably break up the array, to make it easier to read.\r\n```\r\nwatchdog('asdf', 'whatever ...', array(\r\n '@a' => 'qwer',\r\n '@b' => 'rewq',\r\n))\r\n```\r\nor something of the like?","created_at":"2013-12-04T18:36:07Z","updated_at":"2013-12-04T18:36:07Z","html_url":"https://github.com/discoverygarden/delftdora/pull/6#discussion_r8104817","pull_request_url":"https://api.github.com/repos/discoverygarden/delftdora/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/discoverygarden/delftdora/pulls/comments/8104817"},"html":{"href":"https://github.com/discoverygarden/delftdora/pull/6#discussion_r8104817"},"pull_request":{"href":"https://api.github.com/repos/discoverygarden/delftdora/pulls/6"}}}}

{"repository":{"description":"","watchers":0,"stargazers":0,"forks":6,"fork":false,"size":177,"owner":"discoverygarden","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2013-04-02T09:43:17-07:00","pushed_at":"2013-11-21T10:43:10-08:00","master_branch":"7.x","organization":"discoverygarden"},"actor_attributes":{"type":"User","name":"Adam","company":"discoverygarden Inc.","location":"Canada","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/discoverygarden/delftdora/pull/6#discussion_r8104817"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/softwerkskammer/Agora/pulls/comments/8033779","id":8033779,"diff_hunk":"@@ -111,48 +103,86 @@ describe('Resource', function () {\n resource.addMemberId('memberID2');\n expect(resource.registeredMembers()).to.not.be.empty;\n expect(copy.registeredMembers()).to.be.empty;\n- done();\n });\n \n- it('copies the limit', function (done) {\n+ it('copies the limit', function () {\n var resource = new Resource({_registeredMembers: [\n {memberId: 'memberID'}\n ], _limit: 1});\n var copy = new Resource({}).copyFrom(resource);\n expect(copy.limit()).to.equal(1);\n- done();\n });\n \n- it('opens the registration for the copy', function (done) {\n+ it('opens the registration for the copy', function () {\n var resource = new Resource({_registeredMembers: [\n {memberId: 'memberID'}\n ], _limit: 1});\n var copy = new Resource({}).copyFrom(resource);\n expect(copy.registrationOpen()).to.be.true;\n- done();\n });\n \n- it('opens the registration for the copy even when it was not open for the original', function (done) {\n+ it('opens the registration for the copy even when it was not open for the original', function () {\n var resource = new Resource({_registeredMembers: [\n {memberId: 'memberID'}\n ], _limit: 1, _registrationOpen: false});\n var copy = new Resource({}).copyFrom(resource);\n expect(copy.registrationOpen()).to.be.true;\n- done();\n });\n \n- it('sets the waitinglist preference for the copy to false', function (done) {\n- var resource = new Resource({_registeredMembers: [ {memberId: 'memberID'} ]});\n+ it('sets the waitinglist preference for the copy to false', function () {\n+ var resource = new Resource({_registeredMembers: [\n+ {memberId: 'memberID'}\n+ ]});\n var copy = new Resource({}).copyFrom(resource);\n expect(copy.withWaitinglist()).to.be.false;\n- done();\n });\n \n- it('sets the waitinglist preference for the copy to false even when it was true for the original', function (done) {\n- var resource = new Resource({_registeredMembers: [ {memberId: 'memberID'} ], _withWaitinglist: true});\n+ it('sets the waitinglist preference for the copy to false even when it was true for the original', function () {\n+ var resource = new Resource({_registeredMembers: [\n+ {memberId: 'memberID'}\n+ ], _withWaitinglist: true});\n var copy = new Resource({}).copyFrom(resource);\n expect(copy.withWaitinglist()).to.be.false;\n- done();\n+ });\n+\n+ });\n+\n+ describe(\"(fillFromUI)\", function () {\n+\n+ it(\"adds a limit if it is given\", function () {\n+ var resource = new Resource({ });\n+ resource.fillFromUI({limit: \"10\"});\n+ expect(resource.limit()).to.equal(10);\n+ });\n+\n+ it(\"removes a limit if it is not given\", function () {\n+ var resource = new Resource({ limit: 10 });\n+ resource.fillFromUI({limit: \"\"});\n+ expect(resource.limit()).to.be.undefined;\n+ });\n+\n+ it(\"allows registration if it is indicated\", function () {\n+ var resource = new Resource({ });","path":"test/activities/resource_object_test.js","position":249,"original_position":249,"commit_id":"81e8250852eda3ac57a1deec9db2e3c1c6602393","original_commit_id":"81e8250852eda3ac57a1deec9db2e3c1c6602393","user":{"login":"NicoleRauch","id":436499,"avatar_url":"https://1.gravatar.com/avatar/820c27382c2be30cf388f319ad28e75b?d=https%3A%2F%2Fidenticons.github.com%2F2264385914f0f4716a22ba644c52d2f5.png&r=x","gravatar_id":"820c27382c2be30cf388f319ad28e75b","url":"https://api.github.com/users/NicoleRauch","html_url":"https://github.com/NicoleRauch","followers_url":"https://api.github.com/users/NicoleRauch/followers","following_url":"https://api.github.com/users/NicoleRauch/following{/other_user}","gists_url":"https://api.github.com/users/NicoleRauch/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoleRauch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoleRauch/subscriptions","organizations_url":"https://api.github.com/users/NicoleRauch/orgs","repos_url":"https://api.github.com/users/NicoleRauch/repos","events_url":"https://api.github.com/users/NicoleRauch/events{/privacy}","received_events_url":"https://api.github.com/users/NicoleRauch/received_events","type":"User","site_admin":false},"body":"hier auch leeres Objekt weg","created_at":"2013-12-02T18:03:23Z","updated_at":"2013-12-02T18:03:23Z","html_url":"https://github.com/softwerkskammer/Agora/pull/525#discussion_r8033779","pull_request_url":"https://api.github.com/repos/softwerkskammer/Agora/pulls/525","_links":{"self":{"href":"https://api.github.com/repos/softwerkskammer/Agora/pulls/comments/8033779"},"html":{"href":"https://github.com/softwerkskammer/Agora/pull/525#discussion_r8033779"},"pull_request":{"href":"https://api.github.com/repos/softwerkskammer/Agora/pulls/525"}}}}

{"repository":{"description":"Die Software für die Plattform der Softwerkskammer","homepage":"","watchers":25,"stargazers":25,"forks":43,"fork":false,"size":7745,"owner":"softwerkskammer","private":false,"open_issues":8,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-03-14T14:07:21-07:00","pushed_at":"2013-12-01T08:10:50-08:00","master_branch":"master","organization":"softwerkskammer"},"actor_attributes":{"type":"User","name":"Nicole Rauch","blog":"http://pboop.wordpress.com","location":"Karlsruhe","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/softwerkskammer/Agora/pull/525#discussion_r8033779"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/FriendsOfSymfony/FOSRestBundle/pulls/comments/8305588","id":8305588,"diff_hunk":"@@ -0,0 +1,385 @@\n+<?php\n+\n+/*\n+ * This file is part of the FOSRestBundle package.\n+ *\n+ * (c) FriendsOfSymfony <http://friendsofsymfony.github.com/>\n+ *\n+ * For the full copyright and license information, please view the LICENSE\n+ * file that was distributed with this source code.\n+ */\n+\n+namespace FOS\\RestBundle\\Tests\\Request;\n+\n+use FOS\\RestBundle\\Request\\ConfigurationInterfaceRequestBodyParamConverter;\n+use JMS\\Serializer\\Exception\\RuntimeException;\n+use JMS\\Serializer\\Exception\\UnsupportedFormatException;\n+use Symfony\\Component\\HttpFoundation\\Request;\n+\n+/**\n+ * @author Tyler Stroud <[email protected]>\n+ */\n+class ConfigurationInterfaceRequestBodyParamConverterTest extends \\PHPUnit_Framework_TestCase\n+{\n+ protected $serializer;\n+ protected $converter;\n+\n+ public function setUp()\n+ {\n+ $method = new \\ReflectionMethod(\n+ 'Sensio\\Bundle\\FrameworkExtraBundle\\Request\\ParamConverter\\ParamConverterInterface',\n+ 'supports'\n+ );\n+ $parameters = $method->getParameters();\n+ if ('Sensio\\Bundle\\FrameworkExtraBundle\\Configuration\\ConfigurationInterface' != $parameters[0]->getClass()->getName()) {\n+ $this->markTestSkipped();","path":"Tests/Request/ConfigurationInterfaceRequestBodyParamConverterTest.php","position":38,"original_position":35,"commit_id":"e47b2ebedcbddbfba48bffeb9cdd5e4c40e3cbbf","original_commit_id":"61e7f6a3445062da565c9f0c23338762ea94f45f","user":{"login":"xabbuh","id":1957048,"avatar_url":"https://gravatar.com/avatar/b5fe043ff5cd47b3b35d95e78fce5539?d=https%3A%2F%2Fidenticons.github.com%2F9783d5b0ef8edb092e0779a155cfa8c0.png&r=x","gravatar_id":"b5fe043ff5cd47b3b35d95e78fce5539","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"body":"done","created_at":"2013-12-12T16:50:15Z","updated_at":"2013-12-12T16:50:15Z","html_url":"https://github.com/FriendsOfSymfony/FOSRestBundle/pull/633#discussion_r8305588","pull_request_url":"https://api.github.com/repos/FriendsOfSymfony/FOSRestBundle/pulls/633","_links":{"self":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSRestBundle/pulls/comments/8305588"},"html":{"href":"https://github.com/FriendsOfSymfony/FOSRestBundle/pull/633#discussion_r8305588"},"pull_request":{"href":"https://api.github.com/repos/FriendsOfSymfony/FOSRestBundle/pulls/633"}}}}

{"repository":{"description":"This Bundle provides various tools to rapidly develop RESTful API's with Symfony2","homepage":"http://friendsofsymfony.github.com/","watchers":711,"stargazers":711,"forks":282,"fork":false,"size":4242,"owner":"FriendsOfSymfony","private":false,"open_issues":70,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2011-03-21T16:14:13-07:00","pushed_at":"2013-12-09T23:27:30-08:00","master_branch":"master","organization":"FriendsOfSymfony"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/FriendsOfSymfony/FOSRestBundle/pull/633#discussion_r8305588"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/UNN-VMK-Software/agile-development-course/pulls/comments/7078546","id":7078546,"diff_hunk":"@@ -0,0 +1,75 @@\n+package ru.unn.agile.temperatureConverterTests;\n+\n+import org.junit.Before;\n+import org.junit.Rule;\n+import org.junit.Test;\n+import org.junit.rules.ExpectedException;\n+\n+import static junit.framework.Assert.*;\n+\n+import ru.unn.agile.temperatureConverter.*;\n+import static ru.unn.agile.temperatureConverter.AvailableScales.*;\n+import static ru.unn.agile.temperatureConverter.Converter.*;\n+\n+public class TemperatureConverterTests {\n+\n+ private Temperature t;\n+\n+ @Rule\n+ public ExpectedException exception = ExpectedException.none();\n+\n+ @Before\n+ public void setUp() {\n+ t = new Temperature(36.5, Celsius);\n+ }\n+\n+ @Test\n+ public void canCreateTemperature() {","path":"code/roman-kotelnikov/core/src/test/ru/unn/agile/temperatureConverterTests/TemperatureConverterTests.java","position":27,"original_position":27,"commit_id":"581b81073164779649464f9e0fe6455e1094a0b3","original_commit_id":"581b81073164779649464f9e0fe6455e1094a0b3","user":{"login":"kirill-kornyakov","id":1688526,"avatar_url":"https://2.gravatar.com/avatar/9ee7b0b81f36454d834ad27d443e8994?d=https%3A%2F%2Fidenticons.github.com%2Fcf85dca5fc523132b58deba5be43601c.png","gravatar_id":"9ee7b0b81f36454d834ad27d443e8994","url":"https://api.github.com/users/kirill-kornyakov","html_url":"https://github.com/kirill-kornyakov","followers_url":"https://api.github.com/users/kirill-kornyakov/followers","following_url":"https://api.github.com/users/kirill-kornyakov/following{/other_user}","gists_url":"https://api.github.com/users/kirill-kornyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/kirill-kornyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirill-kornyakov/subscriptions","organizations_url":"https://api.github.com/users/kirill-kornyakov/orgs","repos_url":"https://api.github.com/users/kirill-kornyakov/repos","events_url":"https://api.github.com/users/kirill-kornyakov/events{/privacy}","received_events_url":"https://api.github.com/users/kirill-kornyakov/received_events","type":"User","site_admin":false},"body":"Два assert в одном методе. И второй проверяет сразу 2 вещи: что произошло присваивание, и что работает вывод в строку. Итого, 3 разных проверки на один тест. Многовато...","created_at":"2013-10-19T06:55:12Z","updated_at":"2013-10-19T06:55:12Z","html_url":"https://github.com/UNN-VMK-Software/agile-development-course/pull/41#discussion_r7078546","pull_request_url":"https://api.github.com/repos/UNN-VMK-Software/agile-development-course/pulls/41","_links":{"self":{"href":"https://api.github.com/repos/UNN-VMK-Software/agile-development-course/pulls/comments/7078546"},"html":{"href":"https://github.com/UNN-VMK-Software/agile-development-course/pull/41#discussion_r7078546"},"pull_request":{"href":"https://api.github.com/repos/UNN-VMK-Software/agile-development-course/pulls/41"}}}}

{"repository":{"description":"Course on Agile Development (in Russian)","homepage":"http://unn-vmk-software.github.io/agile-development-course/","watchers":2,"stargazers":2,"forks":31,"fork":false,"size":82268,"owner":"UNN-VMK-Software","private":false,"open_issues":11,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2013-05-02T13:26:34-07:00","pushed_at":"2013-10-17T22:51:14-07:00","master_branch":"master","organization":"UNN-VMK-Software"},"actor_attributes":{"type":"User","name":"Kirill Kornyakov","company":"Itseez, UNN","location":"Nizhny Novgorod, Russia","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/UNN-VMK-Software/agile-development-course/pull/41#discussion_r7078546"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/3154012","id":3154012,"body":"Please revert this gitignore change -- I'll take care of it with other cleanup work I'm doing on CLC-1349. ","diff_hunk":"@@ -36,3 +36,6 @@ app/assets/stylesheets/application.css\n \n # Ignore processed VCR files\n /fixtures/vcr_cassettes/*.json\n+\n+# Ignore raw VCR files\n+/fixtures/raw_vcr_recordings/*.json","path":".gitignore","position":6,"original_position":6,"commit_id":"3907d5fcf56cd171b6b154ec11ee67b2333e56f7","original_commit_id":"3907d5fcf56cd171b6b154ec11ee67b2333e56f7","user":{"login":"ctweney","id":453309,"avatar_url":"https://secure.gravatar.com/avatar/229c86b167f89a3d9f88fa1d1890d236?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"229c86b167f89a3d9f88fa1d1890d236","url":"https://api.github.com/users/ctweney","html_url":"https://github.com/ctweney","followers_url":"https://api.github.com/users/ctweney/followers","following_url":"https://api.github.com/users/ctweney/following","gists_url":"https://api.github.com/users/ctweney/gists{/gist_id}","starred_url":"https://api.github.com/users/ctweney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctweney/subscriptions","organizations_url":"https://api.github.com/users/ctweney/orgs","repos_url":"https://api.github.com/users/ctweney/repos","events_url":"https://api.github.com/users/ctweney/events{/privacy}","received_events_url":"https://api.github.com/users/ctweney/received_events","type":"User"},"created_at":"2013-02-26T15:04:19Z","updated_at":"2013-02-26T15:04:19Z","_links":{"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/3154012"},"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/713#discussion_r3154012"},"pull_request":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/713"}}}}

{"repository":{"description":"","watchers":6,"stargazers":6,"forks":6,"fork":false,"size":1328,"owner":"ets-berkeley-edu","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2012-08-20T09:45:39-07:00","pushed_at":"2013-02-25T15:12:58-08:00","master_branch":"master","organization":"ets-berkeley-edu"},"actor_attributes":{"type":"User","name":"Chris Tweney","company":"UC Berkeley","blog":"ets.berkeley.edu","location":"Berkeley, CA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/ets-berkeley-edu/calcentral/pull/713#discussion_r3154012"}

PullRequestReviewCommentEvent

{"comment":{"commit_id":"b211adf48e88d0c4dd8ccbae7b308057af75ff79","position":5,"updated_at":"2013-01-29T18:52:48Z","original_position":5,"original_commit_id":"b211adf48e88d0c4dd8ccbae7b308057af75ff79","body":"@shacker For now I just copied/pasted this but I'll follow up on it in a next PR.","url":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/2813511","_links":{"html":{"href":"https://github.com/ets-berkeley-edu/calcentral/pull/565#discussion_r2813511"},"self":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/comments/2813511"},"pull_request":{"href":"https://api.github.com/repos/ets-berkeley-edu/calcentral/pulls/565"}},"created_at":"2013-01-29T18:52:48Z","id":2813511,"user":{"following_url":"https://api.github.com/users/christianv/following","events_url":"https://api.github.com/users/christianv/events{/privacy}","type":"User","subscriptions_url":"https://api.github.com/users/christianv/subscriptions","gists_url":"https://api.github.com/users/christianv/gists{/gist_id}","gravatar_id":"7ef7ea08be8b62f753c64405f23aa520","url":"https://api.github.com/users/christianv","received_events_url":"https://api.github.com/users/christianv/received_events","avatar_url":"https://secure.gravatar.com/avatar/7ef7ea08be8b62f753c64405f23aa520?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","id":127199,"followers_url":"https://api.github.com/users/christianv/followers","organizations_url":"https://api.github.com/users/christianv/orgs","starred_url":"https://api.github.com/users/christianv/starred{/owner}{/repo}","login":"christianv","repos_url":"https://api.github.com/users/christianv/repos"},"path":"app/assets/stylesheets/_footer.scss"}}

{"repository":{"watchers":4,"open_issues":3,"owner":"ets-berkeley-edu","has_issues":true,"stargazers":4,"master_branch":"master","has_downloads":true,"organization":"ets-berkeley-edu","fork":false,"size":1168,"has_wiki":true,"created_at":"2012-08-20T09:45:39-07:00","description":"","private":false,"pushed_at":"2013-01-29T08:55:18-08:00","forks":6,"language":"Ruby"},"actor_attributes":{"name":"Christian Vuerings","type":"User","company":"","blog":"http://denbuzze.com","location":"Berkeley, US","email":"[email protected]"},"url":"https://github.com/ets-berkeley-edu/calcentral/pull/565#discussion_r2813511"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/comments/7153211","id":7153211,"diff_hunk":"@@ -0,0 +1,61 @@\n+# A module implementing strong (Dirichlet) boundary conditions.\n+import utils\n+import numpy as np\n+import pyop2 as op2\n+\n+\n+class DirichletBC(object):\n+ '''Implementation of a strong Dirichlet boundary condition.\n+\n+ :arg V: the :class:`FunctionSpace` on which the boundary condition\n+ should be applied.\n+ :arg g: the :class:`GenericFunction` defining the boundary condition","path":"python/firedrake/bcs.py","position":12,"original_position":12,"commit_id":"57c2347ca238c8cdfd194385e38696107b631803","original_commit_id":"57c2347ca238c8cdfd194385e38696107b631803","user":{"login":"kynan","id":346079,"avatar_url":"https://2.gravatar.com/avatar/d178a6201be696c466c41c355c671707?d=https%3A%2F%2Fidenticons.github.com%2F9bb86da02519414f9b33c29045352750.png&r=x","gravatar_id":"d178a6201be696c466c41c355c671707","url":"https://api.github.com/users/kynan","html_url":"https://github.com/kynan","followers_url":"https://api.github.com/users/kynan/followers","following_url":"https://api.github.com/users/kynan/following{/other_user}","gists_url":"https://api.github.com/users/kynan/gists{/gist_id}","starred_url":"https://api.github.com/users/kynan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kynan/subscriptions","organizations_url":"https://api.github.com/users/kynan/orgs","repos_url":"https://api.github.com/users/kynan/repos","events_url":"https://api.github.com/users/kynan/events{/privacy}","received_events_url":"https://api.github.com/users/kynan/received_events","type":"User","site_admin":false},"body":"This probably wants to just be a `Function`?","created_at":"2013-10-23T10:41:15Z","updated_at":"2013-10-23T10:41:15Z","html_url":"https://github.com/firedrakeproject/firedrake/pull/44#discussion_r7153211","pull_request_url":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/44","_links":{"self":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/comments/7153211"},"html":{"href":"https://github.com/firedrakeproject/firedrake/pull/44#discussion_r7153211"},"pull_request":{"href":"https://api.github.com/repos/firedrakeproject/firedrake/pulls/44"}}}}

{"repository":{"description":"Firedrake is an automated system for the portable solution of partial differential equations using the finite element method (FEM)","homepage":"http://firedrakeproject.org","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":6840,"owner":"firedrakeproject","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2013-10-07T06:07:44-07:00","pushed_at":"2013-10-23T03:01:10-07:00","master_branch":"master","organization":"firedrakeproject"},"actor_attributes":{"type":"User","name":"Florian Rathgeber","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/firedrakeproject/firedrake/pull/44#discussion_r7153211"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/gwt-maven-plugin/gwt-maven-plugin/pulls/comments/7881187","id":7881187,"diff_hunk":"@@ -98,56 +89,15 @@\n }\n if ( modules == null )\n {\n- //Use a Set to avoid duplicate when user set src/main/java as <resource>\n- Set<String> mods = new HashSet<String>();\n-\n- Collection<String> sourcePaths = (Collection<String>) getProject().getCompileSourceRoots();\n- for ( String sourcePath : sourcePaths )\n+ List<String> gwtModules = DefaultGwtModuleReader.getGwtModules( getProject(), getLog() );","path":"src/main/java/org/codehaus/mojo/gwt/AbstractGwtModuleMojo.java","position":47,"original_position":47,"commit_id":"e67c7a5e6a440696ef6b535a0c54a6637924ecf9","original_commit_id":"e67c7a5e6a440696ef6b535a0c54a6637924ecf9","user":{"login":"tbroyer","id":173813,"avatar_url":"https://0.gravatar.com/avatar/13753e40e0a6a2ef6b0652e1e05b0af0?d=https%3A%2F%2Fidenticons.github.com%2F991fd8eba91c4e98c9ef9aa04e4342fd.png&r=x","gravatar_id":"13753e40e0a6a2ef6b0652e1e05b0af0","url":"https://api.github.com/users/tbroyer","html_url":"https://github.com/tbroyer","followers_url":"https://api.github.com/users/tbroyer/followers","following_url":"https://api.github.com/users/tbroyer/following{/other_user}","gists_url":"https://api.github.com/users/tbroyer/gists{/gist_id}","starred_url":"https://api.github.com/users/tbroyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbroyer/subscriptions","organizations_url":"https://api.github.com/users/tbroyer/orgs","repos_url":"https://api.github.com/users/tbroyer/repos","events_url":"https://api.github.com/users/tbroyer/events{/privacy}","received_events_url":"https://api.github.com/users/tbroyer/received_events","type":"User","site_admin":false},"body":"Why not use `new DefaultGwtModuleReader(getProject(), getLog(), classpathBuilder).getGwtModules()` ? (possibly building the `DefaultGwtModuleReader` only once and storing it in a field, if possible and useful)","created_at":"2013-11-25T00:34:08Z","updated_at":"2013-11-25T00:34:08Z","html_url":"https://github.com/gwt-maven-plugin/gwt-maven-plugin/pull/68#discussion_r7881187","pull_request_url":"https://api.github.com/repos/gwt-maven-plugin/gwt-maven-plugin/pulls/68","_links":{"self":{"href":"https://api.github.com/repos/gwt-maven-plugin/gwt-maven-plugin/pulls/comments/7881187"},"html":{"href":"https://github.com/gwt-maven-plugin/gwt-maven-plugin/pull/68#discussion_r7881187"},"pull_request":{"href":"https://api.github.com/repos/gwt-maven-plugin/gwt-maven-plugin/pulls/68"}}}}

{"repository":{"description":"","homepage":"mojo.codehaus.org/gwt-maven-plugin","watchers":98,"stargazers":98,"forks":52,"fork":false,"size":2199,"owner":"gwt-maven-plugin","private":false,"open_issues":18,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2011-05-30T00:56:10-07:00","pushed_at":"2013-11-18T00:47:15-08:00","master_branch":"master","organization":"gwt-maven-plugin"},"actor_attributes":{"type":"User","name":"Thomas Broyer","blog":"http://profiles.google.com/t.broyer","location":"Dijon, France","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/gwt-maven-plugin/gwt-maven-plugin/pull/68#discussion_r7881187"}