Datasets:

labofsahil

/

github-event-dataset-2013

like 0

Follow

Sahil 2

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/typekit/webfontloader/pulls/comments/2966815","id":2966815,"body":"I think setup like this should be happening in a `beforeEach` block instead of out in the open at test execution time. Usually, the only thing I place outside of `beforeEach` or `it` blocks are `var` statements so that variables can be shared at the right scope level. Otherwise, the execution time of the setup code isn't explicitly well-defined. Does it all execute when the tests are evaluated, or only once each test is actually run?","path":"spec/ascender/ascenderscript_spec.js","position":20,"original_position":20,"commit_id":"b0ca4ea48f8125149e868667b0ffbe7dabb74e32","original_commit_id":"b0ca4ea48f8125149e868667b0ffbe7dabb74e32","user":{"login":"seanami","id":330111,"avatar_url":"https://secure.gravatar.com/avatar/dac5975436d8cb13bcd53a238a4c9b4e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"dac5975436d8cb13bcd53a238a4c9b4e","url":"https://api.github.com/users/seanami","followers_url":"https://api.github.com/users/seanami/followers","following_url":"https://api.github.com/users/seanami/following","gists_url":"https://api.github.com/users/seanami/gists{/gist_id}","starred_url":"https://api.github.com/users/seanami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanami/subscriptions","organizations_url":"https://api.github.com/users/seanami/orgs","repos_url":"https://api.github.com/users/seanami/repos","events_url":"https://api.github.com/users/seanami/events{/privacy}","received_events_url":"https://api.github.com/users/seanami/received_events","type":"User"},"created_at":"2013-02-11T19:21:41Z","updated_at":"2013-02-11T19:21:41Z","_links":{"self":{"href":"https://api.github.com/repos/typekit/webfontloader/pulls/comments/2966815"},"html":{"href":"https://github.com/typekit/webfontloader/pull/78#discussion_r2966815"},"pull_request":{"href":"https://api.github.com/repos/typekit/webfontloader/pulls/78"}}}}

{"repository":{"description":"WebFont Loader gives you added control when using linked fonts via @font-face.","homepage":"","watchers":663,"stargazers":663,"forks":49,"fork":false,"size":575,"owner":"typekit","private":false,"open_issues":7,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2010-04-20T17:54:16-07:00","pushed_at":"2013-02-11T05:04:20-08:00","organization":"typekit"},"actor_attributes":{"name":"Sean McBride","company":"Typekit","blog":"http://seanmcb.com","location":"San Francisco, CA","type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/typekit/webfontloader/pull/78#discussion_r2966815"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/vrapper/vrapper/pulls/comments/4605218","id":4605218,"body":"Short answer: my weekend ended :-)\r\n\r\nI wanted to get a working prototype so I could play with it at work and get as much feedback from you guys.\r\nI'm planning to get rid of `msplit/mvsplit` in favor of `split!/vsplit!`.","diff_hunk":"@@ -199,6 +218,22 @@ public Object evaluate(EditorAdaptor vim, Queue<String> command) {\n mapping.add(\"set\", buildConfigEvaluator());\n mapping.add(\"source\", sourceConfigFile);\n // save, close\n+ mapping.add(\"vsplit\", vsplitEditor);\n+ mapping.add(\"split\", hsplitEditor);\n+ mapping.add(\"mvsplit\", vsplitMoveEditor);\n+ mapping.add(\"msplit\", hsplitMoveEditor);\n+ mapping.add(\"wincmd_h\", switchEditorLeft);\n+ mapping.add(\"wincmd_l\", switchEditorRight);\n+ mapping.add(\"wincmd_k\", switchEditorUp);\n+ mapping.add(\"wincmd_j\", switchEditorDown);\n+ mapping.add(\"wincmd_H\", moveEditorLeft);\n+ mapping.add(\"wincmd_L\", moveEditorRight);\n+ mapping.add(\"wincmd_K\", moveEditorUp);\n+ mapping.add(\"wincmd_J\", moveEditorDown);\n+ mapping.add(\"wincmd_Hc\", cloneEditorLeft);\n+ mapping.add(\"wincmd_Lc\", cloneEditorRight);\n+ mapping.add(\"wincmd_Kc\", cloneEditorUp);\n+ mapping.add(\"wincmd_Jc\", cloneEditorDown);","path":"net.sourceforge.vrapper.core/src/net/sourceforge/vrapper/vim/modes/commandline/CommandLineParser.java","position":60,"original_position":60,"commit_id":"57b50da0eb51e6ffb9dc008c58b90f98654b02e2","original_commit_id":"57b50da0eb51e6ffb9dc008c58b90f98654b02e2","user":{"login":"igrekster","id":1772013,"avatar_url":"https://secure.gravatar.com/avatar/7d957da7ce44a9b881e1ae484e165f7f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"7d957da7ce44a9b881e1ae484e165f7f","url":"https://api.github.com/users/igrekster","html_url":"https://github.com/igrekster","followers_url":"https://api.github.com/users/igrekster/followers","following_url":"https://api.github.com/users/igrekster/following{/other_user}","gists_url":"https://api.github.com/users/igrekster/gists{/gist_id}","starred_url":"https://api.github.com/users/igrekster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igrekster/subscriptions","organizations_url":"https://api.github.com/users/igrekster/orgs","repos_url":"https://api.github.com/users/igrekster/repos","events_url":"https://api.github.com/users/igrekster/events{/privacy}","received_events_url":"https://api.github.com/users/igrekster/received_events","type":"User"},"created_at":"2013-06-09T23:09:39Z","updated_at":"2013-06-09T23:09:39Z","html_url":"https://github.com/vrapper/vrapper/pull/221#discussion_r4605218","pull_request_url":"https://api.github.com/repos/vrapper/vrapper/pulls/221","_links":{"self":{"href":"https://api.github.com/repos/vrapper/vrapper/pulls/comments/4605218"},"html":{"href":"https://github.com/vrapper/vrapper/pull/221#discussion_r4605218"},"pull_request":{"href":"https://api.github.com/repos/vrapper/vrapper/pulls/221"}}}}

{"repository":{"description":"Vim-like editing in Eclipse","homepage":"http://vrapper.sourceforge.net/","watchers":348,"stargazers":348,"forks":57,"fork":false,"size":1708,"owner":"vrapper","private":false,"open_issues":24,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2010-07-13T13:15:53-07:00","pushed_at":"2013-06-07T16:17:55-07:00","master_branch":"master","organization":"vrapper"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/vrapper/vrapper/pull/221#discussion_r4605218"}

PullRequestReviewCommentEvent

{"comment":{"updated_at":"2013-01-25T11:23:28Z","url":"https://api.github.com/repos/webinos/Webinos-Platform/pulls/comments/2772902","body":"indentation","original_commit_id":"ecafefea4e17e75ef6ec2e88ce9891e50d8d9b5d","_links":{"pull_request":{"href":"https://api.github.com/repos/webinos/Webinos-Platform/pulls/431"},"html":{"href":"https://github.com/webinos/Webinos-Platform/pull/431#discussion_r2772902"},"self":{"href":"https://api.github.com/repos/webinos/Webinos-Platform/pulls/comments/2772902"}},"original_position":136,"created_at":"2013-01-25T11:23:28Z","position":136,"commit_id":"ecafefea4e17e75ef6ec2e88ce9891e50d8d9b5d","user":{"events_url":"https://api.github.com/users/habibvirji/events{/privacy}","login":"habibvirji","received_events_url":"https://api.github.com/users/habibvirji/received_events","url":"https://api.github.com/users/habibvirji","organizations_url":"https://api.github.com/users/habibvirji/orgs","gists_url":"https://api.github.com/users/habibvirji/gists{/gist_id}","starred_url":"https://api.github.com/users/habibvirji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/habibvirji/subscriptions","following_url":"https://api.github.com/users/habibvirji/following","type":"User","followers_url":"https://api.github.com/users/habibvirji/followers","id":1446130,"repos_url":"https://api.github.com/users/habibvirji/repos","avatar_url":"https://secure.gravatar.com/avatar/1931510ec248305f4f66bd94026cc69f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"1931510ec248305f4f66bd94026cc69f"},"path":"webinos/core/pzp/lib/pzp_sessionHandling.js","id":2772902}}

{"repository":{"watchers":62,"owner":"webinos","has_wiki":false,"stargazers":62,"open_issues":10,"homepage":"http://www.webinos.org/","fork":false,"size":347188,"has_issues":false,"created_at":"2012-04-10T07:14:19-07:00","description":"","private":false,"has_downloads":true,"pushed_at":"2013-01-25T02:59:17-08:00","forks":48,"language":"JavaScript","organization":"webinos"},"actor_attributes":{"location":"UK","name":"Habib Virji","type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/webinos/Webinos-Platform/pull/431#discussion_r2772902"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/8144261","id":8144261,"diff_hunk":"@@ -0,0 +1,253 @@\n+<?php\n+/**\n+ * @link http://www.yiiframework.com/\n+ * @copyright Copyright (c) 2008 Yii Software LLC\n+ * @license http://www.yiiframework.com/license/\n+ */\n+\n+namespace yii\\mongo;\n+\n+use yii\\base\\Component;\n+use yii\\base\\InvalidConfigException;\n+use Yii;\n+\n+/**\n+ * Connection represents a connection to a MongoDb server.\n+ *\n+ * Connection works together with [[Database]] and [[Collection]] to provide data access\n+ * to the Mongo database. They are wrappers of the [[MongoDB PHP extension]](http://us1.php.net/manual/en/book.mongo.php).\n+ *\n+ * To establish a DB connection, set [[dsn]] and then call [[open()]] to be true.\n+ *\n+ * The following example shows how to create a Connection instance and establish\n+ * the DB connection:\n+ *\n+ * ~~~\n+ * $connection = new \\yii\\mongo\\Connection([\n+ * 'dsn' => $dsn,\n+ * ]);\n+ * $connection->open();\n+ * ~~~\n+ *\n+ * After the Mongo connection is established, one can access Mongo databases and collections:\n+ *\n+ * ~~~\n+ * $database = $connection->getDatabase('my_mongo_db');\n+ * $collection = $database->getCollection('customer');\n+ * $collection->insert(['name' => 'John Smith', 'status' => 1]);\n+ * ~~~\n+ *\n+ * You can work with several different databases at the same server using this class.\n+ * However, while it is unlikely your application will actually need it, the Connection class\n+ * provides ability to use [[defaultDatabaseName]] as well as a shortcut method [[getCollection()]]\n+ * to retrieve a particular collection instance:\n+ *\n+ * ~~~\n+ * // get collection 'customer' from default database:\n+ * $collection = $connection->getCollection('customer');\n+ * // get collection 'customer' from database 'mydatabase':\n+ * $collection = $connection->getCollection(['mydatabase', 'customer']);\n+ * ~~~\n+ *\n+ * Connection is often used as an application component and configured in the application\n+ * configuration like the following:\n+ *\n+ * ~~~\n+ * [\n+ *\t 'components' => [\n+ *\t\t 'mongo' => [\n+ *\t\t\t 'class' => '\\yii\\mongo\\Connection',\n+ *\t\t\t 'dsn' => 'mongodb://developer:password@localhost:27017/mydatabase',\n+ *\t\t ],\n+ *\t ],\n+ * ]\n+ * ~~~\n+ *\n+ * @property boolean $isActive Whether the Mongo connection is established. This property is read-only.\n+ * is read-only.\n+ *\n+ * @author Paul Klimov <[email protected]>\n+ * @since 2.0\n+ */\n+class Connection extends Component\n+{\n+\t/**\n+\t * @var string host:port\n+\t *\n+\t * Correct syntax is:\n+\t * mongodb://[username:password@]host1[:port1][,host2[:port2:],...][/dbname]\n+\t * For example:\n+\t * mongodb://localhost:27017\n+\t * mongodb://developer:password@localhost:27017\n+\t * mongodb://developer:password@localhost:27017/mydatabase\n+\t */\n+\tpublic $dsn;\n+\t/**\n+\t * @var array connection options.\n+\t * for example:\n+\t * ~~~\n+\t * [\n+\t * 'persist' => true, // use persistent connection\n+\t * 'socketTimeoutMS' => 1000, // how long a send or receive on a socket can take before timing out\n+\t * 'journal' => true // block write operations until the journal be flushed the to disk\n+\t * ]\n+\t * ~~~\n+\t */\n+\tpublic $options = [];\n+\t/**\n+\t * @var string name of the Mongo database to use by default.\n+\t * If this field left blank, connection instance will attempt to determine it from\n+\t * [[options]] and [[dsn]] automatically, if needed.\n+\t */\n+\tpublic $defaultDatabaseName;\n+\t/**\n+\t * @var \\MongoClient mongo client instance.\n+\t */\n+\tpublic $mongoClient;\n+\t/**\n+\t * @var Database[] list of Mongo databases\n+\t */\n+\tprivate $_databases = [];\n+\n+\t/**\n+\t * Returns the Mongo collection with the given name.\n+\t * @param string|null $name collection name, if null default one will be used.\n+\t * @param boolean $refresh whether to reload the table schema even if it is found in the cache.","path":"extensions/mongo/Connection.php","position":115,"original_position":115,"commit_id":"062e138c836c2a80e61d1261f4af8fd72a6e6692","original_commit_id":"062e138c836c2a80e61d1261f4af8fd72a6e6692","user":{"login":"Sammaye","id":323996,"avatar_url":"https://2.gravatar.com/avatar/2c4991a0f5c50e48aaaa694c5ff496e0?d=https%3A%2F%2Fidenticons.github.com%2Fe89c036a60adaf845eb712c3710a6a43.png&r=x","gravatar_id":"2c4991a0f5c50e48aaaa694c5ff496e0","url":"https://api.github.com/users/Sammaye","html_url":"https://github.com/Sammaye","followers_url":"https://api.github.com/users/Sammaye/followers","following_url":"https://api.github.com/users/Sammaye/following{/other_user}","gists_url":"https://api.github.com/users/Sammaye/gists{/gist_id}","starred_url":"https://api.github.com/users/Sammaye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sammaye/subscriptions","organizations_url":"https://api.github.com/users/Sammaye/orgs","repos_url":"https://api.github.com/users/Sammaye/repos","events_url":"https://api.github.com/users/Sammaye/events{/privacy}","received_events_url":"https://api.github.com/users/Sammaye/received_events","type":"User","site_admin":false},"body":"Probably better to say connection since the PHP driver makes a connection per credentials per database so when you refresh the database by re-selecting it it is effectively recreating the connections.","created_at":"2013-12-05T20:51:56Z","updated_at":"2013-12-05T20:51:56Z","html_url":"https://github.com/yiisoft/yii2/pull/1438#discussion_r8144261","pull_request_url":"https://api.github.com/repos/yiisoft/yii2/pulls/1438","_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/8144261"},"html":{"href":"https://github.com/yiisoft/yii2/pull/1438#discussion_r8144261"},"pull_request":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/1438"}}}}

{"repository":{"description":"Yii 2 framework main development repo","homepage":"http://www.yiiframework.com","watchers":1436,"stargazers":1436,"forks":563,"fork":false,"size":24124,"owner":"yiisoft","private":false,"open_issues":119,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2012-02-13T07:32:36-08:00","pushed_at":"2013-12-05T11:50:13-08:00","master_branch":"master","organization":"yiisoft"},"actor_attributes":{"type":"User","blog":"sammaye.wordpress.com","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/yiisoft/yii2/pull/1438#discussion_r8144261"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/8579378","id":8579378,"diff_hunk":"@@ -39,6 +39,26 @@ The output of an action is what the method returns. The return value will be han\n component which can convert the output to differnet formats such as JSON for example. The default behavior\n is to output the value unchanged though.\n \n+You also can disable CSRF validation per controller, by setting its property:","path":"docs/guide/controller.md","position":4,"original_position":4,"commit_id":"5c2064bd949221e4e7fe3ea02edae5025c2c95dd","original_commit_id":"5c2064bd949221e4e7fe3ea02edae5025c2c95dd","user":{"login":"qiangxue","id":993322,"avatar_url":"https://gravatar.com/avatar/f5897d0a3ee1c390cce0da65e08044e9?d=https%3A%2F%2Fidenticons.github.com%2F46aea18590b8f6c72658c9d26f4ebabd.png&r=x","gravatar_id":"f5897d0a3ee1c390cce0da65e08044e9","url":"https://api.github.com/users/qiangxue","html_url":"https://github.com/qiangxue","followers_url":"https://api.github.com/users/qiangxue/followers","following_url":"https://api.github.com/users/qiangxue/following{/other_user}","gists_url":"https://api.github.com/users/qiangxue/gists{/gist_id}","starred_url":"https://api.github.com/users/qiangxue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiangxue/subscriptions","organizations_url":"https://api.github.com/users/qiangxue/orgs","repos_url":"https://api.github.com/users/qiangxue/repos","events_url":"https://api.github.com/users/qiangxue/events{/privacy}","received_events_url":"https://api.github.com/users/qiangxue/received_events","type":"User","site_admin":false},"body":"per controller and/or action","created_at":"2013-12-29T17:36:42Z","updated_at":"2013-12-29T17:36:42Z","html_url":"https://github.com/yiisoft/yii2/pull/1689#discussion_r8579378","pull_request_url":"https://api.github.com/repos/yiisoft/yii2/pulls/1689","_links":{"self":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/comments/8579378"},"html":{"href":"https://github.com/yiisoft/yii2/pull/1689#discussion_r8579378"},"pull_request":{"href":"https://api.github.com/repos/yiisoft/yii2/pulls/1689"}}}}

{"repository":{"description":"Yii 2 framework main development repo","homepage":"http://www.yiiframework.com","watchers":1528,"stargazers":1528,"forks":639,"fork":false,"size":25461,"owner":"yiisoft","private":false,"open_issues":144,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2012-02-13T07:32:36-08:00","pushed_at":"2013-12-29T07:31:35-08:00","master_branch":"master","organization":"yiisoft"},"actor_attributes":{"type":"User","name":"Qiang Xue","blog":"http://www.yiiframework.com","location":"Virginia, U.S.A.","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/yiisoft/yii2/pull/1689#discussion_r8579378"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/zendesk/kasket/pulls/comments/7863838","id":7863838,"diff_hunk":"@@ -22,7 +22,7 @@ def to_kasket_query(klass, binds = [])\n end\n \n query[:key] = klass.kasket_key_for(query[:attributes])\n- query[:key] << '/first' if query[:limit] == 1 && query[:index] != [:id]\n+ query[:key] << '/first' if query[:limit] == 1 && query[:index].last != :id","path":"lib/kasket/select_manager_mixin.rb","position":5,"original_position":5,"commit_id":"93ab156b99ba5764844a3147b99bacf46c4da959","original_commit_id":"93ab156b99ba5764844a3147b99bacf46c4da959","user":{"login":"staugaard","id":4300,"avatar_url":"https://0.gravatar.com/avatar/20b2ca7b0d0e17062702c6bc48007e5b?d=https%3A%2F%2Fidenticons.github.com%2Facf666483bc8723fae7feda6f6a9cb7a.png&r=x","gravatar_id":"20b2ca7b0d0e17062702c6bc48007e5b","url":"https://api.github.com/users/staugaard","html_url":"https://github.com/staugaard","followers_url":"https://api.github.com/users/staugaard/followers","following_url":"https://api.github.com/users/staugaard/following{/other_user}","gists_url":"https://api.github.com/users/staugaard/gists{/gist_id}","starred_url":"https://api.github.com/users/staugaard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/staugaard/subscriptions","organizations_url":"https://api.github.com/users/staugaard/orgs","repos_url":"https://api.github.com/users/staugaard/repos","events_url":"https://api.github.com/users/staugaard/events{/privacy}","received_events_url":"https://api.github.com/users/staugaard/received_events","type":"User","site_admin":false},"body":"why `.last` ? is `!query[:index].include?(:id)` maybe better?","created_at":"2013-11-22T18:17:56Z","updated_at":"2013-11-22T18:17:56Z","html_url":"https://github.com/zendesk/kasket/pull/9#discussion_r7863838","pull_request_url":"https://api.github.com/repos/zendesk/kasket/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/zendesk/kasket/pulls/comments/7863838"},"html":{"href":"https://github.com/zendesk/kasket/pull/9#discussion_r7863838"},"pull_request":{"href":"https://api.github.com/repos/zendesk/kasket/pulls/9"}}}}

{"repository":{"description":"A caching layer for ActiveRecord. Puts a cap on your queries!","homepage":"","watchers":4,"stargazers":4,"forks":0,"fork":true,"size":727,"owner":"zendesk","private":false,"open_issues":2,"has_issues":false,"has_downloads":false,"has_wiki":false,"language":"Ruby","created_at":"2013-02-19T15:57:02-08:00","pushed_at":"2013-11-21T14:23:29-08:00","master_branch":"master","organization":"zendesk"},"actor_attributes":{"type":"User","name":"Mick Staugaard","company":"Zendesk, PodcastMachine","blog":"http://mick.staugaard.com","location":"San Francisco","email":"[email protected]"},"url":"https://github.com/zendesk/kasket/pull/9#discussion_r7863838"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/zendesk/radar_client/pulls/comments/5126002","id":5126002,"body":"Well, either unshift() should be push or shift() should be pop() on 319, I guess. I will make the change.","diff_hunk":"@@ -310,65 +295,44 @@ Client.prototype._memorize = function(message) {\n }\n };\n \n-Client.prototype._restore = function(done) {\n- var client = this, total = 0, to, message;\n-\n- function ack() {\n- client._waitCounter--;\n- if(client._waitCounter === 0) {\n- done();\n- }\n- }\n-\n- function restoreSubscription(to){\n- var item = client._subscriptions[to];\n- client._waitCounter++;\n- total++;\n- setTimeout(function() {\n- client[item](to, ack);\n- }, 1);\n- }\n+Client.prototype._restore = function() {\n+ var item, i, to, message;\n+ if (this._restoreRequired) {\n+ this._restoreRequired = false;\n \n- function restorePresence(to){\n- client._waitCounter++;\n- total++;\n- setTimeout(function() {\n- client.set(to, client._presences[to], ack);\n- }, 1);\n- }\n+ log.info('restore-subscriptions');\n \n+ for (to in this._subscriptions) {\n+ if (this._subscriptions.hasOwnProperty(to)) {\n+ item = this._subscriptions[to];\n+ this[item](to);\n+ }\n+ }\n \n- log.info('restore-subscriptions');\n- for (to in client._subscriptions) {\n- if (!client._subscriptions.hasOwnProperty(to)) { continue; }\n- restoreSubscription(to);\n- }\n+ for (to in this._presences) {\n+ if (this._presences.hasOwnProperty(to)) {\n+ this.set(to, this._presences[to]);\n+ }\n+ }\n \n- for (to in client._presences) {\n- if (!client._presences.hasOwnProperty(to)) { continue; }\n- restorePresence(to);\n- }\n- // if we didn't do anything, just trigger done()\n- if(total === 0) {\n- done();\n+ while (this._queuedMessages.length) {\n+ this._write(this._queuedMessages.shift());\n+ }\n }\n };\n \n Client.prototype._sendMessage = function(message) {\n this._memorize(message);\n+\n if (this._socket && this.manager.is('activated')) {\n this._socket.sendPacket('message', JSON.stringify(message));\n } else if (this._isConfigured) {\n- this._queue(message);\n+ this._restoreRequired = true;\n+ this._queuedMessages.unshift(message);","path":"dist/radar_client.js","position":163,"original_position":163,"commit_id":"1da6a9845bf3f2a822570ff0cb87ef830e583786","original_commit_id":"1da6a9845bf3f2a822570ff0cb87ef830e583786","user":{"login":"samshull","id":181527,"avatar_url":"https://secure.gravatar.com/avatar/db556ca7eacf0a64df0f2dfd254dfd85?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"db556ca7eacf0a64df0f2dfd254dfd85","url":"https://api.github.com/users/samshull","html_url":"https://github.com/samshull","followers_url":"https://api.github.com/users/samshull/followers","following_url":"https://api.github.com/users/samshull/following{/other_user}","gists_url":"https://api.github.com/users/samshull/gists{/gist_id}","starred_url":"https://api.github.com/users/samshull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samshull/subscriptions","organizations_url":"https://api.github.com/users/samshull/orgs","repos_url":"https://api.github.com/users/samshull/repos","events_url":"https://api.github.com/users/samshull/events{/privacy}","received_events_url":"https://api.github.com/users/samshull/received_events","type":"User"},"created_at":"2013-07-10T20:19:21Z","updated_at":"2013-07-10T20:19:21Z","html_url":"https://github.com/zendesk/radar_client/pull/6#discussion_r5126002","pull_request_url":"https://api.github.com/repos/zendesk/radar_client/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/zendesk/radar_client/pulls/comments/5126002"},"html":{"href":"https://github.com/zendesk/radar_client/pull/6#discussion_r5126002"},"pull_request":{"href":"https://api.github.com/repos/zendesk/radar_client/pulls/6"}}}}

{"repository":{"description":"High level API and backend for writing web apps that use push messaging ","homepage":"http://radar.zendesk.com","watchers":6,"stargazers":6,"forks":4,"fork":false,"size":368,"owner":"zendesk","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-10-02T13:16:42-07:00","pushed_at":"2013-07-10T10:40:44-07:00","master_branch":"master","organization":"zendesk"},"actor_attributes":{"type":"User","name":"Sam Shull","blog":"https://plus.google.com/111307290890060734642/about","location":"Fort Wayne, IN, USA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/zendesk/radar_client/pull/6#discussion_r5126002"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/AppScale/appscale/pulls/comments/3823285","id":3823285,"body":"done","diff_hunk":"@@ -0,0 +1,625 @@\n+import datetime\n+import hashlib\n+import os\n+import re\n+import sys\n+import tempfile\n+import urllib\n+import SOAPpy\n+if 'TOOLS_PATH' in os.environ:\n+ sys.path.append(os.environ['TOOLS_PATH']+'/lib')\n+else:\n+ sys.path.append('/usr/local/appscale-tools/lib')\n+from appcontroller_client import AppControllerClient\n+from local_state import LocalState\n+\n+from google.appengine.api import users\n+\n+from secret_key import GLOBAL_SECRET_KEY\n+\n+class AppHelperException(Exception):\n+ \"\"\" An exception thrown if the requested helper function failed. \"\"\"\n+ pass\n+\n+class AppDashboardHelper:\n+ \"\"\" Helper class to get info from AppScale. \"\"\"\n+\n+ # Name of the cookie used for login.\n+ DEV_APPSERVER_LOGIN_COOKIE = 'dev_appserver_login'\n+\n+ def __init__(self, response):\n+ \"\"\" Constructor. \n+\n+ Args:\n+ response: the webapp2 response object of the parent of ths AppDashboard\n+ object.\n+ \"\"\"\n+ self.server = None\n+ self.uaserver = None\n+ self.response = response\n+ self.cache = {}\n+\n+ def get_server(self):\n+ \"\"\" Connects to the AppControler and returns the connection handle.\n+\n+ Returns:\n+ An AppControllerClient object.\n+ \"\"\"\n+ if self.server is None:\n+ self.server = AppControllerClient('127.0.0.1', GLOBAL_SECRET_KEY)\n+ return self.server\n+\n+ def get_uaserver(self):\n+ \"\"\" Connects to the UserAppServer and returns the connection handle\n+\n+ Returns:\n+ An SOAPpy object that is connected to the UserAppServer.\n+ \"\"\"\n+ if self.uaserver is None:\n+ acc = self.get_server()\n+ uas_host = acc.get_uaserver_host(False)\n+ self.uaserver = SOAPpy.SOAPProxy('https://%s:%s' % (uas_host, 4343))\n+ return self.uaserver\n+\n+ def get_user_capabilities(self, email):\n+ \"\"\" Query the AppController and return the capabilites of the user.\n+\n+ Args:\n+ email: a str containing the email of the user being queried.\n+ Returns:\n+ A list of strs containing the capabilities of the user being queried.\n+ \"\"\"\n+ if 'user_caps' in self.cache:\n+ if email in self.cache['user_caps']:\n+ return self.cache['user_caps'][email]\n+ else:\n+ self.cache['user_caps'] = {}\n+ try:\n+ uas = self.get_uaserver()\n+ caps_list = uas.get_capabilities(email, GLOBAL_SECRET_KEY).split(':')\n+ self.cache['user_caps'][email] = caps_list\n+ return caps_list\n+ except Exception as e:\n+ sys.stderr.write(\"AppDashboardHelper.get_user_capabilities() caught \"\\\n+ \"Exception \" + str(type(e)) + \":\" + str(e))\n+\n+\n+ def get_status_info(self):\n+ \"\"\" Query the AppController and get the status informatoin for all the \n+ server in the cluster.\n+\n+ Returns:\n+ A list of dicts containing the status information on each server.\n+ \"\"\"\n+ try:\n+ acc = self.get_server()\n+ node = acc.get_stats()\n+ return node\n+ except Exception as e:\n+ sys.stderr.write(\"AppDashboardHelper.get_status_info() caught \"\\\n+ \"Exception \" + str(type(e)) + \":\" + str(e))\n+ return []\n+\n+ def get_host_with_role(self, role):\n+ \"\"\"Searches through the local metadata to see which virtual machine runs the\n+ specified role.\n+\n+ Args:\n+ role: A str indicating the role to search for.\n+ Returns:\n+ A str containing the host that runs the specified service.\n+ \"\"\"\n+ acc = self.get_server()\n+ if 'get_role_info' in self.cache:\n+ node = self.cache['get_role_info']\n+ else:\n+ try:\n+ nodes = acc.get_role_info()\n+ except Exception as e:\n+ sys.stderr.write(\"AppDashboardHelper.get_host_with_role() caught \"\\\n+ \"Exception \" + str(type(e)) + \":\" + str(e))\n+ return ''\n+ for node in nodes:\n+ if role in node['jobs']:\n+ return node['public_ip']\n+\n+ def get_head_node_ip(self):\n+ \"\"\" Query the AppController and return the ip of the head node. \n+\n+ Returns:\n+ A str containing the ip of the head node.\n+ \"\"\"\n+ return self.get_host_with_role('shadow')\n+\n+ def get_login_host(self):\n+ \"\"\" Querys the AppController and returns the ip of the login host. \n+\n+ Returns:\n+ A str containing the host that runs the login service.\n+ \"\"\"\n+ return self.get_host_with_role('login')\n+\n+ def get_monitoring_url(self):\n+ \"\"\" Querys the AppController and returns the url of the monitoring service. \n+\n+ Returns:\n+ A str containing the url of the monitoring service.\n+ \"\"\"\n+ return \"http://\"+self.get_head_node_ip()+\":8050\"\n+\n+ def get_application_info(self):\n+ \"\"\" Querys the AppController and returns the list of applications running on\n+ this cloud.\n+ \n+ Returns:\n+ A list of tupels, the first element is the app name, the second element is\n+ the url of the app (if running) or None (if loading).\n+ \"\"\"\n+ status = self.get_status_info()\n+ ret = {}\n+ if len(status) > 0:\n+ for app in status[0]['apps'].keys():\n+ if app == 'none':\n+ break\n+ if status[0]['apps'][app]:\n+ try:\n+ ret[app] = \"http://\" + self.get_login_host() + \":\"\\\n+ + str(self.get_app_port(app))\n+ except AppHelperException:\n+ ret[app] = None\n+ else:\n+ ret[app] = None\n+ return ret\n+ \n+ def get_database_info(self):\n+ \"\"\" Querys the AppController and returns the database information of this\n+ cloud.\n+\n+ Return:\n+ A dict containing the database information.\n+ \"\"\"\n+ try:\n+ acc = self.get_server()\n+ return acc.get_database_information()\n+ except Exception as e:\n+ sys.stderr.write(\"AppDashboardHelper.get_database_info() caught \"\n+ \"Exception \" + str(type(e)) + \":\" + str(e))\n+ return {}\n+\n+ def get_service_info(self):\n+ \"\"\" Querys the AppController and returns a list of API services running on\n+ this cloud.\n+\n+ Returns:\n+ A dict where the keys are the names of the services, and the values or the\n+ status of that service.\n+ \"\"\"\n+ try:\n+ acc = self.get_server()\n+ return acc.get_api_status()\n+ except Exception as e:\n+ sys.stderr.write(\"AppDashboardHelper.get_service_info() caught Exception\"\\\n+ + str(type(e)) + \":\" + str(e))\n+ return {}\n+\n+ def get_app_port(self, appname): \n+ \"\"\" Querys the UserAppServer and returns the port that the app is running\n+ on.\n+ \n+ Args:\n+ appname: name of the app being queried.","path":"AppDashboard/lib/app_dashboard_helper.py","position":210,"original_position":210,"commit_id":"ec12fc45fef9b645b6da41eff2358f71b334a665","original_commit_id":"fec41698d8e40e234f253e469c160e66b1a59168","user":{"login":"briandrawert","id":1413538,"avatar_url":"https://secure.gravatar.com/avatar/449d0547b4e73ade7df6107ecb34eaeb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"449d0547b4e73ade7df6107ecb34eaeb","url":"https://api.github.com/users/briandrawert","html_url":"https://github.com/briandrawert","followers_url":"https://api.github.com/users/briandrawert/followers","following_url":"https://api.github.com/users/briandrawert/following","gists_url":"https://api.github.com/users/briandrawert/gists{/gist_id}","starred_url":"https://api.github.com/users/briandrawert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briandrawert/subscriptions","organizations_url":"https://api.github.com/users/briandrawert/orgs","repos_url":"https://api.github.com/users/briandrawert/repos","events_url":"https://api.github.com/users/briandrawert/events{/privacy}","received_events_url":"https://api.github.com/users/briandrawert/received_events","type":"User"},"created_at":"2013-04-16T23:09:22Z","updated_at":"2013-04-16T23:09:22Z","html_url":"https://github.com/AppScale/appscale/pull/390#discussion_r3823285","pull_request_url":"https://api.github.com/repos/AppScale/appscale/pulls/390","_links":{"self":{"href":"https://api.github.com/repos/AppScale/appscale/pulls/comments/3823285"},"html":{"href":"https://github.com/AppScale/appscale/pull/390#discussion_r3823285"},"pull_request":{"href":"https://api.github.com/repos/AppScale/appscale/pulls/390"}}}}

{"repository":{"description":"The Open Source Implementation of Google App Engine -- Take your apps everywhere.","homepage":"http://www.appscale.com","watchers":131,"stargazers":131,"forks":38,"fork":false,"size":888,"owner":"AppScale","private":false,"open_issues":93,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-03-22T15:35:50-07:00","pushed_at":"2013-04-16T13:27:42-07:00","master_branch":"testing","organization":"AppScale"},"actor_attributes":{"type":"User","name":"Brian Drawert","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/AppScale/appscale/pull/390#discussion_r3823285"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/BlueText/bigsky/pulls/comments/6930612","id":6930612,"diff_hunk":"@@ -0,0 +1,11 @@\n+package bigsky;\n+\n+import javax.swing.DefaultListModel;\n+\n+public class Global {\n+\t//These are used by the contactList or contact search is one way or another","path":"bigsky/src/bigsky/Global.java","position":6,"original_position":6,"commit_id":"7ff516545b7686f07f5c4bb381c28dfbd2ad0bc4","original_commit_id":"7ff516545b7686f07f5c4bb381c28dfbd2ad0bc4","user":{"login":"travisreed-wf","id":2651858,"avatar_url":"https://2.gravatar.com/avatar/94fadf75a2e2d103b04358d5062e4d8c?d=https%3A%2F%2Fidenticons.github.com%2F4ac9bc830332b8fc604bc2ba2538a35f.png","gravatar_id":"94fadf75a2e2d103b04358d5062e4d8c","url":"https://api.github.com/users/travisreed-wf","html_url":"https://github.com/travisreed-wf","followers_url":"https://api.github.com/users/travisreed-wf/followers","following_url":"https://api.github.com/users/travisreed-wf/following{/other_user}","gists_url":"https://api.github.com/users/travisreed-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/travisreed-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travisreed-wf/subscriptions","organizations_url":"https://api.github.com/users/travisreed-wf/orgs","repos_url":"https://api.github.com/users/travisreed-wf/repos","events_url":"https://api.github.com/users/travisreed-wf/events{/privacy}","received_events_url":"https://api.github.com/users/travisreed-wf/received_events","type":"User","site_admin":false},"body":"I created this file because *@#& security. Also, this is way easier than trying to pass stuff around. If you guys have any variables you want to make global put them in here","created_at":"2013-10-12T04:11:47Z","updated_at":"2013-10-12T04:11:47Z","html_url":"https://github.com/BlueText/bigsky/pull/11#discussion_r6930612","pull_request_url":"https://api.github.com/repos/BlueText/bigsky/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/BlueText/bigsky/pulls/comments/6930612"},"html":{"href":"https://github.com/BlueText/bigsky/pull/11#discussion_r6930612"},"pull_request":{"href":"https://api.github.com/repos/BlueText/bigsky/pulls/11"}}}}

{"repository":{"description":"Windows side of BlueText","homepage":"","watchers":0,"stargazers":0,"forks":5,"fork":false,"size":286,"owner":"BlueText","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2013-09-09T09:29:08-07:00","pushed_at":"2013-10-11T20:09:11-07:00","master_branch":"master","organization":"BlueText"},"actor_attributes":{"type":"User","name":"Travis Reed","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/BlueText/bigsky/pull/11#discussion_r6930612"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/Catrobat/Catroid/pulls/comments/6599368","id":6599368,"body":":+1:\r\nhttp://stackoverflow.com/a/6667365","diff_hunk":"@@ -151,7 +151,11 @@ public void create() {\n \t\tvirtualWidthHalf = virtualWidth / 2;\n \t\tvirtualHeightHalf = virtualHeight / 2;\n \n-\t\tscreenMode = ScreenModes.STRETCH;\n+\t\tif (ProjectManager.getInstance().getCurrentProject().getScreenMode().equals(\"STRETCH\")) {","path":"catroid/src/org/catrobat/catroid/stage/StageListener.java","position":5,"original_position":5,"commit_id":"182010453fb36cfa52cb8036c8996d7b966650de","original_commit_id":"182010453fb36cfa52cb8036c8996d7b966650de","user":{"login":"robertpainsi","id":1794599,"avatar_url":"https://1.gravatar.com/avatar/1cf94d396fb014db82213488618a618c?d=https%3A%2F%2Fidenticons.github.com%2F1a8e95f443abd19be032fe551b14974e.png","gravatar_id":"1cf94d396fb014db82213488618a618c","url":"https://api.github.com/users/robertpainsi","html_url":"https://github.com/robertpainsi","followers_url":"https://api.github.com/users/robertpainsi/followers","following_url":"https://api.github.com/users/robertpainsi/following{/other_user}","gists_url":"https://api.github.com/users/robertpainsi/gists{/gist_id}","starred_url":"https://api.github.com/users/robertpainsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertpainsi/subscriptions","organizations_url":"https://api.github.com/users/robertpainsi/orgs","repos_url":"https://api.github.com/users/robertpainsi/repos","events_url":"https://api.github.com/users/robertpainsi/events{/privacy}","received_events_url":"https://api.github.com/users/robertpainsi/received_events","type":"User"},"created_at":"2013-09-26T12:38:16Z","updated_at":"2013-09-26T12:38:16Z","html_url":"https://github.com/Catrobat/Catroid/pull/730#discussion_r6599368","pull_request_url":"https://api.github.com/repos/Catrobat/Catroid/pulls/730","_links":{"self":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/comments/6599368"},"html":{"href":"https://github.com/Catrobat/Catroid/pull/730#discussion_r6599368"},"pull_request":{"href":"https://api.github.com/repos/Catrobat/Catroid/pulls/730"}}}}

{"repository":{"description":"A Catrobat IDE for Android.","homepage":"www.pocketcode.org","watchers":61,"stargazers":61,"forks":41,"fork":false,"size":156613,"owner":"Catrobat","private":false,"open_issues":81,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2012-05-28T17:18:04-07:00","pushed_at":"2013-09-26T05:36:33-07:00","master_branch":"master","organization":"Catrobat"},"actor_attributes":{"type":"User","name":"Robert Painsi","email":"[email protected]"},"url":"https://github.com/Catrobat/Catroid/pull/730#discussion_r6599368"}

PullRequestReviewCommentEvent

{"comment":{"original_commit_id":"f37914d8174ad61358395d302d8964490dc9d0c0","original_position":58,"id":2537111,"user":{"following_url":"https://api.github.com/users/narfbg/following","gists_url":"https://api.github.com/users/narfbg/gists{/gist_id}","received_events_url":"https://api.github.com/users/narfbg/received_events","events_url":"https://api.github.com/users/narfbg/events{/privacy}","id":1058011,"followers_url":"https://api.github.com/users/narfbg/followers","avatar_url":"https://secure.gravatar.com/avatar/01c7cad7af7361ad9ca670fbf1d502e4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","type":"User","starred_url":"https://api.github.com/users/narfbg/starred{/owner}{/repo}","login":"narfbg","url":"https://api.github.com/users/narfbg","subscriptions_url":"https://api.github.com/users/narfbg/subscriptions","organizations_url":"https://api.github.com/users/narfbg/orgs","repos_url":"https://api.github.com/users/narfbg/repos","gravatar_id":"01c7cad7af7361ad9ca670fbf1d502e4"},"body":"This does nothing.","created_at":"2013-01-03T09:58:40Z","commit_id":"f37914d8174ad61358395d302d8964490dc9d0c0","url":"https://api.github.com/repos/EllisLab/CodeIgniter/pulls/comments/2537111","_links":{"pull_request":{"href":"https://api.github.com/repos/EllisLab/CodeIgniter/pulls/2105"},"html":{"href":"https://github.com/EllisLab/CodeIgniter/pull/2105#discussion_r2537111"},"self":{"href":"https://api.github.com/repos/EllisLab/CodeIgniter/pulls/comments/2537111"}},"position":58,"updated_at":"2013-01-03T09:58:40Z","path":"system/database/DB_utility.php"}}

{"repository":{"has_issues":true,"has_wiki":true,"owner":"EllisLab","created_at":"2011-08-19T06:34:00-07:00","homepage":"http://codeigniter.com/","open_issues":180,"integrate_branch":"feature/unit-tests","master_branch":"develop","pushed_at":"2013-01-03T01:46:18-08:00","description":"EllisLab's Open Source PHP Framework","watchers":4858,"forks":1718,"fork":false,"size":3196,"has_downloads":true,"organization":"EllisLab","stargazers":4858,"private":false,"language":"PHP"},"actor_attributes":{"type":"User","company":"Applicata Ltd.","location":"Bulgaria","name":"Andrey Andreev","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/EllisLab/CodeIgniter/pull/2105#discussion_r2537111"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/Factlink/pavlov/pulls/comments/6743024","id":6743024,"body":"Quotation marks not needed","diff_hunk":"@@ -0,0 +1,114 @@\n+require_relative 'pavlov_helper'\n+\n+module Interactors\n+ module ExampleModule\n+ class Followers\n+ include Pavlov::Interactor\n+\n+ arguments :user_name, :skip, :take\n+\n+ def authorized?\n+ !! pavlov_options[:current_user]\n+ end\n+\n+ def validate\n+ validate_nonempty_string :user_name, user_name\n+ validate_integer :skip, skip\n+ validate_integer :take, take\n+ end\n+\n+ def execute\n+ user = query(:'user_by_username', username: user_name)","path":"spec/regression/example5_spec.rb","position":21,"original_position":21,"commit_id":"311ed4d0f5f17698fbb6f399a7a0587dd6dc9377","original_commit_id":"311ed4d0f5f17698fbb6f399a7a0587dd6dc9377","user":{"login":"janpaul123","id":177461,"avatar_url":"https://0.gravatar.com/avatar/d1809393c6fcd63dcc5ddd5e128dc967?d=https%3A%2F%2Fidenticons.github.com%2F8b1880d756a10b8fcc0330ef01bd752f.png","gravatar_id":"d1809393c6fcd63dcc5ddd5e128dc967","url":"https://api.github.com/users/janpaul123","html_url":"https://github.com/janpaul123","followers_url":"https://api.github.com/users/janpaul123/followers","following_url":"https://api.github.com/users/janpaul123/following{/other_user}","gists_url":"https://api.github.com/users/janpaul123/gists{/gist_id}","starred_url":"https://api.github.com/users/janpaul123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janpaul123/subscriptions","organizations_url":"https://api.github.com/users/janpaul123/orgs","repos_url":"https://api.github.com/users/janpaul123/repos","events_url":"https://api.github.com/users/janpaul123/events{/privacy}","received_events_url":"https://api.github.com/users/janpaul123/received_events","type":"User"},"created_at":"2013-10-03T14:51:31Z","updated_at":"2013-10-03T14:51:31Z","html_url":"https://github.com/Factlink/pavlov/pull/74#discussion_r6743024","pull_request_url":"https://api.github.com/repos/Factlink/pavlov/pulls/74","_links":{"self":{"href":"https://api.github.com/repos/Factlink/pavlov/pulls/comments/6743024"},"html":{"href":"https://github.com/Factlink/pavlov/pull/74#discussion_r6743024"},"pull_request":{"href":"https://api.github.com/repos/Factlink/pavlov/pulls/74"}}}}

{"repository":{"description":"Provides a Command/Query/Interactor framework.","homepage":"","watchers":9,"stargazers":9,"forks":5,"fork":false,"size":1318,"owner":"Factlink","private":false,"open_issues":8,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-01-07T05:36:47-08:00","pushed_at":"2013-10-03T07:26:37-07:00","master_branch":"master","organization":"Factlink"},"actor_attributes":{"type":"User","name":"Jan Paul Posma","company":"FactLink, Versal","blog":"http://janpaulposma.nl","location":"Groningen, Netherlands","email":"[email protected]"},"url":"https://github.com/Factlink/pavlov/pull/74#discussion_r6743024"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/Freeseer/freeseer/pulls/comments/8046124","id":8046124,"diff_hunk":"@@ -35,490 +37,424 @@\n \r\n log = logging.getLogger(__name__)\r\n \r\n+\r\n class QtDBConnector():\r\n presentationsModel = None\r\n failuresModel = None\r\n recentconnModel = None\r\n- \r\n+\r\n def __init__(self, configdir, talkdb_file=\"presentations.db\"):\r\n- \"\"\"\r\n- Initialize the QtDBConnector\r\n- \"\"\"\r\n+ \"\"\"Initializes the QtDBConnector\"\"\"\r\n self.configdir = configdir\r\n- self.talkdb_file = os.path.abspath(\"%s/%s\" % (self.configdir, talkdb_file))\r\n- \r\n+ self.talkdb_file = os.path.join(\"{}/{}\".format(self.configdir, talkdb_file))\r\n+\r\n if not os.path.isfile(self.talkdb_file):\r\n- file = open(self.talkdb_file, 'w')\r\n- file.write('')\r\n- file.close()\r\n- \r\n+ with open(self.talkdb_file, 'w') as file:\r\n+ file.write('')\r\n self.__open_table()\r\n- \r\n+\r\n def __open_table(self):\r\n- \"\"\"\r\n- This function options a connection to the database. Used by the init function.\r\n- \"\"\"\r\n+ \"\"\"Opens a connection to the database. Uses by the init function.\"\"\"\r\n self.talkdb = QtSql.QSqlDatabase.addDatabase(\"QSQLITE\")\r\n self.talkdb.setDatabaseName(self.talkdb_file)\r\n- \r\n- if (self.talkdb.open()):\r\n- \r\n+\r\n+ if self.talkdb.open():\r\n+\r\n # check if presentations table exists and if not create it.\r\n if not self.talkdb.tables().contains(\"presentations\"):\r\n self.__create_presentations_table()\r\n self.__insert_default_talk()\r\n- \r\n+\r\n # check if failures table exists and if not create it.\r\n if not self.talkdb.tables().contains(\"failures\"):\r\n self.__create_failures_table()\r\n- \r\n+\r\n # check if recentConnections table exists and if not create it.\r\n if not self.talkdb.tables().contains(\"recentconn\"):\r\n self.__create_recentconn_table()\r\n- \r\n- #verify that correct version of database exists\r\n+\r\n+ # verify that correct version of database exists\r\n self.__update_version()\r\n else:\r\n log.error(\"Unable to create talkdb file.\")\r\n- \r\n+\r\n def __close_table(self):\r\n- \"\"\"\r\n- This function is used to close the connection the the database. \r\n- \"\"\"\r\n+ \"\"\"Closes the connection the the database.\"\"\"\r\n self.talkdb.close()\r\n \r\n def get_program_version_int(self):\r\n- \"\"\"\r\n- Get Freeseer's current version as an integer.\r\n- \"\"\"\r\n+ \"\"\"Gets Freeseer's current version as an integer.\"\"\"\r\n result = []\r\n for c in __version__:\r\n if c.isdigit():\r\n result.append(c)\r\n return int(''.join(result))\r\n- \r\n+\r\n def __get_db_version_int(self):\r\n- \"\"\"\r\n- Get the database's current version. Default is 0 if unset (for 2x and older)\r\n- \"\"\"\r\n+ \"\"\"Gets the database's current version. Default is 0 if unset (for 2x and older)\"\"\"\r\n query = QtSql.QSqlQuery('PRAGMA user_version')\r\n query.first()\r\n return query.value(0).toInt()[0]\r\n \r\n def __update_version(self):\r\n- \"\"\"\r\n- Upgrade database to the latest version.\r\n+ \"\"\"Upgrades database to the latest version.\r\n updaterVersion[i] version number of the incremental update function located at updaters[i]\r\n updaters[] functions are then called in order starting at the old version to the end.\r\n- Version # of 2.x and older is 0\r\n- \"\"\"\r\n- \r\n+ Version # of 2.x and older is 0\"\"\"\r\n+\r\n db_version = self.__get_db_version_int()\r\n program_version = self.get_program_version_int()\r\n if program_version == db_version:\r\n return\r\n- \r\n+\r\n def update_2xto30():\r\n- \"\"\"\r\n- Incremental update of database from 2.x and older to 3.0.\r\n- \"\"\"\r\n- QtSql.QSqlQuery('ALTER TABLE presentations RENAME TO presentations_old') #temporary table\r\n+ \"\"\"Perfrorms incremental update of database from 2.x and older to 3.0.\"\"\"\r\n+ # temporary table\r\n+ QtSql.QSqlQuery('ALTER TABLE presentations RENAME TO presentations_old')\r\n self.__create_presentations_table()\r\n- QtSql.QSqlQuery(\"\"\"INSERT INTO presentations \r\n- SELECT Id, Title, Speaker, Description, Level, Event, Room, Time from presentations_old\"\"\")\r\n+ QtSql.QSqlQuery(\"\"\"INSERT INTO presentations\r\n+ SELECT Id, Title, Speaker, Description, Category, Event, Room, Time\r\n+ from presentations_old\"\"\")\r\n QtSql.QSqlQuery('DROP TABLE presentations_old')\r\n- \r\n- updaters = [update_2xto30]\r\n- updaterVersion = [0] #next entry is 300\r\n- \r\n- if len(updaters) != len(updaterVersion) or db_version not in updaterVersion: #not setup properly\r\n+\r\n+ def update_30to31():\r\n+ \"\"\"Performs incremental update of database from 3.0 and older to 3.1.\"\"\"\r\n+ # temporary table\r\n+ QtSql.QSqlQuery('ALTER TABLE presentations RENAME TO presentations_old')\r\n+ self.__create_presentations_table()\r\n+ QtSql.QSqlQuery(\"\"\"INSERT INTO presentations\r\n+ SELECT Id, Title, Speaker, Description, Category, Event, Room, Time\r\n+ from presentations_old\"\"\")\r\n+ QtSql.QSqlQuery('ALTER TABLE presentations RENAME COLUMN Category to Category')\r\n+ QtSql.QSqlQuery('ALTER TABLE presentations RENAME COLUMN Time to Date')\r\n+ QtSql.QSqlQuery('ALTER TABLE presentations ADD COLUMN Time timestamp')\r\n+ QtSql.QSqlQuery('UPDATE table SET Date = Time')\r\n+ QtSql.QSqlQuery('DROP TABLE presentations_old')\r\n+\r\n+ updaters = [update_30to31]\r\n+ updaterVersion = [0] # next entry is 300\r\n+ # not setup properly\r\n+ if len(updaters) != len(updaterVersion) or db_version not in updaterVersion:\r\n log.info('Database upgrade failed.')\r\n return\r\n for updater in updaters[updaterVersion.index(db_version):]:\r\n updater()\r\n QtSql.QSqlQuery('PRAGMA user_version = %i' % program_version)\r\n log.info('Upgraded presentations database from version %i', db_version)\r\n- \r\n+\r\n def __create_presentations_table(self):\r\n- \"\"\"\r\n- Creates the presentations table in the database. Should be used to\r\n- initialize a new table.\r\n- \"\"\"\r\n+ \"\"\"Creates the presentations table in the database. Should be used to initialize a new table.\"\"\"\r\n+ log.info(\"table created\")\r\n query = QtSql.QSqlQuery('''CREATE TABLE IF NOT EXISTS presentations\r\n (Id INTEGER PRIMARY KEY,\r\n Title varchar(255),\r\n Speaker varchar(100),\r\n Description text,\r\n- Level varchar(25),\r\n+ Category varchar(25),\r\n Event varchar(100),\r\n Room varchar(25),\r\n+ Date timestamp,\r\n Time timestamp,\r\n UNIQUE (Speaker, Title) ON CONFLICT IGNORE)''')\r\n- \r\n+\r\n def __insert_default_talk(self):\r\n- \"\"\"\r\n- Insert the default talk data into the database.\r\n- \"\"\"\r\n- presentation = Presentation(\"Intro to Freeseer\",\r\n- \"Thanh Ha\",\r\n- \"\",\r\n- \"\",\r\n- \"SC2011\",\r\n- \"T105\",\r\n- \"\")\r\n- self.insert_presentation(presentation)\r\n- \r\n+ \"\"\"Inserts the required placeholder talk into the database.At least one talk must exist\"\"\"\r\n+ self.insert_presentation(Presentation(\"\", \"\", \"\", \"\", \"\", \"\", \"\", \"\"))\r\n+\r\n def get_talks(self):\r\n- \"\"\"\r\n- Gets all the talks from the database including all columns.\r\n- \"\"\"\r\n- result = QtSql.QSqlQuery('''SELECT * FROM presentations''')\r\n- return result\r\n- \r\n+ \"\"\"Gets all the talks from the database including all columns\"\"\"\r\n+ return QtSql.QSqlQuery('''SELECT * FROM presentations''')\r\n+\r\n def get_events(self):\r\n- \"\"\"\r\n- Gets all the talk events from the database.\r\n- \"\"\"\r\n- result = QtSql.QSqlQuery('''SELECT DISTINCT Event FROM presentations''')\r\n- return result\r\n- \r\n+ \"\"\"Gets all the talk events from the database\"\"\"\r\n+ return QtSql.QSqlQuery('''SELECT DISTINCT Event FROM presentations''')\r\n+\r\n def get_talk_ids(self):\r\n- \"\"\"\r\n- Gets all the talk events from the database.\r\n- \"\"\"\r\n- result = QtSql.QSqlQuery('''SELECT Id FROM presentations''')\r\n- return result\r\n- \r\n+ \"\"\"Gets all the talk events from the database\"\"\"\r\n+ return QtSql.QSqlQuery('''SELECT Id FROM presentations''')\r\n+\r\n def get_talks_by_event(self, event):\r\n- \"\"\"\r\n- Gets the talks signed in a specific event from the database.\r\n- \"\"\"\r\n- result = QtSql.QSqlQuery('''SELECT * FROM presentations WHERE Event=%s''' % event)\r\n- return result\r\n- \r\n+ \"\"\"Gets the talks signed in a specific event from the database\"\"\"\r\n+ return QtSql.QSqlQuery('''SELECT * FROM presentations WHERE Event=%s''' % event)\r\n+\r\n def get_talks_by_room(self, room):\r\n- \"\"\"\r\n- Gets the talks hosted in a specific room from the database.\r\n- \"\"\"\r\n- result = QtSql.QSqlQuery('''SELECT * FROM presentations WHERE Room=%s''' % room)\r\n- return result\r\n- \r\n+ \"\"\"Gets the talks hosted in a specific room from the database\"\"\"\r\n+ return QtSql.QSqlQuery('''SELECT * FROM presentations WHERE Room=%s''' % room)\r\n+\r\n def get_presentation(self, talk_id):\r\n- \"\"\"\r\n- Return a Presentation object associated to a talk_id.\r\n- \"\"\"\r\n+ \"\"\"Returns a Presentation object associated to a talk_id\"\"\"\r\n result = QtSql.QSqlQuery('''SELECT * FROM presentations WHERE Id=\"%s\"''' % talk_id)\r\n if result.next():\r\n- p = Presentation(unicode(result.value(1).toString()), # title\r\n- unicode(result.value(2).toString()), # speaker\r\n- unicode(result.value(3).toString()), # description\r\n- unicode(result.value(4).toString()), # level\r\n- unicode(result.value(5).toString()), # event\r\n- unicode(result.value(6).toString()), # room\r\n- unicode(result.value(7).toString())) # time\r\n+ return Presentation(title=unicode(result.value(1).toString()),\r\n+ speaker=unicode(result.value(2).toString()),\r\n+ description=unicode(result.value(3).toString()),\r\n+ category=unicode(result.value(4).toString()),\r\n+ event=unicode(result.value(5).toString()),\r\n+ room=unicode(result.value(6).toString()),\r\n+ date=unicode(result.value(7).toString()),\r\n+ time=unicode(result.value(8).toString()))\r\n else:\r\n- p = None\r\n- \r\n- return p\r\n- \r\n+ return None\r\n+\r\n+ def get_string_list(self,column):\r\n+ \"\"\"Returns a column as a QStringList\"\"\"\r\n+ tempList = QStringList()\r\n+ result = QtSql.QSqlQuery('''SELECT DISTINCT %s FROM presentations''' %column)\r\n+ while result.next():\r\n+ tempList.append(result.value(0).toString())\r\n+ return tempList\r\n+\r\n+\r\n def presentation_exists(self, presentation):\r\n- \"\"\"\r\n- Check if there's a presentation with the same Speaker and Title already stored\r\n- \"\"\"\r\n+ \"\"\"Checks if there's a presentation with the same Speaker and Title already stored\"\"\"\r\n result = QtSql.QSqlQuery('''SELECT * FROM presentations''')\r\n- while(result.next()): \r\n- if(unicode(presentation.title) == unicode(result.value(1).toString()) and unicode(presentation.speaker) == unicode(result.value(2).toString())):\r\n- return True \r\n+ while result.next():\r\n+ if(unicode(presentation.title) == unicode(result.value(1).toString()) \r\n+ and unicode(presentation.speaker) == unicode(result.value(2).toString())):\r\n+ return True\r\n return False\r\n- \r\n+\r\n #\r\n # Presentation Create, Update, Delete\r\n #\r\n def insert_presentation(self, presentation):\r\n- \"\"\"\r\n- Insert a Presentation into the database.\r\n- \"\"\"\r\n- query = QtSql.QSqlQuery('''INSERT INTO presentations VALUES (NULL, \"%s\", \"%s\", \"%s\", \"%s\", \"%s\", \"%s\", \"%s\")''' %\r\n- (presentation.title,\r\n- presentation.speaker,\r\n- presentation.description,\r\n- presentation.level,\r\n- presentation.event,\r\n- presentation.room,\r\n- presentation.time))\r\n- log.info(\"Talk added: %s - %s\" % (presentation.speaker, presentation.title))\r\n- \r\n+ \"\"\"Inserts a passed Presentation into the database.\"\"\"\r\n+ # Handle old field names\r\n+ # Level to Category\r\n+ try:\r\n+ if not presentation.level and presentation.category:\r\n+ presentation.level = presentation.category\r\n+ except AttributeError:\r\n+ log.debug(\"Did not copy Category field to Level field\")\r\n+\r\n+ # Duplicate time to date field for older RSS / CSV formats\r\n+ # If date is empty, and time has a full DateTime, split the DateTime to\r\n+ # both Date and Time\r\n+ if not presentation.date and presentation.time and len(presentation.time) == 16:\r\n+ presentation.date, presentation.time = presentation.time[:-6], presentation.time[11:]\r\n+\r\n+ query = QtSql.QSqlQuery(\r\n+ '''INSERT INTO presentations VALUES (NULL, \"%s\", \"%s\", \"%s\", \"%s\", \"%s\", \"%s\", \"%s\", \"%s\")''' %\r\n+ (presentation.title,\r\n+ presentation.speaker,\r\n+ presentation.description,\r\n+ presentation.category,\r\n+ presentation.event,\r\n+ presentation.room,\r\n+ presentation.date,\r\n+ presentation.time))\r\n+ log.info(\"Talk added: %s - %s\" %(presentation.speaker, presentation.title))\r\n+\r\n def update_presentation(self, talk_id, presentation):\r\n- \"\"\"\r\n- Update an existing Presentation in the database.\r\n- \"\"\"\r\n- query = QtSql.QSqlQuery('''UPDATE presentations SET Title=\"%s\", Speaker=\"%s\", Event=\"%s\", Room=\"%s\", Time=\"%s\" WHERE Id=\"%s\"''' %\r\n- (presentation.title,\r\n- presentation.speaker,\r\n- presentation.event,\r\n- presentation.room,\r\n- presentation.time,\r\n- talk_id))\r\n+ \"\"\"Updates an existing Presentation in the database.\"\"\"\r\n+ query = QtSql.QSqlQuery(\r\n+ '''UPDATE presentations SET Title=\"%s\", Speaker=\"%s\", Event=\"%s\", Room=\"%s\", Date=\"%s\", Time=\"%s\"\r\n+ WHERE Id=\"%s\"''' %\r\n+ (presentation.title,\r\n+ presentation.speaker,\r\n+ presentation.event,\r\n+ presentation.room,\r\n+ presentation.date,\r\n+ presentation.time,\r\n+ talk_id))\r\n log.info(\"Talk %s updated: %s - %s\" % (talk_id, presentation.speaker, presentation.title))\r\n- \r\n+\r\n def delete_presentation(self, talk_id):\r\n- \"\"\"\r\n- Removes a Presentation from the database\r\n- \"\"\"\r\n+ \"\"\"Removes a Presentation from the database\"\"\"\r\n query = QtSql.QSqlQuery('''DELETE FROM presentations WHERE Id=\"%s\"''' % talk_id)\r\n log.info(\"Talk %s deleted.\" % talk_id)\r\n- \r\n+\r\n def clear_database(self):\r\n- \"\"\"\r\n- Clears the presentations table\r\n- \"\"\"\r\n+ \"\"\"Clears the presentations table\"\"\"\r\n query = QtSql.QSqlQuery('''DELETE FROM presentations''')\r\n log.info(\"Database cleared.\")\r\n- \r\n+\r\n #\r\n- # Data Model Retrieval \r\n+ # Data Model Retrieval\r\n #\r\n def get_presentations_model(self):\r\n- \"\"\"\r\n- Gets the Presentation Table Model.\r\n- Useful for Qt GUI based Frontends to load the Model in Table Views.\r\n- \"\"\"\r\n+ \"\"\"Gets the Presentation Table Model. Useful for Qt GUI based Frontends to load the Model in Table Views\"\"\"\r\n if self.presentationsModel is None:\r\n self.presentationsModel = QtSql.QSqlTableModel()\r\n self.presentationsModel.setTable(\"presentations\")\r\n self.presentationsModel.setEditStrategy(QtSql.QSqlTableModel.OnFieldChange)\r\n self.presentationsModel.select()\r\n- \r\n return self.presentationsModel\r\n \r\n def get_events_model(self):\r\n- \"\"\"\r\n- Gets the Events Model.\r\n- Useful for Qt GUI based Frontends to load the Model into Views.\r\n- \"\"\"\r\n+ \"\"\"Gets the Events Model. Useful for Qt GUI based Frontends to load the Model into Views\"\"\"\r\n self.eventsModel = QtSql.QSqlQueryModel()\r\n self.eventsModel.setQuery(\"SELECT DISTINCT Event FROM presentations ORDER BY Event ASC\")\r\n- \r\n return self.eventsModel\r\n- \r\n+\r\n def get_dates_from_event_room_model(self, event, room):\r\n- \"\"\"\r\n- Gets the Rooms Model.\r\n- Useful for Qt GUI based Frontends to load the Model into Views.\r\n- \"\"\"\r\n+ \"\"\"Gets the Rooms Model.Useful for Qt GUI based Frontends to load the Model into Views.\"\"\"\r\n self.datesModel = QtSql.QSqlQueryModel()\r\n- self.datesModel.setQuery(\"SELECT DISTINCT date(Time) FROM presentations WHERE Event='%s' and Room='%s' ORDER BY Time ASC\" % (event, room))\r\n- \r\n+ self.datesModel.setQuery(\r\n+ \"SELECT DISTINCT date(Time) FROM presentations WHERE Event='%s' and Room='%s' ORDER BY Date ASC\"\r\n+ % (event, room))\r\n return self.datesModel\r\n- \r\n+\r\n def get_rooms_model(self, event):\r\n- \"\"\"\r\n- Gets the Rooms Model.\r\n- Useful for Qt GUI based Frontends to load the Model into Views.\r\n- \"\"\"\r\n+ \"\"\"Gets the Rooms Model. Useful for Qt GUI based Frontends to load the Model into Views\"\"\"\r\n self.roomsModel = QtSql.QSqlQueryModel()\r\n self.roomsModel.setQuery(\"SELECT DISTINCT Room FROM presentations WHERE Event='%s' ORDER BY Room ASC\" % event)\r\n- \r\n return self.roomsModel\r\n- \r\n+\r\n def get_talks_model(self, event, room, date=None):\r\n- \"\"\"\r\n- Gets the Talks Model. A talk is defined as \"<presenter> - <talk_title>\"\r\n- Useful for Qt GUI based Frontends to load the Model into Views.\r\n- \"\"\"\r\n- \r\n+ \"\"\"Gets the Talks Model. A talk is defined as \"<presenter> - <talk_title>\"\r\n+ Useful for Qt GUI based Frontends to load the Model into Views\"\"\"\r\n self.talksModel = QtSql.QSqlQueryModel()\r\n if date == \"\":\r\n self.talksModel.setQuery(\"SELECT (Speaker || ' - ' || Title), Id FROM presentations \\\r\n- WHERE Event='%s' and Room='%s' ORDER BY Time ASC\" % (event, room))\r\n+ WHERE Event='%s' and Room='%s' ORDER BY Date ASC\" % (event, room))\r\n else:\r\n self.talksModel.setQuery(\"SELECT (Speaker || ' - ' || Title), Id FROM presentations \\\r\n- WHERE Event='%s' and Room='%s' and date(Time) LIKE '%s' ORDER BY Time ASC\" % (event, room, date))\r\n- \r\n+ WHERE Event='%s' and Room='%s' and date(Date) LIKE '%s' ORDER BY Date ASC\" \r\n+ % (event, room, date))\r\n return self.talksModel\r\n- \r\n+\r\n def get_talk_between_time(self, event, room, starttime, endtime):\r\n- \"\"\"\r\n- Returns the talkID of the first talk found between a starttime, and endtime for a specified event/room.\r\n- Else return None\r\n- \"\"\"\r\n- query = QtSql.QSqlQuery(\"SELECT Id, Time FROM presentations \\\r\n+ \"\"\"Returns the talkID of the first talk found between a starttime, and endtime for a specified event/room.\r\n+ Else return None\"\"\"\r\n+ query = QtSql.QSqlQuery(\"SELECT Id, Date FROM presentations \\\r\n WHERE Event='%s' AND Room='%s' \\\r\n- AND Time BETWEEN '%s' \\\r\n- AND '%s' ORDER BY Time ASC\" % (event, room, starttime, endtime))\r\n+ AND Date BETWEEN '%s' \\\r\n+ AND '%s' ORDER BY Date ASC\" % (event, room, starttime, endtime))\r\n query.next()\r\n if query.isValid():\r\n return query.value(0)\r\n else:\r\n return None\r\n- \r\n- \r\n- ##\r\n- ## Import / Export Functions\r\n- ##\r\n- \r\n+\r\n+ #\r\n+ # Import / Export Functions\r\n+ #\r\n+ # Needs to be updated for category field, separate date and time fields\r\n def add_talks_from_rss(self, rss):\r\n- \"\"\"Adds talks from an rss feed.\"\"\"\r\n+ \"\"\"Adds talks from an rss feed\"\"\"\r\n entry = str(rss)\r\n feedparser = FeedParser(entry)\r\n-\r\n if len(feedparser.build_data_dictionary()) == 0:\r\n log.info(\"RSS: No data found.\")\r\n-\r\n else:\r\n for presentation in feedparser.build_data_dictionary():\r\n talk = Presentation(presentation[\"Title\"],\r\n presentation[\"Speaker\"],\r\n presentation[\"Abstract\"], # Description\r\n+ presentation[\"Category\"],\r\n presentation[\"Level\"],\r\n presentation[\"Event\"],\r\n presentation[\"Room\"],\r\n+ presentation[\"Date\"],\r\n presentation[\"Time\"])\r\n self.insert_presentation(talk)\r\n- \r\n+\r\n def add_talks_from_csv(self, fname):\r\n- \"\"\"Adds talks from a csv file.\r\n- \r\n- Title and speaker must be present.\r\n- \"\"\"\r\n- file = open(fname,'r')\r\n+ \"\"\"Adds talks from a csv file. Title and speaker must be present.\"\"\"\r\n+ file = open(fname, 'r')\r","path":"src/freeseer/framework/database.py","position":535,"original_position":535,"commit_id":"ad16feed4fb6ff97757be968632d29757380cbad","original_commit_id":"ad16feed4fb6ff97757be968632d29757380cbad","user":{"login":"dideler","id":497458,"avatar_url":"https://0.gravatar.com/avatar/12ecd2ec519dec0959f43f193eaca10c?d=https%3A%2F%2Fidenticons.github.com%2F86d3b62be3e568496ee6f61dfe37a07f.png&r=x","gravatar_id":"12ecd2ec519dec0959f43f193eaca10c","url":"https://api.github.com/users/dideler","html_url":"https://github.com/dideler","followers_url":"https://api.github.com/users/dideler/followers","following_url":"https://api.github.com/users/dideler/following{/other_user}","gists_url":"https://api.github.com/users/dideler/gists{/gist_id}","starred_url":"https://api.github.com/users/dideler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dideler/subscriptions","organizations_url":"https://api.github.com/users/dideler/orgs","repos_url":"https://api.github.com/users/dideler/repos","events_url":"https://api.github.com/users/dideler/events{/privacy}","received_events_url":"https://api.github.com/users/dideler/received_events","type":"User","site_admin":false},"body":"Could you use `with open(fname) as file:` here instead?","created_at":"2013-12-03T00:20:52Z","updated_at":"2013-12-03T00:20:52Z","html_url":"https://github.com/Freeseer/freeseer/pull/395#discussion_r8046124","pull_request_url":"https://api.github.com/repos/Freeseer/freeseer/pulls/395","_links":{"self":{"href":"https://api.github.com/repos/Freeseer/freeseer/pulls/comments/8046124"},"html":{"href":"https://github.com/Freeseer/freeseer/pull/395#discussion_r8046124"},"pull_request":{"href":"https://api.github.com/repos/Freeseer/freeseer/pulls/395"}}}}

{"repository":{"description":"A set of tools designed for capturing presentations. The main tool is capable of capturing VGA output and audio, and mixing them together to produce a video.","homepage":"http://freeseer.github.io","watchers":142,"stargazers":142,"forks":77,"fork":false,"size":119930,"owner":"Freeseer","private":false,"open_issues":92,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2009-12-01T06:17:15-08:00","pushed_at":"2013-12-01T07:11:11-08:00","integrate_branch":"integration","master_branch":"master","organization":"Freeseer"},"actor_attributes":{"type":"User","name":"Dennis Ideler","company":"Hiring? Send me an email.","blog":"www.dennisideler.com","location":"St. Catharines, ON, Canada","email":"[email protected]"},"url":"https://github.com/Freeseer/freeseer/pull/395#discussion_r8046124"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/Freeseer/freeseer/pulls/comments/7993974","id":7993974,"diff_hunk":"@@ -0,0 +1,120 @@\n+#!/usr/bin/python\n+# -*- coding: utf-8 -*-\n+\n+'''\n+freeseer - vga/presentation capture software\n+\n+Copyright (C) 2013 Free and Open Source Software Learning Centre\n+http://fosslc.org\n+\n+This program is free software: you can redistribute it and/or modify\n+it under the terms of the GNU General Public License as published by\n+the Free Software Foundation, either version 3 of the License, or\n+(at your option) any later version.\n+\n+This program is distributed in the hope that it will be useful,\n+but WITHOUT ANY WARRANTY; without even the implied warranty of\n+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+GNU General Public License for more details.\n+\n+You should have received a copy of the GNU General Public License\n+along with this program. If not, see <http://www.gnu.org/licenses/>.\n+\n+For support, questions, suggestions or any other inquiries, visit:\n+http://wiki.github.com/Freeseer/freeseer/\n+'''\n+\n+import argparse\n+import ConfigParser\n+import os\n+\n+from oauth2client import tools\n+\n+from freeseer.framework.youtube import YoutubeService\n+\n+\n+class YoutubeFrontend(object):\n+\n+ def __init__(self):\n+ # Parser for command-line arguments\n+ self.parser = argparse.ArgumentParser(\n+ description=\"Youtube Framework\",\n+ formatter_class=argparse.RawDescriptionHelpFormatter,\n+ parents=[tools.argparser])\n+ self.set_defaults()\n+\n+ def set_defaults(self):\n+ config = ConfigParser.ConfigParser()\n+ configdir = os.path.abspath(os.path.expanduser('~/.freeseer/'))\n+ configfile = os.path.abspath(\"%s/freeseer.conf\" % configdir)\n+ config.readfp(open(configfile))\n+\n+ self.video_directory = config.get('Global', 'video_directory') + \"/\"\n+ self.client_secrets = os.path.abspath(\"%s/client_secrets.json\" % configdir)","path":"src/freeseer/frontend/upload/youtube.py","position":53,"original_position":53,"commit_id":"d683e65a1340d51b6a75513c57411e41273fecb1","original_commit_id":"d683e65a1340d51b6a75513c57411e41273fecb1","user":{"login":"mtomwing","id":959968,"avatar_url":"https://2.gravatar.com/avatar/f71d92db223bfa895e73aec3f561a178?d=https%3A%2F%2Fidenticons.github.com%2F36ad2f10d8f1998e17777a4bba9be34a.png&r=x","gravatar_id":"f71d92db223bfa895e73aec3f561a178","url":"https://api.github.com/users/mtomwing","html_url":"https://github.com/mtomwing","followers_url":"https://api.github.com/users/mtomwing/followers","following_url":"https://api.github.com/users/mtomwing/following{/other_user}","gists_url":"https://api.github.com/users/mtomwing/gists{/gist_id}","starred_url":"https://api.github.com/users/mtomwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtomwing/subscriptions","organizations_url":"https://api.github.com/users/mtomwing/orgs","repos_url":"https://api.github.com/users/mtomwing/repos","events_url":"https://api.github.com/users/mtomwing/events{/privacy}","received_events_url":"https://api.github.com/users/mtomwing/received_events","type":"User","site_admin":false},"body":"You should use `os.path.join` whenever you make to make a new path.\r\n\r\n```python\r\nos.path.join(configdir, 'client_secrets.json')\r\n```\r\n\r\nI don't think the absolute paths are required either.","created_at":"2013-11-29T01:41:40Z","updated_at":"2013-11-29T01:41:40Z","html_url":"https://github.com/Freeseer/freeseer/pull/402#discussion_r7993974","pull_request_url":"https://api.github.com/repos/Freeseer/freeseer/pulls/402","_links":{"self":{"href":"https://api.github.com/repos/Freeseer/freeseer/pulls/comments/7993974"},"html":{"href":"https://github.com/Freeseer/freeseer/pull/402#discussion_r7993974"},"pull_request":{"href":"https://api.github.com/repos/Freeseer/freeseer/pulls/402"}}}}

{"repository":{"description":"A set of tools designed for capturing presentations. The main tool is capable of capturing VGA output and audio, and mixing them together to produce a video.","homepage":"http://freeseer.github.io","watchers":141,"stargazers":141,"forks":77,"fork":false,"size":119478,"owner":"Freeseer","private":false,"open_issues":92,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2009-12-01T06:17:15-08:00","pushed_at":"2013-11-02T18:24:24-07:00","integrate_branch":"integration","master_branch":"master","organization":"Freeseer"},"actor_attributes":{"type":"User","name":"Michael Tom-Wing","blog":"http://mtomwing.com","location":"Vancouver, BC","email":"[email protected]"},"url":"https://github.com/Freeseer/freeseer/pull/402#discussion_r7993974"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://github.com/api/v3/repos/Homebrew/homebrew/pulls/comments/8442122","id":8442122,"body":"We don't really want to add freemium stuff like that to Homebrew.","diff_hunk":"@@ -0,0 +1,81 @@\n+require 'formula'\n+\n+class ShrewsoftVpnClient < Formula\n+\n+ homepage 'https://www.shrew.net'\n+ url 'https://www.shrew.net/download/ike/ike-2.2.1-release.tbz2'\n+ sha1 'a52a49248fa663dfbd9e208eaa3e706a17bb9c8c'\n+\n+ option 'with-gui', 'Enable Client QT GUI'\n+ option 'without-natt', 'Disable Nat Traversal Support'\n+ option 'without-ldap', 'Disable LDAP Authentication Support'\n+\n+ depends_on 'cmake' => :build\n+ depends_on 'tuntap' => :recommended\n+ depends_on 'openssl'\n+ depends_on 'qt' if build.with? 'gui'\n+\n+ def install\n+\n+ # there is no suport for an alternate Frameworks folder, must change hard-coded paths\n+ ['package/macosx/vpn-client-install.packproj'] +\n+ Dir['source/*/CMakeLists.txt'].each do |path|\n+ next unless File.read(path).include? '/Library/Frameworks'\n+ inreplace path, '/Library/Frameworks', frameworks","path":"Library/Formula/shrewsoft-vpn-client.rb","position":24,"original_position":24,"commit_id":"0d1bc7947e057d66eb42f085ee3a7c7333749cce","original_commit_id":"0d1bc7947e057d66eb42f085ee3a7c7333749cce","user":{"login":"mikemcquaid","id":125011,"avatar_url":"https://0.gravatar.com/avatar/215e0166d4d8265395c5d9076da73c70?d=https%3A%2F%2Fidenticons.github.com%2F19e490b885e34ade007230f7a58dc9a4.png","gravatar_id":"215e0166d4d8265395c5d9076da73c70","url":"https://github.com/api/v3/users/mikemcquaid","html_url":"https://github.com/mikemcquaid","followers_url":"https://github.com/api/v3/users/mikemcquaid/followers","following_url":"https://github.com/api/v3/users/mikemcquaid/following{/other_user}","gists_url":"https://github.com/api/v3/users/mikemcquaid/gists{/gist_id}","starred_url":"https://github.com/api/v3/users/mikemcquaid/starred{/owner}{/repo}","subscriptions_url":"https://github.com/api/v3/users/mikemcquaid/subscriptions","organizations_url":"https://github.com/api/v3/users/mikemcquaid/orgs","repos_url":"https://github.com/api/v3/users/mikemcquaid/repos","events_url":"https://github.com/api/v3/users/mikemcquaid/events{/privacy}","received_events_url":"https://github.com/api/v3/users/mikemcquaid/received_events","type":"User"},"created_at":"2013-12-18T16:59:29Z","updated_at":"2013-12-18T16:59:29Z","html_url":"https://github.com/Homebrew/homebrew/pull/25099#discussion_r8442122","pull_request_url":"https://github.com/api/v3/repos/Homebrew/homebrew/pulls/25099","_links":{"self":{"href":"https://github.com/api/v3/repos/Homebrew/homebrew/pulls/comments/8442122"},"html":{"href":"https://github.com/Homebrew/homebrew/pull/25099#discussion_r8442122"},"pull_request":{"href":"https://github.com/api/v3/repos/Homebrew/homebrew/pulls/25099"}}}}

{"repository":{"description":"The missing package manager for OS X.","homepage":"http://brew.sh","watchers":15091,"stargazers":15091,"forks":7616,"fork":false,"size":1033421,"owner":"Homebrew","private":false,"open_issues":305,"has_issues":true,"has_downloads":false,"has_wiki":true,"language":"Ruby","created_at":"2009-05-20T12:38:37-07:00","pushed_at":"2013-12-18T08:55:13-08:00","integrate_branch":"staging","master_branch":"master","organization":"Homebrew"},"actor_attributes":{"type":"User","name":"Mike McQuaid","company":"GitHub","blog":"mikemcquaid.com","location":"Edinburgh, Scotland","email":"[email protected]"},"url":"https://github.com/Homebrew/homebrew/pull/25099#discussion_r8442122"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/Incubaid/arakoon/pulls/comments/4725033","id":4725033,"body":"I'm (still) not convinced it's a good idea to have this as the default. `Lwt.Canceled` in threads during normal operation is a bug. Only when `run` finalizes, these things are expected to occur.","diff_hunk":"@@ -0,0 +1,92 @@\n+(*\n+This file is part of Arakoon, a distributed key-value store. Copyright\n+(C) 2010 Incubaid BVBA\n+\n+Licensees holding a valid Incubaid license may use this file in\n+accordance with Incubaid's Arakoon commercial license agreement. For\n+more information on how to enter into this agreement, please contact\n+Incubaid (contact details can be found on www.arakoon.org/licensing).\n+\n+Alternatively, this file may be redistributed and/or modified under\n+the terms of the GNU Affero General Public License version 3, as\n+published by the Free Software Foundation. Under this license, this\n+file is distributed in the hope that it will be useful, but WITHOUT\n+ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or\n+FITNESS FOR A PARTICULAR PURPOSE.\n+\n+See the GNU Affero General Public License for more details.\n+You should have received a copy of the\n+GNU Affero General Public License along with this program (file \"COPYING\").\n+If not, see <http://www.gnu.org/licenses/>.\n+*)\n+\n+open Lwt\n+\n+\n+let igns = Hashtbl.create 10\n+let detacheds = Hashtbl.create 10\n+\n+let rec get_key () =\n+ let candidate = Random.int 1073741823 in\n+ if Hashtbl.mem igns candidate\n+ then\n+ get_key ()\n+ else\n+ candidate\n+\n+let ignore_result (t:'a Lwt.t) =\n+ let key = get_key () in\n+ let t' () =\n+ Lwt.finalize\n+ (fun () -> t)\n+ (fun () ->\n+ Hashtbl.remove igns key;\n+ Lwt.return ()) in\n+ Hashtbl.add igns key t;\n+ Lwt.ignore_result (t' ())\n+\n+let detach (t: unit -> string) =\n+ let t' = Lwt_preemptive.detach t () in\n+ let key = get_key () in\n+ Hashtbl.add detacheds key t';\n+ Lwt.finalize\n+ (fun () -> t')\n+ (fun () ->\n+ Hashtbl.remove detacheds key;\n+ Lwt.return ())\n+\n+let async_exception_hook : (exn -> unit) ref =\n+ ref (fun exn ->\n+ prerr_string \"Fatal error: exception \";\n+ prerr_string (Printexc.to_string exn);\n+ prerr_char '\\n';\n+ Printexc.print_backtrace stderr;\n+ flush stderr;\n+ exit 2)\n+let () =\n+ Lwt.async_exception_hook :=\n+ (function\n+ | Lwt.Canceled -> ()","path":"src/tools/lwt_extra.ml","position":69,"original_position":69,"commit_id":"9f87dd2ebfd98a84dfc1471a05e05953f5dbb3e3","original_commit_id":"9f87dd2ebfd98a84dfc1471a05e05953f5dbb3e3","user":{"login":"NicolasT","id":102605,"avatar_url":"https://secure.gravatar.com/avatar/cdb9a7e894ce5c90532025979b53d93e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"cdb9a7e894ce5c90532025979b53d93e","url":"https://api.github.com/users/NicolasT","html_url":"https://github.com/NicolasT","followers_url":"https://api.github.com/users/NicolasT/followers","following_url":"https://api.github.com/users/NicolasT/following{/other_user}","gists_url":"https://api.github.com/users/NicolasT/gists{/gist_id}","starred_url":"https://api.github.com/users/NicolasT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicolasT/subscriptions","organizations_url":"https://api.github.com/users/NicolasT/orgs","repos_url":"https://api.github.com/users/NicolasT/repos","events_url":"https://api.github.com/users/NicolasT/events{/privacy}","received_events_url":"https://api.github.com/users/NicolasT/received_events","type":"User"},"created_at":"2013-06-17T14:28:48Z","updated_at":"2013-06-17T14:28:48Z","html_url":"https://github.com/Incubaid/arakoon/pull/90#discussion_r4725033","pull_request_url":"https://api.github.com/repos/Incubaid/arakoon/pulls/90","_links":{"self":{"href":"https://api.github.com/repos/Incubaid/arakoon/pulls/comments/4725033"},"html":{"href":"https://github.com/Incubaid/arakoon/pull/90#discussion_r4725033"},"pull_request":{"href":"https://api.github.com/repos/Incubaid/arakoon/pulls/90"}}}}

{"repository":{"description":"A consistent distributed key-value store","homepage":"http://arakoon.org","watchers":15,"stargazers":15,"forks":0,"fork":false,"size":2476,"owner":"Incubaid","private":false,"open_issues":7,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"OCaml","created_at":"2011-12-20T04:25:30-08:00","pushed_at":"2013-06-17T07:03:17-07:00","master_branch":"1.6","organization":"Incubaid"},"actor_attributes":{"type":"User","name":"Nicolas Trangez","blog":"http://eikke.com","location":".be","email":"0439b3006bc37ebea3c0caae45b71835440236f5"},"url":"https://github.com/Incubaid/arakoon/pull/90#discussion_r4725033"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/Mirantis/fuel-docs/pulls/comments/7182989","id":7182989,"diff_hunk":"@@ -21,3 +21,125 @@ In order to deploy Neutron, you need to enable it in the Fuel configuration.\n Fuel will then set up an additional node in the OpenStack installation to act \n as an L3 router, or, depending on the configuration options you've chosen, \n install Neutron on the controllers.\n+\n+\n+Terminology\n+-----------\n+\n+* **Public network** (also known as External) network used for Internet access for all nodes.\n+ This network also may be called “external”.\n+* **Floating IP network** subnet within public network allocated for tenant \n+ Internet access. The local router or DHCP server directly assigns IP \n+ addresses for this network. If a tenant delegate a floating IP address to \n+ the tenant, IP address will be in this subnet.\n+* **Private network** network used for passing tenant private traffic.\n+* **Admin network** network used for PXE booting and orchestration of\n+ environment nodes from Fuel Master.\n+* **Storage network** network used for communicating between storage nodes \n+ (using Ceph, swift, or cinder) and compute nodes.\n+* **Management network** (also known as Internal) used\n+ for necessary communication between controllers and computes for AMQP, \n+ database synchronization, and other inter-node traffic required for\n+ supporting services.\n+* **Router** virtual Neutron router.\n+* **NIC** network interface card (ethernet adapter).\n+\n+Overview\n+--------\n+OpenStack networking with Neutron (Quantum) has some differences from \n+Nova-network. Neutron is able to virtualize and manage both layer 2 (logical) \n+and layer 3 (network) of the OSI network model, as compared to simple layer 3 \n+virtualization provided by nova-network. This is the main difference between \n+the two networking models for OpenStack. Virtual networks (one or more) can be \n+created for a single tenant, forming an isolated L2 network called a \n+\"private network.\" Each private network can support one or many IP subnets.\n+Private networks can be segmented using two different technologies:\n+\n+* **VLAN segmentation** Isolated tenant \"private network\" traffic is managed by \n+Neutron by the use of a dedicated network adapter. This network adapter must be \n+attached to an untagged network segment. This network segment also must be \n+reserved only for Neutron on each host (Computes and Controllers). You should \n+not use any other 802.1q VLANs on this network for other purposes. \n+Additionally, each private network requires its own dedicated VLAN, selected \n+from a given range configured in Fuel UI. \n+\n+* **GRE segmentation** In this mode of operation, Neutron does not\n+require a dedicated network adapter. Neutron builds a mesh of GRE tunnels from\n+each compute node and controller nodes to every other node. Private networks\n+for each tenant make use of this mesh for isolated traffic. Additionally, your\n+Public network should remain untagged if you consolidate all Neutron traffic to\n+one NIC.\n+\n+Additionally, some networks may be 802.1q networks and based on one NIC. But Administrative \n+and Private (if you use VLAN-segmentation) networks must placed on dedicated \n+NIC. Also recommended make Public network as untagged, if you union some \n+networks by 801.1q to one NIC.\n+\n+Commonly, network map for VLAN mode may be looked as:\n+\n+.. image:: /_images/Neutron_32_gre_v2.png\n+ :align: center\n+\n+\n+Commonly, network map for GRE mode may be looked as:\n+\n+.. image:: /_images/Neutron_32_vlan_v2.png\n+ :align: center\n+ \n+The most likely configuration for different number NICs on cluster nodes:\n+\n++------+----------------------------------------+----------------------------------------+ \n+| NICs | VLAN | GRE | \n++======+========================================+========================================+ \n+| 2 | Not supported | .. image:: /_images/q32_gre_2nic.svg | \n+| | | :align: center |\n++------+----------------------------------------+----------------------------------------+\n+| 3 | .. image:: /_images/q32_vlan_3nic.svg | .. image:: /_images/q32_gre_3nic.svg |\n+| | :align: center | :align: center |\n++------+----------------------------------------+----------------------------------------+\n+| 4 | .. image:: /_images/q32_vlan_4nic.svg | .. image:: /_images/q32_gre_4nic.svg |\n+| | :align: center | :align: center |\n++------+----------------------------------------+----------------------------------------+\n+\n+\n+Known limitations\n+-----------------\n+","path":"pages/reference-architecture/0060-quantum-vs-nova-network.rst","position":96,"original_position":96,"commit_id":"eebc18f0848aa79962ccb7fdbc7ee17779051caa","original_commit_id":"eebc18f0848aa79962ccb7fdbc7ee17779051caa","user":{"login":"adanin","id":1999329,"avatar_url":"https://0.gravatar.com/avatar/2c04a75b098c49fef8d4b0762b49acb2?d=https%3A%2F%2Fidenticons.github.com%2Fcce1ebd987834d25f5fe9a070be312db.png&r=x","gravatar_id":"2c04a75b098c49fef8d4b0762b49acb2","url":"https://api.github.com/users/adanin","html_url":"https://github.com/adanin","followers_url":"https://api.github.com/users/adanin/followers","following_url":"https://api.github.com/users/adanin/following{/other_user}","gists_url":"https://api.github.com/users/adanin/gists{/gist_id}","starred_url":"https://api.github.com/users/adanin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adanin/subscriptions","organizations_url":"https://api.github.com/users/adanin/orgs","repos_url":"https://api.github.com/users/adanin/repos","events_url":"https://api.github.com/users/adanin/events{/privacy}","received_events_url":"https://api.github.com/users/adanin/received_events","type":"User","site_admin":false},"body":"This item is about Quantum.","created_at":"2013-10-24T09:21:36Z","updated_at":"2013-10-24T09:21:36Z","html_url":"https://github.com/Mirantis/fuel-docs/pull/55#discussion_r7182989","pull_request_url":"https://api.github.com/repos/Mirantis/fuel-docs/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/Mirantis/fuel-docs/pulls/comments/7182989"},"html":{"href":"https://github.com/Mirantis/fuel-docs/pull/55#discussion_r7182989"},"pull_request":{"href":"https://api.github.com/repos/Mirantis/fuel-docs/pulls/55"}}}}

{"repository":{"description":"","watchers":2,"stargazers":2,"forks":21,"fork":false,"size":21152,"owner":"Mirantis","private":false,"open_issues":7,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-06-25T00:33:03-07:00","pushed_at":"2013-10-24T00:36:06-07:00","master_branch":"master","organization":"Mirantis"},"actor_attributes":{"type":"User","name":"Andrey Danin","company":"Mirantis","email":"[email protected]"},"url":"https://github.com/Mirantis/fuel-docs/pull/55#discussion_r7182989"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments/7297016","id":7297016,"diff_hunk":"@@ -2,9 +2,12 @@\n \n import pytest\n from unittestzero import Assert\n+#from py.path import local\n \n logger = logging.getLogger(__name__)\n \n+\n+# DEPRECATED!!!","path":"fixtures/server_roles.py","position":9,"original_position":9,"commit_id":"59287f007cc4f6293d565302e0a467256aff090b","original_commit_id":"59287f007cc4f6293d565302e0a467256aff090b","user":{"login":"mfalesni","id":2163040,"avatar_url":"https://0.gravatar.com/avatar/173255d180b1eeae4c750740f20934ad?d=https%3A%2F%2Fidenticons.github.com%2Fd5015a4b584bbf229001cbb45ebbc8aa.png&r=x","gravatar_id":"173255d180b1eeae4c750740f20934ad","url":"https://api.github.com/users/mfalesni","html_url":"https://github.com/mfalesni","followers_url":"https://api.github.com/users/mfalesni/followers","following_url":"https://api.github.com/users/mfalesni/following{/other_user}","gists_url":"https://api.github.com/users/mfalesni/gists{/gist_id}","starred_url":"https://api.github.com/users/mfalesni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfalesni/subscriptions","organizations_url":"https://api.github.com/users/mfalesni/orgs","repos_url":"https://api.github.com/users/mfalesni/repos","events_url":"https://api.github.com/users/mfalesni/events{/privacy}","received_events_url":"https://api.github.com/users/mfalesni/received_events","type":"User","site_admin":false},"body":"I did a github search for it.","created_at":"2013-10-29T22:23:05Z","updated_at":"2013-10-29T22:23:05Z","html_url":"https://github.com/RedHatQE/cfme_tests/pull/172#discussion_r7297016","pull_request_url":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/172","_links":{"self":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/comments/7297016"},"html":{"href":"https://github.com/RedHatQE/cfme_tests/pull/172#discussion_r7297016"},"pull_request":{"href":"https://api.github.com/repos/RedHatQE/cfme_tests/pulls/172"}}}}

{"repository":{"description":"CloudForms Management Engine - Functional tests","homepage":"","watchers":6,"stargazers":6,"forks":15,"fork":false,"size":1554,"owner":"RedHatQE","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-02-06T13:59:17-08:00","pushed_at":"2013-10-22T10:56:30-07:00","master_branch":"master","organization":"RedHatQE"},"actor_attributes":{"type":"User","name":"Milan Falešník","company":"Red Hat Brno","location":"Brno","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/RedHatQE/cfme_tests/pull/172#discussion_r7297016"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/Rhinofly/PeLoTi/pulls/comments/8502870","id":8502870,"diff_hunk":"@@ -0,0 +1,26 @@\n+package controllers\n+\n+import models.MongoDB\n+import play.api.data.Form\n+import play.api.data.Forms.email\n+import play.api.mvc.Action\n+import play.api.mvc.Controller\n+import service.Service\n+\n+class Portal(service: Service) extends Controller {\n+\n+ val requestForm = Form(\n+ \"email\" -> email)\n+\n+ def request = Action {","path":"app/controllers/Portal.scala","position":15,"original_position":15,"commit_id":"5e7d4ea9cfbf5a9fc19301d90a2de6159505accd","original_commit_id":"5e7d4ea9cfbf5a9fc19301d90a2de6159505accd","user":{"login":"EECOLOR","id":1486362,"avatar_url":"https://gravatar.com/avatar/dfcffa6d61323027cb75ee36d1fbb508?d=https%3A%2F%2Fidenticons.github.com%2Fbcc664059259f3a71105588b6c935b40.png&r=x","gravatar_id":"dfcffa6d61323027cb75ee36d1fbb508","url":"https://api.github.com/users/EECOLOR","html_url":"https://github.com/EECOLOR","followers_url":"https://api.github.com/users/EECOLOR/followers","following_url":"https://api.github.com/users/EECOLOR/following{/other_user}","gists_url":"https://api.github.com/users/EECOLOR/gists{/gist_id}","starred_url":"https://api.github.com/users/EECOLOR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EECOLOR/subscriptions","organizations_url":"https://api.github.com/users/EECOLOR/orgs","repos_url":"https://api.github.com/users/EECOLOR/repos","events_url":"https://api.github.com/users/EECOLOR/events{/privacy}","received_events_url":"https://api.github.com/users/EECOLOR/received_events","type":"User","site_admin":false},"body":"`requestToken`","created_at":"2013-12-20T16:10:27Z","updated_at":"2013-12-20T16:10:27Z","html_url":"https://github.com/Rhinofly/PeLoTi/pull/4#discussion_r8502870","pull_request_url":"https://api.github.com/repos/Rhinofly/PeLoTi/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/Rhinofly/PeLoTi/pulls/comments/8502870"},"html":{"href":"https://github.com/Rhinofly/PeLoTi/pull/4#discussion_r8502870"},"pull_request":{"href":"https://api.github.com/repos/Rhinofly/PeLoTi/pulls/4"}}}}

{"repository":{"description":"","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":1020,"owner":"Rhinofly","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"created_at":"2013-12-03T02:10:26-08:00","pushed_at":"2013-12-20T05:58:35-08:00","master_branch":"master","organization":"Rhinofly"},"actor_attributes":{"type":"User","name":"EECOLOR","company":"Rhinofly","location":"Utrecht, Netherlands","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Rhinofly/PeLoTi/pull/4#discussion_r8502870"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/Rhinofly/play-elasticsearch-client/pulls/comments/7606489","id":7606489,"diff_hunk":"@@ -0,0 +1,99 @@\n+package play.modules.elasticsearch\n+\n+import play.api.libs.json._\n+import play.api.libs.json.Json.JsValueWrapper\n+\n+/**\n+ * Mappings for ES indexes and types. See http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/mapping.html.\n+ *\n+ * The Mapping class defines mappings for fields recursively.\n+ * The field name at the top-level is the type that is mapped in ElasticSearch.\n+ */\n+\n+case class Mapping(\n+ field: String,\n+ fieldType: MappingType.Value = MappingType.`object`,\n+ index: IndexType.Value = IndexType.analyzed,\n+ store: Boolean = false,\n+ boost: Double = 1.0,\n+ properties: Seq[Mapping] = Seq()\n+ )\n+\n+object MappingType extends Enumeration {\n+ val `object` = Value(\"object\")\n+ val string = Value(\"string\")\n+ val byte = Value(\"byte\")\n+ val short = Value(\"short\")\n+ val integer = Value(\"integer\")\n+ val long = Value(\"long\")\n+ val float = Value(\"float\")\n+ val double = Value(\"double\")\n+ val date = Value(\"date\")\n+ val boolean = Value(\"boolean\")\n+ val binary = Value(\"binary\")\n+}\n+\n+object IndexType extends Enumeration {\n+ val analyzed = Value(\"analyzed\")\n+ val no = Value(\"no\")\n+ val not_analyzed = Value(\"not_analyzed\")\n+}\n+\n+object Mapping {\n+\n+ // Writing mappings.\n+\n+ implicit object mappingWrites extends Writes[Mapping] {\n+ def writes(mapping: Mapping) = Json.obj( mapping.field -> mappingJson(mapping) )\n+ }\n+\n+ def mappingJson(mapping: Mapping): JsValueWrapper =\n+ Json.obj(\n+ \"type\" -> Json.toJson(mapping.fieldType.toString()),\n+ \"index\" -> Json.toJson(mapping.index.toString()),\n+ \"store\" -> Json.toJson(if (mapping.store) \"yes\" else \"no\"),\n+ \"boost\" -> Json.toJson(mapping.boost),\n+ \"properties\" -> Json.obj(mapping.properties.map{jsonTuple}:_*)\n+ )\n+\n+ def jsonTuple(mapping: Mapping) = (mapping.field -> mappingJson(mapping))\n+\n+ /**\n+ * Make several type mappings into one mappings definition, used at index creation.\n+ * See http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/indices-create-index.html#mappings.\n+ */\n+ def jsonForTypes(mappings: Seq[Mapping]) = Json.obj(\"mappings\" -> Json.obj(mappings.map{jsonTuple}:_*))\n+\n+ // Reading mappings.\n+\n+ implicit object mappingReads extends Reads[Mapping] {\n+ def reads(json: JsValue): JsResult[Mapping] = json match {\n+ case JsObject(Seq((field, jsMapping))) => JsSuccess(jsonMapping(field, jsMapping))\n+ case _ => JsError()","path":"app/play/modules/elasticsearch/Mapping.scala","position":72,"original_position":72,"commit_id":"dc8c6618c3da95c96c6a119b63e8dc2fd36d49ed","original_commit_id":"dc8c6618c3da95c96c6a119b63e8dc2fd36d49ed","user":{"login":"EECOLOR","id":1486362,"avatar_url":"https://1.gravatar.com/avatar/dfcffa6d61323027cb75ee36d1fbb508?d=https%3A%2F%2Fidenticons.github.com%2Fbcc664059259f3a71105588b6c935b40.png&r=x","gravatar_id":"dfcffa6d61323027cb75ee36d1fbb508","url":"https://api.github.com/users/EECOLOR","html_url":"https://github.com/EECOLOR","followers_url":"https://api.github.com/users/EECOLOR/followers","following_url":"https://api.github.com/users/EECOLOR/following{/other_user}","gists_url":"https://api.github.com/users/EECOLOR/gists{/gist_id}","starred_url":"https://api.github.com/users/EECOLOR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EECOLOR/subscriptions","organizations_url":"https://api.github.com/users/EECOLOR/orgs","repos_url":"https://api.github.com/users/EECOLOR/repos","events_url":"https://api.github.com/users/EECOLOR/events{/privacy}","received_events_url":"https://api.github.com/users/EECOLOR/received_events","type":"User","site_admin":false},"body":"The error here is not very helpful. To make better use of error handling in `Json` it's better to use path's. This is quite a tricky subject though, so for now you could just add a `ValidationError` instance.","created_at":"2013-11-12T20:52:52Z","updated_at":"2013-11-12T20:52:52Z","html_url":"https://github.com/Rhinofly/play-elasticsearch-client/pull/2#discussion_r7606489","pull_request_url":"https://api.github.com/repos/Rhinofly/play-elasticsearch-client/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/Rhinofly/play-elasticsearch-client/pulls/comments/7606489"},"html":{"href":"https://github.com/Rhinofly/play-elasticsearch-client/pull/2#discussion_r7606489"},"pull_request":{"href":"https://api.github.com/repos/Rhinofly/play-elasticsearch-client/pulls/2"}}}}

{"repository":{"description":"Small ElasticSearch client","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":696,"owner":"Rhinofly","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Scala","created_at":"2013-10-09T07:23:40-07:00","pushed_at":"2013-11-12T05:38:41-08:00","master_branch":"master","organization":"Rhinofly"},"actor_attributes":{"type":"User","name":"EECOLOR","company":"Rhinofly","location":"Utrecht, Netherlands","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Rhinofly/play-elasticsearch-client/pull/2#discussion_r7606489"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/SciTools/iris/pulls/comments/3430381","id":3430381,"body":"Raw asserts should not be used here as it does not indicate a fatal error in logic, but rather a test failure. As hinted at above, please use one of the assert methods instead.","diff_hunk":"@@ -495,7 +496,215 @@ def test_nearest_neighbour_locator_style_coord(self):\n \n b = iris.analysis.interpolate.extract_nearest_neighbour(self.cube, point_spec) \n self.assertCML(b, ('analysis', 'interpolation', 'nearest_neighbour_extract_latitude.cml'))\n- \n- \n+\n+ def test_nearest_neighbour_circular(self):\n+ # test on non-circular coordinate (latitude)\n+ lat_vals = np.array([\n+ [-150.0, -90], [-97, -90], [-92, -90], [-91, -90], [-90.1, -90],\n+ [-90.0, -90], [-89.9, -90],\n+ [-89, -90], [-88, -87.5], [-87, -87.5],\n+ [-86, -85], [-85.5, -85],\n+ [81, 80], [84, 85], [84.8, 85], [85, 85], [86, 85],\n+ [87, 87.5], [88, 87.5], [89, 90],\n+ [89.9, 90], [90.0, 90], [90.1, 90],\n+ [95, 90], [100, 90], [150, 90]])\n+ lat_test_vals = lat_vals[:, 0]\n+ lat_expect_vals = lat_vals[:, 1]\n+ lat_coord_vals = self.cube.coord('latitude').points\n+\n+ def near_value(val, vals):\n+ # return the *exact* value from vals that is closest to val.\n+ # - and raise an exception if there isn't a close match.\n+ best_val = vals[np.argmin(np.abs(vals - val))]\n+ if val == 0.0:\n+ # absolute tolerance to 0.0 (ok for magnitudes >= 1.0 or so)\n+ error_level = best_val\n+ else:\n+ # calculate relative-tolerance\n+ error_level = abs(0.5 * (val - best_val) / (val + best_val))\n+ if error_level > 1.0e-6:\n+ print 'error_level {}% match of {} to one of {}'.format(\n+ 100.0 * error_level, val, vals)\n+ assert error_level < 1.0e-6","path":"lib/iris/tests/test_interpolation.py","position":52,"original_position":52,"commit_id":"d5b6e27af1dd4040437b1a370eb84e4ae2cc33d3","original_commit_id":"d5b6e27af1dd4040437b1a370eb84e4ae2cc33d3","user":{"login":"esc24","id":1634089,"avatar_url":"https://secure.gravatar.com/avatar/8bd0e92cdf61b60bc2e2aa4bd77cfc3e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"8bd0e92cdf61b60bc2e2aa4bd77cfc3e","url":"https://api.github.com/users/esc24","html_url":"https://github.com/esc24","followers_url":"https://api.github.com/users/esc24/followers","following_url":"https://api.github.com/users/esc24/following","gists_url":"https://api.github.com/users/esc24/gists{/gist_id}","starred_url":"https://api.github.com/users/esc24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esc24/subscriptions","organizations_url":"https://api.github.com/users/esc24/orgs","repos_url":"https://api.github.com/users/esc24/repos","events_url":"https://api.github.com/users/esc24/events{/privacy}","received_events_url":"https://api.github.com/users/esc24/received_events","type":"User"},"created_at":"2013-03-19T12:57:40Z","updated_at":"2013-03-19T12:57:40Z","html_url":"https://github.com/SciTools/iris/pull/391#discussion_r3430381","pull_request_url":"https://api.github.com/repos/SciTools/iris/pulls/391","_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments/3430381"},"html":{"href":"https://github.com/SciTools/iris/pull/391#discussion_r3430381"},"pull_request":{"href":"https://api.github.com/repos/SciTools/iris/pulls/391"}}}}

{"repository":{"description":"A powerful, easy to use, and community-driven Python library for analysing and visualising meteorological and oceanographic data sets.","homepage":"http://scitools.org.uk/iris/","watchers":19,"stargazers":19,"forks":19,"fork":false,"size":836,"owner":"SciTools","private":false,"open_issues":109,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-08-06T03:09:14-07:00","pushed_at":"2013-03-15T08:36:05-07:00","master_branch":"master","organization":"SciTools"},"actor_attributes":{"type":"User","name":"Ed Campbell","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/SciTools/iris/pull/391#discussion_r3430381"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/SciTools/thea/pulls/comments/6321498","id":6321498,"body":"Methods ```setup_1D_cube```, ```setup_2D_cube```, ```setup_4D_cube``` and ```setup_7D_cube``` could be defined as functions outside the class ...\r\n\r\nInfact, these are pretty much the same as those methods in ```test_cube_logic.py``` is there an opportunity to share these functions between the tests rather than duplicate the code ?","diff_hunk":"@@ -0,0 +1,392 @@\n+# -*- coding: iso-8859-1 -*-\n+#\n+#\n+# (C) British Crown Copyright 2013, Met Office\n+# All rights reserved.\n+#\n+# Redistribution and use in source and binary forms, with or without\n+# modification, are permitted provided that the following conditions are met:\n+#\n+# Redistributions of source code must retain the above copyright notice,\n+# this list of conditions and the following disclaimer.\n+#\n+# Redistributions in binary form must reproduce the above copyright notice,\n+# this list of conditions and the following disclaimer in the documentation\n+# and/or other materials provided with the distribution.\n+#\n+# Neither the name of the Met Office nor the names of its contributors\n+# may be used to endorse or promote products derived from this software\n+# without specific prior written permission.\n+#\n+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\"\n+# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE\n+# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE\n+# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE\n+# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR\n+# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF\n+# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS\n+# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN\n+# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)\n+# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF\n+# THE POSSIBILITY OF SUCH DAMAGE.\n+#\n+# This file is part of Thea.\n+\n+import unittest\n+import numpy as np\n+import iris\n+\n+import thea.gui_logic as gl\n+\n+\n+class guiLogicTests(unittest.TestCase):\n+\n+ def compare_dict(self, dictA, dictB):\n+ for key in dictB.keys():\n+ if not key in dictA.keys():\n+ msg = \"Key: \" + str(key) + \" does not exist in dictA\"\n+ return msg\n+ for key in dictA.keys():\n+ if not key in dictB.keys():\n+ msg = \"Key: \" + str(key) + \" does not exist in dictB\"\n+ return msg\n+ elif not dictA[key] == dictB[key]:\n+ msg = \"dictA: \" + str(key) + \": \" + str(dictA[key])\n+ msg += \" dictB: \" + str(key) + \": \" + str(dictB[key])\n+ return msg\n+ return None\n+\n+ def test_compare_dict_pass(self):\n+ dictA = {'one': 1,\n+ 'two': 2,\n+ 'three': 3}\n+ dictB = {'one': 1,\n+ 'two': 2,\n+ 'three': 3}\n+ result = self.compare_dict(dictA, dictB)\n+ self.assertIsNone(result)\n+\n+ def test_compare_dict_fail_element_wrong(self):\n+ dictA = {'one': 1,\n+ 'two': 2,\n+ 'three': 3}\n+ dictB = {'one': 1,\n+ 'two': 6,\n+ 'three': 3}\n+ result = self.compare_dict(dictA, dictB)\n+ self.assertEqual(result, \"dictA: two: 2 dictB: two: 6\")\n+\n+ def test_compare_dict_fail_A_too_large(self):\n+ dictA = {'one': 1,\n+ 'two': 2,\n+ 'three': 3}\n+ dictB = {'one': 1,\n+ 'two': 2}\n+ result = self.compare_dict(dictA, dictB)\n+ self.assertEqual(result, \"Key: three does not exist in dictB\")\n+\n+ def test_compare_dict_fail_B_too_large(self):\n+ dictA = {'one': 1,\n+ 'two': 2}\n+ dictB = {'one': 1,\n+ 'two': 2,\n+ 'three': 3}\n+ result = self.compare_dict(dictA, dictB)\n+ self.assertEqual(result, \"Key: three does not exist in dictA\")\n+\n+ def setup_1D_cube(self):\n+ cube = iris.load_cube(iris.sample_data_path('SOI_Darwin.nc'))\n+ return cube\n+\n+ def setup_2D_cube(self):\n+ cube = iris.load_cube(iris.sample_data_path('air_temp.pp'))\n+ return cube\n+\n+ def setup_4D_cube(self):\n+ cube = iris.load(iris.sample_data_path('uk_hires.pp'))[0]\n+ return cube\n+\n+ def setup_7D_anonymous_cube(self):\n+ data = np.arange(0, 5*5*5*5*5*5*5)\n+ data = np.reshape(data, [5, 5, 5, 5, 5, 5, 5])\n+ cube = iris.cube.Cube(data)\n+ return cube","path":"lib/thea/tests/test_gui_logic.py","position":113,"original_position":113,"commit_id":"9af7350bd8b4a54cd4215d4b034462a764be992d","original_commit_id":"9af7350bd8b4a54cd4215d4b034462a764be992d","user":{"login":"bjlittle","id":2051656,"avatar_url":"https://0.gravatar.com/avatar/907798185f1ed99aead3bb410977197b?d=https%3A%2F%2Fidenticons.github.com%2Fdb3f48893678f13c66be6bc13ba5b0dd.png","gravatar_id":"907798185f1ed99aead3bb410977197b","url":"https://api.github.com/users/bjlittle","html_url":"https://github.com/bjlittle","followers_url":"https://api.github.com/users/bjlittle/followers","following_url":"https://api.github.com/users/bjlittle/following{/other_user}","gists_url":"https://api.github.com/users/bjlittle/gists{/gist_id}","starred_url":"https://api.github.com/users/bjlittle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjlittle/subscriptions","organizations_url":"https://api.github.com/users/bjlittle/orgs","repos_url":"https://api.github.com/users/bjlittle/repos","events_url":"https://api.github.com/users/bjlittle/events{/privacy}","received_events_url":"https://api.github.com/users/bjlittle/received_events","type":"User"},"created_at":"2013-09-12T13:33:21Z","updated_at":"2013-09-12T13:33:21Z","html_url":"https://github.com/SciTools/thea/pull/1#discussion_r6321498","pull_request_url":"https://api.github.com/repos/SciTools/thea/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/SciTools/thea/pulls/comments/6321498"},"html":{"href":"https://github.com/SciTools/thea/pull/1#discussion_r6321498"},"pull_request":{"href":"https://api.github.com/repos/SciTools/thea/pulls/1"}}}}

{"repository":{"description":"Python GUI to visualise a cube","homepage":"","watchers":0,"stargazers":0,"forks":4,"fork":false,"size":2130,"owner":"SciTools","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"created_at":"2013-06-21T08:11:48-07:00","pushed_at":"2013-06-21T08:11:48-07:00","master_branch":"master","organization":"SciTools"},"actor_attributes":{"type":"User","name":"Bill Little","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/SciTools/thea/pull/1#discussion_r6321498"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/SciTools/iris/pulls/comments/6850854","id":6850854,"diff_hunk":"@@ -143,27 +143,48 @@ def decode_uri(uri, default='file'):\n return scheme, part\n \n \n-def load_files(filenames, callback):\n+def expand_filespecs(file_specs):\n \"\"\"\n- Takes a list of filenames which may also be globs, and optionally a\n- callback function, and returns a generator of Cubes from the given files.\n+ Work out matching file paths from a list of file-specs.\n \n- .. note::\n+ Args:\n \n- Typically, this function should not be called directly; instead, the\n- intended interface for loading is :func:`iris.load`.\n+ * file_specs (iterable of string):\n+ File paths which may contain '~' elements or wildcards.\n+\n+ Returns:\n+ A dictionary of {globspec: file-paths-list}. The 'globspec's retain\n+ any wildcards but have any '~' elements expanded.","path":"lib/iris/io/__init__.py","position":21,"original_position":21,"commit_id":"41b0988c3567e407da0703845cb612063a6ca540","original_commit_id":"41b0988c3567e407da0703845cb612063a6ca540","user":{"login":"pp-mo","id":2089069,"avatar_url":"https://2.gravatar.com/avatar/7ee7bfc0aa5417821b890383e5dbb276?d=https%3A%2F%2Fidenticons.github.com%2F83ddad428a2cf609a85fbcff64ee9207.png","gravatar_id":"7ee7bfc0aa5417821b890383e5dbb276","url":"https://api.github.com/users/pp-mo","html_url":"https://github.com/pp-mo","followers_url":"https://api.github.com/users/pp-mo/followers","following_url":"https://api.github.com/users/pp-mo/following{/other_user}","gists_url":"https://api.github.com/users/pp-mo/gists{/gist_id}","starred_url":"https://api.github.com/users/pp-mo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pp-mo/subscriptions","organizations_url":"https://api.github.com/users/pp-mo/orgs","repos_url":"https://api.github.com/users/pp-mo/repos","events_url":"https://api.github.com/users/pp-mo/events{/privacy}","received_events_url":"https://api.github.com/users/pp-mo/received_events","type":"User","site_admin":false},"body":"Whoops I hadn't spotted that. \r\nIt was used in the original caller before I split this off, but only for the error handling which is now contained here.\r\nWill fix...","created_at":"2013-10-09T09:28:35Z","updated_at":"2013-10-09T09:28:35Z","html_url":"https://github.com/SciTools/iris/pull/787#discussion_r6850854","pull_request_url":"https://api.github.com/repos/SciTools/iris/pulls/787","_links":{"self":{"href":"https://api.github.com/repos/SciTools/iris/pulls/comments/6850854"},"html":{"href":"https://github.com/SciTools/iris/pull/787#discussion_r6850854"},"pull_request":{"href":"https://api.github.com/repos/SciTools/iris/pulls/787"}}}}

{"repository":{"description":"A powerful, easy to use, and community-driven Python library for analysing and visualising meteorological and oceanographic data sets.","homepage":"http://scitools.org.uk/iris/","watchers":38,"stargazers":38,"forks":35,"fork":false,"size":97753,"owner":"SciTools","private":false,"open_issues":138,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-08-06T03:09:14-07:00","pushed_at":"2013-10-04T02:38:49-07:00","master_branch":"master","organization":"SciTools"},"actor_attributes":{"type":"User","name":"Patrick Peglar","company":"MetOffice","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/SciTools/iris/pull/787#discussion_r6850854"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/SketchUp/sketchup-stl/pulls/comments/6787826","id":6787826,"diff_hunk":"@@ -0,0 +1,122 @@\n+module CommunityExtensions\n+ module STL\n+ module Cleanup\n+ # Cleans up the geometry in the given +entities+ collection.\n+ #\n+ # @param [Sketchup::Entities] entities\n+ # \n+ # @return [Nil]\n+ def cleanup_geometry(entities)\n+ stack = entities.select { |e| e.is_a?(Sketchup::Edge) }\n+ until stack.empty?\n+ edge = stack.shift\n+ next unless edge.valid?\n+ next unless edge.faces.length == 2\n+ face1, face2 = edge.faces\n+ # Check if all the points of the two faces are on the same plane.\n+ # Comparing normals is not enough.\n+ next unless face1.normal.samedirection?(face2.normal)\n+ pts1 = face1.vertices.map { |vertex| vertex.position }\n+ pts2 = face2.vertices.map { |vertex| vertex.position }\n+ points = pts1 + pts2\n+ plane = Geom.fit_plane_to_points(points)\n+ next unless points.all? { |point| point.on_plane?(plane) }\n+ # In CleanUp the faces are checked to not be duplicate of each other -\n+ # overlapping. But since can we assume the STL importer doesn't create\n+ # such messy geometry?\n+ # \n+ # There is also a routine in CleanUp omitted here that checks if the\n+ # faces to be merged are degenerate - all edges are parallel.\n+ # \n+ # These check have been omitted to save processing time - as they might\n+ # not appear in a STL import? The checks where required in CleanUp due\n+ # to the large amount of degenerate geometry it was fed.\n+ # \n+ # \n+ # Erasing the shared edges is tricky. Often things get messed up if we\n+ # try to erase them all at once. When colouring the result of\n+ # shared_edges it appear that edges between non-planar faces are\n+ # returned. Not sure why this is.\n+ # \n+ # What does seem to work best is to first erase the edge we got from the\n+ # stack and then check the shared set of edges afterwards and erase them\n+ # after we've verified they are not part of any faces any more.\n+ shared_edges = face1.edges & face2.edges\n+ #shared_edges.each { |e| e.material = 'red' } # DEBUG\n+ edge.erase!\n+ # Find left over edges that are no longer connected to any face.\n+ loose_edges = shared_edges.select { |e| e.valid? && e.faces.empty? }\n+ entities.erase_entities(loose_edges)\n+ # Validate result - check if we destroyed some geometry.\n+ if face1.deleted? && face2.deleted?\n+ puts 'Merge error!' # DEBUG. What should be do there?\n+ end\n+ end\n+ nil\n+ end\n+ private :cleanup_geometry\n+\n+ # This function is ported from Vertex Tools. It attempts to trigger\n+ # SketchUp's own healing mechanism.\n+ #\n+ # I have tried two versions of this method, one where there is one temp\n+ # group and edge for each vertex, and one (this one) where there is only\n+ # one temp group. This latter one is three times faster than the former.\n+ # However, when testing Vertex Tools there appeared to be some edge cases\n+ # where this one didn't fix everything.\n+ # Those cases where very extreme cases of messed up geometry, so I chose\n+ # to still use this one due to its performance.\n+ #\n+ # Should there be a number of cases where healing is required and this\n+ # method doesn't cut it, then it can be replaced with the alternative\n+ # version. But until we have a set of real world cases I want to use this\n+ # one. \n+ #\n+ # -ThomThom\n+ #\n+ # @param [Sketchup::Entities] entities\n+ # @param [Array<Geom::Point3d>] points\n+ #\n+ # @return [Integer]\n+ # @since 1.1.0\n+ def heal_geometry(entities)\n+ # Collect positions of all vertices.\n+ vertices = entities.grep(Sketchup::Edge) { |edge|\n+ edge.vertices\n+ }\n+ vertices.flatten!\n+ vertices.uniq!\n+ points = vertices.map! { |vertex| vertex.position }\n+ # Heal vertices.\n+ # Create a temp group with a set of zero length edges for each vertex -\n+ # when exploded will trigger SketchUp's internal healing function.\n+ temp_group = entities.add_group\n+ offset_reverse = [Z_AXIS.reverse]\n+ for point in points\n+ temp_edge = temp_group.entities.add_line(point, point.offset(Z_AXIS))\n+ # To prevent the temp edges to merging with each other they must be\n+ # transformed to zero length edges immediately after creation.\n+ # See Issue #77.\n+ temp_group.entities.transform_by_vectors(\n+ [temp_edge.end], offset_reverse)\n+ end\n+ temp_group.explode\n+ points.size\n+ end\n+ private :heal_geometry\n+\n+ # Checks of a given instance contains geometry that is solid. Compatible\n+ # with older SketchUp versions before SketchUp 8.\n+ #\n+ # @param [Sketchup::Group,Sketchup::ComponentInstance] instance\n+ def is_solid?(entities)","path":"src/sketchup-stl/cleanup.rb","position":112,"original_position":112,"commit_id":"d02a796cf6a4f31e2a29618d72f6efa1d8db0d0d","original_commit_id":"d02a796cf6a4f31e2a29618d72f6efa1d8db0d0d","user":{"login":"thomthom","id":192418,"avatar_url":"https://0.gravatar.com/avatar/b0220a4b0ec42f2ddc610d0c187b1ee1?d=https%3A%2F%2Fidenticons.github.com%2Fd8287a9444b92f6e0912a6bf9e735661.png","gravatar_id":"b0220a4b0ec42f2ddc610d0c187b1ee1","url":"https://api.github.com/users/thomthom","html_url":"https://github.com/thomthom","followers_url":"https://api.github.com/users/thomthom/followers","following_url":"https://api.github.com/users/thomthom/following{/other_user}","gists_url":"https://api.github.com/users/thomthom/gists{/gist_id}","starred_url":"https://api.github.com/users/thomthom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomthom/subscriptions","organizations_url":"https://api.github.com/users/thomthom/orgs","repos_url":"https://api.github.com/users/thomthom/repos","events_url":"https://api.github.com/users/thomthom/events{/privacy}","received_events_url":"https://api.github.com/users/thomthom/received_events","type":"User"},"body":"This isn't really a cleanup method. Maybe the module should be a Utility module? In which case `cleanup_geometry` is fine for a method name.","created_at":"2013-10-06T19:27:28Z","updated_at":"2013-10-06T19:27:28Z","html_url":"https://github.com/SketchUp/sketchup-stl/pull/100#discussion_r6787826","pull_request_url":"https://api.github.com/repos/SketchUp/sketchup-stl/pulls/100","_links":{"self":{"href":"https://api.github.com/repos/SketchUp/sketchup-stl/pulls/comments/6787826"},"html":{"href":"https://github.com/SketchUp/sketchup-stl/pull/100#discussion_r6787826"},"pull_request":{"href":"https://api.github.com/repos/SketchUp/sketchup-stl/pulls/100"}}}}

{"repository":{"description":"A SketchUp Ruby Extension that adds STL (STereoLithography) file format import and export.","homepage":"http://extensions.sketchup.com/content/sketchup-stl","watchers":67,"stargazers":67,"forks":19,"fork":false,"size":1179,"owner":"SketchUp","private":false,"open_issues":22,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2012-10-11T12:48:08-07:00","pushed_at":"2013-09-29T03:48:15-07:00","master_branch":"master","organization":"SketchUp"},"actor_attributes":{"type":"User","name":"Thomas Thomassen","blog":"http://www.thomthom.net/","location":"Trondheim, Norway","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/SketchUp/sketchup-stl/pull/100#discussion_r6787826"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/aerogear/aerogear-js/pulls/comments/5480277","id":5480277,"body":"Just use object literal here:\r\n\r\n```JS\r\nvar metadata = {\r\n deviceToken: \"theDeviceToken\",\r\n alias: \"some_username\",\r\n category: \"email\"\r\n};\r\n```","diff_hunk":"@@ -15,24 +15,61 @@\n */\n (function( AeroGear, $, undefined ) {\n /**\n- DESCRIPTION\n+ The UnifiedPushClient object is used to perfom register and unregister operations against the AeroGear UnifiedPush server.\n @constructs AeroGear.UnifiedPushClient\n @param {String} variantID - the id representing the mobile application variant\n @param {String} variantSecret - the secret for the mobile application variant\n- @param {String} [pushServerURL=\"http://\" + window.location.hostname + \":8080/ag-push/rest/registry/device\"] - location of the unified push server\n+ @param {String} pushServerURL - the location of the UnifiedPush server\n @returns {Object} The created unified push server client\n+ @example\n+ //Create the UnifiedPush client object:\n+ var client = AeroGear.UnifiedPushClient(\n+ \"myVariantID\",\n+ \"myVariantSecret\",\n+ \"http://SERVER:PORT/CONTEXT/rest/registry/device\"\n+ );\n+\n+ // assemble the metadata for the registration:\n+ var metadata = new Object();","path":"src/unified-push/aerogear.unifiedpush.js","position":21,"original_position":21,"commit_id":"e81ef429493f3e7951fe562c48ff7a0120c85e88","original_commit_id":"e81ef429493f3e7951fe562c48ff7a0120c85e88","user":{"login":"kborchers","id":282468,"avatar_url":"https://secure.gravatar.com/avatar/911518c9eb1079cb417b06b78215414b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"911518c9eb1079cb417b06b78215414b","url":"https://api.github.com/users/kborchers","html_url":"https://github.com/kborchers","followers_url":"https://api.github.com/users/kborchers/followers","following_url":"https://api.github.com/users/kborchers/following{/other_user}","gists_url":"https://api.github.com/users/kborchers/gists{/gist_id}","starred_url":"https://api.github.com/users/kborchers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kborchers/subscriptions","organizations_url":"https://api.github.com/users/kborchers/orgs","repos_url":"https://api.github.com/users/kborchers/repos","events_url":"https://api.github.com/users/kborchers/events{/privacy}","received_events_url":"https://api.github.com/users/kborchers/received_events","type":"User"},"created_at":"2013-07-30T15:46:09Z","updated_at":"2013-07-30T15:46:09Z","html_url":"https://github.com/aerogear/aerogear-js/pull/50#discussion_r5480277","pull_request_url":"https://api.github.com/repos/aerogear/aerogear-js/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-js/pulls/comments/5480277"},"html":{"href":"https://github.com/aerogear/aerogear-js/pull/50#discussion_r5480277"},"pull_request":{"href":"https://api.github.com/repos/aerogear/aerogear-js/pulls/50"}}}}

{"repository":{"description":"JavaScript client library implementation for AeroGear","watchers":11,"stargazers":11,"forks":9,"fork":false,"size":1554,"owner":"aerogear","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-07-09T12:33:26-07:00","pushed_at":"2013-07-29T09:22:46-07:00","master_branch":"master","organization":"aerogear"},"actor_attributes":{"type":"User","name":"Kris Borchers","location":"Naperville, IL","email":"[email protected]"},"url":"https://github.com/aerogear/aerogear-js/pull/50#discussion_r5480277"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/aerogear/aerogear-controller/pulls/comments/3079375","id":3079375,"body":"Ah, well spotted and I missed this while refactoring limitParamValue which was previously a String. Fixed locally now.","path":"src/main/java/org/jboss/aerogear/controller/router/rest/pagination/PaginationInfo.java","position":72,"original_position":72,"commit_id":"94c2dd69002a8c2e71342426daf36f768a366da7","original_commit_id":"94c2dd69002a8c2e71342426daf36f768a366da7","user":{"login":"danbev","id":432351,"avatar_url":"https://secure.gravatar.com/avatar/1be2cab21d939dc1abb2ed47b46877c6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"1be2cab21d939dc1abb2ed47b46877c6","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User"},"created_at":"2013-02-20T12:29:47Z","updated_at":"2013-02-20T12:29:47Z","_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-controller/pulls/comments/3079375"},"html":{"href":"https://github.com/aerogear/aerogear-controller/pull/50#discussion_r3079375"},"pull_request":{"href":"https://api.github.com/repos/aerogear/aerogear-controller/pulls/50"}}}}

{"repository":{"description":"","homepage":"","watchers":19,"stargazers":19,"forks":14,"fork":false,"size":376,"owner":"aerogear","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2012-03-06T11:47:39-08:00","pushed_at":"2013-02-18T17:41:49-08:00","master_branch":"master","organization":"aerogear"},"actor_attributes":{"name":"Daniel Bevenius","company":"Red Hat/JBoss","blog":"http://aerogear.org","location":"Sweden","email":"[email protected]","type":"User"},"url":"https://github.com/aerogear/aerogear-controller/pull/50#discussion_r3079375"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit/pulls/comments/3169552","id":3169552,"body":"`eq(1)`? Are there going to be many elements with the class 'beta-notice'? I am inclined to suggest that we perhaps add a class of `.js-footer` to the element we want this to stop scrolling at. That way we can move it in the future without any need to change this script.","diff_hunk":"@@ -45,7 +45,8 @@\n stopScrollingAtFooter.initTimeout();\n },\n updateFooterTop: function(){\n- var footer = $('#footer');\n+ var $betaNotice = $('.beta-notice'),\n+ footer = ($betaNotice.length) ? $betaNotice.eq(1) : $('#footer');","path":"app/assets/javascripts/govuk/stop-scrolling-at-footer.js","position":6,"original_position":6,"commit_id":"2a6766343866afd87c554bbade1f3c334211afcf","original_commit_id":"2a6766343866afd87c554bbade1f3c334211afcf","user":{"login":"edds","id":35035,"avatar_url":"https://secure.gravatar.com/avatar/5ce91fa49a613cbc3e20d5f96856473f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"5ce91fa49a613cbc3e20d5f96856473f","url":"https://api.github.com/users/edds","html_url":"https://github.com/edds","followers_url":"https://api.github.com/users/edds/followers","following_url":"https://api.github.com/users/edds/following","gists_url":"https://api.github.com/users/edds/gists{/gist_id}","starred_url":"https://api.github.com/users/edds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edds/subscriptions","organizations_url":"https://api.github.com/users/edds/orgs","repos_url":"https://api.github.com/users/edds/repos","events_url":"https://api.github.com/users/edds/events{/privacy}","received_events_url":"https://api.github.com/users/edds/received_events","type":"User"},"created_at":"2013-02-27T12:14:16Z","updated_at":"2013-02-27T12:14:16Z","_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit/pulls/comments/3169552"},"html":{"href":"https://github.com/alphagov/govuk_frontend_toolkit/pull/31#discussion_r3169552"},"pull_request":{"href":"https://api.github.com/repos/alphagov/govuk_frontend_toolkit/pulls/31"}}}}

{"repository":{"description":"Generic tools and helpers for building GDS front-end apps","watchers":12,"stargazers":12,"forks":4,"fork":false,"size":324,"owner":"alphagov","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-08-15T09:02:20-07:00","pushed_at":"2013-02-25T06:52:36-08:00","master_branch":"master","organization":"alphagov"},"actor_attributes":{"type":"User","name":"Edd Sowden","blog":"http://e26.co.uk","location":"London, UK","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/alphagov/govuk_frontend_toolkit/pull/31#discussion_r3169552"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/alphagov/transition/pulls/comments/5525255","id":5525255,"body":"Have a blueberry, maybe that'll help?!?!","diff_hunk":"@@ -42,6 +41,7 @@ def url_filter(urls)\n urls = urls.where(content_type_id: params[:content_type]) if params[:content_type].present?\n urls = urls.where(state: URL_FILTER_QUERY_TO_STATE[params[:state]]) if params[:state].present?\n urls = urls.where(for_scraping: params[:for_scrape] == 'true') if params[:for_scrape].present?\n+ urls = urls.order(:id)","path":"app/controllers/urls_controller.rb","position":12,"original_position":12,"commit_id":"8cff1b65eaad4d2ac98280ba3c4f89fca0268d88","original_commit_id":"8cff1b65eaad4d2ac98280ba3c4f89fca0268d88","user":{"login":"jpawlyn","id":45294,"avatar_url":"https://secure.gravatar.com/avatar/b01d396d3dd8a8b793f8dc9a3f730338?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"b01d396d3dd8a8b793f8dc9a3f730338","url":"https://api.github.com/users/jpawlyn","html_url":"https://github.com/jpawlyn","followers_url":"https://api.github.com/users/jpawlyn/followers","following_url":"https://api.github.com/users/jpawlyn/following{/other_user}","gists_url":"https://api.github.com/users/jpawlyn/gists{/gist_id}","starred_url":"https://api.github.com/users/jpawlyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpawlyn/subscriptions","organizations_url":"https://api.github.com/users/jpawlyn/orgs","repos_url":"https://api.github.com/users/jpawlyn/repos","events_url":"https://api.github.com/users/jpawlyn/events{/privacy}","received_events_url":"https://api.github.com/users/jpawlyn/received_events","type":"User"},"created_at":"2013-08-01T09:09:52Z","updated_at":"2013-08-01T09:09:52Z","html_url":"https://github.com/alphagov/transition/pull/61#discussion_r5525255","pull_request_url":"https://api.github.com/repos/alphagov/transition/pulls/61","_links":{"self":{"href":"https://api.github.com/repos/alphagov/transition/pulls/comments/5525255"},"html":{"href":"https://github.com/alphagov/transition/pull/61#discussion_r5525255"},"pull_request":{"href":"https://api.github.com/repos/alphagov/transition/pulls/61"}}}}

{"repository":{"description":"","watchers":0,"stargazers":0,"forks":2,"fork":false,"size":1898,"owner":"alphagov","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-04-12T07:19:35-07:00","pushed_at":"2013-08-01T01:54:06-07:00","master_branch":"master","organization":"alphagov"},"actor_attributes":{"type":"User","name":"Jolyon Pawlyn","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/alphagov/transition/pull/61#discussion_r5525255"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/alphagov/whitehall/pulls/comments/8368075","id":8368075,"diff_hunk":"@@ -0,0 +1,77 @@\n+require 'csv'\n+\n+module DataHygiene\n+ class DuplicateAttachmentFinder\n+ DUP_EDITION_ATTACHMENT_SQL = <<-HEREDOC\n+ SELECT attachable_id as id, attachment_data.carrierwave_file as filename FROM attachments\n+ JOIN attachment_data on attachments.attachment_data_id = attachment_data.id\n+ JOIN editions on attachable_id = editions.id\n+ WHERE attachable_type = \"Edition\" AND editions.state = 'published'\n+ GROUP BY attachable_type, attachable_id, attachment_data.carrierwave_file\n+ HAVING count(*) > 1;\n+ HEREDOC\n+\n+ DUP_NON_EDITION_ATTACHMENT_SQL = <<-HEREDOC\n+ SELECT attachable_type, attachable_id as id FROM attachments\n+ JOIN attachment_data on attachments.attachment_data_id = attachment_data.id\n+ WHERE attachable_type != \"Edition\" and attachable_type != \"SupportingPage\"\n+ GROUP BY attachable_type, attachable_id, attachment_data.carrierwave_file\n+ HAVING count(*) > 1;\n+ HEREDOC\n+\n+ def editions\n+ Edition.where(id: edition_ids)\n+ end\n+\n+ def non_editions\n+ duplicate_non_edition_results.collect do |results|\n+ type, id = results\n+ type.constantize.find(id)\n+ end\n+ end\n+\n+ def csv_dump\n+ CSV.generate do |csv|\n+ csv << %w(TYPE ID DEPARTMENT ADMIN_URL PUBLIC_URL FILENAME IDENTICAL?)\n+ duplicate_edition_results.each do |duplicate_info|\n+ id, filename, _ = duplicate_info","path":"lib/data_hygiene/duplicate_attachment_finder.rb","position":37,"original_position":37,"commit_id":"b3c52b9bc7e254ee23e27ccddc2c9be07fc04569","original_commit_id":"b3c52b9bc7e254ee23e27ccddc2c9be07fc04569","user":{"login":"elliotcm","id":109225,"avatar_url":"https://gravatar.com/avatar/2c938ed150a685b33d1b91266b382c8d?d=https%3A%2F%2Fidenticons.github.com%2Fe77f0f131d3e625309e880f7a3492b89.png&r=x","gravatar_id":"2c938ed150a685b33d1b91266b382c8d","url":"https://api.github.com/users/elliotcm","html_url":"https://github.com/elliotcm","followers_url":"https://api.github.com/users/elliotcm/followers","following_url":"https://api.github.com/users/elliotcm/following{/other_user}","gists_url":"https://api.github.com/users/elliotcm/gists{/gist_id}","starred_url":"https://api.github.com/users/elliotcm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elliotcm/subscriptions","organizations_url":"https://api.github.com/users/elliotcm/orgs","repos_url":"https://api.github.com/users/elliotcm/repos","events_url":"https://api.github.com/users/elliotcm/events{/privacy}","received_events_url":"https://api.github.com/users/elliotcm/received_events","type":"User","site_admin":false},"body":"This is an array of arrays, right? So we can do `duplicate_edition_results.each do |(id, filename, _)|`, although looking at the SQL I'm not sure where the third parameter is coming from, so could it not be ` duplicate_edition_results.each do |(id, filename)|`?","created_at":"2013-12-16T14:53:19Z","updated_at":"2013-12-16T14:53:19Z","html_url":"https://github.com/alphagov/whitehall/pull/1161#discussion_r8368075","pull_request_url":"https://api.github.com/repos/alphagov/whitehall/pulls/1161","_links":{"self":{"href":"https://api.github.com/repos/alphagov/whitehall/pulls/comments/8368075"},"html":{"href":"https://github.com/alphagov/whitehall/pull/1161#discussion_r8368075"},"pull_request":{"href":"https://api.github.com/repos/alphagov/whitehall/pulls/1161"}}}}

{"repository":{"description":"Inside Government: how the UK Government works, what it's doing, and how you can get involved.","homepage":"https://www.gov.uk/government/","watchers":122,"stargazers":122,"forks":22,"fork":false,"size":154008,"owner":"alphagov","private":false,"open_issues":5,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2011-09-19T08:10:49-07:00","pushed_at":"2013-12-16T05:10:09-08:00","master_branch":"master","organization":"alphagov"},"actor_attributes":{"type":"User","name":"Elliot Crosby-McCullough","company":"GDS","blog":"http://elliotcm.co.uk","location":"United Kingdom","email":"[email protected]"},"url":"https://github.com/alphagov/whitehall/pull/1161#discussion_r8368075"}

PullRequestReviewCommentEvent

{"comment":{"user":{"subscriptions_url":"https://api.github.com/users/alext/subscriptions","gists_url":"https://api.github.com/users/alext/gists{/gist_id}","following_url":"https://api.github.com/users/alext/following","avatar_url":"https://secure.gravatar.com/avatar/6bbe0049baa059b9f3e5be8db1abbeb9?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","login":"alext","received_events_url":"https://api.github.com/users/alext/received_events","events_url":"https://api.github.com/users/alext/events{/privacy}","gravatar_id":"6bbe0049baa059b9f3e5be8db1abbeb9","repos_url":"https://api.github.com/users/alext/repos","followers_url":"https://api.github.com/users/alext/followers","id":5560,"url":"https://api.github.com/users/alext","type":"User","organizations_url":"https://api.github.com/users/alext/orgs","starred_url":"https://api.github.com/users/alext/starred{/owner}{/repo}"},"path":"lib/flows/locales/en/maternity-paternity-calculator.yml","commit_id":"d7c376eca68a1162d1d69f1ec2f354bf68e6e9d5","original_position":5,"updated_at":"2013-02-04T14:29:03Z","created_at":"2013-02-04T14:29:03Z","body":"This part slug doesn't exist in production at the moment, so you get redirected to the start of the guide.","original_commit_id":"d7c376eca68a1162d1d69f1ec2f354bf68e6e9d5","id":2876625,"url":"https://api.github.com/repos/alphagov/smart-answers/pulls/comments/2876625","position":5,"_links":{"pull_request":{"href":"https://api.github.com/repos/alphagov/smart-answers/pulls/167"},"html":{"href":"https://github.com/alphagov/smart-answers/pull/167#discussion_r2876625"},"self":{"href":"https://api.github.com/repos/alphagov/smart-answers/pulls/comments/2876625"}}}}

{"repository":{"forks":6,"owner":"alphagov","has_downloads":true,"open_issues":3,"homepage":"","has_wiki":true,"watchers":26,"created_at":"2011-10-26T08:39:01-07:00","fork":false,"size":1908,"description":"","stargazers":26,"organization":"alphagov","private":false,"has_issues":true,"language":"Ruby","pushed_at":"2013-02-04T06:13:17-08:00"},"actor_attributes":{"location":"London","type":"User","company":"Government Digital Service","email":"[email protected]","name":"Alex Tomlins"},"url":"https://github.com/alphagov/smart-answers/pull/167#discussion_r2876625"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/atlasapi/atlas-persistence/pulls/comments/6746344","id":6746344,"body":"Perhaps this could be extracted to a `ApplicationSources.defaultSources()` method which returns a private static final instance which is this 'empty' sources.","diff_hunk":"@@ -28,25 +42,41 @@ private String generateSlug(Id id) {\n private String generateApiKey() {\n return new UUIDGenerator().generate();\n }\n- \n- protected Application addIdAndApiKey(Application application) {\n- Id id = Id.valueOf(idGenerator.generateRaw());\n- ApplicationCredentials credentials = application.getCredentials()\n- .copy().withApiKey(generateApiKey()).build();\n- Application modified = application.copy()\n- .withId(id)\n- .withCredentials(credentials)\n- .withSlug(generateSlug(id))\n- .build();\n- return modified;\n- }\n \n abstract void doCreateApplication(Application application);\n \n abstract void doUpdateApplication(Application application);\n \n public Application createApplication(Application application) {\n- Application created = withGuaranteedSlug(addIdAndApiKey(application));\n+ // Create requests do not have to post credentials or \n+ // sources part of the object so ensure these exist\n+ ApplicationCredentials.Builder credentialsBuilder;\n+ if (application.getCredentials() != null) {\n+ credentialsBuilder = application.getCredentials().copy();\n+ } else {\n+ credentialsBuilder = ApplicationCredentials.builder();\n+ }\n+ credentialsBuilder = credentialsBuilder.withApiKey(generateApiKey());\n+ ApplicationSources sources = application.getSources();\n+ // If sources not given create an empty sources object\n+ if (sources == null) {\n+ sources = ApplicationSources","path":"src/main/java/org/atlasapi/persistence/application/AbstractApplicationStore.java","position":74,"original_position":74,"commit_id":"e525819f0528e34cb5eb83e36406c5919b0098cd","original_commit_id":"e525819f0528e34cb5eb83e36406c5919b0098cd","user":{"login":"fredvdd","id":147739,"avatar_url":"https://2.gravatar.com/avatar/70daa9f81f2d6e10f1bed1dcc1ebdcc3?d=https%3A%2F%2Fidenticons.github.com%2F15fddc3a74f3f9a48916e97fdef9fa51.png","gravatar_id":"70daa9f81f2d6e10f1bed1dcc1ebdcc3","url":"https://api.github.com/users/fredvdd","html_url":"https://github.com/fredvdd","followers_url":"https://api.github.com/users/fredvdd/followers","following_url":"https://api.github.com/users/fredvdd/following{/other_user}","gists_url":"https://api.github.com/users/fredvdd/gists{/gist_id}","starred_url":"https://api.github.com/users/fredvdd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fredvdd/subscriptions","organizations_url":"https://api.github.com/users/fredvdd/orgs","repos_url":"https://api.github.com/users/fredvdd/repos","events_url":"https://api.github.com/users/fredvdd/events{/privacy}","received_events_url":"https://api.github.com/users/fredvdd/received_events","type":"User"},"created_at":"2013-10-03T16:35:37Z","updated_at":"2013-10-03T16:35:37Z","html_url":"https://github.com/atlasapi/atlas-persistence/pull/105#discussion_r6746344","pull_request_url":"https://api.github.com/repos/atlasapi/atlas-persistence/pulls/105","_links":{"self":{"href":"https://api.github.com/repos/atlasapi/atlas-persistence/pulls/comments/6746344"},"html":{"href":"https://github.com/atlasapi/atlas-persistence/pull/105#discussion_r6746344"},"pull_request":{"href":"https://api.github.com/repos/atlasapi/atlas-persistence/pulls/105"}}}}

{"repository":{"description":"","homepage":"docs.atlasapi.org","watchers":3,"stargazers":3,"forks":0,"fork":false,"size":5256,"owner":"atlasapi","private":false,"open_issues":5,"has_issues":false,"has_downloads":false,"has_wiki":false,"language":"Java","created_at":"2010-07-07T09:30:16-07:00","pushed_at":"2013-10-03T09:01:58-07:00","master_branch":"master","organization":"atlasapi"},"actor_attributes":{"type":"User","name":"Fred van den Driessche","company":"Metabroadcast","location":"London","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/atlasapi/atlas-persistence/pull/105#discussion_r6746344"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/autotest/virt-test/pulls/comments/5088444","id":5088444,"body":"I will check on this and if appropriate would update it in libvirt_vm. Thanks :+1: ","diff_hunk":"@@ -0,0 +1,140 @@\n+import re, logging\n+from autotest.client.shared import error\n+from virttest import virsh, libvirt_vm\n+from virttest.libvirt_xml import vm_xml\n+\n+driver_dict = {'virtio':'virtio_net', '-':'8139cp', 'e1000':'e1000',\n+ 'rtl8139':'8139cp'}\n+\n+# Regular expression for the below output\n+# vnet0 bridge virbr0 virtio 52:54:00:b2:b3:b4\n+rg = re.compile(r\"^(\\w+)\\s+(\\w+)\\s+(\\w+)\\s+(\\S+)\\s+(([a-fA-F0-9]{2}:?){6})\")\n+\n+def run_virsh_domiflist(test, params, env):\n+ \"\"\"\n+ Step 1: Get the virsh domiflist value.\n+ Step 2: Check for interface in xml file.\n+ Step 3: Check for type in xml file.\n+ Step 4: Check for model inside the guest and xml file.\n+ Step 5: Check for mac id inside the guest and xml file\n+ \"\"\"\n+\n+ def parse_interface_details(output):","path":"libvirt/tests/src/virsh_cmd/domain/virsh_domiflist.py","position":22,"original_position":22,"commit_id":"e8a84a8411d698e737ad7e9fc947ee35356e0d1a","original_commit_id":"e8a84a8411d698e737ad7e9fc947ee35356e0d1a","user":{"login":"sathnaga","id":1841809,"avatar_url":"https://secure.gravatar.com/avatar/54f3f774152fcf970183aac2bf237594?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"54f3f774152fcf970183aac2bf237594","url":"https://api.github.com/users/sathnaga","html_url":"https://github.com/sathnaga","followers_url":"https://api.github.com/users/sathnaga/followers","following_url":"https://api.github.com/users/sathnaga/following{/other_user}","gists_url":"https://api.github.com/users/sathnaga/gists{/gist_id}","starred_url":"https://api.github.com/users/sathnaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sathnaga/subscriptions","organizations_url":"https://api.github.com/users/sathnaga/orgs","repos_url":"https://api.github.com/users/sathnaga/repos","events_url":"https://api.github.com/users/sathnaga/events{/privacy}","received_events_url":"https://api.github.com/users/sathnaga/received_events","type":"User"},"created_at":"2013-07-09T12:34:14Z","updated_at":"2013-07-09T12:34:14Z","html_url":"https://github.com/autotest/virt-test/pull/565#discussion_r5088444","pull_request_url":"https://api.github.com/repos/autotest/virt-test/pulls/565","_links":{"self":{"href":"https://api.github.com/repos/autotest/virt-test/pulls/comments/5088444"},"html":{"href":"https://github.com/autotest/virt-test/pull/565#discussion_r5088444"},"pull_request":{"href":"https://api.github.com/repos/autotest/virt-test/pulls/565"}}}}

{"repository":{"description":"Linux Virtualization Tests","watchers":34,"stargazers":34,"forks":47,"fork":false,"size":2560,"owner":"autotest","private":false,"open_issues":5,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-09-25T09:10:43-07:00","pushed_at":"2013-07-08T20:02:04-07:00","master_branch":"master","organization":"autotest"},"actor_attributes":{"type":"User","name":"Satheesh Rajendran","company":"IBM","location":"Bangalore","email":"[email protected]"},"url":"https://github.com/autotest/virt-test/pull/565#discussion_r5088444"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/autotest/virt-test/pulls/comments/6820890","id":6820890,"diff_hunk":"@@ -534,7 +534,7 @@ def write(self, path, content):\n This call creates a file called \"path\". The content of the file\n is the string \"content\" (which can contain any 8 bit data).\n \"\"\"\n- return self.inner_cmd(\"write %s %s\" % (path, content))\n+ return self.inner_cmd(\"write '%s' '%s'\" % (path, content))","path":"virttest/utils_libguestfs.py","position":5,"original_position":5,"commit_id":"5af678bb5eb8c090fdd76d673f586dc26306fa2a","original_commit_id":"5af678bb5eb8c090fdd76d673f586dc26306fa2a","user":{"login":"yumingfei","id":2076220,"avatar_url":"https://0.gravatar.com/avatar/cc30a056c732ffec7d9704bfe09d5e00?d=https%3A%2F%2Fidenticons.github.com%2Fb1c37f97f6420209ce09285347a95d71.png","gravatar_id":"cc30a056c732ffec7d9704bfe09d5e00","url":"https://api.github.com/users/yumingfei","html_url":"https://github.com/yumingfei","followers_url":"https://api.github.com/users/yumingfei/followers","following_url":"https://api.github.com/users/yumingfei/following{/other_user}","gists_url":"https://api.github.com/users/yumingfei/gists{/gist_id}","starred_url":"https://api.github.com/users/yumingfei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yumingfei/subscriptions","organizations_url":"https://api.github.com/users/yumingfei/orgs","repos_url":"https://api.github.com/users/yumingfei/repos","events_url":"https://api.github.com/users/yumingfei/events{/privacy}","received_events_url":"https://api.github.com/users/yumingfei/received_events","type":"User","site_admin":false},"body":"Yes, but since I seperate the two pull requests, I have to.\r\nI will update in time or maybe push to next directly.","created_at":"2013-10-08T09:40:19Z","updated_at":"2013-10-08T09:40:19Z","html_url":"https://github.com/autotest/virt-test/pull/883#discussion_r6820890","pull_request_url":"https://api.github.com/repos/autotest/virt-test/pulls/883","_links":{"self":{"href":"https://api.github.com/repos/autotest/virt-test/pulls/comments/6820890"},"html":{"href":"https://github.com/autotest/virt-test/pull/883#discussion_r6820890"},"pull_request":{"href":"https://api.github.com/repos/autotest/virt-test/pulls/883"}}}}

{"repository":{"description":"Linux Virtualization Tests","watchers":44,"stargazers":44,"forks":60,"fork":false,"size":32767,"owner":"autotest","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-09-25T09:10:43-07:00","pushed_at":"2013-10-07T08:31:01-07:00","master_branch":"master","organization":"autotest"},"actor_attributes":{"type":"User","name":"Fergus Yu","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/autotest/virt-test/pull/883#discussion_r6820890"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/autotest/virt-test/pulls/comments/6050779","id":6050779,"body":"Maybe a clean up here?","diff_hunk":"@@ -0,0 +1,49 @@\n+- svirt_attach_disk:\n+ virt_test_type = libvirt\n+ type = svirt_attach_disk\n+ start_vm = no\n+ kill_vm = yes\n+ kill_vm_gracefully = yes\n+ kill_vm_on_error = yes\n+ # Label for VM.\n+ # Prefix of 'sad' for \"svirt_attach_disk\"\n+ sad_vm_sec_label = \"system_u:system_r:svirt_t:s0:c87,c520\"\n+ # Default label for the other source.\n+ # To assure VM is able to access other sources.\n+ sad_disk_default_label = \"system_u:object_r:svirt_image_t:s0\"\n+ variants:\n+ - host_selinux_enforcing:\n+ sad_host_selinux = \"enforcing\"\n+ # TODO:","path":"libvirt/tests/cfg/svirt/svirt_attach_disk.cfg","position":17,"original_position":17,"commit_id":"8100ff1aa1e9a18c6f117b1640af0cf11ac99d0d","original_commit_id":"8100ff1aa1e9a18c6f117b1640af0cf11ac99d0d","user":{"login":"clebergnu","id":447178,"avatar_url":"https://1.gravatar.com/avatar/df2929fe99f0b5a825144148cee669d0?d=https%3A%2F%2Fidenticons.github.com%2Fa4a19b81c4755a4ae0ad47cb16b5b571.png","gravatar_id":"df2929fe99f0b5a825144148cee669d0","url":"https://api.github.com/users/clebergnu","html_url":"https://github.com/clebergnu","followers_url":"https://api.github.com/users/clebergnu/followers","following_url":"https://api.github.com/users/clebergnu/following{/other_user}","gists_url":"https://api.github.com/users/clebergnu/gists{/gist_id}","starred_url":"https://api.github.com/users/clebergnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebergnu/subscriptions","organizations_url":"https://api.github.com/users/clebergnu/orgs","repos_url":"https://api.github.com/users/clebergnu/repos","events_url":"https://api.github.com/users/clebergnu/events{/privacy}","received_events_url":"https://api.github.com/users/clebergnu/received_events","type":"User"},"created_at":"2013-08-29T00:48:15Z","updated_at":"2013-08-29T00:48:15Z","html_url":"https://github.com/autotest/virt-test/pull/561#discussion_r6050779","pull_request_url":"https://api.github.com/repos/autotest/virt-test/pulls/561","_links":{"self":{"href":"https://api.github.com/repos/autotest/virt-test/pulls/comments/6050779"},"html":{"href":"https://github.com/autotest/virt-test/pull/561#discussion_r6050779"},"pull_request":{"href":"https://api.github.com/repos/autotest/virt-test/pulls/561"}}}}

{"repository":{"description":"Linux Virtualization Tests","watchers":41,"stargazers":41,"forks":57,"fork":false,"size":27007,"owner":"autotest","private":false,"open_issues":57,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-09-25T09:10:43-07:00","pushed_at":"2013-08-28T15:34:42-07:00","master_branch":"master","organization":"autotest"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/autotest/virt-test/pull/561#discussion_r6050779"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/composer/composer/pulls/comments/7220103","id":7220103,"diff_hunk":"@@ -496,6 +496,15 @@ protected function loadIncludes($data)\n if (isset($data['packages'])) {\n foreach ($data['packages'] as $package => $versions) {\n foreach ($versions as $version => $metadata) {\n+\n+ // we copy over the repository's connection options\n+ if (!empty($this->options)) {\n+ if (!isset($metadata['extra']['context-options'])) {\n+ $metadata['extra']['context-options'] = array();\n+ }\n+ $metadata['extra']['context-options'] = array_replace_recursive($this->options, $metadata['extra']['context-options']);","path":"src/Composer/Repository/ComposerRepository.php","position":10,"original_position":10,"commit_id":"4fc5d0f4bf3ea75f40d3e40bbfa8cbb367d5f402","original_commit_id":"4fc5d0f4bf3ea75f40d3e40bbfa8cbb367d5f402","user":{"login":"stof","id":439401,"avatar_url":"https://0.gravatar.com/avatar/7894bbdf1c05b18a1444ad8c76c9d583?d=https%3A%2F%2Fidenticons.github.com%2Fd339b80a37d1fe7e96192364ab2d75fe.png&r=x","gravatar_id":"7894bbdf1c05b18a1444ad8c76c9d583","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"This should be done for all repositories, not only for composer repositories, right ?","created_at":"2013-10-25T15:56:09Z","updated_at":"2013-10-25T15:56:09Z","html_url":"https://github.com/composer/composer/pull/2362#discussion_r7220103","pull_request_url":"https://api.github.com/repos/composer/composer/pulls/2362","_links":{"self":{"href":"https://api.github.com/repos/composer/composer/pulls/comments/7220103"},"html":{"href":"https://github.com/composer/composer/pull/2362#discussion_r7220103"},"pull_request":{"href":"https://api.github.com/repos/composer/composer/pulls/2362"}}}}

{"repository":{"description":"Dependency Manager for PHP","homepage":"http://getcomposer.org/","watchers":2887,"stargazers":2887,"forks":761,"fork":false,"size":16214,"owner":"composer","private":false,"open_issues":352,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2011-06-08T01:53:00-07:00","pushed_at":"2013-10-21T02:51:22-07:00","master_branch":"master","organization":"composer"},"actor_attributes":{"type":"User","name":"Christophe Coevoet","company":"Incenteev","location":"Paris","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/composer/composer/pull/2362#discussion_r7220103"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/concerto/concerto/pulls/comments/5783262","id":5783262,"body":"hahaha, yea ... my bad \r\n:octocat: ","diff_hunk":"@@ -165,9 +166,10 @@ def matches?(request)\n match 'content/' => 'feeds#index'\n match 'browse/' => 'feeds#index'\n \n+","path":"config/routes.rb","position":null,"original_position":14,"commit_id":"7a4a2f04118f136f36672ad4f87d17c04593bdd0","original_commit_id":"b266a7ed9a53969ccebb0d1add69e613806e87ca","user":{"login":"gabe283","id":3246274,"avatar_url":"https://secure.gravatar.com/avatar/80abd72cfc6479f247a418ccc9678a5c?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"80abd72cfc6479f247a418ccc9678a5c","url":"https://api.github.com/users/gabe283","html_url":"https://github.com/gabe283","followers_url":"https://api.github.com/users/gabe283/followers","following_url":"https://api.github.com/users/gabe283/following{/other_user}","gists_url":"https://api.github.com/users/gabe283/gists{/gist_id}","starred_url":"https://api.github.com/users/gabe283/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabe283/subscriptions","organizations_url":"https://api.github.com/users/gabe283/orgs","repos_url":"https://api.github.com/users/gabe283/repos","events_url":"https://api.github.com/users/gabe283/events{/privacy}","received_events_url":"https://api.github.com/users/gabe283/received_events","type":"User"},"created_at":"2013-08-15T04:44:44Z","updated_at":"2013-08-15T04:44:44Z","html_url":"https://github.com/concerto/concerto/pull/634#discussion_r5783262","pull_request_url":"https://api.github.com/repos/concerto/concerto/pulls/634","_links":{"self":{"href":"https://api.github.com/repos/concerto/concerto/pulls/comments/5783262"},"html":{"href":"https://github.com/concerto/concerto/pull/634#discussion_r5783262"},"pull_request":{"href":"https://api.github.com/repos/concerto/concerto/pulls/634"}}}}

{"repository":{"description":"Concerto Digital Signage System v2 (In Development)","homepage":"http://www.concerto-signage.org","watchers":60,"stargazers":60,"forks":15,"fork":false,"size":13230,"owner":"concerto","private":false,"open_issues":62,"has_issues":true,"has_downloads":false,"has_wiki":true,"language":"Ruby","created_at":"2010-02-19T06:03:05-08:00","pushed_at":"2013-08-14T21:11:13-07:00","master_branch":"master","organization":"concerto"},"actor_attributes":{"type":"User","name":"Gabe Perez","email":"[email protected]"},"url":"https://github.com/concerto/concerto/pull/634#discussion_r5783262"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/diagrams/diagrams-lib/pulls/comments/7101065","id":7101065,"diff_hunk":"@@ -262,14 +266,14 @@ numSegs :: ( Floating (Scalar v), Num c, Ord (Scalar v), InnerSpace v,\n FT.Measured (SegMeasure v) a\n )\n => a -> c\n-numSegs = fromIntegral . trailMeasure 0 (getSum . getSegCount)\n+numSegs = fromIntegral . trailMeasure 0 (getSum . view getSegCount)\n \n -- | Compute the total offset of anything measured by 'SegMeasure'.\n offset :: ( Floating (Scalar v), Ord (Scalar v), InnerSpace v,\n FT.Measured (SegMeasure v) t\n )\n => t -> v\n-offset = trailMeasure zeroV (getTotalOffset . oeOffset)\n+offset = trailMeasure zeroV (view getTotalOffset . view oeOffset)","path":"src/Diagrams/Trail.hs","position":62,"original_position":62,"commit_id":"b33b498bc52c4f733feccbebcb2148dda93c6de9","original_commit_id":"b33b498bc52c4f733feccbebcb2148dda93c6de9","user":{"login":"jeffreyrosenbluth","id":1226936,"avatar_url":"https://2.gravatar.com/avatar/081ba388b15855fa5e5c7e37ab5df39f?d=https%3A%2F%2Fidenticons.github.com%2F001a8d0a097fb9e53c5333065dbc9a42.png","gravatar_id":"081ba388b15855fa5e5c7e37ab5df39f","url":"https://api.github.com/users/jeffreyrosenbluth","html_url":"https://github.com/jeffreyrosenbluth","followers_url":"https://api.github.com/users/jeffreyrosenbluth/followers","following_url":"https://api.github.com/users/jeffreyrosenbluth/following{/other_user}","gists_url":"https://api.github.com/users/jeffreyrosenbluth/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffreyrosenbluth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffreyrosenbluth/subscriptions","organizations_url":"https://api.github.com/users/jeffreyrosenbluth/orgs","repos_url":"https://api.github.com/users/jeffreyrosenbluth/repos","events_url":"https://api.github.com/users/jeffreyrosenbluth/events{/privacy}","received_events_url":"https://api.github.com/users/jeffreyrosenbluth/received_events","type":"User","site_admin":false},"body":"yes","created_at":"2013-10-21T17:32:42Z","updated_at":"2013-10-21T17:32:42Z","html_url":"https://github.com/diagrams/diagrams-lib/pull/131#discussion_r7101065","pull_request_url":"https://api.github.com/repos/diagrams/diagrams-lib/pulls/131","_links":{"self":{"href":"https://api.github.com/repos/diagrams/diagrams-lib/pulls/comments/7101065"},"html":{"href":"https://github.com/diagrams/diagrams-lib/pull/131#discussion_r7101065"},"pull_request":{"href":"https://api.github.com/repos/diagrams/diagrams-lib/pulls/131"}}}}

{"repository":{"description":"Diagrams standard library","watchers":16,"stargazers":16,"forks":9,"fork":false,"size":3059,"owner":"diagrams","private":false,"open_issues":39,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Haskell","created_at":"2012-07-24T16:03:00-07:00","pushed_at":"2013-10-21T07:51:48-07:00","master_branch":"master","organization":"diagrams"},"actor_attributes":{"type":"User","name":"Jeffrey Rosenbluth","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/diagrams/diagrams-lib/pull/131#discussion_r7101065"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments/3189474","id":3189474,"body":"Missing spaces around negation","diff_hunk":"@@ -0,0 +1,127 @@\n+<?php\n+/*\n+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS\n+ * \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT\n+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR\n+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT\n+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT\n+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,\n+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY\n+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE\n+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+ *\n+ * This software consists of voluntary contributions made by many individuals\n+ * and is licensed under the MIT license. For more information, see\n+ * <http://www.doctrine-project.org>.\n+ */\n+\n+namespace Doctrine\\ORM\\Event;\n+\n+use Doctrine\\ORM\\EntityManager;\n+use Doctrine\\ORM\\Events;\n+use Doctrine\\ORM\\Query;\n+\n+/**\n+ * Dispatcher for postLoad event on entities used during object hydration.\n+ *\n+ * @author Lukasz Cybula <[email protected]>\n+ * @since 2.4\n+ */\n+class PostLoadEventDispatcher\n+{\n+ /**\n+ * Entity Manager\n+ *\n+ * @var \\Doctrine\\ORM\\EntityManager\n+ */\n+ private $entityManager;\n+\n+ /**\n+ * Metadata Factory\n+ *\n+ * @var \\Doctrine\\ORM\\Mapping\\ClassMetadataFactory\n+ */\n+ private $metadataFactory;\n+\n+ /**\n+ * The query hints\n+ *\n+ * @var array\n+ */\n+ private $hints = array();\n+\n+ /**\n+ * Entities enqueued for postLoad dispatching\n+ *\n+ * @var array\n+ */\n+ private $entities = array();\n+\n+ /**\n+ * Constructs a new dispatcher instance\n+ *\n+ * @param EntityManager $em\n+ */\n+ public function __construct(EntityManager $em)\n+ {\n+ $this->entityManager = $em;\n+ $this->metadataFactory = $em->getMetadataFactory();\n+ }\n+\n+ /**\n+ * Initializes dispatcher for new query\n+ *\n+ * @param array $hints\n+ */\n+ public function init(array $hints = array())\n+ {\n+ $this->invoker = $this->entityManager->getUnitOfWork()->getListenersInvoker();\n+ $this->hints = $hints;\n+ $this->entities = array();\n+ }\n+\n+ /**\n+ * Dispatches postLoad event for specified entity or enqueues it for later dispatching\n+ *\n+ * @param object $entity\n+ */\n+ public function dispatchPostLoad($entity)\n+ {\n+ $className = get_class($entity);\n+ $meta = $this->metadataFactory->getMetadataFor($className);\n+ $invoke = $this->invoker->getSubscribedSystems($meta, Events::postLoad);\n+\n+ if ($invoke === ListenersInvoker::INVOKE_NONE) {\n+ return;\n+ }\n+\n+ if (isset($this->hints[Query::HINT_INTERNAL_ITERATION])) {\n+ $this->invoker->invoke($meta, Events::postLoad, $entity, new LifecycleEventArgs($entity, $this->entityManager), $invoke);\n+ } else {\n+ if (!isset($this->entities[$className])) {","path":"lib/Doctrine/ORM/Event/PostLoadEventDispatcher.php","position":103,"original_position":103,"commit_id":"356dad76a15ac8387d111020f73eec08f37ca064","original_commit_id":"356dad76a15ac8387d111020f73eec08f37ca064","user":{"login":"norzechowicz","id":1921950,"avatar_url":"https://secure.gravatar.com/avatar/36d174c39e952e5327d9bb942985a943?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"36d174c39e952e5327d9bb942985a943","url":"https://api.github.com/users/norzechowicz","html_url":"https://github.com/norzechowicz","followers_url":"https://api.github.com/users/norzechowicz/followers","following_url":"https://api.github.com/users/norzechowicz/following","gists_url":"https://api.github.com/users/norzechowicz/gists{/gist_id}","starred_url":"https://api.github.com/users/norzechowicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/norzechowicz/subscriptions","organizations_url":"https://api.github.com/users/norzechowicz/orgs","repos_url":"https://api.github.com/users/norzechowicz/repos","events_url":"https://api.github.com/users/norzechowicz/events{/privacy}","received_events_url":"https://api.github.com/users/norzechowicz/received_events","type":"User"},"created_at":"2013-02-28T14:51:41Z","updated_at":"2013-02-28T14:51:41Z","_links":{"self":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/comments/3189474"},"html":{"href":"https://github.com/doctrine/doctrine2/pull/470#discussion_r3189474"},"pull_request":{"href":"https://api.github.com/repos/doctrine/doctrine2/pulls/470"}}}}

{"repository":{"description":"Doctrine 2 Object Relational Mapper","homepage":"http://www.doctrine-project.org","watchers":1651,"stargazers":1651,"forks":625,"fork":false,"size":5604,"owner":"doctrine","private":false,"open_issues":29,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"PHP","created_at":"2010-04-06T14:42:59-07:00","pushed_at":"2013-02-27T03:47:08-08:00","integrate_branch":"DDC-597","master_branch":"master","organization":"doctrine"},"actor_attributes":{"type":"User","name":"Norbert Orzechowicz","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/doctrine/doctrine2/pull/470#discussion_r3189474"}

PullRequestReviewCommentEvent

{"comment":{"created_at":"2013-01-13T17:09:19Z","updated_at":"2013-01-13T17:09:19Z","commit_id":"679ecf19f1cfbe43543da2cdb72327198a1b686c","id":2629350,"path":"src/DoctrineModule/Stdlib/Hydrator/Strategy/AbstractCollectionStrategy.php","url":"https://api.github.com/repos/doctrine/DoctrineModule/pulls/comments/2629350","_links":{"pull_request":{"href":"https://api.github.com/repos/doctrine/DoctrineModule/pulls/106"},"self":{"href":"https://api.github.com/repos/doctrine/DoctrineModule/pulls/comments/2629350"},"html":{"href":"https://github.com/doctrine/DoctrineModule/pull/106#discussion_r2629350"}},"original_commit_id":"804ed390af2cdd092077dcea3749e4845c6db190","user":{"gravatar_id":"3cf7a8ab0bccee5b65d39b50a170a555","repos_url":"https://api.github.com/users/Ocramius/repos","avatar_url":"https://secure.gravatar.com/avatar/3cf7a8ab0bccee5b65d39b50a170a555?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","followers_url":"https://api.github.com/users/Ocramius/followers","organizations_url":"https://api.github.com/users/Ocramius/orgs","type":"User","id":154256,"events_url":"https://api.github.com/users/Ocramius/events{/privacy}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","url":"https://api.github.com/users/Ocramius","following_url":"https://api.github.com/users/Ocramius/following","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","received_events_url":"https://api.github.com/users/Ocramius/received_events","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","login":"Ocramius"},"original_position":54,"position":60,"body":"Then avoid using it. A fluid interface is useful when you have to compose complex objects such as the QueryBuilder or an AST for example.\r\nIf you really want to keep it, use `@return self` in the docblock"}}

{"repository":{"watchers":155,"owner":"doctrine","pushed_at":"2012-12-20T13:44:24-08:00","description":"Zend Framework 2 Module for Doctrine","stargazers":155,"forks":75,"organization":"doctrine","language":"PHP","has_issues":true,"has_downloads":true,"fork":false,"size":736,"created_at":"2011-12-29T17:44:19-08:00","open_issues":11,"has_wiki":true,"private":false,"homepage":"http://www.doctrine-project.org/jira"},"actor_attributes":{"type":"User","company":"Com2-Gmbh","location":"Frankfurt, Germany","name":"Marco Pivetta","blog":"http://ocramius.github.com/","email":"[email protected]"},"url":"https://github.com/doctrine/DoctrineModule/pull/106#discussion_r2629350"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/emediate/wtforms_web2py/pulls/comments/3851624","id":3851624,"body":"\"So here we are trying...\"","diff_hunk":"@@ -1,10 +1,15 @@\n+# web2py works internally with bytestring, and WTForms uses unicode.\n+# So there we trying to monkeypatch WTForms to convert to/from unicode.","path":"wtforms_web2py/__init__.py","position":2,"original_position":2,"commit_id":"e1deced845036c8b21e8873f914943ce85b46aa1","original_commit_id":"e1deced845036c8b21e8873f914943ce85b46aa1","user":{"login":"z4y4ts","id":453047,"avatar_url":"https://secure.gravatar.com/avatar/115e0f0e4b15ef18e409c995ef102cb2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"115e0f0e4b15ef18e409c995ef102cb2","url":"https://api.github.com/users/z4y4ts","html_url":"https://github.com/z4y4ts","followers_url":"https://api.github.com/users/z4y4ts/followers","following_url":"https://api.github.com/users/z4y4ts/following","gists_url":"https://api.github.com/users/z4y4ts/gists{/gist_id}","starred_url":"https://api.github.com/users/z4y4ts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/z4y4ts/subscriptions","organizations_url":"https://api.github.com/users/z4y4ts/orgs","repos_url":"https://api.github.com/users/z4y4ts/repos","events_url":"https://api.github.com/users/z4y4ts/events{/privacy}","received_events_url":"https://api.github.com/users/z4y4ts/received_events","type":"User"},"created_at":"2013-04-18T11:43:30Z","updated_at":"2013-04-18T11:43:30Z","html_url":"https://github.com/emediate/wtforms_web2py/pull/1#discussion_r3851624","pull_request_url":"https://api.github.com/repos/emediate/wtforms_web2py/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/emediate/wtforms_web2py/pulls/comments/3851624"},"html":{"href":"https://github.com/emediate/wtforms_web2py/pull/1#discussion_r3851624"},"pull_request":{"href":"https://api.github.com/repos/emediate/wtforms_web2py/pulls/1"}}}}

{"repository":{"description":"Extension for WTForms form processing library for integration with web2py framework.","watchers":0,"stargazers":0,"forks":1,"fork":false,"size":192,"owner":"emediate","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-04-17T05:50:49-07:00","pushed_at":"2013-04-17T07:20:23-07:00","master_branch":"master","organization":"emediate"},"actor_attributes":{"type":"User","name":"Alexander Zayats","blog":"blog.zayats.org.ua","location":"Kiev, Ukraine","email":"[email protected]"},"url":"https://github.com/emediate/wtforms_web2py/pull/1#discussion_r3851624"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/8188057","id":8188057,"diff_hunk":"@@ -220,108 +222,85 @@ var ReactEventEmitter = merge(ReactEventEmitterMixin, {\n * Also, `keyup`/`keypress`/`keydown` do not bubble to the window on IE, but\n * they bubble to document.\n *\n- * @param {boolean} touchNotMouse Listen to touch events instead of mouse.\n+ * @param {string} event\n * @param {DOMDocument} contentDocument Document which owns the container\n- * @private\n- * @see http://www.quirksmode.org/dom/events/keys.html.\n */\n- listenAtTopLevel: function(touchNotMouse, contentDocument) {\n- invariant(\n- !contentDocument._isListening,\n- 'listenAtTopLevel(...): Cannot setup top-level listener more than once.'\n- );\n- var topLevelTypes = EventConstants.topLevelTypes;\n+ listenTo: function(event, contentDocument) {\n var mountAt = contentDocument;\n-\n- registerScrollValueMonitoring();\n- trapBubbledEvent(topLevelTypes.topMouseOver, 'mouseover', mountAt);\n- trapBubbledEvent(topLevelTypes.topMouseDown, 'mousedown', mountAt);\n- trapBubbledEvent(topLevelTypes.topMouseUp, 'mouseup', mountAt);\n- trapBubbledEvent(topLevelTypes.topMouseMove, 'mousemove', mountAt);\n- trapBubbledEvent(topLevelTypes.topMouseOut, 'mouseout', mountAt);\n- trapBubbledEvent(topLevelTypes.topClick, 'click', mountAt);\n- trapBubbledEvent(topLevelTypes.topDoubleClick, 'dblclick', mountAt);\n- trapBubbledEvent(topLevelTypes.topContextMenu, 'contextmenu', mountAt);\n- if (touchNotMouse) {\n- trapBubbledEvent(topLevelTypes.topTouchStart, 'touchstart', mountAt);\n- trapBubbledEvent(topLevelTypes.topTouchEnd, 'touchend', mountAt);\n- trapBubbledEvent(topLevelTypes.topTouchMove, 'touchmove', mountAt);\n- trapBubbledEvent(topLevelTypes.topTouchCancel, 'touchcancel', mountAt);\n+ if (mountAt[topListenersIDKey] == null) {\n+ mountAt[topListenersIDKey] = reactTopListenersCounter++;\n+ alreadyListeningTo[mountAt[topListenersIDKey]] = {};\n }\n- trapBubbledEvent(topLevelTypes.topKeyUp, 'keyup', mountAt);\n- trapBubbledEvent(topLevelTypes.topKeyPress, 'keypress', mountAt);\n- trapBubbledEvent(topLevelTypes.topKeyDown, 'keydown', mountAt);\n- trapBubbledEvent(topLevelTypes.topInput, 'input', mountAt);\n- trapBubbledEvent(topLevelTypes.topChange, 'change', mountAt);\n- trapBubbledEvent(\n- topLevelTypes.topSelectionChange,\n- 'selectionchange',\n- mountAt\n- );\n+ var topListenersID = mountAt[topListenersIDKey];\n+ var registrationName = ReactEventEmitter.registrationNameModules[event];\n+ var dependencies = registrationName.eventTypes[EventPluginRegistry.registrationNameEventNameMapping[event]].dependencies;","path":"src/core/ReactEventEmitter.js","position":181,"original_position":181,"commit_id":"8f294c807cecc7641005dd184c91d4a83d2c44b5","original_commit_id":"8f294c807cecc7641005dd184c91d4a83d2c44b5","user":{"login":"SanderSpies","id":1114117,"avatar_url":"https://1.gravatar.com/avatar/e1732fb312c5f04a7b829ea0992e2be3?d=https%3A%2F%2Fidenticons.github.com%2F77bd89433c5cddd3e477b35321cb5bd3.png&r=x","gravatar_id":"e1732fb312c5f04a7b829ea0992e2be3","url":"https://api.github.com/users/SanderSpies","html_url":"https://github.com/SanderSpies","followers_url":"https://api.github.com/users/SanderSpies/followers","following_url":"https://api.github.com/users/SanderSpies/following{/other_user}","gists_url":"https://api.github.com/users/SanderSpies/gists{/gist_id}","starred_url":"https://api.github.com/users/SanderSpies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SanderSpies/subscriptions","organizations_url":"https://api.github.com/users/SanderSpies/orgs","repos_url":"https://api.github.com/users/SanderSpies/repos","events_url":"https://api.github.com/users/SanderSpies/events{/privacy}","received_events_url":"https://api.github.com/users/SanderSpies/received_events","type":"User","site_admin":false},"body":"Line probably too long.","created_at":"2013-12-09T02:40:53Z","updated_at":"2013-12-09T02:40:53Z","html_url":"https://github.com/facebook/react/pull/462#discussion_r8188057","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/462","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/8188057"},"html":{"href":"https://github.com/facebook/react/pull/462#discussion_r8188057"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/462"}}}}

{"repository":{"description":"React is a JavaScript library for building user interfaces. It's declarative, efficient, and extremely flexible. What's more, it works with the libraries and frameworks that you already know.","homepage":"http://facebook.github.io/react/","watchers":2743,"stargazers":2743,"forks":330,"fork":false,"size":21606,"owner":"facebook","private":false,"open_issues":140,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-05-24T09:15:54-07:00","pushed_at":"2013-12-06T15:34:21-08:00","master_branch":"master","organization":"facebook"},"actor_attributes":{"type":"User","name":"Sander Spies","blog":"https://plus.google.com/107788656628562624395/posts","location":"Almere, Netherlands","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/facebook/react/pull/462#discussion_r8188057"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/7965019","id":7965019,"diff_hunk":"@@ -0,0 +1,11 @@\n+module.exports.generic = {\n+ src: ['./build/modules/**/*.js'],\n+ options: {\n+ jsLintXML: 'complexity-report.xml', // create XML JSLint-like report\n+ checkstyleXML: 'complexity-checkstyle.xml', // create checkstyle report","path":"grunt/config/complexity.js","position":5,"original_position":5,"commit_id":"cf435b670890d2271f8e2a837fb7e5f2011ad4b0","original_commit_id":"cf435b670890d2271f8e2a837fb7e5f2011ad4b0","user":{"login":"zpao","id":8445,"avatar_url":"https://2.gravatar.com/avatar/10e6f9e15d7148c230fce273ee1865ee?d=https%3A%2F%2Fidenticons.github.com%2Fe3d11d85deaf57a720d252cd069bcd37.png&r=x","gravatar_id":"10e6f9e15d7148c230fce273ee1865ee","url":"https://api.github.com/users/zpao","html_url":"https://github.com/zpao","followers_url":"https://api.github.com/users/zpao/followers","following_url":"https://api.github.com/users/zpao/following{/other_user}","gists_url":"https://api.github.com/users/zpao/gists{/gist_id}","starred_url":"https://api.github.com/users/zpao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zpao/subscriptions","organizations_url":"https://api.github.com/users/zpao/orgs","repos_url":"https://api.github.com/users/zpao/repos","events_url":"https://api.github.com/users/zpao/events{/privacy}","received_events_url":"https://api.github.com/users/zpao/received_events","type":"User","site_admin":false},"body":"What are these files for? Do we need them to exist in the root? Maybe we could put them into `.grunt` and keep the root a bit cleaner.","created_at":"2013-11-27T18:07:09Z","updated_at":"2013-11-27T18:07:09Z","html_url":"https://github.com/facebook/react/pull/617#discussion_r7965019","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/617","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/7965019"},"html":{"href":"https://github.com/facebook/react/pull/617#discussion_r7965019"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/617"}}}}

{"repository":{"description":"React is a JavaScript library for building user interfaces. It's declarative, efficient, and extremely flexible. What's more, it works with the libraries and frameworks that you already know.","homepage":"http://facebook.github.io/react/","watchers":2654,"stargazers":2654,"forks":319,"fork":false,"size":21050,"owner":"facebook","private":false,"open_issues":166,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-05-24T09:15:54-07:00","pushed_at":"2013-11-25T09:29:53-08:00","master_branch":"master","organization":"facebook"},"actor_attributes":{"type":"User","name":"Paul O’Shannessy","company":"Facebook","blog":"http://zpao.com","location":"San Francisco, CA","email":"[email protected]"},"url":"https://github.com/facebook/react/pull/617#discussion_r7965019"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/pulls/comments/5497723","id":5497723,"body":"Totally agree. It's like all Utils functions we need, like isValidUrl or OpenLayers pure functions (addLayer, removeLayer, getScale) and others. We should decide where to put it now before duplicate code between CatalogTree, Search and the ImportXXX components)","diff_hunk":"@@ -0,0 +1,316 @@\n+(function() {\n+ goog.provide('ga_importwms_directive');\n+\n+ var module = angular.module('ga_importwms_directive', [\n+ 'pascalprecht.translate'\n+ ]);\n+\n+ module.controller('GaImportWmsDirectiveController',\n+ ['$scope', '$http', '$q', '$log', '$translate',\n+ function($scope, $http, $q, $log, $translate) {\n+\n+ $scope.layers = [];\n+\n+ // from Angular\n+ // https://github.com/angular/angular.js/blob/master/src/ng/directive/input.js#L3\n+ var URL_REGEXP =\n+ /^(ftp|http|https):\\/\\/(\\w+:{0,1}\\w*@)?(\\S+)(:[0-9]+)?(\\/|\\/([\\w#!:.?+=&%@!\\-\\/]))?$/;\n+\n+\n+ // copy from ImportKml","path":"src/components/importwms/ImportWmsDirective.js","position":20,"original_position":20,"commit_id":"61170dbde34860007bf635fd34656087b75acb3c","original_commit_id":"61170dbde34860007bf635fd34656087b75acb3c","user":{"login":"oterral","id":621420,"avatar_url":"https://secure.gravatar.com/avatar/f42230151d95e440df21166893d44aaa?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"f42230151d95e440df21166893d44aaa","url":"https://api.github.com/users/oterral","html_url":"https://github.com/oterral","followers_url":"https://api.github.com/users/oterral/followers","following_url":"https://api.github.com/users/oterral/following{/other_user}","gists_url":"https://api.github.com/users/oterral/gists{/gist_id}","starred_url":"https://api.github.com/users/oterral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oterral/subscriptions","organizations_url":"https://api.github.com/users/oterral/orgs","repos_url":"https://api.github.com/users/oterral/repos","events_url":"https://api.github.com/users/oterral/events{/privacy}","received_events_url":"https://api.github.com/users/oterral/received_events","type":"User"},"created_at":"2013-07-31T08:00:23Z","updated_at":"2013-07-31T08:00:23Z","html_url":"https://github.com/geoadmin/mf-geoadmin3/pull/191#discussion_r5497723","pull_request_url":"https://api.github.com/repos/geoadmin/mf-geoadmin3/pulls/191","_links":{"self":{"href":"https://api.github.com/repos/geoadmin/mf-geoadmin3/pulls/comments/5497723"},"html":{"href":"https://github.com/geoadmin/mf-geoadmin3/pull/191#discussion_r5497723"},"pull_request":{"href":"https://api.github.com/repos/geoadmin/mf-geoadmin3/pulls/191"}}}}

{"repository":{"description":"next generation map.geo.admin.ch","watchers":4,"stargazers":4,"forks":0,"fork":false,"size":3156,"owner":"geoadmin","private":false,"open_issues":17,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-05-30T23:37:20-07:00","pushed_at":"2013-07-30T23:44:43-07:00","master_branch":"master","organization":"geoadmin"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/geoadmin/mf-geoadmin3/pull/191#discussion_r5497723"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/comments/7030949","id":7030949,"diff_hunk":"@@ -11,13 +11,13 @@\n fullName = pageargs.get('fullName')\n %>\n \n-<div class=\"htmlpopup-content\">\n- <span style=\"font-weight:bold;\">${fullName}</span> (${attribution})\n+<div class=\"htmlpopup-header\">\n+ <span>${fullName}</span> (${attribution})\n </div>\n <div class=\"htmlpopup-content\">\n- <span style=\"font-weight:bold;\">${_('Information')}</span>\n+ <span>${_('Information')}</span>\n <br>\n- <table border=\"0\" cellspacing=\"0\" cellpadding=\"1\" width=\"400px\" style=\"font-size: 100%;\" padding=\"1 1 1 1\">\n+ <table>\n ${self.table_body(c, lang)}\n % if c['stable_id'] is True:\n <tr><td width=\"150\"></td><td><a href=\"${baseUrl}?${c['layerBodId']}=${c['id']}&lang=${lang}\" target=\"new\">${_('Link to object')}</a></td></tr>","path":"chsdi/templates/htmlpopup/base.mako","position":17,"original_position":17,"commit_id":"d955bc6ac0c2f9104919fed2120e6d3ef3c64ee3","original_commit_id":"d955bc6ac0c2f9104919fed2120e6d3ef3c64ee3","user":{"login":"oterral","id":621420,"avatar_url":"https://1.gravatar.com/avatar/f42230151d95e440df21166893d44aaa?d=https%3A%2F%2Fidenticons.github.com%2F34b50854d28e4c5213dea00936fd15a9.png","gravatar_id":"f42230151d95e440df21166893d44aaa","url":"https://api.github.com/users/oterral","html_url":"https://github.com/oterral","followers_url":"https://api.github.com/users/oterral/followers","following_url":"https://api.github.com/users/oterral/following{/other_user}","gists_url":"https://api.github.com/users/oterral/gists{/gist_id}","starred_url":"https://api.github.com/users/oterral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oterral/subscriptions","organizations_url":"https://api.github.com/users/oterral/orgs","repos_url":"https://api.github.com/users/oterral/repos","events_url":"https://api.github.com/users/oterral/events{/privacy}","received_events_url":"https://api.github.com/users/oterral/received_events","type":"User","site_admin":false},"body":"I suppose the width=\"150\" can be done with css","created_at":"2013-10-17T12:42:20Z","updated_at":"2013-10-17T12:42:20Z","html_url":"https://github.com/geoadmin/mf-chsdi3/pull/174#discussion_r7030949","pull_request_url":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/174","_links":{"self":{"href":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/comments/7030949"},"html":{"href":"https://github.com/geoadmin/mf-chsdi3/pull/174#discussion_r7030949"},"pull_request":{"href":"https://api.github.com/repos/geoadmin/mf-chsdi3/pulls/174"}}}}

{"repository":{"description":"next generation of api.geo.admin.ch","watchers":1,"stargazers":1,"forks":1,"fork":false,"size":19129,"owner":"geoadmin","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-05-30T23:59:44-07:00","pushed_at":"2013-10-17T05:40:43-07:00","master_branch":"master","organization":"geoadmin"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/geoadmin/mf-chsdi3/pull/174#discussion_r7030949"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/gitlabhq/gitlab-shell/pulls/comments/7798256","id":7798256,"diff_hunk":"@@ -12,20 +12,36 @@ resp = GitlabNet.new.check\n if resp.code == \"200\"\n print 'OK'\n else\n- puts \"FAILED. code: #{resp.code}\"\n+ abort \"FAILED. code: #{resp.code}\"\n end\n \n puts \"\\nCheck directories and files: \"\n \n config = GitlabConfig.new\n-dirs = [config.repos_path, config.auth_file, config.redis['bin']]\n+dirs = [config.repos_path, config.auth_file]\n \n dirs.each do |dir|\n print \"\\t#{dir}: \"\n if File.exists?(dir)\n print 'OK'\n else\n- puts \"FAILED\"\n+ abort \"FAILED\"\n end\n puts \"\\n\"\n end\n+\n+# Do not need to check for redis executable if no \"redis\" section\n+unless config.redis.empty?\n+ print \"Check for redis-cli binary: \"\n+ if config.redis['bin'] && File.exists?(config.redis['bin'])","path":"bin/check","position":28,"original_position":28,"commit_id":"63d5a9f177222aabbacc1af34186b76ee054e050","original_commit_id":"63d5a9f177222aabbacc1af34186b76ee054e050","user":{"login":"jacobvosmaer","id":1336311,"avatar_url":"https://2.gravatar.com/avatar/e66d11c0eedf8c07b3b18fca46599807?d=https%3A%2F%2Fidenticons.github.com%2F5a08aa73fc6d6918ad8661f2627c726d.png&r=x","gravatar_id":"e66d11c0eedf8c07b3b18fca46599807","url":"https://api.github.com/users/jacobvosmaer","html_url":"https://github.com/jacobvosmaer","followers_url":"https://api.github.com/users/jacobvosmaer/followers","following_url":"https://api.github.com/users/jacobvosmaer/following{/other_user}","gists_url":"https://api.github.com/users/jacobvosmaer/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobvosmaer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobvosmaer/subscriptions","organizations_url":"https://api.github.com/users/jacobvosmaer/orgs","repos_url":"https://api.github.com/users/jacobvosmaer/repos","events_url":"https://api.github.com/users/jacobvosmaer/events{/privacy}","received_events_url":"https://api.github.com/users/jacobvosmaer/received_events","type":"User","site_admin":false},"body":"Ah, I missed your commit message.\r\n\r\nI tried it out independently in IRB and I also noticed the `nil` returned by `system` when the command is not found. I propose to address this by adding a message to the `abort` (see my comment above). I appreciate that the current solution gives more detailed information, but I am not sure if the added detail is worth the extra code and tying this script more tightly to `lib/gitlab_config.rb`.","created_at":"2013-11-20T17:19:03Z","updated_at":"2013-11-20T17:19:03Z","html_url":"https://github.com/gitlabhq/gitlab-shell/pull/109#discussion_r7798256","pull_request_url":"https://api.github.com/repos/gitlabhq/gitlab-shell/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/gitlabhq/gitlab-shell/pulls/comments/7798256"},"html":{"href":"https://github.com/gitlabhq/gitlab-shell/pull/109#discussion_r7798256"},"pull_request":{"href":"https://api.github.com/repos/gitlabhq/gitlab-shell/pulls/109"}}}}

{"repository":{"description":"Replacement for gitolite","watchers":181,"stargazers":181,"forks":112,"fork":false,"size":769,"owner":"gitlabhq","private":false,"open_issues":33,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-02-04T00:11:01-08:00","pushed_at":"2013-11-20T06:44:20-08:00","master_branch":"master","organization":"gitlabhq"},"actor_attributes":{"type":"User","name":"Jacob Vosmaer","company":"GitLab.com","blog":"www.jacobvosmaer.nl","email":"[email protected]"},"url":"https://github.com/gitlabhq/gitlab-shell/pull/109#discussion_r7798256"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/4071835","id":4071835,"body":"I just mean, when switches fail they revert to this default. 404 or 500 is a bad default if the edition is live.","diff_hunk":"@@ -90,6 +90,10 @@ object CommonSwitches {\n \"If this switch is on related content AB test will be enabled.\",\n initiallyOn = false)\n \n+ val AustraliaFrontSwitch = DefaultSwitch(\"australia-front\",\n+ \"If this switch is on the australia front will be available\",\n+ initiallyOn = false)","path":"common/app/conf/switches.scala","position":6,"original_position":6,"commit_id":"65b8b18232f4d6bd2576db20d507a625df24939b","original_commit_id":"65b8b18232f4d6bd2576db20d507a625df24939b","user":{"login":"commuterjoy","id":84996,"avatar_url":"https://secure.gravatar.com/avatar/3e3718a0195b07de4701e993d9d949a5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"3e3718a0195b07de4701e993d9d949a5","url":"https://api.github.com/users/commuterjoy","html_url":"https://github.com/commuterjoy","followers_url":"https://api.github.com/users/commuterjoy/followers","following_url":"https://api.github.com/users/commuterjoy/following","gists_url":"https://api.github.com/users/commuterjoy/gists{/gist_id}","starred_url":"https://api.github.com/users/commuterjoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commuterjoy/subscriptions","organizations_url":"https://api.github.com/users/commuterjoy/orgs","repos_url":"https://api.github.com/users/commuterjoy/repos","events_url":"https://api.github.com/users/commuterjoy/events{/privacy}","received_events_url":"https://api.github.com/users/commuterjoy/received_events","type":"User"},"created_at":"2013-05-03T10:52:45Z","updated_at":"2013-05-03T10:52:45Z","html_url":"https://github.com/guardian/frontend/pull/760#discussion_r4071835","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/760","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/4071835"},"html":{"href":"https://github.com/guardian/frontend/pull/760#discussion_r4071835"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/760"}}}}

{"repository":{"description":"Source for the Guardian's responsive mobile site, coming soon to a desktop near you...","homepage":"http://m.guardian.co.uk","watchers":248,"stargazers":248,"forks":21,"fork":false,"size":5616,"owner":"guardian","private":false,"open_issues":33,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-05-18T08:39:15-07:00","pushed_at":"2013-05-03T03:21:55-07:00","master_branch":"master","organization":"guardian"},"actor_attributes":{"type":"User","name":"Matt Chadburn","company":"Guardian","blog":"http://matt.chadburn.co.uk/","location":"London","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/guardian/frontend/pull/760#discussion_r4071835"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/8567283","id":8567283,"diff_hunk":"@@ -17,10 +17,25 @@\n \n .commercial__title {\n color: $c-brandBlue;\n+ text-transform: lowercase;\n+ word-spacing: -0.25em;\n @include fs-headline(2);\n margin: 0;\n padding: $baseline*2 $baseline;\n float: left;\n+ .em {\n+ font-style: italic;\n+ }\n+}\n+\n+.commercial__subtitle {\n+\tcolor: #fff;\n+ @include f-headline;\n+ @include font-size(12,12);\n+\tmargin: 0;\n+ position: absolute;\n+\tbottom: $baseline;\n+\tpadding: $baseline;","path":"common/app/assets/stylesheets/module/commercial/_commercial-component.scss","position":22,"original_position":22,"commit_id":"fb72ded975c99eda0132fb9338c617f22909107a","original_commit_id":"fb72ded975c99eda0132fb9338c617f22909107a","user":{"login":"kaelig","id":85783,"avatar_url":"https://gravatar.com/avatar/f7e7b837bd06d6193f4ac70f17e6f44b?d=https%3A%2F%2Fidenticons.github.com%2Fa8ce4ba49cb1f14b8cb0ad8679d52f75.png&r=x","gravatar_id":"f7e7b837bd06d6193f4ac70f17e6f44b","url":"https://api.github.com/users/kaelig","html_url":"https://github.com/kaelig","followers_url":"https://api.github.com/users/kaelig/followers","following_url":"https://api.github.com/users/kaelig/following{/other_user}","gists_url":"https://api.github.com/users/kaelig/gists{/gist_id}","starred_url":"https://api.github.com/users/kaelig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaelig/subscriptions","organizations_url":"https://api.github.com/users/kaelig/orgs","repos_url":"https://api.github.com/users/kaelig/repos","events_url":"https://api.github.com/users/kaelig/events{/privacy}","received_events_url":"https://api.github.com/users/kaelig/received_events","type":"User","site_admin":false},"body":"Indentation","created_at":"2013-12-27T13:32:23Z","updated_at":"2013-12-27T13:32:23Z","html_url":"https://github.com/guardian/frontend/pull/2625#discussion_r8567283","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/2625","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/8567283"},"html":{"href":"https://github.com/guardian/frontend/pull/2625#discussion_r8567283"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/2625"}}}}

{"repository":{"description":"Source for the Guardian's responsive site, coming soon to a desktop near you...","homepage":"http://www.theguardian.com/uk?view=mobile","watchers":1600,"stargazers":1600,"forks":137,"fork":false,"size":258737,"owner":"guardian","private":false,"open_issues":136,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-05-18T08:39:15-07:00","pushed_at":"2013-12-27T03:47:57-08:00","master_branch":"master","organization":"guardian"},"actor_attributes":{"type":"User","name":"Kaelig","company":"The Guardian","blog":"http://blog.kaelig.fr","location":"London, UK","email":"[email protected]"},"url":"https://github.com/guardian/frontend/pull/2625#discussion_r8567283"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/guardian/frontend/pulls/comments/4585250","id":4585250,"body":"I did this for prototyping only. IMHO rems (+px fallback) are more efficient and maintainable. Let's have a talk about it soon.","diff_hunk":"@@ -0,0 +1,316 @@\n+/* ==========================================================================\n+ Discussion\n+ ========================================================================== */\n+.d-discussion {\n+ font-size: 14px;\n+ font-size: 1.4rem;\n+ max-width: 600px; // Cap the number of words per line for readability\n+}\n+\n+\n+/* Tabs\n+ ========================================================================== */\n+.d-tabs {\n+ margin: 20px 0 $baseline*3 0;\n+}\n+.d-tabs__container {\n+ display: table;\n+ background-color: $darkMushroom;\n+ width: 100%;\n+}\n+.d-tabs__byline,\n+.d-tabs__commentcount {\n+ @include box-sizing(border-box);\n+ border-top: 2px solid $darkMushroom;\n+ border-bottom: 2px solid $darkMushroom;\n+ display: table-cell;\n+ cursor: pointer;\n+}\n+.d-tabs__byline {\n+ @extend %type-7;\n+ vertical-align: top;\n+ padding: 4px $gutter;\n+\n+ a {\n+ pointer-events: none;\n+ color: #666666;\n+ }\n+\n+ &.d-tabs--active a {\n+ pointer-events: auto;\n+ color: $linkBlue;\n+ }\n+}\n+.d-tabs__commentcount {\n+ padding: 12px 16px 16px 16px;\n+ width: 60px;\n+ text-align: center;\n+}\n+.d-tabs--active {\n+ border-bottom: 0;\n+ background-color: #fff;\n+}\n+\n+.d-thread {\n+ list-style: none;\n+ margin-left: 0;\n+ margin-bottom: 1em;\n+}\n+.d-thread .d-thread {\n+ padding-left: 24px; /* aligns with top level comment's body */\n+ border-left: 12px solid $darkMushroom;\n+\n+ @media (min-width: 768px) {\n+ padding-left: 40px;\n+ border-left-width: 20px;\n+ }\n+}\n+.d-comment {\n+ color: #333;\n+ font-family: sans-serif;\n+}\n+.d-thread .d-thread .d-comment,\n+.d-comment + .d-comment {\n+ border-top: 1px solid #EDEDE7;\n+}\n+.d-comment--blocked > .d-comment__inner {\n+ opacity: .5;\n+}\n+.d-comment__inner {\n+ padding-top: 12px;\n+ position: relative;\n+}\n+.d-comment:target > .d-comment__inner {\n+ background: rgba(149, 177, 202, .3);\n+ padding-left: 4px;\n+ padding-right: 4px;\n+ margin-left: -4px;\n+ margin-right: -4px;\n+}\n+\n+.d-comment__pick {\n+ position: absolute;\n+ top: 8px;\n+ right: 0;\n+}\n+\n+.d-comment__header {\n+ margin-top: -2px;\n+}\n+.d-comment__avatar-wrapper {\n+ display: block;\n+}\n+.d-comment__avatar {\n+ padding-top: 2px; /* align avatar with body text */\n+}\n+\n+.d-comment__meta {\n+ line-height: 1.3;\n+ word-break: break-all;\n+ word-break: break-word;\n+ word-wrap: break-word;\n+}\n+.d-comment__author {\n+ font-family: $serif;\n+}\n+\n+@media (min-width: 768px) {\n+ .d-comment__avatar {\n+ width: 60px;\n+ height: 60px;\n+ }\n+ .d-comment__author {\n+ font-size: 1.28571428571em;\n+ }\n+ .d-comment__author + .d-badge {\n+ top: -.15em;\n+ }\n+}\n+\n+.d-meta-separator {\n+ color: #aaa;\n+ font-size: .85714285714em;","path":"common/app/assets/stylesheets/module/_discussion.scss","position":132,"original_position":132,"commit_id":"6ff3585c88fee52fe448ae842d3d85303092f6b2","original_commit_id":"5fa808d2e9f4537469397f9fc5e4f8045ec79add","user":{"login":"kaelig","id":85783,"avatar_url":"https://secure.gravatar.com/avatar/f7e7b837bd06d6193f4ac70f17e6f44b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"f7e7b837bd06d6193f4ac70f17e6f44b","url":"https://api.github.com/users/kaelig","html_url":"https://github.com/kaelig","followers_url":"https://api.github.com/users/kaelig/followers","following_url":"https://api.github.com/users/kaelig/following{/other_user}","gists_url":"https://api.github.com/users/kaelig/gists{/gist_id}","starred_url":"https://api.github.com/users/kaelig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaelig/subscriptions","organizations_url":"https://api.github.com/users/kaelig/orgs","repos_url":"https://api.github.com/users/kaelig/repos","events_url":"https://api.github.com/users/kaelig/events{/privacy}","received_events_url":"https://api.github.com/users/kaelig/received_events","type":"User"},"created_at":"2013-06-07T09:15:01Z","updated_at":"2013-06-07T09:15:01Z","html_url":"https://github.com/guardian/frontend/pull/974#discussion_r4585250","pull_request_url":"https://api.github.com/repos/guardian/frontend/pulls/974","_links":{"self":{"href":"https://api.github.com/repos/guardian/frontend/pulls/comments/4585250"},"html":{"href":"https://github.com/guardian/frontend/pull/974#discussion_r4585250"},"pull_request":{"href":"https://api.github.com/repos/guardian/frontend/pulls/974"}}}}

{"repository":{"description":"Source for the Guardian's responsive mobile site, coming soon to a desktop near you...","homepage":"http://m.guardian.co.uk","watchers":285,"stargazers":285,"forks":21,"fork":false,"size":13540,"owner":"guardian","private":false,"open_issues":47,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-05-18T08:39:15-07:00","pushed_at":"2013-06-07T02:14:58-07:00","master_branch":"master","organization":"guardian"},"actor_attributes":{"type":"User","name":"Kaelig","company":"The Guardian","blog":"http://blog.kaelig.fr","location":"London, UK","email":"[email protected]"},"url":"https://github.com/guardian/frontend/pull/974#discussion_r4585250"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/hpcugent/easybuild-easyconfigs/pulls/comments/3046294","id":3046294,"body":"If it is possible to avoid hardwiring the license server in the easyconfig, \r\nI think that would be optimal (eg. how it's doable with the intel compiler),\r\nso that we can share the very exact easyconfig file across most/all easybuild users.\r\nIt is also a matter of orthogonality: we expect easyconfigs to be open, we'd rather \r\navoid seeing keys in there (if we can do an import, that could also be a solution)","path":"easybuild/easyconfigs/m/MATLAB/MATLAB-2012b.eb","position":13,"original_position":13,"commit_id":"73c7df339237a5e13789fb9bacafa9dea2a87d83","original_commit_id":"73c7df339237a5e13789fb9bacafa9dea2a87d83","user":{"login":"fgeorgatos","id":1531968,"avatar_url":"https://secure.gravatar.com/avatar/bb589825ef114ee063cbcd84601499bc?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"bb589825ef114ee063cbcd84601499bc","url":"https://api.github.com/users/fgeorgatos","html_url":"https://github.com/fgeorgatos","followers_url":"https://api.github.com/users/fgeorgatos/followers","following_url":"https://api.github.com/users/fgeorgatos/following","gists_url":"https://api.github.com/users/fgeorgatos/gists{/gist_id}","starred_url":"https://api.github.com/users/fgeorgatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgeorgatos/subscriptions","organizations_url":"https://api.github.com/users/fgeorgatos/orgs","repos_url":"https://api.github.com/users/fgeorgatos/repos","events_url":"https://api.github.com/users/fgeorgatos/events{/privacy}","received_events_url":"https://api.github.com/users/fgeorgatos/received_events","type":"User"},"created_at":"2013-02-18T10:46:42Z","updated_at":"2013-02-18T10:46:42Z","_links":{"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyconfigs/pulls/comments/3046294"},"html":{"href":"https://github.com/hpcugent/easybuild-easyconfigs/pull/107#discussion_r3046294"},"pull_request":{"href":"https://api.github.com/repos/hpcugent/easybuild-easyconfigs/pulls/107"}}}}

{"repository":{"description":"A collection of easyconfig files that describe which software to build using which build options with EasyBuild.","homepage":"http://hpcugent.github.com/easybuild/","watchers":1,"stargazers":1,"forks":11,"fork":false,"size":816,"owner":"hpcugent","private":false,"open_issues":28,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-10-15T07:32:53-07:00","pushed_at":"2013-02-01T00:10:34-08:00","master_branch":"master","organization":"hpcugent"},"actor_attributes":{"name":"Fotis Georgatos","blog":"http://cern.ch/fotis","type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/hpcugent/easybuild-easyconfigs/pull/107#discussion_r3046294"}

PullRequestReviewCommentEvent

{"comment":{"user":{"gravatar_id":"93efe8c67147791f743923763ff6197d","followers_url":"https://api.github.com/users/boegel/followers","url":"https://api.github.com/users/boegel","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","received_events_url":"https://api.github.com/users/boegel/received_events","following_url":"https://api.github.com/users/boegel/following","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","type":"User","events_url":"https://api.github.com/users/boegel/events{/privacy}","avatar_url":"https://secure.gravatar.com/avatar/93efe8c67147791f743923763ff6197d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","id":620876,"login":"boegel","repos_url":"https://api.github.com/users/boegel/repos"},"url":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/2924729","path":"easybuild/tools/module_generator.py","body":"@fgeorgatos: Sorry about the confusion, @itkovian is right, one author per line is better, and epydoc handles it correctly.","original_position":17,"commit_id":"1bfdf26d3ceaaf88ae272d67e8d3488dffe03715","original_commit_id":"1bfdf26d3ceaaf88ae272d67e8d3488dffe03715","_links":{"pull_request":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/458"},"html":{"href":"https://github.com/hpcugent/easybuild-framework/pull/458#discussion_r2924729"},"self":{"href":"https://api.github.com/repos/hpcugent/easybuild-framework/pulls/comments/2924729"}},"created_at":"2013-02-07T11:11:47Z","id":2924729,"position":17,"updated_at":"2013-02-07T11:11:47Z"}}

{"repository":{"description":"EasyBuild is a software installation framework in Python that allows you to install software in a structured and robust way. ","watchers":17,"open_issues":113,"has_issues":true,"owner":"hpcugent","language":"Python","stargazers":17,"pushed_at":"2013-02-04T08:07:56-08:00","master_branch":"master","forks":8,"has_downloads":true,"fork":false,"size":592,"homepage":"http://hpcugent.github.com/easybuild/","private":false,"created_at":"2012-03-08T09:07:43-08:00","has_wiki":false,"organization":"hpcugent"},"actor_attributes":{"name":"Kenneth Hoste","location":"Belgium","email":"[email protected]","type":"User","blog":"http://boegel.kejo.be"},"url":"https://github.com/hpcugent/easybuild-framework/pull/458#discussion_r2924729"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/inspircd/inspircd/pulls/comments/3378207","id":3378207,"body":"`if (!extban && ...)`","diff_hunk":"@@ -81,7 +77,17 @@ class CommandTban : public Command\n \t\tstd::vector<std::string> setban;\n \t\tsetban.push_back(parameters[0]);\n \t\tsetban.push_back(\"+b\");\n-\t\tsetban.push_back(parameters[2]);\n+\t\t//\tIf it's not a valid ban, and not an extban, try to convert it to a nickban\n+\t\tif (parameters[2].find(':') == std::string::npos && !ServerInstance->IsValidMask(parameters[2]))","path":"src/modules/m_timedbans.cpp","position":21,"original_position":21,"commit_id":"79a8457bb275811c88e2c0a714065ad1b1beb3ac","original_commit_id":"79a8457bb275811c88e2c0a714065ad1b1beb3ac","user":{"login":"attilamolnar","id":1634220,"avatar_url":"https://secure.gravatar.com/avatar/2040308b6f1260422c8d1b0e6372b3e1?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"2040308b6f1260422c8d1b0e6372b3e1","url":"https://api.github.com/users/attilamolnar","html_url":"https://github.com/attilamolnar","followers_url":"https://api.github.com/users/attilamolnar/followers","following_url":"https://api.github.com/users/attilamolnar/following","gists_url":"https://api.github.com/users/attilamolnar/gists{/gist_id}","starred_url":"https://api.github.com/users/attilamolnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attilamolnar/subscriptions","organizations_url":"https://api.github.com/users/attilamolnar/orgs","repos_url":"https://api.github.com/users/attilamolnar/repos","events_url":"https://api.github.com/users/attilamolnar/events{/privacy}","received_events_url":"https://api.github.com/users/attilamolnar/received_events","type":"User"},"created_at":"2013-03-14T18:06:49Z","updated_at":"2013-03-14T18:06:49Z","html_url":"https://github.com/inspircd/inspircd/pull/436#discussion_r3378207","pull_request_url":"https://api.github.com/repos/inspircd/inspircd/pulls/436","_links":{"self":{"href":"https://api.github.com/repos/inspircd/inspircd/pulls/comments/3378207"},"html":{"href":"https://github.com/inspircd/inspircd/pull/436#discussion_r3378207"},"pull_request":{"href":"https://api.github.com/repos/inspircd/inspircd/pulls/436"}}}}

{"repository":{"description":"Main inspircd repository.","homepage":"http://inspircd.github.com","watchers":138,"stargazers":138,"forks":46,"fork":false,"size":84470,"owner":"inspircd","private":false,"open_issues":55,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"C++","created_at":"2012-03-21T05:22:32-07:00","pushed_at":"2013-03-11T12:56:40-07:00","master_branch":"insp20","organization":"inspircd"},"actor_attributes":{"type":"User","name":"Attila Molnar","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/inspircd/inspircd/pull/436#discussion_r3378207"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/libqueso/queso/pulls/comments/7681356","id":7681356,"diff_hunk":"@@ -487,3 +452,602 @@ \\section{The Software Stack of an Application Using QUESO}\n Once the two-model analysis end, the combined model can use the full set of processors.\\footnote{The parallel capabilities of QUESO have been exercised on the Ranger system of the TACC \\cite{tacc} with up to 16k processors.}\n \n \n+\n+\\section{Algorithms for solving Statistical Inverse Problems}\n+\n+The goal of inference is to characterize the posterior PDF, or to evaluate point or interval estimates based on the posterior~\\cite{HuMa01}.\n+Samples from posterior can be obtained using Markov chain Monte Carlo (MCMC) which require only pointwise evaluations of the unnormalized posterior.\n+The resulting samples can then be used to either visually present the posterior or its marginals, or to construct sample estimates of posterior expectations.\n+Examples of MCMC are: the Metropolis-Hastings (MH) algorithm~\\cite{Metr_1953,Hast_1970}, the Delayed Rejection (DR) algorithm~\\cite{GrMi01,Mira01}, and\n+Adaptive Metropolis (AM)~\\cite{HaSaTa01} which are combined together in the Delayed Rejection Adaptive Metropolis, DRAM, algorithm~\\cite{HaLaMiSa06}. The DRAM is implemented in QUESO and available for the solution of SIP. MCMC methods are well-established and documented~\\cite{CaSo07,GrMi01,HaLaMiSa06,HaSaTa01,Hast_1970,KaSo05,Laine08,Metr_1953,Mira01}; thus only brief description of the DRAM algorithm is presented in Section \\ref{sec:DRAM}. \n+\n+\n+During model construction, errors arising from imperfect modeling and uncertainties due to incomplete information about the system and its environment always exist; thus, there has been a crescent interest in Bayesian model class updating and selection \\cite{ChingChen2007,ChOlPr10,CheungPrudencio2012}. \n+\n+Model updating refers to the methodology that determines the most plausible model for a system, given a prior PDF. One stochastic method that handles model updating successfully is the multilevel method. Throughout the years, sereveral versions of the same method have been implemented as improvements of its predecessors~\\cite{BeckAu2002,ChingChen2007,CheungPrudencio2012}. QUESO hosts the novel Adaptive Multilevel Stochastic Simulation Algorithm (Throughout)~\\cite{CheungPrudencio2012}, which is described in Section \\ref{sec:ML:intro}. For details about the method, please refer to \\cite{CheungPrudencio2012}.\n+\n+%\\subsection{Markov chain Monte Carlo Algorithms}\\label{sec:DRAM}\n+\n+\n+\\subsection{DRAM Algorithm}\\label{sec:DRAM}\n+\n+DRAM is a combination of two ideas for improving the efficiency of Metropolis-Hastings type Markov chain Monte Carlo (MCMC) algorithms, Delayed Rejection and Adaptive Metropolis~\\cite{DRAMtool}. \n+\n+Random walk Metropolis-Hasting algorithm with Gaussian proposal distribution is useful in simulating from the posterior distribution in many Bayesian data analysis situations.\n+% For example, in large class of nonlinear models we can write the model as\n+% $$\n+% y = f(x;\\btheta) + \\varepsilon,\\quad \\varepsilon \\sim \\mathcal{N}(0,I \\sigma^2),\n+% $$\n+% where $y$ are indepndent observations of the system, with the expected behaviour described by the model function $f(x;\\btheta)$, depending on control variables $x$ and model parameters $\\btheta$ distribution.\n+% \n+In order for the chain to be efficient, the proposal covariance must somehow be tuned to the shape and size of the target distribution. This is important in highly nonlinear situations, when there are correlation between the components of the posterior, or when the dimension of the parameter is high. The problem of adapting the proposal distribution using the chain simulated so far is that when the accepted values depend on the history of the chain, it is no longer Markovian and standard convergence results do not apply. One solution is to use adaptation only for the burn-in period and discard the part of the chain where adaptation has been used. In that respect, the adaptation can be thought as automatic burn-in. The idea of diminishing adaptation is that when adaptation works well, its effect gets smaller and we might be able to prove the ergodicity properties of the chain even when adaptation is used throughout the whole simulation. This is the ideology behind AM adaptation. On the other hand, the DR \n+method allows the use of the the current rejected values without losing the Markovian property and thus allows to adapt locally to the current location of the target distribution.\n+\n+In Adaptive Metropolis~\\cite{HaSaTa01} the covariance matrix of the Gaussian proposal distribution is adapted on the fly using the past chain. This adaptation destroys the Markovian property of the chain, however, it can be shown that the ergodicity properties of the generated sample remain. How well this works on finite samples and on high dimension is not obvious and must be verified by simulations.\n+\n+Starting from initial covariance $C^{(0)}$, the target covariance is updated at given intervals from the chain generated so far.\n+$$\n+%C_i = (cov(chain1:i) + I\\delta)s,\n+C^{(i)} = s_d \\, cov(\\text{chain}_1:\\text{chain}_i) + s_d \\varepsilon I_d,\n+$$\n+the small number $\\varepsilon$ prevents the sample covariance matrix from becoming singular. For the scaling factor, the value $s_d = 2.4^2/d$ is standard optimal choice for Gaussian targets, $d$ being the dimension of the target~\\cite{GelmanEtAl2004}. A standard updating formula for the sample covariance matrix can be used, so that the whole chain does not need to reside in the computer memory.\n+\n+With the Delayed rejection method~\\cite{Mira01}, it becomes possible to make use of several tries after rejecting a value by using different proposals while keep the reversibility of the chain. Delayed rejection method (DR) works in the following way. Upon rejection a proposed candidate point, instead of advancing time and retaining the same position, a second stage move is proposed. The acceptance probability of the second stage candidate is computed so that reversibility of the Markov chain relative to the distribution of interest is preserved. The process of delaying rejection can be iterated for a fixed or random number of stages, let's say $n_\\text{stages}$. The higher stage proposals are allowed to depend on the candidates so far proposed and rejected. Thus DR allows partial local adaptation of the proposal within each time step of the Markov chain still retaining the Markovian property and reversibility.\n+\n+The first stage acceptance probability in DR is the standard MH acceptance and it can be written as\n+\\begin{equation*}\n+\\alpha_1(\\mathbf{a},\\mathbf{x}^{(1)}) = \\text{ min}\n+\\left\\{ 1,\n+\\frac{\\pi(\\mathbf{x}^{(1)})}{\\pi(\\mathbf{a})} \\cdot\n+\\frac{q_1(\\mathbf{x}^{(1)},\\mathbf{a})}{q_1(\\mathbf{a},\\mathbf{x}^{(1)})}\n+\\right\\},\n+\\end{equation*}\n+\n+Here $\\mathbf{a}$ is the current point, $\\mathbf{x}^{(1)}$ is the proposed new value drawn from the distribution $q_1(\\mathbf{a}, \\cdot)$, and $\\pi$ is the target distribution. If $\\mathbf{x}^{(1)}$ is rejected, a second candidate $\\mathbf{x}^{(2)}$ is drawn from $q_2(\\mathbf{a}, \\mathbf{x}^{(1)} , \\cdot)$ using the acceptance probability\n+\\begin{equation*}\n+\\alpha_2( \\mathbf{a}, \\mathbf{x}^{(1)}, \\mathbf{x}^{(2)}) =\\min \\left\\{1,\n+\\dfrac{\\pi( \\mathbf{x}^{(2)}) q_1( \\mathbf{x}^{(2)}, \\mathbf{x}^{(1)}) q_2( \\mathbf{x}^{(2)}, \\mathbf{x}^{(1)}, \\mathbf{a})[1 - \\alpha_1( \\mathbf{x}^{(2)} , \\mathbf{x}^{(1)} )]}{\\pi( \\mathbf{a}) q_1( \\mathbf{a}, \\mathbf{x}^{(1)}) q_2( \\mathbf{a}, \\mathbf{x}^{(1)}, \\mathbf{x}^{(2)})[1 - \\alpha_1 ( \\mathbf{a}, \\mathbf{x}^{(1)} )]}\n+\\right\\}\n+\\end{equation*}\n+%\n+i.e., it depends not only on the current position of the chain but also on what we have just proposed and rejected.\n+\n+As the reversibility property is preserved, this method also leads to the same stationary distribution $\\pi$ as the standard MH algorithm. The procedure can be iterated further for higher-stage proposals. \n+%\n+The Gaussian proposal at each stage $i$ is defined as:\n+\\begin{equation} % Gamma_i esta embutido na formula do q_i\n+\\label{eq:qi}\n+q_i(\\underbrace{\\mathbf{a},\\mathbf{x}^{(1)},\\ldots,\\mathbf{x}^{(i-1)}}_{i\\text{ terms}},\\mathbf{z})\n+=\n+e^{-\\dfrac{1}{2}{\\displaystyle \\left\\{[\\mathbf{z}-\\mathbf{a}]^T\\cdot \\left[\\mathbf{C}\\right]^{-1}\\cdot[\\mathbf{z}-\\mathbf{a}]\\right\\}}} \n+\\end{equation}\n+\n+% \\begin{equation*} % Gamma_i esta embutido na formula do q_i\n+% q_i(\\underbrace{\\mathbf{a},\\mathbf{x}^{(1)},\\ldots,\\mathbf{x}^{(i-1)}}_{i\\text{ terms}},\\mathbf{z})\n+% =\n+% e^{-\\dfrac{1}{2}{\\displaystyle \\left\\{[\\mathbf{z}-\\mathbf{a}]^T\\cdot \\left[\\frac{1}{\\gamma_i^2}\\mathbf{C}\\right]^{-1}\\cdot[\\mathbf{z}-\\mathbf{a}]\\right\\}}} \n+% \\end{equation*}\n+where the covariance matrix $\\mathbf{C}$ and the scalings for the higher-stage proposal covariances $1=\\gamma_1\\leqslant\\gamma_2\\leqslant\\ldots\\leqslant\\gamma_{n_{\\text{stages}}}$ are given.\n+\n+\n+If $q_i$ denotes the proposal at the $i$-th stage, the acceptance probability at that stage is:\n+\\begin{equation}\\label{eq-alphas}\n+\\alpha_i(\\mathbf{a},\\mathbf{x}^{(1)},\\ldots,\\mathbf{x}^{(i)}) = \\text{ min}\n+\\left\\{1,\n+\\frac {\\pi(\\mathbf{x}^{(i)})}{\\pi(\\mathbf{a})} \\cdot q_{\\text{fraction}} \\cdot \\alpha_{\\text{fraction}}\n+\\right\\}.\n+\\end{equation}\n+where the expressions $q_{\\text{fraction}}$ and $\\alpha_{\\text{fraction}}$ are given by\n+\\begin{equation*}\n+q_{\\text{fraction}}=\n+\\frac{q_1(\\mathbf{x}^{(i)},\\mathbf{x}^{(i-1)})}{q_1(\\mathbf{a},\\mathbf{x}^{(1)})}\n+\\frac{q_2(\\mathbf{x}^{(i)},\\mathbf{x}^{(i-1)},\\mathbf{x}^{(i-2)})}{q_2(\\mathbf{a},\\mathbf{x}^{(1)},\\mathbf{x}^{(2)})}\n+\\ldots\n+\\frac{q_i(\\mathbf{x}^{(i)},\\mathbf{x}^{(i-1)},\\ldots,\\mathbf{x}^{(1)},\\mathbf{a})}{q_i(\\mathbf{a},\\mathbf{x}^{(1)},\\ldots,\\mathbf{x}^{(i-1)},\\mathbf{x}^{(i)})}\n+\\end{equation*}\n+and\n+\\begin{equation*}\n+\\alpha_{\\text{fraction}}=\n+\\frac{[1-\\alpha_1(\\mathbf{x}^{(i)},\\mathbf{x}^{(i-1)})]}{[1-\\alpha_1(\\mathbf{a},\\mathbf{x}^{(1)})]}\n+\\frac{[1-\\alpha_2(\\mathbf{x}^{(i)},\\mathbf{x}^{(i-1)},\\mathbf{x}^{(i-2)})]}{[1-\\alpha_2(\\mathbf{a},\\mathbf{x}^{(1)},\\mathbf{x}^{(2)})]}\n+\\ldots\n+\\frac{[1-\\alpha_{i-1}(\\mathbf{x}^{(i)},\\mathbf{x}^{(i-1)},\\ldots,\\mathbf{x}^{(1)})]}{[1-\\alpha_{i-1}(\\mathbf{a},\\mathbf{x}^{(1)},\\ldots,\\mathbf{x}^{(i-1)})]}.\n+\\end{equation*}\n+\n+\n+Since all acceptance probabilities are computed so that reversibility with respect to $\\pi$ is preserved separately at each\n+stage, the process of delaying rejection can be interrupted at any stage that is, we can, in advance, decide to try at\n+most, say, 3 times to move away from the current position,\n+otherwise we let the chain stay where it is. Alternatively,\n+upon each rejection, we can toss a p-coin (i.e., a coin with\n+head probability equal to p), and if the outcome is head we\n+move to a higher stage proposal, otherwise we stay put~\\cite{HaLaMiSa06}.\n+\n+\n+The smaller overall rejection rate of DR guarantees smaller asymptotic variance of the estimates based on the chain. The DR chain can be shown to be asymptotically more efficient that MH chain in the sense of Peskun ordering (Mira, 2001a). \n+\n+% Haario, et al. 2006 \\cite{} combine AM and DR into a method called DRAM, in whzt they clain to me a straightforward possibility amonsgt the possible different implementations of the idea, which is decribed in this section.\n+% In order to be able to adapt the proposal at all you need some accepted points to start with. One ``master\" proposal is tried first. After rejection, a try with modified version of the first proposal is done according to DR. A second proposal can be one with a smaller covariance, or with different orientation of the principal axes. The master proposal is adapted using the chain generated so far, and the second stage proposal follows the adaptation in obvious manner. %In the examples, and in the dramrun Matlab function, the second stage is just a scaled down version of the first stage proposal that itself is adapted according to AM. \n+% \n+% \n+% The DRAM may be considered a straightforward way of combining AM adaptation with a $m$-stages DR algorithm, by doing:\n+% i) the proposal at the first stage of DR is adapted just as in AM: the covariance $C^{(1)}$ is computed from the points of the\n+% sampled chain, no matter at which stage these points have been accepted in the sample path;\n+% ii0 the covariance $C^{(i)}$ of the proposal for the $i$-th stage ($i=2,\\ldots, m$) is always computed simply as a scaled version\n+% of the proposal of the first stage, $C^{(i)} = \\gamma_i C^{(1)}$; where the scale factors $\\gamma_i$ can be somewhat freely chosen.\n+% \n+% ------------\n+\n+\n+Haario, et al. 2006 \\cite{HaLaMiSa06} combine AM and DR into a method called DRAM, in what they claim to be a straightforward possibility amongst the possible different implementations of the idea, and which is described in this section.\n+\n+In order to be able to adapt the proposal, all you need some accepted points to start with. \n+%\n+One ``master\" proposal is tried first -- i.e., the proposal at the first stage of DR is adapted just as in AM: the covariance $C^{(1)}$ is computed from the points of the sampled chain, no matter at which stage these points have been accepted in the sample path. \n+After rejection, a try with modified version of the first proposal is done according to DR. A second proposal can be one with a smaller covariance, or with different orientation of the principal axes. The most common choice is to always compute the covariance $C^{(i)}$ of the proposal for the $i$-th stage ($i=2,\\ldots, n_\\text{stages}$) simply as a scaled version of the proposal of the first stage, $$C^{(i)} = \\gamma_i C^{(1)}$$ where the scale factors $\\gamma_i$ can be somewhat freely chosen. Then, the master proposal is adapted using the chain generated so far, and the second stage proposal follows the adaptation in obvious manner. %In the examples, and in the dramrun Matlab function, the second stage is just a scaled down version of the first stage proposal that itself is adapted according to AM. \n+\n+\n+\n+The requirements for the DRAM algorithm are:\n+\\begin{itemize}\n+ \\item Number $n_{\\text{pos}}\\geqslant 2$ of positions in the chain;\n+ \\item Initial guess $\\mathbf{m}^{(0)}$;\n+ \\item Number of stages for the DR method: $n_{\\text{stages}}\\geqslant 1$;\n+ \\item For $1\\leqslant i\\leqslant n_{\\text{stages}}$, functions $q_i:\\underbrace{\\mathbb{R}^N\\times\\ldots\\times\\mathbb{R}^N}_{(i+1)\\text{ times}}\\rightarrow\\mathbb{R}_{+}$, such that $q_i(\\mathbf{a},\\mathbf{x}^{(1)},\\ldots,\\mathbf{x}^{(i-1)},\\cdot)$ is a PDF for any $(\\mathbf{a},\\mathbf{x}^{(1)},\\ldots,\\mathbf{x}^{(i-1)})\\in\\underbrace{\\mathbb{R}^N\\times\\ldots\\times\\mathbb{R}^N}_{i\\text{ times}}$; i.e., choose $q_i$ as in Equation~\\eqref{eq:qi};\n+ \\item Recursively define $\\alpha_i:\\underbrace{\\mathbb{R}^n\\times\\ldots\\times\\mathbb{R}^n}_{(i+1)\\text{ times}}\\rightarrow [0,1],\\quad 1\\leqslant i\\leqslant n_{\\text{stages}}$ according to Equation~\\eqref{eq-alphas}.\n+\\end{itemize}\n+\n+% . Also, the Gaussian proposal at each stage $i$ is defined as:\n+% \\begin{equation*}\n+% q_i(\\underbrace{\\mathbf{a},\\mathbf{b},\\ldots,\\mathbf{y}}_{i\\text{ terms}},\\mathbf{z})\n+% =\n+% e^{-\\frac{1}{2}{\\displaystyle \\left\\{[\\mathbf{z}-\\mathbf{a}]^T\\cdot \\left[\\frac{1}{\\gamma_i^2}\\mathbf{C}\\right]^{-1}\\cdot[\\mathbf{z}-\\mathbf{a}]\\right\\}}}\n+% \\end{equation*}\n+% when the covariance matrix $\\mathbf{C}$ and the ($n_{\\text{stages}}$) numbers $1=\\gamma_1\\leqslant\\gamma_2\\leqslant\\ldots\\leqslant\\gamma_{n_{\\text{stages}}}$ are given.\n+% \n+\n+Recalling that a sample is defined as:\n+\\begin{equation*} % tirei o gamma_i de ser umbutido na covariance matrix","path":"manual/users/users_1_introduction.tex","position":611,"original_position":611,"commit_id":"3bc49449853b27168839754da94430e496a0813c","original_commit_id":"3bc49449853b27168839754da94430e496a0813c","user":{"login":"dmcdougall","id":328518,"avatar_url":"https://1.gravatar.com/avatar/ee646002e51a3c83e01db85ae42187ff?d=https%3A%2F%2Fidenticons.github.com%2F0d3991f076299043944a511c201467e3.png&r=x","gravatar_id":"ee646002e51a3c83e01db85ae42187ff","url":"https://api.github.com/users/dmcdougall","html_url":"https://github.com/dmcdougall","followers_url":"https://api.github.com/users/dmcdougall/followers","following_url":"https://api.github.com/users/dmcdougall/following{/other_user}","gists_url":"https://api.github.com/users/dmcdougall/gists{/gist_id}","starred_url":"https://api.github.com/users/dmcdougall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmcdougall/subscriptions","organizations_url":"https://api.github.com/users/dmcdougall/orgs","repos_url":"https://api.github.com/users/dmcdougall/repos","events_url":"https://api.github.com/users/dmcdougall/events{/privacy}","received_events_url":"https://api.github.com/users/dmcdougall/received_events","type":"User","site_admin":false},"body":"I was just translating it for myself so I understood the comment. And so that anybody else reading this paper trail can also understand the comment. I certainly didn't mean to cause any offence.","created_at":"2013-11-15T03:10:39Z","updated_at":"2013-11-15T03:10:39Z","html_url":"https://github.com/libqueso/queso/pull/179#discussion_r7681356","pull_request_url":"https://api.github.com/repos/libqueso/queso/pulls/179","_links":{"self":{"href":"https://api.github.com/repos/libqueso/queso/pulls/comments/7681356"},"html":{"href":"https://github.com/libqueso/queso/pull/179#discussion_r7681356"},"pull_request":{"href":"https://api.github.com/repos/libqueso/queso/pulls/179"}}}}

{"repository":{"description":"QUESO is a C++ library for doing uncertainty quantification. QUESO stands for Quantification of Uncertainty for Estimation, Simulation and Optimization.","homepage":"","watchers":6,"stargazers":6,"forks":7,"fork":false,"size":179780,"owner":"libqueso","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Matlab","created_at":"2013-08-30T09:47:00-07:00","pushed_at":"2013-11-14T18:05:13-08:00","master_branch":"dev","organization":"libqueso"},"actor_attributes":{"type":"User","name":"Damon McDougall","company":"University of Texas at Austin","blog":"http://www.damon-is-a-geek.com","location":"Austin","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/libqueso/queso/pull/179#discussion_r7681356"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/linkedin/datafu/pulls/comments/8546995","id":8546995,"diff_hunk":"@@ -0,0 +1,548 @@\n+package datafu.test.pig.stats.entropy;\n+\n+import static org.testng.Assert.*;\n+\n+import java.util.ArrayList;\n+import java.util.Iterator;\n+import java.util.List;\n+\n+import org.adrianwalker.multilinestring.Multiline;\n+import org.apache.pig.data.Tuple;\n+import org.apache.pig.pigunit.PigTest;\n+import org.testng.annotations.Test;\n+\n+import datafu.test.pig.PigTests;\n+\n+/*\n+ * R's entropy library: http://cran.r-project.org/web/packages/entropy/entropy.pdf\n+ * used as our test benchmark \n+ */\n+public class EntropyTests extends PigTests\n+{\n+ /**\n+ register $JAR_PATH\n+\n+ define Entropy datafu.pig.stats.entropy.Entropy();\n+ \n+ data = load 'input' as (val:double);\n+ --describe data;\n+ data_grouped = GROUP data BY val;\n+ data_cnt = FOREACH data_grouped GENERATE COUNT(data) AS cnt;\n+ data_cnt_grouped = GROUP data_cnt ALL;\n+ data_out = FOREACH data_cnt_grouped GENERATE Entropy(data_cnt);\n+ store data_out into 'output';\n+ */\n+ @Multiline private String entropy;\n+ \n+ @Test\n+ public void uniqValEntropoyTest() throws Exception\n+ {\n+ System.out.println(entropy);\n+ PigTest test = createPigTestFromString(entropy); // logarithm base is e \n+ \n+ writeLinesToFile(\"input\",\n+ \"98.94791\",\n+ \"38.61010\",\n+ \"97.10575\",\n+ \"62.28313\",\n+ \"38.83960\",\n+ \"32.05370\",\n+ \"96.10962\",\n+ \"28.72388\",\n+ \"96.65888\",\n+ \"20.41135\");\n+ \n+ test.runScript();\n+ \n+ /* Add expected values, computed using R:\n+ * \n+ * e.g.\n+ * \n+ * > v=c(98.94791,38.61010,97.10575,62.28313,38.83960,32.05370,96.10962,28.72388,96.65888,20.41135) \n+ * > table(v)\n+ * v\n+ * 20.41135 28.72388 32.0537 38.6101 38.8396 62.28313 96.10962 96.65888 97.10575 98.94791 \n+ * 1 1 1 1 1 1 1 1 1 1 \n+ * > count=c(1,1,1,1,1,1,1,1,1,1)\n+ * > library(entropy)\n+ * > entropy(count)\n+ * [1] 2.302585\n+ * \n+ */\n+ List<Double> expectedOutput = new ArrayList<Double>();\n+ expectedOutput.add(2.302585);\n+ \n+ List<Tuple> output = this.getLinesForAlias(test, \"data_out\");\n+ Iterator<Double> expectationIterator = expectedOutput.iterator();\n+ for (Tuple t : output)\n+ {\n+ assertTrue(expectationIterator.hasNext());\n+ Double entropy = (Double)t.get(0);\n+ assertEquals(String.format(\"%.5f\",entropy),String.format(\"%.5f\", expectationIterator.next()));\n+ }\n+ }\n+\n+ @Test\n+ public void singleValEntropoyTest() throws Exception\n+ {\n+ System.out.println(entropy);\n+ PigTest test = createPigTestFromString(entropy); // logarithm base is e \n+ \n+ writeLinesToFile(\"input\",\n+ \"98.94791\",\n+ \"98.94791\",\n+ \"98.94791\",\n+ \"98.94791\",\n+ \"98.94791\",\n+ \"98.94791\",\n+ \"98.94791\",\n+ \"98.94791\",\n+ \"98.94791\",\n+ \"98.94791\");\n+ \n+ test.runScript();\n+ \n+ /* Add expected values, computed using R:\n+ * \n+ * e.g.\n+ * \n+ * > v=c(98.94791,98.94791,98.94791,98.94791,98.94791,98.94791,98.94791,98.94791,98.94791,98.94791) \n+ * > table(v)\n+ * v\n+ * 98.94791 \n+ * 10 \n+ * > count=(10)\n+ * > library(entropy)\n+ * > entropy(count)\n+ * [1] 0\n+ * \n+ */\n+ List<Double> expectedOutput = new ArrayList<Double>();\n+ expectedOutput.add(0.0);\n+ \n+ List<Tuple> output = this.getLinesForAlias(test, \"data_out\");\n+ Iterator<Double> expectationIterator = expectedOutput.iterator();\n+ for (Tuple t : output)\n+ {\n+ assertTrue(expectationIterator.hasNext());\n+ Double entropy = (Double)t.get(0);\n+ assertEquals(String.format(\"%.5f\",entropy),String.format(\"%.5f\", expectationIterator.next()));\n+ }\n+ }\n+\n+ @Test\n+ public void dupValEntropoyTest() throws Exception\n+ {\n+ System.out.println(entropy);\n+ PigTest test = createPigTestFromString(entropy); // logarithm base is e \n+ \n+ writeLinesToFile(\"input\",\n+ \"98.94791\",\n+ \"38.61010\",\n+ \"97.10575\",\n+ \"62.28313\",\n+ \"38.61010\",\n+ \"32.05370\",\n+ \"96.10962\",\n+ \"38.61010\",\n+ \"96.10962\",\n+ \"20.41135\");\n+ \n+ test.runScript();\n+ \n+ /* Add expected values, computed using R:\n+ * \n+ * e.g.\n+ * \n+ * > v=c(98.94791,38.61010,97.10575,62.28313,38.61010,32.05370,96.10962,38.61010,96.10962,20.41135) \n+ * > table(v)\n+ * v\n+ * 20.41135 32.0537 38.6101 62.28313 96.10962 97.10575 98.94791 \n+ * 1 1 3 1 2 1 1 \n+ * > count=c(1,1,3,1,2,1,1)\n+ * > library(entropy)\n+ * > entropy(count)\n+ * [1] 1.834372\n+ * \n+ */\n+ List<Double> expectedOutput = new ArrayList<Double>();\n+ expectedOutput.add(1.834372);\n+ \n+ List<Tuple> output = this.getLinesForAlias(test, \"data_out\");\n+ Iterator<Double> expectationIterator = expectedOutput.iterator();\n+ for (Tuple t : output)\n+ {\n+ assertTrue(expectationIterator.hasNext());\n+ Double entropy = (Double)t.get(0);\n+ assertEquals(String.format(\"%.5f\",entropy),String.format(\"%.5f\", expectationIterator.next()));\n+ }\n+ }\n+\n+ @Test\n+ public void emptyInputBagEntropoyTest() throws Exception\n+ {\n+ System.out.println(entropy);\n+ PigTest test = createPigTestFromString(entropy); // logarithm base is e \n+ \n+ writeLinesToFile(\"input\"\n+ );\n+\n+ test.runScript();\n+ \n+ /* Add expected values, computed using R:\n+ * \n+ * e.g.\n+ * \n+ * > v=c() \n+ * > table(v)\n+ * < table of extent 0 > \n+ * > count=c()\n+ * > library(entropy)\n+ * > entropy(count)\n+ * [1] 0 \n+ * \n+ */\n+ List<Double> expectedOutput = new ArrayList<Double>();\n+ expectedOutput.add(0.0);\n+ \n+ List<Tuple> output = this.getLinesForAlias(test, \"data_out\");\n+ Iterator<Double> expectationIterator = expectedOutput.iterator();\n+ for (Tuple t : output)\n+ {\n+ assertTrue(expectationIterator.hasNext());\n+ Double entropy = (Double)t.get(0);\n+ assertEquals(String.format(\"%.5f\",entropy),String.format(\"%.5f\", expectationIterator.next()));\n+ }\n+ }\n+\n+ @Test\n+ public void singleElemInputBagEntropoyTest() throws Exception\n+ {\n+ System.out.println(entropy);\n+ PigTest test = createPigTestFromString(entropy); // logarithm base is e \n+ \n+ writeLinesToFile(\"input\",\n+ \"98.94791\");\n+\n+ test.runScript();\n+ \n+ /* Add expected values, computed using R:\n+ * \n+ * e.g.\n+ * \n+ * > count=c(1)\n+ * > library(entropy)\n+ * > entropy(count)\n+ * [1] 0\n+ * \n+ */\n+ List<Double> expectedOutput = new ArrayList<Double>();\n+ expectedOutput.add(0.0);\n+ \n+ List<Tuple> output = this.getLinesForAlias(test, \"data_out\");\n+ Iterator<Double> expectationIterator = expectedOutput.iterator();\n+ for (Tuple t : output)\n+ {\n+ assertTrue(expectationIterator.hasNext());\n+ Double entropy = (Double)t.get(0);\n+ assertEquals(String.format(\"%.5f\",entropy),String.format(\"%.5f\", expectationIterator.next()));\n+ }\n+ }\n+\n+ /**\n+ register $JAR_PATH\n+\n+ define Entropy datafu.pig.stats.entropy.Entropy();\n+\n+ data = load 'input' as (x:chararray, y:double);\n+ --describe data;\n+ data_grouped = GROUP data BY (x, y);\n+ data_cnt = FOREACH data_grouped GENERATE COUNT(data);\n+ data_cnt_grouped = GROUP data_cnt ALL;\n+ data_out = FOREACH data_cnt_grouped GENERATE Entropy(data_cnt);\n+ store data_out into 'output';\n+ */\n+ @Multiline private String pairEntropy;\n+ \n+ @Test\n+ public void dupPairValEntropoyTest() throws Exception\n+ {\n+ System.out.println(pairEntropy);\n+ PigTest test = createPigTestFromString(pairEntropy); // logarithm base is e \n+ \n+ writeLinesToFile(\"input\",\n+ \"hadoop\t98.94791\",\n+ \"bigdata\t38.61010\",\n+ \"hadoop\t97.10575\",\n+ \"datafu\t32.05370\",\n+ \"bigdata\t38.61010\",\n+ \"datafu\t32.05370\",\n+ \"datafu\t32.05370\",\n+ \"hadoop\t38.61010\",\n+ \"pig\t96.10962\",\n+ \"pig\t20.41135\");\n+ \n+ test.runScript();\n+ \n+ /* Add expected values, computed using R:\n+ * \n+ * e.g.\n+ * > t <- data.table(x=c(\"hadoop\",\"bigdata\",\"hadoop\",\"datafu\",\"bigdata\",\"datafu\",\"datafu\",\"hadoop\",\"pig\",\"pig\"),y=c(98.94791,38.61010,97.10575,32.05370,38.61010,32.05370,32.05370,38.61010,96.10962,20.41135))\n+ * > t <- t[order(x,y)]\n+ * > count<-c(2,3,1,1,1,1,1)\n+ * > library(entropy)\n+ * > entropy(count)\n+ * [1] 1.834372 \n+ * \n+ */\n+ List<Double> expectedOutput = new ArrayList<Double>();\n+ expectedOutput.add(1.834372);\n+ \n+ List<Tuple> output = this.getLinesForAlias(test, \"data_out\");\n+ Iterator<Double> expectationIterator = expectedOutput.iterator();\n+ for (Tuple t : output)\n+ {\n+ assertTrue(expectationIterator.hasNext());\n+ Double entropy = (Double)t.get(0);\n+ assertEquals(String.format(\"%.5f\",entropy),String.format(\"%.5f\", expectationIterator.next()));\n+ }\n+ }\n+\n+ /**\n+ register $JAR_PATH\n+\n+ define Entropy datafu.pig.stats.entropy.Entropy();\n+ \n+ data_cnt = load 'input' as val;\n+ --describe data_cnt;\n+ data_cnt_grouped = GROUP data_cnt ALL;\n+ data_out = FOREACH data_cnt_grouped GENERATE Entropy(data_cnt);\n+ store data_out into 'output';\n+ */\n+ @Multiline private String rawByteInputEntropy;\n+ \n+ @Test\n+ public void rawByteInputEntropoyTest() throws Exception\n+ {\n+ System.out.println(rawByteInputEntropy);\n+ PigTest test = createPigTestFromString(rawByteInputEntropy); // logarithm base is 2 ","path":"test/pig/datafu/test/pig/stats/entropy/EntropyTests.java","position":328,"original_position":328,"commit_id":"a5849fd6f375fbdd1cf4e47d75ada8332d84cc90","original_commit_id":"a5849fd6f375fbdd1cf4e47d75ada8332d84cc90","user":{"login":"matthayes","id":212331,"avatar_url":"https://gravatar.com/avatar/d8c501c3eb6c504475bc945c8972ab52?d=https%3A%2F%2Fidenticons.github.com%2Fff788f50a9c8aae646ff817e78f3eef9.png&r=x","gravatar_id":"d8c501c3eb6c504475bc945c8972ab52","url":"https://api.github.com/users/matthayes","html_url":"https://github.com/matthayes","followers_url":"https://api.github.com/users/matthayes/followers","following_url":"https://api.github.com/users/matthayes/following{/other_user}","gists_url":"https://api.github.com/users/matthayes/gists{/gist_id}","starred_url":"https://api.github.com/users/matthayes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthayes/subscriptions","organizations_url":"https://api.github.com/users/matthayes/orgs","repos_url":"https://api.github.com/users/matthayes/repos","events_url":"https://api.github.com/users/matthayes/events{/privacy}","received_events_url":"https://api.github.com/users/matthayes/received_events","type":"User","site_admin":false},"body":"or is this 2 a typo?","created_at":"2013-12-24T22:38:53Z","updated_at":"2013-12-24T22:38:53Z","html_url":"https://github.com/linkedin/datafu/pull/78#discussion_r8546995","pull_request_url":"https://api.github.com/repos/linkedin/datafu/pulls/78","_links":{"self":{"href":"https://api.github.com/repos/linkedin/datafu/pulls/comments/8546995"},"html":{"href":"https://github.com/linkedin/datafu/pull/78#discussion_r8546995"},"pull_request":{"href":"https://api.github.com/repos/linkedin/datafu/pulls/78"}}}}

{"repository":{"description":"Hadoop library for large-scale data processing","homepage":"http://data.linkedin.com/opensource/datafu","watchers":476,"stargazers":476,"forks":110,"fork":false,"size":25193,"owner":"linkedin","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2011-09-16T15:32:31-07:00","pushed_at":"2013-12-17T14:01:10-08:00","master_branch":"master","organization":"linkedin"},"actor_attributes":{"type":"User","name":"Matt Hayes","company":"LinkedIn","location":"Mountain View, CA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/linkedin/datafu/pull/78#discussion_r8546995"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/lizardfs/lizardfs/pulls/comments/6153971","id":6153971,"body":"Should've been rather CHARTS_COUNT (and eventually CHART_VERSION)","diff_hunk":"@@ -36,42 +36,44 @@\n #include \"masterconn.h\"\n #include \"hddspacemgr.h\"\n #include \"replicator.h\"\n+#include \"time_constants.h\"\n \n #define CHARTS_FILENAME \"csstats.mfs\"\n \n-#define CHARTS_UCPU 0\n-#define CHARTS_SCPU 1\n-#define CHARTS_MASTERIN 2\n-#define CHARTS_MASTEROUT 3\n-#define CHARTS_CSCONNIN 4\n-#define CHARTS_CSCONNOUT 5\n-#define CHARTS_CSSERVIN 6\n-#define CHARTS_CSSERVOUT 7\n-#define CHARTS_BYTESR 8\n-#define CHARTS_BYTESW 9\n-#define CHARTS_LLOPR 10\n-#define CHARTS_LLOPW 11\n-#define CHARTS_DATABYTESR 12\n-#define CHARTS_DATABYTESW 13\n-#define CHARTS_DATALLOPR 14\n-#define CHARTS_DATALLOPW 15\n-#define CHARTS_HLOPR 16\n-#define CHARTS_HLOPW 17\n-#define CHARTS_RTIME 18\n-#define CHARTS_WTIME 19\n-#define CHARTS_REPL 20\n-#define CHARTS_CREATE 21\n-#define CHARTS_DELETE 22\n-#define CHARTS_VERSION 23\n-#define CHARTS_DUPLICATE 24\n-#define CHARTS_TRUNCATE 25\n-#define CHARTS_DUPTRUNC 26\n-#define CHARTS_TEST 27\n-#define CHARTS_CHUNKIOJOBS 28\n-#define CHARTS_CHUNKOPJOBS 29\n-\n-#define CHARTS 30\n+enum CHARTS_TYPES {\n+\tCHARTS_UCPU,\n+\tCHARTS_SCPU,\n+\tCHARTS_MASTERIN,\n+\tCHARTS_MASTEROUT,\n+\tCHARTS_CSCONNIN,\n+\tCHARTS_CSCONNOUT,\n+\tCHARTS_CSSERVIN,\n+\tCHARTS_CSSERVOUT,\n+\tCHARTS_BYTESR,\n+\tCHARTS_BYTESW,\n+\tCHARTS_LLOPR,\n+\tCHARTS_LLOPW,\n+\tCHARTS_DATABYTESR,\n+\tCHARTS_DATABYTESW,\n+\tCHARTS_DATALLOPR,\n+\tCHARTS_DATALLOPW,\n+\tCHARTS_HLOPR,\n+\tCHARTS_HLOPW,\n+\tCHARTS_RTIME,\n+\tCHARTS_WTIME,\n+\tCHARTS_REPL,\n+\tCHARTS_CREATE,\n+\tCHARTS_DELETE,\n+\tCHARTS_VERSION,\n+\tCHARTS_DUPLICATE,\n+\tCHARTS_TRUNCATE,\n+\tCHARTS_DUPTRUNC,\n+\tCHARTS_TEST,\n+\tCHARTS_CHUNKIOJOBS,\n+\tCHARTS_CHUNKOPJOBS,\n \n+\tCHART_COUNT","path":"mfschunkserver/chartsdata.cc","position":72,"original_position":72,"commit_id":"291fc752842ccebc5a1d079f1e2bc23f8dcdf8fc","original_commit_id":"291fc752842ccebc5a1d079f1e2bc23f8dcdf8fc","user":{"login":"camelon","id":4325719,"avatar_url":"https://0.gravatar.com/avatar/c8404677be494d2603d0c6a45d381c31?d=https%3A%2F%2Fidenticons.github.com%2F9e83ce0f7a689a7542e034efe055f88f.png","gravatar_id":"c8404677be494d2603d0c6a45d381c31","url":"https://api.github.com/users/camelon","html_url":"https://github.com/camelon","followers_url":"https://api.github.com/users/camelon/followers","following_url":"https://api.github.com/users/camelon/following{/other_user}","gists_url":"https://api.github.com/users/camelon/gists{/gist_id}","starred_url":"https://api.github.com/users/camelon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camelon/subscriptions","organizations_url":"https://api.github.com/users/camelon/orgs","repos_url":"https://api.github.com/users/camelon/repos","events_url":"https://api.github.com/users/camelon/events{/privacy}","received_events_url":"https://api.github.com/users/camelon/received_events","type":"User"},"created_at":"2013-09-04T14:03:08Z","updated_at":"2013-09-04T14:03:08Z","html_url":"https://github.com/lizardfs/lizardfs/pull/36#discussion_r6153971","pull_request_url":"https://api.github.com/repos/lizardfs/lizardfs/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/lizardfs/lizardfs/pulls/comments/6153971"},"html":{"href":"https://github.com/lizardfs/lizardfs/pull/36#discussion_r6153971"},"pull_request":{"href":"https://api.github.com/repos/lizardfs/lizardfs/pulls/36"}}}}

{"repository":{"description":"LizardFS is an Open Source Distributed File System licenced under GPLv3.","homepage":"http://lizardfs.org","watchers":13,"stargazers":13,"forks":15,"fork":false,"size":292,"owner":"lizardfs","private":false,"open_issues":6,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2013-05-01T14:08:33-07:00","pushed_at":"2013-09-02T01:49:28-07:00","master_branch":"master","organization":"lizardfs"},"actor_attributes":{"type":"User","name":"camelon","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/lizardfs/lizardfs/pull/36#discussion_r6153971"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/logstash/logstash/pulls/comments/7236087","id":7236087,"diff_hunk":"@@ -1,63 +1,92 @@\n-# do not repack jar files\n-%define __os_install_post %{nil}","path":"pkg/rpm/SPECS/logstash.spec","position":2,"original_position":2,"commit_id":"e19d057ecc2dd26653259cf5ec246710717fb3dc","original_commit_id":"e19d057ecc2dd26653259cf5ec246710717fb3dc","user":{"login":"mzaccari","id":646363,"avatar_url":"https://2.gravatar.com/avatar/5df7f6f32fb5db04164b79c61bfb823a?d=https%3A%2F%2Fidenticons.github.com%2F343847f33ce2c3fd638e065353fc99f3.png&r=x","gravatar_id":"5df7f6f32fb5db04164b79c61bfb823a","url":"https://api.github.com/users/mzaccari","html_url":"https://github.com/mzaccari","followers_url":"https://api.github.com/users/mzaccari/followers","following_url":"https://api.github.com/users/mzaccari/following{/other_user}","gists_url":"https://api.github.com/users/mzaccari/gists{/gist_id}","starred_url":"https://api.github.com/users/mzaccari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzaccari/subscriptions","organizations_url":"https://api.github.com/users/mzaccari/orgs","repos_url":"https://api.github.com/users/mzaccari/repos","events_url":"https://api.github.com/users/mzaccari/events{/privacy}","received_events_url":"https://api.github.com/users/mzaccari/received_events","type":"User","site_admin":false},"body":"Ah, correction: It appears the line affecting JAR repackaging is `%define __jar_repack %{nil}`, which reduces the build time and removes the dependency on `jpackage-utils`. I guess my question at this point is whether or not there is an advantage to re-packaging the JAR during build time.","created_at":"2013-10-27T08:58:53Z","updated_at":"2013-10-27T08:58:53Z","html_url":"https://github.com/logstash/logstash/pull/680#discussion_r7236087","pull_request_url":"https://api.github.com/repos/logstash/logstash/pulls/680","_links":{"self":{"href":"https://api.github.com/repos/logstash/logstash/pulls/comments/7236087"},"html":{"href":"https://github.com/logstash/logstash/pull/680#discussion_r7236087"},"pull_request":{"href":"https://api.github.com/repos/logstash/logstash/pulls/680"}}}}

{"repository":{"description":"logstash - logs/event transport, processing, management, search.","homepage":"http://logstash.net/","watchers":1751,"stargazers":1751,"forks":618,"fork":false,"size":75994,"owner":"logstash","private":false,"open_issues":24,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2010-11-17T17:31:50-08:00","pushed_at":"2013-10-25T11:15:59-07:00","master_branch":"master","organization":"logstash"},"actor_attributes":{"type":"User","name":"Michael Zaccari","company":"Accelerated Concepts","blog":"","location":"Tampa, FL","email":"[email protected]"},"url":"https://github.com/logstash/logstash/pull/680#discussion_r7236087"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/lxcenter/hypervm/pulls/comments/6513339","id":6513339,"body":"back in time?","diff_hunk":"@@ -1,16 +1,17 @@\n <html>\n <!-- httpdocs/lib/indexheader.html -->\n <head>\n- <title>HyperVM</title>\n+ <title>HyperVM 2.1.0</title>\n <meta http-equiv=\"Content-Type\" content=\"text/html; charset=UTF-8\" ></meta>\n <link rel=\"StyleSheet\" href=\"/htmllib/css/common.css\" type=\"text/css\">\n <script language=\"javascript\" src=\"/htmllib/js/login.js\"></script>\n <script language=\"javascript\" src=\"/htmllib/js/preop.js\"></script>\n <meta name=\"GOOGLEBOT\" content=\"NOARCHIVE\">\n <meta name=\"ROBOTS\" content=\"NONE\">\n- <meta name=\"COPYRIGHT\" content=\"&copy; 2013 LxCenter\">\n+ <meta name=\"COPYRIGHT\" content=\"&copy; 2011 LxCenter\">","path":"hypervm/httpdocs/lib/indexheader.html","position":13,"original_position":13,"commit_id":"d1f7c97428285e3e5200f9c84c603f36e9681daa","original_commit_id":"d1f7c97428285e3e5200f9c84c603f36e9681daa","user":{"login":"dterweij","id":1059028,"avatar_url":"https://0.gravatar.com/avatar/a262d2ef96ea969e4974dc98a48e0ba9?d=https%3A%2F%2Fidenticons.github.com%2F936d7eeb19c4309e45cb7a0b3e313f86.png","gravatar_id":"a262d2ef96ea969e4974dc98a48e0ba9","url":"https://api.github.com/users/dterweij","html_url":"https://github.com/dterweij","followers_url":"https://api.github.com/users/dterweij/followers","following_url":"https://api.github.com/users/dterweij/following{/other_user}","gists_url":"https://api.github.com/users/dterweij/gists{/gist_id}","starred_url":"https://api.github.com/users/dterweij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dterweij/subscriptions","organizations_url":"https://api.github.com/users/dterweij/orgs","repos_url":"https://api.github.com/users/dterweij/repos","events_url":"https://api.github.com/users/dterweij/events{/privacy}","received_events_url":"https://api.github.com/users/dterweij/received_events","type":"User"},"created_at":"2013-09-23T12:46:20Z","updated_at":"2013-09-23T12:46:20Z","html_url":"https://github.com/lxcenter/hypervm/pull/57#discussion_r6513339","pull_request_url":"https://api.github.com/repos/lxcenter/hypervm/pulls/57","_links":{"self":{"href":"https://api.github.com/repos/lxcenter/hypervm/pulls/comments/6513339"},"html":{"href":"https://github.com/lxcenter/hypervm/pull/57#discussion_r6513339"},"pull_request":{"href":"https://api.github.com/repos/lxcenter/hypervm/pulls/57"}}}}

{"repository":{"description":"Virtualization Manager for OpenVZ and Xen.","homepage":"http://lxcenter.org/software/hypervm","watchers":36,"stargazers":36,"forks":26,"fork":false,"size":22337,"owner":"lxcenter","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2011-09-17T19:46:39-07:00","pushed_at":"2013-09-10T09:22:56-07:00","master_branch":"master","organization":"lxcenter"},"actor_attributes":{"type":"User","name":"Danny Terweij","company":"LxCenter","blog":"www.lxcenter.org","location":"Netherlands","email":"[email protected]"},"url":"https://github.com/lxcenter/hypervm/pull/57#discussion_r6513339"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/macoslib/macoslib/pulls/comments/7879841","id":7879841,"diff_hunk":"@@ -153,14 +181,10 @@ Class CFType\n \t\t \n \t\t #if TargetMacOS\n \t\t \n-\t\t if ref = nil then\n+\t\t if ref.value = nil then\n \t\t return new CFType() // this gives a CFType object whose \"IsNULL()\" function returns true\n \t\t end if\n \t\t \n-\t\t if not hasOwnership then\n-\t\t Retain(ref)\n-\t\t hasOwnership = true\n-\t\t end if","path":"macoslib/CoreFoundation/CFType.rbbas","position":175,"original_position":176,"commit_id":"3c8bd4ae6962e5f894ed02e156f7c475497ada70","original_commit_id":"91a7cbe25fb8e4e8c121180630a8d2ab4295bf9d","user":{"login":"declaresub","id":31868,"avatar_url":"https://0.gravatar.com/avatar/5d68f9fe41bcf1fb5b9daaf5675f4081?d=https%3A%2F%2Fidenticons.github.com%2Fc732e4cb57268226f297e389d8382baf.png&r=x","gravatar_id":"5d68f9fe41bcf1fb5b9daaf5675f4081","url":"https://api.github.com/users/declaresub","html_url":"https://github.com/declaresub","followers_url":"https://api.github.com/users/declaresub/followers","following_url":"https://api.github.com/users/declaresub/following{/other_user}","gists_url":"https://api.github.com/users/declaresub/gists{/gist_id}","starred_url":"https://api.github.com/users/declaresub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/declaresub/subscriptions","organizations_url":"https://api.github.com/users/declaresub/orgs","repos_url":"https://api.github.com/users/declaresub/repos","events_url":"https://api.github.com/users/declaresub/events{/privacy}","received_events_url":"https://api.github.com/users/declaresub/received_events","type":"User","site_admin":false},"body":"\r\nOn Nov 24, 2013, at 2:23 PM, Thomas Tempelmann <[email protected]> wrote:\r\n\r\n> In macoslib/CoreFoundation/CFType.rbbas:\r\n> \r\n> > \t\t return new CFType() // this gives a CFType object whose \"IsNULL()\" function returns true\r\n> > \t\t end if\r\n> > \t\t \r\n> > -\t\t if not hasOwnership then\r\n> > -\t\t Retain(ref)\r\n> > -\t\t hasOwnership = true\r\n> > -\t\t end if\r\n> \r\n> I am only looking at the diff here, but it looks as if the Retain() code has been removed and the hasOwnership test is not existing any more!?\r\n> \r\n> —\r\n> Reply to this email directly or view it on GitHub.\r\n> \r\n\r\n\r\nI did get rid of the shared Retain method. The hasOwnership test still exists, though. The code in AdoptNoVerify now looks like (comments omitted)\r\n\r\n self.mRef = ref\r\n \r\n if not hasOwnership then\r\n self.Retain()\r\n end if","created_at":"2013-11-24T19:28:05Z","updated_at":"2013-11-24T19:28:05Z","html_url":"https://github.com/macoslib/macoslib/pull/115#discussion_r7879841","pull_request_url":"https://api.github.com/repos/macoslib/macoslib/pulls/115","_links":{"self":{"href":"https://api.github.com/repos/macoslib/macoslib/pulls/comments/7879841"},"html":{"href":"https://github.com/macoslib/macoslib/pull/115#discussion_r7879841"},"pull_request":{"href":"https://api.github.com/repos/macoslib/macoslib/pulls/115"}}}}

{"repository":{"description":"MacOSLib - a set of classes to use OS X specific functions in Real Studio / Xojo applications","homepage":"","watchers":17,"stargazers":17,"forks":14,"fork":false,"size":15909,"owner":"macoslib","private":false,"open_issues":6,"has_issues":true,"has_downloads":true,"has_wiki":true,"created_at":"2012-09-29T08:18:17-07:00","pushed_at":"2013-11-24T11:02:44-08:00","master_branch":"master","organization":"macoslib"},"actor_attributes":{"type":"User","name":"","blog":"http://www.declareSub.com","email":"[email protected]"},"url":"https://github.com/macoslib/macoslib/pull/115#discussion_r7879841"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/mulesoft/mule/pulls/comments/8364708","id":8364708,"diff_hunk":"@@ -0,0 +1,481 @@\n+/*\n+ * Copyright (c) MuleSoft, Inc. All rights reserved. http://www.mulesoft.com\n+ * The software in this package is published under the terms of the CPAL v1.0\n+ * license, a copy of which has been included with this distribution in the\n+ * LICENSE.txt file.\n+ */\n+package org.mule.module.launcher;\n+\n+import static org.mule.util.SplashScreen.miniSplash;\n+\n+import org.mule.config.i18n.MessageFactory;\n+import org.mule.module.launcher.artifact.Artifact;\n+import org.mule.module.launcher.artifact.ArtifactFactory;\n+import org.mule.module.launcher.util.ObservableList;\n+import org.mule.util.CollectionUtils;\n+import org.mule.util.FileUtils;\n+import org.mule.util.StringUtils;\n+\n+import java.io.File;\n+import java.io.IOException;\n+import java.net.MalformedURLException;\n+import java.net.URL;\n+import java.util.Collection;\n+import java.util.HashMap;\n+import java.util.Map;\n+import java.util.concurrent.TimeUnit;\n+import java.util.concurrent.locks.ReentrantLock;\n+\n+import org.apache.commons.beanutils.BeanPropertyValueEqualsPredicate;\n+import org.apache.commons.beanutils.BeanToPropertyValueTransformer;\n+import org.apache.commons.logging.Log;\n+import org.apache.commons.logging.LogFactory;\n+\n+/**\n+ * Deployer of an artifact within mule container.\n+ * - Keeps track of deployed artifacts\n+ * - Avoid already deployed artifacts to be redeployed\n+ * - Deploys, undeploys, redeploys packaged and exploded artifacts\n+ */\n+public class ArtifactDeployer<T extends Artifact>\n+{\n+\n+ public static final String ARTIFACT_NAME_PROPERTY = \"artifactName\";\n+ protected transient final Log logger = LogFactory.getLog(getClass());\n+ public static final String ZIP_FILE_SUFFIX = \".zip\";\n+ public static final String ANOTHER_DEPLOYMENT_OPERATION_IS_IN_PROGRESS = \"Another deployment operation is in progress\";\n+ public static final String INSTALL_OPERATION_HAS_BEEN_INTERRUPTED = \"Install operation has been interrupted\";\n+\n+ private Map<String, ZombieFile> artifactZombieMap = new HashMap<String, ZombieFile>();\n+ private File artifactDir;\n+ private ObservableList<T> artifacts;\n+ private DeploymentListener deploymentListener;\n+ private ReentrantLock deploymentInProgressLcok;\n+ protected MuleDeployer<T> deployer;\n+ protected ArtifactFactory<T> artifactFactory;\n+\n+ public ArtifactDeployer(DeploymentListener deploymentListener, MuleDeployer deployer, ArtifactFactory artifactFactory, ObservableList<T> artifacts, ReentrantLock lock)\n+ {\n+ this.deploymentListener = deploymentListener;\n+ this.deployer = deployer;\n+ this.artifactFactory = artifactFactory;\n+ this.artifacts = artifacts;\n+ this.deploymentInProgressLcok = lock;\n+ this.artifactDir = artifactFactory.getArtifactDir();\n+ }\n+\n+\n+ public void deployPackagedArtifact(String zip) throws Exception\n+ {\n+ URL url;\n+ File artifactZip;\n+\n+ final String artifactName = StringUtils.removeEnd(zip, ZIP_FILE_SUFFIX);\n+\n+ artifactZip = new File(artifactDir, zip);\n+ url = artifactZip.toURI().toURL();\n+\n+ ZombieFile zombieFile = artifactZombieMap.get(artifactName);\n+ if (zombieFile != null)\n+ {\n+ if (zombieFile.isFor(url) && !zombieFile.updatedZombieApp())\n+ {\n+ // Skips the file because it was already deployed with failure\n+ return;\n+ }\n+ }\n+\n+ // check if this artifact is running first, undeploy it then\n+ T artifact = (T) CollectionUtils.find(artifacts, new BeanPropertyValueEqualsPredicate(ARTIFACT_NAME_PROPERTY, artifactName));\n+ if (artifact != null)\n+ {\n+ undeploy(artifactName);\n+ }\n+\n+ deploy(url);\n+ }\n+\n+ public void deployExplodedArtifact(String artifactName) throws DeploymentException\n+ {\n+ @SuppressWarnings(\"rawtypes\")\n+ Collection<String> deployedAppNames = CollectionUtils.collect(artifacts, new BeanToPropertyValueTransformer(ARTIFACT_NAME_PROPERTY));\n+\n+ if (deployedAppNames.contains(artifactName) && (!artifactZombieMap.containsKey(artifactName)))\n+ {\n+ return;\n+ }\n+\n+ ZombieFile zombieFile = artifactZombieMap.get(artifactName);\n+\n+ if ((zombieFile != null) && (!zombieFile.updatedZombieApp()))\n+ {\n+ return;\n+ }\n+\n+ deployExplodedApp(artifactName);\n+ }\n+\n+ public Map<String, ZombieFile> getArtifactZombieMap()\n+ {\n+ return artifactZombieMap;\n+ }\n+\n+ private void deployExplodedApp(String addedApp) throws DeploymentException\n+ {\n+ if (logger.isInfoEnabled())\n+ {\n+ logger.info(\"================== New Exploded Artifact: \" + addedApp);\n+ }\n+\n+ T artifact;\n+ try\n+ {\n+ artifact = artifactFactory.createArtifact(addedApp);\n+\n+ // add to the list of known artifacts first to avoid deployment loop on failure\n+ onArtifactInstalled(artifact);\n+ }\n+ catch (Throwable t)\n+ {\n+ final File artifactDir1 = artifactDir;\n+ File artifactDir = new File(artifactDir1, addedApp);\n+\n+ addZombieFile(addedApp, artifactDir);\n+\n+ String msg = miniSplash(String.format(\"Failed to deploy exploded artifact: '%s', see below\", addedApp));\n+ logger.error(msg, t);\n+\n+ deploymentListener.onDeploymentFailure(addedApp, t);\n+\n+ if (t instanceof DeploymentException)\n+ {\n+ throw (DeploymentException) t;\n+ }\n+ else\n+ {\n+ msg = \"Failed to deploy artifact: \" + addedApp;\n+ throw new DeploymentException(MessageFactory.createStaticMessage(msg), t);\n+ }\n+ }\n+\n+ deployArtifact(artifact);\n+ }\n+\n+ protected void onArtifactInstalled(T a)\n+ {\n+ trackArtifact(a);\n+ }\n+\n+ public void undeploy(String artifactName)\n+ {\n+ if (artifactZombieMap.containsKey(artifactName))\n+ {\n+ return;\n+ }\n+ T artifact = (T) CollectionUtils.find(artifacts, new BeanPropertyValueEqualsPredicate(ARTIFACT_NAME_PROPERTY, artifactName));\n+ undeploy(artifact);\n+ }\n+\n+ public void deploy(URL artifactAchivedUrl) throws IOException\n+ {\n+ T artifact;\n+\n+ try\n+ {\n+ try\n+ {\n+ artifact = guardedInstallFrom(artifactAchivedUrl);\n+ trackArtifact(artifact);\n+ }\n+ catch (Throwable t)\n+ {\n+ File artifactArchive = new File(artifactAchivedUrl.toURI());\n+ String artifactName = StringUtils.removeEnd(artifactArchive.getName(), ZIP_FILE_SUFFIX);\n+\n+ //// error text has been created by the deployer already\n+ final String msg = miniSplash(String.format(\"Failed to deploy artifact '%s', see below\", artifactName));\n+ logger.error(msg, t);\n+\n+ addZombieFile(artifactName, artifactArchive);\n+\n+ deploymentListener.onDeploymentFailure(artifactName, t);\n+\n+ throw t;\n+ }\n+\n+ deployArtifact(artifact);\n+ }\n+ catch (Throwable t)\n+ {\n+ if (t instanceof DeploymentException)\n+ {\n+ // re-throw\n+ throw ((DeploymentException) t);\n+ }\n+\n+ final String msg = \"Failed to deploy from URL: \" + artifactAchivedUrl;\n+ throw new DeploymentException(MessageFactory.createStaticMessage(msg), t);\n+ }\n+ }\n+\n+ private void guardedDeploy(T artifact)\n+ {\n+ try\n+ {\n+ if (!deploymentInProgressLcok.tryLock(0, TimeUnit.SECONDS))\n+ {\n+ return;\n+ }\n+\n+ deployer.deploy(artifact);\n+ }\n+ catch (InterruptedException e)\n+ {\n+ Thread.currentThread().interrupt();\n+ }\n+ finally\n+ {\n+ if (deploymentInProgressLcok.isHeldByCurrentThread())\n+ {\n+ deploymentInProgressLcok.unlock();\n+ }\n+ }\n+ }\n+\n+ public void deployArtifact(T artifact) throws DeploymentException\n+ {\n+ try\n+ {\n+ deploymentListener.onDeploymentStart(artifact.getArtifactName());\n+ guardedDeploy(artifact);\n+ deploymentListener.onDeploymentSuccess(artifact.getArtifactName());\n+ artifactZombieMap.remove(artifact.getArtifactName());\n+ }\n+ catch (Throwable t)\n+ {\n+ // error text has been created by the deployer already\n+ String msg = miniSplash(String.format(\"Failed to deploy artifact '%s', see below\", artifact.getArtifactName()));\n+ logger.error(msg, t);\n+\n+ addZombieApp(artifact);\n+\n+ deploymentListener.onDeploymentFailure(artifact.getArtifactName(), t);\n+ if (t instanceof DeploymentException)\n+ {\n+ throw (DeploymentException) t;\n+ }\n+ else\n+ {\n+ msg = \"Failed to deploy artifact: \" + artifact.getArtifactName();\n+ throw new DeploymentException(MessageFactory.createStaticMessage(msg), t);\n+ }\n+ }\n+ }\n+\n+ protected void addZombieApp(Artifact artifact)\n+ {\n+ File resourceFile = artifact.getConfigResourcesFile()[0];\n+ ZombieFile zombieFile = new ZombieFile();\n+\n+ if (resourceFile.exists())\n+ {\n+ try\n+ {\n+ zombieFile.url = resourceFile.toURI().toURL();\n+ zombieFile.lastUpdated = resourceFile.lastModified();\n+\n+ artifactZombieMap.put(artifact.getArtifactName(), zombieFile);\n+ }\n+ catch (MalformedURLException e)\n+ {\n+ // Ignore resource\n+ }\n+ }\n+ }\n+\n+ protected void addZombieFile(String artifactName, File marker)\n+ {\n+ // no sync required as deploy operations are single-threaded\n+ if (marker == null)\n+ {\n+ return;\n+ }\n+\n+ if (!marker.exists())\n+ {\n+ return;\n+ }\n+\n+ try\n+ {\n+ long lastModified = marker.lastModified();\n+\n+ ZombieFile zombieFile = new ZombieFile();\n+ zombieFile.url = marker.toURI().toURL();\n+ zombieFile.lastUpdated = lastModified;\n+\n+ artifactZombieMap.put(artifactName, zombieFile);\n+ }\n+ catch (MalformedURLException e)\n+ {\n+ logger.debug(String.format(\"Failed to mark an exploded artifact [%s] as a zombie\", marker.getName()), e);\n+ }\n+ }\n+\n+ public T findArtifact(String artifactName)\n+ {\n+ return (T) CollectionUtils.find(artifacts, new BeanPropertyValueEqualsPredicate(ARTIFACT_NAME_PROPERTY, artifactName));\n+ }\n+\n+ private void trackArtifact(T artifact)\n+ {\n+ T previousArtifact = findArtifact(artifact.getArtifactName());\n+ artifacts.remove(previousArtifact);\n+\n+ artifacts.add(artifact);\n+ }\n+\n+ protected void undeploy(T artifact)\n+ {\n+ if (logger.isInfoEnabled())\n+ {\n+ logger.info(\"================== Request to Undeploy Artifact: \" + artifact.getArtifactName());\n+ }\n+\n+ try\n+ {\n+ deploymentListener.onUndeploymentStart(artifact.getArtifactName());\n+\n+ artifacts.remove(artifact);\n+ guardedUndeploy(artifact);\n+\n+ deploymentListener.onUndeploymentSuccess(artifact.getArtifactName());\n+ }\n+ catch (RuntimeException e)\n+ {\n+ deploymentListener.onUndeploymentFailure(artifact.getArtifactName(), e);\n+ throw e;\n+ }\n+ }\n+\n+ private T guardedInstallFrom(URL artifactUrl) throws IOException\n+ {\n+ try\n+ {\n+ if (!deploymentInProgressLcok.tryLock(0, TimeUnit.SECONDS))\n+ {\n+ throw new IOException(ANOTHER_DEPLOYMENT_OPERATION_IS_IN_PROGRESS);\n+ }\n+ return deployer.installFrom(artifactUrl);\n+ }\n+ catch (InterruptedException e)\n+ {\n+ Thread.currentThread().interrupt();\n+ throw new IOException(INSTALL_OPERATION_HAS_BEEN_INTERRUPTED);\n+ }\n+ finally\n+ {\n+ if (deploymentInProgressLcok.isHeldByCurrentThread())\n+ {\n+ deploymentInProgressLcok.unlock();\n+ }\n+ }\n+ }\n+\n+ private void guardedUndeploy(T artifact)\n+ {\n+ try\n+ {\n+ if (!deploymentInProgressLcok.tryLock(0, TimeUnit.SECONDS))\n+ {\n+ return;\n+ }\n+\n+ deployer.undeploy(artifact);\n+ }\n+ catch (InterruptedException e)\n+ {\n+ Thread.currentThread().interrupt();\n+ }\n+ finally\n+ {\n+ if (deploymentInProgressLcok.isHeldByCurrentThread())\n+ {\n+ deploymentInProgressLcok.unlock();\n+ }\n+ }\n+ }\n+\n+ public Map<URL, Long> getArtifactsZombieMap()\n+ {\n+ Map<URL, Long> result = new HashMap<URL, Long>();\n+\n+ for (String artifact : artifactZombieMap.keySet())\n+ {\n+ ZombieFile file = artifactZombieMap.get(artifact);\n+ result.put(file.url, file.lastUpdated);\n+ }\n+ return result;\n+ }\n+\n+ public void setDeployer(MuleDeployer deployer)","path":"modules/launcher/src/main/java/org/mule/module/launcher/ArtifactDeployer.java","position":421,"original_position":421,"commit_id":"a601e4d92b1e90c39b74a2ca4f05fda9f73c3789","original_commit_id":"a601e4d92b1e90c39b74a2ca4f05fda9f73c3789","user":{"login":"pablokraan","id":561399,"avatar_url":"https://gravatar.com/avatar/5abf2c7d2fee464413077859f5e0d1bf?d=https%3A%2F%2Fidenticons.github.com%2Fcc02ecf039fc2a1d0717c64d95b4bc64.png&r=x","gravatar_id":"5abf2c7d2fee464413077859f5e0d1bf","url":"https://api.github.com/users/pablokraan","html_url":"https://github.com/pablokraan","followers_url":"https://api.github.com/users/pablokraan/followers","following_url":"https://api.github.com/users/pablokraan/following{/other_user}","gists_url":"https://api.github.com/users/pablokraan/gists{/gist_id}","starred_url":"https://api.github.com/users/pablokraan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pablokraan/subscriptions","organizations_url":"https://api.github.com/users/pablokraan/orgs","repos_url":"https://api.github.com/users/pablokraan/repos","events_url":"https://api.github.com/users/pablokraan/events{/privacy}","received_events_url":"https://api.github.com/users/pablokraan/received_events","type":"User","site_admin":false},"body":"Deployer is also injected on constructor. Maybe you forgot to remove it form there?","created_at":"2013-12-16T12:10:57Z","updated_at":"2013-12-16T12:10:57Z","html_url":"https://github.com/mulesoft/mule/pull/221#discussion_r8364708","pull_request_url":"https://api.github.com/repos/mulesoft/mule/pulls/221","_links":{"self":{"href":"https://api.github.com/repos/mulesoft/mule/pulls/comments/8364708"},"html":{"href":"https://github.com/mulesoft/mule/pull/221#discussion_r8364708"},"pull_request":{"href":"https://api.github.com/repos/mulesoft/mule/pulls/221"}}}}

{"repository":{"description":"Mule Community Edition","watchers":64,"stargazers":64,"forks":107,"fork":false,"size":241810,"owner":"mulesoft","private":false,"open_issues":15,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2012-12-07T11:23:06-08:00","pushed_at":"2013-12-13T14:50:24-08:00","master_branch":"mule-3.x","organization":"mulesoft"},"actor_attributes":{"type":"User","name":"Pablo Kraan","company":"Mulesoft","location":"Argentina","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mulesoft/mule/pull/221#discussion_r8364708"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/openSUSE/aaa_base/pulls/comments/6633838","id":6633838,"body":"Oh ok. Right, the u+ on this Debian unstable system I have at $orkplace has it, but it’s new.\r\n\r\nAnyway, no complaints here ;_)","diff_hunk":"@@ -28,6 +28,8 @@ if test -z \"$is\" ; then\n */ksh)\tis=ksh ;;\n */ksh93)\tis=ksh ;;\n */pdksh)\tis=ksh ;;\n+ */mksh)\tis=ksh ;;","path":"files/etc/bash.bashrc","position":4,"original_position":4,"commit_id":"b820efb7f0c481b03184125ef7708b0134411e40","original_commit_id":"b820efb7f0c481b03184125ef7708b0134411e40","user":{"login":"mirabilos","id":861078,"avatar_url":"https://2.gravatar.com/avatar/4a1f42a59e40446158ce872818a963a3?d=https%3A%2F%2Fidenticons.github.com%2F4474cf619f759e760d980f9a0727860b.png","gravatar_id":"4a1f42a59e40446158ce872818a963a3","url":"https://api.github.com/users/mirabilos","html_url":"https://github.com/mirabilos","followers_url":"https://api.github.com/users/mirabilos/followers","following_url":"https://api.github.com/users/mirabilos/following{/other_user}","gists_url":"https://api.github.com/users/mirabilos/gists{/gist_id}","starred_url":"https://api.github.com/users/mirabilos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirabilos/subscriptions","organizations_url":"https://api.github.com/users/mirabilos/orgs","repos_url":"https://api.github.com/users/mirabilos/repos","events_url":"https://api.github.com/users/mirabilos/events{/privacy}","received_events_url":"https://api.github.com/users/mirabilos/received_events","type":"User"},"created_at":"2013-09-27T17:31:41Z","updated_at":"2013-09-27T17:31:41Z","html_url":"https://github.com/openSUSE/aaa_base/pull/8#discussion_r6633838","pull_request_url":"https://api.github.com/repos/openSUSE/aaa_base/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/openSUSE/aaa_base/pulls/comments/6633838"},"html":{"href":"https://github.com/openSUSE/aaa_base/pull/8#discussion_r6633838"},"pull_request":{"href":"https://api.github.com/repos/openSUSE/aaa_base/pulls/8"}}}}

{"repository":{"description":"Files for the openSUSE package aaa_base (http://build.opensuse.org/package/show?package=aaa_base&project=Base:System)","watchers":0,"stargazers":0,"forks":6,"fork":false,"size":4589,"owner":"openSUSE","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Shell","created_at":"2012-11-05T01:16:49-08:00","pushed_at":"2013-09-27T00:39:27-07:00","master_branch":"master","organization":"openSUSE"},"actor_attributes":{"type":"User","blog":"https://www.mirbsd.org/jupp.htm","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/openSUSE/aaa_base/pull/8#discussion_r6633838"}

PullRequestReviewCommentEvent

{"comment":{"_links":{"html":{"href":"https://github.com/openSUSE/zypper/pull/29#discussion_r2806344"},"self":{"href":"https://api.github.com/repos/openSUSE/zypper/pulls/comments/2806344"},"pull_request":{"href":"https://api.github.com/repos/openSUSE/zypper/pulls/29"}},"user":{"gravatar_id":"b82d2964275747add35e4e44b2d2ab2a","url":"https://api.github.com/users/gabi2","type":"User","starred_url":"https://api.github.com/users/gabi2/starred{/owner}{/repo}","following_url":"https://api.github.com/users/gabi2/following","subscriptions_url":"https://api.github.com/users/gabi2/subscriptions","gists_url":"https://api.github.com/users/gabi2/gists{/gist_id}","login":"gabi2","received_events_url":"https://api.github.com/users/gabi2/received_events","events_url":"https://api.github.com/users/gabi2/events{/privacy}","repos_url":"https://api.github.com/users/gabi2/repos","organizations_url":"https://api.github.com/users/gabi2/orgs","avatar_url":"https://secure.gravatar.com/avatar/b82d2964275747add35e4e44b2d2ab2a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","id":1658828,"followers_url":"https://api.github.com/users/gabi2/followers"},"url":"https://api.github.com/repos/openSUSE/zypper/pulls/comments/2806344","commit_id":"368df50fea69a25219b79fda119dfb84d15282c8","body":"The reason for disabling the name attribute together with dependencies was, that with it the result was a list of all available packages. ","updated_at":"2013-01-29T09:40:09Z","position":87,"original_position":87,"path":"src/Zypper.cc","created_at":"2013-01-29T09:40:09Z","id":2806344,"original_commit_id":"ae41409348ee14a7666e0bdda8528810372bace4"}}

{"repository":{"stargazers":11,"owner":"openSUSE","has_issues":true,"has_downloads":true,"open_issues":4,"organization":"openSUSE","homepage":"http://en.opensuse.org/Portal:Zypper","has_wiki":true,"fork":false,"size":424,"created_at":"2011-07-29T03:21:40-07:00","description":"World's most powerful command line package manager","watchers":11,"private":false,"pushed_at":"2013-01-24T02:58:48-08:00","forks":7,"language":"C++"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/openSUSE/zypper/pull/29#discussion_r2806344"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/opennode/opennode-tui/pulls/comments/3392024","id":3392024,"body":"We are so bleeding edge :)","diff_hunk":"@@ -414,7 +414,7 @@ def save_as_ovf(vm_settings, storage_pool, unpack=True):\n log.info(msg)\n print msg\n arch_location = path.join(config.getstring('general', 'storage-endpoint'), storage_pool, \"kvm\")\n- ovf_archive_fnm = path.join(arch_location, \"%s.tar\" % vm_settings[\"template_name\"])\n+ ovf_archive_fnm = path.join(arch_location, \"%s.ova\" % vm_settings[\"template_name\"])","path":"opennode/cli/actions/vm/kvm.py","position":14,"original_position":14,"commit_id":"e5948b0226b0b26d9efce84bb29a6f9a0edaabff","original_commit_id":"e5948b0226b0b26d9efce84bb29a6f9a0edaabff","user":{"login":"livenson","id":524168,"avatar_url":"https://secure.gravatar.com/avatar/bd4a31901b1d236156d30fcc8cd58b59?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"bd4a31901b1d236156d30fcc8cd58b59","url":"https://api.github.com/users/livenson","html_url":"https://github.com/livenson","followers_url":"https://api.github.com/users/livenson/followers","following_url":"https://api.github.com/users/livenson/following","gists_url":"https://api.github.com/users/livenson/gists{/gist_id}","starred_url":"https://api.github.com/users/livenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livenson/subscriptions","organizations_url":"https://api.github.com/users/livenson/orgs","repos_url":"https://api.github.com/users/livenson/repos","events_url":"https://api.github.com/users/livenson/events{/privacy}","received_events_url":"https://api.github.com/users/livenson/received_events","type":"User"},"created_at":"2013-03-15T14:40:18Z","updated_at":"2013-03-15T14:40:18Z","html_url":"https://github.com/opennode/opennode-tui/pull/109#discussion_r3392024","pull_request_url":"https://api.github.com/repos/opennode/opennode-tui/pulls/109","_links":{"self":{"href":"https://api.github.com/repos/opennode/opennode-tui/pulls/comments/3392024"},"html":{"href":"https://github.com/opennode/opennode-tui/pull/109#discussion_r3392024"},"pull_request":{"href":"https://api.github.com/repos/opennode/opennode-tui/pulls/109"}}}}

{"repository":{"description":"OpenNode Textual User Interface (TUI)","homepage":"http://www.opennodecloud.com","watchers":7,"stargazers":7,"forks":3,"fork":false,"size":464,"owner":"opennode","private":false,"open_issues":30,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2011-09-06T06:10:29-07:00","pushed_at":"2013-03-15T05:56:15-07:00","master_branch":"master","organization":"opennode"},"actor_attributes":{"type":"User","name":"Ilja Livenson","location":"Estonia","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/opennode/opennode-tui/pull/109#discussion_r3392024"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/5828781","id":5828781,"body":"Typehint view?","diff_hunk":"@@ -568,4 +563,20 @@ private static function delOldVersions($versionsByFile, &$allVersions, $versions\n \t\treturn $size;\n \t}\n \n+\t/**\n+\t * @brief create recursively missing directories\n+\t * @param string $filename $path to a file\n+\t */\n+\tprivate static function createMissingDirectories($filename, $view) {","path":"apps/files_versions/lib/versions.php","position":106,"original_position":106,"commit_id":"f71794f0d5a09686e2bcf1a5b6ec0b19076a43e5","original_commit_id":"f71794f0d5a09686e2bcf1a5b6ec0b19076a43e5","user":{"login":"bantu","id":189375,"avatar_url":"https://1.gravatar.com/avatar/88483d87947219efecfc570465c753b2?d=https%3A%2F%2Fidenticons.github.com%2Fcdc48f189c0e2e8a870f3d54615a2f0d.png","gravatar_id":"88483d87947219efecfc570465c753b2","url":"https://api.github.com/users/bantu","html_url":"https://github.com/bantu","followers_url":"https://api.github.com/users/bantu/followers","following_url":"https://api.github.com/users/bantu/following{/other_user}","gists_url":"https://api.github.com/users/bantu/gists{/gist_id}","starred_url":"https://api.github.com/users/bantu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bantu/subscriptions","organizations_url":"https://api.github.com/users/bantu/orgs","repos_url":"https://api.github.com/users/bantu/repos","events_url":"https://api.github.com/users/bantu/events{/privacy}","received_events_url":"https://api.github.com/users/bantu/received_events","type":"User"},"created_at":"2013-08-17T11:42:03Z","updated_at":"2013-08-17T11:42:03Z","html_url":"https://github.com/owncloud/core/pull/4427#discussion_r5828781","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/4427","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/5828781"},"html":{"href":"https://github.com/owncloud/core/pull/4427#discussion_r5828781"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/4427"}}}}

{"repository":{"description":"The ownCloud core","watchers":1258,"stargazers":1258,"forks":414,"fork":false,"size":119179,"owner":"owncloud","private":false,"open_issues":549,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2012-08-25T03:32:48-07:00","pushed_at":"2013-08-17T04:40:03-07:00","master_branch":"master","organization":"owncloud"},"actor_attributes":{"type":"User","name":"Andreas Fischer","blog":"http://www.andreasfischer.net","location":"Karlsruhe, Germany","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/owncloud/core/pull/4427#discussion_r5828781"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/owncloud/core/pulls/comments/6083788","id":6083788,"body":"cruft","diff_hunk":"@@ -84,6 +87,7 @@\n $tmpl->assign('displayNameChangeSupported', OC_User::canUserChangeDisplayName(OC_User::getUser()));\n $tmpl->assign('displayName', OC_User::getDisplayName());\n $tmpl->assign('enableDecryptAll' , $enableDecryptAll);\n+$tmpl->assign('avatar', OC_Config::getValue('avatar', 'local'));","path":"settings/personal.php","position":14,"original_position":14,"commit_id":"ecf187393becc7dc613b4fd1322e40eb58f9f0fd","original_commit_id":"ecf187393becc7dc613b4fd1322e40eb58f9f0fd","user":{"login":"Kondou-ger","id":1410802,"avatar_url":"https://1.gravatar.com/avatar/917dab919ae812f8252b2f501c514b19?d=https%3A%2F%2Fidenticons.github.com%2Fd07869ed62cb1b7f88b731956ab913ee.png","gravatar_id":"917dab919ae812f8252b2f501c514b19","url":"https://api.github.com/users/Kondou-ger","html_url":"https://github.com/Kondou-ger","followers_url":"https://api.github.com/users/Kondou-ger/followers","following_url":"https://api.github.com/users/Kondou-ger/following{/other_user}","gists_url":"https://api.github.com/users/Kondou-ger/gists{/gist_id}","starred_url":"https://api.github.com/users/Kondou-ger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kondou-ger/subscriptions","organizations_url":"https://api.github.com/users/Kondou-ger/orgs","repos_url":"https://api.github.com/users/Kondou-ger/repos","events_url":"https://api.github.com/users/Kondou-ger/events{/privacy}","received_events_url":"https://api.github.com/users/Kondou-ger/received_events","type":"User"},"created_at":"2013-08-30T11:11:23Z","updated_at":"2013-08-30T11:11:23Z","html_url":"https://github.com/owncloud/core/pull/4506#discussion_r6083788","pull_request_url":"https://api.github.com/repos/owncloud/core/pulls/4506","_links":{"self":{"href":"https://api.github.com/repos/owncloud/core/pulls/comments/6083788"},"html":{"href":"https://github.com/owncloud/core/pull/4506#discussion_r6083788"},"pull_request":{"href":"https://api.github.com/repos/owncloud/core/pulls/4506"}}}}

{"repository":{"description":"The ownCloud core","watchers":1317,"stargazers":1317,"forks":429,"fork":false,"size":173495,"owner":"owncloud","private":false,"open_issues":594,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2012-08-25T03:32:48-07:00","pushed_at":"2013-08-30T04:02:39-07:00","master_branch":"master","organization":"owncloud"},"actor_attributes":{"type":"User","name":"Christopher","blog":"ts.unde.re","location":"Germany","email":"[email protected]"},"url":"https://github.com/owncloud/core/pull/4506#discussion_r6083788"}

PullRequestReviewCommentEvent

{"comment":{"_links":{"self":{"href":"https://api.github.com/repos/phpbb-de/quickinstall/pulls/comments/2710914"},"html":{"href":"https://github.com/phpbb-de/quickinstall/pull/3#discussion_r2710914"},"pull_request":{"href":"https://api.github.com/repos/phpbb-de/quickinstall/pulls/3"}},"url":"https://api.github.com/repos/phpbb-de/quickinstall/pulls/comments/2710914","original_position":254,"created_at":"2013-01-21T11:02:54Z","body":"lol","position":254,"updated_at":"2013-01-21T11:02:54Z","commit_id":"92310d6f534bf3252bb4bd9eaa8aa4f1c4b47d43","original_commit_id":"92310d6f534bf3252bb4bd9eaa8aa4f1c4b47d43","path":"language/de_x_sie/qi.php","user":{"subscriptions_url":"https://api.github.com/users/bantu/subscriptions","url":"https://api.github.com/users/bantu","type":"User","received_events_url":"https://api.github.com/users/bantu/received_events","starred_url":"https://api.github.com/users/bantu/starred{/owner}{/repo}","login":"bantu","followers_url":"https://api.github.com/users/bantu/followers","events_url":"https://api.github.com/users/bantu/events{/privacy}","organizations_url":"https://api.github.com/users/bantu/orgs","id":189375,"following_url":"https://api.github.com/users/bantu/following","avatar_url":"https://secure.gravatar.com/avatar/88483d87947219efecfc570465c753b2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"88483d87947219efecfc570465c753b2","gists_url":"https://api.github.com/users/bantu/gists{/gist_id}","repos_url":"https://api.github.com/users/bantu/repos"},"id":2710914}}

{"repository":{"owner":"phpbb-de","has_downloads":true,"pushed_at":"2012-12-31T04:21:02-08:00","forks":1,"organization":"phpbb-de","has_wiki":false,"created_at":"2012-11-19T18:15:36-08:00","master_branch":"intl-de","homepage":"","fork":true,"size":208,"open_issues":2,"watchers":0,"private":false,"has_issues":false,"description":"German Translation of QuickInstall | Send pull requests for the german language to this repository. ","stargazers":0,"language":"PHP"},"actor_attributes":{"location":"Karlsruhe, Germany","type":"User","blog":"http://www.andreasfischer.net","name":"Andreas Fischer","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/phpbb-de/quickinstall/pull/3#discussion_r2710914"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/praekelt/vumi-go/pulls/comments/6181001","id":6181001,"body":"Hmm. Maybe I'd be happier if VumiApi just had a class variable called \"_on_create\" that was set to \"None\" and was overridden by tests. That seems to be a fairly common sort of idiom in Twisted.","diff_hunk":"@@ -515,6 +515,11 @@ def __init__(self, manager, redis, sender=None):\n self.session_manager = SessionManager(\n self.redis.sub_manager('session_manager'))\n self.mapi = sender\n+ self._persist_collect_hook(self)\n+\n+ def _persist_collect_hook(self, vumi_api):\n+ # This allows us to collect riak/redis managers for cleanup in tests.\n+ pass","path":"go/vumitools/api.py","position":8,"original_position":8,"commit_id":"dc85258a35bb99cbcede3ab3bad09bc5ba859ce8","original_commit_id":"03fc7a007f11c8ff94d5e13af52c6fd19afc4f1d","user":{"login":"hodgestar","id":165551,"avatar_url":"https://1.gravatar.com/avatar/337cadae5be17c19e2defb615d7de9f8?d=https%3A%2F%2Fidenticons.github.com%2Fad0c17a89c56731630582f6a2b95c044.png","gravatar_id":"337cadae5be17c19e2defb615d7de9f8","url":"https://api.github.com/users/hodgestar","html_url":"https://github.com/hodgestar","followers_url":"https://api.github.com/users/hodgestar/followers","following_url":"https://api.github.com/users/hodgestar/following{/other_user}","gists_url":"https://api.github.com/users/hodgestar/gists{/gist_id}","starred_url":"https://api.github.com/users/hodgestar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hodgestar/subscriptions","organizations_url":"https://api.github.com/users/hodgestar/orgs","repos_url":"https://api.github.com/users/hodgestar/repos","events_url":"https://api.github.com/users/hodgestar/events{/privacy}","received_events_url":"https://api.github.com/users/hodgestar/received_events","type":"User"},"created_at":"2013-09-05T13:27:31Z","updated_at":"2013-09-05T13:27:31Z","html_url":"https://github.com/praekelt/vumi-go/pull/690#discussion_r6181001","pull_request_url":"https://api.github.com/repos/praekelt/vumi-go/pulls/690","_links":{"self":{"href":"https://api.github.com/repos/praekelt/vumi-go/pulls/comments/6181001"},"html":{"href":"https://github.com/praekelt/vumi-go/pull/690#discussion_r6181001"},"pull_request":{"href":"https://api.github.com/repos/praekelt/vumi-go/pulls/690"}}}}

{"repository":{"description":"","homepage":"","watchers":7,"stargazers":7,"forks":2,"fork":false,"size":7992,"owner":"praekelt","private":false,"open_issues":62,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-06-24T01:46:21-07:00","pushed_at":"2013-09-05T05:42:43-07:00","master_branch":"develop","organization":"praekelt"},"actor_attributes":{"type":"User","name":"Simon Cross","company":"Praekelt Foundation","blog":"hodgestar.za.net","location":"Cape Town, South Africa","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/praekelt/vumi-go/pull/690#discussion_r6181001"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/refinery/refinerycms/pulls/comments/5852826","id":5852826,"body":"Yeah I meant `except` - thanks!\r\n\r\nNo need to open new PR because you can update current one by just force pushing to your branch after you have made changes locally.","diff_hunk":"@@ -225,7 +225,7 @@ module Refinery\n module Admin\n class EventsController < ::Refinery::AdminController\n \n- before_filter :find_all_event_types, :only => [:show]","path":"doc/guides/4 - Refinery Extensions/5 - Relating Resources in an Extension.textile","position":13,"original_position":13,"commit_id":"5811f2e479e9cc35ae02b939d0e36e7db1f66df0","original_commit_id":"5811f2e479e9cc35ae02b939d0e36e7db1f66df0","user":{"login":"ugisozols","id":148708,"avatar_url":"https://0.gravatar.com/avatar/5cba606090e5f29f910274796748f20a?d=https%3A%2F%2Fidenticons.github.com%2Fc2f2c5bea08415228284d7e51461a137.png","gravatar_id":"5cba606090e5f29f910274796748f20a","url":"https://api.github.com/users/ugisozols","html_url":"https://github.com/ugisozols","followers_url":"https://api.github.com/users/ugisozols/followers","following_url":"https://api.github.com/users/ugisozols/following{/other_user}","gists_url":"https://api.github.com/users/ugisozols/gists{/gist_id}","starred_url":"https://api.github.com/users/ugisozols/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ugisozols/subscriptions","organizations_url":"https://api.github.com/users/ugisozols/orgs","repos_url":"https://api.github.com/users/ugisozols/repos","events_url":"https://api.github.com/users/ugisozols/events{/privacy}","received_events_url":"https://api.github.com/users/ugisozols/received_events","type":"User"},"created_at":"2013-08-19T20:11:47Z","updated_at":"2013-08-19T20:11:47Z","html_url":"https://github.com/refinery/refinerycms/pull/2385#discussion_r5852826","pull_request_url":"https://api.github.com/repos/refinery/refinerycms/pulls/2385","_links":{"self":{"href":"https://api.github.com/repos/refinery/refinerycms/pulls/comments/5852826"},"html":{"href":"https://github.com/refinery/refinerycms/pull/2385#discussion_r5852826"},"pull_request":{"href":"https://api.github.com/repos/refinery/refinerycms/pulls/2385"}}}}

{"repository":{"description":"An extendable Ruby on Rails CMS that supports Rails 3.2","homepage":"http://refinerycms.com/guides/","watchers":2734,"stargazers":2734,"forks":999,"fork":false,"size":31649,"owner":"refinery","private":false,"open_issues":21,"has_issues":true,"has_downloads":false,"has_wiki":true,"language":"Ruby","created_at":"2009-05-28T13:13:21-07:00","pushed_at":"2013-08-18T08:35:01-07:00","integrate_branch":"master","master_branch":"master","organization":"refinery"},"actor_attributes":{"type":"User","name":"Uģis Ozols","blog":"http://ugisozols.com","location":"Latvia","email":"[email protected]"},"url":"https://github.com/refinery/refinerycms/pull/2385#discussion_r5852826"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/rubinius/rubinius/pulls/comments/5844760","id":5844760,"body":"Does this raise the correct error type or should it be more descriptive?","diff_hunk":"@@ -39,6 +39,7 @@ def StringValue(obj)\n \n def FloatValue(obj)\n begin\n+ raise if obj.kind_of?(String)","path":"kernel/common/kernel.rb","position":4,"original_position":4,"commit_id":"f337ba8dd56d599a0d9e9f01a95cfd8a35531897","original_commit_id":"f337ba8dd56d599a0d9e9f01a95cfd8a35531897","user":{"login":"dbussink","id":7851,"avatar_url":"https://2.gravatar.com/avatar/b012094b37ab6946c44eaa41d7828478?d=https%3A%2F%2Fidenticons.github.com%2F47951a40efc0d2f7da8ff1ecbfde80f4.png","gravatar_id":"b012094b37ab6946c44eaa41d7828478","url":"https://api.github.com/users/dbussink","html_url":"https://github.com/dbussink","followers_url":"https://api.github.com/users/dbussink/followers","following_url":"https://api.github.com/users/dbussink/following{/other_user}","gists_url":"https://api.github.com/users/dbussink/gists{/gist_id}","starred_url":"https://api.github.com/users/dbussink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbussink/subscriptions","organizations_url":"https://api.github.com/users/dbussink/orgs","repos_url":"https://api.github.com/users/dbussink/repos","events_url":"https://api.github.com/users/dbussink/events{/privacy}","received_events_url":"https://api.github.com/users/dbussink/received_events","type":"User"},"created_at":"2013-08-19T15:19:07Z","updated_at":"2013-08-19T15:19:07Z","html_url":"https://github.com/rubinius/rubinius/pull/2565#discussion_r5844760","pull_request_url":"https://api.github.com/repos/rubinius/rubinius/pulls/2565","_links":{"self":{"href":"https://api.github.com/repos/rubinius/rubinius/pulls/comments/5844760"},"html":{"href":"https://github.com/rubinius/rubinius/pull/2565#discussion_r5844760"},"pull_request":{"href":"https://api.github.com/repos/rubinius/rubinius/pulls/2565"}}}}

{"repository":{"description":"Rubinius, the Ruby Environment","homepage":"http://github.com/rubinius/rubinius","watchers":1803,"stargazers":1803,"forks":467,"fork":false,"size":160199,"owner":"rubinius","private":false,"open_issues":87,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2008-01-12T08:46:52-08:00","pushed_at":"2013-08-19T07:03:28-07:00","master_branch":"master","organization":"rubinius"},"actor_attributes":{"type":"User","name":"Dirkjan Bussink","company":"CriticalCodes","blog":"http://www.criticalcodes.com","location":"Enschede","email":"[email protected]"},"url":"https://github.com/rubinius/rubinius/pull/2565#discussion_r5844760"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/sailthru/sailthru-ruby-client/pulls/comments/6954745","id":6954745,"diff_hunk":"@@ -676,38 +676,38 @@ def process_job(job, options = {}, report_email = nil, postback_url = nil, binar\n # params\n # emails, String | Array\n # implementation for import_job \n- def process_import_job(list, emails, report_email = nil, postback_url = nil)\n- data = {}\n+ def process_import_job(list, emails, report_email = nil, postback_url = nil, options = {})","path":"lib/sailthru.rb","position":6,"original_position":6,"commit_id":"bcdb2adc771227f18849a31558fbaefac2320647","original_commit_id":"bcdb2adc771227f18849a31558fbaefac2320647","user":{"login":"sinneduy","id":1448225,"avatar_url":"https://0.gravatar.com/avatar/cc49ab5321074b6483235d107d7e50a7?d=https%3A%2F%2Fidenticons.github.com%2Fba02e8585ac5b93c2b8682b094b72950.png","gravatar_id":"cc49ab5321074b6483235d107d7e50a7","url":"https://api.github.com/users/sinneduy","html_url":"https://github.com/sinneduy","followers_url":"https://api.github.com/users/sinneduy/followers","following_url":"https://api.github.com/users/sinneduy/following{/other_user}","gists_url":"https://api.github.com/users/sinneduy/gists{/gist_id}","starred_url":"https://api.github.com/users/sinneduy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sinneduy/subscriptions","organizations_url":"https://api.github.com/users/sinneduy/orgs","repos_url":"https://api.github.com/users/sinneduy/repos","events_url":"https://api.github.com/users/sinneduy/events{/privacy}","received_events_url":"https://api.github.com/users/sinneduy/received_events","type":"User","site_admin":false},"body":"Sorry, but isn't this specific to python?","created_at":"2013-10-14T20:33:11Z","updated_at":"2013-10-14T20:33:11Z","html_url":"https://github.com/sailthru/sailthru-ruby-client/pull/37#discussion_r6954745","pull_request_url":"https://api.github.com/repos/sailthru/sailthru-ruby-client/pulls/37","_links":{"self":{"href":"https://api.github.com/repos/sailthru/sailthru-ruby-client/pulls/comments/6954745"},"html":{"href":"https://github.com/sailthru/sailthru-ruby-client/pull/37#discussion_r6954745"},"pull_request":{"href":"https://api.github.com/repos/sailthru/sailthru-ruby-client/pulls/37"}}}}

{"repository":{"description":"sailthru ruby client","homepage":"http://docs.sailthru.com","watchers":16,"stargazers":16,"forks":20,"fork":false,"size":393,"owner":"sailthru","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2011-01-18T14:12:01-08:00","pushed_at":"2013-10-14T12:42:23-07:00","master_branch":"master","organization":"sailthru"},"actor_attributes":{"type":"User","name":"Dennis Yu","company":"Sailthru","location":"New York","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/sailthru/sailthru-ruby-client/pull/37#discussion_r6954745"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/sonatype/security/pulls/comments/3460380","id":3460380,"body":"@since for new pulblic api","diff_hunk":"@@ -0,0 +1,28 @@\n+/*\n+ * Copyright (c) 2007-2013 Sonatype, Inc. All rights reserved.\n+ *\n+ * This program is licensed to you under the Apache License Version 2.0,\n+ * and you may not use this file except in compliance with the Apache License Version 2.0.\n+ * You may obtain a copy of the Apache License Version 2.0 at http://www.apache.org/licenses/LICENSE-2.0.\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the Apache License Version 2.0 is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the Apache License Version 2.0 for the specific language governing permissions and limitations there under.\n+ */\n+package org.sonatype.security.configuration.upgrade;\n+\n+import org.sonatype.configuration.upgrade.ConfigurationUpgrader;\n+import org.sonatype.security.configuration.model.SecurityConfiguration;\n+\n+/**\n+ * Defines a type for upgraders of security-configuration.xml.\n+ * This is only used if an old version is detected and needs to be upgraded\n+ * \n+ * @author Steve Carlucci\n+ */\n+public interface SecurityConfigurationUpgrader","path":"security-configuration/src/main/java/org/sonatype/security/configuration/upgrade/SecurityConfigurationUpgrader.java","position":24,"original_position":24,"commit_id":"e853f28e87e352b34e51e915b0217bcf989fbb81","original_commit_id":"e853f28e87e352b34e51e915b0217bcf989fbb81","user":{"login":"jdillon","id":20114,"avatar_url":"https://secure.gravatar.com/avatar/5f8fecf073c59b12605ed2a364cf1406?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"5f8fecf073c59b12605ed2a364cf1406","url":"https://api.github.com/users/jdillon","html_url":"https://github.com/jdillon","followers_url":"https://api.github.com/users/jdillon/followers","following_url":"https://api.github.com/users/jdillon/following","gists_url":"https://api.github.com/users/jdillon/gists{/gist_id}","starred_url":"https://api.github.com/users/jdillon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdillon/subscriptions","organizations_url":"https://api.github.com/users/jdillon/orgs","repos_url":"https://api.github.com/users/jdillon/repos","events_url":"https://api.github.com/users/jdillon/events{/privacy}","received_events_url":"https://api.github.com/users/jdillon/received_events","type":"User"},"created_at":"2013-03-20T21:42:18Z","updated_at":"2013-03-20T21:42:18Z","html_url":"https://github.com/sonatype/security/pull/25#discussion_r3460380","pull_request_url":"https://api.github.com/repos/sonatype/security/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/sonatype/security/pulls/comments/3460380"},"html":{"href":"https://github.com/sonatype/security/pull/25#discussion_r3460380"},"pull_request":{"href":"https://api.github.com/repos/sonatype/security/pulls/25"}}}}

{"repository":{"description":"","homepage":"","watchers":5,"stargazers":5,"forks":2,"fork":false,"size":232,"owner":"sonatype","private":false,"open_issues":2,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2010-05-13T05:58:14-07:00","pushed_at":"2013-03-20T14:12:48-07:00","master_branch":"master","organization":"sonatype"},"actor_attributes":{"type":"User","name":"Jason Dillon","blog":"http://avidcracksmoker.com","location":"San Jose, CA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/sonatype/security/pull/25#discussion_r3460380"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/stackmob/stackmob-js-sdk/pulls/comments/3593012","id":3593012,"body":"it's in login() twice, so I removed this one","diff_hunk":"@@ -1236,8 +1278,8 @@\n \n options['data'] = options['data'] || {};\n \n- options['data'][StackMob.loginField] = this.get(StackMob.loginField);","path":"stackmob.js","position":552,"original_position":323,"commit_id":"c042001eac34f0950075a5edd29c22070f39aef1","original_commit_id":"9573412e610ca1e74b66a410a9098c72f86409f7","user":{"login":"ericktai","id":324507,"avatar_url":"https://secure.gravatar.com/avatar/75500930d2ec95d7dc47bdf16c2923f0?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"75500930d2ec95d7dc47bdf16c2923f0","url":"https://api.github.com/users/ericktai","html_url":"https://github.com/ericktai","followers_url":"https://api.github.com/users/ericktai/followers","following_url":"https://api.github.com/users/ericktai/following","gists_url":"https://api.github.com/users/ericktai/gists{/gist_id}","starred_url":"https://api.github.com/users/ericktai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericktai/subscriptions","organizations_url":"https://api.github.com/users/ericktai/orgs","repos_url":"https://api.github.com/users/ericktai/repos","events_url":"https://api.github.com/users/ericktai/events{/privacy}","received_events_url":"https://api.github.com/users/ericktai/received_events","type":"User"},"created_at":"2013-03-29T23:20:59Z","updated_at":"2013-03-29T23:20:59Z","html_url":"https://github.com/stackmob/stackmob-js-sdk/pull/45#discussion_r3593012","pull_request_url":"https://api.github.com/repos/stackmob/stackmob-js-sdk/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/stackmob/stackmob-js-sdk/pulls/comments/3593012"},"html":{"href":"https://github.com/stackmob/stackmob-js-sdk/pull/45#discussion_r3593012"},"pull_request":{"href":"https://api.github.com/repos/stackmob/stackmob-js-sdk/pulls/45"}}}}

{"repository":{"description":"StackMob's Javascript SDK","watchers":20,"stargazers":20,"forks":11,"fork":false,"size":456,"owner":"stackmob","private":false,"open_issues":7,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-06-12T10:36:51-07:00","pushed_at":"2013-03-29T16:17:46-07:00","master_branch":"master","organization":"stackmob"},"actor_attributes":{"type":"User","name":"Erick Tai","company":"StackMob","blog":"http://www.stackmob.com","location":"San Francisco, CA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/stackmob/stackmob-js-sdk/pull/45#discussion_r3593012"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/stackmob/stackmob-customcode-example/pulls/comments/3788927","id":3788927,"body":"@cosileone return an error","diff_hunk":"@@ -0,0 +1,76 @@\n+/**\n+ * Copyright 2012-2013 StackMob\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package com.stackmob.example.util;\n+\n+import com.stackmob.core.customcode.CustomCodeMethod;\n+import com.stackmob.core.rest.ProcessedAPIRequest;\n+import com.stackmob.core.rest.ResponseToProcess;\n+import com.stackmob.sdkapi.SDKServiceProvider;\n+import com.stackmob.sdkapi.SMInt;\n+import com.stackmob.sdkapi.SMString;\n+import org.json.simple.JSONObject;\n+import org.json.simple.parser.JSONParser;\n+import org.json.simple.parser.ParseException;\n+\n+import java.net.HttpURLConnection;\n+import java.util.*;\n+\n+/**\n+ * This example will show a user how to read the parameters passed in from a JSON request body\n+ */\n+\n+public class ReadParams implements CustomCodeMethod {\n+\n+ @Override\n+ public String getMethodName() {\n+ return \"ReadParams\";\n+ }\n+\n+ @Override\n+ public List<String> getParams() {\n+ return Arrays.asList(\"model\", \"make\", \"year\");\n+ }\n+\n+ @Override\n+ public ResponseToProcess execute(ProcessedAPIRequest request, SDKServiceProvider serviceProvider) {\n+ String model = \"\";\n+ String make = \"\";\n+ String year = \"\";\n+\n+ JSONParser parser = new JSONParser();\n+\n+ try {\n+ Object obj = parser.parse(request.getBody());\n+ JSONObject jsonObject = (JSONObject) obj;\n+\n+ // Find the values you are looking for\n+ model = (String) jsonObject.get(\"model\");\n+ make = (String) jsonObject.get(\"make\");\n+ year = (String) jsonObject.get(\"year\");\n+ } catch (ParseException pe) {\n+ // Log your error","path":"java/src/main/java/com/stackmob/example/util/ReadParams.java","position":65,"original_position":65,"commit_id":"651f2f8317bbc5b5169b7267cd562def2ca71b68","original_commit_id":"651f2f8317bbc5b5169b7267cd562def2ca71b68","user":{"login":"taylorleese","id":202401,"avatar_url":"https://secure.gravatar.com/avatar/4374a176f51f309c5a49f44fd1d7a730?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"4374a176f51f309c5a49f44fd1d7a730","url":"https://api.github.com/users/taylorleese","html_url":"https://github.com/taylorleese","followers_url":"https://api.github.com/users/taylorleese/followers","following_url":"https://api.github.com/users/taylorleese/following","gists_url":"https://api.github.com/users/taylorleese/gists{/gist_id}","starred_url":"https://api.github.com/users/taylorleese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylorleese/subscriptions","organizations_url":"https://api.github.com/users/taylorleese/orgs","repos_url":"https://api.github.com/users/taylorleese/repos","events_url":"https://api.github.com/users/taylorleese/events{/privacy}","received_events_url":"https://api.github.com/users/taylorleese/received_events","type":"User"},"created_at":"2013-04-15T06:51:32Z","updated_at":"2013-04-15T06:51:32Z","html_url":"https://github.com/stackmob/stackmob-customcode-example/pull/10#discussion_r3788927","pull_request_url":"https://api.github.com/repos/stackmob/stackmob-customcode-example/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/stackmob/stackmob-customcode-example/pulls/comments/3788927"},"html":{"href":"https://github.com/stackmob/stackmob-customcode-example/pull/10#discussion_r3788927"},"pull_request":{"href":"https://api.github.com/repos/stackmob/stackmob-customcode-example/pulls/10"}}}}

{"repository":{"description":"StackMob Custom Code Example Project","homepage":"","watchers":15,"stargazers":15,"forks":37,"fork":false,"size":228,"owner":"stackmob","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2012-04-11T16:48:52-07:00","pushed_at":"2013-04-09T18:13:59-07:00","master_branch":"master","organization":"stackmob"},"actor_attributes":{"type":"User","name":"Taylor Leese","company":"StackMob","blog":"http://about.me/taylorleese","location":"Dublin, CA","email":"[email protected]"},"url":"https://github.com/stackmob/stackmob-customcode-example/pull/10#discussion_r3788927"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/storyarc/pagination/pulls/comments/4578846","id":4578846,"body":"I simply added a newline at end of line.","diff_hunk":"@@ -4,4 +4,4 @@ Permission is hereby granted, free of charge, to any person obtaining a copy of\n \n The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.\n \n-THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.\n\\ No newline at end of file\n+THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.","path":"LICENSE.txt","position":6,"original_position":6,"commit_id":"7fe8552565ae9a44d8712092e00d558e5b9d174a","original_commit_id":"7fe8552565ae9a44d8712092e00d558e5b9d174a","user":{"login":"rxaviers","id":967155,"avatar_url":"https://secure.gravatar.com/avatar/6e836e35b57421faa0067702089ed46e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"6e836e35b57421faa0067702089ed46e","url":"https://api.github.com/users/rxaviers","html_url":"https://github.com/rxaviers","followers_url":"https://api.github.com/users/rxaviers/followers","following_url":"https://api.github.com/users/rxaviers/following{/other_user}","gists_url":"https://api.github.com/users/rxaviers/gists{/gist_id}","starred_url":"https://api.github.com/users/rxaviers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rxaviers/subscriptions","organizations_url":"https://api.github.com/users/rxaviers/orgs","repos_url":"https://api.github.com/users/rxaviers/repos","events_url":"https://api.github.com/users/rxaviers/events{/privacy}","received_events_url":"https://api.github.com/users/rxaviers/received_events","type":"User"},"created_at":"2013-06-06T21:50:57Z","updated_at":"2013-06-06T21:50:57Z","html_url":"https://github.com/storyarc/pagination/pull/2#discussion_r4578846","pull_request_url":"https://api.github.com/repos/storyarc/pagination/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/storyarc/pagination/pulls/comments/4578846"},"html":{"href":"https://github.com/storyarc/pagination/pull/2#discussion_r4578846"},"pull_request":{"href":"https://api.github.com/repos/storyarc/pagination/pulls/2"}}}}

{"repository":{"description":"","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":112,"owner":"storyarc","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"created_at":"2013-06-06T13:09:12-07:00","pushed_at":"2013-06-06T14:47:57-07:00","master_branch":"master","organization":"storyarc"},"actor_attributes":{"type":"User","name":"Rafael Xavier de Souza","blog":"http://rafael.xavier.blog.br","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/storyarc/pagination/pull/2#discussion_r4578846"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/wet-boew/wet-boew/pulls/comments/2955822","id":2955822,"body":"Indenting","path":"src/theme-base/sass/includes/_default-mobile.scss","position":803,"original_position":803,"commit_id":"7626d031014962d061e5ca33b545f51204d8aba3","original_commit_id":"7626d031014962d061e5ca33b545f51204d8aba3","user":{"login":"nschonni","id":1297909,"avatar_url":"https://secure.gravatar.com/avatar/629fa905b76d5e22210586cec7a98825?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"629fa905b76d5e22210586cec7a98825","url":"https://api.github.com/users/nschonni","followers_url":"https://api.github.com/users/nschonni/followers","following_url":"https://api.github.com/users/nschonni/following","gists_url":"https://api.github.com/users/nschonni/gists{/gist_id}","starred_url":"https://api.github.com/users/nschonni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nschonni/subscriptions","organizations_url":"https://api.github.com/users/nschonni/orgs","repos_url":"https://api.github.com/users/nschonni/repos","events_url":"https://api.github.com/users/nschonni/events{/privacy}","received_events_url":"https://api.github.com/users/nschonni/received_events","type":"User"},"created_at":"2013-02-10T19:37:02Z","updated_at":"2013-02-10T19:37:02Z","_links":{"self":{"href":"https://api.github.com/repos/wet-boew/wet-boew/pulls/comments/2955822"},"html":{"href":"https://github.com/wet-boew/wet-boew/pull/1203#discussion_r2955822"},"pull_request":{"href":"https://api.github.com/repos/wet-boew/wet-boew/pulls/1203"}}}}

{"repository":{"description":"Main repository of the Web Experience Toolkit (WET)","watchers":206,"stargazers":206,"forks":154,"fork":false,"size":21816,"owner":"wet-boew","private":false,"open_issues":153,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-05-11T06:31:20-07:00","pushed_at":"2013-02-10T00:43:50-08:00","organization":"wet-boew"},"actor_attributes":{"name":"Nick Schonning","company":"Citizenship and Immigration Canada","location":"Toronto, Ontario, Canada","email":"[email protected]","type":"User"},"url":"https://github.com/wet-boew/wet-boew/pull/1203#discussion_r2955822"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/wet-boew/wet-boew/pulls/comments/2970431","id":2970431,"body":"Is there a reason this one strips the target=\"_blank\" off? Compare to https://github.com/wet-boew/wet-boew/pull/1213/files#L169R70, which also doesn't use the `#160`","path":"demos/theme-gcwu-fegc/application-nosearchlang-secnav2-ara.html","position":20,"original_position":20,"commit_id":"c226d9c7ed3bba266dbb6a92e34fde6eb850dfbf","original_commit_id":"c226d9c7ed3bba266dbb6a92e34fde6eb850dfbf","user":{"login":"nschonni","id":1297909,"avatar_url":"https://secure.gravatar.com/avatar/629fa905b76d5e22210586cec7a98825?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"629fa905b76d5e22210586cec7a98825","url":"https://api.github.com/users/nschonni","followers_url":"https://api.github.com/users/nschonni/followers","following_url":"https://api.github.com/users/nschonni/following","gists_url":"https://api.github.com/users/nschonni/gists{/gist_id}","starred_url":"https://api.github.com/users/nschonni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nschonni/subscriptions","organizations_url":"https://api.github.com/users/nschonni/orgs","repos_url":"https://api.github.com/users/nschonni/repos","events_url":"https://api.github.com/users/nschonni/events{/privacy}","received_events_url":"https://api.github.com/users/nschonni/received_events","type":"User"},"created_at":"2013-02-11T22:59:50Z","updated_at":"2013-02-11T22:59:50Z","_links":{"self":{"href":"https://api.github.com/repos/wet-boew/wet-boew/pulls/comments/2970431"},"html":{"href":"https://github.com/wet-boew/wet-boew/pull/1213#discussion_r2970431"},"pull_request":{"href":"https://api.github.com/repos/wet-boew/wet-boew/pulls/1213"}}}}

{"repository":{"description":"Main repository of the Web Experience Toolkit (WET)","watchers":207,"stargazers":207,"forks":156,"fork":false,"size":21936,"owner":"wet-boew","private":false,"open_issues":153,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-05-11T06:31:20-07:00","pushed_at":"2013-02-11T14:29:34-08:00","organization":"wet-boew"},"actor_attributes":{"name":"Nick Schonning","company":"Citizenship and Immigration Canada","location":"Toronto, Ontario, Canada","email":"[email protected]","type":"User"},"url":"https://github.com/wet-boew/wet-boew/pull/1213#discussion_r2970431"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/wet-boew/wet-boew/pulls/comments/5775053","id":5775053,"body":"I think so (but you don't need the bracket). @pjackson28 am I missing an obvious reason that the comparison was done that way?","diff_hunk":"@@ -83,7 +83,7 @@\n \t\t\t\tif (value === 'undefined') {\n \t\t\t\t\tvalue = $this.text();\n \t\t\t\t}\t\n-\t\t\t\tdatalist_items.push('<li class=\"al-option\" id=\"al-option-' + index + '-' + index2 + '\"><a href=\"javascript:;\"><span class=\"al-value\">' + (value !== 'undefined' ? value : \"\") + '</span><span class=\"al-label\">' + (label !== 'undefined' ? label : \"\") + '</span></a></li>');\n+\t\t\t\tdatalist_items.push('<li class=\"al-option\" id=\"al-option-' + index + '-' + index2 + '\"><a href=\"javascript:;\"><span class=\"al-value\">' + (value !== undefined ? value : \"\") + '</span><span class=\"al-label\">' + (label !== undefined ? label : \"\") + '</span></a></li>');","path":"src/js/polyfills/datalist.js","position":5,"original_position":5,"commit_id":"f10594ba623e87164d55697f5a342651a665be99","original_commit_id":"f10594ba623e87164d55697f5a342651a665be99","user":{"login":"nschonni","id":1297909,"avatar_url":"https://secure.gravatar.com/avatar/629fa905b76d5e22210586cec7a98825?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"629fa905b76d5e22210586cec7a98825","url":"https://api.github.com/users/nschonni","html_url":"https://github.com/nschonni","followers_url":"https://api.github.com/users/nschonni/followers","following_url":"https://api.github.com/users/nschonni/following{/other_user}","gists_url":"https://api.github.com/users/nschonni/gists{/gist_id}","starred_url":"https://api.github.com/users/nschonni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nschonni/subscriptions","organizations_url":"https://api.github.com/users/nschonni/orgs","repos_url":"https://api.github.com/users/nschonni/repos","events_url":"https://api.github.com/users/nschonni/events{/privacy}","received_events_url":"https://api.github.com/users/nschonni/received_events","type":"User"},"created_at":"2013-08-14T20:24:11Z","updated_at":"2013-08-14T20:24:11Z","html_url":"https://github.com/wet-boew/wet-boew/pull/2824#discussion_r5775053","pull_request_url":"https://api.github.com/repos/wet-boew/wet-boew/pulls/2824","_links":{"self":{"href":"https://api.github.com/repos/wet-boew/wet-boew/pulls/comments/5775053"},"html":{"href":"https://github.com/wet-boew/wet-boew/pull/2824#discussion_r5775053"},"pull_request":{"href":"https://api.github.com/repos/wet-boew/wet-boew/pulls/2824"}}}}

{"repository":{"description":"Web Experience Toolkit (WET): Open source code library for building innovative websites that are accessible, usable, interoperable, mobile-friendly and multilingual. This collaborative open source project is led by the Government of Canada.","homepage":"http://wet-boew.github.io/wet-boew/index-eng.html","watchers":290,"stargazers":290,"forks":254,"fork":false,"size":140672,"owner":"wet-boew","private":false,"open_issues":227,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-05-11T06:31:20-07:00","pushed_at":"2013-08-14T12:37:24-07:00","master_branch":"master","organization":"wet-boew"},"actor_attributes":{"type":"User","name":"Nick Schonning","company":"Citizenship and Immigration Canada","blog":"http://wet-boew.github.com/","location":"Toronto, Ontario, Canada","email":"[email protected]"},"url":"https://github.com/wet-boew/wet-boew/pull/2824#discussion_r5775053"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/worklist/hifi/pulls/comments/8419701","id":8419701,"diff_hunk":"@@ -19,10 +19,12 @@\n #include <ParticleScriptingInterface.h>\n #include <VoxelScriptingInterface.h>\n \n+const QString NO_SCRIPT(\"\");\n+\n class ScriptEngine : public QObject {\n Q_OBJECT\n public:\n- ScriptEngine(QString scriptContents, bool wantMenuItems = false, \n+ ScriptEngine(QString scriptContents = NO_SCRIPT, bool wantMenuItems = false, ","path":"libraries/scriptengine/src/ScriptEngine.h","position":10,"original_position":10,"commit_id":"88c319a0daa279fdf404a3868460d79910f50629","original_commit_id":"88c319a0daa279fdf404a3868460d79910f50629","user":{"login":"birarda","id":724069,"avatar_url":"https://gravatar.com/avatar/5ed8d6478590ae9259a083f2fcb2ab56?d=https%3A%2F%2Fidenticons.github.com%2F677aff3b995dba3b7c054a6edede1c10.png&r=x","gravatar_id":"5ed8d6478590ae9259a083f2fcb2ab56","url":"https://api.github.com/users/birarda","html_url":"https://github.com/birarda","followers_url":"https://api.github.com/users/birarda/followers","following_url":"https://api.github.com/users/birarda/following{/other_user}","gists_url":"https://api.github.com/users/birarda/gists{/gist_id}","starred_url":"https://api.github.com/users/birarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birarda/subscriptions","organizations_url":"https://api.github.com/users/birarda/orgs","repos_url":"https://api.github.com/users/birarda/repos","events_url":"https://api.github.com/users/birarda/events{/privacy}","received_events_url":"https://api.github.com/users/birarda/received_events","type":"User","site_admin":false},"body":"pass the QString by ref (and you should be able to &NO_SCRIPT)","created_at":"2013-12-17T22:19:56Z","updated_at":"2013-12-17T22:19:56Z","html_url":"https://github.com/worklist/hifi/pull/1394#discussion_r8419701","pull_request_url":"https://api.github.com/repos/worklist/hifi/pulls/1394","_links":{"self":{"href":"https://api.github.com/repos/worklist/hifi/pulls/comments/8419701"},"html":{"href":"https://github.com/worklist/hifi/pull/1394#discussion_r8419701"},"pull_request":{"href":"https://api.github.com/repos/worklist/hifi/pulls/1394"}}}}

{"repository":{"description":"Open, decentralized virtual world using sensors to control avatars and dynamically assigned devices as servers. San Francisco based startup, we are hiring: http://highfidelity.io/jobs You can also contribute by doing jobs listed at http://worklist.net/worklist.php","homepage":"http://highfidelity.io","watchers":49,"stargazers":49,"forks":39,"fork":false,"size":113960,"owner":"worklist","private":false,"open_issues":6,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2012-08-10T11:26:22-07:00","pushed_at":"2013-12-17T13:02:05-08:00","master_branch":"master","organization":"worklist"},"actor_attributes":{"type":"User","name":"Stephen Birarda","company":"High Fidelity","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/worklist/hifi/pull/1394#discussion_r8419701"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/worklist/hifi/pulls/comments/4286116","id":4286116,"body":"spacing on comma","diff_hunk":"@@ -527,14 +534,17 @@ int main(int argc, const char * argv[])\n if (packetData[0] == PACKET_HEADER_SET_VOXEL || packetData[0] == PACKET_HEADER_SET_VOXEL_DESTRUCTIVE) {\n bool destructive = (packetData[0] == PACKET_HEADER_SET_VOXEL_DESTRUCTIVE);\n \n- PerformanceWarning warn(true,\n+ PerformanceWarning warn(::wantAnimationDebug,\n destructive ? \"PACKET_HEADER_SET_VOXEL_DESTRUCTIVE\" : \"PACKET_HEADER_SET_VOXEL\",\n- true);\n+ ::wantAnimationDebug);\n \n \tunsigned short int itemNumber = (*((unsigned short int*)&packetData[1]));\n- \tprintf(\"got %s - command from client receivedBytes=%ld itemNumber=%d\\n\",\n- \t destructive ? \"PACKET_HEADER_SET_VOXEL_DESTRUCTIVE\" : \"PACKET_HEADER_SET_VOXEL\",\n- \t\treceivedBytes,itemNumber);\n+ \t\n+ \tif (::wantAnimationDebug) {\n+ printf(\"got %s - command from client receivedBytes=%ld itemNumber=%d\\n\",\n+ destructive ? \"PACKET_HEADER_SET_VOXEL_DESTRUCTIVE\" : \"PACKET_HEADER_SET_VOXEL\",\n+ receivedBytes,itemNumber);","path":"voxel-server/src/main.cpp","position":57,"original_position":57,"commit_id":"d0b1d49b5d7e2136d723837c37acbafc73186634","original_commit_id":"d0b1d49b5d7e2136d723837c37acbafc73186634","user":{"login":"birarda","id":724069,"avatar_url":"https://secure.gravatar.com/avatar/5ed8d6478590ae9259a083f2fcb2ab56?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"5ed8d6478590ae9259a083f2fcb2ab56","url":"https://api.github.com/users/birarda","html_url":"https://github.com/birarda","followers_url":"https://api.github.com/users/birarda/followers","following_url":"https://api.github.com/users/birarda/following{/other_user}","gists_url":"https://api.github.com/users/birarda/gists{/gist_id}","starred_url":"https://api.github.com/users/birarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birarda/subscriptions","organizations_url":"https://api.github.com/users/birarda/orgs","repos_url":"https://api.github.com/users/birarda/repos","events_url":"https://api.github.com/users/birarda/events{/privacy}","received_events_url":"https://api.github.com/users/birarda/received_events","type":"User"},"created_at":"2013-05-17T23:07:56Z","updated_at":"2013-05-17T23:07:56Z","html_url":"https://github.com/worklist/hifi/pull/348#discussion_r4286116","pull_request_url":"https://api.github.com/repos/worklist/hifi/pulls/348","_links":{"self":{"href":"https://api.github.com/repos/worklist/hifi/pulls/comments/4286116"},"html":{"href":"https://github.com/worklist/hifi/pull/348#discussion_r4286116"},"pull_request":{"href":"https://api.github.com/repos/worklist/hifi/pulls/348"}}}}

{"repository":{"description":"Test platform for various render and interface tests for next-gen VR system","watchers":6,"stargazers":6,"forks":14,"fork":false,"size":3264,"owner":"worklist","private":false,"open_issues":7,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2012-08-10T11:26:22-07:00","pushed_at":"2013-05-17T15:43:32-07:00","master_branch":"master","organization":"worklist"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/worklist/hifi/pull/348#discussion_r4286116"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/wysiwhat/Aloha-Editor/pulls/comments/3979399","id":3979399,"body":"What happens if the query returns an error ; )","diff_hunk":"@@ -0,0 +1,490 @@\n+# Aloha Video Plugin\n+# * -----------------\n+# * This plugin handles when the insertVideo button is clicked\n+#\n+define ['aloha', 'jquery', 'popover', 'ui/ui', 'css!assorted/css/image.css'], (Aloha, jQuery, Popover, UI) ->\n+\n+ embedder = (url_validator, embed_code_generator, query_generator, search_results_generator) ->\n+ this.embed_code_gen = embed_code_generator\n+ this.url_validator = url_validator\n+ this.query_generator = query_generator\n+ this.search_results_generator = search_results_generator\n+ result = this\n+\n+\n+ YOUTUBE_ID = 0\n+ VIMEO_ID = 1\n+ SLIDESHARE_ID = 2\n+ CONCORD_ID = 3\n+\n+ lastKnownUrlId = ''\n+ lastWorkingEmbedder = -1\n+\n+ # Creates a youtube embedder\n+ youtube_url_validator = (url) ->\n+ regexp = /^(?:https?:\\/\\/)?(?:www\\.)?youtube\\.com\\/watch\\?(?=.*v=((\\w|-){11}))(?:\\S+)?$/\n+ if url.match(regexp)\n+ lastKnownUrlId = RegExp.$1\n+ lastWorkingEmbedder = YOUTUBE_ID\n+ return RegExp.$1\n+ else\n+ lastWorkingEmbedder = -1\n+ return false\n+ \n+ youtube_embed_code_generator = (id) ->\n+ return jQuery('<iframe style=\"width:640px; height:360px\" width=\"640\" height=\"360\" src=\"http:\\/\\/www.youtube.com/embed/' + id + '?wmode=transparent\" frameborder=\"0\" allowfullscreen></iframe>')\n+\n+ youtube_query_generator = (queryTerms) -> \n+ terms = queryTerms.split(' ')\n+ return 'https://gdata.youtube.com/feeds/api/videos?q='+terms.join('+')+'&alt=json&v=2'\n+\n+ youtube_search_results_generator = (responseObj) ->\n+ eleList = [ ]\n+ videoList = responseObj.feed.entry\n+ for video in videoList\n+ thumbnailUrl = video.media$group.media$thumbnail[0].url\n+ thumbnailHeight = video.media$group.media$thumbnail[0].height\n+ thumbnailWidth = video.media$group.media$thumbnail[0].width\n+ videoTitle = video.title.$t\n+ videoDescription = video.media$group.media$description.$t\n+ videoLengthString = getTimeString(video.media$group.yt$duration.seconds)\n+ idTokens = video.id.$t.split(':')\n+ videoId = idTokens[idTokens.length-1]\n+ newEntry = jQuery('<div style=\"width:100%;border-bottom: 1px solid black;\" class=\"search-result\" id='+videoId+'><table><tr><td width=20% rowspan=3><img src='+thumbnailUrl+' /></td><td><b>'+videoTitle+'</b></td></tr><tr><td>'+videoDescription+'</td></tr><tr><td>Duration: '+videoLengthString+'</td></tr></table></div>')\n+ eleList.push(newEntry)\n+ return eleList\n+\n+ vimeo_url_validator = (url) ->\n+ if url.indexOf('vimeo.com/') != -1\n+ offset = url.indexOf('vimeo.com/')\n+ offset = offset + 10\n+ videoIdStr = url.substring(offset)\n+ intRegex = /^[0-9]$/\n+ for c in videoIdStr\n+ if !intRegex.test(c)\n+ return false\n+ lastKnownUrlId = videoIdStr\n+ lastWorkingEmbedder = VIMEO_ID\n+ return videoIdStr\n+ lastWorkingEmbedder = -1\n+ return false\n+\n+ vimeo_embed_code_generator = (id) ->\n+ return jQuery('<iframe style=\"width:640px; height:380px\" src=\"http://player.vimeo.com/video/'+id+'\" width=\"640\" height=\"380\" frameborder=\"0\" webkitAllowFullScreen mozallowfullscreen allowFullScreen></iframe>') \n+\n+ vimeo_query_generator = (queryTerms) -> \n+ terms = queryTerms.split(' ')\n+ url = 'http://vimeo.com/api/rest/v2&format=json&method=vimeo.videos.search&oauth_consumer_key=c1f5add1d34817a6775d10b3f6821268&oauth_nonce=da3f0c0437ad303c7cdb11c522abef4f&oauth_signature_method=HMAC-SHA1&oauth_timestamp=1365564937&oauth_token=1bba5c6f35030672b0b4b5c8cf8ed156&oauth_version=1.0&page=0&per_page=50&query='+terms.join('+')+'&user_id=jmaxg3'\n+ return url\n+\n+ vimeo_search_results_generator = (responseObj) ->\n+ return [ ]\n+\n+ slideshare_url_validator = (inputurl, inputbox) ->\n+ if inputurl.indexOf('slideshare.net') == -1\n+ return false\n+\n+ encodedUrl = encodeURIComponent(inputurl)\n+ jQuery.ajax({\n+ url: 'http://www.slideshare.net/api/oembed/2?url='+encodedUrl+'&format=jsonp',\n+ async:false,\n+ dataType: 'jsonp',\n+ success: (result, status, statusObject) -> \n+ id = result.slideshow_id\n+ if inputurl == inputbox.value\n+ inputbox.style.borderColor='green'\n+ inputbox.style.borderWidth='medium'\n+ lastKnownUrlId = id\n+ lastWorkingEmbedder = SLIDESHARE_ID\n+ })\n+ \n+ lastWorkingEmbedder = -1\n+ return false\n+ \n+ slideshare_embed_code_generator = (id) ->\n+ return jQuery('<iframe style=\"width:427px; height:356px\" src=\"http://www.slideshare.net/slideshow/embed_code/'+id+'\" width=\"427\" height=\"356\" frameborder=\"0\" marginwidth=\"0\" marginheight=\"0\" scrolling=\"no\" style=\"border:1px solid #CCC;border-width:1px 1px 0;margin-bottom:5px\" allowfullscreen webkitallowfullscreen mozallowfullscreen> </iframe>') \n+\n+ slideshare_query_generator = (queryTerms) -> \n+ return false\n+\n+ slideshare_search_results_generator = (responseObj) ->\n+ return [ ]\n+\n+ concord_url_validator = (url) ->\n+ concordLabUrl = 'lab.concord.org/examples/interactives/interactives.html#interactives/samples/'\n+ if url.indexOf(concordLabUrl) != -1\n+ offset = url.indexOf(concordLabUrl)\n+ offset = offset + concordLabUrl.length\n+ id = url.substring(offset)\n+ if id.length > 5\n+ post = id.substring(id.length-5)\n+ if post == '.json'\n+ id = id.substring(0, id.length-5)\n+ console.debug id\n+ lastKnownUrlId = id\n+ lastWorkingEmbedder = CONCORD_ID\n+ return id\n+\n+ return false\n+\n+ concord_embed_code_generator = (id) ->\n+ return jQuery('<iframe style=\"width:925px; height:575px\" width=\"925\" height=\"575\" frameborder=\"no\" scrolling=\"no\" src=\"http://lab.concord.org/examples/interactives/embeddable.html#interactives/samples/'+id+'.json\"></iframe>')\n+\n+ concord_query_generator = (queryTerms) -> \n+ false\n+\n+ concord_search_results_generator = (responseObj) ->\n+ return [ ]\n+\n+ youtube_embedder = new embedder(youtube_url_validator, youtube_embed_code_generator, youtube_query_generator, youtube_search_results_generator)\n+ vimeo_embedder = new embedder(vimeo_url_validator, vimeo_embed_code_generator, vimeo_query_generator, vimeo_search_results_generator)\n+ slideshare_embedder = new embedder(slideshare_url_validator, slideshare_embed_code_generator, slideshare_query_generator, slideshare_search_results_generator)\n+ concord_embedder = new embedder(concord_url_validator, concord_embed_code_generator, concord_query_generator, concord_search_results_generator)\n+\n+ # Adds the youtube embedders to the list of embedders\n+ embedders = []\n+ embedders[YOUTUBE_ID] = youtube_embedder\n+ embedders[VIMEO_ID] = vimeo_embedder\n+ embedders[SLIDESHARE_ID] = slideshare_embedder\n+ embedders[CONCORD_ID] = concord_embedder\n+\n+ active_embedder = youtube_embedder\n+ active_embedder_value = 'youtube'\n+ \n+ checkURL = (url, inputbox) ->\n+ for embedder in embedders\n+ if (embedder.url_validator(url, inputbox)) \n+ return true\n+ return false\n+\n+ # This will be prefixed with Aloha.settings.baseUrl\n+ WARNING_IMAGE_PATH = '/../plugins/oerpub/image/img/warning.png'\n+\n+ DIALOG_HTML = '''\n+ <form class=\"plugin video modal hide fade\" id=\"linkModal\" tabindex=\"-1\" role=\"dialog\" aria-labelledby=\"linkModalLabel\" aria-hidden=\"true\" data-backdrop=\"false\">\n+ <div class=\"modal-header\">\n+ <button type=\"button\" class=\"close\" data-dismiss=\"modal\" aria-hidden=\"true\">&times;</button>\n+ <h3>Insert video</h3>\n+ </div>\n+ <div class=\"modal-body\">\n+ <div class=\"image-options\">\n+ <center><input type=\"text\" style=\"width:80%;\" id=\"video-url-input\" class=\"upload-url-input\" placeholder=\"Enter URL of video ...\"/></center>\n+ </div>\n+ <center>OR</center>\n+ <div class=\"modal-body\" >\n+ <center><input type=\"text\" style=\"width:80%;\" id=\"video-search-input\" class-\"upload-url-input\" placeholder=\"Enter search terms for your video ...\"/></center>\n+ <center><table><tr><td><input id='media-sites' type=\"radio\" name=\"video-site\" value=\"youtube\" checked>Youtube</input></td><td><input disabled id='media-sites' type=\"radio\" name=\"video-site\" value=\"vimeo\">Vimeo (search not working)</input></td></tr></table></center>\n+ <center><button type=\"search\" class=\"btn btn-primary action search\">Search</button></center>\n+ </div>\n+ <div class=\"modal-body\" >\n+ <div style=\"border:1px solid; height:200px; width:100%; overflow-x:auto; overflow-y:scroll;\" id=\"search-results\">\n+ </div>\n+ </div>\n+ </div>\n+ <div class=\"modal-footer\">\n+ <button type=\"submit\" class=\"btn btn-primary action insert\">Insert</button>\n+ <button class=\"btn action cancel\">Cancel</button>\n+ </div>\n+ </form>'''\n+\n+ \n+ getTimeString = (timeInSeconds) ->\n+ nHours = 0\n+ nMinutes = 0\n+ nSeconds = 0\n+ ivalue = parseInt(timeInSeconds)\n+\n+ if ivalue > 3600\n+ nHours = Math.floor(ivalue / 3600)\n+ ivalue = ivalue - (3600 * nHours)\n+ if ivalue > 60\n+ nMinutes = Math.floor(ivalue / 60)\n+ ivalue = ivalue - (60 * nMinutes)\n+ nSeconds = ivalue\n+\n+ str = ''\n+ if nHours > 0\n+ str = str + nHours.toString()+' hours'\n+ if nMinutes > 0\n+ if str.length != 0\n+ str = str + ', '\n+ str = str + nMinutes.toString() + ' mins'\n+ if nSeconds > 0\n+ if str.length != 0\n+ str = str + ', '\n+ str = str + nSeconds.toString() + ' secs'\n+ return str\n+\n+ # Defines a template for an embedder object which is responsible for generating embed html and validating a url\n+ showModalDialog = ($el) ->\n+ settings = Aloha.require('assorted/assorted-plugin').settings\n+ root = Aloha.activeEditable.obj\n+ dialog = jQuery(DIALOG_HTML)\n+\n+ # Find the dynamic modal elements and bind events to the buttons\n+ $placeholder = dialog.find('.placeholder.preview')\n+ $uploadUrl = dialog.find('.upload-url-input')\n+ $searchTerms = dialog.find('#video-search-input')\n+ $searchResults = dialog.find('#search-results')\n+ $submit = dialog.find('.action.insert')\n+ dialog.find(\"#video-url-input\")[0].onkeyup = (event) -> \n+ target = event.currentTarget\n+ currentVal = target.value\n+ valid = checkURL(currentVal, target)\n+ if(valid) \n+ target.style.borderColor='green'\n+ target.style.borderWidth='medium'\n+ else\n+ target.style.borderColor='red'\n+ target.style.borderWidth='medium'\n+\n+ for radio in dialog.find('#media-sites')\n+ radio.onclick = (event) ->\n+ val = event.target.value\n+ if active_embedder_value != val\n+ index = 0\n+ for radio in dialog.find('#media-sites')\n+ if radio.value == val\n+ console.debug 'Setting '+radio.value\n+ active_embedder_value = radio.value\n+ active_embedder = embedders[index]\n+ break\n+ index = index + 1\n+ \n+ # If we're editing an image pull in the src.\n+ # It will be undefined if this is a new image.\n+ #\n+ # This variable is updated when one of the following occurs:\n+ # * selects an image from the filesystem\n+ # * enters a URL (TODO: Verify it's an image)\n+ # * drops an image into the drop div\n+\n+ # $el might not be an image, it might be a placeholder for a future image\n+ if $el.is('img')\n+ # On submit $el.attr('src') will point to what is set in this variable\n+ # preserve the alt text if editing an image\n+ videoSource = $el.attr('src')\n+ imageAltText = $el.attr('alt')\n+ else\n+ videoSource = ''\n+ imageAltText = ''\n+\n+ dialog.find('[name=alt]').val(imageAltText)\n+ # Checks if the URL is a valid one -- i.e. if one of the embedders can parse and generate embedded html for it\n+ # /^https?:\\/\\// - old regex\n+ if checkURL(videoSource, $uploadUrl)\n+ $uploadUrl.val(videoSource)\n+ $uploadUrl.show()\n+ # Retrieves embedder which can matches the format of the URL\n+\n+ setvideoSource = (href) ->\n+ videoSource = href\n+ $submit.removeClass('disabled')\n+\n+ # Uses the File API to render a preview of the image\n+ # and updates the modal's videoSource\n+ loadLocalFile = (file, $img, callback) ->\n+ reader = new FileReader()\n+ reader.onloadend = () ->\n+ if $img\n+ $img.attr('src', reader.result)\n+ # If we get an image then update the modal's videoSource\n+ setvideoSource(reader.result)\n+ callback(reader.result) if callback\n+ reader.readAsDataURL(file)\n+\n+ # Add click handlers\n+ dialog.find('.upload-image-link').on 'click', (evt) ->\n+ evt.preventDefault()\n+ $placeholder.hide()\n+ $uploadUrl.hide()\n+\n+ dialog.find('.upload-url-link').on 'click', (evt) ->\n+ evt.preventDefault()\n+ $placeholder.hide()\n+ $uploadUrl.show()\n+\n+ $uploadUrl.on 'change', () ->\n+ $previewImg = $placeholder.find('img')\n+ url = $uploadUrl.val()\n+ setvideoSource(url)\n+ if settings.image.preview\n+ $previewImg.attr 'src', url\n+ $placeholder.show()\n+\n+ # On save update the actual video element. Use the submit event because this\n+ # allows the use of html5 validation.\n+ deferred = $.Deferred()\n+\n+ dialog.on 'click', '.btn.btn-primary.action.insert', (evt) =>\n+ evt.preventDefault() # Don't submit the form\n+ console.debug 'Inserting...'\n+ if $el.is('img')\n+ $el.attr 'src', videoSource\n+ $el.attr 'alt', dialog.find('[name=alt]').val()\n+ else\n+ # Embeds the video into the page\n+ #mediaWrapper = jQuery('<div class=\"media\"></div>')\n+ if videoSource.length == 0\n+ # Use search results\n+ for child in $searchResults.children()\n+ if child.className == 'search-result-selected'\n+ video_id = child.id\n+ mediaElement = active_embedder.embed_code_gen(video_id)\n+ break\n+ else\n+ # Use url\n+ console.debug 'Attempting URL support with '+lastWorkingEmbedder\n+ if lastWorkingEmbedder == -1\n+ return\n+ mediaElement = embedders[lastWorkingEmbedder].embed_code_gen(lastKnownUrlId)\n+\n+ #mediaWrapper.append(mediaElement)\n+ #AlohaInsertIntoDom(mediaWrapper)\n+ AlohaInsertIntoDom(mediaElement)\n+ dialog.modal('hide')\n+\n+ dialog.on 'click', '.btn.btn-primary.action.search', (evt) =>\n+ evt.preventDefault() # Don't submit the form\n+ queryUrl = active_embedder.query_generator($searchTerms[0].value)\n+ $searchResults.empty()\n+ $searchResults.append(jQuery('<div style=\"width=100%\" >Searching...</div>'))\n+ jQuery.get(queryUrl, (responseObj) => ","path":"src/plugins/oer/assorted/lib/video.coffee","position":352,"original_position":352,"commit_id":"8c8b77b613937fe70ae3ccf11ec3657377a1101b","original_commit_id":"8c8b77b613937fe70ae3ccf11ec3657377a1101b","user":{"login":"philschatz","id":253202,"avatar_url":"https://secure.gravatar.com/avatar/230b534963782ec45db2e2dbf8bf6709?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"230b534963782ec45db2e2dbf8bf6709","url":"https://api.github.com/users/philschatz","html_url":"https://github.com/philschatz","followers_url":"https://api.github.com/users/philschatz/followers","following_url":"https://api.github.com/users/philschatz/following","gists_url":"https://api.github.com/users/philschatz/gists{/gist_id}","starred_url":"https://api.github.com/users/philschatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philschatz/subscriptions","organizations_url":"https://api.github.com/users/philschatz/orgs","repos_url":"https://api.github.com/users/philschatz/repos","events_url":"https://api.github.com/users/philschatz/events{/privacy}","received_events_url":"https://api.github.com/users/philschatz/received_events","type":"User"},"created_at":"2013-04-26T15:57:41Z","updated_at":"2013-04-26T15:57:41Z","html_url":"https://github.com/wysiwhat/Aloha-Editor/pull/25#discussion_r3979399","pull_request_url":"https://api.github.com/repos/wysiwhat/Aloha-Editor/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/wysiwhat/Aloha-Editor/pulls/comments/3979399"},"html":{"href":"https://github.com/wysiwhat/Aloha-Editor/pull/25#discussion_r3979399"},"pull_request":{"href":"https://api.github.com/repos/wysiwhat/Aloha-Editor/pulls/25"}}}}

{"repository":{"description":"WYSIWHAT is a repo for the development of Aloha plugins, models, tests, and examples for use in the production of books and open educational resources. We intend to commit all code back to Aloha when plugins reach maturity.","homepage":"http://wysiwhat.github.com/Aloha-Editor/","watchers":20,"stargazers":20,"forks":9,"fork":true,"size":1292,"owner":"wysiwhat","private":false,"open_issues":3,"has_issues":true,"has_downloads":false,"has_wiki":true,"language":"JavaScript","created_at":"2012-07-25T01:36:22-07:00","pushed_at":"2013-04-26T08:45:13-07:00","integrate_branch":"dev","master_branch":"master","organization":"wysiwhat"},"actor_attributes":{"type":"User","name":"Philip Schatz","company":"Connexions","blog":"http://cnx.org","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/wysiwhat/Aloha-Editor/pull/25#discussion_r3979399"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/wysiwhat/Aloha-Editor/pulls/comments/4057492","id":4057492,"body":"Good point, TODO","diff_hunk":"@@ -0,0 +1,490 @@\n+# Aloha Video Plugin\n+# * -----------------\n+# * This plugin handles when the insertVideo button is clicked\n+#\n+define ['aloha', 'jquery', 'popover', 'ui/ui', 'css!assorted/css/image.css'], (Aloha, jQuery, Popover, UI) ->\n+\n+ embedder = (url_validator, embed_code_generator, query_generator, search_results_generator) ->\n+ this.embed_code_gen = embed_code_generator\n+ this.url_validator = url_validator\n+ this.query_generator = query_generator\n+ this.search_results_generator = search_results_generator\n+ result = this\n+\n+\n+ YOUTUBE_ID = 0\n+ VIMEO_ID = 1\n+ SLIDESHARE_ID = 2\n+ CONCORD_ID = 3\n+\n+ lastKnownUrlId = ''\n+ lastWorkingEmbedder = -1\n+\n+ # Creates a youtube embedder\n+ youtube_url_validator = (url) ->\n+ regexp = /^(?:https?:\\/\\/)?(?:www\\.)?youtube\\.com\\/watch\\?(?=.*v=((\\w|-){11}))(?:\\S+)?$/\n+ if url.match(regexp)\n+ lastKnownUrlId = RegExp.$1\n+ lastWorkingEmbedder = YOUTUBE_ID\n+ return RegExp.$1\n+ else\n+ lastWorkingEmbedder = -1\n+ return false\n+ \n+ youtube_embed_code_generator = (id) ->\n+ return jQuery('<iframe style=\"width:640px; height:360px\" width=\"640\" height=\"360\" src=\"http:\\/\\/www.youtube.com/embed/' + id + '?wmode=transparent\" frameborder=\"0\" allowfullscreen></iframe>')\n+\n+ youtube_query_generator = (queryTerms) -> \n+ terms = queryTerms.split(' ')\n+ return 'https://gdata.youtube.com/feeds/api/videos?q='+terms.join('+')+'&alt=json&v=2'\n+\n+ youtube_search_results_generator = (responseObj) ->\n+ eleList = [ ]\n+ videoList = responseObj.feed.entry\n+ for video in videoList\n+ thumbnailUrl = video.media$group.media$thumbnail[0].url\n+ thumbnailHeight = video.media$group.media$thumbnail[0].height\n+ thumbnailWidth = video.media$group.media$thumbnail[0].width\n+ videoTitle = video.title.$t\n+ videoDescription = video.media$group.media$description.$t\n+ videoLengthString = getTimeString(video.media$group.yt$duration.seconds)\n+ idTokens = video.id.$t.split(':')\n+ videoId = idTokens[idTokens.length-1]\n+ newEntry = jQuery('<div style=\"width:100%;border-bottom: 1px solid black;\" class=\"search-result\" id='+videoId+'><table><tr><td width=20% rowspan=3><img src='+thumbnailUrl+' /></td><td><b>'+videoTitle+'</b></td></tr><tr><td>'+videoDescription+'</td></tr><tr><td>Duration: '+videoLengthString+'</td></tr></table></div>')\n+ eleList.push(newEntry)\n+ return eleList\n+\n+ vimeo_url_validator = (url) ->\n+ if url.indexOf('vimeo.com/') != -1\n+ offset = url.indexOf('vimeo.com/')\n+ offset = offset + 10\n+ videoIdStr = url.substring(offset)\n+ intRegex = /^[0-9]$/\n+ for c in videoIdStr\n+ if !intRegex.test(c)\n+ return false\n+ lastKnownUrlId = videoIdStr\n+ lastWorkingEmbedder = VIMEO_ID\n+ return videoIdStr\n+ lastWorkingEmbedder = -1\n+ return false\n+\n+ vimeo_embed_code_generator = (id) ->\n+ return jQuery('<iframe style=\"width:640px; height:380px\" src=\"http://player.vimeo.com/video/'+id+'\" width=\"640\" height=\"380\" frameborder=\"0\" webkitAllowFullScreen mozallowfullscreen allowFullScreen></iframe>') \n+\n+ vimeo_query_generator = (queryTerms) -> \n+ terms = queryTerms.split(' ')\n+ url = 'http://vimeo.com/api/rest/v2&format=json&method=vimeo.videos.search&oauth_consumer_key=c1f5add1d34817a6775d10b3f6821268&oauth_nonce=da3f0c0437ad303c7cdb11c522abef4f&oauth_signature_method=HMAC-SHA1&oauth_timestamp=1365564937&oauth_token=1bba5c6f35030672b0b4b5c8cf8ed156&oauth_version=1.0&page=0&per_page=50&query='+terms.join('+')+'&user_id=jmaxg3'\n+ return url\n+\n+ vimeo_search_results_generator = (responseObj) ->\n+ return [ ]\n+\n+ slideshare_url_validator = (inputurl, inputbox) ->\n+ if inputurl.indexOf('slideshare.net') == -1\n+ return false\n+\n+ encodedUrl = encodeURIComponent(inputurl)\n+ jQuery.ajax({\n+ url: 'http://www.slideshare.net/api/oembed/2?url='+encodedUrl+'&format=jsonp',\n+ async:false,\n+ dataType: 'jsonp',\n+ success: (result, status, statusObject) -> \n+ id = result.slideshow_id\n+ if inputurl == inputbox.value\n+ inputbox.style.borderColor='green'\n+ inputbox.style.borderWidth='medium'\n+ lastKnownUrlId = id\n+ lastWorkingEmbedder = SLIDESHARE_ID\n+ })\n+ \n+ lastWorkingEmbedder = -1\n+ return false\n+ \n+ slideshare_embed_code_generator = (id) ->\n+ return jQuery('<iframe style=\"width:427px; height:356px\" src=\"http://www.slideshare.net/slideshow/embed_code/'+id+'\" width=\"427\" height=\"356\" frameborder=\"0\" marginwidth=\"0\" marginheight=\"0\" scrolling=\"no\" style=\"border:1px solid #CCC;border-width:1px 1px 0;margin-bottom:5px\" allowfullscreen webkitallowfullscreen mozallowfullscreen> </iframe>') \n+\n+ slideshare_query_generator = (queryTerms) -> \n+ return false\n+\n+ slideshare_search_results_generator = (responseObj) ->\n+ return [ ]\n+\n+ concord_url_validator = (url) ->\n+ concordLabUrl = 'lab.concord.org/examples/interactives/interactives.html#interactives/samples/'\n+ if url.indexOf(concordLabUrl) != -1\n+ offset = url.indexOf(concordLabUrl)\n+ offset = offset + concordLabUrl.length\n+ id = url.substring(offset)\n+ if id.length > 5\n+ post = id.substring(id.length-5)\n+ if post == '.json'\n+ id = id.substring(0, id.length-5)\n+ console.debug id\n+ lastKnownUrlId = id\n+ lastWorkingEmbedder = CONCORD_ID\n+ return id\n+\n+ return false\n+\n+ concord_embed_code_generator = (id) ->\n+ return jQuery('<iframe style=\"width:925px; height:575px\" width=\"925\" height=\"575\" frameborder=\"no\" scrolling=\"no\" src=\"http://lab.concord.org/examples/interactives/embeddable.html#interactives/samples/'+id+'.json\"></iframe>')\n+\n+ concord_query_generator = (queryTerms) -> \n+ false\n+\n+ concord_search_results_generator = (responseObj) ->\n+ return [ ]\n+\n+ youtube_embedder = new embedder(youtube_url_validator, youtube_embed_code_generator, youtube_query_generator, youtube_search_results_generator)\n+ vimeo_embedder = new embedder(vimeo_url_validator, vimeo_embed_code_generator, vimeo_query_generator, vimeo_search_results_generator)\n+ slideshare_embedder = new embedder(slideshare_url_validator, slideshare_embed_code_generator, slideshare_query_generator, slideshare_search_results_generator)\n+ concord_embedder = new embedder(concord_url_validator, concord_embed_code_generator, concord_query_generator, concord_search_results_generator)\n+\n+ # Adds the youtube embedders to the list of embedders\n+ embedders = []\n+ embedders[YOUTUBE_ID] = youtube_embedder\n+ embedders[VIMEO_ID] = vimeo_embedder\n+ embedders[SLIDESHARE_ID] = slideshare_embedder\n+ embedders[CONCORD_ID] = concord_embedder\n+\n+ active_embedder = youtube_embedder\n+ active_embedder_value = 'youtube'\n+ \n+ checkURL = (url, inputbox) ->\n+ for embedder in embedders\n+ if (embedder.url_validator(url, inputbox)) \n+ return true\n+ return false\n+\n+ # This will be prefixed with Aloha.settings.baseUrl\n+ WARNING_IMAGE_PATH = '/../plugins/oerpub/image/img/warning.png'\n+\n+ DIALOG_HTML = '''\n+ <form class=\"plugin video modal hide fade\" id=\"linkModal\" tabindex=\"-1\" role=\"dialog\" aria-labelledby=\"linkModalLabel\" aria-hidden=\"true\" data-backdrop=\"false\">\n+ <div class=\"modal-header\">\n+ <button type=\"button\" class=\"close\" data-dismiss=\"modal\" aria-hidden=\"true\">&times;</button>\n+ <h3>Insert video</h3>\n+ </div>\n+ <div class=\"modal-body\">\n+ <div class=\"image-options\">\n+ <center><input type=\"text\" style=\"width:80%;\" id=\"video-url-input\" class=\"upload-url-input\" placeholder=\"Enter URL of video ...\"/></center>\n+ </div>\n+ <center>OR</center>\n+ <div class=\"modal-body\" >\n+ <center><input type=\"text\" style=\"width:80%;\" id=\"video-search-input\" class-\"upload-url-input\" placeholder=\"Enter search terms for your video ...\"/></center>\n+ <center><table><tr><td><input id='media-sites' type=\"radio\" name=\"video-site\" value=\"youtube\" checked>Youtube</input></td><td><input disabled id='media-sites' type=\"radio\" name=\"video-site\" value=\"vimeo\">Vimeo (search not working)</input></td></tr></table></center>\n+ <center><button type=\"search\" class=\"btn btn-primary action search\">Search</button></center>\n+ </div>\n+ <div class=\"modal-body\" >\n+ <div style=\"border:1px solid; height:200px; width:100%; overflow-x:auto; overflow-y:scroll;\" id=\"search-results\">\n+ </div>\n+ </div>\n+ </div>\n+ <div class=\"modal-footer\">\n+ <button type=\"submit\" class=\"btn btn-primary action insert\">Insert</button>\n+ <button class=\"btn action cancel\">Cancel</button>\n+ </div>\n+ </form>'''\n+\n+ \n+ getTimeString = (timeInSeconds) ->\n+ nHours = 0\n+ nMinutes = 0\n+ nSeconds = 0\n+ ivalue = parseInt(timeInSeconds)\n+\n+ if ivalue > 3600\n+ nHours = Math.floor(ivalue / 3600)\n+ ivalue = ivalue - (3600 * nHours)\n+ if ivalue > 60\n+ nMinutes = Math.floor(ivalue / 60)\n+ ivalue = ivalue - (60 * nMinutes)\n+ nSeconds = ivalue\n+\n+ str = ''\n+ if nHours > 0\n+ str = str + nHours.toString()+' hours'\n+ if nMinutes > 0\n+ if str.length != 0\n+ str = str + ', '\n+ str = str + nMinutes.toString() + ' mins'\n+ if nSeconds > 0\n+ if str.length != 0\n+ str = str + ', '\n+ str = str + nSeconds.toString() + ' secs'\n+ return str\n+\n+ # Defines a template for an embedder object which is responsible for generating embed html and validating a url\n+ showModalDialog = ($el) ->\n+ settings = Aloha.require('assorted/assorted-plugin').settings\n+ root = Aloha.activeEditable.obj\n+ dialog = jQuery(DIALOG_HTML)\n+\n+ # Find the dynamic modal elements and bind events to the buttons\n+ $placeholder = dialog.find('.placeholder.preview')\n+ $uploadUrl = dialog.find('.upload-url-input')\n+ $searchTerms = dialog.find('#video-search-input')\n+ $searchResults = dialog.find('#search-results')\n+ $submit = dialog.find('.action.insert')\n+ dialog.find(\"#video-url-input\")[0].onkeyup = (event) -> \n+ target = event.currentTarget\n+ currentVal = target.value\n+ valid = checkURL(currentVal, target)\n+ if(valid) \n+ target.style.borderColor='green'","path":"src/plugins/oer/assorted/lib/video.coffee","position":235,"original_position":235,"commit_id":"8c8b77b613937fe70ae3ccf11ec3657377a1101b","original_commit_id":"8c8b77b613937fe70ae3ccf11ec3657377a1101b","user":{"login":"agrippa","id":941469,"avatar_url":"https://secure.gravatar.com/avatar/4cfd18de205b9dd1910efd92cc586106?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"4cfd18de205b9dd1910efd92cc586106","url":"https://api.github.com/users/agrippa","html_url":"https://github.com/agrippa","followers_url":"https://api.github.com/users/agrippa/followers","following_url":"https://api.github.com/users/agrippa/following","gists_url":"https://api.github.com/users/agrippa/gists{/gist_id}","starred_url":"https://api.github.com/users/agrippa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrippa/subscriptions","organizations_url":"https://api.github.com/users/agrippa/orgs","repos_url":"https://api.github.com/users/agrippa/repos","events_url":"https://api.github.com/users/agrippa/events{/privacy}","received_events_url":"https://api.github.com/users/agrippa/received_events","type":"User"},"created_at":"2013-05-02T15:54:47Z","updated_at":"2013-05-02T15:54:47Z","html_url":"https://github.com/wysiwhat/Aloha-Editor/pull/25#discussion_r4057492","pull_request_url":"https://api.github.com/repos/wysiwhat/Aloha-Editor/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/wysiwhat/Aloha-Editor/pulls/comments/4057492"},"html":{"href":"https://github.com/wysiwhat/Aloha-Editor/pull/25#discussion_r4057492"},"pull_request":{"href":"https://api.github.com/repos/wysiwhat/Aloha-Editor/pulls/25"}}}}

{"repository":{"description":"WYSIWHAT is a repo for the development of Aloha plugins, models, tests, and examples for use in the production of books and open educational resources. We intend to commit all code back to Aloha when plugins reach maturity.","homepage":"http://wysiwhat.github.com/Aloha-Editor/","watchers":19,"stargazers":19,"forks":9,"fork":true,"size":1552,"owner":"wysiwhat","private":false,"open_issues":7,"has_issues":true,"has_downloads":false,"has_wiki":true,"language":"JavaScript","created_at":"2012-07-25T01:36:22-07:00","pushed_at":"2013-05-02T06:13:16-07:00","integrate_branch":"dev","master_branch":"master","organization":"wysiwhat"},"actor_attributes":{"type":"User","name":"Max Grossman","company":"Rice University","blog":"jmg3.web.rice.edu","location":"Houston, TX","email":"[email protected]"},"url":"https://github.com/wysiwhat/Aloha-Editor/pull/25#discussion_r4057492"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/4teamwork/ftw.participation/pulls/comments/8284496","id":8284496,"diff_hunk":"@@ -0,0 +1,59 @@\n+from ftw.participation.tests.layer import FTW_PARTICIPATION_INTEGRATION_TESTING\n+from unittest2 import TestCase\n+from plone.app.testing import login, setRoles\n+from ftw.participation.interfaces import IParticipationSupport\n+from ftw.participation.interfaces import IParticipationBrowserLayer\n+from ftw.participation.invitation import Invitation\n+from zope.interface import alsoProvides\n+from ftw.testing.mailing import Mailing\n+from Products.CMFCore.utils import getToolByName\n+\n+\n+class TestInvitationAcceptmail(TestCase):\n+\n+ layer = FTW_PARTICIPATION_INTEGRATION_TESTING\n+\n+ def setUp(self):\n+ self.portal = self.layer['portal']\n+ alsoProvides(self.portal.REQUEST, IParticipationBrowserLayer)\n+ self.portal_url = self.portal.portal_url()\n+\n+ regtool = getToolByName(self.portal, 'portal_registration')\n+ regtool.addMember('usera', 'secret',\n+ properties={'username': 'usera',\n+ 'fullname': 'Usera',\n+ 'email': '[email protected]'})\n+\n+ regtool.addMember('userb', 'secret',\n+ properties={'username': 'userb',\n+ 'fullname': 'Userb',\n+ 'email': '[email protected]'})\n+\n+ setRoles(self.portal, 'userb', ['Manager'])\n+ setRoles(self.portal, 'usera', ['Manager'])\n+\n+ login(self.portal, 'usera')\n+\n+ self.demo_folder = self.portal.get(self.portal.invokeFactory(\n+ 'Folder', 'demo-folder'))\n+ alsoProvides(self.demo_folder, IParticipationSupport)\n+ Mailing(self.layer['portal']).set_up()\n+\n+ def tearDown(self):","path":"ftw/participation/tests/test_accept.py","position":42,"original_position":42,"commit_id":"c0dd0d44f77a5a21c9cb012326491c6a2e74e669","original_commit_id":"c0dd0d44f77a5a21c9cb012326491c6a2e74e669","user":{"login":"jone","id":7469,"avatar_url":"https://gravatar.com/avatar/90cd2a47d3ff93bf12ee7c588a9ae7fb?d=https%3A%2F%2Fidenticons.github.com%2F9cd3598a91516950427c605ae29cff68.png&r=x","gravatar_id":"90cd2a47d3ff93bf12ee7c588a9ae7fb","url":"https://api.github.com/users/jone","html_url":"https://github.com/jone","followers_url":"https://api.github.com/users/jone/followers","following_url":"https://api.github.com/users/jone/following{/other_user}","gists_url":"https://api.github.com/users/jone/gists{/gist_id}","starred_url":"https://api.github.com/users/jone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jone/subscriptions","organizations_url":"https://api.github.com/users/jone/orgs","repos_url":"https://api.github.com/users/jone/repos","events_url":"https://api.github.com/users/jone/events{/privacy}","received_events_url":"https://api.github.com/users/jone/received_events","type":"User","site_admin":false},"body":"Wrong indentation?","created_at":"2013-12-11T22:28:59Z","updated_at":"2013-12-11T22:28:59Z","html_url":"https://github.com/4teamwork/ftw.participation/pull/17#discussion_r8284496","pull_request_url":"https://api.github.com/repos/4teamwork/ftw.participation/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/4teamwork/ftw.participation/pulls/comments/8284496"},"html":{"href":"https://github.com/4teamwork/ftw.participation/pull/17#discussion_r8284496"},"pull_request":{"href":"https://api.github.com/repos/4teamwork/ftw.participation/pulls/17"}}}}

{"repository":{"description":"Invite other users (registered or unregistered) to a context in plone.","homepage":"","watchers":1,"stargazers":1,"forks":0,"fork":false,"size":1168,"owner":"4teamwork","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-12-01T09:08:58-08:00","pushed_at":"2013-12-11T14:25:58-08:00","master_branch":"master","organization":"4teamwork"},"actor_attributes":{"type":"User","name":"Jonas Baumann","company":"4teamwork AG","blog":"http://github.com/4teamwork","location":"Bern, Switzerland","email":"[email protected]"},"url":"https://github.com/4teamwork/ftw.participation/pull/17#discussion_r8284496"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/4teamwork/ftw.workspace/pulls/comments/7338188","id":7338188,"diff_hunk":"@@ -117,17 +125,19 @@ msgstr \"Typ\"\n \n #. Default: \"Text\"\n #: ./ftw/workspace/content/folder_extender.py:32\n-#: ./ftw/workspace/content/workspace.py:30\n+#: ./ftw/workspace/content/workspace.py:32\n msgid \"label_text\"\n msgstr \"Text\"\n \n-#. Default: \"today\"\n-#: ./ftw/workspace/browser/overview.py:115\n+#. Default: \"Today, ${time}\"\n+#: ./ftw/workspace/browser/overview.py:129\n+#, fuzzy","path":"ftw/workspace/locales/de/LC_MESSAGES/ftw.workspace.po","position":116,"original_position":116,"commit_id":"345771b8fb91d81be2fc87800c4f310e52575dc3","original_commit_id":"345771b8fb91d81be2fc87800c4f310e52575dc3","user":{"login":"maethu","id":437933,"avatar_url":"https://0.gravatar.com/avatar/18df112ba3654190d3d30a714040cc27?d=https%3A%2F%2Fidenticons.github.com%2F73b291e726ec082a0801935046642817.png&r=x","gravatar_id":"18df112ba3654190d3d30a714040cc27","url":"https://api.github.com/users/maethu","html_url":"https://github.com/maethu","followers_url":"https://api.github.com/users/maethu/followers","following_url":"https://api.github.com/users/maethu/following{/other_user}","gists_url":"https://api.github.com/users/maethu/gists{/gist_id}","starred_url":"https://api.github.com/users/maethu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maethu/subscriptions","organizations_url":"https://api.github.com/users/maethu/orgs","repos_url":"https://api.github.com/users/maethu/repos","events_url":"https://api.github.com/users/maethu/events{/privacy}","received_events_url":"https://api.github.com/users/maethu/received_events","type":"User","site_admin":false},"body":"awww...","created_at":"2013-10-31T10:23:51Z","updated_at":"2013-10-31T10:23:51Z","html_url":"https://github.com/4teamwork/ftw.workspace/pull/22#discussion_r7338188","pull_request_url":"https://api.github.com/repos/4teamwork/ftw.workspace/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/4teamwork/ftw.workspace/pulls/comments/7338188"},"html":{"href":"https://github.com/4teamwork/ftw.workspace/pull/22#discussion_r7338188"},"pull_request":{"href":"https://api.github.com/repos/4teamwork/ftw.workspace/pulls/22"}}}}

{"repository":{"description":"A project folder for plone.","homepage":"","watchers":3,"stargazers":3,"forks":0,"fork":false,"size":833,"owner":"4teamwork","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-11-30T06:47:20-08:00","pushed_at":"2013-10-30T01:36:12-07:00","master_branch":"master","organization":"4teamwork"},"actor_attributes":{"type":"User","name":"Mathias Leimgruber","company":"4teamwork AG","location":"Bern (Switzerland)","email":"[email protected]"},"url":"https://github.com/4teamwork/ftw.workspace/pull/22#discussion_r7338188"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments/6819005","id":6819005,"diff_hunk":"@@ -139,6 +139,24 @@ def home_dir\n @home_dir ||= Pathname.new(ENV['CP_HOME_DIR'] || \"~/.cocoapods\").expand_path\n end\n \n+ # @return [Pathname] the directory where a given CocoaPods source is stored.\n+ #\n+ def source_repo_dir(name)\n+ self.repos_dir = self.repos_dir + name\n+ end\n+\n+ # @return [<Array>Pathname] directories of all specified sources in Podfile\n+ #\n+ def podfile_repos_dirs","path":"lib/cocoapods/config.rb","position":12,"original_position":12,"commit_id":"49731e9a03e0cc3289b7bc1b81e172558a3c2bdd","original_commit_id":"49731e9a03e0cc3289b7bc1b81e172558a3c2bdd","user":{"login":"irrationalfab","id":1048705,"avatar_url":"https://2.gravatar.com/avatar/b6dde1a78e6215a592768c1e78a54adc?d=https%3A%2F%2Fidenticons.github.com%2Fbdc4e72be51d566c2fc9564ed8182611.png","gravatar_id":"b6dde1a78e6215a592768c1e78a54adc","url":"https://api.github.com/users/irrationalfab","html_url":"https://github.com/irrationalfab","followers_url":"https://api.github.com/users/irrationalfab/followers","following_url":"https://api.github.com/users/irrationalfab/following{/other_user}","gists_url":"https://api.github.com/users/irrationalfab/gists{/gist_id}","starred_url":"https://api.github.com/users/irrationalfab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irrationalfab/subscriptions","organizations_url":"https://api.github.com/users/irrationalfab/orgs","repos_url":"https://api.github.com/users/irrationalfab/repos","events_url":"https://api.github.com/users/irrationalfab/events{/privacy}","received_events_url":"https://api.github.com/users/irrationalfab/received_events","type":"User","site_admin":false},"body":"I would move this to the Analyzer.","created_at":"2013-10-08T07:54:14Z","updated_at":"2013-10-08T07:54:14Z","html_url":"https://github.com/CocoaPods/CocoaPods/pull/1143#discussion_r6819005","pull_request_url":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/1143","_links":{"self":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/comments/6819005"},"html":{"href":"https://github.com/CocoaPods/CocoaPods/pull/1143#discussion_r6819005"},"pull_request":{"href":"https://api.github.com/repos/CocoaPods/CocoaPods/pulls/1143"}}}}

{"repository":{"description":"The Objective-C library dependency manager.","homepage":"cocoapods.org","watchers":3149,"stargazers":3149,"forks":428,"fork":false,"size":38424,"owner":"CocoaPods","private":false,"open_issues":106,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2011-08-13T17:10:53-07:00","pushed_at":"2013-10-07T09:27:38-07:00","master_branch":"master","organization":"CocoaPods"},"actor_attributes":{"type":"User","name":"Fabio Pelosin","company":"Discontinuity","blog":"https://twitter.com/fabiopelosin","location":"Italy","email":"[email protected]"},"url":"https://github.com/CocoaPods/CocoaPods/pull/1143#discussion_r6819005"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/CocoaPods/pod-template/pulls/comments/7092148","id":7092148,"diff_hunk":"@@ -55,14 +59,40 @@ task :release do\n sh \"rake spec\"\n \n puts \"* Linting the podspec\"\n- sh \"pod lib lint\"\n+# sh \"pod lib lint\"\n \n # Then release\n+ \n+ # If we have no origin set (perhaps new branch) configure git ","path":"Rakefile","position":27,"original_position":27,"commit_id":"6920b960b50039cbff1da08ba23f697b3b333889","original_commit_id":"6920b960b50039cbff1da08ba23f697b3b333889","user":{"login":"irrationalfab","id":1048705,"avatar_url":"https://0.gravatar.com/avatar/b6dde1a78e6215a592768c1e78a54adc?d=https%3A%2F%2Fidenticons.github.com%2Fbdc4e72be51d566c2fc9564ed8182611.png","gravatar_id":"b6dde1a78e6215a592768c1e78a54adc","url":"https://api.github.com/users/irrationalfab","html_url":"https://github.com/irrationalfab","followers_url":"https://api.github.com/users/irrationalfab/followers","following_url":"https://api.github.com/users/irrationalfab/following{/other_user}","gists_url":"https://api.github.com/users/irrationalfab/gists{/gist_id}","starred_url":"https://api.github.com/users/irrationalfab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irrationalfab/subscriptions","organizations_url":"https://api.github.com/users/irrationalfab/orgs","repos_url":"https://api.github.com/users/irrationalfab/repos","events_url":"https://api.github.com/users/irrationalfab/events{/privacy}","received_events_url":"https://api.github.com/users/irrationalfab/received_events","type":"User","site_admin":false},"body":"That would be a graceful way to handle it, as I am all in for elegant software: :+ ","created_at":"2013-10-21T12:46:04Z","updated_at":"2013-10-21T12:46:04Z","html_url":"https://github.com/CocoaPods/pod-template/pull/10#discussion_r7092148","pull_request_url":"https://api.github.com/repos/CocoaPods/pod-template/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/CocoaPods/pod-template/pulls/comments/7092148"},"html":{"href":"https://github.com/CocoaPods/pod-template/pull/10#discussion_r7092148"},"pull_request":{"href":"https://api.github.com/repos/CocoaPods/pod-template/pulls/10"}}}}

{"repository":{"description":"An opinionated template for creating a Pod.","watchers":17,"stargazers":17,"forks":2,"fork":false,"size":185,"owner":"CocoaPods","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-04-16T14:18:37-07:00","pushed_at":"2013-08-16T12:57:57-07:00","master_branch":"master","organization":"CocoaPods"},"actor_attributes":{"type":"User","name":"Fabio Pelosin","company":"Discontinuity","blog":"https://twitter.com/fabiopelosin","location":"Italy","email":"[email protected]"},"url":"https://github.com/CocoaPods/pod-template/pull/10#discussion_r7092148"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/HouseTrip/integrity/pulls/comments/5418889","id":5418889,"body":"Weren't we supposed to load these from config file?","diff_hunk":"@@ -8,30 +8,29 @@\n \n require \"integrity\"\n \n-auth = YAML.load_file(File.expand_path('../config/auth.yml', __FILE__))\n+# auth = YAML.load_file(File.expand_path('config/auth.yml', __FILE__))\n \n Integrity.env = ENV['INTEGRITY_ENV'] || 'development'\n \n-#case Integrity.env\n-#when 'development'\n-# HOST = \"127.0.0.1\"\n-#when 'production'\n+case Integrity.env\n+when 'development'\n+ HOST = \"127.0.0.1\"\n+when 'production'\n HOST = \"integrity.housetripdev.com\"\n-#end\n+end\n \n Integrity.configure do |c|\n c.database = \"mysql://root@#{HOST}/integrity\"\n c.directory = \"builds\"\n c.base_url = \"http://#{HOST}\"\n c.log = \"log/integrity.app.log\"\n- c.github_token = auth['authentication'][:github_token]\n+ c.github_token = \"9D615729-F85A-4688-AA53-439B91455623\"\n+ c.github_key = \"f3afbc0e09945abe5af2\"\n+ c.github_secret = \"cc7d26b6460d2a5a163e327195b5d53ef12ffa1a\"","path":"init.rb","position":29,"original_position":29,"commit_id":"0bcebb5ba8fda03fb8332db99d5500a7a74aa2ad","original_commit_id":"0bcebb5ba8fda03fb8332db99d5500a7a74aa2ad","user":{"login":"dawid-sklodowski","id":459346,"avatar_url":"https://secure.gravatar.com/avatar/073c19a8d1fd30baa6dba34eaa55fe90?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"073c19a8d1fd30baa6dba34eaa55fe90","url":"https://api.github.com/users/dawid-sklodowski","html_url":"https://github.com/dawid-sklodowski","followers_url":"https://api.github.com/users/dawid-sklodowski/followers","following_url":"https://api.github.com/users/dawid-sklodowski/following{/other_user}","gists_url":"https://api.github.com/users/dawid-sklodowski/gists{/gist_id}","starred_url":"https://api.github.com/users/dawid-sklodowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawid-sklodowski/subscriptions","organizations_url":"https://api.github.com/users/dawid-sklodowski/orgs","repos_url":"https://api.github.com/users/dawid-sklodowski/repos","events_url":"https://api.github.com/users/dawid-sklodowski/events{/privacy}","received_events_url":"https://api.github.com/users/dawid-sklodowski/received_events","type":"User"},"created_at":"2013-07-26T09:18:10Z","updated_at":"2013-07-26T09:18:10Z","html_url":"https://github.com/HouseTrip/integrity/pull/40#discussion_r5418889","pull_request_url":"https://api.github.com/repos/HouseTrip/integrity/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/HouseTrip/integrity/pulls/comments/5418889"},"html":{"href":"https://github.com/HouseTrip/integrity/pull/40#discussion_r5418889"},"pull_request":{"href":"https://api.github.com/repos/HouseTrip/integrity/pulls/40"}}}}

{"repository":{"description":"Continuous Integration server","homepage":"http://integrityapp.com","watchers":2,"stargazers":2,"forks":1,"fork":true,"size":6902,"owner":"HouseTrip","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2012-02-08T06:54:14-08:00","pushed_at":"2013-07-26T02:12:07-07:00","integrate_branch":"master","master_branch":"master","organization":"HouseTrip"},"actor_attributes":{"type":"User","name":"Dawid Sklodowski","company":"HouseTrip","blog":"http://www.onceuponaline.info","location":"London","email":"[email protected]"},"url":"https://github.com/HouseTrip/integrity/pull/40#discussion_r5418889"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/Islandora/islandora/pulls/comments/4498860","id":4498860,"body":"Ya but as I said before Smith's use case requires copying from \"ingested\" data-stream's, that belonging to NewFedoraObjects which have not yet been ingested.","diff_hunk":"@@ -952,6 +952,63 @@ function islandora_add_object(AbstractObject &$object) {\n }\n \n /**\n+ * Creates a new object with the same properties as the old.\n+ *\n+ * @todo Make Tuque objects support cloneing.\n+ *\n+ * @param AbstractObject $object\n+ * An existing or new Fedora Object.\n+ *\n+ * @return AbstractObject\n+ * The new Fedora Object with properties identical to the object given. This\n+ * returned object is not automatically ingested.\n+ */\n+function islandora_copy_object(AbstractObject $object) {\n+ $clone = $object->repository->constructObject($object->id);\n+ $object_properties = array(\n+ 'state',\n+ 'createdDate',\n+ 'lastModifiedDate',\n+ 'label',\n+ 'owner',\n+ 'logMessage',\n+ );\n+ // Copy Properties.\n+ foreach ($object_properties as $property) {\n+ if (isset($object->$property)) {\n+ $clone->$property = $object->$property;\n+ }\n+ }\n+ $datastream_properties = array(\n+ 'label',\n+ 'versionable',\n+ 'state',\n+ 'mimetype',\n+ 'format',\n+ 'size',\n+ 'checksum',\n+ 'checksumType',\n+ 'createdDate',\n+ 'content',\n+ 'url',\n+ 'location',\n+ );\n+ // Copy Datastreams.\n+ foreach ($object as $dsid => $datastream) {\n+ if (empty($clone[$dsid])) {\n+ $ds = $clone->constructDatastream($dsid, $datastream->controlGroup);\n+ $clone->ingestDatastream($ds);","path":"islandora.module","position":49,"original_position":49,"commit_id":"59f8744a4317dbe4f7ce7cdecd209ea0f720e1f2","original_commit_id":"59f8744a4317dbe4f7ce7cdecd209ea0f720e1f2","user":{"login":"nigelgbanks","id":487373,"avatar_url":"https://secure.gravatar.com/avatar/bec82eec5febf14afea7e29b8e789fdf?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"bec82eec5febf14afea7e29b8e789fdf","url":"https://api.github.com/users/nigelgbanks","html_url":"https://github.com/nigelgbanks","followers_url":"https://api.github.com/users/nigelgbanks/followers","following_url":"https://api.github.com/users/nigelgbanks/following{/other_user}","gists_url":"https://api.github.com/users/nigelgbanks/gists{/gist_id}","starred_url":"https://api.github.com/users/nigelgbanks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigelgbanks/subscriptions","organizations_url":"https://api.github.com/users/nigelgbanks/orgs","repos_url":"https://api.github.com/users/nigelgbanks/repos","events_url":"https://api.github.com/users/nigelgbanks/events{/privacy}","received_events_url":"https://api.github.com/users/nigelgbanks/received_events","type":"User"},"created_at":"2013-06-03T13:16:33Z","updated_at":"2013-06-03T13:16:33Z","html_url":"https://github.com/Islandora/islandora/pull/341#discussion_r4498860","pull_request_url":"https://api.github.com/repos/Islandora/islandora/pulls/341","_links":{"self":{"href":"https://api.github.com/repos/Islandora/islandora/pulls/comments/4498860"},"html":{"href":"https://github.com/Islandora/islandora/pull/341#discussion_r4498860"},"pull_request":{"href":"https://api.github.com/repos/Islandora/islandora/pulls/341"}}}}

{"repository":{"description":"A Drupal module for browsing and managing Fedora-based digital repositories","homepage":"http://islandora.ca/","watchers":51,"stargazers":51,"forks":38,"fork":true,"size":780,"owner":"Islandora","private":false,"open_issues":5,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2010-11-23T13:56:01-08:00","pushed_at":"2013-06-03T05:59:39-07:00","master_branch":"7.x","organization":"Islandora"},"actor_attributes":{"type":"User","name":"Nigel Banks","company":"Discovery Garden Inc.","blog":"nigelbanks.ca","location":"Canada","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Islandora/islandora/pull/341#discussion_r4498860"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/Islandora/islandora/pulls/comments/3859498","id":3859498,"body":"This moves the already selected content models to the top of the display.","diff_hunk":"@@ -738,3 +751,54 @@ function islandora_get_content_models($ignore_system_namespace = TRUE) {\n }\n return $content_models;\n }\n+\n+/**\n+ * Returns Drupal tableselect element allowing selection of Content Models.\n+ *\n+ * @param string $drupal_variable\n+ * the name of the Drupal variable holding selected content models\n+ * Content models held in this variable will appear at the top of\n+ * the displayed list\n+ *\n+ * @return array\n+ * Drupal form element allowing content model selection\n+ */\n+function islandora_content_model_select_table_form_element($drupal_variable) {\n+ $defaults = array();\n+ $rows = array();\n+ $content_models = array();\n+\n+ $options = islandora_get_content_models(TRUE);\n+ foreach ($options as $option) {\n+ $content_models[$option['pid']] = $option['label'];\n+ }\n+\n+ $selected = array_values(variable_get($drupal_variable, array('')));\n+ foreach ($selected as $selection) {\n+ if (isset($content_models[$selection])) {\n+ $content_models = array($selection => $content_models[$selection]) + $content_models;\n+ }\n+ }","path":"includes/utilities.inc","position":66,"original_position":66,"commit_id":"69ce869b818dcd9bfad37bed2879160755541913","original_commit_id":"69ce869b818dcd9bfad37bed2879160755541913","user":{"login":"ajstanley","id":494887,"avatar_url":"https://secure.gravatar.com/avatar/1686c1e52a1155f2f75298d54b999044?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"1686c1e52a1155f2f75298d54b999044","url":"https://api.github.com/users/ajstanley","html_url":"https://github.com/ajstanley","followers_url":"https://api.github.com/users/ajstanley/followers","following_url":"https://api.github.com/users/ajstanley/following","gists_url":"https://api.github.com/users/ajstanley/gists{/gist_id}","starred_url":"https://api.github.com/users/ajstanley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajstanley/subscriptions","organizations_url":"https://api.github.com/users/ajstanley/orgs","repos_url":"https://api.github.com/users/ajstanley/repos","events_url":"https://api.github.com/users/ajstanley/events{/privacy}","received_events_url":"https://api.github.com/users/ajstanley/received_events","type":"User"},"created_at":"2013-04-18T17:55:57Z","updated_at":"2013-04-18T17:55:57Z","html_url":"https://github.com/Islandora/islandora/pull/307#discussion_r3859498","pull_request_url":"https://api.github.com/repos/Islandora/islandora/pulls/307","_links":{"self":{"href":"https://api.github.com/repos/Islandora/islandora/pulls/comments/3859498"},"html":{"href":"https://github.com/Islandora/islandora/pull/307#discussion_r3859498"},"pull_request":{"href":"https://api.github.com/repos/Islandora/islandora/pulls/307"}}}}

{"repository":{"description":"A Drupal module for browsing and managing Fedora-based digital repositories","homepage":"http://islandora.ca/","watchers":47,"stargazers":47,"forks":38,"fork":true,"size":816,"owner":"Islandora","private":false,"open_issues":3,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2010-11-23T13:56:01-08:00","pushed_at":"2013-04-15T06:53:56-07:00","master_branch":"7.x","organization":"Islandora"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Islandora/islandora/pull/307#discussion_r3859498"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/4493137","id":4493137,"body":"Can do.","diff_hunk":"@@ -30,3 +30,4 @@\n \n /usr\n /COMMIT\n+/contrib/vagrant/.vagrant","path":".gitignore","position":4,"original_position":4,"commit_id":"1cf9747cc22973edbec210e1639370096e8a531b","original_commit_id":"1cf9747cc22973edbec210e1639370096e8a531b","user":{"login":"pao","id":140497,"avatar_url":"https://secure.gravatar.com/avatar/16d8443194c380ca93a77fb8530a5aee?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"16d8443194c380ca93a77fb8530a5aee","url":"https://api.github.com/users/pao","html_url":"https://github.com/pao","followers_url":"https://api.github.com/users/pao/followers","following_url":"https://api.github.com/users/pao/following{/other_user}","gists_url":"https://api.github.com/users/pao/gists{/gist_id}","starred_url":"https://api.github.com/users/pao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pao/subscriptions","organizations_url":"https://api.github.com/users/pao/orgs","repos_url":"https://api.github.com/users/pao/repos","events_url":"https://api.github.com/users/pao/events{/privacy}","received_events_url":"https://api.github.com/users/pao/received_events","type":"User"},"created_at":"2013-06-03T01:20:43Z","updated_at":"2013-06-03T01:20:43Z","html_url":"https://github.com/JuliaLang/julia/pull/3266#discussion_r4493137","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/3266","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/4493137"},"html":{"href":"https://github.com/JuliaLang/julia/pull/3266#discussion_r4493137"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/3266"}}}}

{"repository":{"description":"The Julia Language: A fresh approach to technical computing.","homepage":"http://julialang.org/","watchers":2201,"stargazers":2201,"forks":398,"fork":false,"size":8072,"owner":"JuliaLang","private":false,"open_issues":408,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Julia","created_at":"2011-04-21T00:01:50-07:00","pushed_at":"2013-06-02T17:44:50-07:00","master_branch":"master","organization":"JuliaLang"},"actor_attributes":{"type":"User","name":"Patrick O'Leary","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/JuliaLang/julia/pull/3266#discussion_r4493137"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/JuliaLang/RPMmd.jl/pulls/comments/5859902","id":5859902,"body":"probably best to do a `Pkg.update()` here","diff_hunk":"@@ -380,6 +388,37 @@ function help()\n less(Pkg.dir(\"RPMmd\",\"README.md\"))\n end\n \n+# BinDeps integration\n+\n+using BinDeps\n+import BinDeps: PackageManager, can_use, package_available, available_version, libdir, generate_steps, LibraryDependency, provider\n+\n+type RPM <: PackageManager \n+ package\n+end\n+can_use(::Type{RPM}) = OS_NAME == :Windows\n+function package_available(p::RPM) \n+ !can_use(RPM) && return false\n+ pkgs = p.package\n+ if isa(pkgs,String)\n+ pkgs = [pkgs]\n+ end\n+ return all(pkg->(length(lookup(pkg).p) > 0),pkgs)","path":"src/RPMmd.jl","position":48,"original_position":48,"commit_id":"9987ebb6aed3cef16ab17cf198cfb41718f450bd","original_commit_id":"9987ebb6aed3cef16ab17cf198cfb41718f450bd","user":{"login":"vtjnash","id":330950,"avatar_url":"https://0.gravatar.com/avatar/8af4d5971a2308b86a94f58fb98129c5?d=https%3A%2F%2Fidenticons.github.com%2F5d5113de843c8b258029d6a06bccd163.png","gravatar_id":"8af4d5971a2308b86a94f58fb98129c5","url":"https://api.github.com/users/vtjnash","html_url":"https://github.com/vtjnash","followers_url":"https://api.github.com/users/vtjnash/followers","following_url":"https://api.github.com/users/vtjnash/following{/other_user}","gists_url":"https://api.github.com/users/vtjnash/gists{/gist_id}","starred_url":"https://api.github.com/users/vtjnash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtjnash/subscriptions","organizations_url":"https://api.github.com/users/vtjnash/orgs","repos_url":"https://api.github.com/users/vtjnash/repos","events_url":"https://api.github.com/users/vtjnash/events{/privacy}","received_events_url":"https://api.github.com/users/vtjnash/received_events","type":"User"},"created_at":"2013-08-20T03:24:31Z","updated_at":"2013-08-20T03:24:31Z","html_url":"https://github.com/JuliaLang/RPMmd.jl/pull/4#discussion_r5859902","pull_request_url":"https://api.github.com/repos/JuliaLang/RPMmd.jl/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/RPMmd.jl/pulls/comments/5859902"},"html":{"href":"https://github.com/JuliaLang/RPMmd.jl/pull/4#discussion_r5859902"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/RPMmd.jl/pulls/4"}}}}

{"repository":{"description":"RPM-md processing library","watchers":0,"stargazers":0,"forks":2,"fork":false,"size":80,"owner":"JuliaLang","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Julia","created_at":"2013-05-25T19:31:56-07:00","pushed_at":"2013-07-07T01:24:17-07:00","master_branch":"master","organization":"JuliaLang"},"actor_attributes":{"type":"User","name":"Jameson Nash","blog":"","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/JuliaLang/RPMmd.jl/pull/4#discussion_r5859902"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/7799806","id":7799806,"diff_hunk":"@@ -525,53 +476,41 @@ eigvals(x::Number) = [one(x)]\n #Computes maximum and minimum eigenvalue\n function eigmax(A::Union(Number, AbstractMatrix))\n v = eigvals(A)\n- iseltype(v,Complex) ? error(\"complex eigenvalues cannot be ordered\") : maximum(v)\n+ iseltype(v,Complex) ? error(\"DomainError: complex eigenvalues cannot be ordered\") : maximum(v)","path":"base/linalg/factorization.jl","position":561,"original_position":561,"commit_id":"52a1f6c642c9937fb16fac8766316e3d0142029a","original_commit_id":"4fa5c32ac4fa7d66d1a125a09af0fbde05211a6f","user":{"login":"jiahao","id":1732,"avatar_url":"https://0.gravatar.com/avatar/6cba33e8e7c69fa63f6ad386b7a958c5?d=https%3A%2F%2Fidenticons.github.com%2F270edd69788dce200a3b395a6da6fdb7.png&r=x","gravatar_id":"6cba33e8e7c69fa63f6ad386b7a958c5","url":"https://api.github.com/users/jiahao","html_url":"https://github.com/jiahao","followers_url":"https://api.github.com/users/jiahao/followers","following_url":"https://api.github.com/users/jiahao/following{/other_user}","gists_url":"https://api.github.com/users/jiahao/gists{/gist_id}","starred_url":"https://api.github.com/users/jiahao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiahao/subscriptions","organizations_url":"https://api.github.com/users/jiahao/orgs","repos_url":"https://api.github.com/users/jiahao/repos","events_url":"https://api.github.com/users/jiahao/events{/privacy}","received_events_url":"https://api.github.com/users/jiahao/received_events","type":"User","site_admin":false},"body":"@andreasnoackjensen I agree with the sentiment, but didn’t implement it that way because of the reason @ivarne pointed out. This is really a placeholder until that gets fixed.","created_at":"2013-11-20T18:11:16Z","updated_at":"2013-11-20T18:11:16Z","html_url":"https://github.com/JuliaLang/julia/pull/4830#discussion_r7799806","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/4830","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/7799806"},"html":{"href":"https://github.com/JuliaLang/julia/pull/4830#discussion_r7799806"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/4830"}}}}

{"repository":{"description":"The Julia Language: A fresh approach to technical computing.","homepage":"http://julialang.org/","watchers":2699,"stargazers":2699,"forks":521,"fork":false,"size":77823,"owner":"JuliaLang","private":false,"open_issues":501,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Julia","created_at":"2011-04-21T00:01:50-07:00","pushed_at":"2013-11-20T08:03:20-08:00","master_branch":"master","organization":"JuliaLang"},"actor_attributes":{"type":"User","name":"Jiahao Chen","company":"MIT","blog":"http://theochem.mit.edu","location":"Cambridge, MA","email":"[email protected]"},"url":"https://github.com/JuliaLang/julia/pull/4830#discussion_r7799806"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/Normation/cf-clerk/pulls/comments/3296917","id":3296917,"body":"I would prefer the object name to be the same as the root trait, ie: DisplayPriority\r\n","diff_hunk":"@@ -364,3 +364,30 @@ object SectionVariableSpec {\n }\n }\n \n+/**\n+ * A trait to describe the display priority, which represents when the\n+ * section will be shown (when we are high priority ? low ?), with a default\n+ * to high\n+ */\n+trait DisplayPriority {\n+ def priority : String\n+}\n+\n+final case object HighDisplayPriority extends DisplayPriority {\n+ val priority = \"high\"\n+}\n+\n+final case object LowDisplayPriority extends DisplayPriority {\n+ val priority = \"low\"\n+}\n+\n+\n+object DisplayPriorityFactory {","path":"src/main/scala/com/normation/cfclerk/domain/VariableAndSectionSpec.scala","position":43,"original_position":43,"commit_id":"689d06c2026d0ffa23d57d82163d504bb2cca9ba","original_commit_id":"689d06c2026d0ffa23d57d82163d504bb2cca9ba","user":{"login":"fanf","id":44649,"avatar_url":"https://secure.gravatar.com/avatar/91812763826e2319128c245b94dc78e5?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"91812763826e2319128c245b94dc78e5","url":"https://api.github.com/users/fanf","html_url":"https://github.com/fanf","followers_url":"https://api.github.com/users/fanf/followers","following_url":"https://api.github.com/users/fanf/following","gists_url":"https://api.github.com/users/fanf/gists{/gist_id}","starred_url":"https://api.github.com/users/fanf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fanf/subscriptions","organizations_url":"https://api.github.com/users/fanf/orgs","repos_url":"https://api.github.com/users/fanf/repos","events_url":"https://api.github.com/users/fanf/events{/privacy}","received_events_url":"https://api.github.com/users/fanf/received_events","type":"User"},"created_at":"2013-03-08T13:03:40Z","updated_at":"2013-03-08T13:03:40Z","_links":{"self":{"href":"https://api.github.com/repos/Normation/cf-clerk/pulls/comments/3296917"},"html":{"href":"https://github.com/Normation/cf-clerk/pull/8#discussion_r3296917"},"pull_request":{"href":"https://api.github.com/repos/Normation/cf-clerk/pulls/8"}}}}

{"repository":{"description":"","homepage":"http://www.rudder-project.org/","watchers":1,"stargazers":1,"forks":3,"fork":false,"size":292,"owner":"Normation","private":false,"open_issues":3,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Scala","created_at":"2011-10-06T12:24:42-07:00","pushed_at":"2013-02-23T03:57:45-08:00","master_branch":"master","organization":"Normation"},"actor_attributes":{"type":"User","name":"Francois Armand","blog":"http://fanf42.blogspot.com","location":"France / Paris","email":"[email protected]"},"url":"https://github.com/Normation/cf-clerk/pull/8#discussion_r3296917"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/RT-Thread/rt-thread/pulls/comments/6990828","id":6990828,"diff_hunk":"@@ -208,4 +208,21 @@ int cmd_free(int argc, char** argv)\n }\n FINSH_FUNCTION_EXPORT_ALIAS(cmd_free, __cmd_free, \"show the memory usage in the system\");\n \n+// --------------------------------------------------------------------------\n+#ifdef MSH_USING_LINUX\n+int cli_list(int argc, char **argv)\n+{\n+\treturn msh_help(argc, argv);\n+}\n+FINSH_FUNCTION_EXPORT_ALIAS(cli_list, __cmd_list, \"list rtt support commands\");","path":"components/finsh/msh_cmd.c","position":10,"original_position":10,"commit_id":"71968876a2602e8bae3998f5e2e4b8cc5584cdfe","original_commit_id":"71968876a2602e8bae3998f5e2e4b8cc5584cdfe","user":{"login":"BernardXiong","id":1241087,"avatar_url":"https://1.gravatar.com/avatar/bd1b96645c5209dbff0a54536f8238a6?d=https%3A%2F%2Fidenticons.github.com%2F1b292347da67bd2d126788b7bebf02f7.png","gravatar_id":"bd1b96645c5209dbff0a54536f8238a6","url":"https://api.github.com/users/BernardXiong","html_url":"https://github.com/BernardXiong","followers_url":"https://api.github.com/users/BernardXiong/followers","following_url":"https://api.github.com/users/BernardXiong/following{/other_user}","gists_url":"https://api.github.com/users/BernardXiong/gists{/gist_id}","starred_url":"https://api.github.com/users/BernardXiong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BernardXiong/subscriptions","organizations_url":"https://api.github.com/users/BernardXiong/orgs","repos_url":"https://api.github.com/users/BernardXiong/repos","events_url":"https://api.github.com/users/BernardXiong/events{/privacy}","received_events_url":"https://api.github.com/users/BernardXiong/received_events","type":"User","site_admin":false},"body":"Please do not use rtt for RT-Thread. Please use full and regular name. ","created_at":"2013-10-16T01:57:45Z","updated_at":"2013-10-16T01:57:45Z","html_url":"https://github.com/RT-Thread/rt-thread/pull/176#discussion_r6990828","pull_request_url":"https://api.github.com/repos/RT-Thread/rt-thread/pulls/176","_links":{"self":{"href":"https://api.github.com/repos/RT-Thread/rt-thread/pulls/comments/6990828"},"html":{"href":"https://github.com/RT-Thread/rt-thread/pull/176#discussion_r6990828"},"pull_request":{"href":"https://api.github.com/repos/RT-Thread/rt-thread/pulls/176"}}}}

{"repository":{"description":"RT-Thread open source operating system.","watchers":75,"stargazers":75,"forks":93,"fork":false,"size":68410,"owner":"RT-Thread","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2013-01-02T06:49:21-08:00","pushed_at":"2013-10-14T16:24:03-07:00","master_branch":"master","organization":"RT-Thread"},"actor_attributes":{"type":"User","name":"Bernard Xiong","company":"Shanghai Real-Thread Inc.","blog":"http://en.rt-thread.org","location":"Shanghai China","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/RT-Thread/rt-thread/pull/176#discussion_r6990828"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/RiotGames/berkshelf-api/pulls/comments/4219664","id":4219664,"body":":+1:, also this pattern is very common when using the Zlib library. I can't believe there's no helper function.","diff_hunk":"@@ -0,0 +1,85 @@\n+module Berkshelf::API\n+ module SiteConnector\n+ # @author Andrew Garson <[email protected]>\n+ class Opscode\n+\n+ include Celluloid\n+\n+ attr_reader :connection\n+\n+ # @param [Faraday::Connection] connection \n+ # Optional parameter for setting the connection object\n+ # This should only be set manually for testing\n+ def initialize()\n+ @connection = Faraday.new(\"http://cookbooks.opscode.com\") do |c|\n+ c.use FaradayMiddleware::ParseJson, content_type: 'application/json'\n+ c.use Faraday::Adapter::NetHttp\n+ end\n+ end\n+\n+ # @return [Array<String>]\n+ # A list of cookbook names available on the server\n+ def all_cookbooks\n+ count = connection.get(\"/api/v1/cookbooks?start=0&items=0\").body[\"total\"]\n+ cookbooks = connection.get(\"/api/v1/cookbooks?start=0&items=#{count}\").body[\"items\"]\n+ cookbooks.map { |cb| cb[\"cookbook_name\"] }\n+ end\n+\n+ # @param [String] cookbook\n+ # the name of the cookbook to find version for\n+ #\n+ # @return [Array<String>]\n+ # A list of versions of this cookbook available on the server\n+ def all_versions(cookbook)\n+ versions = connection.get(\"/api/v1/cookbooks/#{cookbook}\").body[\"versions\"]\n+ versions.map { |version| version.split(\"/\").last.gsub(\"_\", \".\") }\n+ end\n+\n+ # @param [String] cookbook \n+ # The name of the cookbook to download\n+ # @param [String] version \n+ # The version of the cookbook to download\n+ # @param [String] destination\n+ # The directory to download the cookbook to\n+ #\n+ # @return [void]\n+ def download(cookbook, version, destination)\n+ version_data = connection.get(\"/api/v1/cookbooks/#{cookbook}/versions/#{version.gsub(\".\", \"_\")}\").body\n+ uri = version_data[\"file\"]\n+ tgz = StringIO.new(Faraday.get(uri).body)\n+ tar = ungzip(tgz)\n+ untar(tar, destination)\n+ end\n+\n+ private\n+\n+ # Shamelessly stolen from \n+ # https://gist.github.com/sinisterchipmunk/1335041\n+ def ungzip(tarfile)\n+ z = Zlib::GzipReader.new(tarfile)","path":"lib/berkshelf/api/site_connector/opscode.rb","position":59,"original_position":59,"commit_id":"389bb1309ec07f702ae0c32d3ee283b9c66fcdc0","original_commit_id":"389bb1309ec07f702ae0c32d3ee283b9c66fcdc0","user":{"login":"reset","id":54036,"avatar_url":"https://secure.gravatar.com/avatar/3d82f244760ff3e9e4151e5f5c0c0026?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"3d82f244760ff3e9e4151e5f5c0c0026","url":"https://api.github.com/users/reset","html_url":"https://github.com/reset","followers_url":"https://api.github.com/users/reset/followers","following_url":"https://api.github.com/users/reset/following{/other_user}","gists_url":"https://api.github.com/users/reset/gists{/gist_id}","starred_url":"https://api.github.com/users/reset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reset/subscriptions","organizations_url":"https://api.github.com/users/reset/orgs","repos_url":"https://api.github.com/users/reset/repos","events_url":"https://api.github.com/users/reset/events{/privacy}","received_events_url":"https://api.github.com/users/reset/received_events","type":"User"},"created_at":"2013-05-14T18:19:41Z","updated_at":"2013-05-14T18:19:41Z","html_url":"https://github.com/RiotGames/berkshelf-api/pull/2#discussion_r4219664","pull_request_url":"https://api.github.com/repos/RiotGames/berkshelf-api/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/RiotGames/berkshelf-api/pulls/comments/4219664"},"html":{"href":"https://github.com/RiotGames/berkshelf-api/pull/2#discussion_r4219664"},"pull_request":{"href":"https://api.github.com/repos/RiotGames/berkshelf-api/pulls/2"}}}}

{"repository":{"description":"Berkshelf dependency API server","homepage":"berkshelf.com","watchers":2,"stargazers":2,"forks":0,"fork":false,"size":492,"owner":"RiotGames","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-05-05T23:34:58-07:00","pushed_at":"2013-05-14T10:38:59-07:00","master_branch":"master","organization":"RiotGames"},"actor_attributes":{"type":"User","name":"Jamie Winsor","company":"Riot Games","blog":"vialstudios.com","location":"Santa Monica, CA","email":"[email protected]"},"url":"https://github.com/RiotGames/berkshelf-api/pull/2#discussion_r4219664"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/Work4Labs/pynagiosplugins/pulls/comments/3441272","id":3441272,"body":"Don't get why people wouldn't do\r\n\r\n def compute_message(self):\r\n # Do stuff\r\n message = super().compute_message()\r\n # Do more stuff\r\n return message\r\n\r\nwhich should remove the need for this method? Inheritance doesn't seem to be properly used here.","diff_hunk":"@@ -60,14 +61,48 @@ def compute(self):\n \n # Handle status\n def compute_status_code(self):\n- if self.is_unknown():\n+ if self._is_unknown():\n return self.STATUS_UNKNOWN\n- if self.is_critical():\n+ if self._is_critical():\n return self.STATUS_CRITICAL\n- if self.is_warning():\n+ if self._is_warning():\n return self.STATUS_WARNING\n return self.STATUS_OK\n \n+ def get_status_string(self):\n+ \"\"\"Returns the name of the current status\"\"\"\n+ return ['OK', 'WARNING', 'CRITICAL', 'UNKNOWN'][self.status_code]\n+\n+ def get_title(self):\n+ \"\"\"You probably don't need to override this.\"\"\"\n+ return self.title.upper()\n+\n+ def _is_unknown(self):\n+ \"\"\"Do not override this.\"\"\"\n+ if not self.has_enough_data:\n+ return False\n+ return self.is_unknown()\n+\n+ def _is_critical(self):\n+ \"\"\"Do not override this.\"\"\"\n+ if not self.has_enough_data:\n+ return False\n+ return self.is_critical()\n+\n+ def _is_warning(self):\n+ \"\"\"Do not override this.\"\"\"\n+ if not self.has_enough_data:\n+ return False\n+ return self.is_warning()\n+\n+ def _compute_message(self):\n+ \"\"\"Do not override this.\"\"\"\n+ if not self.has_enough_data:\n+ return 'Not enough data to run check.'\n+ return self.compute_message()","path":"pynagiosplugins/nagios_check.py","position":62,"original_position":62,"commit_id":"4f91ce93cd2aa7a7ba505864dc18e2d2df16bf13","original_commit_id":"4f91ce93cd2aa7a7ba505864dc18e2d2df16bf13","user":{"login":"olivierlefloch","id":66783,"avatar_url":"https://secure.gravatar.com/avatar/a6b7c8af08661cff2f30278333aca6c9?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"a6b7c8af08661cff2f30278333aca6c9","url":"https://api.github.com/users/olivierlefloch","html_url":"https://github.com/olivierlefloch","followers_url":"https://api.github.com/users/olivierlefloch/followers","following_url":"https://api.github.com/users/olivierlefloch/following","gists_url":"https://api.github.com/users/olivierlefloch/gists{/gist_id}","starred_url":"https://api.github.com/users/olivierlefloch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivierlefloch/subscriptions","organizations_url":"https://api.github.com/users/olivierlefloch/orgs","repos_url":"https://api.github.com/users/olivierlefloch/repos","events_url":"https://api.github.com/users/olivierlefloch/events{/privacy}","received_events_url":"https://api.github.com/users/olivierlefloch/received_events","type":"User"},"created_at":"2013-03-19T21:27:02Z","updated_at":"2013-03-19T21:27:02Z","html_url":"https://github.com/Work4Labs/pynagiosplugins/pull/3#discussion_r3441272","pull_request_url":"https://api.github.com/repos/Work4Labs/pynagiosplugins/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/Work4Labs/pynagiosplugins/pulls/comments/3441272"},"html":{"href":"https://github.com/Work4Labs/pynagiosplugins/pull/3#discussion_r3441272"},"pull_request":{"href":"https://api.github.com/repos/Work4Labs/pynagiosplugins/pulls/3"}}}}

{"repository":{"description":"","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":352,"owner":"Work4Labs","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-03-15T14:07:38-07:00","pushed_at":"2013-03-19T07:02:48-07:00","master_branch":"master","organization":"Work4Labs"},"actor_attributes":{"type":"User","name":"Olivier Le Floch","company":"Work4 Labs","blog":"http://olivier.le-floch.fr/","location":"Paris","email":"[email protected]"},"url":"https://github.com/Work4Labs/pynagiosplugins/pull/3#discussion_r3441272"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/atlassian/sitemesh2/pulls/comments/6787299","id":6787299,"diff_hunk":"@@ -68,7 +68,21 @@ private Page parseHtmlPage(SitemeshBuffer buffer, int position)\n position = findEndOf(data, length, position + 4, \">\");\n headStart = position;\n // Find end of head\n- position = findStartOf(data, length, position, \"</head>\");\n+ while (position < length - 2)\n+ {\n+ // quickly search for closing tag markers","path":"src/java/com/opensymphony/module/sitemesh/parser/PartialPageParser.java","position":7,"original_position":7,"commit_id":"0e6af2ab6c6bb42245a045c524d5892a2033b163","original_commit_id":"0e6af2ab6c6bb42245a045c524d5892a2033b163","user":{"login":"ericdalgliesh","id":914042,"avatar_url":"https://0.gravatar.com/avatar/f14badaf3bc25b6a3a1b37796a45018f?d=https%3A%2F%2Fidenticons.github.com%2F8f6fc5c263cb189a3b825916868b35b8.png","gravatar_id":"f14badaf3bc25b6a3a1b37796a45018f","url":"https://api.github.com/users/ericdalgliesh","html_url":"https://github.com/ericdalgliesh","followers_url":"https://api.github.com/users/ericdalgliesh/followers","following_url":"https://api.github.com/users/ericdalgliesh/following{/other_user}","gists_url":"https://api.github.com/users/ericdalgliesh/gists{/gist_id}","starred_url":"https://api.github.com/users/ericdalgliesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericdalgliesh/subscriptions","organizations_url":"https://api.github.com/users/ericdalgliesh/orgs","repos_url":"https://api.github.com/users/ericdalgliesh/repos","events_url":"https://api.github.com/users/ericdalgliesh/events{/privacy}","received_events_url":"https://api.github.com/users/ericdalgliesh/received_events","type":"User"},"body":"If you're trying to avoid the lowercase stuff, you can also check for the '>' in the appropriate positions. This will also work as a quick check that the string ends at the appropriate location which will exclude anything that's not a </head> most of the time. You could even apply this comparison before the '/' comparison to avoid the '/' comparison which gives a true result for all closing tags rather than only closing tags with the same length as \"</head>\".","created_at":"2013-10-06T16:51:45Z","updated_at":"2013-10-06T16:51:45Z","html_url":"https://github.com/atlassian/sitemesh2/pull/6#discussion_r6787299","pull_request_url":"https://api.github.com/repos/atlassian/sitemesh2/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/atlassian/sitemesh2/pulls/comments/6787299"},"html":{"href":"https://github.com/atlassian/sitemesh2/pull/6#discussion_r6787299"},"pull_request":{"href":"https://api.github.com/repos/atlassian/sitemesh2/pulls/6"}}}}

{"repository":{"description":"SiteMesh 2: Official repository","homepage":"http://www.opensymphony.com/sitemesh","watchers":6,"stargazers":6,"forks":7,"fork":true,"size":16360,"owner":"atlassian","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2011-02-15T18:50:24-08:00","pushed_at":"2013-04-14T21:11:25-07:00","master_branch":"master","organization":"atlassian"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/atlassian/sitemesh2/pull/6#discussion_r6787299"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/candlepin/candlepin/pulls/comments/4440000","id":4440000,"body":"Add a blank line after the getArches() method so it's not butted up against the next method.","diff_hunk":"@@ -250,6 +262,15 @@ public String getReleaseVer() {\n return releaseVer;\n }\n \n+\n+\n+ public void setArches(Set<Arch> arches) {\n+ this.arches = arches;\n+ }\n+\n+ public Set<Arch> getArches() {\n+ return arches;\n+ }","path":"src/main/java/org/candlepin/model/Content.java","position":46,"original_position":46,"commit_id":"16c2ce08ca2d7fd75f68db40706816c1d89a96ab","original_commit_id":"16c2ce08ca2d7fd75f68db40706816c1d89a96ab","user":{"login":"jmrodri","id":17137,"avatar_url":"https://secure.gravatar.com/avatar/9b8b8a3f02a847f77a37ff41fc510ce6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"9b8b8a3f02a847f77a37ff41fc510ce6","url":"https://api.github.com/users/jmrodri","html_url":"https://github.com/jmrodri","followers_url":"https://api.github.com/users/jmrodri/followers","following_url":"https://api.github.com/users/jmrodri/following{/other_user}","gists_url":"https://api.github.com/users/jmrodri/gists{/gist_id}","starred_url":"https://api.github.com/users/jmrodri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmrodri/subscriptions","organizations_url":"https://api.github.com/users/jmrodri/orgs","repos_url":"https://api.github.com/users/jmrodri/repos","events_url":"https://api.github.com/users/jmrodri/events{/privacy}","received_events_url":"https://api.github.com/users/jmrodri/received_events","type":"User"},"created_at":"2013-05-29T17:31:57Z","updated_at":"2013-05-29T17:31:57Z","html_url":"https://github.com/candlepin/candlepin/pull/269#discussion_r4440000","pull_request_url":"https://api.github.com/repos/candlepin/candlepin/pulls/269","_links":{"self":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/comments/4440000"},"html":{"href":"https://github.com/candlepin/candlepin/pull/269#discussion_r4440000"},"pull_request":{"href":"https://api.github.com/repos/candlepin/candlepin/pulls/269"}}}}

{"repository":{"description":"The Candlepin entitlement engine","homepage":"http://candlepinproject.org","watchers":12,"stargazers":12,"forks":13,"fork":false,"size":1916,"owner":"candlepin","private":false,"open_issues":4,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2012-06-07T07:58:35-07:00","pushed_at":"2013-05-29T08:13:44-07:00","master_branch":"master","organization":"candlepin"},"actor_attributes":{"type":"User","name":"jesus m. rodriguez","blog":"http://zeusville.wordpress.com/","location":"Wake Forest, NC","email":"[email protected]"},"url":"https://github.com/candlepin/candlepin/pull/269#discussion_r4440000"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/celluloid/reel/pulls/comments/7616177","id":7616177,"diff_hunk":"@@ -60,4 +61,51 @@ def fragment\n end\n \n end\n+\n+ module SocketMixin\n+\n+ # Optimizations possible, depending on OS:\n+ \n+ # TCP_NODELAY: prevent TCP packets from being buffered\n+ # TCP_CORK: TODO: tersely describe\n+ # SO_REUSEADDR: TODO: tersely describe\n+\n+ if RUBY_PLATFORM =~ /linux/\n+\n+ # Only Linux supports the mix of socket behaviors given in these optimizations.\n+ # Beaware, certain optimizations may work individually off Linux; not together.\n+ def optimize_socket socket\n+ if TCPSocket === socket\n+ socket.setsockopt( Socket::IPPROTO_TCP, :TCP_NODELAY, 1 )\n+ socket.setsockopt( Socket::IPPROTO_TCP, 3, 1 ) # TCP_CORK\n+ socket.setsockopt( Socket::SOL_SOCKET, Socket::SO_REUSEADDR, 1 )\n+ end\n+ end\n+\n+ def deoptimize_socket socket\n+ if TCPSocket === socket","path":"lib/reel/mixins.rb","position":34,"original_position":34,"commit_id":"f5ed50af16f5733c37ae34ca538886aa28ec80ea","original_commit_id":"f5ed50af16f5733c37ae34ca538886aa28ec80ea","user":{"login":"tarcieri","id":797,"avatar_url":"https://0.gravatar.com/avatar/4131d2f57a0db2a2b4d9a62bd389fd44?d=https%3A%2F%2Fidenticons.github.com%2Fbeb22fb694d513edcf5533cf006dfeae.png&r=x","gravatar_id":"4131d2f57a0db2a2b4d9a62bd389fd44","url":"https://api.github.com/users/tarcieri","html_url":"https://github.com/tarcieri","followers_url":"https://api.github.com/users/tarcieri/followers","following_url":"https://api.github.com/users/tarcieri/following{/other_user}","gists_url":"https://api.github.com/users/tarcieri/gists{/gist_id}","starred_url":"https://api.github.com/users/tarcieri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tarcieri/subscriptions","organizations_url":"https://api.github.com/users/tarcieri/orgs","repos_url":"https://api.github.com/users/tarcieri/repos","events_url":"https://api.github.com/users/tarcieri/events{/privacy}","received_events_url":"https://api.github.com/users/tarcieri/received_events","type":"User","site_admin":false},"body":"I'd prefer the more readable version unless you have a benchmark showing `===` is a bottleneck","created_at":"2013-11-13T03:33:14Z","updated_at":"2013-11-13T03:33:14Z","html_url":"https://github.com/celluloid/reel/pull/119#discussion_r7616177","pull_request_url":"https://api.github.com/repos/celluloid/reel/pulls/119","_links":{"self":{"href":"https://api.github.com/repos/celluloid/reel/pulls/comments/7616177"},"html":{"href":"https://github.com/celluloid/reel/pull/119#discussion_r7616177"},"pull_request":{"href":"https://api.github.com/repos/celluloid/reel/pulls/119"}}}}

{"repository":{"description":"Celluloid::IO-powered web server","homepage":"http://celluloid.io","watchers":358,"stargazers":358,"forks":50,"fork":false,"size":2977,"owner":"celluloid","private":false,"open_issues":17,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2012-02-12T21:22:56-08:00","pushed_at":"2013-11-12T14:39:39-08:00","master_branch":"master","organization":"celluloid"},"actor_attributes":{"type":"User","name":"Tony Arcieri","company":"Square","blog":"http://tonyarcieri.com","location":"San Francisco, CA","email":"[email protected]"},"url":"https://github.com/celluloid/reel/pull/119#discussion_r7616177"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/cleandart/clean_data/pulls/comments/8230173","id":8230173,"diff_hunk":"@@ -291,23 +291,42 @@ class DataCollection extends DataCollectionView with DataChangeListenersMixin<Da\n return collection;\n }\n \n+ factory DataCollection.identity() => new DataCollection();\n+\n+ void _addAll(Iterable<DataView> elements, {author: null}){\n+ _removedObjects.removeAll(elements);\n+ elements.forEach((DataView d) {\n+ _markAdded(d);\n+ });\n+ _data.addAll(elements);\n+ elements.forEach((DataView d) {\n+ _addOnDataChangeListener(d, d);\n+ });\n+ _notify(author: author);\n+ }\n+\n /**\n * Appends the [dataObj] to the collection.\n *\n * Data objects should have unique IDs.\n */\n- void add(DataView dataObj, {author: null}) {\n- _removedObjects.remove(dataObj);\n- _markAdded(dataObj);\n- _removedObjects.remove(dataObj);\n-\n- _data.add(dataObj);\n \n- _addOnDataChangeListener(dataObj, dataObj);\n- _notify(author: author);\n+ bool add(DataView dataObj, {author: null}) {\n+ var res = !_data.contains(dataObj);\n+ this._addAll([dataObj], author: author);\n+ return res;\n }\n \n \n+ /**\n+ * Appends all [elements] to the collection.\n+ *\n+ * Data object should have unique IDs.","path":"lib/src/data_collection.dart","position":96,"original_position":96,"commit_id":"c7bb31797e698cb0722c7ef677f506b83fccd32b","original_commit_id":"c7bb31797e698cb0722c7ef677f506b83fccd32b","user":{"login":"marcelka","id":2097987,"avatar_url":"https://identicons.github.com/d1511399861afa6e450b6ddf00dcea50.png","gravatar_id":null,"url":"https://api.github.com/users/marcelka","html_url":"https://github.com/marcelka","followers_url":"https://api.github.com/users/marcelka/followers","following_url":"https://api.github.com/users/marcelka/following{/other_user}","gists_url":"https://api.github.com/users/marcelka/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelka/subscriptions","organizations_url":"https://api.github.com/users/marcelka/orgs","repos_url":"https://api.github.com/users/marcelka/repos","events_url":"https://api.github.com/users/marcelka/events{/privacy}","received_events_url":"https://api.github.com/users/marcelka/received_events","type":"User","site_admin":false},"body":"Remove this line.","created_at":"2013-12-10T12:29:44Z","updated_at":"2013-12-10T12:29:44Z","html_url":"https://github.com/cleandart/clean_data/pull/18#discussion_r8230173","pull_request_url":"https://api.github.com/repos/cleandart/clean_data/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/cleandart/clean_data/pulls/comments/8230173"},"html":{"href":"https://github.com/cleandart/clean_data/pull/18#discussion_r8230173"},"pull_request":{"href":"https://api.github.com/repos/cleandart/clean_data/pulls/18"}}}}

{"repository":{"description":"Web Framework written in Dart","watchers":1,"stargazers":1,"forks":2,"fork":true,"size":776,"owner":"cleandart","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Dart","created_at":"2013-08-14T05:24:18-07:00","pushed_at":"2013-12-10T03:57:04-08:00","master_branch":"master","organization":"cleandart"},"actor_attributes":{"type":"User","name":"Marcela Hrdá","location":"Bratislava","email":"[email protected]"},"url":"https://github.com/cleandart/clean_data/pull/18#discussion_r8230173"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/eiffelhub/json/pulls/comments/6565998","id":6565998,"body":"detachable is ok since JSON also supports null values. The put procedure creates a JSON_NULL object in case the value is not attached.","diff_hunk":"@@ -52,6 +52,57 @@ feature -- Change Element\n object.extend (l_value, key)\n end\n \n+ put_string (value: detachable JSON_STRING; key: JSON_STRING)","path":"library/kernel/json_object.e","position":4,"original_position":4,"commit_id":"95fd5f93fcb1bba3c93a8d01e973848877abbede","original_commit_id":"95fd5f93fcb1bba3c93a8d01e973848877abbede","user":{"login":"ynh","id":1868109,"avatar_url":"https://2.gravatar.com/avatar/38758db0d1cf0ce3006e36140f01bda6?d=https%3A%2F%2Fidenticons.github.com%2F4966280d73a4a723afaa6180d45e0025.png","gravatar_id":"38758db0d1cf0ce3006e36140f01bda6","url":"https://api.github.com/users/ynh","html_url":"https://github.com/ynh","followers_url":"https://api.github.com/users/ynh/followers","following_url":"https://api.github.com/users/ynh/following{/other_user}","gists_url":"https://api.github.com/users/ynh/gists{/gist_id}","starred_url":"https://api.github.com/users/ynh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ynh/subscriptions","organizations_url":"https://api.github.com/users/ynh/orgs","repos_url":"https://api.github.com/users/ynh/repos","events_url":"https://api.github.com/users/ynh/events{/privacy}","received_events_url":"https://api.github.com/users/ynh/received_events","type":"User"},"created_at":"2013-09-25T07:48:21Z","updated_at":"2013-09-25T07:48:21Z","html_url":"https://github.com/eiffelhub/json/pull/7#discussion_r6565998","pull_request_url":"https://api.github.com/repos/eiffelhub/json/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/eiffelhub/json/pulls/comments/6565998"},"html":{"href":"https://github.com/eiffelhub/json/pull/7#discussion_r6565998"},"pull_request":{"href":"https://api.github.com/repos/eiffelhub/json/pulls/7"}}}}

{"repository":{"description":"Eiffel JSON library","homepage":"Old location was http://ejson.origo.ethz.ch","watchers":8,"stargazers":8,"forks":4,"fork":false,"size":1084,"owner":"eiffelhub","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Eiffel","created_at":"2012-04-04T08:15:37-07:00","pushed_at":"2013-08-05T14:16:29-07:00","master_branch":"master","organization":"eiffelhub"},"actor_attributes":{"type":"User","location":"Bern, Switzerland","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/eiffelhub/json/pull/7#discussion_r6565998"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/expertiza/expertiza/pulls/comments/7447273","id":7447273,"diff_hunk":"@@ -147,23 +221,49 @@ def get_cycle_deviation_score(cycle)\n deviation_score = deviation_score / count unless count == 0.0\n return deviation_score\n end\n+=end\n+\n+ #OSS808 Change 28/10/2013\n+ #created a new method collusion_cycles to access cycles related code\n+\n+ def collusion_cycles\n+ self.collusion_cycles=CollusionCycle.two_node_cycles\n+ self.collusion_cycles<<CollusionCycle.three_node_cycles\n+ self.collusion_cycles<<CollusionCycle.four_node_cycles\n+ similarity_score= CollusionCycle.cycle_similarity_score(self.collusion_cycles)\n+ deviation_score=CollusionCycle.cycle_deviation_score(self.collusion_cycles)\n+ end\n \n- def get_review_score\n+ #OSS808 Change 27/10/2013\n+ # Renamed to review_score from get_review_score\n+\n+ def review_score","path":"app/models/assignment_participant.rb","position":251,"original_position":251,"commit_id":"14994c4b1c9eb0658ee7bc81404fc9f5a754c185","original_commit_id":"14994c4b1c9eb0658ee7bc81404fc9f5a754c185","user":{"login":"akofink","id":761923,"avatar_url":"https://0.gravatar.com/avatar/c4ebb99f2f580465c75217333f2c62a6?d=https%3A%2F%2Fidenticons.github.com%2F931b143448b4427755ed303b5d47a047.png&r=x","gravatar_id":"c4ebb99f2f580465c75217333f2c62a6","url":"https://api.github.com/users/akofink","html_url":"https://github.com/akofink","followers_url":"https://api.github.com/users/akofink/followers","following_url":"https://api.github.com/users/akofink/following{/other_user}","gists_url":"https://api.github.com/users/akofink/gists{/gist_id}","starred_url":"https://api.github.com/users/akofink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akofink/subscriptions","organizations_url":"https://api.github.com/users/akofink/orgs","repos_url":"https://api.github.com/users/akofink/repos","events_url":"https://api.github.com/users/akofink/events{/privacy}","received_events_url":"https://api.github.com/users/akofink/received_events","type":"User","site_admin":false},"body":"Revert this change. You should never change the public interface of a class. Dr. Gehringer specifically mentioned this in his lecture last Friday.","created_at":"2013-11-05T21:56:09Z","updated_at":"2013-11-05T21:56:09Z","html_url":"https://github.com/expertiza/expertiza/pull/359#discussion_r7447273","pull_request_url":"https://api.github.com/repos/expertiza/expertiza/pulls/359","_links":{"self":{"href":"https://api.github.com/repos/expertiza/expertiza/pulls/comments/7447273"},"html":{"href":"https://github.com/expertiza/expertiza/pull/359#discussion_r7447273"},"pull_request":{"href":"https://api.github.com/repos/expertiza/expertiza/pulls/359"}}}}

{"repository":{"description":"Expertiza is a web application where students can submit and peer-review learning objects (articles, code, web sites, etc). The Expertiza project is supported by the National Science Foundation.","homepage":"http://wikis.lib.ncsu.edu/index.php/Expertiza","watchers":91,"stargazers":91,"forks":189,"fork":false,"size":20483,"owner":"expertiza","private":false,"open_issues":9,"has_issues":true,"has_downloads":false,"has_wiki":true,"language":"Ruby","created_at":"2010-10-04T20:37:29-07:00","pushed_at":"2013-11-04T10:15:08-08:00","master_branch":"master","organization":"expertiza"},"actor_attributes":{"type":"User","name":"Andrew Kofink","blog":"http://akofink.com","email":"[email protected]"},"url":"https://github.com/expertiza/expertiza/pull/359#discussion_r7447273"}

PullRequestReviewCommentEvent

{"comment":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/4700951","id":4700951,"body":"Add php doc please","diff_hunk":"@@ -0,0 +1,44 @@\n+<?php\n+/**\n+ * File containing the LegacyResponse class.\n+ *\n+ * @copyright Copyright (C) 1999-2013 eZ Systems AS. All rights reserved.\n+ * @license http://www.gnu.org/licenses/gpl-2.0.txt GNU General Public License v2\n+ * @version //autogentag//\n+ */\n+\n+namespace eZ\\Bundle\\EzPublishLegacyBundle;\n+\n+use Symfony\\Component\\HttpFoundation\\Response;\n+\n+/**\n+ * Class LegacyResponse\n+ *\n+ * An extend of the Symfony Response class with an extra module result attribute.\n+ * It can be useful if you need to access module result information in an event listener.\n+ *\n+ * @package eZ\\Bundle\\EzPublishLegacyBundle\n+ */\n+class LegacyResponse extends Response\n+{\n+ protected $moduleResult = null;","path":"eZ/Bundle/EzPublishLegacyBundle/LegacyResponse.php","position":24,"original_position":24,"commit_id":"9ed1f6b33c2a4087c579bf1a47715597c9ff3194","original_commit_id":"9ed1f6b33c2a4087c579bf1a47715597c9ff3194","user":{"login":"lolautruche","id":313528,"avatar_url":"https://secure.gravatar.com/avatar/f37e2139d6bde024b7aa7e7306903519?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"f37e2139d6bde024b7aa7e7306903519","url":"https://api.github.com/users/lolautruche","html_url":"https://github.com/lolautruche","followers_url":"https://api.github.com/users/lolautruche/followers","following_url":"https://api.github.com/users/lolautruche/following{/other_user}","gists_url":"https://api.github.com/users/lolautruche/gists{/gist_id}","starred_url":"https://api.github.com/users/lolautruche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lolautruche/subscriptions","organizations_url":"https://api.github.com/users/lolautruche/orgs","repos_url":"https://api.github.com/users/lolautruche/repos","events_url":"https://api.github.com/users/lolautruche/events{/privacy}","received_events_url":"https://api.github.com/users/lolautruche/received_events","type":"User"},"created_at":"2013-06-14T13:28:43Z","updated_at":"2013-06-14T13:28:43Z","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/411#discussion_r4700951","pull_request_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/411","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/comments/4700951"},"html":{"href":"https://github.com/ezsystems/ezpublish-kernel/pull/411#discussion_r4700951"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/411"}}}}

{"repository":{"description":"","homepage":"","watchers":69,"stargazers":69,"forks":34,"fork":false,"size":3660,"owner":"ezsystems","private":false,"open_issues":32,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"PHP","created_at":"2011-04-26T01:54:24-07:00","pushed_at":"2013-06-14T06:23:13-07:00","master_branch":"master","organization":"ezsystems"},"actor_attributes":{"type":"User","name":"Jérôme Vieilledent","company":"eZ Systems","blog":"http://www.lolart.net","location":"Lyon","email":"[email protected]"},"url":"https://github.com/ezsystems/ezpublish-kernel/pull/411#discussion_r4700951"}