Search is not available for this dataset
type
stringclasses 17
values | public
bool 2
classes | payload
stringlengths 2
1.27M
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringclasses 0
values | other
stringlengths 34
66.4k
|
---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/learningequality/ka-lite/pulls/comments/5830119","id":5830119,"body":"Real changes start here.","diff_hunk":"@@ -112,16 +115,37 @@ def get_data_form(request, *args, **kwargs):\n \n # Fill in backwards: a user implies a group\n if form.data.get(\"user\") and not form.data.get(\"group\"):\n- user = get_object_or_404(FacilityUser, id=form.data[\"user\"])\n- form.data[\"group\"] = getattr(user.group, \"id\", None)\n+ user = get_object_or_404(FacilityUser, id=form.data[\"user\"])\n+ form.data[\"group\"] = getattr(user.group, \"id\", None)\n \n if form.data.get(\"group\") and not form.data.get(\"facility\"):\n- group = get_object_or_404(FacilityGroup, id=form.data[\"group\"])\n- form.data[\"facility\"] = getattr(group.facility, \"id\")\n+ group = get_object_or_404(FacilityGroup, id=form.data[\"group\"])\n+ form.data[\"facility\"] = getattr(group.facility, \"id\")\n \n return form\n \n \n+def query_logs(users, items, logtype, logdict):","path":"kalite/coachreports/api_views.py","position":100,"original_position":100,"commit_id":"554ed290c8814ffec1bb869d6fc55364af11d64d","original_commit_id":"554ed290c8814ffec1bb869d6fc55364af11d64d","user":{"login":"rtibbles","id":1680573,"avatar_url":"https://2.gravatar.com/avatar/1a2f3374de870804f021ee28a23f373d?d=https%3A%2F%2Fidenticons.github.com%2Fa6ba2b6377ec7c896dd713ea38e60361.png","gravatar_id":"1a2f3374de870804f021ee28a23f373d","url":"https://api.github.com/users/rtibbles","html_url":"https://github.com/rtibbles","followers_url":"https://api.github.com/users/rtibbles/followers","following_url":"https://api.github.com/users/rtibbles/following{/other_user}","gists_url":"https://api.github.com/users/rtibbles/gists{/gist_id}","starred_url":"https://api.github.com/users/rtibbles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtibbles/subscriptions","organizations_url":"https://api.github.com/users/rtibbles/orgs","repos_url":"https://api.github.com/users/rtibbles/repos","events_url":"https://api.github.com/users/rtibbles/events{/privacy}","received_events_url":"https://api.github.com/users/rtibbles/received_events","type":"User"},"created_at":"2013-08-17T23:37:41Z","updated_at":"2013-08-17T23:37:41Z","html_url":"https://github.com/learningequality/ka-lite/pull/497#discussion_r5830119","pull_request_url":"https://api.github.com/repos/learningequality/ka-lite/pulls/497","_links":{"self":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/comments/5830119"},"html":{"href":"https://github.com/learningequality/ka-lite/pull/497#discussion_r5830119"},"pull_request":{"href":"https://api.github.com/repos/learningequality/ka-lite/pulls/497"}}}} | {
"id": 5741125,
"name": "ka-lite",
"url": "https://github.com/learningequality/ka-lite"
} | {
"id": null,
"login": "rtibbles",
"gravatar_id": "1a2f3374de870804f021ee28a23f373d",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "learningequality",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-17T23:37:41 | null | {"repository":{"description":"KA Lite: lightweight web server for serving core Khan Academy content (videos and exercises) without needing internet connectivity","homepage":"http://kalite.learningequality.org/","watchers":83,"stargazers":83,"forks":82,"fork":false,"size":43741,"owner":"learningequality","private":false,"open_issues":177,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-09-09T13:01:40-07:00","pushed_at":"2013-08-17T11:18:23-07:00","master_branch":"master","organization":"learningequality"},"actor_attributes":{"type":"User","name":"Richard Tibbles","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/learningequality/ka-lite/pull/497#discussion_r5830119"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla-services/heka/pulls/comments/6474443","id":6474443,"body":"Do we still need to be populating this?","diff_hunk":"@@ -139,6 +139,7 @@ func ReportSpec(c gs.Context) {\n \t\tfor i := 0; i < Globals().PoolSize; i++ {\n \t\t\tpc.injectRecycleChan <- NewPipelinePack(pc.injectRecycleChan)\n \t\t}","path":"pipeline/report_test.go","position":3,"original_position":3,"commit_id":"b143d3dd5c7674d1a99aa4f4f9a7ae4c0413bd96","original_commit_id":"b143d3dd5c7674d1a99aa4f4f9a7ae4c0413bd96","user":{"login":"rafrombrc","id":151364,"avatar_url":"https://2.gravatar.com/avatar/e1a84ff925d8a5df8446dc2c6a106b9c?d=https%3A%2F%2Fidenticons.github.com%2Fb754980865415f2efd94b209973a5d03.png","gravatar_id":"e1a84ff925d8a5df8446dc2c6a106b9c","url":"https://api.github.com/users/rafrombrc","html_url":"https://github.com/rafrombrc","followers_url":"https://api.github.com/users/rafrombrc/followers","following_url":"https://api.github.com/users/rafrombrc/following{/other_user}","gists_url":"https://api.github.com/users/rafrombrc/gists{/gist_id}","starred_url":"https://api.github.com/users/rafrombrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafrombrc/subscriptions","organizations_url":"https://api.github.com/users/rafrombrc/orgs","repos_url":"https://api.github.com/users/rafrombrc/repos","events_url":"https://api.github.com/users/rafrombrc/events{/privacy}","received_events_url":"https://api.github.com/users/rafrombrc/received_events","type":"User"},"created_at":"2013-09-19T21:52:15Z","updated_at":"2013-09-19T21:52:15Z","html_url":"https://github.com/mozilla-services/heka/pull/435#discussion_r6474443","pull_request_url":"https://api.github.com/repos/mozilla-services/heka/pulls/435","_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/heka/pulls/comments/6474443"},"html":{"href":"https://github.com/mozilla-services/heka/pull/435#discussion_r6474443"},"pull_request":{"href":"https://api.github.com/repos/mozilla-services/heka/pulls/435"}}}} | {
"id": 6248212,
"name": "heka",
"url": "https://github.com/mozilla-services/heka"
} | {
"id": null,
"login": "rafrombrc",
"gravatar_id": "e1a84ff925d8a5df8446dc2c6a106b9c",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla-services",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-19T21:52:15 | null | {"repository":{"description":"Data collection and processing made easy.","homepage":"http://hekad.readthedocs.org/","watchers":707,"stargazers":707,"forks":59,"fork":false,"size":6461,"owner":"mozilla-services","private":false,"open_issues":52,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Go","created_at":"2012-10-16T10:20:51-07:00","pushed_at":"2013-09-19T14:47:46-07:00","master_branch":"dev","organization":"mozilla-services"},"actor_attributes":{"type":"User","name":"Rob Miller","company":"Mozilla Corp","blog":"http://blog.nonsequitarian.org/","location":"Oakland, CA","email":"[email protected]"},"url":"https://github.com/mozilla-services/heka/pull/435#discussion_r6474443"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/pantheon-systems/fusedav/pulls/comments/5620695","id":5620695,"body":"review","diff_hunk":"@@ -1028,6 +1095,93 @@ void filecache_delete(filecache_t *cache, const char *path, bool unlink_cachefil\n return;\n }\n \n+void filecache_forensic_haven(const char *cache_path, filecache_t *cache, const char *path, off_t fsize, GError **gerr) {","path":"src/filecache.c","position":581,"original_position":581,"commit_id":"11f704fdbf7e8b285479f21f7017006c1b81c3ba","original_commit_id":"11f704fdbf7e8b285479f21f7017006c1b81c3ba","user":{"login":"jerryblakley","id":2422445,"avatar_url":"https://secure.gravatar.com/avatar/6b1d1c979fe73ca0e66d9f79f8b4794f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"6b1d1c979fe73ca0e66d9f79f8b4794f","url":"https://api.github.com/users/jerryblakley","html_url":"https://github.com/jerryblakley","followers_url":"https://api.github.com/users/jerryblakley/followers","following_url":"https://api.github.com/users/jerryblakley/following{/other_user}","gists_url":"https://api.github.com/users/jerryblakley/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryblakley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryblakley/subscriptions","organizations_url":"https://api.github.com/users/jerryblakley/orgs","repos_url":"https://api.github.com/users/jerryblakley/repos","events_url":"https://api.github.com/users/jerryblakley/events{/privacy}","received_events_url":"https://api.github.com/users/jerryblakley/received_events","type":"User"},"created_at":"2013-08-07T00:11:36Z","updated_at":"2013-08-07T00:11:36Z","html_url":"https://github.com/pantheon-systems/fusedav/pull/103#discussion_r5620695","pull_request_url":"https://api.github.com/repos/pantheon-systems/fusedav/pulls/103","_links":{"self":{"href":"https://api.github.com/repos/pantheon-systems/fusedav/pulls/comments/5620695"},"html":{"href":"https://github.com/pantheon-systems/fusedav/pull/103#discussion_r5620695"},"pull_request":{"href":"https://api.github.com/repos/pantheon-systems/fusedav/pulls/103"}}}} | {
"id": 2977118,
"name": "fusedav",
"url": "https://github.com/pantheon-systems/fusedav"
} | {
"id": null,
"login": "jerryblakley",
"gravatar_id": "6b1d1c979fe73ca0e66d9f79f8b4794f",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "pantheon-systems",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-07T00:11:36 | null | {"repository":{"description":"Successor to git://git.0pointer.de/fusedav.git","homepage":"http://0pointer.de/lennart/projects/fusedav/","watchers":4,"stargazers":4,"forks":2,"fork":false,"size":1652,"owner":"pantheon-systems","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2011-12-13T18:28:22-08:00","pushed_at":"2013-08-06T17:08:20-07:00","master_branch":"master","organization":"pantheon-systems"},"actor_attributes":{"type":"User","name":"Jerry Blakley","company":"Pantheon Systems","location":"San Francisco, CA","email":"[email protected]"},"url":"https://github.com/pantheon-systems/fusedav/pull/103#discussion_r5620695"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/GalSim-developers/GalSim/pulls/comments/3385854","id":3385854,"body":"Done.","diff_hunk":"@@ -0,0 +1,2 @@\n+from des_shapelet import *","path":"galsim/des/__init__.py","position":19,"original_position":1,"commit_id":"fcaba40ffa13b0af48c7a22e9567faa197dc4013","original_commit_id":"cad385721bcbeb3c28a1af4e622987b8c02bd8a0","user":{"login":"rmjarvis","id":623887,"avatar_url":"https://secure.gravatar.com/avatar/4536b0aa642c3258af0c8117e627f17f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"4536b0aa642c3258af0c8117e627f17f","url":"https://api.github.com/users/rmjarvis","html_url":"https://github.com/rmjarvis","followers_url":"https://api.github.com/users/rmjarvis/followers","following_url":"https://api.github.com/users/rmjarvis/following","gists_url":"https://api.github.com/users/rmjarvis/gists{/gist_id}","starred_url":"https://api.github.com/users/rmjarvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmjarvis/subscriptions","organizations_url":"https://api.github.com/users/rmjarvis/orgs","repos_url":"https://api.github.com/users/rmjarvis/repos","events_url":"https://api.github.com/users/rmjarvis/events{/privacy}","received_events_url":"https://api.github.com/users/rmjarvis/received_events","type":"User"},"created_at":"2013-03-15T03:00:21Z","updated_at":"2013-03-15T03:00:21Z","html_url":"https://github.com/GalSim-developers/GalSim/pull/363#discussion_r3385854","pull_request_url":"https://api.github.com/repos/GalSim-developers/GalSim/pulls/363","_links":{"self":{"href":"https://api.github.com/repos/GalSim-developers/GalSim/pulls/comments/3385854"},"html":{"href":"https://github.com/GalSim-developers/GalSim/pull/363#discussion_r3385854"},"pull_request":{"href":"https://api.github.com/repos/GalSim-developers/GalSim/pulls/363"}}}} | {
"id": 3510804,
"name": "GalSim",
"url": "https://github.com/GalSim-developers/GalSim"
} | {
"id": null,
"login": "rmjarvis",
"gravatar_id": "4536b0aa642c3258af0c8117e627f17f",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "GalSim-developers",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-15T03:00:21 | null | {"repository":{"description":"The modular galaxy image simulation toolkit","homepage":"","watchers":12,"stargazers":12,"forks":2,"fork":false,"size":20574,"owner":"GalSim-developers","private":false,"open_issues":34,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2012-02-21T18:51:45-08:00","pushed_at":"2013-03-14T19:51:21-07:00","master_branch":"master","organization":"GalSim-developers"},"actor_attributes":{"type":"User","name":"Mike Jarvis","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/GalSim-developers/GalSim/pull/363#discussion_r3385854"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments/6881812","id":6881812,"diff_hunk":"@@ -139,7 +139,14 @@\n a[1] = -a[1];\n a[2] = -a[2];\n }\n-\n+\t \n+ /** \\brief a = b */\n+ template <typename T> bool\n+ equal3(const T a[3], const T b[3])","path":"recognition/include/pcl/recognition/ransac_based/auxiliary.h","position":8,"original_position":8,"commit_id":"30baffc0066698c3fbe05c809bd835bfe8e605e5","original_commit_id":"30baffc0066698c3fbe05c809bd835bfe8e605e5","user":{"login":"jspricke","id":480915,"avatar_url":"https://2.gravatar.com/avatar/1502361802f66201b72580f7183b5b14?d=https%3A%2F%2Fidenticons.github.com%2Fd37c34092a32ff3a872e51a5601b7306.png","gravatar_id":"1502361802f66201b72580f7183b5b14","url":"https://api.github.com/users/jspricke","html_url":"https://github.com/jspricke","followers_url":"https://api.github.com/users/jspricke/followers","following_url":"https://api.github.com/users/jspricke/following{/other_user}","gists_url":"https://api.github.com/users/jspricke/gists{/gist_id}","starred_url":"https://api.github.com/users/jspricke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspricke/subscriptions","organizations_url":"https://api.github.com/users/jspricke/orgs","repos_url":"https://api.github.com/users/jspricke/repos","events_url":"https://api.github.com/users/jspricke/events{/privacy}","received_events_url":"https://api.github.com/users/jspricke/received_events","type":"User","site_admin":false},"body":"Please add a space before (","created_at":"2013-10-10T09:33:15Z","updated_at":"2013-10-10T09:33:15Z","html_url":"https://github.com/PointCloudLibrary/pcl/pull/269#discussion_r6881812","pull_request_url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/269","_links":{"self":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/comments/6881812"},"html":{"href":"https://github.com/PointCloudLibrary/pcl/pull/269#discussion_r6881812"},"pull_request":{"href":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/269"}}}} | {
"id": 8162615,
"name": "pcl",
"url": "https://github.com/PointCloudLibrary/pcl"
} | {
"id": null,
"login": "jspricke",
"gravatar_id": "1502361802f66201b72580f7183b5b14",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "PointCloudLibrary",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-10T09:33:15 | null | {"repository":{"description":"Point Cloud Library (PCL)","homepage":"http://www.pointclouds.org","watchers":170,"stargazers":170,"forks":209,"fork":false,"size":239980,"owner":"PointCloudLibrary","private":false,"open_issues":8,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2013-02-12T08:40:25-08:00","pushed_at":"2013-10-10T02:28:08-07:00","master_branch":"master","organization":"PointCloudLibrary"},"actor_attributes":{"type":"User","name":"Jochen Sprickerhof","blog":"http://jochen.sprickerhof.de","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/PointCloudLibrary/pcl/pull/269#discussion_r6881812"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/7922477","id":7922477,"diff_hunk":"@@ -49,4 +93,19 @@ void DBusManager::OnNameOwned(const std::string& service_name, bool success) {\n on_success_callback_.Run();\n }\n \n+DBusManager::DBusManager()\n+ : dbus_manager_impl_(DBusManagerImpl::Get()) {}","path":"dbus/dbus_manager.cc","position":98,"original_position":98,"commit_id":"8c9abc8c503290fa642ee4502acb57e440393d5b","original_commit_id":"8c9abc8c503290fa642ee4502acb57e440393d5b","user":{"login":"pozdnyakov","id":998253,"avatar_url":"https://2.gravatar.com/avatar/4ffb512f7312fbe30369fb8b78de59af?d=https%3A%2F%2Fidenticons.github.com%2F8e231c4fb7821d5ecb7d9114e4a4a204.png&r=x","gravatar_id":"4ffb512f7312fbe30369fb8b78de59af","url":"https://api.github.com/users/pozdnyakov","html_url":"https://github.com/pozdnyakov","followers_url":"https://api.github.com/users/pozdnyakov/followers","following_url":"https://api.github.com/users/pozdnyakov/following{/other_user}","gists_url":"https://api.github.com/users/pozdnyakov/gists{/gist_id}","starred_url":"https://api.github.com/users/pozdnyakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pozdnyakov/subscriptions","organizations_url":"https://api.github.com/users/pozdnyakov/orgs","repos_url":"https://api.github.com/users/pozdnyakov/repos","events_url":"https://api.github.com/users/pozdnyakov/events{/privacy}","received_events_url":"https://api.github.com/users/pozdnyakov/received_events","type":"User","site_admin":false},"body":"Great, this approach looks much better to me than passing dbusmanager all around the application classes. ","created_at":"2013-11-26T12:16:22Z","updated_at":"2013-11-26T12:16:22Z","html_url":"https://github.com/crosswalk-project/crosswalk/pull/1187#discussion_r7922477","pull_request_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/1187","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/7922477"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/1187#discussion_r7922477"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/1187"}}}} | {
"id": 9207280,
"name": "crosswalk",
"url": "https://github.com/crosswalk-project/crosswalk"
} | {
"id": null,
"login": "pozdnyakov",
"gravatar_id": "4ffb512f7312fbe30369fb8b78de59af",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "crosswalk-project",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-26T12:16:22 | null | {"repository":{"description":"","watchers":22,"stargazers":22,"forks":50,"fork":false,"size":24254,"owner":"crosswalk-project","private":false,"open_issues":91,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2013-04-03T16:30:12-07:00","pushed_at":"2013-11-26T03:53:18-08:00","master_branch":"master","organization":"crosswalk-project"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/crosswalk-project/crosswalk/pull/1187#discussion_r7922477"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/7429170","id":7429170,"diff_hunk":"@@ -0,0 +1,107 @@\n+// Copyright (c) 2013 Intel Corporation. All rights reserved.\n+// Use of this source code is governed by a BSD-style license that can be\n+// found in the LICENSE file.\n+\n+#include \"xwalk/application/browser/application_event_registrar.h\"\n+\n+#include \"content/public/browser/browser_thread.h\"\n+\n+using content::BrowserThread;\n+\n+namespace xwalk {\n+namespace application {\n+\n+AppEventRegistrar::HandlerRecord::HandlerRecord(\n+ const std::string& event_name,\n+ const std::string& app_id,\n+ const EventHandlerCallback& callback)\n+ : event_name(event_name),\n+ app_id(app_id),\n+ callback(callback) {\n+}\n+\n+AppEventRegistrar::HandlerRecord::~HandlerRecord() {\n+}\n+\n+bool\n+AppEventRegistrar::HandlerRecord::operator==(const HandlerRecord& other) const {\n+ return event_name == other.event_name &&\n+ app_id == other.app_id &&\n+ callback.Equals(other.callback);\n+}\n+\n+AppEventRegistrar::AppEventRegistrar(ApplicationEventRouter* router)\n+ : router_(router),\n+ weak_ptr_factory_(this) {\n+}\n+\n+AppEventRegistrar::~AppEventRegistrar() {\n+ RemoveAll();\n+}\n+\n+void AppEventRegistrar::Add(const std::string& event_name,\n+ const std::string& app_id,\n+ const EventHandlerCallback& callback) {\n+ linked_ptr<HandlerRecord> record(\n+ new HandlerRecord(event_name, app_id, callback));\n+ records_.push_back(record);\n+\n+ scoped_ptr<EventHandler> handler(new EventHandler(\n+ event_name, app_id, callback, GetWeakPtr()));\n+\n+ if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {\n+ BrowserThread::PostTask(\n+ BrowserThread::UI, FROM_HERE,\n+ base::Bind(&ApplicationEventRouter::AddEventHandler,\n+ base::Unretained(router_), base::Passed(&handler)));\n+ } else {\n+ router_->AddEventHandler(handler.Pass());\n+ }\n+}\n+\n+void AppEventRegistrar::Remove(const std::string& event_name,\n+ const std::string& app_id,\n+ const EventHandlerCallback& callback) {\n+ HandlerRecord record(event_name, app_id, callback);\n+ HandlerRecordVector::iterator it = records_.begin();\n+ for (; it != records_.end(); it++) {\n+ if (**it == record)\n+ break;\n+ }\n+ if (it == records_.end())\n+ return;\n+\n+ records_.erase(it);\n+ scoped_ptr<EventHandler> handler(new EventHandler(\n+ event_name, app_id, callback, GetWeakPtr()));\n+ RemoveEventHandler(handler.Pass());\n+}\n+\n+void AppEventRegistrar::RemoveAll() {\n+ HandlerRecordVector::iterator it = records_.begin();\n+ for (; it != records_.end(); it++) {\n+ scoped_ptr<EventHandler> handler(new EventHandler(\n+ (*it)->event_name, (*it)->app_id, (*it)->callback, GetWeakPtr()));\n+ RemoveEventHandler(handler.Pass());\n+ }\n+ records_.clear();\n+}\n+","path":"application/browser/application_event_registrar.cc","position":89,"original_position":89,"commit_id":"3201262f4ac2253625f39011b328707b78145ecd","original_commit_id":"3201262f4ac2253625f39011b328707b78145ecd","user":{"login":"mbbill","id":841602,"avatar_url":"https://0.gravatar.com/avatar/4c96f8afdf03dfe5591422ca283a0dbd?d=https%3A%2F%2Fidenticons.github.com%2Fc1bda2e86e4595c6038e8cb9cdbe92ca.png&r=x","gravatar_id":"4c96f8afdf03dfe5591422ca283a0dbd","url":"https://api.github.com/users/mbbill","html_url":"https://github.com/mbbill","followers_url":"https://api.github.com/users/mbbill/followers","following_url":"https://api.github.com/users/mbbill/following{/other_user}","gists_url":"https://api.github.com/users/mbbill/gists{/gist_id}","starred_url":"https://api.github.com/users/mbbill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbbill/subscriptions","organizations_url":"https://api.github.com/users/mbbill/orgs","repos_url":"https://api.github.com/users/mbbill/repos","events_url":"https://api.github.com/users/mbbill/events{/privacy}","received_events_url":"https://api.github.com/users/mbbill/received_events","type":"User","site_admin":false},"body":"The 'RemoveEventHandler' is thread-safe but 'RemoveAll' is not, perhaps there should be some pointers for the user.","created_at":"2013-11-05T12:51:45Z","updated_at":"2013-11-05T12:51:45Z","html_url":"https://github.com/crosswalk-project/crosswalk/pull/1057#discussion_r7429170","pull_request_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/1057","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/7429170"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/1057#discussion_r7429170"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/1057"}}}} | {
"id": 9207280,
"name": "crosswalk",
"url": "https://github.com/crosswalk-project/crosswalk"
} | {
"id": null,
"login": "mbbill",
"gravatar_id": "4c96f8afdf03dfe5591422ca283a0dbd",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "crosswalk-project",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-05T12:51:45 | null | {"repository":{"description":"","watchers":14,"stargazers":14,"forks":45,"fork":false,"size":22256,"owner":"crosswalk-project","private":false,"open_issues":126,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2013-04-03T16:30:12-07:00","pushed_at":"2013-11-05T04:02:45-08:00","master_branch":"master","organization":"crosswalk-project"},"actor_attributes":{"type":"User","name":"Ming, Bai","company":"Intel","location":"SH","email":"[email protected]"},"url":"https://github.com/crosswalk-project/crosswalk/pull/1057#discussion_r7429170"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/7086952","id":7086952,"diff_hunk":"@@ -84,8 +90,12 @@\n },\n {\n 'destination': '<(PRODUCT_DIR)/xwalk_xwview_test/assets',\n- 'files': ['<(java_in_dir)/assets/index.html'],\n+ 'files': ['<(java_in_dir)/assets/framesEcho.html'],\n },\n+ {\n+ 'destination': '<(PRODUCT_DIR)/xwalk_xwview_test/assets',\n+ 'files': ['<(java_in_dir)/assets/index.html'],\n+ }","path":"xwalk_android_tests.gypi","position":null,"original_position":32,"commit_id":"0124a581f07bce871b6e78bf2906040ddf88e7ee","original_commit_id":"0bb1cf2693a9902b7846a1b6f8cf8a1e769b945c","user":{"login":"halton","id":433218,"avatar_url":"https://2.gravatar.com/avatar/12aa489648dd89d591d6514602d705be?d=https%3A%2F%2Fidenticons.github.com%2F41d0f00a74366a18ad9881e44620a9a9.png","gravatar_id":"12aa489648dd89d591d6514602d705be","url":"https://api.github.com/users/halton","html_url":"https://github.com/halton","followers_url":"https://api.github.com/users/halton/followers","following_url":"https://api.github.com/users/halton/following{/other_user}","gists_url":"https://api.github.com/users/halton/gists{/gist_id}","starred_url":"https://api.github.com/users/halton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halton/subscriptions","organizations_url":"https://api.github.com/users/halton/orgs","repos_url":"https://api.github.com/users/halton/repos","events_url":"https://api.github.com/users/halton/events{/privacy}","received_events_url":"https://api.github.com/users/halton/received_events","type":"User","site_admin":false},"body":"After sync with @hmin , we agree to use previous code instead of copy whole folder. We might improve that in later PR. @DonnaWuDongxia, you need change the code back, I'm sorry for change code back and force.","created_at":"2013-10-21T07:22:39Z","updated_at":"2013-10-21T07:22:39Z","html_url":"https://github.com/crosswalk-project/crosswalk/pull/907#discussion_r7086952","pull_request_url":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/907","_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/comments/7086952"},"html":{"href":"https://github.com/crosswalk-project/crosswalk/pull/907#discussion_r7086952"},"pull_request":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk/pulls/907"}}}} | {
"id": 9207280,
"name": "crosswalk",
"url": "https://github.com/crosswalk-project/crosswalk"
} | {
"id": null,
"login": "halton",
"gravatar_id": "12aa489648dd89d591d6514602d705be",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "crosswalk-project",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-21T07:22:39 | null | {"repository":{"description":"","watchers":10,"stargazers":10,"forks":41,"fork":false,"size":21020,"owner":"crosswalk-project","private":false,"open_issues":202,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2013-04-03T16:30:12-07:00","pushed_at":"2013-10-20T08:52:57-07:00","master_branch":"master","organization":"crosswalk-project"},"actor_attributes":{"type":"User","name":"Halton Huo","company":"Intel","location":"Beijing, China","email":"[email protected] or halton.huo"},"url":"https://github.com/crosswalk-project/crosswalk/pull/907#discussion_r7086952"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/opscode-cookbooks/tmux/pulls/comments/6358152","id":6358152,"body":"I don't think you meant to delete this file?","diff_hunk":"@@ -1,5 +0,0 @@\n-if node['platform_family'] == 'rhel'\n- include_recipe 'yum::epel'\n-end\n-\n-package 'tmux'","path":"recipes/package.rb","position":5,"original_position":5,"commit_id":"454c7839ebf91d108f942798c1735975a800dd7d","original_commit_id":"454c7839ebf91d108f942798c1735975a800dd7d","user":{"login":"btm","id":4381,"avatar_url":"https://1.gravatar.com/avatar/4e4adb8dd390e1daecb15a67f05ae0d1?d=https%3A%2F%2Fidenticons.github.com%2Fd2e9dd9dcd97fd12a2cb62e2bf7cbe35.png","gravatar_id":"4e4adb8dd390e1daecb15a67f05ae0d1","url":"https://api.github.com/users/btm","html_url":"https://github.com/btm","followers_url":"https://api.github.com/users/btm/followers","following_url":"https://api.github.com/users/btm/following{/other_user}","gists_url":"https://api.github.com/users/btm/gists{/gist_id}","starred_url":"https://api.github.com/users/btm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btm/subscriptions","organizations_url":"https://api.github.com/users/btm/orgs","repos_url":"https://api.github.com/users/btm/repos","events_url":"https://api.github.com/users/btm/events{/privacy}","received_events_url":"https://api.github.com/users/btm/received_events","type":"User"},"created_at":"2013-09-13T20:34:22Z","updated_at":"2013-09-13T20:34:22Z","html_url":"https://github.com/opscode-cookbooks/tmux/pull/12#discussion_r6358152","pull_request_url":"https://api.github.com/repos/opscode-cookbooks/tmux/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/opscode-cookbooks/tmux/pulls/comments/6358152"},"html":{"href":"https://github.com/opscode-cookbooks/tmux/pull/12#discussion_r6358152"},"pull_request":{"href":"https://api.github.com/repos/opscode-cookbooks/tmux/pulls/12"}}}} | {
"id": 3720707,
"name": "tmux",
"url": "https://github.com/opscode-cookbooks/tmux"
} | {
"id": null,
"login": "btm",
"gravatar_id": "4e4adb8dd390e1daecb15a67f05ae0d1",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "opscode-cookbooks",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-13T20:34:22 | null | {"repository":{"description":"Development repository for Opscode Cookbook tmux","homepage":"http://community.opscode.com/cookbooks/tmux","watchers":20,"stargazers":20,"forks":25,"fork":false,"size":244,"owner":"opscode-cookbooks","private":false,"open_issues":2,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2012-03-14T11:22:26-07:00","pushed_at":"2013-09-10T08:02:23-07:00","master_branch":"master","organization":"opscode-cookbooks"},"actor_attributes":{"type":"User","name":"Bryan McLellan","company":"Opscode","blog":"http://blog.loftninjas.org","location":"Surry, ME","email":"[email protected]"},"url":"https://github.com/opscode-cookbooks/tmux/pull/12#discussion_r6358152"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/opscode-cookbooks/homebrew/pulls/comments/8424911","id":8424911,"diff_hunk":"@@ -20,3 +20,4 @@\n #\n \n default['homebrew']['owner'] = nil\n+default['homebrew']['install_script_uri'] = 'https://raw.github.com/mxcl/homebrew/go/install'","path":"attributes/default.rb","position":null,"original_position":4,"commit_id":"08790258c347d0f8ed7d11cc867ed9f772388d22","original_commit_id":"bb5274dc42b7a4a9820554c7a3ae8a6b81485e9e","user":{"login":"spesnova","id":261700,"avatar_url":"https://gravatar.com/avatar/32f2e5ddb187baa2abac66d7e8b283fe?d=https%3A%2F%2Fidenticons.github.com%2Fe3c62cfac82b888849703b591e953b3f.png&r=x","gravatar_id":"32f2e5ddb187baa2abac66d7e8b283fe","url":"https://api.github.com/users/spesnova","html_url":"https://github.com/spesnova","followers_url":"https://api.github.com/users/spesnova/followers","following_url":"https://api.github.com/users/spesnova/following{/other_user}","gists_url":"https://api.github.com/users/spesnova/gists{/gist_id}","starred_url":"https://api.github.com/users/spesnova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spesnova/subscriptions","organizations_url":"https://api.github.com/users/spesnova/orgs","repos_url":"https://api.github.com/users/spesnova/repos","events_url":"https://api.github.com/users/spesnova/events{/privacy}","received_events_url":"https://api.github.com/users/spesnova/received_events","type":"User","site_admin":false},"body":"OK, I'll change to `install_script`\r\n\r\nCurrently, as hiremaga commented, url changes frequently. So this should be an attribute. Why don't we hard-code this url after these url changes become stable?","created_at":"2013-12-18T02:16:49Z","updated_at":"2013-12-18T02:16:49Z","html_url":"https://github.com/opscode-cookbooks/homebrew/pull/20#discussion_r8424911","pull_request_url":"https://api.github.com/repos/opscode-cookbooks/homebrew/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/opscode-cookbooks/homebrew/pulls/comments/8424911"},"html":{"href":"https://github.com/opscode-cookbooks/homebrew/pull/20#discussion_r8424911"},"pull_request":{"href":"https://api.github.com/repos/opscode-cookbooks/homebrew/pulls/20"}}}} | {
"id": 4728983,
"name": "homebrew",
"url": "https://github.com/opscode-cookbooks/homebrew"
} | {
"id": null,
"login": "spesnova",
"gravatar_id": "32f2e5ddb187baa2abac66d7e8b283fe",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "opscode-cookbooks",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-18T02:16:49 | null | {"repository":{"description":"Development repository for Opscode Cookbook homebrew","homepage":"http://community.opscode.com/cookbooks/homebrew","watchers":48,"stargazers":48,"forks":39,"fork":false,"size":246,"owner":"opscode-cookbooks","private":false,"open_issues":5,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2012-06-20T10:16:00-07:00","pushed_at":"2013-11-03T20:22:55-08:00","master_branch":"master","organization":"opscode-cookbooks"},"actor_attributes":{"type":"User","name":"Seigo Uchida","location":"Tokyo, Japan","email":"[email protected]"},"url":"https://github.com/opscode-cookbooks/homebrew/pull/20#discussion_r8424911"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/TakenokoChocoHolic/wpcs/pulls/comments/4086710","id":4086710,"body":"For inconsistency, we should write this line as follows, I think.\r\n\r\n gems = messages.reject{ |_| _.starts_with?(Rails.root.to_s) }","diff_hunk":"@@ -8,4 +8,21 @@ def format_date(date_time, format = nil)\n return date_time.strftime(format)\n end\n \n+ def format_backtrace(messages)\n+ def same_prefix(lhs, rhs)\n+ len = 0.upto(lhs.size) do |i|\n+ break i if lhs[i] != rhs[i]\n+ end\n+ lhs[0...len]\n+ end\n+\n+ gems = messages.reject{|_| _.starts_with?(Rails.root.to_s)}","path":"app/helpers/application_helper.rb","position":12,"original_position":12,"commit_id":"8396b42efc5583bc97e2e82ddc44595c0a604125","original_commit_id":"8396b42efc5583bc97e2e82ddc44595c0a604125","user":{"login":"exKAZUu","id":436237,"avatar_url":"https://secure.gravatar.com/avatar/bfee60ccae73e6bdafde5eda16db9b52?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"bfee60ccae73e6bdafde5eda16db9b52","url":"https://api.github.com/users/exKAZUu","html_url":"https://github.com/exKAZUu","followers_url":"https://api.github.com/users/exKAZUu/followers","following_url":"https://api.github.com/users/exKAZUu/following{/other_user}","gists_url":"https://api.github.com/users/exKAZUu/gists{/gist_id}","starred_url":"https://api.github.com/users/exKAZUu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exKAZUu/subscriptions","organizations_url":"https://api.github.com/users/exKAZUu/orgs","repos_url":"https://api.github.com/users/exKAZUu/repos","events_url":"https://api.github.com/users/exKAZUu/events{/privacy}","received_events_url":"https://api.github.com/users/exKAZUu/received_events","type":"User"},"created_at":"2013-05-05T12:09:53Z","updated_at":"2013-05-05T12:09:53Z","html_url":"https://github.com/TakenokoChocoHolic/wpcs/pull/146#discussion_r4086710","pull_request_url":"https://api.github.com/repos/TakenokoChocoHolic/wpcs/pulls/146","_links":{"self":{"href":"https://api.github.com/repos/TakenokoChocoHolic/wpcs/pulls/comments/4086710"},"html":{"href":"https://github.com/TakenokoChocoHolic/wpcs/pull/146#discussion_r4086710"},"pull_request":{"href":"https://api.github.com/repos/TakenokoChocoHolic/wpcs/pulls/146"}}}} | {
"id": 7731458,
"name": "wpcs",
"url": "https://github.com/TakenokoChocoHolic/wpcs"
} | {
"id": null,
"login": "exKAZUu",
"gravatar_id": "bfee60ccae73e6bdafde5eda16db9b52",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "TakenokoChocoHolic",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-05T12:09:53 | null | {"repository":{"description":"","watchers":1,"stargazers":1,"forks":3,"fork":false,"size":624,"owner":"TakenokoChocoHolic","private":false,"open_issues":7,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-01-21T03:56:14-08:00","pushed_at":"2013-05-05T05:01:55-07:00","master_branch":"master","organization":"TakenokoChocoHolic"},"actor_attributes":{"type":"User","name":"SAKAMOTO Kazunori","company":"Waseda University","blog":"http://twitter.com/exkazuu","location":"Japan","email":"[email protected]"},"url":"https://github.com/TakenokoChocoHolic/wpcs/pull/146#discussion_r4086710"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/railsbridge-boston/railsbridge-boston/pulls/comments/5427397","id":5427397,"body":"thoughtbot should not be capitalized.","diff_hunk":"@@ -0,0 +1,229 @@\n+On a sunny Saturday morning in June, over 100 techies piled into the \n+Microsoft NERD center by the Charles River in Cambrdige. 68 students\n+and 35 teaching assistants worked through a curriculum of Ruby, \n+Rails, HTML, and CSS. Armed with laptops, a projector, and \n+determination the students built fully functional web applications, \n+deployed on Heroku servers for all the world to see. \n+\n+The Boston Railsbridge Workshop for women and their friends was first\n+held in August of 2012. It set out to improve the diversity of an \n+increasingly-homogenized community of Ruby developers in Boston. \n+\n+Since then, 4 more workshops have been held and over 200 students \n+have run through its lessons. At the June workshop, 64 of the 68 \n+attending students identified as women. Students range from \n+entrepreneurs to college undergraduates to those just looking for a\n+career change. The workshop aims to act as an entry point into the\n+often exclusive or intimidating world of open source developoment.\n+The curriculum assumes no prior experience with programming and \n+application development. On Friday evening, students install \n+Ruby, Rails, Git, Heroku, and other necessary libraries. Then, \n+with the aids of their TAs, they work through a series of lessons\n+to build their own survey application. In addition, several \n+lectures are given to introduce topics, such as Ruby syntax and the \n+Model-View-Controller pattern. The workshop wrapped up with a \n+cooldown at the Cambridge Brewing Company, where students and TAs \n+shared tips, business cards, and a few beverages. \n+\n+### TA-to-Student Ratio\n+\n+This workshop was our largest yet, both in terms of students and \n+teaching assistants. Thanks to the vibrant Boston Ruby community \n+and the tireless work of the organizers, we were able to approach \n+a ratio of 2 students for every 1 teaching assistant. In addition, \n+many students of previous workshops came back to be teaching \n+assistants for this workshop. In previous workshops, we'd found \n+that the number of teaching assistants was overwhelmingly the most \n+lauded feature of the workshop amongst students, and we feel like \n+it is the key to our success.\n+\n+### Childcare\n+\n+Thanks to sponsorship from [Thoughtbot](http://www.thoughtbot.com/), we \n+were able to ofter childcare assistance during the workshop. One \n+mother left us particularly kind feedback.\n+\n+---\n+\n+> I'd like to extend the most heartfelt of thank-yous to those who \n+> made childcare possible. I felt entirely comfortable leaving my \n+> two-year-old with the person the service sent, and without the \n+> childcare I wouldn't have been able to attend at all. I appreciate \n+> the organizers thinking of (single) moms who want to code more than \n+> I can say.\n+\n+### Updated Curriculum\n+\n+Before each workshop, we do our best to take into account any \n+suggestions made and keep all references to technology up to date. \n+We faced an interesting quandary with Rails 4.0, which was to be \n+released imminently at the time of the workshop. In the end, we \n+decided to stick with 3.2. \n+\n+If you would like to help out with the curriculum, head over to \n+[our github page](https://github.com/railsbridge-boston/railsbridge-boston) \n+and raise a discussion or make a pull request.\n+\n+### Continuing Education\n+\n+A common suggestion from previous attendees was that they often \n+felt confused as to what they should do after the workshop. Anyone \n+who has tried to teach themselves a new technology knows that it \n+can be just like a minotaur's labyrinth, full of misleading paths \n+and shifting sands. Before we closed out this workshop, we made a \n+special note of showing different resources and tutorials that \n+were appropriately challenging and informative.\n+\n+Thanks to our awesome sponsors, we were also able to offer our \n+graduates several freebies and deals. Every student was able to \n+choose an [O'Reilly E-book](http://oreilly.com/) for free. Ryan \n+Bates was kind enough to offer some free subscriptions to \n+[Railscasts](railscasts.com) and [Thoughtbot](http://www.thoughtbot.com) provided ","path":"views/blog/2013_jun_recap_text.markdown","position":81,"original_position":81,"commit_id":"e1a8d6d8f54fc8d2cdebf4abe7f846c2abc11f3c","original_commit_id":"e1a8d6d8f54fc8d2cdebf4abe7f846c2abc11f3c","user":{"login":"drapergeek","id":89965,"avatar_url":"https://secure.gravatar.com/avatar/052d8e5667c18e10d59e98a35d84642a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"052d8e5667c18e10d59e98a35d84642a","url":"https://api.github.com/users/drapergeek","html_url":"https://github.com/drapergeek","followers_url":"https://api.github.com/users/drapergeek/followers","following_url":"https://api.github.com/users/drapergeek/following{/other_user}","gists_url":"https://api.github.com/users/drapergeek/gists{/gist_id}","starred_url":"https://api.github.com/users/drapergeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drapergeek/subscriptions","organizations_url":"https://api.github.com/users/drapergeek/orgs","repos_url":"https://api.github.com/users/drapergeek/repos","events_url":"https://api.github.com/users/drapergeek/events{/privacy}","received_events_url":"https://api.github.com/users/drapergeek/received_events","type":"User"},"created_at":"2013-07-26T17:06:39Z","updated_at":"2013-07-26T17:06:39Z","html_url":"https://github.com/railsbridge-boston/railsbridge-boston/pull/84#discussion_r5427397","pull_request_url":"https://api.github.com/repos/railsbridge-boston/railsbridge-boston/pulls/84","_links":{"self":{"href":"https://api.github.com/repos/railsbridge-boston/railsbridge-boston/pulls/comments/5427397"},"html":{"href":"https://github.com/railsbridge-boston/railsbridge-boston/pull/84#discussion_r5427397"},"pull_request":{"href":"https://api.github.com/repos/railsbridge-boston/railsbridge-boston/pulls/84"}}}} | {
"id": 5565625,
"name": "railsbridge-boston",
"url": "https://github.com/railsbridge-boston/railsbridge-boston"
} | {
"id": null,
"login": "drapergeek",
"gravatar_id": "052d8e5667c18e10d59e98a35d84642a",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "railsbridge-boston",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-26T17:06:39 | null | {"repository":{"description":"Railsbridge Boston workshop for women and their friends.","homepage":"","watchers":16,"stargazers":16,"forks":27,"fork":false,"size":61674,"owner":"railsbridge-boston","private":false,"open_issues":20,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-08-26T19:10:34-07:00","pushed_at":"2013-07-26T10:02:33-07:00","master_branch":"master","organization":"railsbridge-boston"},"actor_attributes":{"type":"User","name":"Jason Draper","blog":"","location":"Boston, MA","email":"[email protected]"},"url":"https://github.com/railsbridge-boston/railsbridge-boston/pull/84#discussion_r5427397"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/pulls/comments/4823538","id":4823538,"body":"Can you provide database-agnostic documentation here? Perhaps just keep the `all` and do the nil checking in the block. Inefficient, but will work for everyone.","diff_hunk":"@@ -418,6 +418,14 @@ User.all.each do |user|\n end\n ```\n \n+`recreate_versions!` will throw an exception if it encounters a record without an image. To avoid this, eg. in production, simply scope the records to recreate the images for:\n+\n+```ruby\n+User.where(\"avatar IS NOT NULL\").each do |user|","path":"README.md","position":16,"original_position":16,"commit_id":"2e87a32df2f54838411712b81ef91ecd72879ef9","original_commit_id":"2e87a32df2f54838411712b81ef91ecd72879ef9","user":{"login":"bensie","id":4595,"avatar_url":"https://secure.gravatar.com/avatar/80643cc5c7a70d4cdddebc3185cd3c18?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"80643cc5c7a70d4cdddebc3185cd3c18","url":"https://api.github.com/users/bensie","html_url":"https://github.com/bensie","followers_url":"https://api.github.com/users/bensie/followers","following_url":"https://api.github.com/users/bensie/following{/other_user}","gists_url":"https://api.github.com/users/bensie/gists{/gist_id}","starred_url":"https://api.github.com/users/bensie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bensie/subscriptions","organizations_url":"https://api.github.com/users/bensie/orgs","repos_url":"https://api.github.com/users/bensie/repos","events_url":"https://api.github.com/users/bensie/events{/privacy}","received_events_url":"https://api.github.com/users/bensie/received_events","type":"User"},"created_at":"2013-06-21T17:56:44Z","updated_at":"2013-06-21T17:56:44Z","html_url":"https://github.com/carrierwaveuploader/carrierwave/pull/1129#discussion_r4823538","pull_request_url":"https://api.github.com/repos/carrierwaveuploader/carrierwave/pulls/1129","_links":{"self":{"href":"https://api.github.com/repos/carrierwaveuploader/carrierwave/pulls/comments/4823538"},"html":{"href":"https://github.com/carrierwaveuploader/carrierwave/pull/1129#discussion_r4823538"},"pull_request":{"href":"https://api.github.com/repos/carrierwaveuploader/carrierwave/pulls/1129"}}}} | {
"id": 47087,
"name": "carrierwave",
"url": "https://github.com/carrierwaveuploader/carrierwave"
} | {
"id": null,
"login": "bensie",
"gravatar_id": "80643cc5c7a70d4cdddebc3185cd3c18",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "carrierwaveuploader",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-21T17:56:44 | null | {"repository":{"description":"Classier solution for file uploads for Rails, Sinatra and other Ruby web frameworks","homepage":"https://github.com/carrierwaveuploader/carrierwave","watchers":4090,"stargazers":4090,"forks":638,"fork":false,"size":900,"owner":"carrierwaveuploader","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2008-08-28T11:39:49-07:00","pushed_at":"2013-06-13T08:57:41-07:00","master_branch":"master","organization":"carrierwaveuploader"},"actor_attributes":{"type":"User","name":"James Miller","company":"JK Tech","blog":"http://www.bensie.com","location":"San Diego, CA","email":"[email protected]"},"url":"https://github.com/carrierwaveuploader/carrierwave/pull/1129#discussion_r4823538"} |
PullRequestReviewCommentEvent | true | {"comment":{"body":"let that \"=\" breathe if possible :)","commit_id":"0d0ccfd782afb91223c1ccdb740c7fd4b296a783","_links":{"html":{"href":"https://github.com/ImaginationForPeople/imaginationforpeople/pull/86#discussion_r2896599"},"pull_request":{"href":"https://api.github.com/repos/ImaginationForPeople/imaginationforpeople/pulls/86"},"self":{"href":"https://api.github.com/repos/ImaginationForPeople/imaginationforpeople/pulls/comments/2896599"}},"original_position":35,"url":"https://api.github.com/repos/ImaginationForPeople/imaginationforpeople/pulls/comments/2896599","id":2896599,"updated_at":"2013-02-05T17:35:58Z","user":{"followers_url":"https://api.github.com/users/glibersat/followers","subscriptions_url":"https://api.github.com/users/glibersat/subscriptions","received_events_url":"https://api.github.com/users/glibersat/received_events","events_url":"https://api.github.com/users/glibersat/events{/privacy}","organizations_url":"https://api.github.com/users/glibersat/orgs","repos_url":"https://api.github.com/users/glibersat/repos","login":"glibersat","avatar_url":"https://secure.gravatar.com/avatar/2fbd59ebf1e0808716a569f0305d2873?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gists_url":"https://api.github.com/users/glibersat/gists{/gist_id}","starred_url":"https://api.github.com/users/glibersat/starred{/owner}{/repo}","url":"https://api.github.com/users/glibersat","id":262663,"type":"User","gravatar_id":"2fbd59ebf1e0808716a569f0305d2873","following_url":"https://api.github.com/users/glibersat/following"},"path":"apps/api/views/workgroup.py","original_commit_id":"0d0ccfd782afb91223c1ccdb740c7fd4b296a783","position":35,"created_at":"2013-02-05T17:35:58Z"}} | {
"id": 2533661,
"name": "imaginationforpeople",
"url": "https://github.com/ImaginationForPeople/imaginationforpeople"
} | {
"id": null,
"login": "glibersat",
"gravatar_id": "2fbd59ebf1e0808716a569f0305d2873",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "ImaginationForPeople",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-05T17:35:58 | null | {"repository":{"homepage":"http://imaginationforpeople.org/wiki/en/dev","owner":"ImaginationForPeople","has_issues":true,"created_at":"2011-10-07T09:20:55-07:00","description":"I4P: Web-Application powering imaginationforpeople.org","has_downloads":true,"organization":"ImaginationForPeople","watchers":22,"language":"JavaScript","open_issues":2,"pushed_at":"2013-02-04T12:33:22-08:00","stargazers":22,"forks":14,"fork":false,"size":668,"has_wiki":false,"private":false,"integrate_branch":"develop"},"actor_attributes":{"company":"Fuzzy Frequency","location":"Lille, France","name":"Guillaume Libersat","blog":"http://fuzzyfrequency.com","email":"[email protected]","type":"User"},"url":"https://github.com/ImaginationForPeople/imaginationforpeople/pull/86#discussion_r2896599"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/appcelerator-modules/ti.passbook/pulls/comments/4316552","id":4316552,"body":"Does this function need to check for iOS6 before attempting to use PKPassLibrary?","diff_hunk":"@@ -0,0 +1,238 @@\n+/**\n+ * Ti.Passbook Module\n+ * Copyright (c) 2013 by Appcelerator, Inc. All Rights Reserved.\n+ * Please see the LICENSE included with this distribution for details.\n+ */\n+\n+#import <PassKit/PassKit.h>\n+#import \"TiPassbookModule.h\"\n+#import \"TiBase.h\"\n+#import \"TiHost.h\"\n+#import \"TiUtils.h\"\n+#import \"TiApp.h\"\n+#import \"TiPassbookPassProxy.h\"\n+\n+@implementation TiPassbookModule\n+\n+#pragma mark Internal\n+\n+// this is generated for your module, please do not change it\n+-(id)moduleGUID\n+{\n+\treturn @\"e46dcae2-4553-4ebb-9fe2-1b234776727a\";\n+}\n+\n+// this is generated for your module, please do not change it\n+-(NSString*)moduleId\n+{\n+\treturn @\"ti.passbook\";\n+}\n+\n+#pragma mark Lifecycle\n+\n+-(void)startup\n+{\n+\t// this method is called when the module is first loaded\n+\t// you *must* call the superclass\n+\t[super startup];\n+ \n+#if __IPHONE_OS_VERSION_MAX_ALLOWED < __IPHONE_6_0\n+ NSLog(@\"[ERROR] Passbook module compiled without support for iOS 6.0! Nothing will work unless you recompile the module!\");\n+ return;\n+#endif\n+ if (![TiUtils isIOS6OrGreater]) {\n+ NSLog(@\"[ERROR] Passbook module does not support less than iOS 6.0\");\n+ return;\n+ }\n+ \n+ _passLibrary = [[PKPassLibrary alloc] init];\n+\n+ // Listen for PKLibraryEvents\n+ [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(passLibraryDidChange:) name:PKPassLibraryDidChangeNotification object:_passLibrary];\n+\t\n+\tNSLog(@\"[INFO] %@ loaded\",self); \n+}\n+\n+-(void)shutdown:(id)sender\n+{\n+\t// this method is called when the module is being unloaded\n+\t// typically this is during shutdown. make sure you don't do too\n+\t// much processing here or the app will be quit forceably\n+\t\n+ // Listening for PKLibraryEvents\n+ [[NSNotificationCenter defaultCenter] removeObserver:self];\n+ \n+\t// you *must* call the superclass\n+\t[super shutdown:sender];\n+}\n+\n+#pragma mark Cleanup \n+\n+-(void)dealloc\n+{\n+ RELEASE_TO_NIL(_passLibrary);\n+\t// release any resources that have been retained by the module\n+\t[super dealloc];\n+}\n+\n+#pragma mark Listener Notifications\n+\n+-(void)passLibraryDidChange:(NSNotification *)note\n+{\n+ NSDictionary *userInfo = [note userInfo];\n+ NSArray *passArray;\n+ \n+ if ((passArray = [userInfo objectForKey:PKPassLibraryAddedPassesUserInfoKey]) && [self _hasListeners:@\"addedpasses\"]) {\n+ NSDictionary *event = [self pkPassArrayToEventDictionary:passArray];\n+ [self fireEvent:@\"addedpasses\" withObject:event];\n+ }\n+ \n+ if ((passArray = [userInfo objectForKey: PKPassLibraryRemovedPassInfosUserInfoKey]) && [self _hasListeners:@\"removedpasses\"]) {\n+ NSDictionary *event = [self passIdArrayToEventDictionary:passArray];\n+ [self fireEvent:@\"removedpasses\" withObject:event];\n+ }\n+ \n+ if ((passArray = [userInfo objectForKey:PKPassLibraryReplacementPassesUserInfoKey]) && [self _hasListeners:@\"replacedpasses\"]) {\n+ NSDictionary *event = [self pkPassArrayToEventDictionary:passArray];\n+ [self fireEvent:@\"replacedpasses\" withObject:event];\n+ }\n+}\n+\n+-(NSDictionary *)pkPassArrayToEventDictionary:(NSArray *)passArray\n+{\n+ NSMutableArray *passes = [NSMutableArray arrayWithCapacity:[passArray count]];\n+ for (PKPass *pkPass in passArray) {\n+ [passes addObject:[[[TiPassbookPassProxy alloc] initWithPass:pkPass pageContext:[self executionContext]] autorelease]];\n+ }\n+ return [NSDictionary dictionaryWithObject:passes forKey:@\"passes\"];\n+}\n+\n+-(NSDictionary *)passIdArrayToEventDictionary:(NSArray *)passArray\n+{\n+ NSMutableArray *passes = [NSMutableArray arrayWithCapacity:[passArray count]];\n+ for (NSDictionary *passDict in passArray) {\n+ [passes addObject:[NSDictionary dictionaryWithObjectsAndKeys:\n+ [passDict objectForKey:PKPassLibraryPassTypeIdentifierUserInfoKey], @\"passTypeIdentifier\",\n+ [passDict objectForKey:PKPassLibrarySerialNumberUserInfoKey], @\"serialNumber\",\n+ nil]];\n+ }\n+ return [NSDictionary dictionaryWithObject:passes forKey:@\"passIds\"];\n+}\n+\n+#pragma mark - Public APIs\n+\n+-(id)isPassLibraryAvailable:(id)args\n+{\n+ return NUMBOOL([PKPassLibrary isPassLibraryAvailable]);","path":"ios/Classes/TiPassbookModule.m","position":126,"original_position":126,"commit_id":"d2b863f7b8f3827348f503dc7395524d4b57fe07","original_commit_id":"d2b863f7b8f3827348f503dc7395524d4b57fe07","user":{"login":"JeffEnglish","id":143293,"avatar_url":"https://secure.gravatar.com/avatar/dc7128cfcf6623e988d7e3a6738be377?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"dc7128cfcf6623e988d7e3a6738be377","url":"https://api.github.com/users/JeffEnglish","html_url":"https://github.com/JeffEnglish","followers_url":"https://api.github.com/users/JeffEnglish/followers","following_url":"https://api.github.com/users/JeffEnglish/following{/other_user}","gists_url":"https://api.github.com/users/JeffEnglish/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffEnglish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffEnglish/subscriptions","organizations_url":"https://api.github.com/users/JeffEnglish/orgs","repos_url":"https://api.github.com/users/JeffEnglish/repos","events_url":"https://api.github.com/users/JeffEnglish/events{/privacy}","received_events_url":"https://api.github.com/users/JeffEnglish/received_events","type":"User"},"created_at":"2013-05-21T13:34:16Z","updated_at":"2013-05-21T13:34:16Z","html_url":"https://github.com/appcelerator-modules/ti.passbook/pull/1#discussion_r4316552","pull_request_url":"https://api.github.com/repos/appcelerator-modules/ti.passbook/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/appcelerator-modules/ti.passbook/pulls/comments/4316552"},"html":{"href":"https://github.com/appcelerator-modules/ti.passbook/pull/1#discussion_r4316552"},"pull_request":{"href":"https://api.github.com/repos/appcelerator-modules/ti.passbook/pulls/1"}}}} | {
"id": 9921952,
"name": "ti.passbook",
"url": "https://github.com/appcelerator-modules/ti.passbook"
} | {
"id": null,
"login": "JeffEnglish",
"gravatar_id": "dc7128cfcf6623e988d7e3a6738be377",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "appcelerator-modules",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-21T13:34:16 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":2,"fork":false,"size":116,"owner":"appcelerator-modules","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"created_at":"2013-05-07T14:22:04-07:00","pushed_at":"2013-05-07T14:25:54-07:00","master_branch":"master","organization":"appcelerator-modules"},"actor_attributes":{"type":"User","name":"Jeff English","company":"Appcelerator","blog":"www.appcelerator.com","location":"Plano, TX","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/appcelerator-modules/ti.passbook/pull/1#discussion_r4316552"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/appcelerator-modules/ti.newsstand/pulls/comments/3353865","id":3353865,"body":"Shouldn't this event be 'assetComplete'","diff_hunk":"@@ -0,0 +1,362 @@\n+/**\n+ * Ti.Newsstand Module\n+ * Copyright (c) 2013 by Appcelerator, Inc. All Rights Reserved.\n+ * Please see the LICENSE included with this distribution for details.\n+ */\n+\n+#import <NewsstandKit/NewsstandKit.h>\n+#import \"TiNewsstandModule.h\"\n+#import \"TiBase.h\"\n+#import \"TiHost.h\"\n+#import \"TiNewsstandIssueProxy.h\"\n+\n+@implementation TiNewsstandModule\n+\n+@synthesize username = _username;\n+@synthesize password = _password;\n+\n+#pragma mark Internal\n+\n+// this is generated for your module, please do not change it\n+-(id)moduleGUID\n+{\n+ return @\"21c03409-3f8c-41db-bf41-d45eaa784f17\";\n+}\n+\n+// this is generated for your module, please do not change it\n+-(NSString*)moduleId\n+{\n+ return @\"ti.newsstand\";\n+}\n+\n+#pragma mark Lifecycle\n+\n+-(void)startup\n+{\n+ // this method is called when the module is first loaded\n+ // you *must* call the superclass\n+ [super startup];\n+\n+ // Pending downloads must be reconnected when the app starts or they will be cancelled\n+ [self checkForPendingDownloads];\n+ \n+ NSLog(@\"[INFO] %@ loaded\",self);\n+}\n+\n+-(void)shutdown:(id)sender\n+{\n+ // this method is called when the module is being unloaded\n+ // typically this is during shutdown. make sure you don't do too\n+ // much processing here or the app will be quit forceably\n+ \n+ // you *must* call the superclass\n+ [super shutdown:sender];\n+}\n+\n+#pragma mark Cleanup \n+\n+-(void)dealloc\n+{\n+ RELEASE_TO_NIL(_username);\n+ RELEASE_TO_NIL(_password);\n+ [super dealloc];\n+}\n+\n+#pragma mark Internal Memory Management\n+\n+-(void)didReceiveMemoryWarning:(NSNotification*)notification\n+{\n+ // optionally release any resources that can be dynamically\n+ // reloaded once memory is available - such as caches\n+ [super didReceiveMemoryWarning:notification];\n+}\n+\n+#pragma mark Public APIs\n+\n+MAKE_SYSTEM_PROP(ISSUE_CONTENT_STATUS_NONE, NKIssueContentStatusNone);\n+MAKE_SYSTEM_PROP(ISSUE_CONTENT_STATUS_DOWNLOADING, NKIssueContentStatusDownloading);\n+MAKE_SYSTEM_PROP(ISSUE_CONTENT_STATUS_AVAILABLE, NKIssueContentStatusAvailable);\n+\n+// Removes the once per day throttle from news stand notifications\n+-(void)enableDevMode:(id)args\n+{\n+ [[NSUserDefaults standardUserDefaults] setBool:YES forKey:@\"NKDontThrottleNewsstandContentNotifications\"];\n+ NSLog(@\"[INFO] Dev mode enabled\");\n+}\n+\n+-(TiNewsstandIssueProxy*)addIssue:(id)args\n+{\n+ ENSURE_SINGLE_ARG(args, NSDictionary);\n+ \n+ NSString *name = [args objectForKey:@\"name\"];\n+ NSDate *date = [args objectForKey:@\"date\"];\n+ \n+ ENSURE_TYPE(name, NSString);\n+ ENSURE_TYPE(date, NSDate);\n+ \n+ // An exception is thrown if the issue already exists, and the rest of the js function\n+ // is not executed if we let it fail naturally\n+ if ([[NKLibrary sharedLibrary] issueWithName:name]) {\n+ NSLog(@\"[ERROR] there is already an issue for this name -> '%@'\",name);\n+ return nil;\n+ }\n+ \n+ NKIssue *nkIssue = [[NKLibrary sharedLibrary] addIssueWithName:name date:date];\n+ // nkIssue could be nil if the instance couldn’t be created\n+ if (nkIssue == nil) {\n+ return nil;\n+ }\n+ \n+ return [[[TiNewsstandIssueProxy alloc] initWithIssue:nkIssue pageContext:[self executionContext] delegate:self] autorelease];\n+}\n+\n+-(void)removeIssue:(id)args\n+{\n+ ENSURE_SINGLE_ARG(args, TiNewsstandIssueProxy);\n+ [args removeIssueFromLibrary];\n+}\n+\n+-(TiNewsstandIssueProxy*)getIssue:(id)args\n+{\n+ ENSURE_SINGLE_ARG(args, NSDictionary);\n+ \n+ NSString *name = [args objectForKey:@\"name\"];\n+ \n+ ENSURE_STRING(name);\n+ \n+ NKIssue *nkIssue = [[NKLibrary sharedLibrary] issueWithName:name];\n+ // nkIssue my be nil if the issue couldn't be retrieved\n+ if (nkIssue == nil) {\n+ NSLog(@\"[ERROR] Issue named '%@' does not exist in library\",name);\n+ return nil;\n+ }\n+ \n+ return [[[TiNewsstandIssueProxy alloc] initWithIssue:nkIssue pageContext:[self executionContext] delegate:self] autorelease];\n+}\n+\n+// Set the username and password that will be used to authenticate if downloadAsset requires basic auth\n+-(void)setBasicAuthentication:(id)args\n+{\n+ ENSURE_SINGLE_ARG(args, NSDictionary);\n+ \n+ NSString *user;\n+ NSString *pass;\n+ \n+ ENSURE_ARG_FOR_KEY(user, args, @\"username\", NSString);\n+ ENSURE_ARG_FOR_KEY(pass, args, @\"password\", NSString);\n+ \n+ self.username = user;\n+ self.password = pass;\n+}\n+\n+#pragma mark Properties\n+\n+-(NSArray*)issues\n+{\n+ NSArray *issues = [[NKLibrary sharedLibrary] issues];\n+ NSMutableArray *result = [NSMutableArray arrayWithCapacity:[issues count]];\n+ [issues enumerateObjectsUsingBlock:^(id obj, NSUInteger idx, BOOL *stop){\n+ [result addObject:[[[TiNewsstandIssueProxy alloc] initWithIssue:obj pageContext:[self executionContext] delegate:self] autorelease]];\n+ }];\n+ \n+ return result;\n+}\n+\n+-(void)setCurrentlyReadingIssue:(id)args\n+{\n+ ENSURE_SINGLE_ARG(args, TiNewsstandIssueProxy);\n+ [args setCurrentlyReading];\n+}\n+\n+-(TiNewsstandIssueProxy*)currentlyReadingIssue\n+{\n+ NKIssue *nkIssue = [[NKLibrary sharedLibrary] currentlyReadingIssue];\n+ return nkIssue ? [[[TiNewsstandIssueProxy alloc] initWithIssue:nkIssue pageContext:[self executionContext] delegate:self] autorelease] : nil;\n+}\n+\n+-(void)setIconImage:(id)args\n+{\n+ ENSURE_SINGLE_ARG(args, TiFile);\n+ \n+ NSString *path = [args path];\n+ \n+ NSLog(@\"[INFO] Updating app icon with image at: %@\",path);\n+ \n+ UIImage *newcover = [UIImage imageWithContentsOfFile:path];\n+ [[UIApplication sharedApplication] setNewsstandIconImage:newcover];\n+}\n+\n+// Will display the \"new\" badge if number is greater than 0\n+-(void)setApplicationIconBadgeNumber:(id)args\n+{\n+ ENSURE_SINGLE_ARG(args, NSNumber);\n+\n+ NSLog(@\"[INFO] Setting app badge number to %@\",args);\n+ \n+ [[UIApplication sharedApplication] setApplicationIconBadgeNumber:[args integerValue]];\n+}\n+\n+-(NSNumber*)applicationIconBadgeNumber\n+{\n+ return [NSNumber numberWithInteger:[[UIApplication sharedApplication]applicationIconBadgeNumber]];\n+}\n+\n+#pragma mark - NSURLConnectionDownloadDelegate\n+\n+-(void)connection:(NSURLConnection *)connection didFailWithError:(NSError *)error\n+{\n+ [self fireErrorEvent:connection error:error];\n+}\n+\n+- (void)connection:(NSURLConnection *)connection didReceiveAuthenticationChallenge:(NSURLAuthenticationChallenge *)challenge\n+{\n+ if ([challenge previousFailureCount] != 0) {\n+ [[challenge sender] cancelAuthenticationChallenge:challenge];\n+ return;\n+ }\n+ \n+ NSURLCredential *newCredential = [NSURLCredential credentialWithUser:self.username\n+ password:self.password\n+ persistence:NSURLCredentialPersistenceNone];\n+ \n+ [[challenge sender] useCredential:newCredential forAuthenticationChallenge:challenge];\n+ NSLog(@\"[INFO] Responded to authentication challenge\");\n+}\n+\n+-(void)connection:(NSURLConnection *)connection didWriteData:(long long)bytesWritten totalBytesWritten:(long long)totalBytesWritten expectedTotalBytes:(long long)expectedTotalBytes\n+{\n+ [self fireProgressEvent:connection totalBytesWritten:totalBytesWritten expectedTotalBytes:expectedTotalBytes];\n+}\n+\n+-(void)connectionDidResumeDownloading:(NSURLConnection *)connection totalBytesWritten:(long long)totalBytesWritten expectedTotalBytes:(long long)expectedTotalBytes\n+{\n+ [self fireProgressEvent:connection totalBytesWritten:totalBytesWritten expectedTotalBytes:expectedTotalBytes];\n+}\n+\n+-(void)connectionDidFinishDownloading:(NSURLConnection *)connection destinationURL:(NSURL *)destinationURL\n+{\n+ NKAssetDownload *dnl = connection.newsstandAssetDownload;\n+ NKIssue *nkIssue = dnl.issue;\n+ \n+ NSString *tempFileName = [[dnl userInfo] objectForKey:@\"filename\"]; // use filename provided in userInfo if it exists\n+ NSString *fileName = (tempFileName) ? tempFileName : [[dnl.URLRequest URL] lastPathComponent];\n+ NSString *filePath = [[nkIssue.contentURL path] stringByAppendingPathComponent:fileName];\n+ NSError *error = nil;\n+ \n+ NSLog(@\"[INFO] File is being copied to %@\",filePath);\n+ if ([[NSFileManager defaultManager] fileExistsAtPath:filePath]) { \n+ NSLog(@\"[ERROR] Overwriting file named '%@'. See module documentation to learn how to specify a downloaded file's filename.\",fileName);\n+ if ([[NSFileManager defaultManager] removeItemAtPath:filePath error:&error] == NO) {\n+ [self fireErrorEvent:connection error:error];\n+ return;\n+ }\n+ }\n+ \n+ if ([[NSFileManager defaultManager] moveItemAtPath:[destinationURL path] toPath:filePath error:&error] == NO) {\n+ [self fireErrorEvent:connection error:error];\n+ return;\n+ }\n+ \n+ [self fireAssetCompleteEvent:connection filePath:filePath];\n+}\n+\n+#pragma mark Listener Notifications\n+\n+-(void)_listenerAdded:(NSString *)type count:(int)count\n+{\n+ if (count == 1 && [type isEqualToString:@\"issuecomplete\"]) {\n+ [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(issueDownloadComplete:) name:NKIssueDownloadCompletedNotification object:nil];\n+ }\n+}\n+\n+-(void)_listenerRemoved:(NSString *)type count:(int)count\n+{\n+ if (count == 0 && [type isEqualToString:@\"issuecomplete\"]) {\n+ [[NSNotificationCenter defaultCenter] removeObserver:self];\n+ }\n+}\n+\n+#pragma mark Observers\n+\n+-(void)issueDownloadComplete:(NSNotification *)note\n+{\n+ [self fireIssueCompleteEvent:note];\n+}\n+\n+#pragma mark Fire Events\n+\n+-(void)fireErrorEvent:(NSURLConnection *)connection error:(NSError *)error\n+{\n+ NKAssetDownload *dnl = connection.newsstandAssetDownload;\n+ NSDictionary *userInfo = [[dnl userInfo] objectForKey:@\"userInfo\"];\n+ userInfo = userInfo ? userInfo : [NSDictionary dictionary]; // userInfo can not be nil when added to dictionary\n+ \n+ if ([self _hasListeners:@\"error\"]) {\n+ NSDictionary *event = [NSDictionary dictionaryWithObjectsAndKeys:\n+ [[dnl issue] name], @\"name\",\n+ userInfo, @\"userInfo\",\n+ [error localizedDescription], @\"description\",\n+ [NSNumber numberWithInteger:[error code]], @\"code\",\n+ nil\n+ ];\n+ [self fireEvent:@\"error\" withObject:event];\n+ }\n+}\n+\n+-(void)fireProgressEvent:(NSURLConnection *)connection totalBytesWritten:(long long)totalBytesWritten expectedTotalBytes:(long long)expectedTotalBytes\n+{\n+ if ([self _hasListeners:@\"progress\"]) {\n+ NKAssetDownload *dnl = connection.newsstandAssetDownload;\n+ NSDictionary *userInfo = [[dnl userInfo] objectForKey:@\"userInfo\"];\n+ userInfo = userInfo ? userInfo : [NSDictionary dictionary]; // userInfo can not be nil when added to dictionary\n+ \n+ NSDictionary *event = [NSDictionary dictionaryWithObjectsAndKeys:\n+ [NSNumber numberWithFloat: totalBytesWritten], @\"bytesWritten\",\n+ [NSNumber numberWithFloat: expectedTotalBytes], @\"totalBytes\",\n+ [[dnl issue] name], @\"name\",\n+ userInfo, @\"userInfo\",\n+ nil\n+ ];\n+ \n+ [self fireEvent:@\"progress\" withObject:event];\n+ }\n+}\n+\n+-(void)fireAssetCompleteEvent:(NSURLConnection *)connection filePath:(NSString *)filePath\n+{\n+ NKAssetDownload *dnl = connection.newsstandAssetDownload;\n+ NSDictionary *userInfo = [[dnl userInfo] objectForKey:@\"userInfo\"];\n+ userInfo = userInfo ? userInfo : [NSDictionary dictionary]; // userInfo can not be nil when added to dictionary\n+ \n+ if ([self _hasListeners:@\"assetcomplete\"]) {\n+ NSDictionary *event = [NSDictionary dictionaryWithObjectsAndKeys:\n+ [[dnl issue] name], @\"name\",\n+ userInfo, @\"userInfo\",\n+ filePath, @\"filePath\",\n+ nil\n+ ];\n+ [self fireEvent:@\"assetcomplete\" withObject:event];","path":"ios/Classes/TiNewsstandModule.m","position":338,"original_position":338,"commit_id":"67dfa1e9b5ea97c9da59155224f57d61ba7dc9c3","original_commit_id":"67dfa1e9b5ea97c9da59155224f57d61ba7dc9c3","user":{"login":"JeffEnglish","id":143293,"avatar_url":"https://secure.gravatar.com/avatar/dc7128cfcf6623e988d7e3a6738be377?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"dc7128cfcf6623e988d7e3a6738be377","url":"https://api.github.com/users/JeffEnglish","html_url":"https://github.com/JeffEnglish","followers_url":"https://api.github.com/users/JeffEnglish/followers","following_url":"https://api.github.com/users/JeffEnglish/following","gists_url":"https://api.github.com/users/JeffEnglish/gists{/gist_id}","starred_url":"https://api.github.com/users/JeffEnglish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JeffEnglish/subscriptions","organizations_url":"https://api.github.com/users/JeffEnglish/orgs","repos_url":"https://api.github.com/users/JeffEnglish/repos","events_url":"https://api.github.com/users/JeffEnglish/events{/privacy}","received_events_url":"https://api.github.com/users/JeffEnglish/received_events","type":"User"},"created_at":"2013-03-13T13:56:42Z","updated_at":"2013-03-13T13:56:42Z","html_url":"https://github.com/appcelerator-modules/ti.newsstand/pull/1#discussion_r3353865","pull_request_url":"https://api.github.com/repos/appcelerator-modules/ti.newsstand/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/appcelerator-modules/ti.newsstand/pulls/comments/3353865"},"html":{"href":"https://github.com/appcelerator-modules/ti.newsstand/pull/1#discussion_r3353865"},"pull_request":{"href":"https://api.github.com/repos/appcelerator-modules/ti.newsstand/pulls/1"}}}} | {
"id": 8510358,
"name": "ti.newsstand",
"url": "https://github.com/appcelerator-modules/ti.newsstand"
} | {
"id": null,
"login": "JeffEnglish",
"gravatar_id": "dc7128cfcf6623e988d7e3a6738be377",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "appcelerator-modules",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-13T13:56:42 | null | {"repository":{"description":"","watchers":1,"stargazers":1,"forks":2,"fork":false,"size":112,"owner":"appcelerator-modules","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"created_at":"2013-03-01T13:09:58-08:00","pushed_at":"2013-03-07T17:01:56-08:00","master_branch":"master","organization":"appcelerator-modules"},"actor_attributes":{"type":"User","name":"Jeff English","company":"Appcelerator","blog":"www.appcelerator.com","location":"Plano, TX","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/appcelerator-modules/ti.newsstand/pull/1#discussion_r3353865"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/stxnext-kindergarten/abartosinski/pulls/comments/8434583","id":8434583,"diff_hunk":"@@ -56,14 +57,33 @@ def presence_weekday_view(user_id):\n \"\"\"\n Returns total presence time of given user grouped by weekday.\n \"\"\"\n- data = get_data()\n- if user_id not in data:\n- log.debug('User %s not found!', user_id)\n+ data = get_user_data(user_id)\n+\n+ if data is None:\n return []\n \n- weekdays = group_by_weekday(data[user_id])\n- result = [(calendar.day_abbr[weekday], sum(intervals))\n- for weekday, intervals in weekdays.items()]\n+ weekdays = group_by_weekday(data)\n+ result = [(calendar.day_abbr[weekday], sum(presences['intervals']))","path":"src/presence_analyzer/views.py","position":47,"original_position":47,"commit_id":"f824b810d551ab0d76e2c66e5073545619717bdd","original_commit_id":"f824b810d551ab0d76e2c66e5073545619717bdd","user":{"login":"krotkiewicz","id":2101767,"avatar_url":"https://gravatar.com/avatar/293b5ea77d2b1367c8de54fd652979c0?d=https%3A%2F%2Fidenticons.github.com%2Fe11cc80588684b233b45575602012e37.png&r=x","gravatar_id":"293b5ea77d2b1367c8de54fd652979c0","url":"https://api.github.com/users/krotkiewicz","html_url":"https://github.com/krotkiewicz","followers_url":"https://api.github.com/users/krotkiewicz/followers","following_url":"https://api.github.com/users/krotkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/krotkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/krotkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krotkiewicz/subscriptions","organizations_url":"https://api.github.com/users/krotkiewicz/orgs","repos_url":"https://api.github.com/users/krotkiewicz/repos","events_url":"https://api.github.com/users/krotkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/krotkiewicz/received_events","type":"User","site_admin":false},"body":"f","created_at":"2013-12-18T12:44:34Z","updated_at":"2013-12-18T12:44:34Z","html_url":"https://github.com/stxnext-kindergarten/abartosinski/pull/4#discussion_r8434583","pull_request_url":"https://api.github.com/repos/stxnext-kindergarten/abartosinski/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/stxnext-kindergarten/abartosinski/pulls/comments/8434583"},"html":{"href":"https://github.com/stxnext-kindergarten/abartosinski/pull/4#discussion_r8434583"},"pull_request":{"href":"https://api.github.com/repos/stxnext-kindergarten/abartosinski/pulls/4"}}}} | {
"id": 15226955,
"name": "abartosinski",
"url": "https://github.com/stxnext-kindergarten/abartosinski"
} | {
"id": null,
"login": "krotkiewicz",
"gravatar_id": "293b5ea77d2b1367c8de54fd652979c0",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "stxnext-kindergarten",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-18T12:44:34 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":1,"fork":false,"size":252,"owner":"stxnext-kindergarten","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-12-16T05:50:04-08:00","pushed_at":"2013-12-18T02:22:02-08:00","master_branch":"master","organization":"stxnext-kindergarten"},"actor_attributes":{"type":"User","name":"Konrad Rotkiewicz","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/stxnext-kindergarten/abartosinski/pull/4#discussion_r8434583"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/6074558","id":6074558,"body":"As I mentioned before, remove these prototype functions since we would remove them soon anyway. See #1082 ","diff_hunk":"@@ -0,0 +1,120 @@\n+/*global define*/\n+define([\n+ './defaultValue',\n+ './defined',\n+ './DeveloperError'\n+ ], function(\n+ defaultValue,\n+ defined,\n+ DeveloperError) {\n+ \"use strict\";\n+\n+ /**\n+ * Represents a scalar value's lower and upper bound at a near distance and far distance in eye space.\n+ * @alias NearFarScalar\n+ * @constructor\n+ *\n+ * @param {Number} [near=0.0] The lower bound of the camera range.\n+ * @param {Number} [nearValue=0.0] The value at the lower bound of the camera range.\n+ * @param {Number} [far=0.0] The upper bound of the camera range.\n+ * @param {Number} [farValue=0.0] The value at the upper bound of the camera range.\n+ */\n+ var NearFarScalar = function(near, nearValue, far, farValue) {\n+ /**\n+ * The lower bound of the camera range.\n+ * @type {Number}\n+ * @default 0.0\n+ */\n+ this.near = defaultValue(near, 0.0);\n+ /**\n+ * The value at the lower bound of the camera range.\n+ * @type {Number}\n+ * @default 0.0\n+ */\n+ this.nearValue = defaultValue(nearValue, 0.0);\n+ /**\n+ * The upper bound of the camera range.\n+ * @type {Number}\n+ * @default 1.0\n+ */\n+ this.far = defaultValue(far, 1.0);\n+ /**\n+ * The value at the upper bound of the camera range.\n+ * @type {Number}\n+ * @default 1.0\n+ */\n+ this.farValue = defaultValue(farValue, 0.0);\n+ };\n+\n+ /**\n+ * Duplicates a NearFarScalar instance.\n+ * @memberof NearFarScalar\n+ *\n+ * @param {NearFarScalar} nearFarScalar The NearFarScalar to duplicate.\n+ * @param {NearFarScalar} [result] The object onto which to store the result.\n+ * @return {NearFarScalar} The modified result parameter or a new NearFarScalar instance if one was not provided. (Returns undefined if nearFarScalar is undefined)\n+ */\n+ NearFarScalar.clone = function(nearFarScalar, result) {\n+ if (!defined(nearFarScalar)) {\n+ return undefined;\n+ }\n+\n+ if (!defined(result)) {\n+ return new NearFarScalar(nearFarScalar.near,\n+ nearFarScalar.nearValue,\n+ nearFarScalar.far,\n+ nearFarScalar.farValue);\n+ }\n+\n+ result.near = nearFarScalar.near;\n+ result.nearValue = nearFarScalar.nearValue;\n+ result.far = nearFarScalar.far;\n+ result.farValue = nearFarScalar.farValue;\n+ return result;\n+ };\n+\n+ /**\n+ * Compares the provided NearFarScalar and returns <code>true</code> if they are equal,\n+ * <code>false</code> otherwise.\n+ * @memberof NearFarScalar\n+ *\n+ * @param {NearFarScalar} [left] The first Extent.\n+ * @param {NearFarScalar} [right] The second Extent.\n+ *\n+ * @return {Boolean} <code>true</code> if left and right are equal; otherwise <code>false</code>.\n+ */\n+ NearFarScalar.equals = function(left, right) {\n+ return (left === right) ||\n+ ((defined(left)) &&\n+ (defined(right)) &&\n+ (left.near === right.near) &&\n+ (left.nearValue === right.nearValue) &&\n+ (left.far === right.far) &&\n+ (left.farValue === right.farValue));\n+ };\n+\n+ /**\n+ * Duplicates this NearFarScalar instance.\n+ * @memberof NearFarScalar\n+ *\n+ * @param {NearFarScalar} [result] The object onto which to store the result.\n+ * @return {NearFarScalar} The modified result parameter or a new NearFarScalar instance if one was not provided.\n+ */\n+ NearFarScalar.prototype.clone = function(result) {","path":"Source/Core/NearFarScalar.js","position":103,"original_position":103,"commit_id":"4e34924f4115a36ae9c955a1d270d30578b9f195","original_commit_id":"4e34924f4115a36ae9c955a1d270d30578b9f195","user":{"login":"pjcozzi","id":782098,"avatar_url":"https://0.gravatar.com/avatar/744fc861be12525cb0e08418aeb372d2?d=https%3A%2F%2Fidenticons.github.com%2F0d206dad3952396d4f98cbb43db4a272.png","gravatar_id":"744fc861be12525cb0e08418aeb372d2","url":"https://api.github.com/users/pjcozzi","html_url":"https://github.com/pjcozzi","followers_url":"https://api.github.com/users/pjcozzi/followers","following_url":"https://api.github.com/users/pjcozzi/following{/other_user}","gists_url":"https://api.github.com/users/pjcozzi/gists{/gist_id}","starred_url":"https://api.github.com/users/pjcozzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjcozzi/subscriptions","organizations_url":"https://api.github.com/users/pjcozzi/orgs","repos_url":"https://api.github.com/users/pjcozzi/repos","events_url":"https://api.github.com/users/pjcozzi/events{/privacy}","received_events_url":"https://api.github.com/users/pjcozzi/received_events","type":"User"},"created_at":"2013-08-29T22:01:20Z","updated_at":"2013-08-29T22:01:20Z","html_url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/1074#discussion_r6074558","pull_request_url":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/1074","_links":{"self":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/comments/6074558"},"html":{"href":"https://github.com/AnalyticalGraphicsInc/cesium/pull/1074#discussion_r6074558"},"pull_request":{"href":"https://api.github.com/repos/AnalyticalGraphicsInc/cesium/pulls/1074"}}}} | {
"id": 3606738,
"name": "cesium",
"url": "https://github.com/AnalyticalGraphicsInc/cesium"
} | {
"id": null,
"login": "pjcozzi",
"gravatar_id": "744fc861be12525cb0e08418aeb372d2",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "AnalyticalGraphicsInc",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-29T22:01:20 | null | {"repository":{"description":"WebGL virtual globe and map engine","homepage":"http://cesium.agi.com/","watchers":260,"stargazers":260,"forks":151,"fork":false,"size":303655,"owner":"AnalyticalGraphicsInc","private":false,"open_issues":137,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-03-02T14:27:14-08:00","pushed_at":"2013-08-29T14:30:00-07:00","master_branch":"master","organization":"AnalyticalGraphicsInc"},"actor_attributes":{"type":"User","name":"Patrick Cozzi","blog":"http://www.seas.upenn.edu/~pcozzi/","email":"[email protected]"},"url":"https://github.com/AnalyticalGraphicsInc/cesium/pull/1074#discussion_r6074558"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/8011626","id":8011626,"diff_hunk":"@@ -7885,7 +7891,14 @@ Expression *DotVarExp::semantic(Scope *sc)\n \n Dsymbol *vparent = var->toParent();\n AggregateDeclaration *ad = vparent ? vparent->isAggregateDeclaration() : NULL;\n- e1 = getRightThis(loc, sc, ad, e1, var);\n+ if (Expression *e1x = getRightThis(loc, sc, ad, e1, var, 1))\n+ e1 = e1x;\n+ else\n+ {\n+ Expression *e = new VarExp(loc, var);","path":"src/expression.c","position":null,"original_position":64,"commit_id":"c2ba89dc203c34740fbc21d8a116994046a7bbf4","original_commit_id":"869da11e3f3f03a12b9e3f590f632d3a84bd8090","user":{"login":"9rnsr","id":254394,"avatar_url":"https://2.gravatar.com/avatar/58e2a2560f187a0d9542fae68035ffcf?d=https%3A%2F%2Fidenticons.github.com%2F7646c9beab10bbae207c543e590d73eb.png&r=x","gravatar_id":"58e2a2560f187a0d9542fae68035ffcf","url":"https://api.github.com/users/9rnsr","html_url":"https://github.com/9rnsr","followers_url":"https://api.github.com/users/9rnsr/followers","following_url":"https://api.github.com/users/9rnsr/following{/other_user}","gists_url":"https://api.github.com/users/9rnsr/gists{/gist_id}","starred_url":"https://api.github.com/users/9rnsr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9rnsr/subscriptions","organizations_url":"https://api.github.com/users/9rnsr/orgs","repos_url":"https://api.github.com/users/9rnsr/repos","events_url":"https://api.github.com/users/9rnsr/events{/privacy}","received_events_url":"https://api.github.com/users/9rnsr/received_events","type":"User","site_admin":false},"body":"Sorry I forgot to push the updated commit. Pushed.","created_at":"2013-11-30T18:27:24Z","updated_at":"2013-11-30T18:27:24Z","html_url":"https://github.com/D-Programming-Language/dmd/pull/2897#discussion_r8011626","pull_request_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/2897","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/8011626"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/2897#discussion_r8011626"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/2897"}}}} | {
"id": 1257070,
"name": "dmd",
"url": "https://github.com/D-Programming-Language/dmd"
} | {
"id": null,
"login": "9rnsr",
"gravatar_id": "58e2a2560f187a0d9542fae68035ffcf",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "D-Programming-Language",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-30T18:27:24 | null | {"repository":{"description":"dmd D Programming Language compiler","homepage":"dlang.org","watchers":583,"stargazers":583,"forks":159,"fork":false,"size":36816,"owner":"D-Programming-Language","private":false,"open_issues":108,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"C","created_at":"2011-01-14T22:53:53-08:00","pushed_at":"2013-11-30T08:38:08-08:00","integrate_branch":"master","master_branch":"master","organization":"D-Programming-Language"},"actor_attributes":{"type":"User","name":"Hara Kenji","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/D-Programming-Language/dmd/pull/2897#discussion_r8011626"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/7875709","id":7875709,"diff_hunk":"@@ -1492,6 +1492,15 @@ void test74()\n \n /***************************************************/\n \n+void test9212()\n+{\n+ int[int] aa;\n+ foreach (const key, val; aa) {}\n+ foreach (size_t key, val; aa) {}","path":"test/runnable/xtest46.d","position":8,"original_position":8,"commit_id":"c8219a198c2a9a31042d05cbf35b57f631ac3ecf","original_commit_id":"c8219a198c2a9a31042d05cbf35b57f631ac3ecf","user":{"login":"9rnsr","id":254394,"avatar_url":"https://2.gravatar.com/avatar/58e2a2560f187a0d9542fae68035ffcf?d=https%3A%2F%2Fidenticons.github.com%2F7646c9beab10bbae207c543e590d73eb.png&r=x","gravatar_id":"58e2a2560f187a0d9542fae68035ffcf","url":"https://api.github.com/users/9rnsr","html_url":"https://github.com/9rnsr","followers_url":"https://api.github.com/users/9rnsr/followers","following_url":"https://api.github.com/users/9rnsr/following{/other_user}","gists_url":"https://api.github.com/users/9rnsr/gists{/gist_id}","starred_url":"https://api.github.com/users/9rnsr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/9rnsr/subscriptions","organizations_url":"https://api.github.com/users/9rnsr/orgs","repos_url":"https://api.github.com/users/9rnsr/repos","events_url":"https://api.github.com/users/9rnsr/events{/privacy}","received_events_url":"https://api.github.com/users/9rnsr/received_events","type":"User","site_admin":false},"body":"Why this is accepted? Passing size_t* to `_aaApply2` will cause memory corruption.","created_at":"2013-11-23T14:32:24Z","updated_at":"2013-11-23T14:32:24Z","html_url":"https://github.com/D-Programming-Language/dmd/pull/2864#discussion_r7875709","pull_request_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/2864","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/7875709"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/2864#discussion_r7875709"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/2864"}}}} | {
"id": 1257070,
"name": "dmd",
"url": "https://github.com/D-Programming-Language/dmd"
} | {
"id": null,
"login": "9rnsr",
"gravatar_id": "58e2a2560f187a0d9542fae68035ffcf",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "D-Programming-Language",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-23T14:32:24 | null | {"repository":{"description":"dmd D Programming Language compiler","homepage":"dlang.org","watchers":577,"stargazers":577,"forks":161,"fork":false,"size":35867,"owner":"D-Programming-Language","private":false,"open_issues":104,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"C","created_at":"2011-01-14T22:53:53-08:00","pushed_at":"2013-11-23T05:03:32-08:00","integrate_branch":"master","master_branch":"master","organization":"D-Programming-Language"},"actor_attributes":{"type":"User","name":"Hara Kenji","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/D-Programming-Language/dmd/pull/2864#discussion_r7875709"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/5055618","id":5055618,"body":"> Even better... I get a nice forward reference error with it\r\n\r\nAww. Oh well, keep it a comment then.","diff_hunk":"@@ -1987,6 +1987,70 @@ public struct Regex(Char)\n +/\n @property bool empty() const nothrow { return ir is null; }\n \n+ /++\n+ A range of all the named captures in the regex.\n+ Example:","path":"std/regex.d","position":6,"original_position":6,"commit_id":"c76de6191f6ebd2efdfd9b9cdd682dc9f5c09f1e","original_commit_id":"c76de6191f6ebd2efdfd9b9cdd682dc9f5c09f1e","user":{"login":"AndrejMitrovic","id":360179,"avatar_url":"https://secure.gravatar.com/avatar/6b80b27e0030320efddd03358546176a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"6b80b27e0030320efddd03358546176a","url":"https://api.github.com/users/AndrejMitrovic","html_url":"https://github.com/AndrejMitrovic","followers_url":"https://api.github.com/users/AndrejMitrovic/followers","following_url":"https://api.github.com/users/AndrejMitrovic/following{/other_user}","gists_url":"https://api.github.com/users/AndrejMitrovic/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrejMitrovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrejMitrovic/subscriptions","organizations_url":"https://api.github.com/users/AndrejMitrovic/orgs","repos_url":"https://api.github.com/users/AndrejMitrovic/repos","events_url":"https://api.github.com/users/AndrejMitrovic/events{/privacy}","received_events_url":"https://api.github.com/users/AndrejMitrovic/received_events","type":"User"},"created_at":"2013-07-07T21:13:53Z","updated_at":"2013-07-07T21:13:53Z","html_url":"https://github.com/D-Programming-Language/phobos/pull/1385#discussion_r5055618","pull_request_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/1385","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/5055618"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/1385#discussion_r5055618"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/1385"}}}} | {
"id": 1257084,
"name": "phobos",
"url": "https://github.com/D-Programming-Language/phobos"
} | {
"id": null,
"login": "AndrejMitrovic",
"gravatar_id": "6b80b27e0030320efddd03358546176a",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "D-Programming-Language",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-07T21:13:53 | null | {"repository":{"description":"The standard library of the D programming language","homepage":"dlang.org/phobos","watchers":354,"stargazers":354,"forks":203,"fork":false,"size":2292,"owner":"D-Programming-Language","private":false,"open_issues":87,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"D","created_at":"2011-01-14T23:00:06-08:00","pushed_at":"2013-07-06T02:24:40-07:00","master_branch":"master","organization":"D-Programming-Language"},"actor_attributes":{"type":"User","name":"Andrej Mitrovic","location":"Pula, Croatia","email":"5794f310a19b9f56c0f38785af244b499a6b2f40"},"url":"https://github.com/D-Programming-Language/phobos/pull/1385#discussion_r5055618"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/4230516","id":4230516,"body":"I agree with yebblies. Now let's get this fixed before 2.063. :)","diff_hunk":"@@ -1095,6 +1096,40 @@ void PragmaDeclaration::semantic(Scope *sc)\n \n if (se->sz != 1)\n error(\"mangled name characters can only be of type char\");\n+\n+ for (size_t i = 0; i < se->len; )\n+ {\n+ unsigned char *p = (unsigned char *)se->string;\n+ dchar_t c = p[i];\n+ if (c < 0x80)\n+ {\n+ if (c >= 'A' && c <= 'Z' ||\n+ c >= 'a' && c <= 'z' ||\n+ c >= '0' && c <= '9' ||\n+ c != 0 && strchr(\"$%().:?@[]_\", c))\n+ {\n+ ++i;\n+ continue;\n+ }\n+ else\n+ {\n+ error(\"char 0x%02x not allowed in identifier\", c);","path":"src/attrib.c","position":null,"original_position":29,"commit_id":"e9629f8fdb89d4000ff5c98c9d015254a93f2063","original_commit_id":"cf6a234a9abd53f983650e8183e231930337af61","user":{"login":"ibuclaw","id":397929,"avatar_url":"https://secure.gravatar.com/avatar/907f83bbb9b80bd8cf5e2f1a07c42e5e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"907f83bbb9b80bd8cf5e2f1a07c42e5e","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User"},"created_at":"2013-05-15T08:36:41Z","updated_at":"2013-05-15T08:36:41Z","html_url":"https://github.com/D-Programming-Language/dmd/pull/2030#discussion_r4230516","pull_request_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/2030","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/4230516"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/2030#discussion_r4230516"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/2030"}}}} | {
"id": 1257070,
"name": "dmd",
"url": "https://github.com/D-Programming-Language/dmd"
} | {
"id": null,
"login": "ibuclaw",
"gravatar_id": "907f83bbb9b80bd8cf5e2f1a07c42e5e",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "D-Programming-Language",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-15T08:36:41 | null | {"repository":{"description":"dmd D Programming Language compiler","homepage":"d-programming-language.org","watchers":458,"stargazers":458,"forks":144,"fork":false,"size":105553,"owner":"D-Programming-Language","private":false,"open_issues":2,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"C","created_at":"2011-01-14T22:53:53-08:00","pushed_at":"2013-05-15T01:09:53-07:00","integrate_branch":"master","master_branch":"master","organization":"D-Programming-Language"},"actor_attributes":{"type":"User","name":"Iain Buclaw","location":"UK","email":"[email protected]"},"url":"https://github.com/D-Programming-Language/dmd/pull/2030#discussion_r4230516"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/8337921","id":8337921,"diff_hunk":"@@ -2497,6 +2497,10 @@ Expression *Expression::checkToBoolean(Scope *sc)\n error(\"expression %s of type %s does not have a boolean value\", toChars(), t->toChars());\n return new ErrorExp();\n }\n+\n+ if (tb->ty == Tarray)\n+ warning(\"converting dynamic arrays to boolean is deprecated, instead use array.ptr\");","path":"src/expression.c","position":6,"original_position":6,"commit_id":"03048ac2b1a87f680eb2cb58d76c60a1c0eb6560","original_commit_id":"03048ac2b1a87f680eb2cb58d76c60a1c0eb6560","user":{"login":"dawgfoto","id":288976,"avatar_url":"https://gravatar.com/avatar/d919a6f84bb1b92ff78e2da0810a844d?d=https%3A%2F%2Fidenticons.github.com%2F70af8121c515935ba0c2cde9ede20fa9.png&r=x","gravatar_id":"d919a6f84bb1b92ff78e2da0810a844d","url":"https://api.github.com/users/dawgfoto","html_url":"https://github.com/dawgfoto","followers_url":"https://api.github.com/users/dawgfoto/followers","following_url":"https://api.github.com/users/dawgfoto/following{/other_user}","gists_url":"https://api.github.com/users/dawgfoto/gists{/gist_id}","starred_url":"https://api.github.com/users/dawgfoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawgfoto/subscriptions","organizations_url":"https://api.github.com/users/dawgfoto/orgs","repos_url":"https://api.github.com/users/dawgfoto/repos","events_url":"https://api.github.com/users/dawgfoto/events{/privacy}","received_events_url":"https://api.github.com/users/dawgfoto/received_events","type":"User","site_admin":false},"body":"How about `instead use .length or .ptr`.","created_at":"2013-12-13T16:57:51Z","updated_at":"2013-12-13T16:57:51Z","html_url":"https://github.com/D-Programming-Language/dmd/pull/2885#discussion_r8337921","pull_request_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/2885","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/8337921"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/2885#discussion_r8337921"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/2885"}}}} | {
"id": 1257070,
"name": "dmd",
"url": "https://github.com/D-Programming-Language/dmd"
} | {
"id": null,
"login": "dawgfoto",
"gravatar_id": "d919a6f84bb1b92ff78e2da0810a844d",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "D-Programming-Language",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-13T16:57:51 | null | {"repository":{"description":"dmd D Programming Language compiler","homepage":"dlang.org","watchers":585,"stargazers":585,"forks":166,"fork":false,"size":38447,"owner":"D-Programming-Language","private":false,"open_issues":104,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"C","created_at":"2011-01-14T22:53:53-08:00","pushed_at":"2013-12-13T06:18:50-08:00","integrate_branch":"master","master_branch":"master","organization":"D-Programming-Language"},"actor_attributes":{"type":"User","name":"Martin Nowak","location":"Berlin, Germany","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/D-Programming-Language/dmd/pull/2885#discussion_r8337921"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/8517838","id":8517838,"diff_hunk":"@@ -15,8 +15,8 @@\n module std.complex;\n \n \n-import std.format, std.math, std.numeric, std.traits;\n-\n+import std.exception, std.format, std.math, std.numeric, std.traits;","path":"std/complex.d","position":6,"original_position":6,"commit_id":"bf28d0f52f92aedd56b0e9f083231b47a99278c5","original_commit_id":"bf28d0f52f92aedd56b0e9f083231b47a99278c5","user":{"login":"andralex","id":566679,"avatar_url":"https://gravatar.com/avatar/84f8321680c16c6dcf8203a54be03930?d=https%3A%2F%2Fidenticons.github.com%2F5c2df94207c5c4ee1432ee611b25d20b.png&r=x","gravatar_id":"84f8321680c16c6dcf8203a54be03930","url":"https://api.github.com/users/andralex","html_url":"https://github.com/andralex","followers_url":"https://api.github.com/users/andralex/followers","following_url":"https://api.github.com/users/andralex/following{/other_user}","gists_url":"https://api.github.com/users/andralex/gists{/gist_id}","starred_url":"https://api.github.com/users/andralex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andralex/subscriptions","organizations_url":"https://api.github.com/users/andralex/orgs","repos_url":"https://api.github.com/users/andralex/repos","events_url":"https://api.github.com/users/andralex/events{/privacy}","received_events_url":"https://api.github.com/users/andralex/received_events","type":"User","site_admin":false},"body":"From my painful experience it's much easier to do this in the beginning rather than later...","created_at":"2013-12-21T17:13:30Z","updated_at":"2013-12-21T17:13:30Z","html_url":"https://github.com/D-Programming-Language/phobos/pull/1797#discussion_r8517838","pull_request_url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/1797","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/8517838"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/1797#discussion_r8517838"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/1797"}}}} | {
"id": 1257084,
"name": "phobos",
"url": "https://github.com/D-Programming-Language/phobos"
} | {
"id": null,
"login": "andralex",
"gravatar_id": "84f8321680c16c6dcf8203a54be03930",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "D-Programming-Language",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-21T17:13:30 | null | {"repository":{"description":"The standard library of the D programming language","homepage":"dlang.org/phobos","watchers":413,"stargazers":413,"forks":249,"fork":false,"size":32539,"owner":"D-Programming-Language","private":false,"open_issues":80,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"D","created_at":"2011-01-14T23:00:06-08:00","pushed_at":"2013-12-21T08:16:48-08:00","master_branch":"master","organization":"D-Programming-Language"},"actor_attributes":{"type":"User","name":"Andrei Alexandrescu","company":"Facebook","blog":"http://erdani.com","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/D-Programming-Language/phobos/pull/1797#discussion_r8517838"} |
PullRequestReviewCommentEvent | true | {"comment":{"original_commit_id":"c37860f08b7c3c6f6cc59dd16f0c48e1e2e7e644","id":2729135,"original_position":99,"url":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/2729135","user":{"starred_url":"https://api.github.com/users/jmdavis/starred{/owner}{/repo}","received_events_url":"https://api.github.com/users/jmdavis/received_events","avatar_url":"https://secure.gravatar.com/avatar/797e06feb159ad441a5dd270c4ccf06e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","id":579956,"events_url":"https://api.github.com/users/jmdavis/events{/privacy}","url":"https://api.github.com/users/jmdavis","type":"User","following_url":"https://api.github.com/users/jmdavis/following","followers_url":"https://api.github.com/users/jmdavis/followers","login":"jmdavis","gravatar_id":"797e06feb159ad441a5dd270c4ccf06e","subscriptions_url":"https://api.github.com/users/jmdavis/subscriptions","gists_url":"https://api.github.com/users/jmdavis/gists{/gist_id}","repos_url":"https://api.github.com/users/jmdavis/repos","organizations_url":"https://api.github.com/users/jmdavis/orgs"},"path":"std/exception.d","body":"You should use `is` when checking for `null`.","commit_id":"c37860f08b7c3c6f6cc59dd16f0c48e1e2e7e644","created_at":"2013-01-22T17:44:47Z","updated_at":"2013-01-22T17:44:47Z","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/comments/2729135"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/phobos/pulls/1090"},"html":{"href":"https://github.com/D-Programming-Language/phobos/pull/1090#discussion_r2729135"}},"position":99}} | {
"id": 1257084,
"name": "phobos",
"url": "https://github.com/D-Programming-Language/phobos"
} | {
"id": null,
"login": "jmdavis",
"gravatar_id": "797e06feb159ad441a5dd270c4ccf06e",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "D-Programming-Language",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-01-22T17:44:47 | null | {"repository":{"has_issues":false,"description":"The standard library of the D programming language","owner":"D-Programming-Language","language":"D","has_downloads":true,"pushed_at":"2013-01-21T19:39:38-08:00","watchers":324,"forks":174,"open_issues":41,"organization":"D-Programming-Language","has_wiki":false,"stargazers":324,"fork":false,"size":1132,"created_at":"2011-01-14T23:00:06-08:00","homepage":"dlang.org/phobos","private":false},"actor_attributes":{"name":"Jonathan M Davis","location":"Fresno, CA, USA","type":"User","company":"Schneider Electric","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/D-Programming-Language/phobos/pull/1090#discussion_r2729135"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/7875738","id":7875738,"diff_hunk":"@@ -1492,6 +1492,15 @@ void test74()\n \n /***************************************************/\n \n+void test9212()\n+{\n+ int[int] aa;\n+ foreach (const key, val; aa) {}\n+ foreach (size_t key, val; aa) {}","path":"test/runnable/xtest46.d","position":8,"original_position":8,"commit_id":"c8219a198c2a9a31042d05cbf35b57f631ac3ecf","original_commit_id":"c8219a198c2a9a31042d05cbf35b57f631ac3ecf","user":{"login":"yebblies","id":580100,"avatar_url":"https://1.gravatar.com/avatar/94a16a9c162f5fc451a2c421f9c2acda?d=https%3A%2F%2Fidenticons.github.com%2Fc4a0b3e2996e7ee5918867f855c2b5d9.png&r=x","gravatar_id":"94a16a9c162f5fc451a2c421f9c2acda","url":"https://api.github.com/users/yebblies","html_url":"https://github.com/yebblies","followers_url":"https://api.github.com/users/yebblies/followers","following_url":"https://api.github.com/users/yebblies/following{/other_user}","gists_url":"https://api.github.com/users/yebblies/gists{/gist_id}","starred_url":"https://api.github.com/users/yebblies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yebblies/subscriptions","organizations_url":"https://api.github.com/users/yebblies/orgs","repos_url":"https://api.github.com/users/yebblies/repos","events_url":"https://api.github.com/users/yebblies/events{/privacy}","received_events_url":"https://api.github.com/users/yebblies/received_events","type":"User","site_admin":false},"body":"Because the compiler rewrites it to\r\n```d\r\nint val = __applyArg1;\r\nuint key = __applyArg0;\r\n```\r\nwhen ref is not needed. Otherwise const would not work either. This already works for `opApply`, I just had to weaken the error condition.","created_at":"2013-11-23T14:41:33Z","updated_at":"2013-11-23T14:41:33Z","html_url":"https://github.com/D-Programming-Language/dmd/pull/2864#discussion_r7875738","pull_request_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/2864","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/7875738"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/2864#discussion_r7875738"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/2864"}}}} | {
"id": 1257070,
"name": "dmd",
"url": "https://github.com/D-Programming-Language/dmd"
} | {
"id": null,
"login": "yebblies",
"gravatar_id": "94a16a9c162f5fc451a2c421f9c2acda",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "D-Programming-Language",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-23T14:41:33 | null | {"repository":{"description":"dmd D Programming Language compiler","homepage":"dlang.org","watchers":577,"stargazers":577,"forks":161,"fork":false,"size":35867,"owner":"D-Programming-Language","private":false,"open_issues":104,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"C","created_at":"2011-01-14T22:53:53-08:00","pushed_at":"2013-11-23T05:03:32-08:00","integrate_branch":"master","master_branch":"master","organization":"D-Programming-Language"},"actor_attributes":{"type":"User","name":"Daniel Murphy","company":"University of New South Wales","location":"Australia","email":"[email protected]"},"url":"https://github.com/D-Programming-Language/dmd/pull/2864#discussion_r7875738"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/D-Programming-Language/tools/pulls/comments/8569880","id":8569880,"diff_hunk":"@@ -106,8 +106,8 @@ $(ROOT)/dman: $(TAGS) $(PHOBOS_TAGS)\n $(ROOT)/dman: DFLAGS += -J.\n \n install: $(TOOLS) $(CURL_TOOLS)\n-\tinstall -d $(DESTDIR)$(PREFIX)\n-\tinstall -t $(DESTDIR)$(PREFIX) $(^)\n+\tmkdir -p $(INSTALL_DIR)/bin\n+\tcp $^ $(INSTALL_DIR)/bin","path":"posix.mak","position":15,"original_position":15,"commit_id":"17a8bca271ef17fa9f6e25ff8dd5fa30c392b690","original_commit_id":"17a8bca271ef17fa9f6e25ff8dd5fa30c392b690","user":{"login":"andralex","id":566679,"avatar_url":"https://gravatar.com/avatar/84f8321680c16c6dcf8203a54be03930?d=https%3A%2F%2Fidenticons.github.com%2F5c2df94207c5c4ee1432ee611b25d20b.png&r=x","gravatar_id":"84f8321680c16c6dcf8203a54be03930","url":"https://api.github.com/users/andralex","html_url":"https://github.com/andralex","followers_url":"https://api.github.com/users/andralex/followers","following_url":"https://api.github.com/users/andralex/following{/other_user}","gists_url":"https://api.github.com/users/andralex/gists{/gist_id}","starred_url":"https://api.github.com/users/andralex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andralex/subscriptions","organizations_url":"https://api.github.com/users/andralex/orgs","repos_url":"https://api.github.com/users/andralex/repos","events_url":"https://api.github.com/users/andralex/events{/privacy}","received_events_url":"https://api.github.com/users/andralex/received_events","type":"User","site_admin":false},"body":"Add the `-u` flag? This will compulsively copy everything, always.","created_at":"2013-12-27T17:24:22Z","updated_at":"2013-12-27T17:24:22Z","html_url":"https://github.com/D-Programming-Language/tools/pull/87#discussion_r8569880","pull_request_url":"https://api.github.com/repos/D-Programming-Language/tools/pulls/87","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/tools/pulls/comments/8569880"},"html":{"href":"https://github.com/D-Programming-Language/tools/pull/87#discussion_r8569880"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/tools/pulls/87"}}}} | {
"id": 1262864,
"name": "tools",
"url": "https://github.com/D-Programming-Language/tools"
} | {
"id": null,
"login": "andralex",
"gravatar_id": "84f8321680c16c6dcf8203a54be03930",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "D-Programming-Language",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-27T17:24:22 | null | {"repository":{"description":"Ancilliary tools for the D programming language compiler","homepage":"dlang.org","watchers":75,"stargazers":75,"forks":54,"fork":false,"size":494,"owner":"D-Programming-Language","private":false,"open_issues":8,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"D","created_at":"2011-01-17T01:07:05-08:00","pushed_at":"2013-12-27T09:22:39-08:00","master_branch":"master","organization":"D-Programming-Language"},"actor_attributes":{"type":"User","name":"Andrei Alexandrescu","company":"Facebook","blog":"http://erdani.com","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/D-Programming-Language/tools/pull/87#discussion_r8569880"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/5733092","id":5733092,"body":"Right, I just reduced the number of calls of toParent.","diff_hunk":"@@ -2168,16 +2168,15 @@ bool VarDeclaration::isDataseg()\n #endif\n if (storage_class & STCmanifest)\n return false;\n- Dsymbol *parent = this->toParent();\n+ Dsymbol *parent = toParent();\n if (!parent && !(storage_class & STCstatic))\n- { error(\"forward referenced\");\n+ {\n+ error(\"forward referenced\");\n type = Type::terror;\n return false;\n }\n- return canTakeAddressOf() &&\n- (storage_class & (STCstatic | STCextern | STCtls | STCgshared) ||\n- toParent()->isModule() ||\n- toParent()->isTemplateInstance());\n+ return storage_class & (STCstatic | STCextern | STCtls | STCgshared) ||\n+ parent->isModule() || parent->isTemplateInstance();","path":"src/declaration.c","position":18,"original_position":18,"commit_id":"1c0b6dab4ee318dbef332c07404801a86105f3c0","original_commit_id":"1c0b6dab4ee318dbef332c07404801a86105f3c0","user":{"login":"hpohl","id":682376,"avatar_url":"https://secure.gravatar.com/avatar/3a349d50001ce31e35e2888c83114c12?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"3a349d50001ce31e35e2888c83114c12","url":"https://api.github.com/users/hpohl","html_url":"https://github.com/hpohl","followers_url":"https://api.github.com/users/hpohl/followers","following_url":"https://api.github.com/users/hpohl/following{/other_user}","gists_url":"https://api.github.com/users/hpohl/gists{/gist_id}","starred_url":"https://api.github.com/users/hpohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpohl/subscriptions","organizations_url":"https://api.github.com/users/hpohl/orgs","repos_url":"https://api.github.com/users/hpohl/repos","events_url":"https://api.github.com/users/hpohl/events{/privacy}","received_events_url":"https://api.github.com/users/hpohl/received_events","type":"User"},"created_at":"2013-08-13T11:15:37Z","updated_at":"2013-08-13T11:15:37Z","html_url":"https://github.com/D-Programming-Language/dmd/pull/2470#discussion_r5733092","pull_request_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/2470","_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/5733092"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/2470#discussion_r5733092"},"pull_request":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/2470"}}}} | {
"id": 1257070,
"name": "dmd",
"url": "https://github.com/D-Programming-Language/dmd"
} | {
"id": null,
"login": "hpohl",
"gravatar_id": "3a349d50001ce31e35e2888c83114c12",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "D-Programming-Language",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-13T11:15:37 | null | {"repository":{"description":"dmd D Programming Language compiler","homepage":"dlang.org","watchers":505,"stargazers":505,"forks":151,"fork":false,"size":28649,"owner":"D-Programming-Language","private":false,"open_issues":80,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"C","created_at":"2011-01-14T22:53:53-08:00","pushed_at":"2013-08-12T22:21:17-07:00","integrate_branch":"master","master_branch":"master","organization":"D-Programming-Language"},"actor_attributes":{"type":"User","name":"Henning Pohl","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/D-Programming-Language/dmd/pull/2470#discussion_r5733092"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/symfony2admingenerator/AdmingeneratorGeneratorBundle/pulls/comments/4874453","id":4874453,"body":"@sescandell another approach would be to use my recursive ordering fix ONLY for `object_actions` and `batch_actions` and for the rest only apply standard array_replace_recursive\r\n\r\nArray merge is not an option here, becouse if you have:\r\n```php\r\nparams:\r\n object_actions:\r\n actionA: ~ #some settings\r\n actionB: ~ #some settings\r\n edit: ~ #some settings\r\nbuilders:\r\n list:\r\n object_actions:\r\n actionA: ~\r\n actionB: ~\r\n edit: ~\r\n actions:\r\n object_actions:\r\n actionA: ~\r\n```\r\n\r\nthen actions builder will get `edit` and `actionB` merged anyways (which we don't want)","diff_hunk":"@@ -59,14 +59,39 @@ public function setBaseAdminTemplate($base_admin_template)\n public function addBuilder(BuilderInterface $builder)\n {\n parent::addBuilder($builder);\n- $vars = array_replace_recursive(\n- $this->getFromYaml(sprintf('builders.%s.params', $builder->getYamlKey()), array()),\n- $this->getFromYaml('params', array()),\n- $this->getFromYaml(sprintf('builders.%s.params', $builder->getYamlKey()), array())\n+ \n+ $builder->setVariables(\n+ $this->recursiveReplace(\n+ $this->getFromYaml('params', array()),\n+ $this->getFromYaml(sprintf('builders.%s.params', $builder->getYamlKey()), array())\n+ )\n );\n- $builder->setVariables($vars);\n $builder->setColumnClass($this->getColumnClass());\n }\n+ \n+ /**\n+ * Recursively replaces Base array values with Replacedement array values\n+ * while keeping indexes of Replacement array\n+ * \n+ * @param array $base Base array\n+ * @param array $replacement Replacement array\n+ */\n+ protected function recursiveReplace($base, $replacement)","path":"Builder/Generator.php","position":26,"original_position":26,"commit_id":"bb78353f0c74fce0afc6569040f67e31c6321de4","original_commit_id":"bb78353f0c74fce0afc6569040f67e31c6321de4","user":{"login":"loostro","id":1419884,"avatar_url":"https://secure.gravatar.com/avatar/27e105f9f249460987432b2b1de2c28d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"27e105f9f249460987432b2b1de2c28d","url":"https://api.github.com/users/loostro","html_url":"https://github.com/loostro","followers_url":"https://api.github.com/users/loostro/followers","following_url":"https://api.github.com/users/loostro/following{/other_user}","gists_url":"https://api.github.com/users/loostro/gists{/gist_id}","starred_url":"https://api.github.com/users/loostro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loostro/subscriptions","organizations_url":"https://api.github.com/users/loostro/orgs","repos_url":"https://api.github.com/users/loostro/repos","events_url":"https://api.github.com/users/loostro/events{/privacy}","received_events_url":"https://api.github.com/users/loostro/received_events","type":"User"},"created_at":"2013-06-25T18:58:09Z","updated_at":"2013-06-25T18:58:09Z","html_url":"https://github.com/symfony2admingenerator/AdmingeneratorGeneratorBundle/pull/529#discussion_r4874453","pull_request_url":"https://api.github.com/repos/symfony2admingenerator/AdmingeneratorGeneratorBundle/pulls/529","_links":{"self":{"href":"https://api.github.com/repos/symfony2admingenerator/AdmingeneratorGeneratorBundle/pulls/comments/4874453"},"html":{"href":"https://github.com/symfony2admingenerator/AdmingeneratorGeneratorBundle/pull/529#discussion_r4874453"},"pull_request":{"href":"https://api.github.com/repos/symfony2admingenerator/AdmingeneratorGeneratorBundle/pulls/529"}}}} | {
"id": 2151686,
"name": "AdmingeneratorGeneratorBundle",
"url": "https://github.com/symfony2admingenerator/AdmingeneratorGeneratorBundle"
} | {
"id": null,
"login": "loostro",
"gravatar_id": "27e105f9f249460987432b2b1de2c28d",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "symfony2admingenerator",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-25T18:58:09 | null | {"repository":{"description":"Admingenerator for Symfony2, parse generator.yml files to build classes","homepage":"http://symfony2admingenerator.org/","watchers":317,"stargazers":317,"forks":104,"fork":false,"size":1656,"owner":"symfony2admingenerator","private":false,"open_issues":38,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-08-03T16:29:30-07:00","pushed_at":"2013-06-24T11:27:24-07:00","master_branch":"master","organization":"symfony2admingenerator"},"actor_attributes":{"type":"User","name":"loostro","location":"Poland","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/symfony2admingenerator/AdmingeneratorGeneratorBundle/pull/529#discussion_r4874453"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/comments/7413737","id":7413737,"diff_hunk":"@@ -310,8 +388,13 @@ def disconnect\n end\n \n # Stop the timer after the last disconnection from this instance.\n+ # If persistence was enabled for this instance, and there is an authoritative state\n+ # then save the current authoritative state.\n \n if clients.length == 1 # going to 0\n+ if VWF::Application::Reflector.instance_is_persistence_enabled?( env ) and ! session[ :authoritative_state ].nil?","path":"lib/vwf/application/reflector.rb","position":133,"original_position":133,"commit_id":"1892be9661dd42d5c956c7fc7d2b9b3f1330d309","original_commit_id":"1892be9661dd42d5c956c7fc7d2b9b3f1330d309","user":{"login":"jessmartin","id":27258,"avatar_url":"https://2.gravatar.com/avatar/5413a812757c471c3bd10baf4614ebf7?d=https%3A%2F%2Fidenticons.github.com%2Faaea30db7c8b270df7a0f70f92db0ab3.png&r=x","gravatar_id":"5413a812757c471c3bd10baf4614ebf7","url":"https://api.github.com/users/jessmartin","html_url":"https://github.com/jessmartin","followers_url":"https://api.github.com/users/jessmartin/followers","following_url":"https://api.github.com/users/jessmartin/following{/other_user}","gists_url":"https://api.github.com/users/jessmartin/gists{/gist_id}","starred_url":"https://api.github.com/users/jessmartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessmartin/subscriptions","organizations_url":"https://api.github.com/users/jessmartin/orgs","repos_url":"https://api.github.com/users/jessmartin/repos","events_url":"https://api.github.com/users/jessmartin/events{/privacy}","received_events_url":"https://api.github.com/users/jessmartin/received_events","type":"User","site_admin":false},"body":"Don't use `and`. Use `&&`.","created_at":"2013-11-04T21:20:44Z","updated_at":"2013-11-04T21:20:44Z","html_url":"https://github.com/virtual-world-framework/vwf/pull/62#discussion_r7413737","pull_request_url":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/comments/7413737"},"html":{"href":"https://github.com/virtual-world-framework/vwf/pull/62#discussion_r7413737"},"pull_request":{"href":"https://api.github.com/repos/virtual-world-framework/vwf/pulls/62"}}}} | {
"id": 3857149,
"name": "vwf",
"url": "https://github.com/virtual-world-framework/vwf"
} | {
"id": null,
"login": "jessmartin",
"gravatar_id": "5413a812757c471c3bd10baf4614ebf7",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "virtual-world-framework",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-04T21:20:44 | null | {"repository":{"description":"Virtual World Framework","homepage":"http://virtualworldframework.com","watchers":53,"stargazers":53,"forks":24,"fork":false,"size":505471,"owner":"virtual-world-framework","private":false,"open_issues":8,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-03-28T09:40:09-07:00","pushed_at":"2013-11-04T09:19:14-08:00","master_branch":"master","organization":"virtual-world-framework"},"actor_attributes":{"type":"User","name":"Jess Martin","company":"","blog":"http://jessmart.in","location":"Fuquay-Varina, NC","email":"[email protected]"},"url":"https://github.com/virtual-world-framework/vwf/pull/62#discussion_r7413737"} |