Search is not available for this dataset
type
stringclasses 17
values | public
bool 2
classes | payload
stringlengths 2
1.27M
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringclasses 0
values | other
stringlengths 34
66.4k
|
---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/ezsystems/ezfind/pulls/comments/3100540","id":3100540,"body":"ini always return strings, better would be !$iniSearchServerURI or !empty( $iniSearchServerURI )","path":"classes/ezsolrbase.php","position":5,"original_position":5,"commit_id":"9ab3809f6dfcfb86418fd05cd5fc19f5f424a189","original_commit_id":"9ab3809f6dfcfb86418fd05cd5fc19f5f424a189","user":{"login":"andrerom","id":289757,"avatar_url":"https://secure.gravatar.com/avatar/90bed9bc49929b9eaf0764d20429f5b3?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"90bed9bc49929b9eaf0764d20429f5b3","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User"},"created_at":"2013-02-21T15:46:39Z","updated_at":"2013-02-21T15:46:39Z","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezfind/pulls/comments/3100540"},"html":{"href":"https://github.com/ezsystems/ezfind/pull/97#discussion_r3100540"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/ezfind/pulls/97"}}}} | {
"id": 1007121,
"name": "ezfind",
"url": "https://github.com/ezsystems/ezfind"
} | {
"id": null,
"login": "andrerom",
"gravatar_id": "90bed9bc49929b9eaf0764d20429f5b3",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "ezsystems",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-21T15:46:39 | null | {"repository":{"description":"","homepage":"","watchers":66,"stargazers":66,"forks":48,"fork":false,"size":804,"owner":"ezsystems","private":false,"open_issues":25,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"PHP","created_at":"2010-10-19T13:46:09-07:00","pushed_at":"2013-02-18T02:35:11-08:00","master_branch":"master","organization":"ezsystems"},"actor_attributes":{"name":"André R.","company":"eZ Systems","location":"Oslo, Norway","type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/ezsystems/ezfind/pull/97#discussion_r3100540"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/getsentry/sentry/pulls/comments/4834466","id":4834466,"body":"I dont think you should need this. sentry.wsgi immediately does a configure() to import the settings in a correct manner","diff_hunk":"@@ -203,6 +204,52 @@ You'll use the builtin HttpProxyModule within Nginx to handle proxying::\n proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;\n }\n \n+Running Sentry as WSGI application\n+----------------------------------\n+\n+Sentry can use any WSGI server using ``sentry.wsgi`` module. To setup Sentry with `uWSGI <http://projects.unbit.it/uwsgi/>`_, add at the top of ``sentry.conf`` file::\n+\n+ from sentry.conf.server import *","path":"docs/quickstart/index.rst","position":19,"original_position":19,"commit_id":"e0c89d865c873d215ff49f79d4e1f582ad684d5c","original_commit_id":"e0c89d865c873d215ff49f79d4e1f582ad684d5c","user":{"login":"dcramer","id":23610,"avatar_url":"https://secure.gravatar.com/avatar/51567a4f786cd8a2c41c513b592de9f9?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"51567a4f786cd8a2c41c513b592de9f9","url":"https://api.github.com/users/dcramer","html_url":"https://github.com/dcramer","followers_url":"https://api.github.com/users/dcramer/followers","following_url":"https://api.github.com/users/dcramer/following{/other_user}","gists_url":"https://api.github.com/users/dcramer/gists{/gist_id}","starred_url":"https://api.github.com/users/dcramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcramer/subscriptions","organizations_url":"https://api.github.com/users/dcramer/orgs","repos_url":"https://api.github.com/users/dcramer/repos","events_url":"https://api.github.com/users/dcramer/events{/privacy}","received_events_url":"https://api.github.com/users/dcramer/received_events","type":"User"},"created_at":"2013-06-23T21:55:39Z","updated_at":"2013-06-23T21:55:39Z","html_url":"https://github.com/getsentry/sentry/pull/921#discussion_r4834466","pull_request_url":"https://api.github.com/repos/getsentry/sentry/pulls/921","_links":{"self":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/comments/4834466"},"html":{"href":"https://github.com/getsentry/sentry/pull/921#discussion_r4834466"},"pull_request":{"href":"https://api.github.com/repos/getsentry/sentry/pulls/921"}}}} | {
"id": 873328,
"name": "sentry",
"url": "https://github.com/getsentry/sentry"
} | {
"id": null,
"login": "dcramer",
"gravatar_id": "51567a4f786cd8a2c41c513b592de9f9",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "getsentry",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-23T21:55:39 | null | {"repository":{"description":"Sentry is a realtime error logging and aggregation platform","homepage":"https://getsentry.com","watchers":3285,"stargazers":3285,"forks":432,"fork":false,"size":10496,"owner":"getsentry","private":false,"open_issues":149,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2010-08-30T15:06:41-07:00","pushed_at":"2013-06-23T11:19:12-07:00","master_branch":"master","organization":"getsentry"},"actor_attributes":{"type":"User","name":"David Cramer","company":"Disqus","blog":"http://www.davidcramer.net/","location":"San Francisco, CA","email":"[email protected]"},"url":"https://github.com/getsentry/sentry/pull/921#discussion_r4834466"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/6157847","id":6157847,"body":"Ah, I guess that's the explanation.","diff_hunk":"@@ -0,0 +1,70 @@\n+/*\n+ * Hibernate, Relational Persistence for Idiomatic Java\n+ *\n+ * Copyright (c) 2013, Red Hat, Inc. and/or its affiliates or third-party contributors as\n+ * indicated by the @author tags or express copyright attribution\n+ * statements applied by the authors. All third-party contributions are\n+ * distributed under license by Red Hat, Inc.\n+ *\n+ * This copyrighted material is made available to anyone wishing to use, modify,\n+ * copy, or redistribute it subject to the terms and conditions of the GNU\n+ * Lesser General Public License, as published by the Free Software Foundation.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY\n+ * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License\n+ * for more details.\n+ *\n+ * You should have received a copy of the GNU Lesser General Public License\n+ * along with this distribution; if not, write to:\n+ * Free Software Foundation, Inc.\n+ * 51 Franklin Street, Fifth Floor\n+ * Boston, MA 02110-1301 USA\n+ */\n+package org.hibernate.search.test.util;\n+\n+import java.lang.reflect.Method;\n+\n+import org.hibernate.service.ServiceRegistry;\n+import org.hibernate.service.ServiceRegistryBuilder;\n+\n+/**\n+ * Hibernate ORM 4.3 changed some internal methods names compared to 4.2 which we use\n+ * in the testsuite only, so rather than bothering with backwards compatibility in ORM\n+ * we acn workaround the problem with some reflection.\n+ */\n+public class ServiceRegistryTools {\n+\n+\tprivate static final Method builderMethod = identifyCorrectBuilderMethod();\n+\n+\tpublic static ServiceRegistry build(ServiceRegistryBuilder registryBuilder) {\n+\t\ttry {\n+\t\t\treturn (ServiceRegistry) builderMethod.invoke( registryBuilder );\n+\t\t}\n+\t\tcatch (Exception e) {\n+\t\t\tthrow new RuntimeException( e );\n+\t\t}\n+\t}\n+\n+\tprivate static Method identifyCorrectBuilderMethod() {\n+\t\ttry {\n+\t\t\treturn ServiceRegistryBuilder.class.getMethod( \"build\" );\n+\t\t}\n+\t\tcatch (SecurityException e) {\n+\t\t\te.printStackTrace();\n+\t\t}\n+\t\tcatch (NoSuchMethodException e) {\n+\t\t\ttry {\n+\t\t\t\treturn ServiceRegistryBuilder.class.getMethod( \"buildServiceRegistry\" );\n+\t\t\t}\n+\t\t\tcatch (SecurityException e1) {\n+\t\t\t\te1.printStackTrace();\n+\t\t\t}\n+\t\t\tcatch (NoSuchMethodException e1) {\n+\t\t\t\te1.printStackTrace();\n+\t\t\t}\n+\t\t}\n+\t\treturn null;//better to allow NPE than to debug a class initialization failure","path":"orm/src/test/java/org/hibernate/search/test/util/ServiceRegistryTools.java","position":67,"original_position":67,"commit_id":"f495799fc6fa4d84d08029c8a0ca3bea05ce0243","original_commit_id":"f495799fc6fa4d84d08029c8a0ca3bea05ce0243","user":{"login":"gunnarmorling","id":28612,"avatar_url":"https://0.gravatar.com/avatar/8e25c0ca4bf25113bd9c0ccc5d118164?d=https%3A%2F%2Fidenticons.github.com%2F6760b957686819cb6636c2319fb4f872.png","gravatar_id":"8e25c0ca4bf25113bd9c0ccc5d118164","url":"https://api.github.com/users/gunnarmorling","html_url":"https://github.com/gunnarmorling","followers_url":"https://api.github.com/users/gunnarmorling/followers","following_url":"https://api.github.com/users/gunnarmorling/following{/other_user}","gists_url":"https://api.github.com/users/gunnarmorling/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarmorling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarmorling/subscriptions","organizations_url":"https://api.github.com/users/gunnarmorling/orgs","repos_url":"https://api.github.com/users/gunnarmorling/repos","events_url":"https://api.github.com/users/gunnarmorling/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarmorling/received_events","type":"User"},"created_at":"2013-09-04T15:58:38Z","updated_at":"2013-09-04T15:58:38Z","html_url":"https://github.com/hibernate/hibernate-search/pull/476#discussion_r6157847","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/476","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/6157847"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/476#discussion_r6157847"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/476"}}}} | {
"id": 990281,
"name": "hibernate-search",
"url": "https://github.com/hibernate/hibernate-search"
} | {
"id": null,
"login": "gunnarmorling",
"gravatar_id": "8e25c0ca4bf25113bd9c0ccc5d118164",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "hibernate",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-04T15:58:38 | null | {"repository":{"description":"Hibernate Search: full-text search for domain model","homepage":"http://search.hibernate.org","watchers":103,"stargazers":103,"forks":70,"fork":false,"size":7708,"owner":"hibernate","private":false,"open_issues":1,"has_issues":false,"has_downloads":false,"has_wiki":false,"language":"Java","created_at":"2010-10-15T08:55:09-07:00","pushed_at":"2013-09-03T08:39:33-07:00","master_branch":"master","organization":"hibernate"},"actor_attributes":{"type":"User","name":"Gunnar Morling","blog":"http://musingsofaprogrammingaddict.blogspot.com","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/hibernate/hibernate-search/pull/476#discussion_r6157847"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/comments/4720980","id":4720980,"body":"See previous comment about RuntimeException","diff_hunk":"@@ -0,0 +1,142 @@\n+/*\n+ * Hibernate, Relational Persistence for Idiomatic Java\n+ *\n+ * JBoss, Home of Professional Open Source\n+ * Copyright 2013 Red Hat Inc. and/or its affiliates and other contributors\n+ * as indicated by the @authors tag. All rights reserved.\n+ * See the copyright.txt in the distribution for a\n+ * full listing of individual contributors.\n+ *\n+ * This copyrighted material is made available to anyone wishing to use,\n+ * modify, copy, or redistribute it subject to the terms and conditions\n+ * of the GNU Lesser General Public License, v. 2.1.\n+ * This program is distributed in the hope that it will be useful, but WITHOUT A\n+ * WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A\n+ * PARTICULAR PURPOSE. See the GNU Lesser General Public License for more details.\n+ * You should have received a copy of the GNU Lesser General Public License,\n+ * v.2.1 along with this distribution; if not, write to the Free Software\n+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,\n+ * MA 02110-1301, USA.\n+ */\n+package org.hibernate.ogm.datastore.couchdb.impl;\n+\n+import org.hibernate.ogm.datastore.couchdb.impl.util.CouchDBConfiguration;\n+import org.hibernate.ogm.datastore.spi.DatastoreProvider;\n+import org.hibernate.ogm.dialect.GridDialect;\n+import org.hibernate.ogm.dialect.couchdb.CouchDBDialect;\n+import org.hibernate.ogm.dialect.couchdb.Environment;\n+import org.hibernate.ogm.dialect.couchdb.util.DataBaseURL;\n+import org.hibernate.service.spi.Configurable;\n+import org.hibernate.service.spi.ServiceRegistryAwareService;\n+import org.hibernate.service.spi.ServiceRegistryImplementor;\n+import org.hibernate.service.spi.Startable;\n+import org.hibernate.service.spi.Stoppable;\n+\n+import java.net.MalformedURLException;\n+import java.util.Map;\n+\n+/**\n+ * Creates a fully configured instance of {@link CouchDBDatastore}\n+ *\n+ * @author Andrea Boriero <[email protected]/>\n+ */\n+public class CouchDBDatastoreProvider implements DatastoreProvider, Startable, Stoppable, ServiceRegistryAwareService,\n+\t\tConfigurable {\n+\n+\tprivate static final int DEFAULT_COUCHDB_PORT = 5984;\n+\tprivate static final String LOCAL_HOST = \"localhost\";\n+\n+\tprivate CouchDBDatastore datastore;\n+\n+\tprivate CouchDBConfiguration configuration;\n+\n+\tpublic CouchDBDatastoreProvider() {\n+\t\tconfiguration = new CouchDBConfiguration();\n+\t}\n+\n+\t@Override\n+\tpublic void configure(Map configurationValues) {\n+\t\tconfiguration.setConfigurationValues( configurationValues );\n+\t}\n+\n+\t@Override\n+\tpublic void injectServices(ServiceRegistryImplementor serviceRegistry) {\n+\t}\n+\n+\t@Override\n+\tpublic void stop() {\n+\t\tif ( datastore != null ) {\n+\t\t\tdatastore.shutDown();\n+\t\t\tdatastore = null;\n+\t\t}\n+\t}\n+\n+\t@Override\n+\tpublic void start() {\n+\t\tif ( isDatastoreNotInitialized() ) {\n+\t\t\tdatastore = CouchDBDatastore.newInstance( retrieveDataBaseURL(), retrieveUsername(), retrievePassword(),\n+\t\t\t\t\tisCreateDatabase() );\n+\t\t}\n+\t}\n+\n+\t@Override\n+\tpublic Class<? extends GridDialect> getDefaultDialect() {\n+\t\treturn CouchDBDialect.class;\n+\t}\n+\n+\t/**\n+\t * Provides an instance of CouchDBDatastore\n+\t *\n+\t * @return an instance of CouchDBDatastore\n+\t */\n+\tpublic CouchDBDatastore getDataStore() {\n+\t\treturn datastore;\n+\t}\n+\n+\tprivate boolean isDatastoreNotInitialized() {\n+\t\treturn datastore == null;\n+\t}\n+\n+\tprivate DataBaseURL retrieveDataBaseURL() {\n+\t\tif ( isDatabaseNameConfigured() ) {\n+\t\t\ttry {\n+\t\t\t\treturn new DataBaseURL( getDatabaseHost(), getDatabasePort(), getDatabaseName() );\n+\t\t\t}\n+\t\t\tcatch ( MalformedURLException e ) {\n+\t\t\t\tthrow new RuntimeException( e );\n+\t\t\t}\n+\t\t}\n+\t\telse {\n+\t\t\tthrow new RuntimeException( \"Missing property value: \" + Environment.COUCHDB_DATABASE );","path":"hibernate-ogm-couchdb/src/main/java/org/hibernate/ogm/datastore/couchdb/impl/CouchDBDatastoreProvider.java","position":110,"original_position":110,"commit_id":"82e05d829fa286e0a985508b9672c129d985721d","original_commit_id":"82e05d829fa286e0a985508b9672c129d985721d","user":{"login":"DavideD","id":559221,"avatar_url":"https://secure.gravatar.com/avatar/81bb77cf77fb3dd1347f0c5c39e20548?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"81bb77cf77fb3dd1347f0c5c39e20548","url":"https://api.github.com/users/DavideD","html_url":"https://github.com/DavideD","followers_url":"https://api.github.com/users/DavideD/followers","following_url":"https://api.github.com/users/DavideD/following{/other_user}","gists_url":"https://api.github.com/users/DavideD/gists{/gist_id}","starred_url":"https://api.github.com/users/DavideD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavideD/subscriptions","organizations_url":"https://api.github.com/users/DavideD/orgs","repos_url":"https://api.github.com/users/DavideD/repos","events_url":"https://api.github.com/users/DavideD/events{/privacy}","received_events_url":"https://api.github.com/users/DavideD/received_events","type":"User"},"created_at":"2013-06-17T10:14:14Z","updated_at":"2013-06-17T10:14:14Z","html_url":"https://github.com/hibernate/hibernate-ogm/pull/193#discussion_r4720980","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/193","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/comments/4720980"},"html":{"href":"https://github.com/hibernate/hibernate-ogm/pull/193#discussion_r4720980"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/193"}}}} | {
"id": 1608936,
"name": "hibernate-ogm",
"url": "https://github.com/hibernate/hibernate-ogm"
} | {
"id": null,
"login": "DavideD",
"gravatar_id": "81bb77cf77fb3dd1347f0c5c39e20548",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "hibernate",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-17T10:14:14 | null | {"repository":{"description":"Hibernate Object/Grid Mapper","homepage":"http://ogm.hibernate.org","watchers":92,"stargazers":92,"forks":55,"fork":false,"size":668,"owner":"hibernate","private":false,"open_issues":11,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2011-04-13T04:40:56-07:00","pushed_at":"2013-06-07T04:24:33-07:00","master_branch":"master","organization":"hibernate"},"actor_attributes":{"type":"User","name":"Davide D'Alto","location":"London","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/hibernate/hibernate-ogm/pull/193#discussion_r4720980"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/huskysoft/403Interviewer/pulls/comments/4577330","id":4577330,"body":"could also just not append the default here, since the php layer will default to EN. not a big deal either way","diff_hunk":"@@ -103,6 +107,17 @@ public String getQuestions(Difficulty difficulty,\n \t\t\t\t\tPARAM_AUTHORID, String.valueOf(authorId));\n \t\t\turlToSend.append(str);\n \t\t}\n+\t\tLanguage lang;\n+\t\ttry {\n+\t\t\tlang = Language.valueOf(Locale.getDefault().getLanguage().\n+\t\t\t\t\ttrim().toUpperCase());\n+\t\t} catch (Exception e) {\n+\t\t\tlang = DEFAULT_LANGUAGE;","path":"InterviewAnnihilator/src/com/huskysoft/interviewannihilator/service/NetworkService.java","position":31,"original_position":31,"commit_id":"24bcf613ca979341943fa97d98bbcc35a0cb7a24","original_commit_id":"24bcf613ca979341943fa97d98bbcc35a0cb7a24","user":{"login":"bkng","id":1864070,"avatar_url":"https://secure.gravatar.com/avatar/888197314ebaf3799be6194dd90ee38c?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"888197314ebaf3799be6194dd90ee38c","url":"https://api.github.com/users/bkng","html_url":"https://github.com/bkng","followers_url":"https://api.github.com/users/bkng/followers","following_url":"https://api.github.com/users/bkng/following{/other_user}","gists_url":"https://api.github.com/users/bkng/gists{/gist_id}","starred_url":"https://api.github.com/users/bkng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkng/subscriptions","organizations_url":"https://api.github.com/users/bkng/orgs","repos_url":"https://api.github.com/users/bkng/repos","events_url":"https://api.github.com/users/bkng/events{/privacy}","received_events_url":"https://api.github.com/users/bkng/received_events","type":"User"},"created_at":"2013-06-06T20:46:03Z","updated_at":"2013-06-06T20:46:03Z","html_url":"https://github.com/huskysoft/403Interviewer/pull/205#discussion_r4577330","pull_request_url":"https://api.github.com/repos/huskysoft/403Interviewer/pulls/205","_links":{"self":{"href":"https://api.github.com/repos/huskysoft/403Interviewer/pulls/comments/4577330"},"html":{"href":"https://github.com/huskysoft/403Interviewer/pull/205#discussion_r4577330"},"pull_request":{"href":"https://api.github.com/repos/huskysoft/403Interviewer/pulls/205"}}}} | {
"id": 9326139,
"name": "403Interviewer",
"url": "https://github.com/huskysoft/403Interviewer"
} | {
"id": null,
"login": "bkng",
"gravatar_id": "888197314ebaf3799be6194dd90ee38c",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "huskysoft",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-06T20:46:03 | null | {"repository":{"description":"Interview Annihilator repository","watchers":0,"stargazers":0,"forks":7,"fork":false,"size":704,"owner":"huskysoft","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2013-04-09T09:39:39-07:00","pushed_at":"2013-06-06T10:45:10-07:00","master_branch":"master","organization":"huskysoft"},"actor_attributes":{"type":"User","name":"Bennett Ng","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/huskysoft/403Interviewer/pull/205#discussion_r4577330"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/inaes-tic/mbc-mosto/pulls/comments/3784917","id":3784917,"body":"We can send prev, current and next Caspa playlist ids too somewhere...\r\n\r\nEnviado desde mi BlackBerry\r\n\r\n-----Original Message-----\r\nFrom: Tomas Neme <[email protected]>\r\nDate: Sat, 13 Apr 2013 16:28:56 \r\nTo: inaes-tic/mbc-mosto<[email protected]>\r\nReply-To: inaes-tic/mbc-mosto <[email protected]>\r\nCc: Juan Martin Runge<[email protected]>\r\nSubject: Re: [mbc-mosto] NOT FOR MERGE please review (#54)\r\n\r\n> + if( i < meltedStatus.current ) {\r\n> + if( clips[i].playlist_id != status.show.current ) {\r\n> + status.show.previous = { _id: clips[i].playlist_id };\r\n> + }\r\n> + } else if ( i > meltedStatus.current ) {\r\n> + if( clips[i].playlist_id != status.show.current ) {\r\n> + // I'm pass `previous` and the first into `next`, so I'm\r\n> + // done here\r\n> + status.show.next = { _id: clips[i].playlist_id };\r\n> + break;\r\n> + }\r\n> + }\r\n> + }\r\n> +\r\n> + this.status = _.extend(this.status, status);\r\n> + // except next. If that's undefined, I just don't know!\r\n\r\ncan someone think of a workaround for this? if the current playlist goes all the way to the end of the clips list, I have no way of knowing what's the next show going to be!\r\n\r\n---\r\nReply to this email directly or view it on GitHub:\r\nhttps://github.com/inaes-tic/mbc-mosto/pull/54/files#r3784755\r\n\r\n","diff_hunk":"@@ -0,0 +1,117 @@\n+/*******************\n+ * This is the pubsub driver that should tell caspa about the melted status\n+ *\n+ *******************/\n+var events = require('events');\n+var util = require('util');\n+var _ = require('underscore');\n+var mbc = require('mbc-common');\n+\n+defaults = { // copied from caspa/models.App.Status\n+ _id: 2,\n+ piece: {\n+ previous: {name: ''},\n+ current: {name: '', progress: '0%'},\n+ next: {name: ''},\n+ },\n+ show: {\n+ previous: {_id: -1},\n+ current: {_id: -1},\n+ next: {_id: -1},\n+ },\n+ source: null,\n+ on_air: false,\n+};\n+\n+function CaspaDriver() {\n+ events.EventEmitter.call(this);\n+ var self = this;\n+ this.status = _.clone(defaults);\n+ this.publisher = mbc.pubsub();\n+\n+ CaspaDriver.prototype.setupAll = function() {\n+ var setups = [\n+ this.setupStatus\n+ ];\n+ var sendReady = _.after(setups.length, function() {\n+ self.emit('ready');\n+ });\n+ setups.forEach(function(setup){\n+ setup(sendReady);\n+ });\n+ };\n+\n+ CaspaDriver.prototype.setupStatus = function(callback) {\n+ var db = mbc.db();\n+ var col = db.collection('status');\n+ col.findOne({_id: 2}, function(err, res) {\n+ if( err )\n+ // err.. do something?\n+ return;\n+ if( !res ) {\n+ // the status doesn't exist, create it\n+ col.save(self.status, function(err, itm) {\n+ callback();\n+ });\n+ } else {\n+ // res existed, just signal as ready\n+ callback();\n+ }\n+ });\n+ };\n+\n+ CaspaDriver.prototype.setStatus = function(meltedStatus) {\n+ // this overrides this.status with the values passed by status\n+ function makePiece(clip) {\n+ return {\n+ name: clip.name,\n+ _id: clip.id\n+ }\n+ }\n+ var clips = meltedStatus.clips;\n+ var status = {\n+ piece: {\n+ previous: makePiece(clips[meltedStatus.previous]),\n+ current: makePiece(clips[meltedStatus.current]),\n+ next: makePiece(clips[meltedStatus.next]),\n+ },\n+ show: {\n+ current: { _id: clips[meltedStatus.current].playlist_id },\n+ },\n+ on_air: true,\n+ };\n+ status.piece.current.progress = meltedStatus.position + \"%\";\n+\n+ for( var i in meltedStatus.clips ) {\n+ if( i < meltedStatus.current ) {\n+ if( clips[i].playlist_id != status.show.current ) {\n+ status.show.previous = { _id: clips[i].playlist_id };\n+ }\n+ } else if ( i > meltedStatus.current ) {\n+ if( clips[i].playlist_id != status.show.current ) {\n+ // I'm pass `previous` and the first into `next`, so I'm\n+ // done here\n+ status.show.next = { _id: clips[i].playlist_id };\n+ break;\n+ }\n+ }\n+ }\n+\n+ this.status = _.extend(this.status, status);\n+ // except next. If that's undefined, I just don't know!","path":"drivers/status/pubsub.js","position":101,"original_position":101,"commit_id":"84031eb2885ebdd7c69753a49901de9ae9e37b81","original_commit_id":"84031eb2885ebdd7c69753a49901de9ae9e37b81","user":{"login":"jmrunge","id":518134,"avatar_url":"https://secure.gravatar.com/avatar/a177acc736ceaa73306d6a689afd189a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"a177acc736ceaa73306d6a689afd189a","url":"https://api.github.com/users/jmrunge","html_url":"https://github.com/jmrunge","followers_url":"https://api.github.com/users/jmrunge/followers","following_url":"https://api.github.com/users/jmrunge/following","gists_url":"https://api.github.com/users/jmrunge/gists{/gist_id}","starred_url":"https://api.github.com/users/jmrunge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmrunge/subscriptions","organizations_url":"https://api.github.com/users/jmrunge/orgs","repos_url":"https://api.github.com/users/jmrunge/repos","events_url":"https://api.github.com/users/jmrunge/events{/privacy}","received_events_url":"https://api.github.com/users/jmrunge/received_events","type":"User"},"created_at":"2013-04-14T02:04:49Z","updated_at":"2013-04-14T02:04:49Z","html_url":"https://github.com/inaes-tic/mbc-mosto/pull/54#discussion_r3784917","pull_request_url":"https://api.github.com/repos/inaes-tic/mbc-mosto/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/inaes-tic/mbc-mosto/pulls/comments/3784917"},"html":{"href":"https://github.com/inaes-tic/mbc-mosto/pull/54#discussion_r3784917"},"pull_request":{"href":"https://api.github.com/repos/inaes-tic/mbc-mosto/pulls/54"}}}} | {
"id": 7042724,
"name": "mbc-mosto",
"url": "https://github.com/inaes-tic/mbc-mosto"
} | {
"id": null,
"login": "jmrunge",
"gravatar_id": "a177acc736ceaa73306d6a689afd189a",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "inaes-tic",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-14T02:04:49 | null | {"repository":{"description":"@mbc-playout's playlist juggler","watchers":1,"stargazers":1,"forks":0,"fork":false,"size":3064,"owner":"inaes-tic","private":false,"open_issues":28,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-12-06T12:47:55-08:00","pushed_at":"2013-04-13T16:19:32-07:00","master_branch":"master","organization":"inaes-tic"},"actor_attributes":{"type":"User","name":"Juan Martin Runge","blog":"www.zirsi.com.ar","location":"Bariloche, Argentina","email":"[email protected]"},"url":"https://github.com/inaes-tic/mbc-mosto/pull/54#discussion_r3784917"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/inaes-tic/backbone.io/pulls/comments/5762148","id":5762148,"body":"That options cames from our search configuration","diff_hunk":"@@ -89,12 +90,40 @@ module.exports = function(db, colname, options) {\n }\n });\n \n+ if(_.has(options.search, 'criteria') && _.has(data.query, 'criteria')) {\n+ var criteria_keys = _.keys(data.query.criteria);\n+ var criteria_values = _.values(data.query.criteria);\n+ var options_keys = _.keys(options.search.criteria);\n+ var options_values = _.values(options.search.criteria);\n+\n+ if (!(_.difference(criteria_keys, options_keys))) {\n+ res.end({'error':'criteria is not valid - read ' + criteria_keys });\n+ }\n+\n+ if(!(_.every(criteria_values, function(val) { return _.isArray(val); }))) {\n+ res.end({'error':'criteria is not an array - read '});\n+ }\n+ }\n+\n data.max_items = options.search.max_facets;\n }\n \n+ //Creating criterias from collection search config and request data\n+ if(_.has(data.query, 'criteria')) {\n+ var criteria = _.reduce(data.query.criteria, function(memo, criteria, key) {\n+ var replace_str = \"%value%\";\n+ var options_key = options.search.criteria[key];\n+ _.forEach(criteria, function(param) {\n+ options_key = options_key.replace(replace_str, param);\n+ });\n+ return _.extend(memo, JSON.parse(options_key));\n+ }, {});\n+ _.extend(query, criteria);\n+ }\n+\n // Creating mongo expression using text search string\n if(_.has(data.query,'text')) {\n- _.forEach(options.search.fulltxt, function(field) {\n+ _.forEach(options.search.fulltext, function(field) {","path":"middleware/mongoStore.js","position":55,"original_position":55,"commit_id":"e21099d74004d22bf4e4f44721ba35b3e93bf068","original_commit_id":"e21099d74004d22bf4e4f44721ba35b3e93bf068","user":{"login":"josx","id":791137,"avatar_url":"https://secure.gravatar.com/avatar/5c56ec5b37853023a1e795069f5a2a3d?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"5c56ec5b37853023a1e795069f5a2a3d","url":"https://api.github.com/users/josx","html_url":"https://github.com/josx","followers_url":"https://api.github.com/users/josx/followers","following_url":"https://api.github.com/users/josx/following{/other_user}","gists_url":"https://api.github.com/users/josx/gists{/gist_id}","starred_url":"https://api.github.com/users/josx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josx/subscriptions","organizations_url":"https://api.github.com/users/josx/orgs","repos_url":"https://api.github.com/users/josx/repos","events_url":"https://api.github.com/users/josx/events{/privacy}","received_events_url":"https://api.github.com/users/josx/received_events","type":"User"},"created_at":"2013-08-14T12:43:38Z","updated_at":"2013-08-14T12:43:38Z","html_url":"https://github.com/inaes-tic/backbone.io/pull/15#discussion_r5762148","pull_request_url":"https://api.github.com/repos/inaes-tic/backbone.io/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/inaes-tic/backbone.io/pulls/comments/5762148"},"html":{"href":"https://github.com/inaes-tic/backbone.io/pull/15#discussion_r5762148"},"pull_request":{"href":"https://api.github.com/repos/inaes-tic/backbone.io/pulls/15"}}}} | {
"id": 7013822,
"name": "backbone.io",
"url": "https://github.com/inaes-tic/backbone.io"
} | {
"id": null,
"login": "josx",
"gravatar_id": "5c56ec5b37853023a1e795069f5a2a3d",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "inaes-tic",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-14T12:43:38 | null | {"repository":{"description":"Backbone.js sync via Socket.IO","homepage":"scttnlsn.github.com/backbone.io","watchers":1,"stargazers":1,"forks":0,"fork":true,"size":210,"owner":"inaes-tic","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-12-04T23:58:18-08:00","pushed_at":"2013-08-13T12:54:31-07:00","master_branch":"master","organization":"inaes-tic"},"actor_attributes":{"type":"User","name":"José Luis Di Biase","company":".::Crear::.","blog":"http://www.elarteylatecnologia.com.ar","location":"Lanus, Buenos Aires, Argentina","email":"[email protected]"},"url":"https://github.com/inaes-tic/backbone.io/pull/15#discussion_r5762148"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/inaes-tic/mbc-mosto/pulls/comments/3863143","id":3863143,"body":"Yes. To all... cleaning code...\r\nEl abr 18, 2013 5:51 PM, \"Juan Martin Runge\" <[email protected]>\r\nescribió:\r\n\r\n> In mosto.js:\r\n>\r\n> > this.server_started = false;\r\n> > + this.default_config = {\r\n> > + \"fps\": \"30\",\r\n> > + \"resolution\": \"hd\",\r\n> > + \"playout_mode\": \"direct\",\r\n> > + \"playlists_maxlength\": \"24:00:00\",\r\n> > + \"scheduled_playlist_maxlength\": \"04:00:00\",\r\n> > + \"timer_interval\": \"00:00:00\"\r\n> > + };\r\n>\r\n> This should be written in config only, doesnt it?\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub<https://github.com/inaes-tic/mbc-mosto/pull/69/files#r3863074>\r\n> .\r\n>","diff_hunk":"@@ -195,53 +997,112 @@ function mosto(configFile) {\n };\n \n mosto.prototype.initDriver = function() {\n+\n console.log(\"mbc-mosto: [INFO] Initializing playlists driver\");\n+\n self.driver.registerNewPlaylistListener(self.addPlaylist);\n self.driver.registerUpdatePlaylistListener(self.updatePlaylist);\n self.driver.registerRemovePlaylistListener(self.removePlaylist);\n+\n self.driver.start();\n };\n \n mosto.prototype.startMvcpServer = function(callback) {\n var result = self.server.initServer();\n result.then(function() {\n- \"mbc-mosto: [INFO] MVCP server started\";\n+ console.log(\"mbc-mosto: [INFO] MVCP server started\");\n+ self.server_started = true;\n if (callback !== undefined) {\n- self.server_started = true;\n callback();\n }\n }, function(err) {\n var e = new Error(\"mbc-mosto: [ERROR] Error starting MVCP server: \" + err + \".\\nRetrying in 5 seconds...\");\n console.error(e);\n setTimeout(function() {\n- self.startMvcpServer(self.playPlaylists);\n+ self.startMvcpServer(callback);\n }, 5000);\n });\n };\n- \n- this.configFile = configFile;\n- this.config = false;\n- this.playlists = [];\n+\n+\n+ /** CONFIGURATION */\n+ this.configFile = configFile;\n+ this.config = false;\n this.server_started = false;\n+ this.default_config = {\n+ \"fps\": \"30\",\n+ \"resolution\": \"hd\",\n+ \"playout_mode\": \"direct\",\n+ \"playlists_maxlength\": \"24:00:00\",\n+ \"scheduled_playlist_maxlength\": \"04:00:00\",\n+ \"timer_interval\": \"00:00:00\"\n+ };","path":"mosto.js","position":1130,"original_position":1130,"commit_id":"1a24a15e324227b061a4717efaa03c6bc0371396","original_commit_id":"1a24a15e324227b061a4717efaa03c6bc0371396","user":{"login":"fabriciocosta","id":2193311,"avatar_url":"https://secure.gravatar.com/avatar/1f1acf721ab1b97298e273cd623d538c?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"1f1acf721ab1b97298e273cd623d538c","url":"https://api.github.com/users/fabriciocosta","html_url":"https://github.com/fabriciocosta","followers_url":"https://api.github.com/users/fabriciocosta/followers","following_url":"https://api.github.com/users/fabriciocosta/following","gists_url":"https://api.github.com/users/fabriciocosta/gists{/gist_id}","starred_url":"https://api.github.com/users/fabriciocosta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabriciocosta/subscriptions","organizations_url":"https://api.github.com/users/fabriciocosta/orgs","repos_url":"https://api.github.com/users/fabriciocosta/repos","events_url":"https://api.github.com/users/fabriciocosta/events{/privacy}","received_events_url":"https://api.github.com/users/fabriciocosta/received_events","type":"User"},"created_at":"2013-04-18T20:54:12Z","updated_at":"2013-04-18T20:54:12Z","html_url":"https://github.com/inaes-tic/mbc-mosto/pull/69#discussion_r3863143","pull_request_url":"https://api.github.com/repos/inaes-tic/mbc-mosto/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/inaes-tic/mbc-mosto/pulls/comments/3863143"},"html":{"href":"https://github.com/inaes-tic/mbc-mosto/pull/69#discussion_r3863143"},"pull_request":{"href":"https://api.github.com/repos/inaes-tic/mbc-mosto/pulls/69"}}}} | {
"id": 7042724,
"name": "mbc-mosto",
"url": "https://github.com/inaes-tic/mbc-mosto"
} | {
"id": null,
"login": "fabriciocosta",
"gravatar_id": "1f1acf721ab1b97298e273cd623d538c",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "inaes-tic",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-18T20:54:12 | null | {"repository":{"description":"@mbc-playout's playlist juggler","watchers":1,"stargazers":1,"forks":0,"fork":false,"size":1104,"owner":"inaes-tic","private":false,"open_issues":26,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-12-06T12:47:55-08:00","pushed_at":"2013-04-18T10:08:52-07:00","master_branch":"master","organization":"inaes-tic"},"actor_attributes":{"type":"User","name":"Fabricio Costa Alisedo","company":"Moldeo Interactive Cooperativa de Trabajo Ltd.","blog":"http://www.moldeointeractive.com.ar","location":"Buenos Aires, Argentina","email":"59bd0a3ff43b32849b319e645d4798d8a5d1e889@moldeointeractive.com.ar"},"url":"https://github.com/inaes-tic/mbc-mosto/pull/69#discussion_r3863143"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/jenkinsci/email-ext-plugin/pulls/comments/8270394","id":8270394,"diff_hunk":"@@ -0,0 +1,3 @@\n+<div>\n+ An email will be sent when the build status changes form anything to \"Unstable\".","path":"src/main/resources/hudson/plugins/emailext/plugins/trigger/FirstUnstableTrigger/help.html","position":null,"original_position":2,"commit_id":"3a3febf396f4ee7c455a380702820fd9af8e3dd8","original_commit_id":"21c97b8626b4aa48bd2bda11b39921c30e1993e5","user":{"login":"alecharp","id":985955,"avatar_url":"https://2.gravatar.com/avatar/8254814a3136a30724cd428841f8e155?d=https%3A%2F%2Fidenticons.github.com%2F7f9e3f01a1ab4c493e038f47ed722a8c.png&r=x","gravatar_id":"8254814a3136a30724cd428841f8e155","url":"https://api.github.com/users/alecharp","html_url":"https://github.com/alecharp","followers_url":"https://api.github.com/users/alecharp/followers","following_url":"https://api.github.com/users/alecharp/following{/other_user}","gists_url":"https://api.github.com/users/alecharp/gists{/gist_id}","starred_url":"https://api.github.com/users/alecharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alecharp/subscriptions","organizations_url":"https://api.github.com/users/alecharp/orgs","repos_url":"https://api.github.com/users/alecharp/repos","events_url":"https://api.github.com/users/alecharp/events{/privacy}","received_events_url":"https://api.github.com/users/alecharp/received_events","type":"User","site_admin":false},"body":"Thanks!\nI made the corrections.\nWe may need a release as the latest from 26th October doesn't have either\n the \"Status Changed\" trigger. What do you think?","created_at":"2013-12-11T15:43:19Z","updated_at":"2013-12-11T15:43:19Z","html_url":"https://github.com/jenkinsci/email-ext-plugin/pull/81#discussion_r8270394","pull_request_url":"https://api.github.com/repos/jenkinsci/email-ext-plugin/pulls/81","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/email-ext-plugin/pulls/comments/8270394"},"html":{"href":"https://github.com/jenkinsci/email-ext-plugin/pull/81#discussion_r8270394"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/email-ext-plugin/pulls/81"}}}} | {
"id": 1163553,
"name": "email-ext-plugin",
"url": "https://github.com/jenkinsci/email-ext-plugin"
} | {
"id": null,
"login": "alecharp",
"gravatar_id": "8254814a3136a30724cd428841f8e155",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "jenkinsci",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-11T15:43:19 | null | {"repository":{"description":"Jenkins email-ext plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Email-ext+plugin","watchers":73,"stargazers":73,"forks":118,"fork":false,"size":23007,"owner":"jenkinsci","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2010-12-12T21:35:01-08:00","pushed_at":"2013-12-05T07:56:41-08:00","master_branch":"master","organization":"jenkinsci"},"actor_attributes":{"type":"User","name":"Adrien Lecharpentier","company":"Zenika","blog":"http://blog.lecharpentier.org","location":"Paris, Fr","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/jenkinsci/email-ext-plugin/pull/81#discussion_r8270394"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/jenkinsci/email-ext-plugin/pulls/comments/3460367","id":3460367,"body":"I would like if this were optional somehow, rather than add a static dependency.","diff_hunk":"@@ -115,7 +115,12 @@\n <artifactId>groovy-sandbox</artifactId>\n <version>1.0</version>\n </dependency>\n- </dependencies> \n+ <dependency>\n+ <groupId>org.jsoup</groupId>\n+ <artifactId>jsoup</artifactId>\n+ <version>1.7.2</version>\n+ </dependency>","path":"pom.xml","position":9,"original_position":9,"commit_id":"68d65aae23a16860eaf7a70b48fd0470f52d6f1e","original_commit_id":"68d65aae23a16860eaf7a70b48fd0470f52d6f1e","user":{"login":"slide","id":55871,"avatar_url":"https://secure.gravatar.com/avatar/c1d5a49b51f1aa3df7aa8ee8fad45aca?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"c1d5a49b51f1aa3df7aa8ee8fad45aca","url":"https://api.github.com/users/slide","html_url":"https://github.com/slide","followers_url":"https://api.github.com/users/slide/followers","following_url":"https://api.github.com/users/slide/following","gists_url":"https://api.github.com/users/slide/gists{/gist_id}","starred_url":"https://api.github.com/users/slide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slide/subscriptions","organizations_url":"https://api.github.com/users/slide/orgs","repos_url":"https://api.github.com/users/slide/repos","events_url":"https://api.github.com/users/slide/events{/privacy}","received_events_url":"https://api.github.com/users/slide/received_events","type":"User"},"created_at":"2013-03-20T21:41:50Z","updated_at":"2013-03-20T21:41:50Z","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/email-ext-plugin/pulls/comments/3460367"},"html":{"href":"https://github.com/jenkinsci/email-ext-plugin/pull/60#discussion_r3460367"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/email-ext-plugin/pulls/60"}}}} | {
"id": 1163553,
"name": "email-ext-plugin",
"url": "https://github.com/jenkinsci/email-ext-plugin"
} | {
"id": null,
"login": "slide",
"gravatar_id": "c1d5a49b51f1aa3df7aa8ee8fad45aca",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "jenkinsci",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-20T21:41:50 | null | {"repository":{"description":"Jenkins email-ext plugin","homepage":"https://wiki.jenkins-ci.org/display/JENKINS/Email-ext+plugin","watchers":69,"stargazers":69,"forks":66,"fork":false,"size":688,"owner":"jenkinsci","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2010-12-12T21:35:01-08:00","pushed_at":"2013-03-18T07:52:47-07:00","master_branch":"master","organization":"jenkinsci"},"actor_attributes":{"type":"User","name":"Alex Earl","blog":"http://earl-of-code.com","location":"San Tan Valley, AZ","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/jenkinsci/email-ext-plugin/pull/60#discussion_r3460367"} |
PullRequestReviewCommentEvent | true | {"comment":{"commit_id":"3a6bbf65cfd88831ee0f722a92c77af9c7668f93","original_position":71,"user":{"events_url":"https://api.github.com/users/agramfort/events{/privacy}","gravatar_id":"e9758ca665b8c3d8cb3026c114d05833","gists_url":"https://api.github.com/users/agramfort/gists{/gist_id}","login":"agramfort","type":"User","organizations_url":"https://api.github.com/users/agramfort/orgs","id":161052,"received_events_url":"https://api.github.com/users/agramfort/received_events","subscriptions_url":"https://api.github.com/users/agramfort/subscriptions","followers_url":"https://api.github.com/users/agramfort/followers","url":"https://api.github.com/users/agramfort","following_url":"https://api.github.com/users/agramfort/following","avatar_url":"https://secure.gravatar.com/avatar/e9758ca665b8c3d8cb3026c114d05833?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","repos_url":"https://api.github.com/users/agramfort/repos","starred_url":"https://api.github.com/users/agramfort/starred{/owner}{/repo}"},"path":"mne/source_space.py","created_at":"2013-02-06T08:35:02Z","original_commit_id":"3a6bbf65cfd88831ee0f722a92c77af9c7668f93","id":2906550,"_links":{"html":{"href":"https://github.com/mne-tools/mne-python/pull/437#discussion_r2906550"},"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/2906550"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/437"}},"updated_at":"2013-02-06T08:35:02Z","position":71,"body":"scipy.linalg","url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/2906550"}} | {
"id": 1301584,
"name": "mne-python",
"url": "https://github.com/mne-tools/mne-python"
} | {
"id": null,
"login": "agramfort",
"gravatar_id": "e9758ca665b8c3d8cb3026c114d05833",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mne-tools",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-06T08:35:02 | null | {"repository":{"watchers":24,"owner":"mne-tools","homepage":"http://martinos.org/mne/","stargazers":24,"created_at":"2011-01-27T19:31:13-08:00","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","has_downloads":true,"open_issues":44,"language":"Python","fork":false,"size":1256,"organization":"mne-tools","private":false,"has_wiki":true,"pushed_at":"2013-02-05T09:25:08-08:00","forks":25,"has_issues":true},"actor_attributes":{"name":"Alexandre Gramfort","company":"Telecom ParisTech, CEA Neurospin, INRIA Parietal","type":"User","blog":"http://about.me/agramfort","location":"Paris, France","email":"[email protected]"},"url":"https://github.com/mne-tools/mne-python/pull/437#discussion_r2906550"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/4761271","id":4761271,"body":"yeah if there is a need for better documentation it might best fit where the traits are defined...","diff_hunk":"@@ -0,0 +1,810 @@\n+\"\"\"Traits-based GUI for head-MRI coregistration\"\"\"\n+\n+# Authors: Christian Brodbeck <[email protected]>\n+#\n+# License: BSD (3-clause)\n+\n+import os\n+from Queue import Queue\n+from threading import Thread\n+\n+import numpy as np\n+from numpy import dot\n+from scipy.spatial.distance import cdist\n+\n+from mayavi.core.ui.mayavi_scene import MayaviScene\n+from mayavi.tools.mlab_scene_model import MlabSceneModel\n+from pyface.api import error, confirm, warning, OK, YES, information, \\\n+ FileDialog\n+from traits.api import HasTraits, HasPrivateTraits, cached_property, \\\n+ on_trait_change, Instance, Property, Any, Array, Bool, \\\n+ Button, Directory, Enum, Float, Int, List, Str\n+from traitsui.api import View, Item, HGroup, VGroup, EnumEditor, TextEditor, \\\n+ Handler\n+from traitsui.menu import Action, UndoButton, CancelButton\n+from tvtk.pyface.scene_editor import SceneEditor\n+\n+from ..fiff import FIFF\n+from ..source_space import prepare_bem_model, setup_source_space\n+from ..transforms import write_trans\n+from ..transforms.transforms import rotation, translation, apply_trans\n+from ..transforms.coreg import trans_fname, fit_matched_pts, fit_point_cloud, \\\n+ scale_mri\n+from ..utils import get_subjects_dir\n+from .fiducials_gui import FiducialsPanel\n+from .file_traits import assert_env_set, BemSource, RawHspSource, \\\n+ SubjectSelector\n+from .viewer import HeadViewController, PointObject, SurfaceObject, \\\n+ headview_item\n+\n+\n+laggy_float_editor = TextEditor(auto_set=False, enter_set=True, evaluate=float)\n+\n+\n+class CoregFrameHandler(Handler):\n+ \"Handler to check for unfinished processes before closing the window\"\n+ def close(self, info, is_ok):\n+ if info.object.coreg.queue.unfinished_tasks:\n+ msg = (\"Can not close the window while saving is still in \"\n+ \"progress. Please wait until all MRIs are processed.\")\n+ title = \"Saving Still in Progress\"\n+ information(None, msg, title)\n+ return False\n+ else:\n+ return True\n+\n+\n+class CoregPanel(HasPrivateTraits):\n+ \"\"\"Traits object for estimating the head mri transform.\n+\n+ Notes\n+ -----\n+ Transform from head to mri space is modeled with the following steps:\n+\n+ * move the head shape to its nasion position\n+ * rotate the head shape with user defined rotation around its nasion\n+ * move the head shape by user defined translation\n+ * move the head shape origin to the mri nasion\n+\n+ If MRI scaling is enabled,\n+\n+ * the MRI is scaled relative to its origin center (prior to any\n+ transformation of the digitizer head)\n+ \"\"\"\n+ raw_dir = Str\n+ subject = Any(\"MRI subject name\")\n+ tgt_subject = Str(desc=\"subject for which the MRI will be scaled, \"\n+ \"inferred from raw file name\")\n+ subjects_dir = Str\n+\n+ # data source\n+ mri_pts = Array(shape=(None, 3))\n+ mri_fid = Array(shape=(3, 3))\n+ hsp_pts = Array(shape=(None, 3))\n+ hsp_fid = Array(shape=(3, 3))\n+ dig = List(desc=\"digitizer fiducials for info['dig']\")\n+\n+ # dependent\n+ src_pts = Property(depends_on=['hsp_pts', 'hsp_fid'], desc=\"hsp points \"\n+ \"moved to their nasion\")\n+ src_fid = Property(depends_on='hsp_fid')\n+ tgt_origin = Property(depends_on=['mri_fid', 'scale'])\n+ tgt_pts = Property(depends_on=['mri_pts', 'tgt_origin'], desc=\"mri_pts \"\n+ \"scaled and moved to their nasion\")\n+ tgt_fid = Property(depends_on=['tgt_origin'])\n+\n+ # parameters\n+ reset_params = Button(label='Reset')\n+ n_scale_params = Enum(0, 1, 3, desc=\"Scale the MRI to better fit the \"\n+ \"subject's head shape (a new MRI subject will be \"\n+ \"created with a name specified upon saving)\")\n+ scale3 = Array(float, (1, 3), [[1, 1, 1]], label='Scale by 3')\n+ scale1 = Float(1, label='Scale by 1')\n+ rotation = Array(float, (1, 3))\n+ translation = Array(float, (1, 3))\n+\n+ # transforms\n+ scale = Property(depends_on=['n_scale_params', 'scale3', 'scale1'])\n+ head_mri_trans = Property(depends_on=['tgt_origin', 'hsp_fid',\n+ 'translation', 'rotation', 'scale'])\n+\n+ # fitting\n+ has_fid_data = Property(Bool, depends_on=['mri_fid', 'hsp_fid'])\n+ has_pts_data = Property(Bool, depends_on=['mri_pts', 'hsp_pts'])\n+ # fitting with scaling\n+ fits_rot = Button(label='Fit Head Shape')\n+ fits_fid = Button(label='Fit Fiducials')\n+ fits_ap = Button(label='Fit LAP/RAP')\n+ # fitting without scaling\n+ fit_rot = Button(label='Fit Head Shape')\n+ fit_fid = Button(label='Fit Fiducials')\n+ fit_ap = Button(label='Fit LAP/RAP')\n+\n+ # saving\n+ can_save = Property(Bool, depends_on='dig')\n+ save = Button\n+ queue = Instance(Queue, ())\n+ queue_feedback = Str('')\n+ queue_current = Str('')\n+ queue_len = Int(0)\n+ queue_len_str = Property(Str, depends_on=['queue_len'])\n+ process_repr = Property(Str, depends_on=['queue_len', 'queue_current'])\n+\n+ # View Element\n+ axis_labels = Str(\"Right \\t\\tAnterior\\t\\tSuperior\")\n+\n+ view = View(VGroup(Item('n_scale_params', label='MRI Scaling',\n+ style='custom', show_label=True,\n+ editor=EnumEditor(values={0: '1:No Scaling',\n+ 1: '2:1 Param',\n+ 3: '3:3 Params'},\n+ cols=3)),\n+ Item('scale1', enabled_when='n_scale_params == 1',\n+ label=\"Scale (x1)\", show_label=True,\n+ editor=laggy_float_editor,\n+ tooltip=\"Scale along all axes with this factor\"),\n+ Item('scale3', enabled_when='n_scale_params == 3',\n+ label=\"Scale (x3)\", show_label=True,\n+ tooltip=\"Scaling along x (right), y (anterior) \"\n+ \"and z (superior) axes\"),\n+ HGroup(Item('fits_rot', enabled_when='n_scale_params',\n+ tooltip=\"Rotate the digitizer head shape \"\n+ \"and scale the MRI so as to minimize the \"\n+ \"distance from each digitizer point to the \"\n+ \"closest MRI point\"),\n+ Item('fits_ap',\n+ enabled_when='n_scale_params == 1',\n+ tooltip=\"While leaving the nasion in \"\n+ \"place, rotate the digitizer head shape \"\n+ \"and scale the MRI so as to minimize the \"\n+ \"distance of the two auricular points\"),\n+ Item('fits_fid',\n+ enabled_when='n_scale_params == 1',\n+ tooltip=\"Move and rotate the digitizer \"\n+ \"head shape, and scale the MRI so as to \"\n+ \"minimize the distance of the three \"\n+ \"fiducials.\"),\n+ show_labels=False),\n+ '_',\n+ Item('axis_labels', show_label=False, style='readonly'),\n+ Item('translation', show_label=True,\n+ tooltip=\"Movement into x (right), y (anterior) \"\n+ \"and z (superior) direction\"),\n+ Item('rotation', show_label=True,\n+ tooltip=\"Rotation around the right, anterior \"\n+ \"and superior axes\"),\n+ HGroup(Item('fit_rot', enabled_when='has_pts_data',\n+ tooltip=\"Rotate the head shape (around the \"\n+ \"nasion) so as to minimize the distance \"\n+ \"from each head shape point to its closest \"\n+ \"MRI point\"),\n+ Item('fit_ap', enabled_when='has_fid_data',\n+ tooltip=\"Try to match the LAP and the RAP, \"\n+ \"leaving the Nasion in place\"),\n+ Item('fit_fid', enabled_when='has_fid_data',\n+ tooltip=\"Move and rotate the head shape so \"\n+ \"as to minimize the distance between the \"\n+ \"MRI and head shape fiducials\"),\n+ show_labels=False),\n+ '_',\n+ HGroup(Item('save', enabled_when='can_save',\n+ tooltip=\"Save the trans file and (if \"\n+ \"scaling is enabled) the scaled MRI\"),\n+ Item('reset_params', tooltip=\"Reset all \"\n+ \"coregistration parameters\"),\n+ show_labels=False),\n+ Item('process_repr', style='readonly'),\n+ show_labels=False),\n+ kind='panel', buttons=[UndoButton])\n+\n+ def __init__(self, *args, **kwargs):\n+ super(CoregPanel, self).__init__(*args, **kwargs)\n+\n+ # setup save worker\n+ def worker():\n+ while True:\n+ desc, cmd, args, kwargs = self.queue.get()\n+\n+ self.queue_len -= 1\n+ self.queue_current = 'Processing: %s' % desc\n+\n+ # task\n+ try:\n+ cmd(*args, **kwargs)\n+ self.queue.task_done()\n+ except Exception as err:\n+ msg = str(err)\n+ error(None, msg, \"Error Scaling MRI\")\n+ res = \"Error in %s\"\n+ else:\n+ res = \"Done: %s\"\n+\n+ # finalize\n+ self.queue_current = ''\n+ self.queue_feedback = res % desc\n+ self.queue.task_done()\n+\n+ t = Thread(target=worker)\n+ t.daemon = True\n+ t.start()\n+\n+ @cached_property","path":"mne/gui/coreg_gui.py","position":231,"original_position":231,"commit_id":"1471dec9dce58c6ca8f6ab91a70c5409bc5f7941","original_commit_id":"1471dec9dce58c6ca8f6ab91a70c5409bc5f7941","user":{"login":"christianmbrodbeck","id":145771,"avatar_url":"https://secure.gravatar.com/avatar/e2965d97f2ecb5b43c3459bf3d09a383?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"e2965d97f2ecb5b43c3459bf3d09a383","url":"https://api.github.com/users/christianmbrodbeck","html_url":"https://github.com/christianmbrodbeck","followers_url":"https://api.github.com/users/christianmbrodbeck/followers","following_url":"https://api.github.com/users/christianmbrodbeck/following{/other_user}","gists_url":"https://api.github.com/users/christianmbrodbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/christianmbrodbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianmbrodbeck/subscriptions","organizations_url":"https://api.github.com/users/christianmbrodbeck/orgs","repos_url":"https://api.github.com/users/christianmbrodbeck/repos","events_url":"https://api.github.com/users/christianmbrodbeck/events{/privacy}","received_events_url":"https://api.github.com/users/christianmbrodbeck/received_events","type":"User"},"created_at":"2013-06-18T22:10:22Z","updated_at":"2013-06-18T22:10:22Z","html_url":"https://github.com/mne-tools/mne-python/pull/379#discussion_r4761271","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/379","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/4761271"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/379#discussion_r4761271"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/379"}}}} | {
"id": 1301584,
"name": "mne-python",
"url": "https://github.com/mne-tools/mne-python"
} | {
"id": null,
"login": "christianmbrodbeck",
"gravatar_id": "e2965d97f2ecb5b43c3459bf3d09a383",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mne-tools",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-18T22:10:22 | null | {"repository":{"description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","homepage":"http://martinos.org/mne/","watchers":38,"stargazers":38,"forks":38,"fork":false,"size":2112,"owner":"mne-tools","private":false,"open_issues":40,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-01-27T19:31:13-08:00","pushed_at":"2013-06-18T13:12:39-07:00","master_branch":"master","organization":"mne-tools"},"actor_attributes":{"type":"User","name":"Christian Brodbeck","company":"NYU","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mne-tools/mne-python/pull/379#discussion_r4761271"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/5052316","id":5052316,"body":"Hey, good morning! I now would have time to take a look. What's the current status of your branch? Does your local look like your remote which I see here?","diff_hunk":"@@ -0,0 +1,444 @@\n+# Authors: Christoph Dinh <[email protected]>\n+# Martin Luessi <[email protected]>\n+# Matti Hamalainen <[email protected]>\n+#\n+# License: BSD (3-clause)\n+import copy\n+import time\n+\n+import numpy as np\n+\n+import logging\n+logger = logging.getLogger('mne')\n+\n+from .. import verbose, fiff\n+from ..baseline import rescale\n+from ..epochs import _BaseEpochs\n+from ..event import _find_events\n+from ..filter import detrend\n+\n+\n+class RtEpochs(_BaseEpochs):\n+ \"\"\"Realtime Epochs\n+\n+ Can receive epochs in real time from an RtClient.\n+\n+ For example, to get some epochs from a running mne_rt_server on\n+ 'localhost', you could use:\n+\n+ client = mne.realtime.RtClient('localhost')\n+ event_id, tmin, tmax = 1, -0.2, 0.5\n+\n+ epochs = mne.realtime.RtEpochs(client, event_id, tmin, tmax, 5)\n+ epochs.start() # start the measurement and start receiving epochs\n+\n+ evoked_1 = epochs.average() # computed over epoch 1..5\n+ evoked_2 = epochs.average() # computed over epoch 6..10\n+\n+ By default, every epoch is only returned once. This behavior can be changed\n+ by using \"consume_epochs=False\", which means that epochs will be returned\n+ until they have manually been removed using \"remove_old_epochs\", e.g.:\n+\n+ epochs = mne.realtime.RtEpochs(client, event_id, tmin, tmax, 5,\n+ consume_epochs=False)\n+ epochs.start() # start the measurement and start receiving epochs\n+\n+ evoked_1 = epochs.average() # computed over epochs 1..5\n+ epochs.remove_old_epochs(1) # remove the oldest epoch\n+ evoked_2 = epochs.average() # computed over epochs 2..6\n+\n+ Parameters\n+ ----------\n+ client : instance of mne.realtime.RtClient\n+ The realtime client.\n+ event_id : int | list of int\n+ The id of the event to consider. If int, only events with the\n+ ID specified by event_id are considered. Multiple event ID's\n+ can be specified using a list.\n+ tmin : float\n+ Start time before event.\n+ tmax : float\n+ End time after event.\n+ n_epochs : int\n+ Number of epochs to return before iteration over epochs stops.\n+ consume_epochs : bool","path":"mne/realtime/epochs.py","position":64,"original_position":64,"commit_id":"78035e24d02057932592d43589608622aa65b368","original_commit_id":"78035e24d02057932592d43589608622aa65b368","user":{"login":"dengemann","id":1908618,"avatar_url":"https://secure.gravatar.com/avatar/6a4d7813e97a1152418809d9a2e67db9?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"6a4d7813e97a1152418809d9a2e67db9","url":"https://api.github.com/users/dengemann","html_url":"https://github.com/dengemann","followers_url":"https://api.github.com/users/dengemann/followers","following_url":"https://api.github.com/users/dengemann/following{/other_user}","gists_url":"https://api.github.com/users/dengemann/gists{/gist_id}","starred_url":"https://api.github.com/users/dengemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengemann/subscriptions","organizations_url":"https://api.github.com/users/dengemann/orgs","repos_url":"https://api.github.com/users/dengemann/repos","events_url":"https://api.github.com/users/dengemann/events{/privacy}","received_events_url":"https://api.github.com/users/dengemann/received_events","type":"User"},"created_at":"2013-07-06T07:55:53Z","updated_at":"2013-07-06T07:55:53Z","html_url":"https://github.com/mne-tools/mne-python/pull/615#discussion_r5052316","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/615","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/5052316"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/615#discussion_r5052316"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/615"}}}} | {
"id": 1301584,
"name": "mne-python",
"url": "https://github.com/mne-tools/mne-python"
} | {
"id": null,
"login": "dengemann",
"gravatar_id": "6a4d7813e97a1152418809d9a2e67db9",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mne-tools",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-06T07:55:53 | null | {"repository":{"description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","homepage":"http://martinos.org/mne/","watchers":38,"stargazers":38,"forks":39,"fork":false,"size":1640,"owner":"mne-tools","private":false,"open_issues":45,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-01-27T19:31:13-08:00","pushed_at":"2013-07-05T09:22:01-07:00","master_branch":"master","organization":"mne-tools"},"actor_attributes":{"type":"User","name":"Denis A. Engemann","company":"Juelich Research Centre","location":"Cologne, Germany","email":"[email protected]"},"url":"https://github.com/mne-tools/mne-python/pull/615#discussion_r5052316"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/montagejs/frb/pulls/comments/7738674","id":7738674,"diff_hunk":"@@ -234,6 +234,32 @@ function makeOnlyBinder(observeCollection) {\n };\n }\n \n+// collection.one() <- value\n+// empty the collection and set its one item to value\n+exports.makeOneBinder = makeOneBinder;\n+function makeOneBinder(observeCollection) {\n+ return function bindOne(observeValue, sourceScope, targetScope, descriptor, trace) {\n+ return observeCollection(autoCancelPrevious(function replaceCollection(collection) {\n+ if (!collection) return;\n+ return observeValue(autoCancelPrevious(function replaceOneValue(value) {\n+ if (value == null) return;\n+\n+ // FIXME: this is debatable. If set to its current value, do we clear the rest of the collection?\n+ // I err towards no, in part because this solves the case of two-way bindings, where we were always\n+ // clearing out the source collection. That could be solved other ways without this little quirk.","path":"binders.js","position":16,"original_position":16,"commit_id":"35a680fe3472f07f4e22f91239ec6cb76ceba68a","original_commit_id":"35a680fe3472f07f4e22f91239ec6cb76ceba68a","user":{"login":"asolove","id":8495,"avatar_url":"https://0.gravatar.com/avatar/646ce4739174937f99c0bedf20946875?d=https%3A%2F%2Fidenticons.github.com%2F3488330ba18d83e3d0ab177178ca66eb.png&r=x","gravatar_id":"646ce4739174937f99c0bedf20946875","url":"https://api.github.com/users/asolove","html_url":"https://github.com/asolove","followers_url":"https://api.github.com/users/asolove/followers","following_url":"https://api.github.com/users/asolove/following{/other_user}","gists_url":"https://api.github.com/users/asolove/gists{/gist_id}","starred_url":"https://api.github.com/users/asolove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asolove/subscriptions","organizations_url":"https://api.github.com/users/asolove/orgs","repos_url":"https://api.github.com/users/asolove/repos","events_url":"https://api.github.com/users/asolove/events{/privacy}","received_events_url":"https://api.github.com/users/asolove/received_events","type":"User","site_admin":false},"body":"I'm missing something. If you have a SortedSet two-way bound with its .one(), is there some way for the value returned by set.one() to change without the values in the set themselves changing? And if they change, then we will do the forward binding by calling one() to get the new value out of the set and arrive at a stable state?","created_at":"2013-11-18T21:02:47Z","updated_at":"2013-11-18T21:02:47Z","html_url":"https://github.com/montagejs/frb/pull/31#discussion_r7738674","pull_request_url":"https://api.github.com/repos/montagejs/frb/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/montagejs/frb/pulls/comments/7738674"},"html":{"href":"https://github.com/montagejs/frb/pull/31#discussion_r7738674"},"pull_request":{"href":"https://api.github.com/repos/montagejs/frb/pulls/31"}}}} | {
"id": 5907187,
"name": "frb",
"url": "https://github.com/montagejs/frb"
} | {
"id": null,
"login": "asolove",
"gravatar_id": "646ce4739174937f99c0bedf20946875",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "montagejs",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-18T21:02:47 | null | {"repository":{"description":"Functional Reactive Bindings (frb): A CommonJS package that includes functional and generic building blocks to help incrementally ensure consistent state.","homepage":"http://documentup.com/montagejs/frb/","watchers":60,"stargazers":60,"forks":9,"fork":false,"size":1271,"owner":"montagejs","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-09-21T13:45:36-07:00","pushed_at":"2013-11-05T15:10:28-08:00","master_branch":"master","organization":"montagejs"},"actor_attributes":{"type":"User","name":"Adam Solove","blog":"http://www.adamsolove.com/","location":"Washington, DC","email":"[email protected]"},"url":"https://github.com/montagejs/frb/pull/31#discussion_r7738674"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/comments/3239704","id":3239704,"body":"No it's ok. I did it when I merged your changes.","diff_hunk":"@@ -528,7 +527,6 @@ void Preferences::read()\n MScore::setHRaster(s.value(\"hraster\", MScore::hRaster()).toInt());\n MScore::setVRaster(s.value(\"vraster\", MScore::vRaster()).toInt());\n \n- nativeDialogs = s.value(\"nativeDialogs\", nativeDialogs).toBool();","path":"mscore/preferences.cpp","position":12,"original_position":12,"commit_id":"bc56e2ad7db4b00d5898ab618017d70c419cf5c7","original_commit_id":"bc56e2ad7db4b00d5898ab618017d70c419cf5c7","user":{"login":"lasconic","id":234271,"avatar_url":"https://secure.gravatar.com/avatar/13235ccd902ea667b2b4353eb74fc812?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"13235ccd902ea667b2b4353eb74fc812","url":"https://api.github.com/users/lasconic","html_url":"https://github.com/lasconic","followers_url":"https://api.github.com/users/lasconic/followers","following_url":"https://api.github.com/users/lasconic/following","gists_url":"https://api.github.com/users/lasconic/gists{/gist_id}","starred_url":"https://api.github.com/users/lasconic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasconic/subscriptions","organizations_url":"https://api.github.com/users/lasconic/orgs","repos_url":"https://api.github.com/users/lasconic/repos","events_url":"https://api.github.com/users/lasconic/events{/privacy}","received_events_url":"https://api.github.com/users/lasconic/received_events","type":"User"},"created_at":"2013-03-05T08:49:10Z","updated_at":"2013-03-05T08:49:10Z","_links":{"self":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/comments/3239704"},"html":{"href":"https://github.com/musescore/MuseScore/pull/240#discussion_r3239704"},"pull_request":{"href":"https://api.github.com/repos/musescore/MuseScore/pulls/240"}}}} | {
"id": 4454793,
"name": "MuseScore",
"url": "https://github.com/musescore/MuseScore"
} | {
"id": null,
"login": "lasconic",
"gravatar_id": "13235ccd902ea667b2b4353eb74fc812",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "musescore",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-05T08:49:10 | null | {"repository":{"description":"MuseScore is a open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!","homepage":"http://musescore.org","watchers":87,"stargazers":87,"forks":81,"fork":false,"size":1348,"owner":"musescore","private":false,"open_issues":13,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"C++","created_at":"2012-05-26T05:46:33-07:00","pushed_at":"2013-03-04T23:50:41-08:00","master_branch":"master","organization":"musescore"},"actor_attributes":{"type":"User","name":"Nicolas Froment","blog":"http://lasconic.com","location":"Toulouse, France","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/musescore/MuseScore/pull/240#discussion_r3239704"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/openshift/origin-server/pulls/comments/7897336","id":7897336,"diff_hunk":"@@ -282,6 +282,26 @@ def get_scaling_limits\n return min, max\n end\n \n+ def get_max_sessions_per_gear\n+ marker_dir = File.join(ENV['OPENSHIFT_REPO_DIR'], \".openshift/markers/\")\n+ sessions_file = File.join(marker_dir, \"max_sessions\")\n+ max_sessions = 20\n+ if File.exists? sessions_file\n+ sessions_data = File.read(sessions_file)\n+ begin\n+ if sessions_data.to_i <= 0\n+ @log.info(\"Unable to use negative or zero sessions! Using default...\")\n+ max_sessions = 20\n+ else \n+ max_sessions = sessions_data.to_i\n+ end\n+ rescue Exception => e\n+ @log.error(\"Unable to get gear's max sessions because of #{e.message}\")\n+ end\n+ end\n+ return max_sessions","path":"cartridges/openshift-origin-cartridge-haproxy/usr/bin/haproxy_ctld.rb","position":55,"original_position":55,"commit_id":"6f783650f20fe1834db1a52310466d29938cc81d","original_commit_id":"6f783650f20fe1834db1a52310466d29938cc81d","user":{"login":"mfojtik","id":44136,"avatar_url":"https://1.gravatar.com/avatar/2745f4559a5adff89b87db874b6cb10e?d=https%3A%2F%2Fidenticons.github.com%2F2fdef625a264874c1a4081ca24dd479d.png&r=x","gravatar_id":"2745f4559a5adff89b87db874b6cb10e","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"This return is not needed, as in Ruby the last statement in the block is always returned.... also the `max_sessions` variable is not needed at all :-)\r\n\r\n```\r\n\r\nMAX_SESSIONS = 20\r\n\r\ndef get_max_sessions_per_gear\r\n marker_dir = File.join(ENV['OPENSHIFT_REPO_DIR'], \".openshift/markers/\")\r\n max_sessions_marker = File.join(marker_dir, \"max_sessions\")\r\n return MAX_SESSIONS unless File.exists?(max_sessions_marker)\r\n max_sessions = File.read(max_sessions_marker).to_i rescue 0\r\n if max_sessions > 0\r\n max_sessions\r\n else\r\n @log.info \"The max_sessions value is invalid, defaulting to #{MAX_SESSIONS}\"\r\n MAX_SESSIONS\r\n end\r\nend\r\n```","created_at":"2013-11-25T17:18:58Z","updated_at":"2013-11-25T17:18:58Z","html_url":"https://github.com/openshift/origin-server/pull/4053#discussion_r7897336","pull_request_url":"https://api.github.com/repos/openshift/origin-server/pulls/4053","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-server/pulls/comments/7897336"},"html":{"href":"https://github.com/openshift/origin-server/pull/4053#discussion_r7897336"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin-server/pulls/4053"}}}} | {
"id": 4097634,
"name": "origin-server",
"url": "https://github.com/openshift/origin-server"
} | {
"id": null,
"login": "mfojtik",
"gravatar_id": "2745f4559a5adff89b87db874b6cb10e",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "openshift",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-25T17:18:58 | null | {"repository":{"description":"Public open source repository for the OpenShift Origin server components","homepage":"http://openshift.github.io","watchers":525,"stargazers":525,"forks":264,"fork":false,"size":100788,"owner":"openshift","private":false,"open_issues":58,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2012-04-21T09:43:10-07:00","pushed_at":"2013-11-25T08:53:17-08:00","master_branch":"master","organization":"openshift"},"actor_attributes":{"type":"User","name":"Michal Fojtik","company":"Red Hat, Inc","blog":"mifo.sk","location":"Brno, Czech republic","email":"[email protected]"},"url":"https://github.com/openshift/origin-server/pull/4053#discussion_r7897336"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/openshift/rhc/pulls/comments/3713823","id":3713823,"body":"This file is generated, so will fix common area.","diff_hunk":"@@ -0,0 +1,1199 @@\n+#\n+# This is the bash auto completion script for the rhc command\n+#\n+_rhc()\n+{\n+ local cur opts prev\n+ COMPREPLY=()\n+ cur=\"${COMP_WORDS[COMP_CWORD]}\"\n+ if [ $COMP_CWORD -eq 1 ]; then\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--clean --config --debug --insecure --mock --noprompt --password --rhlogin --server --ssl-ca-file --ssl-client-cert-file --ssl-version --timeout --token\"\n+ elif [ -z $cur ]; then\n+ opts=\"account alias alias-add alias-delete-cert alias-list alias-remove alias-update-cert app app-create app-delete app-force-stop app-reload app-restart app-show app-ssh app-start app-stop app-tidy apps authorization authorization-add authorization-delete authorization-delete-all cartridge cartridge-add cartridge-list cartridge-reload cartridge-remove cartridge-restart cartridge-scale cartridge-show cartridge-start cartridge-status cartridge-stop cartridge-storage domain domain-create domain-delete domain-show domain-update git-clone logout port-forward server setup snapshot snapshot-restore snapshot-save sshkey sshkey-add sshkey-list sshkey-remove sshkey-show tail threaddump\"\n+ else\n+ opts=\"account account-logout add-alias add-authorization add-cartridge add-sshkey alias alias-add alias-delete-cert alias-list alias-remove alias-update-cert app app-create app-delete app-force-stop app-reload app-restart app-show app-snapshot app-ssh app-start app-stop app-tidy apps authorization authorization-add authorization-delete authorization-delete-all authorizations cartridge cartridge-add cartridge-list cartridge-reload cartridge-remove cartridge-restart cartridge-scale cartridge-show cartridge-start cartridge-status cartridge-stop cartridge-storage cartridges create-app create-domain delete-all-authorization delete-app delete-authorization delete-cert-alias delete-domain domain domain-alter domain-create domain-delete domain-destroy domain-show domain-update force-stop-app git-clone list-alias list-cartridge list-sshkey logout port-forward reload-app reload-cartridge remove-alias remove-cartridge remove-sshkey restart-app restart-cartridge restore-snapshot save-snapshot scale-cartridge server setup show-app show-cartridge show-domain show-sshkey snapshot snapshot-restore snapshot-save ssh ssh-app sshkey sshkey-add sshkey-delete sshkey-list sshkey-remove sshkey-show start-app start-cartridge status-cartridge stop-app stop-cartridge storage-cartridge tail threaddump tidy-app update-cert-alias update-domain\"\n+ fi\n+ else\n+ prev=\"${COMP_WORDS[@]:0:COMP_CWORD}\"\n+ SAVE_IFS=$IFS\n+ IFS=\" \"\n+ case \"${prev[*]}\" in\n+\n+ \"rhc account\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc account logout\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--all\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc account-logout\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--all\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc add-alias\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc add-authorization\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--expires-in --note --scopes\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc add-cartridge\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc add-sshkey\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--confirm\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc alias\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"add remove update-cert delete-cert list\"\n+ fi\n+ ;;\n+\n+ \"rhc alias add\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc alias delete-cert\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --confirm --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc alias list\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc alias remove\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc alias update-cert\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --certificate --namespace --passphrase --private-key\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc alias-add\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc alias-delete-cert\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --confirm --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc alias-list\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc alias-remove\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc alias-update-cert\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --certificate --namespace --passphrase --private-key\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"create delete start stop force-stop restart reload tidy show ssh\"\n+ fi\n+ ;;\n+\n+ \"rhc app create\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--[no-]dns --[no-]git --app --enable-jenkins --from-code --gear-size --namespace --nogit --repo --scaling --type\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app delete\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --bypass --confirm --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app force-stop\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app reload\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app restart\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app show\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --gears --namespace --state\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app snapshot\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app ssh\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace --ssh\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app start\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app stop\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app tidy\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app-create\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--[no-]dns --[no-]git --app --enable-jenkins --from-code --gear-size --namespace --nogit --repo --scaling --type\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app-delete\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --bypass --confirm --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app-force-stop\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app-reload\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app-restart\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app-show\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --gears --namespace --state\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app-snapshot\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app-ssh\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace --ssh\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app-start\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app-stop\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc app-tidy\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc apps\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc authorization\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"add delete delete-all\"\n+ fi\n+ ;;\n+\n+ \"rhc authorization add\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--expires-in --note --scopes\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc authorization delete\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--auth-token\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc authorization delete-all\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc authorization-add\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--expires-in --note --scopes\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc authorization-delete\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--auth-token\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc authorization-delete-all\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc authorizations\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"list add show remove start stop restart status reload scale storage\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge add\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge list\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--verbose\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge reload\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge remove\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --confirm --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge restart\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge scale\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --max --min --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge show\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge start\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge status\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge stop\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge storage\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--add --app --cartridge --force --namespace --remove --set --show\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge-add\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge-list\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--verbose\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge-reload\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge-remove\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --confirm --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge-restart\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge-scale\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --max --min --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge-show\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge-start\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge-status\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge-stop\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridge-storage\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--add --app --cartridge --force --namespace --remove --set --show\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc cartridges\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--verbose\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc create-app\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--[no-]dns --[no-]git --app --enable-jenkins --from-code --gear-size --namespace --nogit --repo --scaling --type\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc create-domain\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc delete-all-authorization\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc delete-app\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --bypass --confirm --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc delete-authorization\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--auth-token\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc delete-cert-alias\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --confirm --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc delete-domain\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc domain\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"create alter update show destroy delete\"\n+ fi\n+ ;;\n+\n+ \"rhc domain alter\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc domain create\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc domain delete\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc domain destroy\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc domain show\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc domain update\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc domain-alter\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc domain-create\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc domain-delete\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc domain-destroy\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc domain-show\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc domain-update\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc force-stop-app\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc git-clone\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace --repo\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc list-alias\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc list-cartridge\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--verbose\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc list-sshkey\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc logout\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--all\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc port-forward\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc reload-app\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc reload-cartridge\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc remove-alias\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc remove-cartridge\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --confirm --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc remove-sshkey\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc restart-app\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc restart-cartridge\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc restore-snapshot\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --filepath --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc save-snapshot\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --filepath --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc scale-cartridge\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--app --cartridge --max --min --namespace\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc server\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"\"\n+ else\n+ opts=\"\"\n+ fi\n+ ;;\n+\n+ \"rhc setup\")\n+ if [[ \"$cur\" == -* ]]; then\n+ opts=\"--[no-]create-token --autocomplete --clean --server\"","path":"autocomplete/rhc_bash","position":921,"original_position":921,"commit_id":"6d0eceada7258f2eb7775ad1de738a6446ef200b","original_commit_id":"6d0eceada7258f2eb7775ad1de738a6446ef200b","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://secure.gravatar.com/avatar/df83d905f402066ed435c8b3550573eb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"df83d905f402066ed435c8b3550573eb","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User"},"created_at":"2013-04-09T14:02:22Z","updated_at":"2013-04-09T14:02:22Z","html_url":"https://github.com/openshift/rhc/pull/352#discussion_r3713823","pull_request_url":"https://api.github.com/repos/openshift/rhc/pulls/352","_links":{"self":{"href":"https://api.github.com/repos/openshift/rhc/pulls/comments/3713823"},"html":{"href":"https://github.com/openshift/rhc/pull/352#discussion_r3713823"},"pull_request":{"href":"https://api.github.com/repos/openshift/rhc/pulls/352"}}}} | {
"id": 2073976,
"name": "rhc",
"url": "https://github.com/openshift/rhc"
} | {
"id": null,
"login": "smarterclayton",
"gravatar_id": "df83d905f402066ed435c8b3550573eb",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "openshift",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-09T14:02:22 | null | {"repository":{"description":"Public open source repository for the Red Hat OpenShift client tools and the 'rhc' gem.","homepage":"http://openshift.redhat.com/","watchers":134,"stargazers":134,"forks":60,"fork":false,"size":932,"owner":"openshift","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2011-07-19T12:17:52-07:00","pushed_at":"2013-04-08T13:44:44-07:00","master_branch":"master","organization":"openshift"},"actor_attributes":{"type":"User","name":"Clayton Coleman","company":"Red Hat","location":"North Carolina","email":"[email protected]"},"url":"https://github.com/openshift/rhc/pull/352#discussion_r3713823"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/railsware/js-routes/pulls/comments/3408567","id":3408567,"body":"Same stars here. Remove plz.","diff_hunk":"@@ -0,0 +1,134 @@\n+ParameterMissing = (@message) -> #\n+ParameterMissing:: = new Error()\n+defaults =\n+ prefix: \"PREFIX\"\n+ default_url_options: DEFAULT_URL_OPTIONS\n+\n+NodeTypes = NODE_TYPES\n+Utils =\n+ serialize: (obj) ->\n+ return \"\" unless obj\n+ if window.jQuery\n+ result = window.jQuery.param(obj)\n+ return (if not result then \"\" else \"?#{result}\")\n+ s = []\n+ for own key, prop of obj\n+ if prop?\n+ if prop instanceof Array\n+ for val, i in prop\n+ s.push \"#{key}#{encodeURIComponent(\"[]\")}=#{encodeURIComponent(val.toString())}\"\n+ else\n+ s.push \"#{key}=#{encodeURIComponent(prop.toString())}\"\n+ return \"\" unless s.length\n+ \"?#{s.join(\"&\")}\"\n+\n+ clean_path: (path) ->\n+ path = path.split(\"://\")\n+ last_index = path.length - 1\n+ path[last_index] = path[last_index].replace(/\\/+/g, \"/\").replace(/\\/$/m, \"\")\n+ path.join \"://\"\n+\n+ set_default_url_options: (optional_parts, options) ->\n+ for part, i in optional_parts\n+ options[part] = defaults.default_url_options[part] if not options.hasOwnProperty(part) and defaults.default_url_options.hasOwnProperty(part)\n+\n+ extract_anchor: (options) ->\n+ anchor = (if options.hasOwnProperty(\"anchor\") then options.anchor else null)\n+ options.anchor = null\n+ (if anchor then \"##{anchor}\" else \"\")\n+\n+ extract_options: (number_of_params, args) ->\n+ if args.length > number_of_params\n+ (if typeof (args[args.length - 1]) is \"object\" then args.pop() else {})\n+ else\n+ {}\n+\n+ path_identifier: (object) ->\n+ return \"0\" if object is 0\n+ # null, undefined, false or ''\n+ return \"\" unless object\n+ if typeof (object) is \"object\"\n+ property = object.to_param or object.id or object\n+ property = property.call(object) if typeof (property) is \"function\"\n+ property.toString()\n+ else\n+ object.toString()\n+\n+ clone: (obj) ->\n+ return obj if null is obj or \"object\" isnt typeof obj\n+ copy = obj.constructor()\n+ copy[key] = attr for own key, attr of obj\n+ copy\n+\n+ prepare_parameters: (required_parameters, actual_parameters, options) ->\n+ result = @clone(options) or {}\n+ result[val] = actual_parameters[i] for val, i in required_parameters\n+ result\n+\n+ build_path: (required_parameters, optional_parts, route, args) ->\n+ args = Array::slice.call(args)\n+ opts = @extract_options(required_parameters.length, args)\n+ throw new Error(\"Too many parameters provided for path\") if args.length > required_parameters.length\n+ parameters = @prepare_parameters(required_parameters, args, opts)\n+ @set_default_url_options optional_parts, parameters\n+ result = Utils.get_prefix()\n+ anchor = Utils.extract_anchor(parameters)\n+ result += @visit(route, parameters)\n+ Utils.clean_path(result + anchor) + Utils.serialize(parameters)\n+ #\n+ # * This function is JavaScript impelementation of the\n+ # * Journey::Visitors::Formatter that builds route by given parameters\n+ # * from route binary tree.\n+ # * Binary tree is serialized in the following way:\n+ # * [node type, left node, right node ]\n+ # *\n+ # * @param {Boolean} optional Marks the currently visited branch as optional.\n+ # * If set to `true`, this method will not throw when encountering\n+ # * a missing parameter (used in recursive calls).\n+ #\n+ visit: (route, parameters, optional) ->\n+ [type, left, right] = route\n+ switch type\n+ when NodeTypes.GROUP\n+ @visit left, parameters, true\n+ when NodeTypes.STAR\n+ @visit left, parameters, true\n+ when NodeTypes.CAT\n+ leftPart = @visit(left, parameters, optional)\n+ rightPart = @visit(right, parameters, optional)\n+ return \"\" if optional and not (leftPart and rightPart)\n+ \"#{leftPart}#{rightPart}\"\n+ when NodeTypes.LITERAL, NodeTypes.SLASH, NodeTypes.DOT\n+ left\n+ when NodeTypes.SYMBOL\n+ value = parameters[left]\n+ if value?\n+ parameters[left] = null\n+ return @path_identifier(value)\n+ if optional\n+ \"\" # missing parameter\n+ else\n+ throw new ParameterMissing(\"Route parameter missing: #{left}\")\n+ #\n+ # * I don't know what is this node type\n+ # * Please send your PR if you do\n+ #","path":"lib/routes.js.coffee","position":115,"original_position":115,"commit_id":"cba96b84cb8318e7fe370a64d55ee3b9cba639c7","original_commit_id":"cba96b84cb8318e7fe370a64d55ee3b9cba639c7","user":{"login":"bogdan","id":122436,"avatar_url":"https://secure.gravatar.com/avatar/91913f6ab8085bab0f2aa43995ba8ca2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"91913f6ab8085bab0f2aa43995ba8ca2","url":"https://api.github.com/users/bogdan","html_url":"https://github.com/bogdan","followers_url":"https://api.github.com/users/bogdan/followers","following_url":"https://api.github.com/users/bogdan/following","gists_url":"https://api.github.com/users/bogdan/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdan/subscriptions","organizations_url":"https://api.github.com/users/bogdan/orgs","repos_url":"https://api.github.com/users/bogdan/repos","events_url":"https://api.github.com/users/bogdan/events{/privacy}","received_events_url":"https://api.github.com/users/bogdan/received_events","type":"User"},"created_at":"2013-03-18T08:16:23Z","updated_at":"2013-03-18T08:16:23Z","html_url":"https://github.com/railsware/js-routes/pull/64#discussion_r3408567","pull_request_url":"https://api.github.com/repos/railsware/js-routes/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/railsware/js-routes/pulls/comments/3408567"},"html":{"href":"https://github.com/railsware/js-routes/pull/64#discussion_r3408567"},"pull_request":{"href":"https://api.github.com/repos/railsware/js-routes/pulls/64"}}}} | {
"id": 2149005,
"name": "js-routes",
"url": "https://github.com/railsware/js-routes"
} | {
"id": null,
"login": "bogdan",
"gravatar_id": "91913f6ab8085bab0f2aa43995ba8ca2",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "railsware",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-18T08:16:23 | null | {"repository":{"description":"Brings Rails named routes to javascript","homepage":"","watchers":319,"stargazers":319,"forks":35,"fork":false,"size":192,"owner":"railsware","private":false,"open_issues":5,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2011-08-03T07:53:48-07:00","pushed_at":"2013-02-13T02:11:47-08:00","master_branch":"master","organization":"railsware"},"actor_attributes":{"type":"User","name":"Bogdan Gusiev","company":"Curebit","blog":"http://gusiev.com","location":"Kiev, Ukraine","email":"[email protected]"},"url":"https://github.com/railsware/js-routes/pull/64#discussion_r3408567"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/6222379","id":6222379,"body":"Awesome, sounds good to me!","diff_hunk":"@@ -121,3 +121,85 @@ def remove(name, path):\n ).format(name)\n \n return ret\n+\n+\n+def auto(name):","path":"salt/states/alternatives.py","position":6,"original_position":6,"commit_id":"62bc594d005dc2498254367f4fa53596654b9357","original_commit_id":"62bc594d005dc2498254367f4fa53596654b9357","user":{"login":"techhat","id":287147,"avatar_url":"https://0.gravatar.com/avatar/fc2a3fc8175e74ff156c3bde240f9267?d=https%3A%2F%2Fidenticons.github.com%2Fbde9e6e5bfc27f2b0468294d6de90b61.png","gravatar_id":"fc2a3fc8175e74ff156c3bde240f9267","url":"https://api.github.com/users/techhat","html_url":"https://github.com/techhat","followers_url":"https://api.github.com/users/techhat/followers","following_url":"https://api.github.com/users/techhat/following{/other_user}","gists_url":"https://api.github.com/users/techhat/gists{/gist_id}","starred_url":"https://api.github.com/users/techhat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techhat/subscriptions","organizations_url":"https://api.github.com/users/techhat/orgs","repos_url":"https://api.github.com/users/techhat/repos","events_url":"https://api.github.com/users/techhat/events{/privacy}","received_events_url":"https://api.github.com/users/techhat/received_events","type":"User"},"created_at":"2013-09-06T23:33:05Z","updated_at":"2013-09-06T23:33:05Z","html_url":"https://github.com/saltstack/salt/pull/7107#discussion_r6222379","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/7107","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/6222379"},"html":{"href":"https://github.com/saltstack/salt/pull/7107#discussion_r6222379"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/7107"}}}} | {
"id": 1390248,
"name": "salt",
"url": "https://github.com/saltstack/salt"
} | {
"id": null,
"login": "techhat",
"gravatar_id": "fc2a3fc8175e74ff156c3bde240f9267",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "saltstack",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-06T23:33:05 | null | {"repository":{"description":"Central system and configuration manager ","homepage":"saltstack.org","watchers":2168,"stargazers":2168,"forks":767,"fork":false,"size":17464,"owner":"saltstack","private":false,"open_issues":165,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-02-20T12:16:56-08:00","pushed_at":"2013-09-06T13:40:47-07:00","master_branch":"develop","organization":"saltstack"},"actor_attributes":{"type":"User","name":"Joseph Hall","company":"Salt Stack, Inc.","blog":"http://www.saltstack.com/","location":"Salt Lake City, UT","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/saltstack/salt/pull/7107#discussion_r6222379"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/scala-ide/scala-ide/pulls/comments/6261483","id":6261483,"body":"I believe it would be better to guard access to ``_sourceFile`` with a different lock than the ``ScalaCompilationUnit`` instance lock. My reasons are:\r\n\r\n1) Granularity\r\n2) Avoiding deadlocks\r\n3) Encapsulation ","diff_hunk":"@@ -72,7 +72,19 @@ trait ScalaCompilationUnit extends Openable\n \n val file : AbstractFile\n \n- override def sourceFile(contents: Array[Char]): SourceFile = new BatchSourceFile(file, contents)\n+ override def sourceFile(contents: Array[Char]): SourceFile = synchronized {\n+ _sourceFile = new BatchSourceFile(file, contents)\n+ _sourceFile\n+ }\n+\n+ private var _sourceFile: SourceFile = _\n+\n+ /** Return the most recent source file, or a fresh one based on the underlying file contents. */\n+ override def sourceFile(): SourceFile = synchronized {","path":"org.scala-ide.sdt.core/src/scala/tools/eclipse/javaelements/ScalaCompilationUnit.scala","position":13,"original_position":13,"commit_id":"b45c5d10d82be9c7142fe5ff7b22c4abaa73ede2","original_commit_id":"b45c5d10d82be9c7142fe5ff7b22c4abaa73ede2","user":{"login":"dotta","id":703748,"avatar_url":"https://0.gravatar.com/avatar/a20e94bcdbd6613506c752e72209b584?d=https%3A%2F%2Fidenticons.github.com%2Fc2f90c1e30045a340972006bd3b02742.png","gravatar_id":"a20e94bcdbd6613506c752e72209b584","url":"https://api.github.com/users/dotta","html_url":"https://github.com/dotta","followers_url":"https://api.github.com/users/dotta/followers","following_url":"https://api.github.com/users/dotta/following{/other_user}","gists_url":"https://api.github.com/users/dotta/gists{/gist_id}","starred_url":"https://api.github.com/users/dotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotta/subscriptions","organizations_url":"https://api.github.com/users/dotta/orgs","repos_url":"https://api.github.com/users/dotta/repos","events_url":"https://api.github.com/users/dotta/events{/privacy}","received_events_url":"https://api.github.com/users/dotta/received_events","type":"User"},"created_at":"2013-09-10T10:03:29Z","updated_at":"2013-09-10T10:03:29Z","html_url":"https://github.com/scala-ide/scala-ide/pull/516#discussion_r6261483","pull_request_url":"https://api.github.com/repos/scala-ide/scala-ide/pulls/516","_links":{"self":{"href":"https://api.github.com/repos/scala-ide/scala-ide/pulls/comments/6261483"},"html":{"href":"https://github.com/scala-ide/scala-ide/pull/516#discussion_r6261483"},"pull_request":{"href":"https://api.github.com/repos/scala-ide/scala-ide/pulls/516"}}}} | {
"id": 2510011,
"name": "scala-ide",
"url": "https://github.com/scala-ide/scala-ide"
} | {
"id": null,
"login": "dotta",
"gravatar_id": "a20e94bcdbd6613506c752e72209b584",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "scala-ide",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-10T10:03:29 | null | {"repository":{"description":"Scala IDE for Eclipse","homepage":"www.scala-ide.org","watchers":298,"stargazers":298,"forks":127,"fork":false,"size":148484,"owner":"scala-ide","private":false,"open_issues":2,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Scala","created_at":"2011-10-03T22:56:23-07:00","pushed_at":"2013-09-10T00:57:05-07:00","master_branch":"master","organization":"scala-ide"},"actor_attributes":{"type":"User","name":"Mirco Dotta","company":"Typesafe","location":"Lausanne","email":"[email protected]"},"url":"https://github.com/scala-ide/scala-ide/pull/516#discussion_r6261483"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/scala-ide/scala-ide.github.com/pulls/comments/6235342","id":6235342,"body":"spurious linebreak ?","diff_hunk":"@@ -0,0 +1,81 @@\n+---\n+layout: blog\n+title: Scala IDE 3.0.2-RC2 release\n+author: Scala IDE team\n+disqus: false\n+---\n+\n+We are very happy to announce the simultaneous release of three products today:\n+\n+* The first release candidate of the 3.0.2 maintenance release for Scala IDE, based on the\n+fresh Scala 2.10.3-RC2 release.\n+* A new Scala Search 0.2.0 release, with Type Hierarchy support!\n+* And a bugfix release of the Play plugin, v0.4.1.\n+\n+*All releases are available only for Eclipse 4.x (i.e., Juno and Kepler). Support for Eclipse\n+3.x is discontinued.*\n+\n+## Scala IDE 3.0.2-RC1\n+\n+Besides upgrading to the freshly announced Scala 2.10.3-RC2, the great news is that with\n+this release we officially start support for Eclipse 4.x. Therefore, the old Eclipse 3.x\n+platform is abandoned.\n+\n+But that’s not it, of course this maintenance release comes with a few more goodies:\n+\n+* Updated the build compiler to use the recently released sbt 0.13.0 (which, among others,\n+includes an important fix for correctly handling build cancellation, see [sbt pr #812](https://github.com/sbt/sbt/pull/821))\n+* Semantic highlighting now works also on source attachments [#1000939](https://www.assembla.com/spaces/scala-ide/tickets/1000939).\n+* Fixed a race-condition that can lead to “Resource XXX does not exist.” errors (see [#1001846](https://www.assembla.com/spaces/scala-ide/tickets/1001846) for details)\n+\n+For the complete list of fixes, please see our [changelog][changelog].\n+\n+## Scala Search 0.2.0\n+\n+Scala Search aims to extend the IDE with a range of search-related features that focus on\n+improving code navigation and hence aid developers better understanding Scala code.\n+\n+In its first release, it provided [support for Find Occurrences for members (vals, vars and methods)](http://scala-ide.org/blog/release-notes-3.0.1-RC01.html#scala_search).\n+The spotlight of this new release is Type Hierarchy support, allowing you to easily visualize the\n+inheritance relations existing among types. Read the [documentation](http://scala-ide.org/docs/current-user-doc/features/navigating/type-hierarchy.html)","path":"blog/_posts/2013-09-06-release-notes-3.0.2-RC01.md","position":40,"original_position":40,"commit_id":"2a5f48f07f69601124c18f93ab06c9658f7ddc26","original_commit_id":"2a5f48f07f69601124c18f93ab06c9658f7ddc26","user":{"login":"huitseeker","id":4142,"avatar_url":"https://1.gravatar.com/avatar/dc11aab8ab70b10a828b5ee4735183e8?d=https%3A%2F%2Fidenticons.github.com%2F0777acff7c9ab34562699e4e1d05affb.png","gravatar_id":"dc11aab8ab70b10a828b5ee4735183e8","url":"https://api.github.com/users/huitseeker","html_url":"https://github.com/huitseeker","followers_url":"https://api.github.com/users/huitseeker/followers","following_url":"https://api.github.com/users/huitseeker/following{/other_user}","gists_url":"https://api.github.com/users/huitseeker/gists{/gist_id}","starred_url":"https://api.github.com/users/huitseeker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huitseeker/subscriptions","organizations_url":"https://api.github.com/users/huitseeker/orgs","repos_url":"https://api.github.com/users/huitseeker/repos","events_url":"https://api.github.com/users/huitseeker/events{/privacy}","received_events_url":"https://api.github.com/users/huitseeker/received_events","type":"User"},"created_at":"2013-09-09T11:30:07Z","updated_at":"2013-09-09T11:30:07Z","html_url":"https://github.com/scala-ide/scala-ide.github.com/pull/40#discussion_r6235342","pull_request_url":"https://api.github.com/repos/scala-ide/scala-ide.github.com/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/scala-ide/scala-ide.github.com/pulls/comments/6235342"},"html":{"href":"https://github.com/scala-ide/scala-ide.github.com/pull/40#discussion_r6235342"},"pull_request":{"href":"https://api.github.com/repos/scala-ide/scala-ide.github.com/pulls/40"}}}} | {
"id": 2850781,
"name": "scala-ide.github.com",
"url": "https://github.com/scala-ide/scala-ide.github.com"
} | {
"id": null,
"login": "huitseeker",
"gravatar_id": "dc11aab8ab70b10a828b5ee4735183e8",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "scala-ide",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-09T11:30:07 | null | {"repository":{"description":"","homepage":"","watchers":7,"stargazers":7,"forks":8,"fork":false,"size":408,"owner":"scala-ide","private":false,"open_issues":7,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-11-25T08:27:42-08:00","pushed_at":"2013-09-05T00:46:11-07:00","master_branch":"master","organization":"scala-ide"},"actor_attributes":{"type":"User","name":"François Garillot","blog":"","location":"Lausanne, Switzerland","email":"[email protected]"},"url":"https://github.com/scala-ide/scala-ide.github.com/pull/40#discussion_r6235342"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/scieloorg/balaio/pulls/comments/4637762","id":4637762,"body":"Não precisa.. estou ajustando conforme reviso.\r\n\r\n\r\nOn Tue, Jun 11, 2013 at 1:26 PM, Jamil Atta Junior <[email protected]\r\n> wrote:\r\n\r\n> In balaio/checkin.py:\r\n>\r\n> > @@ -137,6 +141,9 @@ def restore_perms(self):\r\n> > os.chmod(self._filename, self._default_perms)\r\n> > self.is_locked = False\r\n> >\r\n> > + def rename_package(self, prefix='__failed__'):\r\n> > + os.rename(self._filename, prefix + self._filename)\r\n>\r\n> Vou realizar esse ajuste.\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub<https://github.com/scieloorg/balaio/pull/27/files#r4637542>\r\n> .\r\n>","diff_hunk":"@@ -137,6 +141,9 @@ def restore_perms(self):\n os.chmod(self._filename, self._default_perms)\n self.is_locked = False\n \n+ def rename_package(self, prefix='__failed__'):\n+ os.rename(self._filename, prefix + self._filename)","path":"balaio/checkin.py","position":55,"original_position":55,"commit_id":"2b76505aefe31015a95df34866ded4b915384863","original_commit_id":"2b76505aefe31015a95df34866ded4b915384863","user":{"login":"gustavofonseca","id":161335,"avatar_url":"https://secure.gravatar.com/avatar/8b09d1fd6b426a5873362967360612cb?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"8b09d1fd6b426a5873362967360612cb","url":"https://api.github.com/users/gustavofonseca","html_url":"https://github.com/gustavofonseca","followers_url":"https://api.github.com/users/gustavofonseca/followers","following_url":"https://api.github.com/users/gustavofonseca/following{/other_user}","gists_url":"https://api.github.com/users/gustavofonseca/gists{/gist_id}","starred_url":"https://api.github.com/users/gustavofonseca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gustavofonseca/subscriptions","organizations_url":"https://api.github.com/users/gustavofonseca/orgs","repos_url":"https://api.github.com/users/gustavofonseca/repos","events_url":"https://api.github.com/users/gustavofonseca/events{/privacy}","received_events_url":"https://api.github.com/users/gustavofonseca/received_events","type":"User"},"created_at":"2013-06-11T16:36:46Z","updated_at":"2013-06-11T16:36:46Z","html_url":"https://github.com/scieloorg/balaio/pull/27#discussion_r4637762","pull_request_url":"https://api.github.com/repos/scieloorg/balaio/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/scieloorg/balaio/pulls/comments/4637762"},"html":{"href":"https://github.com/scieloorg/balaio/pull/27#discussion_r4637762"},"pull_request":{"href":"https://api.github.com/repos/scieloorg/balaio/pulls/27"}}}} | {
"id": 9944156,
"name": "balaio",
"url": "https://github.com/scieloorg/balaio"
} | {
"id": null,
"login": "gustavofonseca",
"gravatar_id": "8b09d1fd6b426a5873362967360612cb",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "scieloorg",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-11T16:36:46 | null | {"repository":{"description":"Ferramenta para triagem e publicação de pacotes de submissão de artigos para o SciELO.","watchers":0,"stargazers":0,"forks":2,"fork":false,"size":196,"owner":"scieloorg","private":false,"open_issues":14,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2013-05-08T12:28:03-07:00","pushed_at":"2013-06-07T07:34:26-07:00","master_branch":"master","organization":"scieloorg"},"actor_attributes":{"type":"User","name":"Gustavo Fonseca","company":"SciELO ","blog":"http://gusfonseca.wordpress.com","location":"São Paulo","email":"[email protected]"},"url":"https://github.com/scieloorg/balaio/pull/27#discussion_r4637762"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/spilgames/glue/pulls/comments/8584615","id":8584615,"diff_hunk":"@@ -0,0 +1,52 @@\n+/*\n+ * @module Rotatable\n+ * @namespace component\n+ * @desc Represents a rotatable component\n+ * @copyright (C) 2013 SpilGames\n+ * @author Felipe Alfonso\n+ * @license BSD 3-Clause License (see LICENSE file in project root)\n+ *\n+ * Only when performance issues: Remove the need for getters and setters in visible\n+ */\n+glue.module.create(\n+ 'glue/component/rotatable',\n+ [\n+ 'glue',\n+ 'glue/math/vector'\n+ ],\n+ function (Glue, Vector) {\n+ return function (obj) {\n+ var angle = 0,\n+ handle = Vector(0, 0);\n+ obj = obj || {};\n+ obj.rotatable = {\n+ draw: function (deltaT, context) {\n+ context.translate(handle.x, handle.y);\n+ context.rotate(angle);\n+ context.translate(-handle.x, -handle.y);\n+ },\n+ setAngleDegree: function (value) {\n+ angle = value && !isNaN(value) ? value : angle;\n+ angle *= Math.PI / 180;\n+ },\n+ setAngleRadian: function (value) {\n+ angle = !isNaN(value) ? value : angle;","path":"js/modules/glue/component/rotatable.js","position":33,"original_position":33,"commit_id":"10659f9add6f1602b25f94a9e3125e419942c87d","original_commit_id":"10659f9add6f1602b25f94a9e3125e419942c87d","user":{"login":"Buffer-Overflow","id":2873924,"avatar_url":"https://gravatar.com/avatar/6d08eb28f55d90e261e737b3591b4a3a?d=https%3A%2F%2Fidenticons.github.com%2F745011fd971ef655ce2c3ef10bec5ecc.png&r=x","gravatar_id":"6d08eb28f55d90e261e737b3591b4a3a","url":"https://api.github.com/users/Buffer-Overflow","html_url":"https://github.com/Buffer-Overflow","followers_url":"https://api.github.com/users/Buffer-Overflow/followers","following_url":"https://api.github.com/users/Buffer-Overflow/following{/other_user}","gists_url":"https://api.github.com/users/Buffer-Overflow/gists{/gist_id}","starred_url":"https://api.github.com/users/Buffer-Overflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Buffer-Overflow/subscriptions","organizations_url":"https://api.github.com/users/Buffer-Overflow/orgs","repos_url":"https://api.github.com/users/Buffer-Overflow/repos","events_url":"https://api.github.com/users/Buffer-Overflow/events{/privacy}","received_events_url":"https://api.github.com/users/Buffer-Overflow/received_events","type":"User","site_admin":false},"body":"Use Sugar.isNumber","created_at":"2013-12-30T13:57:37Z","updated_at":"2013-12-30T13:57:37Z","html_url":"https://github.com/spilgames/glue/pull/53#discussion_r8584615","pull_request_url":"https://api.github.com/repos/spilgames/glue/pulls/53","_links":{"self":{"href":"https://api.github.com/repos/spilgames/glue/pulls/comments/8584615"},"html":{"href":"https://github.com/spilgames/glue/pull/53#discussion_r8584615"},"pull_request":{"href":"https://api.github.com/repos/spilgames/glue/pulls/53"}}}} | {
"id": 14061002,
"name": "glue",
"url": "https://github.com/spilgames/glue"
} | {
"id": null,
"login": "Buffer-Overflow",
"gravatar_id": "6d08eb28f55d90e261e737b3591b4a3a",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "spilgames",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-30T13:57:37 | null | {"repository":{"description":"JavaScript game engine","homepage":"","watchers":3,"stargazers":3,"forks":0,"fork":false,"size":4870,"owner":"spilgames","private":false,"open_issues":10,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-11-01T21:32:51-07:00","pushed_at":"2013-12-30T05:45:20-08:00","master_branch":"master","organization":"spilgames"},"actor_attributes":{"type":"User","name":"Jeroen Reurings","company":"Spilgames","blog":"http://github.com/buffer-overflow","location":"The netherlands","email":"[email protected]"},"url":"https://github.com/spilgames/glue/pull/53#discussion_r8584615"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/sugarlabs/sugar-web/pulls/comments/5007794","id":5007794,"body":"Oh, I see this line will block you. I have ongoing work for palettes, I will hurry up then.","diff_hunk":"@@ -342,11 +348,11 @@ label {\n \n .palette-container {\n width: @cell-size - 2 * @line-width;\n- height: @cell-size - 2 * @line-width;","path":"graphics/css/sugar.less","position":26,"original_position":26,"commit_id":"577b027d20ac178a4c3dccf279eaac71bf2c886c","original_commit_id":"577b027d20ac178a4c3dccf279eaac71bf2c886c","user":{"login":"manuq","id":83944,"avatar_url":"https://secure.gravatar.com/avatar/4e9cd5761343c5b7cc27f91e8e5b8a37?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"4e9cd5761343c5b7cc27f91e8e5b8a37","url":"https://api.github.com/users/manuq","html_url":"https://github.com/manuq","followers_url":"https://api.github.com/users/manuq/followers","following_url":"https://api.github.com/users/manuq/following{/other_user}","gists_url":"https://api.github.com/users/manuq/gists{/gist_id}","starred_url":"https://api.github.com/users/manuq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manuq/subscriptions","organizations_url":"https://api.github.com/users/manuq/orgs","repos_url":"https://api.github.com/users/manuq/repos","events_url":"https://api.github.com/users/manuq/events{/privacy}","received_events_url":"https://api.github.com/users/manuq/received_events","type":"User"},"created_at":"2013-07-03T12:39:48Z","updated_at":"2013-07-03T12:39:48Z","html_url":"https://github.com/sugarlabs/sugar-web/pull/56#discussion_r5007794","pull_request_url":"https://api.github.com/repos/sugarlabs/sugar-web/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/sugarlabs/sugar-web/pulls/comments/5007794"},"html":{"href":"https://github.com/sugarlabs/sugar-web/pull/56#discussion_r5007794"},"pull_request":{"href":"https://api.github.com/repos/sugarlabs/sugar-web/pulls/56"}}}} | {
"id": 9904139,
"name": "sugar-web",
"url": "https://github.com/sugarlabs/sugar-web"
} | {
"id": null,
"login": "manuq",
"gravatar_id": "4e9cd5761343c5b7cc27f91e8e5b8a37",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "sugarlabs",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-03T12:39:48 | null | {"repository":{"description":"Components for Sugar web activities","homepage":"","watchers":1,"stargazers":1,"forks":5,"fork":false,"size":472,"owner":"sugarlabs","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2013-05-06T21:51:22-07:00","pushed_at":"2013-07-02T08:49:31-07:00","master_branch":"master","organization":"sugarlabs"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/sugarlabs/sugar-web/pull/56#discussion_r5007794"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments/8320712","id":8320712,"diff_hunk":"@@ -55,42 +55,20 @@\n \r\n \r\n /*\r\n- * Sleepy Pens\r\n- */\r\n-/obj/item/weapon/pen/sleepypen\r\n-\tdesc = \"It's a black ink pen with a sharp point and a carefully engraved \\\"Waffle Co.\\\"\"\r\n-\torigin_tech = \"materials=2;syndicate=5\"\r\n-\r\n-\r\n-/obj/item/weapon/pen/sleepypen/New()\r\n-\tcreate_reagents(30)\r\n-\treagents.add_reagent(\"chloralhydrate\", 22)\t//Used to be 100 sleep toxin\t//30 Chloral seems to be fatal, reducing it to 22.\r\n-\t..()\r\n-\r\n-\r\n-/obj/item/weapon/pen/sleepypen/attack(mob/M, mob/user)\r\n-\tif(!istype(M))\treturn\r\n-\r\n-\t..()\r\n-\tif(reagents.total_volume)\r\n-\t\tif(M.reagents)\r\n-\t\t\treagents.trans_to(M, 30) //used to be 150\r\n-\r\n-\r\n-/*\r\n * Parapens\r\n */\r\n /obj/item/weapon/pen/paralysis\r\n \torigin_tech = \"materials=2;syndicate=5\"\r\n \r\n \r\n-/obj/item/weapon/pen/paralysis/attack(mob/M, mob/user)\r\n+/obj/item/weapon/pen/paralysis/attack(mob/living/M, mob/user)\r\n \tif(!istype(M))\treturn\r\n \r\n \t..()\r","path":"code/modules/paperwork/pen.dm","position":37,"original_position":37,"commit_id":"130803fcd96a4e49322668fb8c2271686b57de0f","original_commit_id":"130803fcd96a4e49322668fb8c2271686b57de0f","user":{"login":"Anonus","id":3886584,"avatar_url":"https://gravatar.com/avatar/39d1c1c99e299edbc28cd9732e7ec5a3?d=https%3A%2F%2Fidenticons.github.com%2Fc7e3dc9a7ef3b1cec8e050c5ef6f28e8.png&r=x","gravatar_id":"39d1c1c99e299edbc28cd9732e7ec5a3","url":"https://api.github.com/users/Anonus","html_url":"https://github.com/Anonus","followers_url":"https://api.github.com/users/Anonus/followers","following_url":"https://api.github.com/users/Anonus/following{/other_user}","gists_url":"https://api.github.com/users/Anonus/gists{/gist_id}","starred_url":"https://api.github.com/users/Anonus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anonus/subscriptions","organizations_url":"https://api.github.com/users/Anonus/orgs","repos_url":"https://api.github.com/users/Anonus/repos","events_url":"https://api.github.com/users/Anonus/events{/privacy}","received_events_url":"https://api.github.com/users/Anonus/received_events","type":"User","site_admin":false},"body":"Pens shouldn't prick through thick materials either.","created_at":"2013-12-13T00:23:39Z","updated_at":"2013-12-13T00:23:39Z","html_url":"https://github.com/tgstation/-tg-station/pull/2028#discussion_r8320712","pull_request_url":"https://api.github.com/repos/tgstation/-tg-station/pulls/2028","_links":{"self":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/comments/8320712"},"html":{"href":"https://github.com/tgstation/-tg-station/pull/2028#discussion_r8320712"},"pull_request":{"href":"https://api.github.com/repos/tgstation/-tg-station/pulls/2028"}}}} | {
"id": 3234987,
"name": "-tg-station",
"url": "https://github.com/tgstation/-tg-station"
} | {
"id": null,
"login": "Anonus",
"gravatar_id": "39d1c1c99e299edbc28cd9732e7ec5a3",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "tgstation",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-13T00:23:39 | null | {"repository":{"description":"/tg/'s SS13 branch","homepage":"","watchers":106,"stargazers":106,"forks":332,"fork":false,"size":359299,"owner":"tgstation","private":false,"open_issues":322,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"DM","created_at":"2012-01-21T09:32:47-08:00","pushed_at":"2013-12-12T16:16:17-08:00","master_branch":"master","organization":"tgstation"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/tgstation/-tg-station/pull/2028#discussion_r8320712"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/travis-ci/travis-core/pulls/comments/5105532","id":5105532,"body":"maybe we can just use `api_key` and ditch `api_username`?","diff_hunk":"@@ -0,0 +1,11 @@\n+class CreateMetadataProviders < ActiveRecord::Migration\n+ def change\n+ create_table :metadata_providers do |t|\n+ t.string :name\n+ t.string :api_username","path":"db/migrate/20130709233500_create_metadata_providers.rb","position":5,"original_position":5,"commit_id":"1b4e934f6b13a8104b1926c05f6624983469ee9e","original_commit_id":"1b4e934f6b13a8104b1926c05f6624983469ee9e","user":{"login":"joshk","id":8701,"avatar_url":"https://secure.gravatar.com/avatar/21b21efe14359ec323f9a70464b91e39?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"21b21efe14359ec323f9a70464b91e39","url":"https://api.github.com/users/joshk","html_url":"https://github.com/joshk","followers_url":"https://api.github.com/users/joshk/followers","following_url":"https://api.github.com/users/joshk/following{/other_user}","gists_url":"https://api.github.com/users/joshk/gists{/gist_id}","starred_url":"https://api.github.com/users/joshk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshk/subscriptions","organizations_url":"https://api.github.com/users/joshk/orgs","repos_url":"https://api.github.com/users/joshk/repos","events_url":"https://api.github.com/users/joshk/events{/privacy}","received_events_url":"https://api.github.com/users/joshk/received_events","type":"User"},"created_at":"2013-07-10T00:03:03Z","updated_at":"2013-07-10T00:03:03Z","html_url":"https://github.com/travis-ci/travis-core/pull/233#discussion_r5105532","pull_request_url":"https://api.github.com/repos/travis-ci/travis-core/pulls/233","_links":{"self":{"href":"https://api.github.com/repos/travis-ci/travis-core/pulls/comments/5105532"},"html":{"href":"https://github.com/travis-ci/travis-core/pull/233#discussion_r5105532"},"pull_request":{"href":"https://api.github.com/repos/travis-ci/travis-core/pulls/233"}}}} | {
"id": 2723436,
"name": "travis-core",
"url": "https://github.com/travis-ci/travis-core"
} | {
"id": null,
"login": "joshk",
"gravatar_id": "21b21efe14359ec323f9a70464b91e39",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "travis-ci",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-10T00:03:03 | null | {"repository":{"description":"Models and classes shared by Travis hub and server","homepage":"","watchers":125,"stargazers":125,"forks":50,"fork":false,"size":2060,"owner":"travis-ci","private":false,"open_issues":27,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2011-11-06T17:15:11-08:00","pushed_at":"2013-07-09T16:57:05-07:00","master_branch":"master","organization":"travis-ci"},"actor_attributes":{"type":"User","name":"Josh Kalderimis","company":"Travis CI","blog":"http://blog.cookiestack.com","location":"Berlin, Germany","email":"[email protected]"},"url":"https://github.com/travis-ci/travis-core/pull/233#discussion_r5105532"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/AllPlayers/26fin.com/pulls/comments/6243872","id":6243872,"body":"same here","diff_hunk":"@@ -13,4 +13,5 @@\n <div class=\"panel\">\n \t<div class=\"subnote\"><em><sup>(a)</sup> This\trate\tis\tbased\ton\tyour\ttransactions\tqualifying\tat\tthe\tlowest\tpossible\tInterchange\tlevel.\t\tBecause\ta\tvariety\tof\tfactors\tmay\taffect\twhether\tyour\ttransactions\tqualify\tat\tthis\tlevel,\tyour\trate\tmay\tbe\thigher.\t\tPlease\trefer\tto\tthe\tQualification\tTiers\tdocument\tat\thttp://www.meritcard.com/CustomerTier.aspx\tor\tthe\tProgram\tGuide\tfor\tdetails.</em></div><br>\n \t<div class=\"subnote\"><em><sup>(b)</sup> Merchants\twill\tbe\tcharged\ta\t$25/month\tAccount\tMaintenance\tFee.\t\tThe\tfee\twill\tbe\trebated\tfor\tthose\tmonths\twith\tmore\tthan\t$2500\tin\tnet\tmonthly\tvolume.\t\tThe\tannual\trebate\twill\tbe\tcalculated\tby\tTwoSix\tFinancial\tand\twill\tbe\trefunded\tto\tthe\tmerchant\tin\tJanuary\tof\tthe\tfollowing\tyear\tfor\tvolume\ttotals\tfrom\tthe\tprevious\tyear.</em></div>","path":"getstarted.html","position":3,"original_position":3,"commit_id":"b75e066bb8760f080ecef9fef266accebc6c8f21","original_commit_id":"b75e066bb8760f080ecef9fef266accebc6c8f21","user":{"login":"loganbfisher","id":1943982,"avatar_url":"https://1.gravatar.com/avatar/56f0e208a9a489b0dd59a098a780fc00?d=https%3A%2F%2Fidenticons.github.com%2F1a8033e53a4ef5e7d6405505a94689fd.png","gravatar_id":"56f0e208a9a489b0dd59a098a780fc00","url":"https://api.github.com/users/loganbfisher","html_url":"https://github.com/loganbfisher","followers_url":"https://api.github.com/users/loganbfisher/followers","following_url":"https://api.github.com/users/loganbfisher/following{/other_user}","gists_url":"https://api.github.com/users/loganbfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/loganbfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loganbfisher/subscriptions","organizations_url":"https://api.github.com/users/loganbfisher/orgs","repos_url":"https://api.github.com/users/loganbfisher/repos","events_url":"https://api.github.com/users/loganbfisher/events{/privacy}","received_events_url":"https://api.github.com/users/loganbfisher/received_events","type":"User"},"created_at":"2013-09-09T17:10:41Z","updated_at":"2013-09-09T17:10:41Z","html_url":"https://github.com/AllPlayers/26fin.com/pull/35#discussion_r6243872","pull_request_url":"https://api.github.com/repos/AllPlayers/26fin.com/pulls/35","_links":{"self":{"href":"https://api.github.com/repos/AllPlayers/26fin.com/pulls/comments/6243872"},"html":{"href":"https://github.com/AllPlayers/26fin.com/pull/35#discussion_r6243872"},"pull_request":{"href":"https://api.github.com/repos/AllPlayers/26fin.com/pulls/35"}}}} | {
"id": 7611413,
"name": "26fin.com",
"url": "https://github.com/AllPlayers/26fin.com"
} | {
"id": null,
"login": "loganbfisher",
"gravatar_id": "56f0e208a9a489b0dd59a098a780fc00",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "AllPlayers",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-09T17:10:41 | null | {"repository":{"description":"The public facing 26 financial website.","homepage":"26fin.com","watchers":0,"stargazers":0,"forks":4,"fork":false,"size":260,"owner":"AllPlayers","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"CSS","created_at":"2013-01-14T11:51:35-08:00","pushed_at":"2013-09-06T14:27:45-07:00","master_branch":"gh-pages","organization":"AllPlayers"},"actor_attributes":{"type":"User","name":"Logan Fisher","company":"allplayers.com","blog":"www.loganbfisher.com","location":"Dallas, Texas","email":"[email protected]"},"url":"https://github.com/AllPlayers/26fin.com/pull/35#discussion_r6243872"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/BrandyMint/masha/pulls/comments/5503827","id":5503827,"body":"created_at нужно в виде timestamp передавать","diff_hunk":"@@ -0,0 +1,28 @@\n+:javascript\n+ window.ICRM_Settings = {\n+\n+ email: \"#{ current_user.email if current_user }\",\n+ first_name: \"#{ current_user.name if current_user }\",\n+ user_hash: \"#{ current_user.id if current_user }\",\n+ created_at: \"#{ current_user.created_at if current_user }\",","path":"app/views/layouts/_widget.html.haml","position":7,"original_position":7,"commit_id":"8f20ace991adb3a9b34aaf9b50da029316908ed5","original_commit_id":"8f20ace991adb3a9b34aaf9b50da029316908ed5","user":{"login":"dapi","id":31139,"avatar_url":"https://secure.gravatar.com/avatar/2acd6312f73d16ce507b6e7cb7a3d548?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"2acd6312f73d16ce507b6e7cb7a3d548","url":"https://api.github.com/users/dapi","html_url":"https://github.com/dapi","followers_url":"https://api.github.com/users/dapi/followers","following_url":"https://api.github.com/users/dapi/following{/other_user}","gists_url":"https://api.github.com/users/dapi/gists{/gist_id}","starred_url":"https://api.github.com/users/dapi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dapi/subscriptions","organizations_url":"https://api.github.com/users/dapi/orgs","repos_url":"https://api.github.com/users/dapi/repos","events_url":"https://api.github.com/users/dapi/events{/privacy}","received_events_url":"https://api.github.com/users/dapi/received_events","type":"User"},"created_at":"2013-07-31T14:02:04Z","updated_at":"2013-07-31T14:02:04Z","html_url":"https://github.com/BrandyMint/masha/pull/50#discussion_r5503827","pull_request_url":"https://api.github.com/repos/BrandyMint/masha/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/BrandyMint/masha/pulls/comments/5503827"},"html":{"href":"https://github.com/BrandyMint/masha/pull/50#discussion_r5503827"},"pull_request":{"href":"https://api.github.com/repos/BrandyMint/masha/pulls/50"}}}} | {
"id": 10262203,
"name": "masha",
"url": "https://github.com/BrandyMint/masha"
} | {
"id": null,
"login": "dapi",
"gravatar_id": "2acd6312f73d16ce507b6e7cb7a3d548",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "BrandyMint",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-31T14:02:04 | null | {"repository":{"description":"Маша-учетчица, все знает о том, чем вы занимались сегодня на работе","homepage":"","watchers":0,"stargazers":0,"forks":3,"fork":false,"size":665,"owner":"BrandyMint","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-05-24T01:19:57-07:00","pushed_at":"2013-07-31T01:45:35-07:00","master_branch":"master","organization":"BrandyMint"},"actor_attributes":{"type":"User","name":"Danil Pismenny","company":"brandymint.ru","blog":"dapi.ru","location":"Cheboksary, Russia","email":"[email protected]"},"url":"https://github.com/BrandyMint/masha/pull/50#discussion_r5503827"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/BrandyMint/new.chebit.ru/pulls/comments/2957631","id":2957631,"body":"а вот границы лучше задавать в пикселях, чтобы не зависели от устройства и браузера","path":"app/assets/stylesheets/home.css.sass","position":45,"original_position":45,"commit_id":"2cb335d0fe7a438a0ab9866de6f0ca165c8db7b9","original_commit_id":"2cb335d0fe7a438a0ab9866de6f0ca165c8db7b9","user":{"login":"sibsfinx","id":1164353,"avatar_url":"https://secure.gravatar.com/avatar/003ad104d30032c25d3bb478c134a38c?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"003ad104d30032c25d3bb478c134a38c","url":"https://api.github.com/users/sibsfinx","followers_url":"https://api.github.com/users/sibsfinx/followers","following_url":"https://api.github.com/users/sibsfinx/following","gists_url":"https://api.github.com/users/sibsfinx/gists{/gist_id}","starred_url":"https://api.github.com/users/sibsfinx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sibsfinx/subscriptions","organizations_url":"https://api.github.com/users/sibsfinx/orgs","repos_url":"https://api.github.com/users/sibsfinx/repos","events_url":"https://api.github.com/users/sibsfinx/events{/privacy}","received_events_url":"https://api.github.com/users/sibsfinx/received_events","type":"User"},"created_at":"2013-02-11T06:16:54Z","updated_at":"2013-02-11T06:16:54Z","_links":{"self":{"href":"https://api.github.com/repos/BrandyMint/new.chebit.ru/pulls/comments/2957631"},"html":{"href":"https://github.com/BrandyMint/new.chebit.ru/pull/17#discussion_r2957631"},"pull_request":{"href":"https://api.github.com/repos/BrandyMint/new.chebit.ru/pulls/17"}}}} | {
"id": 7771944,
"name": "new.chebit.ru",
"url": "https://github.com/BrandyMint/new.chebit.ru"
} | {
"id": null,
"login": "sibsfinx",
"gravatar_id": "003ad104d30032c25d3bb478c134a38c",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "BrandyMint",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-11T06:16:54 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":13364,"owner":"BrandyMint","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-01-23T01:51:29-08:00","pushed_at":"2013-02-10T22:07:54-08:00","organization":"BrandyMint"},"actor_attributes":{"name":"Alexander Mescheryakov","blog":"octobear.ru","email":"[email protected]","type":"User"},"url":"https://github.com/BrandyMint/new.chebit.ru/pull/17#discussion_r2957631"} |
PullRequestReviewCommentEvent | true | {"comment":{"original_commit_id":"053ca111b0595783cd54d926269469ea762e12fc","user":{"organizations_url":"https://api.github.com/users/dapi/orgs","subscriptions_url":"https://api.github.com/users/dapi/subscriptions","repos_url":"https://api.github.com/users/dapi/repos","type":"User","received_events_url":"https://api.github.com/users/dapi/received_events","gravatar_id":"2acd6312f73d16ce507b6e7cb7a3d548","id":31139,"events_url":"https://api.github.com/users/dapi/events{/privacy}","followers_url":"https://api.github.com/users/dapi/followers","starred_url":"https://api.github.com/users/dapi/starred{/owner}{/repo}","avatar_url":"https://secure.gravatar.com/avatar/2acd6312f73d16ce507b6e7cb7a3d548?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","url":"https://api.github.com/users/dapi","gists_url":"https://api.github.com/users/dapi/gists{/gist_id}","following_url":"https://api.github.com/users/dapi/following","login":"dapi"},"commit_id":"053ca111b0595783cd54d926269469ea762e12fc","path":"app/views/layouts/_conference.html.haml","_links":{"pull_request":{"href":"https://api.github.com/repos/BrandyMint/new.chebit.ru/pulls/3"},"html":{"href":"https://github.com/BrandyMint/new.chebit.ru/pull/3#discussion_r2806356"},"self":{"href":"https://api.github.com/repos/BrandyMint/new.chebit.ru/pulls/comments/2806356"}},"body":"А у конференция не может быть без title. Это надо и валидацией в моделе и в базе null => false подвтердить.\r\n\r\nУ тебя получается если названия конфы нет, то будет пустая ссылка","position":11,"updated_at":"2013-01-29T09:41:28Z","id":2806356,"original_position":11,"url":"https://api.github.com/repos/BrandyMint/new.chebit.ru/pulls/comments/2806356","created_at":"2013-01-29T09:41:28Z"}} | {
"id": 7771944,
"name": "new.chebit.ru",
"url": "https://github.com/BrandyMint/new.chebit.ru"
} | {
"id": null,
"login": "dapi",
"gravatar_id": "2acd6312f73d16ce507b6e7cb7a3d548",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "BrandyMint",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-01-29T09:41:28 | null | {"repository":{"stargazers":0,"owner":"BrandyMint","has_wiki":true,"open_issues":1,"organization":"BrandyMint","has_issues":true,"fork":false,"size":764,"created_at":"2013-01-23T01:51:29-08:00","has_downloads":true,"description":"","watchers":0,"private":false,"pushed_at":"2013-01-29T01:33:56-08:00","forks":0,"language":"Ruby"},"actor_attributes":{"location":"Cheboksary, Russia","name":"Danil Pismenny","company":"brandymint.ru","blog":"dapi.ru","type":"User","email":"[email protected]"},"url":"https://github.com/BrandyMint/new.chebit.ru/pull/3#discussion_r2806356"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Connexions/rhaptos.cnxmlutils/pulls/comments/8314023","id":8314023,"diff_hunk":"@@ -627,40 +628,238 @@\n <!-- Media: Partial Support -->\n <!-- ========================= -->\n \n-<xsl:template match=\"c:media[not(@display or @longdesc)]\">\n+<xsl:template match=\"c:media\">\n <span class=\"media\">\n- <xsl:apply-templates select=\"@*|node()\"/>\n+ <!-- Apply c:media required attributes -->\n+ <xsl:attribute name=\"id\">\n+ <xsl:value-of select=\"@id\"/>\n+ </xsl:attribute>\n+ <xsl:attribute name=\"alt\">\n+ <xsl:value-of select=\"@alt\"/>\n+ </xsl:attribute>\n+ <!-- Apply c:media optional attributes -->\n+ <xsl:if test=\"@display\">\n+ <xsl:attribute name=\"data-display\">\n+\t<xsl:value-of select=\"@display\"/>\n+ </xsl:attribute>\n+ </xsl:if>\n+ <xsl:if test=\"@longdesc\">\n+ <xsl:attribute name=\"data-longdesc\">\n+\t<xsl:value-of select=\"@longdesc\"/>\n+ </xsl:attribute>\n+ </xsl:if>\n+ <xsl:apply-templates select=\"node()\"/>\n </span>\n </xsl:template>\n \n+<!-- General attribute reassignment -->\n+<xsl:template match=\"c:media/*/@longdesc\">\n+ <xsl:attribute name=\"data-longdesc\">\n+ <xsl:value-of select=\".\"/>\n+ </xsl:attribute>\n+</xsl:template>\n+<xsl:template match=\"c:media/*[@for='pdf']/@for\">\n+ <xsl:attribute name=\"data-print\">\n+ <xsl:text>true</xsl:text>\n+ </xsl:attribute>\n+</xsl:template>\n+<xsl:template match=\"c:media/*[@for='default' or @for='online']/@for\">\n+ <xsl:attribute name=\"data-print\">\n+ <xsl:text>false</xsl:text>\n+ </xsl:attribute>\n+</xsl:template>\n+\n+<!-- Reassign all c:param as @name=@value -->\n+<xsl:template match=\"c:audio/c:param|c:flash/c:param|c:video/c:param|c:java-applet/c:param|c:image/c:param|c:labview/c:param|c:download/c:param\">\n+ <xsl:attribute name=\"{@name}\">\n+ <xsl:value-of select=\"@value\"/>\n+ </xsl:attribute>\n+</xsl:template>\n+<xsl:template name=\"param-pass-through\">\n+ <xsl:for-each select=\"c:param\">\n+ <param name=\"{@name}\" value=\"{@value}\"/>\n+ </xsl:for-each>\n+</xsl:template>\n+\n+<!-- Ensure when applying templates within c:media/* that you use the\n+ following sequence for audio, flash, video, java-applet, image,\n+ labview, and download:\n+ <xsl:apply-templates select=\"@*|c:param\"/>\n+ <xsl:apply-templates select=\"node()[not(self::c:param)]\"/>\n+ -->\n+\n+<xsl:template match=\"c:media/c:download\">\n+ <a href=\"{@src}\" data-media-type=\"{@mime-type}\" class=\"{local-name()}\">\n+ <xsl:apply-templates select=\"@*|c:param\"/>\n+ <xsl:apply-templates select=\"node()[not(self::c:param)]\"/>\n+ <!-- Link text -->\n+ <xsl:value-of select=\"@src\"/>\n+ </a>\n+</xsl:template>\n+\n+<xsl:template match=\"c:media/c:audio\">\n+ <audio src=\"{@src}\" data-media-type=\"{@mime-type}\">\n+ <xsl:if test=\"@volume='0'\">\n+ <xsl:attribute name=\"muted\">\n+\t<xsl:text>true</xsl:text>\n+ </xsl:attribute>\n+ </xsl:if>\n+ <xsl:if test=\"not(@volume='0')\">\n+ <xsl:attribute name=\"data-volume\">\n+\t<xsl:value-of select=\"@volume\"/>\n+ </xsl:attribute>\n+ </xsl:if>\n+ <xsl:if test=\"@standby\">\n+ <xsl:attribute name=\"data-standby\">\n+\t<xsl:value-of select=\"@standby\"/>\n+ </xsl:attribute>\n+ </xsl:if>\n+ <xsl:if test=\"@autoplay\">\n+ <xsl:attribute name=\"autoplay\">\n+\t<xsl:value-of select=\"@autoplay\"/>\n+ </xsl:attribute>\n+ </xsl:if>\n+ <xsl:if test=\"@loop\">\n+ <xsl:attribute name=\"loop\">\n+\t<xsl:value-of select=\"@loop\"/>\n+ </xsl:attribute>\n+ </xsl:if>\n+ <xsl:if test=\"@controller\">\n+ <xsl:attribute name=\"controller\">\n+\t<xsl:value-of select=\"@controller\"/>\n+ </xsl:attribute>\n+ </xsl:if>\n+ <xsl:apply-templates select=\"@*|c:param\"/>","path":"rhaptos/cnxmlutils/xsl/cnxml-to-html5.xsl","position":119,"original_position":119,"commit_id":"373fff3ffbd6931f0626bae87f9910c05b1ed3d1","original_commit_id":"373fff3ffbd6931f0626bae87f9910c05b1ed3d1","user":{"login":"philschatz","id":253202,"avatar_url":"https://gravatar.com/avatar/230b534963782ec45db2e2dbf8bf6709?d=https%3A%2F%2Fidenticons.github.com%2Fd27a64caa1d3b2c818fc1a27ce126ecb.png&r=x","gravatar_id":"230b534963782ec45db2e2dbf8bf6709","url":"https://api.github.com/users/philschatz","html_url":"https://github.com/philschatz","followers_url":"https://api.github.com/users/philschatz/followers","following_url":"https://api.github.com/users/philschatz/following{/other_user}","gists_url":"https://api.github.com/users/philschatz/gists{/gist_id}","starred_url":"https://api.github.com/users/philschatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philschatz/subscriptions","organizations_url":"https://api.github.com/users/philschatz/orgs","repos_url":"https://api.github.com/users/philschatz/repos","events_url":"https://api.github.com/users/philschatz/events{/privacy}","received_events_url":"https://api.github.com/users/philschatz/received_events","type":"User","site_admin":false},"body":"for audio and video, these params should probably be `data-` prefixed.","created_at":"2013-12-12T20:47:52Z","updated_at":"2013-12-12T20:47:52Z","html_url":"https://github.com/Connexions/rhaptos.cnxmlutils/pull/28#discussion_r8314023","pull_request_url":"https://api.github.com/repos/Connexions/rhaptos.cnxmlutils/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/Connexions/rhaptos.cnxmlutils/pulls/comments/8314023"},"html":{"href":"https://github.com/Connexions/rhaptos.cnxmlutils/pull/28#discussion_r8314023"},"pull_request":{"href":"https://api.github.com/repos/Connexions/rhaptos.cnxmlutils/pulls/28"}}}} | {
"id": 2917192,
"name": "rhaptos.cnxmlutils",
"url": "https://github.com/Connexions/rhaptos.cnxmlutils"
} | {
"id": null,
"login": "philschatz",
"gravatar_id": "230b534963782ec45db2e2dbf8bf6709",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Connexions",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-12T20:47:52 | null | {"repository":{"description":"","homepage":"","watchers":3,"stargazers":3,"forks":4,"fork":false,"size":1341,"owner":"Connexions","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"XSLT","created_at":"2011-12-05T06:52:48-08:00","pushed_at":"2013-12-12T12:09:03-08:00","master_branch":"master","organization":"Connexions"},"actor_attributes":{"type":"User","name":"Philip Schatz","company":"Connexions","blog":"http://openstaxcollege.org","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Connexions/rhaptos.cnxmlutils/pull/28#discussion_r8314023"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Connexions/cnx-archive/pulls/comments/7466562","id":7466562,"diff_hunk":"@@ -27,6 +27,7 @@\n \n WILDCARD_KEYWORD = 'text'\n VALID_FILTER_KEYWORDS = ('type', 'pubYear', 'authorID','subject',)\n+RETURN_TOP_KEYWORDS = 200 # Return the top X keywords only","path":"cnxarchive/search.py","position":4,"original_position":4,"commit_id":"cd5ed8de81caf215055f0f1e1f9cc5b40ab947ae","original_commit_id":"cd5ed8de81caf215055f0f1e1f9cc5b40ab947ae","user":{"login":"karenc","id":153353,"avatar_url":"https://2.gravatar.com/avatar/f44eb2ddf5dd414f2be7e040c27e9882?d=https%3A%2F%2Fidenticons.github.com%2Fe8c0f57099f969cb61b8592a0dc3e701.png&r=x","gravatar_id":"f44eb2ddf5dd414f2be7e040c27e9882","url":"https://api.github.com/users/karenc","html_url":"https://github.com/karenc","followers_url":"https://api.github.com/users/karenc/followers","following_url":"https://api.github.com/users/karenc/following{/other_user}","gists_url":"https://api.github.com/users/karenc/gists{/gist_id}","starred_url":"https://api.github.com/users/karenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karenc/subscriptions","organizations_url":"https://api.github.com/users/karenc/orgs","repos_url":"https://api.github.com/users/karenc/repos","events_url":"https://api.github.com/users/karenc/events{/privacy}","received_events_url":"https://api.github.com/users/karenc/received_events","type":"User","site_admin":false},"body":"I didn't think this was a very good name either ;D I'll change it to `MAX_VALUES_FOR_KEYWORDS`.","created_at":"2013-11-06T15:31:30Z","updated_at":"2013-11-06T15:31:30Z","html_url":"https://github.com/Connexions/cnx-archive/pull/132#discussion_r7466562","pull_request_url":"https://api.github.com/repos/Connexions/cnx-archive/pulls/132","_links":{"self":{"href":"https://api.github.com/repos/Connexions/cnx-archive/pulls/comments/7466562"},"html":{"href":"https://github.com/Connexions/cnx-archive/pull/132#discussion_r7466562"},"pull_request":{"href":"https://api.github.com/repos/Connexions/cnx-archive/pulls/132"}}}} | {
"id": 11369603,
"name": "cnx-archive",
"url": "https://github.com/Connexions/cnx-archive"
} | {
"id": null,
"login": "karenc",
"gravatar_id": "f44eb2ddf5dd414f2be7e040c27e9882",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Connexions",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-06T15:31:30 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":1,"fork":false,"size":221966,"owner":"Connexions","private":false,"open_issues":10,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2013-07-12T06:45:05-07:00","pushed_at":"2013-11-06T03:43:01-08:00","master_branch":"master","organization":"Connexions"},"actor_attributes":{"type":"User","name":"Karen Chan","company":"","blog":"http://www.karen-chan.com/","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/Connexions/cnx-archive/pull/132#discussion_r7466562"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/FinalsClub/karmaworld/pulls/comments/5096103","id":5096103,"body":"This isn't the same thing as: \r\n\r\n env.proj_root = '/var/www/karmaworld'\r\n env.proj_dir = os.path.join(env.proj_root, 'karmaworld')\r\n\r\n\r\nThe old example would evaluate to `/var/www/karmaworld/karmaworld`. Is this a bug you're fixing, or is this a change you're making?","diff_hunk":"@@ -1,174 +1,122 @@\n-\"\"\"Management utilities.\"\"\"\n+\n+\"\"\" Karmaworld Fabric management script\n+ Finals Club (c) 2013\"\"\"\n \n import os\n-from contextlib import contextmanager as _contextmanager\n \n from fabric.api import cd, env, lcd, prefix, run, task, local, settings\n+from fabvenv import virtualenv\n \n-\n-########## GLOBALS\n+######### GLOBAL\n env.proj_repo = '[email protected]:FinalsClub/karmaworld.git'\n-env.virtualenv = 'venv-kw'\n-env.activate = 'workon %s' % env.virtualenv\n-\n-# Using this env var to be able to specify the function\n-# used to run the commands. By default it's `run`, which\n-# runs commands remotely, but in the `here` task we set\n-# env.run to `local` to run commands locally.\n-env.run = run\n-env.cd = cd\n-########## END GLOBALS\n \n \n-########## HELPERS\n-@_contextmanager\n-def _virtualenv():\n- \"\"\"\n- Changes to the proj_dir and activates the virtualenv\n- \"\"\"\n- with env.cd(env.proj_dir):\n- with prefix(env.activate):\n- yield\n-\n-########## END HELPERS\n-\n-########## ENVIRONMENTS\n+######## Define host(s)\n @task\n def here():\n \"\"\"\n Connection information for the local machine\n \"\"\"\n- # This is required, because local doesn't read the user's\n- # .bashrc file, because it doesn't use an interactive shell\n- def _custom_local(command):\n- prefixed_command = '/bin/bash -l -i -c \"%s\"' % command\n- return local(prefixed_command)\n \n # This is required for the same reason as above\n- env.activate = '/bin/bash -l -i -c \"workon %s\"' % env.virtualenv\n env.proj_dir = os.getcwd()\n env.proj_root = os.path.dirname(env.proj_dir)\n- env.run = _custom_local\n env.cd = lcd\n env.reqs = 'reqs/dev.txt'\n- env.confs = 'confs/dev/'\n- env.branch = 'master'\n+ env.confs = 'confs/stag/'\n+ env.branch = 'beta'\n+ env.run = virtenv_exec\n+\n \n \n+####### Define production host\n @task\n-def beta():\n+def prod():\n \"\"\"\n- Beta connection information\n+ Connection Information for production machine\n \"\"\"\n+\n env.user = 'djkarma'\n- env.hosts = ['beta.karmanotes.org']\n+ env.hosts = ['karmanotes.org']\n env.proj_root = '/var/www/karmaworld'\n- env.proj_dir = os.path.join(env.proj_root, 'karmaworld')\n+ env.proj_dir = '/var/www/karmaworld'\n env.reqs = 'reqs/prod.txt'\n- env.confs = 'confs/beta/'\n+ env.confs = 'confs/prod/'\n env.branch = 'beta'\n+ env.run = virtenv_exec\n+ env.gunicorn_addr = '127.0.0.1:8000'\n \n-\n+####### Define beta host\n @task\n-def prod():\n- \"\"\"\n- Production connection information\n+def beta():\n+ \"\"\" \n+ Connection Information for beta machine \n \"\"\"\n+\n env.user = 'djkarma'\n- env.hosts = ['karmanotes.org']\n+ env.hosts = ['beta.karmanotes.org']\n env.proj_root = '/var/www/karmaworld'\n- env.proj_dir = os.path.join(env.proj_root, 'karmaworld')\n+ env.proj_dir = '/var/www/karmaworld'\n env.reqs = 'reqs/prod.txt'\n env.confs = 'confs/prod/'\n- env.branch = 'master'","path":"fabfile.py","position":109,"original_position":109,"commit_id":"6de594d18d8359c9d040e23f95930e3ef23d9e98","original_commit_id":"6de594d18d8359c9d040e23f95930e3ef23d9e98","user":{"login":"sethwoodworth","id":123998,"avatar_url":"https://secure.gravatar.com/avatar/e3a16fb8067bc8cc26eeb08cd4409e75?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"e3a16fb8067bc8cc26eeb08cd4409e75","url":"https://api.github.com/users/sethwoodworth","html_url":"https://github.com/sethwoodworth","followers_url":"https://api.github.com/users/sethwoodworth/followers","following_url":"https://api.github.com/users/sethwoodworth/following{/other_user}","gists_url":"https://api.github.com/users/sethwoodworth/gists{/gist_id}","starred_url":"https://api.github.com/users/sethwoodworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethwoodworth/subscriptions","organizations_url":"https://api.github.com/users/sethwoodworth/orgs","repos_url":"https://api.github.com/users/sethwoodworth/repos","events_url":"https://api.github.com/users/sethwoodworth/events{/privacy}","received_events_url":"https://api.github.com/users/sethwoodworth/received_events","type":"User"},"created_at":"2013-07-09T17:33:06Z","updated_at":"2013-07-09T17:33:06Z","html_url":"https://github.com/FinalsClub/karmaworld/pull/128#discussion_r5096103","pull_request_url":"https://api.github.com/repos/FinalsClub/karmaworld/pulls/128","_links":{"self":{"href":"https://api.github.com/repos/FinalsClub/karmaworld/pulls/comments/5096103"},"html":{"href":"https://github.com/FinalsClub/karmaworld/pull/128#discussion_r5096103"},"pull_request":{"href":"https://api.github.com/repos/FinalsClub/karmaworld/pulls/128"}}}} | {
"id": 7263563,
"name": "karmaworld",
"url": "https://github.com/FinalsClub/karmaworld"
} | {
"id": null,
"login": "sethwoodworth",
"gravatar_id": "e3a16fb8067bc8cc26eeb08cd4409e75",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "FinalsClub",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-09T17:33:06 | null | {"repository":{"description":"KarmaNotes.org v3.0","watchers":1,"stargazers":1,"forks":3,"fork":false,"size":1008,"owner":"FinalsClub","private":false,"open_issues":28,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-12-20T12:07:06-08:00","pushed_at":"2013-07-09T10:31:47-07:00","master_branch":"master","organization":"FinalsClub"},"actor_attributes":{"type":"User","name":"Seth Woodworth","company":"FinalsClub Foundation","blog":"sethish.com","location":"Boston","email":"[email protected]"},"url":"https://github.com/FinalsClub/karmaworld/pull/128#discussion_r5096103"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/OpenSocial/explorer/pulls/comments/7702288","id":7702288,"diff_hunk":"@@ -32,34 +35,35 @@\n * A container {@link SecurityToken} whose owner and viewer IDs are derived from an OpenID","path":"java/server/src/main/java/org/opensocial/explorer/server/login/LoginSecurityToken.java","position":20,"original_position":20,"commit_id":"3850fb083fe4d2ac49390b9aca480d9f89ddd510","original_commit_id":"3850fb083fe4d2ac49390b9aca480d9f89ddd510","user":{"login":"ryanjbaxter","id":524254,"avatar_url":"https://1.gravatar.com/avatar/53a1e8497bf6bce5a4dd2b7674929d57?d=https%3A%2F%2Fidenticons.github.com%2Fb36b91578c3118904fce2400501a2544.png&r=x","gravatar_id":"53a1e8497bf6bce5a4dd2b7674929d57","url":"https://api.github.com/users/ryanjbaxter","html_url":"https://github.com/ryanjbaxter","followers_url":"https://api.github.com/users/ryanjbaxter/followers","following_url":"https://api.github.com/users/ryanjbaxter/following{/other_user}","gists_url":"https://api.github.com/users/ryanjbaxter/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanjbaxter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanjbaxter/subscriptions","organizations_url":"https://api.github.com/users/ryanjbaxter/orgs","repos_url":"https://api.github.com/users/ryanjbaxter/repos","events_url":"https://api.github.com/users/ryanjbaxter/events{/privacy}","received_events_url":"https://api.github.com/users/ryanjbaxter/received_events","type":"User","site_admin":false},"body":"Should we update the comment here if the token is no longer specific to OpenID?","created_at":"2013-11-15T20:59:04Z","updated_at":"2013-11-15T20:59:04Z","html_url":"https://github.com/OpenSocial/explorer/pull/83#discussion_r7702288","pull_request_url":"https://api.github.com/repos/OpenSocial/explorer/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/OpenSocial/explorer/pulls/comments/7702288"},"html":{"href":"https://github.com/OpenSocial/explorer/pull/83#discussion_r7702288"},"pull_request":{"href":"https://api.github.com/repos/OpenSocial/explorer/pulls/83"}}}} | {
"id": 8959462,
"name": "explorer",
"url": "https://github.com/OpenSocial/explorer"
} | {
"id": null,
"login": "ryanjbaxter",
"gravatar_id": "53a1e8497bf6bce5a4dd2b7674929d57",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "OpenSocial",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-15T20:59:04 | null | {"repository":{"description":"Tool to learn how to develop OpenSocial gadgets. #social","homepage":"","watchers":23,"stargazers":23,"forks":39,"fork":false,"size":14561,"owner":"OpenSocial","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-03-22T12:39:33-07:00","pushed_at":"2013-11-13T08:33:43-08:00","master_branch":"master","organization":"OpenSocial"},"actor_attributes":{"type":"User","name":"Ryan Baxter","blog":"ryanjbaxter.com","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/OpenSocial/explorer/pull/83#discussion_r7702288"} |
PullRequestReviewCommentEvent | true | {"comment":{"original_position":90,"original_commit_id":"e3a8b0e7790ca5d966aeb57480d074605b40e0ae","created_at":"2013-01-15T23:16:39Z","updated_at":"2013-01-15T23:16:39Z","user":{"organizations_url":"https://api.github.com/users/winhamwr/orgs","gravatar_id":"23de2d62fa46d3785970220b5b135b7c","subscriptions_url":"https://api.github.com/users/winhamwr/subscriptions","login":"winhamwr","events_url":"https://api.github.com/users/winhamwr/events{/privacy}","avatar_url":"https://secure.gravatar.com/avatar/23de2d62fa46d3785970220b5b135b7c?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","received_events_url":"https://api.github.com/users/winhamwr/received_events","url":"https://api.github.com/users/winhamwr","id":56973,"repos_url":"https://api.github.com/users/winhamwr/repos","following_url":"https://api.github.com/users/winhamwr/following","starred_url":"https://api.github.com/users/winhamwr/starred{/owner}{/repo}","followers_url":"https://api.github.com/users/winhamwr/followers","gists_url":"https://api.github.com/users/winhamwr/gists{/gist_id}","type":"User"},"path":"docx2html/tests/test_xml.py","url":"https://api.github.com/repos/PolicyStat/docx2html/pulls/comments/2658396","id":2658396,"body":"Looks like this might be one possible solution: https://mailman-mail5.webfaction.com/pipermail/lxml/2012-June/006432.html\r\n\r\nMight want to shoot for html5 doctype instead of html 4","position":90,"commit_id":"e3a8b0e7790ca5d966aeb57480d074605b40e0ae","_links":{"self":{"href":"https://api.github.com/repos/PolicyStat/docx2html/pulls/comments/2658396"},"pull_request":{"href":"https://api.github.com/repos/PolicyStat/docx2html/pulls/4"},"html":{"href":"https://github.com/PolicyStat/docx2html/pull/4#discussion_r2658396"}}}} | {
"id": 7547761,
"name": "docx2html",
"url": "https://github.com/PolicyStat/docx2html"
} | {
"id": null,
"login": "winhamwr",
"gravatar_id": "23de2d62fa46d3785970220b5b135b7c",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "PolicyStat",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-01-15T23:16:39 | null | {"repository":{"watchers":2,"owner":"PolicyStat","pushed_at":"2013-01-14T15:07:49-08:00","description":"Convert a docx (OOXML) file to html","stargazers":2,"forks":0,"has_downloads":true,"organization":"PolicyStat","has_wiki":true,"fork":false,"size":1080,"created_at":"2013-01-10T12:09:11-08:00","open_issues":1,"private":false,"has_issues":true},"actor_attributes":{"company":"PolicyStat","name":"Wes Winham","blog":"http://twitter.com/weswinham","email":"[email protected]","location":"Indiana","type":"User"},"url":"https://github.com/PolicyStat/docx2html/pull/4#discussion_r2658396"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments/4611247","id":4611247,"body":"fair enough but I still dont see why --clear over `clean`","diff_hunk":"@@ -167,6 +168,8 @@ class VirtualEnv\n def handle(fun, dir, args)\n task Tasks.new.task_name(dir, args[:name]) do\n dest = Platform.path_for(args[:dest])\n+ # Clean the destination dir(build/python) before virtualenv'ing into it","path":"rake-tasks/crazy_fun/mappings/python.rb","position":16,"original_position":16,"commit_id":"245a2ec3106556e81b6fa121a6cd0d7444ed51a5","original_commit_id":"245a2ec3106556e81b6fa121a6cd0d7444ed51a5","user":{"login":"AutomatedTester","id":128518,"avatar_url":"https://secure.gravatar.com/avatar/87b062ebe606f08b5c9b7b8b2d64f2ec?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"87b062ebe606f08b5c9b7b8b2d64f2ec","url":"https://api.github.com/users/AutomatedTester","html_url":"https://github.com/AutomatedTester","followers_url":"https://api.github.com/users/AutomatedTester/followers","following_url":"https://api.github.com/users/AutomatedTester/following{/other_user}","gists_url":"https://api.github.com/users/AutomatedTester/gists{/gist_id}","starred_url":"https://api.github.com/users/AutomatedTester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutomatedTester/subscriptions","organizations_url":"https://api.github.com/users/AutomatedTester/orgs","repos_url":"https://api.github.com/users/AutomatedTester/repos","events_url":"https://api.github.com/users/AutomatedTester/events{/privacy}","received_events_url":"https://api.github.com/users/AutomatedTester/received_events","type":"User"},"created_at":"2013-06-10T13:34:56Z","updated_at":"2013-06-10T13:34:56Z","html_url":"https://github.com/SeleniumHQ/selenium/pull/86#discussion_r4611247","pull_request_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/86","_links":{"self":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments/4611247"},"html":{"href":"https://github.com/SeleniumHQ/selenium/pull/86#discussion_r4611247"},"pull_request":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/86"}}}} | {
"id": 7613257,
"name": "selenium",
"url": "https://github.com/SeleniumHQ/selenium"
} | {
"id": null,
"login": "AutomatedTester",
"gravatar_id": "87b062ebe606f08b5c9b7b8b2d64f2ec",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "SeleniumHQ",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-10T13:34:56 | null | {"repository":{"description":"A mirror of the Selenium source. Please log Issues in Google Code. Also confirm you have signed the CLA http://goo.gl/qC50R when making a Pull Request","homepage":"https://code.google.com/p/selenium/","watchers":92,"stargazers":92,"forks":103,"fork":false,"size":43068,"owner":"SeleniumHQ","private":false,"open_issues":15,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2013-01-14T13:40:56-08:00","pushed_at":"2013-06-05T13:00:39-07:00","master_branch":"master","organization":"SeleniumHQ"},"actor_attributes":{"type":"User","name":"David Burns","company":"Mozilla Corporation","blog":"http://www.theautomatedtester.co.uk","location":"Bournemouth, England","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/SeleniumHQ/selenium/pull/86#discussion_r4611247"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/arquillian/arquillian.github.com/pulls/comments/3194432","id":3194432,"body":"zarządany -> zarządzany ","diff_hunk":"@@ -0,0 +1,558 @@\n+---\n+layout: guide\n+title: \"Szybki start: Zróbmy to raz jeszcze\"\n+authors: [mojavelinux]\n+translators: [glipecki]\n+description: Część druga seri \"Szybki start\". Potwierdź swoje postępy w bardziej skomplikowanych przykładach i naucz się wykorzystywać zdalne kontenery.\n+guide_group: 1\n+guide_order: 20\n+TODO: [\"port configuration and arquillian.launch\", \"expected deployment error\"]\n+---\n+To wprowadzenie jest kontynuacją serii \"Szybki start\":/guides/getting_started. Dzięki niemu będziesz mógł ugruntować swoją wiedzę na temat Arquilliana, wykorzystując bardziej skomplikowany przykład. Po przeczytaniu tego przewodnika będziesz potrafił:\n+\n+* Napisać testy Arquilliana wykorzystujące CDI(Contexts and Dependency Injection) oraz EJB(Enterprise JavaBeans).\n+* Wykonywać testy Arquilliana wykorzytując zdalny kontener.\n+* Debugować testy Arquilliana wykorzytując zdalny kontener.\n+\n+W oparciu o ten przewodnik dodasz nowy profil budowania swojej aplikacji w Mavenie. Dzięki niemu będziesz mógł wskazać Arquillianowi kiedy uruchomić testy na zdalnym kontenerze (np. serwera aplikacji). To znaczy, że będziesz testował _w realnym środowisku_. Żadnych mocków. Żadnych środowisk testowych! A ponieważ najcięższą pracę wykonałeś w pierwszej części wprowadzenia, nie powinno zająć to zbyt wiele czasu.\n+\n+h3. Założenia\n+\n+Wprowadzenie zakłada, że skonfigurowałeś już swój projekt do pracy z Arquillianem oraz napisałeś i wykonałeś przynajmniej jeden test. Jeśli jeszcze tego nie zrobiłeś, wróć proszę do przewodnika \"Szybki start\":/guides/getting_started i poznaj podstawy Arquilliana.\n+\n+h3. Stwórz komponenty\n+\n+Będziesz przygotowywał bardzo prosty backend dla aplikacji sklepu. Użyjemy komponent koszyka zakupów do przechowywania produktów wybranych przez odwiedzających i komponent repozytorium do przechowywania i pobierania złożonych zamówień. Zaimplementujemy je korzystając z odpowiednio CDI i EJB. Ponieważ korzystamy z Java EE 6 API możemy wykorzystać obie te technologie bez żadnego dodatkowego nakładu pracy. (Jeżeli potrzebujesz, dowiedz się z przewodnika \"Szybki start\":/guides/getting_started jak dołączyć wspomniane API do swojego projektu).\n+\n+Zacznijmy od komponentu przenoszącego zamówienia do i z magazynu danych. Trzymając się dobrych praktyk tworzenia oprogramowania, oraz w celu ułatwienia pisania testów, zaczniemy od zdefiniowania interfejsu. W swoim IDE utwórz nowy lokalny interfejs EJB @OrderRepository@ i uzupełnij go podanym kodem:\n+\n+div(filename). src/main/java/org/arquillian/example/OrderRepository.java\n+\n+bc(prettify).. package org.arquillian.example;\n+\n+import java.util.List;\n+import javax.ejb.Local;\n+\n+@Local\n+public interface OrderRepository {\n+ void addOrder(List<String> order);\n+ List<List<String>> getOrders();\n+ int getOrderCount();\n+}\n+\n+p. Implementacją zajmiemy się później. Póki co przejdźmy do opisu wykorzystania tego API.\n+\n+W trakcie korzystania ze strony, odwiedzający będą dodawać produkty do swoich koszyków z zakupami. Żeby wymodelować ten scenariusz wykorzystamy komponent CDI, który będzie powiązany z sesją HTTP odwiedzającego. Gdy kupujący zechce zrealizować zakupy ze swojego koszyka, komponent ten będzie delegował żądanie do @OrderRepository@.\n+\n+W IDE utwórz klasę @Basket@ i powiąż ją z kontekstem sesji, dodając adnotację zakresu @@SessionScoped@, jak w przykładzie poniżej:\n+\n+div(filename). src/main/java/org/arquillian/example/Basket.java\n+\n+bc(prettify).. package org.arquillian.example;\n+\n+import java.io.Serializable;\n+import java.util.ArrayList;\n+import java.util.Collections;\n+import java.util.List;\n+\n+import javax.annotation.PostConstruct;\n+import javax.ejb.EJB;\n+import javax.enterprise.context.SessionScoped;\n+\n+@SessionScoped\n+public class Basket implements Serializable {\n+ private static final long serialVersionUID = 1L;\n+ private List<String> items;\n+ \n+ @EJB\n+ private OrderRepository repo;\n+ \n+ public void addItem(String item) {\n+ items.add(item);\n+ }\n+ \n+ public List<String> getItems() {\n+ return Collections.unmodifiableList(items);\n+ }\n+ \n+ public int getItemCount() {\n+ return items.size();\n+ }\n+ \n+ public void placeOrder() {\n+ repo.addOrder(items);\n+ items.clear();\n+ }\n+ \n+ @PostConstruct\n+ void initialize() {\n+ items = new ArrayList<String>();\n+ }\n+}\n+\n+p. Jak widzisz, wiążemy komponent EJB do naszego komponentu CDI, dokładnie tą integrację będziemy chcieli przetestować!\n+\n+h3. Implementuj etapami\n+\n+Nie jesteśmy jeszcze zupełnie gotowi do tworzenia kolejnych testów, ponieważ nie dostarczyliśmy żadnej implementacji dla @OrderRepository@.\n+\n+Na potrzeby tego przykładu, załóżmy że interfejs @OrderRepository@ jest implementowany przez inny zespół (lub w kolejnej iteracji). To idealne miejsce dla wykorzystania funkcjonalności micro-deploymentu. Przygotujemy implementację singletona EJB działającego w pamięci i dostarczymy ją w archiwum testowym w celu szybkiego uruchomienia aplikacji. (W przyszłości możemy nawet zdecydować o zachowaniu tej implementacji dla testów tego punktu styku).\n+\n+Utwórz klasę @SingletonOrderRepository@ w testowym folderze i uzupełnij ją kodem pokazanym poniżej:\n+\n+div(filename). src/test/java/org/arquillian/example/SingletonOrderRepository.java\n+\n+bc(prettify).. package org.arquillian.example;\n+\n+import java.util.ArrayList;\n+import java.util.Collections;\n+import java.util.List;\n+\n+import javax.annotation.PostConstruct;\n+import javax.ejb.Lock;\n+import javax.ejb.LockType;\n+import javax.ejb.Singleton;\n+\n+@Singleton\n+@Lock(LockType.READ)\n+public class SingletonOrderRepository implements OrderRepository {\n+ private List<List<String>> orders;\n+ \n+ @Override\n+ @Lock(LockType.WRITE)\n+ public void addOrder(List<String> order) {\n+ orders.add(order);\n+ }\n+ \n+ @Override\n+ public List<List<String>> getOrders() {\n+ return Collections.unmodifiableList(orders);\n+ }\n+ \n+ @Override\n+ public int getOrderCount() {\n+ return orders.size();\n+ }\n+ \n+ @PostConstruct\n+ void initialize() {\n+ orders = new ArrayList<List<String>>();\n+ }\n+}\n+\n+p. Dodatkową zaletą tej implementacji jest możliwość zapoznania się z nową funkcjonalnością singletonów z EJB 3.1 w środowisku testowym Arquilliana. Dlatego właśnie lubimy nazywać Arquilliana, poza narzędziem testującym, środowiskiem do nauki.\n+\n+Teraz jesteśmy gotowi do pisania testów Arquilliana.\n+\n+h3. Napisz testy\n+\n+Napiszemy test, który będzie symulował dodanie produktów do instancji klasy @Basket@ i wykorzystanie jej do złożenia zamówienia. Zweryfikuje on czy zamówienie zostało przetworzone i zapisze je w instancji klasy @OrderRepository@.\n+\n+p(info). %Oczywiście będziemy testować tylko implementację działającą w pamięci. Nauczysz się jak pisać testy wykorzystujące bazę danych w przewodniku \"Testowanie Java Persistence\":/guides/testing_java_persistence. Możesz wtedy powrócić do tego przewodnika i przygotować implementację opartą o JPA.%\n+\n+Utwórz klasę @BasketTest@ i oznacz ją adnotacją @@RunWith(Arquillian.class)@, aby wykorzystać Arquilliana do uruchomienia tego testu:\n+\n+div(filename). src/test/java/org/arquillian/example/BasketTest.java\n+\n+bc(prettify).. package org.arquillian.example;\n+\n+import org.jboss.arquillian.junit.Arquillian;\n+import org.junit.runner.RunWith;\n+\n+@RunWith(Arquillian.class)\n+public class BasketTest {\n+}\n+\n+p. W następnym kroku zdefiniujemy archiwum testowe, zawierające koszyk, interfejs repozytorium zamówień oraz jego implementację jako singleton. Dodatkowo potrzebujemy pusty plik beans.xml, który uaktywni CDI (EJB jest aktywowane automatycznie). Zauważ, że poprzez konkretne zdefiniowanie co ma trafić do archiwum, mamy pełną kontrolę nad classpathem aplikacji\n+\n+div(filename). src/test/java/org/arquillian/example/BasketTest.java\n+\n+bc(prettify).. package org.arquillian.example;\n+\n+import org.jboss.arquillian.container.test.api.Deployment;\n+import org.jboss.arquillian.junit.Arquillian;\n+import org.jboss.shrinkwrap.api.ShrinkWrap;\n+import org.jboss.shrinkwrap.api.asset.EmptyAsset;\n+import org.jboss.shrinkwrap.api.spec.JavaArchive;\n+import org.junit.runner.RunWith;\n+\n+@RunWith(Arquillian.class)\n+public class BasketTest {\n+ @Deployment\n+ public static JavaArchive createDeployment() {\n+ return ShrinkWrap.create(JavaArchive.class, \"test.jar\")\n+ .addClasses(Basket.class, OrderRepository.class, SingletonOrderRepository.class)\n+ .addAsManifestResource(EmptyAsset.INSTANCE, \"beans.xml\");\n+ }\n+}\n+\n+p. Jedyne co nam pozostało to wstrzyknięcie koszyka i repozytorium zamówień do klasy testowej oraz przetestowanie ich współdziałania. Będziemy wstrzykiwać interfejs EJB, nie jego implementację. Kontener EJB automatycznie odnajdzie odpowiadającą implementację i ją wykorzysta.\n+\n+JUnit domyślnie wykonuje metody @@Test@ w nieokreślonej kolejności. Arquillianowa wersja testów JUnitowych dostarcza adnotację @@InSequence@ pozwalającą określić wprost kolejność wykonywania metod testowych. Wykorzystamy ją, żeby w pierwszej metodzie testowej dodać dwa zamówienia oraz w drugiej sprawdzić czy nadal znajdują się w repozytorium.\n+\n+div(filename). src/test/java/org/arquillian/example/BasketTest.java\n+\n+bc(prettify).. package org.arquillian.example;\n+\n+import javax.ejb.EJB;\n+import javax.inject.Inject;\n+\n+import org.jboss.arquillian.container.test.api.Deployment;\n+import org.jboss.arquillian.junit.Arquillian;\n+import org.jboss.arquillian.junit.InSequence;\n+import org.jboss.shrinkwrap.api.ShrinkWrap;\n+import org.jboss.shrinkwrap.api.asset.EmptyAsset;\n+import org.jboss.shrinkwrap.api.spec.JavaArchive;\n+import org.junit.Assert;\n+import org.junit.Test;\n+import org.junit.runner.RunWith;\n+\n+@RunWith(Arquillian.class)\n+public class BasketTest {\n+ @Deployment\n+ public static JavaArchive createDeployment() {\n+ return ShrinkWrap.create(JavaArchive.class, \"test.jar\")\n+ .addClasses(Basket.class, OrderRepository.class, SingletonOrderRepository.class)\n+ .addAsManifestResource(EmptyAsset.INSTANCE, \"beans.xml\");\n+ }\n+ \n+ @Inject\n+ Basket basket;\n+ \n+ @EJB\n+ OrderRepository repo;\n+ \n+ @Test\n+ @InSequence(1)\n+ public void place_order_should_add_order() {\n+ basket.addItem(\"sunglasses\");\n+ basket.addItem(\"suit\");\n+ basket.placeOrder();\n+ Assert.assertEquals(1, repo.getOrderCount());\n+ Assert.assertEquals(0, basket.getItemCount());\n+ \n+ basket.addItem(\"raygun\");\n+ basket.addItem(\"spaceship\");\n+ basket.placeOrder();\n+ Assert.assertEquals(2, repo.getOrderCount());\n+ Assert.assertEquals(0, basket.getItemCount());\n+ }\n+ \n+ @Test\n+ @InSequence(2)\n+ public void order_should_be_persistent() {\n+ Assert.assertEquals(2, repo.getOrderCount());\n+ }\n+}\n+\n+p. Napisaliśmy nasz test. Pora przygotować środowisko, w którym go uruchomimy.\n+\n+h3. Dodaj zdalne kontenery\n+\n+Napisany przez nas test wykorzystuje zarówno CDI, jak i EJB. Ta kombinacja przesuwa granicę tego, co może dostarczyć nam osadzone środowisko testowe (takie jak Weld Embedded czy OpenEJB Embedded). Dużo prościej jest wykorzystać kontener zgodny ze standardem Java EE. Dodatkowo zwiększymy wiarygodność naszych przypadków testowych. Dlatego, póki co, zapomnimy o osadzanych kontenerach.\n+\n+W poprzednim wprowadzeniu wykorzystywaliśmy zarówno osadzane, jak i zarządzane kontenery. W obu przypadkach Arquillian musi uruchomić kontener przed rozpoczęciem zestawu testów oraz zatrzymać go po ich zakończeniu. Co jeżeli kontener jest już uruchomiony (bądź zamierzasz taki uruchomić na potrzeby testów)? To oczywiście najszybsza metoda uruchamiania testów. Nawet jeżeli kontener uruchamia się błyskawicznie, nigdy testy nie wykonają się szybciej niż gdyby nie musiały nic uruchamiać.\n+\n+Zdalny kontener dostarcza nam idealne środowisko programistyczne dla testów integracyjnych. Jak przekonasz się później, umożliwia również bardzo łatwe debugowanie testów. Ponieważ nie ma żadnych odniesień do kontenera w testach, nic nie stoi na przeszkodzie żeby wykorzystać kontener zdalny w trakcie programowania, a zarządzany w przypadku środowiska ciągłej integracji. W zasadzie, zarządzane kontenery najlepiej się sprawdzają w przypadku środowisk ciągłe integracji.\n+\n+p(warning). %Określenie _zdalny_ odnosi się do kontenera w osobnym procesie, nie zawsze na zdalnej maszynie. Chociaż oba scenariusze są wspierane%\n+\n+Zdalny kontener to samodzielny proces, w którym Arquillian uruchamia testy wykorzystując jego klienckie API. W związku z tym, będziesz potrzebował:\n+\n+* API modelu programowania (muszą być spakowane razem z archiwum testowym jedynie gdy kontener ich nie zapewnia).\n+* Adapter Arquilliana dla wybranego zdalnego kontenera.\n+* API aplikacji klienckiej kontenera, w celu komunikacji z jego procesem.\n+\n+W swoim pliku pom.xml dodaj dwa nowe profile wewnątrz elementu @<profiles>@. \n+Pierwszy z nich wykorzystuje zdalny kontener JBoss AS 7.1: \n+\n+div(filename). pom.xml\n+\n+bc(prettify).. <!-- clip -->\n+<profile>\n+ <id>arquillian-jbossas-remote</id>\n+ <dependencies>\n+ <dependency>\n+ <groupId>org.jboss.spec</groupId>\n+ <artifactId>jboss-javaee-6.0</artifactId>\n+ <version>1.0.0.Final</version>\n+ <type>pom</type>\n+ <scope>provided</scope>\n+ </dependency>\n+ <dependency>\n+ <groupId>org.jboss.as</groupId>\n+ <artifactId>jboss-as-arquillian-container-remote</artifactId>\n+ <version>7.1.1.Final</version>\n+ <scope>test</scope>\n+ </dependency>\n+ <dependency>\n+ <groupId>org.jboss.arquillian.protocol</groupId>\n+ <artifactId>arquillian-protocol-servlet</artifactId>\n+ <scope>test</scope>\n+ </dependency>\n+ </dependencies>\n+</profile>\n+<!-- clip -->\n+\n+p(info). %Domyślnie, JBoss AS 7 instaluje archiwa na serwerze wykorzystując protokół JMX. My jednak poszliśmy o krok dalej i dodaliśmy wsparcie dla protokołu wykorzystującego Servlety w profilu @arquillian-jbossas-managed@, Wwrazie gdybyśmy chcieli z niego skorzystać w przyszłości. Zajrzyj do \"FAQ\":https://community.jboss.org/wiki/WhyDoIGetNoActiveContextsForScopeTypeWhenTestingOnJBossAS7 żeby sprawdzić jak się pomiędzy nimi przełączać.%\n+\n+p. Drugi profil wykorzystuje zdalny kontener GlassFish 3.1.2:\n+\n+div(filename). pom.xml\n+\n+bc(prettify).. <!-- clip -->\n+<profile>\n+ <id>arquillian-glassfish-remote</id>\n+ <dependencies>\n+ <dependency>\n+ <groupId>org.jboss.spec</groupId>\n+ <artifactId>jboss-javaee-6.0</artifactId>\n+ <version>1.0.0.Final</version>\n+ <type>pom</type>\n+ <scope>provided</scope>\n+ </dependency>\n+ <dependency>\n+ <groupId>org.jboss.weld</groupId>\n+ <artifactId>weld-api</artifactId>\n+ <version>1.1.Final</version>\n+ <scope>test</scope>\n+ </dependency>\n+ <dependency>\n+ <groupId>org.jboss.arquillian.container</groupId>\n+ <artifactId>arquillian-glassfish-remote-3.1</artifactId>\n+ <version>1.0.0.CR3</version>\n+ <scope>test</scope>\n+ </dependency>\n+ </dependencies>\n+</profile>\n+<!-- clip -->\n+\n+p(info). %Adapter zdalny dla GlassFisha wykorzystuje bibliotekę Jersey do komunikacji z kontenerem poprzez JAX-RS (REST), dlatego też przez co został dodany do zależności. API Welda jest potrzebne do unmarshallingu wyjątków zwracanych przez testy w kontenerze.%\n+\n+Jak już dodasz nowe profile do swojego pliku pom.xml, kliknij prawym przyciskiem na projekcie w Eclipse i wybierze Maven > Update Project Configuration. Jeżeli na projekcie zostały oznaczone błędy kompilacji musisz aktywować jeden z przygotowanych profili.\n+\n+Pamiętaj, że masz dwie możliwości wyboru profili Mavena w Eclipse (zakładając że wykorzystuje \"Maven Integration for Eclipse\":http://www.eclipse.org/m2e):\n+\n+# Ręczna konfiguracja (standardowe podejście)\n+# Maven profile selector (JBoss Tools)\n+\n+W przewodniku \"Szybki start\"::/guides/getting_started#test_across_containers znajdziesz instrukcję jak uaktywnić profil Mavena. Kiedy już to zrobisz, projekt powinien budować się bez błędów.\n+\n+Adaptery zdalnych kontenerów zakładają, że te są uruchomione. W związku z tym, zajmijmy się ich konfiguracją, abyśmy mogli uruchamiać je komfortowo z IDE przed uruchomieniem testów.\n+\n+h3. Zarządzaj serwerami\n+\n+Najprostszym sposobem na zarządzanie zdalnymi kontenerami jest skonfigurowanie ich w swoim IDE. Jeżeli wolisz korzystać z konsoli, możesz pominąć ten krok i wystartować serwery odpowiednimi skryptami startującymi.\n+\n+Pokażemy jak dodać serwer (kontener) w Eclipse. Proces dla innych IDE jest podobny. Będziesz potrzebował zarówno \"JBoss Tools\":http://jboss.org/tools jak i \"GlassFish Java EE Application Server Plugin\":http://marketplace.eclipse.org/content/glassfish-java-ee-application-server-plugin-eclipse/metrics, oba dostępne w Eclipse MarketPlace. \n+\n+W Eclipse, wybierz Window > Show View > Servers z paska menu. Gdy widok już się otworzy, kliknij prawym przyciskiem i wybierz New > Server. Utwórz server dla JBoss AS 7.1:\n+\n+!/images/guides/arquillian_tutorial_2_new_jbossas_server.png!\n+\n+oraz kolejny dla GlassFish 3.1.2:\n+\n+!/images/guides/arquillian_tutorial_2_new_glassfish_server.png!\n+\n+p(info). %Kreator konfiguracji dla JBoss AS wymaga wskazania istniejącej instalacji. Natomiast kreator dla GlassFish 3.1.2 pozwala ściągnąć i rozpakować dystrybucję automatycznie.%\n+\n+Po zakończeniu procesu dodawania kontenerów, powinieneś zobaczyć je na liście w widoku serwerów:\n+\n+!/images/guides/arquillian_tutorial_2_servers_view.png!\n+\n+Żeby wystartować serwer, wybierz go z listy (jak na obrazku powyżej) i kliknij zieloną ikonę uruchomienia na pasku narzędzi.\n+\n+p(info). %Arquillian zakłada, że kontenery pracują na swoich domyślnych portach. Jeżeli je zmieniłeś musisz uaktualnić plik arquillian.xml i podać odpowiednie porty dla każdego kontenera. Zapoznaj się z \"przewodnikiem referencyjnym\":https://docs.jboss.org/author/display/ARQ/Container+adapters, aby dowiedzieć się jak to zrobić.%\n+\n+Teraz, gdy Twój kontener jest gotowy i uruchomiony, przyszła pora na wykonanie testów.\n+\n+h3. Uruchom testy Arquilliana\n+\n+W celu uruchomienia testów Arquilliana, musisz wykonać następujące kroki:\n+\n+# Uruchom zdalny kontener\n+# Uaktywnij profil Mavena odpowiadający uruchomionemu kontenerowi\n+# Uruchom testy\n+\n+Zacznijmy od JBoss AS.\n+\n+h4. Uruchom testy na JBoss AS\n+\n+Zacznij od uruchomienia kontenera JBoss AS. Otwórz widok Servers, wybierz JBoss AS i kliknij zielony przycisk \"odtwarzania\". Poczekaj aż serwer się uruchomi (nie powinno to zająć zbyt wiele czasu).\n+\n+Gdy kontener jest już uruchomiony, uaktywnij profil @arquillian-jbossas-remote@ używając konfiguracji we właściwościach Mavena lub JBoss Tools Maven Profile selector. Edytor profili poniżej pokazuje poprawne ustawienia.\n+\n+!/images/guides/arquillian_tutorial_2_jbossas_profile_selection.png!\n+\n+Na koniec kliknij prawym przyciskiem na klasę @BasketTest@ i wybierz Run As > JUnit Test. Powinieneś zauważyć sporą aktywność w oknie Console i później... *(greenbar)zielony pasek* w oknie testów JUnita!\n+\n+Testy możesz również uruchomić z linii poleceń, używając Mavena:\n+\n+bc(command). $ mvn test -Parquillian-jbossas-remote -Dtest=BasketTest\n+\n+Powinieneś zobaczyć następujący wynik wypisany na konsoli:\n+\n+bc(output). -------------------------------------------------------\n+T E S T S\n+-------------------------------------------------------\n+Running org.arquillian.example.BasketTest\n+...\n+Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.844 sec\n+\n+*Gratulacje!* Zdobyłeś swój pierwszy *(greenbar)zielony pasek* testując Arquillianem na zdalnym kontenerze!\n+\n+p(info). %Możesz również wstrzyknąć bean EJB @OrderRepository@ używająć @@Inject@ zamiast @@EJB@. Spróbuj sam!%\n+\n+Jeżeli chcesz się upewnić, że singleton faktycznie wykonuje swoje zadanie, śmiało usuń adnotację @@Singleton@ z klasy @SingletonOrderRepository@ i zastąp ją adnotacją @@Stateful@. Powinieneś zobaczyć błąd asercji podczas uruchamiania testów. Cofnij wprowadzone zmiany a pasek z powrotem stanie się zielony.\n+\n+Zostawmy na chwilę JBoss AS, więc skorzystaj widoku Servers i zatrzymaj go. Uruchomimy dokładnie ten sam test na serwerze GlassFish 3.1.2.\n+\n+h4. Uruchom testy na GlassFishu\n+\n+Żeby uruchomić testy na serwerze GlassFish, zacznij od jego wystartowania. Otwórz widok Servers, wybierz GlassFish 3.1.2 i kliknij zielony przycisk \"odtwarzania\". Poczekaj aż kontener się uruchomi.\n+\n+Gdy wszystko już jest gotowe, aktywuj profil Mavena @arquillian-glassfish-remote@ używając zakładki właściwości Mavena lub JBoss Tools Maven profile selector. Pamiętaj żeby deaktywować profil @arquillian-jbossas-remote@. Edytor profili poniżej pokazuje poprawną konfigurację.\n+\n+!/images/guides/arquillian_tutorial_2_glassfish_profile_selection.png!\n+\n+Na koniec, kliknij prawym przyciskiem na klasę @BasketTest@ i wybierz Run As > JUnit Test. Powinieneś dostrzec dużą aktywość w oknie Console i później... *(greenbar)zielony pasek* w oknie testów JUnita!\n+\n+Testy możesz również uruchomić z linii poleceń, używając Mavena:\n+\n+bc(command). $ mvn test -Parquillian-glassfish-remote -Dtest=BasketTest\n+\n+Powinieneś zobaczyć następujący wynik wypisany na konsoli:\n+\n+bc(output). -------------------------------------------------------\n+T E S T S\n+-------------------------------------------------------\n+Running org.arquillian.example.BasketTest\n+...\n+Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.549 sec\n+\n+*Gratulacje!* Zdobyłeś kolejny *(greenbar)zielony pasek*.\n+\n+Nadal powinieneś mieć możliwość uruchomienia test w osadzonym środowisku Embedded GlassFish używając profilu z poprzedniego przewodnika. Sprawdź to. Powinieneś również móc bez przeszkód debugować swój test. \n+\n+Oczywiście debugowanie testów w osadzonym kontenerze jest proste, skoro oba działają w tym samym procesie co środowisko uruchomieniowe. Ale co ze zdalnymi kontenerami?\n+\n+h3. Debuguj testy Arquilliana\n+\n+Debugowanie testów w zdalnym kontenerze? Wydaje się być trudne. Niespodzianka! Wcale takie nie jest. Jedyne co musisz zrobić, to zmodyfikować jeden z kroków i dodać jeden dodatkowy:\n+\n+# *Debuguj zdalny kontener*\n+# Uaktywnij profile Mavena odpowiadający uruchomionemu kontenerowi\n+# *Ustaw breakpoint*\n+# Uruchom test\n+\n+W widoku Servers, powinieneś widzieć ikonę robaka zaraz obok zielonej ikony odtwarzania. Kliknij ją aby uruchomić serwer w trybie debugowania. Eclipse automatycznie podłączy swój debuger do kontenera.\n+\n+Ustaw breakpoint w metodzie @addOrder()@ w @SingletonOrderRepository@.\n+Uruchom test ponownie klikając prawym przyciskiem i wybierając Run As > JUnit Test.\n+\n+p(warning). %Nie musisz wybierać Debug As > JUnit Test. Kod testu jest uruchamiany wewnątrz kontenera, który już jest w trybie debugowania.%\n+\n+Test powinien zatrzymać się na breakpoincie. Jeżeli korzystasz z JBoss AS możesz otworzyć konsolę administracyjną i potwierdzić, że aplikacja jest faktycznie uruchomiona na serwerze.\n+\n+Jeżeli przyjrzysz się sekcji stack trace w widoku Eclipse Debug, zauważysz że serwer jest sterowany przez zdalny protokół (JMX bądź Servlet) i JUnit został uruchomiony ponownie wewnątrz kontenera.\n+\n+!/images/guides/arquillian_tutorial_2_debug_remote_test.png!\n+\n+Możesz teraz spokojnie majsterkować przy serwerze korzystając z wygody swojego IDE.\n+\n+p(warning). %Jeżeli widzisz komunikat \"Source not found\" w edytorze podczas wstrzymania wykonywania na breakpoincie musisz dodać konfigurację debugowania do swojego projektu. Kliknij \"Edit Source Lookup Path...\", wtedy \"Add...\", wybierz Java Project, zaznacz checkbox obok swojego projektu i wybierz \"OK\". Voila!%\n+\n+h4. Otwieranie klas zewnętrznych bibliotek\n+\n+Jeżeli zamierzasz otwierać klasy z zewnętrznych bibliotek (kod spoza Twojej aplikacji), musisz je połączyć z ich kodami źródłowymi.\n+\n+p(info). %Można pominąć tę konfigurację gdy korzystasz z Mavena do zarządzania projektem oraz dana biblioteka jest dostępna w repozytoriach Mavena. Gdy natrafisz na breakpoint w jeszcze nie ściągniętej bibliotece, poczekaj chwilę aż zostanie pobrana i kod źródłowy zostanie wyświetlony. Jeżeli tak się nie stanie, to najprawdopodobniej kod nie jest dostępny w repozytorium i musisz kontynuować czytanie.%\n+\n+Oto kroki które musisz wykonać żeby podpiąć kody źródłowe biblioteki w konfiguracji debugowania:\n+\n+# Wybierz @Run > Debug Configurations...@ z głównego paska narzędzi\n+# Wybierz nazwę klasy testowej w kategorii JUnit (lub TetNG)\n+# Wybierz zakładkę Source\n+# Kliknij przycisk Add... po prawej stronie\n+# Jeżeli kody źródłowe są w innym projekcie:\n+## Wybierz Java Project\n+## Zaznacz projekt zawierający klasę którą chcesz debugować\n+## Kliknij OK w oknie Project Selection\n+# Jeżeli kody źródłowe są w bibliotece:\n+## Wybierz External Archive\n+## Przejdź do archiwum zawierającego kody źródłowe (które oczywiście musisz sam ściągnąć)\n+# Kliknij Close w oknie Debug Configurations\n+\n+Będziesz musiał powtórzyć te kroki dla każdej klasy którą chcesz debugować, jednak musisz zrobić to tylko raz (raz ustawiona konfiguracja debugowania jest stała).\n+\n+h3. Debuguj zarządany serwer","path":"guides/getting_started_rinse_and_repeat_pl.textile","position":488,"original_position":488,"commit_id":"45ef305b1c95137ea69e63037d9d519e19c567d6","original_commit_id":"45ef305b1c95137ea69e63037d9d519e19c567d6","user":{"login":"mmatloka","id":82916,"avatar_url":"https://secure.gravatar.com/avatar/de3a444ea45fdd4c93317f7df808589a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"de3a444ea45fdd4c93317f7df808589a","url":"https://api.github.com/users/mmatloka","html_url":"https://github.com/mmatloka","followers_url":"https://api.github.com/users/mmatloka/followers","following_url":"https://api.github.com/users/mmatloka/following","gists_url":"https://api.github.com/users/mmatloka/gists{/gist_id}","starred_url":"https://api.github.com/users/mmatloka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmatloka/subscriptions","organizations_url":"https://api.github.com/users/mmatloka/orgs","repos_url":"https://api.github.com/users/mmatloka/repos","events_url":"https://api.github.com/users/mmatloka/events{/privacy}","received_events_url":"https://api.github.com/users/mmatloka/received_events","type":"User"},"created_at":"2013-02-28T19:34:33Z","updated_at":"2013-02-28T19:34:33Z","_links":{"self":{"href":"https://api.github.com/repos/arquillian/arquillian.github.com/pulls/comments/3194432"},"html":{"href":"https://github.com/arquillian/arquillian.github.com/pull/197#discussion_r3194432"},"pull_request":{"href":"https://api.github.com/repos/arquillian/arquillian.github.com/pulls/197"}}}} | {
"id": 2431108,
"name": "arquillian.github.com",
"url": "https://github.com/arquillian/arquillian.github.com"
} | {
"id": null,
"login": "mmatloka",
"gravatar_id": "de3a444ea45fdd4c93317f7df808589a",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "arquillian",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-28T19:34:33 | null | {"repository":{"description":"Arquillian website source (develop branch) and hosting (master branch). Baked with Awestruct.","homepage":"http://arquillian.org","watchers":56,"stargazers":56,"forks":57,"fork":false,"size":382,"owner":"arquillian","private":false,"open_issues":73,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2011-09-21T09:43:42-07:00","pushed_at":"2013-02-24T03:51:33-08:00","master_branch":"develop","organization":"arquillian"},"actor_attributes":{"type":"User","name":"Michał Matłoka","location":"Poznań, Poland","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/arquillian/arquillian.github.com/pull/197#discussion_r3194432"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls/comments/6000649","id":6000649,"body":"This formatting is a bit odd. Why not simply:\r\n```\r\nif email is not None and \\\r\n 'email_from' in self.settings and \\\r\n ...:\r\n```\r\n?","diff_hunk":"@@ -0,0 +1,128 @@\n+# -*- coding: utf-8 -*-\n+\n+# Copyright (c) 2013, Camptocamp SA\n+# All rights reserved.\n+\n+# Redistribution and use in source and binary forms, with or without\n+# modification, are permitted provided that the following conditions are met:\n+\n+# 1. Redistributions of source code must retain the above copyright notice, this\n+# list of conditions and the following disclaimer.\n+# 2. Redistributions in binary form must reproduce the above copyright notice,\n+# this list of conditions and the following disclaimer in the documentation\n+# and/or other materials provided with the distribution.\n+\n+# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\" AND\n+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED\n+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE\n+# DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR\n+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES\n+# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;\n+# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND\n+# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT\n+# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS\n+# SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+\n+# The views and conclusions contained in the software and documentation are those\n+# of the authors and should not be interpreted as representing official policies,\n+# either expressed or implied, of the FreeBSD Project.\n+\n+\n+import random\n+import string\n+import logging\n+from datetime import datetime\n+from urlparse import urlparse\n+\n+from pyramid.httpexceptions import HTTPFound, HTTPBadRequest, \\\n+ HTTPNotFound, HTTPInternalServerError\n+from pyramid.view import view_config\n+\n+from c2cgeoportal.models import DBSession, Shorturl\n+from c2cgeoportal.lib.email_ import send_email\n+\n+\n+logger = logging.getLogger(__name__)\n+\n+\n+class Shortner(object):\n+\n+ def __init__(self, request):\n+ self.request = request\n+ self.settings = request.registry.settings.get('shortner', {})\n+\n+ @view_config(route_name='shortner_get')\n+ def get(self):\n+ ref = self.request.matchdict['ref']\n+ short_urls = DBSession.query(Shorturl).filter(Shorturl.ref == ref).all()\n+\n+ if len(short_urls) != 1:\n+ raise HTTPNotFound(\"Ref '%s' not found\" % ref)\n+\n+ short_urls[0].nb_hits += 1\n+ short_urls[0].last_hit = datetime.now()\n+\n+ return HTTPFound(location=short_urls[0].url)\n+\n+ @view_config(route_name='shortner_create', renderer='json')\n+ def create(self):\n+\n+ if 'url' not in self.request.params:\n+ raise HTTPBadRequest('The parameter url is required')\n+\n+ url = self.request.params['url']\n+\n+ # Check that it is an internal URL...\n+ hostname = urlparse(url).hostname\n+ if hostname != self.request.host:\n+ raise HTTPBadRequest(\"The requested host '%s' shound be '%s'\" % (\n+ hostname, self.request.host\n+ ))\n+\n+ tries = 0\n+ while True:\n+ ref = ''.join(\n+ random.choice(string.ascii_letters + string.digits)\n+ for i in range(self.settings.get('length', 4))\n+ )\n+ test_url = DBSession.query(Shorturl).filter(Shorturl.ref == ref).all()\n+ if len(test_url) == 0:\n+ break\n+ if tries > 20: # pragma: no cover\n+ message = \"No free ref found, considere to incrase the length\"\n+ logging.error(message)\n+ raise HTTPInternalServerError(message)\n+\n+ user_email = self.request.user.email \\\n+ if self.request.user is not None else None\n+ email = self.request.params.get('email') or user_email\n+ short_url = Shorturl()\n+ short_url.url = url\n+ short_url.ref = ref\n+ short_url.creator_email = email\n+ short_url.creation = datetime.now()\n+ short_url.nb_hits = 0\n+\n+ DBSession.add(short_url)\n+\n+ s_url = self.request.route_url('shortner_get', ref=ref)\n+\n+ if \\","path":"c2cgeoportal/views/shortner.py","position":110,"original_position":110,"commit_id":"f9800a0ec814cbca764fc462948b909b87a5d778","original_commit_id":"f9800a0ec814cbca764fc462948b909b87a5d778","user":{"login":"asaunier","id":1192331,"avatar_url":"https://2.gravatar.com/avatar/b7b80e5cbe5a60a446836ccaa4f11070?d=https%3A%2F%2Fidenticons.github.com%2F8ff06797ab99e9a0cf4486197812809b.png","gravatar_id":"b7b80e5cbe5a60a446836ccaa4f11070","url":"https://api.github.com/users/asaunier","html_url":"https://github.com/asaunier","followers_url":"https://api.github.com/users/asaunier/followers","following_url":"https://api.github.com/users/asaunier/following{/other_user}","gists_url":"https://api.github.com/users/asaunier/gists{/gist_id}","starred_url":"https://api.github.com/users/asaunier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asaunier/subscriptions","organizations_url":"https://api.github.com/users/asaunier/orgs","repos_url":"https://api.github.com/users/asaunier/repos","events_url":"https://api.github.com/users/asaunier/events{/privacy}","received_events_url":"https://api.github.com/users/asaunier/received_events","type":"User"},"created_at":"2013-08-27T09:26:59Z","updated_at":"2013-08-27T09:26:59Z","html_url":"https://github.com/camptocamp/c2cgeoportal/pull/667#discussion_r6000649","pull_request_url":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls/667","_links":{"self":{"href":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls/comments/6000649"},"html":{"href":"https://github.com/camptocamp/c2cgeoportal/pull/667#discussion_r6000649"},"pull_request":{"href":"https://api.github.com/repos/camptocamp/c2cgeoportal/pulls/667"}}}} | {
"id": 2932773,
"name": "c2cgeoportal",
"url": "https://github.com/camptocamp/c2cgeoportal"
} | {
"id": null,
"login": "asaunier",
"gravatar_id": "b7b80e5cbe5a60a446836ccaa4f11070",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "camptocamp",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-27T09:26:59 | null | {"repository":{"description":"","homepage":"","watchers":7,"stargazers":7,"forks":5,"fork":false,"size":78484,"owner":"camptocamp","private":false,"open_issues":82,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-12-07T05:42:59-08:00","pushed_at":"2013-08-26T06:42:36-07:00","master_branch":"master","organization":"camptocamp"},"actor_attributes":{"type":"User","name":"Alex Saunier","company":"Camptocamp SA","location":"Lausanne Switzerland","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/camptocamp/c2cgeoportal/pull/667#discussion_r6000649"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/cappuccino/cappuccino/pulls/comments/3685088","id":3685088,"body":"Yes, I think you are correct. There will need to be a removeObserver before line 322. Should I add this as a commit to this pull request?","diff_hunk":"@@ -319,9 +319,6 @@ var _CPimageAndTextViewFrameSizeChangedFlag = 1 << 0,\n if (_image == anImage)\n return;\n \n- if ([_image delegate] === self)\n- [[CPNotificationCenter defaultCenter] removeObserver:self name:CPImageDidLoadNotification object:_image];\n-","path":"AppKit/_CPImageAndTextView.j","position":6,"original_position":6,"commit_id":"aa0602dcbba6a37e8d8790669475eed4b390fb27","original_commit_id":"aa0602dcbba6a37e8d8790669475eed4b390fb27","user":{"login":"saikat","id":83782,"avatar_url":"https://secure.gravatar.com/avatar/8b59c2bf33544984d2611f06f613e891?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"8b59c2bf33544984d2611f06f613e891","url":"https://api.github.com/users/saikat","html_url":"https://github.com/saikat","followers_url":"https://api.github.com/users/saikat/followers","following_url":"https://api.github.com/users/saikat/following","gists_url":"https://api.github.com/users/saikat/gists{/gist_id}","starred_url":"https://api.github.com/users/saikat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saikat/subscriptions","organizations_url":"https://api.github.com/users/saikat/orgs","repos_url":"https://api.github.com/users/saikat/repos","events_url":"https://api.github.com/users/saikat/events{/privacy}","received_events_url":"https://api.github.com/users/saikat/received_events","type":"User"},"created_at":"2013-04-06T23:12:20Z","updated_at":"2013-04-06T23:12:20Z","html_url":"https://github.com/cappuccino/cappuccino/pull/1889#discussion_r3685088","pull_request_url":"https://api.github.com/repos/cappuccino/cappuccino/pulls/1889","_links":{"self":{"href":"https://api.github.com/repos/cappuccino/cappuccino/pulls/comments/3685088"},"html":{"href":"https://github.com/cappuccino/cappuccino/pull/1889#discussion_r3685088"},"pull_request":{"href":"https://api.github.com/repos/cappuccino/cappuccino/pulls/1889"}}}} | {
"id": 49107,
"name": "cappuccino",
"url": "https://github.com/cappuccino/cappuccino"
} | {
"id": null,
"login": "saikat",
"gravatar_id": "8b59c2bf33544984d2611f06f613e891",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "cappuccino",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-06T23:12:20 | null | {"repository":{"description":"Web Application Framework in JavaScript and Objective-J","homepage":"http://cappuccino-project.org","watchers":1842,"stargazers":1842,"forks":291,"fork":false,"size":4008,"owner":"cappuccino","private":false,"open_issues":134,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Objective-J","created_at":"2008-09-04T03:43:35-07:00","pushed_at":"2013-04-06T05:49:43-07:00","integrate_branch":"integration","master_branch":"master","organization":"cappuccino"},"actor_attributes":{"type":"User","name":"Saikat Chakrabarti","company":"Mockingbird","blog":"http://techblog.gomockingbird.com","location":"San Francisco, CA","email":"[email protected], saikat"},"url":"https://github.com/cappuccino/cappuccino/pull/1889#discussion_r3685088"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/collective/collective.lineage/pulls/comments/6869414","id":6869414,"diff_hunk":"@@ -45,7 +47,7 @@ def disableFolder(folder):\n zope.event.notify(ChildSiteRemovedEvent(folder))\n \n \n-@adapter(ISubtypeAddedEvent)\n+@adapter(ISubtypeAddedEvent, IImagingSchema)","path":"src/collective/lineage/subscribers.py","position":14,"original_position":14,"commit_id":"ea87ce4c16f030bb109573809c7d7126e5591461","original_commit_id":"ea87ce4c16f030bb109573809c7d7126e5591461","user":{"login":"claytron","id":41368,"avatar_url":"https://0.gravatar.com/avatar/b5157e29f3e0cd4cd5ff3a48f3702e73?d=https%3A%2F%2Fidenticons.github.com%2F49ca11219d4192ba6f36a4540ed5fac5.png","gravatar_id":"b5157e29f3e0cd4cd5ff3a48f3702e73","url":"https://api.github.com/users/claytron","html_url":"https://github.com/claytron","followers_url":"https://api.github.com/users/claytron/followers","following_url":"https://api.github.com/users/claytron/following{/other_user}","gists_url":"https://api.github.com/users/claytron/gists{/gist_id}","starred_url":"https://api.github.com/users/claytron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claytron/subscriptions","organizations_url":"https://api.github.com/users/claytron/orgs","repos_url":"https://api.github.com/users/claytron/repos","events_url":"https://api.github.com/users/claytron/events{/privacy}","received_events_url":"https://api.github.com/users/claytron/received_events","type":"User","site_admin":false},"body":"This is just for when the event fires. Is that the only time there is a problem with the missing `IImagingSchema` adaptation?","created_at":"2013-10-09T20:24:31Z","updated_at":"2013-10-09T20:24:31Z","html_url":"https://github.com/collective/collective.lineage/pull/20#discussion_r6869414","pull_request_url":"https://api.github.com/repos/collective/collective.lineage/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/collective/collective.lineage/pulls/comments/6869414"},"html":{"href":"https://github.com/collective/collective.lineage/pull/20#discussion_r6869414"},"pull_request":{"href":"https://api.github.com/repos/collective/collective.lineage/pulls/20"}}}} | {
"id": 3264054,
"name": "collective.lineage",
"url": "https://github.com/collective/collective.lineage"
} | {
"id": null,
"login": "claytron",
"gravatar_id": "b5157e29f3e0cd4cd5ff3a48f3702e73",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "collective",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-09T20:24:31 | null | {"repository":{"watchers":4,"stargazers":4,"forks":2,"fork":false,"size":440,"owner":"collective","private":false,"open_issues":9,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-01-25T02:40:05-08:00","pushed_at":"2013-10-07T10:47:47-07:00","master_branch":"master","organization":"collective"},"actor_attributes":{"type":"User","name":"Clayton Parker","company":"Six Feet Up, Inc.","blog":"http://claytron.com","location":"planet earth","email":"[email protected]"},"url":"https://github.com/collective/collective.lineage/pull/20#discussion_r6869414"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/dreamwidth/dw-free/pulls/comments/4146894","id":4146894,"body":"Interesting... shouldn't POST override GET? Why do you go the other way?","diff_hunk":"@@ -0,0 +1,183 @@\n+#!/usr/bin/perl\n+##\n+## DW::Controller::Manage::Externalaccounts::twittersettings\n+##\n+## /manage/externalaccounts/twittersettings\n+##\n+## Authors:\n+## Simon Waldman <[email protected]>\n+##\n+## Copyright (c) 2012 by Dreamwidth Studios, LLC.\n+##\n+## This program is free software; you may redistribute it and/or modify it under\n+## the same terms as Perl itself. For a copy of the license, please reference\n+## 'perldoc perlartistic' or 'perldoc perlgpl'.\n+##\n+#\n+\n+\n+package DW::Controller::Manage::Externalaccounts::Twittersettings;\n+\n+use strict;\n+use warnings;\n+use DW::Controller;\n+use DW::Routing;\n+use DW::Template;\n+use DW::External::Account;\n+use DW::External::OAuth;\n+\n+DW::Routing->register_string( \"/manage/externalaccounts/twittersettings\", \\&twittersettings_handler, app=>1 );\n+\n+sub twittersettings_handler {\n+ my ( $ok, $rv ) = controller( anonymous => 0 );\n+ return $rv unless $ok;\n+\n+ my $u = $rv->{u};\n+\n+ return error_ml( 'twitter.twitter_disabled' ) unless $LJ::TWITTER{enabled};\n+\n+ my $r = DW::Request->get;\n+ my $get_args = $r->get_args;\n+ my $post_args = $r->post_args;\n+\n+ my @message_list; #non-error messages to show at the top of the form\n+ my @error_list; #error messages to show at the top of the form\n+ my $vars; #hashref for outputs to the template;\n+\n+ my $acctid = $get_args->{acctid} || $post_args->{acctid};","path":"cgi-bin/DW/Controller/Manage/Externalaccounts/Twittersettings.pm","position":47,"original_position":47,"commit_id":"556bb0db13e155d2e17dc309add96f6ea54e33ad","original_commit_id":"556bb0db13e155d2e17dc309add96f6ea54e33ad","user":{"login":"xb95","id":361428,"avatar_url":"https://secure.gravatar.com/avatar/f5eb27f42a3a520903f1a4b8e55744e4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"f5eb27f42a3a520903f1a4b8e55744e4","url":"https://api.github.com/users/xb95","html_url":"https://github.com/xb95","followers_url":"https://api.github.com/users/xb95/followers","following_url":"https://api.github.com/users/xb95/following{/other_user}","gists_url":"https://api.github.com/users/xb95/gists{/gist_id}","starred_url":"https://api.github.com/users/xb95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xb95/subscriptions","organizations_url":"https://api.github.com/users/xb95/orgs","repos_url":"https://api.github.com/users/xb95/repos","events_url":"https://api.github.com/users/xb95/events{/privacy}","received_events_url":"https://api.github.com/users/xb95/received_events","type":"User"},"created_at":"2013-05-09T00:43:57Z","updated_at":"2013-05-09T00:43:57Z","html_url":"https://github.com/dreamwidth/dw-free/pull/250#discussion_r4146894","pull_request_url":"https://api.github.com/repos/dreamwidth/dw-free/pulls/250","_links":{"self":{"href":"https://api.github.com/repos/dreamwidth/dw-free/pulls/comments/4146894"},"html":{"href":"https://github.com/dreamwidth/dw-free/pull/250#discussion_r4146894"},"pull_request":{"href":"https://api.github.com/repos/dreamwidth/dw-free/pulls/250"}}}} | {
"id": 4257922,
"name": "dw-free",
"url": "https://github.com/dreamwidth/dw-free"
} | {
"id": null,
"login": "xb95",
"gravatar_id": "f5eb27f42a3a520903f1a4b8e55744e4",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "dreamwidth",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-09T00:43:57 | null | {"repository":{"description":"Dreamwidth's open source repository","watchers":26,"stargazers":26,"forks":53,"fork":false,"size":904,"owner":"dreamwidth","private":false,"open_issues":8,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Perl","created_at":"2012-05-07T23:37:02-07:00","pushed_at":"2013-05-07T00:54:16-07:00","master_branch":"develop","organization":"dreamwidth"},"actor_attributes":{"type":"User","name":"Mark Smith","company":"Bump Technologies","blog":"http://qq.is/","location":"Mountain View, CA","email":"[email protected]"},"url":"https://github.com/dreamwidth/dw-free/pull/250#discussion_r4146894"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-goodies/pulls/comments/7807675","id":7807675,"diff_hunk":"@@ -0,0 +1,58 @@\n+package DDG::Goodie::Sudoku;\n+# ABSTRACT: Show a small sudoku puzzle.\n+\n+use DDG::Goodie;\n+use Games::Sudoku::Component;\n+\n+use strict;\n+use warnings;\n+\n+triggers startend => 'sudoku';\n+\n+zci is_cached => 0;\n+zci answer_type => \"sudoku\";\n+\n+primary_example_queries 'sudoku easy';\n+description 'show a little sudoku you can play in the browser';\n+\n+name 'Sudoku';\n+category 'random';\n+attribution github => ['https://github.com/DrDub', 'DrDub'],\n+ web => ['http://duboue.net/', 'Pablo Duboue'];\n+\n+handle remainder => sub {","path":"lib/DDG/Goodie/Sudoku.pm","position":null,"original_position":23,"commit_id":"3a6c91df9984280547b35ca0354f37588650198b","original_commit_id":"aa555cfe332276acb0f6bf86309fa4ce08c7f2bd","user":{"login":"jagtalon","id":81969,"avatar_url":"https://0.gravatar.com/avatar/8eb5461f8bbecfbe25145b719ad8720b?d=https%3A%2F%2Fidenticons.github.com%2Fc2b9b2c416e6e64bebc29c99ba8abcb0.png&r=x","gravatar_id":"8eb5461f8bbecfbe25145b719ad8720b","url":"https://api.github.com/users/jagtalon","html_url":"https://github.com/jagtalon","followers_url":"https://api.github.com/users/jagtalon/followers","following_url":"https://api.github.com/users/jagtalon/following{/other_user}","gists_url":"https://api.github.com/users/jagtalon/gists{/gist_id}","starred_url":"https://api.github.com/users/jagtalon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jagtalon/subscriptions","organizations_url":"https://api.github.com/users/jagtalon/orgs","repos_url":"https://api.github.com/users/jagtalon/repos","events_url":"https://api.github.com/users/jagtalon/events{/privacy}","received_events_url":"https://api.github.com/users/jagtalon/received_events","type":"User","site_admin":false},"body":"We should probably be stricter here. \"sudoku party\", although I'm sure they're not very popular, will trigger this instant answer.","created_at":"2013-11-20T22:03:41Z","updated_at":"2013-11-20T22:03:41Z","html_url":"https://github.com/duckduckgo/zeroclickinfo-goodies/pull/255#discussion_r7807675","pull_request_url":"https://api.github.com/repos/duckduckgo/zeroclickinfo-goodies/pulls/255","_links":{"self":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-goodies/pulls/comments/7807675"},"html":{"href":"https://github.com/duckduckgo/zeroclickinfo-goodies/pull/255#discussion_r7807675"},"pull_request":{"href":"https://api.github.com/repos/duckduckgo/zeroclickinfo-goodies/pulls/255"}}}} | {
"id": 2164979,
"name": "zeroclickinfo-goodies",
"url": "https://github.com/duckduckgo/zeroclickinfo-goodies"
} | {
"id": null,
"login": "jagtalon",
"gravatar_id": "8eb5461f8bbecfbe25145b719ad8720b",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "duckduckgo",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-20T22:03:41 | null | {"repository":{"description":"DuckDuckGo instant answer plugins based on Perl functions","homepage":"http://duckduckhack.com/","watchers":169,"stargazers":169,"forks":208,"fork":false,"size":4583,"owner":"duckduckgo","private":false,"open_issues":40,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Perl","created_at":"2011-08-06T06:26:05-07:00","pushed_at":"2013-11-15T09:30:37-08:00","master_branch":"master","organization":"duckduckgo"},"actor_attributes":{"type":"User","name":"Jag Talon","company":"DuckDuckGo","blog":"jagtalon.com","location":"New Jersey","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/duckduckgo/zeroclickinfo-goodies/pull/255#discussion_r7807675"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/ela-compil/sandwich/pulls/comments/7091864","id":7091864,"diff_hunk":"@@ -29,6 +33,8 @@ public void Run()\n listener.Start();\n Log.Info(\"Start Http server\");\n \n+ ConnectBase();","path":"Source/sandwich/HttpServer.cs","position":25,"original_position":25,"commit_id":"ce608fa0448f73a0b59aa2cd1b0d26e33b841d99","original_commit_id":"ce608fa0448f73a0b59aa2cd1b0d26e33b841d99","user":{"login":"gralin","id":3457048,"avatar_url":"https://2.gravatar.com/avatar/ba019971aa3e173ba08ba0c6df2a02a8?d=https%3A%2F%2Fidenticons.github.com%2F3ec3bd20c6c5abcfccde89b8289333a3.png","gravatar_id":"ba019971aa3e173ba08ba0c6df2a02a8","url":"https://api.github.com/users/gralin","html_url":"https://github.com/gralin","followers_url":"https://api.github.com/users/gralin/followers","following_url":"https://api.github.com/users/gralin/following{/other_user}","gists_url":"https://api.github.com/users/gralin/gists{/gist_id}","starred_url":"https://api.github.com/users/gralin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gralin/subscriptions","organizations_url":"https://api.github.com/users/gralin/orgs","repos_url":"https://api.github.com/users/gralin/repos","events_url":"https://api.github.com/users/gralin/events{/privacy}","received_events_url":"https://api.github.com/users/gralin/received_events","type":"User","site_admin":false},"body":"InitializeDatabase instead of ConnectBase","created_at":"2013-10-21T12:31:22Z","updated_at":"2013-10-21T12:31:22Z","html_url":"https://github.com/ela-compil/sandwich/pull/15#discussion_r7091864","pull_request_url":"https://api.github.com/repos/ela-compil/sandwich/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/ela-compil/sandwich/pulls/comments/7091864"},"html":{"href":"https://github.com/ela-compil/sandwich/pull/15#discussion_r7091864"},"pull_request":{"href":"https://api.github.com/repos/ela-compil/sandwich/pulls/15"}}}} | {
"id": 12723523,
"name": "sandwich",
"url": "https://github.com/ela-compil/sandwich"
} | {
"id": null,
"login": "gralin",
"gravatar_id": "ba019971aa3e173ba08ba0c6df2a02a8",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "ela-compil",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-21T12:31:22 | null | {"repository":{"description":"Sandwich module","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":2524,"owner":"ela-compil","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C#","created_at":"2013-09-10T00:50:58-07:00","pushed_at":"2013-10-21T05:13:37-07:00","master_branch":"master","organization":"ela-compil"},"actor_attributes":{"type":"User","name":"Jakub Bartkowiak","company":"Ela-compil sp. z o. o.","location":"Poznań, Poland","email":"[email protected]"},"url":"https://github.com/ela-compil/sandwich/pull/15#discussion_r7091864"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/getpelican/pelican/pulls/comments/5588579","id":5588579,"body":"The class is useful to store the dict of Reader instances (and to avoid instantiating one Reader object for each file as it was done before). I'm open to use another implementation, but it seems to be the most convenient.","diff_hunk":"@@ -339,74 +337,90 @@ def read(self, source_path):\n return content, metadata\n \n \n-EXTENSIONS = {}\n+class Readers(object):","path":"pelican/readers.py","position":75,"original_position":75,"commit_id":"f343069362f0bc6f66ef3240df96c8b2906adef4","original_commit_id":"f343069362f0bc6f66ef3240df96c8b2906adef4","user":{"login":"saimn","id":311639,"avatar_url":"https://secure.gravatar.com/avatar/68055804a3fffd2dceba5d6dcae00121?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"68055804a3fffd2dceba5d6dcae00121","url":"https://api.github.com/users/saimn","html_url":"https://github.com/saimn","followers_url":"https://api.github.com/users/saimn/followers","following_url":"https://api.github.com/users/saimn/following{/other_user}","gists_url":"https://api.github.com/users/saimn/gists{/gist_id}","starred_url":"https://api.github.com/users/saimn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saimn/subscriptions","organizations_url":"https://api.github.com/users/saimn/orgs","repos_url":"https://api.github.com/users/saimn/repos","events_url":"https://api.github.com/users/saimn/events{/privacy}","received_events_url":"https://api.github.com/users/saimn/received_events","type":"User"},"created_at":"2013-08-05T20:07:38Z","updated_at":"2013-08-05T20:07:38Z","html_url":"https://github.com/getpelican/pelican/pull/1011#discussion_r5588579","pull_request_url":"https://api.github.com/repos/getpelican/pelican/pulls/1011","_links":{"self":{"href":"https://api.github.com/repos/getpelican/pelican/pulls/comments/5588579"},"html":{"href":"https://github.com/getpelican/pelican/pull/1011#discussion_r5588579"},"pull_request":{"href":"https://api.github.com/repos/getpelican/pelican/pulls/1011"}}}} | {
"id": 993110,
"name": "pelican",
"url": "https://github.com/getpelican/pelican"
} | {
"id": null,
"login": "saimn",
"gravatar_id": "68055804a3fffd2dceba5d6dcae00121",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "getpelican",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-05T20:07:38 | null | {"repository":{"description":"Static site generator that supports Markdown and reST syntax. Powered by Python.","homepage":"http://getpelican.com/","watchers":2266,"stargazers":2266,"forks":591,"fork":false,"size":7585,"owner":"getpelican","private":false,"open_issues":78,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2010-10-16T11:57:40-07:00","pushed_at":"2013-08-05T08:54:36-07:00","master_branch":"master","organization":"getpelican"},"actor_attributes":{"type":"User","name":"Simon Conseil","blog":"http://saimon.org/","location":"","email":"[email protected]"},"url":"https://github.com/getpelican/pelican/pull/1011#discussion_r5588579"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/hedgeyedev/paypal-ipn-forwarder/pulls/comments/4890449","id":4890449,"body":"config.yml does not have the server url. config.yml has the information needed to send the emails out","diff_hunk":"@@ -1,45 +1,52 @@\n require_relative 'poller'\n class Router\n \n- def initialize(target, server_client)\n- @target = target\n- @killing = false\n- @server_client = server_client\n- end\n+ TEST_ON = 'on'\n+ TEST_OFF = 'off'\n \n+ def initialize(target)\n+ @target = target\n+ @server_url = load_server_url\n+ end\n \n def forward_ipn(ipn)\n- if(ipn == \"VERIFIED\")\n- send_verified\n- else\n- send_ipn(ipn)\n- end\n+ if (ipn == 'VERIFIED')\n+ send_verified\n+ else\n+ send_ipn(ipn)\n end\n+ end\n \n- def send_verified#same functionality as send_verification\n+ def send_verified #same functionality as send_verification\n @target.verified\n end\n \n def send_ipn(ipn)\n- @target.send_ipn(ipn)\n- end\n-\n- def load_server_url\n- url = YAML::load_file(File.expand_path(\"../../config/router.yml\", __FILE__))\n+ @target.send_ipn(ipn)\n end\n \n def test_mode_on\n- RestClient.post load_server_url, my_ip_address\n+ set_test_mode(TEST_ON)\n end\n \n def test_mode_off\n- url = 'http://superbox.hedgeye.com:8810/test/'\n- message = ip_address\n- @server_client.post @url, message\n+ set_test_mode(TEST_OFF)\n+ end\n+\n+ #from: http://claudiofloreani.blogspot.com/2011/10/ruby-how-to-get-my-private-and-public.html\n+ def my_ip_address\n+ Socket.ip_address_list.detect { |intf| intf.ipv4_private? }.ip_address\n+ end\n+\n+ private\n+\n+ def load_server_url\n+ url = YAML::load_file(File.expand_path('../../config/config.yml', __FILE__))","path":"lib/router.rb","position":64,"original_position":64,"commit_id":"b77930ad765a52b120acfa1a95b777fa5395250c","original_commit_id":"b77930ad765a52b120acfa1a95b777fa5395250c","user":{"login":"dostapenko","id":4440649,"avatar_url":"https://secure.gravatar.com/avatar/6547acaea3a0e64620572dabef85a300?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"6547acaea3a0e64620572dabef85a300","url":"https://api.github.com/users/dostapenko","html_url":"https://github.com/dostapenko","followers_url":"https://api.github.com/users/dostapenko/followers","following_url":"https://api.github.com/users/dostapenko/following{/other_user}","gists_url":"https://api.github.com/users/dostapenko/gists{/gist_id}","starred_url":"https://api.github.com/users/dostapenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dostapenko/subscriptions","organizations_url":"https://api.github.com/users/dostapenko/orgs","repos_url":"https://api.github.com/users/dostapenko/repos","events_url":"https://api.github.com/users/dostapenko/events{/privacy}","received_events_url":"https://api.github.com/users/dostapenko/received_events","type":"User"},"created_at":"2013-06-26T13:24:58Z","updated_at":"2013-06-26T13:24:58Z","html_url":"https://github.com/hedgeyedev/paypal-ipn-forwarder/pull/25#discussion_r4890449","pull_request_url":"https://api.github.com/repos/hedgeyedev/paypal-ipn-forwarder/pulls/25","_links":{"self":{"href":"https://api.github.com/repos/hedgeyedev/paypal-ipn-forwarder/pulls/comments/4890449"},"html":{"href":"https://github.com/hedgeyedev/paypal-ipn-forwarder/pull/25#discussion_r4890449"},"pull_request":{"href":"https://api.github.com/repos/hedgeyedev/paypal-ipn-forwarder/pulls/25"}}}} | {
"id": 10341211,
"name": "paypal-ipn-forwarder",
"url": "https://github.com/hedgeyedev/paypal-ipn-forwarder"
} | {
"id": null,
"login": "dostapenko",
"gravatar_id": "6547acaea3a0e64620572dabef85a300",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "hedgeyedev",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-26T13:24:58 | null | {"repository":{"description":"Forward PayPal IPN notifications to your development machine","watchers":0,"stargazers":0,"forks":3,"fork":false,"size":280,"owner":"hedgeyedev","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-05-28T10:28:44-07:00","pushed_at":"2013-06-25T16:02:05-07:00","master_branch":"master","organization":"hedgeyedev"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/hedgeyedev/paypal-ipn-forwarder/pull/25#discussion_r4890449"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/4364997","id":4364997,"body":"I think you can remove the commented lines :)","diff_hunk":"@@ -0,0 +1,136 @@\n+package org.infinispan.loaders;\n+\n+import org.infinispan.Cache;\n+import org.infinispan.configuration.cache.CacheMode;\n+import org.infinispan.configuration.cache.ConfigurationBuilder;\n+import org.infinispan.configuration.cache.VersioningScheme;\n+import org.infinispan.container.DataContainer;\n+import org.infinispan.container.entries.InternalCacheEntry;\n+import org.infinispan.loaders.dummy.DummyInMemoryCacheStoreConfigurationBuilder;\n+import org.infinispan.manager.EmbeddedCacheManager;\n+import org.infinispan.test.SingleCacheManagerTest;\n+import org.infinispan.test.TestingUtil;\n+import org.infinispan.test.fwk.TestCacheManagerFactory;\n+import org.infinispan.transaction.TransactionMode;\n+import org.infinispan.util.concurrent.IsolationLevel;\n+import org.testng.annotations.Test;\n+\n+import java.util.concurrent.Callable;\n+\n+import static java.util.concurrent.TimeUnit.MILLISECONDS;\n+import static org.infinispan.test.TestingUtil.withTx;\n+import static org.testng.AssertJUnit.*;\n+\n+/**\n+ * Tests write skew functionality when interacting with a cache loader.\n+ *\n+ * @author Pedro Ruivo\n+ * @author Galder Zamarreño\n+ * @since 5.3\n+ */\n+@Test(groups = \"functional\", testName = \"loaders.WriteSkewCacheLoaderFunctionalTest\")\n+public class WriteSkewCacheLoaderFunctionalTest extends SingleCacheManagerTest {\n+\n+// Cache cache;","path":"core/src/test/java/org/infinispan/loaders/WriteSkewCacheLoaderFunctionalTest.java","position":34,"original_position":34,"commit_id":"51440962309b48cc29b0216d06945aa942570f10","original_commit_id":"51440962309b48cc29b0216d06945aa942570f10","user":{"login":"pruivo","id":1492066,"avatar_url":"https://secure.gravatar.com/avatar/c6ad2ad7863a47cedec1531347c817d7?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"c6ad2ad7863a47cedec1531347c817d7","url":"https://api.github.com/users/pruivo","html_url":"https://github.com/pruivo","followers_url":"https://api.github.com/users/pruivo/followers","following_url":"https://api.github.com/users/pruivo/following{/other_user}","gists_url":"https://api.github.com/users/pruivo/gists{/gist_id}","starred_url":"https://api.github.com/users/pruivo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pruivo/subscriptions","organizations_url":"https://api.github.com/users/pruivo/orgs","repos_url":"https://api.github.com/users/pruivo/repos","events_url":"https://api.github.com/users/pruivo/events{/privacy}","received_events_url":"https://api.github.com/users/pruivo/received_events","type":"User"},"created_at":"2013-05-23T17:06:01Z","updated_at":"2013-05-23T17:06:01Z","html_url":"https://github.com/infinispan/infinispan/pull/1829#discussion_r4364997","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/1829","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/4364997"},"html":{"href":"https://github.com/infinispan/infinispan/pull/1829#discussion_r4364997"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/1829"}}}} | {
"id": 1050944,
"name": "infinispan",
"url": "https://github.com/infinispan/infinispan"
} | {
"id": null,
"login": "pruivo",
"gravatar_id": "c6ad2ad7863a47cedec1531347c817d7",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "infinispan",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-23T17:06:01 | null | {"repository":{"description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","homepage":"http://www.infinispan.org","watchers":224,"stargazers":224,"forks":138,"fork":false,"size":26108,"owner":"infinispan","private":false,"open_issues":3,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2010-11-04T05:33:19-07:00","pushed_at":"2013-05-23T09:38:02-07:00","master_branch":"master","organization":"infinispan"},"actor_attributes":{"type":"User","name":"Pedro Ruivo","company":"INESC-ID","blog":"www.sites.google.com/site/pedroruivo2/","location":"Lisbon","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/infinispan/infinispan/pull/1829#discussion_r4364997"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/3326193","id":3326193,"body":"Can you explain this change? I'm not getting it","diff_hunk":"@@ -187,7 +183,7 @@ public static void assertFileExistsHavingRLCount(Cache cache, String fileName, S\n }\n FileReadLockKey readLockKey = new FileReadLockKey(indexName,fileName);\n Object value = cache.get(readLockKey);\n- if (expectedReadcount == 1) {\n+ if (expectedReadcount <= 1) {","path":"lucene/lucene-v3/src/test/java/org/infinispan/lucene/DirectoryIntegrityCheck.java","position":16,"original_position":16,"commit_id":"7d25c81d6f181c5d21f042789c6457813bbb7151","original_commit_id":"7d25c81d6f181c5d21f042789c6457813bbb7151","user":{"login":"Sanne","id":42573,"avatar_url":"https://secure.gravatar.com/avatar/6886c741845f42bd459dc5dade7b1fc2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"6886c741845f42bd459dc5dade7b1fc2","url":"https://api.github.com/users/Sanne","html_url":"https://github.com/Sanne","followers_url":"https://api.github.com/users/Sanne/followers","following_url":"https://api.github.com/users/Sanne/following","gists_url":"https://api.github.com/users/Sanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanne/subscriptions","organizations_url":"https://api.github.com/users/Sanne/orgs","repos_url":"https://api.github.com/users/Sanne/repos","events_url":"https://api.github.com/users/Sanne/events{/privacy}","received_events_url":"https://api.github.com/users/Sanne/received_events","type":"User"},"created_at":"2013-03-11T22:00:19Z","updated_at":"2013-03-11T22:00:19Z","html_url":"https://github.com/infinispan/infinispan/pull/1656#discussion_r3326193","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/1656","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/3326193"},"html":{"href":"https://github.com/infinispan/infinispan/pull/1656#discussion_r3326193"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/1656"}}}} | {
"id": 1050944,
"name": "infinispan",
"url": "https://github.com/infinispan/infinispan"
} | {
"id": null,
"login": "Sanne",
"gravatar_id": "6886c741845f42bd459dc5dade7b1fc2",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "infinispan",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-11T22:00:19 | null | {"repository":{"description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","homepage":"http://www.infinispan.org","watchers":202,"stargazers":202,"forks":130,"fork":false,"size":23452,"owner":"infinispan","private":false,"open_issues":16,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2010-11-04T05:33:19-07:00","pushed_at":"2013-03-11T14:01:53-07:00","master_branch":"master","organization":"infinispan"},"actor_attributes":{"type":"User","name":"Sanne Grinovero","company":"Red Hat","blog":"http://in.relation.to/Bloggers/Sanne","location":"United Kingdom","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/infinispan/infinispan/pull/1656#discussion_r3326193"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/3382076","id":3382076,"body":"javadoc..","diff_hunk":"@@ -0,0 +1,45 @@\n+/*\n+ * JBoss, Home of Professional Open Source\n+ * Copyright 2012 Red Hat Inc. and/or its affiliates and other\n+ * contributors as indicated by the @author tags. All rights reserved.\n+ * See the copyright.txt in the distribution for a full listing of\n+ * individual contributors.\n+ * \n+ * This is free software; you can redistribute it and/or modify it\n+ * under the terms of the GNU Lesser General Public License as\n+ * published by the Free Software Foundation; either version 2.1 of\n+ * the License, or (at your option) any later version.\n+ * \n+ * This software is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU\n+ * Lesser General Public License for more details.\n+ * \n+ * You should have received a copy of the GNU Lesser General Public\n+ * License along with this software; if not, write to the Free\n+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA\n+ * 02110-1301 USA, or see the FSF site: http://www.fsf.org.\n+ */\n+\n+package org.infinispan.loaders.mongodb.configuration;\n+\n+/**\n+ * @author Guillaume Scheibel <[email protected]>\n+ */\n+public interface MongoDBCacheStoreConfigurationChildBuilder {","path":"cachestore/mongodb/src/main/java/org/infinispan/loaders/mongodb/configuration/MongoDBCacheStoreConfigurationChildBuilder.java","position":29,"original_position":29,"commit_id":"ed937ea94cf1d6db199fda36fcf53ee8237f053c","original_commit_id":"ed937ea94cf1d6db199fda36fcf53ee8237f053c","user":{"login":"Sanne","id":42573,"avatar_url":"https://secure.gravatar.com/avatar/6886c741845f42bd459dc5dade7b1fc2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"6886c741845f42bd459dc5dade7b1fc2","url":"https://api.github.com/users/Sanne","html_url":"https://github.com/Sanne","followers_url":"https://api.github.com/users/Sanne/followers","following_url":"https://api.github.com/users/Sanne/following","gists_url":"https://api.github.com/users/Sanne/gists{/gist_id}","starred_url":"https://api.github.com/users/Sanne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sanne/subscriptions","organizations_url":"https://api.github.com/users/Sanne/orgs","repos_url":"https://api.github.com/users/Sanne/repos","events_url":"https://api.github.com/users/Sanne/events{/privacy}","received_events_url":"https://api.github.com/users/Sanne/received_events","type":"User"},"created_at":"2013-03-14T21:25:03Z","updated_at":"2013-03-14T21:25:03Z","html_url":"https://github.com/infinispan/infinispan/pull/1473#discussion_r3382076","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/1473","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/3382076"},"html":{"href":"https://github.com/infinispan/infinispan/pull/1473#discussion_r3382076"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/1473"}}}} | {
"id": 1050944,
"name": "infinispan",
"url": "https://github.com/infinispan/infinispan"
} | {
"id": null,
"login": "Sanne",
"gravatar_id": "6886c741845f42bd459dc5dade7b1fc2",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "infinispan",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-14T21:25:03 | null | {"repository":{"description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","homepage":"http://www.infinispan.org","watchers":204,"stargazers":204,"forks":130,"fork":false,"size":23424,"owner":"infinispan","private":false,"open_issues":14,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2010-11-04T05:33:19-07:00","pushed_at":"2013-03-14T06:50:52-07:00","master_branch":"master","organization":"infinispan"},"actor_attributes":{"type":"User","name":"Sanne Grinovero","company":"Red Hat","blog":"http://in.relation.to/Bloggers/Sanne","location":"United Kingdom","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/infinispan/infinispan/pull/1473#discussion_r3382076"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/4415269","id":4415269,"body":"yes tomas, please use something of the form log.debugf(\"... %s ... %s\", args[i], args[i].getClass()...","diff_hunk":"@@ -278,6 +278,20 @@ public Object invoke(String name, Object[] args, String[] sig) throws MBeanExcep\n throw new MBeanException(new ServiceNotFoundException(msg), msg);\n }\n \n+ // Argument type transformation according to signatures\n+ for (int i = 0; i < args.length; i++) {\n+ // arguments are taken from RHQ like java.lang.String but we need some fields to be numbers\n+ if (log.isDebugEnabled())\n+ log.debugf(\"Argument value before transformation: \" + args[i] + \" and its class: \" +","path":"core/src/main/java/org/infinispan/jmx/ResourceDMBean.java","position":8,"original_position":8,"commit_id":"41b8c63e08c0f24c0f41c9a873dabd522a0fba75","original_commit_id":"9074ed99807663c9e4b68aba6397eec31944af20","user":{"login":"tristantarrant","id":392478,"avatar_url":"https://secure.gravatar.com/avatar/a0bbac2ddda65366d24691b7d3daa735?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"a0bbac2ddda65366d24691b7d3daa735","url":"https://api.github.com/users/tristantarrant","html_url":"https://github.com/tristantarrant","followers_url":"https://api.github.com/users/tristantarrant/followers","following_url":"https://api.github.com/users/tristantarrant/following{/other_user}","gists_url":"https://api.github.com/users/tristantarrant/gists{/gist_id}","starred_url":"https://api.github.com/users/tristantarrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tristantarrant/subscriptions","organizations_url":"https://api.github.com/users/tristantarrant/orgs","repos_url":"https://api.github.com/users/tristantarrant/repos","events_url":"https://api.github.com/users/tristantarrant/events{/privacy}","received_events_url":"https://api.github.com/users/tristantarrant/received_events","type":"User"},"created_at":"2013-05-28T15:27:08Z","updated_at":"2013-05-28T15:27:08Z","html_url":"https://github.com/infinispan/infinispan/pull/1838#discussion_r4415269","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/1838","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/4415269"},"html":{"href":"https://github.com/infinispan/infinispan/pull/1838#discussion_r4415269"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/1838"}}}} | {
"id": 1050944,
"name": "infinispan",
"url": "https://github.com/infinispan/infinispan"
} | {
"id": null,
"login": "tristantarrant",
"gravatar_id": "a0bbac2ddda65366d24691b7d3daa735",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "infinispan",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-28T15:27:08 | null | {"repository":{"description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","homepage":"http://www.infinispan.org","watchers":225,"stargazers":225,"forks":139,"fork":false,"size":25820,"owner":"infinispan","private":false,"open_issues":6,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2010-11-04T05:33:19-07:00","pushed_at":"2013-05-28T04:11:18-07:00","master_branch":"master","organization":"infinispan"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/infinispan/infinispan/pull/1838#discussion_r4415269"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/8496881","id":8496881,"diff_hunk":"@@ -33,5 +53,12 @@ message QueryResponse {\n */\n required int32 projectionSize = 2;\n \n- repeated org.infinispan.protostream.WrappedMessage results = 3;\n+ /**\n+ * The list of matching results. The size should be either numResults, if no projections are used, or numResults *\n+ * projectionSize otherwise. If projections are used, then each group of projectionSize consecutive elements\n+ * represent together a result.\n+ */\n+ repeated org.infinispan.protostream.WrappedMessage results = 3;\n+\n+ //TODO add number of total matching results, which usually != numResults if pagination was used","path":"remote-query/remote-query-client/src/main/resources/query.proto","position":62,"original_position":62,"commit_id":"f2e87047484ef1910c0c8731680ce0469e5daefe","original_commit_id":"f2e87047484ef1910c0c8731680ce0469e5daefe","user":{"login":"mmarkus","id":427349,"avatar_url":"https://gravatar.com/avatar/76dd10839a7cdb00276b30d989de3ad3?d=https%3A%2F%2Fidenticons.github.com%2F9dbf75c8179fcc636543e78b77410e49.png&r=x","gravatar_id":"76dd10839a7cdb00276b30d989de3ad3","url":"https://api.github.com/users/mmarkus","html_url":"https://github.com/mmarkus","followers_url":"https://api.github.com/users/mmarkus/followers","following_url":"https://api.github.com/users/mmarkus/following{/other_user}","gists_url":"https://api.github.com/users/mmarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/mmarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmarkus/subscriptions","organizations_url":"https://api.github.com/users/mmarkus/orgs","repos_url":"https://api.github.com/users/mmarkus/repos","events_url":"https://api.github.com/users/mmarkus/events{/privacy}","received_events_url":"https://api.github.com/users/mmarkus/received_events","type":"User","site_admin":false},"body":"okay","created_at":"2013-12-20T10:52:32Z","updated_at":"2013-12-20T10:52:32Z","html_url":"https://github.com/infinispan/infinispan/pull/2310#discussion_r8496881","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/2310","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/8496881"},"html":{"href":"https://github.com/infinispan/infinispan/pull/2310#discussion_r8496881"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/2310"}}}} | {
"id": 1050944,
"name": "infinispan",
"url": "https://github.com/infinispan/infinispan"
} | {
"id": null,
"login": "mmarkus",
"gravatar_id": "76dd10839a7cdb00276b30d989de3ad3",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "infinispan",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-20T10:52:32 | null | {"repository":{"description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","homepage":"http://www.infinispan.org","watchers":266,"stargazers":266,"forks":200,"fork":false,"size":89961,"owner":"infinispan","private":false,"open_issues":4,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2010-11-04T05:33:19-07:00","pushed_at":"2013-12-19T10:51:23-08:00","master_branch":"master","organization":"infinispan"},"actor_attributes":{"type":"User","name":"Mircea Markus","company":"JBoss by RedHat","blog":"http://mirceamarkus.blogspot.com/","location":"London, U.K.","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/infinispan/infinispan/pull/2310#discussion_r8496881"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/3265572","id":3265572,"body":"you don't need to create callback for sync commands, or?","diff_hunk":"@@ -208,49 +215,107 @@ private boolean containsOnlyNulls(RspList<Object> l) {\n * Message contains a Command. Execute it against *this* object and return result.\n */\n @Override\n- public Object handle(Message req) {\n+ public void handle(Message req, org.jgroups.blocks.Response response) throws Exception {\n if (isValid(req)) {\n ReplicableCommand cmd = null;\n try {\n cmd = (ReplicableCommand) req_marshaller.objectFromBuffer(req.getRawBuffer(), req.getOffset(), req.getLength());\n- if (cmd == null) throw new NullPointerException(\"Unable to execute a null command! Message was \" + req);\n+ if (cmd == null) {\n+ throw new NullPointerException(\"Unable to execute a null command! Message was \" + req);\n+ }\n+ JGroupsAsyncInvocationRequest callback = fromJGroupsResponse(response);","path":"core/src/main/java/org/infinispan/remoting/transport/jgroups/CommandAwareRpcDispatcher.java","position":64,"original_position":64,"commit_id":"48846c61ec9670597782dedfeb65e86e9ef3d124","original_commit_id":"48846c61ec9670597782dedfeb65e86e9ef3d124","user":{"login":"mmarkus","id":427349,"avatar_url":"https://secure.gravatar.com/avatar/76dd10839a7cdb00276b30d989de3ad3?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"76dd10839a7cdb00276b30d989de3ad3","url":"https://api.github.com/users/mmarkus","html_url":"https://github.com/mmarkus","followers_url":"https://api.github.com/users/mmarkus/followers","following_url":"https://api.github.com/users/mmarkus/following","gists_url":"https://api.github.com/users/mmarkus/gists{/gist_id}","starred_url":"https://api.github.com/users/mmarkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmarkus/subscriptions","organizations_url":"https://api.github.com/users/mmarkus/orgs","repos_url":"https://api.github.com/users/mmarkus/repos","events_url":"https://api.github.com/users/mmarkus/events{/privacy}","received_events_url":"https://api.github.com/users/mmarkus/received_events","type":"User"},"created_at":"2013-03-06T17:55:57Z","updated_at":"2013-03-06T17:55:57Z","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/3265572"},"html":{"href":"https://github.com/infinispan/infinispan/pull/1705#discussion_r3265572"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/1705"}}}} | {
"id": 1050944,
"name": "infinispan",
"url": "https://github.com/infinispan/infinispan"
} | {
"id": null,
"login": "mmarkus",
"gravatar_id": "76dd10839a7cdb00276b30d989de3ad3",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "infinispan",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-06T17:55:57 | null | {"repository":{"description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","homepage":"http://www.infinispan.org","watchers":201,"stargazers":201,"forks":129,"fork":false,"size":23612,"owner":"infinispan","private":false,"open_issues":15,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2010-11-04T05:33:19-07:00","pushed_at":"2013-03-06T08:38:46-08:00","master_branch":"master","organization":"infinispan"},"actor_attributes":{"type":"User","name":"Mircea Markus","company":"JBoss by RedHat","blog":"http://mirceamarkus.blogspot.com/","location":"London, U.K.","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/infinispan/infinispan/pull/1705#discussion_r3265572"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/jbosstools/jbosstools-build/pulls/comments/6580379","id":6580379,"body":"i found that some of the 'new' hibernate tools tests actually uses jmock - but here jmock is bundled.\r\n\r\nI never liked jmock being added here since others are also used (i.e. mockito) and I don't see any trace/jiras documenting why it should be here and not just declared in the plugins that actually do need it.\r\n\r\nAlso this seem to avoid the jmock not needing to be included in target platform which isn't nice too - thus i'm +1 for this change for sure.\r\n","diff_hunk":"@@ -241,28 +241,6 @@\n \t\t\t\t\t<!-- set useUIThread=true for regular ui tests -->\n \t\t\t\t\t<!-- set useUIThread=false for swtbot tests -->\n \n-\t\t\t\t\t<!-- TODO: add new profile to permit running against JBDS product/application\n-\t\t\t\t\t\tfor JBDS tests, against Eclipse SDK for JBT -->\n-\t\t\t\t\t<product>org.eclipse.platform.ide</product>\n-\t\t\t\t\t<application>org.eclipse.ui.ide.workbench</application>\n-\t\t\t\t\t<dependencies>\n-\t\t\t\t\t\t<dependency>\n-\t\t\t\t\t\t\t<type>p2-installable-unit</type>\n-\t\t\t\t\t\t\t<artifactId>org.eclipse.platform</artifactId>\n-\t\t\t\t\t\t\t<version>0.0.0</version>\n-\t\t\t\t\t\t</dependency>\n-\t\t\t\t\t\t<!-- http://www.jmock.org/maven.html -->\n-\t\t\t\t\t\t<dependency>\n-\t\t\t\t\t\t\t<groupId>org.jmock</groupId>","path":"parent/pom.xml","position":16,"original_position":16,"commit_id":"327e4b153b4b1103e46e1835e17cc517a86bfa48","original_commit_id":"327e4b153b4b1103e46e1835e17cc517a86bfa48","user":{"login":"maxandersen","id":54129,"avatar_url":"https://2.gravatar.com/avatar/a56c04b64774ff2ad72e8b1ae57a19de?d=https%3A%2F%2Fidenticons.github.com%2F90ca71c2ad9fa1f48c0938ab8098b9e2.png","gravatar_id":"a56c04b64774ff2ad72e8b1ae57a19de","url":"https://api.github.com/users/maxandersen","html_url":"https://github.com/maxandersen","followers_url":"https://api.github.com/users/maxandersen/followers","following_url":"https://api.github.com/users/maxandersen/following{/other_user}","gists_url":"https://api.github.com/users/maxandersen/gists{/gist_id}","starred_url":"https://api.github.com/users/maxandersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxandersen/subscriptions","organizations_url":"https://api.github.com/users/maxandersen/orgs","repos_url":"https://api.github.com/users/maxandersen/repos","events_url":"https://api.github.com/users/maxandersen/events{/privacy}","received_events_url":"https://api.github.com/users/maxandersen/received_events","type":"User"},"created_at":"2013-09-25T18:07:42Z","updated_at":"2013-09-25T18:07:42Z","html_url":"https://github.com/jbosstools/jbosstools-build/pull/111#discussion_r6580379","pull_request_url":"https://api.github.com/repos/jbosstools/jbosstools-build/pulls/111","_links":{"self":{"href":"https://api.github.com/repos/jbosstools/jbosstools-build/pulls/comments/6580379"},"html":{"href":"https://github.com/jbosstools/jbosstools-build/pull/111#discussion_r6580379"},"pull_request":{"href":"https://api.github.com/repos/jbosstools/jbosstools-build/pulls/111"}}}} | {
"id": 6308269,
"name": "jbosstools-build",
"url": "https://github.com/jbosstools/jbosstools-build"
} | {
"id": null,
"login": "maxandersen",
"gravatar_id": "a56c04b64774ff2ad72e8b1ae57a19de",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "jbosstools",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-25T18:07:42 | null | {"repository":{"description":"JBoss Tools :: Build { parent pom & target platform definitions }","homepage":"","watchers":1,"stargazers":1,"forks":17,"fork":false,"size":56787,"owner":"jbosstools","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Shell","created_at":"2012-10-20T04:22:48-07:00","pushed_at":"2013-09-25T04:44:20-07:00","master_branch":"master","organization":"jbosstools"},"actor_attributes":{"type":"User","name":"Max Rydahl Andersen","company":"Red Hat","blog":"http://in.relation.to/Bloggers/Max","location":"Switzerland","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/jbosstools/jbosstools-build/pull/111#discussion_r6580379"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/4979891","id":4979891,"body":"It's nice to have some unit tests for this! Thanks!","diff_hunk":"@@ -0,0 +1,41 @@\n+import os\n+\n+import matplotlib as mpl\n+from matplotlib.tests import assert_str_equal\n+\n+templaterc = os.path.join(os.path.dirname(__file__), 'test_rcsetup.rc')\n+deprecated = ['svg.embed_char_paths', 'savefig.extension']\n+\n+def test_defaults():","path":"lib/matplotlib/tests/test_rcsetup.py","position":9,"original_position":9,"commit_id":"6bd355f2754fbbaa29871902d059c27b92efda2c","original_commit_id":"6bd355f2754fbbaa29871902d059c27b92efda2c","user":{"login":"NelleV","id":184798,"avatar_url":"https://secure.gravatar.com/avatar/18f719a71cd957dc6f79655448cacad1?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"18f719a71cd957dc6f79655448cacad1","url":"https://api.github.com/users/NelleV","html_url":"https://github.com/NelleV","followers_url":"https://api.github.com/users/NelleV/followers","following_url":"https://api.github.com/users/NelleV/following{/other_user}","gists_url":"https://api.github.com/users/NelleV/gists{/gist_id}","starred_url":"https://api.github.com/users/NelleV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NelleV/subscriptions","organizations_url":"https://api.github.com/users/NelleV/orgs","repos_url":"https://api.github.com/users/NelleV/repos","events_url":"https://api.github.com/users/NelleV/events{/privacy}","received_events_url":"https://api.github.com/users/NelleV/received_events","type":"User"},"created_at":"2013-07-02T08:22:26Z","updated_at":"2013-07-02T08:22:26Z","html_url":"https://github.com/matplotlib/matplotlib/pull/2193#discussion_r4979891","pull_request_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/2193","_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/4979891"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/2193#discussion_r4979891"},"pull_request":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/2193"}}}} | {
"id": 1385122,
"name": "matplotlib",
"url": "https://github.com/matplotlib/matplotlib"
} | {
"id": null,
"login": "NelleV",
"gravatar_id": "18f719a71cd957dc6f79655448cacad1",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "matplotlib",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-02T08:22:26 | null | {"repository":{"description":"matplotlib: plotting with Python","homepage":"http://matplotlib.org/","watchers":877,"stargazers":877,"forks":417,"fork":false,"size":8880,"owner":"matplotlib","private":false,"open_issues":5,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2011-02-18T19:17:12-08:00","pushed_at":"2013-07-01T10:53:56-07:00","integrate_branch":"master","master_branch":"master","organization":"matplotlib"},"actor_attributes":{"type":"User","name":"Varoquaux","location":"Paris","email":"[email protected]"},"url":"https://github.com/matplotlib/matplotlib/pull/2193#discussion_r4979891"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/meducation/front-end/pulls/comments/7879613","id":7879613,"diff_hunk":"@@ -15,7 +15,36 @@\n }\n ]);\n \n- angular.module('meducationFrontEnd', ['meducationTemplates']).constant('apiURI', '/api');\n+ angular.module('meducationFrontEnd', ['meducationTemplates', 'ngResource']).constant('apiURI', '/api');\n+\n+ mainModule = angular.module('meducationFrontEnd');\n+\n+ syllabusItemsControllerFunction = function($scope, syllabusItemsService) {\n+ var levels;\n+ levels = [0, 1, 2, 3, 4];","path":"lib/assets/javascripts/meducation_front_end.js","position":18,"original_position":18,"commit_id":"f953443f2cc74f27161e34d0ed833e00516c16d1","original_commit_id":"f953443f2cc74f27161e34d0ed833e00516c16d1","user":{"login":"iHiD","id":286476,"avatar_url":"https://2.gravatar.com/avatar/955103d80e386882143a78875fb727bf?d=https%3A%2F%2Fidenticons.github.com%2F66a04212026e6c48b31b7a1e06c1c597.png&r=x","gravatar_id":"955103d80e386882143a78875fb727bf","url":"https://api.github.com/users/iHiD","html_url":"https://github.com/iHiD","followers_url":"https://api.github.com/users/iHiD/followers","following_url":"https://api.github.com/users/iHiD/following{/other_user}","gists_url":"https://api.github.com/users/iHiD/gists{/gist_id}","starred_url":"https://api.github.com/users/iHiD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iHiD/subscriptions","organizations_url":"https://api.github.com/users/iHiD/orgs","repos_url":"https://api.github.com/users/iHiD/repos","events_url":"https://api.github.com/users/iHiD/events{/privacy}","received_events_url":"https://api.github.com/users/iHiD/received_events","type":"User","site_admin":false},"body":"`levels = [0..4]`","created_at":"2013-11-24T18:45:20Z","updated_at":"2013-11-24T18:45:20Z","html_url":"https://github.com/meducation/front-end/pull/18#discussion_r7879613","pull_request_url":"https://api.github.com/repos/meducation/front-end/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/meducation/front-end/pulls/comments/7879613"},"html":{"href":"https://github.com/meducation/front-end/pull/18#discussion_r7879613"},"pull_request":{"href":"https://api.github.com/repos/meducation/front-end/pulls/18"}}}} | {
"id": 12922211,
"name": "front-end",
"url": "https://github.com/meducation/front-end"
} | {
"id": null,
"login": "iHiD",
"gravatar_id": "955103d80e386882143a78875fb727bf",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "meducation",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-24T18:45:20 | null | {"repository":{"description":"Collection of Single Page Applications for Meducation","watchers":0,"stargazers":0,"forks":1,"fork":false,"size":897,"owner":"meducation","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"CoffeeScript","created_at":"2013-09-18T05:15:11-07:00","pushed_at":"2013-11-24T09:45:19-08:00","master_branch":"master","organization":"meducation"},"actor_attributes":{"type":"User","name":"Jeremy Walker","blog":"http://www.ihid.co.uk","location":"Birmingham, England","email":"[email protected]"},"url":"https://github.com/meducation/front-end/pull/18#discussion_r7879613"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/metarelate/metOcean-mapping/pulls/comments/2977149","id":2977149,"body":"Please use ```\"\"\"```","path":"lib/editor/app/forms.py","position":258,"original_position":258,"commit_id":"6cda01a7c570da443cdad47d4c17bd7197efe979","original_commit_id":"6cda01a7c570da443cdad47d4c17bd7197efe979","user":{"login":"esc24","id":1634089,"avatar_url":"https://secure.gravatar.com/avatar/8bd0e92cdf61b60bc2e2aa4bd77cfc3e?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"8bd0e92cdf61b60bc2e2aa4bd77cfc3e","url":"https://api.github.com/users/esc24","followers_url":"https://api.github.com/users/esc24/followers","following_url":"https://api.github.com/users/esc24/following","gists_url":"https://api.github.com/users/esc24/gists{/gist_id}","starred_url":"https://api.github.com/users/esc24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esc24/subscriptions","organizations_url":"https://api.github.com/users/esc24/orgs","repos_url":"https://api.github.com/users/esc24/repos","events_url":"https://api.github.com/users/esc24/events{/privacy}","received_events_url":"https://api.github.com/users/esc24/received_events","type":"User"},"created_at":"2013-02-12T12:20:30Z","updated_at":"2013-02-12T12:20:30Z","_links":{"self":{"href":"https://api.github.com/repos/metarelate/metOcean-mapping/pulls/comments/2977149"},"html":{"href":"https://github.com/metarelate/metOcean-mapping/pull/28#discussion_r2977149"},"pull_request":{"href":"https://api.github.com/repos/metarelate/metOcean-mapping/pulls/28"}}}} | {
"id": 5412176,
"name": "metOcean-mapping",
"url": "https://github.com/metarelate/metOcean-mapping"
} | {
"id": null,
"login": "esc24",
"gravatar_id": "8bd0e92cdf61b60bc2e2aa4bd77cfc3e",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "metarelate",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-12T12:20:30 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":4,"fork":false,"size":148,"owner":"metarelate","private":false,"open_issues":11,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-08-14T04:58:14-07:00","pushed_at":"2012-12-06T02:16:35-08:00","organization":"metarelate"},"actor_attributes":{"name":"Ed Campbell","type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/metarelate/metOcean-mapping/pull/28#discussion_r2977149"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mortardata/mortar/pulls/comments/3251468","id":3251468,"body":"It has been for the templating, but it got taken out.","diff_hunk":"@@ -0,0 +1,174 @@\n+#\n+# Copyright 2012 Mortar Data Inc.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+#\n+\n+require \"erb\"\n+require 'ostruct'","path":"lib/mortar/local/pig.rb","position":18,"original_position":18,"commit_id":"d83a60ba61ca31bfb75a8316f454762f1c19b5a3","original_commit_id":"407045c0673db71cbbd9bc3bf6818fb524f8343f","user":{"login":"MarkRoddy","id":346362,"avatar_url":"https://secure.gravatar.com/avatar/ac25b3f7bf1399399a6ad4cefea84bc6?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"ac25b3f7bf1399399a6ad4cefea84bc6","url":"https://api.github.com/users/MarkRoddy","html_url":"https://github.com/MarkRoddy","followers_url":"https://api.github.com/users/MarkRoddy/followers","following_url":"https://api.github.com/users/MarkRoddy/following","gists_url":"https://api.github.com/users/MarkRoddy/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkRoddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkRoddy/subscriptions","organizations_url":"https://api.github.com/users/MarkRoddy/orgs","repos_url":"https://api.github.com/users/MarkRoddy/repos","events_url":"https://api.github.com/users/MarkRoddy/events{/privacy}","received_events_url":"https://api.github.com/users/MarkRoddy/received_events","type":"User"},"created_at":"2013-03-05T21:29:55Z","updated_at":"2013-03-05T21:29:55Z","_links":{"self":{"href":"https://api.github.com/repos/mortardata/mortar/pulls/comments/3251468"},"html":{"href":"https://github.com/mortardata/mortar/pull/54#discussion_r3251468"},"pull_request":{"href":"https://api.github.com/repos/mortardata/mortar/pulls/54"}}}} | {
"id": 5169277,
"name": "mortar",
"url": "https://github.com/mortardata/mortar"
} | {
"id": null,
"login": "MarkRoddy",
"gravatar_id": "ac25b3f7bf1399399a6ad4cefea84bc6",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mortardata",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-05T21:29:55 | null | {"repository":{"description":"Mortar Development Framework","homepage":"www.mortardata.com","watchers":22,"stargazers":22,"forks":3,"fork":false,"size":492,"owner":"mortardata","private":false,"open_issues":5,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2012-07-24T11:12:32-07:00","pushed_at":"2013-03-05T11:58:42-08:00","master_branch":"master","organization":"mortardata"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mortardata/mortar/pull/54#discussion_r3251468"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-contacts/pulls/comments/6425853","id":6425853,"body":"done","diff_hunk":"@@ -328,19 +328,91 @@ void SeasidePerson::setAvatarPath(QUrl avatarPath)\n \n QUrl SeasidePerson::avatarUrl() const\n {\n- QContactAvatar avatarDetail = mContact->detail<QContactAvatar>();\n- return avatarDetail.imageUrl();\n+ return filteredAvatarUrl();\n }\n \n void SeasidePerson::setAvatarUrl(QUrl avatarUrl)\n {\n- QContactAvatar avatarDetail = mContact->detail<QContactAvatar>();\n- avatarDetail.setImageUrl(avatarUrl);\n- mContact->saveDetail(&avatarDetail);\n+ // we always set the avatar with the metadata flag \"local\".\n+ QContactAvatar localAvatar;\n+ QList<QContactAvatar> avatars = mContact->details<QContactAvatar>();\n+ for (int i = 0; i < avatars.size(); ++i) {\n+ if (avatars[i].value(QContactAvatar__FieldAvatarMetadata) == QString(QLatin1String(\"local\"))) {\n+ localAvatar = avatars[i];\n+ break;\n+ }\n+ }\n+\n+ localAvatar.setImageUrl(avatarUrl);\n+ localAvatar.setValue(QContactAvatar__FieldAvatarMetadata, QString(QLatin1String(\"local\")));\n+ mContact->saveDetail(&localAvatar);\n emit avatarUrlChanged();\n emit avatarPathChanged();\n }\n \n+#define IGNORE_AVATAR 0 // invalid/empty\n+#define APPEND_AVATAR 1 // matches but isn't a local file path\n+#define SELECT_AVATAR 2 // matches and is a local file path\n+static int ignoreAppendOrSelectAvatar(const QContactAvatar &avatar)","path":"src/seasideperson.cpp","position":34,"original_position":34,"commit_id":"d07b2b8aa38958e1aa7ceb1f367225912a6fee7e","original_commit_id":"d07b2b8aa38958e1aa7ceb1f367225912a6fee7e","user":{"login":"chriadam","id":2569776,"avatar_url":"https://1.gravatar.com/avatar/7cf45e93e7e17739635963a68c1dc9a4?d=https%3A%2F%2Fidenticons.github.com%2Fb0b6437bd35985aaf202b0dea29aa0f5.png","gravatar_id":"7cf45e93e7e17739635963a68c1dc9a4","url":"https://api.github.com/users/chriadam","html_url":"https://github.com/chriadam","followers_url":"https://api.github.com/users/chriadam/followers","following_url":"https://api.github.com/users/chriadam/following{/other_user}","gists_url":"https://api.github.com/users/chriadam/gists{/gist_id}","starred_url":"https://api.github.com/users/chriadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriadam/subscriptions","organizations_url":"https://api.github.com/users/chriadam/orgs","repos_url":"https://api.github.com/users/chriadam/repos","events_url":"https://api.github.com/users/chriadam/events{/privacy}","received_events_url":"https://api.github.com/users/chriadam/received_events","type":"User"},"created_at":"2013-09-18T06:07:55Z","updated_at":"2013-09-18T06:07:55Z","html_url":"https://github.com/nemomobile/nemo-qml-plugin-contacts/pull/54#discussion_r6425853","pull_request_url":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-contacts/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-contacts/pulls/comments/6425853"},"html":{"href":"https://github.com/nemomobile/nemo-qml-plugin-contacts/pull/54#discussion_r6425853"},"pull_request":{"href":"https://api.github.com/repos/nemomobile/nemo-qml-plugin-contacts/pulls/54"}}}} | {
"id": 9983003,
"name": "nemo-qml-plugin-contacts",
"url": "https://github.com/nemomobile/nemo-qml-plugin-contacts"
} | {
"id": null,
"login": "chriadam",
"gravatar_id": "7cf45e93e7e17739635963a68c1dc9a4",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "nemomobile",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-18T06:07:55 | null | {"repository":{"description":"QML plugin for contacts","watchers":10,"stargazers":10,"forks":20,"fork":false,"size":840,"owner":"nemomobile","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2013-05-10T07:23:14-07:00","pushed_at":"2013-09-09T00:57:54-07:00","master_branch":"master","organization":"nemomobile"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/nemomobile/nemo-qml-plugin-contacts/pull/54#discussion_r6425853"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/nemomobile/voicecall/pulls/comments/6629378","id":6629378,"body":"It's whether you're the one that made the call multiparty, or whether the remote person at the end of the call is hosting a multiparty. One allows you to keep track of all the participants, the other doesn't.","diff_hunk":"@@ -43,6 +44,8 @@ class AbstractVoiceCallHandler : public QObject\n Q_PROPERTY(bool isEmergency READ isEmergency NOTIFY emergencyChanged)\n Q_PROPERTY(bool isMultiparty READ isMultiparty NOTIFY multipartyChanged)\n Q_PROPERTY(bool isForwarded READ isForwarded NOTIFY forwardedChanged)\n+ Q_PROPERTY(bool isRemoteHeld READ isRemoteHeld NOTIFY remoteHeldChanged)\n+ Q_PROPERTY(bool isRemoteMultiparty READ isRemoteMultiparty NOTIFY remoteMultipartyChanged)","path":"lib/src/abstractvoicecallhandler.h","position":13,"original_position":13,"commit_id":"3fe78d1a76da7830c5a78fa12aafb6aef52beced","original_commit_id":"3fe78d1a76da7830c5a78fa12aafb6aef52beced","user":{"login":"tswindell","id":833539,"avatar_url":"https://2.gravatar.com/avatar/17dc32e576987ed0f6c41565586fb5ef?d=https%3A%2F%2Fidenticons.github.com%2Feedaef969dec8965a0abdc5021efcc20.png","gravatar_id":"17dc32e576987ed0f6c41565586fb5ef","url":"https://api.github.com/users/tswindell","html_url":"https://github.com/tswindell","followers_url":"https://api.github.com/users/tswindell/followers","following_url":"https://api.github.com/users/tswindell/following{/other_user}","gists_url":"https://api.github.com/users/tswindell/gists{/gist_id}","starred_url":"https://api.github.com/users/tswindell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tswindell/subscriptions","organizations_url":"https://api.github.com/users/tswindell/orgs","repos_url":"https://api.github.com/users/tswindell/repos","events_url":"https://api.github.com/users/tswindell/events{/privacy}","received_events_url":"https://api.github.com/users/tswindell/received_events","type":"User"},"created_at":"2013-09-27T14:42:57Z","updated_at":"2013-09-27T14:42:57Z","html_url":"https://github.com/nemomobile/voicecall/pull/40#discussion_r6629378","pull_request_url":"https://api.github.com/repos/nemomobile/voicecall/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/nemomobile/voicecall/pulls/comments/6629378"},"html":{"href":"https://github.com/nemomobile/voicecall/pull/40#discussion_r6629378"},"pull_request":{"href":"https://api.github.com/repos/nemomobile/voicecall/pulls/40"}}}} | {
"id": 5259485,
"name": "voicecall",
"url": "https://github.com/nemomobile/voicecall"
} | {
"id": null,
"login": "tswindell",
"gravatar_id": "17dc32e576987ed0f6c41565586fb5ef",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "nemomobile",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-27T14:42:57 | null | {"repository":{"description":"Dialer middleware for Nemo Mobile","homepage":"","watchers":12,"stargazers":12,"forks":22,"fork":false,"size":952,"owner":"nemomobile","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2012-08-01T06:24:03-07:00","pushed_at":"2013-09-27T03:00:29-07:00","master_branch":"master","organization":"nemomobile"},"actor_attributes":{"type":"User","name":"Tom","blog":"hacking-mobility.blogspot.com","location":"Cambridge, UK","email":"[email protected]"},"url":"https://github.com/nemomobile/voicecall/pull/40#discussion_r6629378"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/nemomobile/qtcontacts-sqlite/pulls/comments/4515546","id":4515546,"body":"Should it be 0.0.1 instead of 12? I actually think versioning according to functionality makes more sense, so I'm fine with 0.0.12 actually.","diff_hunk":"@@ -0,0 +1,46 @@\n+Name: qtcontacts-sqlite-qt5\n+Version: 0.0.12","path":"rpm/qtcontacts-sqlite-qt5.spec","position":2,"original_position":2,"commit_id":"7e06c493ee772e4b28b37b7475e7b8419fed8d15","original_commit_id":"7e06c493ee772e4b28b37b7475e7b8419fed8d15","user":{"login":"chriadam","id":2569776,"avatar_url":"https://secure.gravatar.com/avatar/7cf45e93e7e17739635963a68c1dc9a4?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"7cf45e93e7e17739635963a68c1dc9a4","url":"https://api.github.com/users/chriadam","html_url":"https://github.com/chriadam","followers_url":"https://api.github.com/users/chriadam/followers","following_url":"https://api.github.com/users/chriadam/following{/other_user}","gists_url":"https://api.github.com/users/chriadam/gists{/gist_id}","starred_url":"https://api.github.com/users/chriadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriadam/subscriptions","organizations_url":"https://api.github.com/users/chriadam/orgs","repos_url":"https://api.github.com/users/chriadam/repos","events_url":"https://api.github.com/users/chriadam/events{/privacy}","received_events_url":"https://api.github.com/users/chriadam/received_events","type":"User"},"created_at":"2013-06-04T04:24:17Z","updated_at":"2013-06-04T04:24:17Z","html_url":"https://github.com/nemomobile/qtcontacts-sqlite/pull/13#discussion_r4515546","pull_request_url":"https://api.github.com/repos/nemomobile/qtcontacts-sqlite/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/nemomobile/qtcontacts-sqlite/pulls/comments/4515546"},"html":{"href":"https://github.com/nemomobile/qtcontacts-sqlite/pull/13#discussion_r4515546"},"pull_request":{"href":"https://api.github.com/repos/nemomobile/qtcontacts-sqlite/pulls/13"}}}} | {
"id": 9290689,
"name": "qtcontacts-sqlite",
"url": "https://github.com/nemomobile/qtcontacts-sqlite"
} | {
"id": null,
"login": "chriadam",
"gravatar_id": "7cf45e93e7e17739635963a68c1dc9a4",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "nemomobile",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-04T04:24:17 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":3,"fork":false,"size":300,"owner":"nemomobile","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2013-04-08T00:20:09-07:00","pushed_at":"2013-05-26T16:04:07-07:00","master_branch":"master","organization":"nemomobile"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/nemomobile/qtcontacts-sqlite/pull/13#discussion_r4515546"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/nemomobile/libqofono/pulls/comments/5338931","id":5338931,"body":"hmmm... ","diff_hunk":"@@ -280,9 +294,235 @@ void QOfonoConnectionContext::setOneProperty(const QString &prop, const QDBusVar\n void QOfonoConnectionContext::setPropertyFinished(QDBusPendingCallWatcher *watch)\n {\n QDBusPendingReply<> reply = *watch;\n+\n if(reply.isError()) {\n qDebug() << Q_FUNC_INFO << reply.error().message();\n Q_EMIT reportError(reply.error().message());\n }\n+ Q_EMIT setPropertyFinished();\n+\n+}\n+\n+//check provision against mbpi\n+bool QOfonoConnectionContext::validateProvisioning()\n+{\n+ QString provider;\n+ QString mcc;\n+ QString mnc;\n+\n+ QOfonoManager manager;\n+ QOfonoNetworkRegistration netReg;\n+ if (manager.modems().count() > 0) {\n+ netReg.setModemPath(manager.modems().at(0));","path":"src/qofonoconnectioncontext.cpp","position":81,"original_position":81,"commit_id":"dfe907175c30e1634998d311ac0b39876b4e2dd8","original_commit_id":"dfe907175c30e1634998d311ac0b39876b4e2dd8","user":{"login":"lpotter","id":69512,"avatar_url":"https://secure.gravatar.com/avatar/dbb338c6c905a460d0f689175252c365?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"dbb338c6c905a460d0f689175252c365","url":"https://api.github.com/users/lpotter","html_url":"https://github.com/lpotter","followers_url":"https://api.github.com/users/lpotter/followers","following_url":"https://api.github.com/users/lpotter/following{/other_user}","gists_url":"https://api.github.com/users/lpotter/gists{/gist_id}","starred_url":"https://api.github.com/users/lpotter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpotter/subscriptions","organizations_url":"https://api.github.com/users/lpotter/orgs","repos_url":"https://api.github.com/users/lpotter/repos","events_url":"https://api.github.com/users/lpotter/events{/privacy}","received_events_url":"https://api.github.com/users/lpotter/received_events","type":"User"},"created_at":"2013-07-23T07:47:46Z","updated_at":"2013-07-23T07:47:46Z","html_url":"https://github.com/nemomobile/libqofono/pull/17#discussion_r5338931","pull_request_url":"https://api.github.com/repos/nemomobile/libqofono/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/nemomobile/libqofono/pulls/comments/5338931"},"html":{"href":"https://github.com/nemomobile/libqofono/pull/17#discussion_r5338931"},"pull_request":{"href":"https://api.github.com/repos/nemomobile/libqofono/pulls/17"}}}} | {
"id": 7874435,
"name": "libqofono",
"url": "https://github.com/nemomobile/libqofono"
} | {
"id": null,
"login": "lpotter",
"gravatar_id": "dbb338c6c905a460d0f689175252c365",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "nemomobile",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-23T07:47:46 | null | {"repository":{"description":"Rewritten version of libofono-qt","watchers":0,"stargazers":0,"forks":9,"fork":false,"size":696,"owner":"nemomobile","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2013-01-28T09:04:20-08:00","pushed_at":"2013-07-18T22:08:19-07:00","master_branch":"master","organization":"nemomobile"},"actor_attributes":{"type":"User","name":"Lorn Potter","company":"llornkcor technologies","blog":"http://llornkcor.com","location":"Brisbane, Australia","email":"[email protected]"},"url":"https://github.com/nemomobile/libqofono/pull/17#discussion_r5338931"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/nemomobile/libcommhistory/pulls/comments/5232531","id":5232531,"body":"It would be good to add indexes on remoteUid, type, direction.","diff_hunk":"@@ -0,0 +1,191 @@\n+/******************************************************************************\n+**\n+** This file is part of libcommhistory.\n+**\n+** Copyright (C) 2013 Jolla Ltd.\n+** Contact: John Brooks <[email protected]>\n+**\n+** This library is free software; you can redistribute it and/or modify it\n+** under the terms of the GNU Lesser General Public License version 2.1 as\n+** published by the Free Software Foundation.\n+**\n+** This library is distributed in the hope that it will be useful, but\n+** WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY\n+** or FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public\n+** License for more details.\n+**\n+** You should have received a copy of the GNU Lesser General Public License\n+** along with this library; if not, write to the Free Software Foundation, Inc.,\n+** 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA\n+**\n+******************************************************************************/\n+\n+#include \"commhistorydatabase.h\"\n+#include <QDir>\n+#include <QFile>\n+#include <QSqlError>\n+#include <QSqlQuery>\n+#include <QDebug>\n+\n+#if QT_VERSION < QT_VERSION_CHECK(5, 0, 0)\n+#include <QDesktopServices>\n+#else\n+#include <QStandardPaths>\n+#endif\n+\n+// Appended to GenericDataLocation (or a hardcoded equivalent on Qt4)\n+#define COMMHISTORY_DATABASE_DIR \"/commhistory/\"\n+#define COMMHISTORY_DATABASE_NAME \"commhistory.db\"\n+\n+static const char *db_setup[] = {\n+ \"PRAGMA temp_store = MEMORY\",\n+ \"PRAGMA journal_mode = WAL\",\n+ \"PRAGMA foreign_keys = ON\"\n+};\n+static int db_setup_count = sizeof(db_setup) / sizeof(*db_setup);\n+\n+static const char *db_schema[] = {\n+ \"PRAGMA encoding = \\\"UTF-16\\\"\",\n+\n+ \"CREATE TABLE Groups ( \"\n+ \" id INTEGER PRIMARY KEY AUTOINCREMENT, \"\n+ \" localUid TEXT, \"\n+ \" remoteUids TEXT, \"\n+ \" type INTEGER, \"\n+ \" chatName TEXT, \"\n+ \" lastModified INTEGER UNSIGNED \"\n+ \")\",\n+\n+ \"CREATE TABLE Events ( \"\n+ \" id INTEGER PRIMARY KEY AUTOINCREMENT, \"\n+ \" type INTEGER, \"\n+ \" startTime INTEGER, \"\n+ \" endTime INTEGER, \"\n+ \" direction INTEGER, \"\n+ \" isDraft INTEGER, \"\n+ \" isRead INTEGER, \"\n+ \" isMissedCall INTEGER, \"\n+ \" isEmergencyCall INTEGER, \"\n+ \" status INTEGER, \"\n+ \" bytesReceived INTEGER, \"\n+ \" localUid TEXT, \"\n+ \" remoteUid TEXT, \"\n+ \" parentId INTEGER, \"\n+ \" subject TEXT, \"\n+ \" freeText TEXT, \"\n+ \" groupId INTEGER, \"\n+ \" messageToken TEXT, \"\n+ \" lastModified INTEGER, \"\n+ \" vCardFileName TEXT, \"\n+ \" vCardLabel TEXT, \"\n+ \" isDeleted INTEGER, \"\n+ \" reportDelivery INTEGER, \"\n+ \" validityPeriod INTEGER, \"\n+ \" contentLocation TEXT, \"\n+ \" messageParts TEXT, \"\n+ \" headers TEXT, \"\n+ \" readStatus INTEGER, \"\n+ \" reportRead INTEGER, \"\n+ \" reportedReadRequested INTEGER, \"\n+ \" mmsId INTEGER, \"\n+ \" isAction INTEGER, \"\n+ \" FOREIGN KEY(groupId) REFERENCES Groups(id) ON DELETE CASCADE \"\n+ \")\"\n+};","path":"src/commhistorydatabase.cpp","position":94,"original_position":94,"commit_id":"3a22dbdac308751b34a1b4b9406e2bd1ecf2e95d","original_commit_id":"3a22dbdac308751b34a1b4b9406e2bd1ecf2e95d","user":{"login":"matthewvogt","id":2569784,"avatar_url":"https://secure.gravatar.com/avatar/f66a825bd08acdf905252948e76e4d2b?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"f66a825bd08acdf905252948e76e4d2b","url":"https://api.github.com/users/matthewvogt","html_url":"https://github.com/matthewvogt","followers_url":"https://api.github.com/users/matthewvogt/followers","following_url":"https://api.github.com/users/matthewvogt/following{/other_user}","gists_url":"https://api.github.com/users/matthewvogt/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewvogt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewvogt/subscriptions","organizations_url":"https://api.github.com/users/matthewvogt/orgs","repos_url":"https://api.github.com/users/matthewvogt/repos","events_url":"https://api.github.com/users/matthewvogt/events{/privacy}","received_events_url":"https://api.github.com/users/matthewvogt/received_events","type":"User"},"created_at":"2013-07-17T00:40:52Z","updated_at":"2013-07-17T00:40:52Z","html_url":"https://github.com/nemomobile/libcommhistory/pull/26#discussion_r5232531","pull_request_url":"https://api.github.com/repos/nemomobile/libcommhistory/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/nemomobile/libcommhistory/pulls/comments/5232531"},"html":{"href":"https://github.com/nemomobile/libcommhistory/pull/26#discussion_r5232531"},"pull_request":{"href":"https://api.github.com/repos/nemomobile/libcommhistory/pulls/26"}}}} | {
"id": 5357750,
"name": "libcommhistory",
"url": "https://github.com/nemomobile/libcommhistory"
} | {
"id": null,
"login": "matthewvogt",
"gravatar_id": "f66a825bd08acdf905252948e76e4d2b",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "nemomobile",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-17T00:40:52 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":7,"fork":false,"size":2492,"owner":"nemomobile","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2012-08-09T09:00:39-07:00","pushed_at":"2013-06-16T21:08:05-07:00","master_branch":"master","organization":"nemomobile"},"actor_attributes":{"type":"User","name":"mvogt","email":"[email protected]"},"url":"https://github.com/nemomobile/libcommhistory/pull/26#discussion_r5232531"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/comments/4833782","id":4833782,"body":"Should also add a `margin-left: -325px` to center the modal","diff_hunk":"@@ -0,0 +1,21 @@\n+#deleteresources-modal {\n+ width: 650px;","path":"node_modules/oae-core/deleteresources/css/deleteresources.css","position":2,"original_position":2,"commit_id":"d0084921e764892371853b94a88a186d91d148ed","original_commit_id":"d0084921e764892371853b94a88a186d91d148ed","user":{"login":"nicolaasmatthijs","id":109850,"avatar_url":"https://secure.gravatar.com/avatar/8d128e44d86f7ea45534291c2c36599a?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"8d128e44d86f7ea45534291c2c36599a","url":"https://api.github.com/users/nicolaasmatthijs","html_url":"https://github.com/nicolaasmatthijs","followers_url":"https://api.github.com/users/nicolaasmatthijs/followers","following_url":"https://api.github.com/users/nicolaasmatthijs/following{/other_user}","gists_url":"https://api.github.com/users/nicolaasmatthijs/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaasmatthijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaasmatthijs/subscriptions","organizations_url":"https://api.github.com/users/nicolaasmatthijs/orgs","repos_url":"https://api.github.com/users/nicolaasmatthijs/repos","events_url":"https://api.github.com/users/nicolaasmatthijs/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaasmatthijs/received_events","type":"User"},"created_at":"2013-06-23T18:00:12Z","updated_at":"2013-06-23T18:00:12Z","html_url":"https://github.com/oaeproject/3akai-ux/pull/2947#discussion_r4833782","pull_request_url":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/2947","_links":{"self":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/comments/4833782"},"html":{"href":"https://github.com/oaeproject/3akai-ux/pull/2947#discussion_r4833782"},"pull_request":{"href":"https://api.github.com/repos/oaeproject/3akai-ux/pulls/2947"}}}} | {
"id": 761723,
"name": "3akai-ux",
"url": "https://github.com/oaeproject/3akai-ux"
} | {
"id": null,
"login": "nicolaasmatthijs",
"gravatar_id": "8d128e44d86f7ea45534291c2c36599a",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "oaeproject",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-23T18:00:12 | null | {"repository":{"description":"Open Academic Environment (OAE) Front-End","homepage":"http://www.oaeproject.org","watchers":115,"stargazers":115,"forks":208,"fork":false,"size":22960,"owner":"oaeproject","private":false,"open_issues":17,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2010-07-07T05:48:50-07:00","pushed_at":"2013-06-23T09:41:08-07:00","master_branch":"master","organization":"oaeproject"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/oaeproject/3akai-ux/pull/2947#discussion_r4833782"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/phpmyadmin/error-reporting-server/pulls/comments/6259990","id":6259990,"body":"it doesnt say anything since first of all we are not compatible with all versions of php 5 we start at like 5.3 at least for the tests. Also single files are not compatible with a version of php it is the whole project so if we need this kind of info we can have it in the readme not separately in files.","diff_hunk":"@@ -6,34 +6,31 @@\n * This file is application-wide controller file. You can put all\n * application-wide controller-related methods here.\n *\n- * PHP 5","path":"app/Controller/AppController.php","position":4,"original_position":4,"commit_id":"33a62df5999d2aa771aef17a62d971494d0780c9","original_commit_id":"33a62df5999d2aa771aef17a62d971494d0780c9","user":{"login":"m0hamed","id":896466,"avatar_url":"https://0.gravatar.com/avatar/fca7aa9368b8deaf2ee2d2b30452c980?d=https%3A%2F%2Fidenticons.github.com%2Fd0a904c1fa8890706ffed4e6b6ba5675.png","gravatar_id":"fca7aa9368b8deaf2ee2d2b30452c980","url":"https://api.github.com/users/m0hamed","html_url":"https://github.com/m0hamed","followers_url":"https://api.github.com/users/m0hamed/followers","following_url":"https://api.github.com/users/m0hamed/following{/other_user}","gists_url":"https://api.github.com/users/m0hamed/gists{/gist_id}","starred_url":"https://api.github.com/users/m0hamed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m0hamed/subscriptions","organizations_url":"https://api.github.com/users/m0hamed/orgs","repos_url":"https://api.github.com/users/m0hamed/repos","events_url":"https://api.github.com/users/m0hamed/events{/privacy}","received_events_url":"https://api.github.com/users/m0hamed/received_events","type":"User"},"created_at":"2013-09-10T08:26:54Z","updated_at":"2013-09-10T08:26:54Z","html_url":"https://github.com/phpmyadmin/error-reporting-server/pull/17#discussion_r6259990","pull_request_url":"https://api.github.com/repos/phpmyadmin/error-reporting-server/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/phpmyadmin/error-reporting-server/pulls/comments/6259990"},"html":{"href":"https://github.com/phpmyadmin/error-reporting-server/pull/17#discussion_r6259990"},"pull_request":{"href":"https://api.github.com/repos/phpmyadmin/error-reporting-server/pulls/17"}}}} | {
"id": 11733893,
"name": "error-reporting-server",
"url": "https://github.com/phpmyadmin/error-reporting-server"
} | {
"id": null,
"login": "m0hamed",
"gravatar_id": "fca7aa9368b8deaf2ee2d2b30452c980",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "phpmyadmin",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-10T08:26:54 | null | {"repository":{"description":"phpMyAdmin server side component for the error reporting system","watchers":1,"stargazers":1,"forks":1,"fork":false,"size":240,"owner":"phpmyadmin","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"PHP","created_at":"2013-07-29T00:39:50-07:00","pushed_at":"2013-09-05T09:53:40-07:00","master_branch":"master","organization":"phpmyadmin"},"actor_attributes":{"type":"User","name":"Mohamed Ashraf","location":"egypt","email":"[email protected]"},"url":"https://github.com/phpmyadmin/error-reporting-server/pull/17#discussion_r6259990"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/prometheus/prometheus/pulls/comments/4167919","id":4167919,"body":"In the case of wrapping a single line, I think the correctly ordered form is more readable, no?","diff_hunk":"@@ -74,12 +74,14 @@ func NewTieredStorage(appendToMemoryQueueDepth, appendToDiskQueueDepth, viewQueu\n }\n \n // Enqueues Samples for storage.\n-func (t *TieredStorage) AppendSamples(s model.Samples) (err error) {\n+func (t *TieredStorage) AppendSamples(samples model.Samples) (err error) {\n \tif len(t.draining) > 0 {\n \t\treturn fmt.Errorf(\"Storage is in the process of draining.\")\n \t}\n \n-\tt.appendToMemoryQueue <- s\n+\tt.memoryMutex.Lock()\n+\tt.memoryArena.AppendSamples(samples)\n+\tt.memoryMutex.Unlock()","path":"storage/metric/tiered.go","position":45,"original_position":45,"commit_id":"0339108201f27bfa64c948d1b422cb87994a4bbe","original_commit_id":"0339108201f27bfa64c948d1b422cb87994a4bbe","user":{"login":"juliusv","id":538008,"avatar_url":"https://secure.gravatar.com/avatar/60d05309d93979e15117f3dfbda6a15f?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"60d05309d93979e15117f3dfbda6a15f","url":"https://api.github.com/users/juliusv","html_url":"https://github.com/juliusv","followers_url":"https://api.github.com/users/juliusv/followers","following_url":"https://api.github.com/users/juliusv/following{/other_user}","gists_url":"https://api.github.com/users/juliusv/gists{/gist_id}","starred_url":"https://api.github.com/users/juliusv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliusv/subscriptions","organizations_url":"https://api.github.com/users/juliusv/orgs","repos_url":"https://api.github.com/users/juliusv/repos","events_url":"https://api.github.com/users/juliusv/events{/privacy}","received_events_url":"https://api.github.com/users/juliusv/received_events","type":"User"},"created_at":"2013-05-10T09:05:16Z","updated_at":"2013-05-10T09:05:16Z","html_url":"https://github.com/prometheus/prometheus/pull/232#discussion_r4167919","pull_request_url":"https://api.github.com/repos/prometheus/prometheus/pulls/232","_links":{"self":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/comments/4167919"},"html":{"href":"https://github.com/prometheus/prometheus/pull/232#discussion_r4167919"},"pull_request":{"href":"https://api.github.com/repos/prometheus/prometheus/pulls/232"}}}} | {
"id": 6838921,
"name": "prometheus",
"url": "https://github.com/prometheus/prometheus"
} | {
"id": null,
"login": "juliusv",
"gravatar_id": "60d05309d93979e15117f3dfbda6a15f",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "prometheus",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-10T09:05:16 | null | {"repository":{"description":"Bedecke deinen Himmel, Zeus! A new kid is in town.","homepage":"","watchers":10,"stargazers":10,"forks":4,"fork":false,"size":1772,"owner":"prometheus","private":false,"open_issues":0,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Go","created_at":"2012-11-24T03:14:12-08:00","pushed_at":"2013-05-09T12:29:50-07:00","master_branch":"master","organization":"prometheus"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/prometheus/prometheus/pull/232#discussion_r4167919"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/4417767","id":4417767,"body":"Would it be worthwhile to add yardoc for the new method signature?","diff_hunk":"@@ -33,16 +33,16 @@ def computer_name\n @computer_name\n end\n \n- def computer_uri\n- \"WinNT://#{computer_name}\"\n+ def computer_uri(host = '.')","path":"lib/puppet/util/adsi.rb","position":6,"original_position":6,"commit_id":"b4f84e1fde6a79af0a04c31f8f0b688f223b7a7f","original_commit_id":"b4f84e1fde6a79af0a04c31f8f0b688f223b7a7f","user":{"login":"adrienthebo","id":172194,"avatar_url":"https://secure.gravatar.com/avatar/3bc6d4c30aba3b9e7d15a92d4b894d27?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"3bc6d4c30aba3b9e7d15a92d4b894d27","url":"https://api.github.com/users/adrienthebo","html_url":"https://github.com/adrienthebo","followers_url":"https://api.github.com/users/adrienthebo/followers","following_url":"https://api.github.com/users/adrienthebo/following{/other_user}","gists_url":"https://api.github.com/users/adrienthebo/gists{/gist_id}","starred_url":"https://api.github.com/users/adrienthebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrienthebo/subscriptions","organizations_url":"https://api.github.com/users/adrienthebo/orgs","repos_url":"https://api.github.com/users/adrienthebo/repos","events_url":"https://api.github.com/users/adrienthebo/events{/privacy}","received_events_url":"https://api.github.com/users/adrienthebo/received_events","type":"User"},"created_at":"2013-05-28T17:14:41Z","updated_at":"2013-05-28T17:14:41Z","html_url":"https://github.com/puppetlabs/puppet/pull/1663#discussion_r4417767","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/1663","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/4417767"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/1663#discussion_r4417767"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/1663"}}}} | {
"id": 910744,
"name": "puppet",
"url": "https://github.com/puppetlabs/puppet"
} | {
"id": null,
"login": "adrienthebo",
"gravatar_id": "3bc6d4c30aba3b9e7d15a92d4b894d27",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "puppetlabs",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-05-28T17:14:41 | null | {"repository":{"description":"Server automation framework and application","homepage":"http://www.puppetlabs.com/puppet/introduction/","watchers":1312,"stargazers":1312,"forks":569,"fork":false,"size":26748,"owner":"puppetlabs","private":false,"open_issues":19,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2010-09-14T12:26:44-07:00","pushed_at":"2013-05-24T13:46:43-07:00","master_branch":"master","organization":"puppetlabs"},"actor_attributes":{"type":"User","name":"Adrien Thebo","company":"Puppet Labs","blog":"http://somethingsinistral.net","location":"Portland, Oregon","email":"[email protected]"},"url":"https://github.com/puppetlabs/puppet/pull/1663#discussion_r4417767"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/puppetlabs/hiera/pulls/comments/3273311","id":3273311,"body":"Admittedly this is pre-existing but this regex is pretty magical, but since this PR is dealing with expanding hierarchy levels that look like `%{foo}/%{bar}` I'm going to nitpick a little. This is automatically assuming that we're using `/` as the file separator, which means that this will not behave as expected on Windows.","diff_hunk":"@@ -56,8 +56,11 @@ def datasources(scope, override=nil, hierarchy=nil)\n hierarchy.insert(0, override) if override\n \n hierarchy.flatten.map do |source|\n- source = parse_string(source, scope)\n- yield(source) unless source == \"\" or source =~ /(^\\/|\\/\\/|\\/$)/\n+ if sources = parse_string(source, scope)\n+ sources.each do |source|\n+ yield(source) unless source == \"\" or source =~ /(^\\/|\\/\\/|\\/$)/","path":"lib/hiera/backend.rb","position":8,"original_position":8,"commit_id":"f5f44295a26ee22bcee1bc24dc46c2a6f95efcc2","original_commit_id":"f5f44295a26ee22bcee1bc24dc46c2a6f95efcc2","user":{"login":"adrienthebo","id":172194,"avatar_url":"https://secure.gravatar.com/avatar/3bc6d4c30aba3b9e7d15a92d4b894d27?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"3bc6d4c30aba3b9e7d15a92d4b894d27","url":"https://api.github.com/users/adrienthebo","html_url":"https://github.com/adrienthebo","followers_url":"https://api.github.com/users/adrienthebo/followers","following_url":"https://api.github.com/users/adrienthebo/following","gists_url":"https://api.github.com/users/adrienthebo/gists{/gist_id}","starred_url":"https://api.github.com/users/adrienthebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrienthebo/subscriptions","organizations_url":"https://api.github.com/users/adrienthebo/orgs","repos_url":"https://api.github.com/users/adrienthebo/repos","events_url":"https://api.github.com/users/adrienthebo/events{/privacy}","received_events_url":"https://api.github.com/users/adrienthebo/received_events","type":"User"},"created_at":"2013-03-07T01:14:26Z","updated_at":"2013-03-07T01:14:26Z","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/hiera/pulls/comments/3273311"},"html":{"href":"https://github.com/puppetlabs/hiera/pull/48#discussion_r3273311"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/hiera/pulls/48"}}}} | {
"id": 1845241,
"name": "hiera",
"url": "https://github.com/puppetlabs/hiera"
} | {
"id": null,
"login": "adrienthebo",
"gravatar_id": "3bc6d4c30aba3b9e7d15a92d4b894d27",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "puppetlabs",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-07T01:14:26 | null | {"repository":{"description":"Lightweight Pluggable Hierarchical Database","homepage":"http://projects.puppetlabs.com/projects/hiera/","watchers":146,"stargazers":146,"forks":67,"fork":false,"size":332,"owner":"puppetlabs","private":false,"open_issues":5,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2011-06-03T17:48:22-07:00","pushed_at":"2013-03-05T15:25:04-08:00","master_branch":"master","organization":"puppetlabs"},"actor_attributes":{"type":"User","name":"Adrien Thebo","company":"Puppet Labs","blog":"http://somethingsinistral.net","location":"Portland, Oregon","email":"[email protected]"},"url":"https://github.com/puppetlabs/hiera/pull/48#discussion_r3273311"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/puppetlabs/trapperkeeper/pulls/comments/8484380","id":8484380,"diff_hunk":"@@ -184,7 +184,7 @@\n `puppetlabs.trapperkeeper.core/-main` if you use `puppetlabs.trapperkeeper.core`\n as the `:main` namespace in your leinengen project.\"\n [& args]\n- {:pre [(seq? args)\n+ {:pre [((some-fn seq? nil?) args)","path":"src/puppetlabs/trapperkeeper/core.clj","position":14,"original_position":14,"commit_id":"cdef14bb6a81d071b380f74714cdb4e326a334b9","original_commit_id":"4cc2ebd80faa1f048771f4d0cd4a5a19b555ebc2","user":{"login":"nwolfe","id":1787615,"avatar_url":"https://gravatar.com/avatar/9a10f2655ebdb5e9ed6be6a1add94802?d=https%3A%2F%2Fidenticons.github.com%2F90cfa8d4d5ecd1f592c029f3778d920d.png&r=x","gravatar_id":"9a10f2655ebdb5e9ed6be6a1add94802","url":"https://api.github.com/users/nwolfe","html_url":"https://github.com/nwolfe","followers_url":"https://api.github.com/users/nwolfe/followers","following_url":"https://api.github.com/users/nwolfe/following{/other_user}","gists_url":"https://api.github.com/users/nwolfe/gists{/gist_id}","starred_url":"https://api.github.com/users/nwolfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwolfe/subscriptions","organizations_url":"https://api.github.com/users/nwolfe/orgs","repos_url":"https://api.github.com/users/nwolfe/repos","events_url":"https://api.github.com/users/nwolfe/events{/privacy}","received_events_url":"https://api.github.com/users/nwolfe/received_events","type":"User","site_admin":false},"body":"`some-fn` doesn't dig into the `args`, it operates on it as a collection. It's like saying \"args needs to satisfy one of these predicates: nil? seq?\"","created_at":"2013-12-19T21:07:23Z","updated_at":"2013-12-19T21:07:23Z","html_url":"https://github.com/puppetlabs/trapperkeeper/pull/93#discussion_r8484380","pull_request_url":"https://api.github.com/repos/puppetlabs/trapperkeeper/pulls/93","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper/pulls/comments/8484380"},"html":{"href":"https://github.com/puppetlabs/trapperkeeper/pull/93#discussion_r8484380"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/trapperkeeper/pulls/93"}}}} | {
"id": 13941296,
"name": "trapperkeeper",
"url": "https://github.com/puppetlabs/trapperkeeper"
} | {
"id": null,
"login": "nwolfe",
"gravatar_id": "9a10f2655ebdb5e9ed6be6a1add94802",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "puppetlabs",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-19T21:07:23 | null | {"repository":{"description":"","watchers":1,"stargazers":1,"forks":3,"fork":false,"size":790,"owner":"puppetlabs","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Clojure","created_at":"2013-10-28T16:14:43-07:00","pushed_at":"2013-12-19T10:57:28-08:00","master_branch":"master","organization":"puppetlabs"},"actor_attributes":{"type":"User","name":"Nate Wolfe","company":"Puppet Labs","location":"Portland, Oregon","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/puppetlabs/trapperkeeper/pull/93#discussion_r8484380"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/4930604","id":4930604,"body":"Why the preceeding `_`? I don't think I've seen that anywhere else in the code base. Also, the name `_to_hash` doesn't seem right since those style of methods don't normally take a parameter and instead just return the representation of the receiver in some form. Maybe `add_entries_to(target)` would be a better name?","diff_hunk":"@@ -74,6 +74,22 @@ def is_local_scope?\n def parent\n @parent\n end\n+\n+ def _to_hash(target = {})","path":"lib/puppet/parser/scope.rb","position":5,"original_position":5,"commit_id":"d54d88702f31615af78744c09b95d5b5019e591e","original_commit_id":"d54d88702f31615af78744c09b95d5b5019e591e","user":{"login":"zaphod42","id":295810,"avatar_url":"https://secure.gravatar.com/avatar/36ccf398adbe1a4264d57b32917b990c?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"36ccf398adbe1a4264d57b32917b990c","url":"https://api.github.com/users/zaphod42","html_url":"https://github.com/zaphod42","followers_url":"https://api.github.com/users/zaphod42/followers","following_url":"https://api.github.com/users/zaphod42/following{/other_user}","gists_url":"https://api.github.com/users/zaphod42/gists{/gist_id}","starred_url":"https://api.github.com/users/zaphod42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaphod42/subscriptions","organizations_url":"https://api.github.com/users/zaphod42/orgs","repos_url":"https://api.github.com/users/zaphod42/repos","events_url":"https://api.github.com/users/zaphod42/events{/privacy}","received_events_url":"https://api.github.com/users/zaphod42/received_events","type":"User"},"created_at":"2013-06-28T00:48:41Z","updated_at":"2013-06-28T00:48:41Z","html_url":"https://github.com/puppetlabs/puppet/pull/1735#discussion_r4930604","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/1735","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/4930604"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/1735#discussion_r4930604"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/1735"}}}} | {
"id": 910744,
"name": "puppet",
"url": "https://github.com/puppetlabs/puppet"
} | {
"id": null,
"login": "zaphod42",
"gravatar_id": "36ccf398adbe1a4264d57b32917b990c",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "puppetlabs",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-28T00:48:41 | null | {"repository":{"description":"Server automation framework and application","homepage":"http://www.puppetlabs.com/puppet/introduction/","watchers":1367,"stargazers":1367,"forks":590,"fork":false,"size":27116,"owner":"puppetlabs","private":false,"open_issues":28,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2010-09-14T12:26:44-07:00","pushed_at":"2013-06-27T16:57:54-07:00","master_branch":"master","organization":"puppetlabs"},"actor_attributes":{"type":"User","name":"Andrew Parker","company":"Puppet Labs","blog":"http://softwarelifecycle.wordpress.com","location":"Portland, OR","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/puppetlabs/puppet/pull/1735#discussion_r4930604"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/7846247","id":7846247,"diff_hunk":"@@ -0,0 +1,44 @@\n+#!/usr/bin/env ruby\n+\n+require 'spec_helper'\n+require 'puppet/util/windows'\n+\n+describe \"Puppet::Util::Windows::SecurityDescriptor\", :if => Puppet.features.microsoft_windows? do\n+ let(:dacl) { Puppet::Util::Windows::AccessControlList.new }\n+\n+ let(:owner_sid) { 'S-1-5-18' }\n+ let(:group_sid) { 'S-1-0-0' }\n+ let(:new_sid) { 'S-1-5-32-500-1-2-3' }\n+\n+ context \"owner\" do\n+ it \"changes the owner\" do\n+ sd = Puppet::Util::Windows::SecurityDescriptor.new(owner_sid, group_sid, dacl)\n+ sd.owner = new_sid\n+\n+ sd.owner.should == new_sid\n+ end\n+\n+ it \"performs a noop if the new owner is the same as the old one\" do\n+ sd = Puppet::Util::Windows::SecurityDescriptor.new(owner_sid, group_sid, dacl)\n+ sd.owner = sd.owner\n+\n+ sd.dacl.object_id.should == dacl.object_id\n+ end\n+ end\n+\n+ context \"group\" do\n+ it \"changes the group\" do\n+ sd = Puppet::Util::Windows::SecurityDescriptor.new(owner_sid, group_sid, dacl)\n+ sd.group = new_sid\n+\n+ sd.group.should == new_sid","path":"spec/unit/util/windows/security_descriptor_spec.rb","position":34,"original_position":34,"commit_id":"02a810b2f45bea81928bd930e6bad3f915509e0b","original_commit_id":"02a810b2f45bea81928bd930e6bad3f915509e0b","user":{"login":"Iristyle","id":394081,"avatar_url":"https://1.gravatar.com/avatar/c807a386363efa2147c76f4769cb24ee?d=https%3A%2F%2Fidenticons.github.com%2F70d00b04bdbb2a3f332ad608e26e7c15.png&r=x","gravatar_id":"c807a386363efa2147c76f4769cb24ee","url":"https://api.github.com/users/Iristyle","html_url":"https://github.com/Iristyle","followers_url":"https://api.github.com/users/Iristyle/followers","following_url":"https://api.github.com/users/Iristyle/following{/other_user}","gists_url":"https://api.github.com/users/Iristyle/gists{/gist_id}","starred_url":"https://api.github.com/users/Iristyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Iristyle/subscriptions","organizations_url":"https://api.github.com/users/Iristyle/orgs","repos_url":"https://api.github.com/users/Iristyle/repos","events_url":"https://api.github.com/users/Iristyle/events{/privacy}","received_events_url":"https://api.github.com/users/Iristyle/received_events","type":"User","site_admin":false},"body":"Same comment here about verifying dacl changed.","created_at":"2013-11-22T01:57:48Z","updated_at":"2013-11-22T01:57:48Z","html_url":"https://github.com/puppetlabs/puppet/pull/2099#discussion_r7846247","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet/pulls/2099","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/comments/7846247"},"html":{"href":"https://github.com/puppetlabs/puppet/pull/2099#discussion_r7846247"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet/pulls/2099"}}}} | {
"id": 910744,
"name": "puppet",
"url": "https://github.com/puppetlabs/puppet"
} | {
"id": null,
"login": "Iristyle",
"gravatar_id": "c807a386363efa2147c76f4769cb24ee",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "puppetlabs",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-22T01:57:48 | null | {"repository":{"description":"Server automation framework and application","homepage":"http://www.puppetlabs.com/puppet/introduction/","watchers":1643,"stargazers":1643,"forks":757,"fork":false,"size":69974,"owner":"puppetlabs","private":false,"open_issues":9,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2010-09-14T12:26:44-07:00","pushed_at":"2013-11-21T17:26:23-08:00","master_branch":"master","organization":"puppetlabs"},"actor_attributes":{"type":"User","name":"Ethan J. Brown","location":"CT","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/puppetlabs/puppet/pull/2099#discussion_r7846247"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/rackerlabs/otter/pulls/comments/5170385","id":5170385,"body":"Non-blocking: We may need to decide about semicolon. In CQL3, batch operations need to have semicolons. I guess there can be separate PR to add semicolon to all the queries and remove comment about batch statements not having semicolon","diff_hunk":"@@ -716,21 +716,37 @@ def delete_group(self):\n \"\"\"\n see :meth:`otter.models.interface.IScalingGroup.delete_group`\n \"\"\"\n- def _maybe_delete(state):\n- if len(state.active) + len(state.pending) > 0:\n- raise GroupNotEmptyError(self.tenant_id, self.uuid)\n-\n+ # Events can only be deleted by policy id, since that and trigger are\n+ # the only parts of the compound key\n+ def _delete_everything(policies):\n+ params = {\n+ 'tenantId': self.tenant_id,\n+ 'groupId': self.uuid\n+ }\n queries = [\n _cql_delete_all_in_group.format(cf=table) for table in\n (self.config_table, self.launch_table, self.policies_table,\n self.webhooks_table, self.state_table)]\n \n- b = Batch(queries,\n- {\"tenantId\": self.tenant_id, \"groupId\": self.uuid},\n+ if len(policies) > 0:\n+ events_query, events_params = _delete_events_query_and_params(\n+ policies.keys(), self.event_table)\n+ queries.append(events_query.rstrip(';'))","path":"otter/models/cass.py","position":25,"original_position":25,"commit_id":"648fa6d6735ef34e120e2c8be5659ad4fc08d7df","original_commit_id":"648fa6d6735ef34e120e2c8be5659ad4fc08d7df","user":{"login":"manishtomar","id":758529,"avatar_url":"https://secure.gravatar.com/avatar/a7b7b5d5928ed1e87a4bacd94b3bfbac?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"a7b7b5d5928ed1e87a4bacd94b3bfbac","url":"https://api.github.com/users/manishtomar","html_url":"https://github.com/manishtomar","followers_url":"https://api.github.com/users/manishtomar/followers","following_url":"https://api.github.com/users/manishtomar/following{/other_user}","gists_url":"https://api.github.com/users/manishtomar/gists{/gist_id}","starred_url":"https://api.github.com/users/manishtomar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishtomar/subscriptions","organizations_url":"https://api.github.com/users/manishtomar/orgs","repos_url":"https://api.github.com/users/manishtomar/repos","events_url":"https://api.github.com/users/manishtomar/events{/privacy}","received_events_url":"https://api.github.com/users/manishtomar/received_events","type":"User"},"created_at":"2013-07-12T17:45:30Z","updated_at":"2013-07-12T17:45:30Z","html_url":"https://github.com/rackerlabs/otter/pull/256#discussion_r5170385","pull_request_url":"https://api.github.com/repos/rackerlabs/otter/pulls/256","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/otter/pulls/comments/5170385"},"html":{"href":"https://github.com/rackerlabs/otter/pull/256#discussion_r5170385"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/otter/pulls/256"}}}} | {
"id": 6097139,
"name": "otter",
"url": "https://github.com/rackerlabs/otter"
} | {
"id": null,
"login": "manishtomar",
"gravatar_id": "a7b7b5d5928ed1e87a4bacd94b3bfbac",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "rackerlabs",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-12T17:45:30 | null | {"repository":{"description":"Rackspace Autoscale","homepage":"","watchers":14,"stargazers":14,"forks":2,"fork":false,"size":3256,"owner":"rackerlabs","private":false,"open_issues":11,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Python","created_at":"2012-10-05T14:35:59-07:00","pushed_at":"2013-07-12T10:34:36-07:00","master_branch":"master","organization":"rackerlabs"},"actor_attributes":{"type":"User","name":"Manish Tomar","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/rackerlabs/otter/pull/256#discussion_r5170385"} |
PullRequestReviewCommentEvent | true | {"comment":{"_links":{"html":{"href":"https://github.com/symfony-fr/symfony-docs-fr/pull/218#discussion_r2868689"},"pull_request":{"href":"https://api.github.com/repos/symfony-fr/symfony-docs-fr/pulls/218"},"self":{"href":"https://api.github.com/repos/symfony-fr/symfony-docs-fr/pulls/comments/2868689"}},"updated_at":"2013-02-02T09:45:51Z","body":"idem ici","commit_id":"661662585bcc0d69e26a9c399bda06547e77127d","original_commit_id":"661662585bcc0d69e26a9c399bda06547e77127d","url":"https://api.github.com/repos/symfony-fr/symfony-docs-fr/pulls/comments/2868689","created_at":"2013-02-02T09:45:51Z","position":25,"original_position":25,"id":2868689,"user":{"avatar_url":"https://secure.gravatar.com/avatar/79ef9e05f2bf86044fe3151e9c0a54ff?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","received_events_url":"https://api.github.com/users/gregquat/received_events","events_url":"https://api.github.com/users/gregquat/events{/privacy}","repos_url":"https://api.github.com/users/gregquat/repos","login":"gregquat","starred_url":"https://api.github.com/users/gregquat/starred{/owner}{/repo}","gravatar_id":"79ef9e05f2bf86044fe3151e9c0a54ff","type":"User","organizations_url":"https://api.github.com/users/gregquat/orgs","url":"https://api.github.com/users/gregquat","id":293127,"subscriptions_url":"https://api.github.com/users/gregquat/subscriptions","followers_url":"https://api.github.com/users/gregquat/followers","gists_url":"https://api.github.com/users/gregquat/gists{/gist_id}","following_url":"https://api.github.com/users/gregquat/following"},"path":"book/translation.rst"}} | {
"id": 1795810,
"name": "symfony-docs-fr",
"url": "https://github.com/symfony-fr/symfony-docs-fr"
} | {
"id": null,
"login": "gregquat",
"gravatar_id": "79ef9e05f2bf86044fe3151e9c0a54ff",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "symfony-fr",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-02T09:45:51 | null | {"repository":{"open_issues":4,"owner":"symfony-fr","has_downloads":true,"homepage":"","watchers":49,"created_at":"2011-05-24T14:21:36-07:00","has_wiki":true,"description":"French translation for Symfony2 documentation","stargazers":49,"organization":"symfony-fr","fork":false,"size":332,"language":"Python","pushed_at":"2013-02-02T01:06:25-08:00","forks":48,"private":false,"has_issues":true},"actor_attributes":{"company":"Obtao (http://obtao.com)","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709","type":"User","name":"Grégory Quatannens","blog":"https://twitter.com/gregquat","location":"Lille, France"},"url":"https://github.com/symfony-fr/symfony-docs-fr/pull/218#discussion_r2868689"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/tagasauris/external-hits-js/pulls/comments/8268751","id":8268751,"diff_hunk":"@@ -0,0 +1,80 @@\n+<!DOCTYPE html>\n+<html>\n+ <head>\n+ <title>External HIT: Scores</title>\n+ <meta name=\"viewport\" content=\"width=device-width, initial-scale=1.0\">\n+ <link href=\"bower_components/bootstrap/dist/css/bootstrap.min.css\" rel=\"stylesheet\">\n+ <!-- HTML5 Shim and Respond.js IE8 support of HTML5 elements and media queries -->\n+ <!-- WARNING: Respond.js doesn't work if you view the page via file:// -->\n+ <!--[if lt IE 9]>\n+ <script src=\"https://oss.maxcdn.com/libs/html5shiv/3.7.0/html5shiv.js\"></script>\n+ <script src=\"https://oss.maxcdn.com/libs/respond.js/1.3.0/respond.min.js\"></script>\n+ <![endif]-->\n+ <style type=\"text/css\">\n+ body, iframe, #loading {\n+ width: 100%;\n+ height: 100%;\n+ }\n+\n+ iframe {\n+ border: 0;\n+ display: none;\n+ }\n+\n+ #loading {\n+ text-align: center;\n+ }\n+\n+ </style>\n+ </head>\n+ <body>\n+ <div class=\"container\">\n+ <div class=\"navbar-header\">\n+ <a class=\"navbar-brand\" href=\"#\">Scores</a>\n+ </div>\n+ <div class=\"navbar-collapse collapse\">\n+ <ul class=\"nav navbar-nav\">\n+ <li><a id=\"start\" href=\"#\">Start</a></li>\n+ </ul>\n+ </div><!--/.nav-collapse -->\n+ </div>\n+ <div id=\"loading\" class=\"container\">\n+ <h1>Loading...</h1>\n+ </div>\n+ <iframe id=\"externalHolder\" src=\"http://127.0.0.1:8000/examples/scores/child.html?state=abcd&source=http://127.0.0.1:8000/examples/scores/response.json&results=http://127.0.0.1:8000/examples/scores/response.json\"></iframe>\n+\n+ <script src=\"bower_components/jquery/jquery.min.js\"></script>\n+ <script src=\"bower_components/bootstrap/dist/js/bootstrap.min.js\"></script>\n+ <script src=\"http://127.0.0.1:8000/lib/parent.js\"></script>\n+ <script type=\"text/javascript\">\n+ var client = new Tagasauris.ParentClient({\n+ iFrame: 'externalHolder',\n+ logging: true\n+ });\n+\n+ client.onStarted = function() {\n+ console.log('Parent: onStarted');\n+ }\n+\n+ client.onSuccess = function() {\n+ console.log('Parent: onSuccess');\n+ alert('Success!');\n+ }\n+\n+ client.onError = function() {\n+ console.log('Parent: onError');\n+ alert('Something went wrong!');\n+ }\n+\n+ var iFrame = document.getElementById('externalHolder');","path":"examples/scores/parent.html","position":69,"original_position":69,"commit_id":"9ddb7d6e954cfc400efc40a6b84ec6ae8d0607ae","original_commit_id":"9ddb7d6e954cfc400efc40a6b84ec6ae8d0607ae","user":{"login":"dancio","id":1325987,"avatar_url":"https://1.gravatar.com/avatar/1fd1fd45770d1d6a16d18ad07ca29569?d=https%3A%2F%2Fidenticons.github.com%2Fe53ddc05eaa4b407df55eb484dded487.png&r=x","gravatar_id":"1fd1fd45770d1d6a16d18ad07ca29569","url":"https://api.github.com/users/dancio","html_url":"https://github.com/dancio","followers_url":"https://api.github.com/users/dancio/followers","following_url":"https://api.github.com/users/dancio/following{/other_user}","gists_url":"https://api.github.com/users/dancio/gists{/gist_id}","starred_url":"https://api.github.com/users/dancio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dancio/subscriptions","organizations_url":"https://api.github.com/users/dancio/orgs","repos_url":"https://api.github.com/users/dancio/repos","events_url":"https://api.github.com/users/dancio/events{/privacy}","received_events_url":"https://api.github.com/users/dancio/received_events","type":"User","site_admin":false},"body":"oversight","created_at":"2013-12-11T15:04:19Z","updated_at":"2013-12-11T15:04:19Z","html_url":"https://github.com/tagasauris/external-hits-js/pull/1#discussion_r8268751","pull_request_url":"https://api.github.com/repos/tagasauris/external-hits-js/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/tagasauris/external-hits-js/pulls/comments/8268751"},"html":{"href":"https://github.com/tagasauris/external-hits-js/pull/1#discussion_r8268751"},"pull_request":{"href":"https://api.github.com/repos/tagasauris/external-hits-js/pulls/1"}}}} | {
"id": 14959647,
"name": "external-hits-js",
"url": "https://github.com/tagasauris/external-hits-js"
} | {
"id": null,
"login": "dancio",
"gravatar_id": "1fd1fd45770d1d6a16d18ad07ca29569",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "tagasauris",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-11T15:04:19 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":356,"owner":"tagasauris","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"created_at":"2013-12-05T08:48:06-08:00","pushed_at":"2013-12-11T06:21:48-08:00","master_branch":"master","organization":"tagasauris"},"actor_attributes":{"type":"User","name":"Daniel Kopka","company":"SharQ","location":"Poland","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/tagasauris/external-hits-js/pull/1#discussion_r8268751"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/5309524","id":5309524,"body":"If I had to guess it was because I was staring at NULL in the database all over the place when I was removing the compute_resource_id's and uuid's and looking at the table contents before writing the patch to be sure I understood what needed to be done. I think I just jumped from NULL to NIL. ","diff_hunk":"@@ -49,6 +49,19 @@ def create\n def edit\n end\n \n+ def manage\n+ vms = @compute_resource.vms\n+ Host.where(:uuid => NIL).each do |host|","path":"app/controllers/compute_resources_controller.rb","position":15,"original_position":15,"commit_id":"5e11cb7da864506cd08effd1b5f975481c18f403","original_commit_id":"5e11cb7da864506cd08effd1b5f975481c18f403","user":{"login":"jmontleon","id":1850500,"avatar_url":"https://secure.gravatar.com/avatar/86c8481505859ccfc22675d6e9956266?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"86c8481505859ccfc22675d6e9956266","url":"https://api.github.com/users/jmontleon","html_url":"https://github.com/jmontleon","followers_url":"https://api.github.com/users/jmontleon/followers","following_url":"https://api.github.com/users/jmontleon/following{/other_user}","gists_url":"https://api.github.com/users/jmontleon/gists{/gist_id}","starred_url":"https://api.github.com/users/jmontleon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmontleon/subscriptions","organizations_url":"https://api.github.com/users/jmontleon/orgs","repos_url":"https://api.github.com/users/jmontleon/repos","events_url":"https://api.github.com/users/jmontleon/events{/privacy}","received_events_url":"https://api.github.com/users/jmontleon/received_events","type":"User"},"created_at":"2013-07-21T17:03:13Z","updated_at":"2013-07-21T17:03:13Z","html_url":"https://github.com/theforeman/foreman/pull/803#discussion_r5309524","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/803","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/5309524"},"html":{"href":"https://github.com/theforeman/foreman/pull/803#discussion_r5309524"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/803"}}}} | {
"id": 258750,
"name": "foreman",
"url": "https://github.com/theforeman/foreman"
} | {
"id": null,
"login": "jmontleon",
"gravatar_id": "86c8481505859ccfc22675d6e9956266",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "theforeman",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-21T17:03:13 | null | {"repository":{"description":"an application that automates the lifecycle of servers ","homepage":"http://theforeman.org","watchers":277,"stargazers":277,"forks":152,"fork":false,"size":14500,"owner":"theforeman","private":false,"open_issues":38,"has_issues":false,"has_downloads":false,"has_wiki":false,"language":"Ruby","created_at":"2009-07-23T08:07:00-07:00","pushed_at":"2013-07-21T04:09:44-07:00","integrate_branch":"develop","master_branch":"develop","organization":"theforeman"},"actor_attributes":{"type":"User","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/theforeman/foreman/pull/803#discussion_r5309524"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/6028893","id":6028893,"body":"Not translated.","diff_hunk":"@@ -5,8 +5,16 @@ def show_console_action(state, link)\n state ? link : \"\"\n end\n \n- def vm_state s\n- s ? ' ' + _(\"Off\") : ' ' + _(\"On\")\n+ def vm_state vm\n+ if vm.state == 'PAUSED'\n+ ' ' + _(\"Paused\")\n+ else\n+ vm.ready? ? (\"On\") : (\"Off\")","path":"app/helpers/compute_resources_helper.rb","position":10,"original_position":10,"commit_id":"03aed2d4f1d4efdb47486ff7741703b938a28868","original_commit_id":"03aed2d4f1d4efdb47486ff7741703b938a28868","user":{"login":"lzap","id":49752,"avatar_url":"https://2.gravatar.com/avatar/b6acf830dd3925cb0033b7d86c95f5da?d=https%3A%2F%2Fidenticons.github.com%2F6c8d4342527b19b4a17adf20741f8863.png","gravatar_id":"b6acf830dd3925cb0033b7d86c95f5da","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User"},"created_at":"2013-08-28T09:22:26Z","updated_at":"2013-08-28T09:22:26Z","html_url":"https://github.com/theforeman/foreman/pull/845#discussion_r6028893","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/845","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/6028893"},"html":{"href":"https://github.com/theforeman/foreman/pull/845#discussion_r6028893"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/845"}}}} | {
"id": 258750,
"name": "foreman",
"url": "https://github.com/theforeman/foreman"
} | {
"id": null,
"login": "lzap",
"gravatar_id": "b6acf830dd3925cb0033b7d86c95f5da",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "theforeman",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-28T09:22:26 | null | {"repository":{"description":"an application that automates the lifecycle of servers ","homepage":"http://theforeman.org","watchers":297,"stargazers":297,"forks":165,"fork":false,"size":15316,"owner":"theforeman","private":false,"open_issues":46,"has_issues":false,"has_downloads":false,"has_wiki":false,"language":"Ruby","created_at":"2009-07-23T08:07:00-07:00","pushed_at":"2013-08-23T08:35:06-07:00","integrate_branch":"develop","master_branch":"develop","organization":"theforeman"},"actor_attributes":{"type":"User","name":"Lukáš Zapletal","company":"Red Hat","blog":"http://lukas.zapletalovi.com","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/theforeman/foreman/pull/845#discussion_r6028893"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/theforeman/foreman-installer/pulls/comments/8330121","id":8330121,"diff_hunk":"@@ -1 +1 @@\n-Subproject commit 57ce1c70c822ae96b2fe17512913981485160539\n+Subproject commit 63b5aba9fd8aee29ae2461d1819abc92095afc50","path":"modules/concat","position":2,"original_position":2,"commit_id":"18788a9f0b31b33c9c86ed29055ca5ce55bbac0f","original_commit_id":"18788a9f0b31b33c9c86ed29055ca5ce55bbac0f","user":{"login":"domcleal","id":482089,"avatar_url":"https://gravatar.com/avatar/b610ed8556fcee2b7ab876c642a4ce42?d=https%3A%2F%2Fidenticons.github.com%2Fa3815ce6fe14ce9594a64da81bbd7d15.png&r=x","gravatar_id":"b610ed8556fcee2b7ab876c642a4ce42","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"This updates us from ripienaar-concat to puppetlabs-concat, while we still have postgresql pinned at an older version which points at the former. I wouldn't bump it yet.","created_at":"2013-12-13T11:43:59Z","updated_at":"2013-12-13T11:43:59Z","html_url":"https://github.com/theforeman/foreman-installer/pull/80#discussion_r8330121","pull_request_url":"https://api.github.com/repos/theforeman/foreman-installer/pulls/80","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman-installer/pulls/comments/8330121"},"html":{"href":"https://github.com/theforeman/foreman-installer/pull/80#discussion_r8330121"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman-installer/pulls/80"}}}} | {
"id": 3449530,
"name": "foreman-installer",
"url": "https://github.com/theforeman/foreman-installer"
} | {
"id": null,
"login": "domcleal",
"gravatar_id": "b610ed8556fcee2b7ab876c642a4ce42",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "theforeman",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-13T11:43:59 | null | {"repository":{"description":"Automated Foreman installation and configuration","homepage":"http://theforeman.org/projects/foreman/wiki/Using_Puppet_Module_ready_to_use","watchers":43,"stargazers":43,"forks":41,"fork":false,"size":686,"owner":"theforeman","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2012-02-15T05:10:32-08:00","pushed_at":"2013-12-12T03:54:06-08:00","master_branch":"develop","organization":"theforeman"},"actor_attributes":{"type":"User","name":"Dominic Cleal","company":"Red Hat","blog":"http://m0dlx.com/","location":"UK","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/theforeman/foreman-installer/pull/80#discussion_r8330121"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments/3566633","id":3566633,"body":"No, but was more of a tidyup as I was in the same file. IMO services shouldn't have write access to their own config files, it should be root-only. It's the sort of thing we prevent in SELinux policies, restricting where services can write to in order to remove possible escalation vectors. Our modules do this for a few other services, and it's on my TODO list to fix those too...","diff_hunk":"@@ -5,13 +5,21 @@\n environment => \"RAILS_ENV=${foreman::environment}\",\n }\n \n- file {'/etc/foreman/settings.yaml':\n+ file { '/etc/foreman/settings.yaml':\n content => template('foreman/settings.yaml.erb'),\n notify => Class['foreman::service'],\n- owner => $foreman::user,\n+ owner => 'root',","path":"manifests/config.pp","position":9,"original_position":9,"commit_id":"49a7f01c99e33627fd2e9cfc3a6b2db278a4ae47","original_commit_id":"49a7f01c99e33627fd2e9cfc3a6b2db278a4ae47","user":{"login":"domcleal","id":482089,"avatar_url":"https://secure.gravatar.com/avatar/b610ed8556fcee2b7ab876c642a4ce42?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"b610ed8556fcee2b7ab876c642a4ce42","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User"},"created_at":"2013-03-28T09:28:44Z","updated_at":"2013-03-28T09:28:44Z","html_url":"https://github.com/theforeman/puppet-foreman/pull/51#discussion_r3566633","pull_request_url":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/comments/3566633"},"html":{"href":"https://github.com/theforeman/puppet-foreman/pull/51#discussion_r3566633"},"pull_request":{"href":"https://api.github.com/repos/theforeman/puppet-foreman/pulls/51"}}}} | {
"id": 3449583,
"name": "puppet-foreman",
"url": "https://github.com/theforeman/puppet-foreman"
} | {
"id": null,
"login": "domcleal",
"gravatar_id": "b610ed8556fcee2b7ab876c642a4ce42",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "theforeman",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-28T09:28:44 | null | {"repository":{"description":"Puppet module for Foreman","homepage":"","watchers":31,"stargazers":31,"forks":45,"fork":false,"size":268,"owner":"theforeman","private":false,"open_issues":6,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2012-02-15T05:19:01-08:00","pushed_at":"2013-03-26T15:44:29-07:00","master_branch":"master","organization":"theforeman"},"actor_attributes":{"type":"User","name":"Dominic Cleal","company":"Red Hat","blog":"http://m0dlx.com/","location":"UK","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/theforeman/puppet-foreman/pull/51#discussion_r3566633"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments/3332074","id":3332074,"body":"This should be 1800 by default, it's in seconds.","diff_hunk":"@@ -13,6 +13,9 @@\n $passenger = true\n $port = 8140\n $listen = false\n+ $pluginsync = true\n+ $splay = false\n+ $runinterval = '30'","path":"manifests/params.pp","position":6,"original_position":6,"commit_id":"16b8a9201b9d8ddbbbd430b53877022eeaf7acf0","original_commit_id":"16b8a9201b9d8ddbbbd430b53877022eeaf7acf0","user":{"login":"domcleal","id":482089,"avatar_url":"https://secure.gravatar.com/avatar/b610ed8556fcee2b7ab876c642a4ce42?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"b610ed8556fcee2b7ab876c642a4ce42","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User"},"created_at":"2013-03-12T09:47:16Z","updated_at":"2013-03-12T09:47:16Z","html_url":"https://github.com/theforeman/puppet-puppet/pull/46#discussion_r3332074","pull_request_url":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/46","_links":{"self":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/comments/3332074"},"html":{"href":"https://github.com/theforeman/puppet-puppet/pull/46#discussion_r3332074"},"pull_request":{"href":"https://api.github.com/repos/theforeman/puppet-puppet/pulls/46"}}}} | {
"id": 3449635,
"name": "puppet-puppet",
"url": "https://github.com/theforeman/puppet-puppet"
} | {
"id": null,
"login": "domcleal",
"gravatar_id": "b610ed8556fcee2b7ab876c642a4ce42",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "theforeman",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-03-12T09:47:16 | null | {"repository":{"description":"Puppet module for Puppet client and server","homepage":"","watchers":22,"stargazers":22,"forks":26,"fork":false,"size":216,"owner":"theforeman","private":false,"open_issues":5,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Puppet","created_at":"2012-02-15T05:23:34-08:00","pushed_at":"2013-03-03T00:26:09-08:00","master_branch":"master","organization":"theforeman"},"actor_attributes":{"type":"User","name":"Dominic Cleal","company":"Red Hat","blog":"http://m0dlx.com/","location":"UK","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/theforeman/puppet-puppet/pull/46#discussion_r3332074"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/7651761","id":7651761,"diff_hunk":"@@ -21,5 +25,25 @@ def http_auth_set?\n request.authorization.present? && request.authorization =~ /\\ABasic/\n end\n \n+ def signo_auth\n+ u, p = ActionController::HttpAuthentication::Basic.user_name_and_password(controller.request)\n+ uri = URI.parse(\"#{Setting['signo_url']}/login.json?username=#{URI.escape(u)}&password=#{URI.escape(p)}\")\n+ http = Net::HTTP.new(uri.host, uri.port)\n+ if uri.scheme == 'https'\n+ http.use_ssl = true\n+ http.verify_mode = OpenSSL::SSL::VERIFY_NONE","path":"app/services/sso/basic.rb","position":null,"original_position":27,"commit_id":"2164f95640dd7ca6a917aeec24ab16cbb3dac44e","original_commit_id":"8bbcb6f66616ad3c4e83bd571e160c85c5ab88dd","user":{"login":"ares","id":109773,"avatar_url":"https://0.gravatar.com/avatar/9304bd2a9e1b339269640a8091dd8a7b?d=https%3A%2F%2Fidenticons.github.com%2F01f34dfe5d0c4e5aa25d00beea480eab.png&r=x","gravatar_id":"9304bd2a9e1b339269640a8091dd8a7b","url":"https://api.github.com/users/ares","html_url":"https://github.com/ares","followers_url":"https://api.github.com/users/ares/followers","following_url":"https://api.github.com/users/ares/following{/other_user}","gists_url":"https://api.github.com/users/ares/gists{/gist_id}","starred_url":"https://api.github.com/users/ares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ares/subscriptions","organizations_url":"https://api.github.com/users/ares/orgs","repos_url":"https://api.github.com/users/ares/repos","events_url":"https://api.github.com/users/ares/events{/privacy}","received_events_url":"https://api.github.com/users/ares/received_events","type":"User","site_admin":false},"body":"http://goo.gl/2VaHrY","created_at":"2013-11-14T07:15:46Z","updated_at":"2013-11-14T07:15:46Z","html_url":"https://github.com/theforeman/foreman/pull/866#discussion_r7651761","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/866","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/7651761"},"html":{"href":"https://github.com/theforeman/foreman/pull/866#discussion_r7651761"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/866"}}}} | {
"id": 258750,
"name": "foreman",
"url": "https://github.com/theforeman/foreman"
} | {
"id": null,
"login": "ares",
"gravatar_id": "9304bd2a9e1b339269640a8091dd8a7b",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "theforeman",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-14T07:15:46 | null | {"repository":{"description":"an application that automates the lifecycle of servers ","homepage":"http://theforeman.org","watchers":323,"stargazers":323,"forks":205,"fork":false,"size":20552,"owner":"theforeman","private":false,"open_issues":36,"has_issues":false,"has_downloads":false,"has_wiki":false,"language":"Ruby","created_at":"2009-07-23T08:07:00-07:00","pushed_at":"2013-11-13T06:34:34-08:00","integrate_branch":"develop","master_branch":"develop","organization":"theforeman"},"actor_attributes":{"type":"User","name":"Marek Hulán","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/theforeman/foreman/pull/866#discussion_r7651761"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/thoughtbot/vimulator/pulls/comments/7555653","id":7555653,"diff_hunk":"@@ -178,12 +178,20 @@\n };\n \n Vimulator.Base.prototype.insertRowBelow = function (text, index) {\n+ var newLines, i;\n index = index || this.cursor.row;\n- this.lines.splice(index + 1, 0, text);\n+ newLines = text.split('\\n');\n+ for (i = newLines.length - 1; i >= 0; i -= 1) {\n+ this.lines.splice(index + 1, 0, newLines[i]);\n+ }\n };\n Vimulator.Base.prototype.insertRowAbove = function (text, index) {\n+ var newLines, i;\n index = index || this.cursor.row;\n- this.lines.splice(index, 0, text);\n+ newLines = text.split('\\n');\n+ for (i = newLines.length - 1; i >= 0; i -= 1) {\n+ this.lines.splice(index, 0, newLines[i]);\n+ }","path":"js/base.js","position":19,"original_position":19,"commit_id":"e265915a424d7c4633411274a13125b671a3e199","original_commit_id":"e265915a424d7c4633411274a13125b671a3e199","user":{"login":"georgebrock","id":35861,"avatar_url":"https://0.gravatar.com/avatar/46caf38e6cbc74005d6c643fd9186ef7?d=https%3A%2F%2Fidenticons.github.com%2F2bfe367f6f040df48462a1a9a684ea43.png&r=x","gravatar_id":"46caf38e6cbc74005d6c643fd9186ef7","url":"https://api.github.com/users/georgebrock","html_url":"https://github.com/georgebrock","followers_url":"https://api.github.com/users/georgebrock/followers","following_url":"https://api.github.com/users/georgebrock/following{/other_user}","gists_url":"https://api.github.com/users/georgebrock/gists{/gist_id}","starred_url":"https://api.github.com/users/georgebrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgebrock/subscriptions","organizations_url":"https://api.github.com/users/georgebrock/orgs","repos_url":"https://api.github.com/users/georgebrock/repos","events_url":"https://api.github.com/users/georgebrock/events{/privacy}","received_events_url":"https://api.github.com/users/georgebrock/received_events","type":"User","site_admin":false},"body":"Good call, thanks. I'll DRY this up.","created_at":"2013-11-11T10:19:16Z","updated_at":"2013-11-11T10:19:16Z","html_url":"https://github.com/thoughtbot/vimulator/pull/6#discussion_r7555653","pull_request_url":"https://api.github.com/repos/thoughtbot/vimulator/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/vimulator/pulls/comments/7555653"},"html":{"href":"https://github.com/thoughtbot/vimulator/pull/6#discussion_r7555653"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/vimulator/pulls/6"}}}} | {
"id": 7021368,
"name": "vimulator",
"url": "https://github.com/thoughtbot/vimulator"
} | {
"id": null,
"login": "georgebrock",
"gravatar_id": "46caf38e6cbc74005d6c643fd9186ef7",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "thoughtbot",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-11-11T10:19:16 | null | {"repository":{"description":"A JavaScript Vim simulator for demonstrations","watchers":73,"stargazers":73,"forks":5,"fork":false,"size":358,"owner":"thoughtbot","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-12-05T09:19:02-08:00","pushed_at":"2013-11-01T00:58:47-07:00","master_branch":"master","organization":"thoughtbot"},"actor_attributes":{"type":"User","name":"George Brocklehurst","company":"thoughtbot","blog":"http://georgebrock.com","location":"Stockholm","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/thoughtbot/vimulator/pull/6#discussion_r7555653"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/thoughtbot/clearance/pulls/comments/5126166","id":5126166,"body":"Okay; if this is a requirement because of the current API, it would probably be a bad idea to try and jam that change into this commit. Worth thinking about for the future, though.","diff_hunk":"@@ -57,8 +57,8 @@ def remember_token\n end\n \n def with_remember_token\n- if token = remember_token\n- yield token\n+ if remember_token","path":"lib/clearance/session.rb","position":40,"original_position":40,"commit_id":"a23074eddad135ae54ee2cf73b55c0b12ab59a09","original_commit_id":"a23074eddad135ae54ee2cf73b55c0b12ab59a09","user":{"login":"jferris","id":7591,"avatar_url":"https://secure.gravatar.com/avatar/7fd56fa98da45bc532e898132085bd05?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"7fd56fa98da45bc532e898132085bd05","url":"https://api.github.com/users/jferris","html_url":"https://github.com/jferris","followers_url":"https://api.github.com/users/jferris/followers","following_url":"https://api.github.com/users/jferris/following{/other_user}","gists_url":"https://api.github.com/users/jferris/gists{/gist_id}","starred_url":"https://api.github.com/users/jferris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jferris/subscriptions","organizations_url":"https://api.github.com/users/jferris/orgs","repos_url":"https://api.github.com/users/jferris/repos","events_url":"https://api.github.com/users/jferris/events{/privacy}","received_events_url":"https://api.github.com/users/jferris/received_events","type":"User"},"created_at":"2013-07-10T20:24:22Z","updated_at":"2013-07-10T20:24:22Z","html_url":"https://github.com/thoughtbot/clearance/pull/318#discussion_r5126166","pull_request_url":"https://api.github.com/repos/thoughtbot/clearance/pulls/318","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/clearance/pulls/comments/5126166"},"html":{"href":"https://github.com/thoughtbot/clearance/pull/318#discussion_r5126166"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/clearance/pulls/318"}}}} | {
"id": 56125,
"name": "clearance",
"url": "https://github.com/thoughtbot/clearance"
} | {
"id": null,
"login": "jferris",
"gravatar_id": "7fd56fa98da45bc532e898132085bd05",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "thoughtbot",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-10T20:24:22 | null | {"repository":{"description":"Rails authentication with email & password.","homepage":"http://thoughtbot.com/community/","watchers":1262,"stargazers":1262,"forks":164,"fork":false,"size":888,"owner":"thoughtbot","private":false,"open_issues":9,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2008-09-24T12:57:58-07:00","pushed_at":"2013-07-10T11:40:15-07:00","integrate_branch":"master","master_branch":"master","organization":"thoughtbot"},"actor_attributes":{"type":"User","name":"Joe Ferris","company":"thoughtbot, inc.","location":"Cambridge, MA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/thoughtbot/clearance/pull/318#discussion_r5126166"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/comments/6023589","id":6023589,"body":"Are others using Pow? I've gotten out of the habit of using it.","diff_hunk":"@@ -3,9 +3,33 @@\n # Set up Rails app. Run this script immediately after cloning the codebase.\n # https://github.com/thoughtbot/guides/tree/master/protocol\n \n+# Bundle the gems\n bundle install --binstubs=bin/stubs\n+\n+# Set up the database\n bundle exec rake db:setup\n \n+# Set up staging and production git remotes\n+# git remote add staging [email protected]:appname.git\n+# git remote add production [email protected]:appname.git\n+\n+# Copy any sample .env files to .env\n+if [ ! -f .env ]; then\n+ cp .sample.env .env\n+fi\n+\n+# Set up configurable environment variables\n if [ ! -f .env ]; then\n cp .sample.env .env\n fi\n+\n+# Install pow to run application locally\n+if [ ! -d ~/.pow ]; then\n+ curl get.pow.cx | sh\n+fi\n+\n+# Set up pow - visit \"http://appname.dev\" to view development environment\n+ln -s $(pwd) ~/.pow/$(basename $(pwd))","path":"templates/bin_setup","position":30,"original_position":30,"commit_id":"db0ec9727c9dc2b5403d85a4ece9b8dd820c0512","original_commit_id":"db0ec9727c9dc2b5403d85a4ece9b8dd820c0512","user":{"login":"croaky","id":198,"avatar_url":"https://0.gravatar.com/avatar/8e2b996de3842c6ef7e68a82fa5f01f5?d=https%3A%2F%2Fidenticons.github.com%2F0e65972dce68dad4d52d063967f0a705.png","gravatar_id":"8e2b996de3842c6ef7e68a82fa5f01f5","url":"https://api.github.com/users/croaky","html_url":"https://github.com/croaky","followers_url":"https://api.github.com/users/croaky/followers","following_url":"https://api.github.com/users/croaky/following{/other_user}","gists_url":"https://api.github.com/users/croaky/gists{/gist_id}","starred_url":"https://api.github.com/users/croaky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/croaky/subscriptions","organizations_url":"https://api.github.com/users/croaky/orgs","repos_url":"https://api.github.com/users/croaky/repos","events_url":"https://api.github.com/users/croaky/events{/privacy}","received_events_url":"https://api.github.com/users/croaky/received_events","type":"User"},"created_at":"2013-08-28T01:50:14Z","updated_at":"2013-08-28T01:50:14Z","html_url":"https://github.com/thoughtbot/suspenders/pull/221#discussion_r6023589","pull_request_url":"https://api.github.com/repos/thoughtbot/suspenders/pulls/221","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/comments/6023589"},"html":{"href":"https://github.com/thoughtbot/suspenders/pull/221#discussion_r6023589"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/suspenders/pulls/221"}}}} | {
"id": 666566,
"name": "suspenders",
"url": "https://github.com/thoughtbot/suspenders"
} | {
"id": null,
"login": "croaky",
"gravatar_id": "8e2b996de3842c6ef7e68a82fa5f01f5",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "thoughtbot",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-28T01:50:14 | null | {"repository":{"description":"A Rails 4 template with our standard defaults, ready to deploy to Heroku.","homepage":"","watchers":671,"stargazers":671,"forks":114,"fork":false,"size":870,"owner":"thoughtbot","private":false,"open_issues":13,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Ruby","created_at":"2010-05-14T07:34:46-07:00","pushed_at":"2013-08-26T15:56:49-07:00","master_branch":"master","organization":"thoughtbot"},"actor_attributes":{"type":"User","name":"Dan Croak","company":"thoughtbot","blog":"http://clarity.fm/croaky","location":"San Francisco","email":"[email protected]"},"url":"https://github.com/thoughtbot/suspenders/pull/221#discussion_r6023589"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/thoughtbot/shakespeare_analyzer/pulls/comments/6350827","id":6350827,"body":"Good job on getting tests working for this!\r\n\r\nNext challenge: make them run without hitting an external service. If ibiblio.org goes down, your test will fail. Also, these will run slower than they need to.\r\n\r\nI'd recommend downloading or creating a small xml fixture and including it in a spec/fixtures directory. Then have your program analyze that for testing.\r\n\r\nBy the way: making sure your program can swap out details like this (like whether it accepts a url OR a local file) will likely improve its design.","diff_hunk":"@@ -0,0 +1,37 @@\n+require \"spec_helper\"","path":"spec/shakespeare_analyzer_spec.rb","position":1,"original_position":1,"commit_id":"4225136b9be695de7ca10f9fac5b7b22c294a2c3","original_commit_id":"4225136b9be695de7ca10f9fac5b7b22c294a2c3","user":{"login":"r00k","id":46677,"avatar_url":"https://2.gravatar.com/avatar/ad4631ddac812d2492978b531cadb387?d=https%3A%2F%2Fidenticons.github.com%2Fe24a9dd946214b62855f5056c64b25c7.png","gravatar_id":"ad4631ddac812d2492978b531cadb387","url":"https://api.github.com/users/r00k","html_url":"https://github.com/r00k","followers_url":"https://api.github.com/users/r00k/followers","following_url":"https://api.github.com/users/r00k/following{/other_user}","gists_url":"https://api.github.com/users/r00k/gists{/gist_id}","starred_url":"https://api.github.com/users/r00k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r00k/subscriptions","organizations_url":"https://api.github.com/users/r00k/orgs","repos_url":"https://api.github.com/users/r00k/repos","events_url":"https://api.github.com/users/r00k/events{/privacy}","received_events_url":"https://api.github.com/users/r00k/received_events","type":"User"},"created_at":"2013-09-13T15:44:34Z","updated_at":"2013-09-13T15:44:34Z","html_url":"https://github.com/thoughtbot/shakespeare_analyzer/pull/2#discussion_r6350827","pull_request_url":"https://api.github.com/repos/thoughtbot/shakespeare_analyzer/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/shakespeare_analyzer/pulls/comments/6350827"},"html":{"href":"https://github.com/thoughtbot/shakespeare_analyzer/pull/2#discussion_r6350827"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/shakespeare_analyzer/pulls/2"}}}} | {
"id": 12737555,
"name": "shakespeare_analyzer",
"url": "https://github.com/thoughtbot/shakespeare_analyzer"
} | {
"id": null,
"login": "r00k",
"gravatar_id": "ad4631ddac812d2492978b531cadb387",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "thoughtbot",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-13T15:44:34 | null | {"repository":{"description":"An exercise for Prime subscribers.","watchers":2,"stargazers":2,"forks":11,"fork":false,"size":143,"owner":"thoughtbot","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"created_at":"2013-09-10T11:43:50-07:00","pushed_at":"2013-09-10T11:54:25-07:00","master_branch":"master","organization":"thoughtbot"},"actor_attributes":{"type":"User","name":"Ben Orenstein","blog":"www.codeulate.com","location":"Boston, MA","email":"[email protected]"},"url":"https://github.com/thoughtbot/shakespeare_analyzer/pull/2#discussion_r6350827"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/ui-alchemy/alchemy/pulls/comments/3939714","id":3939714,"body":"There is a grunt task that does this for you called [grunt-angular-templates](https://github.com/ericclemmons/grunt-angular-templates).","diff_hunk":"@@ -250,10 +256,10 @@ module.exports = function (grunt) {\n var content = escapeContent(grunt.file.read(file)),\n template = '';\n \n- template += 'angular.module(\"alch-templates\").run(function($templateCache) {\\n';\n+ template += 'angular.module(\"alch-templates\").run([\"$templateCache\", function($templateCache) {\\n';","path":"Gruntfile.js","position":47,"original_position":47,"commit_id":"151869d4600a9bc34c4f9f527151fcc5cf85f6cd","original_commit_id":"151869d4600a9bc34c4f9f527151fcc5cf85f6cd","user":{"login":"waldenraines","id":4116405,"avatar_url":"https://secure.gravatar.com/avatar/1bdf38c72d4260c67cf194adcd1c2648?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"1bdf38c72d4260c67cf194adcd1c2648","url":"https://api.github.com/users/waldenraines","html_url":"https://github.com/waldenraines","followers_url":"https://api.github.com/users/waldenraines/followers","following_url":"https://api.github.com/users/waldenraines/following","gists_url":"https://api.github.com/users/waldenraines/gists{/gist_id}","starred_url":"https://api.github.com/users/waldenraines/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waldenraines/subscriptions","organizations_url":"https://api.github.com/users/waldenraines/orgs","repos_url":"https://api.github.com/users/waldenraines/repos","events_url":"https://api.github.com/users/waldenraines/events{/privacy}","received_events_url":"https://api.github.com/users/waldenraines/received_events","type":"User"},"created_at":"2013-04-24T15:59:59Z","updated_at":"2013-04-24T15:59:59Z","html_url":"https://github.com/ui-alchemy/alchemy/pull/1#discussion_r3939714","pull_request_url":"https://api.github.com/repos/ui-alchemy/alchemy/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/ui-alchemy/alchemy/pulls/comments/3939714"},"html":{"href":"https://github.com/ui-alchemy/alchemy/pull/1#discussion_r3939714"},"pull_request":{"href":"https://api.github.com/repos/ui-alchemy/alchemy/pulls/1"}}}} | {
"id": 9108515,
"name": "alchemy",
"url": "https://github.com/ui-alchemy/alchemy"
} | {
"id": null,
"login": "waldenraines",
"gravatar_id": "1bdf38c72d4260c67cf194adcd1c2648",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "ui-alchemy",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-24T15:59:59 | null | {"repository":{"description":"","watchers":1,"stargazers":1,"forks":1,"fork":false,"size":3588,"owner":"ui-alchemy","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-03-29T16:25:51-07:00","pushed_at":"2013-04-16T08:36:36-07:00","master_branch":"master","organization":"ui-alchemy"},"actor_attributes":{"type":"User","name":"Walden Raines","company":"Red Hat","location":"Raleigh, NC","email":"[email protected]"},"url":"https://github.com/ui-alchemy/alchemy/pull/1#discussion_r3939714"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments/5757105","id":5757105,"body":"On first reading, I assumed \"period\" was a measurement of time. Maybe `CONN_DHANDLE_SWEEP_TRIGGER` would be a better name.","diff_hunk":"@@ -60,6 +60,11 @@ struct __wt_named_data_source {\n #define\tWT_NUM_INTERNAL_SESSIONS\t2\n \n /*\n+ * Periodically clear out unused dhandles from the connection list.\n+ */\n+#define\tCONN_DHANDLE_SWEEP_PERIOD\t10","path":"src/include/connection.h","position":6,"original_position":6,"commit_id":"ef8fbd6bf8ab1c52fe36438b1c8adef5a4b565d4","original_commit_id":"ef8fbd6bf8ab1c52fe36438b1c8adef5a4b565d4","user":{"login":"michaelcahill","id":1264383,"avatar_url":"https://secure.gravatar.com/avatar/a92a6f13a9e699d5b7097ad4743bca36?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"a92a6f13a9e699d5b7097ad4743bca36","url":"https://api.github.com/users/michaelcahill","html_url":"https://github.com/michaelcahill","followers_url":"https://api.github.com/users/michaelcahill/followers","following_url":"https://api.github.com/users/michaelcahill/following{/other_user}","gists_url":"https://api.github.com/users/michaelcahill/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelcahill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelcahill/subscriptions","organizations_url":"https://api.github.com/users/michaelcahill/orgs","repos_url":"https://api.github.com/users/michaelcahill/repos","events_url":"https://api.github.com/users/michaelcahill/events{/privacy}","received_events_url":"https://api.github.com/users/michaelcahill/received_events","type":"User"},"created_at":"2013-08-14T07:40:21Z","updated_at":"2013-08-14T07:40:21Z","html_url":"https://github.com/wiredtiger/wiredtiger/pull/620#discussion_r5757105","pull_request_url":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/620","_links":{"self":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/comments/5757105"},"html":{"href":"https://github.com/wiredtiger/wiredtiger/pull/620#discussion_r5757105"},"pull_request":{"href":"https://api.github.com/repos/wiredtiger/wiredtiger/pulls/620"}}}} | {
"id": 2944302,
"name": "wiredtiger",
"url": "https://github.com/wiredtiger/wiredtiger"
} | {
"id": null,
"login": "michaelcahill",
"gravatar_id": "a92a6f13a9e699d5b7097ad4743bca36",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "wiredtiger",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-14T07:40:21 | null | {"repository":{"description":"WiredTiger's source tree","homepage":"http://source.wiredtiger.com/","watchers":32,"stargazers":32,"forks":12,"fork":false,"size":55988,"owner":"wiredtiger","private":false,"open_issues":74,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C","created_at":"2011-12-08T16:43:19-08:00","pushed_at":"2013-08-13T19:02:31-07:00","master_branch":"master","organization":"wiredtiger"},"actor_attributes":{"type":"User","name":"Michael Cahill","company":"WiredTiger, Inc.","blog":"http://wiredtiger.com/","email":"[email protected]"},"url":"https://github.com/wiredtiger/wiredtiger/pull/620#discussion_r5757105"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/AutoFixture/AutoFixture/pulls/comments/5967721","id":5967721,"body":"Is *.csproj.VisualState.xml* a mandatory project/solution file?","diff_hunk":"@@ -0,0 +1,15 @@\n+<?xml version=\"1.0\" encoding=\"utf-8\"?>\r","path":"Src/AutoFixture.NUnit.org.UnitTest/AutoFixture.NUnit.UnitTest.csproj.VisualState.xml","position":1,"original_position":1,"commit_id":"4dfd373c8b8eccf1a0dea690cb3c62a2addaaf6b","original_commit_id":"4dfd373c8b8eccf1a0dea690cb3c62a2addaaf6b","user":{"login":"moodmosaic","id":287532,"avatar_url":"https://2.gravatar.com/avatar/eabf4956b887ad719b87c1507e69e22e?d=https%3A%2F%2Fidenticons.github.com%2F7761172ef21d5d7afd4760a83dfcd3cb.png","gravatar_id":"eabf4956b887ad719b87c1507e69e22e","url":"https://api.github.com/users/moodmosaic","html_url":"https://github.com/moodmosaic","followers_url":"https://api.github.com/users/moodmosaic/followers","following_url":"https://api.github.com/users/moodmosaic/following{/other_user}","gists_url":"https://api.github.com/users/moodmosaic/gists{/gist_id}","starred_url":"https://api.github.com/users/moodmosaic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moodmosaic/subscriptions","organizations_url":"https://api.github.com/users/moodmosaic/orgs","repos_url":"https://api.github.com/users/moodmosaic/repos","events_url":"https://api.github.com/users/moodmosaic/events{/privacy}","received_events_url":"https://api.github.com/users/moodmosaic/received_events","type":"User"},"created_at":"2013-08-25T06:42:39Z","updated_at":"2013-08-25T06:42:39Z","html_url":"https://github.com/AutoFixture/AutoFixture/pull/158#discussion_r5967721","pull_request_url":"https://api.github.com/repos/AutoFixture/AutoFixture/pulls/158","_links":{"self":{"href":"https://api.github.com/repos/AutoFixture/AutoFixture/pulls/comments/5967721"},"html":{"href":"https://github.com/AutoFixture/AutoFixture/pull/158#discussion_r5967721"},"pull_request":{"href":"https://api.github.com/repos/AutoFixture/AutoFixture/pulls/158"}}}} | {
"id": 4475900,
"name": "AutoFixture",
"url": "https://github.com/AutoFixture/AutoFixture"
} | {
"id": null,
"login": "moodmosaic",
"gravatar_id": "eabf4956b887ad719b87c1507e69e22e",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "AutoFixture",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-08-25T06:42:39 | null | {"repository":{"description":"AutoFixture is an open source framework for .NET designed to minimize the 'Arrange' phase of your unit tests. Its primary goal is to allow developers to focus on what is being tested rather than how to setup the test scenario, by making it easier to create object graphs containing test data.","homepage":"","watchers":180,"stargazers":180,"forks":42,"fork":false,"size":16346,"owner":"AutoFixture","private":false,"open_issues":20,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C#","created_at":"2012-05-28T17:00:02-07:00","pushed_at":"2013-08-18T10:45:35-07:00","master_branch":"master","organization":"AutoFixture"},"actor_attributes":{"type":"User","name":"Nikos Baxevanis","company":"moodmosaic","blog":"http://nikosbaxevanis.com/blog","location":"","email":"[email protected]"},"url":"https://github.com/AutoFixture/AutoFixture/pull/158#discussion_r5967721"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/MakingSense/Knockout-Validation/pulls/comments/5489840","id":5489840,"body":"Typo, should say: \"Custom class *has* been removed.\"","diff_hunk":"@@ -563,5 +563,32 @@ test(\"HTML5 Input types\", function () {\n });\n \n \n+test(\"Custom error class\", function () {\n+\n+ var vm = {\n+ testObj: ko.observable().extend({ max: { params: 100, customClass: \"customErrorClass\", message: \"Andres\" }})\n+ };\n+\n+ // setup the html\n+ addTestHtml('<input type=\"text\" id=\"testElement1\" data-bind=\"value: testObj\"/>');\n+\n+ // make sure we allow element decorations\n+ ko.validation.init({ decorateElement: true }, true);\n+\n+ applyTestBindings(vm);\n+\n+ var $el = $('#testElement1');\n+ ok(!$el.hasClass('customErrorClass'), 'Does not have the custom class yet');\n+ vm.testObj(200); // should not validate the max rule\n+ ok(!vm.testObj.isValid(), \"Object is not valid\");\n+ ok($el.hasClass('customErrorClass'), 'Have the custom class');\n+ vm.testObj(50);\n+ ok(vm.testObj.isValid(), \"Object is valid\");\n+ ok(!$el.hasClass('customErrorClass'), 'Custom class have been removed');","path":"Tests/validation-ui-tests.js","position":25,"original_position":25,"commit_id":"b24dca56e242c8f4948cfeefb98f28263d03703e","original_commit_id":"b24dca56e242c8f4948cfeefb98f28263d03703e","user":{"login":"AlphaGit","id":1113433,"avatar_url":"https://secure.gravatar.com/avatar/95c6daeb7837bb1eee0dc2d58d334cb3?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"95c6daeb7837bb1eee0dc2d58d334cb3","url":"https://api.github.com/users/AlphaGit","html_url":"https://github.com/AlphaGit","followers_url":"https://api.github.com/users/AlphaGit/followers","following_url":"https://api.github.com/users/AlphaGit/following{/other_user}","gists_url":"https://api.github.com/users/AlphaGit/gists{/gist_id}","starred_url":"https://api.github.com/users/AlphaGit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlphaGit/subscriptions","organizations_url":"https://api.github.com/users/AlphaGit/orgs","repos_url":"https://api.github.com/users/AlphaGit/repos","events_url":"https://api.github.com/users/AlphaGit/events{/privacy}","received_events_url":"https://api.github.com/users/AlphaGit/received_events","type":"User"},"created_at":"2013-07-30T21:41:34Z","updated_at":"2013-07-30T21:41:34Z","html_url":"https://github.com/MakingSense/Knockout-Validation/pull/1#discussion_r5489840","pull_request_url":"https://api.github.com/repos/MakingSense/Knockout-Validation/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/MakingSense/Knockout-Validation/pulls/comments/5489840"},"html":{"href":"https://github.com/MakingSense/Knockout-Validation/pull/1#discussion_r5489840"},"pull_request":{"href":"https://api.github.com/repos/MakingSense/Knockout-Validation/pulls/1"}}}} | {
"id": 11318262,
"name": "Knockout-Validation",
"url": "https://github.com/MakingSense/Knockout-Validation"
} | {
"id": null,
"login": "AlphaGit",
"gravatar_id": "95c6daeb7837bb1eee0dc2d58d334cb3",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "MakingSense",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-30T21:41:34 | null | {"repository":{"description":"A validation library for Knockout JS","homepage":"","watchers":0,"stargazers":0,"forks":1,"fork":true,"size":359,"owner":"MakingSense","private":false,"open_issues":1,"has_issues":false,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2013-07-10T10:05:46-07:00","pushed_at":"2013-06-26T12:39:36-07:00","master_branch":"master","organization":"MakingSense"},"actor_attributes":{"type":"User","name":"Alpha","blog":"http://blog.alphasmanifesto.com","location":"Austin, TX","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/MakingSense/Knockout-Validation/pull/1#discussion_r5489840"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/ProjectAres/Client/pulls/comments/3863413","id":3863413,"body":"Need ```this.``` notation","diff_hunk":"@@ -0,0 +1,191 @@\n+package tc.oc.projectares.client.config;\n+\n+import net.minecraft.src.ModLoader;\n+import java.io.File;\n+import java.io.FileInputStream;\n+import java.io.FileOutputStream;\n+import java.util.Properties;\n+import tc.oc.projectares.client.ProjectAres;\n+\n+public class ConfigAres {\n+ private static Properties defaults = new Properties();\n+ private String configPath;\n+ private Properties config;\n+ \n+ // update this value to change the config version.\n+ private static int version = 1;\n+\n+ // main variables\n+ public static int configVersion;\n+ public static boolean toggleSneakEnabled;\n+ public static String toggleSneakKey;\n+\n+ /**\n+ * Default values created when class is first referenced\n+ */\n+ static {\n+ // if the value is missing, it should force an update. Don't change it.\n+ defaults.setProperty(\"configVersion\", \"0\");\n+ defaults.setProperty(\"toggleSneakEnabled\", \"true\");\n+ defaults.setProperty(\"toggleSneakKey\", \"Z\");\n+ }\n+\n+ public ConfigAres() {\n+ ProjectAres.info(\"Attempting to load/create the configuration.\");\n+ loadConfig();\n+ loadConfigData();\n+ }\n+\n+ /**\n+ * Attempts to find a config\n+ * If there is one load it\n+ * If there is not one create one\n+ */\n+ private void loadConfig() {\n+ config = new Properties(defaults);\n+\n+ try {\n+ configPath = ModLoader.getMinecraftInstance().getMinecraftDir().getCanonicalPath() + File.separatorChar + \"config\" + File.separatorChar + \"OfficialProjectAres\" + File.separatorChar;\n+\n+ File cfg = new File(configPath + \"mod_Ares.cfg\");\n+\n+ if(cfg.exists()) {\n+ ProjectAres.info(\"Config file found, loading...\");\n+ config.load(new FileInputStream(configPath + \"mod_Ares.cfg\"));\n+ } else {\n+ ProjectAres.info(\"No config file found, creating...\");\n+ createConfig(cfg);","path":"src/main/java/tc/oc/projectares/client/config/ConfigAres.java","position":57,"original_position":57,"commit_id":"acc08612f993454d71192756839b017de9de8ec7","original_commit_id":"acc08612f993454d71192756839b017de9de8ec7","user":{"login":"mrapple","id":481658,"avatar_url":"https://secure.gravatar.com/avatar/e518e043c2e94b64dd06eaa14185d7e2?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"e518e043c2e94b64dd06eaa14185d7e2","url":"https://api.github.com/users/mrapple","html_url":"https://github.com/mrapple","followers_url":"https://api.github.com/users/mrapple/followers","following_url":"https://api.github.com/users/mrapple/following","gists_url":"https://api.github.com/users/mrapple/gists{/gist_id}","starred_url":"https://api.github.com/users/mrapple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrapple/subscriptions","organizations_url":"https://api.github.com/users/mrapple/orgs","repos_url":"https://api.github.com/users/mrapple/repos","events_url":"https://api.github.com/users/mrapple/events{/privacy}","received_events_url":"https://api.github.com/users/mrapple/received_events","type":"User"},"created_at":"2013-04-18T21:06:10Z","updated_at":"2013-04-18T21:06:10Z","html_url":"https://github.com/ProjectAres/Client/pull/8#discussion_r3863413","pull_request_url":"https://api.github.com/repos/ProjectAres/Client/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/ProjectAres/Client/pulls/comments/3863413"},"html":{"href":"https://github.com/ProjectAres/Client/pull/8#discussion_r3863413"},"pull_request":{"href":"https://api.github.com/repos/ProjectAres/Client/pulls/8"}}}} | {
"id": 7073286,
"name": "Client",
"url": "https://github.com/ProjectAres/Client"
} | {
"id": null,
"login": "mrapple",
"gravatar_id": "e518e043c2e94b64dd06eaa14185d7e2",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "ProjectAres",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-18T21:06:10 | null | {"repository":{"description":"Official Project Ares client mod that provides useful information and features to players","homepage":"","watchers":5,"stargazers":5,"forks":6,"fork":false,"size":308,"owner":"ProjectAres","private":false,"open_issues":3,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Java","created_at":"2012-12-08T15:11:33-08:00","pushed_at":"2013-03-28T12:07:34-07:00","master_branch":"master","organization":"ProjectAres"},"actor_attributes":{"type":"User","name":"MonsieurApple","company":"Project Ares","blog":"https://oc.tc","location":"Minnesota, USA","email":"[email protected]"},"url":"https://github.com/ProjectAres/Client/pull/8#discussion_r3863413"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/5270622","id":5270622,"body":"comma","diff_hunk":"@@ -364,7 +418,7 @@ class instance_halls_of_reflection : public InstanceMapScript\n {\n temp->CastSpell(temp, SPELL_SPIRIT_ACTIVATE, true);\n temp->RemoveFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_IMMUNE_TO_PC|UNIT_FLAG_IMMUNE_TO_NPC|UNIT_FLAG_NOT_SELECTABLE);\n- temp->AI()->DoZoneInCombat();\n+ temp->AI()->DoZoneInCombat(temp,100.00f);","path":"src/server/scripts/Northrend/FrozenHalls/HallsOfReflection/instance_halls_of_reflection.cpp","position":129,"original_position":129,"commit_id":"5e2324e640e6aedeff2ae4344087bbc1d79bb0b5","original_commit_id":"5e2324e640e6aedeff2ae4344087bbc1d79bb0b5","user":{"login":"Subv","id":357072,"avatar_url":"https://secure.gravatar.com/avatar/22425321ce534d18919abbe8d3349f09?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"22425321ce534d18919abbe8d3349f09","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User"},"created_at":"2013-07-18T15:27:22Z","updated_at":"2013-07-18T15:27:22Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/10303#discussion_r5270622","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/10303","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/5270622"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/10303#discussion_r5270622"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/10303"}}}} | {
"id": 1204412,
"name": "TrinityCore",
"url": "https://github.com/TrinityCore/TrinityCore"
} | {
"id": null,
"login": "Subv",
"gravatar_id": "22425321ce534d18919abbe8d3349f09",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "TrinityCore",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-07-18T15:27:22 | null | {"repository":{"description":"TrinityCore Open Source MMO Framework","homepage":"http://www.trinitycore.org","watchers":2169,"stargazers":2169,"forks":1864,"fork":false,"size":422624,"owner":"TrinityCore","private":false,"open_issues":1792,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2010-12-28T15:40:07-08:00","pushed_at":"2013-07-18T06:23:17-07:00","master_branch":"master","organization":"TrinityCore"},"actor_attributes":{"type":"User","email":"[email protected]"},"url":"https://github.com/TrinityCore/TrinityCore/pull/10303#discussion_r5270622"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/6780623","id":6780623,"diff_hunk":"@@ -0,0 +1,134 @@\n+/*\n+ * Copyright (C) 2008-2013 TrinityCore <http://www.trinitycore.org/>\n+ *\n+ * This program is free software; you can redistribute it and/or modify it\n+ * under the terms of the GNU General Public License as published by the\n+ * Free Software Foundation; either version 2 of the License, or (at your\n+ * option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful, but WITHOUT\n+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or\n+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for\n+ * more details.\n+ *\n+ * You should have received a copy of the GNU General Public License along\n+ * with this program. If not, see <http://www.gnu.org/licenses/>.\n+ */\n+ \n+#include \"ScriptMgr.h\"\n+#include \"ScriptedCreature.h\"\n+\n+enum Quests\n+{\n+ // 1 - wargen attack\n+ LOCKDOWN = 14078,\n+ SOMETHINGS_AMISS = 14091\n+ // 2 - forsaken invasion\n+\n+ // 3 - cataclism\n+};\n+\n+enum Says\n+{\n+ // 1 - wargen attack\n+\n+ // 2 - forsaken invasion\n+\n+ // 3 - cataclism\n+};\n+\n+enum Spells\n+{\n+ // 1 - wargen attack \n+ SPELL_PHASE_2 = 59073 // good spell ?\n+ // 2 - forsaken invasion\n+\n+ // 3 - cataclism\n+};\n+\n+enum Events\n+{\n+ // 1 - wargen attack\n+ EVENT_NPC_PRINCE_LIAM_GREYMANE_1_SAY = 1\n+ // 2 - forsaken invasion\n+\n+ // 3 - cataclism\n+};\n+\n+// 1 - wargen attack\n+/************************************ Phase 1 ************************************/\n+class npc_prince_liam_greymane_1 : public CreatureScript\n+{\n+public:\n+ npc_prince_liam_greymane_1() : CreatureScript(\"npc_prince_liam_greymane_1\") {}\n+\n+ CreatureAI* GetAI(Creature* creature) const OVERRIDE\n+ {\n+ return new npc_prince_liam_greymane_1AI (creature);\n+ }\n+\n+ struct npc_prince_liam_greymane_1AI : public ScriptedAI\n+ {\n+ bool cantalk;\n+ int prince_liam_say;\n+\n+ npc_prince_liam_greymane_1AI(Creature* creature) : ScriptedAI(creature) {}\n+\n+ void Reset() OVERRIDE\n+ {\n+ cantalk = true;\n+ prince_liam_say = 0;\n+ events.ScheduleEvent(EVENT_NPC_PRINCE_LIAM_GREYMANE_1_SAY, 30000);\n+ }\n+\n+ void UpdateAI(uint32 diff) OVERRIDE\n+ {\n+ events.Update(diff);\n+\n+ while (uint32 eventId = events.ExecuteEvent()) \n+ {\n+ switch (eventId)\n+ {\n+ case EVENT_NPC_PRINCE_LIAM_GREYMANE_1_SAY:\n+ events.ScheduleEvent(EVENT_NPC_PRINCE_LIAM_GREYMANE_1_SAY, 30000);\n+ if (prince_liam_say > 2) prince_liam_say = 0;\n+ Talk(prince_liam_say);\n+ ++prince_liam_say;\n+ break;\n+ default:\n+ break;\n+ }\n+ } \n+ }\n+\n+ private:\n+ EventMap events;\n+ };\n+};\n+\n+class npc_lieutenant_walden : public CreatureScript\n+{\n+public:\n+ npc_lieutenant_walden() : CreatureScript(\"npc_lieutenant_walden\") {}\n+\n+ bool OnQuestReward(Player* player, Creature* creature, Quest const* quest, uint32 opt) OVERRIDE\n+ {\n+ if (quest->GetQuestId() == LOCKDOWN)\n+ {\n+\t\t\t//creature->CastSpell((Unit*)player, SPELL_PHASE_2, true); // wrong spell or spell not working correctly\n+ creature->AddAura(SPELL_PHASE_2, (Unit*)player); ","path":"src/server/scripts/EasternKingdoms/zone_gilneas.cpp","position":119,"original_position":119,"commit_id":"cfe40c1ca80478746c9d1cc6598a5ca27cf3f400","original_commit_id":"51a846165ac19c7b4bcc7b4e59297472da4e6729","user":{"login":"ukulutl","id":1016606,"avatar_url":"https://1.gravatar.com/avatar/b7b0b2f97c9bd62cb73ffd624c748b27?d=https%3A%2F%2Fidenticons.github.com%2F27c02b60f6858c636f78a7680abf0901.png","gravatar_id":"b7b0b2f97c9bd62cb73ffd624c748b27","url":"https://api.github.com/users/ukulutl","html_url":"https://github.com/ukulutl","followers_url":"https://api.github.com/users/ukulutl/followers","following_url":"https://api.github.com/users/ukulutl/following{/other_user}","gists_url":"https://api.github.com/users/ukulutl/gists{/gist_id}","starred_url":"https://api.github.com/users/ukulutl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ukulutl/subscriptions","organizations_url":"https://api.github.com/users/ukulutl/orgs","repos_url":"https://api.github.com/users/ukulutl/repos","events_url":"https://api.github.com/users/ukulutl/events{/privacy}","received_events_url":"https://api.github.com/users/ukulutl/received_events","type":"User"},"body":"INSERT INTO `spell_area` (`spell`, `area`, `quest_start`, `quest_end`, `aura_spell`, `racemask`, `gender`, `autocast`, `quest_start_status`, `quest_end_status`) VALUES ('59073', '4756', '14078', '14159', '0', '0', '2', '1', '64', '64');\r\nAs I said maybe wrong spell not sure but it simply disapear using what I use ","created_at":"2013-10-04T22:25:08Z","updated_at":"2013-10-04T22:25:08Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/11000#discussion_r6780623","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/11000","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/6780623"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/11000#discussion_r6780623"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/11000"}}}} | {
"id": 1204412,
"name": "TrinityCore",
"url": "https://github.com/TrinityCore/TrinityCore"
} | {
"id": null,
"login": "ukulutl",
"gravatar_id": "b7b0b2f97c9bd62cb73ffd624c748b27",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "TrinityCore",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-10-04T22:25:08 | null | {"repository":{"description":"TrinityCore Open Source MMO Framework","homepage":"http://www.trinitycore.org","watchers":2253,"stargazers":2253,"forks":2038,"fork":false,"size":446135,"owner":"TrinityCore","private":false,"open_issues":1829,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"C++","created_at":"2010-12-28T15:40:07-08:00","pushed_at":"2013-10-04T12:18:46-07:00","master_branch":"master","organization":"TrinityCore"},"actor_attributes":{"type":"User","location":"Catalunya","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/TrinityCore/TrinityCore/pull/11000#discussion_r6780623"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/Yarl-IT-Hub/ySchool/pulls/comments/6629089","id":6629089,"body":" Displaying \"Staff_Id\" make no sence for endusers,(teachers, or school level it operators)\r\nwhat about saying \"Staff ID/No:\"","diff_hunk":"@@ -33,9 +37,63 @@\n </div>\n \n <div class=\"span10\">\n- test add new Staff.\n- Add new staffs form here.\n- </div>\n+ Add New Staff Here....\n+\t\t \n+\t<h:form class=\"form-horizontal\" enctype=\"multipart/form-data\">\n+ <div class=\"tab-content\">\n+\t\t\t\t\n+\t\t\t\t <fieldset>\n+\t\t\t\t <div class=\"control-group\">\n+ <label class=\"control-label\" for=\"Staff_Id\">Staff_Id</label>\n+\n+ <div class=\"controls\">\n+ <h:inputText id=\"Staff_Id\" value=\"\" required=\"true\"","path":"yschool/src/main/webapp/faces/staff/staffNew.xhtml","position":29,"original_position":29,"commit_id":"88253d167fda54abdd11070155622bdfe4a2a934","original_commit_id":"88253d167fda54abdd11070155622bdfe4a2a934","user":{"login":"Jay-Krish","id":1880266,"avatar_url":"https://2.gravatar.com/avatar/68c48f74a71c1e165e0f2f9bc0e9cb02?d=https%3A%2F%2Fidenticons.github.com%2Fa913f9b9c210a1588180c307e150e2e0.png","gravatar_id":"68c48f74a71c1e165e0f2f9bc0e9cb02","url":"https://api.github.com/users/Jay-Krish","html_url":"https://github.com/Jay-Krish","followers_url":"https://api.github.com/users/Jay-Krish/followers","following_url":"https://api.github.com/users/Jay-Krish/following{/other_user}","gists_url":"https://api.github.com/users/Jay-Krish/gists{/gist_id}","starred_url":"https://api.github.com/users/Jay-Krish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jay-Krish/subscriptions","organizations_url":"https://api.github.com/users/Jay-Krish/orgs","repos_url":"https://api.github.com/users/Jay-Krish/repos","events_url":"https://api.github.com/users/Jay-Krish/events{/privacy}","received_events_url":"https://api.github.com/users/Jay-Krish/received_events","type":"User"},"created_at":"2013-09-27T14:32:23Z","updated_at":"2013-09-27T14:32:23Z","html_url":"https://github.com/Yarl-IT-Hub/ySchool/pull/19#discussion_r6629089","pull_request_url":"https://api.github.com/repos/Yarl-IT-Hub/ySchool/pulls/19","_links":{"self":{"href":"https://api.github.com/repos/Yarl-IT-Hub/ySchool/pulls/comments/6629089"},"html":{"href":"https://github.com/Yarl-IT-Hub/ySchool/pull/19#discussion_r6629089"},"pull_request":{"href":"https://api.github.com/repos/Yarl-IT-Hub/ySchool/pulls/19"}}}} | {
"id": 3087569,
"name": "ySchool",
"url": "https://github.com/Yarl-IT-Hub/ySchool"
} | {
"id": null,
"login": "Jay-Krish",
"gravatar_id": "68c48f74a71c1e165e0f2f9bc0e9cb02",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "Yarl-IT-Hub",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-27T14:32:23 | null | {"repository":{"description":"","homepage":"","watchers":18,"stargazers":18,"forks":23,"fork":false,"size":22152,"owner":"Yarl-IT-Hub","private":false,"open_issues":0,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"JavaScript","created_at":"2012-01-02T05:12:54-08:00","pushed_at":"2013-09-27T07:19:36-07:00","master_branch":"master","organization":"Yarl-IT-Hub"},"actor_attributes":{"type":"User","name":"JayaKrishnan","email":"[email protected]"},"url":"https://github.com/Yarl-IT-Hub/ySchool/pull/19#discussion_r6629089"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/biom-format/biom-format/pulls/comments/3845663","id":3845663,"body":"```otuTable``` -> ```biom```","diff_hunk":"@@ -0,0 +1,97 @@\n+################################################################################\n+# Validity methods:\n+#\n+# These are delicate, because they are effectively at the S4 infrastructure\n+# level, in between \"new\" and the constructor. Some of the issues that might\n+# otherwise go here can be also be dealt with in the constructors, if needed.\n+################################################################################\n+validbiom = function(object){\n+\t\n+\t# All the required top-level keys are present\n+\tbiomreqdkeys = c(\"id\", \"format\", \"format_url\", \"type\", \"generated_by\", \"date\",\n+\t\t\t\t\t\t\t\t\t \"rows\", \"columns\", \"matrix_type\", \"matrix_element_type\", \"shape\", \"data\")\n+\tif( !all(biomreqdkeys %in% names(object)) ){\n+\t\tmissingkeysmessage = paste(\"\", \n+\t\t\t\t\t\"Not all required top-level keys are present in biom-object.\",\n+\t\t\t\t\t\"Required keys are:\", paste0(biomreqdkeys, collapse=\"\\n\"),\n+\t\t\t\t\tsep=\"\\n\")\n+\t\treturn(missingkeysmessage)\n+\t}\n+\t\n+\t# Matrix shape and number of row/col elements matches\n+\tbshape = biomshape(object)\n+\tif( bshape[\"ncol\"] > length(object$columns) ){\n+\t\treturn(\"shape specifies more cols than are present in metadata\")\n+\t}\n+\tif( bshape[\"nrow\"] > length(object$rows) ){\n+\t\treturn(\"shape field specifies more rows than are present in metadata\")\n+\t}\n+\tif( bshape[\"ncol\"] < length(object$columns) ){\n+\t\treturn(\"more metadata cols than specified by shape field\")\n+\t}\n+\tif( bshape[\"nrow\"] < length(object$rows) ){\n+\t\treturn(\"more metadata rows than specified by shape field\")\n+\t}\t\n+\t\n+\t# The type field has an acceptable value\n+\tbiomtypevals = c(\"OTU table\",\n+\t\t\"Pathway table\",\n+\t\t\"Function table\",\n+\t\t\"Ortholog table\",\n+\t\t\"Gene table\",\n+\t\t\"Metabolite table\",\n+\t\t\"Taxon table\"\n+\t)\n+\tif( !object$type %in% biomtypevals ){\n+\t\treturn(\"type field has unsupported value\")\n+\t}\n+\t\n+\t# The matrix_type has an acceptable value\n+\tbiommatrixtypes = c(\"sparse\", \"dense\")\n+\tif( !object$matrix_type %in% biommatrixtypes ){\n+\t\treturn(\"matrix_type field has unsupported value\")\n+\t}\n+\t\n+\t# The matrix_element_type has an acceptable value\n+\tbiommatrixelemtypes = c(\"int\", \"float\", \"unicode\")\n+\tif( !object$matrix_element_type %in% biommatrixelemtypes ){\n+\t\treturn(\"matrix_element_type field has unsupported value\")\n+\t}\t\n+\t\n+\t# If sparse, all data fields should have length of 3 (row, col, val)\n+\tif( identical(object$matrix_type, \"sparse\") ){\n+\t\tif( !all(sapply(object$data, length)==3) ){\n+\t\t\treturn(\"Some data fields for this sparse biom format do not have 3 elements\")\n+\t\t}\n+\t}\n+\t# If dense, data fields should have length equal to\n+\tif( identical(object$matrix_type, \"dense\") ){\n+\t\tif( !all(sapply(object$data, length)==bshape[\"ncol\"]) ){\n+\t\t\treturn(paste(\"Some data fields for this dense biom format\", \n+\t\t\t\t\t\t\t\t\t \"do not have the expected number columns:\", bshape[\"ncol\"], sep=\" \"))\n+\t\t}\n+\t}\t\n+\t\n+\t# metadata ids -- rownames and colnames -- must be unique\n+\trow_names = sapply(object$rows, function(i) i$id)\n+\tdupr = duplicated(row_names)\n+\tcol_names = sapply(object$columns, function(i) i$id)\n+\tdupc = duplicated(col_names)\n+\tif( any(dupr) ){\n+\t\treturn(paste(\"The following row ids were duplicated: \\n\",\n+\t\t\t\t\tpaste0(row_names[dupr], collapse=\"\\n\"), sep=\"\"))\n+\t}\n+\tif( any(dupc) ){\n+\t\treturn(paste(\"The following col ids were duplicated: \\n\",\n+\t\t\t\t\t\t\t\t paste0(col_names[dupc], collapse=\"\\n\"), sep=\"\"))\n+\t}\t\n+\t\n+\t# If we get all the way here without returning a string,\n+\t# then consider it a valid object.\n+\t# In which case should return TRUE.\n+\treturn(TRUE)\n+}\n+################################################################################\n+## assign the function as the validity method for the otuTable class","path":"R-code/rbiom/R/validity-methods.R","position":95,"original_position":95,"commit_id":"888c7e810a3093f1efd64ce1827b7d3e0edbaf82","original_commit_id":"888c7e810a3093f1efd64ce1827b7d3e0edbaf82","user":{"login":"jrrideout","id":1847232,"avatar_url":"https://secure.gravatar.com/avatar/9e0f900bf3227c537736e8d56121fa89?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"9e0f900bf3227c537736e8d56121fa89","url":"https://api.github.com/users/jrrideout","html_url":"https://github.com/jrrideout","followers_url":"https://api.github.com/users/jrrideout/followers","following_url":"https://api.github.com/users/jrrideout/following","gists_url":"https://api.github.com/users/jrrideout/gists{/gist_id}","starred_url":"https://api.github.com/users/jrrideout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrrideout/subscriptions","organizations_url":"https://api.github.com/users/jrrideout/orgs","repos_url":"https://api.github.com/users/jrrideout/repos","events_url":"https://api.github.com/users/jrrideout/events{/privacy}","received_events_url":"https://api.github.com/users/jrrideout/received_events","type":"User"},"created_at":"2013-04-18T01:38:05Z","updated_at":"2013-04-18T01:38:05Z","html_url":"https://github.com/biom-format/biom-format/pull/27#discussion_r3845663","pull_request_url":"https://api.github.com/repos/biom-format/biom-format/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/biom-format/biom-format/pulls/comments/3845663"},"html":{"href":"https://github.com/biom-format/biom-format/pull/27#discussion_r3845663"},"pull_request":{"href":"https://api.github.com/repos/biom-format/biom-format/pulls/27"}}}} | {
"id": 3999367,
"name": "biom-format",
"url": "https://github.com/biom-format/biom-format"
} | {
"id": null,
"login": "jrrideout",
"gravatar_id": "9e0f900bf3227c537736e8d56121fa89",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "biom-format",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-04-18T01:38:05 | null | {"repository":{"description":"The Biological Observation Matrix (BIOM) Format Project","homepage":"http://biom-format.org","watchers":12,"stargazers":12,"forks":9,"fork":false,"size":483,"owner":"biom-format","private":false,"open_issues":4,"has_issues":true,"has_downloads":true,"has_wiki":false,"language":"Python","created_at":"2012-04-11T16:10:28-07:00","pushed_at":"2013-04-15T18:09:56-07:00","master_branch":"master","organization":"biom-format"},"actor_attributes":{"type":"User","name":"Jai Ram Rideout","company":"Microbial Genetics and Genomics Center","location":"Flagstaff, AZ","email":"[email protected]"},"url":"https://github.com/biom-format/biom-format/pull/27#discussion_r3845663"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/forcedotcom/phoenix/pulls/comments/4763447","id":4763447,"body":"It'd be nice to have a builder here","diff_hunk":"@@ -290,8 +293,8 @@ protected PTable addDynamicColumns(List<ColumnDef> dynColumns, PTable theTable)\n addDef.getScale(), addDef.isNull(), position, addDef.getColumnModifier()));\n position++;\n }\n- theTable = new PTableImpl(theTable.getName(), theTable.getType(), theTable.getTimeStamp(),\n- theTable.getSequenceNumber(), theTable.getPKName(), theTable.getBucketNum(), allcolumns);\n+ theTable = PTableImpl.makePTable(theTable.getName(), theTable.getType(), theTable.getTimeStamp(),","path":"src/main/java/com/salesforce/phoenix/compile/FromCompiler.java","position":34,"original_position":34,"commit_id":"94e2855d0a1c4ea3761d407bc173de0c8393a0a3","original_commit_id":"94e2855d0a1c4ea3761d407bc173de0c8393a0a3","user":{"login":"jtaylor-sfdc","id":3300897,"avatar_url":"https://secure.gravatar.com/avatar/f5d13f349653ca33e4d8d5fcc38b2c86?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"f5d13f349653ca33e4d8d5fcc38b2c86","url":"https://api.github.com/users/jtaylor-sfdc","html_url":"https://github.com/jtaylor-sfdc","followers_url":"https://api.github.com/users/jtaylor-sfdc/followers","following_url":"https://api.github.com/users/jtaylor-sfdc/following{/other_user}","gists_url":"https://api.github.com/users/jtaylor-sfdc/gists{/gist_id}","starred_url":"https://api.github.com/users/jtaylor-sfdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtaylor-sfdc/subscriptions","organizations_url":"https://api.github.com/users/jtaylor-sfdc/orgs","repos_url":"https://api.github.com/users/jtaylor-sfdc/repos","events_url":"https://api.github.com/users/jtaylor-sfdc/events{/privacy}","received_events_url":"https://api.github.com/users/jtaylor-sfdc/received_events","type":"User"},"created_at":"2013-06-19T00:27:28Z","updated_at":"2013-06-19T00:27:28Z","html_url":"https://github.com/forcedotcom/phoenix/pull/272#discussion_r4763447","pull_request_url":"https://api.github.com/repos/forcedotcom/phoenix/pulls/272","_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/phoenix/pulls/comments/4763447"},"html":{"href":"https://github.com/forcedotcom/phoenix/pull/272#discussion_r4763447"},"pull_request":{"href":"https://api.github.com/repos/forcedotcom/phoenix/pulls/272"}}}} | {
"id": 7676364,
"name": "phoenix",
"url": "https://github.com/forcedotcom/phoenix"
} | {
"id": null,
"login": "jtaylor-sfdc",
"gravatar_id": "f5d13f349653ca33e4d8d5fcc38b2c86",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "forcedotcom",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-19T00:27:28 | null | {"repository":{"description":"","watchers":275,"stargazers":275,"forks":91,"fork":false,"size":1648,"owner":"forcedotcom","private":false,"open_issues":51,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2013-01-17T15:11:59-08:00","pushed_at":"2013-06-17T14:26:22-07:00","master_branch":"master","organization":"forcedotcom"},"actor_attributes":{"type":"User","name":"James Taylor","company":"Salesforce.com","email":"[email protected]"},"url":"https://github.com/forcedotcom/phoenix/pull/272#discussion_r4763447"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/kijiproject/kiji-common-flags/pulls/comments/3178849","id":3178849,"body":"we should name this parsesSubclasses (no capital C) to be consistent with Java (i.e. Class.asSubclass).","diff_hunk":"@@ -0,0 +1,44 @@\n+/**\n+ * Licensed to WibiData, Inc. under one or more contributor license\n+ * agreements. See the NOTICE file distributed with this work for\n+ * additional information regarding copyright ownership. WibiData, Inc.\n+ * licenses this file to you under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance\n+ * with the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or\n+ * implied. See the License for the specific language governing\n+ * permissions and limitations under the License.\n+ */\n+\n+package org.kiji.common.flags;\n+\n+/**\n+ * Base interface of a parser for flag values.\n+ *\n+ * All flag value parsers must implement this interface.\n+ *\n+ * @param <T> Type of the parsed value.\n+ */\n+public interface ValueParser<T> {\n+\n+ /** @return the class of the value being parsed. */\n+ Class<? extends T> getParsedClass();\n+\n+ /** @return whether this parser also parses subclasses */\n+ boolean parsesSubClasses();","path":"src/main/java/org/kiji/common/flags/ValueParser.java","position":33,"original_position":33,"commit_id":"4b7a407d5a321ddd7084b2891c69ef60fe4ae554","original_commit_id":"4b7a407d5a321ddd7084b2891c69ef60fe4ae554","user":{"login":"gwu","id":469312,"avatar_url":"https://secure.gravatar.com/avatar/ff6c9a8fa5884cf6578bb5c53b9f6874?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"ff6c9a8fa5884cf6578bb5c53b9f6874","url":"https://api.github.com/users/gwu","html_url":"https://github.com/gwu","followers_url":"https://api.github.com/users/gwu/followers","following_url":"https://api.github.com/users/gwu/following","gists_url":"https://api.github.com/users/gwu/gists{/gist_id}","starred_url":"https://api.github.com/users/gwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwu/subscriptions","organizations_url":"https://api.github.com/users/gwu/orgs","repos_url":"https://api.github.com/users/gwu/repos","events_url":"https://api.github.com/users/gwu/events{/privacy}","received_events_url":"https://api.github.com/users/gwu/received_events","type":"User"},"created_at":"2013-02-27T21:24:26Z","updated_at":"2013-02-27T21:24:26Z","_links":{"self":{"href":"https://api.github.com/repos/kijiproject/kiji-common-flags/pulls/comments/3178849"},"html":{"href":"https://github.com/kijiproject/kiji-common-flags/pull/2#discussion_r3178849"},"pull_request":{"href":"https://api.github.com/repos/kijiproject/kiji-common-flags/pulls/2"}}}} | {
"id": 7122611,
"name": "kiji-common-flags",
"url": "https://github.com/kijiproject/kiji-common-flags"
} | {
"id": null,
"login": "gwu",
"gravatar_id": "ff6c9a8fa5884cf6578bb5c53b9f6874",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "kijiproject",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-02-27T21:24:26 | null | {"repository":{"description":"A Java command-line flag parsing library ","watchers":0,"stargazers":0,"forks":1,"fork":false,"size":184,"owner":"kijiproject","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Java","created_at":"2012-12-11T17:37:21-08:00","pushed_at":"2012-12-11T17:38:57-08:00","master_branch":"master","organization":"kijiproject"},"actor_attributes":{"type":"User","name":"Garrett Wu","location":"San Francisco, CA","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/kijiproject/kiji-common-flags/pull/2#discussion_r3178849"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/kotisdesign/file-uploader/pulls/comments/6530358","id":6530358,"body":"<3 the ```expect``` syntax.","diff_hunk":"@@ -1,47 +1,28 @@\n require 'spec_helper'\n \n describe User do\n-\n+ \n let(:user) { FactoryGirl.create(:user) }\n \n- describe \"when applying basic validations\" do\n- it \"should let a valid user through\" do\n- expect(user).to be_valid\n- end\n-\n- xit \"should not validate a user with a bad password\" do\n- user.password = \"foo\"\n- user.password_confirmation = \"bar\"\n-\n- expect(user).not_to be_valid\n- end\n-\n- describe \"and validating a user's email address\" do\n- it \"should allow valid .uk emails\" do\n- user.email = \"[email protected]\"\n-\n- expect(user).to be_valid\n- end\n-\n- it \"should NOT allow users with invalid email\" do\n- user.email = \"foo\"\n+ it \"should have a valid factory\" do\n+ expect(user).to be_valid","path":"spec/models/user_spec.rb","position":30,"original_position":30,"commit_id":"52677476616309880c6a3133b416c2517877ad80","original_commit_id":"52677476616309880c6a3133b416c2517877ad80","user":{"login":"kerrizor","id":257689,"avatar_url":"https://0.gravatar.com/avatar/f4d5752d6f4f839083cf810ad2c3a911?d=https%3A%2F%2Fidenticons.github.com%2F33a5d50309286dbaebfd5dbb96b3f6d0.png","gravatar_id":"f4d5752d6f4f839083cf810ad2c3a911","url":"https://api.github.com/users/kerrizor","html_url":"https://github.com/kerrizor","followers_url":"https://api.github.com/users/kerrizor/followers","following_url":"https://api.github.com/users/kerrizor/following{/other_user}","gists_url":"https://api.github.com/users/kerrizor/gists{/gist_id}","starred_url":"https://api.github.com/users/kerrizor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kerrizor/subscriptions","organizations_url":"https://api.github.com/users/kerrizor/orgs","repos_url":"https://api.github.com/users/kerrizor/repos","events_url":"https://api.github.com/users/kerrizor/events{/privacy}","received_events_url":"https://api.github.com/users/kerrizor/received_events","type":"User"},"created_at":"2013-09-23T22:34:34Z","updated_at":"2013-09-23T22:34:34Z","html_url":"https://github.com/kotisdesign/file-uploader/pull/2#discussion_r6530358","pull_request_url":"https://api.github.com/repos/kotisdesign/file-uploader/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/kotisdesign/file-uploader/pulls/comments/6530358"},"html":{"href":"https://github.com/kotisdesign/file-uploader/pull/2#discussion_r6530358"},"pull_request":{"href":"https://api.github.com/repos/kotisdesign/file-uploader/pulls/2"}}}} | {
"id": 12709377,
"name": "file-uploader",
"url": "https://github.com/kotisdesign/file-uploader"
} | {
"id": null,
"login": "kerrizor",
"gravatar_id": "f4d5752d6f4f839083cf810ad2c3a911",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "kotisdesign",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-23T22:34:34 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":556,"owner":"kotisdesign","private":false,"open_issues":2,"has_issues":true,"has_downloads":true,"has_wiki":true,"language":"Ruby","created_at":"2013-09-09T11:36:04-07:00","pushed_at":"2013-09-23T14:37:11-07:00","master_branch":"master","organization":"kotisdesign"},"actor_attributes":{"type":"User","name":"Kerri Miller","company":"Blue Box Group","blog":"http://kerrizor.com","location":"Seattle, WA","email":"[email protected]"},"url":"https://github.com/kotisdesign/file-uploader/pull/2#discussion_r6530358"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/makingwaves/ezforgotpassword/pulls/comments/4913280","id":4913280,"body":"You are in effect caching the object in itself, instead of creating a new object each time you need it. The problem with this is that you can't have multiple objects with different user emails by this method. And that it really isn't necessary to do it this way, you're just making the code more complex.","diff_hunk":"@@ -0,0 +1,88 @@\n+<?php\n+\n+/**\n+ * Class handles the password operations basing on user email.\n+ */\n+class eZForgotPasswordGenerator\n+{\n+ private static $user;\n+ private static $obj = null;\n+\n+ /**\n+ * Blocked constructor - only for internal use\n+ */\n+ private function __construct() {}\n+\n+ /**\n+ * Method generates the hash value\n+ * @return type\n+ */\n+ private function generateHash()\n+ {\n+ $ini = eZINI::instance( 'ezforgotpassword.ini' );\n+ return hash_hmac( 'md5', self::$user->attribute( 'email' ) . microtime(), $ini->variable( 'MainSettings', 'Md5Key' ) );\n+ }\n+\n+ /**\n+ * Sets the user_email for an object and returns the object\n+ * @param string $user_email\n+ * @return eZForgotPasswordGenerator\n+ */\n+ public static function getInstanceByEmail( $user_email )\n+ {\n+ if ( is_null( self::$obj ) )\n+ {\n+ self::$obj = new self();\n+ self::$user = eZUser::fetchByEmail( $user_email );\n+\n+ if ( filter_var( $user_email, FILTER_VALIDATE_EMAIL ) === false || is_null( self::$user ) )\n+ {\n+ throw new Exception( 'Incorrect email address.' );\n+ }\n+ }\n+\n+ return self::$obj;","path":"classes/eZForgotPasswordGenerator.php","position":44,"original_position":44,"commit_id":"dca29e9939905d88c3c4028f4f8c51bdb47e02b5","original_commit_id":"dca29e9939905d88c3c4028f4f8c51bdb47e02b5","user":{"login":"arnebratt","id":1096883,"avatar_url":"https://secure.gravatar.com/avatar/6a69f51838dbfab01ed65bd6babe05ba?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-user-420.png","gravatar_id":"6a69f51838dbfab01ed65bd6babe05ba","url":"https://api.github.com/users/arnebratt","html_url":"https://github.com/arnebratt","followers_url":"https://api.github.com/users/arnebratt/followers","following_url":"https://api.github.com/users/arnebratt/following{/other_user}","gists_url":"https://api.github.com/users/arnebratt/gists{/gist_id}","starred_url":"https://api.github.com/users/arnebratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnebratt/subscriptions","organizations_url":"https://api.github.com/users/arnebratt/orgs","repos_url":"https://api.github.com/users/arnebratt/repos","events_url":"https://api.github.com/users/arnebratt/events{/privacy}","received_events_url":"https://api.github.com/users/arnebratt/received_events","type":"User"},"created_at":"2013-06-27T11:03:26Z","updated_at":"2013-06-27T11:03:26Z","html_url":"https://github.com/makingwaves/ezforgotpassword/pull/1#discussion_r4913280","pull_request_url":"https://api.github.com/repos/makingwaves/ezforgotpassword/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/makingwaves/ezforgotpassword/pulls/comments/4913280"},"html":{"href":"https://github.com/makingwaves/ezforgotpassword/pull/1#discussion_r4913280"},"pull_request":{"href":"https://api.github.com/repos/makingwaves/ezforgotpassword/pulls/1"}}}} | {
"id": 10962046,
"name": "ezforgotpassword",
"url": "https://github.com/makingwaves/ezforgotpassword"
} | {
"id": null,
"login": "arnebratt",
"gravatar_id": "6a69f51838dbfab01ed65bd6babe05ba",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "makingwaves",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-06-27T11:03:26 | null | {"repository":{"description":"","watchers":0,"stargazers":0,"forks":0,"fork":false,"size":192,"owner":"makingwaves","private":false,"open_issues":1,"has_issues":true,"has_downloads":true,"has_wiki":false,"created_at":"2013-06-26T00:59:58-07:00","pushed_at":"2013-06-27T00:26:03-07:00","master_branch":"master","organization":"makingwaves"},"actor_attributes":{"type":"User","name":"Arne","company":"Making Waves","location":"Oslo","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/makingwaves/ezforgotpassword/pull/1#discussion_r4913280"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/6202032","id":6202032,"body":"nit: please remove this line","diff_hunk":"@@ -82,6 +84,22 @@ navigator.mozL10n.ready(function bluetoothSettings() {\n }\n \n var nameEntered = window.prompt(_('change-phone-name'), myName);\n+ nameEntered = nameEntered.replace(/^\\s+|\\s+$/g, '');\n+\n+ if (nameEntered.length > MAX_DEVICE_NAME_LENGTH) {\n+","path":"apps/settings/js/bluetooth.js","position":16,"original_position":16,"commit_id":"ff1fb4fd619fb295012c0770f757de0258ce41fd","original_commit_id":"ff1fb4fd619fb295012c0770f757de0258ce41fd","user":{"login":"crh0716","id":2899280,"avatar_url":"https://0.gravatar.com/avatar/ab20989d946f4bd31c590b5a6ef73f7a?d=https%3A%2F%2Fidenticons.github.com%2F021394cc83b6f0d37aaaf1a268e7ab7d.png","gravatar_id":"ab20989d946f4bd31c590b5a6ef73f7a","url":"https://api.github.com/users/crh0716","html_url":"https://github.com/crh0716","followers_url":"https://api.github.com/users/crh0716/followers","following_url":"https://api.github.com/users/crh0716/following{/other_user}","gists_url":"https://api.github.com/users/crh0716/gists{/gist_id}","starred_url":"https://api.github.com/users/crh0716/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crh0716/subscriptions","organizations_url":"https://api.github.com/users/crh0716/orgs","repos_url":"https://api.github.com/users/crh0716/repos","events_url":"https://api.github.com/users/crh0716/events{/privacy}","received_events_url":"https://api.github.com/users/crh0716/received_events","type":"User"},"created_at":"2013-09-06T06:41:48Z","updated_at":"2013-09-06T06:41:48Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/11979#discussion_r6202032","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/11979","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/6202032"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/11979#discussion_r6202032"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/11979"}}}} | {
"id": 2317369,
"name": "gaia",
"url": "https://github.com/mozilla-b2g/gaia"
} | {
"id": null,
"login": "crh0716",
"gravatar_id": "ab20989d946f4bd31c590b5a6ef73f7a",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla-b2g",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-06T06:41:48 | null | {"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1336,"stargazers":1336,"forks":974,"fork":false,"size":34224,"owner":"mozilla-b2g","private":false,"open_issues":801,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-09-05T20:47:44-07:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Arthur Chen","location":"","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla-b2g/gaia/pull/11979#discussion_r6202032"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/6460819","id":6460819,"body":"Indeed. It's to show a \"no connection\" message and \"loading\" indicator when appropriate.","diff_hunk":"@@ -0,0 +1,194 @@\n+.evmeScope .evme-apps {\n+ position: absolute;\n+ top: 8.1rem;\n+ left: 0;\n+ right: -2rem;\n+ bottom: 0;\n+ z-index: 50;\n+}\n+.evmeScope.loading-app .evme-apps {\n+ pointer-events: none;\n+}\n+\n+.evmeScope.empty-query #evmeApps {\n+ display: none;\n+}\n+\n+.evmeScope .evme-apps > div {\n+ -moz-box-orient: vertical;\n+ -moz-box-sizing: border-box;\n+ display: -moz-box;\n+ width: 100%;\n+ min-height: 100%;\n+ padding-right: 1rem;\n+}\n+.evmeScope .evme-apps .loading-apps {\n+ position: absolute;\n+ top: 50%;\n+ left: 0;\n+ right: 2rem;\n+ text-align: center;\n+ height: 10rem;\n+ line-height: 10rem;\n+ margin-top: -5.1rem;\n+ display: none;\n+ pointer-events: none;\n+}\n+.evmeScope .show-loading-apps .loading-apps {\n+ display: block;\n+}\n+\n+.evmeScope .evme-apps ul li {\n+ clear: both;\n+ width: 25%;\n+ height: 9.4rem;\n+ padding-top: 1rem;\n+ text-align: center;\n+ cursor: pointer;\n+ margin-right: -0.4rem; /* inline-block spacing fix */\n+ display: inline-block;\n+ vertical-align: top;\n+ transition: transform .2s linear;\n+ position: relative; /* for span.remove positioning */\n+}\n+\n+.evmeScope .evme-apps ul.marketapps li{\n+ height: 9.3rem;\n+}\n+\n+.evmeScope .evme-apps:not(.has-installed) .has-installed-visible {\n+ display: none;\n+}\n+ .evmeScope .evme-apps ul li img {\n+\ttransition: transform .2s linear;\n+ }\n+.evmeScope .evme-apps ul #button-more {\n+ position: absolute;\n+ top: auto;\n+ bottom: 1.5rem;\n+ left: 0;\n+ height: auto;\n+ color: #b4dae7;\n+ font-size: 1.5rem;\n+ font-weight: 600;\n+ text-shadow: 0 0.1rem 0.1rem #000;\n+ cursor: pointer;\n+ z-index: 100;\n+ opacity: 0;\n+}\n+.evmeScope .evme-apps ul #button-more.visible {\n+ opacity: 1;\n+}\n+\n+.evmeScope .evme-apps ul li:nth-child(4n+1) {\n+ clear: both;\n+}\n+.evmeScope .evme-apps ul {\n+ padding: 0;\n+ margin: 0;\n+ display: inline;\n+}\n+.evmeScope .evme-apps ul.cloud {\n+ min-height: 0.1rem; /* meant for when there's no content */\n+}\n+.evmeScope .evme-apps ul li.new:not(.installed) img {\n+ transform: scale(0);\n+}\n+.evmeScope .evme-apps ul li > span.remove {\n+ position: absolute;\n+ top: .5rem;\n+ left: .8rem;\n+ width: calc(100% - .5rem);\n+ height: 2.6rem;\n+ z-index: 2;\n+ background: url(/resources/images/delete.png) no-repeat left top;\n+ display: none;\n+}\n+\n+/* Notifications */\n+\n+.evmeScope .evme-apps section[role=\"notification\"] {\n+ position: relative;\n+ -moz-box-flex: 1;\n+ display: none;\n+ visibility: hidden;\n+ min-height: 6rem;\n+}\n+.evmeScope .evme-apps.has-more section[role=\"notification\"] {\n+ margin-top: 1rem;\n+ box-shadow: 0 -0.1rem 0 0 rgba(255, 255, 255, .4), 0 -0.2rem 0 0 rgba(0, 0, 0, .4);\n+}\n+.evmeScope .evme-apps section[role=\"notification\"] > div {\n+ position: absolute;\n+ left: 0;\n+ right: 2rem;\n+ top: 50%;\n+ color: #fff;\n+ font-size: 1.6rem;\n+ text-align: center;\n+}\n+.evmeScope .evme-apps section[role=\"notification\"].loading-more > div {\n+ height: 3rem;\n+ margin-top: -1.5rem;\n+}\n+.evmeScope .evme-apps section[role=\"notification\"].connection-message > div {\n+ height: 3rem;\n+ margin-top: -2rem;\n+}\n+\n+.evmeScope:not(.connection-error) .evme-apps.has-more section[role=\"notification\"].loading-more,\n+.evmeScope.connection-error .evme-apps section[role=\"notification\"].connection-message {\n+ display: block;\n+}\n+\n+.evmeScope .evme-apps section[role=\"notification\"].show,\n+.evmeScope.connection-error .evme-apps section[role=\"notification\"].connection-message {\n+ display: block;\n+ visibility: visible;","path":"apps/homescreen/everything.me/modules/Results/Results.css","position":147,"original_position":147,"commit_id":"7676408c250ce453febae85d26a92d59d3f5b71a","original_commit_id":"7676408c250ce453febae85d26a92d59d3f5b71a","user":{"login":"ranbena","id":486954,"avatar_url":"https://2.gravatar.com/avatar/eba21d4c1a3927d9b282814c8679a230?d=https%3A%2F%2Fidenticons.github.com%2F0619e0892692ada9c4cda5498bcd9eb6.png","gravatar_id":"eba21d4c1a3927d9b282814c8679a230","url":"https://api.github.com/users/ranbena","html_url":"https://github.com/ranbena","followers_url":"https://api.github.com/users/ranbena/followers","following_url":"https://api.github.com/users/ranbena/following{/other_user}","gists_url":"https://api.github.com/users/ranbena/gists{/gist_id}","starred_url":"https://api.github.com/users/ranbena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranbena/subscriptions","organizations_url":"https://api.github.com/users/ranbena/orgs","repos_url":"https://api.github.com/users/ranbena/repos","events_url":"https://api.github.com/users/ranbena/events{/privacy}","received_events_url":"https://api.github.com/users/ranbena/received_events","type":"User"},"created_at":"2013-09-19T13:55:21Z","updated_at":"2013-09-19T13:55:21Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/12289#discussion_r6460819","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/12289","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/6460819"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/12289#discussion_r6460819"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/12289"}}}} | {
"id": 2317369,
"name": "gaia",
"url": "https://github.com/mozilla-b2g/gaia"
} | {
"id": null,
"login": "ranbena",
"gravatar_id": "eba21d4c1a3927d9b282814c8679a230",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla-b2g",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-19T13:55:21 | null | {"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1345,"stargazers":1345,"forks":1001,"fork":false,"size":624539,"owner":"mozilla-b2g","private":false,"open_issues":831,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-09-19T05:53:07-07:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Ran Ben Aharon","company":"Everything.me","blog":"http://ranbena.com","location":"Israel","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla-b2g/gaia/pull/12289#discussion_r6460819"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/6473207","id":6473207,"body":"It seems like each of these refresh calls this should roll into the `init` for the proper select.","diff_hunk":"@@ -203,15 +178,15 @@ var AlarmEdit = {\n \n // Init time, repeat, sound, snooze selection menu.\n this.initTimeSelect();\n- this.refreshTimeMenu();\n+ this.timeButton.refreshButtonLabel();\n this.initRepeatSelect();\n- this.refreshRepeatMenu();\n+ this.repeatButton.refreshButtonLabel();","path":"apps/clock/js/alarm_edit.js","position":160,"original_position":160,"commit_id":"1269758ca6607304725e1ff327f869c1f55c63c7","original_commit_id":"1269758ca6607304725e1ff327f869c1f55c63c7","user":{"login":"gnarf","id":549355,"avatar_url":"https://1.gravatar.com/avatar/de31e75f0b6f31344cc18e2a15c2f1c9?d=https%3A%2F%2Fidenticons.github.com%2F5929fca29f45007b2851299cd9e2e8b0.png","gravatar_id":"de31e75f0b6f31344cc18e2a15c2f1c9","url":"https://api.github.com/users/gnarf","html_url":"https://github.com/gnarf","followers_url":"https://api.github.com/users/gnarf/followers","following_url":"https://api.github.com/users/gnarf/following{/other_user}","gists_url":"https://api.github.com/users/gnarf/gists{/gist_id}","starred_url":"https://api.github.com/users/gnarf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnarf/subscriptions","organizations_url":"https://api.github.com/users/gnarf/orgs","repos_url":"https://api.github.com/users/gnarf/repos","events_url":"https://api.github.com/users/gnarf/events{/privacy}","received_events_url":"https://api.github.com/users/gnarf/received_events","type":"User"},"created_at":"2013-09-19T21:02:26Z","updated_at":"2013-09-19T21:02:26Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/12320#discussion_r6473207","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/12320","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/6473207"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/12320#discussion_r6473207"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/12320"}}}} | {
"id": 2317369,
"name": "gaia",
"url": "https://github.com/mozilla-b2g/gaia"
} | {
"id": null,
"login": "gnarf",
"gravatar_id": "de31e75f0b6f31344cc18e2a15c2f1c9",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla-b2g",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-19T21:02:26 | null | {"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1346,"stargazers":1346,"forks":1002,"fork":false,"size":624824,"owner":"mozilla-b2g","private":false,"open_issues":831,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-09-19T09:10:53-07:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Corey Frang","company":"Momentum Workshop","blog":"gnarf.net","location":"Rockford, IL","email":"[email protected]"},"url":"https://github.com/mozilla-b2g/gaia/pull/12320#discussion_r6473207"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/8307166","id":8307166,"diff_hunk":"@@ -0,0 +1,292 @@\n+/*global Utils, Template, Threads, ThreadUI, MessageManager, ContactRenderer,\n+ Contacts*/\n+/*exported Information */\n+\n+(function(exports) {\n+'use strict';\n+\n+/*\n+ Information view module is a subpanel belongs to TheadUI panel. This\n+ module provide some default method for thiw view module:\n+\n+ show: Reuse the ThreadUI page for information view. Hiding unrelated icon,\n+ reset the header, and render container for showing the view.\n+\n+ reset: Hide the view container, clean up the contact list and resume the\n+ icons/header for ThreadUI.\n+\n+ renderContactList(participants, options): Rendering group-view style contact\n+ list inside the page. Participants is an array of contact number and option\n+ is for setting additional information for rendering other lock for contact\n+ information.\n+*/\n+var TMPL = ['number', 'report'].reduce(function(tmpls, name) {\n+ tmpls[Utils.camelCase(name)] =\n+ Template('messages-' + name + '-tmpl');\n+ return tmpls;\n+}, {});\n+\n+function completeLocaleFormat(timestamp) {\n+ return Utils.date.format.localeFormat(new Date(+timestamp),\n+ navigator.mozL10n.get('report-dateTimeFormat')\n+ );\n+}\n+\n+// Generate report Div contains delivery report and read report for showing\n+// report information within contact list\n+function createReportDiv(reports) {\n+ var reportDiv = document.createElement('div');\n+ var data = {\n+ delivery: '',\n+ deliveryL10n: '',\n+ deliveryDateL10n: '',\n+ read: 'hide', // TODO: Check read status when gecko ready\n+ readL10n: 'message-read', // TODO: Check read status when gecko ready\n+ readDateL10n: '' // TODO: Check read status when gecko ready\n+ };\n+\n+ switch (reports.deliveryStatus) {\n+ case 'pending':\n+ data.deliveryL10n = 'message-requested';\n+ break;\n+ case 'success':\n+ data.deliveryDateL10n = completeLocaleFormat(reports.deliveryTimestamp);\n+ break;\n+ case 'error':\n+ data.deliveryL10n = 'message-status-error';\n+ break;\n+ case 'not-applicable':\n+ data.delivery = 'hide';\n+ }\n+ reportDiv.innerHTML = TMPL.report.interpolate(data);\n+ reportDiv.classList.add('report');\n+ return reportDiv;\n+}\n+\n+// Compute attachment size and return the corresponding l10nId(KB/MB) and\n+// args (total attachment size for message)\n+function sizeL10nParam(attachments) {\n+ var l10nId, l10nArgs;\n+ var size = 0;\n+\n+ attachments.forEach(function(attachment) {\n+ size += attachment.content.size;\n+ });\n+ var sizeKB = size / 1024;\n+ if (sizeKB < 1024) {\n+ l10nId = 'attachmentSize';\n+ l10nArgs = { n: sizeKB.toFixed(1) };\n+ } else {\n+ l10nId = 'attachmentSizeMB';\n+ l10nArgs = { n: (sizeKB / 1024).toFixed(1) };\n+ }\n+ return {\n+ l10nId: l10nId,\n+ l10nArgs: l10nArgs\n+ };\n+}\n+\n+// Incoming message: return array of sender number string;\n+// Outgoing message: return array of object(number and report div block).\n+function createListWithMsgInfo(message) {\n+ var list = [];\n+ if (message.sender) {\n+ list.push(message.sender);\n+ } else {\n+ if (message.type === 'mms') {\n+ message.deliveryInfo.forEach(function(info) {\n+ list.push({number: info.receiver,\n+ infoBlock: createReportDiv(info)});\n+ });\n+ } else {\n+ var info = {};\n+ info.deliveryStatus = message.deliveryStatus;\n+ info.deliveryTimestamp = message.deliveryTimestamp;\n+ list.push({number: message.receiver,\n+ infoBlock: createReportDiv(info)});\n+ }\n+ }\n+ return list;\n+}\n+\n+var VIEWS = {\n+ group: {\n+ name: 'participants',\n+ render: function renderGroup() {\n+ var lastId = Threads.lastId;\n+ var participants = lastId && Threads.get(lastId).participants;\n+ this.renderContactList(participants);\n+ navigator.mozL10n.localize(ThreadUI.headerText, 'participant', {\n+ n: participants.length\n+ });\n+ },\n+ elements: ['list']\n+ },\n+ report: {\n+ name: 'report',\n+ render: function renderReport() {\n+ var localize = navigator.mozL10n.localize;\n+ var messageId = +window.location.hash.split('=')[1];\n+ var request = MessageManager.getMessage(messageId);\n+\n+ request.onsuccess = (function() {\n+ var message = request.result;\n+ var type = message.type;\n+\n+ this.subject.textContent = '';\n+ this.datetime.textContent = completeLocaleFormat(message.timestamp);\n+\n+ // Filled in the description/status/size","path":"apps/sms/js/information.js","position":139,"original_position":139,"commit_id":"608c0423166f377f3d0c455964a0a33627197088","original_commit_id":"608c0423166f377f3d0c455964a0a33627197088","user":{"login":"julienw","id":454175,"avatar_url":"https://gravatar.com/avatar/a2b625f331361a7110da59a907d79e95?d=https%3A%2F%2Fidenticons.github.com%2F18225bff160f20d20462aa09c88c1d69.png&r=x","gravatar_id":"a2b625f331361a7110da59a907d79e95","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"body":"nit: \"Fill in\"","created_at":"2013-12-12T17:36:27Z","updated_at":"2013-12-12T17:36:27Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/13654#discussion_r8307166","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/13654","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/8307166"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/13654#discussion_r8307166"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/13654"}}}} | {
"id": 2317369,
"name": "gaia",
"url": "https://github.com/mozilla-b2g/gaia"
} | {
"id": null,
"login": "julienw",
"gravatar_id": "a2b625f331361a7110da59a907d79e95",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla-b2g",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-12-12T17:36:27 | null | {"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1437,"stargazers":1437,"forks":1208,"fork":false,"size":737613,"owner":"mozilla-b2g","private":false,"open_issues":949,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-12-12T09:24:55-08:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Julien Wajsberg","company":"Mozilla","blog":"http://everlong.org/","email":"da39a3ee5e6b4b0d3255bfef95601890afd80709"},"url":"https://github.com/mozilla-b2g/gaia/pull/13654#discussion_r8307166"} |
PullRequestReviewCommentEvent | true | {"comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/6517817","id":6517817,"body":"I was simply moving code, so I'm not entirely sure. My guess here though would be for the call log perhaps?","diff_hunk":"@@ -60,10 +60,34 @@ contacts.Details = (function() {\n initPullEffect(cover);\n \n utils.listeners.add({\n- '#toggle-favorite': toggleFavorite\n+ '#toggle-favorite': toggleFavorite,\n+ '#details-back': handleDetailsBack,\n+ '#edit-contact-button': showEditContact\n });\n };\n \n+ var handleDetailsBack = function handleDetailsBack() {\n+ if (ActivityHandler.currentlyHandling) {\n+ ActivityHandler.postCancel();\n+ Contacts.navigation.home();\n+ } else {\n+ var hasParams = window.location.hash.split('?');\n+ var params = hasParams.length > 1 ?\n+ utils.extractParams(hasParams[1]) : -1;\n+\n+ Contacts.navigation.back();\n+ // post message to parent page included Contacts app.\n+ if (params['back_to_previous_tab'] === '1') {\n+ var message = { 'type': 'contactsiframe', 'message': 'back' };\n+ window.parent.postMessage(message, COMMS_APP_ORIGIN);\n+ }","path":"apps/communications/contacts/js/views/details.js","position":25,"original_position":25,"commit_id":"5b77747df50279a9f75eb9390030a083772d6c26","original_commit_id":"5b77747df50279a9f75eb9390030a083772d6c26","user":{"login":"KevinGrandon","id":122602,"avatar_url":"https://1.gravatar.com/avatar/cf3541775f9060d370587dc1bcfcac9b?d=https%3A%2F%2Fidenticons.github.com%2F9c5dad2c9961076b07478ef9db6cec11.png","gravatar_id":"cf3541775f9060d370587dc1bcfcac9b","url":"https://api.github.com/users/KevinGrandon","html_url":"https://github.com/KevinGrandon","followers_url":"https://api.github.com/users/KevinGrandon/followers","following_url":"https://api.github.com/users/KevinGrandon/following{/other_user}","gists_url":"https://api.github.com/users/KevinGrandon/gists{/gist_id}","starred_url":"https://api.github.com/users/KevinGrandon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KevinGrandon/subscriptions","organizations_url":"https://api.github.com/users/KevinGrandon/orgs","repos_url":"https://api.github.com/users/KevinGrandon/repos","events_url":"https://api.github.com/users/KevinGrandon/events{/privacy}","received_events_url":"https://api.github.com/users/KevinGrandon/received_events","type":"User"},"created_at":"2013-09-23T15:34:43Z","updated_at":"2013-09-23T15:34:43Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/12110#discussion_r6517817","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/12110","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/6517817"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/12110#discussion_r6517817"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/12110"}}}} | {
"id": 2317369,
"name": "gaia",
"url": "https://github.com/mozilla-b2g/gaia"
} | {
"id": null,
"login": "KevinGrandon",
"gravatar_id": "cf3541775f9060d370587dc1bcfcac9b",
"avatar_url": null,
"url": null
} | {
"id": null,
"login": "mozilla-b2g",
"gravatar_id": null,
"avatar_url": null,
"url": null
} | 2013-09-23T15:34:43 | null | {"repository":{"description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see https://wiki.mozilla.org/Release_Management/B2G_Landing","homepage":"https://wiki.mozilla.org/B2G","watchers":1345,"stargazers":1345,"forks":1005,"fork":false,"size":653106,"owner":"mozilla-b2g","private":false,"open_issues":833,"has_issues":false,"has_downloads":true,"has_wiki":false,"language":"JavaScript","created_at":"2011-09-02T18:38:46-07:00","pushed_at":"2013-09-23T08:31:03-07:00","master_branch":"master","organization":"mozilla-b2g"},"actor_attributes":{"type":"User","name":"Kevin Grandon","company":"Mozilla","blog":"kevingrandon.com","location":"San Francisco, CA","email":"[email protected]"},"url":"https://github.com/mozilla-b2g/gaia/pull/12110#discussion_r6517817"} |