Datasets:

aqubed

/

kub_tickets_small

like 1

Follow

Aqubed AI (ACubed AI) 2

[ "Verolop", "aojea" ]

[ "kind/cleanup", "lgtm", "size/XS", "area/release-eng", "release-note-none", "approved", "cncf-cla: yes", "sig/release", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Aug 11 04:35:43 UTC 2023.\n", "created_at": "2023-08-11 07:50:52" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-11 07:50:57" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119899#\" title=\"Author self-approved\">sanchita-07</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[CHANGELOG/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/OWNERS)~~ [sanchita-07]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-11 07:51:23" }, { "body": "/retest", "created_at": "2023-08-11 09:45:52" }, { "body": "/milestone v1.28", "created_at": "2023-08-11 09:52:44" }, { "body": "LGTM label has been added. <details>Git tree hash: 95e9372904e0a9f6f3dc185b527c040d7e48c652</details>", "created_at": "2023-08-11 09:54:17" }, { "body": "LGTM label has been added. <details>Git tree hash: 265f077033155013a4f6ac45983b809d4ff66c3a</details>", "created_at": "2023-08-11 09:56:02" }, { "body": "/lgtm\r\n\r\nfrom sig-network", "created_at": "2023-08-11 09:58:38" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:50:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:50:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:50:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:50:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:50:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:50:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:50:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:51:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:51:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:51:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:51:39", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:51:49", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:51:49", "type": "review_requested" }, { "author": "sanchita-07", "created_at": "2023-08-11 08:19:28", "type": "mentioned" }, { "author": "sanchita-07", "created_at": "2023-08-11 08:19:28", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 09:52:46", "type": "milestoned" }, { "author": "Verolop", "created_at": "2023-08-11 09:54:14", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 09:54:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 09:54:37", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 09:54:38", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 09:56:01", "type": "labeled" }, { "author": "aojea", "created_at": "2023-08-11 09:58:43", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:55:26", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:55:26", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:55:26", "type": "closed" } ]

[ "mrunalp", "dashpole", "derekwaynecarr", "dchen1107" ]

[ "area/kubelet", "kind/cleanup", "lgtm", "sig/node", "size/S", "release-note-none", "cncf-cla: yes", "sig/instrumentation", "priority/important-longterm", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Aug 11 04:35:43 UTC 2023.\n", "created_at": "2023-08-11 07:25:40" }, { "body": "https://github.com/kubernetes/kubernetes/pull/119897\r\n\r\n@saschagrunert I just create a pr to fix this too, haha, :).\r\nI will close mine. ", "created_at": "2023-08-11 07:49:27" }, { "body": "> #119897\r\n> \r\n> @saschagrunert I just create a pr to fix this too, haha, :). I will close mine.\r\n\r\nOops, thank you! :pray: ", "created_at": "2023-08-11 07:56:12" }, { "body": "/retest", "created_at": "2023-08-11 08:28:19" }, { "body": "/triage accepted\r\n/priority important-longterm", "created_at": "2023-08-11 10:20:20" }, { "body": "/sig instrumentation", "created_at": "2023-08-14 02:42:34" }, { "body": "/assign", "created_at": "2023-08-24 16:35:02" }, { "body": "LGTM label has been added. <details>Git tree hash: 3395e8665409fe1d2422642698d16e9c26af1f5a</details>", "created_at": "2023-08-24 17:41:35" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119898#pullrequestreview-1594136933\" title=\"Approved\">dashpole</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119898#\" title=\"Author self-approved\">saschagrunert</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [random-liu](https://github.com/random-liu) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"random-liu\"]} -->", "created_at": "2023-08-24 17:42:01" }, { "body": "/assign @derekwaynecarr @dchen1107 @mrunalp ", "created_at": "2023-08-25 06:45:38" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:25:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:25:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:25:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:25:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:25:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:25:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:25:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:26:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:26:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:26:21", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:26:32", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 07:26:32", "type": "review_requested" }, { "author": "saschagrunert", "created_at": "2023-08-11 07:49:28", "type": "mentioned" }, { "author": "saschagrunert", "created_at": "2023-08-11 07:49:28", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-11 07:56:13", "type": "mentioned" }, { "author": "saschagrunert", "created_at": "2023-08-11 07:56:13", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-11 08:05:02", "type": "mentioned" }, { "author": "saschagrunert", "created_at": "2023-08-11 08:05:02", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-11 08:22:01", "type": "mentioned" }, { "author": "saschagrunert", "created_at": "2023-08-11 08:22:02", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:20:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:20:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:20:24", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:20:24", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 02:42:36", "type": "labeled" }, { "author": "dashpole", "created_at": "2023-08-24 16:35:03", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-24 17:41:33", "type": "labeled" }, { "author": "mrunalp", "created_at": "2023-08-25 06:45:39", "type": "mentioned" }, { "author": "mrunalp", "created_at": "2023-08-25 06:45:39", "type": "subscribed" }, { "author": "derekwaynecarr", "created_at": "2023-08-25 06:45:39", "type": "mentioned" }, { "author": "derekwaynecarr", "created_at": "2023-08-25 06:45:39", "type": "subscribed" }, { "author": "dchen1107", "created_at": "2023-08-25 06:45:39", "type": "mentioned" }, { "author": "dchen1107", "created_at": "2023-08-25 06:45:39", "type": "subscribed" }, { "author": "dchen1107", "created_at": "2023-08-25 06:45:40", "type": "assigned" }, { "author": "derekwaynecarr", "created_at": "2023-08-25 06:45:40", "type": "assigned" }, { "author": "mrunalp", "created_at": "2023-08-25 06:45:40", "type": "assigned" } ]

[]

[ "area/kubelet", "kind/cleanup", "sig/node", "size/S", "cncf-cla: yes", "needs-ok-to-test", "do-not-merge/release-note-label-needed", "needs-priority", "needs-triage" ]

[ { "body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-11 05:54:02" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Aug 11 04:35:43 UTC 2023.\n", "created_at": "2023-08-11 05:54:03" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-11 05:54:08" }, { "body": "Hi @fatsheep9146. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-08-11 05:54:09" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119897#\" title=\"Author self-approved\">fatsheep9146</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [random-liu](https://github.com/random-liu) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"random-liu\"]} -->", "created_at": "2023-08-11 05:54:56" }, { "body": "duplicate with #119898", "created_at": "2023-08-11 07:50:02" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-11 05:54:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 05:54:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 05:54:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 05:54:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 05:54:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 05:54:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 05:54:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 05:54:09", "type": "labeled" }, { "author": "fatsheep9146", "created_at": "2023-08-11 05:54:09", "type": "mentioned" }, { "author": "fatsheep9146", "created_at": "2023-08-11 05:54:09", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 05:54:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 05:54:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 05:54:46", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 05:55:11", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 05:55:11", "type": "review_requested" }, { "author": "fatsheep9146", "created_at": "2023-08-11 07:50:02", "type": "closed" } ]

[]

[ "kind/bug", "sig/cli", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-11 03:14:58" }, { "body": "hmm... https://github.com/kubernetes/kubernetes/pull/83552 added checking for schema-invalid objectmeta ... it may need expanding to handle the list case correctly", "created_at": "2023-08-11 14:38:24" }, { "body": "/sig cli\r\n", "created_at": "2023-08-14 16:18:22" }, { "body": "Got it, thanks @liggitt for your information. ", "created_at": "2023-08-15 03:25:40" } ]

[ { "author": "guicailiao", "created_at": "2023-08-11 03:14:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 03:14:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 03:14:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:18:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:18:26", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-15 03:25:41", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-15 03:25:41", "type": "subscribed" } ]

[ "mortent" ]

[ "kind/cleanup", "size/XS", "release-note-none", "sig/apps", "cncf-cla: yes", "needs-ok-to-test", "needs-priority", "do-not-merge/contains-merge-commits", "needs-triage" ]

[ { "body": "<a href=\"https://easycla.lfx.linuxfoundation.org/#/?version=2\"><img src=\"https://s3.amazonaws.com/cla-project-logo-prod/cla-signed.svg\" alt=\"CLA Signed\" align=\"left\" height=\"28\" width=\"328\" ></a><br/><br />The committers listed above are authorized under a signed CLA.<ul><li>:white_check_mark: login: luohaha3123 / name: lhaha (a947ce1a373462a753f1e2c0acb0e65e98cfbdf0, 7202b7fa90cf3ff6ab9fa95dac3f1a5d99cb0f1b, da0e9c96a4e586fd2983339016fbb3579f4d225d)</li></ul>", "created_at": "2023-08-11 01:37:39" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 10 22:35:08 UTC 2023.\n", "created_at": "2023-08-11 01:37:39" }, { "body": "Welcome @luohaha3123! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:", "created_at": "2023-08-11 01:37:43" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-11 01:37:43" }, { "body": "Hi @luohaha3123. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-08-11 01:37:44" }, { "body": "Adding label `do-not-merge/contains-merge-commits` because PR contains merge commits, which are not allowed in this repository.\nUse `git rebase` to reapply your commits on top of the target branch. Detailed instructions for doing so can be found [here](https://git.k8s.io/community/contributors/guide/github-workflow.md#4-keep-your-branch-in-sync).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-11 01:37:51" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119895#\" title=\"Author self-approved\">luohaha3123</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [janetkuo](https://github.com/janetkuo) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/controller/job/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/job/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"janetkuo\"]} -->", "created_at": "2023-08-11 01:38:06" }, { "body": "/assign @mortent ", "created_at": "2023-08-12 01:37:51" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-11 01:37:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 01:37:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 01:37:38", "type": "labeled" }, { "author": "luohaha3123", "created_at": "2023-08-11 01:37:39", "type": "mentioned" }, { "author": "luohaha3123", "created_at": "2023-08-11 01:37:39", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 01:37:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 01:37:42", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 01:37:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 01:37:43", "type": "labeled" }, { "author": "luohaha3123", "created_at": "2023-08-11 01:37:43", "type": "mentioned" }, { "author": "luohaha3123", "created_at": "2023-08-11 01:37:44", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 01:37:44", "type": "labeled" }, { "author": "luohaha3123", "created_at": "2023-08-11 01:37:44", "type": "mentioned" }, { "author": "luohaha3123", "created_at": "2023-08-11 01:37:44", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 01:37:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 01:38:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 01:38:19", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 01:38:28", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 01:38:28", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 01:46:02", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 01:46:02", "type": "labeled" }, { "author": "luohaha3123", "created_at": "2023-08-12 01:04:41", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-12 01:06:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-12 01:06:59", "type": "unlabeled" }, { "author": "mortent", "created_at": "2023-08-12 01:37:51", "type": "mentioned" }, { "author": "mortent", "created_at": "2023-08-12 01:37:51", "type": "subscribed" }, { "author": "mortent", "created_at": "2023-08-12 01:37:52", "type": "assigned" }, { "author": "luohaha3123", "created_at": "2023-08-12 01:57:55", "type": "closed" }, { "author": "luohaha3123", "created_at": "2023-08-12 01:58:48", "type": "head_ref_deleted" } ]

[]

[ "sig/node", "kind/feature", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 21:07:00" }, { "body": "/sig node\r\n", "created_at": "2023-08-14 16:12:26" }, { "body": "So this sounds a lot like https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/1287-in-place-update-pod-resources#summary\r\n\r\nI believe this feature is alpha in 1.27. You should play around with that feature and see if it solves your purpose. \r\n\r\nhttps://kubernetes.io/blog/2023/05/12/in-place-pod-resize-alpha/ ", "created_at": "2023-08-16 11:43:40" }, { "body": "Yes in place update will solve the problem by just only changing the limits after deploying the service but have a problem with it.\r\n1: After every time deploying microservice need to update the resource limits.\r\n2: After pod restart (by any reason) not possible to update the resource limits.\r\n3: Managing different limits for a same microservice will be challenge with helm chart.\r\n\r\n", "created_at": "2023-08-17 06:09:12" } ]

[ { "author": "saireddyb", "created_at": "2023-08-10 21:06:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 21:06:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 21:06:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:12:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:12:29", "type": "unlabeled" } ]

[]

[ "needs-sig", "triage/duplicate", "needs-triage" ]

[ { "body": "There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:\n- `/sig <group-name>`\n- `/wg <group-name>`\n- `/committee <group-name>`\n\nPlease see the [group list](https://git.k8s.io/community/sig-list.md) for a listing of the SIGs, working groups, and committees available.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 20:52:27" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 20:52:28" }, { "body": "This and #119894 are the same, Please close this in favor of #119894 as its description explains the problem better\r\n/triage duplicate", "created_at": "2023-08-14 02:49:38" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-10 20:52:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 20:52:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 02:49:40", "type": "labeled" }, { "author": "saireddyb", "created_at": "2023-08-14 12:07:03", "type": "closed" } ]

[ "HirazawaUi" ]

[ "sig/node", "kind/feature", "needs-triage" ]

[ { "body": "cc @yuanchen8911 (as kubernetes/enhancements#3902 is related)", "created_at": "2023-08-10 18:38:55" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 18:46:07" }, { "body": "/assign", "created_at": "2023-08-11 01:57:16" }, { "body": "Please hold. This hasn't been triaged.\r\nI just noticed this comment:\r\n\r\n```\r\n// Handling taint based evictions. Because we don't want a dedicated logic in TaintManager for NC-originated\r\n// taints and we normally don't rate limit evictions caused by taints, we need to rate limit adding taints.\r\n```\r\n\r\nSo it sounds intentional", "created_at": "2023-08-11 12:40:02" } ]

[ { "author": "yuanchen8911", "created_at": "2023-08-10 18:38:56", "type": "mentioned" }, { "author": "yuanchen8911", "created_at": "2023-08-10 18:38:56", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 18:46:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 18:46:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 18:46:06", "type": "labeled" }, { "author": "HirazawaUi", "created_at": "2023-08-11 01:57:18", "type": "assigned" } ]

[]

[ "kind/bug", "sig/node", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 17:52:08" }, { "body": "/sig node\r\n", "created_at": "2023-08-14 16:16:30" }, { "body": "> 1.24.13-gke.2500\r\n\r\nnormally you should first ask for support at the managed solution (GKE), then if they think it's appropriate, they can log the upstream kubernetes ticket - i.e. in case there is a bug.\r\n", "created_at": "2023-08-14 16:17:39" }, { "body": "/triage needs-information\r\nThis needs more information. Please add steps to reproduce and check if this is reproducible in >= 1.25 versions.\r\n", "created_at": "2023-08-16 17:32:29" }, { "body": "@ndixita: The label(s) `triage/need-information` cannot be applied, because the repository doesn't have them.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119891#issuecomment-1681015895):\n\n>/triage need-information\r\n>This needs more information. Please add steps to reproduce and check if this is reproducible in >= 1.25 versions.\r\n>\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-16 17:32:31" } ]

[ { "author": "roy-work", "created_at": "2023-08-10 17:38:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:52:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:52:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:16:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:16:33", "type": "unlabeled" }, { "author": "ndixita", "created_at": "2023-08-16 17:32:31", "type": "mentioned" }, { "author": "ndixita", "created_at": "2023-08-16 17:32:31", "type": "subscribed" } ]

[ "haircommander", "SergeyKanzhelev" ]

[ "area/test", "lgtm", "sig/node", "size/XS", "kind/flake", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "needs-priority", "needs-triage" ]

[ { "body": "/test pull-kubernetes-node-crio-e2e", "created_at": "2023-08-10 17:23:06" }, { "body": "Skipping CI for Draft Pull Request.\nIf you want CI signal for your change, please convert it to an actual PR.\nYou can still manually trigger a test run with `/test all`", "created_at": "2023-08-10 17:25:43" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 10 16:35:18 UTC 2023.\n", "created_at": "2023-08-10 17:25:45" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 17:25:50" }, { "body": "/kind flake", "created_at": "2023-08-10 17:28:24" }, { "body": "/test pull-kubernetes-node-crio-e2e ", "created_at": "2023-08-10 18:05:13" }, { "body": "/test pull-kubernetes-node-crio-e2e", "created_at": "2023-08-10 18:42:16" }, { "body": "/retest pull-kubernetes-node-crio-e2e", "created_at": "2023-08-10 18:48:40" }, { "body": "@tzneal: The `/retest` command does not accept any targets.\nThe following commands are available to trigger required jobs:\n* `/test pull-cadvisor-e2e-kubernetes`\n* `/test pull-kubernetes-conformance-kind-ga-only-parallel`\n* `/test pull-kubernetes-coverage-unit`\n* `/test pull-kubernetes-dependencies`\n* `/test pull-kubernetes-dependencies-go-canary`\n* `/test pull-kubernetes-e2e-gce`\n* `/test pull-kubernetes-e2e-gce-100-performance`\n* `/test pull-kubernetes-e2e-gce-big-performance`\n* `/test pull-kubernetes-e2e-gce-canary`\n* `/test pull-kubernetes-e2e-gce-cos`\n* `/test pull-kubernetes-e2e-gce-cos-canary`\n* `/test pull-kubernetes-e2e-gce-cos-no-stage`\n* `/test pull-kubernetes-e2e-gce-network-proxy-http-connect`\n* `/test pull-kubernetes-e2e-gce-scale-performance-manual`\n* `/test pull-kubernetes-e2e-kind`\n* `/test pull-kubernetes-e2e-kind-ipv6`\n* `/test pull-kubernetes-integration`\n* `/test pull-kubernetes-integration-go-canary`\n* `/test pull-kubernetes-kubemark-e2e-gce-scale`\n* `/test pull-kubernetes-node-e2e-containerd`\n* `/test pull-kubernetes-typecheck`\n* `/test pull-kubernetes-unit`\n* `/test pull-kubernetes-unit-go-canary`\n* `/test pull-kubernetes-update`\n* `/test pull-kubernetes-verify`\n* `/test pull-kubernetes-verify-go-canary`\n\nThe following commands are available to trigger optional jobs:\n* `/test check-dependency-stats`\n* `/test pull-ci-kubernetes-unit-windows`\n* `/test pull-e2e-gce-cloud-provider-disabled`\n* `/test pull-kubernetes-conformance-image-test`\n* `/test pull-kubernetes-conformance-kind-ga-only`\n* `/test pull-kubernetes-conformance-kind-ipv6-parallel`\n* `/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e`\n* `/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e-features`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-eviction`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-features`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-serial`\n* `/test pull-kubernetes-cross`\n* `/test pull-kubernetes-e2e-autoscaling-hpa-cm`\n* `/test pull-kubernetes-e2e-autoscaling-hpa-cpu`\n* `/test pull-kubernetes-e2e-capz-azure-disk`\n* `/test pull-kubernetes-e2e-capz-azure-disk-vmss`\n* `/test pull-kubernetes-e2e-capz-azure-file`\n* `/test pull-kubernetes-e2e-capz-azure-file-vmss`\n* `/test pull-kubernetes-e2e-capz-conformance`\n* `/test pull-kubernetes-e2e-capz-windows`\n* `/test pull-kubernetes-e2e-capz-windows-alpha-feature-vpa`\n* `/test pull-kubernetes-e2e-capz-windows-alpha-features`\n* `/test pull-kubernetes-e2e-capz-windows-serial-slow-hpa`\n* `/test pull-kubernetes-e2e-containerd-gce`\n* `/test pull-kubernetes-e2e-gce-correctness`\n* `/test pull-kubernetes-e2e-gce-cos-alpha-features`\n* `/test pull-kubernetes-e2e-gce-cos-kubetest2`\n* `/test pull-kubernetes-e2e-gce-csi-serial`\n* `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\n* `/test pull-kubernetes-e2e-gce-kubelet-credential-provider`\n* `/test pull-kubernetes-e2e-gce-network-proxy-grpc`\n* `/test pull-kubernetes-e2e-gce-serial`\n* `/test pull-kubernetes-e2e-gce-storage-disruptive`\n* `/test pull-kubernetes-e2e-gce-storage-slow`\n* `/test pull-kubernetes-e2e-gce-storage-snapshot`\n* `/test pull-kubernetes-e2e-gci-gce-autoscaling`\n* `/test pull-kubernetes-e2e-gci-gce-ingress`\n* `/test pull-kubernetes-e2e-gci-gce-ipvs`\n* `/test pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2`\n* `/test pull-kubernetes-e2e-kind-alpha-features`\n* `/test pull-kubernetes-e2e-kind-canary`\n* `/test pull-kubernetes-e2e-kind-dual-canary`\n* `/test pull-kubernetes-e2e-kind-ipv6-canary`\n* `/test pull-kubernetes-e2e-kind-ipvs-dual-canary`\n* `/test pull-kubernetes-e2e-kind-kms`\n* `/test pull-kubernetes-e2e-kind-multizone`\n* `/test pull-kubernetes-e2e-kops-aws`\n* `/test pull-kubernetes-e2e-storage-kind-disruptive`\n* `/test pull-kubernetes-e2e-ubuntu-gce-network-policies`\n* `/test pull-kubernetes-integration-eks`\n* `/test pull-kubernetes-kind-dra`\n* `/test pull-kubernetes-kind-json-logging`\n* `/test pull-kubernetes-kind-text-logging`\n* `/test pull-kubernetes-kubemark-e2e-gce-big`\n* `/test pull-kubernetes-local-e2e`\n* `/test pull-kubernetes-node-arm64-e2e-containerd-ec2`\n* `/test pull-kubernetes-node-arm64-e2e-containerd-serial-ec2`\n* `/test pull-kubernetes-node-arm64-ubuntu-serial-gce`\n* `/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e`\n* `/test pull-kubernetes-node-crio-cgrpv2-e2e`\n* `/test pull-kubernetes-node-crio-cgrpv2-e2e-kubetest2`\n* `/test pull-kubernetes-node-crio-e2e`\n* `/test pull-kubernetes-node-crio-e2e-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-alpha-features`\n* `/test pull-kubernetes-node-e2e-containerd-ec2`\n* `/test pull-kubernetes-node-e2e-containerd-features`\n* `/test pull-kubernetes-node-e2e-containerd-features-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-serial-ec2`\n* `/test pull-kubernetes-node-e2e-containerd-sidecar-containers`\n* `/test pull-kubernetes-node-e2e-containerd-standalone-mode`\n* `/test pull-kubernetes-node-e2e-containerd-standalone-mode-all-alpha`\n* `/test pull-kubernetes-node-e2e-crio-dra`\n* `/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2`\n* `/test pull-kubernetes-node-kubelet-credential-provider`\n* `/test pull-kubernetes-node-kubelet-serial-containerd`\n* `/test pull-kubernetes-node-kubelet-serial-containerd-kubetest2`\n* `/test pull-kubernetes-node-kubelet-serial-cpu-manager`\n* `/test pull-kubernetes-node-kubelet-serial-cpu-manager-kubetest2`\n* `/test pull-kubernetes-node-kubelet-serial-crio-cgroupv1`\n* `/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2`\n* `/test pull-kubernetes-node-kubelet-serial-hugepages`\n* `/test pull-kubernetes-node-kubelet-serial-memory-manager`\n* `/test pull-kubernetes-node-kubelet-serial-pod-disruption-conditions`\n* `/test pull-kubernetes-node-kubelet-serial-topology-manager`\n* `/test pull-kubernetes-node-kubelet-serial-topology-manager-kubetest2`\n* `/test pull-kubernetes-node-memoryqos-cgrpv2`\n* `/test pull-kubernetes-node-swap-fedora`\n* `/test pull-kubernetes-node-swap-fedora-serial`\n* `/test pull-kubernetes-node-swap-ubuntu-serial`\n* `/test pull-kubernetes-unit-experimental`\n* `/test pull-kubernetes-verify-strict-lint`\n* `/test pull-publishing-bot-validate`\n\nUse `/test all` to run the following jobs that were automatically triggered:\n* `pull-kubernetes-conformance-kind-ga-only-parallel`\n* `pull-kubernetes-conformance-kind-ipv6-parallel`\n* `pull-kubernetes-dependencies`\n* `pull-kubernetes-e2e-gce`\n* `pull-kubernetes-e2e-kind`\n* `pull-kubernetes-e2e-kind-ipv6`\n* `pull-kubernetes-integration`\n* `pull-kubernetes-node-e2e-containerd`\n* `pull-kubernetes-typecheck`\n* `pull-kubernetes-unit`\n* `pull-kubernetes-verify`\n\n\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119890#issuecomment-1673735784):\n\n>/retest pull-kubernetes-node-crio-e2e\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 18:54:48" }, { "body": "/test pull-kubernetes-node-crio-e2e\r\n/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e\r\n/test pull-kubernetes-node-crio-cgrpv2-e2e", "created_at": "2023-08-10 23:01:30" }, { "body": "/test pull-kubernetes-node-crio-e2e\r\n/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e\r\n/test pull-kubernetes-node-crio-cgrpv2-e2e", "created_at": "2023-08-12 00:49:10" }, { "body": "/test pull-kubernetes-node-crio-e2e\r\n/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e\r\n/test pull-kubernetes-node-crio-cgrpv2-e2e", "created_at": "2023-08-12 01:48:33" }, { "body": "/retest", "created_at": "2023-08-13 18:26:32" }, { "body": "/assign haircommander", "created_at": "2023-08-14 13:13:56" }, { "body": "LGTM label has been added. <details>Git tree hash: dd3782d4267255500ef41a4de7ce795192593da4</details>", "created_at": "2023-08-15 22:43:53" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119890#pullrequestreview-1579569159\" title=\"Approved\">SergeyKanzhelev</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119890#\" title=\"Author self-approved\">tzneal</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e_node/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/OWNERS)~~ [SergeyKanzhelev]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-15 22:44:09" } ]

[ { "author": "tzneal", "created_at": "2023-08-10 17:22:51", "type": "ready_for_review" }, { "author": "tzneal", "created_at": "2023-08-10 17:24:23", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:25:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:25:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:25:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:25:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:25:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:25:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:25:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:26:10", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:26:10", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:26:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:26:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:26:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:27:22", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:27:22", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:28:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:28:15", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:29:42", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:31:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:34:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:40:18", "type": "unlabeled" }, { "author": "tzneal", "created_at": "2023-08-10 18:04:09", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-08-10 18:04:09", "type": "subscribed" }, { "author": "tzneal", "created_at": "2023-08-10 18:54:49", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-08-10 18:54:49", "type": "subscribed" }, { "author": "tzneal", "created_at": "2023-08-10 21:37:22", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-08-10 21:37:22", "type": "subscribed" }, { "author": "tzneal", "created_at": "2023-08-10 23:36:33", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-08-10 23:36:33", "type": "subscribed" }, { "author": "tzneal", "created_at": "2023-08-12 00:48:25", "type": "head_ref_force_pushed" }, { "author": "tzneal", "created_at": "2023-08-12 01:25:42", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-08-12 01:25:42", "type": "subscribed" }, { "author": "tzneal", "created_at": "2023-08-12 02:21:12", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-08-12 02:21:12", "type": "subscribed" }, { "author": "tzneal", "created_at": "2023-08-14 13:13:41", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 13:13:43", "type": "unlabeled" }, { "author": "haircommander", "created_at": "2023-08-14 13:13:58", "type": "assigned" }, { "author": "tzneal", "created_at": "2023-08-14 13:14:29", "type": "renamed" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-15 22:43:49", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 22:43:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 22:44:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:45", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:45", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:46", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:47", "type": "milestoned" }, { "author": "tzneal", "created_at": "2023-08-16 17:12:23", "type": "head_ref_deleted" } ]

[]

[ "sig/node", "kind/failing-test", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 17:07:05" }, { "body": "So far no luck on reproducing this one. With `RUN_UNTIL_FAILURE=true`, it passed 193 times before I stopped it. \r\n\r\nEdit: And I just noticed the failures were all on crio, its good on containerd where I tested 🤦 Maybe a CRIO issue?\r\n", "created_at": "2023-08-10 17:07:58" }, { "body": "Test failed at 11:07:37.305:\r\n\r\n```\r\nIn [It] at: test/e2e_node/container_lifecycle_test.go:597 @ 08/09/23 11:07:37.305\r\n```\r\n\r\nbut it looks like the container was actually removed 1 second later:\r\n\r\n```\r\nAug 09 11:07:38 tmp-node-e2e-5c3909c7-fedora-coreos-38-20230722-3-0-gcp-x86-64 crio[2331]: time=\"2023-08-09 11:07:38.540684114Z\" level=info msg=\"Removed container 1ed6bbacc0f6a67599a00d65b48f0416ef233809c2c8b3e3f0eafcad3d7e5421: containers-lifecycle-test-9761/pod-termination-grace-period/busybox\" file=\"server/container_remove.go:47\" id=5626aa34-df58-4e8f-a924-f04f19353b16 name=/runtime.v1.RuntimeService/RemoveContainer\r\n```", "created_at": "2023-08-10 17:21:17" }, { "body": "On a test run where this passed, it took ~37 seconds (must complete in less than 40 seconds for the test to pass, 30 seconds grace period + a 10 second buffer).\r\n\r\n```\r\n STEP: ensuring the pod is terminated within the grace period seconds + buffer seconds @ 08/10/23 10:17:50.184\r\n \r\nAug 10 10:18:27 tmp-node-e2e-bc2e2423-fedora-coreos-38-20230722-3-0-gcp-x86-64 crio[2202]: time=\"2023-08-10 10:18:27.966947629Z\" level=info msg=\"Removed container 0ef6f3bee901f275f2a1b0ca6771922604d74dbe814e2b3c7bcdf4052bab61fa: containers-lifecycle-test-2998/pod-termination-grace-period/busybox\" file=\"server/container_remove.go:47\" id=6c90283b-f856-4e42-a4e2-992dd7fd71ec name=/runtime.v1.RuntimeService/RemoveContainer\r\n```", "created_at": "2023-08-10 18:09:08" }, { "body": "Another failure, here it looks like it took 58 seconds for the pod to be removed.\r\n\r\n```\r\nSTEP: ensuring the pod is terminated within the grace period seconds + buffer seconds @ 08/11/23 10:27:05.659\r\nAug 11 10:27:45.662: INFO: Failed inside E2E framework:\r\n\r\nAug 11 10:28:03 tmp-node-e2e-8624445f-fedora-coreos-38-20230722-3-0-gcp-x86-64 crio[2309]: time=\"2023-08-11 10:28:03.895769946Z\" level=info msg=\"Removed container 4fc642f64124a14f0de2ae8b2a1c9ed427e0993508854701e8d2fcc40f2af8ca: containers-lifecycle-test-1299/pod-termination-grace-period/busybox\" file=\"server/container_remove.go:47\" id=0e20d38d-47bf-407a-94c3-ac69d76024c5 name=/runtime.v1.RuntimeService/RemoveContainer\r\n```\r\n\r\n\r\n@haircommander It looks like we can deflake these tests by just raising the buffer, but is there a potential crio issue and these pods should be removed faster?", "created_at": "2023-08-11 12:33:57" }, { "body": "I think bumping the time makes sense. Maybe cri-o does something synchronously that containerd takes care of async or something. Do you have a suggested time to bump it to?", "created_at": "2023-08-11 18:55:51" }, { "body": "I bumped the buffer from 10s to 30s in https://github.com/kubernetes/kubernetes/pull/119890. That would have prevented fix the four occurrences I've looked at so far.", "created_at": "2023-08-12 00:49:51" }, { "body": "Passing so far, I'll close this in a few days if they stay green:\r\n\r\n- https://testgrid.k8s.io/sig-node-cri-o#ci-crio-cgroupv2-node-e2e-conformance\r\n- https://testgrid.k8s.io/sig-node-cri-o#ci-crio-cgroupv1-node-e2e-conformance\r\n", "created_at": "2023-08-16 17:15:34" }, { "body": "Flakes on other tests for those jobs, but this particular test is green now.", "created_at": "2023-08-18 12:57:31" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:06:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:07:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:07:04", "type": "labeled" }, { "author": "haircommander", "created_at": "2023-08-11 12:33:57", "type": "mentioned" }, { "author": "haircommander", "created_at": "2023-08-11 12:33:57", "type": "subscribed" }, { "author": "tzneal", "created_at": "2023-08-18 12:57:31", "type": "closed" } ]

[ "logicalhan" ]

[ "kind/bug", "priority/important-soon", "area/apiserver", "lgtm", "sig/api-machinery", "release-note", "size/M", "approved", "cncf-cla: yes", "kind/regression", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 10 10:36:06 UTC 2023.\n", "created_at": "2023-08-10 15:36:29" }, { "body": "/cc @serathius ", "created_at": "2023-08-10 15:36:44" }, { "body": "/assign @logicalhan\r\n/triage accepted", "created_at": "2023-08-10 16:32:43" }, { "body": "LGTM label has been added. <details>Git tree hash: 444cc7dfcf01ff31c07961b8c862f1092cb2e9c0</details>", "created_at": "2023-08-10 16:36:20" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119888#\" title=\"Author self-approved\">dgrisonnet</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119888#pullrequestreview-1572311511\" title=\"Approved\">logicalhan</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/apiserver/pkg/storage/etcd3/metrics/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/storage/etcd3/metrics/OWNERS)~~ [logicalhan]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-10 16:36:37" }, { "body": "@logicalhan @deads2k Is it too late to tag milestone 1.28 for this PR?", "created_at": "2023-08-10 17:18:52" }, { "body": "> @logicalhan @deads2k Is it too late to tag milestone 1.28 for this PR?\r\n\r\nThis looks like a bugfix, we should probably take it.\r\n\r\n", "created_at": "2023-08-10 17:19:40" }, { "body": "David is out on vacation. @liggitt Would you mind tagging the milestone 1.28 for this PR? Thanks.\r\n", "created_at": "2023-08-10 17:29:30" }, { "body": "/kind regression\r\n/milestone v1.28\r\n/hold for coordination with release folks\r\n(this seems important for 1.28.0, but small enough that it could go in after rc1 without needing another rc)", "created_at": "2023-08-10 17:31:21" }, { "body": "is this a regression in 1.28 relative to 1.27?", "created_at": "2023-08-10 17:34:39" }, { "body": "> is this a regression in 1.28 relative to 1.27?\r\n\r\nIt is not given the code is added in 1.28 I believe.", "created_at": "2023-08-10 17:38:18" }, { "body": "> > is this a regression in 1.28 relative to 1.27?\r\n> \r\n> It is not given the code is added in 1.28 I believe.\r\n\r\nI might have misunderstood you. You mean if this issue wasn't in 1.27 but it is in 1.28, then yes.", "created_at": "2023-08-10 17:40:47" }, { "body": "/priority important-soon", "created_at": "2023-08-10 17:42:38" }, { "body": "rc1 cut is in progress, once that completes, will unhold this and merge to be available in 1.28.0", "created_at": "2023-08-10 18:04:52" }, { "body": "/hold cancel", "created_at": "2023-08-11 01:23:40" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-10 15:36:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 15:36:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 15:36:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 15:36:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 15:36:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 15:36:35", "type": "labeled" }, { "author": "serathius", "created_at": "2023-08-10 15:36:44", "type": "mentioned" }, { "author": "serathius", "created_at": "2023-08-10 15:36:45", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 15:36:45", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 15:37:00", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 15:37:00", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 15:37:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 15:37:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 15:37:15", "type": "unlabeled" }, { "author": "bertinatto", "created_at": "2023-08-10 16:23:04", "type": "referenced" }, { "author": "logicalhan", "created_at": "2023-08-10 16:32:44", "type": "mentioned" }, { "author": "logicalhan", "created_at": "2023-08-10 16:32:44", "type": "subscribed" }, { "author": "logicalhan", "created_at": "2023-08-10 16:32:45", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:32:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:32:46", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:36:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:36:39", "type": "labeled" }, { "author": "logicalhan", "created_at": "2023-08-10 17:18:52", "type": "mentioned" }, { "author": "logicalhan", "created_at": "2023-08-10 17:18:52", "type": "subscribed" }, { "author": "deads2k", "created_at": "2023-08-10 17:18:52", "type": "mentioned" }, { "author": "deads2k", "created_at": "2023-08-10 17:18:53", "type": "subscribed" }, { "author": "logicalhan", "created_at": "2023-08-10 17:19:41", "type": "mentioned" }, { "author": "logicalhan", "created_at": "2023-08-10 17:19:41", "type": "subscribed" }, { "author": "deads2k", "created_at": "2023-08-10 17:19:41", "type": "mentioned" }, { "author": "deads2k", "created_at": "2023-08-10 17:19:41", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-10 17:29:30", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-10 17:29:30", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:36:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:36:08", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:36:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:51:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:51:12", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 17:59:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 18:00:01", "type": "unlabeled" }, { "author": "bertinatto", "created_at": "2023-08-10 18:12:25", "type": "referenced" }, { "author": "bertinatto", "created_at": "2023-08-10 18:13:23", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 01:23:41", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-11 02:54:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 03:53:26", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 03:53:26", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 03:53:27", "type": "closed" }, { "author": "bertinatto", "created_at": "2023-08-11 15:03:09", "type": "referenced" }, { "author": "bertinatto", "created_at": "2023-08-11 15:04:56", "type": "referenced" }, { "author": "bertinatto", "created_at": "2023-08-11 15:08:44", "type": "referenced" }, { "author": "bertinatto", "created_at": "2023-08-11 15:09:46", "type": "referenced" } ]

[ "danwinship" ]

[ "kind/bug", "sig/network", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 15:12:18" }, { "body": "/sig network\r\n\r\n> net.netfilter.nf_conntrack_tcp_be_liberal = 1 on nodes doesn't reproduce the issue anymore\r\n\r\nBut it has in the past? What has changed?", "created_at": "2023-08-11 05:51:53" }, { "body": "Related https://github.com/kubernetes/kubernetes/issues/117924? Probably not, since net.netfilter.nf_conntrack_tcp_be_liberal = 1 doesn't work, but if something has changed...?\r\n\r\n\r\n", "created_at": "2023-08-11 06:04:06" }, { "body": "let's get the facts first, the environment says bare metal and 1.24 and calico ...\r\n\r\nare you using kube-proxy? iptables or ipvs?\r\nhow many interfaces you have per node?\r\nwas this working in 1.23 and started to fail once you upgraded to 1.24?", "created_at": "2023-08-11 07:30:23" }, { "body": "@uablrek So setting the net.netfilter.nf_conntrack_tcp_be_liberal = 1 fixed the issue for this case as in original defect.", "created_at": "2023-08-11 16:23:48" }, { "body": "@aojea I apologize i should have put it in the description itself. I have updated it now.\r\nWe are using kube-proxy with ipvs. The problematic node has 64 interfaces (This includes calico and Oam interfaces). We jumped from k8 v1.21.11 to k8 1.24.7, so we haven't tested 1.23. ", "created_at": "2023-08-11 16:37:29" }, { "body": "I see it is definitely is related to [ https://github.com/kubernetes/kubernetes/issues/117924](117924)@uablrek . I just confirmed the same issue is there in k8 1.21.11 as well. ", "created_at": "2023-08-11 17:27:26" }, { "body": "@jasvinder1107 Can we set this issue as duplicate of https://github.com/kubernetes/kubernetes/issues/117924 then?\r\n\r\nYou can use net.netfilter.nf_conntrack_tcp_be_liberal=1 as a work-around until it's fixed. A problem as I see it, is that [I can't reproduce the problem](https://github.com/kubernetes/kubernetes/issues/117924#issuecomment-1545793708) which make it hard to verify a PR. On the other hand, the problem is analyzed in an excellent way so it should be possible to fix.\r\n\r\nPerhaps you can help by testing a PR?\r\n\r\n/cc @aroradaman", "created_at": "2023-08-12 07:28:12" }, { "body": "@uablrek, sure, you can mark this as duplicate. The problem is this issue is only reproduced in our prod env with servers having high uptime. Also, I was able to see intermittent timeouts during release certification testing. A simple reboot solves the problem for some time. It is not easy to reproduce, but l will see if i can tweak conntrack buffers and try to reproduce it early. I will keep you posted on the progress of reproduction.", "created_at": "2023-08-14 01:26:53" }, { "body": "/assign @danwinship ", "created_at": "2023-08-17 16:15:09" }, { "body": "This is a duplicate of https://github.com/kubernetes/kubernetes/issues/117924", "created_at": "2023-08-17 16:17:48" }, { "body": "> enable the net.netfilter.nf_conntrack_tcp_be_liberal = 1 on nodes fixed the issue for us.\r\n\r\nIf that works for you then that's our recommendation. There's discussion going on in the other issue @uablrek linked to about exactly what rules kubernetes should be creating to try to avoid this problem, but we know that we can't fix all connection reset problems for all kubernetes connections without also potentially breaking some non-kubernetes traffic for some users.\r\n", "created_at": "2023-08-22 13:30:41" }, { "body": "/close\r\n\r\ndup of https://github.com/kubernetes/kubernetes/issues/117924", "created_at": "2023-08-22 13:31:09" }, { "body": "@danwinship: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119887#issuecomment-1688196319):\n\n>/close\r\n>\r\n>dup of https://github.com/kubernetes/kubernetes/issues/117924\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-22 13:31:15" } ]

[ { "author": "jasvinder1107", "created_at": "2023-08-10 15:12:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 15:12:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 15:12:17", "type": "labeled" }, { "author": "jasvinder1107", "created_at": "2023-08-10 15:26:05", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 05:51:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 05:51:56", "type": "unlabeled" }, { "author": "uablrek", "created_at": "2023-08-11 16:23:49", "type": "mentioned" }, { "author": "uablrek", "created_at": "2023-08-11 16:23:49", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-08-11 16:37:30", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-11 16:37:30", "type": "subscribed" }, { "author": "uablrek", "created_at": "2023-08-11 17:27:27", "type": "mentioned" }, { "author": "uablrek", "created_at": "2023-08-11 17:27:27", "type": "subscribed" }, { "author": "aroradaman", "created_at": "2023-08-12 07:28:13", "type": "mentioned" }, { "author": "aroradaman", "created_at": "2023-08-12 07:28:13", "type": "subscribed" }, { "author": "jasvinder1107", "created_at": "2023-08-12 07:28:13", "type": "mentioned" }, { "author": "jasvinder1107", "created_at": "2023-08-12 07:28:13", "type": "subscribed" }, { "author": "jasvinder1107", "created_at": "2023-08-14 01:26:53", "type": "closed" }, { "author": "uablrek", "created_at": "2023-08-14 01:26:54", "type": "mentioned" }, { "author": "uablrek", "created_at": "2023-08-14 01:26:54", "type": "subscribed" }, { "author": "jasvinder1107", "created_at": "2023-08-14 01:26:56", "type": "reopened" }, { "author": "danwinship", "created_at": "2023-08-17 16:15:09", "type": "mentioned" }, { "author": "danwinship", "created_at": "2023-08-17 16:15:09", "type": "subscribed" }, { "author": "danwinship", "created_at": "2023-08-17 16:15:11", "type": "assigned" }, { "author": "uablrek", "created_at": "2023-08-22 13:30:41", "type": "mentioned" }, { "author": "uablrek", "created_at": "2023-08-22 13:30:41", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 13:31:15", "type": "closed" }, { "author": "danwinship", "created_at": "2023-08-22 13:31:16", "type": "mentioned" }, { "author": "danwinship", "created_at": "2023-08-22 13:31:16", "type": "subscribed" } ]

[]

[ "sig/scheduling", "sig/node", "kind/feature", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 12:33:37" }, { "body": "Also\r\n/sig node\r\nFYI @derekwaynecarr @mrunalp ", "created_at": "2023-08-10 14:41:44" }, { "body": "I am trying to reproduce this issue, and here is what I see. \r\n\r\nI started a new kind cluster with 3 nodes, and then killed the kublet (docker stop) on one of the nodes, which resulted in:\r\n```\r\nNAME STATUS TAINTS\r\ntest-v1-22-control-plane Ready node-role.kubernetes.io/master:NoSchedule\r\ntest-v1-22-worker Ready\r\ntest-v1-22-worker2 NotReady node.kubernetes.io/unreachable:NoSchedule(21s),node.kubernetes.io/unreachable:NoExecute(16s)\r\n```\r\n\r\nI assume that the taint mentioned in the issue is added at some point later, is that the correct assumption?\r\n```\r\n- key: node.kubernetes.io/not-ready\r\n effect: NoExecute\r\n ```\r\n", "created_at": "2023-08-10 17:51:04" }, { "body": "> However, this has the additional effect that the pod can be scheduled before the node is considered ready.\r\n\r\nI actually wasn't too sure if it's true. Per my understanding, NoExecute doesn't override NoSchedule - i.e., they're handled separately.", "created_at": "2023-08-10 17:51:26" }, { "body": "In the SIG Scheduling meeting, a contributor suggested that we already have the semantics that these workloads need.\r\n\r\nLet's imagine a node has the following taints:\r\n\r\n```yaml\r\n- key: foo\r\n effect: NoExecute\r\n- key: foo\r\n effect: NoSchedule\r\n```\r\n\r\nThen a Pod that has just the toleration for `foo:NoExecute` would obtain the semantics:\r\n- can't schedule\r\n- if it was running, it would be exempted from eviction.\r\n\r\nThis is exactly what we want, except that the node-lifecyle-controller only adds a `node.kubernetes.io/not-ready:NoExecute` taint. Adding an extra `NoSchedule` effect would unfortunately be a breaking change, for pods that today expect to be scheduled.", "created_at": "2023-08-10 17:53:09" }, { "body": "cc @smarterclayton ", "created_at": "2023-08-10 17:54:21" }, { "body": "> I assume that the taint mentioned in the issue is added at some point later, is that the correct assumption?\r\n\r\nA node is usually node ready right after being created (this might be hard to repro in kind). But this documentation also suggests that it will be added sometime after being unreachable.\r\n\r\nhttps://kubernetes.io/docs/concepts/architecture/nodes/#condition", "created_at": "2023-08-10 17:56:36" }, { "body": "Oh, it says below:\r\n\r\n> When problems occur on nodes, the Kubernetes control plane automatically creates [taints](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/) that match the conditions affecting the node. An example of this is when the status of the Ready condition remains Unknown or False for longer than the kube-controller-manager's NodeMonitorGracePeriod, which defaults to 40 seconds. This will cause either an node.kubernetes.io/unreachable taint, for an Unknown status, or a node.kubernetes.io/not-ready taint, for a False status, to be added to the Node.", "created_at": "2023-08-10 17:58:23" }, { "body": "@ichekrygin I think we might be adding the same taint with the 2 effects already, if I'm reading the nodelifecycle code correctly.\r\n\r\nhttps://github.com/kubernetes/kubernetes/blame/18c3c7efb3bcccd84cccc7dacc01f0a7427b8eb9/pkg/controller/nodelifecycle/node_lifecycle_controller.go#L491\r\n\r\nhttps://github.com/kubernetes/kubernetes/blame/18c3c7efb3bcccd84cccc7dacc01f0a7427b8eb9/pkg/controller/nodelifecycle/node_lifecycle_controller.go#L500\r\n\r\nNow I'm wondering if what I observed is a different artifact, perhaps caused by the fact that taints are added asynchronously after the node is created (and in 2 separate calls).\r\n", "created_at": "2023-08-10 18:10:36" }, { "body": "I am trying to better understand the premise of this issue, which seems to be:\r\n \"a given node has `node.kubernetes.io/not-ready:NoExecute` without the matching `node.kubernetes.io/not-ready:NoSchedule`\"\r\n\r\nPer K8s docs: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/#taint-based-evictions\r\n```\r\n- node.kubernetes.io/not-ready: Node is not ready. This corresponds to the NodeCondition Ready being \"False\".\r\n- node.kubernetes.io/unreachable: Node is unreachable from the node controller. This corresponds to the NodeCondition Ready being \"Unknown\".\r\n```\r\n\r\nI can repro this by setting node \"Ready\" condition to \"False\" and observe the following taints: \r\n```\r\nNAME STATUS CONDITIONS TAINTS\r\ntest-v1-22-control-plane Ready MemoryPressure:False,DiskPressure:False,PIDPressure:False,Ready:True node-role.kubernetes.io/master:NoSchedule\r\ntest-v1-22-worker NotReady MemoryPressure:False,DiskPressure:False,PIDPressure:False,Ready:False node.kubernetes.io/not-ready:NoSchedule(9s),node.kubernetes.io/not-ready:NoExecute(6s)\r\n```\r\n\r\nThis resulted in 2 taints, `node.kubernetes.io/not-ready:NoSchedule(9s)` and `node.kubernetes.io/not-ready:NoExecute(6s)`, with the former added 3 seconds earlier than the latter. \r\n\r\nNow, the clearing of the taints is happening in the same order, i.e., \"NoSchedule\" taint removed BEFORE the \"NoExecute\" counterpart, and maybe this is the problem that is being brought up in this proposal/issue assumption.\r\n```\r\ntest-v1-22-worker Ready MemoryPressure:False,DiskPressure:False,PIDPressure:False,Ready:True node.kubernetes.io/not-ready:NoExecute(7s)\r\n```\r\nNote ^, only a singe \"NoExecute\" taint. \r\n\r\nIs this the issue we are trying to address? \r\n\r\nWith that said, the \"NoExectue\" taint is also removed momentarily within 3 seconds delay, so it looks like there is a small window for the pod tolerating the \"NoExecute\" taint to be scheduled on the node, which this proposal is trying to avoid. In this specific context, I suspect this could be an OK path since the node is on the \"recovery\" path anyway. However, I also see how this could be confusing, and perhaps removing \"NoSchedule\" and \"NoExcute\" at the same time could be a better option (or possibly reversing the order and removing \"NoSchedule\" after the \"NoExectue\"). \r\n", "created_at": "2023-08-10 18:14:43" }, { "body": "> This resulted in 2 taints, `node.kubernetes.io/not-ready:NoSchedule(9s)` and `node.kubernetes.io/not-ready:NoExecute(6s)`, with the former added 3 seconds earlier than the latter.\r\n\r\nThanks for confirming. `3s` difference sounds quite significant, which could definitely cause problems in a real cluster. I don't think the order is guaranteed, but the NoSchedule should be more likely to be added first (given the nodelifecycle controller code).\r\n\r\n> Is this the issue we are trying to address?\r\n\r\nNo, this is not what I was trying to solve, but your investigation proves that my original proposal is not necessary. \r\n\r\nThat said, the delay that you show is worrisome. Is this a kind cluster?\r\n\r\nMaybe there is a way we can add both taints in a single API call to reduce latency.", "created_at": "2023-08-10 18:26:01" }, { "body": "Opened #119892 to track improving the number of API calls.\r\n\r\n/close\r\n\r\nThis turned out to be unnecessary.", "created_at": "2023-08-10 18:36:14" }, { "body": "@alculquicondor: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119886#issuecomment-1673718046):\n\n>Opened #119892 to track improving the number of API calls.\r\n>\r\n>/close\r\n>\r\n>This turned out to be unnecessary.\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 18:38:17" }, { "body": "Thanks @ichekrygin for spotting the time gap when controller manager tries to set different taints.\r\n\r\nAgree with Aldo the `3s` gap does need some improvement, esp. it's just observed on a testing cluster.", "created_at": "2023-08-10 18:53:28" } ]

[ { "author": "alculquicondor", "created_at": "2023-08-10 12:33:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:33:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:33:36", "type": "labeled" }, { "author": "mrunalp", "created_at": "2023-08-10 14:41:45", "type": "mentioned" }, { "author": "mrunalp", "created_at": "2023-08-10 14:41:45", "type": "subscribed" }, { "author": "derekwaynecarr", "created_at": "2023-08-10 14:41:45", "type": "mentioned" }, { "author": "derekwaynecarr", "created_at": "2023-08-10 14:41:45", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 14:41:46", "type": "labeled" }, { "author": "smarterclayton", "created_at": "2023-08-10 17:54:22", "type": "mentioned" }, { "author": "smarterclayton", "created_at": "2023-08-10 17:54:22", "type": "subscribed" }, { "author": "ichekrygin", "created_at": "2023-08-10 18:10:36", "type": "mentioned" }, { "author": "ichekrygin", "created_at": "2023-08-10 18:10:36", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 18:38:16", "type": "closed" }, { "author": "alculquicondor", "created_at": "2023-08-10 18:38:18", "type": "mentioned" }, { "author": "alculquicondor", "created_at": "2023-08-10 18:38:18", "type": "subscribed" }, { "author": "ichekrygin", "created_at": "2023-08-10 18:53:28", "type": "mentioned" }, { "author": "ichekrygin", "created_at": "2023-08-10 18:53:29", "type": "subscribed" } ]

[]

[ "area/test", "sig/api-machinery", "size/M", "kind/flake", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "do-not-merge/work-in-progress", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 10 10:36:06 UTC 2023.\n", "created_at": "2023-08-10 12:30:27" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 12:30:31" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119885#\" title=\"Author self-approved\">aojea</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e/apimachinery/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/apimachinery/OWNERS)~~ [aojea]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-10 12:31:08" }, { "body": "/test pull-kubernetes-e2e-kind\r\n/test pull-kubernetes-e2e-kind-ipv6", "created_at": "2023-08-10 15:26:56" }, { "body": "/test pull-kubernetes-e2e-kind\r\n/test pull-kubernetes-e2e-kind-ipv6\r\n\r\nof course it does not flake now XD", "created_at": "2023-08-10 22:47:02" }, { "body": "/test pull-kubernetes-e2e-kind\r\n/test pull-kubernetes-e2e-kind-ipv6\r\n\r\nno failure yet", "created_at": "2023-08-11 08:55:08" }, { "body": "no luck \r\n\r\n> Kubernetes e2e suite: [It] [sig-apps] Job Using a pod failure policy to not count some failures towards the backoffLimit Ignore DisruptionTarget condition expand_more\t\r\n\r\n/test pull-kubernetes-e2e-kind\r\n/test pull-kubernetes-e2e-kind-ipv6", "created_at": "2023-08-11 14:49:46" }, { "body": "/test pull-kubernetes-e2e-kind\r\n/test pull-kubernetes-e2e-kind-ipv6", "created_at": "2023-08-13 16:34:37" }, { "body": "/test pull-kubernetes-e2e-kind\r\n/test pull-kubernetes-e2e-kind-ipv6", "created_at": "2023-08-15 22:21:51" }, { "body": "/test pull-kubernetes-e2e-kind\r\n/test pull-kubernetes-e2e-kind-ipv6", "created_at": "2023-08-16 13:31:35" }, { "body": "I can't repro this", "created_at": "2023-08-19 14:20:48" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:30:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:30:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:30:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:30:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:30:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:30:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:30:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:30:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:31:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:31:20", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:31:20", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:31:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:31:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:31:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:31:34", "type": "unlabeled" }, { "author": "aojea", "created_at": "2023-08-10 13:01:00", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-10 13:01:00", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-08-11 09:32:30", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-11 09:32:31", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-08-19 14:20:48", "type": "closed" } ]

[]

[ "kind/bug", "sig/node", "triage/needs-information", "needs-triage", "wg/batch" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 11:55:33" }, { "body": "/wg Batch", "created_at": "2023-08-10 12:37:52" }, { "body": "are your processes handling the SIGTERM? your application should be handling the signal \r\n\r\n/sig node", "created_at": "2023-08-10 14:48:57" }, { "body": "The processes starts to do a controlled shutdown on the shell propageted\r\nSIGTERM. Kubernets terminationGracePeriodSeconds is 120 seconds\r\nAfter 30 seconds the processes doing shutdown are killed (must be by\r\nkubernetes) but the pod is not killed.\r\n\r\n\r\nMvh / Best regards\r\n\r\nGunnar Berthelsen\r\n91545192\r\n\r\n\r\nOn Thu, Aug 10, 2023 at 4:49 PM Antonio Ojea ***@***.***>\r\nwrote:\r\n\r\n> are your processes handling the SIGTERM? your application should be\r\n> handling the signal\r\n>\r\n> /sig node\r\n>\r\n> —\r\n> Reply to this email directly, view it on GitHub\r\n> <https://github.com/kubernetes/kubernetes/issues/119884#issuecomment-1673372190>,\r\n> or unsubscribe\r\n> <https://github.com/notifications/unsubscribe-auth/ADIC3SEOQJ5R3HXTINKZ5WLXUTYGNANCNFSM6AAAAAA3LMIVK4>\r\n> .\r\n> You are receiving this because you authored the thread.Message ID:\r\n> ***@***.***>\r\n>\r\n", "created_at": "2023-08-14 07:39:17" }, { "body": "/triage needs-information\r\n\r\nWe would need podspec here to triage further to understand what's blocking the pod termination. SIGTERM is expected here. ", "created_at": "2023-08-16 17:37:27" } ]

[ { "author": "gberth", "created_at": "2023-08-10 11:55:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 11:55:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 11:55:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:37:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:37:55", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 14:48:59", "type": "labeled" }, { "author": "Magnus6803", "created_at": "2023-08-14 07:47:20", "type": "unsubscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 17:37:29", "type": "labeled" } ]

[ "jiahuif" ]

[ "kind/bug", "lgtm", "sig/api-machinery", "size/XS", "release-note-none", "approved", "cncf-cla: yes", "ok-to-test", "needs-priority", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 10 10:36:06 UTC 2023.\n", "created_at": "2023-08-10 11:37:50" }, { "body": "Hi @ls-2018. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-08-10 11:37:55" }, { "body": "/ok-to-test", "created_at": "2023-08-10 13:35:14" }, { "body": "/assign\r\n/triage accepted", "created_at": "2023-08-10 16:34:00" }, { "body": "Looks good to me, I'll let @jiahuif lgtm.", "created_at": "2023-08-10 21:50:54" }, { "body": "LGTM label has been added. <details>Git tree hash: 774b3529f9b87463f235be5c215dabb6ef8b6b24</details>", "created_at": "2023-08-15 22:47:00" }, { "body": "/retest", "created_at": "2023-08-15 22:47:00" }, { "body": "/approve", "created_at": "2023-08-15 23:29:12" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119883#\" title=\"Author self-approved\">ls-2018</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119883#issuecomment-1679757045\" title=\"Approved\">yliaog</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/client-go/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/OWNERS)~~ [yliaog]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-15 23:29:39" }, { "body": "/retest", "created_at": "2023-08-16 16:51:27" }, { "body": "/cc @apelisse @yliaog @jiahuif ", "created_at": "2023-08-18 02:08:03" }, { "body": "/release-note none", "created_at": "2023-08-18 17:36:38" }, { "body": "/release-note-none", "created_at": "2023-08-18 17:37:24" }, { "body": "Next time, please fill the release note section (when creating PR) to `NONE` or a description of user-facing changes that your PR makes.", "created_at": "2023-08-18 17:40:04" }, { "body": "ok\r\n", "created_at": "2023-08-19 02:31:28" } ]

[ { "author": "jiahuif", "created_at": "2023-08-10 11:37:47", "type": "mentioned" }, { "author": "jiahuif", "created_at": "2023-08-10 11:37:47", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 11:37:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 11:37:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 11:37:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 11:37:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 11:37:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 11:37:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 11:37:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 11:37:55", "type": "labeled" }, { "author": "ls-2018", "created_at": "2023-08-10 11:37:55", "type": "mentioned" }, { "author": "ls-2018", "created_at": "2023-08-10 11:37:55", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 11:38:26", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 11:38:26", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 11:38:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 11:38:51", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 13:35:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 13:35:17", "type": "unlabeled" }, { "author": "ls-2018", "created_at": "2023-08-10 14:00:07", "type": "mentioned" }, { "author": "ls-2018", "created_at": "2023-08-10 14:00:07", "type": "subscribed" }, { "author": "jiahuif", "created_at": "2023-08-10 16:34:02", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:34:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:34:04", "type": "unlabeled" }, { "author": "jiahuif", "created_at": "2023-08-10 21:50:54", "type": "mentioned" }, { "author": "jiahuif", "created_at": "2023-08-10 21:50:54", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 22:46:58", "type": "labeled" }, { "author": "ls-2018", "created_at": "2023-08-15 23:12:15", "type": "mentioned" }, { "author": "ls-2018", "created_at": "2023-08-15 23:12:15", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 23:29:40", "type": "labeled" }, { "author": "apelisse", "created_at": "2023-08-18 02:08:03", "type": "mentioned" }, { "author": "apelisse", "created_at": "2023-08-18 02:08:03", "type": "subscribed" }, { "author": "jiahuif", "created_at": "2023-08-18 02:08:03", "type": "mentioned" }, { "author": "jiahuif", "created_at": "2023-08-18 02:08:03", "type": "subscribed" }, { "author": "yliaog", "created_at": "2023-08-18 02:08:03", "type": "mentioned" }, { "author": "yliaog", "created_at": "2023-08-18 02:08:03", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-18 02:08:04", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-18 17:37:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-18 17:37:26", "type": "unlabeled" }, { "author": "ls-2018", "created_at": "2023-08-18 18:25:38", "type": "mentioned" }, { "author": "ls-2018", "created_at": "2023-08-18 18:25:38", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-19 00:12:09", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-19 00:12:09", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-19 00:12:09", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-19 00:12:11", "type": "milestoned" } ]

[ "SergeyKanzhelev" ]

[ "area/test", "area/kubelet", "kind/cleanup", "sig/node", "size/M", "kind/flake", "release-note-none", "cncf-cla: yes", "sig/testing", "priority/important-longterm", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 10 04:35:24 UTC 2023.\n", "created_at": "2023-08-10 10:07:10" }, { "body": "/sig node", "created_at": "2023-08-10 10:07:14" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119882#\" title=\"Author self-approved\">ffromani</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [sjenning](https://github.com/sjenning) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/OWNERS)**\n- **[test/e2e_node/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"sjenning\"]} -->", "created_at": "2023-08-10 10:07:57" }, { "body": "This PR can and should wait for the 1.28 freeze to lift", "created_at": "2023-08-10 10:18:04" }, { "body": "/triage accepted\r\n/priority important-longterm\r\n/cc", "created_at": "2023-08-11 10:18:05" }, { "body": "/assign @SergeyKanzhelev \r\n/cc @swatisehgal ", "created_at": "2023-08-16 17:22:37" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-10 10:07:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 10:07:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 10:07:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 10:07:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 10:07:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 10:07:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 10:07:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 10:07:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 10:07:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 10:07:18", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 10:07:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 10:07:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 10:07:47", "type": "labeled" }, { "author": "ffromani", "created_at": "2023-08-10 10:07:58", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 10:08:09", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 10:08:09", "type": "review_requested" }, { "author": "ffromani", "created_at": "2023-08-10 10:37:36", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-08-10 10:37:37", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-08-10 10:45:23", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-08-10 10:45:23", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-08-10 11:03:31", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-08-10 11:03:31", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-08-10 11:25:32", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:18:07", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:18:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:18:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:18:09", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:18:10", "type": "unlabeled" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-16 17:22:38", "type": "mentioned" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-16 17:22:38", "type": "subscribed" }, { "author": "swatisehgal", "created_at": "2023-08-16 17:22:38", "type": "mentioned" }, { "author": "swatisehgal", "created_at": "2023-08-16 17:22:38", "type": "subscribed" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-16 17:22:39", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 17:22:39", "type": "review_requested" }, { "author": "ffromani", "created_at": "2023-08-22 09:12:46", "type": "head_ref_force_pushed" } ]

[]

[ "priority/awaiting-more-evidence", "sig/apps", "sig/architecture", "needs-kind", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 09:05:52" }, { "body": "/sig apps architecture\r\n", "created_at": "2023-08-14 16:16:10" }, { "body": "/remove-kind bug\r\n\r\nI don't think we have enough evidence to confirm that this is a bug.\r\n/priority awaiting-more-evidence", "created_at": "2023-08-14 16:46:01" }, { "body": "@vuravenkatachaitanya \r\nPlease allow me one silly question...\r\nHave you checked if there is no ressource / object existing in the namespace which has some finalizers configured which should be processed by pods which had been running in this namspace itself ?\r\nWhen deleting the namespace the pods which should process the finalizers are probably already gone .. and so the namespace deletion simply waits for a finalizer which never will get processed", "created_at": "2023-08-16 05:48:28" }, { "body": "Fixed issue by following this blog :[[Kubectl: Force Delete Namespace Stuck In Terminating - ShellHacks](https://www.shellhacks.com/kubectl-force-delete-namespace-stuck-in-terminating/)](https://www.shellhacks.com/kubectl-force-delete-namespace-stuck-in-terminating/)", "created_at": "2023-08-16 14:09:05" }, { "body": "Even force delete did not work and command got hung for days. Only fixed when did the above fix.", "created_at": "2023-08-16 14:25:42" } ]

[ { "author": "vuravenkatachaitanya", "created_at": "2023-08-10 09:05:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 09:05:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 09:05:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:16:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:16:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:16:13", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:46:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:46:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:46:04", "type": "unlabeled" }, { "author": "vuravenkatachaitanya", "created_at": "2023-08-16 05:48:28", "type": "mentioned" }, { "author": "vuravenkatachaitanya", "created_at": "2023-08-16 05:48:28", "type": "subscribed" } ]

[ "mrunalp", "derekwaynecarr", "dchen1107", "SergeyKanzhelev", "bart0sh" ]

[ "area/test", "kind/cleanup", "lgtm", "sig/node", "size/S", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "priority/important-longterm", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Aug 10 04:35:24 UTC 2023.\n", "created_at": "2023-08-10 07:54:34" }, { "body": "/triage accepted\r\n/priority important-longterm\r\n/lgtm\r\n/assign @mrunalp @dchen1107 @derekwaynecarr ", "created_at": "2023-08-10 08:39:03" }, { "body": "LGTM label has been added. <details>Git tree hash: 10e800482460d2d5373dd3ee0c7d882c3bcbacb5</details>", "created_at": "2023-08-10 08:39:11" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119880#\" title=\"Author self-approved\">saschagrunert</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119880#pullrequestreview-1581104863\" title=\"Approved\">SergeyKanzhelev</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e/node/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/node/OWNERS)~~ [SergeyKanzhelev]\n- ~~[test/e2e_node/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/OWNERS)~~ [SergeyKanzhelev]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-16 17:25:04" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-10 07:54:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 07:54:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 07:54:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 07:54:36", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 07:54:36", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 07:54:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 07:54:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 07:54:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 07:54:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 07:54:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 07:54:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 07:54:39", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 07:54:40", "type": "labeled" }, { "author": "mrunalp", "created_at": "2023-08-10 08:39:04", "type": "mentioned" }, { "author": "mrunalp", "created_at": "2023-08-10 08:39:04", "type": "subscribed" }, { "author": "derekwaynecarr", "created_at": "2023-08-10 08:39:04", "type": "mentioned" }, { "author": "derekwaynecarr", "created_at": "2023-08-10 08:39:04", "type": "subscribed" }, { "author": "dchen1107", "created_at": "2023-08-10 08:39:04", "type": "mentioned" }, { "author": "dchen1107", "created_at": "2023-08-10 08:39:05", "type": "subscribed" }, { "author": "dchen1107", "created_at": "2023-08-10 08:39:05", "type": "assigned" }, { "author": "derekwaynecarr", "created_at": "2023-08-10 08:39:06", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:39:06", "type": "labeled" }, { "author": "mrunalp", "created_at": "2023-08-10 08:39:06", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:39:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:39:08", "type": "unlabeled" }, { "author": "bart0sh", "created_at": "2023-08-10 08:39:09", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:39:09", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:39:10", "type": "labeled" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-16 17:24:42", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 17:25:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 19:43:55", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 19:43:55", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 19:43:55", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 19:43:57", "type": "milestoned" }, { "author": "saschagrunert", "created_at": "2023-08-17 07:48:08", "type": "head_ref_deleted" } ]

[ "liggitt", "wojtek-t", "shivanshu1333" ]

[ "kind/cleanup", "lgtm", "sig/api-machinery", "size/S", "release-note-none", "approved", "cncf-cla: yes", "ok-to-test", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 22:34:30 UTC 2023.\n", "created_at": "2023-08-10 03:36:54" }, { "body": "<a href=\"https://easycla.lfx.linuxfoundation.org/#/?version=2\"><img src=\"https://s3.amazonaws.com/cla-project-logo-prod/cla-signed.svg\" alt=\"CLA Signed\" align=\"left\" height=\"28\" width=\"328\" ></a><br/><br />The committers listed above are authorized under a signed CLA.<ul><li>:white_check_mark: login: togettoyou / name: Junhao Zou (509ffe2938f4ef03d649c5de9970f8c961e4fbb7)</li></ul>", "created_at": "2023-08-10 03:36:56" }, { "body": "Welcome @togettoyou! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:", "created_at": "2023-08-10 03:36:59" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 03:36:59" }, { "body": "Hi @togettoyou. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-08-10 03:37:00" }, { "body": "/test all", "created_at": "2023-08-10 03:53:11" }, { "body": "@togettoyou: Cannot trigger testing until a trusted user reviews the PR and leaves an `/ok-to-test` message.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119879#issuecomment-1672512962):\n\n>/test all\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 03:53:25" }, { "body": "Hi, @justinsb and @caesarxuchao, could you please assist me with reviewing?", "created_at": "2023-08-13 01:19:10" }, { "body": "/ok-to-test", "created_at": "2023-08-14 06:52:17" }, { "body": "/lgtm", "created_at": "2023-08-14 06:56:52" }, { "body": "LGTM label has been added. <details>Git tree hash: 44dcaa63f44e26395fe206bda8ddbde5426a2948</details>", "created_at": "2023-08-14 06:56:59" }, { "body": "/retest", "created_at": "2023-08-14 08:01:52" }, { "body": "/approve", "created_at": "2023-08-14 09:56:36" }, { "body": "/assign @wojtek-t for approval", "created_at": "2023-08-14 09:57:43" }, { "body": "@shivanshu1333: GitHub didn't allow me to assign the following users: for, approval.\n\nNote that only [kubernetes members](https://github.com/orgs/kubernetes/people) with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.\nFor more information please see [the contributor guide](https://git.k8s.io/community/contributors/guide/first-contribution.md#issue-assignment-in-github)\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119879#issuecomment-1677031781):\n\n>/assign @wojtek-t for approval\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-14 09:57:46" }, { "body": "ping @deads2k @smarterclayton @wojtek-t @liggitt for approval", "created_at": "2023-08-23 06:04:34" }, { "body": "/lgtm\r\n/approve\r\n/sig api-machinery", "created_at": "2023-08-23 13:42:54" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119879#issuecomment-1689990897\" title=\"Approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119879#issuecomment-1677030343\" title=\"Approved\">shivanshu1333</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119879#\" title=\"Author self-approved\">togettoyou</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/registry/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/registry/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-23 13:43:02" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-10 03:36:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 03:36:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 03:36:53", "type": "labeled" }, { "author": "togettoyou", "created_at": "2023-08-10 03:36:56", "type": "mentioned" }, { "author": "togettoyou", "created_at": "2023-08-10 03:36:56", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 03:36:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 03:36:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 03:36:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 03:36:59", "type": "labeled" }, { "author": "togettoyou", "created_at": "2023-08-10 03:36:59", "type": "mentioned" }, { "author": "togettoyou", "created_at": "2023-08-10 03:36:59", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 03:37:00", "type": "labeled" }, { "author": "togettoyou", "created_at": "2023-08-10 03:37:00", "type": "mentioned" }, { "author": "togettoyou", "created_at": "2023-08-10 03:37:00", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 03:41:33", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 03:41:33", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 03:42:56", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 03:42:57", "type": "labeled" }, { "author": "togettoyou", "created_at": "2023-08-10 03:53:25", "type": "mentioned" }, { "author": "togettoyou", "created_at": "2023-08-10 03:53:25", "type": "subscribed" }, { "author": "togettoyou", "created_at": "2023-08-10 07:02:02", "type": "head_ref_force_pushed" }, { "author": "justinsb", "created_at": "2023-08-13 01:19:10", "type": "mentioned" }, { "author": "justinsb", "created_at": "2023-08-13 01:19:10", "type": "subscribed" }, { "author": "caesarxuchao", "created_at": "2023-08-13 01:19:10", "type": "mentioned" }, { "author": "caesarxuchao", "created_at": "2023-08-13 01:19:10", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 06:52:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 06:52:21", "type": "unlabeled" }, { "author": "shivanshu1333", "created_at": "2023-08-14 06:56:57", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 06:56:58", "type": "labeled" }, { "author": "togettoyou", "created_at": "2023-08-14 07:31:21", "type": "mentioned" }, { "author": "togettoyou", "created_at": "2023-08-14 07:31:21", "type": "subscribed" }, { "author": "togettoyou", "created_at": "2023-08-14 07:35:45", "type": "mentioned" }, { "author": "togettoyou", "created_at": "2023-08-14 07:35:45", "type": "subscribed" }, { "author": "togettoyou", "created_at": "2023-08-14 08:30:24", "type": "review_requested" }, { "author": "wojtek-t", "created_at": "2023-08-14 09:57:44", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-08-14 09:57:44", "type": "subscribed" }, { "author": "wojtek-t", "created_at": "2023-08-14 09:57:45", "type": "assigned" }, { "author": "wojtek-t", "created_at": "2023-08-14 09:57:46", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-08-14 09:57:47", "type": "subscribed" }, { "author": "shivanshu1333", "created_at": "2023-08-14 09:57:47", "type": "mentioned" }, { "author": "shivanshu1333", "created_at": "2023-08-14 09:57:47", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-23 06:04:34", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-23 06:04:34", "type": "subscribed" }, { "author": "smarterclayton", "created_at": "2023-08-23 06:04:34", "type": "mentioned" }, { "author": "smarterclayton", "created_at": "2023-08-23 06:04:35", "type": "subscribed" }, { "author": "deads2k", "created_at": "2023-08-23 06:04:35", "type": "mentioned" }, { "author": "deads2k", "created_at": "2023-08-23 06:04:35", "type": "subscribed" }, { "author": "wojtek-t", "created_at": "2023-08-23 06:04:35", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-08-23 06:04:35", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 13:42:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 13:42:58", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-23 13:42:59", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 13:43:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 15:07:30", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 15:07:30", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 15:07:30", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 15:07:32", "type": "milestoned" } ]

[ "enj" ]

[ "area/apiserver", "lgtm", "sig/api-machinery", "release-note", "size/L", "kind/feature", "sig/auth", "approved", "cncf-cla: yes", "needs-priority", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 22:34:30 UTC 2023.\n", "created_at": "2023-08-10 01:01:23" }, { "body": "/sig auth\r\n/triage accepted\r\n/assign @enj\r\n/unassign liggitt smarterclayton", "created_at": "2023-08-10 04:53:38" }, { "body": "/retest", "created_at": "2023-08-10 04:54:04" }, { "body": "@enj I have addressed all your comments, PTAL. Thanks!", "created_at": "2023-08-18 16:38:06" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-18 22:44:16" }, { "body": "LGTM label has been added. <details>Git tree hash: 03cd1f48502220bbbc526e458764eb683eef7d74</details>", "created_at": "2023-08-18 22:44:22" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119878#issuecomment-1684504866\" title=\"Approved\">enj</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119878#\" title=\"Author self-approved\">ritazh</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/apiserver/pkg/storage/value/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/storage/value/OWNERS)~~ [enj]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-18 22:44:23" }, { "body": "/retest", "created_at": "2023-08-18 23:20:55" }, { "body": "@ritazh: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-e2e-gce | 3cbecf218dfea2e99ae95310ac03406d1d87a072 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119878/pull-kubernetes-e2e-gce/1692692695710961664/) | unknown | `/test pull-kubernetes-e2e-gce`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119878). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Aritazh). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-08-19 01:13:07" }, { "body": "/retest", "created_at": "2023-08-19 01:14:17" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-10 01:01:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 01:01:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 01:01:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 01:01:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 01:01:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 01:01:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 01:01:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 01:02:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 01:02:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 01:02:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 01:02:06", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 01:02:15", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 01:02:15", "type": "review_requested" }, { "author": "ritazh", "created_at": "2023-08-10 01:32:16", "type": "mentioned" }, { "author": "ritazh", "created_at": "2023-08-10 01:32:16", "type": "subscribed" }, { "author": "enj", "created_at": "2023-08-10 04:53:38", "type": "mentioned" }, { "author": "enj", "created_at": "2023-08-10 04:53:39", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 04:53:40", "type": "labeled" }, { "author": "enj", "created_at": "2023-08-10 04:53:40", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 04:53:42", "type": "unlabeled" }, { "author": "ritazh", "created_at": "2023-08-16 17:29:34", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 17:29:36", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 17:29:37", "type": "labeled" }, { "author": "ritazh", "created_at": "2023-08-16 17:59:03", "type": "mentioned" }, { "author": "ritazh", "created_at": "2023-08-16 17:59:03", "type": "subscribed" }, { "author": "ritazh", "created_at": "2023-08-16 18:28:05", "type": "mentioned" }, { "author": "ritazh", "created_at": "2023-08-16 18:28:06", "type": "subscribed" }, { "author": "enj", "created_at": "2023-08-18 16:38:07", "type": "mentioned" }, { "author": "enj", "created_at": "2023-08-18 16:38:07", "type": "subscribed" }, { "author": "ritazh", "created_at": "2023-08-18 17:06:04", "type": "mentioned" }, { "author": "ritazh", "created_at": "2023-08-18 17:06:04", "type": "subscribed" }, { "author": "ritazh", "created_at": "2023-08-18 22:35:58", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-18 22:44:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-18 22:44:24", "type": "labeled" }, { "author": "ritazh", "created_at": "2023-08-18 23:04:25", "type": "mentioned" }, { "author": "ritazh", "created_at": "2023-08-18 23:04:25", "type": "subscribed" }, { "author": "ritazh", "created_at": "2023-08-19 01:13:07", "type": "mentioned" }, { "author": "ritazh", "created_at": "2023-08-19 01:13:08", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-19 01:19:21", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-19 01:19:21", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-19 01:19:21", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-19 01:19:22", "type": "milestoned" }, { "author": "ritazh", "created_at": "2023-08-21 04:05:37", "type": "head_ref_deleted" } ]

[ "kannon92", "thockin" ]

[ "kind/cleanup", "lgtm", "size/L", "release-note-none", "sig/apps", "cncf-cla: yes", "ok-to-test", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 22:34:30 UTC 2023.\n", "created_at": "2023-08-10 00:02:09" }, { "body": "<a href=\"https://easycla.lfx.linuxfoundation.org/#/?version=2\"><img src=\"https://s3.amazonaws.com/cla-project-logo-prod/cla-signed.svg\" alt=\"CLA Signed\" align=\"left\" height=\"28\" width=\"328\" ></a><br/><br />The committers listed above are authorized under a signed CLA.<ul><li>:white_check_mark: login: dejanzele / name: Dejan Zele Pejchev (c5464a292e37b52af0902af3925862dc9ec68021, c023b428bb0a16096bf0439e16f4e1e154e6a22d)</li></ul>", "created_at": "2023-08-10 00:02:10" }, { "body": "Welcome @dejanzele! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:", "created_at": "2023-08-10 00:02:13" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 00:02:14" }, { "body": "Hi @dejanzele. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-08-10 00:02:14" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119877#\" title=\"Author self-approved\">dejanzele</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [wojtek-t](https://github.com/wojtek-t) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/registry/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/registry/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"wojtek-t\"]} -->", "created_at": "2023-08-10 00:02:40" }, { "body": "/retest\r\n/cc @thockin ", "created_at": "2023-08-10 10:51:33" }, { "body": "LGTM label has been added. <details>Git tree hash: fb084c55d53cd7808903bc037af04cce5b48d92d</details>", "created_at": "2023-08-22 19:18:14" } ]

[ { "author": "thockin", "created_at": "2023-08-10 00:02:06", "type": "mentioned" }, { "author": "thockin", "created_at": "2023-08-10 00:02:06", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 00:02:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 00:02:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 00:02:08", "type": "labeled" }, { "author": "dejanzele", "created_at": "2023-08-10 00:02:11", "type": "mentioned" }, { "author": "dejanzele", "created_at": "2023-08-10 00:02:11", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 00:02:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 00:02:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 00:02:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 00:02:13", "type": "labeled" }, { "author": "dejanzele", "created_at": "2023-08-10 00:02:14", "type": "mentioned" }, { "author": "dejanzele", "created_at": "2023-08-10 00:02:14", "type": "subscribed" }, { "author": "dejanzele", "created_at": "2023-08-10 00:02:15", "type": "mentioned" }, { "author": "dejanzele", "created_at": "2023-08-10 00:02:15", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 00:02:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 00:02:53", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 00:02:54", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 00:06:02", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 00:06:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 02:00:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 02:00:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 02:00:29", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 02:00:30", "type": "unlabeled" }, { "author": "dejanzele", "created_at": "2023-08-10 02:25:06", "type": "mentioned" }, { "author": "dejanzele", "created_at": "2023-08-10 02:25:06", "type": "subscribed" }, { "author": "thockin", "created_at": "2023-08-10 10:51:33", "type": "mentioned" }, { "author": "thockin", "created_at": "2023-08-10 10:51:33", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 10:51:34", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 14:28:05", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 14:28:05", "type": "labeled" }, { "author": "thockin", "created_at": "2023-08-22 19:18:08", "type": "assigned" }, { "author": "kannon92", "created_at": "2023-08-22 19:18:12", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 19:18:13", "type": "labeled" } ]

[ "dims", "aojea" ]

[ "area/test", "sig/network", "kind/cleanup", "area/kube-proxy", "lgtm", "area/cloudprovider", "sig/api-machinery", "size/XXL", "kind/api-change", "release-note-none", "sig/apps", "approved", "cncf-cla: yes", "sig/testing", "sig/release", "area/code-generation", "area/ipvs", "sig/cloud-provider", "needs-priority", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 22:34:30 UTC 2023.\n", "created_at": "2023-08-09 22:57:01" }, { "body": "/milestone v1.28", "created_at": "2023-08-09 22:57:58" }, { "body": "/cc @RyanAoh ", "created_at": "2023-08-09 22:59:09" }, { "body": "/approve\r\n/lgtm", "created_at": "2023-08-09 23:13:43" }, { "body": "LGTM label has been added. <details>Git tree hash: 66fd8a51120d24c2811cd8f9982691ae247f656b</details>", "created_at": "2023-08-09 23:13:50" }, { "body": "/lgtm\r\n\r\nfor sig network", "created_at": "2023-08-09 23:15:46" }, { "body": "/approve\r\nfor sig api-machinery", "created_at": "2023-08-09 23:20:49" }, { "body": "/test pull-kubernetes-unit ", "created_at": "2023-08-10 01:00:54" }, { "body": "/approve\r\n/retest\r\n", "created_at": "2023-08-10 01:46:43" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119876#issuecomment-1672299999\" title=\"LGTM\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119876#issuecomment-1672305022\" title=\"Approved\">jpbetz</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119876#issuecomment-1672417082\" title=\"Approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119876#\" title=\"Author self-approved\">marosset</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/api/OWNERS)~~ [liggitt]\n- ~~[pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/OWNERS)~~ [liggitt]\n- ~~[pkg/features/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/features/OWNERS)~~ [dims,jpbetz,liggitt,marosset]\n- ~~[pkg/generated/openapi/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/generated/openapi/OWNERS)~~ [dims,liggitt]\n- ~~[pkg/proxy/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/proxy/OWNERS)~~ [dims,liggitt]\n- ~~[pkg/registry/core/service/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/registry/core/service/OWNERS)~~ [dims,liggitt]\n- ~~[staging/src/k8s.io/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/client-go/applyconfigurations/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/applyconfigurations/OWNERS)~~ [dims,jpbetz,liggitt]\n- ~~[staging/src/k8s.io/cloud-provider/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/cloud-provider/OWNERS)~~ [dims,liggitt]\n- ~~[test/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/OWNERS)~~ [dims,liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-10 01:47:08" }, { "body": "/triage accepted", "created_at": "2023-08-15 20:11:20" } ]

[ { "author": "jeremyrickard", "created_at": "2023-08-09 22:56:57", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-09 22:56:57", "type": "subscribed" }, { "author": "gracenng", "created_at": "2023-08-09 22:56:57", "type": "mentioned" }, { "author": "gracenng", "created_at": "2023-08-09 22:56:57", "type": "subscribed" }, { "author": "leonardpahlke", "created_at": "2023-08-09 22:56:57", "type": "mentioned" }, { "author": "leonardpahlke", "created_at": "2023-08-09 22:56:57", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:56:58", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:56:58", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:56:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:56:58", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:56:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:56:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:56:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:57:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:57:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:57:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:57:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:57:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:57:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:57:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:57:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:57:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:57:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:57:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:57:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:57:42", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:57:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:58:00", "type": "milestoned" }, { "author": "RyanAoh", "created_at": "2023-08-09 22:59:09", "type": "mentioned" }, { "author": "RyanAoh", "created_at": "2023-08-09 22:59:09", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:59:10", "type": "review_requested" }, { "author": "dims", "created_at": "2023-08-09 23:13:48", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 23:13:49", "type": "labeled" }, { "author": "aojea", "created_at": "2023-08-09 23:15:51", "type": "assigned" }, { "author": "marosset", "created_at": "2023-08-09 23:43:56", "type": "mentioned" }, { "author": "marosset", "created_at": "2023-08-09 23:43:56", "type": "subscribed" }, { "author": "marosset", "created_at": "2023-08-10 01:37:12", "type": "mentioned" }, { "author": "marosset", "created_at": "2023-08-10 01:37:12", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 01:47:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 02:27:31", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 02:27:31", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 02:27:31", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 20:42:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 20:56:37", "type": "unlabeled" } ]

[ "saschagrunert", "liggitt", "cpanato", "nikhita" ]

[ "lgtm", "size/M", "kind/feature", "area/release-eng", "release-note-none", "approved", "cncf-cla: yes", "sig/release", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 16:32:55 UTC 2023.\n", "created_at": "2023-08-09 22:09:56" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 22:10:01" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-09 22:10:56" }, { "body": "LGTM label has been added. <details>Git tree hash: a1426bc2f637c4c4f6c3e4502114684f16d7cd54</details>", "created_at": "2023-08-09 22:11:02" }, { "body": "/retest-required", "created_at": "2023-08-09 23:09:20" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119875#\" title=\"Author self-approved\">jeremyrickard</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119875#issuecomment-1672229464\" title=\"Approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119875#pullrequestreview-1570919269\" title=\"Approved\">nikhita</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/publishing/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/publishing/OWNERS)~~ [liggitt,nikhita]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-10 02:45:12" }, { "body": "/retest", "created_at": "2023-08-10 03:40:26" }, { "body": "/milestone v1.28", "created_at": "2023-08-23 15:47:37" }, { "body": "/hold cancel", "created_at": "2023-08-23 15:48:31" } ]

[ { "author": "saschagrunert", "created_at": "2023-08-09 22:09:53", "type": "mentioned" }, { "author": "saschagrunert", "created_at": "2023-08-09 22:09:53", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-09 22:09:53", "type": "mentioned" }, { "author": "cpanato", "created_at": "2023-08-09 22:09:53", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-09 22:09:54", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 22:09:54", "type": "subscribed" }, { "author": "nikhita", "created_at": "2023-08-09 22:09:54", "type": "mentioned" }, { "author": "nikhita", "created_at": "2023-08-09 22:09:54", "type": "subscribed" }, { "author": "justaugustus", "created_at": "2023-08-09 22:09:54", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:09:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:09:54", "type": "labeled" }, { "author": "saschagrunert", "created_at": "2023-08-09 22:09:54", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-09 22:09:54", "type": "assigned" }, { "author": "salaxander", "created_at": "2023-08-09 22:09:54", "type": "subscribed" }, { "author": "cici37", "created_at": "2023-08-09 22:09:54", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:09:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:09:54", "type": "labeled" }, { "author": "Verolop", "created_at": "2023-08-09 22:09:54", "type": "subscribed" }, { "author": "palnabarun", "created_at": "2023-08-09 22:09:54", "type": "subscribed" }, { "author": "ameukam", "created_at": "2023-08-09 22:09:55", "type": "subscribed" }, { "author": "xmudrii", "created_at": "2023-08-09 22:09:55", "type": "subscribed" }, { "author": "ramrodo", "created_at": "2023-08-09 22:09:55", "type": "subscribed" }, { "author": "k8s-release-robot", "created_at": "2023-08-09 22:09:55", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-09 22:09:55", "type": "assigned" }, { "author": "puerco", "created_at": "2023-08-09 22:09:55", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-09 22:09:55", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-09 22:09:55", "type": "subscribed" }, { "author": "gracenng", "created_at": "2023-08-09 22:09:55", "type": "subscribed" }, { "author": "jimangel", "created_at": "2023-08-09 22:09:55", "type": "subscribed" }, { "author": "nikhita", "created_at": "2023-08-09 22:09:55", "type": "assigned" }, { "author": "jrsapi", "created_at": "2023-08-09 22:09:55", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-09 22:09:55", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:09:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:09:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:10:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:10:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:10:35", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:10:35", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:10:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:10:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:10:37", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:11:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:11:19", "type": "labeled" }, { "author": "jeremyrickard", "created_at": "2023-08-09 22:45:22", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-09 22:45:23", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-09 22:52:02", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-09 22:52:02", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-09 23:09:29", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-09 23:09:29", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-09 23:47:41", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-09 23:47:41", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-10 03:19:04", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-10 03:19:05", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-10 03:39:37", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-10 03:39:37", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 15:48:03", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 15:50:46", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 17:39:40", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 17:39:40", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 17:39:41", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 17:39:42", "type": "demilestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 17:39:42", "type": "milestoned" } ]

[ "alculquicondor", "atiratree" ]

[ "kind/cleanup", "lgtm", "size/S", "release-note-none", "sig/apps", "approved", "cncf-cla: yes", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 16:32:55 UTC 2023.\n", "created_at": "2023-08-09 20:35:22" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 20:35:27" }, { "body": "/assign @atiratree ", "created_at": "2023-08-09 20:35:34" }, { "body": "/retest", "created_at": "2023-08-10 11:49:44" }, { "body": "thx!\r\n/lgtm", "created_at": "2023-08-10 18:02:46" }, { "body": "LGTM label has been added. <details>Git tree hash: c7ceeaa22d311edc1540857ebf6f5994d22278b0</details>", "created_at": "2023-08-10 18:15:01" }, { "body": "/assign @alculquicondor \r\nFor the job controller code.\r\n\r\nnot sure who to ask for apis changes?", "created_at": "2023-08-17 12:15:21" }, { "body": "/approve\r\n\r\nI see @liggitt was already requested for review. Let's wait.", "created_at": "2023-08-17 13:40:46" }, { "body": "/lgtm", "created_at": "2023-08-17 13:40:54" }, { "body": "/approve", "created_at": "2023-08-17 13:44:41" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119874#issuecomment-1682307964\" title=\"Approved\">alculquicondor</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119874#\" title=\"Author self-approved\">kannon92</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119874#issuecomment-1682314766\" title=\"Approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/OWNERS)~~ [liggitt]\n- ~~[pkg/controller/job/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/job/OWNERS)~~ [alculquicondor,liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-17 13:45:02" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:35:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:35:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:35:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:35:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:35:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:35:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:35:28", "type": "labeled" }, { "author": "atiratree", "created_at": "2023-08-09 20:35:35", "type": "mentioned" }, { "author": "atiratree", "created_at": "2023-08-09 20:35:35", "type": "subscribed" }, { "author": "atiratree", "created_at": "2023-08-09 20:35:36", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:36:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:36:11", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:36:22", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:36:22", "type": "review_requested" }, { "author": "kannon92", "created_at": "2023-08-09 21:36:16", "type": "mentioned" }, { "author": "kannon92", "created_at": "2023-08-09 21:36:16", "type": "subscribed" }, { "author": "toVersus", "created_at": "2023-08-10 00:07:36", "type": "unsubscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 18:14:59", "type": "labeled" }, { "author": "alculquicondor", "created_at": "2023-08-17 12:15:22", "type": "mentioned" }, { "author": "alculquicondor", "created_at": "2023-08-17 12:15:22", "type": "subscribed" }, { "author": "alculquicondor", "created_at": "2023-08-17 12:15:23", "type": "assigned" }, { "author": "liggitt", "created_at": "2023-08-17 13:40:46", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-17 13:40:46", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 13:45:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 18:21:34", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 18:21:34", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 18:21:34", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 18:21:36", "type": "milestoned" } ]

[]

[ "area/test", "sig/network", "area/kubelet", "sig/scalability", "sig/scheduling", "area/kube-proxy", "area/apiserver", "area/kubectl", "area/cloudprovider", "area/provider/gcp", "sig/storage", "sig/node", "sig/api-machinery", "sig/cluster-lifecycle", "sig/autoscaling", "needs-rebase", "size/XXL", "kind/api-change", "sig/contributor-experience", "area/release-eng", "sig/auth", "sig/apps", "sig/windows", "sig/cli", "area/kubeadm", "cncf-cla: yes", "sig/instrumentation", "sig/testing", "needs-ok-to-test", "sig/release", "do-not-merge/release-note-label-needed", "area/code-generation", "area/ipvs", "sig/cloud-provider", "needs-priority", "area/dependency", "do-not-merge/contains-merge-commits", "sig/security", "triage/accepted" ]

[ { "body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 19:43:14" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 16:32:55 UTC 2023.\n", "created_at": "2023-08-09 19:43:16" }, { "body": "Hi @DeeptanshuDas. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-08-09 19:43:21" }, { "body": "Adding label `do-not-merge/contains-merge-commits` because PR contains merge commits, which are not allowed in this repository.\nUse `git rebase` to reapply your commits on top of the target branch. Detailed instructions for doing so can be found [here](https://git.k8s.io/community/contributors/guide/github-workflow.md#4-keep-your-branch-in-sync).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 19:43:29" }, { "body": "/ok to test\r\n", "created_at": "2023-08-09 20:04:48" }, { "body": "PR needs rebase.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 20:07:03" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119873#\" title=\"Author self-approved\">DeeptanshuDas</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [cblecker](https://github.com/cblecker), [liggitt](https://github.com/liggitt), [x13n](https://github.com/x13n), [xmudrii](https://github.com/xmudrii) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/kubernetes/kubernetes/blob/master/OWNERS)**\n- **[.github/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/.github/OWNERS)**\n- **[CHANGELOG/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/OWNERS)**\n- **[LICENSES/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/LICENSES/OWNERS)**\n- **[api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/api/OWNERS)**\n- **[build/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/build/OWNERS)**\n- **[cluster/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cluster/OWNERS)**\n- **[cmd/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/OWNERS)**\n- **[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/hack/OWNERS)**\n- **[pkg/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/OWNERS)**\n- **[pkg/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/api/OWNERS)**\n- **[pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/OWNERS)**\n- **[pkg/controller/apis/config/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/apis/config/OWNERS)**\n- **[pkg/kubelet/apis/config/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/config/OWNERS)**\n- **[pkg/scheduler/framework/autoscaler_contract/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/framework/autoscaler_contract/OWNERS)**\n- **[plugin/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/plugin/OWNERS)**\n- **[staging/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/OWNERS)**\n- **[staging/src/k8s.io/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/OWNERS)**\n- **[staging/src/k8s.io/apiextensions-apiserver/pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiextensions-apiserver/pkg/apis/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"cblecker\",\"liggitt\",\"x13n\",\"xmudrii\"]} -->", "created_at": "2023-08-09 20:09:07" }, { "body": "This changes nearly 2 million lines of code. Did you submit against the correct branch?", "created_at": "2023-08-10 01:26:02" }, { "body": "@DeeptanshuDas can you provide a better description for the change? Please, rebase.", "created_at": "2023-08-10 08:48:22" }, { "body": "/cc", "created_at": "2023-08-10 08:48:36" }, { "body": "Please cleanup the commits. I cannot see the intended changes clearly.", "created_at": "2023-08-10 16:35:06" }, { "body": "> Please cleanup the commits. I cannot see the intended changes clearly.\r\n\r\nI delete the recent commits hope so this will be helpful for you", "created_at": "2023-08-10 18:32:18" }, { "body": "> @DeeptanshuDas can you provide a better description for the change? Please, rebase.\r\n\r\n#119873 I change the ExpectEqual (boolean) to if (<failure check>) framework.Failf(<informative message>) form", "created_at": "2023-08-10 18:42:24" }, { "body": "> https://github.com/kubernetes/kubernetes/pull/119873 I change the ExpectEqual (boolean) to if () framework.Failf() form\r\n\r\nThis PR changes 5000+ files. I really doubt it's needed to change `ExpectEqual`.\r\n\r\nPlease, look at the changes you're proposing to merge and clean them up. Most probably you're targeting another branch or included other people changes.", "created_at": "2023-08-10 18:47:21" }, { "body": "/triage accepted", "created_at": "2023-08-15 20:11:30" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:43:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:43:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:43:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:43:18", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:43:18", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:43:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:43:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:43:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:43:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:43:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:43:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:43:21", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:43:21", "type": "labeled" }, { "author": "DeeptanshuDas", "created_at": "2023-08-09 19:43:22", "type": "mentioned" }, { "author": "DeeptanshuDas", "created_at": "2023-08-09 19:43:22", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:43:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:43:28", "type": "labeled" }, { "author": "DeeptanshuDas", "created_at": "2023-08-09 19:46:46", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:07:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:07:43", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:07:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:42", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:44", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 20:09:59", "type": "labeled" }, { "author": "DeeptanshuDas", "created_at": "2023-08-09 20:10:16", "type": "renamed" }, { "author": "DeeptanshuDas", "created_at": "2023-08-10 08:48:23", "type": "mentioned" }, { "author": "DeeptanshuDas", "created_at": "2023-08-10 08:48:23", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:48:37", "type": "review_requested" }, { "author": "DeeptanshuDas", "created_at": "2023-08-10 18:34:31", "type": "renamed" }, { "author": "DeeptanshuDas", "created_at": "2023-08-10 18:34:45", "type": "renamed" }, { "author": "DeeptanshuDas", "created_at": "2023-08-10 18:42:25", "type": "mentioned" }, { "author": "DeeptanshuDas", "created_at": "2023-08-10 18:42:25", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-11 11:08:01", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 20:33:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 20:33:21", "type": "unlabeled" } ]

[]

[ "area/kubectl", "size/M", "sig/cli", "cncf-cla: yes", "do-not-merge/release-note-label-needed", "ok-to-test", "needs-priority", "needs-triage", "do-not-merge/needs-kind" ]

[ { "body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 19:07:20" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 16:32:55 UTC 2023.\n", "created_at": "2023-08-09 19:07:22" }, { "body": "Hi @akash-kumar-saw. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-08-09 19:07:27" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 19:07:27" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119872#\" title=\"Author self-approved\">akash-kumar-saw</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [knverey](https://github.com/knverey) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"knverey\"]} -->", "created_at": "2023-08-09 19:11:37" }, { "body": "/ok-to-test", "created_at": "2023-08-14 07:00:09" }, { "body": "@akash-kumar-saw: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-node-e2e-containerd | b7b9400292a15b5dd38ca9397b9b1f026de47045 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119872/pull-kubernetes-node-e2e-containerd/1692234333072396288/) | true | `/test pull-kubernetes-node-e2e-containerd`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119872). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Aakash-kumar-saw). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-08-17 18:24:08" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:07:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:07:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:07:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:07:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:07:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:07:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:07:26", "type": "labeled" }, { "author": "akash-kumar-saw", "created_at": "2023-08-09 19:07:27", "type": "mentioned" }, { "author": "akash-kumar-saw", "created_at": "2023-08-09 19:07:27", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:07:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:11:37", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:11:37", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:11:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:11:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:11:41", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 07:00:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 07:00:11", "type": "unlabeled" }, { "author": "akash-kumar-saw", "created_at": "2023-08-14 07:36:55", "type": "mentioned" }, { "author": "akash-kumar-saw", "created_at": "2023-08-14 07:36:55", "type": "subscribed" }, { "author": "akash-kumar-saw", "created_at": "2023-08-14 18:48:50", "type": "head_ref_force_pushed" }, { "author": "akash-kumar-saw", "created_at": "2023-08-14 19:05:01", "type": "mentioned" }, { "author": "akash-kumar-saw", "created_at": "2023-08-14 19:05:02", "type": "subscribed" }, { "author": "akash-kumar-saw", "created_at": "2023-08-14 19:06:06", "type": "mentioned" }, { "author": "akash-kumar-saw", "created_at": "2023-08-14 19:06:06", "type": "subscribed" }, { "author": "akash-kumar-saw", "created_at": "2023-08-14 19:07:09", "type": "mentioned" }, { "author": "akash-kumar-saw", "created_at": "2023-08-14 19:07:09", "type": "subscribed" }, { "author": "akash-kumar-saw", "created_at": "2023-08-14 19:07:19", "type": "mentioned" }, { "author": "akash-kumar-saw", "created_at": "2023-08-14 19:07:20", "type": "subscribed" }, { "author": "akash-kumar-saw", "created_at": "2023-08-14 19:12:00", "type": "mentioned" }, { "author": "akash-kumar-saw", "created_at": "2023-08-14 19:12:00", "type": "subscribed" }, { "author": "akash-kumar-saw", "created_at": "2023-08-14 19:38:49", "type": "mentioned" }, { "author": "akash-kumar-saw", "created_at": "2023-08-14 19:38:49", "type": "subscribed" }, { "author": "akash-kumar-saw", "created_at": "2023-08-14 19:56:43", "type": "mentioned" }, { "author": "akash-kumar-saw", "created_at": "2023-08-14 19:56:43", "type": "subscribed" }, { "author": "akash-kumar-saw", "created_at": "2023-08-17 17:57:28", "type": "head_ref_force_pushed" }, { "author": "akash-kumar-saw", "created_at": "2023-08-17 18:24:09", "type": "mentioned" }, { "author": "akash-kumar-saw", "created_at": "2023-08-17 18:24:09", "type": "subscribed" } ]

[ "jpbetz" ]

[ "area/test", "area/apiserver", "lgtm", "sig/api-machinery", "size/L", "kind/api-change", "cherry-pick-approved", "approved", "cncf-cla: yes", "sig/testing", "area/code-generation", "needs-priority", "triage/accepted" ]

[ { "body": "/retest", "created_at": "2023-08-09 20:36:50" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-09 21:34:04" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119871#issuecomment-1672182951\" title=\"Approved\">jpbetz</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119871#\" title=\"Author self-approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/pkg/apis/OWNERS)~~ [liggitt]\n- ~~[pkg/generated/openapi/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/pkg/generated/openapi/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/api/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/apiserver/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/client-go/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/client-go/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/kube-aggregator/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/kube-aggregator/OWNERS)~~ [liggitt]\n- ~~[test/integration/apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/test/integration/apiserver/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-09 21:34:11" }, { "body": "LGTM label has been added. <details>Git tree hash: 3d3b7cce51d3186c5bb541c9eba5baa3d0744780</details>", "created_at": "2023-08-09 21:34:12" }, { "body": "cc @kubernetes/release-managers \r\n\r\nThis is a late-breaking addition to 1.28.0 (https://github.com/kubernetes/kubernetes/pull/119835) resolving a regression in 1.27 and fixing a client issue related to it. It would be ideal to include this in the current patch releases if possible.", "created_at": "2023-08-09 22:01:51" }, { "body": "/triage accepted", "created_at": "2023-08-15 20:11:48" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:54:31", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:54:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:54:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:54:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:54:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:54:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:54:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:54:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:59:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:00:00", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:00:00", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:00:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:00:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:00:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:00:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:00:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:00:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:00:05", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:00:06", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-09 19:01:01", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 19:01:01", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-09 19:06:16", "type": "head_ref_force_pushed" }, { "author": "liggitt", "created_at": "2023-08-09 19:14:01", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 19:14:01", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-09 19:25:14", "type": "head_ref_force_pushed" }, { "author": "liggitt", "created_at": "2023-08-09 20:03:13", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 20:03:13", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-09 21:34:09", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 21:34:11", "type": "labeled" }, { "author": "justaugustus", "created_at": "2023-08-09 22:01:52", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-09 22:01:52", "type": "subscribed" }, { "author": "Verolop", "created_at": "2023-08-09 22:01:52", "type": "subscribed" }, { "author": "puerco", "created_at": "2023-08-09 22:01:52", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-09 22:01:52", "type": "subscribed" }, { "author": "cici37", "created_at": "2023-08-09 22:01:52", "type": "subscribed" }, { "author": "palnabarun", "created_at": "2023-08-09 22:01:52", "type": "subscribed" }, { "author": "xmudrii", "created_at": "2023-08-09 22:01:52", "type": "subscribed" }, { "author": "k8s-release-robot", "created_at": "2023-08-09 22:01:53", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-09 22:01:53", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-10 14:12:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 14:12:32", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 14:13:28", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 14:13:28", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 14:13:29", "type": "closed" }, { "author": "liggitt", "created_at": "2023-08-10 15:27:30", "type": "head_ref_deleted" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 20:46:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 20:58:18", "type": "unlabeled" } ]

[ "liggitt" ]

[ "kind/bug", "sig/api-machinery", "release-note", "size/L", "cncf-cla: yes", "needs-priority", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 16:32:55 UTC 2023.\n", "created_at": "2023-08-09 18:26:29" }, { "body": "/assign @liggitt \r\n/cc @apelisse @alexzielenski ", "created_at": "2023-08-09 21:06:04" }, { "body": "/triage accepted", "created_at": "2023-08-10 16:36:26" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119870#\" title=\"Author self-approved\">Jefftree</a>*\n**Once this PR has been reviewed and has the lgtm label**, please ask for approval from [liggitt](https://github.com/liggitt). For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/client-go/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/OWNERS)**\n- **[staging/src/k8s.io/kube-aggregator/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kube-aggregator/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"liggitt\"]} -->", "created_at": "2023-08-17 17:02:10" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:26:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:26:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:26:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:26:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:26:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:26:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:26:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:27:01", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:27:01", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:27:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:27:16", "type": "unlabeled" }, { "author": "Jefftree", "created_at": "2023-08-09 18:38:20", "type": "head_ref_force_pushed" }, { "author": "Jefftree", "created_at": "2023-08-09 19:38:47", "type": "mentioned" }, { "author": "Jefftree", "created_at": "2023-08-09 19:38:47", "type": "subscribed" }, { "author": "Jefftree", "created_at": "2023-08-09 21:01:21", "type": "head_ref_force_pushed" }, { "author": "alexzielenski", "created_at": "2023-08-09 21:06:04", "type": "mentioned" }, { "author": "alexzielenski", "created_at": "2023-08-09 21:06:04", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-09 21:06:04", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 21:06:04", "type": "subscribed" }, { "author": "apelisse", "created_at": "2023-08-09 21:06:05", "type": "mentioned" }, { "author": "apelisse", "created_at": "2023-08-09 21:06:05", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-09 21:06:05", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 21:06:06", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 21:06:06", "type": "review_requested" }, { "author": "Jefftree", "created_at": "2023-08-09 21:30:14", "type": "mentioned" }, { "author": "Jefftree", "created_at": "2023-08-09 21:30:14", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:36:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:36:30", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:36:33", "type": "labeled" }, { "author": "Jefftree", "created_at": "2023-08-17 17:01:32", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 17:01:39", "type": "unlabeled" }, { "author": "Jefftree", "created_at": "2023-08-17 17:17:04", "type": "head_ref_force_pushed" }, { "author": "Jefftree", "created_at": "2023-08-17 18:08:46", "type": "mentioned" }, { "author": "Jefftree", "created_at": "2023-08-17 18:08:46", "type": "subscribed" }, { "author": "Jefftree", "created_at": "2023-08-17 18:29:22", "type": "head_ref_force_pushed" } ]

[ "jpbetz" ]

[ "area/test", "lgtm", "sig/api-machinery", "size/M", "kind/flake", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "needs-priority", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 16:32:55 UTC 2023.\n", "created_at": "2023-08-09 16:45:57" }, { "body": "Holding until we run multiple `/test all` to verify that we don't have other flaky tests\r\n/hold", "created_at": "2023-08-09 16:48:54" }, { "body": "/approve\r\n/lgtm\r\n\r\nThe disruption of the flake out weights the value added by this test. We'll ensure that the test is safely replaced in a follow up PR.", "created_at": "2023-08-09 17:45:16" }, { "body": "LGTM label has been added. <details>Git tree hash: b955e937931851e0a2f5267c24ba966ea7709776</details>", "created_at": "2023-08-09 17:45:23" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119869#\" title=\"Author self-approved\">a-hilaly</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119869#issuecomment-1671875845\" title=\"LGTM\">jpbetz</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e/apimachinery/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/apimachinery/OWNERS)~~ [jpbetz]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-09 17:45:38" }, { "body": "/priority critically-urgent", "created_at": "2023-08-09 17:45:40" }, { "body": "@jpbetz: The label(s) `priority/critically-urgent` cannot be applied, because the repository doesn't have them.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119869#issuecomment-1671876332):\n\n>/priority critically-urgent\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 17:45:43" }, { "body": "/test all", "created_at": "2023-08-09 17:46:07" }, { "body": "/test pull-kubernetes-e2e-kind\r\n/test pull-kubernetes-e2e-kind-ipv6\r\n/test pull-kubernetes-node-e2e-containerd\r\n", "created_at": "2023-08-09 18:30:57" }, { "body": "/test all", "created_at": "2023-08-09 23:12:00" }, { "body": "@kubernetes/release-managers This is a flake fix that 1.28 would benefit from. Flake is high rate so I wanted to make you aware and give you the option to either merge for 1.28.0 or wait for backport to improve branch stability post release.", "created_at": "2023-08-09 23:24:36" }, { "body": "with this patch, tests have ran more than 5XX times locally successfully.\r\n/lgtm\r\n/unhold", "created_at": "2023-08-10 00:18:45" }, { "body": "@a-hilaly: you cannot LGTM your own PR.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119869#issuecomment-1672351583):\n\n>with this patch, tests have ran more than 5XX times locally successfully.\r\n>/lgtm\r\n>/unhold\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-10 00:18:47" }, { "body": "/test all", "created_at": "2023-08-10 00:18:59" }, { "body": "/test all", "created_at": "2023-08-10 01:27:31" }, { "body": "/milestone v1.28", "created_at": "2023-08-10 02:07:00" }, { "body": "/unhold", "created_at": "2023-08-10 02:09:23" }, { "body": "/test all", "created_at": "2023-08-10 02:09:40" }, { "body": "/test all\r\n\r\n", "created_at": "2023-08-10 06:14:07" }, { "body": "/test pull-kubernetes-node-e2e-containerd", "created_at": "2023-08-10 07:33:10" }, { "body": "/triage accepted", "created_at": "2023-08-15 20:11:57" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:45:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:45:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:45:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:45:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:46:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:46:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:46:09", "type": "labeled" }, { "author": "a-hilaly", "created_at": "2023-08-09 16:46:17", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:46:39", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:46:40", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:46:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:46:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:46:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:46:55", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:48:55", "type": "labeled" }, { "author": "jpbetz", "created_at": "2023-08-09 17:45:21", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 17:45:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 17:45:39", "type": "labeled" }, { "author": "jpbetz", "created_at": "2023-08-09 17:45:44", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-09 17:45:44", "type": "subscribed" }, { "author": "a-hilaly", "created_at": "2023-08-09 18:13:17", "type": "mentioned" }, { "author": "a-hilaly", "created_at": "2023-08-09 18:13:17", "type": "subscribed" }, { "author": "justaugustus", "created_at": "2023-08-09 23:24:36", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-09 23:24:36", "type": "subscribed" }, { "author": "Verolop", "created_at": "2023-08-09 23:24:37", "type": "subscribed" }, { "author": "puerco", "created_at": "2023-08-09 23:24:37", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-09 23:24:37", "type": "subscribed" }, { "author": "cici37", "created_at": "2023-08-09 23:24:37", "type": "subscribed" }, { "author": "palnabarun", "created_at": "2023-08-09 23:24:37", "type": "subscribed" }, { "author": "xmudrii", "created_at": "2023-08-09 23:24:37", "type": "subscribed" }, { "author": "k8s-release-robot", "created_at": "2023-08-09 23:24:37", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-09 23:24:37", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 00:18:47", "type": "unlabeled" }, { "author": "a-hilaly", "created_at": "2023-08-10 00:18:47", "type": "mentioned" }, { "author": "a-hilaly", "created_at": "2023-08-10 00:18:47", "type": "subscribed" }, { "author": "a-hilaly", "created_at": "2023-08-10 01:15:46", "type": "mentioned" }, { "author": "a-hilaly", "created_at": "2023-08-10 01:15:47", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 02:07:02", "type": "milestoned" }, { "author": "a-hilaly", "created_at": "2023-08-10 02:50:16", "type": "mentioned" }, { "author": "a-hilaly", "created_at": "2023-08-10 02:50:16", "type": "subscribed" }, { "author": "a-hilaly", "created_at": "2023-08-10 03:07:51", "type": "mentioned" }, { "author": "a-hilaly", "created_at": "2023-08-10 03:07:51", "type": "subscribed" }, { "author": "a-hilaly", "created_at": "2023-08-10 06:39:49", "type": "mentioned" }, { "author": "a-hilaly", "created_at": "2023-08-10 06:39:50", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:01:28", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:01:28", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:01:28", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 20:32:42", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 20:41:12", "type": "unlabeled" } ]

[ "jpbetz" ]

[ "area/test", "area/apiserver", "lgtm", "sig/api-machinery", "size/L", "kind/api-change", "cherry-pick-approved", "approved", "cncf-cla: yes", "sig/testing", "area/code-generation", "needs-priority", "triage/accepted" ]

[ { "body": "/retest", "created_at": "2023-08-09 19:46:10" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-09 21:34:24" }, { "body": "LGTM label has been added. <details>Git tree hash: 55ec460d670882fc9adccdf2efa045ad4cfd499d</details>", "created_at": "2023-08-09 21:34:31" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119868#issuecomment-1672183331\" title=\"Approved\">jpbetz</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119868#\" title=\"Author self-approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/pkg/apis/OWNERS)~~ [liggitt]\n- ~~[pkg/generated/openapi/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/pkg/generated/openapi/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/api/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/apiserver/pkg/endpoints/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/apiserver/pkg/endpoints/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/client-go/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/client-go/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/kube-aggregator/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/kube-aggregator/OWNERS)~~ [liggitt]\n- ~~[test/integration/apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/test/integration/apiserver/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-09 21:34:48" }, { "body": "cc @kubernetes/release-managers \r\n\r\nThis is a late-breaking addition to 1.28.0 (https://github.com/kubernetes/kubernetes/pull/119835) resolving a regression in 1.27 and fixing a client issue related to it. It would be ideal to include this in the current patch releases if possible.", "created_at": "2023-08-09 22:01:48" }, { "body": "/triage accepted", "created_at": "2023-08-15 20:12:04" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:34:13", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:34:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:34:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:34:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:34:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:34:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:34:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:34:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:34:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:35:10", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:35:10", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:35:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:35:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:35:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:35:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:35:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:35:27", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:35:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:35:28", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-09 16:41:29", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 16:41:29", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-09 17:06:27", "type": "head_ref_force_pushed" }, { "author": "liggitt", "created_at": "2023-08-09 17:42:59", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 17:42:59", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-09 17:47:03", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 17:47:03", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-09 18:44:11", "type": "head_ref_force_pushed" }, { "author": "liggitt", "created_at": "2023-08-09 19:19:54", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 19:19:54", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-09 21:34:28", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 21:34:30", "type": "labeled" }, { "author": "justaugustus", "created_at": "2023-08-09 22:01:49", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-09 22:01:49", "type": "subscribed" }, { "author": "Verolop", "created_at": "2023-08-09 22:01:49", "type": "subscribed" }, { "author": "puerco", "created_at": "2023-08-09 22:01:49", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-09 22:01:49", "type": "subscribed" }, { "author": "cici37", "created_at": "2023-08-09 22:01:49", "type": "subscribed" }, { "author": "palnabarun", "created_at": "2023-08-09 22:01:49", "type": "subscribed" }, { "author": "xmudrii", "created_at": "2023-08-09 22:01:50", "type": "subscribed" }, { "author": "k8s-release-robot", "created_at": "2023-08-09 22:01:50", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-09 22:01:50", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-10 14:12:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 14:12:20", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 14:13:27", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 14:13:28", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 14:13:28", "type": "closed" }, { "author": "liggitt", "created_at": "2023-08-10 15:27:05", "type": "head_ref_deleted" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 20:41:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 20:56:06", "type": "unlabeled" } ]

[ "liggitt", "aojea" ]

[ "kind/bug", "sig/network", "area/kube-proxy", "lgtm", "release-note", "size/L", "kind/api-change", "approved", "cncf-cla: yes", "needs-priority", "kind/regression", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 10:32:39 UTC 2023.\n", "created_at": "2023-08-09 16:24:36" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 16:24:40" }, { "body": "/test pull-kubernetes-e2e-kind ", "created_at": "2023-08-10 03:42:15" }, { "body": "I did some tests based on your changes, It works well. Maybe we need some comments from aojea, as mentioned by https://github.com/kubernetes/kubernetes/issues/119864#issuecomment-1671642653.", "created_at": "2023-08-10 03:48:53" }, { "body": "@aojea @cyclinder is this PR should be labelled with v1.28 milestone? ", "created_at": "2023-08-10 08:08:21" }, { "body": "/milestone v1.28", "created_at": "2023-08-10 10:42:30" }, { "body": "@furkatgofurov7 I think yes, but need ack for @pohly @aojea ", "created_at": "2023-08-10 10:42:40" }, { "body": "confirmed this fixes the problem https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/119867/pull-kubernetes-e2e-kind/1689565949344092160/artifacts/kind-worker/pods/kube-system_kube-proxy-8grjj_b975a748-1d37-48b2-a111-80ac60f69b03/kube-proxy/0.log\r\n\r\n", "created_at": "2023-08-10 10:44:51" }, { "body": "/approve\r\n\r\none question about the code structure https://github.com/kubernetes/kubernetes/pull/119867#discussion_r1289965949, if we make flags part of the `options` struct I think it will make easier future changes , in case we no longer need to pass the flags to the `Complete` method per example\r\n\r\nI trust @cyclinder or @liggitt and the unit test for this https://github.com/kubernetes/kubernetes/pull/119867#discussion_r1289968043\r\n\r\n@pohly can you remove the WIP from the title if this is ready\r\n\r\n/assign @liggitt ", "created_at": "2023-08-10 11:17:43" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119867#issuecomment-1673029088\" title=\"Approved\">aojea</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119867#\" title=\"Author self-approved\">pohly</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[cmd/kube-proxy/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kube-proxy/OWNERS)~~ [aojea]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-10 11:18:12" }, { "body": "Also tagging relevant SIG based on the label on the PR\r\n\r\n@kubernetes/sig-network-leads ", "created_at": "2023-08-10 11:57:54" }, { "body": "> Also tagging relevant SIG based on the label on the PR\r\n> \r\n> @kubernetes/sig-network-leads\r\n\r\nI'm approving for sig-network \r\n\r\nhttps://github.com/kubernetes/kubernetes/blob/a287fd6aa6aae212a65ca415367cfccb70cd6190/OWNERS_ALIASES#L255-L259", "created_at": "2023-08-10 12:00:26" }, { "body": "/lgtm\r\n\r\nI think this is ok, the change is very contained and well covered with unit tests, and we can see also in CI is working fine", "created_at": "2023-08-10 12:23:50" }, { "body": "LGTM label has been added. <details>Git tree hash: c0b3740e5310a03e449b9dd9bd5dbc0dd45b0794</details>", "created_at": "2023-08-10 12:23:57" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:24:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:24:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:24:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:24:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:24:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:24:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:24:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:24:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:24:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:25:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:25:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:25:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:25:21", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:25:29", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:25:29", "type": "review_requested" }, { "author": "pohly", "created_at": "2023-08-09 16:59:07", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-09 16:59:07", "type": "subscribed" }, { "author": "pohly", "created_at": "2023-08-09 17:18:54", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-09 17:18:54", "type": "subscribed" }, { "author": "pohly", "created_at": "2023-08-10 04:11:46", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-10 04:11:46", "type": "subscribed" }, { "author": "pohly", "created_at": "2023-08-10 07:11:27", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 07:11:29", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 07:11:30", "type": "labeled" }, { "author": "pohly", "created_at": "2023-08-10 07:37:56", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-10 07:37:56", "type": "subscribed" }, { "author": "pohly", "created_at": "2023-08-10 08:03:45", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-10 08:03:45", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-08-10 08:08:21", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-10 08:08:21", "type": "subscribed" }, { "author": "cyclinder", "created_at": "2023-08-10 08:08:22", "type": "mentioned" }, { "author": "cyclinder", "created_at": "2023-08-10 08:08:22", "type": "subscribed" }, { "author": "pohly", "created_at": "2023-08-10 08:11:28", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-10 08:11:28", "type": "subscribed" }, { "author": "pohly", "created_at": "2023-08-10 09:14:21", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 10:42:32", "type": "milestoned" }, { "author": "pohly", "created_at": "2023-08-10 10:42:40", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-10 10:42:40", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-08-10 10:42:40", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-10 10:42:40", "type": "subscribed" }, { "author": "furkatgofurov7", "created_at": "2023-08-10 10:42:40", "type": "mentioned" }, { "author": "furkatgofurov7", "created_at": "2023-08-10 10:42:41", "type": "subscribed" }, { "author": "pohly", "created_at": "2023-08-10 11:17:43", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-10 11:17:43", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-10 11:17:43", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-10 11:17:44", "type": "subscribed" }, { "author": "cyclinder", "created_at": "2023-08-10 11:17:44", "type": "mentioned" }, { "author": "cyclinder", "created_at": "2023-08-10 11:17:44", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-10 11:17:45", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 11:18:13", "type": "labeled" }, { "author": "pohly", "created_at": "2023-08-10 11:22:27", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 11:22:28", "type": "unlabeled" }, { "author": "shaneutt", "created_at": "2023-08-10 11:57:55", "type": "subscribed" }, { "author": "thockin", "created_at": "2023-08-10 11:57:55", "type": "subscribed" }, { "author": "MikeZappa87", "created_at": "2023-08-10 11:57:55", "type": "subscribed" }, { "author": "shaneutt", "created_at": "2023-08-10 12:00:27", "type": "subscribed" }, { "author": "thockin", "created_at": "2023-08-10 12:00:27", "type": "subscribed" }, { "author": "MikeZappa87", "created_at": "2023-08-10 12:00:27", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-08-10 12:23:55", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:23:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:25:27", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:25:27", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:25:27", "type": "closed" } ]

[ "kwakubiney" ]

[ "sig/scheduling", "kind/feature", "triage/accepted" ]

[ { "body": "/triage accepted", "created_at": "2023-08-09 16:17:29" }, { "body": "Can I pick this up?", "created_at": "2023-08-09 17:13:53" }, { "body": "Yes, just type `/assign`.\r\n\r\nNote that we are in code freeze, so this won't be merged until about a month from now.", "created_at": "2023-08-09 17:16:37" }, { "body": "/assign", "created_at": "2023-08-09 17:18:53" }, { "body": "PII? I know that as personally identifying information (ie, data about humans).", "created_at": "2023-08-14 16:44:21" }, { "body": "BTW, ideally we'd also document the change.", "created_at": "2023-08-14 16:45:03" }, { "body": "> PII? I know that as personally identifying information (ie, data about humans).\r\n\r\nIn a multi-tenant environment, pod names could be sensitive information.", "created_at": "2023-08-14 16:58:55" } ]

[ { "author": "alculquicondor", "created_at": "2023-08-09 16:17:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:17:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:17:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:17:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:17:33", "type": "unlabeled" }, { "author": "kwakubiney", "created_at": "2023-08-09 17:18:55", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-21 11:13:24", "type": "closed" } ]

[ "dims" ]

[ "kind/bug", "sig/network", "area/kube-proxy", "area/apiserver", "area/kubectl", "area/cloudprovider", "sig/node", "sig/api-machinery", "size/M", "release-note-none", "sig/auth", "sig/cli", "cncf-cla: yes", "sig/instrumentation", "sig/architecture", "area/code-generation", "sig/cloud-provider", "needs-priority", "area/dependency", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 10:32:39 UTC 2023.\n", "created_at": "2023-08-09 15:34:31" }, { "body": "/retest-required", "created_at": "2023-08-10 13:59:36" }, { "body": "The upgrade may not be trivial. Please check codegen, etc, or try to run `make update` one more time.\r\n\r\n/assign @dims", "created_at": "2023-08-10 16:38:34" }, { "body": "/cc", "created_at": "2023-08-11 10:27:28" }, { "body": "/close\r\n\r\nThis is a duplicate of https://github.com/kubernetes/kubernetes/pull/115067, which is failing tests due to path normalization changes made in the library in 3.10.2.", "created_at": "2023-08-11 14:22:48" }, { "body": "@liggitt: Closed this PR.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119865#issuecomment-1674875817):\n\n>/close\r\n>\r\n>This is a duplicate of https://github.com/kubernetes/kubernetes/pull/115067, which is failing tests due to path normalization changes made in the library in 3.10.2.\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-11 14:22:55" }, { "body": "/reopen\r\n\r\nactually, we can make this the current 3.10.2 bump PR, since the other one needs rebase, but the test failures due to the incompatible go-restful path parsing behavior still have to be resolved (likely by undoing the path processing change made to fix the go-restful security issue, see the `TrimPathStrategy` in https://github.com/emicklei/go-restful/blob/v3/README.md#how-to-customize)", "created_at": "2023-08-11 14:27:53" }, { "body": "@liggitt: Reopened this PR.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119865#issuecomment-1674885765):\n\n>/reopen\r\n>\r\n>actually, we can make this the current 3.10.2 bump PR, since the other one needs rebase, but the test failures due to the incompatible go-restful path parsing behavior still have to be resolved (likely by undoing the path processing change made to fix the go-restful security issue, see the `TrimPathStrategy` in https://github.com/emicklei/go-restful/blob/v3/README.md#how-to-customize)\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-11 14:27:59" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Aug 11 10:38:14 UTC 2023.\n", "created_at": "2023-08-11 14:28:02" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119865#\" title=\"Author self-approved\">charles-chenzz</a>*\n**Once this PR has been reviewed and has the lgtm label**, please ask for approval from [dims](https://github.com/dims). For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/kubernetes/kubernetes/blob/master/OWNERS)**\n- **[staging/src/k8s.io/apiextensions-apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiextensions-apiserver/OWNERS)**\n- **[staging/src/k8s.io/apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/OWNERS)**\n- **[staging/src/k8s.io/cli-runtime/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/cli-runtime/OWNERS)**\n- **[staging/src/k8s.io/client-go/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/OWNERS)**\n- **[staging/src/k8s.io/cloud-provider/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/cloud-provider/OWNERS)**\n- **[staging/src/k8s.io/code-generator/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/code-generator/OWNERS)**\n- **[staging/src/k8s.io/component-base/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/component-base/OWNERS)**\n- **[staging/src/k8s.io/component-helpers/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/component-helpers/OWNERS)**\n- **[staging/src/k8s.io/controller-manager/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/controller-manager/OWNERS)**\n- **[staging/src/k8s.io/dynamic-resource-allocation/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/dynamic-resource-allocation/OWNERS)**\n- **[staging/src/k8s.io/endpointslice/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/endpointslice/OWNERS)**\n- **[staging/src/k8s.io/kms/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kms/OWNERS)**\n- **[staging/src/k8s.io/kube-aggregator/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kube-aggregator/OWNERS)**\n- **[staging/src/k8s.io/kube-controller-manager/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kube-controller-manager/OWNERS)**\n- **[staging/src/k8s.io/kube-proxy/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kube-proxy/OWNERS)**\n- **[staging/src/k8s.io/kube-scheduler/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kube-scheduler/OWNERS)**\n- **[staging/src/k8s.io/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/OWNERS)**\n- **[staging/src/k8s.io/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubelet/OWNERS)**\n- **[staging/src/k8s.io/legacy-cloud-providers/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/legacy-cloud-providers/OWNERS)**\n- **[staging/src/k8s.io/metrics/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/metrics/OWNERS)**\n- **[staging/src/k8s.io/pod-security-admission/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/pod-security-admission/OWNERS)**\n- **[staging/src/k8s.io/sample-apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/sample-apiserver/OWNERS)**\n- **[staging/src/k8s.io/sample-cli-plugin/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/sample-cli-plugin/OWNERS)**\n- **[staging/src/k8s.io/sample-controller/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/sample-controller/OWNERS)**\n- **[vendor/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/vendor/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"dims\"]} -->", "created_at": "2023-08-11 14:28:36" }, { "body": "> /reopen\r\n> \r\n> actually, we can make this the current 3.10.2 bump PR, since the other one needs rebase, but the test failures due to the incompatible go-restful path parsing behavior still have to be resolved (likely by undoing the path processing change made to fix the go-restful security issue, see the `TrimPathStrategy` in https://github.com/emicklei/go-restful/blob/v3/README.md#how-to-customize)\r\n\r\nin the ref link I didn't see `TrimPathStrategy`, am I missing something? if so can you be more specify? like how to set the value in k/k script or code\r\n\r\n<img width=\"1062\" alt=\"image\" src=\"https://github.com/kubernetes/kubernetes/assets/73322208/45fde106-9065-49ed-a6bd-56b2c78597f6\">\r\n", "created_at": "2023-08-11 15:13:23" }, { "body": "Sorry, TrimSlashStrategy", "created_at": "2023-08-11 15:17:12" }, { "body": "@charles-chenzz: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-conformance-kind-ga-only-parallel | aeeb788e8ab026e8db12a54098e7bf17e9591a16 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119865/pull-kubernetes-conformance-kind-ga-only-parallel/1690007157489012736) | true | `/test pull-kubernetes-conformance-kind-ga-only-parallel`\npull-kubernetes-kind-dra | aeeb788e8ab026e8db12a54098e7bf17e9591a16 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119865/pull-kubernetes-kind-dra/1690007157971357696) | false | `/test pull-kubernetes-kind-dra`\npull-kubernetes-node-e2e-containerd | aeeb788e8ab026e8db12a54098e7bf17e9591a16 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119865/pull-kubernetes-node-e2e-containerd/1690007157627424768/) | true | `/test pull-kubernetes-node-e2e-containerd`\npull-kubernetes-e2e-kind-ipv6 | aeeb788e8ab026e8db12a54098e7bf17e9591a16 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119865/pull-kubernetes-e2e-kind-ipv6/1690007157434486784) | true | `/test pull-kubernetes-e2e-kind-ipv6`\npull-kubernetes-e2e-kind | aeeb788e8ab026e8db12a54098e7bf17e9591a16 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119865/pull-kubernetes-e2e-kind/1690007157375766528) | true | `/test pull-kubernetes-e2e-kind`\npull-kubernetes-unit | aeeb788e8ab026e8db12a54098e7bf17e9591a16 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119865/pull-kubernetes-unit/1690007157535150080) | true | `/test pull-kubernetes-unit`\npull-kubernetes-e2e-kind-kms | aeeb788e8ab026e8db12a54098e7bf17e9591a16 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119865/pull-kubernetes-e2e-kind-kms/1690007157585481728) | false | `/test pull-kubernetes-e2e-kind-kms`\npull-kubernetes-verify | aeeb788e8ab026e8db12a54098e7bf17e9591a16 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119865/pull-kubernetes-verify/1690007160550854656) | true | `/test pull-kubernetes-verify`\npull-kubernetes-e2e-gce | aeeb788e8ab026e8db12a54098e7bf17e9591a16 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119865/pull-kubernetes-e2e-gce/1690007157220577280/) | true | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-integration | aeeb788e8ab026e8db12a54098e7bf17e9591a16 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119865/pull-kubernetes-integration/1690007157275103232) | true | `/test pull-kubernetes-integration`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119865). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Acharles-chenzz). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-08-11 15:25:21" }, { "body": "gentle ping @liggitt \r\nI think I still need more hints on how to set the value to TrimSlashStrategy, as I'm not quite familiar with the part of api codebases and the readme.md seems not very clear in my side.", "created_at": "2023-08-11 15:34:02" }, { "body": "it looks like we'll have to override a public package var in go-restful to keep the current behavior we rely on, which is unfortunate\r\n\r\nhttps://github.com/emicklei/go-restful/blob/bdefcacf789abc38c10558828d9f64b02307f32f/route_builder.go#L374-L377\r\n\r\nwe would at least have to do that in the binaries we have that use go-restful (kube-apiserver and kubelet), but maybe also in the k8s.io/apiserver library, which is harder to do in a way that we can guarantee is side-effect-free for someone who uses k8s.io/apiserver AND also uses go-restful directly.", "created_at": "2023-08-11 20:11:42" }, { "body": "yes, but the key point is how do we override on our package to get it compatible with what we need?", "created_at": "2023-08-14 14:30:38" }, { "body": "/triage accepted", "created_at": "2023-08-15 20:12:17" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:34:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:34:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:34:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:34:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:34:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:34:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:34:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:10", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:33", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:33", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:35:33", "type": "review_requested" }, { "author": "toVersus", "created_at": "2023-08-09 15:46:28", "type": "unsubscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-09 15:57:33", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-09 15:57:33", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-09 15:59:04", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-09 15:59:04", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-09 15:59:19", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-09 15:59:19", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-09 16:03:35", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-09 16:03:35", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-09 16:04:18", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-09 16:04:18", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-09 16:05:41", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-09 16:05:41", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-09 16:17:24", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-09 16:17:24", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-09 16:30:07", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-09 16:30:08", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-09 16:31:12", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-09 16:31:12", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-09 16:35:15", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-09 16:35:15", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-10 14:28:21", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-10 14:28:21", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-10 14:28:46", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-10 14:28:47", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-10 14:30:08", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-10 14:30:08", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-10 14:31:27", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-10 14:31:27", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-10 14:39:12", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-10 14:39:12", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-10 14:56:27", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-10 14:56:28", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-10 14:57:27", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-10 14:57:27", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-10 14:58:17", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-10 14:58:17", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-10 16:38:34", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-10 16:38:34", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-10 16:38:35", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:27:29", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 14:22:54", "type": "closed" }, { "author": "liggitt", "created_at": "2023-08-11 14:22:55", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-11 14:22:55", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 14:27:58", "type": "reopened" }, { "author": "liggitt", "created_at": "2023-08-11 14:27:59", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-11 14:27:59", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-11 14:54:27", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-11 14:54:27", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-11 14:54:40", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-11 14:54:40", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-11 14:56:19", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-11 14:56:19", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-11 14:57:58", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-11 14:57:58", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-11 15:00:28", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-11 15:00:28", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-11 15:09:40", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-11 15:09:40", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-11 15:12:31", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-11 15:12:31", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-11 15:20:49", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-11 15:20:49", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-11 15:22:27", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-11 15:22:27", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-08-11 15:25:22", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-08-11 15:25:22", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-11 15:34:02", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-11 15:34:02", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 20:14:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 20:22:53", "type": "unlabeled" }, { "author": "sengaya", "created_at": "2023-08-16 16:46:09", "type": "subscribed" } ]

[ "pohly" ]

[ "kind/bug", "sig/network", "sig/instrumentation", "kind/regression", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 15:15:26" }, { "body": "The problem is caused by this line:\r\n\r\nhttps://github.com/kubernetes/kubernetes/blob/f0dcf0614036d8c3cd1c9f3b3cf8df4bb1d8e44e/cmd/kube-proxy/app/server.go#L250\r\n\r\nAt that point, `o.config.Logging.Verbosity` is 4 (from the command line flag), and then it gets overwritten with `c.Verbosity` == 0.\r\n\r\nThe normal approach would be:\r\n- set up config with defaults\r\n- modify config through flags\r\n- modify config further by parsing a config file into it.\r\n\r\nCan kube-proxy do this? It has the downside that a config file can only overwrite fields if they are in the file. A config field doesn't get reset to defaults just by parsing the file.\r\n\r\n/cc @cyclinder @liggitt @aojea ", "created_at": "2023-08-09 15:23:33" }, { "body": "it looks like kube-proxy special-cases the `processHostnameOverrideFlag` to let a flag override config... can/should it do the same thing for verbosity? are there any other flags like this?", "created_at": "2023-08-09 15:29:44" }, { "body": "> The normal approach would be:\r\n> \r\n> * set up config with defaults\r\n> * modify config through flags\r\n> * modify config further by parsing a config file into it.\r\n\r\nI don't think that's the normal approach... it's more normal to make flags and config file mutually exclusive. That's difficult for things which started as flags and moved into config", "created_at": "2023-08-09 15:30:56" }, { "body": "/sig network\r\n/sig instrumentation\r\n/kind bug\r\n/kind regression\r\n/milestone v1.28\r\n\r\n", "created_at": "2023-08-09 15:33:13" }, { "body": "> it looks like kube-proxy special-cases the `processHostnameOverrideFlag` to let a flag override config... can/should it do the same thing for verbosity? are there any other flags like this?\r\n\r\nlet's go with `verbosity flag override config flag` and warn it and comment as much as possible, I was going with something like\r\n```diff\r\ndiff --git a/cmd/kube-proxy/app/server.go b/cmd/kube-proxy/app/server.go\r\nindex d019212db28..cd82406c3f3 100644\r\n--- a/cmd/kube-proxy/app/server.go\r\n+++ b/cmd/kube-proxy/app/server.go\r\n@@ -260,6 +260,10 @@ func (o *Options) Complete() error {\r\n return err\r\n }\r\n \r\n+ if err := o.processLoggingVerbosityOverrideFlag(); err != nil {\r\n+ return err\r\n+ }\r\n+\r\n return utilfeature.DefaultMutableFeatureGate.SetFromMap(o.config.FeatureGates)\r\n }\r\n \r\n@@ -305,6 +309,17 @@ func (o *Options) processHostnameOverrideFlag() error {\r\n return nil\r\n }\r\n \r\n+// processLoggingVerbosityOverrideFlag processes logging verbosity override flag\r\n+// For historical reasons kube-proxy config override flags https://issues.k8s.io/98302\r\n+// The logging configuration API does not have a way of differentiate between not set\r\n+// or set to 0, and this causes that since https://github.com/kubernetes/kubernetes/pull/117800\r\n+// the verbosity flag is ommited. Until the API for logging allows to discriminate between\r\n+// empty or set to 0, we allow to override the log verbosity with the flag.\r\n+func (o *Options) processLoggingVerbosityOverrideFlag() error {\r\n+\r\n+ return nil\r\n+}\r\n+\r\n // Validate validates all the required options.\r\n func (o *Options) Validate() error {\r\n```\r\n\r\nbut Patrick is working on it so I assign to him the issue @pohly ", "created_at": "2023-08-09 15:37:10" }, { "body": "/assign @pohly ", "created_at": "2023-08-09 15:40:19" }, { "body": "Hey folks, v1.28 Bug Triage Lead here 👋🏼 \r\n\r\nJust wanted to know if this is already tracked by SIG leads and someone already working actively fixing it and set a priority? \r\n\r\n", "created_at": "2023-08-09 16:03:56" }, { "body": "> I don't think that's the normal approach...\r\n\r\nPerhaps I should have said \"this is how component-base/logs was meant to be used\". Somehow it worked for kubelet.\r\n\r\nHere's my preliminary solution: https://github.com/kubernetes/kubernetes/pull/119867\r\n\r\nIt needs more testing, but I wanted to share it early because I am running out of time today.", "created_at": "2023-08-09 16:28:54" }, { "body": "> Hey folks, v1.28 Bug Triage Lead here 👋🏼\r\n> \r\n> Just wanted to know if this is already tracked by SIG leads and someone already working actively fixing it and set a priority?\r\n\r\nit is @furkatgofurov7 , I can take over Patrick's work in case is needed", "created_at": "2023-08-09 16:33:39" }, { "body": "It would be nice if the logs API could distinguish between `setting it to 0` and `not setting it`, how about make `verbosity` to a pointer? But this change is supposed to be a breaking change, I'm not sure of the scope of the impact.\r\n\r\nhttps://github.com/kubernetes/kubernetes/blob/e6218f3d3bede036b2d67a4349dd761aac06ae97/staging/src/k8s.io/component-base/logs/api/v1/types.go#L53\r\n\r\nFor `kube-proxy` side, if set `--config` and `command flags` at the same time, should the command flag override the config file or warn it and be discarded? I think it should be overridden.", "created_at": "2023-08-10 03:07:08" }, { "body": "xref: https://github.com/kubernetes/kubernetes/issues/119523", "created_at": "2023-08-10 10:01:04" } ]

[ { "author": "pohly", "created_at": "2023-08-09 15:15:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:15:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:15:25", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-08-09 15:23:33", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 15:23:33", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-08-09 15:23:34", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-09 15:23:34", "type": "subscribed" }, { "author": "cyclinder", "created_at": "2023-08-09 15:23:34", "type": "mentioned" }, { "author": "cyclinder", "created_at": "2023-08-09 15:23:34", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:33:15", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:33:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:33:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:33:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:33:17", "type": "unlabeled" }, { "author": "pohly", "created_at": "2023-08-09 15:37:11", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-09 15:37:11", "type": "subscribed" }, { "author": "pohly", "created_at": "2023-08-09 15:40:20", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-09 15:40:20", "type": "subscribed" }, { "author": "pohly", "created_at": "2023-08-09 15:40:21", "type": "assigned" }, { "author": "furkatgofurov7", "created_at": "2023-08-09 16:33:40", "type": "mentioned" }, { "author": "furkatgofurov7", "created_at": "2023-08-09 16:33:40", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 12:25:29", "type": "closed" } ]

[]

[ "kind/bug", "sig/network", "sig/instrumentation", "kind/regression", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 15:00:02" }, { "body": "/sig network\r\n/sig instrumentation\r\n/kind bug\r\n/kind regression\r\n/milestone 1.28\r\n\r\nI'm opening this issue just for the specific kube-proxy problem, @pohly will open another issue to track the general problem of not having a possibility to distingish between 0 or empty verbosity\r\n\r\n", "created_at": "2023-08-09 15:01:58" }, { "body": "@aojea: The provided milestone is not valid for this repository. Milestones in this repository: [`next-candidate`, `v1.16`, `v1.17`, `v1.18`, `v1.19`, `v1.20`, `v1.21`, `v1.22`, `v1.23`, `v1.24`, `v1.25`, `v1.26`, `v1.27`, `v1.28`, `v1.29`]\n\nUse `/milestone clear` to clear the milestone.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119863#issuecomment-1671582848):\n\n>/sig network\r\n>/sig instrumentation\r\n>/kind bug\r\n>/kind regression\r\n>/milestone 1.28\r\n>\r\n>I'm opening this issue just for the specific kube-proxy problem, @pohly will open another issue to track the general problem of not having a possibility to distingish between 0 or empty verbosity\r\n>\r\n>\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 15:02:05" }, { "body": "/milestone v1.28", "created_at": "2023-08-09 15:02:23" }, { "body": "/close\r\n\r\nduplicate of https://github.com/kubernetes/kubernetes/issues/119864", "created_at": "2023-08-09 15:33:24" }, { "body": "@aojea: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119863#issuecomment-1671636530):\n\n>/close\r\n>\r\n>duplicate of https://github.com/kubernetes/kubernetes/issues/119864\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 15:33:30" } ]

[ { "author": "aojea", "created_at": "2023-08-09 14:59:52", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-09 14:59:52", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 14:59:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:00:01", "type": "labeled" }, { "author": "pohly", "created_at": "2023-08-09 15:01:59", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-09 15:01:59", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:02:06", "type": "labeled" }, { "author": "pohly", "created_at": "2023-08-09 15:02:06", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-09 15:02:06", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-08-09 15:02:06", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-09 15:02:06", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:02:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:02:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:02:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:02:12", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:02:30", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:33:29", "type": "closed" }, { "author": "aojea", "created_at": "2023-08-09 15:33:30", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-09 15:33:30", "type": "subscribed" } ]

[]

[ "kind/bug", "sig/node", "triage/needs-information", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 14:38:51" }, { "body": "/sig node", "created_at": "2023-08-09 14:42:58" }, { "body": "Could you try reproducing on a supported Kubernetes version (eg. 1.27)?\r\n\r\n/triage needs-information", "created_at": "2023-08-09 17:45:34" }, { "body": "this looks related to pod lifecycle refactor happening in https://github.com/kubernetes/kubernetes/issues/116970", "created_at": "2023-08-09 17:47:06" } ]

[ { "author": "vDMG", "created_at": "2023-08-09 14:38:42", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 14:38:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 14:38:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 14:43:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 14:43:01", "type": "unlabeled" }, { "author": "vDMG", "created_at": "2023-08-09 14:43:35", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 17:45:35", "type": "labeled" } ]

[]

[ "area/test", "kind/cleanup", "area/kubectl", "size/M", "sig/cli", "cncf-cla: yes", "sig/testing", "needs-ok-to-test", "do-not-merge/release-note-label-needed", "needs-priority", "needs-triage" ]

[ { "body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 12:35:29" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 10:32:39 UTC 2023.\n", "created_at": "2023-08-09 12:35:31" }, { "body": "@liangyuanpeng: GitHub didn't allow me to request PR reviews from the following users: of, method, the, author.\n\nNote that only [kubernetes members](https://github.com/orgs/kubernetes/people) and repo collaborators can review this PR, and authors cannot review their own PRs.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119861):\n\n><!-- Thanks for sending a pull request! Here are some tips for you:\r\n>\r\n>1. If this is your first time, please read our contributor guidelines: https://git.k8s.io/community/contributors/guide/first-contribution.md#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n>2. Please label this pull request according to what type of issue you are addressing, especially if this is a release targeted pull request. For reference on required PR/issue labels, read here:\r\n>https://git.k8s.io/community/contributors/devel/sig-release/release.md#issuepr-kind-label\r\n>3. Ensure you have added or ran the appropriate tests for your PR: https://git.k8s.io/community/contributors/devel/sig-testing/testing.md\r\n>4. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n>5. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n>-->\r\n>\r\n>#### What type of PR is this?\r\n>/kind cleanup\r\n>\r\n>#### What this PR does / why we need it:\r\n>\r\n>This PR is replace `wait.poll` and `wait.PollImmediate` to `wait.PollUntilContextTimeout`, cleanup the deprecated method.\r\n>\r\n>This PR Only work for the component of kubectl, update for the below package:\r\n>- staging/src/k8s.io/kubectl/\r\n>- test/e2e/kubectl\r\n>\r\n>/cc the author of new method @smarterclayton \r\n>\r\n>Related:\r\n>- #107826\r\n>\r\n>#### Which issue(s) this PR fixes:\r\n><!--\r\n>*Automatically closes linked issue when PR is merged.\r\n>Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.\r\n>_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*\r\n>-->\r\n>Fixes #\r\n>\r\n>#### Special notes for your reviewer:\r\n>\r\n>#### Does this PR introduce a user-facing change?\r\n><!--\r\n>If no, just write \"NONE\" in the release-note block below.\r\n>If yes, a release note is required:\r\n>Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n>\r\n>For more information on release notes see: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n>-->\r\n>```release-note\r\n>\r\n>```\r\n>\r\n>#### Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:\r\n>\r\n><!--\r\n>This section can be blank if this pull request does not require a release note.\r\n>\r\n>When adding links which point to resources within git repositories, like\r\n>KEPs or supporting documentation, please reference a specific commit and avoid\r\n>linking directly to the master branch. This ensures that links reference a\r\n>specific point in time, rather than a document that may change over time.\r\n>\r\n>See here for guidance on getting permanent links to files: https://help.github.com/en/articles/getting-permanent-links-to-files\r\n>\r\n>Please use the following format for linking documentation:\r\n>- [KEP]: <link>\r\n>- [Usage]: <link>\r\n>- [Other doc]: <link>\r\n>-->\r\n>```docs\r\n>\r\n>```\r\n>\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 12:35:31" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119861#\" title=\"Author self-approved\">liangyuanpeng</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [apelisse](https://github.com/apelisse) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/OWNERS)**\n- **[test/e2e/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/kubectl/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"apelisse\"]} -->", "created_at": "2023-08-09 12:35:33" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 12:35:36" }, { "body": "Hi @liangyuanpeng. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-08-09 12:35:36" } ]

[ { "author": "smarterclayton", "created_at": "2023-08-09 12:35:27", "type": "mentioned" }, { "author": "smarterclayton", "created_at": "2023-08-09 12:35:28", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 12:35:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 12:35:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 12:35:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 12:35:30", "type": "review_requested" }, { "author": "smarterclayton", "created_at": "2023-08-09 12:35:31", "type": "mentioned" }, { "author": "smarterclayton", "created_at": "2023-08-09 12:35:32", "type": "subscribed" }, { "author": "liangyuanpeng", "created_at": "2023-08-09 12:35:32", "type": "mentioned" }, { "author": "liangyuanpeng", "created_at": "2023-08-09 12:35:32", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 12:35:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 12:35:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 12:35:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 12:35:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 12:35:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 12:35:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 12:35:36", "type": "labeled" }, { "author": "liangyuanpeng", "created_at": "2023-08-09 12:35:37", "type": "mentioned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 12:35:37", "type": "labeled" }, { "author": "liangyuanpeng", "created_at": "2023-08-09 12:35:37", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 12:35:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 12:35:38", "type": "unlabeled" }, { "author": "toVersus", "created_at": "2023-08-09 13:36:21", "type": "unsubscribed" } ]

[ "liggitt" ]

[ "kind/cleanup", "lgtm", "size/L", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 10:32:39 UTC 2023.\n", "created_at": "2023-08-09 11:36:07" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 11:36:12" }, { "body": "This is WIP because:\r\n- [x] new golangcli-lint has to be released\r\n- [ ] ~~https://github.com/kubernetes-sigs/logtools/pull/18 needs to be merged and included in a release~~ deferred to future PR\r\n- [ ] ~~[templating and inlining support](https://github.com/kubernetes/kubernetes/pull/118502) for the `logcheck.conf` needs to be merged~~ same", "created_at": "2023-08-09 11:38:57" }, { "body": "there may be a fix for the go1.21 / go-critic issue to try, see https://github.com/kubernetes/kubernetes/pull/119037#issuecomment-1672150122", "created_at": "2023-08-09 21:13:37" }, { "body": "I've tried that fix by bumping the github.com/quasilyte/go-ruleguard dependency and that seems to work.\r\n", "created_at": "2023-08-10 09:28:40" }, { "body": "In order to bump release branches to go1.21, we'll need to pick any *required* changes to support go1.21 back. Can this PR be split into the minimal set to run on go1.21, and a follow-up to switch to the new plugin interface to keep the size of the backports as small as possible?", "created_at": "2023-08-10 14:45:11" }, { "body": "This PR now only has the golangci-lint and ruleguard update.\r\n\r\nI filed an issue about the plugin warning: https://github.com/golangci/golangci-lint/issues/4001", "created_at": "2023-08-10 18:54:31" }, { "body": "https://github.com/golangci/golangci-lint/pull/4002/files added an env variable for suppressing the warning. This is included in this PR now.\r\n", "created_at": "2023-08-16 07:05:49" }, { "body": "/hold \r\n\r\nTo prevent merging without additional approval from someone else.\r\n\r\n", "created_at": "2023-08-16 07:10:03" }, { "body": "/retest\r\n", "created_at": "2023-08-16 08:21:16" }, { "body": "/lgtm\r\n/approve\r\n/hold cancel\r\n\r\ngo ahead and open picks to release-1.25+ branches once this merges so those will be prepped for go1.21 whenever it makes it back to those branches", "created_at": "2023-08-16 13:17:22" }, { "body": "LGTM label has been added. <details>Git tree hash: fe6e939c574a952c423a80401bc8f0fc628036a1</details>", "created_at": "2023-08-16 13:17:29" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119860#issuecomment-1680589044\" title=\"Approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119860#\" title=\"Author self-approved\">pohly</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/hack/OWNERS)~~ [liggitt,pohly]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-16 13:17:49" }, { "body": "/sig testing", "created_at": "2023-08-16 15:34:26" }, { "body": "Cherry-picks created.", "created_at": "2023-08-17 07:56:44" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:36:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:36:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:36:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:36:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:36:09", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:36:09", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:36:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:36:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:36:13", "type": "labeled" }, { "author": "pohly", "created_at": "2023-08-09 11:36:18", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:36:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:36:20", "type": "labeled" }, { "author": "pohly", "created_at": "2023-08-09 12:33:08", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-09 12:33:08", "type": "subscribed" }, { "author": "pohly", "created_at": "2023-08-10 09:28:35", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 09:28:51", "type": "unlabeled" }, { "author": "pohly", "created_at": "2023-08-10 18:34:14", "type": "head_ref_force_pushed" }, { "author": "pohly", "created_at": "2023-08-10 18:36:52", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 18:36:58", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 18:36:59", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 18:36:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 18:42:20", "type": "labeled" }, { "author": "pohly", "created_at": "2023-08-10 18:44:46", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-10 18:44:46", "type": "subscribed" }, { "author": "pohly", "created_at": "2023-08-10 18:54:09", "type": "head_ref_force_pushed" }, { "author": "pohly", "created_at": "2023-08-10 19:51:32", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-10 19:51:32", "type": "subscribed" }, { "author": "pohly", "created_at": "2023-08-16 07:05:26", "type": "head_ref_force_pushed" }, { "author": "pohly", "created_at": "2023-08-16 07:07:45", "type": "head_ref_force_pushed" }, { "author": "pohly", "created_at": "2023-08-16 07:08:32", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 07:08:33", "type": "labeled" }, { "author": "pohly", "created_at": "2023-08-16 07:09:01", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 07:09:03", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 07:10:05", "type": "labeled" }, { "author": "pohly", "created_at": "2023-08-16 08:02:35", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-16 08:02:35", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 13:17:24", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-16 13:17:27", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 13:17:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 15:34:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 15:34:30", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 18:37:01", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 18:37:01", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 18:37:01", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 18:37:05", "type": "milestoned" } ]

[ "neolit123" ]

[ "kind/bug", "kind/cleanup", "lgtm", "sig/cluster-lifecycle", "release-note", "size/XS", "approved", "area/kubeadm", "cncf-cla: yes", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 10:32:39 UTC 2023.\n", "created_at": "2023-08-09 11:24:32" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119859#\" title=\"Author self-approved\">SataQiu</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[cmd/kubeadm/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/OWNERS)~~ [SataQiu]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-09 11:24:35" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 11:24:37" }, { "body": "/hold \r\nfor review", "created_at": "2023-08-09 11:24:58" }, { "body": "LGTM label has been added. <details>Git tree hash: 422afe6e72281fd3016f56e3f44f9f0c14f2bc6c</details>", "created_at": "2023-08-14 06:37:38" }, { "body": "@SataQiu we can drop the hold here, i think.", "created_at": "2023-08-16 06:45:23" }, { "body": "Yes, thanks @neolit123 \r\n/hold cancel", "created_at": "2023-08-16 06:54:52" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:24:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:24:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:24:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:24:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:24:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:24:35", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:24:35", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:24:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:24:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:24:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:24:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:24:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:24:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:24:38", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:25:01", "type": "labeled" }, { "author": "neolit123", "created_at": "2023-08-14 06:37:35", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 06:37:36", "type": "labeled" }, { "author": "SataQiu", "created_at": "2023-08-16 06:45:23", "type": "mentioned" }, { "author": "SataQiu", "created_at": "2023-08-16 06:45:23", "type": "subscribed" }, { "author": "neolit123", "created_at": "2023-08-16 06:54:53", "type": "mentioned" }, { "author": "neolit123", "created_at": "2023-08-16 06:54:53", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:54:54", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 08:22:26", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 08:22:26", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 08:22:26", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 08:22:31", "type": "milestoned" } ]

[ "liggitt" ]

[ "area/test", "sig/network", "area/kubelet", "kind/cleanup", "sig/scheduling", "area/kube-proxy", "area/kubectl", "lgtm", "area/cloudprovider", "sig/storage", "sig/node", "sig/api-machinery", "sig/cluster-lifecycle", "sig/autoscaling", "size/L", "release-note-none", "sig/apps", "approved", "sig/cli", "area/kubeadm", "cncf-cla: yes", "sig/testing", "priority/important-longterm", "area/ipvs", "sig/cloud-provider", "tide/merge-method-squash", "ok-to-test", "area/e2e-test-framework", "kind/deprecation", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 10:32:39 UTC 2023.\n", "created_at": "2023-08-09 10:41:55" }, { "body": "Hi @git-jxj. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-08-09 10:42:00" }, { "body": "/ok-to-test", "created_at": "2023-08-10 03:29:38" }, { "body": "/retest", "created_at": "2023-08-10 04:14:24" }, { "body": "/retest", "created_at": "2023-08-10 05:41:21" }, { "body": "/triage accepted\r\n/priority important-longterm\r\n/assign @liggitt", "created_at": "2023-08-10 08:31:52" }, { "body": "/retest", "created_at": "2023-08-11 03:50:50" }, { "body": "/retest", "created_at": "2023-08-14 04:07:52" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-14 16:01:31" }, { "body": "LGTM label has been added. <details>Git tree hash: 88d66d4a940e2c1fbc72efd02707492881f323c9</details>", "created_at": "2023-08-14 16:01:37" }, { "body": "/lgtm", "created_at": "2023-08-14 16:01:43" }, { "body": "LGTM label has been added. <details>Git tree hash: 88d66d4a940e2c1fbc72efd02707492881f323c9</details>", "created_at": "2023-08-14 16:01:50" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119858#\" title=\"Author self-approved\">git-jxj</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119858#issuecomment-1677615760\" title=\"Approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[cmd/kubeadm/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/OWNERS)~~ [liggitt]\n- ~~[pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/OWNERS)~~ [liggitt]\n- ~~[pkg/controller/daemon/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/daemon/OWNERS)~~ [liggitt]\n- ~~[pkg/controller/deployment/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/deployment/OWNERS)~~ [liggitt]\n- ~~[pkg/controlplane/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controlplane/OWNERS)~~ [liggitt]\n- ~~[pkg/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/OWNERS)~~ [liggitt]\n- ~~[pkg/proxy/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/proxy/OWNERS)~~ [liggitt]\n- ~~[pkg/registry/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/registry/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/apimachinery/pkg/util/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/util/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/cloud-provider/controllers/service/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/cloud-provider/controllers/service/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/legacy-cloud-providers/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/legacy-cloud-providers/OWNERS)~~ [liggitt]\n- ~~[test/e2e/apps/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/apps/OWNERS)~~ [liggitt]\n- ~~[test/e2e/autoscaling/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/autoscaling/OWNERS)~~ [liggitt]\n- ~~[test/e2e/common/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/common/OWNERS)~~ [liggitt]\n- ~~[test/e2e/framework/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/framework/OWNERS)~~ [liggitt]\n- ~~[test/e2e/network/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/network/OWNERS)~~ [liggitt]\n- ~~[test/integration/deployment/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/integration/deployment/OWNERS)~~ [liggitt]\n- ~~[test/integration/scheduler/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/integration/scheduler/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-16 06:26:36" }, { "body": "@liggitt Sorry after rebase the `lgtm` label was accientally removed, could you please review it again? Thanks", "created_at": "2023-08-16 06:29:22" }, { "body": "/retest", "created_at": "2023-08-16 07:13:11" }, { "body": "/lgtm\r\n", "created_at": "2023-08-16 13:18:36" }, { "body": "LGTM label has been added. <details>Git tree hash: fd464cda2756217edeb9572c90194a99e7134c25</details>", "created_at": "2023-08-16 13:18:42" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:41:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:41:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:41:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:41:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:41:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:41:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:41:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:41:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:41:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:41:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:41:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:00", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:00", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:01", "type": "labeled" }, { "author": "git-jxj", "created_at": "2023-08-09 10:42:01", "type": "mentioned" }, { "author": "git-jxj", "created_at": "2023-08-09 10:42:01", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:06", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:42:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 03:29:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 03:29:40", "type": "unlabeled" }, { "author": "git-jxj", "created_at": "2023-08-10 04:08:48", "type": "mentioned" }, { "author": "git-jxj", "created_at": "2023-08-10 04:08:48", "type": "subscribed" }, { "author": "git-jxj", "created_at": "2023-08-10 04:29:26", "type": "mentioned" }, { "author": "git-jxj", "created_at": "2023-08-10 04:29:26", "type": "subscribed" }, { "author": "git-jxj", "created_at": "2023-08-10 04:35:19", "type": "mentioned" }, { "author": "git-jxj", "created_at": "2023-08-10 04:35:19", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-10 08:31:52", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-10 08:31:52", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-10 08:31:54", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:31:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:31:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:31:56", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:31:57", "type": "unlabeled" }, { "author": "git-jxj", "created_at": "2023-08-11 03:46:14", "type": "mentioned" }, { "author": "git-jxj", "created_at": "2023-08-11 03:46:14", "type": "subscribed" }, { "author": "toVersus", "created_at": "2023-08-12 23:26:59", "type": "unsubscribed" }, { "author": "git-jxj", "created_at": "2023-08-14 02:59:35", "type": "review_requested" }, { "author": "git-jxj", "created_at": "2023-08-14 04:00:11", "type": "mentioned" }, { "author": "git-jxj", "created_at": "2023-08-14 04:00:11", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:01:36", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-08-14 16:01:37", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-14 16:01:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:01:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:01:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 23:46:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:25:50", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:25:54", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:26:18", "type": "labeled" }, { "author": "git-jxj", "created_at": "2023-08-16 06:28:03", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:28:34", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-16 06:29:23", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-16 06:29:23", "type": "subscribed" }, { "author": "git-jxj", "created_at": "2023-08-16 06:56:42", "type": "mentioned" }, { "author": "git-jxj", "created_at": "2023-08-16 06:56:42", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 13:18:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 16:33:01", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 16:33:01", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 16:33:01", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 16:33:03", "type": "milestoned" } ]

[]

[ "area/test", "sig/network", "area/kubelet", "kind/cleanup", "sig/scheduling", "area/kube-proxy", "area/apiserver", "area/kubectl", "area/cloudprovider", "area/provider/gcp", "sig/storage", "sig/node", "sig/api-machinery", "sig/cluster-lifecycle", "sig/autoscaling", "size/L", "kind/api-change", "area/release-eng", "release-note-none", "sig/auth", "sig/apps", "sig/cli", "area/kubeadm", "cncf-cla: yes", "sig/instrumentation", "sig/testing", "needs-ok-to-test", "sig/release", "sig/architecture", "area/code-generation", "area/ipvs", "sig/cloud-provider", "needs-priority", "area/e2e-test-framework", "area/dependency", "kind/deprecation", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 10:32:39 UTC 2023.\n", "created_at": "2023-08-09 10:34:29" }, { "body": "Hi @git-jxj. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-08-09 10:34:35" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119857#\" title=\"Author self-approved\">git-jxj</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [deads2k](https://github.com/deads2k), [liggitt](https://github.com/liggitt) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[cmd/kubeadm/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/OWNERS)**\n- **[pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/OWNERS)**\n- **[pkg/controller/daemon/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/daemon/OWNERS)**\n- **[pkg/controller/deployment/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/deployment/OWNERS)**\n- **[pkg/controlplane/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controlplane/OWNERS)**\n- **[pkg/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/OWNERS)**\n- **[pkg/proxy/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/proxy/OWNERS)**\n- **[pkg/registry/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/registry/OWNERS)**\n- **[staging/src/k8s.io/apimachinery/pkg/util/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/util/OWNERS)**\n- **[staging/src/k8s.io/cloud-provider/controllers/service/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/cloud-provider/controllers/service/OWNERS)**\n- **[staging/src/k8s.io/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/OWNERS)**\n- **[staging/src/k8s.io/legacy-cloud-providers/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/legacy-cloud-providers/OWNERS)**\n- **[test/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"deads2k\",\"liggitt\"]} -->", "created_at": "2023-08-09 10:38:06" }, { "body": "/triage accepted", "created_at": "2023-08-15 20:12:27" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:35", "type": "labeled" }, { "author": "git-jxj", "created_at": "2023-08-09 10:34:35", "type": "mentioned" }, { "author": "git-jxj", "created_at": "2023-08-09 10:34:35", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:40", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:40", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:42", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:42", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:46", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:34:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:38:02", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:38:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:38:19", "type": "labeled" }, { "author": "git-jxj", "created_at": "2023-08-09 10:39:29", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:39:48", "type": "unlabeled" }, { "author": "git-jxj", "created_at": "2023-08-09 10:40:11", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 20:19:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 20:52:33", "type": "unlabeled" } ]

[]

[ "kind/bug", "needs-sig", "needs-triage" ]

[ { "body": "There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:\n- `/sig <group-name>`\n- `/wg <group-name>`\n- `/committee <group-name>`\n\nPlease see the [group list](https://git.k8s.io/community/sig-list.md) for a listing of the SIGs, working groups, and committees available.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 10:14:26" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 10:14:27" }, { "body": "that option is no longer needed as the flag says, it is needed for the endpoints-reconciler type `master-count` , that has been deprecated too\r\n\r\n```\r\n--endpoint-reconciler-type string Default: \"lease\"\r\nUse an endpoint reconciler (master-count, lease, none) master-count is deprecated, and will be removed in a future version.\r\n```\r\n\r\n/close", "created_at": "2023-08-09 11:36:01" }, { "body": "@aojea: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119856#issuecomment-1671161256):\n\n>that option is no longer needed as the flag says, it is needed for the endpoints-reconciler type `master-count` , that has been deprecated too\r\n>\r\n>```\r\n>--endpoint-reconciler-type string Default: \"lease\"\r\n>Use an endpoint reconciler (master-count, lease, none) master-count is deprecated, and will be removed in a future version.\r\n>```\r\n>\r\n>/close\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 11:36:07" } ]

[ { "author": "erikschul", "created_at": "2023-08-09 10:14:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:14:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:14:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 11:36:06", "type": "closed" }, { "author": "aojea", "created_at": "2023-08-09 11:36:07", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-09 11:36:07", "type": "subscribed" } ]

[ "deads2k" ]

[ "kind/bug", "sig/api-machinery", "release-note", "size/S", "cncf-cla: yes", "needs-ok-to-test", "needs-priority", "triage/accepted" ]

[ { "body": "<a href=\"https://easycla.lfx.linuxfoundation.org/#/?version=2\"><img src=\"https://s3.amazonaws.com/cla-project-logo-prod/cla-signed.svg\" alt=\"CLA Signed\" align=\"left\" height=\"28\" width=\"328\" ></a><br/><br />The committers listed above are authorized under a signed CLA.<ul><li>:white_check_mark: login: archever / name: Jinghao Lu (d5b5a9e46a74f47f5045b74e97436f6186666003)</li></ul>", "created_at": "2023-08-09 10:02:59" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 04:32:46 UTC 2023.\n", "created_at": "2023-08-09 10:02:59" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119855#\" title=\"Author self-approved\">archever</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [smarterclayton](https://github.com/smarterclayton) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/apimachinery/pkg/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"smarterclayton\"]} -->", "created_at": "2023-08-09 10:03:02" }, { "body": "Welcome @archever! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:", "created_at": "2023-08-09 10:03:04" }, { "body": "Hi @archever. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-08-09 10:03:05" }, { "body": "/assign @deads2k\r\n/triage accepted", "created_at": "2023-08-10 16:39:45" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:02:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:02:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:02:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:03:02", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:03:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:03:02", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:03:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:03:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:03:04", "type": "labeled" }, { "author": "archever", "created_at": "2023-08-09 10:03:04", "type": "mentioned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:03:04", "type": "labeled" }, { "author": "archever", "created_at": "2023-08-09 10:03:04", "type": "subscribed" }, { "author": "archever", "created_at": "2023-08-09 10:03:05", "type": "mentioned" }, { "author": "archever", "created_at": "2023-08-09 10:03:05", "type": "subscribed" }, { "author": "archever", "created_at": "2023-08-09 10:07:30", "type": "head_ref_force_pushed" }, { "author": "archever", "created_at": "2023-08-09 10:07:47", "type": "mentioned" }, { "author": "archever", "created_at": "2023-08-09 10:07:47", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:16:10", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 10:16:11", "type": "labeled" }, { "author": "deads2k", "created_at": "2023-08-10 16:39:46", "type": "mentioned" }, { "author": "deads2k", "created_at": "2023-08-10 16:39:46", "type": "subscribed" }, { "author": "deads2k", "created_at": "2023-08-10 16:39:47", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:39:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:39:49", "type": "unlabeled" } ]

[ "charles-chenzz" ]

[ "kind/cleanup", "needs-sig", "area/dependency", "needs-triage" ]

[ { "body": "There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:\n- `/sig <group-name>`\n- `/wg <group-name>`\n- `/committee <group-name>`\n\nPlease see the [group list](https://git.k8s.io/community/sig-list.md) for a listing of the SIGs, working groups, and committees available.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 09:31:59" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 09:32:00" }, { "body": "/assign", "created_at": "2023-08-09 15:23:19" }, { "body": "https://github.com/kubernetes/kubernetes/pull/115067 is open to try to bump to that version, but is failing tests due to backwards-incompatible changes to path normalization made in go-restful as part of resolving the security issue.\r\n\r\nKubernetes does not make use of go-restful authorization, so is unaffected by the security issue resolved in v3.10.2", "created_at": "2023-08-11 14:24:51" }, { "body": "/remove-kind bug\r\n/kind cleanup\r\n/area dependency", "created_at": "2023-08-11 14:36:35" } ]

[ { "author": "Bjyothi2023", "created_at": "2023-08-09 09:31:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 09:31:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 09:31:59", "type": "labeled" }, { "author": "charles-chenzz", "created_at": "2023-08-09 15:23:21", "type": "assigned" }, { "author": "toVersus", "created_at": "2023-08-09 15:49:21", "type": "unsubscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 14:36:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 14:36:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 14:36:38", "type": "unlabeled" } ]

[ "rphillips" ]

[ "kind/bug", "sig/node", "triage/accepted" ]

[ { "body": "/sig node\r\n", "created_at": "2023-08-09 09:23:06" }, { "body": "\r\n", "created_at": "2023-08-09 09:27:47" }, { "body": "Might be related to https://github.com/kubernetes/kubernetes/issues/118916\r\n\r\n/assign @rphillips \r\n/triage accepted", "created_at": "2023-08-09 17:49:41" } ]

[ { "author": "erichorwath", "created_at": "2023-08-09 09:22:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 09:23:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 09:23:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 09:23:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 09:23:09", "type": "unlabeled" }, { "author": "rphillips", "created_at": "2023-08-09 17:49:42", "type": "mentioned" }, { "author": "rphillips", "created_at": "2023-08-09 17:49:42", "type": "subscribed" }, { "author": "rphillips", "created_at": "2023-08-09 17:49:43", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 17:49:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 17:49:45", "type": "unlabeled" } ]

[]

[ "kind/bug", "sig/node", "triage/needs-information", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 08:03:25" }, { "body": "/sig node", "created_at": "2023-08-09 08:03:55" }, { "body": "> GitVersion:\"v1.23.17\"\r\n\r\n1.23 is EOL please check if this is happening in a supported release, latest supported is 1.25 https://kubernetes.io/releases/", "created_at": "2023-08-09 14:28:17" }, { "body": "You might want to set up a dependency on network from kubelet (assuming you're using systemd), so that it doesn't start until network is ready.\r\n\r\nAlso, could you reproduce this on a later version (eg. 1.27)?\r\n\r\n/triage needs-information", "created_at": "2023-08-09 17:52:36" }, { "body": "The kubelet systemd configuration file already declares a network-online target dependency, but it doesn't seem to work.\r\n\r\n```\r\n[Unit]\r\nDescription=kubelet: The Kubernetes Node Agent\r\nDocumentation=https://kubernetes.io/docs/\r\nWants=network-online.target\r\nAfter=network-online.target\r\n\r\n[Service]\r\nExecStart=/usr/bin/kubelet\r\nRestart=always\r\nStartLimitInterval=0\r\nRestartSec=10\r\n\r\n[Install]\r\nWantedBy=multi-user.target\r\n```\r\nhttps://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/\r\nLooks like additional dependencies are required such as NetworkManager-wait-online.service. I think the best way is that kubelet is compatible with this scenario.\r\n\r\nAlso, I also tested on 1.27 and the problem is still reproducible.\r\n\r\n```\r\nClient Version: version.Info{Major:\"1\", Minor:\"27\", GitVersion:\"v1.27.2\", GitCommit:\"7f6f68fdabc4df88cfea2dcf9a19b2b830f1e647\", GitTreeState:\"clean\", BuildDate:\"2023-05-17T14:20:07Z\", GoVersion:\"go1.20.4\", Compiler:\"gc\", Platform:\"linux/amd64\"}\r\nKustomize Version: v5.0.1\r\nServer Version: version.Info{Major:\"1\", Minor:\"27\", GitVersion:\"v1.27.2\", GitCommit:\"7f6f68fdabc4df88cfea2dcf9a19b2b830f1e647\", GitTreeState:\"clean\", BuildDate:\"2023-05-17T14:13:28Z\", GoVersion:\"go1.20.4\", Compiler:\"gc\", Platform:\"linux/amd64\"}\r\n```", "created_at": "2023-08-10 02:38:33" } ]

[ { "author": "Levi080513", "created_at": "2023-08-09 08:03:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 08:03:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 08:03:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 08:03:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 08:03:59", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 17:52:38", "type": "labeled" } ]

[]

[ "sig/node", "kind/feature", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 07:36:19" }, { "body": "/sig node\r\n", "created_at": "2023-08-14 16:19:37" }, { "body": "/retitle The management of HugePages memory in Kubernetes cannot be changed or deleted", "created_at": "2023-08-14 16:48:44" }, { "body": "/kind feature", "created_at": "2023-08-16 17:39:31" }, { "body": "/remove-kind bug", "created_at": "2023-08-16 17:39:38" }, { "body": "Can I pick this up? @ndixita ", "created_at": "2023-08-20 13:43:54" }, { "body": "> Can I pick this up? @ndixita\r\n\r\nplease go for it", "created_at": "2023-08-21 20:47:42" }, { "body": "> Provide a method to remove huge pages management of Kubernetes\r\n\r\nHey, I think that using the \"none\" memory manager static policy allows us to do this, can't it? If not, could you please elaborate about what's missing? that would help us towards a fix", "created_at": "2023-08-22 12:45:02" }, { "body": "/cc", "created_at": "2023-08-22 12:54:42" } ]

[ { "author": "seavershi", "created_at": "2023-08-09 07:36:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 07:36:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 07:36:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:19:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:19:40", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:48:46", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 17:39:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 17:39:40", "type": "unlabeled" }, { "author": "ndixita", "created_at": "2023-08-20 13:43:54", "type": "mentioned" }, { "author": "ndixita", "created_at": "2023-08-20 13:43:54", "type": "subscribed" }, { "author": "ndixita", "created_at": "2023-08-21 20:47:43", "type": "mentioned" }, { "author": "ndixita", "created_at": "2023-08-21 20:47:43", "type": "subscribed" } ]

[ "adrianchiris", "ffromani" ]

[ "kind/bug", "sig/node", "triage/accepted" ]

[ { "body": "/sig node", "created_at": "2023-08-09 07:38:04" }, { "body": "/assign @adrianchiris ", "created_at": "2023-08-09 07:38:32" }, { "body": "What are you talking about?", "created_at": "2023-08-09 13:52:26" }, { "body": "/triage accepted\r\n/assign @ffromani ", "created_at": "2023-08-09 17:54:30" } ]

[ { "author": "moshe010", "created_at": "2023-08-09 07:35:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 07:35:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 07:35:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 07:38:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 07:38:07", "type": "unlabeled" }, { "author": "adrianchiris", "created_at": "2023-08-09 07:38:32", "type": "mentioned" }, { "author": "adrianchiris", "created_at": "2023-08-09 07:38:32", "type": "subscribed" }, { "author": "adrianchiris", "created_at": "2023-08-09 07:38:34", "type": "assigned" }, { "author": "ffromani", "created_at": "2023-08-09 17:54:31", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-08-09 17:54:31", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-08-09 17:54:32", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 17:54:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 17:54:34", "type": "unlabeled" } ]

[]

[ "sig/scheduling", "kind/feature", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 06:28:25" }, { "body": "/sig scheduling", "created_at": "2023-08-09 07:30:38" }, { "body": "I think this fits the practical needs, we also have different node pools in the same cluster in our production environment and would like to have different strategies for NodeResourceFit as well", "created_at": "2023-08-09 13:01:35" }, { "body": "I think a near-term workaround would be to run multiple schedulers configured differently (e.g. your normal scheduler and a \"gpu\" scheduler) and use taints/tolerations to segregate your pods.", "created_at": "2023-08-09 13:23:59" }, { "body": "/cc", "created_at": "2023-08-09 16:04:18" }, { "body": "> I think a near-term workaround would be to run multiple schedulers configured differently (e.g. your normal scheduler and a \"gpu\" scheduler) and use taints/tolerations to segregate your pods.\r\n\r\n@tzneal Thanks, I think you are right, deploy a scheduler with 2 profiles is a good way to meet the requirement for now. But it still need some changes for existing workload.", "created_at": "2023-08-10 01:20:43" }, { "body": "Do you mean if pod requires gpu, then we'll process with binpack scheduling(by configured)? ", "created_at": "2023-08-16 03:53:38" }, { "body": "> Do you mean if pod requires gpu, then we'll process with binpack scheduling(by configured)?\r\n\r\n@kerthcet I mean maybe we should support apply different resource allocate policy for different nodes (maybe distinguish them using label selectors)", "created_at": "2023-08-16 05:55:17" }, { "body": "If we're going to score the nodes with different strategies, how can we rank them after scoring🤔️. I think their scores will have different meanings under different strategies.", "created_at": "2023-08-16 08:14:51" } ]

[ { "author": "KunWuLuan", "created_at": "2023-08-09 06:28:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 06:28:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 06:28:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 07:30:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 07:30:41", "type": "unlabeled" }, { "author": "tzneal", "created_at": "2023-08-10 01:20:43", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-08-10 01:20:43", "type": "subscribed" }, { "author": "kerthcet", "created_at": "2023-08-16 05:55:17", "type": "mentioned" }, { "author": "kerthcet", "created_at": "2023-08-16 05:55:17", "type": "subscribed" } ]

[]

[ "kind/bug", "area/kubelet", "sig/node", "size/XS", "cncf-cla: no", "needs-ok-to-test", "do-not-merge/release-note-label-needed", "needs-priority", "needs-triage" ]

[ { "body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 05:27:36" }, { "body": " <a href=\"https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/18706487/20580498/119848/#/?version=2\"><img src=\"https://s3.amazonaws.com/cla-project-logo-prod/cla-missing-id.svg\" alt=\"CLA Missing ID\" align=\"left\" height=\"28\" width=\"328\"></a> <a href=\"https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/18706487/20580498/119848/#/?version=2\"><img src=\"https://s3.amazonaws.com/cla-project-logo-prod/cla-not-signed.svg\" alt=\"CLA Not Signed\" align=\"left\" height=\"28\" width=\"328\"></a><br/><br /><ul><li> :x: The email address for the commit (c37a7f0dc536529f67f63d6afb5d6568bbf7c3d2) is not linked to the GitHub account, preventing the EasyCLA check. Consult <a href='https://confluence.linuxfoundation.org/pages/viewpage.action?pageId=86641302' target='_blank'>this Help Article</a> and <a href='https://help.github.com/en/github/committing-changes-to-your-project/why-are-my-commits-linked-to-the-wrong-user' target='_blank'>GitHub Help</a> to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, <a href='https://jira.linuxfoundation.org/servicedesk/customer/portal/4' target='_blank'>please submit a support request ticket</a>.</li></ul>", "created_at": "2023-08-09 05:27:37" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Aug 9 04:32:46 UTC 2023.\n", "created_at": "2023-08-09 05:27:38" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119848#\" title=\"Author self-approved\">nikzayn</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [jingxu97](https://github.com/jingxu97) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/kubelet/volumemanager/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/volumemanager/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"jingxu97\"]} -->", "created_at": "2023-08-09 05:27:40" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 05:27:42" }, { "body": "Hi @nikzayn. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-08-09 05:27:43" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-09 05:27:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 05:27:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 05:27:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 05:27:39", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 05:27:39", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 05:27:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 05:27:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 05:27:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 05:27:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 05:27:42", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 05:27:42", "type": "labeled" }, { "author": "nikzayn", "created_at": "2023-08-09 05:27:43", "type": "mentioned" }, { "author": "nikzayn", "created_at": "2023-08-09 05:27:43", "type": "subscribed" }, { "author": "nikzayn", "created_at": "2023-08-09 06:43:32", "type": "closed" }, { "author": "nikzayn", "created_at": "2023-08-09 08:16:41", "type": "head_ref_deleted" } ]

[ "saschagrunert", "liggitt", "cpanato", "nikhita" ]

[ "lgtm", "size/L", "kind/feature", "area/release-eng", "release-note-none", "approved", "cncf-cla: yes", "sig/release", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Aug 8 22:33:53 UTC 2023.\n", "created_at": "2023-08-09 00:06:58" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 00:07:03" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-09 00:15:49" }, { "body": "LGTM label has been added. <details>Git tree hash: ada4bb9ce5093161f3ec7b2e81420de6346d01e0</details>", "created_at": "2023-08-09 00:15:55" }, { "body": "/retest", "created_at": "2023-08-09 01:07:50" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119847#\" title=\"Author self-approved\">jeremyrickard</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119847#issuecomment-1670474431\" title=\"Approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119847#pullrequestreview-1568627588\" title=\"Approved\">nikhita</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/publishing/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/publishing/OWNERS)~~ [liggitt,nikhita]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-09 02:58:57" }, { "body": "/milestone v1.28", "created_at": "2023-08-09 15:25:28" } ]

[ { "author": "saschagrunert", "created_at": "2023-08-09 00:06:55", "type": "mentioned" }, { "author": "saschagrunert", "created_at": "2023-08-09 00:06:55", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-09 00:06:55", "type": "mentioned" }, { "author": "cpanato", "created_at": "2023-08-09 00:06:55", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-09 00:06:55", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 00:06:55", "type": "subscribed" }, { "author": "nikhita", "created_at": "2023-08-09 00:06:56", "type": "mentioned" }, { "author": "nikhita", "created_at": "2023-08-09 00:06:56", "type": "subscribed" }, { "author": "justaugustus", "created_at": "2023-08-09 00:06:56", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-09 00:06:56", "type": "subscribed" }, { "author": "cici37", "created_at": "2023-08-09 00:06:56", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:06:56", "type": "labeled" }, { "author": "salaxander", "created_at": "2023-08-09 00:06:56", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:06:56", "type": "labeled" }, { "author": "palnabarun", "created_at": "2023-08-09 00:06:56", "type": "subscribed" }, { "author": "Verolop", "created_at": "2023-08-09 00:06:57", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-09 00:06:57", "type": "assigned" }, { "author": "xmudrii", "created_at": "2023-08-09 00:06:57", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:06:57", "type": "labeled" }, { "author": "ameukam", "created_at": "2023-08-09 00:06:57", "type": "subscribed" }, { "author": "k8s-release-robot", "created_at": "2023-08-09 00:06:57", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:06:57", "type": "labeled" }, { "author": "ramrodo", "created_at": "2023-08-09 00:06:57", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-09 00:06:57", "type": "subscribed" }, { "author": "puerco", "created_at": "2023-08-09 00:06:57", "type": "subscribed" }, { "author": "gracenng", "created_at": "2023-08-09 00:06:57", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-09 00:06:57", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-09 00:06:57", "type": "assigned" }, { "author": "jimangel", "created_at": "2023-08-09 00:06:57", "type": "subscribed" }, { "author": "jrsapi", "created_at": "2023-08-09 00:06:57", "type": "subscribed" }, { "author": "nikhita", "created_at": "2023-08-09 00:06:57", "type": "assigned" }, { "author": "saschagrunert", "created_at": "2023-08-09 00:06:58", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:06:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:07:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:07:00", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:07:00", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:07:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:07:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:07:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:07:03", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:07:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:15:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:15:56", "type": "labeled" }, { "author": "jeremyrickard", "created_at": "2023-08-09 00:42:06", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-09 00:42:06", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 14:29:46", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:25:31", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:25:51", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:25:51", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:25:51", "type": "closed" } ]

[]

[ "kind/bug", "sig/storage", "release-note", "size/S", "cncf-cla: no", "needs-ok-to-test", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 22:33:07 UTC 2023.\n", "created_at": "2023-08-08 22:03:58" }, { "body": " <a href=\"https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/18706487/20580498/119845/#/?version=2\"><img src=\"https://s3.amazonaws.com/cla-project-logo-prod/cla-not-signed.svg\" alt=\"CLA Not Signed\" align=\"left\" height=\"28\" width=\"328\"></a><br/><br /><ul><li><a href='https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/18706487/20580498/119845/#/?version=2' target='_blank'>:x:</a> - login: @ADustyOldMuffin / name: Daniel Hix . The commit (afda652488be698bc2280d55c909fcc1b437d2cd) is not authorized under a signed CLA. <a href='https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/18706487/20580498/119845/#/?version=2' target='_blank'>Please click here to be authorized</a>. For further assistance with EasyCLA, <a href='https://jira.linuxfoundation.org/servicedesk/customer/portal/4' target='_blank'>please submit a support request ticket</a>.</li><li><a href='https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/18706487/20580498/119845/#/?version=2' target='_blank'>:x:</a> - login: @robbat2 / name: Robin H. Johnson . The commit (afda652488be698bc2280d55c909fcc1b437d2cd) is not authorized under a signed CLA. <a href='https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/18706487/20580498/119845/#/?version=2' target='_blank'>Please click here to be authorized</a>. For further assistance with EasyCLA, <a href='https://jira.linuxfoundation.org/servicedesk/customer/portal/4' target='_blank'>please submit a support request ticket</a>.</li></ul>", "created_at": "2023-08-08 22:04:00" }, { "body": "Welcome @ADustyOldMuffin! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:", "created_at": "2023-08-08 22:04:01" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 22:04:02" }, { "body": "Hi @ADustyOldMuffin. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-08-08 22:04:02" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119845#\" title=\"Author self-approved\">ADustyOldMuffin</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [saad-ali](https://github.com/saad-ali) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/mount-utils/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/mount-utils/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"saad-ali\"]} -->", "created_at": "2023-08-08 22:04:28" }, { "body": "I'm waiting on my organization for the EasyCLA check, but I'm looking for conversation around this solution and if it works and/or how to go about e2e testing for this past unit testing.", "created_at": "2023-08-08 22:13:48" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-08 22:03:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 22:03:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 22:03:56", "type": "labeled" }, { "author": "robbat2", "created_at": "2023-08-08 22:04:00", "type": "mentioned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 22:04:00", "type": "labeled" }, { "author": "robbat2", "created_at": "2023-08-08 22:04:00", "type": "subscribed" }, { "author": "ADustyOldMuffin", "created_at": "2023-08-08 22:04:00", "type": "mentioned" }, { "author": "ADustyOldMuffin", "created_at": "2023-08-08 22:04:01", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 22:04:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 22:04:02", "type": "labeled" }, { "author": "ADustyOldMuffin", "created_at": "2023-08-08 22:04:02", "type": "mentioned" }, { "author": "ADustyOldMuffin", "created_at": "2023-08-08 22:04:02", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 22:04:02", "type": "labeled" }, { "author": "ADustyOldMuffin", "created_at": "2023-08-08 22:04:03", "type": "mentioned" }, { "author": "ADustyOldMuffin", "created_at": "2023-08-08 22:04:03", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 22:04:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 22:04:27", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 22:04:27", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 22:04:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 22:04:29", "type": "unlabeled" } ]

[ "liggitt" ]

[ "priority/backlog", "kind/cleanup", "area/apiserver", "lgtm", "sig/api-machinery", "size/M", "release-note-none", "sig/auth", "approved", "cncf-cla: yes", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 22:33:07 UTC 2023.\n", "created_at": "2023-08-08 21:45:35" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-10 16:36:28" }, { "body": "LGTM label has been added. <details>Git tree hash: 584d81b8bbe7ff52a7adf5bab29cbc4f7527ed6e</details>", "created_at": "2023-08-10 16:36:34" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119844#\" title=\"Author self-approved\">enj</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119844#issuecomment-1673554333\" title=\"Approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/apimachinery/pkg/util/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/util/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/apiserver/pkg/authentication/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/authentication/OWNERS)~~ [enj,liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-10 16:36:50" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:45:33", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-08-08 21:45:33", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:45:33", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:45:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:45:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:45:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:45:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:45:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:45:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:46:06", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:46:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:46:06", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:46:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:46:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:46:09", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:36:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:36:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:39", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:39", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:39", "type": "closed" } ]

[ "liggitt", "a-hilaly" ]

[ "kind/bug", "area/test", "sig/api-machinery", "size/XS", "kind/flake", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "needs-priority", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 22:33:07 UTC 2023.\n", "created_at": "2023-08-08 21:23:46" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-08 21:36:36" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119843#\" title=\"Author self-approved\">jpbetz</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119843#issuecomment-1670341435\" title=\"Approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e/apimachinery/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/apimachinery/OWNERS)~~ [jpbetz,liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-08 21:36:43" }, { "body": "/retest", "created_at": "2023-08-08 22:09:13" }, { "body": "/retest\r\n(to force multiple runs and build confidence this fixes the flake)", "created_at": "2023-08-08 22:55:08" }, { "body": "/test all", "created_at": "2023-08-08 22:56:16" }, { "body": "/test all", "created_at": "2023-08-09 00:03:28" }, { "body": "/test all", "created_at": "2023-08-09 01:05:31" }, { "body": "/test all", "created_at": "2023-08-09 07:43:13" }, { "body": "looks like the failures seen in `pull-kubernetes-e2e-kind-ipv6` are not related to this test. I will cancel my lgtm and continue re-running the tests this morning\r\n/lgtm cancel", "created_at": "2023-08-09 07:45:00" }, { "body": "/test all", "created_at": "2023-08-09 08:45:38" }, { "body": "/test all", "created_at": "2023-08-09 10:12:05" }, { "body": "@jpbetz: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-e2e-kind-ipv6 | 4759ce7ed9eb0d7849b33bb7044fca1cf0979534 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119843/pull-kubernetes-e2e-kind-ipv6/1689217991100600320) | true | `/test pull-kubernetes-e2e-kind-ipv6`\npull-kubernetes-e2e-kind | 4759ce7ed9eb0d7849b33bb7044fca1cf0979534 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119843/pull-kubernetes-e2e-kind/1689217991050268672) | true | `/test pull-kubernetes-e2e-kind`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119843). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Ajpbetz). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-08-09 10:43:00" }, { "body": "the last to jobs are failing the test this PR is supposed to fix\r\n\r\n> pull-kubernetes-e2e-kind-ipv6\t4759ce7\tlink\ttrue\t/test pull-kubernetes-e2e-kind-ipv6\r\n> pull-kubernetes-e2e-kind\t4759ce7\tlink\ttrue\t/test pull-kubernetes-e2e-kind\r\n\r\nthis means that is highly probable the root cause of the flakiness is related to this\r\n\r\nhttps://screenshot.googleplex.com/8JmDrDK69AUdQbm\r\n\r\nI think this is still flaky", "created_at": "2023-08-09 11:37:52" }, { "body": "@aojea i ran the tests a few times this morning and only one round failed. They are still flaky.. I'm currently trying to debug and reproduce locally.", "created_at": "2023-08-09 11:41:27" }, { "body": "Yep, still flaking. That's too bad. I think we should still constrain to namespace scope, but the search continues.\r\n\r\n@a-hilaly WDYT about removing this test until we have one that we can confirm does not flake? This is having a major impact on CI.", "created_at": "2023-08-09 15:37:00" }, { "body": "> WDYT about removing this test until we have one that we can confirm does not flake? This is having a major impact on CI.\r\n\r\n@jpbetz Yeah that sounds good. I can send PR removing the test and work on fixing/replacing it in a separate PR. would that work?", "created_at": "2023-08-09 16:07:03" }, { "body": "> > WDYT about removing this test until we have one that we can confirm does not flake? This is having a major impact on CI.\r\n> \r\n> Joe Betz Yeah that sounds good. I can send PR removing the test and work on fixing/replacing it in a separate PR. would that work?\r\n\r\nYes, that would be great. Thanks!\r\n\r\nFor the replacement PR, let's run `/test all` a bunch of times and show that we're flake free before we merge.", "created_at": "2023-08-09 16:14:04" }, { "body": "/close\r\n\r\nThis does not fix the flake. @a-hilaly will remove the test in the short term, and long term, replace the test. We'll make sure the webhook matching is namespace scoped in the replacement PR.", "created_at": "2023-08-09 16:15:46" }, { "body": "@jpbetz: Closed this PR.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119843#issuecomment-1671737199):\n\n>/close\r\n>\r\n>This does not fix the flake. @a-hilaly will remove the test in the short term, and long term, replace the test. We'll make sure the webhook matching is namespace scoped in the replacement PR.\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 16:15:52" }, { "body": "@jpbetz I just opened https://github.com/kubernetes/kubernetes/pull/119869 - i'll continue testing for in the PR. And locally i'm running the webhook e2e tests in a loop.\r\n\r\nI'll work on replacing that test as soon as possible.", "created_at": "2023-08-09 17:40:03" }, { "body": "/triage accepted", "created_at": "2023-08-15 20:12:40" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:23:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:23:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:23:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:23:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:23:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:23:48", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:23:48", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:23:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:23:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:23:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:23:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:23:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:23:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:23:51", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:23:52", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-08-08 21:36:41", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:36:42", "type": "labeled" }, { "author": "jpbetz", "created_at": "2023-08-08 21:50:58", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-08 21:50:58", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-09 00:28:52", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-09 00:28:52", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-09 00:59:40", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-09 00:59:40", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-09 01:35:58", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-09 01:35:58", "type": "subscribed" }, { "author": "a-hilaly", "created_at": "2023-08-09 07:43:08", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 07:45:06", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 07:45:07", "type": "review_requested" }, { "author": "jpbetz", "created_at": "2023-08-09 08:13:09", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-09 08:13:09", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-09 08:24:12", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-09 08:24:12", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-09 09:13:00", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-09 09:13:00", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-09 10:40:32", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-09 10:40:32", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-09 10:43:00", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-09 10:43:01", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-08-09 11:41:28", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-09 11:41:28", "type": "subscribed" }, { "author": "a-hilaly", "created_at": "2023-08-09 15:37:00", "type": "mentioned" }, { "author": "a-hilaly", "created_at": "2023-08-09 15:37:00", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-09 16:07:03", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-09 16:07:03", "type": "subscribed" }, { "author": "a-hilaly", "created_at": "2023-08-09 16:15:47", "type": "mentioned" }, { "author": "a-hilaly", "created_at": "2023-08-09 16:15:47", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:15:51", "type": "closed" }, { "author": "jpbetz", "created_at": "2023-08-09 16:15:53", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-09 16:15:53", "type": "subscribed" }, { "author": "a-hilaly", "created_at": "2023-08-09 16:15:53", "type": "mentioned" }, { "author": "a-hilaly", "created_at": "2023-08-09 16:15:53", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-09 17:40:03", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-09 17:40:03", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 21:08:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 21:08:50", "type": "unlabeled" } ]

[ "Jefftree", "deads2k" ]

[ "kind/bug", "sig/api-machinery", "release-note", "size/XXL", "cncf-cla: yes", "do-not-merge/cherry-pick-not-approved", "needs-priority", "kind/regression", "triage/accepted" ]

[ { "body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 20:45:14" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119841#\" title=\"Author self-approved\">atiratree</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [smarterclayton](https://github.com/smarterclayton) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[api/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/api/OWNERS)**\n- **[staging/src/k8s.io/kube-aggregator/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/kube-aggregator/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"smarterclayton\"]} -->", "created_at": "2023-08-08 20:45:17" }, { "body": "/kind bug\r\n/kind regression\r\n/sig api-machinery\r\n/assign @Jefftree\r\n/assign @deads2k ", "created_at": "2023-08-08 20:46:34" }, { "body": "Not sure if we should backport this further back, but we should at least do 1.27, since the OpenAPIV3 feature has been graduated to stable.", "created_at": "2023-08-08 20:48:21" }, { "body": "cc @alexzielenski ", "created_at": "2023-08-08 20:49:44" }, { "body": "/test pull-kubernetes-node-e2e-containerd", "created_at": "2023-08-09 12:34:13" }, { "body": "/triage accepted\r\n", "created_at": "2023-08-10 16:42:10" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:45:14", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:45:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:45:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:45:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:45:17", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:45:17", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:45:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:45:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:45:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:45:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:45:36", "type": "labeled" }, { "author": "Jefftree", "created_at": "2023-08-08 20:46:34", "type": "mentioned" }, { "author": "Jefftree", "created_at": "2023-08-08 20:46:34", "type": "subscribed" }, { "author": "deads2k", "created_at": "2023-08-08 20:46:34", "type": "mentioned" }, { "author": "deads2k", "created_at": "2023-08-08 20:46:34", "type": "subscribed" }, { "author": "deads2k", "created_at": "2023-08-08 20:46:36", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:46:36", "type": "labeled" }, { "author": "Jefftree", "created_at": "2023-08-08 20:46:36", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:46:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:46:38", "type": "unlabeled" }, { "author": "alexzielenski", "created_at": "2023-08-08 20:49:45", "type": "mentioned" }, { "author": "alexzielenski", "created_at": "2023-08-08 20:49:45", "type": "subscribed" }, { "author": "atiratree", "created_at": "2023-08-08 21:10:54", "type": "mentioned" }, { "author": "atiratree", "created_at": "2023-08-08 21:10:54", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:42:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:42:15", "type": "unlabeled" } ]

[ "seans3" ]

[ "kind/cleanup", "sig/api-machinery", "triage/accepted" ]

[ { "body": "/sig api-machinery", "created_at": "2023-08-08 20:41:24" }, { "body": "/assign", "created_at": "2023-08-08 20:44:20" }, { "body": "> * any aggregated api server returning malformed discovery.\r\n\r\nfor subresources which don't accept/return Kubernetes API objects, it's actually correct to not return a kind, so I'm not sure I'd call that malformed", "created_at": "2023-08-09 17:01:56" }, { "body": "Istio client fixed: https://github.com/istio/istio/issues/46396", "created_at": "2023-08-09 18:46:32" }, { "body": "Can you provide a pr for client-go fix？", "created_at": "2023-08-10 00:54:09" }, { "body": "> Can you provide a pr for client-go fix？\r\n\r\nIt was already fixed in 0.26.4+ in https://github.com/kubernetes/kubernetes/pull/116603\r\n\r\nthis issue is tracking propagating adoption of that fix, along with any follow up server-side mitigations like https://github.com/kubernetes/kubernetes/pull/119835", "created_at": "2023-08-10 01:35:14" }, { "body": "@seans3, given the server-side mitigation getting backported to 1.26 and 1.27, we may want to hold off on encouraging client updates until 1.26.8 and 1.27.5 are released that will include https://github.com/kubernetes/kubernetes/pull/119835, and encourage folks to update to v0.26.8 and v0.27.5 instead, so they get the empty GVK filtering as well", "created_at": "2023-08-10 01:49:20" }, { "body": "/triage accepted", "created_at": "2023-08-10 16:44:56" }, { "body": "switching this from bug to cleanup since the bug is already fixed in k8s and this is tracking propagation effort", "created_at": "2023-08-11 14:20:42" } ]

[ { "author": "seans3", "created_at": "2023-08-08 20:40:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:41:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:41:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:41:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:41:28", "type": "unlabeled" }, { "author": "seans3", "created_at": "2023-08-08 20:44:21", "type": "assigned" }, { "author": "seans3", "created_at": "2023-08-10 01:49:20", "type": "mentioned" }, { "author": "seans3", "created_at": "2023-08-10 01:49:21", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:44:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:44:59", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-11 14:20:23", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-11 14:20:23", "type": "labeled" }, { "author": "brandond", "created_at": "2023-08-15 22:15:04", "type": "referenced" }, { "author": "brandond", "created_at": "2023-08-15 22:16:09", "type": "referenced" } ]

[ "sttts", "Jefftree" ]

[ "kind/bug", "lgtm", "sig/api-machinery", "size/XS", "release-note-none", "approved", "cncf-cla: yes", "do-not-merge/cherry-pick-not-approved", "needs-priority", "kind/regression", "triage/accepted" ]

[ { "body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 20:26:52" }, { "body": "/kind bug\r\n/kind regression\r\n/sig api-machinery\r\n/assign @Jefftree \r\n/assign @sttts ", "created_at": "2023-08-08 20:30:01" }, { "body": "Not sure if we should backport this further back, but we should at least do 1.27, since the OpenAPIV3 feature has been graduated to stable. ", "created_at": "2023-08-08 20:34:22" }, { "body": "cc @alexzielenski ", "created_at": "2023-08-08 20:49:38" }, { "body": "/triage accepted", "created_at": "2023-08-10 16:42:50" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-15 08:07:50" }, { "body": "LGTM label has been added. <details>Git tree hash: 38cfbfa3106856cdcdbc3bc270ad6dd2015bf70c</details>", "created_at": "2023-08-15 08:07:57" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119839#\" title=\"Author self-approved\">atiratree</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119839#issuecomment-1678565424\" title=\"Approved\">sttts</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/kube-aggregator/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/kube-aggregator/OWNERS)~~ [sttts]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-15 08:08:18" }, { "body": "/cc kubernetes/release-managers", "created_at": "2023-08-23 21:09:06" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:26:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:26:51", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:26:51", "type": "labeled" }, { "author": "atiratree", "created_at": "2023-08-08 20:26:51", "type": "mentioned" }, { "author": "atiratree", "created_at": "2023-08-08 20:26:51", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:26:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:26:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:26:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:26:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:26:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:26:59", "type": "labeled" }, { "author": "sttts", "created_at": "2023-08-08 20:30:01", "type": "mentioned" }, { "author": "sttts", "created_at": "2023-08-08 20:30:01", "type": "subscribed" }, { "author": "Jefftree", "created_at": "2023-08-08 20:30:02", "type": "mentioned" }, { "author": "Jefftree", "created_at": "2023-08-08 20:30:02", "type": "subscribed" }, { "author": "Jefftree", "created_at": "2023-08-08 20:30:02", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:30:03", "type": "labeled" }, { "author": "sttts", "created_at": "2023-08-08 20:30:03", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:30:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:30:05", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:30:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:30:07", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:32:21", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:32:21", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:35:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:35:21", "type": "unlabeled" }, { "author": "alexzielenski", "created_at": "2023-08-08 20:49:39", "type": "mentioned" }, { "author": "alexzielenski", "created_at": "2023-08-08 20:49:39", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:42:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 16:42:54", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 08:07:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 08:08:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 21:09:08", "type": "review_requested" } ]

[ "haircommander" ]

[ "kind/bug", "sig/node", "triage/accepted" ]

[ { "body": "/sig node", "created_at": "2023-08-08 21:46:29" }, { "body": "Not sure who worked on that feature but I see @vinaykul on the latest with this. ", "created_at": "2023-08-08 21:49:08" }, { "body": "/retitle Container resize policy feature introduced in v1.27 doesn't interrupt CrashLoopBackOff", "created_at": "2023-08-09 17:55:29" }, { "body": "xref to the enhancement: #1287", "created_at": "2023-08-09 17:57:01" }, { "body": "/triage accepted\r\n/assign @haircommander ", "created_at": "2023-08-09 17:57:16" }, { "body": "> xref to the enhancement: #1287\r\n\r\nI had no idea how this was related to the issue. I realize that you meant to include [#1287](https://github.com/kubernetes/enhancements/issues/1287) rather than k/k.", "created_at": "2023-08-09 17:59:32" } ]

[ { "author": "daqo98", "created_at": "2023-08-08 19:01:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 19:01:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 19:01:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:46:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:46:32", "type": "unlabeled" }, { "author": "vinaykul", "created_at": "2023-08-08 21:49:09", "type": "mentioned" }, { "author": "vinaykul", "created_at": "2023-08-08 21:49:09", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 17:55:30", "type": "renamed" }, { "author": "haircommander", "created_at": "2023-08-09 17:57:16", "type": "mentioned" }, { "author": "haircommander", "created_at": "2023-08-09 17:57:17", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 17:57:18", "type": "labeled" }, { "author": "haircommander", "created_at": "2023-08-09 17:57:18", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 17:57:19", "type": "unlabeled" } ]

[ "saschagrunert", "liggitt", "cpanato" ]

[ "area/test", "lgtm", "sig/storage", "sig/node", "release-note", "size/M", "kind/feature", "area/release-eng", "cherry-pick-approved", "sig/apps", "approved", "cncf-cla: yes", "sig/testing", "sig/release", "sig/cloud-provider", "needs-priority", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 18:56:16" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-08 21:22:12" }, { "body": "LGTM label has been added. <details>Git tree hash: 64e5acd2d446ce90d9fe82f9373ea7031a909e1c</details>", "created_at": "2023-08-08 21:22:20" }, { "body": "/test pull-kubernetes-verify", "created_at": "2023-08-08 22:04:06" }, { "body": "1.24 is done, right? (this PR isn't to merge)", "created_at": "2023-08-08 22:57:29" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-09 00:14:44" }, { "body": "LGTM label has been added. <details>Git tree hash: c05c22d1039f3196b905e9c18c682ca174f615d2</details>", "created_at": "2023-08-09 00:14:50" }, { "body": "/retest\r\n\r\nthe vet error is weird… nothing in vet changed between 1.20.6 and 1.20.7", "created_at": "2023-08-09 03:21:26" }, { "body": "Might need to pick https://github.com/kubernetes/kubernetes/pull/111846 but I have no idea why CI chose *now* to complain about this on release-1.24", "created_at": "2023-08-09 03:29:12" }, { "body": "> Might need to pick #111846 but I have no idea why CI chose _now_ to complain about this on release-1.24\r\n\r\nOK, to test this out I cherry picked that into this PR. If it's successful I can remove it and do a separate cherry pick PR and rebase on the branch after that goes in. ", "created_at": "2023-08-09 16:13:04" }, { "body": "> If it's successful I can remove it and do a separate cherry pick PR and rebase on the branch after that goes in.\r\n\r\nif it's successful I don't mind merging it in a single PR", "created_at": "2023-08-09 16:15:14" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-09 16:24:16" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119837#\" title=\"Author self-approved\">jeremyrickard</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119837#issuecomment-1671750570\" title=\"Approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.24/OWNERS)~~ [liggitt]\n- ~~[pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.24/pkg/apis/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-09 16:24:23" }, { "body": "LGTM label has been added. <details>Git tree hash: 38ef5e3bdc961ce206941920fd5be3d00190ab1c</details>", "created_at": "2023-08-09 16:24:23" }, { "body": "/retest", "created_at": "2023-08-09 17:28:33" }, { "body": "/retest", "created_at": "2023-08-09 19:46:34" } ]

[ { "author": "saschagrunert", "created_at": "2023-08-08 18:56:08", "type": "mentioned" }, { "author": "saschagrunert", "created_at": "2023-08-08 18:56:08", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-08 18:56:08", "type": "mentioned" }, { "author": "cpanato", "created_at": "2023-08-08 18:56:09", "type": "subscribed" }, { "author": "justaugustus", "created_at": "2023-08-08 18:56:09", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-08 18:56:09", "type": "subscribed" }, { "author": "salaxander", "created_at": "2023-08-08 18:56:09", "type": "subscribed" }, { "author": "Verolop", "created_at": "2023-08-08 18:56:09", "type": "subscribed" }, { "author": "cici37", "created_at": "2023-08-08 18:56:09", "type": "subscribed" }, { "author": "ameukam", "created_at": "2023-08-08 18:56:09", "type": "subscribed" }, { "author": "palnabarun", "created_at": "2023-08-08 18:56:09", "type": "subscribed" }, { "author": "ramrodo", "created_at": "2023-08-08 18:56:09", "type": "subscribed" }, { "author": "xmudrii", "created_at": "2023-08-08 18:56:09", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:56:10", "type": "labeled" }, { "author": "puerco", "created_at": "2023-08-08 18:56:10", "type": "subscribed" }, { "author": "k8s-release-robot", "created_at": "2023-08-08 18:56:10", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:56:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:56:10", "type": "milestoned" }, { "author": "cpanato", "created_at": "2023-08-08 18:56:10", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 18:56:10", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-08 18:56:10", "type": "assigned" }, { "author": "jimangel", "created_at": "2023-08-08 18:56:10", "type": "subscribed" }, { "author": "gracenng", "created_at": "2023-08-08 18:56:10", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:56:10", "type": "labeled" }, { "author": "jrsapi", "created_at": "2023-08-08 18:56:10", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:56:10", "type": "labeled" }, { "author": "saschagrunert", "created_at": "2023-08-08 18:56:10", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:56:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:56:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:56:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:56:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 19:01:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 19:01:21", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 19:01:21", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 19:01:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 19:01:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 19:01:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 19:01:24", "type": "unlabeled" }, { "author": "jeremyrickard", "created_at": "2023-08-08 19:03:15", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 19:03:15", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 19:46:37", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 19:46:37", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 19:53:03", "type": "head_ref_force_pushed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 20:45:34", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 20:45:34", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 20:53:30", "type": "head_ref_force_pushed" }, { "author": "liggitt", "created_at": "2023-08-08 21:22:17", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:22:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:22:36", "type": "labeled" }, { "author": "jeremyrickard", "created_at": "2023-08-08 21:53:27", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 21:53:27", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 22:57:32", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 22:57:32", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:12:48", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:12:49", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:12:49", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:12:49", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 00:14:48", "type": "labeled" }, { "author": "jeremyrickard", "created_at": "2023-08-09 01:04:16", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-09 01:04:17", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-09 04:12:25", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-09 04:12:25", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:12:06", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:12:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:12:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:12:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:12:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:24:21", "type": "labeled" }, { "author": "jeremyrickard", "created_at": "2023-08-09 17:10:39", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-09 17:10:39", "type": "subscribed" }, { "author": "Verolop", "created_at": "2023-08-09 21:27:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 21:27:41", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 21:29:32", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 21:29:32", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 21:29:32", "type": "closed" } ]

[ "saschagrunert", "liggitt", "cpanato" ]

[ "area/test", "lgtm", "release-note", "size/L", "kind/feature", "area/release-eng", "cherry-pick-approved", "approved", "cncf-cla: yes", "sig/testing", "sig/release", "needs-priority", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 18:32:04" }, { "body": "/retest", "created_at": "2023-08-08 20:05:35" }, { "body": "@dims @liggitt could you review this one? ", "created_at": "2023-08-09 13:21:15" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-09 13:33:51" }, { "body": "LGTM label has been added. <details>Git tree hash: c84786ab24da99aec8d5eadf9bab6b7a35fcdc4b</details>", "created_at": "2023-08-09 13:33:59" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119836#\" title=\"Author self-approved\">jeremyrickard</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119836#issuecomment-1671337707\" title=\"Approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.25/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-09 13:35:20" } ]

[ { "author": "saschagrunert", "created_at": "2023-08-08 18:31:55", "type": "mentioned" }, { "author": "saschagrunert", "created_at": "2023-08-08 18:31:55", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-08 18:31:55", "type": "mentioned" }, { "author": "cpanato", "created_at": "2023-08-08 18:31:55", "type": "subscribed" }, { "author": "justaugustus", "created_at": "2023-08-08 18:31:55", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-08 18:31:56", "type": "subscribed" }, { "author": "salaxander", "created_at": "2023-08-08 18:31:56", "type": "subscribed" }, { "author": "cici37", "created_at": "2023-08-08 18:31:56", "type": "subscribed" }, { "author": "Verolop", "created_at": "2023-08-08 18:31:56", "type": "subscribed" }, { "author": "palnabarun", "created_at": "2023-08-08 18:31:56", "type": "subscribed" }, { "author": "ameukam", "created_at": "2023-08-08 18:31:56", "type": "subscribed" }, { "author": "xmudrii", "created_at": "2023-08-08 18:31:56", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:31:56", "type": "labeled" }, { "author": "ramrodo", "created_at": "2023-08-08 18:31:56", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:31:56", "type": "labeled" }, { "author": "k8s-release-robot", "created_at": "2023-08-08 18:31:56", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:31:56", "type": "milestoned" }, { "author": "puerco", "created_at": "2023-08-08 18:31:56", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 18:31:56", "type": "subscribed" }, { "author": "gracenng", "created_at": "2023-08-08 18:31:56", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-08 18:31:56", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:31:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:31:56", "type": "labeled" }, { "author": "jimangel", "created_at": "2023-08-08 18:31:56", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-08 18:31:56", "type": "assigned" }, { "author": "jrsapi", "created_at": "2023-08-08 18:31:56", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-08 18:31:57", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:32:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:32:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:32:00", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:32:00", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:32:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:32:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:32:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:32:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:32:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:32:05", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:32:05", "type": "labeled" }, { "author": "jeremyrickard", "created_at": "2023-08-08 18:39:41", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 18:39:41", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 19:20:35", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 19:20:36", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 19:48:16", "type": "head_ref_force_pushed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 19:55:04", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 19:55:04", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 20:10:26", "type": "head_ref_force_pushed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 20:52:28", "type": "head_ref_force_pushed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 21:37:18", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 21:37:18", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 21:44:26", "type": "head_ref_force_pushed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 23:41:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 23:41:35", "type": "unlabeled" }, { "author": "jeremyrickard", "created_at": "2023-08-08 23:41:53", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 23:41:54", "type": "labeled" }, { "author": "dims", "created_at": "2023-08-09 13:21:15", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-09 13:21:16", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-09 13:21:16", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 13:21:16", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-09 13:33:56", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 13:33:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 13:35:21", "type": "labeled" }, { "author": "Verolop", "created_at": "2023-08-09 14:21:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 14:21:32", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 14:21:52", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 14:21:52", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 14:21:52", "type": "closed" } ]

[ "dims" ]

[ "kind/bug", "area/test", "priority/critical-urgent", "area/apiserver", "lgtm", "sig/api-machinery", "release-note", "size/L", "kind/api-change", "approved", "cncf-cla: yes", "sig/testing", "area/code-generation", "kind/regression", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 22:33:07 UTC 2023.\n", "created_at": "2023-08-08 18:29:36" }, { "body": "/milestone v1.29\r\n\r\nif we do this, we'll merge into 1.29 and backport, this isn't blocking for 1.28", "created_at": "2023-08-08 18:30:17" }, { "body": "cc @deads2k @jpbetz \r\nfor api-machinery visibility", "created_at": "2023-08-08 18:43:39" }, { "body": "(I'll add more tests if we get agreement on this direction)", "created_at": "2023-08-08 19:08:02" }, { "body": "+1 from me on the direction! 🧭 ", "created_at": "2023-08-08 19:20:05" }, { "body": "/triage accepted", "created_at": "2023-08-08 20:06:50" }, { "body": "/cc @Jefftree ", "created_at": "2023-08-08 20:07:04" }, { "body": "> The backported added a check here: https://github.com/seans3/kubernetes/blob/26bf8a7ceb51bac357d8a02fd3e62b84363716db/staging/src/k8s.io/client-go/discovery/aggregated_discovery.go#L96-L98 whereas we're always appending in v1.26.3 (https://github.com/kubernetes/kubernetes/blob/v1.26.3/staging/src/k8s.io/client-go/discovery/aggregated_discovery.go#L95-L96)\r\n> \r\n> I'm not really sure if this can be fixed with a server side only change but thought it would be important to bring up.\r\n\r\nAgreed... I don't love the extra entry, but I'd expect us to also backport the client-go change that filters empty GVK parent entries. That leads to the following outcomes:\r\n\r\n1. People updating to latest client patch versions of 0.26.x would be in good shape\r\n2. People updating to latest client patch versions of 0.27.x would be in good shape\r\n3. People not updating to latest client patch versions of 0.26.x would be saved from panic crashes but would have an extra entry for the parent with empty GVK\r\n4. People not updating to latest client patch versions of 0.27.x would have an extra entry for the parent with empty GVK\r\n\r\nI think I'd prioritize not crashing v0.26.0 clients over avoiding the empty GVK entry for v0.27.0 clients (and encourage all clients to update to latest patches in general)", "created_at": "2023-08-08 20:17:29" }, { "body": "> I think I'd prioritize not crashing v0.26.0 clients over avoiding the empty GVK entry for v0.27.0 clients (and encourage all clients to update to latest patches in general)\r\n\r\nAs long as we agree on this point, +1 on direction", "created_at": "2023-08-09 15:11:51" }, { "body": "Thinking about this more, I'd actually consider this for 1.28 if possible. It would be nice if we could contain the server behavior that crashes v0.26.0 clients to a single release, and we know that clients often stick on the .0 releases, so getting this into client-go v0.28.0 would be ideal", "created_at": "2023-08-09 15:21:56" }, { "body": "I added tests so all the changes have coverage now", "created_at": "2023-08-09 15:22:13" }, { "body": "/retest\r\n\r\nunrelated OOMKiller node flake", "created_at": "2023-08-09 15:43:52" }, { "body": "LGTM, thanks for raising this and fixing!", "created_at": "2023-08-09 16:31:02" }, { "body": "/hold cancel", "created_at": "2023-08-09 16:32:36" }, { "body": "/retest", "created_at": "2023-08-09 17:02:12" }, { "body": "/retest", "created_at": "2023-08-09 17:07:01" }, { "body": "/approve\r\nFor SIG api-machinery\r\n\r\n+1 for inclusion in 1.28.0\r\n\r\nEDIT: clarified that I'd like to see this in 1.28.0 (not wait for 1.28.1)", "created_at": "2023-08-09 17:23:07" }, { "body": "/milestone v1.28\r\nper discussion in https://kubernetes.slack.com/archives/C0EG7JC6T/p1691598626756569\r\n\r\n1.27 and 1.26 picks open as well to exercise CI\r\n\r\n/hold for coordination with release team relative to rc1", "created_at": "2023-08-09 18:59:33" }, { "body": "OOMKiller flake (https://github.com/kubernetes/kubernetes/issues/119600)\r\n/retest", "created_at": "2023-08-09 19:24:10" }, { "body": "/retest", "created_at": "2023-08-09 19:35:40" }, { "body": "/approve\r\n/lgtm", "created_at": "2023-08-09 19:37:35" }, { "body": "LGTM label has been added. <details>Git tree hash: aa44f93e0fffc21295ab412964ccbf7b5050050f</details>", "created_at": "2023-08-09 19:37:45" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119835#issuecomment-1672036011\" title=\"LGTM\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119835#issuecomment-1671846784\" title=\"Approved\">jpbetz</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119835#\" title=\"Author self-approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/OWNERS)~~ [liggitt]\n- ~~[pkg/generated/openapi/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/generated/openapi/OWNERS)~~ [dims,liggitt]\n- ~~[staging/src/k8s.io/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/apiserver/pkg/endpoints/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/endpoints/OWNERS)~~ [dims,jpbetz,liggitt]\n- ~~[staging/src/k8s.io/client-go/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/OWNERS)~~ [dims,jpbetz,liggitt]\n- ~~[staging/src/k8s.io/kube-aggregator/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kube-aggregator/OWNERS)~~ [dims,jpbetz,liggitt]\n- ~~[test/integration/apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/integration/apiserver/OWNERS)~~ [dims,jpbetz,liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-09 19:37:59" }, { "body": "/retest", "created_at": "2023-08-09 20:36:43" }, { "body": "/hold cancel\r\n\r\nper release-manager discussion in https://kubernetes.slack.com/archives/CJH2GBF7Y/p1691607686137089", "created_at": "2023-08-09 21:35:36" }, { "body": "/priority critical-urgent", "created_at": "2023-08-09 21:39:47" } ]

[ { "author": "apelisse", "created_at": "2023-08-08 18:29:31", "type": "mentioned" }, { "author": "apelisse", "created_at": "2023-08-08 18:29:31", "type": "subscribed" }, { "author": "seans3", "created_at": "2023-08-08 18:29:31", "type": "mentioned" }, { "author": "seans3", "created_at": "2023-08-08 18:29:31", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-08 18:29:32", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-08 18:29:32", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:29:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:29:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:29:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:29:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:29:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:29:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:29:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:29:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:29:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:30:08", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:30:08", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:30:19", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:30:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:30:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:30:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:30:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:30:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:30:37", "type": "unlabeled" }, { "author": "deads2k", "created_at": "2023-08-08 18:43:39", "type": "mentioned" }, { "author": "deads2k", "created_at": "2023-08-08 18:43:39", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-08 18:43:50", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-08 18:43:50", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-08 18:59:57", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-08 18:59:57", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-08 19:28:00", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-08 19:28:00", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:06:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:06:54", "type": "unlabeled" }, { "author": "Jefftree", "created_at": "2023-08-08 20:07:04", "type": "mentioned" }, { "author": "Jefftree", "created_at": "2023-08-08 20:07:04", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:07:05", "type": "review_requested" }, { "author": "liggitt", "created_at": "2023-08-09 15:00:47", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:00:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:00:59", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-08-09 15:28:07", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 15:28:07", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-09 16:11:48", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 16:32:38", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-09 16:45:13", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 16:45:13", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-09 17:06:26", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 17:06:26", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-09 18:45:44", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:59:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:59:35", "type": "demilestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 18:59:35", "type": "milestoned" }, { "author": "liggitt", "created_at": "2023-08-09 19:14:18", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 19:14:18", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-09 19:26:35", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 19:26:35", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-09 19:37:42", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 19:37:43", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-08-09 20:13:20", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-09 20:13:20", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 21:35:37", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 21:39:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 21:39:51", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:37:31", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:37:31", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 22:37:31", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 14:13:35", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 14:13:36", "type": "referenced" }, { "author": "liggitt", "created_at": "2023-08-10 15:26:37", "type": "head_ref_deleted" } ]

[]

[ "sig/auth", "triage/accepted" ]

[ { "body": "Hi, @enj ,\r\nI would like to try this issue.\r\nWould you like to assign this to me?", "created_at": "2023-08-09 13:55:47" }, { "body": "/assign @pegasas \r\nFeel free to reassign this task if any concerns.", "created_at": "2023-08-09 14:01:00" }, { "body": "This issue is not ready to be worked on. It will require discussion with the other SIG Auth leads to determine the best course of action.\r\n\r\nFor the future, discuss assignment on Slack. For example, [sig-auth-authenticators-dev](https://kubernetes.slack.com/archives/C05EZFX1Z2L) is where we coordinate work in this area.\r\n\r\n/unassign pegasas ", "created_at": "2023-08-09 14:40:52" }, { "body": "Sure! Thanks @enj for clarification!\r\nWill continue follow this issue to see how it is settled.", "created_at": "2023-08-09 14:58:49" } ]

[ { "author": "aramase", "created_at": "2023-08-08 18:23:25", "type": "mentioned" }, { "author": "aramase", "created_at": "2023-08-08 18:23:25", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:23:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:23:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:23:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:23:42", "type": "unlabeled" }, { "author": "enj", "created_at": "2023-08-09 13:55:48", "type": "mentioned" }, { "author": "enj", "created_at": "2023-08-09 13:55:48", "type": "subscribed" }, { "author": "pegasas", "created_at": "2023-08-09 13:58:42", "type": "mentioned" }, { "author": "pegasas", "created_at": "2023-08-09 13:58:42", "type": "subscribed" }, { "author": "pegasas", "created_at": "2023-08-09 14:01:00", "type": "mentioned" }, { "author": "pegasas", "created_at": "2023-08-09 14:01:00", "type": "subscribed" }, { "author": "pegasas", "created_at": "2023-08-09 14:01:05", "type": "assigned" }, { "author": "pegasas", "created_at": "2023-08-09 14:41:14", "type": "unassigned" }, { "author": "enj", "created_at": "2023-08-09 14:58:50", "type": "mentioned" }, { "author": "enj", "created_at": "2023-08-09 14:58:50", "type": "subscribed" } ]

[ "Sharpz7" ]

[ "kind/cleanup", "sig/apps", "needs-triage", "wg/batch" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 18:19:01" }, { "body": "/sig apps", "created_at": "2023-08-08 18:19:10" }, { "body": "/remove-kind feature\r\n/kind cleanup", "created_at": "2023-08-08 18:25:09" }, { "body": "/wg batch", "created_at": "2023-08-08 18:25:57" }, { "body": "I am happy to give this a go. ", "created_at": "2023-08-08 18:31:00" }, { "body": "/assign", "created_at": "2023-08-08 18:31:26" }, { "body": "Just to check if I have the logic chain right:\r\n\r\nWe are talking about adding this logic here?https://github.com/kubernetes/kubernetes/blob/f0dcf0614036d8c3cd1c9f3b3cf8df4bb1d8e44e/pkg/controller/job/job_controller.go#L1143-L1145\r\n\r\nIf so, I should probably turn the backup-logic code into a function that then apply that in both places? \r\n\r\n```go\r\n\t\tif jobFinished {\r\n\t\t\tjm.recordJobFinished(jobCtx.job, jobCtx.finishedCondition)\r\n\t\t\tjm.backupRemovePodFinalizers()\r\n\t\t}\r\n```\r\n\r\nI also would be unsure of where in the unit tests this would be tested, are you able to point me to how this is tested in the deletePod function? I assume we add a pod that is never included in the \"uncounted\" lists.", "created_at": "2023-08-10 23:18:12" }, { "body": "> We are talking about adding this logic here?\r\n\r\nI would put it in the event handler, to be more of a \"catch all\"\r\n\r\nhttps://github.com/kubernetes/kubernetes/blob/6e0cb243d57592c917fe449dde20b0e246bc66be/pkg/controller/job/job_controller.go#L453\r\n\r\n> If so, I should probably turn the backup-logic code into a function that then apply that in both places?\r\n\r\nYes, that's a good idea.\r\n\r\n> I also would be unsure of where in the unit tests this would be tested, are you able to point me to how this is tested in the deletePod function? \r\n\r\nI think you would have to force it quite a bit, as we have fixed all the bugs that we have found.\r\n\r\nFor example, from the test:\r\n0. create the controller, but do not start the workers (this will setup the event handlers)\r\n1. create a job\r\n2. create the pods\r\n3. finish the job\r\n4. start the workers\r\n\r\nsome inspiration here https://github.com/kubernetes/kubernetes/blob/6e0cb243d57592c917fe449dde20b0e246bc66be/pkg/controller/job/job_controller_test.go#L4577\r\n", "created_at": "2023-08-11 12:37:13" }, { "body": "Alright, thank you :))", "created_at": "2023-08-11 14:57:15" }, { "body": "Should the issue title be:\r\n\r\n- Remove finalizers from **Pods** belonging to finished Jobs\r\n\r\n?", "created_at": "2023-08-14 16:57:36" }, { "body": "If someone has set a custom finalizer on a Pod, even one owned by a Job, (when) would we remove that finalizer?", "created_at": "2023-08-14 16:59:42" }, { "body": "/retitle Remove tracking finalizers from Pods belonging to finished Jobs\r\n\r\n> If someone has set a custom finalizer on a Pod, even one owned by a Job, (when) would we remove that finalizer?\r\n\r\nNo, only the finalizer specific to job tracking", "created_at": "2023-08-14 17:03:06" } ]

[ { "author": "alculquicondor", "created_at": "2023-08-08 18:18:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:18:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:19:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:19:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:19:13", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:25:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:25:11", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:25:59", "type": "labeled" }, { "author": "Sharpz7", "created_at": "2023-08-08 18:31:28", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 17:03:07", "type": "renamed" } ]

[ "rphillips", "mrunalp", "SergeyKanzhelev" ]

[ "kind/bug", "priority/important-soon", "lgtm", "sig/storage", "sig/node", "release-note", "size/M", "approved", "cncf-cla: yes", "do-not-merge/cherry-pick-not-approved", "triage/accepted" ]

[ { "body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 17:24:45" }, { "body": "/kind bug", "created_at": "2023-08-08 17:45:01" }, { "body": "This test:\r\n```\r\nTest_Run_UpdateNodeStatusFailBeforeOneVolumeDetachNodeWithReadWriteOnce\r\n```\r\n\r\nAlso failed in a related backport: https://github.com/kubernetes/kubernetes/pull/117149#issuecomment-1499593615\r\n\r\n/retest", "created_at": "2023-08-08 20:13:36" }, { "body": "Test passed on a retry 👍 ", "created_at": "2023-08-08 20:57:10" }, { "body": "/sig node", "created_at": "2023-08-10 15:05:07" }, { "body": "/assign @SergeyKanzhelev @mrunalp ", "created_at": "2023-08-10 15:28:26" }, { "body": "/lgtm", "created_at": "2023-08-10 20:53:32" }, { "body": "LGTM label has been added. <details>Git tree hash: 8b9a42b26b3a49c121a74a9af88f2c4f2152ed23</details>", "created_at": "2023-08-10 20:53:39" }, { "body": "/triage accepted\r\n/priority important-soon", "created_at": "2023-08-11 10:26:14" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119832#\" title=\"Author self-approved\">cartermckinnon</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119832#pullrequestreview-1573505972\" title=\"Approved\">jsafrane</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/mount-utils/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.25/staging/src/k8s.io/mount-utils/OWNERS)~~ [jsafrane]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-11 11:42:53" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:24:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:24:44", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:24:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:24:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:24:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:24:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:24:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:24:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:25:23", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:25:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:25:23", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:25:25", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:45:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:45:06", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:47:09", "type": "labeled" }, { "author": "cartermckinnon", "created_at": "2023-08-08 17:59:46", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-08-08 17:59:46", "type": "subscribed" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:00:35", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:00:35", "type": "subscribed" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:02:19", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:02:19", "type": "subscribed" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:14:54", "type": "head_ref_force_pushed" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:49:31", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:49:31", "type": "subscribed" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:51:32", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:51:32", "type": "subscribed" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:54:17", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:54:17", "type": "subscribed" }, { "author": "cartermckinnon", "created_at": "2023-08-08 19:00:10", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 19:00:13", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 19:00:13", "type": "labeled" }, { "author": "cartermckinnon", "created_at": "2023-08-08 19:37:41", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-08-08 19:37:41", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 15:05:12", "type": "labeled" }, { "author": "mrunalp", "created_at": "2023-08-10 15:28:26", "type": "mentioned" }, { "author": "mrunalp", "created_at": "2023-08-10 15:28:27", "type": "subscribed" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-10 15:28:27", "type": "mentioned" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-10 15:28:27", "type": "subscribed" }, { "author": "mrunalp", "created_at": "2023-08-10 15:28:28", "type": "assigned" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-10 15:28:29", "type": "assigned" }, { "author": "rphillips", "created_at": "2023-08-10 20:53:37", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 20:53:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:26:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:26:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:26:18", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:26:19", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 11:42:54", "type": "labeled" } ]

[ "rphillips", "mrunalp", "SergeyKanzhelev" ]

[ "kind/bug", "priority/important-soon", "lgtm", "sig/storage", "sig/node", "release-note", "size/M", "approved", "cncf-cla: yes", "do-not-merge/cherry-pick-not-approved", "triage/accepted" ]

[ { "body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 17:22:02" }, { "body": "/kind bug", "created_at": "2023-08-08 17:44:36" }, { "body": "Unit test failures do not look related to this change.\r\n\r\n/retest", "created_at": "2023-08-08 20:10:44" }, { "body": "Test passed on a retry 👍 ", "created_at": "2023-08-08 20:57:33" }, { "body": "@msau42 @jsafrane can you take a look at this cherry pick?", "created_at": "2023-08-08 20:58:46" }, { "body": "/sig node", "created_at": "2023-08-10 15:05:25" }, { "body": "/assign @SergeyKanzhelev @mrunalp ", "created_at": "2023-08-10 15:28:36" }, { "body": "What is the story here with 1.27 and 1.28 branches? Why we only do 1.26?", "created_at": "2023-08-10 20:19:29" }, { "body": "1.27 and 1.28 contain these patches already.\r\n\r\n```\r\n❯ git tag --contains b84ba39a0f13e77fcb41fa1208801d6ac06a1c33\r\nv1.27.0\r\nv1.27.0-beta.0\r\nv1.27.0-rc.0\r\nv1.27.0-rc.1\r\nv1.27.1\r\nv1.27.2\r\nv1.27.3\r\nv1.27.4\r\nv1.28.0-alpha.0\r\nv1.28.0-alpha.1\r\nv1.28.0-alpha.2\r\nv1.28.0-alpha.3\r\nv1.28.0-alpha.4\r\nv1.28.0-beta.0\r\nv1.28.0-rc.0\r\nv1.29.0-alpha.0\r\n```\r\n\r\n/lgtm", "created_at": "2023-08-10 20:53:09" }, { "body": "LGTM label has been added. <details>Git tree hash: 3090cdc7503a1844a980a60838df06711e55dd43</details>", "created_at": "2023-08-10 20:53:17" }, { "body": "Yes, this change was merged to 1.27 originally. Thanks for taking a look @rphillips!", "created_at": "2023-08-10 21:19:43" }, { "body": "/triage accepted\r\n/priority important-soon", "created_at": "2023-08-11 10:25:30" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119831#\" title=\"Author self-approved\">cartermckinnon</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119831#pullrequestreview-1573504894\" title=\"Approved\">jsafrane</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/mount-utils/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/mount-utils/OWNERS)~~ [jsafrane]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-11 11:42:08" }, { "body": "@kubernetes/release-managers trying to close this and #119832 out -- can someone give them `accepted-cherry-pick`?", "created_at": "2023-08-14 18:21:48" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:22:00", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:22:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:22:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:22:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:22:04", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:22:04", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:22:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:22:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:22:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:22:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:44:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:44:39", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:46:56", "type": "labeled" }, { "author": "cartermckinnon", "created_at": "2023-08-08 17:58:14", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-08-08 17:58:14", "type": "subscribed" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:01:47", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:01:48", "type": "subscribed" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:03:21", "type": "head_ref_force_pushed" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:10:15", "type": "head_ref_force_pushed" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:12:09", "type": "head_ref_force_pushed" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:47:51", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:47:52", "type": "subscribed" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:48:23", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-08-08 18:48:23", "type": "subscribed" }, { "author": "cartermckinnon", "created_at": "2023-08-08 19:01:40", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 19:01:42", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 19:01:43", "type": "labeled" }, { "author": "cartermckinnon", "created_at": "2023-08-08 19:01:51", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-08-08 19:01:51", "type": "subscribed" }, { "author": "cartermckinnon", "created_at": "2023-08-08 19:38:48", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-08-08 19:38:48", "type": "subscribed" }, { "author": "jsafrane", "created_at": "2023-08-08 20:58:46", "type": "mentioned" }, { "author": "jsafrane", "created_at": "2023-08-08 20:58:46", "type": "subscribed" }, { "author": "msau42", "created_at": "2023-08-08 20:58:46", "type": "mentioned" }, { "author": "msau42", "created_at": "2023-08-08 20:58:47", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 15:05:29", "type": "labeled" }, { "author": "mrunalp", "created_at": "2023-08-10 15:28:36", "type": "mentioned" }, { "author": "mrunalp", "created_at": "2023-08-10 15:28:36", "type": "subscribed" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-10 15:28:36", "type": "mentioned" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-10 15:28:37", "type": "subscribed" }, { "author": "mrunalp", "created_at": "2023-08-10 15:28:38", "type": "assigned" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-10 15:28:38", "type": "assigned" }, { "author": "rphillips", "created_at": "2023-08-10 20:53:14", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 20:53:15", "type": "labeled" }, { "author": "rphillips", "created_at": "2023-08-10 21:19:44", "type": "mentioned" }, { "author": "rphillips", "created_at": "2023-08-10 21:19:44", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:25:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:25:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:25:34", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 10:25:35", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-11 11:42:09", "type": "labeled" }, { "author": "justaugustus", "created_at": "2023-08-14 18:21:48", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-14 18:21:48", "type": "subscribed" }, { "author": "Verolop", "created_at": "2023-08-14 18:21:48", "type": "subscribed" }, { "author": "puerco", "created_at": "2023-08-14 18:21:48", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-14 18:21:48", "type": "subscribed" }, { "author": "cici37", "created_at": "2023-08-14 18:21:49", "type": "subscribed" }, { "author": "palnabarun", "created_at": "2023-08-14 18:21:49", "type": "subscribed" }, { "author": "xmudrii", "created_at": "2023-08-14 18:21:49", "type": "subscribed" }, { "author": "k8s-release-robot", "created_at": "2023-08-14 18:21:49", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-14 18:21:49", "type": "subscribed" } ]

[ "dims", "saschagrunert", "liggitt", "ameukam", "cpanato" ]

[ "area/test", "lgtm", "release-note", "size/L", "kind/feature", "area/release-eng", "cherry-pick-approved", "approved", "cncf-cla: yes", "sig/testing", "sig/release", "needs-priority", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 16:57:33" }, { "body": "/lgtm", "created_at": "2023-08-08 17:11:02" }, { "body": "LGTM label has been added. <details>Git tree hash: dc208d9e653c6c46374eb80013532cc3658ede59</details>", "created_at": "2023-08-08 17:11:11" }, { "body": "/lgtm", "created_at": "2023-08-08 18:06:35" }, { "body": "LGTM label has been added. <details>Git tree hash: 678bacf2a8922a4b027a49ba5c9664401ac5e386</details>", "created_at": "2023-08-08 18:06:43" }, { "body": "/retest", "created_at": "2023-08-08 20:18:30" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-08 21:19:16" }, { "body": "LGTM label has been added. <details>Git tree hash: 0624f9d047e201f8dc2b5ee26c85386abb7cfb2f</details>", "created_at": "2023-08-08 21:19:24" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119830#\" title=\"Author self-approved\">jeremyrickard</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119830#issuecomment-1670321921\" title=\"Approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/OWNERS)~~ [liggitt]\n- ~~[build/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/build/OWNERS)~~ [liggitt]\n- ~~[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/hack/OWNERS)~~ [liggitt]\n- ~~[staging/publishing/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/publishing/OWNERS)~~ [liggitt]\n- ~~[test/images/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/test/images/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-08 21:19:41" } ]

[ { "author": "saschagrunert", "created_at": "2023-08-08 16:57:25", "type": "mentioned" }, { "author": "saschagrunert", "created_at": "2023-08-08 16:57:25", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-08 16:57:25", "type": "mentioned" }, { "author": "cpanato", "created_at": "2023-08-08 16:57:25", "type": "subscribed" }, { "author": "justaugustus", "created_at": "2023-08-08 16:57:25", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-08 16:57:25", "type": "subscribed" }, { "author": "salaxander", "created_at": "2023-08-08 16:57:25", "type": "subscribed" }, { "author": "cici37", "created_at": "2023-08-08 16:57:26", "type": "subscribed" }, { "author": "Verolop", "created_at": "2023-08-08 16:57:26", "type": "subscribed" }, { "author": "palnabarun", "created_at": "2023-08-08 16:57:26", "type": "subscribed" }, { "author": "ameukam", "created_at": "2023-08-08 16:57:26", "type": "subscribed" }, { "author": "ramrodo", "created_at": "2023-08-08 16:57:26", "type": "subscribed" }, { "author": "xmudrii", "created_at": "2023-08-08 16:57:26", "type": "subscribed" }, { "author": "puerco", "created_at": "2023-08-08 16:57:26", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:57:26", "type": "milestoned" }, { "author": "k8s-release-robot", "created_at": "2023-08-08 16:57:26", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:57:26", "type": "labeled" }, { "author": "cpanato", "created_at": "2023-08-08 16:57:26", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:57:26", "type": "labeled" }, { "author": "jeremyrickard", "created_at": "2023-08-08 16:57:26", "type": "subscribed" }, { "author": "jimangel", "created_at": "2023-08-08 16:57:26", "type": "subscribed" }, { "author": "gracenng", "created_at": "2023-08-08 16:57:26", "type": "subscribed" }, { "author": "jrsapi", "created_at": "2023-08-08 16:57:26", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:57:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:57:26", "type": "labeled" }, { "author": "cpanato", "created_at": "2023-08-08 16:57:26", "type": "assigned" }, { "author": "saschagrunert", "created_at": "2023-08-08 16:57:27", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:57:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:57:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:57:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:57:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:57:31", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:57:31", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:57:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:57:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:57:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:57:33", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:57:34", "type": "labeled" }, { "author": "jeremyrickard", "created_at": "2023-08-08 16:57:59", "type": "head_ref_force_pushed" }, { "author": "ameukam", "created_at": "2023-08-08 17:11:08", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:11:09", "type": "labeled" }, { "author": "jeremyrickard", "created_at": "2023-08-08 17:34:42", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 17:34:42", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 17:35:20", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 17:35:20", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 17:44:37", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 17:44:37", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 17:49:41", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:49:43", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:49:44", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:49:45", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 17:49:45", "type": "review_requested" }, { "author": "dims", "created_at": "2023-08-08 18:06:40", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 18:06:42", "type": "labeled" }, { "author": "jeremyrickard", "created_at": "2023-08-08 18:41:54", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 18:41:54", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 19:40:56", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 19:40:58", "type": "unlabeled" }, { "author": "jeremyrickard", "created_at": "2023-08-08 20:13:24", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 20:13:24", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 20:26:09", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 20:26:09", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 20:49:45", "type": "head_ref_force_pushed" }, { "author": "liggitt", "created_at": "2023-08-08 21:19:21", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:19:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 21:19:42", "type": "labeled" }, { "author": "jeremyrickard", "created_at": "2023-08-08 23:41:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 23:41:21", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 23:41:51", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 23:41:51", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 23:41:51", "type": "closed" } ]

[ "jsafrane", "bart0sh", "nikzayn" ]

[ "kind/bug", "area/kubelet", "kind/cleanup", "area/logging", "sig/storage", "sig/node", "size/M", "release-note-none", "cncf-cla: yes", "sig/instrumentation", "priority/important-longterm", "triage/accepted", "wg/structured-logging" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 22:33:07 UTC 2023.\n", "created_at": "2023-08-08 16:11:21" }, { "body": "/sig storage", "created_at": "2023-08-08 16:12:13" }, { "body": "/assign", "created_at": "2023-08-09 04:32:25" }, { "body": "> /assign\r\n\r\nHey, @cvvz can you provide the steps to produce this issue also?", "created_at": "2023-08-09 04:47:27" }, { "body": "@nikzayn Just change the kubelet log level to greater than 4 and start kubelet then you can get the log, which didn't print any useful volumes information. https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/volumemanager/reconciler/reconstruct_common.go#L184 ", "created_at": "2023-08-09 06:27:38" }, { "body": "/retest", "created_at": "2023-08-10 04:14:17" }, { "body": "/release-note-none\r\n/triage accepted\r\n/priority important-longterm\r\n/kind cleanup\r\n/lgtm\r\n/assign @jsafrane ", "created_at": "2023-08-10 08:22:17" }, { "body": "LGTM label has been added. <details>Git tree hash: 172c405eaa51856436ca54cee1bbd0402aa1dc49</details>", "created_at": "2023-08-10 08:22:26" }, { "body": "https://github.com/kubernetes/klog/pull/375 replaced Sprintf with JSON and we're bringing it back in this PR.\r\n\r\nWould it be better to make `reconstructedVolume`, `podVolume` and maybe `globalVolumeInfo` public, with public members instead?\r\n\r\n", "created_at": "2023-08-11 11:52:16" }, { "body": "/sig instrumentation\r\n/wg structured-logging\r\n/area logging\r\n", "created_at": "2023-08-14 02:45:25" }, { "body": "> Would it be better to make reconstructedVolume, podVolume and maybe globalVolumeInfo public, with public members instead?\r\n\r\nI think we'd better not; these are structures that designed to be un-exported and only used in reconciler, we should not export them just for log printing. \r\n\r\nAnd this PR is enough to make the logs the same as before.\r\n", "created_at": "2023-08-14 03:59:11" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119829#\" title=\"Author self-approved\">cvvz</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119829#pullrequestreview-1572894332\" title=\"Approved\">togettoyou</a>*\n**Once this PR has been reviewed and has the lgtm label**, please ask for approval from [jsafrane](https://github.com/jsafrane). For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/kubelet/volumemanager/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/volumemanager/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"jsafrane\"]} -->", "created_at": "2023-08-25 12:56:40" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:11:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:11:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:11:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:11:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:11:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:11:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:11:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:12:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:12:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:12:10", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:12:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:12:22", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:12:22", "type": "review_requested" }, { "author": "cvvz", "created_at": "2023-08-08 16:39:35", "type": "mentioned" }, { "author": "cvvz", "created_at": "2023-08-08 16:39:35", "type": "subscribed" }, { "author": "nikzayn", "created_at": "2023-08-09 04:32:27", "type": "assigned" }, { "author": "cvvz", "created_at": "2023-08-09 04:47:27", "type": "mentioned" }, { "author": "cvvz", "created_at": "2023-08-09 04:47:27", "type": "subscribed" }, { "author": "nikzayn", "created_at": "2023-08-09 06:27:38", "type": "mentioned" }, { "author": "nikzayn", "created_at": "2023-08-09 06:27:39", "type": "subscribed" }, { "author": "jsafrane", "created_at": "2023-08-10 08:22:18", "type": "mentioned" }, { "author": "jsafrane", "created_at": "2023-08-10 08:22:18", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:22:19", "type": "labeled" }, { "author": "jsafrane", "created_at": "2023-08-10 08:22:19", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:22:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:22:20", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:22:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:22:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:22:22", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:22:23", "type": "unlabeled" }, { "author": "bart0sh", "created_at": "2023-08-10 08:22:23", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 08:22:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 02:45:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 02:45:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 02:45:29", "type": "labeled" }, { "author": "toVersus", "created_at": "2023-08-14 11:50:50", "type": "unsubscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-25 12:53:44", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-25 12:53:44", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-25 12:53:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-25 12:53:45", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-25 12:53:45", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-25 12:55:41", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-25 12:55:42", "type": "labeled" }, { "author": "cvvz", "created_at": "2023-08-25 12:56:33", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-25 12:56:35", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-25 12:56:36", "type": "labeled" }, { "author": "cvvz", "created_at": "2023-08-25 13:15:51", "type": "mentioned" }, { "author": "cvvz", "created_at": "2023-08-25 13:15:51", "type": "subscribed" }, { "author": "cvvz", "created_at": "2023-08-25 13:17:52", "type": "mentioned" }, { "author": "cvvz", "created_at": "2023-08-25 13:17:52", "type": "subscribed" }, { "author": "cvvz", "created_at": "2023-08-25 14:00:57", "type": "mentioned" }, { "author": "cvvz", "created_at": "2023-08-25 14:00:57", "type": "subscribed" }, { "author": "cvvz", "created_at": "2023-08-25 14:02:39", "type": "mentioned" }, { "author": "cvvz", "created_at": "2023-08-25 14:02:39", "type": "subscribed" } ]

[ "saschagrunert", "liggitt", "ameukam", "cpanato" ]

[ "area/test", "lgtm", "release-note", "size/M", "kind/feature", "area/release-eng", "cherry-pick-approved", "approved", "cncf-cla: yes", "sig/testing", "sig/release", "needs-priority", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 15:59:06" }, { "body": "/lgtm", "created_at": "2023-08-08 16:00:52" }, { "body": "LGTM label has been added. <details>Git tree hash: 572dbe99b230cec6f317d0b7ad782b213959f98c</details>", "created_at": "2023-08-08 16:01:01" }, { "body": "/approve", "created_at": "2023-08-08 16:09:38" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-08 20:20:04" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119828#issuecomment-1669907292\" title=\"Approved\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119828#\" title=\"Author self-approved\">jeremyrickard</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119828#issuecomment-1670253257\" title=\"Approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/OWNERS)~~ [dims,liggitt]\n- ~~[build/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/build/OWNERS)~~ [dims,liggitt]\n- ~~[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/hack/OWNERS)~~ [dims,liggitt]\n- ~~[staging/publishing/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/publishing/OWNERS)~~ [dims,liggitt]\n- ~~[test/images/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/test/images/OWNERS)~~ [dims,liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-08 20:20:29" } ]

[ { "author": "saschagrunert", "created_at": "2023-08-08 15:58:58", "type": "mentioned" }, { "author": "saschagrunert", "created_at": "2023-08-08 15:58:58", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-08 15:58:58", "type": "mentioned" }, { "author": "cpanato", "created_at": "2023-08-08 15:58:58", "type": "subscribed" }, { "author": "justaugustus", "created_at": "2023-08-08 15:58:58", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-08 15:58:59", "type": "subscribed" }, { "author": "cici37", "created_at": "2023-08-08 15:58:59", "type": "subscribed" }, { "author": "salaxander", "created_at": "2023-08-08 15:58:59", "type": "subscribed" }, { "author": "Verolop", "created_at": "2023-08-08 15:58:59", "type": "subscribed" }, { "author": "palnabarun", "created_at": "2023-08-08 15:58:59", "type": "subscribed" }, { "author": "ameukam", "created_at": "2023-08-08 15:58:59", "type": "subscribed" }, { "author": "xmudrii", "created_at": "2023-08-08 15:58:59", "type": "subscribed" }, { "author": "ramrodo", "created_at": "2023-08-08 15:58:59", "type": "subscribed" }, { "author": "k8s-release-robot", "created_at": "2023-08-08 15:58:59", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:58:59", "type": "labeled" }, { "author": "puerco", "created_at": "2023-08-08 15:58:59", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 15:58:59", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:58:59", "type": "milestoned" }, { "author": "cpanato", "created_at": "2023-08-08 15:58:59", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:58:59", "type": "labeled" }, { "author": "cpanato", "created_at": "2023-08-08 15:58:59", "type": "subscribed" }, { "author": "gracenng", "created_at": "2023-08-08 15:58:59", "type": "subscribed" }, { "author": "jimangel", "created_at": "2023-08-08 15:58:59", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:58:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:58:59", "type": "labeled" }, { "author": "jrsapi", "created_at": "2023-08-08 15:58:59", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-08 15:58:59", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:59:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:59:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:59:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:59:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:59:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:59:32", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:59:32", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:59:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:59:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:59:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:59:36", "type": "unlabeled" }, { "author": "ameukam", "created_at": "2023-08-08 16:00:57", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:00:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:10:06", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-08-08 20:20:10", "type": "assigned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 23:40:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 23:40:58", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 23:41:50", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 23:41:50", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 23:41:51", "type": "closed" } ]

[ "jsafrane" ]

[ "kind/bug", "area/kubelet", "sig/storage", "sig/node", "release-note", "size/S", "cncf-cla: yes", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 22:33:07 UTC 2023.\n", "created_at": "2023-08-08 15:53:38" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 15:53:43" }, { "body": "/sig storage", "created_at": "2023-08-08 16:45:16" }, { "body": "/retest", "created_at": "2023-08-09 14:20:13" }, { "body": "/retest", "created_at": "2023-08-10 03:20:34" }, { "body": "@gnufied @jingxu97 @msau42 we were considering marking all reconstructed volumes as uncertain, but from _some_ reason we've chosen to rewrite the reconstruction completely with `NewVolumeManagerReconstruction`.\r\n\r\nDo you remember why? I know for me the main reason for me was SELinux, but we had more issues.", "created_at": "2023-08-11 12:47:18" }, { "body": "https://github.com/kubernetes/kubernetes/issues/119919 can also trigger this issue. I described how to do that in https://github.com/kubernetes/kubernetes/issues/119919. \r\nAnd I've tested with cherry-pick to 1.27.3 to make sure that the problem can be solved.", "created_at": "2023-08-13 05:42:06" }, { "body": "I've tested with cherry-pick to 1.25.11 and 1.27.3 and the problem in this issue can be solved.", "created_at": "2023-08-13 05:43:38" }, { "body": "This PR and https://github.com/kubernetes/kubernetes/pull/119923 have almost the same title, but fixing different bugs. Cold they be merged into one or may be title should be changed?", "created_at": "2023-08-14 11:50:47" }, { "body": "@bart0sh I've changed the title, the symptoms of these two issues are the same while the root cause is different.", "created_at": "2023-08-14 11:55:22" }, { "body": "@jsafrane please triage this PR and set its priority, thanks.", "created_at": "2023-08-14 11:57:14" }, { "body": "/assign @jsafrane ", "created_at": "2023-08-16 09:58:11" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119827#\" title=\"Author self-approved\">cvvz</a>*\n**Once this PR has been reviewed and has the lgtm label**, please ask for approval from [jsafrane](https://github.com/jsafrane). For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/kubelet/volumemanager/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/volumemanager/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"jsafrane\"]} -->", "created_at": "2023-08-25 14:01:00" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:53:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:53:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:53:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:53:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:53:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:53:42", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:53:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:54:11", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:54:11", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:54:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:54:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:54:38", "type": "unlabeled" }, { "author": "cvvz", "created_at": "2023-08-08 16:19:07", "type": "mentioned" }, { "author": "cvvz", "created_at": "2023-08-08 16:19:07", "type": "subscribed" }, { "author": "cvvz", "created_at": "2023-08-08 16:34:09", "type": "mentioned" }, { "author": "cvvz", "created_at": "2023-08-08 16:34:09", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 16:45:18", "type": "labeled" }, { "author": "cvvz", "created_at": "2023-08-08 16:51:24", "type": "mentioned" }, { "author": "cvvz", "created_at": "2023-08-08 16:51:24", "type": "subscribed" }, { "author": "cvvz", "created_at": "2023-08-09 14:58:33", "type": "mentioned" }, { "author": "cvvz", "created_at": "2023-08-09 14:58:33", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 00:55:18", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 00:55:19", "type": "labeled" }, { "author": "cvvz", "created_at": "2023-08-10 01:34:44", "type": "mentioned" }, { "author": "cvvz", "created_at": "2023-08-10 01:34:44", "type": "subscribed" }, { "author": "gnufied", "created_at": "2023-08-11 12:47:18", "type": "mentioned" }, { "author": "gnufied", "created_at": "2023-08-11 12:47:19", "type": "subscribed" }, { "author": "jingxu97", "created_at": "2023-08-11 12:47:19", "type": "mentioned" }, { "author": "jingxu97", "created_at": "2023-08-11 12:47:19", "type": "subscribed" }, { "author": "msau42", "created_at": "2023-08-11 12:47:19", "type": "mentioned" }, { "author": "msau42", "created_at": "2023-08-11 12:47:19", "type": "subscribed" }, { "author": "cvvz", "created_at": "2023-08-14 11:53:46", "type": "renamed" }, { "author": "bart0sh", "created_at": "2023-08-14 11:55:23", "type": "mentioned" }, { "author": "bart0sh", "created_at": "2023-08-14 11:55:23", "type": "subscribed" }, { "author": "jsafrane", "created_at": "2023-08-14 11:57:14", "type": "mentioned" }, { "author": "jsafrane", "created_at": "2023-08-14 11:57:14", "type": "subscribed" }, { "author": "jsafrane", "created_at": "2023-08-16 09:58:11", "type": "mentioned" }, { "author": "jsafrane", "created_at": "2023-08-16 09:58:11", "type": "subscribed" }, { "author": "jsafrane", "created_at": "2023-08-16 09:58:12", "type": "assigned" } ]

[]

[ "area/test", "size/S", "sig/windows", "cncf-cla: yes", "sig/testing", "do-not-merge/release-note-label-needed", "do-not-merge/work-in-progress", "needs-priority", "needs-triage", "do-not-merge/needs-kind" ]

[ { "body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 15:32:19" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 22:33:07 UTC 2023.\n", "created_at": "2023-08-08 15:32:21" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 15:32:27" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119826#\" title=\"Author self-approved\">claudiubelu</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [ravisantoshgudimetla](https://github.com/ravisantoshgudimetla) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[test/e2e/windows/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/windows/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"ravisantoshgudimetla\"]} -->", "created_at": "2023-08-08 15:32:51" }, { "body": "/retest pull-kubernetes-e2e-capz-windows", "created_at": "2023-08-09 08:30:32" }, { "body": "@claudiubelu: The `/retest` command does not accept any targets.\nThe following commands are available to trigger required jobs:\n* `/test pull-cadvisor-e2e-kubernetes`\n* `/test pull-kubernetes-conformance-kind-ga-only-parallel`\n* `/test pull-kubernetes-coverage-unit`\n* `/test pull-kubernetes-dependencies`\n* `/test pull-kubernetes-dependencies-go-canary`\n* `/test pull-kubernetes-e2e-gce`\n* `/test pull-kubernetes-e2e-gce-100-performance`\n* `/test pull-kubernetes-e2e-gce-big-performance`\n* `/test pull-kubernetes-e2e-gce-canary`\n* `/test pull-kubernetes-e2e-gce-cos`\n* `/test pull-kubernetes-e2e-gce-cos-canary`\n* `/test pull-kubernetes-e2e-gce-cos-no-stage`\n* `/test pull-kubernetes-e2e-gce-network-proxy-http-connect`\n* `/test pull-kubernetes-e2e-gce-scale-performance-manual`\n* `/test pull-kubernetes-e2e-kind`\n* `/test pull-kubernetes-e2e-kind-ipv6`\n* `/test pull-kubernetes-integration`\n* `/test pull-kubernetes-integration-go-canary`\n* `/test pull-kubernetes-kubemark-e2e-gce-scale`\n* `/test pull-kubernetes-node-e2e-containerd`\n* `/test pull-kubernetes-typecheck`\n* `/test pull-kubernetes-unit`\n* `/test pull-kubernetes-unit-go-canary`\n* `/test pull-kubernetes-update`\n* `/test pull-kubernetes-verify`\n* `/test pull-kubernetes-verify-go-canary`\n\nThe following commands are available to trigger optional jobs:\n* `/test check-dependency-stats`\n* `/test pull-ci-kubernetes-unit-windows`\n* `/test pull-e2e-gce-cloud-provider-disabled`\n* `/test pull-kubernetes-conformance-image-test`\n* `/test pull-kubernetes-conformance-kind-ga-only`\n* `/test pull-kubernetes-conformance-kind-ipv6-parallel`\n* `/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e`\n* `/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e-features`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-eviction`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-features`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-serial`\n* `/test pull-kubernetes-cross`\n* `/test pull-kubernetes-e2e-autoscaling-hpa-cm`\n* `/test pull-kubernetes-e2e-autoscaling-hpa-cpu`\n* `/test pull-kubernetes-e2e-capz-azure-disk`\n* `/test pull-kubernetes-e2e-capz-azure-disk-vmss`\n* `/test pull-kubernetes-e2e-capz-azure-file`\n* `/test pull-kubernetes-e2e-capz-azure-file-vmss`\n* `/test pull-kubernetes-e2e-capz-conformance`\n* `/test pull-kubernetes-e2e-capz-windows`\n* `/test pull-kubernetes-e2e-capz-windows-alpha-feature-vpa`\n* `/test pull-kubernetes-e2e-capz-windows-alpha-features`\n* `/test pull-kubernetes-e2e-capz-windows-serial-slow-hpa`\n* `/test pull-kubernetes-e2e-containerd-gce`\n* `/test pull-kubernetes-e2e-gce-correctness`\n* `/test pull-kubernetes-e2e-gce-cos-alpha-features`\n* `/test pull-kubernetes-e2e-gce-cos-kubetest2`\n* `/test pull-kubernetes-e2e-gce-csi-serial`\n* `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\n* `/test pull-kubernetes-e2e-gce-kubelet-credential-provider`\n* `/test pull-kubernetes-e2e-gce-network-proxy-grpc`\n* `/test pull-kubernetes-e2e-gce-serial`\n* `/test pull-kubernetes-e2e-gce-storage-disruptive`\n* `/test pull-kubernetes-e2e-gce-storage-slow`\n* `/test pull-kubernetes-e2e-gce-storage-snapshot`\n* `/test pull-kubernetes-e2e-gci-gce-autoscaling`\n* `/test pull-kubernetes-e2e-gci-gce-ingress`\n* `/test pull-kubernetes-e2e-gci-gce-ipvs`\n* `/test pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2`\n* `/test pull-kubernetes-e2e-kind-alpha-features`\n* `/test pull-kubernetes-e2e-kind-canary`\n* `/test pull-kubernetes-e2e-kind-dual-canary`\n* `/test pull-kubernetes-e2e-kind-ipv6-canary`\n* `/test pull-kubernetes-e2e-kind-ipvs-dual-canary`\n* `/test pull-kubernetes-e2e-kind-kms`\n* `/test pull-kubernetes-e2e-kind-multizone`\n* `/test pull-kubernetes-e2e-kops-aws`\n* `/test pull-kubernetes-e2e-storage-kind-disruptive`\n* `/test pull-kubernetes-e2e-ubuntu-gce-network-policies`\n* `/test pull-kubernetes-integration-eks`\n* `/test pull-kubernetes-kind-dra`\n* `/test pull-kubernetes-kind-json-logging`\n* `/test pull-kubernetes-kind-text-logging`\n* `/test pull-kubernetes-kubemark-e2e-gce-big`\n* `/test pull-kubernetes-local-e2e`\n* `/test pull-kubernetes-node-arm64-e2e-containerd-ec2`\n* `/test pull-kubernetes-node-arm64-e2e-containerd-serial-ec2`\n* `/test pull-kubernetes-node-arm64-ubuntu-serial-gce`\n* `/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e`\n* `/test pull-kubernetes-node-crio-cgrpv2-e2e`\n* `/test pull-kubernetes-node-crio-cgrpv2-e2e-kubetest2`\n* `/test pull-kubernetes-node-crio-e2e`\n* `/test pull-kubernetes-node-crio-e2e-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-alpha-features`\n* `/test pull-kubernetes-node-e2e-containerd-ec2`\n* `/test pull-kubernetes-node-e2e-containerd-features`\n* `/test pull-kubernetes-node-e2e-containerd-features-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-serial-ec2`\n* `/test pull-kubernetes-node-e2e-containerd-sidecar-containers`\n* `/test pull-kubernetes-node-e2e-containerd-standalone-mode`\n* `/test pull-kubernetes-node-e2e-containerd-standalone-mode-all-alpha`\n* `/test pull-kubernetes-node-e2e-crio-dra`\n* `/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2`\n* `/test pull-kubernetes-node-kubelet-credential-provider`\n* `/test pull-kubernetes-node-kubelet-serial-containerd`\n* `/test pull-kubernetes-node-kubelet-serial-containerd-kubetest2`\n* `/test pull-kubernetes-node-kubelet-serial-cpu-manager`\n* `/test pull-kubernetes-node-kubelet-serial-cpu-manager-kubetest2`\n* `/test pull-kubernetes-node-kubelet-serial-crio-cgroupv1`\n* `/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2`\n* `/test pull-kubernetes-node-kubelet-serial-hugepages`\n* `/test pull-kubernetes-node-kubelet-serial-memory-manager`\n* `/test pull-kubernetes-node-kubelet-serial-pod-disruption-conditions`\n* `/test pull-kubernetes-node-kubelet-serial-topology-manager`\n* `/test pull-kubernetes-node-kubelet-serial-topology-manager-kubetest2`\n* `/test pull-kubernetes-node-memoryqos-cgrpv2`\n* `/test pull-kubernetes-node-swap-fedora`\n* `/test pull-kubernetes-node-swap-fedora-serial`\n* `/test pull-kubernetes-node-swap-ubuntu-serial`\n* `/test pull-kubernetes-unit-experimental`\n* `/test pull-kubernetes-verify-strict-lint`\n* `/test pull-publishing-bot-validate`\n\nUse `/test all` to run the following jobs that were automatically triggered:\n* `pull-kubernetes-conformance-kind-ga-only-parallel`\n* `pull-kubernetes-conformance-kind-ipv6-parallel`\n* `pull-kubernetes-dependencies`\n* `pull-kubernetes-e2e-capz-windows`\n* `pull-kubernetes-e2e-gce`\n* `pull-kubernetes-e2e-kind`\n* `pull-kubernetes-e2e-kind-ipv6`\n* `pull-kubernetes-integration`\n* `pull-kubernetes-node-e2e-containerd`\n* `pull-kubernetes-typecheck`\n* `pull-kubernetes-unit`\n* `pull-kubernetes-verify`\n\n\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119826#issuecomment-1670897960):\n\n>/retest pull-kubernetes-e2e-capz-windows\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 08:30:36" }, { "body": "/test pull-kubernetes-e2e-capz-windows", "created_at": "2023-08-09 08:31:00" }, { "body": "/test pull-kubernetes-e2e-capz-windows", "created_at": "2023-08-11 07:46:18" }, { "body": "/test pull-kubernetes-e2e-capz-windows", "created_at": "2023-08-15 16:33:22" }, { "body": "@claudiubelu: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-e2e-capz-windows | f0d69c97817cc5fa60eb2afc5a32118ea135bfb9 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119826/pull-kubernetes-e2e-capz-windows/1691488266949234688) | false | `/test pull-kubernetes-e2e-capz-windows`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119826). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Aclaudiubelu). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-08-15 17:55:34" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:32:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:32:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:32:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:32:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:32:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:32:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:32:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:32:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:33:02", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:33:02", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:33:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:33:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:33:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:33:16", "type": "unlabeled" }, { "author": "claudiubelu", "created_at": "2023-08-08 15:41:25", "type": "mentioned" }, { "author": "claudiubelu", "created_at": "2023-08-08 15:41:25", "type": "subscribed" }, { "author": "claudiubelu", "created_at": "2023-08-08 15:46:44", "type": "mentioned" }, { "author": "claudiubelu", "created_at": "2023-08-08 15:46:44", "type": "subscribed" }, { "author": "claudiubelu", "created_at": "2023-08-08 15:49:13", "type": "mentioned" }, { "author": "claudiubelu", "created_at": "2023-08-08 15:49:13", "type": "subscribed" }, { "author": "claudiubelu", "created_at": "2023-08-08 15:49:37", "type": "mentioned" }, { "author": "claudiubelu", "created_at": "2023-08-08 15:49:37", "type": "subscribed" }, { "author": "claudiubelu", "created_at": "2023-08-08 15:49:42", "type": "mentioned" }, { "author": "claudiubelu", "created_at": "2023-08-08 15:49:42", "type": "subscribed" }, { "author": "claudiubelu", "created_at": "2023-08-08 15:49:58", "type": "mentioned" }, { "author": "claudiubelu", "created_at": "2023-08-08 15:49:58", "type": "subscribed" }, { "author": "claudiubelu", "created_at": "2023-08-08 15:50:00", "type": "mentioned" }, { "author": "claudiubelu", "created_at": "2023-08-08 15:50:00", "type": "subscribed" }, { "author": "claudiubelu", "created_at": "2023-08-08 16:24:51", "type": "head_ref_force_pushed" }, { "author": "claudiubelu", "created_at": "2023-08-09 08:30:36", "type": "mentioned" }, { "author": "claudiubelu", "created_at": "2023-08-09 08:30:36", "type": "subscribed" }, { "author": "claudiubelu", "created_at": "2023-08-11 09:08:54", "type": "mentioned" }, { "author": "claudiubelu", "created_at": "2023-08-11 09:08:54", "type": "subscribed" }, { "author": "toVersus", "created_at": "2023-08-13 04:24:25", "type": "unsubscribed" }, { "author": "claudiubelu", "created_at": "2023-08-15 17:55:34", "type": "mentioned" }, { "author": "claudiubelu", "created_at": "2023-08-15 17:55:34", "type": "subscribed" } ]

[ "apelisse" ]

[ "kind/cleanup", "area/apiserver", "lgtm", "sig/api-machinery", "release-note", "size/XS", "approved", "cncf-cla: yes", "needs-priority", "triage/accepted" ]

[ { "body": "@Jefftree: GitHub didn't allow me to request PR reviews from the following users: hickersonj.\n\nNote that only [kubernetes members](https://github.com/orgs/kubernetes/people) and repo collaborators can review this PR, and authors cannot review their own PRs.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119825):\n\n>/kind cleanup\r\n>\r\n>#### What this PR does / why we need it:\r\n>\r\n>Move add GroupVersion log until after an update is confirmed. If the discovery document is unchanged, do not log to prevent polluting the log files. We could technically divide this further into \"adding...\", \"updating...\", etc.\r\n>\r\n>#### Which issue(s) this PR fixes:\r\n><!--\r\n>*Automatically closes linked issue when PR is merged.\r\n>Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.\r\n>_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*\r\n>-->\r\n>Fixes #119546\r\n>\r\n>#### Special notes for your reviewer:\r\n>\r\n>#### Does this PR introduce a user-facing change?\r\n><!--\r\n>If no, just write \"NONE\" in the release-note block below.\r\n>If yes, a release note is required:\r\n>Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n>\r\n>For more information on release notes see: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n>-->\r\n>```release-note\r\n>Fixes bug where Adding GroupVersion log line is constantly repeated without any group version changes\r\n>```\r\n>\r\n>#### Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:\r\n>\r\n><!--\r\n>This section can be blank if this pull request does not require a release note.\r\n>\r\n>When adding links which point to resources within git repositories, like\r\n>KEPs or supporting documentation, please reference a specific commit and avoid\r\n>linking directly to the master branch. This ensures that links reference a\r\n>specific point in time, rather than a document that may change over time.\r\n>\r\n>See here for guidance on getting permanent links to files: https://help.github.com/en/articles/getting-permanent-links-to-files\r\n>\r\n>Please use the following format for linking documentation:\r\n>- [KEP]: <link>\r\n>- [Usage]: <link>\r\n>- [Other doc]: <link>\r\n>-->\r\n>```docs\r\n>\r\n>```\r\n>\r\n>/cc @hickersonj @apelisse @alexzielenski \r\n>\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 14:32:00" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 22:33:07 UTC 2023.\n", "created_at": "2023-08-08 14:32:00" }, { "body": "/retest", "created_at": "2023-08-08 16:40:12" }, { "body": "/triage accepted", "created_at": "2023-08-08 20:07:12" }, { "body": "I think that's fine, thanks\r\n/lgtm\r\n/approve", "created_at": "2023-08-08 20:44:35" }, { "body": "LGTM label has been added. <details>Git tree hash: dff19352ab683e05c970df0a8b034af5d0e71389</details>", "created_at": "2023-08-08 20:44:42" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119825#issuecomment-1670282958\" title=\"Approved\">apelisse</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119825#\" title=\"Author self-approved\">Jefftree</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/apiserver/pkg/endpoints/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/endpoints/OWNERS)~~ [apelisse]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-08 20:44:58" }, { "body": "/retest", "created_at": "2023-08-14 02:47:39" } ]

[ { "author": "hickersonj", "created_at": "2023-08-08 14:31:57", "type": "mentioned" }, { "author": "hickersonj", "created_at": "2023-08-08 14:31:57", "type": "subscribed" }, { "author": "apelisse", "created_at": "2023-08-08 14:31:57", "type": "mentioned" }, { "author": "apelisse", "created_at": "2023-08-08 14:31:57", "type": "subscribed" }, { "author": "alexzielenski", "created_at": "2023-08-08 14:31:57", "type": "mentioned" }, { "author": "alexzielenski", "created_at": "2023-08-08 14:31:57", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 14:31:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 14:31:58", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 14:31:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 14:31:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 14:31:59", "type": "review_requested" }, { "author": "alexzielenski", "created_at": "2023-08-08 14:32:01", "type": "mentioned" }, { "author": "alexzielenski", "created_at": "2023-08-08 14:32:01", "type": "subscribed" }, { "author": "apelisse", "created_at": "2023-08-08 14:32:01", "type": "mentioned" }, { "author": "apelisse", "created_at": "2023-08-08 14:32:02", "type": "subscribed" }, { "author": "Jefftree", "created_at": "2023-08-08 14:32:02", "type": "mentioned" }, { "author": "Jefftree", "created_at": "2023-08-08 14:32:02", "type": "subscribed" }, { "author": "hickersonj", "created_at": "2023-08-08 14:32:02", "type": "mentioned" }, { "author": "hickersonj", "created_at": "2023-08-08 14:32:02", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 14:32:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 14:32:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 14:32:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 14:32:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 14:32:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 14:32:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 14:32:48", "type": "unlabeled" }, { "author": "Jefftree", "created_at": "2023-08-08 15:28:36", "type": "mentioned" }, { "author": "Jefftree", "created_at": "2023-08-08 15:28:36", "type": "subscribed" }, { "author": "Jefftree", "created_at": "2023-08-08 17:38:04", "type": "mentioned" }, { "author": "Jefftree", "created_at": "2023-08-08 17:38:05", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:07:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:07:15", "type": "unlabeled" }, { "author": "apelisse", "created_at": "2023-08-08 20:44:40", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:44:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:44:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:32", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:32", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:32", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:34", "type": "milestoned" } ]

[ "liggitt", "wojtek-t" ]

[ "kind/bug", "area/apiserver", "lgtm", "sig/api-machinery", "size/XS", "kind/flake", "release-note-none", "approved", "cncf-cla: yes", "needs-priority", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 22:33:07 UTC 2023.\n", "created_at": "2023-08-08 13:55:31" }, { "body": "/assign @wojtek-t @liggitt \r\n\r\nI don't think we need this in 1.28.0, it seems this behavior was there for a couple of releases", "created_at": "2023-08-08 13:56:25" }, { "body": "/triage accepted", "created_at": "2023-08-08 20:07:22" }, { "body": "/lgtm\r\n/approve\r\n\r\nThanks!\r\n\r\n@serathius - FYI", "created_at": "2023-08-21 07:59:20" }, { "body": "LGTM label has been added. <details>Git tree hash: 44762259db4a1e04f6078c08f69684b788f88676</details>", "created_at": "2023-08-21 07:59:27" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119824#\" title=\"Author self-approved\">aojea</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119824#issuecomment-1685839309\" title=\"Approved\">wojtek-t</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/apiserver/pkg/storage/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/storage/OWNERS)~~ [wojtek-t]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-21 07:59:44" }, { "body": "Thanks, mind picking this to 1.28 to clean up CI there as well?", "created_at": "2023-08-21 10:58:41" } ]

[ { "author": "aojea", "created_at": "2023-08-08 13:55:29", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:55:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:55:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:55:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:55:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:55:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:55:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:55:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:55:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:56:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:56:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:56:08", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-08 13:56:25", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-08 13:56:25", "type": "subscribed" }, { "author": "wojtek-t", "created_at": "2023-08-08 13:56:26", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-08-08 13:56:26", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-08 13:56:27", "type": "assigned" }, { "author": "wojtek-t", "created_at": "2023-08-08 13:56:27", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:56:27", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:56:27", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:07:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:07:25", "type": "unlabeled" }, { "author": "serathius", "created_at": "2023-08-21 07:59:21", "type": "mentioned" }, { "author": "serathius", "created_at": "2023-08-21 07:59:21", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-21 07:59:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-21 07:59:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-21 09:49:33", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-21 09:49:34", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-21 09:49:34", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-21 09:49:35", "type": "milestoned" } ]

[ "bart0sh" ]

[ "area/test", "kind/cleanup", "lgtm", "sig/node", "size/M", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "priority/important-longterm", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 22:33:07 UTC 2023.\n", "created_at": "2023-08-08 13:23:46" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119819#\" title=\"Author self-approved\">pohly</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e/dra/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/dra/OWNERS)~~ [pohly]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-08 13:24:44" }, { "body": "/triage accepted\r\n/priority important-longterm", "created_at": "2023-08-09 07:41:44" }, { "body": "/retest", "created_at": "2023-08-09 07:41:53" }, { "body": "/lgtm", "created_at": "2023-08-16 10:27:58" }, { "body": "LGTM label has been added. <details>Git tree hash: 1d3b19e3bfe01f295f5c1ebe289a6f1d1b8a15fc</details>", "created_at": "2023-08-16 10:28:05" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:23:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:23:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:23:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:23:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:23:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:23:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:23:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:24:19", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:24:19", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:24:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:24:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:24:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:24:34", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:24:45", "type": "labeled" }, { "author": "pohly", "created_at": "2023-08-08 13:56:49", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-08 13:56:50", "type": "subscribed" }, { "author": "pohly", "created_at": "2023-08-08 14:22:35", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-08 14:22:35", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 07:41:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 07:41:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 07:41:47", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 07:41:48", "type": "unlabeled" }, { "author": "bart0sh", "created_at": "2023-08-16 10:28:03", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 10:28:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 11:32:26", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 11:32:27", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 11:32:27", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 11:32:28", "type": "milestoned" } ]

[ "dims", "aojea" ]

[ "area/test", "priority/critical-urgent", "lgtm", "release-note", "size/XS", "kind/feature", "approved", "cncf-cla: yes", "sig/testing", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 22:33:07 UTC 2023.\n", "created_at": "2023-08-08 13:16:13" }, { "body": "/assign @dims ", "created_at": "2023-08-08 13:21:07" }, { "body": "/triage accepted\r\n/priority critical-urgent", "created_at": "2023-08-08 13:22:51" }, { "body": "> k8s.io/kubernetes/vendor/k8s.io/apiextensions-apiserver/pkg/controller: openapi expand_less\t42s\r\n> {Failed; === RUN TestTwoCRDsSameGroup\r\n> W0808 13:45:28.011276 56400 mutation_detector.go:53] Mutation detector is enabled, this will result in memory leakage.\r\n> I0808 13:45:28.011797 56400 controller.go:134] Starting OpenAPI controller\r\n> controller_test.go:417: Expected path /apis/stable.example.com/v1/coolbars to exist in OpenAPI\r\n> --- FAIL: TestTwoCRDsSameGroup (31.27s)\r\n\r\n/test pull-kubernetes-unit\r\n\r\nunrelated\r\n\r\n/lgtm", "created_at": "2023-08-08 13:59:29" }, { "body": "LGTM label has been added. <details>Git tree hash: e246b7fbded133a692371a2dceb8af4cfa493729</details>", "created_at": "2023-08-08 13:59:39" }, { "body": "/milestone v1.28", "created_at": "2023-08-08 14:20:36" }, { "body": "/approve\r\n/lgtm", "created_at": "2023-08-08 15:08:23" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119818#issuecomment-1669804527\" title=\"LGTM\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119818#\" title=\"Author self-approved\">jeremyrickard</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[build/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/build/OWNERS)~~ [dims]\n- ~~[test/utils/image/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/utils/image/OWNERS)~~ [dims]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-08 15:08:46" } ]

[ { "author": "saschagrunert", "created_at": "2023-08-08 13:16:08", "type": "mentioned" }, { "author": "saschagrunert", "created_at": "2023-08-08 13:16:08", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-08 13:16:08", "type": "mentioned" }, { "author": "cpanato", "created_at": "2023-08-08 13:16:09", "type": "subscribed" }, { "author": "puerco", "created_at": "2023-08-08 13:16:09", "type": "mentioned" }, { "author": "puerco", "created_at": "2023-08-08 13:16:09", "type": "subscribed" }, { "author": "Verolop", "created_at": "2023-08-08 13:16:09", "type": "mentioned" }, { "author": "Verolop", "created_at": "2023-08-08 13:16:09", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:16:09", "type": "labeled" }, { "author": "justaugustus", "created_at": "2023-08-08 13:16:09", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-08 13:16:10", "type": "subscribed" }, { "author": "salaxander", "created_at": "2023-08-08 13:16:10", "type": "subscribed" }, { "author": "Verolop", "created_at": "2023-08-08 13:16:10", "type": "subscribed" }, { "author": "ameukam", "created_at": "2023-08-08 13:16:10", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:16:10", "type": "labeled" }, { "author": "ramrodo", "created_at": "2023-08-08 13:16:10", "type": "subscribed" }, { "author": "cici37", "created_at": "2023-08-08 13:16:10", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:16:10", "type": "labeled" }, { "author": "puerco", "created_at": "2023-08-08 13:16:10", "type": "subscribed" }, { "author": "palnabarun", "created_at": "2023-08-08 13:16:10", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-08 13:16:10", "type": "subscribed" }, { "author": "xmudrii", "created_at": "2023-08-08 13:16:10", "type": "subscribed" }, { "author": "jimangel", "created_at": "2023-08-08 13:16:10", "type": "subscribed" }, { "author": "k8s-release-robot", "created_at": "2023-08-08 13:16:10", "type": "subscribed" }, { "author": "jrsapi", "created_at": "2023-08-08 13:16:10", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 13:16:10", "type": "subscribed" }, { "author": "gracenng", "created_at": "2023-08-08 13:16:10", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:16:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:16:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:16:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:16:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:16:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:16:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:16:57", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:17:06", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:17:06", "type": "review_requested" }, { "author": "dims", "created_at": "2023-08-08 13:21:07", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-08 13:21:07", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-08 13:21:09", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:22:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:22:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:22:55", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:22:56", "type": "unlabeled" }, { "author": "jeremyrickard", "created_at": "2023-08-08 13:58:08", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 13:58:08", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-08-08 13:59:36", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 13:59:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 14:20:39", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:08:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:10:17", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:10:17", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 15:10:17", "type": "closed" } ]

[]

[ "sig/node", "kind/feature", "needs-triage" ]

[ { "body": "/sig node", "created_at": "2023-08-08 12:37:44" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 12:37:44" }, { "body": "How do we publish the `.proto` files for this? Are they a release artefact?\r\n\r\n---\r\n\r\nHow about making the sample API client code in another language (eg Python)? Using another language emphasizes that you can use this from a client implemented in any language.\r\n\r\nWe don't mind what language a third party writes their own implementation in, right?", "created_at": "2023-08-08 13:44:25" }, { "body": "> How do we publish the `.proto` files for this? Are they a release artefact?\r\n\r\nPublished in staging: https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io/kubelet/pkg/apis/podresources/v1\r\n \r\n> How about making the sample API client code in another language (eg Python)? Using another language emphasizes that you can use this from a client implemented in any language.\r\n\r\nThat would be fine. I'm suggesting to promote the golang client because it's a reasonnable starting point and I know for sure there are golang projects consuming the API. But adding more clients is fine and helpful.\r\n\r\n> We don't mind what language a third party writes their own implementation in, right?\r\n\r\nAFAIK we don't mind at all\r\n\r\n", "created_at": "2023-08-08 14:17:31" } ]

[ { "author": "ffromani", "created_at": "2023-08-08 12:37:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:37:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:37:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:37:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:37:47", "type": "unlabeled" } ]

[]

[ "kind/cleanup", "sig/cluster-lifecycle", "size/S", "release-note-none", "area/kubeadm", "cncf-cla: yes", "ok-to-test", "needs-priority", "needs-triage" ]

[ { "body": "<a href=\"https://easycla.lfx.linuxfoundation.org/#/?version=2\"><img src=\"https://s3.amazonaws.com/cla-project-logo-prod/cla-signed.svg\" alt=\"CLA Signed\" align=\"left\" height=\"28\" width=\"328\" ></a><br/><br />The committers listed above are authorized under a signed CLA.<ul><li>:white_check_mark: login: vadimInshakov / name: Vadim Inshakov (7c07064c039b495513b64e20940b06ee3df87812)</li></ul>", "created_at": "2023-08-08 12:29:32" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 22:33:07 UTC 2023.\n", "created_at": "2023-08-08 12:29:32" }, { "body": "Welcome @vadimInshakov! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:", "created_at": "2023-08-08 12:29:36" }, { "body": "Hi @vadimInshakov. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-08-08 12:29:37" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 12:29:38" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119816#\" title=\"Author self-approved\">vadimInshakov</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [fabriziopandini](https://github.com/fabriziopandini) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[cmd/kubeadm/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"fabriziopandini\"]} -->", "created_at": "2023-08-08 12:30:31" }, { "body": "/retest", "created_at": "2023-08-08 12:45:49" }, { "body": "@vadimInshakov: Cannot trigger testing until a trusted user reviews the PR and leaves an `/ok-to-test` message.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119816#issuecomment-1669544360):\n\n>/retest\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 12:46:05" }, { "body": "/cc @fabriziopandini ", "created_at": "2023-08-08 12:53:43" }, { "body": "/ok-to-test", "created_at": "2023-08-09 01:50:46" }, { "body": "As I see, tests that are not affected by this pull request have failed. What are my next steps?", "created_at": "2023-08-10 12:23:45" }, { "body": "@chendave is there anything else I can do for this request?", "created_at": "2023-08-11 22:54:24" }, { "body": "> As I see, tests that are not affected by this pull request have failed. What are my next steps?\r\n\r\nno, pls refer to this log, https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119816/pull-kubernetes-verify/1689091833763729408", "created_at": "2023-08-14 10:19:16" }, { "body": "/retest", "created_at": "2023-08-14 11:49:41" }, { "body": "/kind cleanup\r\n/release-note-none\r\n", "created_at": "2023-08-14 17:16:43" }, { "body": "/retitle kubeadm: check err in idiomatic way\r\n", "created_at": "2023-08-14 17:17:22" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:29:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:29:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:29:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:29:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:29:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:29:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:29:37", "type": "labeled" }, { "author": "vadiminshakov", "created_at": "2023-08-08 12:29:37", "type": "mentioned" }, { "author": "vadiminshakov", "created_at": "2023-08-08 12:29:37", "type": "subscribed" }, { "author": "vadiminshakov", "created_at": "2023-08-08 12:29:38", "type": "mentioned" }, { "author": "vadiminshakov", "created_at": "2023-08-08 12:29:38", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:29:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:30:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:30:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:30:09", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:30:18", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:30:19", "type": "review_requested" }, { "author": "vadiminshakov", "created_at": "2023-08-08 12:39:08", "type": "head_ref_force_pushed" }, { "author": "vadiminshakov", "created_at": "2023-08-08 12:39:13", "type": "mentioned" }, { "author": "vadiminshakov", "created_at": "2023-08-08 12:39:14", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:42:11", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:42:12", "type": "labeled" }, { "author": "vadiminshakov", "created_at": "2023-08-08 12:46:05", "type": "mentioned" }, { "author": "vadiminshakov", "created_at": "2023-08-08 12:46:05", "type": "subscribed" }, { "author": "fabriziopandini", "created_at": "2023-08-08 12:53:44", "type": "mentioned" }, { "author": "fabriziopandini", "created_at": "2023-08-08 12:53:44", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:53:45", "type": "review_requested" }, { "author": "toVersus", "created_at": "2023-08-08 14:51:42", "type": "unsubscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 01:50:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 01:50:48", "type": "unlabeled" }, { "author": "vadiminshakov", "created_at": "2023-08-09 02:20:21", "type": "mentioned" }, { "author": "vadiminshakov", "created_at": "2023-08-09 02:20:21", "type": "subscribed" }, { "author": "vadiminshakov", "created_at": "2023-08-09 02:31:21", "type": "mentioned" }, { "author": "vadiminshakov", "created_at": "2023-08-09 02:31:21", "type": "subscribed" }, { "author": "vadiminshakov", "created_at": "2023-08-09 02:47:07", "type": "mentioned" }, { "author": "vadiminshakov", "created_at": "2023-08-09 02:47:07", "type": "subscribed" }, { "author": "chendave", "created_at": "2023-08-11 22:54:25", "type": "mentioned" }, { "author": "chendave", "created_at": "2023-08-11 22:54:25", "type": "subscribed" }, { "author": "vadiminshakov", "created_at": "2023-08-14 11:35:36", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 11:49:49", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 11:49:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 17:16:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 17:16:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 17:16:45", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 17:16:46", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 17:17:15", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 17:17:24", "type": "renamed" }, { "author": "vadiminshakov", "created_at": "2023-08-14 21:02:52", "type": "head_ref_force_pushed" }, { "author": "vadiminshakov", "created_at": "2023-08-15 08:45:26", "type": "head_ref_force_pushed" } ]

[ "dims", "liggitt", "jeremyrickard" ]

[ "priority/important-soon", "kind/cleanup", "area/apiserver", "area/kubectl", "area/cloudprovider", "sig/storage", "sig/node", "sig/cluster-lifecycle", "size/L", "release-note-none", "sig/auth", "sig/cli", "cncf-cla: yes", "sig/instrumentation", "sig/architecture", "do-not-merge/cherry-pick-not-approved", "do-not-merge/hold", "area/code-generation", "sig/cloud-provider", "area/dependency", "triage/accepted" ]

[ { "body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 05:18:16" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119815#\" title=\"Author self-approved\">MadhavJivrajani</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [liggitt](https://github.com/liggitt), [sttts](https://github.com/sttts) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/OWNERS)**\n- **[staging/src/k8s.io/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/api/OWNERS)**\n- **[staging/src/k8s.io/apiextensions-apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/apiextensions-apiserver/OWNERS)**\n- **[staging/src/k8s.io/apimachinery/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/apimachinery/OWNERS)**\n- **[staging/src/k8s.io/apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/apiserver/OWNERS)**\n- **[staging/src/k8s.io/cli-runtime/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/cli-runtime/OWNERS)**\n- **[staging/src/k8s.io/client-go/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/client-go/OWNERS)**\n- **[staging/src/k8s.io/cloud-provider/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/cloud-provider/OWNERS)**\n- **[staging/src/k8s.io/cluster-bootstrap/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/cluster-bootstrap/OWNERS)**\n- **[staging/src/k8s.io/code-generator/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/code-generator/OWNERS)**\n- **[staging/src/k8s.io/component-base/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/component-base/OWNERS)**\n- **[staging/src/k8s.io/component-helpers/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/component-helpers/OWNERS)**\n- **[staging/src/k8s.io/controller-manager/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/controller-manager/OWNERS)**\n- **[staging/src/k8s.io/cri-api/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/cri-api/OWNERS)**\n- **[staging/src/k8s.io/csi-translation-lib/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/csi-translation-lib/OWNERS)**\n- **[staging/src/k8s.io/dynamic-resource-allocation/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/dynamic-resource-allocation/OWNERS)**\n- **[staging/src/k8s.io/kms/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/kms/OWNERS)**\n- **[staging/src/k8s.io/kube-aggregator/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/kube-aggregator/OWNERS)**\n- **[staging/src/k8s.io/kube-controller-manager/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/kube-controller-manager/OWNERS)**\n- **[staging/src/k8s.io/kube-proxy/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/kube-proxy/OWNERS)**\n- **[staging/src/k8s.io/kube-scheduler/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/kube-scheduler/OWNERS)**\n- **[staging/src/k8s.io/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/kubectl/OWNERS)**\n- **[staging/src/k8s.io/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/kubelet/OWNERS)**\n- **[staging/src/k8s.io/legacy-cloud-providers/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/legacy-cloud-providers/OWNERS)**\n- **[staging/src/k8s.io/metrics/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/metrics/OWNERS)**\n- **[staging/src/k8s.io/mount-utils/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/mount-utils/OWNERS)**\n- **[staging/src/k8s.io/pod-security-admission/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/pod-security-admission/OWNERS)**\n- **[staging/src/k8s.io/sample-apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/sample-apiserver/OWNERS)**\n- **[staging/src/k8s.io/sample-cli-plugin/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/sample-cli-plugin/OWNERS)**\n- **[staging/src/k8s.io/sample-controller/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/sample-controller/OWNERS)**\n- **[vendor/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/vendor/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"liggitt\",\"sttts\"]} -->", "created_at": "2023-08-08 05:18:53" }, { "body": "@MadhavJivrajani: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-e2e-capz-windows-containerd-1-26 | ddfa0a0797c6cce909e02d77daf019df3367ed78 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119815/pull-kubernetes-e2e-capz-windows-containerd-1-26/1688781652878168064) | false | `/test pull-kubernetes-e2e-capz-windows-containerd-1-26`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119815). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3AMadhavJivrajani). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-08-08 06:49:50" }, { "body": "similar comment to https://github.com/kubernetes/kubernetes/pull/119814#issuecomment-1669008998, we don't actually use the impacted method so I'm not sure we should pull in a lot of unrelated changes we don't need to", "created_at": "2023-08-08 07:56:25" }, { "body": "https://github.com/kubernetes/kubernetes/pull/119814#issuecomment-1669336694\r\n/hold ", "created_at": "2023-08-08 10:18:21" }, { "body": "/remove-sig api-machinery", "created_at": "2023-08-08 20:07:41" }, { "body": "/triage accepted", "created_at": "2023-08-24 09:40:11" } ]

[ { "author": "jeremyrickard", "created_at": "2023-08-08 05:18:13", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 05:18:13", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-08 05:18:13", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-08 05:18:14", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-08 05:18:14", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-08 05:18:14", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:15", "type": "labeled" }, { "author": "dims", "created_at": "2023-08-08 05:18:15", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:15", "type": "labeled" }, { "author": "jeremyrickard", "created_at": "2023-08-08 05:18:15", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:15", "type": "milestoned" }, { "author": "liggitt", "created_at": "2023-08-08 05:18:16", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:56", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:56", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:56", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:18:59", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:19:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:19:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:19:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:19:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:19:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:19:04", "type": "labeled" }, { "author": "MadhavJivrajani", "created_at": "2023-08-08 06:49:50", "type": "mentioned" }, { "author": "MadhavJivrajani", "created_at": "2023-08-08 06:49:50", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 10:18:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:07:43", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-24 09:40:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-24 09:40:14", "type": "unlabeled" } ]

[ "dims", "liggitt", "jeremyrickard" ]

[ "priority/important-soon", "kind/cleanup", "area/apiserver", "area/kubectl", "area/cloudprovider", "sig/storage", "sig/node", "sig/cluster-lifecycle", "size/L", "release-note-none", "sig/auth", "sig/cli", "cncf-cla: yes", "sig/instrumentation", "sig/architecture", "do-not-merge/cherry-pick-not-approved", "do-not-merge/hold", "area/code-generation", "sig/cloud-provider", "area/dependency", "triage/accepted" ]

[ { "body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 05:12:28" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119814#\" title=\"Author self-approved\">MadhavJivrajani</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [liggitt](https://github.com/liggitt) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.25/OWNERS)**\n- **[staging/src/k8s.io/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.25/staging/src/k8s.io/api/OWNERS)**\n- **[staging/src/k8s.io/legacy-cloud-providers/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.25/staging/src/k8s.io/legacy-cloud-providers/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"liggitt\"]} -->", "created_at": "2023-08-08 05:13:05" }, { "body": "/priority important-soon", "created_at": "2023-08-08 05:15:34" }, { "body": "We don't use the impacted method, so I'm not sure whether we will bump this dependency in release branches or not", "created_at": "2023-08-08 05:17:08" }, { "body": "@MadhavJivrajani: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-dependencies | a298214282de18d1c287a30e624a48c0a9cf3a75 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119814/pull-kubernetes-dependencies/1688780187585482752) | true | `/test pull-kubernetes-dependencies`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119814). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3AMadhavJivrajani). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-08-08 05:17:39" }, { "body": "> We don't use the impacted method, so I'm not sure whether we will bump this dependency in release branches or not\r\n\r\n@liggitt SGTM either way, this is mostly to make scanners happy for the next set of patch releases. Do you see a downside in cherry-picking this bump?", "created_at": "2023-08-08 05:32:49" }, { "body": "> Do you see a downside in cherry-picking this bump?\r\n\r\nThe actual changes required are much much larger (requires bumping the crypto, text, and sys libraries as well, see the presubmit failure)\r\n\r\nI haven't looked through all the changes to packages we do use yet, but there are also changes in the net http2 package that we'd need to make sure worked back in release branches. It's possible they are all fine, but it's not a no-op, so I wouldn't rush to update just to fix a false positive in a scanner", "created_at": "2023-08-08 06:51:07" }, { "body": "@liggitt that's a good point. \r\nI'll put this on hold for now in case we want to revive it, but if in case there is cause to close it out, I'm good with that.\r\n/hold ", "created_at": "2023-08-08 10:18:06" }, { "body": "+1 to what @liggitt said ", "created_at": "2023-08-08 16:22:01" }, { "body": "/remove-sig api-machinery", "created_at": "2023-08-08 20:07:47" }, { "body": "/triage accepted", "created_at": "2023-08-24 09:39:21" } ]

[ { "author": "jeremyrickard", "created_at": "2023-08-08 05:12:26", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 05:12:26", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-08 05:12:26", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-08 05:12:26", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-08 05:12:26", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-08 05:12:26", "type": "subscribed" }, { "author": "PushkarJ", "created_at": "2023-08-08 05:12:26", "type": "mentioned" }, { "author": "PushkarJ", "created_at": "2023-08-08 05:12:26", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:12:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:12:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:12:27", "type": "milestoned" }, { "author": "dims", "created_at": "2023-08-08 05:12:27", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:12:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:12:27", "type": "labeled" }, { "author": "jeremyrickard", "created_at": "2023-08-08 05:12:27", "type": "assigned" }, { "author": "liggitt", "created_at": "2023-08-08 05:12:28", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:12:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:12:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:12:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:12:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:08", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:09", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:09", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:11", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:13:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:15:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 05:15:37", "type": "unlabeled" }, { "author": "MadhavJivrajani", "created_at": "2023-08-08 05:17:40", "type": "mentioned" }, { "author": "MadhavJivrajani", "created_at": "2023-08-08 05:17:40", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-08 05:32:49", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-08 05:32:49", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-08 10:18:06", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-08 10:18:06", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 10:18:07", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-08-08 16:22:01", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-08 16:22:02", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:07:49", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-24 09:39:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-24 09:39:25", "type": "unlabeled" } ]

[ "kanurag94" ]

[ "sig/api-machinery", "kind/feature", "triage/accepted", "wg/structured-logging" ]

[ { "body": "/wg structure-logging\r\n/sig api-machinery", "created_at": "2023-08-08 03:41:28" }, { "body": "@zwpaper: The label(s) `wg/structure-logging` cannot be applied, because the repository doesn't have them.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119813#issuecomment-1668858660):\n\n>/wg structure-logging\r\n>/sig api-machinery\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 03:41:31" }, { "body": "/wg structured-logging", "created_at": "2023-08-08 03:42:00" }, { "body": "/remove-kind bug\r\n/kind feature", "created_at": "2023-08-08 08:37:25" }, { "body": "Hi, I would love to work on this. If assignable, could you please let me know if my understanding is correct:\r\n\r\n- use `context` to check if there is a logger present in context and change the default logger using something like `klog.SetLogger(klog.FromContext(ctx))`\r\n- make request logging more verbose\r\n\r\n/assign\r\n", "created_at": "2023-08-08 11:49:03" }, { "body": "hi @kanurag94, the issue is not yet accepted by the maintainers, we may have to wait for their response.\n\nAs for the implementation, I think we should use the logger from ctx directly if existing instead of setting the default logger.", "created_at": "2023-08-08 14:53:09" }, { "body": "/cc @apelisse \r\n/triage accepted", "created_at": "2023-08-08 20:01:42" }, { "body": "I think that's more a request for structured logging than api-machinery, but to be honest, I'm unsure what the problem is here? \r\n\r\n> but klog can only print some fixed messages.\r\n\r\nThat doesn't sound correct?", "created_at": "2023-08-08 20:58:02" }, { "body": "> I think that's more a request for structured logging than api-machinery, but to be honest, I'm unsure what the problem is here? \n> \n> \n> \n> > but klog can only print some fixed messages.\n> \n> \n> \n> That doesn't sound correct?\n\nHi @apeliss, that's absolutely correct, but for a request logging, we may expect more, like what is this request, who sent it, eg., which could be set in the contexed logger", "created_at": "2023-08-09 02:09:37" } ]

[ { "author": "zwpaper", "created_at": "2023-08-08 03:01:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 03:02:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 03:02:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 03:41:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 03:41:31", "type": "unlabeled" }, { "author": "zwpaper", "created_at": "2023-08-08 03:41:31", "type": "mentioned" }, { "author": "zwpaper", "created_at": "2023-08-08 03:41:31", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 03:42:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 08:37:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 08:37:27", "type": "unlabeled" }, { "author": "kanurag94", "created_at": "2023-08-08 11:49:05", "type": "assigned" }, { "author": "kanurag94", "created_at": "2023-08-08 14:53:09", "type": "mentioned" }, { "author": "kanurag94", "created_at": "2023-08-08 14:53:09", "type": "subscribed" }, { "author": "apelisse", "created_at": "2023-08-08 20:01:42", "type": "mentioned" }, { "author": "apelisse", "created_at": "2023-08-08 20:01:42", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:01:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:01:45", "type": "unlabeled" } ]

[ "alexzielenski" ]

[ "sig/api-machinery", "size/L", "kind/api-change", "cncf-cla: yes", "do-not-merge/release-note-label-needed", "needs-priority", "triage/accepted" ]

[ { "body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 02:05:05" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 22:33:07 UTC 2023.\n", "created_at": "2023-08-08 02:05:07" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119812#\" title=\"Author self-approved\">weilaaa</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [smarterclayton](https://github.com/smarterclayton) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/apimachinery/pkg/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/OWNERS)**\n- **[staging/src/k8s.io/apimachinery/pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/apis/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"smarterclayton\"]} -->", "created_at": "2023-08-08 02:05:50" }, { "body": "/sig api-machinery", "created_at": "2023-08-08 02:16:03" }, { "body": "/cc @thockin ", "created_at": "2023-08-08 02:19:18" }, { "body": "/retest", "created_at": "2023-08-08 03:05:06" }, { "body": "/cc @jefftree\r\n/triage accepted", "created_at": "2023-08-08 20:08:25" }, { "body": "LGTM label has been added. <details>Git tree hash: 2536aa9d55938af1a6a9ea4a9d4122b9362caa78</details>", "created_at": "2023-08-12 00:34:49" }, { "body": "New changes are detected. LGTM label has been removed.", "created_at": "2023-08-14 04:25:33" }, { "body": "@Jefftree @alexzielenski Resolved nits. PTAL", "created_at": "2023-08-21 08:24:38" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-08 02:05:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 02:05:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 02:05:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 02:05:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 02:05:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 02:05:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 02:05:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 02:05:38", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 02:05:38", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 02:06:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 02:06:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 02:06:04", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 02:06:05", "type": "unlabeled" }, { "author": "thockin", "created_at": "2023-08-08 02:19:18", "type": "mentioned" }, { "author": "thockin", "created_at": "2023-08-08 02:19:18", "type": "subscribed" }, { "author": "weilaaa", "created_at": "2023-08-08 02:37:46", "type": "mentioned" }, { "author": "weilaaa", "created_at": "2023-08-08 02:37:46", "type": "subscribed" }, { "author": "weilaaa", "created_at": "2023-08-08 02:45:29", "type": "mentioned" }, { "author": "weilaaa", "created_at": "2023-08-08 02:45:29", "type": "subscribed" }, { "author": "Jefftree", "created_at": "2023-08-08 20:08:26", "type": "mentioned" }, { "author": "Jefftree", "created_at": "2023-08-08 20:08:26", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:08:26", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:08:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:08:29", "type": "unlabeled" }, { "author": "alexzielenski", "created_at": "2023-08-12 00:34:47", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-12 00:34:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 04:25:32", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 04:25:33", "type": "review_requested" }, { "author": "alexzielenski", "created_at": "2023-08-21 08:24:39", "type": "mentioned" }, { "author": "alexzielenski", "created_at": "2023-08-21 08:24:39", "type": "subscribed" }, { "author": "Jefftree", "created_at": "2023-08-21 08:24:39", "type": "mentioned" }, { "author": "Jefftree", "created_at": "2023-08-21 08:24:39", "type": "subscribed" } ]

[]

[ "area/test", "size/M", "approved", "sig/cli", "cncf-cla: yes", "sig/testing", "do-not-merge/release-note-label-needed", "do-not-merge/work-in-progress", "needs-priority", "needs-triage", "do-not-merge/needs-kind" ]

[ { "body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-07 23:19:53" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 22:33:07 UTC 2023.\n", "created_at": "2023-08-07 23:19:55" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-07 23:20:00" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2", "created_at": "2023-08-08 18:12:23" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2\r\n", "created_at": "2023-08-08 19:30:49" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2", "created_at": "2023-08-08 20:29:26" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2", "created_at": "2023-08-08 21:00:21" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2", "created_at": "2023-08-09 01:26:11" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2", "created_at": "2023-08-09 13:29:39" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2", "created_at": "2023-08-09 13:45:17" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2", "created_at": "2023-08-09 14:29:51" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2", "created_at": "2023-08-09 16:45:42" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2", "created_at": "2023-08-09 19:14:42" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2", "created_at": "2023-08-09 19:50:35" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2", "created_at": "2023-08-09 19:56:41" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2", "created_at": "2023-08-11 02:13:17" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2", "created_at": "2023-08-11 09:15:58" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2", "created_at": "2023-08-11 11:01:57" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2", "created_at": "2023-08-11 11:50:05" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2\r\n", "created_at": "2023-08-11 14:53:22" }, { "body": "/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2", "created_at": "2023-08-13 11:52:08" }, { "body": "/test pull-kubernetes-e2e-ec2", "created_at": "2023-08-13 18:22:13" }, { "body": "/test pull-kubernetes-e2e-ec2-conformance\r\n/test pull-kubernetes-e2e-ec2", "created_at": "2023-08-14 00:17:26" }, { "body": "/test pull-kubernetes-e2e-ec2", "created_at": "2023-08-14 10:10:38" }, { "body": "/test pull-kubernetes-e2e-ec2", "created_at": "2023-08-14 10:58:25" }, { "body": "/test pull-kubernetes-e2e-ec2-conformance\r\n/test pull-kubernetes-e2e-ec2", "created_at": "2023-08-14 11:46:56" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119811#\" title=\"Author self-approved\">dims</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[build/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/build/OWNERS)~~ [dims]\n- ~~[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/hack/OWNERS)~~ [dims]\n- ~~[test/e2e/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/kubectl/OWNERS)~~ [dims]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-14 13:20:47" }, { "body": "/test pull-kubernetes-e2e-ec2-conformance\r\n/test pull-kubernetes-e2e-ec2", "created_at": "2023-08-14 13:20:54" }, { "body": "/test pull-kubernetes-e2e-ec2-conformance\r\n/test pull-kubernetes-e2e-ec2", "created_at": "2023-08-15 11:09:27" }, { "body": "/test pull-kubernetes-e2e-ec2-conformance\r\n/test pull-kubernetes-e2e-ec2", "created_at": "2023-08-15 12:15:07" }, { "body": "/test pull-kubernetes-e2e-ec2-conformance\r\n/test pull-kubernetes-e2e-ec2", "created_at": "2023-08-15 12:45:59" }, { "body": "/test pull-kubernetes-e2e-ec2", "created_at": "2023-08-15 13:46:16" }, { "body": "/test pull-kubernetes-e2e-ec2-conformance\r\n/test pull-kubernetes-e2e-ec2", "created_at": "2023-08-15 15:38:18" }, { "body": "/test pull-kubernetes-e2e-ec2-conformance\r\n/test pull-kubernetes-e2e-ec2", "created_at": "2023-08-16 03:07:47" }, { "body": "@dims: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-node-e2e-ec2-containerd-kubetest2 | faecc29dad673ff63c2e9ad19f45c110abde7f40 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119811/pull-kubernetes-node-e2e-ec2-containerd-kubetest2/1690692718025510912) | false | `/test pull-kubernetes-node-e2e-ec2-containerd-kubetest2`\npull-kubernetes-e2e-kind-ipv6 | 2b2a13e92d7b1ae5724c32a0dec3055286b7d401 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119811/pull-kubernetes-e2e-kind-ipv6/1691077459249729536) | true | `/test pull-kubernetes-e2e-kind-ipv6`\npull-kubernetes-e2e-ec2 | 2b2a13e92d7b1ae5724c32a0dec3055286b7d401 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119811/pull-kubernetes-e2e-ec2/1691647926939422720) | false | `/test pull-kubernetes-e2e-ec2`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119811). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Adims). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-08-16 04:28:04" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:19:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:19:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:19:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:19:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:19:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:19:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:20:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:20:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:20:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:20:51", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:20:52", "type": "review_requested" }, { "author": "dims", "created_at": "2023-08-08 00:15:54", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-08 00:15:55", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-08 18:34:16", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-08 18:34:16", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-08 19:53:40", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-08 19:53:40", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-08 20:50:58", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-08 20:50:58", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-08 23:17:08", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-08 23:17:08", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-09 03:43:11", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-09 03:43:11", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-09 14:07:28", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-09 14:07:29", "type": "subscribed" }, { "author": "toVersus", "created_at": "2023-08-09 14:36:31", "type": "unsubscribed" }, { "author": "dims", "created_at": "2023-08-09 19:02:46", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-09 19:02:46", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-09 19:37:51", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-09 19:37:51", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-10 00:13:34", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-10 00:13:34", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-11 02:31:21", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-11 02:31:21", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-11 09:33:44", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-11 09:33:44", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-11 12:24:08", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-11 12:24:08", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-11 19:10:15", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-11 19:10:15", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-13 14:02:50", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-13 14:02:50", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-13 20:31:04", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-13 20:31:04", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-14 02:30:24", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-14 02:30:24", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-14 04:34:35", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-14 04:34:35", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-14 10:50:30", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-14 10:50:30", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-14 11:38:00", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-14 11:38:00", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-14 12:29:33", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-14 12:29:33", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 13:20:43", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 13:20:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 13:20:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 13:20:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 13:20:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 13:20:49", "type": "unlabeled" }, { "author": "dims", "created_at": "2023-08-14 13:27:53", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-14 13:27:54", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-14 14:03:24", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-14 14:03:24", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-14 15:35:45", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-14 15:35:45", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-15 11:35:02", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-15 11:35:02", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-15 11:35:09", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-15 11:35:09", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-15 12:40:08", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-15 12:40:08", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-15 12:40:23", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-15 12:40:23", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-15 13:39:57", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-15 13:39:57", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-15 14:31:29", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-15 14:31:29", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-15 16:26:35", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-15 16:26:35", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-16 04:28:04", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-16 04:28:05", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-22 18:02:01", "type": "closed" } ]

[ "liggitt", "jeremyrickard" ]

[ "priority/important-soon", "area/apiserver", "lgtm", "area/cloudprovider", "sig/api-machinery", "release-note", "size/L", "kind/api-change", "sig/auth", "approved", "cncf-cla: yes", "do-not-merge/cherry-pick-not-approved", "sig/cloud-provider", "area/dependency", "triage/accepted" ]

[ { "body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-07 23:04:55" }, { "body": "/priority important-soon\r\n/sig api-machinery\r\n\r\n/hold\r\nUntil https://github.com/kubernetes/kubernetes/pull/119800 merges\r\n", "created_at": "2023-08-07 23:06:10" }, { "body": "/triage accepted", "created_at": "2023-08-08 20:08:34" }, { "body": "/hold cancel\r\nThis is ready for backport.\r\n\r\n/assign @jeremyrickard ", "created_at": "2023-08-16 22:35:34" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-17 01:21:21" }, { "body": "LGTM label has been added. <details>Git tree hash: 4150ccbfd2916ec5fb52d6c76918469bb1925c11</details>", "created_at": "2023-08-17 01:21:28" }, { "body": "/hold until https://github.com/kubernetes/kubernetes/pull/119800#issuecomment-1681945591 is understood/fixed", "created_at": "2023-08-17 14:38:31" }, { "body": "/hold cancel\r\nThis is updated with fixes from https://github.com/kubernetes/kubernetes/pull/120097 and ready to merge.", "created_at": "2023-08-23 00:33:18" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-23 13:24:59" }, { "body": "LGTM label has been added. <details>Git tree hash: d26ebcc1b3b25d6ffdf54ff7ee7b4f6fb288097f</details>", "created_at": "2023-08-23 13:25:17" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119810#\" title=\"Author self-approved\">jpbetz</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119810#issuecomment-1689961543\" title=\"Approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/apiextensions-apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/apiextensions-apiserver/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/apiextensions-apiserver/pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/apiextensions-apiserver/pkg/apis/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/apiserver/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/cloud-provider/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/cloud-provider/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/controller-manager/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/controller-manager/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/kube-aggregator/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/kube-aggregator/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/kube-controller-manager/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/kube-controller-manager/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/legacy-cloud-providers/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/legacy-cloud-providers/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/pod-security-admission/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/pod-security-admission/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/sample-apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/sample-apiserver/OWNERS)~~ [liggitt]\n- ~~[vendor/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/vendor/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-23 13:25:37" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:04:54", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:04:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:04:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:04:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:04:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:04:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:04:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:05:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:05:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:05:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:05:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:05:44", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:05:44", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:05:44", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:05:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:05:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:05:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:05:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:05:47", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:05:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:05:48", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:06:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:06:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:06:15", "type": "unlabeled" }, { "author": "jpbetz", "created_at": "2023-08-07 23:11:07", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-07 23:11:07", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-07 23:21:23", "type": "head_ref_force_pushed" }, { "author": "jpbetz", "created_at": "2023-08-07 23:28:17", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-07 23:28:18", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-08 00:44:33", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:08:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:08:38", "type": "unlabeled" }, { "author": "jeremyrickard", "created_at": "2023-08-16 22:35:34", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-16 22:35:34", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-16 22:35:35", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 22:35:35", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-17 01:21:25", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 01:21:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 01:26:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 14:38:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 19:39:34", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 19:39:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 19:39:36", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 19:39:37", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 19:39:37", "type": "review_requested" }, { "author": "jpbetz", "created_at": "2023-08-22 20:26:32", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-22 20:26:32", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-22 23:33:59", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 00:33:19", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 13:25:16", "type": "labeled" } ]

[ "liggitt", "cici37" ]

[ "priority/important-soon", "area/apiserver", "lgtm", "area/cloudprovider", "sig/api-machinery", "release-note", "size/L", "kind/api-change", "sig/auth", "approved", "cncf-cla: yes", "do-not-merge/cherry-pick-not-approved", "sig/cloud-provider", "area/dependency", "triage/accepted" ]

[ { "body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-07 22:34:10" }, { "body": "/priority important-soon\r\n/sig api-machinery\r\n\r\n/hold\r\nUntil https://github.com/kubernetes/kubernetes/pull/119800 merges", "created_at": "2023-08-07 23:06:00" }, { "body": "/retest", "created_at": "2023-08-07 23:06:43" }, { "body": "/triage accepted", "created_at": "2023-08-08 20:08:41" }, { "body": "/hold cancel\r\n\r\nThis is ready for backport.\r\n\r\n/assign @cici37 ", "created_at": "2023-08-16 22:34:52" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-17 01:21:11" }, { "body": "LGTM label has been added. <details>Git tree hash: 163efa8beedd4bf1abba0b7aef1a7ed8ef72eca8</details>", "created_at": "2023-08-17 01:21:18" }, { "body": "/hold until https://github.com/kubernetes/kubernetes/pull/119800#issuecomment-1681945591 is understood/fixed", "created_at": "2023-08-17 14:38:27" }, { "body": "/hold cancel\r\nThis is updated with fixes from https://github.com/kubernetes/kubernetes/pull/120097 and ready to merge.", "created_at": "2023-08-23 00:29:56" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-23 13:24:51" }, { "body": "LGTM label has been added. <details>Git tree hash: 0998c8bfa10f7b1cecd2a38d513d98840373a035</details>", "created_at": "2023-08-23 13:25:15" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119809#\" title=\"Author self-approved\">jpbetz</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119809#issuecomment-1689961363\" title=\"Approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/apiextensions-apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/apiextensions-apiserver/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/apiextensions-apiserver/pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/apiextensions-apiserver/pkg/apis/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/apiserver/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/cloud-provider/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/cloud-provider/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/controller-manager/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/controller-manager/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/kube-aggregator/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/kube-aggregator/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/kube-controller-manager/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/kube-controller-manager/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/legacy-cloud-providers/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/legacy-cloud-providers/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/pod-security-admission/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/pod-security-admission/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/sample-apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/sample-apiserver/OWNERS)~~ [liggitt]\n- ~~[vendor/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/vendor/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-23 13:25:33" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:34:09", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:34:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:34:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:34:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:34:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:34:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:34:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:34:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:34:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:34:42", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:34:42", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:34:42", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:35:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:35:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:35:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:35:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:35:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:35:09", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:35:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:35:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:35:10", "type": "unlabeled" }, { "author": "jpbetz", "created_at": "2023-08-07 22:58:57", "type": "renamed" }, { "author": "jpbetz", "created_at": "2023-08-07 23:00:04", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-07 23:00:04", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:06:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:06:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:06:03", "type": "unlabeled" }, { "author": "jpbetz", "created_at": "2023-08-07 23:15:53", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-07 23:15:53", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-07 23:16:45", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-07 23:16:45", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-07 23:21:55", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:08:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:08:45", "type": "unlabeled" }, { "author": "cici37", "created_at": "2023-08-16 22:34:52", "type": "mentioned" }, { "author": "cici37", "created_at": "2023-08-16 22:34:52", "type": "subscribed" }, { "author": "cici37", "created_at": "2023-08-16 22:34:53", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 22:34:53", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-17 01:21:16", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 01:21:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 01:26:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 14:38:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 23:35:08", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 23:35:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 23:35:10", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 23:35:11", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 23:35:11", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 00:29:58", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 13:25:14", "type": "labeled" } ]

[]

[ "kind/documentation", "kind/cleanup", "sig/api-machinery", "size/M", "release-note-none", "cncf-cla: yes", "ok-to-test", "needs-priority", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 16:31:33 UTC 2023.\n", "created_at": "2023-08-07 22:08:35" }, { "body": "Hi @wafuwafu13. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-08-07 22:08:41" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119808#\" title=\"Author self-approved\">wafuwafu13</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [smarterclayton](https://github.com/smarterclayton) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/client-go/tools/cache/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/cache/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"smarterclayton\"]} -->", "created_at": "2023-08-07 22:09:17" }, { "body": "/kind cleanup\r\n/ok-to-test\r\n", "created_at": "2023-08-08 03:42:16" }, { "body": "/cc @jiahuif \r\n/triage accepted", "created_at": "2023-08-08 20:09:01" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:08:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:08:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:08:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:08:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:08:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:08:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:08:40", "type": "labeled" }, { "author": "wafuwafu13", "created_at": "2023-08-07 22:08:41", "type": "mentioned" }, { "author": "wafuwafu13", "created_at": "2023-08-07 22:08:41", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:08:41", "type": "labeled" }, { "author": "wafuwafu13", "created_at": "2023-08-07 22:08:51", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:09:04", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:09:05", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:09:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:09:31", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 03:42:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 03:42:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 03:42:18", "type": "unlabeled" }, { "author": "jiahuif", "created_at": "2023-08-08 20:09:01", "type": "mentioned" }, { "author": "jiahuif", "created_at": "2023-08-08 20:09:01", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:09:02", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:09:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:09:05", "type": "unlabeled" } ]

[ "dims", "liggitt", "ameukam" ]

[ "priority/important-soon", "area/apiserver", "lgtm", "area/cloudprovider", "sig/api-machinery", "release-note", "size/L", "kind/api-change", "sig/auth", "approved", "cncf-cla: yes", "do-not-merge/cherry-pick-not-approved", "sig/cloud-provider", "area/dependency", "triage/accepted" ]

[ { "body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-07 21:06:20" }, { "body": "/hold\r\nUntil https://github.com/kubernetes/kubernetes/pull/119800 merges", "created_at": "2023-08-07 21:13:33" }, { "body": "/priority important-soon\r\n/sig api-machinery", "created_at": "2023-08-07 21:13:54" }, { "body": "/retest", "created_at": "2023-08-07 23:06:49" }, { "body": "/triage accepted", "created_at": "2023-08-08 20:09:13" }, { "body": "/hold cancel\r\nThis is ready to backport. Since the fix is for an beta feature we didn't try to rush it into 1.28.0.\r\n\r\n/assign @ameukam ", "created_at": "2023-08-16 22:34:17" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-17 01:22:49" }, { "body": "LGTM label has been added. <details>Git tree hash: c67646378a7ee541a6a5d5f938f7f444dfb0380b</details>", "created_at": "2023-08-17 01:22:56" }, { "body": "This is updated with fixes from https://github.com/kubernetes/kubernetes/pull/120097 and ready to merge. It needs a new LGTM.", "created_at": "2023-08-22 22:26:58" }, { "body": "/approve\r\n/lgtm", "created_at": "2023-08-22 22:39:22" }, { "body": "LGTM label has been added. <details>Git tree hash: 9aca86f640e1b5e574751d7e38a3018adf640bc4</details>", "created_at": "2023-08-22 22:39:29" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-23 13:24:27" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119807#issuecomment-1689017539\" title=\"LGTM\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119807#\" title=\"Author self-approved\">jpbetz</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119807#issuecomment-1689960745\" title=\"Approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/OWNERS)~~ [dims,liggitt]\n- ~~[staging/src/k8s.io/apiextensions-apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/staging/src/k8s.io/apiextensions-apiserver/OWNERS)~~ [dims,jpbetz,liggitt]\n- ~~[staging/src/k8s.io/apiextensions-apiserver/pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/staging/src/k8s.io/apiextensions-apiserver/pkg/apis/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/staging/src/k8s.io/apiserver/OWNERS)~~ [dims,jpbetz,liggitt]\n- ~~[staging/src/k8s.io/cloud-provider/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/staging/src/k8s.io/cloud-provider/OWNERS)~~ [dims,liggitt]\n- ~~[staging/src/k8s.io/controller-manager/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/staging/src/k8s.io/controller-manager/OWNERS)~~ [dims,jpbetz,liggitt]\n- ~~[staging/src/k8s.io/kube-aggregator/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/staging/src/k8s.io/kube-aggregator/OWNERS)~~ [dims,jpbetz,liggitt]\n- ~~[staging/src/k8s.io/kube-controller-manager/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/staging/src/k8s.io/kube-controller-manager/OWNERS)~~ [dims,liggitt]\n- ~~[staging/src/k8s.io/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/staging/src/k8s.io/kubelet/OWNERS)~~ [dims,liggitt]\n- ~~[staging/src/k8s.io/legacy-cloud-providers/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/staging/src/k8s.io/legacy-cloud-providers/OWNERS)~~ [dims,liggitt]\n- ~~[staging/src/k8s.io/pod-security-admission/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/staging/src/k8s.io/pod-security-admission/OWNERS)~~ [dims,liggitt]\n- ~~[staging/src/k8s.io/sample-apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/staging/src/k8s.io/sample-apiserver/OWNERS)~~ [dims,jpbetz,liggitt]\n- ~~[vendor/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/vendor/OWNERS)~~ [dims,liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-23 13:24:57" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:53", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:53", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:53", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:55", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:06:56", "type": "unlabeled" }, { "author": "jpbetz", "created_at": "2023-08-07 21:07:28", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:13:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:13:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:13:57", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:14:24", "type": "labeled" }, { "author": "jpbetz", "created_at": "2023-08-07 21:36:13", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-07 21:36:13", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-07 22:58:42", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:09:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:09:17", "type": "unlabeled" }, { "author": "ameukam", "created_at": "2023-08-16 22:34:18", "type": "mentioned" }, { "author": "ameukam", "created_at": "2023-08-16 22:34:18", "type": "subscribed" }, { "author": "ameukam", "created_at": "2023-08-16 22:34:18", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 22:34:19", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-17 01:22:54", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 01:22:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 01:27:44", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-08-22 17:38:39", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 20:05:49", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 20:05:49", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 20:05:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 20:05:50", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 20:05:50", "type": "review_requested" }, { "author": "dims", "created_at": "2023-08-22 22:39:27", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 22:39:28", "type": "labeled" } ]

[ "liggitt" ]

[ "priority/backlog", "kind/cleanup", "lgtm", "sig/api-machinery", "size/XXL", "kind/api-change", "release-note-none", "sig/auth", "sig/apps", "approved", "cncf-cla: yes", "area/code-generation", "api-review", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 16:31:33 UTC 2023.\n", "created_at": "2023-08-07 20:53:16" }, { "body": "/milestone v1.29", "created_at": "2023-08-08 12:22:55" }, { "body": "/priority backlog", "created_at": "2023-08-08 12:23:16" }, { "body": "/assign liggitt\r\n\r\n(no rush, no-op change)", "created_at": "2023-08-08 12:28:25" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-17 15:36:11" }, { "body": "LGTM label has been added. <details>Git tree hash: e5e5ded76bcd0cfc8193e2de86513e7984d161bb</details>", "created_at": "2023-08-17 15:36:18" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119806#\" title=\"Author self-approved\">enj</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119806#issuecomment-1682498648\" title=\"Approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/api/OWNERS)~~ [liggitt]\n- ~~[pkg/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/api/OWNERS)~~ [liggitt]\n- ~~[pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/OWNERS)~~ [liggitt]\n- ~~[pkg/generated/openapi/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/generated/openapi/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/client-go/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-17 15:36:36" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:53:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:53:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:53:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:53:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:53:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:53:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:53:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:53:45", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:53:45", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:53:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:53:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:53:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:53:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:54:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:54:00", "type": "unlabeled" }, { "author": "enj", "created_at": "2023-08-07 21:19:33", "type": "mentioned" }, { "author": "enj", "created_at": "2023-08-07 21:19:33", "type": "subscribed" }, { "author": "enj", "created_at": "2023-08-07 21:27:48", "type": "mentioned" }, { "author": "enj", "created_at": "2023-08-07 21:27:48", "type": "subscribed" }, { "author": "enj", "created_at": "2023-08-07 21:50:20", "type": "mentioned" }, { "author": "enj", "created_at": "2023-08-07 21:50:20", "type": "subscribed" }, { "author": "enj", "created_at": "2023-08-07 23:11:54", "type": "mentioned" }, { "author": "enj", "created_at": "2023-08-07 23:11:54", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:22:56", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:23:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 12:23:20", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-08 12:28:27", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 15:36:16", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-08-17 15:36:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 15:36:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 18:21:22", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 18:21:22", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 18:21:23", "type": "closed" } ]

[]

[ "sig/node", "kind/failing-test", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-07 20:03:38" }, { "body": "/cc @pacoxu @dims @SergeyKanzhelev ", "created_at": "2023-08-07 20:03:59" }, { "body": "I think @tzneal has another issue open..", "created_at": "2023-08-07 20:30:29" }, { "body": "Yeah, I'm tracking the issues that are failing on EC2 instances at https://github.com/kubernetes/kubernetes/issues/119763 . PRs are up for most of them, some config issues on the VM side, some are flakes everywhere, one is still up in the air.", "created_at": "2023-08-07 20:32:39" }, { "body": "@tzneal can we add this one there? ", "created_at": "2023-08-08 09:32:08" }, { "body": "> @tzneal can we add this one there?\r\n\r\nYup, just added it.", "created_at": "2023-08-08 12:59:32" }, { "body": "adding a link to this issue or copying description there would be nice.", "created_at": "2023-08-08 17:46:01" }, { "body": "Sorry, I thought this failing test was already tracked there, though not this particular job. I added a link back to this issue.", "created_at": "2023-08-08 18:02:25" }, { "body": "@dims I looked at this one closer, its run on gke so is unrelated to the other perma-failure on a cgroupsv1 AL2 node.", "created_at": "2023-08-17 00:32:40" } ]

[ { "author": "bart0sh", "created_at": "2023-08-07 20:03:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:03:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:03:37", "type": "labeled" }, { "author": "dims", "created_at": "2023-08-07 20:03:59", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-07 20:03:59", "type": "subscribed" }, { "author": "pacoxu", "created_at": "2023-08-07 20:03:59", "type": "mentioned" }, { "author": "pacoxu", "created_at": "2023-08-07 20:03:59", "type": "subscribed" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-07 20:03:59", "type": "mentioned" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-07 20:04:00", "type": "subscribed" }, { "author": "tzneal", "created_at": "2023-08-07 20:30:29", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-08-07 20:30:29", "type": "subscribed" }, { "author": "tzneal", "created_at": "2023-08-08 09:32:08", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-08-08 09:32:08", "type": "subscribed" }, { "author": "tzneal", "created_at": "2023-08-08 12:59:33", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-08-08 12:59:33", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-17 00:32:41", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-17 00:32:41", "type": "subscribed" } ]

[ "dims", "saschagrunert", "Verolop", "ameukam", "puerco", "cpanato" ]

[ "area/test", "priority/important-soon", "lgtm", "release-note", "size/S", "kind/feature", "area/release-eng", "approved", "cncf-cla: yes", "sig/testing", "sig/release", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 16:31:33 UTC 2023.\n", "created_at": "2023-08-07 19:48:08" }, { "body": "/triage accepted", "created_at": "2023-08-07 19:48:36" }, { "body": "/priority important-soon", "created_at": "2023-08-07 19:49:23" }, { "body": "/milestone v1.28", "created_at": "2023-08-07 19:50:23" }, { "body": "/lgtm", "created_at": "2023-08-07 19:59:54" }, { "body": "LGTM label has been added. <details>Git tree hash: e7fd6ea185057910b66791778a228bdc617110e7</details>", "created_at": "2023-08-07 20:00:01" }, { "body": "/retest ", "created_at": "2023-08-07 21:28:43" }, { "body": "LGTM label has been added. <details>Git tree hash: 1a8d2d3f2ac188e8acadbb63a68fe564817d471f</details>", "created_at": "2023-08-07 23:38:08" }, { "body": "/assign @dims", "created_at": "2023-08-08 00:03:04" }, { "body": "/retest\r\n", "created_at": "2023-08-08 00:13:22" }, { "body": "/approve", "created_at": "2023-08-08 00:38:52" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119804#issuecomment-1668747043\" title=\"Approved\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119804#\" title=\"Author self-approved\">jeremyrickard</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119804#pullrequestreview-1566277726\" title=\"Approved\">Verolop</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/kubernetes/kubernetes/blob/master/OWNERS)~~ [dims]\n- ~~[build/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/build/OWNERS)~~ [dims]\n- ~~[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/hack/OWNERS)~~ [dims]\n- ~~[staging/publishing/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/publishing/OWNERS)~~ [dims]\n- ~~[test/images/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/images/OWNERS)~~ [dims]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-08 00:43:47" } ]

[ { "author": "saschagrunert", "created_at": "2023-08-07 19:48:04", "type": "mentioned" }, { "author": "saschagrunert", "created_at": "2023-08-07 19:48:05", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-07 19:48:05", "type": "mentioned" }, { "author": "cpanato", "created_at": "2023-08-07 19:48:05", "type": "subscribed" }, { "author": "puerco", "created_at": "2023-08-07 19:48:05", "type": "mentioned" }, { "author": "puerco", "created_at": "2023-08-07 19:48:05", "type": "subscribed" }, { "author": "Verolop", "created_at": "2023-08-07 19:48:05", "type": "mentioned" }, { "author": "Verolop", "created_at": "2023-08-07 19:48:05", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:48:06", "type": "labeled" }, { "author": "cpanato", "created_at": "2023-08-07 19:48:06", "type": "assigned" }, { "author": "cici37", "created_at": "2023-08-07 19:48:06", "type": "subscribed" }, { "author": "palnabarun", "created_at": "2023-08-07 19:48:06", "type": "subscribed" }, { "author": "justaugustus", "created_at": "2023-08-07 19:48:06", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:48:06", "type": "labeled" }, { "author": "xmudrii", "created_at": "2023-08-07 19:48:06", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:48:06", "type": "labeled" }, { "author": "k8s-release-robot", "created_at": "2023-08-07 19:48:06", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-07 19:48:06", "type": "subscribed" }, { "author": "puerco", "created_at": "2023-08-07 19:48:06", "type": "assigned" }, { "author": "jeremyrickard", "created_at": "2023-08-07 19:48:06", "type": "subscribed" }, { "author": "salaxander", "created_at": "2023-08-07 19:48:06", "type": "subscribed" }, { "author": "gracenng", "created_at": "2023-08-07 19:48:06", "type": "subscribed" }, { "author": "Verolop", "created_at": "2023-08-07 19:48:06", "type": "subscribed" }, { "author": "ameukam", "created_at": "2023-08-07 19:48:06", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-07 19:48:06", "type": "assigned" }, { "author": "ramrodo", "created_at": "2023-08-07 19:48:06", "type": "subscribed" }, { "author": "puerco", "created_at": "2023-08-07 19:48:06", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-07 19:48:07", "type": "subscribed" }, { "author": "Verolop", "created_at": "2023-08-07 19:48:07", "type": "assigned" }, { "author": "jimangel", "created_at": "2023-08-07 19:48:07", "type": "subscribed" }, { "author": "jrsapi", "created_at": "2023-08-07 19:48:07", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:48:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:48:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:48:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:48:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:48:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:48:40", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:48:45", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:48:45", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:49:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:49:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:49:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:49:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:49:11", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:49:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:49:27", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:50:25", "type": "milestoned" }, { "author": "ameukam", "created_at": "2023-08-07 19:59:58", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:00:00", "type": "labeled" }, { "author": "jeremyrickard", "created_at": "2023-08-07 20:37:05", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-07 20:37:05", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-07 22:20:18", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-07 22:20:18", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:36:01", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:36:02", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:36:02", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:36:02", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:36:02", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:36:02", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 23:38:07", "type": "labeled" }, { "author": "dims", "created_at": "2023-08-08 00:03:04", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-08 00:03:04", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-08 00:03:05", "type": "assigned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 00:07:14", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-08 00:07:15", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 00:43:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 00:44:13", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 00:44:13", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 00:44:13", "type": "closed" } ]

[ "apelisse" ]

[ "lgtm", "sig/api-machinery", "size/XS", "kind/feature", "cncf-cla: yes", "needs-ok-to-test", "do-not-merge/release-note-label-needed", "needs-priority", "triage/accepted" ]

[ { "body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-07 19:22:50" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 16:31:33 UTC 2023.\n", "created_at": "2023-08-07 19:22:52" }, { "body": "Welcome @takirala! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:", "created_at": "2023-08-07 19:22:56" }, { "body": "Hi @takirala. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-08-07 19:22:57" }, { "body": "/cc @seans3 \r\n/triage accepted", "created_at": "2023-08-08 20:10:10" }, { "body": "/approve\r\n/lgtm", "created_at": "2023-08-10 21:48:27" }, { "body": "LGTM label has been added. <details>Git tree hash: c8acd057bb2771c065c29fdd7bf92aec2c5b0fba</details>", "created_at": "2023-08-10 21:48:34" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119802#issuecomment-1673962879\" title=\"LGTM\">apelisse</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119802#\" title=\"Author self-approved\">takirala</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [sttts](https://github.com/sttts) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/client-go/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"sttts\"]} -->", "created_at": "2023-08-10 21:48:50" }, { "body": "/retest", "created_at": "2023-08-11 08:54:31" }, { "body": "@takirala: Cannot trigger testing until a trusted user reviews the PR and leaves an `/ok-to-test` message.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119802#issuecomment-1674413997):\n\n>/retest\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-11 08:54:45" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Aug 11 04:35:43 UTC 2023.\n", "created_at": "2023-08-11 08:57:47" }, { "body": "I guess I don’t have access to rerun tests but also I think the tests are flakes and should be unaffected by the changes here", "created_at": "2023-08-11 08:59:39" }, { "body": "/retest", "created_at": "2023-08-15 16:09:50" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:22:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:22:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:22:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:22:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:22:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:22:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:22:56", "type": "labeled" }, { "author": "takirala", "created_at": "2023-08-07 19:22:56", "type": "mentioned" }, { "author": "takirala", "created_at": "2023-08-07 19:22:56", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:22:57", "type": "labeled" }, { "author": "takirala", "created_at": "2023-08-07 19:22:57", "type": "mentioned" }, { "author": "takirala", "created_at": "2023-08-07 19:22:57", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:23:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:23:21", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:23:42", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:23:42", "type": "review_requested" }, { "author": "seans3", "created_at": "2023-08-08 20:10:11", "type": "mentioned" }, { "author": "seans3", "created_at": "2023-08-08 20:10:11", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:10:12", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:10:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:10:14", "type": "unlabeled" }, { "author": "apelisse", "created_at": "2023-08-10 21:48:31", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 21:48:32", "type": "labeled" }, { "author": "takirala", "created_at": "2023-08-10 22:03:58", "type": "mentioned" }, { "author": "takirala", "created_at": "2023-08-10 22:03:58", "type": "subscribed" }, { "author": "takirala", "created_at": "2023-08-10 22:51:34", "type": "mentioned" }, { "author": "takirala", "created_at": "2023-08-10 22:51:34", "type": "subscribed" }, { "author": "takirala", "created_at": "2023-08-11 08:54:46", "type": "mentioned" }, { "author": "takirala", "created_at": "2023-08-11 08:54:46", "type": "subscribed" }, { "author": "takirala", "created_at": "2023-08-11 08:55:08", "type": "closed" }, { "author": "takirala", "created_at": "2023-08-11 08:55:08", "type": "head_ref_deleted" }, { "author": "takirala", "created_at": "2023-08-11 08:57:38", "type": "head_ref_restored" }, { "author": "takirala", "created_at": "2023-08-11 08:57:43", "type": "reopened" } ]

[ "jpbetz", "liggitt" ]

[ "area/test", "kind/cleanup", "area/apiserver", "sig/api-machinery", "size/L", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "priority/important-longterm", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 16:31:33 UTC 2023.\n", "created_at": "2023-08-07 19:13:25" }, { "body": "/retest", "created_at": "2023-08-09 15:00:32" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119801#\" title=\"Author self-approved\">wojtek-t</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/apimachinery/pkg/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/OWNERS)~~ [wojtek-t]\n- ~~[staging/src/k8s.io/apiserver/pkg/endpoints/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/endpoints/OWNERS)~~ [wojtek-t]\n- ~~[test/integration/apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/integration/apiserver/OWNERS)~~ [wojtek-t]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-15 19:56:29" }, { "body": "/assign @sttts @jpbetz @liggitt - would any of you could help with reviewing this one?", "created_at": "2023-08-21 07:36:19" }, { "body": "/triage accepted", "created_at": "2023-08-22 20:07:39" }, { "body": "I have this queued up for review next week... it might help to go through this in person", "created_at": "2023-08-23 14:33:22" }, { "body": "/retest", "created_at": "2023-08-25 15:51:30" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:13:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:13:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:13:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:13:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:13:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:13:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:13:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:13:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:14:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:14:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:14:23", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:14:23", "type": "review_requested" }, { "author": "wojtek-t", "created_at": "2023-08-07 19:19:56", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-08-07 19:19:56", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:21:05", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:21:06", "type": "labeled" }, { "author": "wojtek-t", "created_at": "2023-08-07 19:53:58", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-08-07 19:53:58", "type": "subscribed" }, { "author": "wojtek-t", "created_at": "2023-08-09 18:57:32", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-08-09 18:57:33", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 19:56:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 19:56:41", "type": "labeled" }, { "author": "wojtek-t", "created_at": "2023-08-15 20:24:45", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-08-15 20:24:45", "type": "subscribed" }, { "author": "wojtek-t", "created_at": "2023-08-15 20:40:42", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-08-15 20:40:42", "type": "subscribed" }, { "author": "wojtek-t", "created_at": "2023-08-15 20:57:00", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-08-15 20:57:00", "type": "subscribed" }, { "author": "wojtek-t", "created_at": "2023-08-20 17:49:56", "type": "head_ref_force_pushed" }, { "author": "wojtek-t", "created_at": "2023-08-20 18:18:47", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-08-20 18:18:47", "type": "subscribed" }, { "author": "wojtek-t", "created_at": "2023-08-20 18:45:38", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-08-20 18:45:38", "type": "subscribed" }, { "author": "wojtek-t", "created_at": "2023-08-21 05:51:44", "type": "head_ref_force_pushed" }, { "author": "wojtek-t", "created_at": "2023-08-21 07:30:47", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-21 07:30:48", "type": "unlabeled" }, { "author": "jpbetz", "created_at": "2023-08-21 07:36:19", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-21 07:36:19", "type": "subscribed" }, { "author": "sttts", "created_at": "2023-08-21 07:36:19", "type": "mentioned" }, { "author": "sttts", "created_at": "2023-08-21 07:36:19", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-21 07:36:19", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-21 07:36:19", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-21 11:56:42", "type": "assigned" }, { "author": "sttts", "created_at": "2023-08-21 11:56:43", "type": "assigned" }, { "author": "liggitt", "created_at": "2023-08-21 11:56:43", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 20:07:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-22 20:07:43", "type": "unlabeled" }, { "author": "sttts", "created_at": "2023-08-23 17:10:13", "type": "unassigned" }, { "author": "wojtek-t", "created_at": "2023-08-25 13:48:09", "type": "head_ref_force_pushed" }, { "author": "wojtek-t", "created_at": "2023-08-25 14:51:52", "type": "head_ref_force_pushed" }, { "author": "wojtek-t", "created_at": "2023-08-25 15:47:23", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-08-25 15:47:23", "type": "subscribed" } ]

[ "liggitt" ]

[ "kind/bug", "priority/important-soon", "area/apiserver", "lgtm", "area/cloudprovider", "sig/api-machinery", "release-note", "size/M", "kind/api-change", "sig/auth", "approved", "cncf-cla: yes", "area/code-generation", "sig/cloud-provider", "area/dependency", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 16:31:33 UTC 2023.\n", "created_at": "2023-08-07 19:01:53" }, { "body": "/priority important-soon", "created_at": "2023-08-07 21:02:32" }, { "body": "The dep bump lgtm to me, and the change is quite contained. A couple questions on the k/k unit test changes.\r\n\r\nI assume we'd want to backport this to release branches anyway, so I could see it waiting for 1.28.1 or going into 1.28.0 IFF it will make the 1.28.0-rc.1 scheduled for Thursday (and not delay it).", "created_at": "2023-08-07 21:17:39" }, { "body": "/hold\r\nFor until code thaw per slack discussion with @dims \r\n\r\nEDIT: We'll backport to 1.28.1 via https://github.com/kubernetes/kubernetes/pull/119807", "created_at": "2023-08-07 22:14:11" }, { "body": "/retest", "created_at": "2023-08-07 23:06:57" }, { "body": "/triage accepted", "created_at": "2023-08-08 20:10:21" }, { "body": "Changelog suggestion\r\n```markdown\r\nFixed a bug where CEL expressions in CRD validation rules would incorrectly compute a high estimated cost for functions that return strings, lists or maps.\r\nThe incorrect cost was evident when the result of a function was used in subsequent operations.\r\n```\r\n\r\nDoes this definitely only apply to CRD validation and not elsewhere?", "created_at": "2023-08-14 16:52:46" }, { "body": "> Changelog suggestion\r\n> \r\n> ```\r\n> Fixed a bug where CEL expressions in CRD validation rules would incorrectly compute a high estimated cost for functions that return strings, lists or maps.\r\n> The incorrect cost was evident when the result of a function was used in subsequent operations.\r\n> ```\r\n> \r\n> Does this definitely only apply to CRD validation and not elsewhere?\r\n\r\nYes, this applies only to CRD validation. It is the only feature that uses estimated cost.", "created_at": "2023-08-16 19:12:38" }, { "body": "/hold cancel\r\nThis is ready to merge.", "created_at": "2023-08-16 19:13:15" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-08-16 19:57:29" }, { "body": "LGTM label has been added. <details>Git tree hash: 31c38f82edcf00bb81d314b41b7c74439caacc5d</details>", "created_at": "2023-08-16 19:57:36" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119800#\" title=\"Author self-approved\">jpbetz</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119800#issuecomment-1681193155\" title=\"Approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[OWNERS](https://github.com/kubernetes/kubernetes/blob/master/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/apiextensions-apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiextensions-apiserver/OWNERS)~~ [jpbetz,liggitt]\n- ~~[staging/src/k8s.io/apiextensions-apiserver/pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiextensions-apiserver/pkg/apis/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/OWNERS)~~ [jpbetz,liggitt]\n- ~~[staging/src/k8s.io/cloud-provider/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/cloud-provider/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/controller-manager/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/controller-manager/OWNERS)~~ [jpbetz,liggitt]\n- ~~[staging/src/k8s.io/kube-aggregator/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kube-aggregator/OWNERS)~~ [jpbetz,liggitt]\n- ~~[staging/src/k8s.io/kube-controller-manager/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kube-controller-manager/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubelet/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/legacy-cloud-providers/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/legacy-cloud-providers/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/pod-security-admission/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/pod-security-admission/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/sample-apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/sample-apiserver/OWNERS)~~ [jpbetz,liggitt]\n- ~~[vendor/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/vendor/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-16 20:02:58" }, { "body": "/retest", "created_at": "2023-08-16 21:27:36" }, { "body": "Merge of this is giving below error in ppc architecture:\r\n```\r\n--- FAIL: TestCostEstimation (1.90s)\r\n --- FAIL: TestCostEstimation/extended_library_replace (0.03s)\r\n --- FAIL: TestCostEstimation/extended_library_replace/calc_maxLength (0.02s)\r\n compilation_test.go:1223: Wrong cost (expected 629152, got 629154)\r\n --- FAIL: TestCostEstimation/extended_library_replace/set_maxLength (0.01s)\r\n compilation_test.go:1223: Wrong cost (expected 14, got 16)\r\n```\r\n@jpbetz Please let us know if anything has to be changed specific to architecture.", "created_at": "2023-08-17 09:29:17" }, { "body": "> Joe Betz Please let us know if anything has to be changed specific to architecture.\r\n\r\nThere is not. The cost of this expression changed from 16 to 14 in cel-go 1.16.1 (https://github.com/google/cel-go/commits/v0.16.1) by this exact amount. Can you point me to the test run, I'd like to validate that the dependency update was applied.", "created_at": "2023-08-17 14:45:17" }, { "body": "> > Joe Betz Please let us know if anything has to be changed specific to architecture.\r\n> \r\n> There is not. The cost of this expression changed from 16 to 14 in cel-go 1.16.1 (https://github.com/google/cel-go/commits/v0.16.1) by this exact amount. Can you point me to the test run, I'd like to validate that the dependency update was applied.\r\n\r\nhttps://prow.ppc64le-cloud.cis.ibm.net/view/gs/ppc64le-kubernetes/logs/periodic-kubernetes-unit-test-ppc64le/1692340684859641856 is the link to CI job that has been failing with above test.\r\n", "created_at": "2023-08-18 04:00:45" }, { "body": "> https://prow.ppc64le-cloud.cis.ibm.net/view/gs/ppc64le-kubernetes/logs/periodic-kubernetes-unit-test-ppc64le/1692340684859641856 is the link to CI job that has been failing with above test.\r\n\r\nYes, the test failures exactly matche what would happen if somehow the cel-go bump from 1.16.0 to 1.16.1 was somehow not applied.\r\n\r\nI checked the cel-go code for anything architecture specific and found nothing. I think our best lead at the moment is that the failure exactly matches what should happen if the dependency bump is not picked up. I've opened a slack thread: https://kubernetes.slack.com/archives/C09QZ4DQB/p1692373534287669\r\n", "created_at": "2023-08-18 15:48:42" }, { "body": "https://github.com/kubernetes/kubernetes/pull/120097 fixes the ppc64le issue.", "created_at": "2023-08-22 04:09:20" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:01:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:01:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:01:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:01:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:01:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:01:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:01:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:02:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:02:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:02:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:02:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:02:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:02:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:02:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:02:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:02:30", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:02:50", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:02:50", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 19:02:50", "type": "review_requested" }, { "author": "jpbetz", "created_at": "2023-08-07 19:09:02", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-07 19:09:03", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-07 19:44:12", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-07 19:44:12", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-07 19:55:00", "type": "head_ref_force_pushed" }, { "author": "jpbetz", "created_at": "2023-08-07 20:31:34", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-07 20:31:35", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-07 20:46:57", "type": "head_ref_force_pushed" }, { "author": "jpbetz", "created_at": "2023-08-07 20:52:51", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:02:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 21:02:36", "type": "unlabeled" }, { "author": "jpbetz", "created_at": "2023-08-07 22:10:38", "type": "head_ref_force_pushed" }, { "author": "jpbetz", "created_at": "2023-08-07 22:12:27", "type": "head_ref_force_pushed" }, { "author": "dims", "created_at": "2023-08-07 22:14:11", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-07 22:14:11", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 22:14:12", "type": "labeled" }, { "author": "jpbetz", "created_at": "2023-08-07 22:42:29", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-07 22:42:29", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-07 22:52:24", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-07 22:52:24", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:10:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:10:25", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 19:13:16", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-16 19:57:34", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 19:57:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 20:02:58", "type": "labeled" }, { "author": "jpbetz", "created_at": "2023-08-16 20:44:56", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-16 20:44:56", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 22:28:04", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 22:28:04", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 22:28:04", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 22:28:05", "type": "milestoned" }, { "author": "jpbetz", "created_at": "2023-08-17 09:29:17", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-17 09:29:18", "type": "subscribed" } ]

[ "tkashem" ]

[ "kind/bug", "priority/important-soon", "sig/api-machinery", "triage/accepted" ]

[ { "body": "/sig api-machinery\r\n", "created_at": "2023-08-07 18:55:32" }, { "body": "/cc @natherz97", "created_at": "2023-08-07 18:59:48" }, { "body": "/cc @MikeSpreitzer @wojtek-t ", "created_at": "2023-08-07 19:00:22" }, { "body": "/cc @andrewsykim", "created_at": "2023-08-07 19:01:57" }, { "body": "/assign", "created_at": "2023-08-07 20:00:42" }, { "body": "/triage accepted", "created_at": "2023-08-08 20:02:15" }, { "body": "Catching up after vacation.\r\n\r\nThanks for reporting this @tkashem - this indeed sounds like a serious enough bug that we should fixed asap.\r\n\r\n> we derive a new context from the request context, and pass the new context to the promise that will be used by req.wait(). the new context has a deadline of 1/4 of the request timeout (15s at most)\r\nThis approach does not depend on arrival of new request - https://github.com/kubernetes/kubernetes/pull/105849 is a work in progress for this approach.\r\n\r\nI very much prefer this option - iterating over all queues doesn't sound great to me.\r\nI didn't yet look into that PR, so I'm nt sure how much feasible it is and what complexity it is introducing, but assuming it's reasonable, I'm very much in favor of this option.\r\n\r\nOne additional comment I have is that we should also think about backporting it upfront, so any changes that would make that easier should be preferrable.\r\n\r\n/priority important-soon\r\n\r\n@MikeSpreitzer - for your thoughts too", "created_at": "2023-08-21 06:01:13" } ]

[ { "author": "tkashem", "created_at": "2023-08-07 18:38:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 18:38:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 18:38:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 18:55:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 18:55:35", "type": "unlabeled" }, { "author": "natherz97", "created_at": "2023-08-07 18:59:49", "type": "mentioned" }, { "author": "natherz97", "created_at": "2023-08-07 18:59:49", "type": "subscribed" }, { "author": "wojtek-t", "created_at": "2023-08-07 19:00:22", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-08-07 19:00:22", "type": "subscribed" }, { "author": "MikeSpreitzer", "created_at": "2023-08-07 19:00:23", "type": "mentioned" }, { "author": "MikeSpreitzer", "created_at": "2023-08-07 19:00:23", "type": "subscribed" }, { "author": "andrewsykim", "created_at": "2023-08-07 19:01:57", "type": "mentioned" }, { "author": "andrewsykim", "created_at": "2023-08-07 19:01:57", "type": "subscribed" }, { "author": "tkashem", "created_at": "2023-08-07 20:00:43", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:02:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:02:19", "type": "unlabeled" }, { "author": "tkashem", "created_at": "2023-08-21 06:01:13", "type": "mentioned" }, { "author": "tkashem", "created_at": "2023-08-21 06:01:14", "type": "subscribed" }, { "author": "MikeSpreitzer", "created_at": "2023-08-21 06:01:14", "type": "mentioned" }, { "author": "MikeSpreitzer", "created_at": "2023-08-21 06:01:14", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-21 06:01:16", "type": "labeled" } ]

[ "dims", "jpbetz", "liggitt" ]

[ "kind/bug", "area/test", "priority/critical-urgent", "lgtm", "sig/api-machinery", "size/M", "kind/flake", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "area/e2e-test-framework", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 16:31:33 UTC 2023.\n", "created_at": "2023-08-07 17:53:00" }, { "body": "/assign @jpbetz @liggitt ", "created_at": "2023-08-07 17:54:23" }, { "body": "addition of endpointslice logic lgtm, not sure about the masking the general error", "created_at": "2023-08-07 18:01:49" }, { "body": "> [FAILED] could not find group version resource for dynamic client and wardle/flunders (discovery error: <nil>, discovery results: map[schema.GroupVersionResource]struct {}{schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"bindings\"}:struct {}{}, schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"configmaps\"}:struct {}{}, schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"endpoints\"}:struct {}{}, schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"events\"}:struct {}{}, schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"limitranges\"}:struct {}{}, schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"persistentvolumeclaims\"}:struct {}{}, schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"pods\"}:struct {}{}, schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"podtemplates\"}:struct {}{}, schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"replicationcontrollers\"}:struct {}{}, schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"resourcequotas\"}:struct {}{}, schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"secrets\"}:struct {}{}, schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"serviceaccounts\"}:struct {}{}, schema.GroupVersionResource{Group:\"\", Version:\"v1\", Resource:\"services\"}:struct {}{}, schema.GroupVersionResource{Group:\"apps\", Version:\"v1\", Resource:\"controllerrevisions\"}:struct {}{}, schema.GroupVersionResource{Group:\"apps\", Version:\"v1\", Resource:\"daemonsets\"}:struct {}{}, schema.GroupVersionResource{Group:\"apps\", Version:\"v1\", Resource:\"deployments\"}:struct {}{}, schema.GroupVersionResource{Group:\"apps\", Version:\"v1\", Resource:\"replicasets\"}:struct {}{}, schema.GroupVersionResource{Group:\"apps\", Version:\"v1\", Resource:\"statefulsets\"}:struct {}{}, schema.GroupVersionResource{Group:\"authorization.k8s.io\", Version:\"v1\", Resource:\"localsubjectaccessreviews\"}:struct {}{}, schema.GroupVersionResource{Group:\"autoscaling\", Version:\"v2\", Resource:\"horizontalpodautoscalers\"}:struct {}{}, schema.GroupVersionResource{Group:\"batch\", Version:\"v1\", Resource:\"cronjobs\"}:struct {}{}, schema.GroupVersionResource{Group:\"batch\", Version:\"v1\", Resource:\"jobs\"}:struct {}{}, schema.GroupVersionResource{Group:\"coordination.k8s.io\", Version:\"v1\", Resource:\"leases\"}:struct {}{}, schema.GroupVersionResource{Group:\"crd-publish-openapi-test-foo.example.com\", Version:\"v1\", Resource:\"e2e-test-crd-publish-openapi-9175-crds\"}:struct {}{}, schema.GroupVersionResource{Group:\"discovery.k8s.io\", Version:\"v1\", Resource:\"endpointslices\"}:struct {}{}, schema.GroupVersionResource{Group:\"events.k8s.io\", Version:\"v1\", Resource:\"events\"}:struct {}{}, schema.GroupVersionResource{Group:\"networking.k8s.io\", Version:\"v1\", Resource:\"ingresses\"}:struct {}{}, schema.GroupVersionResource{Group:\"networking.k8s.io\", Version:\"v1\", Resource:\"networkpolicies\"}:struct {}{}, schema.GroupVersionResource{Group:\"policy\", Version:\"v1\", Resource:\"poddisruptionbudgets\"}:struct {}{}, schema.GroupVersionResource{Group:\"rbac.authorization.k8s.io\", Version:\"v1\", Resource:\"rolebindings\"}:struct {}{}, schema.GroupVersionResource{Group:\"rbac.authorization.k8s.io\", Version:\"v1\", Resource:\"roles\"}:struct {}{}, schema.GroupVersionResource{Group:\"storage.k8s.io\", Version:\"v1\", Resource:\"csistoragecapacities\"}:struct {}{}, schema.GroupVersionResource{Group:\"wardle.example.com\", Version:\"v1beta1\", Resource:\"flunders\"}:struct {}{}})\r\n\r\n/test pull-kubernetes-e2e-kind-ipv6\r\n", "created_at": "2023-08-07 18:33:29" }, { "body": "/lgtm", "created_at": "2023-08-07 20:40:26" }, { "body": "LGTM label has been added. <details>Git tree hash: c0e1e20303023aadd5b28fbee417f2d44a6816d6</details>", "created_at": "2023-08-07 20:40:32" }, { "body": "/retest", "created_at": "2023-08-07 20:40:33" }, { "body": "/priority critical-urgent", "created_at": "2023-08-08 10:29:08" }, { "body": "ping @kubernetes/release-managers ", "created_at": "2023-08-08 10:29:32" }, { "body": "/approve\r\n/lgtm", "created_at": "2023-08-08 10:40:16" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119798#\" title=\"Author self-approved\">aojea</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119798#issuecomment-1669369723\" title=\"LGTM\">dims</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e/framework/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/framework/OWNERS)~~ [aojea,dims]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-08 10:40:38" }, { "body": "/milestone v1.28", "created_at": "2023-08-08 10:43:23" }, { "body": "just saw this test fail again in https://github.com/kubernetes/kubernetes/pull/119798: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119835/pull-kubernetes-e2e-kind/1688980783198375936", "created_at": "2023-08-08 19:06:00" }, { "body": "/triage accepted", "created_at": "2023-08-08 20:10:32" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-07 17:52:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 17:52:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 17:52:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 17:52:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 17:53:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 17:53:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 17:53:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 17:53:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 17:53:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 17:53:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 17:53:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 17:53:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 17:53:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 17:53:54", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 17:54:03", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 17:54:03", "type": "review_requested" }, { "author": "jpbetz", "created_at": "2023-08-07 17:54:23", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-07 17:54:23", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-07 17:54:23", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-07 17:54:23", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-07 17:54:24", "type": "assigned" }, { "author": "liggitt", "created_at": "2023-08-07 17:54:25", "type": "assigned" }, { "author": "aojea", "created_at": "2023-08-07 18:28:32", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-07 18:28:32", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-08-07 18:34:42", "type": "head_ref_force_pushed" }, { "author": "aojea", "created_at": "2023-08-07 19:00:08", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-07 19:00:08", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 20:40:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 10:29:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 10:29:11", "type": "unlabeled" }, { "author": "justaugustus", "created_at": "2023-08-08 10:29:32", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-08-08 10:29:32", "type": "subscribed" }, { "author": "Verolop", "created_at": "2023-08-08 10:29:32", "type": "subscribed" }, { "author": "puerco", "created_at": "2023-08-08 10:29:32", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-08-08 10:29:32", "type": "subscribed" }, { "author": "cici37", "created_at": "2023-08-08 10:29:32", "type": "subscribed" }, { "author": "palnabarun", "created_at": "2023-08-08 10:29:33", "type": "subscribed" }, { "author": "xmudrii", "created_at": "2023-08-08 10:29:33", "type": "subscribed" }, { "author": "k8s-release-robot", "created_at": "2023-08-08 10:29:33", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-08 10:29:33", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-08 10:40:21", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 10:43:25", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 11:52:15", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 11:52:15", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 11:52:15", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:10:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:10:36", "type": "unlabeled" } ]

[]

[ "kind/support", "sig/node", "kind/feature", "sig/apps", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-07 12:23:01" }, { "body": "> Initial analysis of node utilization indicated that resource requests were over 200%, while limits were coming at 99%. This might suggest high utilization at first glance.\r\n\r\nWhere did you get these numbers? Can you show the commands you ran and their output?\r\n\r\n> Failed Pod Assignments: This skewed resource allocation prevents the node from accepting new pods. Attempts to schedule new pods are resulting in failures with the error message: \"0/2 nodes are available: 2 Insufficient memory nodes.\"\r\n\r\nPods are assigned to nodes based on the resource requests. The resource request may not have any relation to the amount of resources that the pod actually uses (e.g. You can have a pod that runs \"/bin/pause\" and give it a CPU request of 20. It won't run on a node unless it has 20 CPUs free, but the pod will never actually use that much CPU. It will just sit idle.). ", "created_at": "2023-08-07 13:08:20" }, { "body": "@tzneal Thanks for your reply. \r\n\r\nMy bad i was talking vice versa of requests and limits :\r\n```\r\n (Total limits may be over 100 percent, i.e., overcommitted.)\r\n Resource Requests Limits\r\n -------- -------- ------\r\n cpu 3115m (41%) 11400m (152%)\r\n memory 9140490624 (29%) 20921295616 (66%)\r\n```\r\nI could not able to recreate the issue now. But I have seen cases where mapr pod (memory intensive) applications used to take over the node resources completely and starve for other pods or fails existing pods.\r\n\r\nBut convincing our capacity team about the node utilisation where they take utilisation report very conventionally using vmstat and top dose not shows load not more than 35% and they don't agree to release new nodes for eks clusters. ", "created_at": "2023-08-10 06:49:08" }, { "body": "There are docs at https://kubernetes.io/docs/concepts/configuration/manage-resources-containers that cover requests/limits. https://kubernetes.io/docs/tasks/configure-pod-container/quality-service-pod/ is probably also of interest since it covers QoS and how its affected by requests/limits.\r\n\r\n\r\n/kind support", "created_at": "2023-08-10 13:09:23" }, { "body": "/sig node apps\r\n/close\r\n\r\nyou could join the above SIG meetings or their slack channels for more direct feedback:\r\nhttps://github.com/kubernetes/community/tree/master/sig-node/README.md\r\nhttps://github.com/kubernetes/community/tree/master/sig-apps/README.md\r\n\r\nif they confirm there is a missing feature or something is not behaving as designed, please re-open this ticket.\r\n", "created_at": "2023-08-14 16:23:02" }, { "body": "@neolit123: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119797#issuecomment-1677654475):\n\n>/sig node apps\r\n>/close\r\n>\r\n>you could join the above SIG meetings or their slack channels for more direct feedback:\r\n>https://github.com/kubernetes/community/tree/master/sig-node/README.md\r\n>https://github.com/kubernetes/community/tree/master/sig-apps/README.md\r\n>\r\n>if they confirm there is a missing feature or something is not behaving as designed, please re-open this ticket.\r\n>\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-14 16:23:07" } ]

[ { "author": "vuravenkatachaitanya", "created_at": "2023-08-07 12:22:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 12:22:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 12:23:00", "type": "labeled" }, { "author": "tzneal", "created_at": "2023-08-10 06:49:09", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-08-10 06:49:09", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-10 13:09:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:23:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:23:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:23:05", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:23:07", "type": "closed" }, { "author": "neolit123", "created_at": "2023-08-14 16:23:08", "type": "mentioned" }, { "author": "neolit123", "created_at": "2023-08-14 16:23:08", "type": "subscribed" } ]

[ "ncdc" ]

[ "priority/important-soon", "kind/cleanup", "lgtm", "sig/api-machinery", "release-note", "size/XS", "approved", "cncf-cla: yes", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 10:31:42 UTC 2023.\n", "created_at": "2023-08-07 11:00:56" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119796#\" title=\"Author self-approved\">sttts</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/client-go/tools/cache/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/cache/OWNERS)~~ [sttts]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-07 11:00:57" }, { "body": "/lgtm", "created_at": "2023-08-07 13:44:44" }, { "body": "LGTM label has been added. <details>Git tree hash: a440cb363919e06ce15419ddf54d432a67912b9e</details>", "created_at": "2023-08-07 13:44:52" }, { "body": "/triage accepted", "created_at": "2023-08-08 20:10:39" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-07 11:00:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 11:00:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 11:00:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 11:00:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 11:00:57", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 11:00:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 11:00:57", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 11:00:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 11:00:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 11:01:01", "type": "labeled" }, { "author": "sttts", "created_at": "2023-08-07 11:01:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 11:01:14", "type": "unlabeled" }, { "author": "ncdc", "created_at": "2023-08-07 13:44:50", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 13:44:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:10:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:10:43", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:25", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:25", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:25", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:27", "type": "milestoned" } ]

[ "p0lyn0mial" ]

[ "priority/important-soon", "kind/cleanup", "area/apiserver", "lgtm", "sig/api-machinery", "release-note", "size/S", "approved", "cncf-cla: yes", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 04:30:46 UTC 2023.\n", "created_at": "2023-08-07 09:28:15" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119795#\" title=\"Author self-approved\">sttts</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/OWNERS)~~ [sttts]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-07 09:28:17" }, { "body": "/lgtm", "created_at": "2023-08-07 09:47:22" }, { "body": "LGTM label has been added. <details>Git tree hash: 3340ca563d608d2f9dae6f631492df53bc6156d0</details>", "created_at": "2023-08-07 09:47:29" }, { "body": "/lgtm", "created_at": "2023-08-07 10:57:17" }, { "body": "LGTM label has been added. <details>Git tree hash: 0cd7e02ac1368cd27bdc552f9bdf292c13ad48ce</details>", "created_at": "2023-08-07 10:57:22" }, { "body": "/triage accepted", "created_at": "2023-08-08 20:10:47" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-07 09:28:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 09:28:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 09:28:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 09:28:17", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 09:28:17", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 09:28:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 09:28:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 09:28:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 09:28:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 09:28:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 09:28:20", "type": "labeled" }, { "author": "sttts", "created_at": "2023-08-07 09:41:49", "type": "head_ref_force_pushed" }, { "author": "sttts", "created_at": "2023-08-07 09:45:32", "type": "head_ref_force_pushed" }, { "author": "p0lyn0mial", "created_at": "2023-08-07 09:47:27", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 09:47:28", "type": "labeled" }, { "author": "sttts", "created_at": "2023-08-07 09:48:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 09:49:01", "type": "unlabeled" }, { "author": "sttts", "created_at": "2023-08-07 10:10:53", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 10:10:55", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 10:10:56", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 10:57:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:10:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:10:51", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:18", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:18", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:18", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:20", "type": "milestoned" } ]

[ "pohly", "dims" ]

[ "kind/bug", "area/kubelet", "kind/cleanup", "lgtm", "sig/node", "size/XS", "release-note-none", "approved", "cncf-cla: yes", "priority/important-longterm", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 04:30:46 UTC 2023.\n", "created_at": "2023-08-07 08:59:37" }, { "body": "/assign @dims @pohly ", "created_at": "2023-08-07 08:59:53" }, { "body": "/retest\r\n/approve\r\n\r\nleaving lgtm for @pohly ", "created_at": "2023-08-07 10:29:23" }, { "body": "Can you remove `Fixes: #117809`? It's related, but might not be the complete fix (depending on whether we decide that klog is doing the right thing here).\r\n\r\n", "created_at": "2023-08-07 10:46:56" }, { "body": "/triage accepted\r\n/priority important-longterm\r\n\r\npriority set because related to a bug", "created_at": "2023-08-07 15:25:17" }, { "body": "LGTM label has been added. <details>Git tree hash: bd403f13d7e32b7d04b3602e93c3a9bd239d2a7f</details>", "created_at": "2023-08-08 07:19:35" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119794#\" title=\"Author self-approved\">aojea</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119794#issuecomment-1667603891\" title=\"Approved\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119794#pullrequestreview-1566635585\" title=\"LGTM\">pohly</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/OWNERS)~~ [dims]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-08 07:19:55" }, { "body": "/retest\r\n\r\nThe pkg/kubelet/cm/dra unit test flake is a know issue with a PR pending.\r\n", "created_at": "2023-08-08 07:20:11" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:59:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:59:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:59:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:59:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:59:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:59:39", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:59:39", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:59:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:59:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:59:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:59:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:59:41", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:59:42", "type": "labeled" }, { "author": "pohly", "created_at": "2023-08-07 08:59:53", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-07 08:59:53", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-07 08:59:54", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-07 08:59:54", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-07 08:59:54", "type": "assigned" }, { "author": "pohly", "created_at": "2023-08-07 08:59:55", "type": "assigned" }, { "author": "aojea", "created_at": "2023-08-07 09:28:19", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-07 09:28:19", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-08-07 09:55:53", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-07 09:55:53", "type": "subscribed" }, { "author": "pohly", "created_at": "2023-08-07 10:29:23", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-07 10:29:23", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 10:29:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 15:25:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 15:25:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 15:25:22", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 15:25:23", "type": "unlabeled" }, { "author": "aojea", "created_at": "2023-08-07 22:48:48", "type": "head_ref_force_pushed" }, { "author": "aojea", "created_at": "2023-08-07 23:28:21", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-07 23:28:21", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 07:19:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:11", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:11", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:11", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 06:13:13", "type": "milestoned" } ]

[]

[ "kind/bug", "area/kubelet", "sig/storage", "sig/node", "size/S", "cncf-cla: yes", "needs-ok-to-test", "do-not-merge/release-note-label-needed", "needs-priority", "needs-triage" ]

[ { "body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-07 08:20:42" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 7 04:30:46 UTC 2023.\n", "created_at": "2023-08-07 08:20:44" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119793#\" title=\"Author self-approved\">borgerli</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [dchen1107](https://github.com/dchen1107) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/OWNERS)**\n- **[pkg/volume/emptydir/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/emptydir/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"dchen1107\"]} -->", "created_at": "2023-08-07 08:20:47" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-07 08:20:49" }, { "body": "Hi @borgerli. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-08-07 08:20:50" }, { "body": "@iholder101, thanks for the reply. \r\n\r\n1. For diretories created for empty-dir, there should be no mountpoints.\r\n\r\n// Not all volumes were removed, so don't clean up the pod directory yet. It is likely\r\n// that there are still mountpoints or files left which could cause removal of the pod\r\n// directory to fail below.\r\n\r\n2. EmptyDir::TearDownAt was called indeeded, but the not-yet-exiting process of init containers created the empty-dir again and put some files under this dir.\r\n\r\n3. And then the empty-dir and its sub-dirs are left undeleted with following logs, and the disk will be filled up eventually:\r\n`Jul 31 19:17:59 10.0.0.10 kubelet[31029]: E0731 19:17:59.243274 31029 kubelet_volumes.go:225] orphaned pod \"1572a192-3951-4853-93ee-46d0f19cc75d\" found, but failed to rmdir() volume at path /var/lib/kubelet/pods/1572a192-3951-4853-93ee-46d0f19cc75d/volumes/kubernetes.io~empty-dir/flink-connector-lib: directory not empty : There were a total of 142 errors similar to this. Turn up verbosity to see them.`", "created_at": "2023-08-08 02:00:33" }, { "body": "> EmptyDir::TearDownAt was called indeeded, but the not-yet-exiting process of init containers created the empty-dir again and put some files under this dir.\r\n\r\nCould it be that TearDown is called earlier than needed, i.e. when container process still uses the directory? If this is the case, it should probably be called when all processes are finished.\r\n\r\nIn any case this should be covered by e2e tests. Please, add.", "created_at": "2023-08-08 11:17:36" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:20:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:20:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:20:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:20:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:20:47", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:20:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:20:47", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:20:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:20:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:20:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:20:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:20:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:20:49", "type": "unlabeled" }, { "author": "borgerli", "created_at": "2023-08-07 08:20:50", "type": "mentioned" }, { "author": "borgerli", "created_at": "2023-08-07 08:20:50", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 08:20:50", "type": "labeled" }, { "author": "iholder101", "created_at": "2023-08-08 02:00:34", "type": "mentioned" }, { "author": "iholder101", "created_at": "2023-08-08 02:00:34", "type": "subscribed" } ]