Datasets:

aqubed

/

kub_tickets_small

like 1

Follow

Aqubed AI (ACubed AI) 2

[]

[ "kind/bug", "kind/support", "sig/node", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-31 13:27:42" }, { "body": "1.19 is end of life , so it should not receive patches, you have to update to a supported version\r\n\r\n/kind support \r\n/sig node ", "created_at": "2023-07-31 22:04:56" }, { "body": "> I just want to know why this is happening, can you explain it from the code level?\r\n", "created_at": "2023-08-01 00:57:58" }, { "body": "> > I just want to know why this is happening, can you explain it from the code level?\r\n\r\nI find which code in k8s Third-party library reference ：github.com/google/cadvistor/container/common/fsHandle.go\r\nfunc (fh *realFsHandler) update() error {\r\n\tvar (\r\n\t\trootUsage, extraUsage fs.UsageInfo\r\n\t\trootErr, extraErr error\r\n\t)\r\n\t// TODO(vishh): Add support for external mounts.\r\n\tif fh.rootfs != \"\" {\r\n\t\trootUsage, rootErr = fh.fsInfo.GetDirUsage(fh.rootfs)\r\n\t}\r\n\r\n\tif fh.extraDir != \"\" {\r\n\t\textraUsage, extraErr = fh.fsInfo.GetDirUsage(fh.extraDir)\r\n\t}\r\n\r\n\t// Wait to handle errors until after all operartions are run.\r\n\t// An error in one will not cause an early return, skipping others\r\n\tfh.Lock()\r\n\tdefer fh.Unlock()\r\n\tfh.lastUpdate = time.Now()\r\n\tif fh.rootfs != \"\" && rootErr == nil {\r\n\t\tfh.usage.InodeUsage = rootUsage.Inodes\r\n\t\tfh.usage.BaseUsageBytes = rootUsage.Bytes\r\n\t\tfh.usage.TotalUsageBytes = rootUsage.Bytes\r\n\t}\r\n\tif fh.extraDir != \"\" && extraErr == nil {\r\n\t\t**fh.usage.TotalUsageBytes += extraUsage.Bytes**//this is error postion\r\n\t}\r\n\r\n\t// Combine errors into a single error to return\r\n\tif rootErr != nil || extraErr != nil {\r\n\t\treturn fmt.Errorf(\"rootDiskErr: %v, extraDiskErr: %v\", rootErr, extraErr)\r\n\t}\r\n\treturn nil\r\n}\r\n\r\n\r\n\r\n", "created_at": "2023-08-08 12:35:58" }, { "body": "Not sure if there's any further investigation we can do, as it was fixed in 1.25.\r\n\r\n/close", "created_at": "2023-08-09 17:41:13" }, { "body": "@mmiranda96: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119691#issuecomment-1671870496):\n\n>Not sure if there's any further investigation we can do, as it was fixed in 1.25.\r\n>\r\n>/close\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 17:41:19" } ]

[ { "author": "kunkunhaohao", "created_at": "2023-07-31 13:27:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 13:27:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 13:27:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 22:04:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 22:04:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 22:04:59", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 17:41:18", "type": "closed" }, { "author": "mmiranda96", "created_at": "2023-08-09 17:41:21", "type": "mentioned" }, { "author": "mmiranda96", "created_at": "2023-08-09 17:41:21", "type": "subscribed" } ]

[ "smarterclayton" ]

[ "kind/cleanup", "sig/api-machinery", "size/M", "release-note-none", "sig/auth", "needs-ok-to-test", "needs-priority", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Jul 31 10:15:47 UTC 2023.\n", "created_at": "2023-07-31 12:54:18" }, { "body": "Hi @Ellioben. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-31 12:54:23" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119690#\" title=\"Author self-approved\">Ellioben</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [deads2k](https://github.com/deads2k) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/client-go/tools/cache/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/cache/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"deads2k\"]} -->", "created_at": "2023-07-31 12:54:43" }, { "body": "/release-note-none", "created_at": "2023-07-31 17:12:53" }, { "body": "/sig auth", "created_at": "2023-08-01 05:04:04" }, { "body": "@Ellioben: You must be a member of the [kubernetes/milestone-maintainers](https://github.com/orgs/kubernetes/teams/milestone-maintainers/members) GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119690#issuecomment-1659574234):\n\n>/milestone v1.28\r\n>/triage accepted\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-01 05:06:22" }, { "body": "@Ellioben: The label `triage/accepted` cannot be applied. Only GitHub organization members can add the label.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119690#issuecomment-1659574234):\n\n>/milestone v1.28\r\n>/triage accepted\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-01 05:06:29" }, { "body": "/assign @smarterclayton\r\nCould you take a look? Thank you.\r\n/triage accepted", "created_at": "2023-08-03 16:37:13" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:54:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:54:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:54:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:54:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:54:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:54:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:54:23", "type": "labeled" }, { "author": "Ellioben", "created_at": "2023-07-31 12:54:24", "type": "mentioned" }, { "author": "Ellioben", "created_at": "2023-07-31 12:54:24", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:54:53", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:54:53", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:55:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:55:07", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 17:13:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 17:13:01", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 05:04:06", "type": "labeled" }, { "author": "Ellioben", "created_at": "2023-08-01 05:06:23", "type": "mentioned" }, { "author": "Ellioben", "created_at": "2023-08-01 05:06:23", "type": "subscribed" }, { "author": "Ellioben", "created_at": "2023-08-01 05:06:29", "type": "mentioned" }, { "author": "Ellioben", "created_at": "2023-08-01 05:06:29", "type": "subscribed" }, { "author": "smarterclayton", "created_at": "2023-08-03 16:37:13", "type": "mentioned" }, { "author": "smarterclayton", "created_at": "2023-08-03 16:37:14", "type": "subscribed" }, { "author": "smarterclayton", "created_at": "2023-08-03 16:37:14", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:37:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:37:16", "type": "unlabeled" }, { "author": "Ellioben", "created_at": "2023-08-15 12:31:32", "type": "closed" } ]

[]

[ "kind/cleanup", "sig/api-machinery", "size/M", "needs-ok-to-test", "do-not-merge/release-note-label-needed", "needs-priority", "do-not-merge/contains-merge-commits", "triage/accepted" ]

[ { "body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-31 12:06:36" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Jul 31 10:15:47 UTC 2023.\n", "created_at": "2023-07-31 12:06:37" }, { "body": "Welcome @Ellioben! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:", "created_at": "2023-07-31 12:06:42" }, { "body": "Hi @Ellioben. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-31 12:06:43" }, { "body": "Adding label `do-not-merge/contains-merge-commits` because PR contains merge commits, which are not allowed in this repository.\nUse `git rebase` to reapply your commits on top of the target branch. Detailed instructions for doing so can be found [here](https://git.k8s.io/community/contributors/guide/github-workflow.md#4-keep-your-branch-in-sync).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-31 12:06:53" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119689#\" title=\"Author self-approved\">Ellioben</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [thockin](https://github.com/thockin) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/client-go/tools/cache/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/cache/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"thockin\"]} -->", "created_at": "2023-07-31 12:07:33" }, { "body": "/triage accepted", "created_at": "2023-08-08 20:13:00" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:06:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:06:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:06:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:06:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:06:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:06:42", "type": "labeled" }, { "author": "Ellioben", "created_at": "2023-07-31 12:06:42", "type": "mentioned" }, { "author": "Ellioben", "created_at": "2023-07-31 12:06:42", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:06:43", "type": "labeled" }, { "author": "Ellioben", "created_at": "2023-07-31 12:06:43", "type": "mentioned" }, { "author": "Ellioben", "created_at": "2023-07-31 12:06:43", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:06:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:07:08", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:07:08", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:07:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 12:07:22", "type": "unlabeled" }, { "author": "Ellioben", "created_at": "2023-07-31 12:42:23", "type": "closed" }, { "author": "Ellioben", "created_at": "2023-07-31 12:42:23", "type": "head_ref_deleted" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:13:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:13:04", "type": "unlabeled" } ]

[ "bobbypage", "SergeyKanzhelev" ]

[ "kind/bug", "priority/important-soon", "area/kubelet", "sig/node", "release-note", "size/M", "ok-to-test", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Jul 31 10:15:47 UTC 2023.\n", "created_at": "2023-07-31 11:29:15" }, { "body": "Hi @chenk008. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-31 11:29:21" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119688#\" title=\"Author self-approved\">chenk008</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [dchen1107](https://github.com/dchen1107) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"dchen1107\"]} -->", "created_at": "2023-07-31 11:29:55" }, { "body": "This change can also help to mitigate issues in https://github.com/kubernetes/kubernetes/issues/117972", "created_at": "2023-08-02 08:38:37" }, { "body": "/ok-to-test\r\n/triage accepted\r\n/priority important-soon\r\n/assign @bobbypage @SergeyKanzhelev \r\n/cc", "created_at": "2023-08-02 13:51:10" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:29:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:29:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:29:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:29:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:29:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:29:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:29:21", "type": "labeled" }, { "author": "chenk008", "created_at": "2023-07-31 11:29:21", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 11:29:22", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:29:43", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:29:43", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:30:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:30:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:30:10", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:49:02", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:49:03", "type": "labeled" }, { "author": "chenk008", "created_at": "2023-07-31 11:59:02", "type": "head_ref_force_pushed" }, { "author": "bobbypage", "created_at": "2023-08-02 13:51:10", "type": "mentioned" }, { "author": "bobbypage", "created_at": "2023-08-02 13:51:10", "type": "subscribed" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-02 13:51:10", "type": "mentioned" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-02 13:51:11", "type": "subscribed" }, { "author": "bobbypage", "created_at": "2023-08-02 13:51:12", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 13:51:12", "type": "labeled" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-02 13:51:12", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 13:51:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 13:51:13", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 13:51:13", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 13:51:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 13:51:15", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 13:51:16", "type": "unlabeled" } ]

[]

[ "kind/bug", "area/kubectl", "size/S", "release-note-action-required", "sig/cli", "needs-ok-to-test", "needs-priority", "kind/deprecation", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Jul 31 10:15:47 UTC 2023.\n", "created_at": "2023-07-31 10:59:35" }, { "body": "Welcome @Affan-7! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:", "created_at": "2023-07-31 10:59:40" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-31 10:59:40" }, { "body": "Hi @Affan-7. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-31 10:59:40" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119687#\" title=\"Author self-approved\">Affan-7</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [brianpursley](https://github.com/brianpursley) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"brianpursley\"]} -->", "created_at": "2023-07-31 11:00:26" }, { "body": "/auto-cc", "created_at": "2023-08-02 12:07:25" }, { "body": "/cc pacoxu", "created_at": "2023-08-15 08:36:03" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:59:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:59:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:59:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:59:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:59:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:59:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:59:40", "type": "labeled" }, { "author": "Affan-7", "created_at": "2023-07-31 10:59:40", "type": "mentioned" }, { "author": "Affan-7", "created_at": "2023-07-31 10:59:40", "type": "subscribed" }, { "author": "Affan-7", "created_at": "2023-07-31 10:59:41", "type": "mentioned" }, { "author": "Affan-7", "created_at": "2023-07-31 10:59:41", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:59:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:00:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:00:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:00:05", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:00:15", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:00:15", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:12:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:12:34", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 12:07:35", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 08:36:04", "type": "review_requested" } ]

[]

[ "kind/cleanup", "sig/scheduling", "sig/storage", "size/M", "release-note-none", "cncf-cla: yes", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Jul 31 10:15:47 UTC 2023.\n", "created_at": "2023-07-31 10:47:34" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-31 10:47:39" }, { "body": "/sig storage\r\n/sig scheduling", "created_at": "2023-07-31 10:47:54" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119686#\" title=\"Author self-approved\">carlory</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [kerthcet](https://github.com/kerthcet) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/scheduler/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"kerthcet\"]} -->", "created_at": "2023-07-31 10:48:14" }, { "body": "@carlory: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-node-e2e-containerd | 13e51ebd9ef68179a604d4696cd7cc0ad9a464e8 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119686/pull-kubernetes-node-e2e-containerd/1686655592803864576/) | true | `/test pull-kubernetes-node-e2e-containerd`\npull-kubernetes-unit | 13e51ebd9ef68179a604d4696cd7cc0ad9a464e8 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119686/pull-kubernetes-unit/1686655592728367104) | true | `/test pull-kubernetes-unit`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119686). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Acarlory). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-08-02 09:15:16" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:47:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:47:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:47:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:47:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:47:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:47:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:47:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:47:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:47:58", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:48:26", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:48:26", "type": "review_requested" }, { "author": "carlory", "created_at": "2023-07-31 10:51:26", "type": "head_ref_force_pushed" }, { "author": "carlory", "created_at": "2023-07-31 11:34:03", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-31 11:34:03", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-31 11:46:41", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-31 11:46:41", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-31 11:53:24", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-31 11:53:24", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-08-02 08:29:40", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 08:29:43", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 08:29:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 08:29:56", "type": "labeled" }, { "author": "carlory", "created_at": "2023-08-02 08:32:37", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-08-02 08:32:37", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-08-02 09:15:16", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-08-02 09:15:16", "type": "subscribed" } ]

[]

[ "kind/bug", "sig/storage", "sig/apps", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-31 07:30:17" }, { "body": "/sig/api-machinery", "created_at": "2023-07-31 08:08:16" }, { "body": "/sig apps\r\n/sig storage", "created_at": "2023-07-31 11:22:54" }, { "body": "Hi, Can someone suggest here?\r\nAs this is introduced in my setup after the v1.27 upgrade?\r\nIs there any change in partition logic?", "created_at": "2023-08-01 05:07:10" }, { "body": "This can be reproduced by using the said STS.\r\n\r\n1 - Deploy STS using attached sts.yaml that has a replica count is 2 and updatingstrategy.rolling.partition as 1.\r\n2 - Do edit STS and update the image to 1.15. This will upgrade, pod-1 with image 1.15.\r\n3 - Next delete the pod pod-0 and check that POD-0 came up with a new image which is not the expected behavior. \r\nPOD 0 should not be updated to a new image until the partition is changed to 0.\r\n\r\nWe have noticed this behavior change in v1.27.\r\n\r\nPla suggest\r\n \r\nSTS.yaml :\r\n---\r\napiVersion: v1\r\nkind: Service\r\nmetadata:\r\n name: nginx\r\n labels:\r\n app: nginx\r\nspec:\r\n ports:\r\n - port: 80\r\n name: web\r\n clusterIP: None\r\n selector:\r\n app: nginx\r\n---\r\napiVersion: apps/v1\r\nkind: StatefulSet\r\nmetadata:\r\n name: web-am\r\nspec:\r\n updateStrategy:\r\n type: RollingUpdate\r\n rollingUpdate:\r\n partition: 1\r\n serviceName: \"nginx\"\r\n replicas: 2\r\n selector:\r\n matchLabels:\r\n app: nginx\r\n template:\r\n metadata:\r\n labels:\r\n app: nginx\r\n spec:\r\n containers:\r\n - name: nginx\r\n args:\r\n - /bin/sh\r\n - -c\r\n - sleep 30;touch /tmp/healthy; sleep 3600\r\n image: nginx:1.14.2\r\n ports:\r\n - containerPort: 80\r\n name: web\r\n ", "created_at": "2023-08-02 06:08:36" } ]

[ { "author": "akki-9922", "created_at": "2023-07-31 07:30:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 07:30:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 07:30:16", "type": "labeled" }, { "author": "akki-9922", "created_at": "2023-07-31 07:30:28", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:22:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:22:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:22:57", "type": "unlabeled" } ]

[ "liangyuanpeng" ]

[ "kind/bug", "sig/apps", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-31 06:14:19" }, { "body": "/SIG Apps", "created_at": "2023-07-31 06:31:09" }, { "body": "kind/bug", "created_at": "2023-07-31 07:43:26" }, { "body": "Some steps to reproduce it would be great.", "created_at": "2023-08-01 02:23:11" }, { "body": "\r\n[sts.zip](https://github.com/kubernetes/kubernetes/files/12228543/sts.zip)\r\n-- Sample yaml attached.\r\n\r\n1 - Deploy STS using attached yaml where replica count is 2 and updatingstrategy.rolling.partition as 1.\r\n\r\n2 - Edit STS and update the image to 1.15. At this stage pod-1 will be updated with image 1.15.\r\n\r\n3 - Now delete the pod pod-0 and check the image tag for POD-0 came up with new image which is not expected [behavio]\r\n", "created_at": "2023-08-01 11:29:54" }, { "body": "/sig apps\r\n/kind bug", "created_at": "2023-08-01 16:15:23" }, { "body": "Any work around for this issue? ", "created_at": "2023-08-01 20:09:15" }, { "body": "> 3 - Now delete the pod pod-0 and check the image tag for POD-0 came up with new image which is not expected [behavio]\r\n\r\nwhat do you mean by \"POD-0 came up with new image\" , the Pod-0 has to have image 1.15 that is the one you have updated to", "created_at": "2023-08-01 20:16:33" }, { "body": "Yes, it is has new image 1.15.\r\nBut I have only updated the image for pod-1 using partition 1 in statefulset.\r\n", "created_at": "2023-08-01 20:22:44" }, { "body": "I'm interested in this, let me check it out.\r\n\r\n/assign", "created_at": "2023-08-02 07:02:03" }, { "body": "HI liangyuanpeng,\r\nAny update, \r\nDo you have any work around for this issue.", "created_at": "2023-08-02 17:30:54" }, { "body": "oh, I missed that part, indeed sounds like a bug and we should have an e2e test verifying that behavior, it seems a simple e2e test to add, @liangyuanpeng please add the e2e test reproducing the issue if you are going to work on this\r\n\r\n/cc @soltysh \r\n\r\n\r\nhttps://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#rolling-updates\r\n\r\n\r\n> Partitioned rolling updates\r\n> The RollingUpdate update strategy can be partitioned, by specifying a .spec.updateStrategy.rollingUpdate.partition. If a partition is specified, all Pods with an ordinal that is greater than or equal to the partition will be updated when the StatefulSet's .spec.template is updated. All Pods with an ordinal that is less than the partition will not be updated, and, even if they are deleted, they will be recreated at the previous version.\r\n> \r\n\r\n", "created_at": "2023-08-03 14:20:24" }, { "body": "Hi @liangyuanpeng,\r\nNeed 1 info for your code changes, with respect to actual problem for my application upgrade.\r\nI have attached the nginx helm chart according to my application and steps to reproduce the issue.\r\nCan you please check and share, why it is working till v1.26.1 and also will it be solved, after your code change.\r\n\r\n[nginx.tar.gz](https://github.com/kubernetes/kubernetes/files/12315653/nginx.tar.gz)\r\n[fallback issue step.txt](https://github.com/kubernetes/kubernetes/files/12315654/fallback.issue.step.txt)\r\n\r\n\r\n\r\n", "created_at": "2023-08-10 17:26:20" }, { "body": "@ankushhifi007 \r\nIn my test, this problem exists in 1.27.x, and I packaged a patch version, maybe it's worth your try. \r\n\r\nghcr.io/liangyuanpeng/kube-controller-manager-amd64:v1.27-patch\r\n\r\nI will try to test again with your files.", "created_at": "2023-08-11 10:12:53" }, { "body": "@liangyuanpeng \r\nAny further findings with my steps and also any possible workaround for me.\r\n\r\n", "created_at": "2023-08-16 03:58:30" }, { "body": "@liangyuanpeng\r\nAny further findings with my steps.", "created_at": "2023-08-17 04:05:56" }, { "body": "@aleksandra-malinowska Can https://github.com/kubernetes/kubernetes/pull/119096 this be potential cause for this issue which is seen only in 1.27.1 but not in 1.26.", "created_at": "2023-08-17 05:36:07" }, { "body": "\r\n\r\n@liangyuanpeng,\r\nI have tested your patch, pod image change issue is fixed during pod restart,\r\n\r\nBut now upgrade procedure is breaking. \r\nI have tested my scenario where stateful set having 2 replicas.\r\nI started upgrade from pod with ordinal number 1, that is working fine.\r\nBut image is not updating while doing the upgrade of pod with ordinal number zero.\r\n\r\nsame upgrade procedure is working with v1.27.0 but after applying the patch it is not working.\r\n\r\n\r\n\r\n\r\n", "created_at": "2023-08-18 11:09:31" }, { "body": "@liangyuanpeng,\r\n1 additional point.\r\nThis behaviour is only with helm upgrade. while upgrading with editing stateful set, it is working fine.\r\n\r\n\r\n\r\n", "created_at": "2023-08-19 08:37:10" }, { "body": "Maybe it is as designed, other replicas will keep old version utill the first upgraded one finished upgring.", "created_at": "2023-08-20 04:10:53" }, { "body": "> Maybe it is as designed, other replicas will keep old version utill the first upgraded one finished upgring.\r\n\r\nYes you are right other replicas keeping the older version till first one is upgraded, but when I am upgrading other pod after \r\nfinish of first pod, it should come up with new image, but with @liangyuanpeng patch helm upgrade with partition 0 is not updating new image in pod-0.", "created_at": "2023-08-20 13:16:15" }, { "body": "> with partition 0 is not updating new image in pod-0\r\n\r\nI think you can check the real partition value in yaml. k8s will update pod with index from `replicas-1` to `partition` if partition is set.\r\n\r\nhttps://github.com/kubernetes/kubernetes/blob/29792427435ecffa0cee3f36da9c3a96db1b1278/pkg/controller/statefulset/stateful_set_control.go#L682-L711", "created_at": "2023-08-21 01:20:52" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-31 06:14:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 06:14:18", "type": "labeled" }, { "author": "ankushhifi007", "created_at": "2023-07-31 06:41:42", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 16:15:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 16:15:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 16:15:26", "type": "unlabeled" }, { "author": "liangyuanpeng", "created_at": "2023-08-02 07:02:05", "type": "assigned" }, { "author": "soltysh", "created_at": "2023-08-03 14:20:25", "type": "mentioned" }, { "author": "soltysh", "created_at": "2023-08-03 14:20:25", "type": "subscribed" }, { "author": "liangyuanpeng", "created_at": "2023-08-03 14:20:25", "type": "mentioned" }, { "author": "liangyuanpeng", "created_at": "2023-08-03 14:20:25", "type": "subscribed" }, { "author": "liangyuanpeng", "created_at": "2023-08-10 17:26:21", "type": "mentioned" }, { "author": "liangyuanpeng", "created_at": "2023-08-10 17:26:21", "type": "subscribed" }, { "author": "ankushhifi007", "created_at": "2023-08-11 10:12:54", "type": "mentioned" }, { "author": "ankushhifi007", "created_at": "2023-08-11 10:12:54", "type": "subscribed" }, { "author": "liangyuanpeng", "created_at": "2023-08-16 03:58:30", "type": "mentioned" }, { "author": "liangyuanpeng", "created_at": "2023-08-16 03:58:30", "type": "subscribed" }, { "author": "liangyuanpeng", "created_at": "2023-08-17 04:05:56", "type": "mentioned" }, { "author": "liangyuanpeng", "created_at": "2023-08-17 04:05:56", "type": "subscribed" }, { "author": "aleksandra-malinowska", "created_at": "2023-08-17 05:36:07", "type": "mentioned" }, { "author": "aleksandra-malinowska", "created_at": "2023-08-17 05:36:07", "type": "subscribed" }, { "author": "liangyuanpeng", "created_at": "2023-08-18 11:09:32", "type": "mentioned" }, { "author": "liangyuanpeng", "created_at": "2023-08-18 11:09:32", "type": "subscribed" }, { "author": "liangyuanpeng", "created_at": "2023-08-19 08:37:11", "type": "mentioned" }, { "author": "liangyuanpeng", "created_at": "2023-08-19 08:37:11", "type": "subscribed" }, { "author": "liangyuanpeng", "created_at": "2023-08-20 13:16:15", "type": "mentioned" }, { "author": "liangyuanpeng", "created_at": "2023-08-20 13:16:15", "type": "subscribed" } ]

[ "tzneal", "SergeyKanzhelev", "upodroid" ]

[ "kind/bug", "area/test", "lgtm", "sig/node", "size/XS", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Jul 30 16:14:21 UTC 2023.\n", "created_at": "2023-07-30 21:14:43" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-30 21:14:47" }, { "body": "/sig node\r\n/assign @tzneal @upodroid @SergeyKanzhelev ", "created_at": "2023-07-30 21:15:21" }, { "body": "/retest", "created_at": "2023-07-30 23:44:38" }, { "body": "/retest", "created_at": "2023-07-31 00:34:36" }, { "body": "LGTM label has been added. <details>Git tree hash: d6bda4ce4ba2611f950e22fa2ee970572ce11eed</details>", "created_at": "2023-07-31 08:30:14" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119682#\" title=\"Author self-approved\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119682#pullrequestreview-1554225966\" title=\"LGTM\">upodroid</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e_node/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/OWNERS)~~ [dims]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-07-31 08:30:31" }, { "body": "This is interesting. Can we investigate the reason of executive bit is not set? Could it be that tar is not run with `-p` option?", "created_at": "2023-07-31 10:10:45" }, { "body": "@bart0sh you can simulate the build of the tar with the following from the root directory:\r\n\r\n```\r\ngo run test/e2e_node/runner/remote/run_remote.go --build-only \r\n```\r\n\r\nyou will end up with `e2e_node_test.tar.gz` in the same directory", "created_at": "2023-07-31 11:27:24" }, { "body": "Thanks. I can see that ginkgo has an executable bit in the tar archive. So the issue is not caused by the way of running tar, but may be by the place (tmp subdir) or by the way it's unpacked on the target instance. \r\nAny ideas how to reproduce this? I have an access to a gcloud project, but I don't know how to run this test there.\r\n", "created_at": "2023-07-31 11:38:59" }, { "body": "@dims I'm able to ssh to the instance now. Here is what I found out so far:\r\n- Execution bit on ginkgo and other binaries is set:\r\n```\r\ned@tmp-node-e2e-d4ce4b12-cos-97-16919-29-21 ~ $ ls -la /tmp/node-e2e-20230801T135528\r\ntotal 345028\r\ndrwx------ 4 ed ed 220 Aug 1 10:56 .\r\ndrwxrwxrwt 13 root root 280 Aug 1 11:06 ..\r\ndrwxr-xr-x 4 root root 80 Aug 1 10:55 cni\r\n-rw-r--r-- 1 root root 297 Aug 1 10:56 credential-provider.yaml\r\n-rwxr-xr-x 1 ed ed 144302752 Aug 1 10:54 e2e_node.test\r\n-rw-r--r-- 1 ed ed 77114433 Aug 1 10:55 e2e_node_test.tar.gz\r\n-rwxr-xr-x 1 ed ed 9543680 Aug 1 10:54 gcp-credential-provider\r\n-rwxr-xr-x 1 ed ed 9973760 Aug 1 10:54 ginkgo\r\n-rwxr-xr-x 1 ed ed 110821376 Aug 1 10:54 kubelet\r\n-rwxr-xr-x 1 ed ed 1544192 Aug 1 10:54 mounter\r\ndrwxr-xr-x 2 ed ed 60 Aug 1 10:56 results\r\n```\r\n- The problem could be with a directory permissions:\r\n```\r\ned@tmp-node-e2e-d4ce4b12-cos-97-16919-29-21 ~ $ ls -la /tmp/ |grep node-e2e\r\ndrwx------ 4 ed ed 220 Aug 1 10:56 node-e2e-20230801T135528\r\n```\r\n- Or, better, with the fact that /tmp is mounted with `noexec`\r\n```\r\ned@tmp-node-e2e-d4ce4b12-cos-97-16919-29-21 ~ $ mount |grep 'on /tmp'\r\ntmpfs on /tmp type tmpfs (rw,nosuid,nodev,noexec)\r\n```\r\n- As a result no binaries can be run from any directory in /tmp:\r\n```\r\ned@tmp-node-e2e-d4ce4b12-cos-97-16919-29-21 /tmp/node-e2e-20230801T135528 $ ./ginkgo\r\n-bash: ./ginkgo: Permission denied\r\ned@tmp-node-e2e-d4ce4b12-cos-97-16919-29-21 /tmp/node-e2e-20230801T135528 $ ./e2e_node.test\r\n-bash: ./e2e_node.test: Permission denied\r\n```\r\n- remounting /tmp discovers another issue (old GLIBC?):\r\n```\r\ned@tmp-node-e2e-d4ce4b12-cos-97-16919-29-21 /tmp/node-e2e-20230801T135528 $ sudo mount -o remount,exec /tmp/\r\ned@tmp-node-e2e-d4ce4b12-cos-97-16919-29-21 /tmp/node-e2e-20230801T135528 $ ./ginkgo \r\n./ginkgo: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by ./ginkgo)\r\n```", "created_at": "2023-08-01 11:34:22" }, { "body": "@bart0sh thanks for digging in! So looks like:\r\n\r\n- we need to remount /tmp `sudo mount -o remount,exec /tmp/`\r\n- we need to compile ginkgo using `CGO_ENABLED=0`", "created_at": "2023-08-01 13:33:03" }, { "body": "@bart0sh do you want to create a `pull` job out of `ci-kubernetes-e2e-node-canary` and work on a patch?\r\n\r\ncc @SergeyKanzhelev as this is a `cos-97-16919-29-21` issue", "created_at": "2023-08-01 13:37:04" }, { "body": "@dims \r\n> we need to remount /tmp sudo mount -o remount,exec /tmp/\r\n\r\nI'd say we need to stop using `--images=cos-97-16919-29-21` and use `--image-config-file` with a proper image config instead. This would guarantee [remounting /tmp](https://github.com/kubernetes/test-infra/blob/master/jobs/e2e_node/containerd/init.yaml#L5).\r\n\r\n> we need to compile ginkgo using CGO_ENABLED=0\r\n\r\nNot just ginkgo, but all the binaries used in e2e node, which is quite a bit of work.\r\nHowever, it may not be needed as `version GLIBC_2.34 not found` error was caused by my build environment (Ubuntu 22.04). prow hosts most probably use something with an older Glibc.\r\n", "created_at": "2023-08-01 14:39:08" }, { "body": "> @bart0sh do you want to create a `pull` job out of `ci-kubernetes-e2e-node-canary` and work on a patch?\r\n\r\nI don't know a history of this job. From the brief look it runs NodeConformance tests excluding serial and flaky ones and belongs to sig-testing. There are other jobs that run NodeConformance tests, I believe. We may need to ask sig-testing folks and @SergeyKanzhelev.", "created_at": "2023-08-01 14:48:50" }, { "body": "@dims I probably misunderstood you. I can quickly come up with a patch to fix remounting issue. It will not fix the job, but we'll see much more output in the logs. \r\nRunning it in my environment passes quite a bit of test cases:\r\n```\r\nRan 96 of 544 Specs in 3601.384 seconds\r\nFAIL! - Suite Timeout Elapsed -- 86 Passed | 10 Failed | 0 Pending | 448 Skipped\r\n--- FAIL: TestE2eNode (3601.42s)\r\nFAIL\r\n\r\nGinkgo ran 1 suite in 1h0m1.539346361s\r\n\r\n```", "created_at": "2023-08-01 17:07:44" }, { "body": "@bart0sh go for it! (PR for patch to fix remounting issue) thanks!", "created_at": "2023-08-01 17:37:42" }, { "body": "@dims done: https://github.com/kubernetes/test-infra/pull/30265", "created_at": "2023-08-01 19:23:00" }, { "body": "Closing as setting executable bit wouldn't help to run ginkgo.\r\n/close", "created_at": "2023-08-01 19:24:19" }, { "body": "@bart0sh: Closed this PR.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119682#issuecomment-1660946131):\n\n>Closing as setting executable bit wouldn't help to run ginkgo.\r\n>/close\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-01 19:24:24" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-30 21:14:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 21:14:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 21:14:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 21:14:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 21:14:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 21:14:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 21:14:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 21:15:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 21:15:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 21:15:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 21:15:14", "type": "unlabeled" }, { "author": "tzneal", "created_at": "2023-07-30 21:15:21", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-07-30 21:15:21", "type": "subscribed" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-30 21:15:21", "type": "mentioned" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-30 21:15:21", "type": "subscribed" }, { "author": "upodroid", "created_at": "2023-07-30 21:15:21", "type": "mentioned" }, { "author": "upodroid", "created_at": "2023-07-30 21:15:21", "type": "subscribed" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-30 21:15:22", "type": "assigned" }, { "author": "tzneal", "created_at": "2023-07-30 21:15:22", "type": "assigned" }, { "author": "upodroid", "created_at": "2023-07-30 21:15:23", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 21:15:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 21:15:37", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 21:15:37", "type": "review_requested" }, { "author": "dims", "created_at": "2023-07-30 21:46:05", "type": "mentioned" }, { "author": "dims", "created_at": "2023-07-30 21:46:05", "type": "subscribed" }, { "author": "dims", "created_at": "2023-07-30 21:51:22", "type": "mentioned" }, { "author": "dims", "created_at": "2023-07-30 21:51:22", "type": "subscribed" }, { "author": "dims", "created_at": "2023-07-31 00:17:47", "type": "mentioned" }, { "author": "dims", "created_at": "2023-07-31 00:17:47", "type": "subscribed" }, { "author": "dims", "created_at": "2023-07-31 01:03:54", "type": "mentioned" }, { "author": "dims", "created_at": "2023-07-31 01:03:54", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 08:30:13", "type": "labeled" }, { "author": "bart0sh", "created_at": "2023-07-31 11:27:24", "type": "mentioned" }, { "author": "bart0sh", "created_at": "2023-07-31 11:27:24", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-01 11:34:22", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-01 11:34:22", "type": "subscribed" }, { "author": "bart0sh", "created_at": "2023-08-01 13:33:03", "type": "mentioned" }, { "author": "bart0sh", "created_at": "2023-08-01 13:33:03", "type": "subscribed" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-01 13:37:05", "type": "mentioned" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-01 13:37:05", "type": "subscribed" }, { "author": "bart0sh", "created_at": "2023-08-01 13:37:05", "type": "mentioned" }, { "author": "bart0sh", "created_at": "2023-08-01 13:37:05", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-01 14:39:09", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-01 14:39:09", "type": "subscribed" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-01 14:48:50", "type": "mentioned" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-01 14:48:50", "type": "subscribed" }, { "author": "bart0sh", "created_at": "2023-08-01 14:48:51", "type": "mentioned" }, { "author": "bart0sh", "created_at": "2023-08-01 14:48:51", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-01 17:07:45", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-01 17:07:45", "type": "subscribed" }, { "author": "bart0sh", "created_at": "2023-08-01 17:37:43", "type": "mentioned" }, { "author": "bart0sh", "created_at": "2023-08-01 17:37:43", "type": "subscribed" }, { "author": "dims", "created_at": "2023-08-01 19:23:00", "type": "mentioned" }, { "author": "dims", "created_at": "2023-08-01 19:23:00", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 19:24:23", "type": "closed" }, { "author": "bart0sh", "created_at": "2023-08-01 19:24:25", "type": "mentioned" }, { "author": "bart0sh", "created_at": "2023-08-01 19:24:25", "type": "subscribed" } ]

[]

[ "kind/failing-test", "needs-sig", "needs-triage" ]

[ { "body": "There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:\n- `/sig <group-name>`\n- `/wg <group-name>`\n- `/committee <group-name>`\n\nPlease see the [group list](https://git.k8s.io/community/sig-list.md) for a listing of the SIGs, working groups, and committees available.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-30 20:56:01" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-30 20:56:02" }, { "body": "failing with the following:\r\n```\r\nE0730 06:17:41.852457 8980 ssh.go:149] failed to run SSH command: out: timeout: failed to run command './ginkgo': Permission denied\r\n```\r\n\r\nfor example, see this [log](https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-e2e-node-canary/1685532509695119360/build-log.txt)", "created_at": "2023-07-30 21:01:19" }, { "body": "> sudo /bin/bash -c 'cd /tmp/node-e2e-20230730T061731 && set -o pipefail; timeout -k 30s 5400.000000s ./ginkgo --nodes=8 --focus=\"\\[NodeConformance\\]\" --skip=\"\\[Flaky\\]|\\[Serial\\]\" --no-color -v ./e2e_node.test -- --system-spec-name= --system-spec-file= --extra-envs= --runtime-config= --v 4 --node-name=tmp-node-e2e-e69587ec-cos-97-16919-29-21 --report-dir=/tmp/node-e2e-20230730T061731/results --report-prefix=cos-97-16919-29-21 --image-description=\"\" --kubelet-flags=--feature-\r\n\r\nis a problem of chmod or that the `tmp` folder does not allow executables? \r\n\r\nwhy it was not failing before?", "created_at": "2023-07-30 21:36:31" }, { "body": "It started failing from a long time ago: https://prow.k8s.io/job-history/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-node-canary?buildId=1653360877933432832.\r\n\r\nAccording to https://github.com/kubernetes/test-infra/pull/26093, \r\n> It has been failing for 272 days: https://storage.cloud.google.com/k8s-metrics/failures-latest.json - so I'm not sure anyone is looking at this test. Let me know if it should be removed instead.\r\n", "created_at": "2023-07-31 02:19:20" }, { "body": "If this would happen in `/tmp` I'd say it's because of a chown (sudo) and a sticky bit. However, it happens in the subdirectory of `/tmp`. It would be better to investigate it further.\r\nCan anyone explain how to run this test on google cloud to reproduce the issue?", "created_at": "2023-07-31 10:46:16" }, { "body": "Investigated. See my findings in [this PR comment](https://github.com/kubernetes/kubernetes/pull/119682#issuecomment-1660133451)", "created_at": "2023-08-01 11:35:20" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:55:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:56:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:56:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 11:10:22", "type": "closed" } ]

[]

[ "kind/bug", "area/test", "area/kubectl", "release-note", "size/M", "sig/cli", "cncf-cla: yes", "sig/testing", "needs-ok-to-test", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Jul 30 16:14:21 UTC 2023.\n", "created_at": "2023-07-30 20:24:48" }, { "body": "<a href=\"https://easycla.lfx.linuxfoundation.org/#/?version=2\"><img src=\"https://s3.amazonaws.com/cla-project-logo-prod/cla-signed.svg\" alt=\"CLA Signed\" align=\"left\" height=\"28\" width=\"328\" ></a><br/><br />The committers listed above are authorized under a signed CLA.<ul><li>:white_check_mark: login: Bhargav-InfraCloud / name: Bhargav Ravuri (6b1cef2269111ec4c5534b6da434ef0cf0f5847d)</li></ul>", "created_at": "2023-07-30 20:24:51" }, { "body": "Welcome @Bhargav-InfraCloud! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:", "created_at": "2023-07-30 20:24:52" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-30 20:24:53" }, { "body": "Hi @Bhargav-InfraCloud. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-30 20:24:53" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119680#\" title=\"Author self-approved\">Bhargav-InfraCloud</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [soltysh](https://github.com/soltysh) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/hack/OWNERS)**\n- **[staging/src/k8s.io/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/OWNERS)**\n- **[test/cmd/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/cmd/OWNERS)**\n- **[test/e2e/instrumentation/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/instrumentation/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"soltysh\"]} -->", "created_at": "2023-07-30 20:25:36" }, { "body": "/remove-sig instrumentation", "created_at": "2023-08-03 14:32:21" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:24:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:24:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:24:47", "type": "labeled" }, { "author": "Bhargav-InfraCloud", "created_at": "2023-07-30 20:24:51", "type": "mentioned" }, { "author": "Bhargav-InfraCloud", "created_at": "2023-07-30 20:24:51", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:24:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:24:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:24:53", "type": "labeled" }, { "author": "Bhargav-InfraCloud", "created_at": "2023-07-30 20:24:53", "type": "mentioned" }, { "author": "Bhargav-InfraCloud", "created_at": "2023-07-30 20:24:53", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:24:53", "type": "labeled" }, { "author": "Bhargav-InfraCloud", "created_at": "2023-07-30 20:24:54", "type": "mentioned" }, { "author": "Bhargav-InfraCloud", "created_at": "2023-07-30 20:24:54", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:24:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:25:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:25:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:25:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:25:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:25:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:25:25", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:25:49", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:25:50", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:36:32", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 20:36:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 14:32:23", "type": "unlabeled" } ]

[ "aojea" ]

[ "sig/api-machinery", "size/M", "release-note-none", "cncf-cla: yes", "needs-ok-to-test", "area/code-generation", "needs-priority", "triage/accepted", "do-not-merge/needs-kind" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Jul 30 16:14:21 UTC 2023.\n", "created_at": "2023-07-30 19:03:05" }, { "body": "Welcome @biswajit-9776! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:", "created_at": "2023-07-30 19:03:09" }, { "body": "Hi @biswajit-9776. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-30 19:03:10" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119679#\" title=\"Author self-approved\">biswajit-9776</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [sttts](https://github.com/sttts) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/code-generator/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/code-generator/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"sttts\"]} -->", "created_at": "2023-07-30 19:03:32" }, { "body": "/assign @aojea \r\nFor the context of linked issue.\r\n/triage accepted", "created_at": "2023-08-03 16:38:07" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-30 19:03:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 19:03:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 19:03:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 19:03:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 19:03:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 19:03:10", "type": "labeled" }, { "author": "biswajit-9776", "created_at": "2023-07-30 19:03:10", "type": "mentioned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 19:03:10", "type": "labeled" }, { "author": "biswajit-9776", "created_at": "2023-07-30 19:03:10", "type": "subscribed" }, { "author": "biswajit-9776", "created_at": "2023-07-30 19:03:11", "type": "mentioned" }, { "author": "biswajit-9776", "created_at": "2023-07-30 19:03:11", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 19:03:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 19:03:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 19:03:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 19:03:45", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 19:03:54", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 19:03:54", "type": "review_requested" }, { "author": "aojea", "created_at": "2023-08-03 16:38:08", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-03 16:38:08", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-08-03 16:38:09", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:38:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:38:11", "type": "unlabeled" } ]

[]

[ "sig/network", "area/apiserver", "area/kubectl", "area/cloudprovider", "sig/node", "sig/api-machinery", "size/XXL", "kind/feature", "sig/auth", "sig/cli", "cncf-cla: yes", "sig/instrumentation", "sig/architecture", "do-not-merge/release-note-label-needed", "do-not-merge/work-in-progress", "sig/cloud-provider", "needs-priority", "triage/accepted" ]

[ { "body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-30 17:19:07" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Jul 30 16:14:21 UTC 2023.\n", "created_at": "2023-07-30 17:19:08" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119677#\" title=\"Author self-approved\">ardaguclu</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [andrewsykim](https://github.com/andrewsykim), [deads2k](https://github.com/deads2k), [ehashman](https://github.com/ehashman), [klueska](https://github.com/klueska), [smarterclayton](https://github.com/smarterclayton), [sttts](https://github.com/sttts) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/hack/OWNERS)**\n- **[pkg/registry/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/registry/OWNERS)**\n- **[staging/src/k8s.io/apimachinery/pkg/util/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/util/OWNERS)**\n- **[staging/src/k8s.io/apiserver/pkg/features/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/features/OWNERS)**\n- **[staging/src/k8s.io/cli-runtime/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/cli-runtime/OWNERS)**\n- **[staging/src/k8s.io/client-go/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/OWNERS)**\n- **[staging/src/k8s.io/component-base/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/component-base/OWNERS)**\n- **[staging/src/k8s.io/component-helpers/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/component-helpers/OWNERS)**\n- **[staging/src/k8s.io/dynamic-resource-allocation/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/dynamic-resource-allocation/OWNERS)**\n- **[staging/src/k8s.io/endpointslice/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/endpointslice/OWNERS)**\n- **[staging/src/k8s.io/kms/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kms/OWNERS)**\n- ~~[staging/src/k8s.io/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/OWNERS)~~ [ardaguclu]\n- **[staging/src/k8s.io/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubelet/OWNERS)**\n- **[staging/src/k8s.io/legacy-cloud-providers/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/legacy-cloud-providers/OWNERS)**\n- **[staging/src/k8s.io/metrics/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/metrics/OWNERS)**\n- **[staging/src/k8s.io/sample-cli-plugin/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/sample-cli-plugin/OWNERS)**\n- **[staging/src/k8s.io/sample-controller/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/sample-controller/OWNERS)**\n- **[vendor/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/vendor/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"andrewsykim\",\"deads2k\",\"ehashman\",\"klueska\",\"smarterclayton\",\"sttts\"]} -->", "created_at": "2023-07-30 17:20:05" }, { "body": "@ardaguclu: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-typecheck | 5a48300547ec2583c59a0536ebfdc244a0315900 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119677/pull-kubernetes-typecheck/1685701569514835968) | true | `/test pull-kubernetes-typecheck`\npull-kubernetes-node-e2e-containerd | 5a48300547ec2583c59a0536ebfdc244a0315900 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119677/pull-kubernetes-node-e2e-containerd/1685701566998253568/) | true | `/test pull-kubernetes-node-e2e-containerd`\npull-kubernetes-e2e-kind-kms | 5a48300547ec2583c59a0536ebfdc244a0315900 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119677/pull-kubernetes-e2e-kind-kms/1685701566620766208) | false | `/test pull-kubernetes-e2e-kind-kms`\npull-kubernetes-e2e-kind-ipv6 | 5a48300547ec2583c59a0536ebfdc244a0315900 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119677/pull-kubernetes-e2e-kind-ipv6/1685701566490742784) | true | `/test pull-kubernetes-e2e-kind-ipv6`\npull-kubernetes-e2e-kind | 5a48300547ec2583c59a0536ebfdc244a0315900 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119677/pull-kubernetes-e2e-kind/1685701566440411136) | true | `/test pull-kubernetes-e2e-kind`\npull-kubernetes-unit | 5a48300547ec2583c59a0536ebfdc244a0315900 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119677/pull-kubernetes-unit/1685701566574628864) | true | `/test pull-kubernetes-unit`\npull-kubernetes-verify | 5a48300547ec2583c59a0536ebfdc244a0315900 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119677/pull-kubernetes-verify/1685701570362085376) | true | `/test pull-kubernetes-verify`\npull-kubernetes-e2e-gce | 5a48300547ec2583c59a0536ebfdc244a0315900 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119677/pull-kubernetes-e2e-gce/1685701566247473152/) | true | `/test pull-kubernetes-e2e-gce`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119677). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Aardaguclu). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-07-30 18:17:15" }, { "body": "/close", "created_at": "2023-07-31 05:46:59" }, { "body": "@ardaguclu: Closed this PR.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119677#issuecomment-1657675241):\n\n>/close\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-31 05:47:05" }, { "body": "/triage accepted", "created_at": "2023-08-08 20:13:06" }, { "body": "/triage accepted", "created_at": "2023-08-08 20:13:25" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:43", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:43", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:57", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:19:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:20:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 17:20:00", "type": "labeled" }, { "author": "ardaguclu", "created_at": "2023-07-30 17:29:06", "type": "mentioned" }, { "author": "ardaguclu", "created_at": "2023-07-30 17:29:06", "type": "subscribed" }, { "author": "ardaguclu", "created_at": "2023-07-30 17:44:36", "type": "mentioned" }, { "author": "ardaguclu", "created_at": "2023-07-30 17:44:36", "type": "subscribed" }, { "author": "ardaguclu", "created_at": "2023-07-30 17:47:49", "type": "mentioned" }, { "author": "ardaguclu", "created_at": "2023-07-30 17:47:49", "type": "subscribed" }, { "author": "ardaguclu", "created_at": "2023-07-30 17:47:57", "type": "mentioned" }, { "author": "ardaguclu", "created_at": "2023-07-30 17:47:57", "type": "subscribed" }, { "author": "ardaguclu", "created_at": "2023-07-30 17:53:52", "type": "mentioned" }, { "author": "ardaguclu", "created_at": "2023-07-30 17:53:52", "type": "subscribed" }, { "author": "ardaguclu", "created_at": "2023-07-30 18:01:16", "type": "mentioned" }, { "author": "ardaguclu", "created_at": "2023-07-30 18:01:16", "type": "subscribed" }, { "author": "ardaguclu", "created_at": "2023-07-30 18:09:02", "type": "mentioned" }, { "author": "ardaguclu", "created_at": "2023-07-30 18:09:03", "type": "subscribed" }, { "author": "ardaguclu", "created_at": "2023-07-30 18:17:15", "type": "mentioned" }, { "author": "ardaguclu", "created_at": "2023-07-30 18:17:15", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 05:47:04", "type": "closed" }, { "author": "ardaguclu", "created_at": "2023-07-31 05:47:05", "type": "mentioned" }, { "author": "ardaguclu", "created_at": "2023-07-31 05:47:05", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:13:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 20:13:10", "type": "unlabeled" } ]

[]

[ "sig/autoscaling", "kind/feature", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-30 15:04:44" }, { "body": "Have you looked into https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler?", "created_at": "2023-07-31 12:37:26" }, { "body": "> Have you looked into https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler?\n\nSo. Can we use VPA along with hpa?. Because if we get more loads to the pods, there will be a limit the vla can autoscale and that may cause the application unhealthy state. So I guess we need both hoa and vpa in these scenarios. Or vpa is recommended to use only for finding the recommendation of the resource and not for dynamic update? ", "created_at": "2023-08-01 19:36:20" }, { "body": "> So. Can we use VPA along with hpa?. Because if we get more loads to the pods, there will be a limit the vla can autoscale and that may cause the application unhealthy state. So I guess we need both hoa and vpa in these scenarios. Or vpa is recommended to use only for finding the recommendation of the resource and not for dynamic update?\r\n\r\n/sig autoscaling\r\n\r\nTo be honest you may know more about this than I do. Maybe you can ask this question on sig-autoscaling in slack?", "created_at": "2023-08-01 19:36:52" }, { "body": "I will be going to try this approach for the automated estimation:\r\n\r\n1. Extract relevant information from JVM settings:\r\nFrom the given JVM settings, you can extract the parameters related to memory usage, such as -Xmx (maximum heap size) and -XX:MetaspaceSize, and CPU usage, such as GC-related parameters like -XX:MaxGCPauseMillis.\r\nAnalyze the values of these parameters to get an idea of the memory and CPU requirements for the application.\r\nMap JVM settings to Kubernetes resource requests and limits:\r\n\r\n2. Based on the extracted values, you can define rules or mappings that convert the JVM settings into appropriate Kubernetes resource requests and limits.\r\nFor example, you can set the memory request to the value of -Xmx and the memory limit to the sum of -Xmx and -XX:MetaspaceSize. Similarly, you can set the CPU request based on the -XX:MaxGCPauseMillis value.\r\nImplement the automated mechanism:\r\n\r\n3. Develop a tool or script that takes the JVM settings as input and calculates the corresponding Kubernetes resource requests and limits based on the defined rules.\r\nIntegrate this tool into the Azure DevOps (ADO) pipeline to automatically update the Variablegroups with the estimated resource values for each application.\r\nTesting and refinement:\r\n\r\n4. Test the automated mechanism with different Spring Boot applications, including those with varying JVM settings, to ensure accurate estimations.\r\nContinuously refine the estimation rules based on feedback and real-world usage patterns.\r\n", "created_at": "2023-08-05 19:34:38" }, { "body": "> I will be going to try this approach for the automated estimation:\n> \n> 1. Extract relevant information from JVM settings:\n> From the given JVM settings, you can extract the parameters related to memory usage, such as -Xmx (maximum heap size) and -XX:MetaspaceSize, and CPU usage, such as GC-related parameters like -XX:MaxGCPauseMillis.\n> Analyze the values of these parameters to get an idea of the memory and CPU requirements for the application.\n> Map JVM settings to Kubernetes resource requests and limits:\n> \n> 2. Based on the extracted values, you can define rules or mappings that convert the JVM settings into appropriate Kubernetes resource requests and limits.\n> For example, you can set the memory request to the value of -Xmx and the memory limit to the sum of -Xmx and -XX:MetaspaceSize. Similarly, you can set the CPU request based on the -XX:MaxGCPauseMillis value.\n> Implement the automated mechanism:\n> \n> 3. Develop a tool or script that takes the JVM settings as input and calculates the corresponding Kubernetes resource requests and limits based on the defined rules.\n> Integrate this tool into the Azure DevOps (ADO) pipeline to automatically update the Variablegroups with the estimated resource values for each application.\n> Testing and refinement:\n> \n> 4. Test the automated mechanism with different Spring Boot applications, including those with varying JVM settings, to ensure accurate estimations.\n> Continuously refine the estimation rules based on feedback and real-world usage patterns.\n> \n\nIs this possible to achieve using vertical pod autoscaler recommender? Can hoa and vpa work together to ensure both the ways scaling happening for cou and memory usage", "created_at": "2023-08-05 20:20:06" } ]

[ { "author": "vivuu1989", "created_at": "2023-07-30 15:04:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 15:04:42", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 15:04:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 19:36:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 19:36:54", "type": "unlabeled" } ]

[]

[ "size/M", "release-note-none", "cncf-cla: yes", "needs-ok-to-test", "needs-priority", "needs-triage", "do-not-merge/needs-sig", "do-not-merge/needs-kind" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Jul 30 10:14:21 UTC 2023.\n", "created_at": "2023-07-30 14:14:50" }, { "body": "Hi @ning0515. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-30 14:14:56" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-30 14:14:56" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119675#\" title=\"Author self-approved\">ning0515</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [sttts](https://github.com/sttts) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/routes/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/routes/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"sttts\"]} -->", "created_at": "2023-07-30 14:15:17" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-30 14:14:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 14:14:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 14:14:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 14:14:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 14:14:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 14:14:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 14:14:55", "type": "labeled" }, { "author": "ning0515", "created_at": "2023-07-30 14:14:56", "type": "mentioned" }, { "author": "ning0515", "created_at": "2023-07-30 14:14:56", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 14:14:57", "type": "labeled" }, { "author": "ning0515", "created_at": "2023-07-30 14:15:28", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 14:15:43", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 14:15:43", "type": "review_requested" }, { "author": "ning0515", "created_at": "2023-07-30 14:15:52", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 06:28:27", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 06:28:28", "type": "labeled" }, { "author": "ning0515", "created_at": "2023-07-31 14:55:39", "type": "review_requested" } ]

[]

[ "kind/bug", "release-note", "size/S", "sig/apps", "cncf-cla: yes", "do-not-merge/work-in-progress", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Jul 30 10:14:21 UTC 2023.\n", "created_at": "2023-07-30 13:53:01" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-30 13:53:06" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119674#\" title=\"Author self-approved\">pacoxu</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [smarterclayton](https://github.com/smarterclayton) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"smarterclayton\"]} -->", "created_at": "2023-07-30 13:53:53" }, { "body": "/test pull-kubernetes-e2e-ubuntu-gce-network-policies\r\n/test pull-kubernetes-e2e-gci-gce-ipvs\r\n/test pull-kubernetes-e2e-gci-gce-ingress", "created_at": "2023-07-30 13:54:10" }, { "body": "/cc @aojea", "created_at": "2023-07-30 13:54:17" }, { "body": "@pacoxu: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-node-e2e-containerd | 1b6ea6a64dab0fdde5db26add93c5a9f9d252c6b | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119674/pull-kubernetes-node-e2e-containerd/1685650050350321664/) | true | `/test pull-kubernetes-node-e2e-containerd`\npull-kubernetes-integration | 1b6ea6a64dab0fdde5db26add93c5a9f9d252c6b | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119674/pull-kubernetes-integration/1685650029382995968) | true | `/test pull-kubernetes-integration`\npull-kubernetes-e2e-gce | 1b6ea6a64dab0fdde5db26add93c5a9f9d252c6b | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119674/pull-kubernetes-e2e-gce/1685650028418306048/) | true | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-e2e-ubuntu-gce-network-policies | 1b6ea6a64dab0fdde5db26add93c5a9f9d252c6b | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119674/pull-kubernetes-e2e-ubuntu-gce-network-policies/1685649999179812864) | false | `/test pull-kubernetes-e2e-ubuntu-gce-network-policies`\npull-kubernetes-e2e-kind-ipv6 | 1b6ea6a64dab0fdde5db26add93c5a9f9d252c6b | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119674/pull-kubernetes-e2e-kind-ipv6/1685650033602465792) | true | `/test pull-kubernetes-e2e-kind-ipv6`\npull-kubernetes-conformance-kind-ga-only-parallel | 1b6ea6a64dab0fdde5db26add93c5a9f9d252c6b | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119674/pull-kubernetes-conformance-kind-ga-only-parallel/1685650036521701376) | true | `/test pull-kubernetes-conformance-kind-ga-only-parallel`\npull-kubernetes-typecheck | 1b6ea6a64dab0fdde5db26add93c5a9f9d252c6b | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119674/pull-kubernetes-typecheck/1685650039885533184) | true | `/test pull-kubernetes-typecheck`\npull-kubernetes-e2e-kind | 1b6ea6a64dab0fdde5db26add93c5a9f9d252c6b | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119674/pull-kubernetes-e2e-kind/1685650031048134656) | true | `/test pull-kubernetes-e2e-kind`\npull-kubernetes-e2e-gci-gce-ipvs | 1b6ea6a64dab0fdde5db26add93c5a9f9d252c6b | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119674/pull-kubernetes-e2e-gci-gce-ipvs/1685649999242727424) | false | `/test pull-kubernetes-e2e-gci-gce-ipvs`\npull-kubernetes-e2e-gci-gce-ingress | 1b6ea6a64dab0fdde5db26add93c5a9f9d252c6b | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119674/pull-kubernetes-e2e-gci-gce-ingress/1685649999129481216) | false | `/test pull-kubernetes-e2e-gci-gce-ingress`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119674). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Apacoxu). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-07-30 14:04:12" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-30 13:53:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 13:53:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 13:53:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 13:53:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 13:53:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 13:53:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 13:53:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 13:53:29", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 13:53:30", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 13:53:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 13:53:43", "type": "unlabeled" }, { "author": "pacoxu", "created_at": "2023-07-30 13:54:01", "type": "head_ref_force_pushed" }, { "author": "aojea", "created_at": "2023-07-30 13:54:17", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-07-30 13:54:17", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 13:54:18", "type": "review_requested" }, { "author": "pacoxu", "created_at": "2023-07-30 13:59:03", "type": "mentioned" }, { "author": "pacoxu", "created_at": "2023-07-30 13:59:03", "type": "subscribed" }, { "author": "pacoxu", "created_at": "2023-07-30 13:59:14", "type": "mentioned" }, { "author": "pacoxu", "created_at": "2023-07-30 13:59:14", "type": "subscribed" }, { "author": "pacoxu", "created_at": "2023-07-30 14:01:20", "type": "mentioned" }, { "author": "pacoxu", "created_at": "2023-07-30 14:01:20", "type": "subscribed" }, { "author": "pacoxu", "created_at": "2023-07-30 14:01:46", "type": "mentioned" }, { "author": "pacoxu", "created_at": "2023-07-30 14:01:46", "type": "subscribed" }, { "author": "pacoxu", "created_at": "2023-07-30 14:01:51", "type": "mentioned" }, { "author": "pacoxu", "created_at": "2023-07-30 14:01:52", "type": "subscribed" }, { "author": "pacoxu", "created_at": "2023-07-30 14:02:14", "type": "mentioned" }, { "author": "pacoxu", "created_at": "2023-07-30 14:02:14", "type": "subscribed" }, { "author": "pacoxu", "created_at": "2023-07-30 14:02:21", "type": "mentioned" }, { "author": "pacoxu", "created_at": "2023-07-30 14:02:21", "type": "subscribed" }, { "author": "pacoxu", "created_at": "2023-07-30 14:02:23", "type": "mentioned" }, { "author": "pacoxu", "created_at": "2023-07-30 14:02:23", "type": "subscribed" }, { "author": "pacoxu", "created_at": "2023-07-30 14:03:31", "type": "mentioned" }, { "author": "pacoxu", "created_at": "2023-07-30 14:03:31", "type": "subscribed" }, { "author": "pacoxu", "created_at": "2023-07-30 14:04:12", "type": "mentioned" }, { "author": "pacoxu", "created_at": "2023-07-30 14:04:12", "type": "subscribed" }, { "author": "pacoxu", "created_at": "2023-07-30 14:05:18", "type": "convert_to_draft" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 14:05:20", "type": "labeled" }, { "author": "pacoxu", "created_at": "2023-07-31 09:54:10", "type": "closed" } ]

[ "pohly", "alculquicondor", "apelisse", "hwdef" ]

[ "kind/cleanup", "sig/api-machinery", "needs-rebase", "size/L", "cncf-cla: yes", "sig/testing", "do-not-merge/release-note-label-needed", "ok-to-test", "needs-priority", "triage/accepted" ]

[ { "body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-30 11:30:40" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Jul 30 10:14:21 UTC 2023.\n", "created_at": "2023-07-30 11:30:42" }, { "body": "Hi @linxiulei. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-30 11:30:47" }, { "body": "/ok-to-test\r\n/sig api-machinery\r\n/sig testing\r\n/assign @pohly @apelisse ", "created_at": "2023-07-30 13:18:51" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119672#\" title=\"Author self-approved\">linxiulei</a>*\n**Once this PR has been reviewed and has the lgtm label**, please ask for approval from [pohly](https://github.com/pohly). For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/hack/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"pohly\"]} -->", "created_at": "2023-07-30 15:29:53" }, { "body": "/retest", "created_at": "2023-07-30 19:41:48" }, { "body": "LGTM label has been added. <details>Git tree hash: c6f5be51218782818f8bec6bb6acbf7b6ecad9fb</details>", "created_at": "2023-07-31 02:43:44" }, { "body": "/cc @alculquicondor", "created_at": "2023-07-31 14:17:25" }, { "body": "LGTM from sig-scheduling", "created_at": "2023-07-31 14:21:44" }, { "body": "New changes are detected. LGTM label has been removed.", "created_at": "2023-08-01 16:56:26" }, { "body": "/assign @pohly @alculquicondor\r\n/triage accepted", "created_at": "2023-08-03 16:39:40" }, { "body": "We agreed to go with https://github.com/kubernetes/kubernetes/pull/119728 instead.\r\n\r\n@jiahuif: thanks for taking the time to write this, sorry that it now doesn't get used now. We can close this PR, right?\r\n", "created_at": "2023-08-17 06:49:01" }, { "body": "PR needs rebase.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-17 06:49:09" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:30:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:30:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:30:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:30:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:30:44", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:30:44", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:30:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:30:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:30:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:30:47", "type": "labeled" }, { "author": "linxiulei", "created_at": "2023-07-30 11:30:47", "type": "mentioned" }, { "author": "linxiulei", "created_at": "2023-07-30 11:30:47", "type": "subscribed" }, { "author": "pohly", "created_at": "2023-07-30 13:18:52", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-07-30 13:18:52", "type": "subscribed" }, { "author": "apelisse", "created_at": "2023-07-30 13:18:52", "type": "mentioned" }, { "author": "apelisse", "created_at": "2023-07-30 13:18:52", "type": "subscribed" }, { "author": "apelisse", "created_at": "2023-07-30 13:18:52", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 13:18:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 13:18:53", "type": "labeled" }, { "author": "pohly", "created_at": "2023-07-30 13:18:53", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 13:18:53", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 13:18:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 13:18:54", "type": "unlabeled" }, { "author": "linxiulei", "created_at": "2023-07-30 14:14:19", "type": "mentioned" }, { "author": "linxiulei", "created_at": "2023-07-30 14:14:20", "type": "subscribed" }, { "author": "linxiulei", "created_at": "2023-07-30 15:29:13", "type": "head_ref_force_pushed" }, { "author": "linxiulei", "created_at": "2023-07-30 16:25:44", "type": "mentioned" }, { "author": "linxiulei", "created_at": "2023-07-30 16:25:44", "type": "subscribed" }, { "author": "linxiulei", "created_at": "2023-07-30 18:11:46", "type": "head_ref_force_pushed" }, { "author": "linxiulei", "created_at": "2023-07-30 18:45:52", "type": "mentioned" }, { "author": "linxiulei", "created_at": "2023-07-30 18:45:52", "type": "subscribed" }, { "author": "hwdef", "created_at": "2023-07-31 02:43:42", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 02:43:42", "type": "labeled" }, { "author": "alculquicondor", "created_at": "2023-07-31 14:17:26", "type": "mentioned" }, { "author": "alculquicondor", "created_at": "2023-07-31 14:17:26", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 14:17:28", "type": "review_requested" }, { "author": "linxiulei", "created_at": "2023-08-01 16:56:21", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 16:56:23", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 16:56:24", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 16:56:24", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 16:56:24", "type": "review_requested" }, { "author": "pohly", "created_at": "2023-08-03 16:39:41", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-03 16:39:41", "type": "subscribed" }, { "author": "alculquicondor", "created_at": "2023-08-03 16:39:41", "type": "mentioned" }, { "author": "alculquicondor", "created_at": "2023-08-03 16:39:41", "type": "subscribed" }, { "author": "alculquicondor", "created_at": "2023-08-03 16:39:42", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:39:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:39:45", "type": "unlabeled" }, { "author": "jiahuif", "created_at": "2023-08-17 06:49:01", "type": "mentioned" }, { "author": "jiahuif", "created_at": "2023-08-17 06:49:01", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 06:49:08", "type": "labeled" } ]

[ "dims", "ameukam", "MadhavJivrajani" ]

[ "kind/bug", "priority/critical-urgent", "lgtm", "area/provider/gcp", "size/XS", "release-note-none", "approved", "cncf-cla: yes", "sig/cloud-provider", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Jul 30 10:14:21 UTC 2023.\n", "created_at": "2023-07-30 11:05:11" }, { "body": "/milestone v1.28\r\n/priority critical-urgent\r\n/triage accepted", "created_at": "2023-07-30 11:06:03" }, { "body": "/lgtm \r\n❤️ ", "created_at": "2023-07-30 11:25:31" }, { "body": "LGTM label has been added. <details>Git tree hash: c630319de7415da4a510dedec2e3faf3dd476131</details>", "created_at": "2023-07-30 11:25:38" }, { "body": "/approve\r\n/lgtm", "created_at": "2023-07-30 12:46:29" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119671#issuecomment-1657130998\" title=\"LGTM\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119671#\" title=\"Author self-approved\">xmudrii</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[cluster/gce/gci/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/gci/OWNERS)~~ [dims]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-07-30 12:46:35" } ]

[ { "author": "dims", "created_at": "2023-07-30 11:05:08", "type": "mentioned" }, { "author": "dims", "created_at": "2023-07-30 11:05:08", "type": "subscribed" }, { "author": "ameukam", "created_at": "2023-07-30 11:05:08", "type": "mentioned" }, { "author": "ameukam", "created_at": "2023-07-30 11:05:08", "type": "subscribed" }, { "author": "ameukam", "created_at": "2023-07-30 11:05:09", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:05:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:05:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:05:09", "type": "labeled" }, { "author": "dims", "created_at": "2023-07-30 11:05:09", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:05:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:05:13", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:05:13", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:05:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:05:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:05:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:05:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:05:16", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:05:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:06:05", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:06:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:06:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:06:07", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:06:07", "type": "unlabeled" }, { "author": "MadhavJivrajani", "created_at": "2023-07-30 11:25:35", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 11:25:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 12:46:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 12:48:01", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 12:48:01", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 12:48:01", "type": "closed" }, { "author": "xmudrii", "created_at": "2023-07-30 12:56:56", "type": "head_ref_deleted" } ]

[ "tzneal", "aojea" ]

[ "kind/bug", "area/test", "priority/important-soon", "lgtm", "sig/node", "size/XS", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "ok-to-test", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Jul 30 04:14:48 UTC 2023.\n", "created_at": "2023-07-30 05:57:09" }, { "body": "Hi @lengrongfu. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-30 05:57:14" }, { "body": "/ok-to-test\r\n/lgtm\r\n/approve", "created_at": "2023-07-30 22:07:12" }, { "body": "LGTM label has been added. <details>Git tree hash: 16c8dcef482da9e55d3bd1534e540c414b5d5e7d</details>", "created_at": "2023-07-30 22:07:20" }, { "body": "/triage accepted\r\n/priority important-soon", "created_at": "2023-07-31 11:29:07" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119670#issuecomment-1657276952\" title=\"Approved\">aojea</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119670#\" title=\"Author self-approved\">lengrongfu</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119670#pullrequestreview-1559492039\" title=\"LGTM\">tzneal</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e_node/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/OWNERS)~~ [aojea]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-02 17:12:21" }, { "body": "Adding f48daf5412edac432c28 so this will show up when searching from [k8s-triage](https://storage.googleapis.com/k8s-triage/index.html).", "created_at": "2023-08-10 19:26:52" }, { "body": "Still failing?\r\n\r\nSee https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119728/pull-kubernetes-node-e2e-containerd/1692065178335580160/\r\n", "created_at": "2023-08-17 08:03:10" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-30 05:57:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 05:57:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 05:57:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 05:57:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 05:57:10", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 05:57:10", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 05:57:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 05:57:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 05:57:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 05:57:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 05:57:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 05:57:13", "type": "labeled" }, { "author": "lengrongfu", "created_at": "2023-07-30 05:57:14", "type": "mentioned" }, { "author": "lengrongfu", "created_at": "2023-07-30 05:57:14", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 22:07:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 22:07:14", "type": "unlabeled" }, { "author": "aojea", "created_at": "2023-07-30 22:07:16", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 22:07:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 22:07:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:29:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:29:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:29:11", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:29:11", "type": "unlabeled" }, { "author": "tzneal", "created_at": "2023-08-02 17:11:59", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 02:43:40", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 02:43:40", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 02:43:40", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 02:43:42", "type": "milestoned" } ]

[]

[ "kind/bug", "sig/node", "triage/accepted" ]

[ { "body": "/sig node", "created_at": "2023-07-29 18:57:58" }, { "body": "I have a k8s 1.24 cluster and running a privileged pod gives cpuset info in `/sys/fs/cgroup/cpuset/cpuset.cpus`\r\n ```\r\nroot@test-0:/# cat /sys/fs/cgroup/cpuset/cpuset.cpus\r\n0-15\r\n```\r\ndoes cgroupv2 change directory layout?", "created_at": "2023-07-30 21:11:36" }, { "body": "> I have a k8s 1.24 cluster and running a privileged pod gives cpuset info in `/sys/fs/cgroup/cpuset/cpuset.cpus`\r\n> \r\n> ```\r\n> root@test-0:/# cat /sys/fs/cgroup/cpuset/cpuset.cpus\r\n> 0-15\r\n> ```\r\n> \r\n> does cgroupv2 change directory layout?\r\n\r\nIt does, yes, in cgroupv1 as per your example, the container's assigned CPUs are found in `/sys/fs/cgroup/cpuset/cpuset.cpus` whereas in cgroupsv2, the container's assigned CPUs are found in `/sys/fs/cgroup/cpuset.cpus`. I believe the inspiration for this is that in Cgroupsv2 resources are now unified together in one process subdirectory whereas in cgroupv1, a process needed to have access to each cgroup resource directory making things a little more complex", "created_at": "2023-07-30 21:21:45" }, { "body": "probably. My host has a `cgroup2 on /sys/fs/cgroup/unified type cgroup2`. But I didn't find it mounted to the test privileged pod.", "created_at": "2023-07-31 02:37:59" }, { "body": "/cc @haircommander \r\n/triage accepted", "created_at": "2023-08-02 17:48:38" }, { "body": "ah! this is expected, the kernel API for cgroupv2 has changed. Now, the file is `/sys/fs/cgroup/cpuset.cpus.effective` which should show you the active cpuset the container is running in", "created_at": "2023-08-03 15:56:31" }, { "body": "I'm afraid the problem still persists with `/sys/fs/cgroup/cpuset.cpus.effective`, cpuset.cpus.effective is showing the effective cpus for the whole node when the container is privileged and works fine when the container is not privileged showing the correct active cpuset.\r\n**Non Privileged Container (Using Pod Spec Defined Above) (Working):**\r\n```bash\r\nroot@test-0:/# cat /sys/fs/cgroup/cpuset.cpus.effective\r\n1-2\r\n```\r\n\r\n**Privileged Container (Using Pod Spec Defined Above) (Not Working):**\r\n```bash\r\nroot@test-0:/# cat /sys/fs/cgroup/cpuset.cpus.effective \r\n0-5\r\n```\r\n\r\nAs mentioned before, since Kubernetes 1.24, it looks to me like the privileged container's /sys/fs/cgroup is getting overridden with host node's /sys/fs/cgroup thus breaking the active cpuset reporting through cgroupv2 \r\n", "created_at": "2023-08-07 21:50:45" }, { "body": "hm if you keep the containerd/cri-o version the same but switch the kube version, does it still change? I see cri-o has been mounting host /sys/fs/cgroup since at least 1.23 so I'm wondering if it's changes in the CRI or something changed in the kubelet somehow..", "created_at": "2023-08-08 20:40:36" }, { "body": "Interesting.. yes all the tests I've ran have kept the Containerd version to 1.6.20 for every Kube version tested. Do you think this is containerd performing the mount of /sys/fs/cgroup with privileged only if K8s version is 1.24 or later? Is this something defined by the CRI between K8s and the runtime?", "created_at": "2023-08-15 14:57:50" } ]

[ { "author": "pjconnol", "created_at": "2023-07-29 18:55:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:55:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:55:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:57:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:58:01", "type": "unlabeled" }, { "author": "haircommander", "created_at": "2023-08-02 17:48:38", "type": "mentioned" }, { "author": "haircommander", "created_at": "2023-08-02 17:48:39", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 17:48:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 17:48:41", "type": "unlabeled" } ]

[]

[ "priority/backlog", "kind/documentation", "kind/cleanup", "size/XS", "release-note-none", "sig/auth", "cncf-cla: yes", "needs-ok-to-test", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sat Jul 29 16:13:13 UTC 2023.\n", "created_at": "2023-07-29 18:40:43" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119668#\" title=\"Author self-approved\">deveshgoyal1000</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [tallclair](https://github.com/tallclair) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/pod-security-admission/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/pod-security-admission/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"tallclair\"]} -->", "created_at": "2023-07-29 18:40:44" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-29 18:40:46" }, { "body": "Hi @deveshgoyal1000. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-29 18:40:48" }, { "body": "there's a few other occurrences of this typo:\r\n\r\n```\r\n\t// by finding the highest request/limit for each resource type, and then using the max of\r\n\t// of that value or the sum of the normal containers. Limits are applied to init containers\r\n```\r\n\r\n```\r\n// estimate the work of of incoming requests.\r\n```\r\n\r\ncan you resolve those as well?", "created_at": "2023-07-31 13:15:46" }, { "body": "/release-note-none\r\n/priority backlog\r\n/remove-kind bug\r\n/kind cleanup", "created_at": "2023-08-08 07:40:30" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:40:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:40:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:40:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:40:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:40:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:40:44", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:40:44", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:40:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:40:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:40:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:40:47", "type": "labeled" }, { "author": "deveshgoyal1000", "created_at": "2023-07-29 18:40:48", "type": "mentioned" }, { "author": "deveshgoyal1000", "created_at": "2023-07-29 18:40:48", "type": "subscribed" }, { "author": "toVersus", "created_at": "2023-07-31 05:48:35", "type": "unsubscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 07:40:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 07:40:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 07:40:32", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 07:40:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 07:40:33", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 07:40:33", "type": "unlabeled" } ]

[]

[ "kind/cleanup", "sig/auth", "sig/security", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-29 18:34:06" }, { "body": "/remove-kind bug\r\n/kind cleanup\r\nThis is not typically a bug and may not need to open an issue to track IMO.\r\n", "created_at": "2023-08-08 07:41:30" }, { "body": "/sig auth", "created_at": "2023-08-14 16:24:04" }, { "body": "/sig security\r\n", "created_at": "2023-08-14 16:24:33" } ]

[ { "author": "deveshgoyal1000", "created_at": "2023-07-29 18:33:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:34:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:34:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 07:41:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 07:41:33", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:24:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:24:07", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 16:24:35", "type": "labeled" }, { "author": "toVersus", "created_at": "2023-08-14 22:31:40", "type": "unsubscribed" } ]

[ "bobbypage", "SergeyKanzhelev" ]

[ "area/kubelet", "sig/node", "release-note", "size/M", "kind/feature", "cncf-cla: yes", "priority/important-longterm", "ok-to-test", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sat Jul 29 16:13:13 UTC 2023.\n", "created_at": "2023-07-29 16:46:47" }, { "body": "Hi @lengrongfu. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-29 16:46:52" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119666#\" title=\"Author self-approved\">lengrongfu</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [yujuhong](https://github.com/yujuhong) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/kubelet/prober/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/prober/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"yujuhong\"]} -->", "created_at": "2023-07-29 16:51:53" }, { "body": "/ok-to-test", "created_at": "2023-07-30 16:09:08" }, { "body": "@lengrongfu: Cannot trigger testing until a trusted user reviews the PR and leaves an `/ok-to-test` message.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119666#issuecomment-1657210142):\n\n>/ok-to-test\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-30 16:09:22" }, { "body": "/priority important-longterm\r\n/triage accepted\r\n/ok-to-test\r\n/assign @bobbypage @SergeyKanzhelev \r\n/cc\r\n\r\n@lengrongfu Can you cover your code with a unit or/and e2e tests?\r\n", "created_at": "2023-08-02 13:47:33" }, { "body": "> /priority important-longterm /triage accepted /ok-to-test /assign @bobbypage @SergeyKanzhelev /cc\r\n> \r\n> @lengrongfu Can you cover your code with a unit or/and e2e tests?\r\n\r\nThanks you tips, add unit test.", "created_at": "2023-08-03 05:55:54" }, { "body": "I'm not sure that #https://github.com/kubernetes/kubernetes/issues/119617 needs fixing _in code_. Are we sure that this is a bug fix?\r\n\r\n(if not: it's looks more like an API change, and should have API review)", "created_at": "2023-08-07 10:20:24" }, { "body": "@sftim Somebody changed the documentation and the new logic makes more sense, what is the way to proceed?", "created_at": "2023-08-22 12:27:08" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-29 16:46:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 16:46:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 16:46:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 16:46:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 16:46:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 16:46:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 16:46:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 16:46:52", "type": "labeled" }, { "author": "lengrongfu", "created_at": "2023-07-29 16:46:53", "type": "mentioned" }, { "author": "lengrongfu", "created_at": "2023-07-29 16:46:53", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 16:51:53", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 16:51:53", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 16:51:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 16:51:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 16:51:56", "type": "unlabeled" }, { "author": "lengrongfu", "created_at": "2023-07-30 16:09:22", "type": "mentioned" }, { "author": "lengrongfu", "created_at": "2023-07-30 16:09:22", "type": "subscribed" }, { "author": "bobbypage", "created_at": "2023-08-02 13:47:34", "type": "mentioned" }, { "author": "bobbypage", "created_at": "2023-08-02 13:47:34", "type": "subscribed" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-02 13:47:34", "type": "mentioned" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-02 13:47:34", "type": "subscribed" }, { "author": "lengrongfu", "created_at": "2023-08-02 13:47:34", "type": "mentioned" }, { "author": "lengrongfu", "created_at": "2023-08-02 13:47:34", "type": "subscribed" }, { "author": "bobbypage", "created_at": "2023-08-02 13:47:35", "type": "assigned" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-02 13:47:35", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 13:47:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 13:47:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 13:47:36", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 13:47:37", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 13:47:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 13:47:38", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 13:47:40", "type": "unlabeled" }, { "author": "lengrongfu", "created_at": "2023-08-03 05:55:00", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 05:55:02", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 05:55:03", "type": "labeled" }, { "author": "bobbypage", "created_at": "2023-08-03 05:55:54", "type": "mentioned" }, { "author": "bobbypage", "created_at": "2023-08-03 05:55:54", "type": "subscribed" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-03 05:55:55", "type": "mentioned" }, { "author": "SergeyKanzhelev", "created_at": "2023-08-03 05:55:55", "type": "subscribed" }, { "author": "lengrongfu", "created_at": "2023-08-03 05:55:55", "type": "mentioned" }, { "author": "lengrongfu", "created_at": "2023-08-03 05:55:55", "type": "subscribed" }, { "author": "sftim", "created_at": "2023-08-22 12:27:09", "type": "mentioned" }, { "author": "sftim", "created_at": "2023-08-22 12:27:09", "type": "subscribed" } ]

[ "mrunalp", "thockin", "derekwaynecarr", "dchen1107", "SergeyKanzhelev", "iholder101" ]

[ "area/test", "area/kubelet", "kind/cleanup", "sig/scheduling", "area/kubectl", "lgtm", "sig/node", "sig/api-machinery", "size/M", "sig/apps", "sig/cli", "cncf-cla: yes", "sig/testing", "priority/important-longterm", "do-not-merge/release-note-label-needed", "triage/accepted" ]

[ { "body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-29 14:15:00" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sat Jul 29 10:13:20 UTC 2023.\n", "created_at": "2023-07-29 14:15:02" }, { "body": "/test pull-kubernetes-e2e-gce-cos-alpha-features\r\n/test pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2", "created_at": "2023-07-29 14:19:59" }, { "body": "/assign @derekwaynecarr @thockin @dchen1107 @SergeyKanzhelev @mrunalp ", "created_at": "2023-07-29 20:17:04" }, { "body": "/triage accepted\r\n/priority important-longterm", "created_at": "2023-07-31 15:32:51" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119665#\" title=\"Author self-approved\">vinaykul</a>*\n**Once this PR has been reviewed and has the lgtm label**, please ask for approval from [thockin](https://github.com/thockin). For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/OWNERS)**\n- **[staging/src/k8s.io/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"thockin\"]} -->", "created_at": "2023-08-07 14:48:53" }, { "body": "@vinaykul: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-e2e-gce-cos-alpha-features | 54c11813c710283da9c84dd14fdf64537a5f20eb | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119665/pull-kubernetes-e2e-gce-cos-alpha-features/1686238066299113472/) | unknown | `/test pull-kubernetes-e2e-gce-cos-alpha-features`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119665). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Avinaykul). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-08-08 11:15:48" }, { "body": "/lgtm\r\nThank you @vinaykul!", "created_at": "2023-08-14 13:22:52" }, { "body": "LGTM label has been added. <details>Git tree hash: e13504b92a8276f4ac5ed20efde13c77f414a14f</details>", "created_at": "2023-08-14 13:23:00" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:05", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:05", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:08", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 14:15:10", "type": "labeled" }, { "author": "vinaykul", "created_at": "2023-07-29 14:49:00", "type": "mentioned" }, { "author": "vinaykul", "created_at": "2023-07-29 14:49:00", "type": "subscribed" }, { "author": "vinaykul", "created_at": "2023-07-29 15:28:57", "type": "mentioned" }, { "author": "vinaykul", "created_at": "2023-07-29 15:28:57", "type": "subscribed" }, { "author": "vinaykul", "created_at": "2023-07-29 15:30:19", "type": "mentioned" }, { "author": "vinaykul", "created_at": "2023-07-29 15:30:19", "type": "subscribed" }, { "author": "vinaykul", "created_at": "2023-07-29 16:49:23", "type": "mentioned" }, { "author": "vinaykul", "created_at": "2023-07-29 16:49:23", "type": "subscribed" }, { "author": "mrunalp", "created_at": "2023-07-29 20:17:04", "type": "mentioned" }, { "author": "mrunalp", "created_at": "2023-07-29 20:17:04", "type": "subscribed" }, { "author": "thockin", "created_at": "2023-07-29 20:17:04", "type": "mentioned" }, { "author": "thockin", "created_at": "2023-07-29 20:17:04", "type": "subscribed" }, { "author": "derekwaynecarr", "created_at": "2023-07-29 20:17:04", "type": "mentioned" }, { "author": "derekwaynecarr", "created_at": "2023-07-29 20:17:04", "type": "subscribed" }, { "author": "dchen1107", "created_at": "2023-07-29 20:17:05", "type": "mentioned" }, { "author": "dchen1107", "created_at": "2023-07-29 20:17:05", "type": "subscribed" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-29 20:17:05", "type": "mentioned" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-29 20:17:05", "type": "subscribed" }, { "author": "dchen1107", "created_at": "2023-07-29 20:17:05", "type": "assigned" }, { "author": "derekwaynecarr", "created_at": "2023-07-29 20:17:06", "type": "assigned" }, { "author": "mrunalp", "created_at": "2023-07-29 20:17:06", "type": "assigned" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-29 20:17:06", "type": "assigned" }, { "author": "thockin", "created_at": "2023-07-29 20:17:07", "type": "assigned" }, { "author": "vinaykul", "created_at": "2023-07-29 21:28:23", "type": "mentioned" }, { "author": "vinaykul", "created_at": "2023-07-29 21:28:23", "type": "subscribed" }, { "author": "vinaykul", "created_at": "2023-07-30 14:47:59", "type": "renamed" }, { "author": "vinaykul", "created_at": "2023-07-30 22:13:11", "type": "mentioned" }, { "author": "vinaykul", "created_at": "2023-07-30 22:13:11", "type": "subscribed" }, { "author": "vinaykul", "created_at": "2023-07-31 01:51:43", "type": "mentioned" }, { "author": "vinaykul", "created_at": "2023-07-31 01:51:44", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:32:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:32:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:32:55", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:32:56", "type": "unlabeled" }, { "author": "vinaykul", "created_at": "2023-07-31 17:22:11", "type": "mentioned" }, { "author": "vinaykul", "created_at": "2023-07-31 17:22:11", "type": "subscribed" }, { "author": "vinaykul", "created_at": "2023-07-31 19:05:34", "type": "mentioned" }, { "author": "vinaykul", "created_at": "2023-07-31 19:05:34", "type": "subscribed" }, { "author": "vinaykul", "created_at": "2023-08-01 06:02:17", "type": "mentioned" }, { "author": "vinaykul", "created_at": "2023-08-01 06:02:18", "type": "subscribed" }, { "author": "ardaguclu", "created_at": "2023-08-01 18:08:49", "type": "subscribed" }, { "author": "ardaguclu", "created_at": "2023-08-01 18:08:52", "type": "unsubscribed" }, { "author": "vinaykul", "created_at": "2023-08-07 14:48:45", "type": "head_ref_force_pushed" }, { "author": "vinaykul", "created_at": "2023-08-07 14:51:08", "type": "renamed" }, { "author": "vinaykul", "created_at": "2023-08-07 15:21:28", "type": "mentioned" }, { "author": "vinaykul", "created_at": "2023-08-07 15:21:28", "type": "subscribed" }, { "author": "vinaykul", "created_at": "2023-08-07 15:57:43", "type": "mentioned" }, { "author": "vinaykul", "created_at": "2023-08-07 15:57:43", "type": "subscribed" }, { "author": "vinaykul", "created_at": "2023-08-08 04:02:51", "type": "head_ref_force_pushed" }, { "author": "vinaykul", "created_at": "2023-08-08 04:45:59", "type": "mentioned" }, { "author": "vinaykul", "created_at": "2023-08-08 04:46:00", "type": "subscribed" }, { "author": "vinaykul", "created_at": "2023-08-08 04:58:55", "type": "mentioned" }, { "author": "vinaykul", "created_at": "2023-08-08 04:58:55", "type": "subscribed" }, { "author": "vinaykul", "created_at": "2023-08-08 11:15:49", "type": "mentioned" }, { "author": "vinaykul", "created_at": "2023-08-08 11:15:49", "type": "subscribed" }, { "author": "vinaykul", "created_at": "2023-08-14 13:22:53", "type": "mentioned" }, { "author": "vinaykul", "created_at": "2023-08-14 13:22:53", "type": "subscribed" }, { "author": "iholder101", "created_at": "2023-08-14 13:22:57", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-14 13:22:59", "type": "labeled" } ]

[]

[ "kind/failing-test", "sig/release", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-29 11:44:34" }, { "body": "`v20230719-72ce785784-master` is changed in https://github.com/kubernetes/test-infra/pull/30179/. ", "created_at": "2023-07-29 12:14:11" } ]

[ { "author": "pacoxu", "created_at": "2023-07-29 11:44:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 11:44:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 11:44:34", "type": "labeled" } ]

[ "tzneal" ]

[ "kind/bug", "area/test", "priority/critical-urgent", "lgtm", "area/provider/gcp", "sig/node", "size/XS", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "sig/cloud-provider", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Jul 28 22:12:27 UTC 2023.\n", "created_at": "2023-07-29 02:18:33" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119663#\" title=\"Author self-approved\">dims</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[cluster/gce/gci/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/gci/OWNERS)~~ [dims]\n- ~~[test/e2e_node/jenkins/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/jenkins/OWNERS)~~ [dims]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-07-29 02:18:34" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-29 02:18:38" }, { "body": "/milestone v1.28", "created_at": "2023-07-29 02:23:22" }, { "body": "Verified problem and that the new URL works. Looks like there are some [settings](https://docs.fastly.com/en/guides/failure-modes-with-large-objects#maximum-object-size-limits) that may resolve this, but this unblocks.\r\n\r\n/lgtm", "created_at": "2023-07-29 02:25:21" }, { "body": "LGTM label has been added. <details>Git tree hash: bc3f6e905879dddb4676cc047940cad248019518</details>", "created_at": "2023-07-29 02:25:28" }, { "body": "/test pull-kubernetes-node-e2e-containerd", "created_at": "2023-07-29 02:49:37" }, { "body": "/test pull-kubernetes-e2e-kind", "created_at": "2023-07-29 02:53:11" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:18:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:18:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:18:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:18:34", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:18:34", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:18:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:18:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:18:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:18:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:18:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:18:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:18:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:18:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:18:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:18:38", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:18:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:20:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:20:18", "type": "unlabeled" }, { "author": "dims", "created_at": "2023-07-29 02:21:31", "type": "unlabeled" }, { "author": "dims", "created_at": "2023-07-29 02:21:31", "type": "labeled" }, { "author": "dims", "created_at": "2023-07-29 02:21:52", "type": "unlabeled" }, { "author": "dims", "created_at": "2023-07-29 02:21:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:23:24", "type": "milestoned" }, { "author": "tzneal", "created_at": "2023-07-29 02:25:25", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 02:25:27", "type": "labeled" }, { "author": "dims", "created_at": "2023-07-29 02:43:34", "type": "mentioned" }, { "author": "dims", "created_at": "2023-07-29 02:43:34", "type": "subscribed" }, { "author": "dims", "created_at": "2023-07-29 02:50:50", "type": "mentioned" }, { "author": "dims", "created_at": "2023-07-29 02:50:51", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 03:27:42", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 03:27:42", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 03:27:42", "type": "closed" } ]

[ "Jefftree" ]

[ "kind/bug", "priority/important-soon", "sig/api-machinery", "kind/regression", "triage/accepted" ]

[ { "body": "/sig api-machinery", "created_at": "2023-07-29 00:00:17" }, { "body": "Something else I also just noticed -- there are no errors or events that pertain to this issue attached to the `APIService` either, which would be useful for debugging if it were.\r\n\r\n```\r\n❯ kubectl describe apiservices.apiregistration.k8s.io v1.allocation.agones.dev\r\nName: v1.allocation.agones.dev\r\nNamespace:\r\nLabels: app=agones\r\n app.kubernetes.io/managed-by=Helm\r\n chart=agones-1.34.0-dev\r\n component=controller\r\n heritage=Helm\r\n release=agones\r\nAnnotations: meta.helm.sh/release-name: agones\r\n meta.helm.sh/release-namespace: agones-system\r\nAPI Version: apiregistration.k8s.io/v1\r\nKind: APIService\r\nMetadata:\r\n Creation Timestamp: 2023-07-28T19:38:30Z\r\n Resource Version: 155113\r\n UID: 03ae8a3a-0100-498e-8429-b09d326f912f\r\nSpec:\r\n Ca Bundle: LS0tLS1CRUdJTiBDRVJUSUZJQ0FURS0tLS0tCk1JSURNRENDQWhpZ0F3SUJBZ0lSQUk5cFB2R3B4QTA5OFUrbm9VeklxWTh3RFFZSktvWklodmNOQVFFTEJRQXcKSWpFZ01CNEdBMVVFQXhNWFlXUnRhWE56YVc5dUxXTnZiblJ5YjJ4c1pYSXRZMkV3SGhjTk1qTXdOekk0TWpNeApNRFF4V2hjTk16TXdOekkxTWpNeE1EUXhXakFpTVNBd0hnWURWUVFERXhkaFpHMXBjM05wYjI0dFkyOXVkSEp2CmJHeGxjaTFqWVRDQ0FTSXdEUVlKS29aSWh2Y05BUUVCQlFBRGdnRVBBRENDQVFvQ2dnRUJBTk83Y3RpREdvN0EKblYzNkdPblkxNW9heTZxNW85QzRxdW9NMVNjeHV3RjNJNFZBTDE2eXJlaFR6UTd0UHdrUUtRSHE4dHRUQXduQgp2NW9Gd25sZmk0UkZkQ3AxcGpMTkRtL3RtaG5IY05yT0czQTQxTUgxaFNralJ1eVJhR2NjbzZVdG9WbUg2d3hpClk3SG50SDRmSEdoVHUrWllFN3YyaU1vTnpkSkpjVy94aGtLUlNaaVk5SGV6TmJUUzNRNS9SQ0I5cEkzMXphYkIKZHkrTjNQMWl3aHc0MHg2MDRsWURIbzRUeTJ5SktkWjhvVjljZ3lPYUgyVDRBKzlZWUkyNFhEZktmcHd0cDU1VApTWlRFVXV1dGN4aVpGQXhwNmZudWo0QytRUC9LdTVNSS9lYnY4bm9iKzUyeGJVdkpyZUNQcHk3Ky9xZkVTbloyCnhEbFd4YWtvVFVjQ0F3RUFBYU5oTUY4d0RnWURWUjBQQVFIL0JBUURBZ0trTUIwR0ExVWRKUVFXTUJRR0NDc0cKQVFVRkJ3TUJCZ2dyQmdFRkJRY0RBakFQQmdOVkhSTUJBZjhFQlRBREFRSC9NQjBHQTFVZERnUVdCQlFSeTYzbgpxOXU4WlpzU09BelIwTDhySXd6L1BEQU5CZ2txaGtpRzl3MEJBUXNGQUFPQ0FRRUFUMlRPNnNreDFyUHVMQWJtClBiaENaYnVYd3g0dVZpK3VkSW53Sm51a0lRSXRlU0twZVl1bHJlVHpOQ0dvWTBkS1NGNjg2OFl0VmpxMElIaXcKenVVV1BDMUMwcFJndXBaclRJMlc1TnF0U3FOdkV4ZWwzQzNWT2hhd2M0S2IrWUtQZ0ZiQjhZTkNJR0xyTVU5bQpjWFJOMTRDMlltd3RWV3loQnQ2eW1WWTlUdW1JZUR4UXZwMkx5UmE0MkJQbCtQQitYMDFpZHVaQUpmMThQdjhYCjgrdnNnR1BXd3kxR2cvbkNUTkR5VlRiVGRhMThIUExNNnlNRUs1RGtvdTVJSllHLzVZQjFFdG9jc1FjUXFLYXIKSWtPTVVRd1YvZ093bEgrRWhPQUxaZjI3dUpQTkNWbDVYQlRMcXJPMmR2cmEzQktNalErZE1HdEpkdHU2b0huNAp3TDI5b1E9PQotLS0tLUVORCBDRVJUSUZJQ0FURS0tLS0tCg==\r\n Group: allocation.agones.dev\r\n Group Priority Minimum: 1000\r\n Service:\r\n Name: agones-controller-service\r\n Namespace: agones-system\r\n Port: 443\r\n Version: v1\r\n Version Priority: 15\r\nStatus:\r\n Conditions:\r\n Last Transition Time: 2023-07-28T23:10:57Z\r\n Message: all checks passed\r\n Reason: Passed\r\n Status: True\r\n Type: Available\r\nEvents: <none>\r\n```", "created_at": "2023-07-29 00:19:21" }, { "body": "Will edit this comment as we go, but just writing down some useful notes:\r\n\r\n- agones should support the `/apis` endpoint: https://github.com/googleforgames/agones/blob/main/pkg/util/apiserver/apiserver.go#L130 so it's weird that a 404 is required\r\n- Aggregated Discovery is fully backwards compatible with previous versions. A fallback https://github.com/kubernetes/kubernetes/blob/v1.27.3/staging/src/k8s.io/kube-aggregator/pkg/apiserver/handler_discovery.go#L231-L233 is implemented so not supporting aggregated discovery on an APIService will fall back to the old behavior (without the `Accept: \"application/json;g=apidiscovery.k8s.io;v=v2beta1;as=APIGroupDiscoveryList\"` accept header)\r\n- The issue brought up https://github.com/googleforgames/agones/issues/3172 is on v1.26.5 in which aggregated discovery is disabled (only enabled for 1.27+)", "created_at": "2023-07-31 18:25:00" }, { "body": "> * Aggregated Discovery is fully backwards compatible with previous versions. A fallback https://github.com/kubernetes/kubernetes/blob/v1.27.3/staging/src/k8s.io/kube-aggregator/pkg/apiserver/handler_discovery.go#L231-L233 is implemented so not supporting aggregated discovery on an APIService will fall back to the old behavior (without the `Accept: \"application/json;g=apidiscovery.k8s.io;v=v2beta1;as=APIGroupDiscoveryList\"` accept header)\r\n\r\nThat assumes the aggregated server is paying attention to the Accept header, and will respond with a NotAcceptable status code if it doesn't support aggregated discovery... that may or may not be true... ways we could make that stronger / more compatible:\r\n1. double check the response content-type\r\n2. send a single request to `/apis` that indicates it accepts BOTH `application/json` and `application/json;g=apidiscovery.k8s.io;v=v2beta1;as=APIGroupDiscoveryList`, and use the content-type in the returned data to decide whether to go down the aggregated or normal discovery path\r\n\r\n\r\n ideally, it would make a single request that indicated it accepted", "created_at": "2023-07-31 18:28:44" }, { "body": "Thanks to an offline chat with @Jefftree - can confirm that returning `HTTP: 406` from `/apis` resolved the issue!\r\n\r\nLong term we'll look at implementing Aggregate Discovery, but this at least gets us past the initial hurdle. Thanks for the support!", "created_at": "2023-07-31 21:26:22" }, { "body": "> Thanks to an offline chat with @Jefftree - can confirm that returning `HTTP: 406` from `/apis` resolved the issue!\r\n\r\nto be clear, this is returning a 406 to requests that don't accept `application/json`, right?", "created_at": "2023-07-31 21:28:49" }, { "body": "Honestly, I just did this:\r\n\r\n```\r\n\t// We don't currently support a root /apis, but since Aggregate Discovery expects\r\n\t// a 406, let's give it what it wants, otherwise namespaces don't successfully terminate.\r\n\tmux.HandleFunc(\"/apis\", func(w http.ResponseWriter, r *http.Request) {\r\n\t\tw.WriteHeader(http.StatusNotAcceptable)\r\n\t\tw.Header().Set(ContentTypeHeader, k8sruntime.ContentTypeJSON)\r\n\t})\r\n```\r\n\r\nOn Agones while we return results on `/apis/{groupversion}` and below, we've never actually implemented a response to root level `/apis` ever, and up until this point haven't had a need to.", "created_at": "2023-07-31 21:56:57" }, { "body": "ah, right... the non-aggregated discovery calls directly to `/apis/$group/$version`\r\n\r\n@Jefftree to be actually compatible, I think the \"success case\" for aggregated discovery should check that the status code is `200` and the returned content is actually aggregated discovery json, and if either of those are false, it should fall back to non-aggregated discovery.", "created_at": "2023-07-31 22:09:57" }, { "body": "> ah, right... the non-aggregated discovery calls directly to `/apis/$group/$version`\r\n> \r\n> @Jefftree to be actually compatible, I think the \"success case\" for aggregated discovery should check that the status code is `200` and the returned content-type is aggregated discovery json, and if either of those are false, it should fall back to non-aggregated discovery.\r\n\r\nYeah I agree, we made a couple assumptions based on the sample apiserver that could be improved for stronger compatibility guarantees. Will look into sending a PR for this once code freeze is over.\r\n\r\n/triage accepted\r\n/assign", "created_at": "2023-08-01 16:26:59" }, { "body": "> Yeah I agree, we made a couple assumptions based on the sample apiserver that could be improved for stronger compatibility guarantees. Will look into sending a PR for this once code freeze is over.\r\n\r\nif possible, let's get that open for review earlier, and craft it to be as minimal a change as possible, since I assume we'll backport it to 1.28 and 1.27", "created_at": "2023-08-01 16:28:10" }, { "body": "Thanks for the quick response - sounds like a reasonable fix to me (for what that's worth 😃).\r\n\r\nI'm definitely here for odd K8s bug reports 😁 ", "created_at": "2023-08-01 17:38:05" }, { "body": "@Jefftree do you have an ETA for a fix implementing https://github.com/kubernetes/kubernetes/issues/119662#issuecomment-1659257581 ?", "created_at": "2023-08-09 15:20:27" }, { "body": "Oh yes, have an implementation and was working on the tests. Will send it out today", "created_at": "2023-08-09 15:51:58" } ]

[ { "author": "markmandel", "created_at": "2023-07-28 23:51:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 23:51:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 23:51:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 00:00:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 00:00:20", "type": "unlabeled" }, { "author": "Jefftree", "created_at": "2023-07-31 21:26:23", "type": "mentioned" }, { "author": "Jefftree", "created_at": "2023-07-31 21:26:23", "type": "subscribed" }, { "author": "Jefftree", "created_at": "2023-07-31 21:28:49", "type": "mentioned" }, { "author": "Jefftree", "created_at": "2023-07-31 21:28:49", "type": "subscribed" }, { "author": "Jefftree", "created_at": "2023-07-31 22:09:58", "type": "mentioned" }, { "author": "Jefftree", "created_at": "2023-07-31 22:09:58", "type": "subscribed" }, { "author": "markmandel", "created_at": "2023-07-31 22:54:35", "type": "referenced" }, { "author": "roberthbailey", "created_at": "2023-08-01 00:57:38", "type": "referenced" }, { "author": "Jefftree", "created_at": "2023-08-01 16:26:59", "type": "mentioned" }, { "author": "Jefftree", "created_at": "2023-08-01 16:26:59", "type": "subscribed" }, { "author": "Jefftree", "created_at": "2023-08-01 16:27:00", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 16:27:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 16:27:02", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-09 15:04:39", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-08-09 15:04:40", "type": "labeled" }, { "author": "Jefftree", "created_at": "2023-08-09 15:20:27", "type": "mentioned" }, { "author": "Jefftree", "created_at": "2023-08-09 15:20:27", "type": "subscribed" } ]

[ "dims", "mrunalp", "sttts", "liggitt", "aojea", "deads2k", "SergeyKanzhelev", "wojtek-t" ]

[ "kind/bug", "priority/important-soon", "lgtm", "sig/node", "sig/api-machinery", "size/M", "release-note-none", "approved", "cncf-cla: yes", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Jul 28 22:12:27 UTC 2023.\n", "created_at": "2023-07-28 22:14:19" }, { "body": "this only modifies the test, it seems WIP", "created_at": "2023-07-28 23:32:39" }, { "body": "/retest", "created_at": "2023-07-29 00:29:14" }, { "body": "/test pull-kubernetes-e2e-gce", "created_at": "2023-07-29 03:48:11" }, { "body": "/retest\r\n/release-note-none", "created_at": "2023-07-29 18:13:37" }, { "body": "/priority important-soon\r\n/triage accepted\r\n/assign @mrunalp @SergeyKanzhelev ", "created_at": "2023-07-29 18:14:39" }, { "body": "FYI, I've gone through the history and haven't found discussion on why these errors did not block the lease update. Initially added here: https://github.com/kubernetes/kubernetes/pull/70034/files#diff-53e6af5b2caffee205409a79f563db9456102ad124ec18a3de6d98553194c406R194", "created_at": "2023-07-29 21:36:16" }, { "body": "There was a previous attempt to fix this that stalled: https://github.com/kubernetes/kubernetes/pull/110834\r\n\r\nI think the approach taken in that PR has issues.", "created_at": "2023-07-31 16:35:47" }, { "body": "/sig node\r\n\r\nThis is apimachinery for *reasons*, but it's kubelet-critical functionality", "created_at": "2023-07-31 22:54:09" }, { "body": "/assign @wojtek-t @liggitt ", "created_at": "2023-08-01 16:58:35" }, { "body": "/lgtm\r\n\r\nI agree with the author that is difficult to understand that if we fail to create a newLease we still want to use it to Update the existing one. Assigning people in the original PR, maybe they have more context https://github.com/kubernetes/kubernetes/pull/119661/files#r1283162922\r\n\r\n/assign @wojtek-t @deads2k @sttts \r\n\r\n", "created_at": "2023-08-03 12:58:48" }, { "body": "LGTM label has been added. <details>Git tree hash: 03ea88ffdf34a90b80fa022c32aad9abb66198cd</details>", "created_at": "2023-08-03 12:58:56" }, { "body": "/approve\r\n/lgtm\r\n\r\nThis one spans across areas I am happy with the review/engagement it has gotten so far and it looks good to me.", "created_at": "2023-08-21 17:07:46" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119661#\" title=\"Author self-approved\">cartermckinnon</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119661#issuecomment-1686715906\" title=\"LGTM\">dims</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/component-helpers/apimachinery/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/component-helpers/apimachinery/OWNERS)~~ [dims]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-21 17:08:12" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 22:14:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 22:14:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 22:14:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 22:14:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 22:14:20", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 22:14:20", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 22:14:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 22:14:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 22:14:23", "type": "labeled" }, { "author": "cartermckinnon", "created_at": "2023-07-28 22:15:36", "type": "renamed" }, { "author": "cartermckinnon", "created_at": "2023-07-28 22:52:35", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-07-28 22:52:35", "type": "subscribed" }, { "author": "cartermckinnon", "created_at": "2023-07-28 22:52:52", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-07-28 22:52:52", "type": "subscribed" }, { "author": "cartermckinnon", "created_at": "2023-07-28 22:58:06", "type": "head_ref_force_pushed" }, { "author": "cartermckinnon", "created_at": "2023-07-28 23:00:16", "type": "head_ref_force_pushed" }, { "author": "cartermckinnon", "created_at": "2023-07-28 23:22:15", "type": "head_ref_force_pushed" }, { "author": "cartermckinnon", "created_at": "2023-07-28 23:29:47", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 23:29:48", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 23:29:49", "type": "labeled" }, { "author": "cartermckinnon", "created_at": "2023-07-28 23:36:47", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 23:36:49", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 23:36:50", "type": "labeled" }, { "author": "cartermckinnon", "created_at": "2023-07-28 23:45:36", "type": "head_ref_force_pushed" }, { "author": "cartermckinnon", "created_at": "2023-07-29 00:17:16", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-07-29 00:17:16", "type": "subscribed" }, { "author": "cartermckinnon", "created_at": "2023-07-29 00:23:55", "type": "head_ref_force_pushed" }, { "author": "cartermckinnon", "created_at": "2023-07-29 00:23:57", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-07-29 00:23:57", "type": "subscribed" }, { "author": "cartermckinnon", "created_at": "2023-07-29 01:02:47", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-07-29 01:02:47", "type": "subscribed" }, { "author": "cartermckinnon", "created_at": "2023-07-29 04:45:05", "type": "mentioned" }, { "author": "cartermckinnon", "created_at": "2023-07-29 04:45:05", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:13:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:13:40", "type": "unlabeled" }, { "author": "mrunalp", "created_at": "2023-07-29 18:14:39", "type": "mentioned" }, { "author": "mrunalp", "created_at": "2023-07-29 18:14:39", "type": "subscribed" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-29 18:14:40", "type": "mentioned" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-29 18:14:40", "type": "subscribed" }, { "author": "mrunalp", "created_at": "2023-07-29 18:14:41", "type": "assigned" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-29 18:14:41", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:14:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:14:42", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:14:43", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 18:14:43", "type": "unlabeled" }, { "author": "cartermckinnon", "created_at": "2023-07-29 21:29:40", "type": "head_ref_force_pushed" }, { "author": "cartermckinnon", "created_at": "2023-07-29 22:42:32", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 22:54:11", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-08-01 16:58:35", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-01 16:58:35", "type": "subscribed" }, { "author": "wojtek-t", "created_at": "2023-08-01 16:58:35", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-08-01 16:58:35", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-01 16:58:37", "type": "assigned" }, { "author": "wojtek-t", "created_at": "2023-08-01 16:58:37", "type": "assigned" }, { "author": "sttts", "created_at": "2023-08-03 12:58:48", "type": "mentioned" }, { "author": "sttts", "created_at": "2023-08-03 12:58:48", "type": "subscribed" }, { "author": "deads2k", "created_at": "2023-08-03 12:58:48", "type": "mentioned" }, { "author": "deads2k", "created_at": "2023-08-03 12:58:48", "type": "subscribed" }, { "author": "wojtek-t", "created_at": "2023-08-03 12:58:49", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-08-03 12:58:49", "type": "subscribed" }, { "author": "deads2k", "created_at": "2023-08-03 12:58:49", "type": "assigned" }, { "author": "sttts", "created_at": "2023-08-03 12:58:50", "type": "assigned" }, { "author": "aojea", "created_at": "2023-08-03 12:58:53", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 12:58:54", "type": "labeled" }, { "author": "cartermckinnon", "created_at": "2023-08-04 20:02:15", "type": "review_requested" }, { "author": "dims", "created_at": "2023-08-21 17:07:51", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-21 17:08:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-21 18:09:23", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-21 18:09:23", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-21 18:09:23", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-21 18:09:25", "type": "milestoned" } ]

[]

[ "kind/bug", "sig/node", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 21:08:46" }, { "body": "/sig node\r\n/priority important-soon\r\n/triage accepted", "created_at": "2023-07-28 21:23:44" }, { "body": "@dims: The label(s) `triage/important-soon` cannot be applied, because the repository doesn't have them.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119660#issuecomment-1656348545):\n\n>/sig node\r\n>/triage important-soon\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 21:23:46" }, { "body": "In this particular case, kubelet should fail to set the lease owner and return this error: https://github.com/kubernetes/kubernetes/blob/dad95e1be65d4e74d33c810f4395596a22115717/pkg/kubelet/util/nodelease.go#L49-L50\r\n\r\nFix looks fairly straightforward, I'll do a sanity check and put up a PR.", "created_at": "2023-07-28 21:43:15" }, { "body": "Hi,\r\n\r\nThis seems pretty much like https://github.com/kubernetes/kubernetes/issues/109777, right?", "created_at": "2023-07-31 10:32:37" }, { "body": "Yep! Looks like a fix was attempted in #110834 but it was never merged.", "created_at": "2023-07-31 15:33:42" }, { "body": "> Yep! Looks like a fix was attempted in https://github.com/kubernetes/kubernetes/pull/110834 but it was never merged.\r\n\r\nAck, lets close this then given its a duplicate of https://github.com/kubernetes/kubernetes/issues/109777.\r\n\r\nThanks\r\n\r\n/close ", "created_at": "2023-07-31 15:35:15" }, { "body": "@odinuge: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119660#issuecomment-1658614315):\n\n>> Yep! Looks like a fix was attempted in https://github.com/kubernetes/kubernetes/pull/110834 but it was never merged.\r\n>\r\n>Ack, lets close this then given its a duplicate of https://github.com/kubernetes/kubernetes/issues/109777.\r\n>\r\n>Thanks\r\n>\r\n>/close \n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-31 15:35:21" } ]

[ { "author": "josselin-c", "created_at": "2023-07-28 21:08:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 21:08:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 21:08:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 21:23:46", "type": "labeled" }, { "author": "dims", "created_at": "2023-07-28 21:23:47", "type": "mentioned" }, { "author": "dims", "created_at": "2023-07-28 21:23:47", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 21:23:47", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:35:20", "type": "closed" }, { "author": "odinuge", "created_at": "2023-07-31 15:35:22", "type": "mentioned" }, { "author": "odinuge", "created_at": "2023-07-31 15:35:22", "type": "subscribed" } ]

[ "ddebroy" ]

[ "area/test", "area/kubelet", "sig/node", "release-note", "size/M", "kind/api-change", "kind/feature", "cncf-cla: yes", "sig/testing", "priority/important-longterm", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Jul 28 16:11:31 UTC 2023.\n", "created_at": "2023-07-28 20:59:43" }, { "body": "Just putting this up as its fresh in my head what is required for this KEP for 1.29. ", "created_at": "2023-07-28 21:02:44" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119659#\" title=\"Author self-approved\">kannon92</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [mrunalp](https://github.com/mrunalp), [smarterclayton](https://github.com/smarterclayton) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/features/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/features/OWNERS)**\n- **[pkg/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/OWNERS)**\n- **[staging/src/k8s.io/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/OWNERS)**\n- **[test/e2e_node/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"mrunalp\",\"smarterclayton\"]} -->", "created_at": "2023-07-28 21:19:07" }, { "body": "/retest", "created_at": "2023-07-29 01:04:10" }, { "body": "/retest", "created_at": "2023-07-30 12:24:52" }, { "body": "/triage accepted\r\n/priority important-longterm\r\n/assign @ddebroy \r\n(as he is a contributor to this feature)\r\n\r\nPlease raise this with SIG node to ensure that this work is tracked for 1.29. 1.29 planning hasn't started yet but there is likely to be a discussion soon. Keep an eye on the SIG node agenda doc and the [planning doc](https://docs.google.com/document/d/1U10J0WwgWXkdYrqWGGvO8iH2HKeerQAlygnqgDgWv4E/edit#heading=h.dlygkubo4ruw).", "created_at": "2023-07-31 10:31:41" }, { "body": "/retest", "created_at": "2023-07-31 11:23:58" }, { "body": "> /triage accepted /priority important-longterm /assign @ddebroy (as he is a contributor to this feature)\r\n> \r\n> Please raise this with SIG node to ensure that this work is tracked for 1.29. 1.29 planning hasn't started yet but there is likely to be a discussion soon. Keep an eye on the SIG node agenda doc and the [planning doc](https://docs.google.com/document/d/1U10J0WwgWXkdYrqWGGvO8iH2HKeerQAlygnqgDgWv4E/edit#heading=h.dlygkubo4ruw).\r\n\r\nThank you @swatisehgal. I will bring this up to sig-node. ", "created_at": "2023-07-31 13:17:56" }, { "body": "hey @ndixita why was this moved to Archive-it?", "created_at": "2023-08-19 20:19:04" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 20:59:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 20:59:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 20:59:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 20:59:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 20:59:44", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 20:59:44", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 20:59:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 20:59:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 20:59:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 20:59:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 20:59:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 20:59:47", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 20:59:48", "type": "labeled" }, { "author": "kannon92", "created_at": "2023-07-28 21:01:11", "type": "head_ref_force_pushed" }, { "author": "kannon92", "created_at": "2023-07-28 21:09:47", "type": "mentioned" }, { "author": "kannon92", "created_at": "2023-07-28 21:09:48", "type": "subscribed" }, { "author": "kannon92", "created_at": "2023-07-28 21:14:03", "type": "head_ref_force_pushed" }, { "author": "kannon92", "created_at": "2023-07-28 21:14:18", "type": "mentioned" }, { "author": "kannon92", "created_at": "2023-07-28 21:14:18", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 21:19:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 21:19:07", "type": "labeled" }, { "author": "kannon92", "created_at": "2023-07-28 21:22:04", "type": "mentioned" }, { "author": "kannon92", "created_at": "2023-07-28 21:22:04", "type": "subscribed" }, { "author": "kannon92", "created_at": "2023-07-28 21:27:53", "type": "head_ref_force_pushed" }, { "author": "kannon92", "created_at": "2023-07-28 21:54:26", "type": "mentioned" }, { "author": "kannon92", "created_at": "2023-07-28 21:54:26", "type": "subscribed" }, { "author": "kannon92", "created_at": "2023-07-28 22:06:30", "type": "mentioned" }, { "author": "kannon92", "created_at": "2023-07-28 22:06:30", "type": "subscribed" }, { "author": "kannon92", "created_at": "2023-07-28 22:06:56", "type": "mentioned" }, { "author": "kannon92", "created_at": "2023-07-28 22:06:57", "type": "subscribed" }, { "author": "kannon92", "created_at": "2023-07-29 01:41:29", "type": "mentioned" }, { "author": "kannon92", "created_at": "2023-07-29 01:41:29", "type": "subscribed" }, { "author": "kannon92", "created_at": "2023-07-29 01:44:08", "type": "mentioned" }, { "author": "kannon92", "created_at": "2023-07-29 01:44:08", "type": "subscribed" }, { "author": "kannon92", "created_at": "2023-07-30 13:33:44", "type": "mentioned" }, { "author": "kannon92", "created_at": "2023-07-30 13:33:44", "type": "subscribed" }, { "author": "ddebroy", "created_at": "2023-07-31 10:31:41", "type": "mentioned" }, { "author": "ddebroy", "created_at": "2023-07-31 10:31:41", "type": "subscribed" }, { "author": "ddebroy", "created_at": "2023-07-31 10:31:42", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:31:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:31:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:31:44", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:31:45", "type": "unlabeled" }, { "author": "swatisehgal", "created_at": "2023-07-31 13:17:56", "type": "mentioned" }, { "author": "swatisehgal", "created_at": "2023-07-31 13:17:56", "type": "subscribed" }, { "author": "ddebroy", "created_at": "2023-07-31 13:17:56", "type": "mentioned" }, { "author": "ddebroy", "created_at": "2023-07-31 13:17:56", "type": "subscribed" }, { "author": "ndixita", "created_at": "2023-08-19 20:19:04", "type": "mentioned" }, { "author": "ndixita", "created_at": "2023-08-19 20:19:04", "type": "subscribed" } ]

[ "pohly" ]

[ "sig/scheduling", "sig/api-machinery", "kind/feature", "sig/apps", "triage/accepted" ]

[ { "body": "/cc @alculquicondor ", "created_at": "2023-07-28 19:24:19" }, { "body": "/sig api-machinery", "created_at": "2023-07-28 19:27:08" }, { "body": "/sig scheduling\r\n/sig apps", "created_at": "2023-07-28 19:27:27" }, { "body": "/assign @pohly \r\n/triage accepted", "created_at": "2023-08-03 16:48:27" } ]

[ { "author": "linxiulei", "created_at": "2023-07-28 19:23:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 19:23:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 19:23:56", "type": "labeled" }, { "author": "alculquicondor", "created_at": "2023-07-28 19:24:19", "type": "mentioned" }, { "author": "alculquicondor", "created_at": "2023-07-28 19:24:19", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 19:27:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 19:27:11", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 19:27:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 19:27:30", "type": "labeled" }, { "author": "pohly", "created_at": "2023-08-03 16:48:27", "type": "mentioned" }, { "author": "pohly", "created_at": "2023-08-03 16:48:27", "type": "subscribed" }, { "author": "pohly", "created_at": "2023-08-03 16:48:28", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:48:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:48:30", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 10:25:35", "type": "closed" } ]

[]

[ "kind/support", "needs-sig", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nSIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the `triage/accepted` label.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 16:31:17" }, { "body": "@gourik22 It seems like you're seeking assistance rather than pointing out any inaccuracies in our documentation. While we appreciate your query, the GitHub issue tracker may not be the best platform to seek advice on Kubernetes. Instead, I suggest exploring other resources like the Kubernetes Slack (http://slack.k8s.io/) or the Discuss Kubernetes (https://discuss.kubernetes.io/) forum for the help you require.\r\n\r\n(Refer: https://github.com/kubernetes/kubernetes/blob/master/SUPPORT.md)", "created_at": "2023-07-28 16:43:21" }, { "body": "> I am trying to implement Keda scaling in listener containers. Noticed that container is accepting new requests at termination period. Is there any way to close the RabbitMQ connection in termination period without breaking the current process?\r\n\r\nThanks", "created_at": "2023-07-28 16:49:16" }, { "body": "/retitle Need assistance with implementing KEDA autoscaling\r\n/kind support", "created_at": "2023-07-28 16:55:18" }, { "body": "/transfer kubernetes\r\n", "created_at": "2023-07-30 21:25:49" }, { "body": "There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:\n- `/sig <group-name>`\n- `/wg <group-name>`\n- `/committee <group-name>`\n\nPlease see the [group list](https://git.k8s.io/community/sig-list.md) for a listing of the SIGs, working groups, and committees available.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-30 21:25:57" }, { "body": "GitHub is the wrong place to ask for assistance around using Kubernetes and related projects.\r\n\r\nhttps://github.com/kubernetes/kubernetes/issues/119683#issuecomment-1657270143\r\n\r\n/close not-planned", "created_at": "2023-07-30 21:26:51" }, { "body": "@sftim: Closing this issue, marking it as \"Not Planned\".\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119683#issuecomment-1657270329):\n\n>GitHub is the wrong place to ask for assistance around using Kubernetes and related projects.\r\n>\r\n>https://github.com/kubernetes/kubernetes/issues/119683#issuecomment-1657270143\r\n>\r\n>/close not-planned\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-30 21:26:56" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 16:31:16", "type": "labeled" }, { "author": "gourik22", "created_at": "2023-07-28 16:43:21", "type": "mentioned" }, { "author": "gourik22", "created_at": "2023-07-28 16:43:21", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 16:55:20", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 16:55:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 21:25:52", "type": "transferred" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 21:25:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 21:26:56", "type": "closed" }, { "author": "sftim", "created_at": "2023-07-30 21:26:56", "type": "mentioned" }, { "author": "sftim", "created_at": "2023-07-30 21:26:56", "type": "subscribed" } ]

[]

[ "area/test", "sig/cluster-lifecycle", "size/L", "kind/feature", "release-note-none", "sig/auth", "area/kubeadm", "cncf-cla: yes", "sig/testing", "do-not-merge/hold", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Jul 28 10:11:44 UTC 2023.\n", "created_at": "2023-07-28 14:02:27" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 14:02:32" }, { "body": "/cc @reylejano ", "created_at": "2023-07-28 14:03:04" }, { "body": "/retest", "created_at": "2023-07-28 15:08:15" }, { "body": "/retest", "created_at": "2023-07-29 03:03:30" }, { "body": "/retest", "created_at": "2023-07-29 09:05:16" }, { "body": "/retest", "created_at": "2023-07-29 14:44:58" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119657#\" title=\"Author self-approved\">charles-chenzz</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [liggitt](https://github.com/liggitt), [neolit123](https://github.com/neolit123) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[cmd/kubeadm/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/OWNERS)**\n- **[plugin/pkg/auth/authenticator/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/plugin/pkg/auth/authenticator/OWNERS)**\n- **[staging/src/k8s.io/cluster-bootstrap/token/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/cluster-bootstrap/token/OWNERS)**\n- **[test/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"liggitt\",\"neolit123\"]} -->", "created_at": "2023-07-30 06:32:04" }, { "body": "/retest", "created_at": "2023-07-30 06:32:53" }, { "body": "/retest-required", "created_at": "2023-07-31 10:05:47" }, { "body": "@charles-chenzz: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-conformance-kind-ipv6-parallel | 939ada161092eaacf60be01fe45c54ca1924f7dc | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119657/pull-kubernetes-conformance-kind-ipv6-parallel/1685898953020674048) | false | `/test pull-kubernetes-conformance-kind-ipv6-parallel`\npull-kubernetes-e2e-kind | 939ada161092eaacf60be01fe45c54ca1924f7dc | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119657/pull-kubernetes-e2e-kind/1685954911637868544) | true | `/test pull-kubernetes-e2e-kind`\npull-kubernetes-e2e-kind-ipv6 | 939ada161092eaacf60be01fe45c54ca1924f7dc | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119657/pull-kubernetes-e2e-kind-ipv6/1685954911684005888) | true | `/test pull-kubernetes-e2e-kind-ipv6`\npull-kubernetes-conformance-kind-ga-only-parallel | 939ada161092eaacf60be01fe45c54ca1924f7dc | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119657/pull-kubernetes-conformance-kind-ga-only-parallel/1685954911738531840) | true | `/test pull-kubernetes-conformance-kind-ga-only-parallel`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119657). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Acharles-chenzz). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-07-31 10:23:50" }, { "body": "don't know why the e2e-kind failed, might need some help", "created_at": "2023-07-31 10:58:49" }, { "body": "/hold\r\n\r\nthis breaks backwards compatibility with existing validation / users of the bootstrap tokens", "created_at": "2023-08-01 15:45:26" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 14:02:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 14:02:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 14:02:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 14:02:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 14:02:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 14:02:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 14:02:33", "type": "labeled" }, { "author": "reylejano", "created_at": "2023-07-28 14:03:05", "type": "mentioned" }, { "author": "reylejano", "created_at": "2023-07-28 14:03:05", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 14:03:06", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 14:03:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 14:03:09", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 14:03:19", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 14:03:20", "type": "review_requested" }, { "author": "charles-chenzz", "created_at": "2023-07-28 14:07:04", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-28 14:07:04", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-28 14:14:29", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-28 14:14:29", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-28 14:14:43", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-28 14:14:43", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-28 14:15:24", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-28 14:15:24", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-28 14:20:54", "type": "convert_to_draft" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 14:20:56", "type": "labeled" }, { "author": "charles-chenzz", "created_at": "2023-07-28 15:12:21", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-28 15:12:21", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-28 15:18:16", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-28 15:18:16", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-28 15:18:24", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-28 15:18:24", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-28 15:20:12", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-28 15:20:12", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-28 15:52:14", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-28 15:52:14", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-29 02:20:24", "type": "head_ref_force_pushed" }, { "author": "charles-chenzz", "created_at": "2023-07-29 03:09:45", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-29 03:09:45", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-29 03:25:57", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-29 03:25:57", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-29 03:25:59", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-29 03:25:59", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-29 03:26:00", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-29 03:26:00", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-29 03:43:57", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-29 03:43:57", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-29 03:44:52", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-29 03:44:52", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 09:04:49", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 09:04:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 09:09:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 09:09:32", "type": "labeled" }, { "author": "charles-chenzz", "created_at": "2023-07-29 09:22:39", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-29 09:22:39", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-29 09:23:23", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-29 09:23:23", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-29 09:25:01", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-29 09:25:01", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-29 09:44:19", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-29 09:44:19", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-29 10:05:24", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-29 10:05:25", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-29 14:42:59", "type": "head_ref_force_pushed" }, { "author": "charles-chenzz", "created_at": "2023-07-29 14:58:00", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-29 14:58:00", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-29 15:03:03", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-29 15:03:03", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-29 15:05:20", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-29 15:05:20", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-29 15:22:59", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-29 15:23:00", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-29 15:45:31", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-29 15:45:31", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-30 06:31:58", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 06:32:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 06:32:05", "type": "labeled" }, { "author": "charles-chenzz", "created_at": "2023-07-30 06:46:52", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-30 06:46:52", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-30 06:48:50", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-30 06:48:50", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-30 06:49:47", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-30 06:49:47", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-30 06:50:06", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-30 06:50:06", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-31 06:23:25", "type": "ready_for_review" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 06:23:27", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 06:23:44", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 06:23:44", "type": "review_requested" }, { "author": "charles-chenzz", "created_at": "2023-07-31 06:39:59", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-31 06:39:59", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-31 06:40:07", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-31 06:40:07", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-31 06:42:31", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-31 06:42:31", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-31 06:42:49", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-31 06:42:50", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-31 06:51:30", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-31 06:51:30", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-31 07:08:24", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-31 07:08:25", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-31 10:20:36", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-31 10:20:36", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-31 10:22:45", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-31 10:22:45", "type": "subscribed" }, { "author": "charles-chenzz", "created_at": "2023-07-31 10:23:51", "type": "mentioned" }, { "author": "charles-chenzz", "created_at": "2023-07-31 10:23:51", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 15:45:27", "type": "labeled" } ]

[]

[ "kind/bug", "sig/network", "area/kube-proxy", "area/ipvs", "triage/accepted" ]

[ { "body": "wanted to work on this \r\n", "created_at": "2023-07-28 11:58:47" }, { "body": "@kushalShukla-web Great! But please coordinate with https://github.com/kubernetes/kubernetes/issues/119524. I hope that one get accepted, and then ~the `nodeIP`s (both families) passed to the proxiers should be usable.~ No, they are not, please see https://github.com/kubernetes/kubernetes/issues/119656#issuecomment-1664290331", "created_at": "2023-07-28 12:45:54" }, { "body": "Discussed this one in the SIG Network meeting today: we agree this is something we'd like to implement, however we weren't sure exactly how to do it with ipvs during the meeting. Whoever takes this on needs to come up with and communicate a clear plan of _how_ it will be accomplished.\r\n\r\n/triage accepted", "created_at": "2023-08-03 16:22:11" }, { "body": "@kushalShukla-web My comment https://github.com/kubernetes/kubernetes/issues/119656#issuecomment-1655630007 is not feasible. For proxy-mode=ipvs the src and dst is _both_ loadBalancerIP. So the nodeIP will not help :disappointed: ", "created_at": "2023-08-03 16:31:15" }, { "body": "@uablrek I did a small experimented with kind + metallb. \r\n\r\nI created a loadbalancer service backed by [whoami pods](https://github.com/traefik/whoami).\r\n\r\nloadBalancerIP: 172.18.255.200\r\npodIP: 10.244.1.3\r\n\r\nconntrack picks the src and dst both as loadBalancerIP.\r\n`tcp 6 115 TIME_WAIT src=172.18.255.200 dst=172.18.255.200 sport=44936 dport=80 src=10.244.1.3 dst=10.244.1.1 sport=80 dport=6952 [ASSURED] mark=0 use=1`\r\n\r\nTried to create an iptables rules matching source and destination with loadbalancerIP to drop packets but it didn't work.\r\n\r\nAfter some exploration I found [ipvs match extension for iptables](https://manpages.ubuntu.com/manpages/xenial/man8/iptables-extensions.8.html#:~:text=to%20prot.-,ipvs,-Match%20IPVS%20connection) and with the following rules I was able to prevent access to lbIP from k8s nodes / host network.\r\n\r\n```iptables -t filter -A OUTPUT -s 172.18.255.200 -m ipvs --vaddr 172.18.255.200 --vport 80 --vproto tcp -j DROP```\r\n\r\nThe solution looks hacky though, we only need this rule if source ranges are defined for the service and node ip is not covered by any of them.\r\nWill try to program this in the ipvs proxier.\r\n", "created_at": "2023-08-06 09:38:54" }, { "body": "Good find! :+1: I had missed the ipvs extension. I started to check nodeIP and the (flawed) `--bind-address` option to experiment with setting a nodeIP as \"src\" for some routes to dodge the lbip-both-as-src-and-dst problem, and an old \"vision\" I have to **not** assign clusterIPs to `kube-ipvs0` at all, but have *one* rule to replace them all, like:\r\n\r\n```\r\nip route add local <ClusterIP-CIDR> dev kube-ipvs0 scope host src <node-ip>\r\n```\r\nIt *can* be done, and in a cluster with 1000's of clusterIP's it would simplify", "created_at": "2023-08-06 10:06:22" } ]

[ { "author": "uablrek", "created_at": "2023-07-28 11:06:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 11:06:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 11:06:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 11:06:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 11:06:59", "type": "labeled" }, { "author": "kushalShukla-web", "created_at": "2023-07-28 12:45:55", "type": "mentioned" }, { "author": "kushalShukla-web", "created_at": "2023-07-28 12:45:55", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:22:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:22:14", "type": "unlabeled" }, { "author": "kushalShukla-web", "created_at": "2023-08-03 16:31:15", "type": "mentioned" }, { "author": "kushalShukla-web", "created_at": "2023-08-03 16:31:15", "type": "subscribed" }, { "author": "uablrek", "created_at": "2023-08-06 09:38:55", "type": "mentioned" }, { "author": "uablrek", "created_at": "2023-08-06 09:38:55", "type": "subscribed" } ]

[ "bart0sh" ]

[ "priority/backlog", "area/kubelet", "kind/cleanup", "lgtm", "sig/node", "size/XS", "release-note-none", "cncf-cla: yes", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Jul 28 10:11:44 UTC 2023.\n", "created_at": "2023-07-28 10:56:06" }, { "body": "/test?", "created_at": "2023-07-28 10:56:15" }, { "body": "@swatisehgal: The following commands are available to trigger required jobs:\n* `/test pull-cadvisor-e2e-kubernetes`\n* `/test pull-kubernetes-conformance-kind-ga-only-parallel`\n* `/test pull-kubernetes-coverage-unit`\n* `/test pull-kubernetes-dependencies`\n* `/test pull-kubernetes-dependencies-go-canary`\n* `/test pull-kubernetes-e2e-gce`\n* `/test pull-kubernetes-e2e-gce-100-performance`\n* `/test pull-kubernetes-e2e-gce-big-performance`\n* `/test pull-kubernetes-e2e-gce-canary`\n* `/test pull-kubernetes-e2e-gce-cos`\n* `/test pull-kubernetes-e2e-gce-cos-canary`\n* `/test pull-kubernetes-e2e-gce-cos-no-stage`\n* `/test pull-kubernetes-e2e-gce-network-proxy-http-connect`\n* `/test pull-kubernetes-e2e-gce-scale-performance-manual`\n* `/test pull-kubernetes-e2e-kind`\n* `/test pull-kubernetes-e2e-kind-ipv6`\n* `/test pull-kubernetes-integration`\n* `/test pull-kubernetes-integration-go-canary`\n* `/test pull-kubernetes-kubemark-e2e-gce-scale`\n* `/test pull-kubernetes-node-e2e-containerd`\n* `/test pull-kubernetes-typecheck`\n* `/test pull-kubernetes-unit`\n* `/test pull-kubernetes-unit-go-canary`\n* `/test pull-kubernetes-update`\n* `/test pull-kubernetes-verify`\n* `/test pull-kubernetes-verify-go-canary`\n\nThe following commands are available to trigger optional jobs:\n* `/test check-dependency-stats`\n* `/test pull-ci-kubernetes-unit-windows`\n* `/test pull-e2e-gce-cloud-provider-disabled`\n* `/test pull-kubernetes-conformance-image-test`\n* `/test pull-kubernetes-conformance-kind-ga-only`\n* `/test pull-kubernetes-conformance-kind-ipv6-parallel`\n* `/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e`\n* `/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e-features`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-eviction`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-features`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-serial`\n* `/test pull-kubernetes-cross`\n* `/test pull-kubernetes-e2e-autoscaling-hpa-cm`\n* `/test pull-kubernetes-e2e-autoscaling-hpa-cpu`\n* `/test pull-kubernetes-e2e-capz-azure-disk`\n* `/test pull-kubernetes-e2e-capz-azure-disk-vmss`\n* `/test pull-kubernetes-e2e-capz-azure-file`\n* `/test pull-kubernetes-e2e-capz-azure-file-vmss`\n* `/test pull-kubernetes-e2e-capz-conformance`\n* `/test pull-kubernetes-e2e-capz-windows`\n* `/test pull-kubernetes-e2e-capz-windows-alpha-feature-vpa`\n* `/test pull-kubernetes-e2e-capz-windows-alpha-features`\n* `/test pull-kubernetes-e2e-capz-windows-serial-slow-hpa`\n* `/test pull-kubernetes-e2e-containerd-gce`\n* `/test pull-kubernetes-e2e-gce-correctness`\n* `/test pull-kubernetes-e2e-gce-cos-alpha-features`\n* `/test pull-kubernetes-e2e-gce-cos-kubetest2`\n* `/test pull-kubernetes-e2e-gce-csi-serial`\n* `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\n* `/test pull-kubernetes-e2e-gce-kubelet-credential-provider`\n* `/test pull-kubernetes-e2e-gce-network-proxy-grpc`\n* `/test pull-kubernetes-e2e-gce-serial`\n* `/test pull-kubernetes-e2e-gce-storage-disruptive`\n* `/test pull-kubernetes-e2e-gce-storage-slow`\n* `/test pull-kubernetes-e2e-gce-storage-snapshot`\n* `/test pull-kubernetes-e2e-gci-gce-autoscaling`\n* `/test pull-kubernetes-e2e-gci-gce-ingress`\n* `/test pull-kubernetes-e2e-gci-gce-ipvs`\n* `/test pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2`\n* `/test pull-kubernetes-e2e-kind-alpha-features`\n* `/test pull-kubernetes-e2e-kind-canary`\n* `/test pull-kubernetes-e2e-kind-dual-canary`\n* `/test pull-kubernetes-e2e-kind-ipv6-canary`\n* `/test pull-kubernetes-e2e-kind-ipvs-dual-canary`\n* `/test pull-kubernetes-e2e-kind-kms`\n* `/test pull-kubernetes-e2e-kind-multizone`\n* `/test pull-kubernetes-e2e-kops-aws`\n* `/test pull-kubernetes-e2e-storage-kind-disruptive`\n* `/test pull-kubernetes-e2e-ubuntu-gce-network-policies`\n* `/test pull-kubernetes-integration-eks`\n* `/test pull-kubernetes-kind-dra`\n* `/test pull-kubernetes-kind-json-logging`\n* `/test pull-kubernetes-kind-text-logging`\n* `/test pull-kubernetes-kubemark-e2e-gce-big`\n* `/test pull-kubernetes-local-e2e`\n* `/test pull-kubernetes-node-arm64-e2e-containerd-ec2`\n* `/test pull-kubernetes-node-arm64-e2e-containerd-serial-ec2`\n* `/test pull-kubernetes-node-arm64-ubuntu-serial-gce`\n* `/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e`\n* `/test pull-kubernetes-node-crio-cgrpv2-e2e`\n* `/test pull-kubernetes-node-crio-cgrpv2-e2e-kubetest2`\n* `/test pull-kubernetes-node-crio-e2e`\n* `/test pull-kubernetes-node-crio-e2e-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-alpha-features`\n* `/test pull-kubernetes-node-e2e-containerd-ec2`\n* `/test pull-kubernetes-node-e2e-containerd-features`\n* `/test pull-kubernetes-node-e2e-containerd-features-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-serial-ec2`\n* `/test pull-kubernetes-node-e2e-containerd-sidecar-containers`\n* `/test pull-kubernetes-node-e2e-containerd-standalone-mode`\n* `/test pull-kubernetes-node-e2e-containerd-standalone-mode-all-alpha`\n* `/test pull-kubernetes-node-e2e-crio-dra`\n* `/test pull-kubernetes-node-kubelet-credential-provider`\n* `/test pull-kubernetes-node-kubelet-serial-containerd`\n* `/test pull-kubernetes-node-kubelet-serial-containerd-kubetest2`\n* `/test pull-kubernetes-node-kubelet-serial-cpu-manager`\n* `/test pull-kubernetes-node-kubelet-serial-cpu-manager-kubetest2`\n* `/test pull-kubernetes-node-kubelet-serial-crio-cgroupv1`\n* `/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2`\n* `/test pull-kubernetes-node-kubelet-serial-hugepages`\n* `/test pull-kubernetes-node-kubelet-serial-memory-manager`\n* `/test pull-kubernetes-node-kubelet-serial-pod-disruption-conditions`\n* `/test pull-kubernetes-node-kubelet-serial-topology-manager`\n* `/test pull-kubernetes-node-kubelet-serial-topology-manager-kubetest2`\n* `/test pull-kubernetes-node-memoryqos-cgrpv2`\n* `/test pull-kubernetes-node-swap-fedora`\n* `/test pull-kubernetes-node-swap-fedora-serial`\n* `/test pull-kubernetes-node-swap-ubuntu-serial`\n* `/test pull-kubernetes-unit-experimental`\n* `/test pull-kubernetes-verify-strict-lint`\n* `/test pull-publishing-bot-validate`\n\nUse `/test all` to run the following jobs that were automatically triggered:\n* `pull-kubernetes-conformance-kind-ga-only-parallel`\n* `pull-kubernetes-dependencies`\n* `pull-kubernetes-e2e-gce`\n* `pull-kubernetes-e2e-kind`\n* `pull-kubernetes-e2e-kind-ipv6`\n* `pull-kubernetes-integration`\n* `pull-kubernetes-node-e2e-containerd`\n* `pull-kubernetes-typecheck`\n* `pull-kubernetes-unit`\n* `pull-kubernetes-verify`\n\n\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119655#issuecomment-1655489120):\n\n>/test?\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 10:56:17" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119655#\" title=\"Author self-approved\">swatisehgal</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [derekwaynecarr](https://github.com/derekwaynecarr) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/kubelet/cm/cpumanager/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/cm/cpumanager/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"derekwaynecarr\"]} -->", "created_at": "2023-07-28 10:56:58" }, { "body": "/test pull-kubernetes-node-kubelet-serial-cpu-manager\r\n/test pull-kubernetes-node-kubelet-serial-memory-manager\r\n/test pull-kubernetes-node-kubelet-serial-topology-manager", "created_at": "2023-07-28 10:58:02" }, { "body": "/test pull-kubernetes-node-kubelet-serial-cpu-manager\r\n/test pull-kubernetes-node-kubelet-serial-memory-manager\r\n/test pull-kubernetes-node-kubelet-serial-topology-manager", "created_at": "2023-07-28 12:05:48" }, { "body": "@swatisehgal: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-node-kubelet-serial-cpu-manager | abfa988104508e3cfe24096e4d968caa6b83d8b7 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119655/pull-kubernetes-node-kubelet-serial-cpu-manager/1684897952658624512/) | false | `/test pull-kubernetes-node-kubelet-serial-cpu-manager`\npull-kubernetes-node-kubelet-serial-memory-manager | abfa988104508e3cfe24096e4d968caa6b83d8b7 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119655/pull-kubernetes-node-kubelet-serial-memory-manager/1684897952742510592/) | false | `/test pull-kubernetes-node-kubelet-serial-memory-manager`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119655). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Aswatisehgal). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-07-28 12:25:01" }, { "body": "/test pull-kubernetes-unit \r\n/test pull-kubernetes-typecheck ", "created_at": "2023-07-28 13:16:37" }, { "body": "/kind cleanup\r\n/release-note-none\r\n/priority backlog\r\n/triage accepted\r\n/cc ", "created_at": "2023-07-31 15:37:30" }, { "body": "/lgtm", "created_at": "2023-07-31 15:38:09" }, { "body": "LGTM label has been added. <details>Git tree hash: 631ddf5dfb7635736b670bd127833733c4bc08e2</details>", "created_at": "2023-07-31 15:38:17" }, { "body": "/label do-not-merge/work-in-progress", "created_at": "2023-07-31 15:40:00" }, { "body": "@bart0sh: The label(s) `/label do-not-merge/work-in-progress` cannot be applied. These labels are supported: `api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, official-cve-feed`. Is this label configured under `labels -> additional_labels` or `labels -> restricted_labels` in `plugin.yaml`?\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119655#issuecomment-1658622366):\n\n>/label do-not-merge/work-in-progress\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-31 15:40:02" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:56:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:56:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:56:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:56:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:56:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:56:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:56:10", "type": "labeled" }, { "author": "swatisehgal", "created_at": "2023-07-28 10:56:17", "type": "mentioned" }, { "author": "swatisehgal", "created_at": "2023-07-28 10:56:18", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:56:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:56:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:56:37", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:56:46", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:56:46", "type": "review_requested" }, { "author": "swatisehgal", "created_at": "2023-07-28 11:16:07", "type": "mentioned" }, { "author": "swatisehgal", "created_at": "2023-07-28 11:16:07", "type": "subscribed" }, { "author": "swatisehgal", "created_at": "2023-07-28 11:18:53", "type": "mentioned" }, { "author": "swatisehgal", "created_at": "2023-07-28 11:18:54", "type": "subscribed" }, { "author": "swatisehgal", "created_at": "2023-07-28 11:57:51", "type": "mentioned" }, { "author": "swatisehgal", "created_at": "2023-07-28 11:57:51", "type": "subscribed" }, { "author": "swatisehgal", "created_at": "2023-07-28 12:05:17", "type": "head_ref_force_pushed" }, { "author": "swatisehgal", "created_at": "2023-07-28 12:24:33", "type": "mentioned" }, { "author": "swatisehgal", "created_at": "2023-07-28 12:24:33", "type": "subscribed" }, { "author": "swatisehgal", "created_at": "2023-07-28 12:25:02", "type": "mentioned" }, { "author": "swatisehgal", "created_at": "2023-07-28 12:25:02", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:37:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:37:31", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:37:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:37:32", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:37:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:37:34", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:37:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:37:35", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:37:35", "type": "unlabeled" }, { "author": "bart0sh", "created_at": "2023-07-31 15:38:14", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:38:15", "type": "labeled" }, { "author": "bart0sh", "created_at": "2023-07-31 15:40:03", "type": "mentioned" }, { "author": "bart0sh", "created_at": "2023-07-31 15:40:03", "type": "subscribed" } ]

[ "wojtek-t" ]

[ "area/test", "kind/cleanup", "lgtm", "sig/api-machinery", "size/XS", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "needs-priority", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Jul 28 10:11:44 UTC 2023.\n", "created_at": "2023-07-28 10:39:47" }, { "body": "/assign @wojtek-t ", "created_at": "2023-07-28 10:39:53" }, { "body": "/test kubernetes-e2e-gce-cos-alpha-features", "created_at": "2023-07-28 10:40:09" }, { "body": "@p0lyn0mial: The specified target(s) for `/test` were not found.\nThe following commands are available to trigger required jobs:\n* `/test pull-cadvisor-e2e-kubernetes`\n* `/test pull-kubernetes-conformance-kind-ga-only-parallel`\n* `/test pull-kubernetes-coverage-unit`\n* `/test pull-kubernetes-dependencies`\n* `/test pull-kubernetes-dependencies-go-canary`\n* `/test pull-kubernetes-e2e-gce`\n* `/test pull-kubernetes-e2e-gce-100-performance`\n* `/test pull-kubernetes-e2e-gce-big-performance`\n* `/test pull-kubernetes-e2e-gce-canary`\n* `/test pull-kubernetes-e2e-gce-cos`\n* `/test pull-kubernetes-e2e-gce-cos-canary`\n* `/test pull-kubernetes-e2e-gce-cos-no-stage`\n* `/test pull-kubernetes-e2e-gce-network-proxy-http-connect`\n* `/test pull-kubernetes-e2e-gce-scale-performance-manual`\n* `/test pull-kubernetes-e2e-kind`\n* `/test pull-kubernetes-e2e-kind-ipv6`\n* `/test pull-kubernetes-integration`\n* `/test pull-kubernetes-integration-go-canary`\n* `/test pull-kubernetes-kubemark-e2e-gce-scale`\n* `/test pull-kubernetes-node-e2e-containerd`\n* `/test pull-kubernetes-typecheck`\n* `/test pull-kubernetes-unit`\n* `/test pull-kubernetes-unit-go-canary`\n* `/test pull-kubernetes-update`\n* `/test pull-kubernetes-verify`\n* `/test pull-kubernetes-verify-go-canary`\n\nThe following commands are available to trigger optional jobs:\n* `/test check-dependency-stats`\n* `/test pull-ci-kubernetes-unit-windows`\n* `/test pull-e2e-gce-cloud-provider-disabled`\n* `/test pull-kubernetes-conformance-image-test`\n* `/test pull-kubernetes-conformance-kind-ga-only`\n* `/test pull-kubernetes-conformance-kind-ipv6-parallel`\n* `/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e`\n* `/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e-features`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-eviction`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-features`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-serial`\n* `/test pull-kubernetes-cross`\n* `/test pull-kubernetes-e2e-autoscaling-hpa-cm`\n* `/test pull-kubernetes-e2e-autoscaling-hpa-cpu`\n* `/test pull-kubernetes-e2e-capz-azure-disk`\n* `/test pull-kubernetes-e2e-capz-azure-disk-vmss`\n* `/test pull-kubernetes-e2e-capz-azure-file`\n* `/test pull-kubernetes-e2e-capz-azure-file-vmss`\n* `/test pull-kubernetes-e2e-capz-conformance`\n* `/test pull-kubernetes-e2e-capz-windows`\n* `/test pull-kubernetes-e2e-capz-windows-alpha-feature-vpa`\n* `/test pull-kubernetes-e2e-capz-windows-alpha-features`\n* `/test pull-kubernetes-e2e-capz-windows-serial-slow-hpa`\n* `/test pull-kubernetes-e2e-containerd-gce`\n* `/test pull-kubernetes-e2e-gce-correctness`\n* `/test pull-kubernetes-e2e-gce-cos-alpha-features`\n* `/test pull-kubernetes-e2e-gce-cos-kubetest2`\n* `/test pull-kubernetes-e2e-gce-csi-serial`\n* `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\n* `/test pull-kubernetes-e2e-gce-kubelet-credential-provider`\n* `/test pull-kubernetes-e2e-gce-network-proxy-grpc`\n* `/test pull-kubernetes-e2e-gce-serial`\n* `/test pull-kubernetes-e2e-gce-storage-disruptive`\n* `/test pull-kubernetes-e2e-gce-storage-slow`\n* `/test pull-kubernetes-e2e-gce-storage-snapshot`\n* `/test pull-kubernetes-e2e-gci-gce-autoscaling`\n* `/test pull-kubernetes-e2e-gci-gce-ingress`\n* `/test pull-kubernetes-e2e-gci-gce-ipvs`\n* `/test pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2`\n* `/test pull-kubernetes-e2e-kind-alpha-features`\n* `/test pull-kubernetes-e2e-kind-canary`\n* `/test pull-kubernetes-e2e-kind-dual-canary`\n* `/test pull-kubernetes-e2e-kind-ipv6-canary`\n* `/test pull-kubernetes-e2e-kind-ipvs-dual-canary`\n* `/test pull-kubernetes-e2e-kind-kms`\n* `/test pull-kubernetes-e2e-kind-multizone`\n* `/test pull-kubernetes-e2e-kops-aws`\n* `/test pull-kubernetes-e2e-storage-kind-disruptive`\n* `/test pull-kubernetes-e2e-ubuntu-gce-network-policies`\n* `/test pull-kubernetes-integration-eks`\n* `/test pull-kubernetes-kind-dra`\n* `/test pull-kubernetes-kind-json-logging`\n* `/test pull-kubernetes-kind-text-logging`\n* `/test pull-kubernetes-kubemark-e2e-gce-big`\n* `/test pull-kubernetes-local-e2e`\n* `/test pull-kubernetes-node-arm64-e2e-containerd-ec2`\n* `/test pull-kubernetes-node-arm64-e2e-containerd-serial-ec2`\n* `/test pull-kubernetes-node-arm64-ubuntu-serial-gce`\n* `/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e`\n* `/test pull-kubernetes-node-crio-cgrpv2-e2e`\n* `/test pull-kubernetes-node-crio-cgrpv2-e2e-kubetest2`\n* `/test pull-kubernetes-node-crio-e2e`\n* `/test pull-kubernetes-node-crio-e2e-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-alpha-features`\n* `/test pull-kubernetes-node-e2e-containerd-ec2`\n* `/test pull-kubernetes-node-e2e-containerd-features`\n* `/test pull-kubernetes-node-e2e-containerd-features-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-serial-ec2`\n* `/test pull-kubernetes-node-e2e-containerd-sidecar-containers`\n* `/test pull-kubernetes-node-e2e-containerd-standalone-mode`\n* `/test pull-kubernetes-node-e2e-containerd-standalone-mode-all-alpha`\n* `/test pull-kubernetes-node-e2e-crio-dra`\n* `/test pull-kubernetes-node-kubelet-credential-provider`\n* `/test pull-kubernetes-node-kubelet-serial-containerd`\n* `/test pull-kubernetes-node-kubelet-serial-containerd-kubetest2`\n* `/test pull-kubernetes-node-kubelet-serial-cpu-manager`\n* `/test pull-kubernetes-node-kubelet-serial-cpu-manager-kubetest2`\n* `/test pull-kubernetes-node-kubelet-serial-crio-cgroupv1`\n* `/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2`\n* `/test pull-kubernetes-node-kubelet-serial-hugepages`\n* `/test pull-kubernetes-node-kubelet-serial-memory-manager`\n* `/test pull-kubernetes-node-kubelet-serial-pod-disruption-conditions`\n* `/test pull-kubernetes-node-kubelet-serial-topology-manager`\n* `/test pull-kubernetes-node-kubelet-serial-topology-manager-kubetest2`\n* `/test pull-kubernetes-node-memoryqos-cgrpv2`\n* `/test pull-kubernetes-node-swap-fedora`\n* `/test pull-kubernetes-node-swap-fedora-serial`\n* `/test pull-kubernetes-node-swap-ubuntu-serial`\n* `/test pull-kubernetes-unit-experimental`\n* `/test pull-kubernetes-verify-strict-lint`\n* `/test pull-publishing-bot-validate`\n\nUse `/test all` to run the following jobs that were automatically triggered:\n* `pull-kubernetes-conformance-kind-ga-only-parallel`\n* `pull-kubernetes-conformance-kind-ipv6-parallel`\n* `pull-kubernetes-dependencies`\n* `pull-kubernetes-e2e-gce`\n* `pull-kubernetes-e2e-kind`\n* `pull-kubernetes-e2e-kind-ipv6`\n* `pull-kubernetes-integration`\n* `pull-kubernetes-node-e2e-containerd`\n* `pull-kubernetes-typecheck`\n* `pull-kubernetes-unit`\n* `pull-kubernetes-verify`\n\n\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119654#issuecomment-1655468459):\n\n>/test kubernetes-e2e-gce-cos-alpha-features\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 10:40:10" }, { "body": "/test pull-kubernetes-e2e-gce-cos-alpha-features", "created_at": "2023-07-28 10:40:36" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-07-28 12:50:47" }, { "body": "LGTM label has been added. <details>Git tree hash: ece02faa46bd1781552d224b2cee248f48096d47</details>", "created_at": "2023-07-28 12:50:54" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119654#\" title=\"Author self-approved\">p0lyn0mial</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119654#issuecomment-1655635800\" title=\"Approved\">wojtek-t</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e/apimachinery/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/apimachinery/OWNERS)~~ [wojtek-t]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-07-28 12:50:55" }, { "body": "/triage accepted", "created_at": "2023-08-03 16:39:54" }, { "body": "/milestone v1.29", "created_at": "2023-08-16 11:23:31" }, { "body": "@p0lyn0mial: You must be a member of the [kubernetes/milestone-maintainers](https://github.com/orgs/kubernetes/teams/milestone-maintainers/members) GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119654#issuecomment-1680423903):\n\n>/milestone v1.29\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-16 11:23:32" }, { "body": "@wojtek-t can you please set the milestone to `1.29` ?", "created_at": "2023-08-16 11:24:28" }, { "body": "/retest", "created_at": "2023-08-16 11:25:11" }, { "body": "/retest", "created_at": "2023-08-16 13:58:21" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:39:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:39:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:39:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:39:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:39:48", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:39:48", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:39:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:39:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:39:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:39:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:39:51", "type": "labeled" }, { "author": "wojtek-t", "created_at": "2023-07-28 10:39:54", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-07-28 10:39:54", "type": "subscribed" }, { "author": "wojtek-t", "created_at": "2023-07-28 10:39:55", "type": "assigned" }, { "author": "p0lyn0mial", "created_at": "2023-07-28 10:40:11", "type": "mentioned" }, { "author": "p0lyn0mial", "created_at": "2023-07-28 10:40:11", "type": "subscribed" }, { "author": "p0lyn0mial", "created_at": "2023-07-28 11:07:33", "type": "mentioned" }, { "author": "p0lyn0mial", "created_at": "2023-07-28 11:07:33", "type": "subscribed" }, { "author": "p0lyn0mial", "created_at": "2023-07-28 11:20:29", "type": "mentioned" }, { "author": "p0lyn0mial", "created_at": "2023-07-28 11:20:29", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 12:50:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 12:50:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:39:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:39:57", "type": "unlabeled" }, { "author": "p0lyn0mial", "created_at": "2023-08-16 11:23:33", "type": "mentioned" }, { "author": "p0lyn0mial", "created_at": "2023-08-16 11:23:33", "type": "subscribed" }, { "author": "wojtek-t", "created_at": "2023-08-16 11:24:28", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-08-16 11:24:29", "type": "subscribed" }, { "author": "p0lyn0mial", "created_at": "2023-08-16 12:35:20", "type": "mentioned" }, { "author": "p0lyn0mial", "created_at": "2023-08-16 12:35:20", "type": "subscribed" }, { "author": "p0lyn0mial", "created_at": "2023-08-16 13:05:55", "type": "mentioned" }, { "author": "p0lyn0mial", "created_at": "2023-08-16 13:05:55", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 16:32:47", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 16:32:47", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 16:32:47", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 16:32:48", "type": "milestoned" } ]

[ "liggitt" ]

[ "kind/bug", "priority/important-soon", "lgtm", "sig/api-machinery", "release-note", "size/L", "kind/api-change", "approved", "cncf-cla: yes", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Jul 28 10:11:44 UTC 2023.\n", "created_at": "2023-07-28 10:34:15" }, { "body": "/retest", "created_at": "2023-07-29 03:48:56" }, { "body": "/priority important-soon\r\n\r\n/cc @kubernetes/sig-api-machinery-pr-reviews \r\n", "created_at": "2023-07-31 08:00:50" }, { "body": "@furkatgofurov7: GitHub didn't allow me to request PR reviews from the following users: kubernetes/sig-api-machinery-pr-reviews.\n\nNote that only [kubernetes members](https://github.com/orgs/kubernetes/people) and repo collaborators can review this PR, and authors cannot review their own PRs.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119653#issuecomment-1657867931):\n\n>/priority important-soon\r\n>\r\n>/cc @kubernetes/sig-api-machinery-pr-reviews \r\n>\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-31 08:00:52" }, { "body": "/triage accepted", "created_at": "2023-07-31 08:02:32" }, { "body": "Hey,\r\n\r\n1.28 Bug Triage Lead here! Can someone please label this PR with proper priority? Thanks! ", "created_at": "2023-07-31 08:03:27" }, { "body": "/lgtm\r\n/approve\r\n\r\npriority is probably important-longterm, ok to wait for master branch to reopen", "created_at": "2023-07-31 13:10:40" }, { "body": "LGTM label has been added. <details>Git tree hash: 7b087cd52dcf1a1368131485d6269a9182147474</details>", "created_at": "2023-07-31 13:10:46" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119653#issuecomment-1658345615\" title=\"Approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119653#\" title=\"Author self-approved\">sttts</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/apiextensions-apiserver/pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiextensions-apiserver/pkg/apis/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-07-31 13:11:03" }, { "body": "`pull-kubernetes-node-e2e-containerd` failed, rerunning it\r\n\r\n/retest", "created_at": "2023-07-31 13:41:46" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:34:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:34:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:34:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:34:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:34:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:34:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:34:19", "type": "labeled" }, { "author": "sttts", "created_at": "2023-07-28 10:34:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:34:44", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:34:48", "type": "labeled" }, { "author": "sttts", "created_at": "2023-07-28 10:34:53", "type": "milestoned" }, { "author": "sttts", "created_at": "2023-07-28 10:35:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:35:14", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-07-28 10:35:17", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:35:22", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:35:22", "type": "review_requested" }, { "author": "sttts", "created_at": "2023-07-28 11:01:59", "type": "mentioned" }, { "author": "sttts", "created_at": "2023-07-28 11:01:59", "type": "subscribed" }, { "author": "lavalamp", "created_at": "2023-07-31 08:00:50", "type": "subscribed" }, { "author": "logicalhan", "created_at": "2023-07-31 08:00:50", "type": "subscribed" }, { "author": "sttts", "created_at": "2023-07-31 08:00:51", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-07-31 08:00:51", "type": "subscribed" }, { "author": "smarterclayton", "created_at": "2023-07-31 08:00:51", "type": "subscribed" }, { "author": "deads2k", "created_at": "2023-07-31 08:00:51", "type": "subscribed" }, { "author": "MadhavJivrajani", "created_at": "2023-07-31 08:00:51", "type": "subscribed" }, { "author": "furkatgofurov7", "created_at": "2023-07-31 08:00:53", "type": "mentioned" }, { "author": "furkatgofurov7", "created_at": "2023-07-31 08:00:53", "type": "subscribed" }, { "author": "lavalamp", "created_at": "2023-07-31 08:00:53", "type": "subscribed" }, { "author": "logicalhan", "created_at": "2023-07-31 08:00:53", "type": "subscribed" }, { "author": "sttts", "created_at": "2023-07-31 08:00:53", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-07-31 08:00:54", "type": "subscribed" }, { "author": "smarterclayton", "created_at": "2023-07-31 08:00:54", "type": "subscribed" }, { "author": "deads2k", "created_at": "2023-07-31 08:00:54", "type": "subscribed" }, { "author": "MadhavJivrajani", "created_at": "2023-07-31 08:00:54", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 08:02:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 08:02:37", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 13:10:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 13:11:04", "type": "labeled" }, { "author": "sttts", "created_at": "2023-07-31 13:39:49", "type": "mentioned" }, { "author": "sttts", "created_at": "2023-07-31 13:39:49", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 14:12:40", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 14:12:40", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 14:12:40", "type": "closed" } ]

[ "bart0sh", "ffromani" ]

[ "kind/bug", "priority/backlog", "area/kubelet", "sig/node", "size/M", "release-note-none", "cncf-cla: yes", "ok-to-test", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Jul 28 04:11:54 UTC 2023.\n", "created_at": "2023-07-28 09:48:34" }, { "body": "Welcome @lixd! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:", "created_at": "2023-07-28 09:48:38" }, { "body": "Hi @lixd. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-28 09:48:39" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119652#\" title=\"Author self-approved\">lixd</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [random-liu](https://github.com/random-liu) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"random-liu\"]} -->", "created_at": "2023-07-28 09:49:23" }, { "body": "/cc @ffromani ", "created_at": "2023-07-28 10:04:38" }, { "body": "/ok-to-test\r\n/priority backlog\r\n/triage accepted", "created_at": "2023-07-28 10:12:23" }, { "body": "Another option could be to store the timestamp of the last check on a checkpoint file (/var/lib/kubelet/...).\r\nIn normal operation this checkpoint would be ignored,because kubelet can keep the necessary state in memory, but on kubelet restart/node reboot this will give us a way to do a precise recovery.\r\nAdditionally, if the checkpoint is missing, kubelet can happily keep its current behavior (either the one fixed in this PR or the previous).\r\nI'm not sure the extra complexity is worht the gains, and I'm not approver so I can't really say, but I for myself would explore this way.", "created_at": "2023-07-28 10:17:55" }, { "body": "/retest", "created_at": "2023-07-28 11:54:57" }, { "body": "/test pull-kubernetes-node-e2e-containerd", "created_at": "2023-07-28 12:54:27" }, { "body": "/cc @bobbypage @odinuge ", "created_at": "2023-07-29 03:24:35" }, { "body": "/cc", "created_at": "2023-07-31 11:09:42" }, { "body": "LGTM label has been added. <details>Git tree hash: 649dd7aa90d60e4036ab8655b80503baecc86776</details>", "created_at": "2023-08-03 09:26:07" }, { "body": "let's hear thoughts from other reviewers and approvers though", "created_at": "2023-08-03 09:26:26" }, { "body": "@lixd Since this is a bugfix, can we have this fix covered by the unit or/and e2e tests?", "created_at": "2023-08-24 09:46:22" }, { "body": "yes,i will add a test to cover this case.", "created_at": "2023-08-24 13:26:07" }, { "body": "/lgtm", "created_at": "2023-08-24 14:28:05" }, { "body": "LGTM label has been added. <details>Git tree hash: 4bcbbd070b4ce33f03747d1bf62615a3714fdab5</details>", "created_at": "2023-08-24 14:28:18" }, { "body": "/retest", "created_at": "2023-08-24 15:01:05" }, { "body": "/test pull-kubernetes-unit", "created_at": "2023-08-25 00:49:12" }, { "body": "New changes are detected. LGTM label has been removed.", "created_at": "2023-08-25 01:58:01" }, { "body": "/cc @bart0sh ", "created_at": "2023-08-25 04:31:40" }, { "body": "@lixd Can you explain what kind of race did you fix with your last commit in this PR?", "created_at": "2023-08-25 07:27:58" }, { "body": "> @lixd Can you explain what kind of race did you fix with your last commit in this PR?\r\n\r\n@bart0sh \r\nthe fakeruntime' ListImage func return a slice,and the caller(manager) got this slice and will wirte it by `im.imageCache.set(images)`, finally func which write it is `sort.sort`,the Swap func `func (a ByImageSize) Swap(i, j int) { a[i], a[j] = a[j], a[i] }`,and the fakeruntime's `GetImageRef` will try to read the slice, so there is a data race, i use snapshot func to solve it.", "created_at": "2023-08-25 09:38:55" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:48:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:48:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:48:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:48:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:48:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:48:38", "type": "labeled" }, { "author": "lixd", "created_at": "2023-07-28 09:48:38", "type": "mentioned" }, { "author": "lixd", "created_at": "2023-07-28 09:48:38", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:48:39", "type": "labeled" }, { "author": "lixd", "created_at": "2023-07-28 09:48:39", "type": "mentioned" }, { "author": "lixd", "created_at": "2023-07-28 09:48:39", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:48:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:49:00", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:49:00", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:49:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:49:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:49:14", "type": "unlabeled" }, { "author": "ffromani", "created_at": "2023-07-28 10:04:39", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-07-28 10:04:39", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:04:40", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:12:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:12:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:12:25", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:12:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:12:26", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:12:27", "type": "unlabeled" }, { "author": "lixd", "created_at": "2023-07-28 10:37:36", "type": "mentioned" }, { "author": "lixd", "created_at": "2023-07-28 10:37:36", "type": "subscribed" }, { "author": "lixd", "created_at": "2023-07-28 11:08:43", "type": "mentioned" }, { "author": "lixd", "created_at": "2023-07-28 11:08:43", "type": "subscribed" }, { "author": "lixd", "created_at": "2023-07-28 12:19:28", "type": "mentioned" }, { "author": "lixd", "created_at": "2023-07-28 12:19:28", "type": "subscribed" }, { "author": "bobbypage", "created_at": "2023-07-29 03:24:35", "type": "mentioned" }, { "author": "bobbypage", "created_at": "2023-07-29 03:24:35", "type": "subscribed" }, { "author": "odinuge", "created_at": "2023-07-29 03:24:35", "type": "mentioned" }, { "author": "odinuge", "created_at": "2023-07-29 03:24:35", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:09:44", "type": "review_requested" }, { "author": "ffromani", "created_at": "2023-08-03 09:26:05", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 09:26:06", "type": "labeled" }, { "author": "lixd", "created_at": "2023-08-24 09:46:22", "type": "mentioned" }, { "author": "lixd", "created_at": "2023-08-24 09:46:22", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-24 14:05:38", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-24 14:05:38", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-24 14:05:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-24 14:05:40", "type": "review_requested" }, { "author": "lixd", "created_at": "2023-08-24 14:07:04", "type": "head_ref_force_pushed" }, { "author": "bart0sh", "created_at": "2023-08-24 14:28:16", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-24 14:28:17", "type": "labeled" }, { "author": "lixd", "created_at": "2023-08-24 14:37:19", "type": "mentioned" }, { "author": "lixd", "created_at": "2023-08-24 14:37:19", "type": "subscribed" }, { "author": "lixd", "created_at": "2023-08-24 14:48:00", "type": "mentioned" }, { "author": "lixd", "created_at": "2023-08-24 14:48:00", "type": "subscribed" }, { "author": "lixd", "created_at": "2023-08-24 15:44:16", "type": "mentioned" }, { "author": "lixd", "created_at": "2023-08-24 15:44:16", "type": "subscribed" }, { "author": "lixd", "created_at": "2023-08-25 01:27:55", "type": "mentioned" }, { "author": "lixd", "created_at": "2023-08-25 01:27:55", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-25 01:58:00", "type": "unlabeled" }, { "author": "bart0sh", "created_at": "2023-08-25 04:31:41", "type": "mentioned" }, { "author": "bart0sh", "created_at": "2023-08-25 04:31:41", "type": "subscribed" }, { "author": "lixd", "created_at": "2023-08-25 07:27:58", "type": "mentioned" }, { "author": "lixd", "created_at": "2023-08-25 07:27:58", "type": "subscribed" }, { "author": "lixd", "created_at": "2023-08-25 09:38:55", "type": "mentioned" }, { "author": "lixd", "created_at": "2023-08-25 09:38:55", "type": "subscribed" }, { "author": "bart0sh", "created_at": "2023-08-25 13:24:21", "type": "mentioned" }, { "author": "bart0sh", "created_at": "2023-08-25 13:24:22", "type": "subscribed" } ]

[]

[ "kind/documentation", "sig/node", "size/XS", "release-note-none", "priority/important-longterm", "ok-to-test", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Jul 28 04:11:54 UTC 2023.\n", "created_at": "2023-07-28 09:21:41" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119651#\" title=\"Author self-approved\">deveshgoyal1000</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [klueska](https://github.com/klueska) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/security/apparmor/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/security/apparmor/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"klueska\"]} -->", "created_at": "2023-07-28 09:21:43" }, { "body": "Hi @deveshgoyal1000. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-28 09:21:46" }, { "body": "/triage accepted\r\n/priority important-longterm", "created_at": "2023-07-28 13:11:57" }, { "body": "/ok-to-test", "created_at": "2023-07-28 13:12:21" }, { "body": "@TommyStarK: /release-note-edit must be used with a release note block.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119651#issuecomment-1655667917):\n\n>/release-note-edit\r\n>\r\n>NONE\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 13:15:20" }, { "body": "/release-note edit\r\n\r\n```release-note\r\nNONE\r\n```", "created_at": "2023-07-28 13:16:03" }, { "body": "/retest", "created_at": "2023-07-28 13:43:22" }, { "body": "@deveshgoyal1000 Thank you for your PR. It seems to only contain trivial edits. Please\r\nread [our trivial edits policy](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#trivial-edits). We encourage you to take a look at confirmed issues and bugs or issues marked help-wanted.", "created_at": "2023-07-31 11:14:25" }, { "body": "/release-note-none\r\n/cc", "created_at": "2023-07-31 15:35:22" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:21:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:21:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:21:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:21:43", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:21:43", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:21:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:21:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:21:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:21:46", "type": "labeled" }, { "author": "deveshgoyal1000", "created_at": "2023-07-28 09:21:47", "type": "mentioned" }, { "author": "deveshgoyal1000", "created_at": "2023-07-28 09:21:47", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:11:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:11:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:12:00", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:12:01", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:12:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:12:24", "type": "unlabeled" }, { "author": "TommyStarK", "created_at": "2023-07-28 13:15:21", "type": "mentioned" }, { "author": "TommyStarK", "created_at": "2023-07-28 13:15:21", "type": "subscribed" }, { "author": "deveshgoyal1000", "created_at": "2023-07-28 13:39:47", "type": "mentioned" }, { "author": "deveshgoyal1000", "created_at": "2023-07-28 13:39:47", "type": "subscribed" }, { "author": "deveshgoyal1000", "created_at": "2023-07-28 13:40:24", "type": "mentioned" }, { "author": "deveshgoyal1000", "created_at": "2023-07-28 13:40:24", "type": "subscribed" }, { "author": "deveshgoyal1000", "created_at": "2023-07-31 11:14:25", "type": "mentioned" }, { "author": "deveshgoyal1000", "created_at": "2023-07-31 11:14:25", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:35:24", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:35:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 15:35:25", "type": "unlabeled" } ]

[]

[ "kind/bug", "needs-sig", "needs-triage" ]

[ { "body": "There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:\n- `/sig <group-name>`\n- `/wg <group-name>`\n- `/committee <group-name>`\n\nPlease see the [group list](https://git.k8s.io/community/sig-list.md) for a listing of the SIGs, working groups, and committees available.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 09:12:22" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 09:12:23" }, { "body": "Sorry, I may misunderstand the problem.\r\n\r\nThere is no global registry prefix configuration for K8S. So everything works as expected in your descriptions.\r\n- `nginx` without any prefix equals to `docker.io/library/nginx`.", "created_at": "2023-08-08 08:08:41" }, { "body": "If the document shows an example like \r\n```\r\nkubectl run nginx --image=DUMMY_SERVER/nginx --restart=Never\r\n```\r\nthen there may be nothing vague.", "created_at": "2023-08-08 08:11:30" }, { "body": "I was led to believe I could force K8S to pull every image through my registry mirror simply by adding an `imagePullSecrets` to the `serviceaccount`, looks like I'm wrong.\r\n\r\nI wanted to avoid the need to edit every image tag to explicitly target the registry instead of docker.io, but I ended up doing it, no choice 🤷‍♂️ For those interested, you could use something more specific like a MutatingAdmissionWebhook or a kind of proxy.\r\n\r\nYou're right, that's better with that doc example modification, it may prevent people from thinking like me 😬 ", "created_at": "2023-08-08 09:12:15" }, { "body": "As I know this can be done with a webhook like kyverno.\r\n\r\nhttps://kyverno.io/docs/installation/customization/#configmap-keys has defaultRegistry.\r\n> defaultRegistry: sets the default image registry to use if one is not specified. Defaults to docker.io.\r\n", "created_at": "2023-08-08 09:56:17" }, { "body": "> As I know this can be done with a webhook like kyverno.\r\n> \r\n> https://kyverno.io/docs/installation/customization/#configmap-keys has defaultRegistry.\r\n> \r\n> > defaultRegistry: sets the default image registry to use if one is not specified. Defaults to docker.io.\r\n\r\nGood to know, thanks !", "created_at": "2023-08-08 09:58:04" } ]

[ { "author": "TBG-FR", "created_at": "2023-07-28 09:12:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:12:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:12:23", "type": "labeled" }, { "author": "TBG-FR", "created_at": "2023-08-08 09:58:05", "type": "closed" } ]

[ "wojtek-t" ]

[ "area/apiserver", "sig/api-machinery", "size/L", "kind/feature", "release-note-none", "cncf-cla: yes", "needs-priority", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Jul 28 04:11:54 UTC 2023.\n", "created_at": "2023-07-28 08:53:34" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119649#\" title=\"Author self-approved\">wackxu</a>*\n**Once this PR has been reviewed and has the lgtm label**, please ask for approval from [wojtek-t](https://github.com/wojtek-t). For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/apiserver/pkg/storage/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/storage/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"wojtek-t\"]} -->", "created_at": "2023-08-01 07:55:48" }, { "body": "/triage accepted", "created_at": "2023-08-03 16:40:23" }, { "body": "@wackxu: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-unit | 6157adf863b62cdc69cb46900ba0f37514dd16d8 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119649/pull-kubernetes-unit/1695014984125255680) | true | `/test pull-kubernetes-unit`\npull-kubernetes-verify | 6157adf863b62cdc69cb46900ba0f37514dd16d8 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119649/pull-kubernetes-verify/1695014987489087488) | true | `/test pull-kubernetes-verify`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119649). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Awackxu). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-08-25 11:01:12" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:53:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:53:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:53:32", "type": "labeled" }, { "author": "wackxu", "created_at": "2023-07-28 08:53:33", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:53:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:53:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:53:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:54:03", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:54:03", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:54:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:54:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:54:30", "type": "unlabeled" }, { "author": "wojtek-t", "created_at": "2023-07-28 09:40:51", "type": "assigned" }, { "author": "wackxu", "created_at": "2023-07-28 09:48:49", "type": "mentioned" }, { "author": "wackxu", "created_at": "2023-07-28 09:48:49", "type": "subscribed" }, { "author": "wackxu", "created_at": "2023-08-01 07:55:42", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 07:55:43", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 07:55:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 07:55:47", "type": "labeled" }, { "author": "wackxu", "created_at": "2023-08-01 08:22:14", "type": "mentioned" }, { "author": "wackxu", "created_at": "2023-08-01 08:22:14", "type": "subscribed" }, { "author": "wackxu", "created_at": "2023-08-01 08:29:55", "type": "mentioned" }, { "author": "wackxu", "created_at": "2023-08-01 08:29:55", "type": "subscribed" }, { "author": "wackxu", "created_at": "2023-08-01 08:35:47", "type": "mentioned" }, { "author": "wackxu", "created_at": "2023-08-01 08:35:47", "type": "subscribed" }, { "author": "wackxu", "created_at": "2023-08-01 08:54:50", "type": "mentioned" }, { "author": "wackxu", "created_at": "2023-08-01 08:54:50", "type": "subscribed" }, { "author": "wackxu", "created_at": "2023-08-01 09:18:24", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:40:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:40:27", "type": "unlabeled" }, { "author": "wackxu", "created_at": "2023-08-25 08:40:22", "type": "mentioned" }, { "author": "wackxu", "created_at": "2023-08-25 08:40:22", "type": "subscribed" }, { "author": "wackxu", "created_at": "2023-08-25 08:47:43", "type": "head_ref_force_pushed" }, { "author": "wackxu", "created_at": "2023-08-25 09:30:55", "type": "mentioned" }, { "author": "wackxu", "created_at": "2023-08-25 09:30:55", "type": "subscribed" }, { "author": "wackxu", "created_at": "2023-08-25 09:40:09", "type": "head_ref_force_pushed" }, { "author": "wackxu", "created_at": "2023-08-25 10:06:51", "type": "head_ref_force_pushed" }, { "author": "wackxu", "created_at": "2023-08-25 10:50:29", "type": "mentioned" }, { "author": "wackxu", "created_at": "2023-08-25 10:50:29", "type": "subscribed" }, { "author": "wackxu", "created_at": "2023-08-25 11:01:12", "type": "mentioned" }, { "author": "wackxu", "created_at": "2023-08-25 11:01:12", "type": "subscribed" } ]

[]

[ "size/S", "kind/feature", "release-note-none", "sig/cli", "cncf-cla: yes", "needs-ok-to-test", "do-not-merge/hold", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Jul 28 04:11:54 UTC 2023.\n", "created_at": "2023-07-28 08:36:50" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119648#\" title=\"Author self-approved\">ning0515</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [pwittrock](https://github.com/pwittrock) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/cli-runtime/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/cli-runtime/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"pwittrock\"]} -->", "created_at": "2023-07-28 08:36:52" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 08:36:54" }, { "body": "Hi @ning0515. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-28 08:36:55" }, { "body": "/hold\r\n\r\nthis feature has not being accepted by the sig, can you please first disucss on the issue and have the sig-cli to sign on the solution?\r\n\r\nhttps://github.com/kubernetes/kubectl/issues/1044", "created_at": "2023-07-30 22:28:46" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:36:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:36:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:36:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:36:52", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:36:52", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:36:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:36:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:36:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:36:55", "type": "labeled" }, { "author": "ning0515", "created_at": "2023-07-28 08:36:56", "type": "mentioned" }, { "author": "ning0515", "created_at": "2023-07-28 08:36:56", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:37:12", "type": "labeled" }, { "author": "ning0515", "created_at": "2023-07-29 07:26:20", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 22:28:47", "type": "labeled" } ]

[]

[ "kind/bug", "priority/important-soon", "area/kubelet", "sig/node", "release-note", "size/L", "cncf-cla: yes", "ok-to-test", "triage/accepted" ]

[ { "body": "<a href=\"https://easycla.lfx.linuxfoundation.org/#/?version=2\"><img src=\"https://s3.amazonaws.com/cla-project-logo-prod/cla-signed.svg\" alt=\"CLA Signed\" align=\"left\" height=\"28\" width=\"328\" ></a><br/><br />The committers listed above are authorized under a signed CLA.<ul><li>:white_check_mark: login: Chaunceyctx / name: Chauncey (92eb42fcee692685fb168d13956798b4b6e8a421)</li></ul>", "created_at": "2023-07-28 08:35:25" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Jul 28 04:11:54 UTC 2023.\n", "created_at": "2023-07-28 08:35:26" }, { "body": "Hi @Chaunceyctx. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-28 08:35:31" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119647#\" title=\"Author self-approved\">Chaunceyctx</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [mrunalp](https://github.com/mrunalp) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"mrunalp\"]} -->", "created_at": "2023-07-28 08:36:13" }, { "body": "@Chaunceyctx Thank you for your PR. Please [sign the CLA](https://github.com/kubernetes/community/tree/master/contributors/guide/contributor-cheatsheet#signing-the-cla) to proceed further, thanks.\r\n\r\n/cc", "created_at": "2023-08-02 15:18:17" }, { "body": "> @Chaunceyctx Thank you for your PR. Please [sign the CLA](https://github.com/kubernetes/community/tree/master/contributors/guide/contributor-cheatsheet#signing-the-cla) to proceed further, thanks.\r\n> \r\n> /cc\r\n\r\nthanks! done", "created_at": "2023-08-03 07:06:45" }, { "body": "/triage accepted\r\n/priority important-soon\r\n/ok-to-test", "created_at": "2023-08-03 09:25:47" }, { "body": "/test", "created_at": "2023-08-03 11:16:36" }, { "body": "@Chaunceyctx: The `/test` command needs one or more targets.\nThe following commands are available to trigger required jobs:\n* `/test pull-cadvisor-e2e-kubernetes`\n* `/test pull-kubernetes-conformance-kind-ga-only-parallel`\n* `/test pull-kubernetes-coverage-unit`\n* `/test pull-kubernetes-dependencies`\n* `/test pull-kubernetes-dependencies-go-canary`\n* `/test pull-kubernetes-e2e-gce`\n* `/test pull-kubernetes-e2e-gce-100-performance`\n* `/test pull-kubernetes-e2e-gce-big-performance`\n* `/test pull-kubernetes-e2e-gce-canary`\n* `/test pull-kubernetes-e2e-gce-cos`\n* `/test pull-kubernetes-e2e-gce-cos-canary`\n* `/test pull-kubernetes-e2e-gce-cos-no-stage`\n* `/test pull-kubernetes-e2e-gce-network-proxy-http-connect`\n* `/test pull-kubernetes-e2e-gce-scale-performance-manual`\n* `/test pull-kubernetes-e2e-kind`\n* `/test pull-kubernetes-e2e-kind-ipv6`\n* `/test pull-kubernetes-integration`\n* `/test pull-kubernetes-integration-go-canary`\n* `/test pull-kubernetes-kubemark-e2e-gce-scale`\n* `/test pull-kubernetes-node-e2e-containerd`\n* `/test pull-kubernetes-typecheck`\n* `/test pull-kubernetes-unit`\n* `/test pull-kubernetes-unit-go-canary`\n* `/test pull-kubernetes-update`\n* `/test pull-kubernetes-verify`\n* `/test pull-kubernetes-verify-go-canary`\n\nThe following commands are available to trigger optional jobs:\n* `/test check-dependency-stats`\n* `/test pull-ci-kubernetes-unit-windows`\n* `/test pull-e2e-gce-cloud-provider-disabled`\n* `/test pull-kubernetes-conformance-image-test`\n* `/test pull-kubernetes-conformance-kind-ga-only`\n* `/test pull-kubernetes-conformance-kind-ipv6-parallel`\n* `/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e`\n* `/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e-features`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-eviction`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-features`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-serial`\n* `/test pull-kubernetes-cross`\n* `/test pull-kubernetes-e2e-autoscaling-hpa-cm`\n* `/test pull-kubernetes-e2e-autoscaling-hpa-cpu`\n* `/test pull-kubernetes-e2e-capz-azure-disk`\n* `/test pull-kubernetes-e2e-capz-azure-disk-vmss`\n* `/test pull-kubernetes-e2e-capz-azure-file`\n* `/test pull-kubernetes-e2e-capz-azure-file-vmss`\n* `/test pull-kubernetes-e2e-capz-conformance`\n* `/test pull-kubernetes-e2e-capz-windows`\n* `/test pull-kubernetes-e2e-capz-windows-alpha-feature-vpa`\n* `/test pull-kubernetes-e2e-capz-windows-alpha-features`\n* `/test pull-kubernetes-e2e-capz-windows-serial-slow-hpa`\n* `/test pull-kubernetes-e2e-containerd-gce`\n* `/test pull-kubernetes-e2e-gce-correctness`\n* `/test pull-kubernetes-e2e-gce-cos-alpha-features`\n* `/test pull-kubernetes-e2e-gce-cos-kubetest2`\n* `/test pull-kubernetes-e2e-gce-csi-serial`\n* `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\n* `/test pull-kubernetes-e2e-gce-kubelet-credential-provider`\n* `/test pull-kubernetes-e2e-gce-network-proxy-grpc`\n* `/test pull-kubernetes-e2e-gce-serial`\n* `/test pull-kubernetes-e2e-gce-storage-disruptive`\n* `/test pull-kubernetes-e2e-gce-storage-slow`\n* `/test pull-kubernetes-e2e-gce-storage-snapshot`\n* `/test pull-kubernetes-e2e-gci-gce-autoscaling`\n* `/test pull-kubernetes-e2e-gci-gce-ingress`\n* `/test pull-kubernetes-e2e-gci-gce-ipvs`\n* `/test pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2`\n* `/test pull-kubernetes-e2e-kind-alpha-features`\n* `/test pull-kubernetes-e2e-kind-canary`\n* `/test pull-kubernetes-e2e-kind-dual-canary`\n* `/test pull-kubernetes-e2e-kind-ipv6-canary`\n* `/test pull-kubernetes-e2e-kind-ipvs-dual-canary`\n* `/test pull-kubernetes-e2e-kind-kms`\n* `/test pull-kubernetes-e2e-kind-multizone`\n* `/test pull-kubernetes-e2e-kops-aws`\n* `/test pull-kubernetes-e2e-storage-kind-disruptive`\n* `/test pull-kubernetes-e2e-ubuntu-gce-network-policies`\n* `/test pull-kubernetes-integration-eks`\n* `/test pull-kubernetes-kind-dra`\n* `/test pull-kubernetes-kind-json-logging`\n* `/test pull-kubernetes-kind-text-logging`\n* `/test pull-kubernetes-kubemark-e2e-gce-big`\n* `/test pull-kubernetes-local-e2e`\n* `/test pull-kubernetes-node-arm64-e2e-containerd-ec2`\n* `/test pull-kubernetes-node-arm64-e2e-containerd-serial-ec2`\n* `/test pull-kubernetes-node-arm64-ubuntu-serial-gce`\n* `/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e`\n* `/test pull-kubernetes-node-crio-cgrpv2-e2e`\n* `/test pull-kubernetes-node-crio-cgrpv2-e2e-kubetest2`\n* `/test pull-kubernetes-node-crio-e2e`\n* `/test pull-kubernetes-node-crio-e2e-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-alpha-features`\n* `/test pull-kubernetes-node-e2e-containerd-ec2`\n* `/test pull-kubernetes-node-e2e-containerd-features`\n* `/test pull-kubernetes-node-e2e-containerd-features-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-serial-ec2`\n* `/test pull-kubernetes-node-e2e-containerd-sidecar-containers`\n* `/test pull-kubernetes-node-e2e-containerd-standalone-mode`\n* `/test pull-kubernetes-node-e2e-containerd-standalone-mode-all-alpha`\n* `/test pull-kubernetes-node-e2e-crio-dra`\n* `/test pull-kubernetes-node-kubelet-credential-provider`\n* `/test pull-kubernetes-node-kubelet-serial-containerd`\n* `/test pull-kubernetes-node-kubelet-serial-containerd-kubetest2`\n* `/test pull-kubernetes-node-kubelet-serial-cpu-manager`\n* `/test pull-kubernetes-node-kubelet-serial-cpu-manager-kubetest2`\n* `/test pull-kubernetes-node-kubelet-serial-crio-cgroupv1`\n* `/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2`\n* `/test pull-kubernetes-node-kubelet-serial-hugepages`\n* `/test pull-kubernetes-node-kubelet-serial-memory-manager`\n* `/test pull-kubernetes-node-kubelet-serial-pod-disruption-conditions`\n* `/test pull-kubernetes-node-kubelet-serial-topology-manager`\n* `/test pull-kubernetes-node-kubelet-serial-topology-manager-kubetest2`\n* `/test pull-kubernetes-node-memoryqos-cgrpv2`\n* `/test pull-kubernetes-node-swap-fedora`\n* `/test pull-kubernetes-node-swap-fedora-serial`\n* `/test pull-kubernetes-node-swap-ubuntu-serial`\n* `/test pull-kubernetes-unit-experimental`\n* `/test pull-kubernetes-verify-strict-lint`\n* `/test pull-publishing-bot-validate`\n\nUse `/test all` to run the following jobs that were automatically triggered:\n* `pull-kubernetes-conformance-kind-ga-only-parallel`\n* `pull-kubernetes-dependencies`\n* `pull-kubernetes-e2e-gce`\n* `pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2`\n* `pull-kubernetes-e2e-kind`\n* `pull-kubernetes-e2e-kind-ipv6`\n* `pull-kubernetes-integration`\n* `pull-kubernetes-node-e2e-containerd`\n* `pull-kubernetes-typecheck`\n* `pull-kubernetes-unit`\n* `pull-kubernetes-verify`\n\n\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119647#issuecomment-1663798963):\n\n>/test\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-03 11:16:50" }, { "body": "/test all", "created_at": "2023-08-03 11:17:06" }, { "body": "/cc @bobbypage @haircommander @derekwaynecarr @bart0sh ", "created_at": "2023-08-06 02:08:05" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:35:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:35:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:35:24", "type": "labeled" }, { "author": "chaunceyctx97", "created_at": "2023-07-28 08:35:26", "type": "mentioned" }, { "author": "chaunceyctx97", "created_at": "2023-07-28 08:35:26", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:35:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:35:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:35:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:35:31", "type": "labeled" }, { "author": "Chaunceyctx", "created_at": "2023-07-28 08:35:31", "type": "mentioned" }, { "author": "Chaunceyctx", "created_at": "2023-07-28 08:35:31", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:35:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:36:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:36:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:36:03", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:36:27", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:36:27", "type": "review_requested" }, { "author": "Chaunceyctx", "created_at": "2023-07-28 09:10:27", "type": "head_ref_force_pushed" }, { "author": "Chaunceyctx", "created_at": "2023-08-02 15:18:17", "type": "mentioned" }, { "author": "Chaunceyctx", "created_at": "2023-08-02 15:18:17", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 15:18:21", "type": "review_requested" }, { "author": "Chaunceyctx", "created_at": "2023-08-03 06:23:25", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 06:23:27", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 06:23:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 06:23:30", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 06:23:31", "type": "labeled" }, { "author": "Chaunceyctx", "created_at": "2023-08-03 07:04:27", "type": "head_ref_force_pushed" }, { "author": "Chaunceyctx", "created_at": "2023-08-03 07:06:45", "type": "mentioned" }, { "author": "Chaunceyctx", "created_at": "2023-08-03 07:06:45", "type": "subscribed" }, { "author": "Chaunceyctx", "created_at": "2023-08-03 08:46:42", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 09:25:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 09:25:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 09:25:49", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 09:25:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 09:25:52", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 09:25:52", "type": "unlabeled" }, { "author": "Chaunceyctx", "created_at": "2023-08-03 10:16:16", "type": "mentioned" }, { "author": "Chaunceyctx", "created_at": "2023-08-03 10:16:17", "type": "subscribed" }, { "author": "Chaunceyctx", "created_at": "2023-08-03 11:14:50", "type": "head_ref_force_pushed" }, { "author": "Chaunceyctx", "created_at": "2023-08-03 11:16:51", "type": "mentioned" }, { "author": "Chaunceyctx", "created_at": "2023-08-03 11:16:51", "type": "subscribed" }, { "author": "bobbypage", "created_at": "2023-08-06 02:08:05", "type": "mentioned" }, { "author": "bobbypage", "created_at": "2023-08-06 02:08:05", "type": "subscribed" }, { "author": "derekwaynecarr", "created_at": "2023-08-06 02:08:05", "type": "mentioned" }, { "author": "derekwaynecarr", "created_at": "2023-08-06 02:08:05", "type": "subscribed" }, { "author": "haircommander", "created_at": "2023-08-06 02:08:05", "type": "mentioned" }, { "author": "haircommander", "created_at": "2023-08-06 02:08:05", "type": "subscribed" }, { "author": "bart0sh", "created_at": "2023-08-06 02:08:06", "type": "mentioned" }, { "author": "bart0sh", "created_at": "2023-08-06 02:08:06", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-06 02:08:06", "type": "review_requested" } ]

[ "aojea" ]

[ "kind/bug", "sig/api-machinery", "triage/accepted" ]

[ { "body": "/sig api-machinery", "created_at": "2023-07-28 09:07:00" }, { "body": "the code you are linking is very old and your server version indicats 1.18, that is EOL\r\n\r\nCheck the most recent code to see if that was already feature, there is also a new feature that may help you to improve your situation https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/3157-watch-list#design-details", "created_at": "2023-07-30 22:41:28" }, { "body": "> the code you are linking is very old and your server version indicats 1.18, that is EOL\r\n> \r\n> Check the most recent code to see if that was already feature, there is also a new feature that may help you to improve your situation https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/3157-watch-list#design-details\r\n\r\n@aojea Thank you for your reply! I have checked the latest master code, there also just retry when connection refused or TooManyRequests. \r\nhttps://github.com/kubernetes/kubernetes/blob/e68629e7b37acb1264f8518192b2d25b723d3be1/staging/src/k8s.io/client-go/tools/cache/reflector.go#L420\r\nhttps://github.com/kubernetes/kubernetes/blob/e68629e7b37acb1264f8518192b2d25b723d3be1/staging/src/k8s.io/client-go/tools/cache/reflector.go#L892-L902\r\nAnd the new feature that you refer to me may help, I will study it carefully. Thanks again!", "created_at": "2023-07-31 04:15:17" }, { "body": "/assign @aojea \r\nThank you.\r\n/triage accepted", "created_at": "2023-08-03 16:49:14" }, { "body": "/triage accepted", "created_at": "2023-08-03 16:55:59" }, { "body": "> And the new feature that you refer to me may help, I will study it carefully. Thanks again!\r\n\r\n/close\r\n\r\nplease feel free to reopen or open a new issue with more details if that information does not solve the problem", "created_at": "2023-08-03 23:13:22" }, { "body": "@aojea: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119646#issuecomment-1664750035):\n\n>> And the new feature that you refer to me may help, I will study it carefully. Thanks again!\r\n>\r\n>/close\r\n>\r\n>please feel free to reopen or open a new issue with more details if that information does not solve the problem\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-03 23:13:27" } ]

[ { "author": "AuroraTwinkle", "created_at": "2023-07-28 08:18:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:18:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:18:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:07:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:07:03", "type": "unlabeled" }, { "author": "aojea", "created_at": "2023-07-31 04:15:17", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-07-31 04:15:17", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-08-03 16:49:14", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-03 16:49:15", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-08-03 16:49:15", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:49:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:49:17", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 23:13:27", "type": "closed" }, { "author": "aojea", "created_at": "2023-08-03 23:13:28", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-03 23:13:28", "type": "subscribed" } ]

[ "Chaunceyctx" ]

[ "kind/bug", "sig/node", "triage/accepted" ]

[ { "body": "/sig node\r\n/assign", "created_at": "2023-07-28 07:51:24" }, { "body": "@bobbypage @liggitt @tallclair @Random-Liu PTAL", "created_at": "2023-07-28 08:49:37" }, { "body": "/cc", "created_at": "2023-07-31 11:09:07" }, { "body": "/triage accepted", "created_at": "2023-08-02 17:51:15" }, { "body": "@klueska @dashpole @liggitt @derekwaynecarr @pacoxu PTAL. Thanks!", "created_at": "2023-08-03 07:18:59" }, { "body": "I have encountered the same bug, is there a plan to fix it?", "created_at": "2023-08-11 01:55:52" }, { "body": "I hope the community can fix this bug as soon as possible.", "created_at": "2023-08-11 02:20:10" }, { "body": "I also met this before, is there a fix plan?", "created_at": "2023-08-11 02:28:00" } ]

[ { "author": "Chaunceyctx", "created_at": "2023-07-28 07:50:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:50:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:50:46", "type": "labeled" }, { "author": "Chaunceyctx", "created_at": "2023-07-28 07:51:26", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:51:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:51:27", "type": "unlabeled" }, { "author": "bobbypage", "created_at": "2023-07-28 08:49:37", "type": "mentioned" }, { "author": "bobbypage", "created_at": "2023-07-28 08:49:37", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-07-28 08:49:37", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-07-28 08:49:37", "type": "subscribed" }, { "author": "tallclair", "created_at": "2023-07-28 08:50:49", "type": "mentioned" }, { "author": "tallclair", "created_at": "2023-07-28 08:50:49", "type": "subscribed" }, { "author": "Random-Liu", "created_at": "2023-07-28 08:50:49", "type": "mentioned" }, { "author": "Random-Liu", "created_at": "2023-07-28 08:50:49", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 17:51:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 17:51:18", "type": "unlabeled" }, { "author": "klueska", "created_at": "2023-08-03 07:19:00", "type": "mentioned" }, { "author": "klueska", "created_at": "2023-08-03 07:19:00", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-03 07:19:00", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-03 07:19:00", "type": "subscribed" }, { "author": "dashpole", "created_at": "2023-08-03 07:19:00", "type": "mentioned" }, { "author": "dashpole", "created_at": "2023-08-03 07:19:00", "type": "subscribed" }, { "author": "derekwaynecarr", "created_at": "2023-08-03 07:19:49", "type": "mentioned" }, { "author": "derekwaynecarr", "created_at": "2023-08-03 07:19:49", "type": "subscribed" }, { "author": "pacoxu", "created_at": "2023-08-03 07:27:39", "type": "mentioned" }, { "author": "pacoxu", "created_at": "2023-08-03 07:27:39", "type": "subscribed" } ]

[]

[ "area/apiserver", "release-note", "size/S", "kind/api-change", "kind/feature", "sig/auth", "cncf-cla: yes", "area/code-generation", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Jul 28 04:11:54 UTC 2023.\n", "created_at": "2023-07-28 07:22:05" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 07:22:08" }, { "body": "xref a previous PR in this direction at https://github.com/kubernetes/kubernetes/pull/118571", "created_at": "2023-08-01 15:06:43" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119644#\" title=\"Author self-approved\">carlory</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [deads2k](https://github.com/deads2k) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/apiserver/pkg/authentication/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/authentication/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"deads2k\"]} -->", "created_at": "2023-08-02 10:29:38" }, { "body": "/remove-sig api-machinery", "created_at": "2023-08-03 16:41:25" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:22:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:22:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:22:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:22:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:22:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:22:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:22:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:22:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:22:32", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:22:32", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:23:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:23:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:23:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:23:05", "type": "unlabeled" }, { "author": "carlory", "created_at": "2023-07-28 07:25:16", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 07:25:16", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-28 07:26:44", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:26:46", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 07:26:46", "type": "labeled" }, { "author": "carlory", "created_at": "2023-07-28 07:30:33", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 07:30:33", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-28 07:34:20", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 07:34:20", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-28 07:34:55", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 07:34:55", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-28 07:35:13", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 07:35:13", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-28 07:35:27", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 07:35:27", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-28 07:37:54", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 07:37:54", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-28 07:53:57", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 07:53:57", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-28 08:14:53", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 08:14:53", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-28 10:57:05", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:57:07", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:57:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:57:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:57:42", "type": "labeled" }, { "author": "carlory", "created_at": "2023-07-28 11:03:54", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 11:03:54", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-28 11:06:30", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 11:06:30", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-28 11:07:04", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 11:07:04", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-28 11:07:15", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 11:07:15", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-28 11:07:21", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 11:07:21", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-28 11:07:41", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 11:07:41", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-28 11:07:45", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 11:07:45", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-28 11:28:04", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 11:28:04", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-28 11:45:00", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-28 11:45:00", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-31 08:19:48", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 08:19:50", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 08:19:51", "type": "labeled" }, { "author": "carlory", "created_at": "2023-07-31 08:22:05", "type": "head_ref_force_pushed" }, { "author": "carlory", "created_at": "2023-07-31 08:47:39", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 08:47:40", "type": "unlabeled" }, { "author": "carlory", "created_at": "2023-08-02 10:29:27", "type": "head_ref_force_pushed" }, { "author": "carlory", "created_at": "2023-08-02 10:31:04", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:41:27", "type": "unlabeled" } ]

[ "liggitt" ]

[ "priority/backlog", "kind/cleanup", "lgtm", "size/XS", "release-note-none", "sig/auth", "approved", "cncf-cla: yes", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Jul 28 04:11:54 UTC 2023.\n", "created_at": "2023-07-28 06:05:37" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 06:05:40" }, { "body": "/lgtm\r\n/approve\r\n/priority backlog\r\n\r\nthis is fine to change, but since the compare happens post-signature check, there's no practical way to exploit this to find the secret value (changing a single byte in the input would fail the signature check and not reach this point in the code)", "created_at": "2023-08-01 15:04:42" }, { "body": "LGTM label has been added. <details>Git tree hash: debb867b4128761f689d1cdd69d2749ad42cbba9</details>", "created_at": "2023-08-01 15:04:53" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119643#\" title=\"Author self-approved\">carlory</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119643#issuecomment-1660510634\" title=\"Approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/serviceaccount/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/serviceaccount/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-01 15:05:08" }, { "body": "@liggitt Should I cherry-pick it into v1.28, v1.27, v1.26, v1.25 and v1.24?", "created_at": "2023-08-16 02:53:15" }, { "body": "No, there's no real security risk this is fixing, see https://github.com/kubernetes/kubernetes/pull/119643#issuecomment-1660510634", "created_at": "2023-08-16 02:54:24" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 06:05:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 06:05:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 06:05:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 06:05:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 06:05:38", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 06:05:38", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 06:05:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 06:05:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 06:05:41", "type": "labeled" }, { "author": "carlory", "created_at": "2023-07-28 06:06:36", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 15:04:47", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-08-01 15:04:50", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 15:04:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 15:04:52", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 15:05:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 02:43:33", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 02:43:33", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 02:43:33", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 02:43:35", "type": "milestoned" }, { "author": "liggitt", "created_at": "2023-08-16 02:53:15", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-16 02:53:15", "type": "subscribed" } ]

[ "lixd" ]

[ "kind/bug", "priority/backlog", "sig/node", "triage/accepted" ]

[ { "body": "/sig node\r\n", "created_at": "2023-07-28 05:58:54" }, { "body": "/assign", "created_at": "2023-07-28 05:59:21" }, { "body": "/triage accepted\r\n/priority backlog\r\n\r\ninitial assessment of priority, subject to change", "created_at": "2023-07-28 10:11:19" } ]

[ { "author": "lixd", "created_at": "2023-07-28 05:55:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 05:55:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 05:55:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 05:58:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 05:58:57", "type": "unlabeled" }, { "author": "lixd", "created_at": "2023-07-28 05:59:23", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:11:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:11:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 10:11:22", "type": "unlabeled" } ]

[ "ning0515" ]

[ "sig/node", "sig/security", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 05:05:47" }, { "body": "/sig security", "created_at": "2023-07-28 05:05:47" }, { "body": "/assign", "created_at": "2023-07-29 14:20:13" }, { "body": "/sig node", "created_at": "2023-08-01 15:46:22" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 05:05:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 05:05:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 05:05:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 05:05:50", "type": "unlabeled" }, { "author": "ning0515", "created_at": "2023-07-29 09:35:56", "type": "assigned" }, { "author": "ning0515", "created_at": "2023-07-29 14:09:56", "type": "unassigned" }, { "author": "ning0515", "created_at": "2023-07-29 14:20:14", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 15:46:24", "type": "labeled" } ]

[]

[ "kind/documentation", "sig/node", "sig/api-machinery", "sig/auth", "sig/security", "needs-triage" ]

[ { "body": "/sig security", "created_at": "2023-07-28 05:01:04" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 05:01:07" }, { "body": "/kind documentation\r\n/sig node api-machinery auth", "created_at": "2023-08-01 15:46:06" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 05:01:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 05:01:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 05:01:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 05:01:07", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 15:46:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 15:46:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 15:46:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 15:46:10", "type": "labeled" } ]

[ "charles-chenzz" ]

[ "kind/feature", "sig/security", "needs-triage" ]

[ { "body": "/sig security", "created_at": "2023-07-28 04:55:04" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 04:55:06" }, { "body": "/assign", "created_at": "2023-07-28 13:58:44" }, { "body": "this needs a kep owned by sig auth:\r\nhttps://github.com/kubernetes/enhancements/blob/master/keps/README.md\r\n\r\nthat covers, upgrades, backwards compatibility, etc.\r\nkubeadm is the only in tree user, but there are external users too.\r\n\r\nreviewing groups can be sig security and cluster-lifecycle.\r\n\r\n> while this is not realistically exploitable with current\r\ntechnology\r\n\r\nthe tokens are usually (by recommendation) ephemeral (token cleaner controller), and they are considered as the less secure cluster bootstrap option. in case someone wishes to bruteforce, and even if said technology is improved, the token could be made to expire before any reasonable bruteforce completes.\r\n\r\nkubeadm tokens currently expire after 24h by default.\r\n", "created_at": "2023-08-15 07:58:26" }, { "body": "/kind feature", "created_at": "2023-08-15 07:58:35" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:55:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:55:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:55:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:55:07", "type": "unlabeled" }, { "author": "charles-chenzz", "created_at": "2023-07-28 13:58:45", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-15 07:58:37", "type": "labeled" } ]

[ "carlory" ]

[ "sig/auth", "sig/security", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 04:50:30" }, { "body": "/sig security", "created_at": "2023-07-28 04:50:30" }, { "body": "/assign", "created_at": "2023-07-28 05:47:37" }, { "body": "/sig auth", "created_at": "2023-08-01 15:04:52" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:50:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:50:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:50:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:50:33", "type": "unlabeled" }, { "author": "carlory", "created_at": "2023-07-28 05:47:39", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 15:04:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 02:43:35", "type": "closed" } ]

[]

[ "kind/bug", "area/kubelet", "sig/node", "release-note", "size/S", "cncf-cla: yes", "priority/important-longterm", "ok-to-test", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Jul 27 22:10:08 UTC 2023.\n", "created_at": "2023-07-28 04:06:09" }, { "body": "Hi @chenk008. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-28 04:06:14" }, { "body": "/ok-to-test\r\n\r\nHi, thanks for this PR. Was this behavior you are fixing observed in the field?", "created_at": "2023-07-28 08:00:52" }, { "body": "@ffromani\r\n\r\n> Was this behavior you are fixing observed in the field?\r\n\r\nYes, it is. This is the error stack\r\n```\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: fatal error: concurrent map iteration and map write\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: goroutine 275 [running]:\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: k8s.io/kubernetes/pkg/kubelet/cm.(*containerManagerImpl).GetNodeAllocatableReservation(0xc00025cdc0)\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: pkg/kubelet/cm/node_container_manager_linux.go:231 +0xb6\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: k8s.io/kubernetes/pkg/kubelet/nodestatus.MachineInfo.func1({0x63638e0?, 0xc0005d5080?}, 0xc0005d5080)\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: pkg/kubelet/nodestatus/setters.go:344 +0x617\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: k8s.io/kubernetes/pkg/kubelet.(*Kubelet).setNodeStatus(0xc000d16c70?, {0x71e47e8, 0xc000134008}, 0x13?)\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: pkg/kubelet/kubelet_node_status.go:700 +0x254\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: k8s.io/kubernetes/pkg/kubelet.(*Kubelet).initialNode(0xc000021800, {0x71e47e8, 0xc000134008})\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: pkg/kubelet/kubelet_node_status.go:427 +0x1725\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: k8s.io/kubernetes/pkg/kubelet.(*Kubelet).registerWithAPIServer(0xc000021800)\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: pkg/kubelet/kubelet_node_status.go:64 +0x85\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: k8s.io/kubernetes/pkg/kubelet.(*Kubelet).syncNodeStatus(0xc000021800)\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: pkg/kubelet/kubelet_node_status.go:524 +0xe5\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1(0x2?)\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:157 +0x3e\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: k8s.io/apimachinery/pkg/util/wait.BackoffUntil(0x2?, {0x71b38a0, 0xc000b345d0}, 0x1, 0xc0002764e0)\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:158 +0xb6\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: k8s.io/apimachinery/pkg/util/wait.JitterUntil(0x2?, 0x2540be400, 0x3fa47ae147ae147b, 0xe0?, 0x2?)\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:135 +0x89\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: created by k8s.io/kubernetes/pkg/kubelet.(*Kubelet).Run\r\nJul 28 10:54:51 iZbp10bvltj11satfno9gpZ kubelet[1483]: pkg/kubelet/kubelet.go:1543 +0x49b\r\n```\r\n", "created_at": "2023-07-28 09:15:27" }, { "body": "/triage accepted\r\n/priority important-longterm\r\n\r\npriority subject to change pending further investigation and triage", "created_at": "2023-07-28 09:25:58" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119637#\" title=\"Author self-approved\">chenk008</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [yujuhong](https://github.com/yujuhong) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/kubelet/cm/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/cm/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"yujuhong\"]} -->", "created_at": "2023-07-31 07:06:49" }, { "body": "/retest", "created_at": "2023-07-31 11:34:19" }, { "body": "@chenk008: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-e2e-kind-ipv6 | 29c2f59099c44994457748c45cd35edf47ca13a3 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119637/pull-kubernetes-e2e-kind-ipv6/1685977247200055296) | true | `/test pull-kubernetes-e2e-kind-ipv6`\npull-kubernetes-e2e-capz-windows | 29c2f59099c44994457748c45cd35edf47ca13a3 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119637/pull-kubernetes-e2e-capz-windows/1685977247304912896) | false | `/test pull-kubernetes-e2e-capz-windows`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119637). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Achenk008). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-07-31 12:22:02" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:06:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:06:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:06:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:06:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:06:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:06:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:06:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:06:14", "type": "labeled" }, { "author": "chenk008", "created_at": "2023-07-28 04:06:15", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-28 04:06:15", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-28 04:06:31", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:06:42", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:06:42", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:07:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:07:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 04:07:12", "type": "unlabeled" }, { "author": "chenk008", "created_at": "2023-07-28 05:42:02", "type": "head_ref_force_pushed" }, { "author": "chenk008", "created_at": "2023-07-28 06:18:24", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 06:34:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 06:34:09", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:00:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:00:55", "type": "unlabeled" }, { "author": "ffromani", "created_at": "2023-07-28 09:15:27", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-07-28 09:15:28", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:26:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:26:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:26:02", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:26:03", "type": "unlabeled" }, { "author": "chenk008", "created_at": "2023-07-29 15:17:58", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 15:18:00", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 15:18:01", "type": "labeled" }, { "author": "chenk008", "created_at": "2023-07-29 15:24:53", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-29 15:24:53", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-29 15:25:07", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-29 15:25:07", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-29 15:25:22", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-29 15:25:22", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-29 15:25:34", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-29 15:25:34", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-29 15:25:36", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-29 15:25:36", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-29 15:26:28", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-29 15:26:28", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-29 15:26:49", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-29 15:26:49", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-29 15:28:30", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-29 15:28:30", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-29 15:56:02", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-29 15:56:02", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-29 16:09:39", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-29 16:09:39", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 01:32:53", "type": "head_ref_force_pushed" }, { "author": "chenk008", "created_at": "2023-07-31 01:39:55", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 01:39:55", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 01:40:28", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 01:40:28", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 01:42:24", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 01:42:24", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 01:42:28", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 01:42:28", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 01:42:34", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 01:42:34", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 01:43:33", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 01:43:33", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 01:45:29", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 01:45:29", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 02:12:19", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 02:12:19", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 02:24:17", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 02:24:17", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 02:25:19", "type": "head_ref_force_pushed" }, { "author": "chenk008", "created_at": "2023-07-31 02:35:03", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 02:35:03", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 02:43:40", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 02:43:40", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 02:44:08", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 02:44:08", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 02:44:36", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 02:44:36", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 02:45:07", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 02:45:07", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 02:50:14", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 02:50:14", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 03:02:01", "type": "head_ref_force_pushed" }, { "author": "chenk008", "created_at": "2023-07-31 03:12:13", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 03:12:13", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 03:20:29", "type": "head_ref_force_pushed" }, { "author": "chenk008", "created_at": "2023-07-31 03:44:55", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 03:44:55", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 03:44:56", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 03:44:56", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 03:44:59", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 03:45:00", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 03:45:01", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 03:45:01", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 03:59:35", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 03:59:35", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 04:33:52", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 04:33:52", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 07:06:13", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 07:06:15", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 07:06:16", "type": "labeled" }, { "author": "chenk008", "created_at": "2023-07-31 07:35:03", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 07:35:03", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 07:36:00", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 07:36:00", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 07:47:00", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 07:47:00", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 08:05:20", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 08:05:20", "type": "subscribed" }, { "author": "toVersus", "created_at": "2023-07-31 08:39:41", "type": "unsubscribed" }, { "author": "chenk008", "created_at": "2023-07-31 12:04:28", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 12:04:28", "type": "subscribed" }, { "author": "chenk008", "created_at": "2023-07-31 12:22:02", "type": "mentioned" }, { "author": "chenk008", "created_at": "2023-07-31 12:22:02", "type": "subscribed" } ]

[ "dims" ]

[ "kind/bug", "area/test", "priority/important-soon", "lgtm", "size/S", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Jul 27 22:10:08 UTC 2023.\n", "created_at": "2023-07-28 01:29:58" }, { "body": "/triage accepted\r\n/priority important-soon\r\n", "created_at": "2023-07-28 02:02:30" }, { "body": "/approve\r\n/lgtm", "created_at": "2023-07-28 02:03:40" }, { "body": "LGTM label has been added. <details>Git tree hash: e4dabc291c857165cf9799f60de6014dfb11e2ab</details>", "created_at": "2023-07-28 02:03:47" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119636#issuecomment-1654867557\" title=\"LGTM\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119636#\" title=\"Author self-approved\">tzneal</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/images/busybox/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/images/busybox/OWNERS)~~ [dims]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-07-28 02:04:01" }, { "body": "/retest", "created_at": "2023-07-28 02:50:38" }, { "body": "Is this target v1.28 or v1.29?", "created_at": "2023-07-31 08:38:10" }, { "body": "@pacoxu we are way too late for 1.28, so for 1.29", "created_at": "2023-07-31 11:34:30" }, { "body": "Yup, agreed. Not sure if I have permissions, but:\r\n\r\n/milestone 1.29", "created_at": "2023-07-31 12:44:10" }, { "body": "@tzneal: You must be a member of the [kubernetes/milestone-maintainers](https://github.com/orgs/kubernetes/teams/milestone-maintainers/members) GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119636#issuecomment-1658304219):\n\n>Yup, agreed. Not sure if I have permissions, but:\r\n>\r\n>/milestone 1.29\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-31 12:44:11" }, { "body": "/milestone 1.29", "created_at": "2023-07-31 17:49:42" }, { "body": "@dims: The provided milestone is not valid for this repository. Milestones in this repository: [`next-candidate`, `v1.16`, `v1.17`, `v1.18`, `v1.19`, `v1.20`, `v1.21`, `v1.22`, `v1.23`, `v1.24`, `v1.25`, `v1.26`, `v1.27`, `v1.28`]\n\nUse `/milestone clear` to clear the milestone.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119636#issuecomment-1658879753):\n\n>/milestone 1.29\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-31 17:49:44" }, { "body": "quick search revealed another busybox mention here: https://github.com/kubernetes/kubernetes/blob/dfe6685f0f98854e7ab8c78523ca2036e1dbc357/test/images/httpd/BASEIMAGE#L6 Maybe more. Should we add them to dependencies under hack to keep consistent?", "created_at": "2023-08-02 17:17:39" }, { "body": "Would it be possible to backport this into v1.28 and v1.27. We've discovered an issue with the busybox-1.29 image causing problems on linux/ppc64le when scheduled in privileged containers on a node with an selinux policy that sets selinuxuser_execmod to off.", "created_at": "2023-08-14 23:39:02" }, { "body": "> Maybe more. Should we add them to dependencies under hack to keep consistent?\r\n\r\nI'm not 100% convinced. That particular test image has a mixture of sources:\r\n\r\n```\r\n$ cat test/images/httpd/BASEIMAGE\r\nlinux/amd64=httpd:2.4.38-alpine\r\nlinux/arm=arm32v6/httpd:2.4.38-alpine\r\nlinux/arm64=arm64v8/httpd:2.4.38-alpine\r\nlinux/ppc64le=ppc64le/httpd:2.4.38-alpine\r\nlinux/s390x=s390x/httpd:2.4.38-alpine\r\nwindows/amd64/1809=REGISTRY/busybox:1.29-2-windows-amd64-1809\r\nwindows/amd64/ltsc2022=REGISTRY/busybox:1.29-2-windows-amd64-ltsc2022\r\n```\r\n\r\nthe busybox image itself is also a mixture:\r\n\r\n```\r\n$ cat test/images/busybox/BASEIMAGE\r\nlinux/amd64=busybox:1.29\r\nlinux/arm=arm32v6/busybox:1.29\r\nlinux/arm64=arm64v8/busybox:1.29\r\nlinux/ppc64le=ppc64le/busybox:1.29\r\nlinux/s390x=s390x/busybox:1.29\r\nwindows/amd64/1809=mcr.microsoft.com/windows/nanoserver:1809\r\nwindows/amd64/ltsc2022=mcr.microsoft.com/windows/nanoserver:ltsc2022\r\n```", "created_at": "2023-08-15 13:09:23" }, { "body": "> Would it be possible to backport this into v1.28 and v1.27\r\n\r\nI'm not entirely sure of the policy, but I'll create cherry-pick CRs once this is in and see.", "created_at": "2023-08-15 13:10:00" }, { "body": "> > Would it be possible to backport this into v1.28 and v1.27\r\n> \r\n> I'm not entirely sure of the policy, but I'll create cherry-pick CRs once this is in and see.\r\n\r\nCherrypick is not required for this code because this is just for building image, we need to update the manifest [here](https://github.com/kubernetes/kubernetes/blob/ad150771936bdd2594b545c6932ae46d8fec4e62/test/utils/image/manifest.go#L241) and cherrypick that one.", "created_at": "2023-08-16 05:24:12" }, { "body": "> > > Would it be possible to backport this into v1.28 and v1.27\r\n> > \r\n> > \r\n> > I'm not entirely sure of the policy, but I'll create cherry-pick CRs once this is in and see.\r\n> \r\n> Cherrypick is not required for this code because this is just for building image, we need to update the manifest [here](https://github.com/kubernetes/kubernetes/blob/ad150771936bdd2594b545c6932ae46d8fec4e62/test/utils/image/manifest.go#L241) and cherrypick that one.\r\n\r\nAh, that's right. Thanks! Verifying locally and submitting the PR soon.", "created_at": "2023-08-16 12:30:17" }, { "body": "I read the criteria at https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md#what-kind-of-prs-are-good-for-cherry-picks and I don't think this would meet the bar for a cherry-pick.\r\n\r\n> Compared to the normal master branch's merge volume across time, the release branches see one or two orders of magnitude less PRs. This is because there is an order or two of magnitude higher scrutiny. Again, the emphasis is on critical bug fixes, e.g.,\r\n>\r\n> Loss of data\r\n Memory corruption\r\n Panic, crash, hang\r\n Security\r\n", "created_at": "2023-08-17 00:27:45" }, { "body": "@tzneal thanks for checking this! very much appreciated!", "created_at": "2023-08-17 13:33:50" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:29:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:29:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:29:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:29:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:30:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:30:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:30:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:30:51", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:30:51", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:31:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:31:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:31:05", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 02:02:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 02:02:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 02:02:33", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 02:02:34", "type": "unlabeled" }, { "author": "tzneal", "created_at": "2023-07-28 02:03:00", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-07-28 02:03:00", "type": "subscribed" }, { "author": "dims", "created_at": "2023-07-28 02:03:45", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 02:03:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 02:04:02", "type": "labeled" }, { "author": "pacoxu", "created_at": "2023-07-31 11:34:30", "type": "mentioned" }, { "author": "pacoxu", "created_at": "2023-07-31 11:34:30", "type": "subscribed" }, { "author": "tzneal", "created_at": "2023-07-31 12:44:12", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-07-31 12:44:12", "type": "subscribed" }, { "author": "dims", "created_at": "2023-07-31 17:49:45", "type": "mentioned" }, { "author": "dims", "created_at": "2023-07-31 17:49:45", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 02:43:25", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 02:43:25", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 02:43:25", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 02:43:27", "type": "milestoned" }, { "author": "tzneal", "created_at": "2023-08-16 12:30:19", "type": "head_ref_deleted" }, { "author": "tzneal", "created_at": "2023-08-17 13:33:51", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-08-17 13:33:51", "type": "subscribed" } ]

[]

[ "kind/bug", "area/test", "size/S", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Jul 27 22:10:08 UTC 2023.\n", "created_at": "2023-07-28 01:09:34" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 01:09:38" }, { "body": "/sig testing", "created_at": "2023-07-28 01:09:55" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119635#\" title=\"Author self-approved\">dims</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/images/busybox/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/images/busybox/OWNERS)~~ [dims]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-07-28 01:14:29" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:09:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:09:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:09:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:09:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:09:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:09:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:09:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:09:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:09:58", "type": "unlabeled" }, { "author": "dims", "created_at": "2023-07-28 01:14:19", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:14:29", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:14:29", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:14:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 01:14:30", "type": "labeled" } ]

[ "dims", "liggitt", "enj", "xmudrii", "gracenng" ]

[ "kind/bug", "lgtm", "size/XS", "area/release-eng", "release-note-none", "sig/auth", "approved", "cncf-cla: yes", "sig/release", "needs-priority", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Jul 27 22:10:08 UTC 2023.\n", "created_at": "2023-07-28 00:08:56" }, { "body": "/sig auth", "created_at": "2023-07-28 00:09:35" }, { "body": "/kind bug\r\n/milestone v1.28\r\n", "created_at": "2023-07-28 00:11:30" }, { "body": "/assign @gracenng @enj ", "created_at": "2023-07-28 00:12:34" }, { "body": "/approve\r\n/lgtm", "created_at": "2023-07-28 00:12:40" }, { "body": "LGTM label has been added. <details>Git tree hash: 5492707befafabca8c3bcee657a59b7485edb744</details>", "created_at": "2023-07-28 00:12:47" }, { "body": "/lgtm", "created_at": "2023-07-28 01:43:38" }, { "body": "/cc @kubernetes/sig-auth-leads ", "created_at": "2023-07-31 08:04:08" }, { "body": "@furkatgofurov7: GitHub didn't allow me to request PR reviews from the following users: kubernetes/sig-auth-leads.\n\nNote that only [kubernetes members](https://github.com/orgs/kubernetes/people) and repo collaborators can review this PR, and authors cannot review their own PRs.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119634#issuecomment-1657872638):\n\n>/cc @kubernetes/sig-auth-leads \n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-31 08:04:10" }, { "body": "/cc @deads2k @ritazh @liggitt \r\n\r\nhey folks, please take a look when you have some spare time, as this is targeting v1.28 and an urgent one to take it in, thank you!", "created_at": "2023-07-31 08:05:40" }, { "body": "/triage accepted", "created_at": "2023-07-31 08:06:18" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-07-31 13:02:00" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119634#\" title=\"Author self-approved\">aramase</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119634#issuecomment-1654786336\" title=\"LGTM\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119634#issuecomment-1658331583\" title=\"Approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119634#pullrequestreview-1554831752\" title=\"Approved\">sanchita-07</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119634#pullrequestreview-1554747690\" title=\"Approved\">xmudrii</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[CHANGELOG/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/OWNERS)~~ [xmudrii]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-07-31 13:53:28" }, { "body": "/pull-kubernetes-e2e-kind-ipv6", "created_at": "2023-07-31 14:19:50" }, { "body": "/retest", "created_at": "2023-07-31 14:20:38" }, { "body": "/retest", "created_at": "2023-07-31 15:24:05" }, { "body": "/retest\r\n\r\n", "created_at": "2023-07-31 16:11:53" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:08:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:08:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:08:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:08:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:09:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:09:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:09:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:09:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:09:38", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:10:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:10:26", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:11:32", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:11:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:11:34", "type": "unlabeled" }, { "author": "enj", "created_at": "2023-07-28 00:12:34", "type": "mentioned" }, { "author": "enj", "created_at": "2023-07-28 00:12:34", "type": "subscribed" }, { "author": "gracenng", "created_at": "2023-07-28 00:12:34", "type": "mentioned" }, { "author": "gracenng", "created_at": "2023-07-28 00:12:34", "type": "subscribed" }, { "author": "enj", "created_at": "2023-07-28 00:12:35", "type": "assigned" }, { "author": "gracenng", "created_at": "2023-07-28 00:12:35", "type": "assigned" }, { "author": "dims", "created_at": "2023-07-28 00:12:44", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:12:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:14:22", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:14:22", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:14:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:14:23", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-07-31 08:04:09", "type": "subscribed" }, { "author": "mikedanese", "created_at": "2023-07-31 08:04:09", "type": "subscribed" }, { "author": "ritazh", "created_at": "2023-07-31 08:04:09", "type": "subscribed" }, { "author": "enj", "created_at": "2023-07-31 08:04:09", "type": "subscribed" }, { "author": "deads2k", "created_at": "2023-07-31 08:04:09", "type": "subscribed" }, { "author": "furkatgofurov7", "created_at": "2023-07-31 08:04:10", "type": "mentioned" }, { "author": "furkatgofurov7", "created_at": "2023-07-31 08:04:10", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-07-31 08:04:11", "type": "subscribed" }, { "author": "mikedanese", "created_at": "2023-07-31 08:04:12", "type": "subscribed" }, { "author": "ritazh", "created_at": "2023-07-31 08:04:12", "type": "subscribed" }, { "author": "enj", "created_at": "2023-07-31 08:04:12", "type": "subscribed" }, { "author": "deads2k", "created_at": "2023-07-31 08:04:12", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-07-31 08:05:40", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-07-31 08:05:41", "type": "subscribed" }, { "author": "ritazh", "created_at": "2023-07-31 08:05:41", "type": "mentioned" }, { "author": "ritazh", "created_at": "2023-07-31 08:05:41", "type": "subscribed" }, { "author": "deads2k", "created_at": "2023-07-31 08:05:41", "type": "mentioned" }, { "author": "deads2k", "created_at": "2023-07-31 08:05:41", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 08:05:41", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 08:05:42", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 08:05:42", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 08:06:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 08:06:22", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-07-31 13:02:06", "type": "assigned" }, { "author": "fsmunoz", "created_at": "2023-07-31 13:14:54", "type": "subscribed" }, { "author": "AnaMMedina21", "created_at": "2023-07-31 13:14:54", "type": "subscribed" }, { "author": "rashansmith", "created_at": "2023-07-31 13:14:54", "type": "subscribed" }, { "author": "muddapu", "created_at": "2023-07-31 13:14:54", "type": "subscribed" }, { "author": "sanchita-07", "created_at": "2023-07-31 13:14:54", "type": "subscribed" }, { "author": "xmudrii", "created_at": "2023-07-31 13:14:57", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 13:15:15", "type": "labeled" }, { "author": "aramase", "created_at": "2023-07-31 14:11:36", "type": "mentioned" }, { "author": "aramase", "created_at": "2023-07-31 14:11:36", "type": "subscribed" }, { "author": "aramase", "created_at": "2023-07-31 14:50:31", "type": "mentioned" }, { "author": "aramase", "created_at": "2023-07-31 14:50:31", "type": "subscribed" }, { "author": "aramase", "created_at": "2023-07-31 14:52:54", "type": "mentioned" }, { "author": "aramase", "created_at": "2023-07-31 14:52:54", "type": "subscribed" }, { "author": "aramase", "created_at": "2023-07-31 15:55:04", "type": "mentioned" }, { "author": "aramase", "created_at": "2023-07-31 15:55:04", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 16:44:39", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 16:44:39", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 16:44:40", "type": "closed" }, { "author": "aramase", "created_at": "2023-07-31 16:50:01", "type": "head_ref_deleted" } ]

[]

[ "kind/bug", "needs-sig", "needs-triage" ]

[ { "body": "There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:\n- `/sig <group-name>`\n- `/wg <group-name>`\n- `/committee <group-name>`\n\nPlease see the [group list](https://git.k8s.io/community/sig-list.md) for a listing of the SIGs, working groups, and committees available.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 23:31:17" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 23:31:19" }, { "body": "https://github.com/kubernetes/kubernetes/blob/master/SUPPORT.md\r\n\r\n/close", "created_at": "2023-07-28 00:44:17" }, { "body": "@dims: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119633#issuecomment-1654810538):\n\n>https://github.com/kubernetes/kubernetes/blob/master/SUPPORT.md\r\n>\r\n>/close\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-28 00:44:21" } ]

[ { "author": "quetdn", "created_at": "2023-07-27 23:31:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 23:31:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 23:31:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:44:21", "type": "closed" }, { "author": "dims", "created_at": "2023-07-28 00:44:22", "type": "mentioned" }, { "author": "dims", "created_at": "2023-07-28 00:44:22", "type": "subscribed" } ]

[]

[ "sig/security", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 22:55:47" }, { "body": "/sig security", "created_at": "2023-07-27 22:55:48" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 22:55:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 22:55:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 22:55:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 22:55:50", "type": "unlabeled" } ]

[ "carlory" ]

[ "sig/security", "needs-triage" ]

[ { "body": "/sig security", "created_at": "2023-07-27 22:10:13" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 22:10:15" }, { "body": "/assign", "created_at": "2023-07-28 03:11:48" }, { "body": "fixed in https://github.com/kubernetes/kubernetes/pull/116785 and latest 1.24+ patch releases", "created_at": "2023-08-01 15:42:05" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 22:10:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 22:10:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 22:10:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 22:10:16", "type": "unlabeled" }, { "author": "carlory", "created_at": "2023-07-28 03:11:49", "type": "assigned" }, { "author": "liggitt", "created_at": "2023-08-01 15:42:07", "type": "closed" } ]

[ "carlory" ]

[ "sig/security", "needs-triage" ]

[ { "body": "/sig security", "created_at": "2023-07-27 21:59:11" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 21:59:12" }, { "body": "/assign", "created_at": "2023-07-28 03:03:56" }, { "body": "Hi @reylejano \r\n\r\nIt has been fixed in https://github.com/kubernetes/kubernetes/pull/117041 and released in 1.24.13. So I'm wondering what we should do with this issue. Should we close it?", "created_at": "2023-07-28 03:40:47" }, { "body": "cc @enj for confirmation. ", "created_at": "2023-07-28 06:10:11" }, { "body": "yes, fixed in https://github.com/kubernetes/kubernetes/pull/117023 and latest 1.24+ patch releases", "created_at": "2023-08-01 15:41:13" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:59:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:59:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:59:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:59:14", "type": "unlabeled" }, { "author": "carlory", "created_at": "2023-07-28 03:03:57", "type": "assigned" }, { "author": "reylejano", "created_at": "2023-07-28 03:40:48", "type": "mentioned" }, { "author": "reylejano", "created_at": "2023-07-28 03:40:48", "type": "subscribed" }, { "author": "enj", "created_at": "2023-07-28 06:10:12", "type": "mentioned" }, { "author": "enj", "created_at": "2023-07-28 06:10:12", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-01 15:41:15", "type": "closed" } ]

[ "Richabanker" ]

[ "sig/api-machinery", "sig/security", "triage/accepted" ]

[ { "body": "/sig security", "created_at": "2023-07-27 21:56:00" }, { "body": "@reylejano Can you give an example of the situation where the obtained `X-Forwarded-Uri` is inaccurate?", "created_at": "2023-07-29 15:05:57" }, { "body": "/sig api-machinery", "created_at": "2023-08-01 15:39:52" }, { "body": "/assign @Richabanker \r\nI recall you have context of the API server proxy. Could you take a look.\r\n/triage accepted", "created_at": "2023-08-03 16:52:51" }, { "body": "@reylejano thanks for the issue. As @lengrongfu asked, could you please provide an example of the incorrect value for the `X-Forwarded-Uri` header after the path.Join() processing? \r\nI understand that the raw URL is processed to better represent a clean concise url (after constructing the url from the path strings, separating them by `/` and then [cleaning](https://pkg.go.dev/path#Clean) the result ) but am unsure about the incorrect implications for this?", "created_at": "2023-08-07 17:50:17" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:56:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:56:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:56:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:56:03", "type": "unlabeled" }, { "author": "reylejano", "created_at": "2023-07-29 15:05:58", "type": "mentioned" }, { "author": "reylejano", "created_at": "2023-07-29 15:05:58", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 15:39:54", "type": "labeled" }, { "author": "Richabanker", "created_at": "2023-08-03 16:52:51", "type": "mentioned" }, { "author": "Richabanker", "created_at": "2023-08-03 16:52:52", "type": "subscribed" }, { "author": "Richabanker", "created_at": "2023-08-03 16:52:52", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:52:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:52:54", "type": "unlabeled" }, { "author": "lengrongfu", "created_at": "2023-08-07 17:50:17", "type": "mentioned" }, { "author": "lengrongfu", "created_at": "2023-08-07 17:50:17", "type": "subscribed" }, { "author": "reylejano", "created_at": "2023-08-07 17:50:17", "type": "mentioned" }, { "author": "reylejano", "created_at": "2023-08-07 17:50:17", "type": "subscribed" } ]

[]

[ "sig/api-machinery", "sig/auth", "sig/security", "needs-triage" ]

[ { "body": "/sig security", "created_at": "2023-07-27 21:50:03" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 21:50:04" }, { "body": "/sig auth\r\n/sig api-machinery", "created_at": "2023-08-01 15:05:37" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:50:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:50:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:50:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:50:06", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 15:05:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 15:05:42", "type": "labeled" } ]

[ "carlory" ]

[ "sig/storage", "sig/security", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 21:44:12" }, { "body": "/sig security", "created_at": "2023-07-27 21:44:12" }, { "body": "/assign", "created_at": "2023-07-28 03:06:50" }, { "body": "/sig storage", "created_at": "2023-07-28 06:34:44" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:44:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:44:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:44:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:44:15", "type": "unlabeled" }, { "author": "carlory", "created_at": "2023-07-28 03:06:51", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 06:34:46", "type": "labeled" } ]

[ "carlory" ]

[ "sig/auth", "sig/security", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 21:37:24" }, { "body": "/sig security", "created_at": "2023-07-27 21:39:06" }, { "body": "/assign", "created_at": "2023-07-28 03:05:00" }, { "body": "nit: please change `(e.g. default/audittest)` to `(e.g. default/audit-test)` in Reproduction Steps", "created_at": "2023-07-28 06:42:59" }, { "body": "/sig auth", "created_at": "2023-08-01 15:38:27" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:37:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:37:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:39:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:39:09", "type": "unlabeled" }, { "author": "carlory", "created_at": "2023-07-28 03:05:01", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 15:38:29", "type": "labeled" } ]

[]

[ "sig/api-machinery", "sig/security", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 21:30:22" }, { "body": "/sig security", "created_at": "2023-07-27 21:30:33" }, { "body": "/sig api-machinery", "created_at": "2023-08-01 15:38:21" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:30:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:30:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:30:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:30:36", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 15:38:22", "type": "labeled" } ]

[ "thockin", "aojea", "xmudrii" ]

[ "kind/bug", "priority/critical-urgent", "kind/documentation", "lgtm", "size/XS", "area/release-eng", "release-note-none", "approved", "cncf-cla: yes", "sig/release", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Jul 27 16:10:38 UTC 2023.\n", "created_at": "2023-07-27 17:50:36" }, { "body": "/assign @thockin @aojea ", "created_at": "2023-07-27 17:50:43" }, { "body": "/milestone v1.28", "created_at": "2023-07-27 17:55:38" }, { "body": "xref: https://github.com/kubernetes/kubernetes/pull/117696", "created_at": "2023-07-27 17:57:02" }, { "body": "/lgtm\r\n/approve", "created_at": "2023-07-27 20:19:43" }, { "body": "LGTM label has been added. <details>Git tree hash: 359556f7055fa629073ee3ea61b69b54f8877cc6</details>", "created_at": "2023-07-27 20:19:50" }, { "body": "/priority critical-urgent\r\n/triage accepted", "created_at": "2023-07-27 21:29:22" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119624#issuecomment-1654510726\" title=\"Approved\">aojea</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119624#\" title=\"Author self-approved\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119624#pullrequestreview-1551506984\" title=\"Approved\">saschagrunert</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119624#pullrequestreview-1551034005\" title=\"Approved\">thockin</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119624#pullrequestreview-1550830743\" title=\"Approved\">xmudrii</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[CHANGELOG/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/OWNERS)~~ [saschagrunert,xmudrii]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-07-28 07:15:18" }, { "body": "/hold cancel", "created_at": "2023-07-29 03:49:48" }, { "body": "/retest", "created_at": "2023-07-31 00:34:44" }, { "body": "/retest", "created_at": "2023-07-31 05:56:28" }, { "body": "They will get reflected in the CHANGELOG.md once [this](https://github.com/kubernetes/sig-release/pull/2296/files#diff-d7f5705b1a6f61c7bb81089eb94f0bf632d1e729d26e8a2731cfdc8520f992d0) gets merged.", "created_at": "2023-07-31 06:08:28" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 17:50:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 17:50:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 17:50:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 17:50:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 17:50:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 17:50:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 17:50:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 17:50:41", "type": "labeled" }, { "author": "thockin", "created_at": "2023-07-27 17:50:43", "type": "mentioned" }, { "author": "thockin", "created_at": "2023-07-27 17:50:43", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-07-27 17:50:43", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-07-27 17:50:43", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-07-27 17:50:44", "type": "assigned" }, { "author": "thockin", "created_at": "2023-07-27 17:50:44", "type": "assigned" }, { "author": "dims", "created_at": "2023-07-27 17:51:02", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 17:51:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 17:51:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 17:51:11", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 17:51:36", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 17:51:36", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 17:55:39", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:19:49", "type": "labeled" }, { "author": "neoaggelos", "created_at": "2023-07-27 21:28:45", "type": "subscribed" }, { "author": "mickeyboxell", "created_at": "2023-07-27 21:28:45", "type": "subscribed" }, { "author": "marosset", "created_at": "2023-07-27 21:28:45", "type": "subscribed" }, { "author": "helayoty", "created_at": "2023-07-27 21:28:45", "type": "subscribed" }, { "author": "fsmunoz", "created_at": "2023-07-27 21:28:45", "type": "subscribed" }, { "author": "gracenng", "created_at": "2023-07-27 21:28:45", "type": "subscribed" }, { "author": "AnaMMedina21", "created_at": "2023-07-27 21:28:46", "type": "subscribed" }, { "author": "leonardpahlke", "created_at": "2023-07-27 21:28:46", "type": "subscribed" }, { "author": "rashansmith", "created_at": "2023-07-27 21:28:46", "type": "subscribed" }, { "author": "muddapu", "created_at": "2023-07-27 21:28:46", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:28:46", "type": "labeled" }, { "author": "sanchita-07", "created_at": "2023-07-27 21:28:46", "type": "subscribed" }, { "author": "xmudrii", "created_at": "2023-07-27 21:28:49", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:28:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:29:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:29:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:29:25", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:29:26", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 03:49:50", "type": "unlabeled" }, { "author": "dims", "created_at": "2023-07-29 04:24:05", "type": "mentioned" }, { "author": "dims", "created_at": "2023-07-29 04:24:05", "type": "subscribed" }, { "author": "dims", "created_at": "2023-07-29 04:51:03", "type": "mentioned" }, { "author": "dims", "created_at": "2023-07-29 04:51:03", "type": "subscribed" }, { "author": "dims", "created_at": "2023-07-31 01:01:32", "type": "mentioned" }, { "author": "dims", "created_at": "2023-07-31 01:01:32", "type": "subscribed" }, { "author": "dims", "created_at": "2023-07-31 01:08:08", "type": "mentioned" }, { "author": "dims", "created_at": "2023-07-31 01:08:08", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 06:28:02", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 06:28:02", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 06:28:02", "type": "closed" } ]

[ "jayunit100" ]

[ "area/test", "sig/network", "kind/cleanup", "lgtm", "size/XS", "release-note-none", "cncf-cla: yes", "sig/testing", "ok-to-test", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Jul 27 16:10:38 UTC 2023.\n", "created_at": "2023-07-27 16:30:11" }, { "body": "Welcome @pramitagautam! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:", "created_at": "2023-07-27 16:30:15" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 16:30:16" }, { "body": "Hi @pramitagautam. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-27 16:30:16" }, { "body": "Tested and can confirm that code created deployment instead of replication controller\r\n\r\n```\r\n>> % kubectl get pods -A -o wide\r\nNAMESPACE NAME READY STATUS RESTARTS AGE IP NODE NOMINATED NODE READINESS GATES\r\nkube-system aws-node-5p64k 1/1 Running 0 4d6h 192.168.91.129 ip-192-168-91-129.ap-south-1.compute.internal <none> <none>\r\nkube-system coredns-6db85c8f99-qcdwf 1/1 Running 0 4d6h 192.168.72.60 ip-192-168-91-129.ap-south-1.compute.internal <none> <none>\r\nkube-system coredns-6db85c8f99-vtq26 1/1 Running 0 4d6h 192.168.81.174 ip-192-168-91-129.ap-south-1.compute.internal <none> <none>\r\nkube-system kube-proxy-lcn8f 1/1 Running 0 4d6h 192.168.91.129 ip-192-168-91-129.ap-south-1.compute.internal <none> <none>\r\nservices-1162 up-down-1-5f67465fb5-dhnk4 0/1 ContainerCreating 0 14s <none> ip-192-168-52-16.ap-south-1.compute.internal <none> <none>\r\nservices-1162 up-down-1-5f67465fb5-h6wq4 1/1 Running 0 14s 192.168.85.82 ip-192-168-91-129.ap-south-1.compute.internal <none> <none>\r\nservices-1162 up-down-1-5f67465fb5-jqrdp 0/1 ContainerCreating 0 14s <none> ip-192-168-52-16.ap-south-1.compute.internal <none> <none>\r\n>> kubectl get deploy -A -o wide\r\nNAMESPACE NAME READY UP-TO-DATE AVAILABLE AGE CONTAINERS IMAGES SELECTOR\r\nkube-system coredns 2/2 2 2 4d6h coredns 602401143452.dkr.ecr.ap-south-1.amazonaws.com/eks/coredns:v1.9.3-eksbuild.2 eks.amazonaws.com/component=coredns,k8s-app=kube-dns\r\nservices-1162 up-down-1 1/3 3 1 21s up-down-1 registry.k8s.io/e2e-test-images/agnhost:2.45 name=up-down-1\r\n```", "created_at": "2023-07-27 16:33:19" }, { "body": "/ok-to-test", "created_at": "2023-07-27 16:48:12" }, { "body": "/retest", "created_at": "2023-07-27 17:28:56" }, { "body": "@pramitagautam Thanks 👍. Appreciated if you can fill the PR template with some details and link the issue in `Fixes` section..etc. ", "created_at": "2023-07-28 02:44:53" }, { "body": "/release-note-none\r\n", "created_at": "2023-07-28 02:49:36" }, { "body": "/lgtm\r\n/approve ", "created_at": "2023-07-28 14:51:01" }, { "body": "LGTM label has been added. <details>Git tree hash: 663eeeaf1eda26ca01aca1a733ba768ecafc217b</details>", "created_at": "2023-07-28 14:51:08" }, { "body": "/approve", "created_at": "2023-07-31 18:54:52" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119623#issuecomment-1658964642\" title=\"Approved\">jayunit100</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119623#\" title=\"Author self-approved\">pramitagautam</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [robscott](https://github.com/robscott) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[test/e2e/network/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/network/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"robscott\"]} -->", "created_at": "2023-07-31 18:55:21" }, { "body": "/cc @aojea", "created_at": "2023-07-31 18:58:15" }, { "body": "/milestone 1.29\r\n\r\nThis has to wait for 1.29 https://www.kubernetes.dev/resources/release/ is not a regression neither critical", "created_at": "2023-08-01 07:59:46" }, { "body": "@aojea: The provided milestone is not valid for this repository. Milestones in this repository: [`next-candidate`, `v1.16`, `v1.17`, `v1.18`, `v1.19`, `v1.20`, `v1.21`, `v1.22`, `v1.23`, `v1.24`, `v1.25`, `v1.26`, `v1.27`, `v1.28`]\n\nUse `/milestone clear` to clear the milestone.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119623#issuecomment-1659772226):\n\n>/milestone 1.29\r\n>\r\n>This has to wait for 1.29 https://www.kubernetes.dev/resources/release/ is not a regression neither critical\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-01 07:59:47" }, { "body": "/milestone v1.29", "created_at": "2023-08-01 08:00:01" }, { "body": "@aojea: The provided milestone is not valid for this repository. Milestones in this repository: [`next-candidate`, `v1.16`, `v1.17`, `v1.18`, `v1.19`, `v1.20`, `v1.21`, `v1.22`, `v1.23`, `v1.24`, `v1.25`, `v1.26`, `v1.27`, `v1.28`]\n\nUse `/milestone clear` to clear the milestone.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119623#issuecomment-1659772651):\n\n>/milestone v1.29\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-01 08:00:03" }, { "body": "/milestone next-candidate", "created_at": "2023-08-01 08:00:17" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:30:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:30:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:30:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:30:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:30:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:30:15", "type": "labeled" }, { "author": "pramitagautam", "created_at": "2023-07-27 16:30:15", "type": "mentioned" }, { "author": "pramitagautam", "created_at": "2023-07-27 16:30:15", "type": "subscribed" }, { "author": "pramitagautam", "created_at": "2023-07-27 16:30:16", "type": "mentioned" }, { "author": "pramitagautam", "created_at": "2023-07-27 16:30:16", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:30:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:30:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:30:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:30:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:30:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:30:48", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:31:11", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:31:11", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:48:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:48:15", "type": "unlabeled" }, { "author": "pramitagautam", "created_at": "2023-07-27 17:18:05", "type": "mentioned" }, { "author": "pramitagautam", "created_at": "2023-07-27 17:18:05", "type": "subscribed" }, { "author": "pramitagautam", "created_at": "2023-07-27 17:20:28", "type": "mentioned" }, { "author": "pramitagautam", "created_at": "2023-07-27 17:20:28", "type": "subscribed" }, { "author": "pramitagautam", "created_at": "2023-07-28 02:44:53", "type": "mentioned" }, { "author": "pramitagautam", "created_at": "2023-07-28 02:44:53", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 02:49:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 02:49:38", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 02:56:58", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 02:56:59", "type": "unlabeled" }, { "author": "jayunit100", "created_at": "2023-07-28 14:51:06", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 14:51:07", "type": "labeled" }, { "author": "aojea", "created_at": "2023-07-31 18:58:16", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-07-31 18:58:16", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 18:58:16", "type": "review_requested" }, { "author": "aojea", "created_at": "2023-08-01 07:59:47", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-01 07:59:48", "type": "subscribed" }, { "author": "aojea", "created_at": "2023-08-01 08:00:03", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-01 08:00:03", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 08:00:19", "type": "milestoned" } ]

[ "bart0sh", "xmudrii" ]

[ "area/test", "priority/backlog", "kind/cleanup", "lgtm", "sig/node", "size/M", "cherry-pick-approved", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "triage/accepted" ]

[ { "body": "/triage accepted", "created_at": "2023-07-28 13:07:21" }, { "body": "/kind cleanup", "created_at": "2023-07-28 13:09:34" }, { "body": "/priority backlog\r\n/lgtm\r\n/release-note-none\r\n/cc kubernetes/release-managers", "created_at": "2023-07-31 10:04:14" }, { "body": "LGTM label has been added. <details>Git tree hash: 3a5551feaaa0d7b2cd60ede1feaae55346147247</details>", "created_at": "2023-07-31 10:04:22" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119622#\" title=\"Author self-approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119622#pullrequestreview-1558635823\" title=\"Approved\">xmudrii</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e_node/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.25/test/e2e_node/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-02 09:50:36" }, { "body": "/retest", "created_at": "2023-08-02 14:51:22" }, { "body": "/test pull-kubernetes-e2e-kind-ipv6", "created_at": "2023-08-02 15:25:38" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:11:25", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:11:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:11:25", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-07-27 16:11:26", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-07-27 16:11:26", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:11:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:11:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:11:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:11:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:11:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:12:05", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:12:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:12:05", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:12:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:12:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:12:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:12:08", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-07-27 16:23:03", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-07-27 16:23:03", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-07-27 16:24:02", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-07-27 16:24:02", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-07-27 16:25:36", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-07-27 16:25:36", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-07-27 16:33:16", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-07-27 16:33:16", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-07-27 17:02:39", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-07-27 17:02:39", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-07-27 21:34:33", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:34:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:07:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:07:25", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:09:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:09:38", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:04:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:04:15", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:04:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:04:16", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:04:18", "type": "unlabeled" }, { "author": "bart0sh", "created_at": "2023-07-31 10:04:19", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:04:20", "type": "labeled" }, { "author": "xmudrii", "created_at": "2023-08-02 09:50:16", "type": "assigned" }, { "author": "xmudrii", "created_at": "2023-08-02 09:50:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 09:50:33", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-02 15:25:03", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-02 15:25:04", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 16:04:41", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 16:04:41", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 16:04:41", "type": "closed" }, { "author": "liggitt", "created_at": "2023-08-10 15:27:25", "type": "head_ref_deleted" } ]

[ "bart0sh", "xmudrii" ]

[ "area/test", "priority/backlog", "kind/cleanup", "lgtm", "sig/node", "size/M", "cherry-pick-approved", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "triage/accepted" ]

[ { "body": "/triage accepted", "created_at": "2023-07-28 13:07:18" }, { "body": "/kind cleanup", "created_at": "2023-07-28 13:09:54" }, { "body": "/retest", "created_at": "2023-07-28 13:25:27" }, { "body": "/priority-backlog\r\n/release-note-none", "created_at": "2023-07-31 10:01:08" }, { "body": "/priority backlog", "created_at": "2023-07-31 10:01:28" }, { "body": "/retest\r\n/lgtm\r\n/cc kubernetes/release-managers", "created_at": "2023-07-31 10:02:48" }, { "body": "LGTM label has been added. <details>Git tree hash: c790ef543b0c3326a5a6b92d638752f3f37a2d23</details>", "created_at": "2023-07-31 10:02:55" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119621#\" title=\"Author self-approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119621#pullrequestreview-1558635589\" title=\"Approved\">xmudrii</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e_node/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/test/e2e_node/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-02 09:50:32" }, { "body": "/check-cla", "created_at": "2023-08-03 22:59:50" }, { "body": "/test pull-kubernetes-node-e2e-containerd", "created_at": "2023-08-03 23:05:37" }, { "body": "/test pull-kubernetes-e2e-gce-ubuntu-containerd", "created_at": "2023-08-03 23:31:30" }, { "body": "/test pull-kubernetes-e2e-gce-ubuntu-containerd", "created_at": "2023-08-04 19:26:33" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:10:37", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:10:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:10:37", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-07-27 16:10:37", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-07-27 16:10:38", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:10:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:10:42", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:10:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:10:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:10:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:11:17", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:11:17", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:11:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:11:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:11:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:11:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:11:20", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-07-27 16:44:21", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-07-27 16:44:21", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:07:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:07:21", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:09:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:09:57", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-07-28 14:02:53", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-07-28 14:02:53", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:01:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:01:10", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:01:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:01:32", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:02:49", "type": "review_requested" }, { "author": "bart0sh", "created_at": "2023-07-31 10:02:53", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 10:02:54", "type": "labeled" }, { "author": "xmudrii", "created_at": "2023-08-02 09:50:09", "type": "assigned" }, { "author": "xmudrii", "created_at": "2023-08-02 09:50:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 09:50:22", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 22:59:52", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-08-03 23:01:50", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-03 23:01:50", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-03 23:26:43", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-03 23:26:43", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-03 23:32:54", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-03 23:32:54", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-04 20:36:42", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-04 20:36:42", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-04 20:36:43", "type": "closed" }, { "author": "liggitt", "created_at": "2023-08-10 15:27:29", "type": "head_ref_deleted" } ]

[ "bart0sh", "xmudrii" ]

[ "area/test", "priority/backlog", "kind/cleanup", "lgtm", "sig/node", "size/M", "cherry-pick-approved", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "triage/accepted" ]

[ { "body": "/triage accepted", "created_at": "2023-07-28 13:07:06" }, { "body": "/kind cleanup", "created_at": "2023-07-28 13:10:01" }, { "body": "/retest", "created_at": "2023-07-28 13:24:55" }, { "body": "/priority-backlog\r\n/release-note-none", "created_at": "2023-07-31 09:53:33" }, { "body": "/priority backlog", "created_at": "2023-07-31 09:54:57" }, { "body": "/lgtm\r\n/cc kubernetes/release-managers", "created_at": "2023-07-31 09:59:51" }, { "body": "LGTM label has been added. <details>Git tree hash: a677d866692c1ae7aa27bf0c429632c79f46dd0c</details>", "created_at": "2023-07-31 09:59:59" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119620#\" title=\"Author self-approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119620#pullrequestreview-1558635358\" title=\"Approved\">xmudrii</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e_node/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/test/e2e_node/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-08-02 09:50:22" }, { "body": "/check-cla", "created_at": "2023-08-03 21:03:02" }, { "body": "/test pull-kubernetes-unit-go-compatibility", "created_at": "2023-08-03 22:33:18" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:09:29", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:09:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:09:29", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-07-27 16:09:30", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-07-27 16:09:30", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:09:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:09:33", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:09:33", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:09:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:09:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:09:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:09:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:09:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:09:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:09:37", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-07-27 16:40:23", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-07-27 16:40:23", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-07-27 17:05:39", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-07-27 17:05:39", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:07:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:07:10", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:10:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 13:10:05", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 09:53:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 09:53:35", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 09:54:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 09:55:01", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 09:59:52", "type": "review_requested" }, { "author": "bart0sh", "created_at": "2023-07-31 09:59:56", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 09:59:58", "type": "labeled" }, { "author": "xmudrii", "created_at": "2023-08-02 09:50:01", "type": "assigned" }, { "author": "xmudrii", "created_at": "2023-08-02 09:50:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 09:50:18", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 21:03:04", "type": "labeled" }, { "author": "liggitt", "created_at": "2023-08-03 21:42:18", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-03 21:42:18", "type": "subscribed" }, { "author": "liggitt", "created_at": "2023-08-03 22:17:17", "type": "mentioned" }, { "author": "liggitt", "created_at": "2023-08-03 22:17:17", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 23:12:21", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 23:12:21", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 23:12:21", "type": "closed" }, { "author": "liggitt", "created_at": "2023-08-10 15:27:04", "type": "head_ref_deleted" } ]

[ "thockin" ]

[ "kind/bug", "sig/api-machinery", "size/M", "release-note-none", "cncf-cla: yes", "needs-ok-to-test", "needs-priority", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Jul 27 04:10:17 UTC 2023.\n", "created_at": "2023-07-27 12:35:01" }, { "body": "Hi @skitt. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-27 12:35:06" }, { "body": "It occurs to me that we could handle overflowing input in the same way in the legacy `FromInt()`...", "created_at": "2023-07-27 12:35:26" }, { "body": "/assign @thockin\r\nFor the context. Thank you.\r\n/triage accepted ", "created_at": "2023-07-27 16:32:29" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119619#\" title=\"Author self-approved\">skitt</a>*\n**Once this PR has been reviewed and has the lgtm label**, please ask for approval from [thockin](https://github.com/thockin). For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/apimachinery/pkg/util/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/util/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"thockin\"]} -->", "created_at": "2023-08-16 08:32:24" }, { "body": "I see this was done in #119858, so all that’s left is the added tests.", "created_at": "2023-08-17 08:11:25" } ]

[ { "author": "thockin", "created_at": "2023-07-27 12:34:58", "type": "mentioned" }, { "author": "thockin", "created_at": "2023-07-27 12:34:58", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 12:34:59", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 12:34:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 12:35:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 12:35:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 12:35:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 12:35:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 12:35:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 12:35:06", "type": "labeled" }, { "author": "skitt", "created_at": "2023-07-27 12:35:07", "type": "mentioned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 12:35:07", "type": "labeled" }, { "author": "skitt", "created_at": "2023-07-27 12:35:07", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 12:35:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 12:35:32", "type": "unlabeled" }, { "author": "thockin", "created_at": "2023-07-27 16:32:30", "type": "mentioned" }, { "author": "thockin", "created_at": "2023-07-27 16:32:30", "type": "subscribed" }, { "author": "thockin", "created_at": "2023-07-27 16:32:31", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:32:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:32:33", "type": "unlabeled" }, { "author": "toVersus", "created_at": "2023-07-30 00:55:03", "type": "unsubscribed" }, { "author": "skitt", "created_at": "2023-08-16 08:30:54", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 17:47:12", "type": "labeled" }, { "author": "skitt", "created_at": "2023-08-17 08:10:53", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-17 08:11:00", "type": "unlabeled" } ]

[ "thockin" ]

[ "kind/cleanup", "area/kubectl", "lgtm", "size/XS", "release-note-none", "approved", "sig/cli", "cncf-cla: yes", "ok-to-test", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Jul 27 04:10:17 UTC 2023.\n", "created_at": "2023-07-27 11:44:02" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 11:44:06" }, { "body": "Hi @skitt. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-27 11:44:07" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119618#\" title=\"Author self-approved\">skitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119618#pullrequestreview-1553520202\" title=\"Approved\">thockin</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/OWNERS)~~ [thockin]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-07-29 23:58:28" }, { "body": "LGTM label has been added. <details>Git tree hash: 82a93282c4460db0d1108f403303ed78efb4c458</details>", "created_at": "2023-07-29 23:58:29" }, { "body": "/ok-to-test", "created_at": "2023-07-30 22:09:48" } ]

[ { "author": "thockin", "created_at": "2023-07-27 11:43:59", "type": "mentioned" }, { "author": "thockin", "created_at": "2023-07-27 11:43:59", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 11:44:00", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 11:44:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 11:44:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 11:44:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 11:44:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 11:44:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 11:44:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 11:44:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 11:44:07", "type": "labeled" }, { "author": "skitt", "created_at": "2023-07-27 11:44:07", "type": "mentioned" }, { "author": "skitt", "created_at": "2023-07-27 11:44:07", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 11:44:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 11:44:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 11:44:32", "type": "unlabeled" }, { "author": "thockin", "created_at": "2023-07-29 23:58:27", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 23:58:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-29 23:58:29", "type": "labeled" }, { "author": "toVersus", "created_at": "2023-07-30 00:55:02", "type": "unsubscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 22:09:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-30 22:09:50", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 02:43:18", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 02:43:19", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 02:43:19", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-16 02:43:20", "type": "milestoned" } ]

[]

[ "kind/bug", "sig/docs", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 10:53:37" }, { "body": "/sig docs", "created_at": "2023-07-27 10:55:59" }, { "body": "/assign\r\n", "created_at": "2023-07-27 17:52:45" }, { "body": "/unassign\r\n", "created_at": "2023-07-27 17:53:04" }, { "body": "Maybe the documentation is wrong? Normally, we try to document how Kubernetes actually behaves.\r\n\r\n/retitle `initialDelaySeconds` logic changed on documentation but not in code or in changelog", "created_at": "2023-08-07 10:19:07" }, { "body": "We should follow the code, then modify the document.", "created_at": "2023-08-09 01:18:27" } ]

[ { "author": "pablo-suazo", "created_at": "2023-07-27 10:53:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 10:53:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 10:53:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 10:56:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 10:56:02", "type": "unlabeled" }, { "author": "Sagar180304", "created_at": "2023-07-27 17:52:47", "type": "assigned" }, { "author": "Sagar180304", "created_at": "2023-07-27 17:53:05", "type": "unassigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-07 10:19:09", "type": "renamed" } ]

[ "apelisse" ]

[ "kind/bug", "sig/api-machinery", "triage/accepted" ]

[ { "body": "/sig api-machinery", "created_at": "2023-07-27 10:06:01" }, { "body": "/assign @apelisse \r\nThank you.\r\n/triage accepted", "created_at": "2023-07-27 16:37:17" }, { "body": "/cc", "created_at": "2023-07-28 02:57:24" }, { "body": "> update your controller's code starting to list with a large RV that exceeds the range of integer.\r\n\r\nI'm curious, how do you end-up with this?", "created_at": "2023-07-31 22:37:24" }, { "body": "> \r\n\r\nHi @apelisse , we are trying to extend the usage of bookmark event for scalability reasons, thus we have large/long resourceversions. then we encounter this issue :D ", "created_at": "2023-08-01 08:24:59" }, { "body": "/cc @jpbetz ", "created_at": "2023-08-01 16:55:50" } ]

[ { "author": "d3c3mber", "created_at": "2023-07-27 10:05:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 10:05:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 10:05:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 10:06:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 10:06:04", "type": "unlabeled" }, { "author": "apelisse", "created_at": "2023-07-27 16:37:18", "type": "mentioned" }, { "author": "apelisse", "created_at": "2023-07-27 16:37:18", "type": "subscribed" }, { "author": "apelisse", "created_at": "2023-07-27 16:37:19", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:37:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:37:21", "type": "unlabeled" }, { "author": "apelisse", "created_at": "2023-08-01 08:25:00", "type": "mentioned" }, { "author": "apelisse", "created_at": "2023-08-01 08:25:00", "type": "subscribed" }, { "author": "jpbetz", "created_at": "2023-08-01 16:55:51", "type": "mentioned" }, { "author": "jpbetz", "created_at": "2023-08-01 16:55:51", "type": "subscribed" } ]

[]

[ "kind/bug", "sig/scalability", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 09:14:27" }, { "body": "/sig scalability", "created_at": "2023-07-27 09:15:29" }, { "body": "I think the default storageWatchListPageSize should be user configurable for kube-apiserver", "created_at": "2023-07-27 12:59:26" }, { "body": "> I think the default storageWatchListPageSize should be user configurable for kube-apiserver\r\n\r\nYes, If we can configure it with adding a new command line argument or using environment variable cc @marseel @wojtek-t ", "created_at": "2023-07-28 02:02:32" } ]

[ { "author": "Sakuralbj", "created_at": "2023-07-27 09:14:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:14:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:14:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:15:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:15:34", "type": "unlabeled" }, { "author": "marseel", "created_at": "2023-07-28 02:02:33", "type": "mentioned" }, { "author": "marseel", "created_at": "2023-07-28 02:02:33", "type": "subscribed" }, { "author": "wojtek-t", "created_at": "2023-07-28 06:09:00", "type": "mentioned" }, { "author": "wojtek-t", "created_at": "2023-07-28 06:09:00", "type": "subscribed" } ]

[ "swatisehgal", "ffromani" ]

[ "kind/bug", "area/test", "priority/important-soon", "lgtm", "sig/node", "size/M", "kind/flake", "release-note-none", "cncf-cla: yes", "sig/testing", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Jul 27 04:10:17 UTC 2023.\n", "created_at": "2023-07-27 09:01:26" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119614#\" title=\"Author self-approved\">ruquanzhao</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [mrunalp](https://github.com/mrunalp) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[test/e2e_node/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"mrunalp\"]} -->", "created_at": "2023-07-27 09:02:19" }, { "body": "/cc @ffromani @chendave ", "created_at": "2023-07-27 09:08:53" }, { "body": "/assign @ffromani \r\n/cc @swatisehgal ", "created_at": "2023-08-02 17:23:53" }, { "body": "/triage accepted\r\n/priority important-soon\r\n/assign @ffromani @swatisehgal ", "created_at": "2023-08-03 10:05:51" }, { "body": "/lgtm\r\n\r\nthe current code could use some attention because it really feels unnecessarily hard to follow. This PR seems to fix the issue so it's a welcome step to improve the noise and enabling us a rewrite later.", "created_at": "2023-08-23 17:15:22" }, { "body": "LGTM label has been added. <details>Git tree hash: da845b9b2e0ebc05a17345f5660a3f4066230346</details>", "created_at": "2023-08-23 17:15:28" }, { "body": "/pull-kubernetes-node-kubelet-serial-cpu-manager", "created_at": "2023-08-23 17:16:35" }, { "body": "/test pull-kubernetes-node-kubelet-serial-cpu-manager", "created_at": "2023-08-23 17:16:41" }, { "body": "/test pull-kubernetes-node-kubelet-serial-cpu-manager", "created_at": "2023-08-24 01:54:20" }, { "body": "@ruquanzhao: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-node-kubelet-serial-cpu-manager | 6808b9e94fb42ca14a2dbba41c27e9c1b215eab6 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119614/pull-kubernetes-node-kubelet-serial-cpu-manager/1694528543725195264/) | false | `/test pull-kubernetes-node-kubelet-serial-cpu-manager`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119614). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Aruquanzhao). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-08-24 02:12:13" }, { "body": "/test pull-kubernetes-node-kubelet-serial-cpu-manager-kubetest2", "created_at": "2023-08-24 02:27:19" }, { "body": "the job \r\n\r\n- pull-kubernetes-node-kubelet-serial-cpu-manager\r\n- pull-kubernetes-node-kubelet-serial-cpu-manager-kubetest2\r\n- ci-kubernetes-node-kubelet-serial-cpu-manager\r\n\r\nis unhealthy, will look into it.", "created_at": "2023-08-24 10:39:22" }, { "body": "> the job\r\n> \r\n> * pull-kubernetes-node-kubelet-serial-cpu-manager\r\n> \r\n> * pull-kubernetes-node-kubelet-serial-cpu-manager-kubetest2\r\n> \r\n> * ci-kubernetes-node-kubelet-serial-cpu-manager\r\n> \r\n> \r\n> is unhealthy, will look into it.\r\n\r\nThanks @ruquanzhao . We are looking into it already. It's unfortunate we have unhealthy jobs now and gets in the way of this PR, but since the whole point of this PR is improving the e2e tests, we need to have some evidence the change is fixing. If there are other options to prove that (code looks good btw) I'll be happy to consider them.", "created_at": "2023-08-24 10:43:13" }, { "body": "xref: https://github.com/kubernetes/kubernetes/issues/118851", "created_at": "2023-08-24 10:50:45" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:01:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:01:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:01:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:01:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:01:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:01:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:01:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:01:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:01:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:01:56", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:01:56", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:02:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:02:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:02:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:02:11", "type": "unlabeled" }, { "author": "chendave", "created_at": "2023-07-27 09:08:54", "type": "mentioned" }, { "author": "chendave", "created_at": "2023-07-27 09:08:54", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-07-27 09:08:54", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-07-27 09:08:54", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:08:54", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:08:54", "type": "review_requested" }, { "author": "ruquanzhao", "created_at": "2023-07-27 09:33:35", "type": "mentioned" }, { "author": "ruquanzhao", "created_at": "2023-07-27 09:33:35", "type": "subscribed" }, { "author": "ruquanzhao", "created_at": "2023-07-27 09:42:21", "type": "mentioned" }, { "author": "ruquanzhao", "created_at": "2023-07-27 09:42:21", "type": "subscribed" }, { "author": "swatisehgal", "created_at": "2023-08-02 17:23:53", "type": "mentioned" }, { "author": "swatisehgal", "created_at": "2023-08-02 17:23:53", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-08-02 17:23:53", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-08-02 17:23:53", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-08-02 17:23:54", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 17:23:55", "type": "review_requested" }, { "author": "ruquanzhao", "created_at": "2023-08-03 09:30:32", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 09:30:34", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 09:30:35", "type": "labeled" }, { "author": "ruquanzhao", "created_at": "2023-08-03 09:30:45", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 09:30:46", "type": "unlabeled" }, { "author": "swatisehgal", "created_at": "2023-08-03 10:05:51", "type": "mentioned" }, { "author": "swatisehgal", "created_at": "2023-08-03 10:05:51", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-08-03 10:05:51", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-08-03 10:05:51", "type": "subscribed" }, { "author": "swatisehgal", "created_at": "2023-08-03 10:05:52", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 10:05:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 10:05:54", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 10:05:54", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 10:05:55", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 17:15:27", "type": "labeled" }, { "author": "ruquanzhao", "created_at": "2023-08-23 17:36:00", "type": "mentioned" }, { "author": "ruquanzhao", "created_at": "2023-08-23 17:36:00", "type": "subscribed" }, { "author": "ruquanzhao", "created_at": "2023-08-24 02:12:13", "type": "mentioned" }, { "author": "ruquanzhao", "created_at": "2023-08-24 02:12:13", "type": "subscribed" }, { "author": "ruquanzhao", "created_at": "2023-08-24 10:43:14", "type": "mentioned" }, { "author": "ruquanzhao", "created_at": "2023-08-24 10:43:14", "type": "subscribed" } ]

[]

[ "sig/network", "kind/feature", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 08:51:45" }, { "body": "/sig network", "created_at": "2023-08-08 07:50:18" }, { "body": "Service is an abstraction, is a frontend that uses Pods as backends for the configured ClusterIP:Port:Protocol, it is not real IP so it does not have to respond to ping (there are some Services implementations that respond to ICMP on the ClusterIP, but that is an implementation detail of that specific implementation)\r\n\r\n/close", "created_at": "2023-08-08 11:05:27" }, { "body": "@aojea: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119613#issuecomment-1669405776):\n\n>Service is an abstraction, is a frontend that uses Pods as backends for the configured ClusterIP:Port:Protocol, it is not real IP so it does not have to respond to ping (there are some Services implementations that respond to ICMP on the ClusterIP, but that is an implementation detail of that specific implementation)\r\n>\r\n>/close\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-08 11:05:32" } ]

[ { "author": "jiamengguo", "created_at": "2023-07-27 08:51:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:51:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:51:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 07:50:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 07:50:21", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-08 11:05:32", "type": "closed" }, { "author": "aojea", "created_at": "2023-08-08 11:05:32", "type": "mentioned" }, { "author": "aojea", "created_at": "2023-08-08 11:05:33", "type": "subscribed" } ]

[ "logicalhan", "dashpole" ]

[ "priority/important-soon", "area/monitoring", "release-note", "size/XS", "cncf-cla: yes", "sig/instrumentation", "sig/architecture", "triage/accepted", "do-not-merge/needs-kind" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Jul 27 04:10:17 UTC 2023.\n", "created_at": "2023-07-27 08:42:24" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119612#\" title=\"Author self-approved\">sttts</a>*\n**Once this PR has been reviewed and has the lgtm label**, please ask for approval from [logicalhan](https://github.com/logicalhan). For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/component-base/tracing/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/component-base/tracing/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"logicalhan\"]} -->", "created_at": "2023-07-27 08:49:44" }, { "body": "/retest", "created_at": "2023-07-27 10:28:48" }, { "body": "/assign", "created_at": "2023-07-27 16:34:01" }, { "body": "/triage accepted", "created_at": "2023-07-27 16:34:48" }, { "body": "> Today, when the otel endpoint is not available the span exporter blocks on every request (hypothesis, @logicalhan or other might be able to confirm). \r\n\r\nI don't believe the hypothesis is correct. In kube component-base, we use a BatchSpanProcessor for our exporter: https://github.com/kubernetes/kubernetes/blob/d4fde1e92a83cb533ae63b3abe9d49f08efb7a2f/staging/src/k8s.io/component-base/tracing/utils.go#L82-L83\r\n\r\nThe BatchSpanProcessor adds recorded spans to a queue, and asynchronously batches and sends spans from front of the queue to the configured exporter.\r\n\r\nWhile it can be configured to block when the queue fills up (https://github.com/open-telemetry/opentelemetry-go/blob/4f0d73cbc2a95f6c452e7a26dc5484559267f8ae/sdk/trace/batch_span_processor.go#L264), by default it drops newly recorded spans.\r\n\r\nChanging the reconnect period will mean we will connect to a local collector more quickly after that collector is deployed, but shouldn't have any meaningful impact on the kube-apiserver's request-path latency.\r\n", "created_at": "2023-07-27 18:28:55" }, { "body": "Ack. Have not digged much deeper. But we saw this dial error and a 5s timeout on an kube-apiserver request. Where could that come from? The IP was for the tracing endpoint.", "created_at": "2023-07-27 18:57:51" }, { "body": "As in: the kube-apiserver made a request to the tracing endpoint which timed out? That would happen if trace export was configured, but no OTel collector is listening at the configured endpoint.", "created_at": "2023-07-27 19:03:45" }, { "body": "Right, that's what I think was the case for us. And my question is whether the kube-apiserver recovers from that or it tries again and again on every request.", "created_at": "2023-07-27 20:18:21" }, { "body": "The kube-apiserver periodically attempts to connect to a local collector. Each time, if it isn't successful, it logs the warning you see above, and retries after a delay. That has no impact at all on requests the APIServer is serving. It just lets you know that you are not exporting trace data. Once it succeeds in connecting to a local collector, it will export the queued spans, and won't log the warning anymore.\r\n\r\nFor span export, it will \"recover\" after a collector is present. For APIServer request serving, there isn't any \"recovery\" needed, as span export doesn't have an impact on request serving.", "created_at": "2023-07-27 20:31:36" }, { "body": "I can confirm your explanation. The error messages appears, but a timeout has no influence on the request. The root cause was different. Thanks!", "created_at": "2023-07-27 21:44:53" } ]

[ { "author": "logicalhan", "created_at": "2023-07-27 08:42:21", "type": "mentioned" }, { "author": "logicalhan", "created_at": "2023-07-27 08:42:21", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:42:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:42:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:42:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:42:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:42:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:42:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:42:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:42:30", "type": "labeled" }, { "author": "logicalhan", "created_at": "2023-07-27 08:42:32", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:42:53", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:42:53", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:43:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:43:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:43:08", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:43:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:43:09", "type": "labeled" }, { "author": "sttts", "created_at": "2023-07-27 08:43:11", "type": "unlabeled" }, { "author": "sttts", "created_at": "2023-07-27 08:43:11", "type": "unlabeled" }, { "author": "sttts", "created_at": "2023-07-27 08:43:11", "type": "unlabeled" }, { "author": "sttts", "created_at": "2023-07-27 08:43:12", "type": "labeled" }, { "author": "sttts", "created_at": "2023-07-27 08:43:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:43:13", "type": "unlabeled" }, { "author": "sttts", "created_at": "2023-07-27 08:43:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:43:19", "type": "unlabeled" }, { "author": "sttts", "created_at": "2023-07-27 08:44:02", "type": "mentioned" }, { "author": "sttts", "created_at": "2023-07-27 08:44:02", "type": "subscribed" }, { "author": "sttts", "created_at": "2023-07-27 08:45:59", "type": "mentioned" }, { "author": "sttts", "created_at": "2023-07-27 08:45:59", "type": "subscribed" }, { "author": "sttts", "created_at": "2023-07-27 08:46:18", "type": "mentioned" }, { "author": "sttts", "created_at": "2023-07-27 08:46:18", "type": "subscribed" }, { "author": "sttts", "created_at": "2023-07-27 08:46:29", "type": "mentioned" }, { "author": "sttts", "created_at": "2023-07-27 08:46:29", "type": "subscribed" }, { "author": "sttts", "created_at": "2023-07-27 08:46:30", "type": "mentioned" }, { "author": "sttts", "created_at": "2023-07-27 08:46:31", "type": "subscribed" }, { "author": "sttts", "created_at": "2023-07-27 08:46:32", "type": "mentioned" }, { "author": "sttts", "created_at": "2023-07-27 08:46:32", "type": "subscribed" }, { "author": "sttts", "created_at": "2023-07-27 08:46:34", "type": "mentioned" }, { "author": "sttts", "created_at": "2023-07-27 08:46:34", "type": "subscribed" }, { "author": "sttts", "created_at": "2023-07-27 08:46:36", "type": "mentioned" }, { "author": "sttts", "created_at": "2023-07-27 08:46:36", "type": "subscribed" }, { "author": "sttts", "created_at": "2023-07-27 08:46:54", "type": "mentioned" }, { "author": "sttts", "created_at": "2023-07-27 08:46:54", "type": "subscribed" }, { "author": "sttts", "created_at": "2023-07-27 08:47:06", "type": "mentioned" }, { "author": "sttts", "created_at": "2023-07-27 08:47:07", "type": "subscribed" }, { "author": "sttts", "created_at": "2023-07-27 08:48:22", "type": "head_ref_force_pushed" }, { "author": "sttts", "created_at": "2023-07-27 08:49:02", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:49:04", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:49:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:49:09", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:49:32", "type": "labeled" }, { "author": "sttts", "created_at": "2023-07-27 09:45:12", "type": "mentioned" }, { "author": "sttts", "created_at": "2023-07-27 09:45:12", "type": "subscribed" }, { "author": "dashpole", "created_at": "2023-07-27 16:34:03", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:34:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:34:52", "type": "unlabeled" }, { "author": "logicalhan", "created_at": "2023-07-27 18:28:55", "type": "mentioned" }, { "author": "logicalhan", "created_at": "2023-07-27 18:28:55", "type": "subscribed" }, { "author": "sttts", "created_at": "2023-07-27 21:44:53", "type": "closed" } ]

[]

[ "kind/bug", "sig/storage", "sig/node", "triage/accepted" ]

[ { "body": "/sig node", "created_at": "2023-07-27 08:26:18" }, { "body": "/sig storage\r\n", "created_at": "2023-07-27 09:59:10" }, { "body": "/cc\r\n", "created_at": "2023-07-31 11:09:31" }, { "body": "Can you supply kubelet logs for when this occurs?\r\n\r\n/triage accepted\r\n/cc tzneal ", "created_at": "2023-08-02 17:55:51" }, { "body": "@tzneal Thank you for your reply!\r\nI reproduced the operations as follow, and got the kubelet log at that time.\r\n\r\n**Operations**\r\n\r\n* 09:53 Deploy `memvol` deployment with 3 replicas\r\n + Each worker has one pod deployed\r\n + Pods consumed almost memory.\r\n + As far as the output of the free and dh commands shows, there is a small amount of memory left.\r\n + Removed deployment because it was using most of the CPU and it seemed impossible to operate.\r\n + However, the Pod is still in Terminating state and is not deleted, so stop all worker VMs.\r\n + See kubelet log ([deployment-memvol-replica-3.log](https://github.com/kubernetes/kubernetes/files/12250104/deployment-memvol-replica-3.log))\r\n* 10:08 Restart worker VMs\r\n + Deploy `memvol` deployment with 6 replicas.\r\n + Each worker has two pods deployed\r\n + The Pods kept the Running state for about 5 minutes\r\n, although they consumed most of the memory and CPU.\r\n + The node seems to be NotReady, so I deleted the deployment.\r\n + Stopped the worker VMs because the Pod remained in Terminating state.\r\n + Start worker VMs again.\r\n + See kubelet log ([deployment-memvol-replica-6.log](https://github.com/kubernetes/kubernetes/files/12250107/deployment-memvol-replica-6.log))", "created_at": "2023-08-03 11:08:59" }, { "body": "You can specify a sizeLimit on the volume, see https://kubernetes.io/docs/concepts/storage/volumes/#emptydir-configuration-example which will limit the amount of memory that is consumed.\r\n\r\nEven without the limits I couldn't exactly reproduce your scenario. In my case, the containers would get OOMKilled and then the pod would be evicted due to memory pressure.", "created_at": "2023-08-03 15:12:32" }, { "body": "Thank you for confirmation!!\r\nIf you let it sit for a little while longer, the deletion of the tmpfs volume will not keep up with the re-creation of the pod, and you would see the behavior as I reported.\r\nIf you set the number of replicas to twice the number of nodes to cause this phenomenon earlier, the OS of the nodes will soon stuck.\r\nImportant thing is that cluster admin needs to prevent the creation of Pods that almost exclusively occupy memory, IMHO.", "created_at": "2023-08-04 01:29:14" }, { "body": "I still couldn't reproduce this. There are options available to cluster admins. They can use namespace limit ranges to enforce a memory request or an admission webhook to force a sizeLimit on the volumes. ", "created_at": "2023-08-09 13:43:22" }, { "body": "We have already promoted https://github.com/kubernetes/enhancements/issues/1967 to beta, which allows sizing memory-backed volumes.", "created_at": "2023-08-09 17:12:11" }, { "body": "@tzneal Thank you for sharing your knowledge!\r\nHowever, I think that the default value is too large and dangerous.\r\nAlso, as a cluster admin, it would be nice if there is a way to restrict or specify which nodes could use EmptyDir. Any ideas?", "created_at": "2023-08-10 02:26:28" }, { "body": "@mmiranda96 The sizeLimit is user-specified and not something that can be restricted by the cluster admin, right?", "created_at": "2023-08-10 02:26:58" }, { "body": "@tzneal Could you try to set `replicas` to twice the number of nodes?\r\n\r\n> If you set the number of replicas to twice the number of nodes ", "created_at": "2023-08-10 10:43:58" } ]

[ { "author": "shu-mutou", "created_at": "2023-07-27 08:25:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:25:51", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:25:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:26:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:26:21", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:59:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 17:55:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 17:55:54", "type": "unlabeled" }, { "author": "tzneal", "created_at": "2023-08-03 11:09:00", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-08-03 11:09:00", "type": "subscribed" }, { "author": "tzneal", "created_at": "2023-08-10 02:26:28", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-08-10 02:26:28", "type": "subscribed" }, { "author": "mmiranda96", "created_at": "2023-08-10 02:26:58", "type": "mentioned" }, { "author": "mmiranda96", "created_at": "2023-08-10 02:26:58", "type": "subscribed" }, { "author": "tzneal", "created_at": "2023-08-10 10:43:59", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-08-10 10:43:59", "type": "subscribed" } ]

[ "mansikulkarni96" ]

[ "kind/bug", "priority/important-soon", "area/kubelet", "sig/node", "size/XS", "sig/windows", "cncf-cla: yes", "do-not-merge/release-note-label-needed", "ok-to-test", "do-not-merge/contains-merge-commits", "triage/accepted" ]

[ { "body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 07:32:59" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Jul 27 04:10:17 UTC 2023.\n", "created_at": "2023-07-27 07:33:01" }, { "body": "Welcome @mukeshmahato18! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:", "created_at": "2023-07-27 07:33:05" }, { "body": "Hi @mukeshmahato18. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-27 07:33:06" }, { "body": "Adding label `do-not-merge/contains-merge-commits` because PR contains merge commits, which are not allowed in this repository.\nUse `git rebase` to reapply your commits on top of the target branch. Detailed instructions for doing so can be found [here](https://git.k8s.io/community/contributors/guide/github-workflow.md#4-keep-your-branch-in-sync).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 07:33:13" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119610#\" title=\"Author self-approved\">mukeshmahato18</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [dashpole](https://github.com/dashpole) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/kubelet/stats/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/stats/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"dashpole\"]} -->", "created_at": "2023-07-27 07:33:41" }, { "body": "@mukeshmahato18: The label(s) `kind/test-failing` cannot be applied, because the repository doesn't have them.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119610#issuecomment-1653853113):\n\n>/sig windows\r\n>/kind test-failing\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 15:28:52" }, { "body": "/sig windows\r\n/kind bug", "created_at": "2023-07-27 15:29:36" }, { "body": "/ok-to-test", "created_at": "2023-07-31 11:18:47" }, { "body": "/assign @mansikulkarni96 \r\n\r\nlooks like other tests are not passing but we will want to run this one as well:\r\n/test pull-ci-kubernetes-unit-windows", "created_at": "2023-08-01 16:28:26" }, { "body": "@mukeshmahato18 can you fix the linter and other tests failures?", "created_at": "2023-08-01 16:28:52" }, { "body": "/test pull-ci-kubernetes-unit-windows", "created_at": "2023-08-01 16:29:08" }, { "body": "@mukeshmahato18 Thank you for the PR! \r\nSince this is a bugfix, can you cover this case with a test to prove that your change actually fixes it?", "created_at": "2023-08-02 12:27:22" }, { "body": "/retest\r\n/triage accepted\r\n/priority important-soon", "created_at": "2023-08-02 12:28:42" }, { "body": "/cc", "created_at": "2023-08-02 12:28:48" }, { "body": "@mukeshmahato18 it looks like a user-visible change. If this is the case, please provide release notes, thanks.", "created_at": "2023-08-02 12:29:38" }, { "body": "@mukeshmahato18: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-typecheck | 366b9ce05abf9d6b998468aefe8650b12479aa7b | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119610/pull-kubernetes-typecheck/1686715661876727808) | true | `/test pull-kubernetes-typecheck`\npull-kubernetes-e2e-capz-windows | 366b9ce05abf9d6b998468aefe8650b12479aa7b | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119610/pull-kubernetes-e2e-capz-windows/1686715661805424640) | false | `/test pull-kubernetes-e2e-capz-windows`\npull-kubernetes-verify | 366b9ce05abf9d6b998468aefe8650b12479aa7b | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119610/pull-kubernetes-verify/1686715661943836672) | true | `/test pull-kubernetes-verify`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119610). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Amukeshmahato18). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-08-02 13:24:13" }, { "body": "@mukeshmahato18 also looks like need to address some linters", "created_at": "2023-08-10 21:32:42" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 07:32:59", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 07:33:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 07:33:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 07:33:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 07:33:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 07:33:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 07:33:06", "type": "labeled" }, { "author": "mukeshmahato18", "created_at": "2023-07-27 07:33:06", "type": "mentioned" }, { "author": "mukeshmahato18", "created_at": "2023-07-27 07:33:06", "type": "subscribed" }, { "author": "mukeshmahato18", "created_at": "2023-07-27 07:33:07", "type": "mentioned" }, { "author": "mukeshmahato18", "created_at": "2023-07-27 07:33:07", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 07:33:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 07:33:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 07:33:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 07:33:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 07:33:32", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 07:33:53", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 07:33:53", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 15:28:51", "type": "labeled" }, { "author": "mukeshmahato18", "created_at": "2023-07-27 15:28:52", "type": "mentioned" }, { "author": "mukeshmahato18", "created_at": "2023-07-27 15:28:52", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 15:29:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 15:29:40", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:18:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 11:18:49", "type": "unlabeled" }, { "author": "mukeshmahato18", "created_at": "2023-07-31 11:27:59", "type": "mentioned" }, { "author": "mukeshmahato18", "created_at": "2023-07-31 11:27:59", "type": "subscribed" }, { "author": "mukeshmahato18", "created_at": "2023-07-31 11:43:24", "type": "mentioned" }, { "author": "mukeshmahato18", "created_at": "2023-07-31 11:43:25", "type": "subscribed" }, { "author": "mukeshmahato18", "created_at": "2023-07-31 11:57:40", "type": "mentioned" }, { "author": "mukeshmahato18", "created_at": "2023-07-31 11:57:40", "type": "subscribed" }, { "author": "mukeshmahato18", "created_at": "2023-07-31 12:13:30", "type": "mentioned" }, { "author": "mukeshmahato18", "created_at": "2023-07-31 12:13:30", "type": "subscribed" }, { "author": "mukeshmahato18", "created_at": "2023-07-31 12:14:13", "type": "mentioned" }, { "author": "mukeshmahato18", "created_at": "2023-07-31 12:14:13", "type": "subscribed" }, { "author": "mansikulkarni96", "created_at": "2023-08-01 16:28:27", "type": "mentioned" }, { "author": "mansikulkarni96", "created_at": "2023-08-01 16:28:27", "type": "subscribed" }, { "author": "mansikulkarni96", "created_at": "2023-08-01 16:28:28", "type": "assigned" }, { "author": "mukeshmahato18", "created_at": "2023-08-01 16:28:52", "type": "mentioned" }, { "author": "mukeshmahato18", "created_at": "2023-08-01 16:28:53", "type": "subscribed" }, { "author": "mukeshmahato18", "created_at": "2023-08-02 12:27:22", "type": "mentioned" }, { "author": "mukeshmahato18", "created_at": "2023-08-02 12:27:23", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 12:28:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 12:28:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 12:28:47", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 12:28:48", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-02 12:28:50", "type": "review_requested" }, { "author": "mukeshmahato18", "created_at": "2023-08-02 12:29:38", "type": "mentioned" }, { "author": "mukeshmahato18", "created_at": "2023-08-02 12:29:38", "type": "subscribed" }, { "author": "mukeshmahato18", "created_at": "2023-08-02 12:35:48", "type": "mentioned" }, { "author": "mukeshmahato18", "created_at": "2023-08-02 12:35:48", "type": "subscribed" }, { "author": "mukeshmahato18", "created_at": "2023-08-02 12:53:28", "type": "mentioned" }, { "author": "mukeshmahato18", "created_at": "2023-08-02 12:53:28", "type": "subscribed" }, { "author": "mukeshmahato18", "created_at": "2023-08-02 13:24:14", "type": "mentioned" }, { "author": "mukeshmahato18", "created_at": "2023-08-02 13:24:14", "type": "subscribed" }, { "author": "mukeshmahato18", "created_at": "2023-08-10 21:32:42", "type": "mentioned" }, { "author": "mukeshmahato18", "created_at": "2023-08-10 21:32:42", "type": "subscribed" }, { "author": "mukeshmahato18", "created_at": "2023-08-11 14:42:02", "type": "closed" } ]

[]

[ "kind/bug", "sig/storage", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 03:33:18" }, { "body": "/sig storage", "created_at": "2023-07-27 05:46:01" }, { "body": "heyy !! is this issue still open??", "created_at": "2023-07-28 18:18:08" }, { "body": "> heyy !! is this issue still open??\r\n\r\nyes, I see it as well, please refer https://github.com/kubernetes/kubernetes/issues/109132#issuecomment-1628931032", "created_at": "2023-07-31 05:58:14" }, { "body": "Encountering the same problem.\r\n```log\r\nblkUtil.DetachFileDevice failed. globalUnmapPath:, podUID: 6c505378-8090-4ebb-950d-cbeb5b8a7ae8, bindMount: true: failed to unmap device from map path. mapPath is empty\r\n```", "created_at": "2023-08-17 05:36:27" } ]

[ { "author": "dsxing", "created_at": "2023-07-27 03:33:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 03:33:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 03:33:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 05:46:03", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 05:46:04", "type": "unlabeled" } ]

[]

[ "kind/bug", "sig/scheduling", "size/M", "release-note-none", "cncf-cla: yes", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Jul 26 22:10:43 UTC 2023.\n", "created_at": "2023-07-27 03:08:49" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-27 03:08:54" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119607#\" title=\"Author self-approved\">wackxu</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [huang-wei](https://github.com/huang-wei) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/scheduler/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"huang-wei\"]} -->", "created_at": "2023-07-27 03:09:37" }, { "body": "/test pull-kubernetes-unit", "created_at": "2023-07-27 07:39:06" }, { "body": "/test pull-kubernetes-e2e-kind", "created_at": "2023-07-27 07:39:15" }, { "body": "/test pull-kubernetes-e2e-kind", "created_at": "2023-07-27 13:23:46" }, { "body": "/test pull-kubernetes-integration", "created_at": "2023-07-27 13:23:57" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 03:08:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 03:08:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 03:08:48", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 03:08:50", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 03:08:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 03:08:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 03:08:55", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 03:09:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 03:09:28", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 03:09:49", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 03:09:49", "type": "review_requested" }, { "author": "wackxu", "created_at": "2023-07-27 03:46:41", "type": "mentioned" }, { "author": "wackxu", "created_at": "2023-07-27 03:46:41", "type": "subscribed" }, { "author": "wackxu", "created_at": "2023-07-27 06:49:20", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 06:49:22", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 06:49:22", "type": "labeled" }, { "author": "wackxu", "created_at": "2023-07-27 07:23:38", "type": "mentioned" }, { "author": "wackxu", "created_at": "2023-07-27 07:23:38", "type": "subscribed" }, { "author": "wackxu", "created_at": "2023-07-27 07:29:12", "type": "mentioned" }, { "author": "wackxu", "created_at": "2023-07-27 07:29:12", "type": "subscribed" }, { "author": "wackxu", "created_at": "2023-07-27 07:51:28", "type": "mentioned" }, { "author": "wackxu", "created_at": "2023-07-27 07:51:28", "type": "subscribed" }, { "author": "wackxu", "created_at": "2023-07-27 08:10:41", "type": "mentioned" }, { "author": "wackxu", "created_at": "2023-07-27 08:10:41", "type": "subscribed" } ]

[ "SergeyKanzhelev" ]

[ "kind/bug", "priority/important-soon", "area/kubelet", "lgtm", "sig/node", "size/M", "cherry-pick-approved", "approved", "cncf-cla: yes", "ok-to-test", "triage/accepted" ]

[ { "body": "Hi @a7i. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-27 01:48:28" }, { "body": "/ok-to-test", "created_at": "2023-07-27 01:49:28" }, { "body": "LGTM label has been added. <details>Git tree hash: 8c9e608921a756678960cc7eeae300c45fa441a3</details>", "created_at": "2023-07-27 20:36:06" }, { "body": "/approve", "created_at": "2023-07-27 20:38:03" }, { "body": "/cc kubernetes/release-managers", "created_at": "2023-07-27 21:43:33" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119606#\" title=\"Author self-approved\">a7i</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119606#issuecomment-1654535690\" title=\"Approved\">mrunalp</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119606#pullrequestreview-1551494838\" title=\"Approved\">saschagrunert</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119606#pullrequestreview-1550731453\" title=\"Approved\">SergeyKanzhelev</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/kubelet/prober/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.25/pkg/kubelet/prober/OWNERS)~~ [mrunalp]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-07-28 07:05:54" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:48:21", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:48:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:48:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:48:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:48:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:48:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:48:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:48:28", "type": "labeled" }, { "author": "a7i", "created_at": "2023-07-27 01:48:29", "type": "mentioned" }, { "author": "a7i", "created_at": "2023-07-27 01:48:29", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:48:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:48:56", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:48:56", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:48:56", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:48:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:48:59", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:49:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:49:31", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:00", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:02", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:03", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:03", "type": "unlabeled" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-27 20:36:03", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:05", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:38:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:43:34", "type": "review_requested" }, { "author": "saschagrunert", "created_at": "2023-07-28 07:05:39", "type": "unlabeled" }, { "author": "saschagrunert", "created_at": "2023-07-28 07:05:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:13:55", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:13:55", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:13:55", "type": "closed" }, { "author": "a7i", "created_at": "2023-07-28 11:30:41", "type": "head_ref_deleted" } ]

[ "SergeyKanzhelev" ]

[ "kind/bug", "priority/important-soon", "area/kubelet", "lgtm", "sig/node", "size/M", "cherry-pick-approved", "approved", "cncf-cla: yes", "ok-to-test", "triage/accepted" ]

[ { "body": "Hi @a7i. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-27 01:45:41" }, { "body": "/ok-to-test", "created_at": "2023-07-27 01:49:23" }, { "body": "LGTM label has been added. <details>Git tree hash: 1c2666cf068caa3b29fe1158711620441d32baf9</details>", "created_at": "2023-07-27 20:36:16" }, { "body": "/approve", "created_at": "2023-07-27 20:37:40" }, { "body": "/cc kubernetes/release-managers", "created_at": "2023-07-27 21:43:16" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119605#\" title=\"Author self-approved\">a7i</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119605#issuecomment-1654535248\" title=\"Approved\">mrunalp</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119605#pullrequestreview-1551494876\" title=\"Approved\">saschagrunert</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119605#pullrequestreview-1550731669\" title=\"Approved\">SergeyKanzhelev</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/kubelet/prober/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/pkg/kubelet/prober/OWNERS)~~ [mrunalp]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-07-28 07:05:38" }, { "body": "/retest", "created_at": "2023-07-28 07:55:57" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:45:34", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:45:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:45:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:45:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:45:39", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:45:40", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:45:41", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:45:41", "type": "labeled" }, { "author": "a7i", "created_at": "2023-07-27 01:45:41", "type": "mentioned" }, { "author": "a7i", "created_at": "2023-07-27 01:45:42", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:45:42", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:46:19", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:46:19", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:46:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:46:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:46:22", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:49:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:49:25", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:12", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:13", "type": "unlabeled" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-27 20:36:13", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:13", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:37:47", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:43:17", "type": "review_requested" }, { "author": "saschagrunert", "created_at": "2023-07-28 07:05:43", "type": "unlabeled" }, { "author": "saschagrunert", "created_at": "2023-07-28 07:05:43", "type": "labeled" }, { "author": "a7i", "created_at": "2023-07-28 07:45:19", "type": "mentioned" }, { "author": "a7i", "created_at": "2023-07-28 07:45:19", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:33:55", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:33:55", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:33:55", "type": "closed" }, { "author": "a7i", "created_at": "2023-07-28 11:30:41", "type": "head_ref_deleted" } ]

[ "SergeyKanzhelev" ]

[ "kind/bug", "priority/important-soon", "area/kubelet", "lgtm", "sig/node", "size/M", "cherry-pick-approved", "approved", "cncf-cla: yes", "ok-to-test", "triage/accepted" ]

[ { "body": "Hi @a7i. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-27 01:44:17" }, { "body": "/ok-to-test", "created_at": "2023-07-27 01:49:16" }, { "body": "/retest-required", "created_at": "2023-07-27 02:58:47" }, { "body": "LGTM label has been added. <details>Git tree hash: f3238f59b7475467165dfe21a1cae893791dcb00</details>", "created_at": "2023-07-27 20:36:24" }, { "body": "/approve", "created_at": "2023-07-27 20:37:22" }, { "body": "/cc kubernetes/release-managers", "created_at": "2023-07-27 21:42:26" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119604#\" title=\"Author self-approved\">a7i</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119604#issuecomment-1654534863\" title=\"Approved\">mrunalp</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119604#pullrequestreview-1551494939\" title=\"Approved\">saschagrunert</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119604#pullrequestreview-1550731879\" title=\"Approved\">SergeyKanzhelev</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/kubelet/prober/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/pkg/kubelet/prober/OWNERS)~~ [mrunalp]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-07-28 07:05:57" }, { "body": "/retest", "created_at": "2023-07-28 07:56:00" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:44:10", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:44:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:44:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:44:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:44:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:44:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:44:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:44:17", "type": "labeled" }, { "author": "a7i", "created_at": "2023-07-27 01:44:18", "type": "mentioned" }, { "author": "a7i", "created_at": "2023-07-27 01:44:18", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:44:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:44:52", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:44:52", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:44:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:44:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:44:54", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:49:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 01:49:18", "type": "unlabeled" }, { "author": "a7i", "created_at": "2023-07-27 02:48:05", "type": "mentioned" }, { "author": "a7i", "created_at": "2023-07-27 02:48:05", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:18", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:20", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:21", "type": "unlabeled" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-27 20:36:21", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:36:23", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 20:37:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 21:42:27", "type": "review_requested" }, { "author": "saschagrunert", "created_at": "2023-07-28 07:05:47", "type": "unlabeled" }, { "author": "saschagrunert", "created_at": "2023-07-28 07:05:47", "type": "labeled" }, { "author": "a7i", "created_at": "2023-07-28 07:45:13", "type": "mentioned" }, { "author": "a7i", "created_at": "2023-07-28 07:45:13", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:35:57", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:35:57", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 08:35:57", "type": "closed" }, { "author": "a7i", "created_at": "2023-07-28 11:30:41", "type": "head_ref_deleted" } ]

[ "SergeyKanzhelev", "mmiranda96" ]

[ "area/test", "lgtm", "sig/node", "size/XS", "release-note-none", "approved", "cncf-cla: yes", "sig/testing", "needs-priority", "kind/regression", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Jul 26 22:10:43 UTC 2023.\n", "created_at": "2023-07-26 23:12:32" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-26 23:12:37" }, { "body": "/cc @SergeyKanzhelev @dims @chendave \r\n\r\nI have verified this patch by running:\r\n\r\n```\r\nkubetest2 noop --test=node \\\r\n -- \\\r\n --repo-root=. --gcp-project=borg-env --gcp-zone=us-central1-a --parallelism=1 \\\r\n --focus-regex=\"\\[Serial\\]\" --use-dockerized-build=true \\\r\n --target-build-arch=linux/arm64 \\\r\n --skip-regex=\"\\[Flaky\\]|\\[Slow\\]|\\[Benchmark\\]|\\[NodeSpecialFeature:.+\\]|\\[NodeSpecialFeature\\]|\\[NodeAlphaFeature:.+\\]|\\[NodeAlphaFeature\\]|\\[NodeFeature:Eviction\\]|\\[NodeFeature:NodeProblemDetector\\]|\\[NodeFeature:OOMScoreAdj\\]|\\[NodeFeature:DevicePluginProbe\\]|\\[NodeConformance\\]|\\[Feature:DynamicResourceAllocation\\]\" \\\r\n --test-args='--container-runtime-endpoint=unix:///run/containerd/containerd.sock --container-runtime-process-name=/usr/bin/containerd --container-runtime-pid-file= --kubelet-flags=\"--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/containerd.service\" --extra-log=\"{\\\"name\\\":\\\"containerd.log\\\", \\\"journalctl\\\": [\\\"-u\\\", \\\"containerd*\\\"]}\"' \\\r\n --image-config-file=\"${GOPATH}/src/k8s.io/test-infra/jobs/e2e_node/arm/image-config-serial.yaml\"\r\n```\r\n\r\nIt is creating a t2a-standard-2 instance instead of n1-standard-1 instance\r\n\r\n/test pull-kubernetes-node-arm64-ubuntu-serial-gce\r\n/test pull-kubernetes-node-crio-cgrpv2-e2e-kubetest2", "created_at": "2023-07-26 23:16:08" }, { "body": "/lgtm", "created_at": "2023-07-26 23:46:02" }, { "body": "LGTM label has been added. <details>Git tree hash: bdf0177e7600b244588c75a6ec1d9b5703712731</details>", "created_at": "2023-07-26 23:46:08" }, { "body": "/test pull-kubernetes-node-arm64-ubuntu-serial", "created_at": "2023-07-26 23:46:32" }, { "body": "@mmiranda96: The specified target(s) for `/test` were not found.\nThe following commands are available to trigger required jobs:\n* `/test pull-cadvisor-e2e-kubernetes`\n* `/test pull-kubernetes-conformance-kind-ga-only-parallel`\n* `/test pull-kubernetes-coverage-unit`\n* `/test pull-kubernetes-dependencies`\n* `/test pull-kubernetes-dependencies-go-canary`\n* `/test pull-kubernetes-e2e-gce`\n* `/test pull-kubernetes-e2e-gce-100-performance`\n* `/test pull-kubernetes-e2e-gce-big-performance`\n* `/test pull-kubernetes-e2e-gce-canary`\n* `/test pull-kubernetes-e2e-gce-cos`\n* `/test pull-kubernetes-e2e-gce-cos-canary`\n* `/test pull-kubernetes-e2e-gce-cos-no-stage`\n* `/test pull-kubernetes-e2e-gce-network-proxy-http-connect`\n* `/test pull-kubernetes-e2e-gce-scale-performance-manual`\n* `/test pull-kubernetes-e2e-kind`\n* `/test pull-kubernetes-e2e-kind-ipv6`\n* `/test pull-kubernetes-integration`\n* `/test pull-kubernetes-integration-go-canary`\n* `/test pull-kubernetes-kubemark-e2e-gce-scale`\n* `/test pull-kubernetes-node-e2e-containerd`\n* `/test pull-kubernetes-typecheck`\n* `/test pull-kubernetes-unit`\n* `/test pull-kubernetes-unit-go-canary`\n* `/test pull-kubernetes-update`\n* `/test pull-kubernetes-verify`\n* `/test pull-kubernetes-verify-go-canary`\n\nThe following commands are available to trigger optional jobs:\n* `/test check-dependency-stats`\n* `/test pull-ci-kubernetes-unit-windows`\n* `/test pull-e2e-gce-cloud-provider-disabled`\n* `/test pull-kubernetes-conformance-image-test`\n* `/test pull-kubernetes-conformance-kind-ga-only`\n* `/test pull-kubernetes-conformance-kind-ipv6-parallel`\n* `/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e`\n* `/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e-features`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-eviction`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-features`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-serial`\n* `/test pull-kubernetes-cross`\n* `/test pull-kubernetes-e2e-autoscaling-hpa-cm`\n* `/test pull-kubernetes-e2e-autoscaling-hpa-cpu`\n* `/test pull-kubernetes-e2e-capz-azure-disk`\n* `/test pull-kubernetes-e2e-capz-azure-disk-vmss`\n* `/test pull-kubernetes-e2e-capz-azure-file`\n* `/test pull-kubernetes-e2e-capz-azure-file-vmss`\n* `/test pull-kubernetes-e2e-capz-conformance`\n* `/test pull-kubernetes-e2e-capz-windows`\n* `/test pull-kubernetes-e2e-capz-windows-alpha-feature-vpa`\n* `/test pull-kubernetes-e2e-capz-windows-alpha-features`\n* `/test pull-kubernetes-e2e-capz-windows-serial-slow-hpa`\n* `/test pull-kubernetes-e2e-containerd-gce`\n* `/test pull-kubernetes-e2e-gce-correctness`\n* `/test pull-kubernetes-e2e-gce-cos-alpha-features`\n* `/test pull-kubernetes-e2e-gce-cos-kubetest2`\n* `/test pull-kubernetes-e2e-gce-csi-serial`\n* `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\n* `/test pull-kubernetes-e2e-gce-kubelet-credential-provider`\n* `/test pull-kubernetes-e2e-gce-network-proxy-grpc`\n* `/test pull-kubernetes-e2e-gce-serial`\n* `/test pull-kubernetes-e2e-gce-storage-disruptive`\n* `/test pull-kubernetes-e2e-gce-storage-slow`\n* `/test pull-kubernetes-e2e-gce-storage-snapshot`\n* `/test pull-kubernetes-e2e-gci-gce-autoscaling`\n* `/test pull-kubernetes-e2e-gci-gce-ingress`\n* `/test pull-kubernetes-e2e-gci-gce-ipvs`\n* `/test pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2`\n* `/test pull-kubernetes-e2e-kind-alpha-features`\n* `/test pull-kubernetes-e2e-kind-canary`\n* `/test pull-kubernetes-e2e-kind-dual-canary`\n* `/test pull-kubernetes-e2e-kind-ipv6-canary`\n* `/test pull-kubernetes-e2e-kind-ipvs-dual-canary`\n* `/test pull-kubernetes-e2e-kind-kms`\n* `/test pull-kubernetes-e2e-kind-multizone`\n* `/test pull-kubernetes-e2e-kops-aws`\n* `/test pull-kubernetes-e2e-storage-kind-disruptive`\n* `/test pull-kubernetes-e2e-ubuntu-gce-network-policies`\n* `/test pull-kubernetes-integration-eks`\n* `/test pull-kubernetes-kind-dra`\n* `/test pull-kubernetes-kind-json-logging`\n* `/test pull-kubernetes-kind-text-logging`\n* `/test pull-kubernetes-kubemark-e2e-gce-big`\n* `/test pull-kubernetes-local-e2e`\n* `/test pull-kubernetes-node-arm64-e2e-containerd-ec2`\n* `/test pull-kubernetes-node-arm64-e2e-containerd-serial-ec2`\n* `/test pull-kubernetes-node-arm64-ubuntu-serial-gce`\n* `/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e`\n* `/test pull-kubernetes-node-crio-cgrpv2-e2e`\n* `/test pull-kubernetes-node-crio-cgrpv2-e2e-kubetest2`\n* `/test pull-kubernetes-node-crio-e2e`\n* `/test pull-kubernetes-node-crio-e2e-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-alpha-features`\n* `/test pull-kubernetes-node-e2e-containerd-ec2`\n* `/test pull-kubernetes-node-e2e-containerd-features`\n* `/test pull-kubernetes-node-e2e-containerd-features-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-serial-ec2`\n* `/test pull-kubernetes-node-e2e-containerd-sidecar-containers`\n* `/test pull-kubernetes-node-e2e-containerd-standalone-mode`\n* `/test pull-kubernetes-node-e2e-containerd-standalone-mode-all-alpha`\n* `/test pull-kubernetes-node-e2e-crio-dra`\n* `/test pull-kubernetes-node-kubelet-credential-provider`\n* `/test pull-kubernetes-node-kubelet-serial-containerd`\n* `/test pull-kubernetes-node-kubelet-serial-containerd-kubetest2`\n* `/test pull-kubernetes-node-kubelet-serial-cpu-manager`\n* `/test pull-kubernetes-node-kubelet-serial-cpu-manager-kubetest2`\n* `/test pull-kubernetes-node-kubelet-serial-crio-cgroupv1`\n* `/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2`\n* `/test pull-kubernetes-node-kubelet-serial-hugepages`\n* `/test pull-kubernetes-node-kubelet-serial-memory-manager`\n* `/test pull-kubernetes-node-kubelet-serial-pod-disruption-conditions`\n* `/test pull-kubernetes-node-kubelet-serial-topology-manager`\n* `/test pull-kubernetes-node-kubelet-serial-topology-manager-kubetest2`\n* `/test pull-kubernetes-node-memoryqos-cgrpv2`\n* `/test pull-kubernetes-node-swap-fedora`\n* `/test pull-kubernetes-node-swap-fedora-serial`\n* `/test pull-kubernetes-node-swap-ubuntu-serial`\n* `/test pull-kubernetes-unit-experimental`\n* `/test pull-kubernetes-verify-strict-lint`\n* `/test pull-publishing-bot-validate`\n\nUse `/test all` to run the following jobs that were automatically triggered:\n* `pull-kubernetes-conformance-kind-ga-only-parallel`\n* `pull-kubernetes-conformance-kind-ipv6-parallel`\n* `pull-kubernetes-dependencies`\n* `pull-kubernetes-e2e-gce`\n* `pull-kubernetes-e2e-kind`\n* `pull-kubernetes-e2e-kind-ipv6`\n* `pull-kubernetes-integration`\n* `pull-kubernetes-node-e2e-containerd`\n* `pull-kubernetes-typecheck`\n* `pull-kubernetes-unit`\n* `pull-kubernetes-verify`\n\n\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119603#issuecomment-1652692413):\n\n>/test pull-kubernetes-node-arm64-ubuntu-serial\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-26 23:46:34" }, { "body": "/test pull-kubernetes-node-arm64-ubuntu-serial-gce", "created_at": "2023-07-26 23:47:12" }, { "body": "/retest-failed", "created_at": "2023-07-27 00:04:19" }, { "body": "https://testgrid.k8s.io/sig-node-containerd#pull-e2e-arm64-gce&width=90 is now green.\r\n\r\n/test pull-kubernetes-unit (looks like is unrelated, https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119603/pull-kubernetes-unit/1684340949473300480)", "created_at": "2023-07-27 01:59:23" }, { "body": "/test pull-kubernetes-e2e-gce", "created_at": "2023-07-27 08:47:23" }, { "body": "Yeah, looks like that failure was a flake.\r\n\r\n/assign @SergeyKanzhelev ", "created_at": "2023-07-27 16:29:59" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119603#pullrequestreview-1550987798\" title=\"Approved\">SergeyKanzhelev</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119603#\" title=\"Author self-approved\">upodroid</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e_node/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/OWNERS)~~ [SergeyKanzhelev]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-07-27 23:18:09" }, { "body": "/retest", "created_at": "2023-07-28 00:24:02" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-26 23:12:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 23:12:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 23:12:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 23:12:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 23:12:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 23:12:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 23:12:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 23:13:10", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 23:13:10", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 23:13:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 23:13:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 23:13:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 23:13:24", "type": "unlabeled" }, { "author": "dims", "created_at": "2023-07-26 23:16:09", "type": "mentioned" }, { "author": "dims", "created_at": "2023-07-26 23:16:09", "type": "subscribed" }, { "author": "chendave", "created_at": "2023-07-26 23:16:09", "type": "mentioned" }, { "author": "chendave", "created_at": "2023-07-26 23:16:09", "type": "subscribed" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-26 23:16:09", "type": "mentioned" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-26 23:16:09", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 23:16:10", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 23:16:10", "type": "review_requested" }, { "author": "mmiranda96", "created_at": "2023-07-26 23:46:06", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 23:46:07", "type": "labeled" }, { "author": "mmiranda96", "created_at": "2023-07-26 23:46:34", "type": "mentioned" }, { "author": "mmiranda96", "created_at": "2023-07-26 23:46:34", "type": "subscribed" }, { "author": "upodroid", "created_at": "2023-07-26 23:56:31", "type": "mentioned" }, { "author": "upodroid", "created_at": "2023-07-26 23:56:31", "type": "subscribed" }, { "author": "upodroid", "created_at": "2023-07-27 00:11:26", "type": "mentioned" }, { "author": "upodroid", "created_at": "2023-07-27 00:11:26", "type": "subscribed" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-27 16:30:00", "type": "mentioned" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-27 16:30:00", "type": "subscribed" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-27 16:30:01", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 23:18:05", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 23:18:10", "type": "labeled" }, { "author": "upodroid", "created_at": "2023-07-27 23:44:27", "type": "mentioned" }, { "author": "upodroid", "created_at": "2023-07-27 23:44:27", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:51:53", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:51:53", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:51:53", "type": "closed" } ]

[ "ffromani" ]

[ "sig/node", "kind/flake", "triage/accepted" ]

[ { "body": "/triage accepted\r\n\r\nsince it was reported, the flakes seems to have reduced:\r\n\r\n\r\nhowever I see a good share of \r\n\r\n```\r\n{ failed [FAILED] the first List() call unexpectedly failed with rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing: dial unix /var/lib/kubelet/pod-resources/kubelet.sock: connect: connection refused\": rpc error: code = Unavailable desc = connection error: desc = \"transport: Error while dialing: dial unix /var/lib/kubelet/pod-resources/kubelet.sock: connect: connection refused\"\r\nIn [It] at: test/e2e_node/podresources_test.go:969 @ 08/09/23 09:52:31.248\r\n```\r\n\r\nwhich contribute to flakes in this area. I'll investigate separately. This specific issue can be closed, please reopen if you think otherwise or if flakes restart meantime", "created_at": "2023-08-09 15:16:16" }, { "body": "/close\r\n\r\nsee: https://github.com/kubernetes/kubernetes/issues/119602#issuecomment-1671607225", "created_at": "2023-08-09 15:16:30" }, { "body": "@ffromani: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119602#issuecomment-1671607559):\n\n>/close\r\n>\r\n>see: https://github.com/kubernetes/kubernetes/issues/119602#issuecomment-1671607225\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-09 15:16:37" } ]

[ { "author": "SergeyKanzhelev", "created_at": "2023-07-26 21:19:13", "type": "labeled" }, { "author": "ffromani", "created_at": "2023-07-26 21:19:14", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-07-26 21:19:14", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-07-26 21:19:15", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 21:19:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 21:19:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:16:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:16:23", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-09 15:16:36", "type": "closed" }, { "author": "ffromani", "created_at": "2023-08-09 15:16:37", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-08-09 15:16:37", "type": "subscribed" } ]

[ "swatisehgal" ]

[ "priority/important-soon", "sig/node", "kind/failing-test", "triage/accepted" ]

[ { "body": "Thanks @SergeyKanzhelev for creating an issue to track this. I will further look into this.\r\n\r\n/assign\r\n/triage accepted\r\n/priority important-soon", "created_at": "2023-07-27 08:40:06" }, { "body": "For CPU manager test, node is not ready. This is the NodeCondition object reported in the logs:\r\n```\r\nNodeCondition{\r\n Type:Ready,\r\n Status:False,\r\n LastHeartbeatTime:2023-07-26 18:10:51 +0000 UTC,\r\n LastTransitionTime:2023-07-26 18:10:41 +0000 UTC,\r\n Reason:KubeletNotReady,\r\n Message:\"container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: cni plugin not initialized\",\r\n},\r\n```\r\n\r\nIt also seems to be the case for memory manager.", "created_at": "2023-07-27 17:25:36" }, { "body": "can it be unspecified cgroup driver?\r\n\r\nI cannot find anything strange in logs from a quick look.", "created_at": "2023-07-27 23:32:25" }, { "body": "\r\n> For CPU manager test, node is not ready. This is the NodeCondition object reported in the logs:\r\n> \r\n> ```\r\n> NodeCondition{\r\n> Type:Ready,\r\n> Status:False,\r\n> LastHeartbeatTime:2023-07-26 18:10:51 +0000 UTC,\r\n> LastTransitionTime:2023-07-26 18:10:41 +0000 UTC,\r\n> Reason:KubeletNotReady,\r\n> Message:\"container runtime network not ready: NetworkReady=false reason:NetworkPluginNotReady message:Network plugin returns error: cni plugin not initialized\",\r\n> },\r\n> ```\r\n> \r\n> It also seems to be the case for memory manager.\r\n\r\nThanks Mike, yeah I noticed this and thought the issue was due to mis-configuration.\r\n\r\n> can it be unspecified cgroup driver?\r\n> \r\n> I cannot find anything strange in logs from a quick look.\r\n\r\nI thought so too and added additional node args in https://github.com/kubernetes/test-infra/pull/30072 but that didn't seem to help. Note that the cgroup driver is specified now.\r\n\r\nAlso, I just found that we don't have results for presubmit jobs with the new multi-NUMA setting:\r\nhttps://testgrid.k8s.io/sig-node-presubmits#pr-kubelet-serial-gce-e2e-cpu-manager\r\nhttps://testgrid.k8s.io/sig-node-presubmits#pr-kubelet-serial-gce-e2e-memory-manager\r\nhttps://testgrid.k8s.io/sig-node-presubmits#pr-kubelet-serial-gce-e2e-topology-manager\r\n\r\nThese jobs are disabled by default and perhaps no one executed them yet.\r\n\r\nI can't help but notice that the common demonimnator between these failing jobs is the image-config-file: [image-config-serial-multi-numa.yaml](https://github.com/kubernetes/test-infra/blob/master/jobs/e2e_node/image-config-serial-multi-numa.yaml) and could be the root cause here.\r\n\r\nNext steps:\r\n\r\n1. Create a dummy PR to test the above presubmit jobs to determine if they are failing as well.\r\n2. Update the image config file or replace it with the older one to narrow down the cause of the issue.\r\n\r\nLet me know if this seems reasonable and if you have more ideas.\r\n \r\n", "created_at": "2023-07-28 10:10:53" }, { "body": "- [X] 1. Create a dummy PR to test the above presubmit jobs to determine if they are failing as well.\r\n[PR ](https://github.com/kubernetes/kubernetes/pull/119655) was created and shows that the multi-numa presubmit jobs for cpu manager and memory manager jobs are failing as well. Topology Manager job passes (probably because tests are skipped) and that is consistent with what we see in case of periodic jobs. I don't see build logs for these jobs and the also noticed that the test results are not stored in testgrid. On inspection of job history we get following:\r\n```\r\nfailed to get job history: failed to locate build data: failed to read pr-logs/directory/pull-kubernetes-node-kubelet-serial-memory-manager/latest-build.txt: creating reader for object pr-logs/directory/pull-kubernetes-node-kubelet-serial-memory-manager/latest-build.txt: storage: object doesn't exist\r\n```\r\nThis would need some investigation.\r\n- [X] 2. Update the image config file or replace it with the older one to narrow down the cause of the issue.\r\nhttps://github.com/kubernetes/test-infra/pull/30249", "created_at": "2023-07-28 13:27:11" }, { "body": "I like the plan. Ping me with PRs when needed", "created_at": "2023-07-28 16:39:43" }, { "body": "@SergeyKanzhelev Please take a look at this [PR](https://github.com/kubernetes/test-infra/pull/30249/files) that updates the machine specified in the image-config-serial-multi-numa.yaml image config file.", "created_at": "2023-07-31 14:18:23" }, { "body": "The above PR(s) didn't seem to help, this issue is still being investigated. ", "created_at": "2023-08-23 17:12:24" }, { "body": "/cc", "created_at": "2023-08-23 17:18:54" } ]

[ { "author": "SergeyKanzhelev", "created_at": "2023-07-26 21:17:34", "type": "labeled" }, { "author": "swa", "created_at": "2023-07-26 21:17:34", "type": "mentioned" }, { "author": "swa", "created_at": "2023-07-26 21:17:34", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 21:17:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 21:17:40", "type": "labeled" }, { "author": "swatisehgal", "created_at": "2023-07-26 21:17:50", "type": "mentioned" }, { "author": "swatisehgal", "created_at": "2023-07-26 21:17:51", "type": "subscribed" }, { "author": "swa", "created_at": "2023-07-26 21:17:51", "type": "unsubscribed" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-27 08:40:06", "type": "mentioned" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-27 08:40:06", "type": "subscribed" }, { "author": "swatisehgal", "created_at": "2023-07-27 08:40:07", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:40:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:40:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 08:40:09", "type": "unlabeled" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-31 14:18:23", "type": "mentioned" }, { "author": "SergeyKanzhelev", "created_at": "2023-07-31 14:18:23", "type": "subscribed" } ]

[ "lengrongfu" ]

[ "sig/node", "kind/failing-test", "triage/accepted" ]

[ { "body": "The problem with OOM kill looks the same as this pr https://github.com/kubernetes/kubernetes/pull/116082", "created_at": "2023-07-30 03:10:39" }, { "body": "#119670 will fix this and is already approved(wait for 1.28 release and merge then).\r\n/assign @lengrongfu", "created_at": "2023-08-01 06:30:07" }, { "body": "/triage accepted", "created_at": "2023-08-01 06:30:20" }, { "body": "> #119670 will fix this and is already approved(wait for 1.28 release and merge then).\r\n\r\nThat PR has been merged, but the problem continues to occur, for example today in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119728/pull-kubernetes-node-e2e-containerd/1692065178335580160/", "created_at": "2023-08-17 08:02:23" }, { "body": "Still seeing this occur fairly regularly. I tested locally just increasing the length of the sleep call, but depending on the node load it still flaked. I'm hopeful but not certain that marking the test as serial in #120059 will eliminate the flake.", "created_at": "2023-08-18 18:22:45" }, { "body": "/reopen", "created_at": "2023-08-20 18:40:04" }, { "body": "@tzneal: Reopened this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119600#issuecomment-1685362454):\n\n>/reopen\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-08-20 18:40:09" }, { "body": "I created https://github.com/kubernetes/kubernetes/pull/120077 to revert the change to serial. It doesn't completely resolve the issue, will be digging into this deeper when I get some time.", "created_at": "2023-08-20 18:40:42" }, { "body": "This looks like a containerd issue and @lengrongfu already created a ticket there. I looked at containerd logs from a good and bad test run. In the good run, we get a `Reason = OOMKilled` in the container stopped event. In the bad run, we get a `Reason = Error` on the container stopped event.\r\n\r\n", "created_at": "2023-08-22 14:03:01" }, { "body": "Linking containerd tickets for completeness:\r\n\r\n- https://github.com/containerd/containerd/issues/8180\r\n- https://github.com/containerd/containerd/issues/8893", "created_at": "2023-08-22 20:45:25" }, { "body": "do you think it is a quick start in our case? Or something else", "created_at": "2023-08-22 20:45:44" }, { "body": "I don't think so since the sleep didn't appear to help. containerd reads the memory.events file in the cgroup directory to discover OOM kills. I *think* what's happening is some race where the cgroup directory gets cleaned up before it has a chance to read the memory.events file. I did some testing and when it fails, containerd tries to read memory.events but it has already been removed.", "created_at": "2023-08-23 01:52:11" }, { "body": "/retitle OOMKiller tests are flaking - sometimes condition returned as Failed instead of OOMKilled", "created_at": "2023-08-23 17:11:34" } ]

[ { "author": "SergeyKanzhelev", "created_at": "2023-07-26 21:15:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 21:15:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 21:15:21", "type": "labeled" }, { "author": "lengrongfu", "created_at": "2023-08-01 06:30:08", "type": "mentioned" }, { "author": "lengrongfu", "created_at": "2023-08-01 06:30:08", "type": "subscribed" }, { "author": "lengrongfu", "created_at": "2023-08-01 06:30:09", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 06:30:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-01 06:30:23", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-19 01:19:33", "type": "closed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-20 18:40:08", "type": "reopened" }, { "author": "tzneal", "created_at": "2023-08-20 18:40:09", "type": "mentioned" }, { "author": "tzneal", "created_at": "2023-08-20 18:40:09", "type": "subscribed" }, { "author": "lengrongfu", "created_at": "2023-08-22 14:03:01", "type": "mentioned" }, { "author": "lengrongfu", "created_at": "2023-08-22 14:03:01", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 17:11:38", "type": "renamed" } ]

[]

[ "sig/node", "kind/failing-test", "needs-triage" ]

[ { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-26 21:12:42" }, { "body": "/cc @upodroid", "created_at": "2023-07-26 21:12:55" }, { "body": "/cc @chendave \r\n\r\nhttps://docs.google.com/document/d/1BR_d8g18tsMrp3sHAcHzxlNFN2OQgO6v_2QVt5d-SjY/edit#heading=h.7mktt8dyxg66", "created_at": "2023-07-26 21:46:13" }, { "body": "ssh connection timeouts:\r\n\r\n```\r\nI0726 15:52:38.933125 9430 ssh.go:146] Running the command ssh, with args: [-o UserKnownHostsFile=/dev/null -o IdentitiesOnly=yes -o CheckHostIP=no -o StrictHostKeyChecking=no -o ServerAliveInterval=30 -o LogLevel=ERROR -i /root/.ssh/google_compute_engine [email protected] -- sudo sh -c 'systemctl list-units --type=service --state=running | grep -e containerd -e crio']\r\nE0726 15:54:48.220733 9430 ssh.go:149] failed to run SSH command: out: ssh: connect to host 34.68.230.162 port 22: Connection timed out\r\n, err: exit status 255\r\n```\r\n\r\nWhich weird given that it ran on the default network and there is a firewall rule in there that allows ssh from anywhere.\r\n\r\nhttps://cloudlogging.app.goo.gl/RYkQoj7gtjaz24249\r\nhttps://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-node-arm64-ubuntu-serial/1684224672486395904/build-log.txt\r\n\r\n", "created_at": "2023-07-26 22:42:35" }, { "body": "Got a fix, another regression from https://github.com/kubernetes/kubernetes/pull/119513\r\n\r\nI really need to get these kubetest2 jobs ran as presubmits by default on k/k ASAP.", "created_at": "2023-07-26 23:08:04" } ]

[ { "author": "SergeyKanzhelev", "created_at": "2023-07-26 21:12:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 21:12:37", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 21:12:42", "type": "labeled" }, { "author": "upodroid", "created_at": "2023-07-26 21:12:55", "type": "mentioned" }, { "author": "upodroid", "created_at": "2023-07-26 21:12:55", "type": "subscribed" }, { "author": "chendave", "created_at": "2023-07-26 21:46:13", "type": "mentioned" }, { "author": "chendave", "created_at": "2023-07-26 21:46:13", "type": "subscribed" }, { "author": "dims", "created_at": "2023-07-26 22:42:35", "type": "mentioned" }, { "author": "dims", "created_at": "2023-07-26 22:42:35", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 00:51:54", "type": "closed" } ]

[]

[ "kind/bug", "sig/cluster-lifecycle", "size/L", "area/kubeadm", "cncf-cla: yes", "do-not-merge/release-note-label-needed", "ok-to-test", "needs-priority", "needs-triage" ]

[ { "body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-26 16:37:27" }, { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Jul 26 16:09:42 UTC 2023.\n", "created_at": "2023-07-26 16:37:29" }, { "body": "<a href=\"https://easycla.lfx.linuxfoundation.org/#/?version=2\"><img src=\"https://s3.amazonaws.com/cla-project-logo-prod/cla-signed.svg\" alt=\"CLA Signed\" align=\"left\" height=\"28\" width=\"328\" ></a><br/><br />The committers listed above are authorized under a signed CLA.<ul><li>:white_check_mark: login: tommas1988 / name: Tommas Yuan (0ae41746d1d7423104c3e158e1a5ef07bada3892, 30badd438826f543a903fb21af9ae7b1ed7ab8eb, 1e7fb1240fc929ffcb91dcabcf3a094310437939)</li></ul>", "created_at": "2023-07-26 16:37:32" }, { "body": "Welcome @tommas1988! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:", "created_at": "2023-07-26 16:37:33" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-26 16:37:33" }, { "body": "Hi @tommas1988. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-26 16:37:34" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119598#\" title=\"Author self-approved\">tommas1988</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [pacoxu](https://github.com/pacoxu) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[cmd/kubeadm/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"pacoxu\"]} -->", "created_at": "2023-07-26 16:37:57" }, { "body": "/ok-to-test\r\n\r\nadding test runs, but note that this needs more discussion. i think.", "created_at": "2023-08-20 14:21:18" }, { "body": "please keep the commits squashed to one.\r\n\r\n> Fixes # https://github.com/kubernetes/kubeadm/issues/2907\r\n\r\nshould be\r\n\r\n> Fixes https://github.com/kubernetes/kubeadm/issues/2907", "created_at": "2023-08-20 14:29:45" }, { "body": "@tommas1988: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-node-e2e-containerd | 1e7fb1240fc929ffcb91dcabcf3a094310437939 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119598/pull-kubernetes-node-e2e-containerd/1693266977918816256/) | true | `/test pull-kubernetes-node-e2e-containerd`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119598). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Atommas1988). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-08-20 14:48:32" }, { "body": "/cc\r\n\r\nalso, pls create a release note for this.", "created_at": "2023-08-23 02:42:39" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:37:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:37:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:37:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:37:32", "type": "labeled" }, { "author": "tommas1988", "created_at": "2023-07-26 16:37:32", "type": "mentioned" }, { "author": "tommas1988", "created_at": "2023-07-26 16:37:32", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:37:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:37:33", "type": "labeled" }, { "author": "tommas1988", "created_at": "2023-07-26 16:37:33", "type": "mentioned" }, { "author": "tommas1988", "created_at": "2023-07-26 16:37:33", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:37:34", "type": "labeled" }, { "author": "tommas1988", "created_at": "2023-07-26 16:37:34", "type": "mentioned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:37:34", "type": "labeled" }, { "author": "tommas1988", "created_at": "2023-07-26 16:37:34", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:38:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:38:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:38:12", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:38:21", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:38:22", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:42:20", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:42:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 12:43:54", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 12:43:55", "type": "labeled" }, { "author": "tommas1988", "created_at": "2023-08-06 21:28:05", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-08-20 14:21:19", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-20 14:21:20", "type": "unlabeled" }, { "author": "tommas1988", "created_at": "2023-08-20 14:48:32", "type": "mentioned" }, { "author": "tommas1988", "created_at": "2023-08-20 14:48:32", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 02:42:40", "type": "review_requested" } ]

[ "nikhita", "xmudrii" ]

[ "priority/critical-urgent", "lgtm", "size/L", "kind/feature", "area/release-eng", "release-note-none", "approved", "cncf-cla: yes", "sig/release", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Jul 26 16:09:42 UTC 2023.\n", "created_at": "2023-07-26 16:28:22" }, { "body": "LGTM label has been added. <details>Git tree hash: ce888480accd7400ec286e98769a7dcaed764458</details>", "created_at": "2023-07-26 16:30:37" }, { "body": "/priority critical-urgent\r\n/triage accepted", "created_at": "2023-07-26 16:34:28" }, { "body": "/kind feature\r\n/remove-kind bug", "created_at": "2023-07-26 16:35:59" }, { "body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119597#\" title=\"Author self-approved\">akhilerm</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119597#pullrequestreview-1548159300\" title=\"Approved\">nikhita</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119597#pullrequestreview-1548171259\" title=\"Approved\">xmudrii</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/publishing/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/publishing/OWNERS)~~ [nikhita]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->", "created_at": "2023-07-26 16:37:22" }, { "body": "/milestone v1.28", "created_at": "2023-07-26 21:12:50" }, { "body": "/hold cancel", "created_at": "2023-07-26 21:22:00" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:28:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:28:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:28:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:28:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:28:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:28:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:28:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:29:02", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:29:03", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:29:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:29:15", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:29:17", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:30:30", "type": "labeled" }, { "author": "nikhita", "created_at": "2023-07-26 16:30:35", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:30:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:30:49", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:34:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:34:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:34:31", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:34:32", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:36:01", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 16:36:02", "type": "unlabeled" }, { "author": "xmudrii", "created_at": "2023-07-26 16:37:06", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 21:12:52", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 21:22:01", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 21:24:08", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 21:24:08", "type": "merged" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 21:24:08", "type": "closed" }, { "author": "akhilerm", "created_at": "2023-07-27 05:57:52", "type": "head_ref_deleted" } ]

[ "bobbypage", "haircommander" ]

[ "kind/documentation", "lgtm", "sig/node", "sig/api-machinery", "size/XS", "kind/api-change", "release-note-none", "cncf-cla: yes", "priority/important-longterm", "area/code-generation", "ok-to-test", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Jul 26 10:09:28 UTC 2023.\n", "created_at": "2023-07-26 15:42:27" }, { "body": "Hi @chicobento. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n", "created_at": "2023-07-26 15:42:31" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119596#\" title=\"Author self-approved\">chicobento</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [thockin](https://github.com/thockin) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/api/OWNERS)**\n- **[pkg/generated/openapi/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/generated/openapi/OWNERS)**\n- **[staging/src/k8s.io/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"thockin\"]} -->", "created_at": "2023-07-27 14:43:39" }, { "body": "/api-review\r\n/sig node\r\n/remove-sig api-machinery", "created_at": "2023-07-27 16:33:41" }, { "body": "/triage accepted\r\n/priority important-longterm\r\n/ok-to-test\r\n/assign @bobbypage @haircommander ", "created_at": "2023-08-03 09:55:17" }, { "body": "the first commit LGTM, the second needs some work--a lot more got pulled in than I (and the [verify job](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119596/pull-kubernetes-verify/1687039445653524480)) would expect", "created_at": "2023-08-03 13:22:36" }, { "body": "/retest", "created_at": "2023-08-03 14:05:38" }, { "body": "hi @haircommander , my env was generating additional, unrelated files on the second commit. I think it was because I was missing the repo tags.\r\nI just rebased my fork, fetched the tags, re-ran the codegen scripts and pushed-force. It looks better now, lets see how it goes on the verify job", "created_at": "2023-08-03 14:07:31" }, { "body": "yup looks good now, thanks\r\n\r\n/lgtm", "created_at": "2023-08-03 16:00:41" }, { "body": "LGTM label has been added. <details>Git tree hash: d8601c1a8cf39ae72c623f037071407b5d5dcc1a</details>", "created_at": "2023-08-03 16:00:50" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:42:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:42:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:42:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:42:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:42:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:42:30", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:42:31", "type": "labeled" }, { "author": "chicobento", "created_at": "2023-07-26 15:42:32", "type": "mentioned" }, { "author": "chicobento", "created_at": "2023-07-26 15:42:32", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:42:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:43:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:43:21", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:43:22", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 19:04:10", "type": "labeled" }, { "author": "chicobento", "created_at": "2023-07-26 19:52:20", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 19:57:01", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 14:43:01", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 14:43:02", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 14:43:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 14:43:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 14:43:55", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:33:43", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:33:43", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 16:39:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 16:39:44", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 16:40:00", "type": "labeled" }, { "author": "chicobento", "created_at": "2023-07-31 16:46:13", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-31 16:46:30", "type": "unlabeled" }, { "author": "chicobento", "created_at": "2023-07-31 16:54:58", "type": "head_ref_force_pushed" }, { "author": "bobbypage", "created_at": "2023-08-03 09:55:18", "type": "mentioned" }, { "author": "bobbypage", "created_at": "2023-08-03 09:55:18", "type": "subscribed" }, { "author": "haircommander", "created_at": "2023-08-03 09:55:18", "type": "mentioned" }, { "author": "haircommander", "created_at": "2023-08-03 09:55:18", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 09:55:19", "type": "labeled" }, { "author": "bobbypage", "created_at": "2023-08-03 09:55:19", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 09:55:19", "type": "labeled" }, { "author": "haircommander", "created_at": "2023-08-03 09:55:19", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 09:55:20", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 09:55:20", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 09:55:22", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 09:55:22", "type": "unlabeled" }, { "author": "chicobento", "created_at": "2023-08-03 10:45:56", "type": "mentioned" }, { "author": "chicobento", "created_at": "2023-08-03 10:45:56", "type": "subscribed" }, { "author": "chicobento", "created_at": "2023-08-03 14:01:30", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 14:01:37", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 14:01:38", "type": "labeled" }, { "author": "haircommander", "created_at": "2023-08-03 14:07:32", "type": "mentioned" }, { "author": "haircommander", "created_at": "2023-08-03 14:07:32", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-03 16:00:49", "type": "labeled" } ]

[]

[ "kind/bug", "area/security", "area/kubelet", "sig/windows", "lifecycle/frozen", "committee/security-response", "triage/accepted", "official-cve-feed" ]

[ { "body": "/area security\r\n/kind bug\r\n/committee security-response\r\n/sig windows\r\n/area kubelet", "created_at": "2023-08-23 14:23:29" }, { "body": "/label official-cve-feed", "created_at": "2023-08-23 14:24:40" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:30:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:30:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:30:52", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:30:53", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:30:54", "type": "labeled" }, { "author": "jeremyrickard", "created_at": "2023-08-23 14:23:05", "type": "renamed" }, { "author": "jsturtevant", "created_at": "2023-08-23 14:23:21", "type": "mentioned" }, { "author": "jsturtevant", "created_at": "2023-08-23 14:23:21", "type": "subscribed" }, { "author": "marosset", "created_at": "2023-08-23 14:23:22", "type": "mentioned" }, { "author": "marosset", "created_at": "2023-08-23 14:23:22", "type": "subscribed" }, { "author": "tomerpeled92", "created_at": "2023-08-23 14:23:22", "type": "mentioned" }, { "author": "tomerpeled92", "created_at": "2023-08-23 14:23:22", "type": "subscribed" }, { "author": "andyzhangx", "created_at": "2023-08-23 14:23:22", "type": "mentioned" }, { "author": "andyzhangx", "created_at": "2023-08-23 14:23:22", "type": "subscribed" }, { "author": "jterry75", "created_at": "2023-08-23 14:23:22", "type": "mentioned" }, { "author": "jterry75", "created_at": "2023-08-23 14:23:22", "type": "subscribed" }, { "author": "KlwntSingh", "created_at": "2023-08-23 14:23:22", "type": "mentioned" }, { "author": "KlwntSingh", "created_at": "2023-08-23 14:23:22", "type": "subscribed" }, { "author": "micahhausler", "created_at": "2023-08-23 14:23:22", "type": "mentioned" }, { "author": "micahhausler", "created_at": "2023-08-23 14:23:22", "type": "subscribed" }, { "author": "ritazh", "created_at": "2023-08-23 14:23:23", "type": "mentioned" }, { "author": "ritazh", "created_at": "2023-08-23 14:23:23", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-08-23 14:23:23", "type": "mentioned" }, { "author": "jeremyrickard", "created_at": "2023-08-23 14:23:23", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 14:23:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 14:23:31", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 14:24:42", "type": "labeled" } ]

[]

[ "kind/bug", "area/security", "area/kubelet", "sig/windows", "lifecycle/frozen", "committee/security-response", "triage/accepted", "official-cve-feed" ]

[ { "body": "/area security\r\n/kind bug\r\n/committee security-response\r\n/sig windows\r\n/area kubelet", "created_at": "2023-08-23 14:22:18" }, { "body": "/label official-cve-feed", "created_at": "2023-08-23 14:22:40" }, { "body": "Weirdly it didn't synk with the official cve feed: \"Official Kubernetes CVE List (last updated: 24 Aug 2023 11:16:31 UTC)\"", "created_at": "2023-08-24 13:26:47" }, { "body": "@sshayb the k8s CVE feed gets updated when there is a new k8s release. You should see recently announced CVEs in the feed soon. However for this particular CVE, it will not show up in the feed as this component is outside of k8s core and it is not part of the k8s release. You can get the latest releases for csi-proxy here: https://github.com/kubernetes-csi/csi-proxy/releases", "created_at": "2023-08-24 20:42:51" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:30:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:30:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:30:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:30:29", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:30:30", "type": "labeled" }, { "author": "jeremyrickard", "created_at": "2023-08-23 14:21:32", "type": "renamed" }, { "author": "jsturtevant", "created_at": "2023-08-23 14:22:06", "type": "mentioned" }, { "author": "jsturtevant", "created_at": "2023-08-23 14:22:06", "type": "subscribed" }, { "author": "marosset", "created_at": "2023-08-23 14:22:06", "type": "mentioned" }, { "author": "marosset", "created_at": "2023-08-23 14:22:07", "type": "subscribed" }, { "author": "tomerpeled92", "created_at": "2023-08-23 14:22:07", "type": "mentioned" }, { "author": "tomerpeled92", "created_at": "2023-08-23 14:22:07", "type": "subscribed" }, { "author": "andyzhangx", "created_at": "2023-08-23 14:22:07", "type": "mentioned" }, { "author": "andyzhangx", "created_at": "2023-08-23 14:22:07", "type": "subscribed" }, { "author": "jterry75", "created_at": "2023-08-23 14:22:07", "type": "mentioned" }, { "author": "jterry75", "created_at": "2023-08-23 14:22:07", "type": "subscribed" }, { "author": "KlwntSingh", "created_at": "2023-08-23 14:22:07", "type": "mentioned" }, { "author": "KlwntSingh", "created_at": "2023-08-23 14:22:07", "type": "subscribed" }, { "author": "micahhausler", "created_at": "2023-08-23 14:22:07", "type": "mentioned" }, { "author": "micahhausler", "created_at": "2023-08-23 14:22:07", "type": "subscribed" }, { "author": "ritazh", "created_at": "2023-08-23 14:22:08", "type": "mentioned" }, { "author": "ritazh", "created_at": "2023-08-23 14:22:08", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 14:22:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 14:22:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-08-23 14:22:45", "type": "labeled" }, { "author": "sshayb", "created_at": "2023-08-24 20:42:51", "type": "mentioned" }, { "author": "sshayb", "created_at": "2023-08-24 20:42:51", "type": "subscribed" } ]

[ "xing-yang" ]

[ "sig/api-machinery", "triage/accepted" ]

[ { "body": "/sig storage", "created_at": "2023-07-27 05:47:33" }, { "body": "After a deep code reading, I think it's not a sig-storage issue. But I'm not sure if it's real bug or not.\r\n\r\nthe quota admission in the kube-apiserver will update the usage value of a quota object if the request is admited though the request would be rejected by the kube-apiserver later. When a user create the same resource repeatedly in a very short time like this issue, the quota admission will update the usage value of the quota object to a wrong value eventually lead to reject other requests.\r\n\r\nthe quota controller in the kube-controller-manager is responsible for tracking quota usage status in the system and sync the quota object from the apiserver when quota is changed, and update the usage value of the quota to real.\r\n\r\n/sig api-machinery\r\n\r\n/cc @xing-yang for sig-storage side reivew.\r\n\r\n/cc @deads2k", "created_at": "2023-07-27 09:23:48" }, { "body": "/assign @xing-yang \r\nFor sig-storage.\r\n/triage accepted", "created_at": "2023-07-27 16:38:22" }, { "body": "Admission is enforced prior to persisting to etcd, so the resource quota reservation is committed before the write fails.\r\n\r\nThe quota controller periodically syncs consumed quota with actually persisted objects, but recovering quota reserved for a failed create happens asynchronously, not synchronously. \r\n\r\nThis issue is a duplicate of https://github.com/kubernetes/kubernetes/issues/61530, https://github.com/kubernetes/kubernetes/issues/70563, https://github.com/kubernetes/kubernetes/issues/76787", "created_at": "2023-08-04 05:27:59" } ]

[ { "author": "ldruschk", "created_at": "2023-07-26 15:21:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:21:21", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:21:22", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 05:47:35", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 05:47:36", "type": "unlabeled" }, { "author": "xing-yang", "created_at": "2023-07-27 09:23:48", "type": "mentioned" }, { "author": "xing-yang", "created_at": "2023-07-27 09:23:48", "type": "subscribed" }, { "author": "deads2k", "created_at": "2023-07-27 09:23:48", "type": "mentioned" }, { "author": "deads2k", "created_at": "2023-07-27 09:23:48", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:23:50", "type": "labeled" }, { "author": "xing-yang", "created_at": "2023-07-27 16:38:22", "type": "mentioned" }, { "author": "xing-yang", "created_at": "2023-07-27 16:38:22", "type": "subscribed" }, { "author": "xing-yang", "created_at": "2023-07-27 16:38:23", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:38:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 16:38:25", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-04 05:28:00", "type": "closed" }, { "author": "liggitt", "created_at": "2023-08-04 05:28:25", "type": "unlabeled" }, { "author": "liggitt", "created_at": "2023-08-04 05:28:25", "type": "unlabeled" } ]

[ "bart0sh", "xmudrii" ]

[ "area/test", "lgtm", "sig/node", "release-note", "size/S", "kind/feature", "sig/cli", "cncf-cla: yes", "sig/testing", "priority/important-longterm", "sig/release", "triage/accepted" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Jul 26 10:09:28 UTC 2023.\n", "created_at": "2023-07-26 13:22:30" }, { "body": "Hey @rayandas, thank you for your PR! I think those utilities are useful in the kubectl image. We usually tend to avoid images with shell by using distroless, but that might not be ideal for kubectl. However, I'd prefer changing the base image rather than adding tools one by one. We should use the base image that provides more tools out of the box and I think `debian-base` image that we ship is a good candidate: `registry.k8s.io/build-image/debian-base:bookworm-v1.0.0`\r\n\r\nI'd also like other RelEng folks to take a look at this PR and provide their feedback, so I'm going to cc them.\r\ncc @kubernetes/release-engineering ", "created_at": "2023-07-26 14:38:51" }, { "body": "@xmudrii Sure, that sounds good. ", "created_at": "2023-07-26 17:02:20" }, { "body": "@rayandas Can you also add a release note since this is a user facing change?", "created_at": "2023-07-27 05:54:20" }, { "body": "/priority important-longterm\r\n/triage accepted", "created_at": "2023-07-27 05:54:43" }, { "body": "/sig cli\r\n/sig release", "created_at": "2023-07-27 05:55:14" }, { "body": "@palnabarun Sure thing. I will add a release note.", "created_at": "2023-07-27 06:06:51" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119592#\" title=\"Author self-approved\">rayandas</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119592#pullrequestreview-1551506504\" title=\"Approved\">saschagrunert</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119592#pullrequestreview-1551675801\" title=\"Approved\">xmudrii</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [dims](https://github.com/dims) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[build/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/build/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"dims\"]} -->", "created_at": "2023-07-28 09:01:58" }, { "body": "LGTM label has been added. <details>Git tree hash: 296ee1f2d76226eb05f5968c9475350849c67e5b</details>", "created_at": "2023-07-28 09:01:58" }, { "body": "/hold\r\nSorry, I am checking if the new kubectl image supports all architectures. Holing it till then. ", "created_at": "2023-07-28 12:52:44" }, { "body": "/hold cancel", "created_at": "2023-07-28 14:46:08" }, { "body": "/lgtm", "created_at": "2023-08-24 14:22:05" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-26 13:22:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 13:22:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 13:22:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 13:22:32", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 13:22:33", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 13:22:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 13:22:36", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 13:23:09", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 13:23:09", "type": "review_requested" }, { "author": "rayandas", "created_at": "2023-07-26 13:24:41", "type": "renamed" }, { "author": "rayandas", "created_at": "2023-07-26 13:31:06", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-26 13:31:06", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-26 13:32:31", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-26 13:32:31", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-26 13:33:33", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-26 13:33:33", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-26 13:40:16", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 13:40:18", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 13:40:19", "type": "labeled" }, { "author": "rayandas", "created_at": "2023-07-26 13:40:35", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-26 13:40:35", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-26 13:50:34", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-26 13:50:34", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-26 13:50:38", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-26 13:50:38", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-26 13:50:56", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-26 13:50:56", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-26 14:01:47", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-26 14:01:47", "type": "subscribed" }, { "author": "dims", "created_at": "2023-07-26 14:07:48", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 14:07:50", "type": "labeled" }, { "author": "rayandas", "created_at": "2023-07-26 14:38:51", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-26 14:38:52", "type": "subscribed" }, { "author": "justaugustus", "created_at": "2023-07-26 14:38:52", "type": "subscribed" }, { "author": "saschagrunert", "created_at": "2023-07-26 14:38:52", "type": "subscribed" }, { "author": "salaxander", "created_at": "2023-07-26 14:38:52", "type": "subscribed" }, { "author": "Verolop", "created_at": "2023-07-26 14:38:52", "type": "subscribed" }, { "author": "ameukam", "created_at": "2023-07-26 14:38:52", "type": "subscribed" }, { "author": "ramrodo", "created_at": "2023-07-26 14:38:52", "type": "subscribed" }, { "author": "cici37", "created_at": "2023-07-26 14:38:52", "type": "subscribed" }, { "author": "puerco", "created_at": "2023-07-26 14:38:53", "type": "subscribed" }, { "author": "palnabarun", "created_at": "2023-07-26 14:38:53", "type": "subscribed" }, { "author": "cpanato", "created_at": "2023-07-26 14:38:53", "type": "subscribed" }, { "author": "xmudrii", "created_at": "2023-07-26 14:38:53", "type": "subscribed" }, { "author": "jimangel", "created_at": "2023-07-26 14:38:53", "type": "subscribed" }, { "author": "jrsapi", "created_at": "2023-07-26 14:38:53", "type": "subscribed" }, { "author": "k8s-release-robot", "created_at": "2023-07-26 14:38:53", "type": "subscribed" }, { "author": "jeremyrickard", "created_at": "2023-07-26 14:38:53", "type": "subscribed" }, { "author": "gracenng", "created_at": "2023-07-26 14:38:53", "type": "subscribed" }, { "author": "xmudrii", "created_at": "2023-07-26 17:02:21", "type": "mentioned" }, { "author": "xmudrii", "created_at": "2023-07-26 17:02:21", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-27 05:30:14", "type": "head_ref_force_pushed" }, { "author": "rayandas", "created_at": "2023-07-27 05:54:20", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-27 05:54:20", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 05:54:45", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 05:54:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 05:54:46", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 05:54:48", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 05:55:16", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 05:55:17", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 05:55:17", "type": "unlabeled" }, { "author": "rayandas", "created_at": "2023-07-27 05:58:32", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-27 05:58:32", "type": "subscribed" }, { "author": "palnabarun", "created_at": "2023-07-27 06:06:51", "type": "mentioned" }, { "author": "palnabarun", "created_at": "2023-07-27 06:06:51", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 06:24:34", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 06:24:35", "type": "unlabeled" }, { "author": "rayandas", "created_at": "2023-07-27 09:24:40", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:25:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:25:14", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:25:15", "type": "labeled" }, { "author": "rayandas", "created_at": "2023-07-27 09:28:55", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:28:57", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:28:58", "type": "labeled" }, { "author": "rayandas", "created_at": "2023-07-27 09:36:59", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-27 09:36:59", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-27 09:38:49", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-27 09:38:49", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-27 09:39:12", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-27 09:39:12", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-27 09:39:21", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-27 09:39:21", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-27 09:40:42", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:40:44", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 09:40:45", "type": "labeled" }, { "author": "rayandas", "created_at": "2023-07-27 09:48:47", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-27 09:48:47", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-27 09:49:37", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-27 09:49:37", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-27 09:50:37", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-27 09:50:37", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-27 09:50:42", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-27 09:50:42", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-27 10:01:29", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-27 10:01:29", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-27 10:38:15", "type": "head_ref_force_pushed" }, { "author": "rayandas", "created_at": "2023-07-27 10:50:16", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-27 10:50:16", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-27 10:50:25", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-27 10:50:25", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-27 10:50:33", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-27 10:50:33", "type": "subscribed" }, { "author": "rayandas", "created_at": "2023-07-27 10:56:22", "type": "head_ref_force_pushed" }, { "author": "rayandas", "created_at": "2023-07-27 11:57:48", "type": "review_requested" }, { "author": "rayandas", "created_at": "2023-07-27 14:06:42", "type": "renamed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 14:06:46", "type": "unlabeled" }, { "author": "rayandas", "created_at": "2023-07-28 05:27:49", "type": "head_ref_force_pushed" }, { "author": "rayandas", "created_at": "2023-07-28 06:11:42", "type": "mentioned" }, { "author": "rayandas", "created_at": "2023-07-28 06:11:42", "type": "subscribed" }, { "author": "xmudrii", "created_at": "2023-07-28 09:01:56", "type": "assigned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 09:01:57", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 12:52:46", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-28 14:46:09", "type": "unlabeled" }, { "author": "bart0sh", "created_at": "2023-08-24 14:23:57", "type": "assigned" } ]

[]

[ "needs-sig", "needs-triage" ]

[ { "body": "There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:\n- `/sig <group-name>`\n- `/wg <group-name>`\n- `/committee <group-name>`\n\nPlease see the [group list](https://git.k8s.io/community/sig-list.md) for a listing of the SIGs, working groups, and committees available.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-26 12:25:24" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-26 12:25:25" }, { "body": "Sorry, no. https://github.com/kubernetes/kubernetes/issues/80029\r\n\r\n/close", "created_at": "2023-07-26 13:21:06" }, { "body": "@dims: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119591#issuecomment-1651794540):\n\n>Sorry, no. https://github.com/kubernetes/kubernetes/issues/80029\r\n>\r\n>/close\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-26 13:21:12" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-26 12:25:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 12:25:25", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 13:21:12", "type": "closed" }, { "author": "dims", "created_at": "2023-07-26 13:21:13", "type": "mentioned" }, { "author": "dims", "created_at": "2023-07-26 13:21:13", "type": "subscribed" } ]

[]

[ "area/test", "area/kubelet", "sig/scheduling", "sig/node", "size/L", "cncf-cla: yes", "sig/testing", "do-not-merge/release-note-label-needed", "do-not-merge/cherry-pick-not-approved", "do-not-merge/work-in-progress", "needs-priority", "needs-triage", "do-not-merge/needs-kind" ]

[ { "body": "Skipping CI for Draft Pull Request.\nIf you want CI signal for your change, please convert it to an actual PR.\nYou can still manually trigger a test run with `/test all`", "created_at": "2023-07-26 10:52:23" }, { "body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-26 10:52:23" }, { "body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-26 10:52:24" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-26 10:52:29" }, { "body": "/test pull-kubernetes-e2e-gce-device-plugin-gpu", "created_at": "2023-07-26 10:52:50" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119590#\" title=\"Author self-approved\">ffromani</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [ahg-g](https://github.com/ahg-g), [klueska](https://github.com/klueska) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/kubelet/cm/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/pkg/kubelet/cm/OWNERS)**\n- **[test/e2e/scheduling/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/test/e2e/scheduling/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"ahg-g\",\"klueska\"]} -->", "created_at": "2023-07-26 15:53:38" }, { "body": "/test pull-kubernetes-e2e-gce-device-plugin-gpu", "created_at": "2023-07-26 15:59:04" }, { "body": "/test pull-kubernetes-e2e-gce-device-plugin-gpu", "created_at": "2023-07-26 16:58:05" }, { "body": "/test pull-kubernetes-e2e-gce-device-plugin-gpu", "created_at": "2023-07-27 10:47:31" }, { "body": "/test pull-kubernetes-e2e-gce-device-plugin-gpu", "created_at": "2023-07-27 11:58:51" }, { "body": "/test pull-kubernetes-e2e-gce-device-plugin-gpu\r\n\r\n\r\n", "created_at": "2023-07-27 12:57:54" }, { "body": "/test pull-kubernetes-e2e-gce-device-plugin-gpu", "created_at": "2023-07-27 13:54:44" }, { "body": "/test pull-kubernetes-e2e-gce-device-plugin-gpu", "created_at": "2023-07-27 14:56:00" }, { "body": "/test pull-kubernetes-e2e-gce-device-plugin-gpu", "created_at": "2023-07-27 15:54:49" }, { "body": "/test pull-kubernetes-e2e-capz-windows-1-27 ", "created_at": "2023-07-28 08:12:16" }, { "body": "/test pull-kubernetes-e2e-capz-windows-1-27", "created_at": "2023-08-02 07:51:06" }, { "body": "/test pull-kubernetes-e2e-gce-device-plugin-gpu", "created_at": "2023-08-02 07:51:12" }, { "body": "/test pull-kubernetes-e2e-gce-device-plugin-gpu", "created_at": "2023-08-03 11:35:51" }, { "body": "/test pull-kubernetes-e2e-capz-windows-1-27", "created_at": "2023-08-08 14:54:22" }, { "body": "@ffromani: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-e2e-gce-device-plugin-gpu | 55fe670e99ceec5000c9f3fa82c34c8d8b2d1c06 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119590/pull-kubernetes-e2e-gce-device-plugin-gpu/1687064741190569984/) | false | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-e2e-capz-windows-1-27 | 55fe670e99ceec5000c9f3fa82c34c8d8b2d1c06 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119590/pull-kubernetes-e2e-capz-windows-1-27/1688926638114344960) | false | `/test pull-kubernetes-e2e-capz-windows-1-27`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119590). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Affromani). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->", "created_at": "2023-08-08 16:41:26" }, { "body": "there were real issues, fixed by https://github.com/kubernetes/test-infra/pull/30450 and https://github.com/kubernetes/test-infra/pull/30352", "created_at": "2023-08-22 06:06:05" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:52:23", "type": "milestoned" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:52:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:52:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:52:23", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:52:24", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:52:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:52:26", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:52:26", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:52:26", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:52:27", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:52:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:52:28", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:52:31", "type": "labeled" }, { "author": "ffromani", "created_at": "2023-07-26 11:36:18", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-07-26 11:36:18", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-07-26 15:30:27", "type": "referenced" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:53:03", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:53:04", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:53:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:53:38", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 15:53:39", "type": "labeled" }, { "author": "ffromani", "created_at": "2023-07-26 16:44:21", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-07-26 16:44:21", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-07-26 16:57:25", "type": "head_ref_force_pushed" }, { "author": "ffromani", "created_at": "2023-07-26 17:43:16", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-07-26 17:43:16", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-07-27 10:47:02", "type": "head_ref_force_pushed" }, { "author": "ffromani", "created_at": "2023-07-27 11:33:03", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-07-27 11:33:03", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-07-27 11:56:10", "type": "head_ref_force_pushed" }, { "author": "ffromani", "created_at": "2023-07-27 12:43:41", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-07-27 12:43:41", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-07-27 12:57:02", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 12:57:04", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-27 12:57:05", "type": "labeled" }, { "author": "ffromani", "created_at": "2023-07-27 13:12:29", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-07-27 13:12:29", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-07-27 14:08:49", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-07-27 14:08:49", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-07-27 14:32:18", "type": "head_ref_force_pushed" }, { "author": "ffromani", "created_at": "2023-07-27 15:42:12", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-07-27 15:42:13", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-07-27 15:53:44", "type": "head_ref_force_pushed" }, { "author": "ffromani", "created_at": "2023-07-27 16:39:24", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-07-27 16:39:24", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-07-28 09:17:50", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-07-28 09:17:50", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-08-02 09:37:06", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-08-02 09:37:06", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-08-03 11:35:42", "type": "head_ref_force_pushed" }, { "author": "ffromani", "created_at": "2023-08-03 12:22:41", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-08-03 12:22:42", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-08-08 16:41:26", "type": "mentioned" }, { "author": "ffromani", "created_at": "2023-08-08 16:41:26", "type": "subscribed" }, { "author": "ffromani", "created_at": "2023-08-22 06:06:06", "type": "closed" }, { "author": "ffromani", "created_at": "2023-08-22 06:06:12", "type": "head_ref_deleted" } ]

[ "brianpursley" ]

[ "kind/bug", "area/kubectl", "release-note", "size/S", "sig/cli", "cncf-cla: yes", "needs-priority", "needs-triage" ]

[ { "body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Jul 26 10:09:28 UTC 2023.\n", "created_at": "2023-07-26 10:13:09" }, { "body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-26 10:13:12" }, { "body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119589#\" title=\"Author self-approved\">carlory</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [brianpursley](https://github.com/brianpursley) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"brianpursley\"]} -->", "created_at": "2023-07-26 10:13:56" }, { "body": "/cc @mpuckett159 @danielmilanov", "created_at": "2023-07-26 10:13:58" }, { "body": "@carlory: GitHub didn't allow me to request PR reviews from the following users: danielmilanov.\n\nNote that only [kubernetes members](https://github.com/orgs/kubernetes/people) and repo collaborators can review this PR, and authors cannot review their own PRs.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119589#issuecomment-1651453932):\n\n>/cc @mpuckett159 @danielmilanov\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>", "created_at": "2023-07-26 10:14:00" }, { "body": "/test pull-kubernetes-node-e2e-containerd", "created_at": "2023-07-26 12:20:16" }, { "body": "/cc @mpuckett159 @ardaguclu @brianpursley", "created_at": "2023-08-22 02:22:30" }, { "body": "/assign @brianpursley", "created_at": "2023-08-22 02:23:02" } ]

[ { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:13:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:13:06", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:13:07", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:13:09", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:13:11", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:13:12", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:13:13", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:13:43", "type": "review_requested" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:13:43", "type": "review_requested" }, { "author": "mpuckett159", "created_at": "2023-07-26 10:13:58", "type": "mentioned" }, { "author": "mpuckett159", "created_at": "2023-07-26 10:13:59", "type": "subscribed" }, { "author": "danielmilanov", "created_at": "2023-07-26 10:13:59", "type": "mentioned" }, { "author": "danielmilanov", "created_at": "2023-07-26 10:13:59", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:14:00", "type": "review_requested" }, { "author": "mpuckett159", "created_at": "2023-07-26 10:14:01", "type": "mentioned" }, { "author": "mpuckett159", "created_at": "2023-07-26 10:14:01", "type": "subscribed" }, { "author": "carlory", "created_at": "2023-07-26 10:14:01", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-26 10:14:01", "type": "subscribed" }, { "author": "danielmilanov", "created_at": "2023-07-26 10:14:01", "type": "mentioned" }, { "author": "danielmilanov", "created_at": "2023-07-26 10:14:01", "type": "subscribed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:14:08", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:14:10", "type": "labeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:14:12", "type": "unlabeled" }, { "author": "carlory", "created_at": "2023-07-26 10:16:37", "type": "head_ref_force_pushed" }, { "author": "carlory", "created_at": "2023-07-26 10:23:37", "type": "head_ref_force_pushed" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:23:39", "type": "unlabeled" }, { "author": "k8s-ci-robot", "created_at": "2023-07-26 10:23:40", "type": "labeled" }, { "author": "carlory", "created_at": "2023-07-26 10:24:44", "type": "head_ref_force_pushed" }, { "author": "carlory", "created_at": "2023-07-26 10:49:55", "type": "mentioned" }, { "author": "carlory", "created_at": "2023-07-26 10:49:56", "type": "subscribed" }, { "author": "brianpursley", "created_at": "2023-08-22 02:22:31", "type": "mentioned" }, { "author": "brianpursley", "created_at": "2023-08-22 02:22:31", "type": "subscribed" }, { "author": "ardaguclu", "created_at": "2023-08-22 02:22:31", "type": "mentioned" }, { "author": "ardaguclu", "created_at": "2023-08-22 02:22:31", "type": "subscribed" }, { "author": "mpuckett159", "created_at": "2023-08-22 02:22:31", "type": "mentioned" }, { "author": "mpuckett159", "created_at": "2023-08-22 02:22:31", "type": "subscribed" }, { "author": "brianpursley", "created_at": "2023-08-22 02:23:02", "type": "mentioned" }, { "author": "brianpursley", "created_at": "2023-08-22 02:23:02", "type": "subscribed" }, { "author": "brianpursley", "created_at": "2023-08-22 02:23:03", "type": "assigned" } ]