number
int64 119k
120k
| title
stringlengths 13
268
| state
stringclasses 2
values | created_at
stringlengths 19
19
| updated_at
stringlengths 19
19
| closed_at
stringlengths 19
19
⌀ | assignees
sequence | labels
sequence | reporter
stringlengths 3
26
| comments
list | events
list |
|---|---|---|---|---|---|---|---|---|---|---|
119,999 | Automated cherry pick of #119860: update to golangci-lint v1.54.1 + go-ruleguard v0.4.0 | open | 2023-08-17 07:37:15 | 2023-08-17 13:46:32 | null | [
"liggitt"
] | [
"kind/cleanup",
"lgtm",
"size/L",
"release-note-none",
"approved",
"cncf-cla: yes",
"sig/testing",
"do-not-merge/cherry-pick-not-approved",
"needs-priority",
"needs-triage"
] | pohly | [
{
"body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-17 07:37:17"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-17 07:37:23"
},
{
"body": "/sig testing\r\n/kind cleanup\r\n/release-note-none",
"created_at": "2023-08-17 07:55:35"
},
{
"body": "/lgtm\r\n/approve",
"created_at": "2023-08-17 13:46:12"
},
{
"body": "LGTM label has been added. <details>Git tree hash: b1560c5c13f84b1e93eeffc45e928a43efde952e</details>",
"created_at": "2023-08-17 13:46:20"
},
{
"body": "/cc @kubernetes/release-managers ",
"created_at": "2023-08-17 13:46:22"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119999#issuecomment-1682317298\" title=\"Approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119999#\" title=\"Author self-approved\">pohly</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/hack/OWNERS)~~ [liggitt,pohly]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-17 13:46:32"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:37:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:37:17",
"type": "labeled"
},
{
"author": "pohly",
"created_at": "2023-08-17 07:37:17",
"type": "mentioned"
},
{
"author": "pohly",
"created_at": "2023-08-17 07:37:17",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:37:18",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:37:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:37:21",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:37:21",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:37:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:37:22",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:37:22",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:37:23",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:37:24",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:36",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:37",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:37",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:37",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:38",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:39",
"type": "unlabeled"
},
{
"author": "liggitt",
"created_at": "2023-08-17 13:46:17",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 13:46:19",
"type": "labeled"
},
{
"author": "justaugustus",
"created_at": "2023-08-17 13:46:22",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-17 13:46:23",
"type": "subscribed"
},
{
"author": "Verolop",
"created_at": "2023-08-17 13:46:23",
"type": "subscribed"
},
{
"author": "puerco",
"created_at": "2023-08-17 13:46:23",
"type": "subscribed"
},
{
"author": "cpanato",
"created_at": "2023-08-17 13:46:23",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 13:46:23",
"type": "review_requested"
},
{
"author": "cici37",
"created_at": "2023-08-17 13:46:23",
"type": "subscribed"
},
{
"author": "palnabarun",
"created_at": "2023-08-17 13:46:23",
"type": "subscribed"
},
{
"author": "xmudrii",
"created_at": "2023-08-17 13:46:23",
"type": "subscribed"
},
{
"author": "k8s-release-robot",
"created_at": "2023-08-17 13:46:23",
"type": "subscribed"
},
{
"author": "jeremyrickard",
"created_at": "2023-08-17 13:46:23",
"type": "subscribed"
}
] |
119,998 | Fix punctuation of error message : "cannot delete Pods declare no controller" | open | 2023-08-17 07:31:37 | 2023-08-19 06:19:21 | null | [] | [
"kind/bug",
"area/kubectl",
"size/XS",
"sig/cli",
"cncf-cla: yes",
"needs-ok-to-test",
"do-not-merge/release-note-label-needed",
"needs-priority",
"needs-triage"
] | itsajay1029 | [
{
"body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-17 07:31:39"
},
{
"body": "<a href=\"https://easycla.lfx.linuxfoundation.org/#/?version=2\"><img src=\"https://s3.amazonaws.com/cla-project-logo-prod/cla-signed.svg\" alt=\"CLA Signed\" align=\"left\" height=\"28\" width=\"328\" ></a><br/><br />The committers listed above are authorized under a signed CLA.<ul><li>:white_check_mark: login: itsajay1029 / name: Ajay Chowdhury (98af83286bdca70dd4fa59bcae510b27a5728de0)</li></ul>",
"created_at": "2023-08-17 07:31:42"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119998#\" title=\"Author self-approved\">itsajay1029</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [seans3](https://github.com/seans3) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"seans3\"]} -->",
"created_at": "2023-08-17 07:31:43"
},
{
"body": "Welcome @itsajay1029! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:",
"created_at": "2023-08-17 07:31:45"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-17 07:31:45"
},
{
"body": "Hi @itsajay1029. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-17 07:31:46"
},
{
"body": "@seans3 Please review the PR",
"created_at": "2023-08-19 06:19:21"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:31:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:31:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:31:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:31:43",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:31:43",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:31:43",
"type": "labeled"
},
{
"author": "itsajay1029",
"created_at": "2023-08-17 07:31:43",
"type": "mentioned"
},
{
"author": "itsajay1029",
"created_at": "2023-08-17 07:31:43",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:31:44",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:31:44",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:31:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:31:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:31:45",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:31:45",
"type": "labeled"
},
{
"author": "itsajay1029",
"created_at": "2023-08-17 07:31:45",
"type": "mentioned"
},
{
"author": "itsajay1029",
"created_at": "2023-08-17 07:31:45",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:31:46",
"type": "labeled"
},
{
"author": "itsajay1029",
"created_at": "2023-08-17 07:31:46",
"type": "mentioned"
},
{
"author": "itsajay1029",
"created_at": "2023-08-17 07:31:46",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:36:29",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:36:30",
"type": "labeled"
},
{
"author": "seans3",
"created_at": "2023-08-19 06:19:21",
"type": "mentioned"
},
{
"author": "seans3",
"created_at": "2023-08-19 06:19:21",
"type": "subscribed"
}
] |
119,997 | Automated cherry pick of #119860: update to golangci-lint v1.54.1 + go-ruleguard v0.4.0 | open | 2023-08-17 07:30:16 | 2023-08-18 14:19:12 | null | [
"liggitt"
] | [
"kind/cleanup",
"lgtm",
"size/L",
"release-note-none",
"approved",
"cncf-cla: yes",
"sig/testing",
"do-not-merge/cherry-pick-not-approved",
"needs-priority",
"needs-triage"
] | pohly | [
{
"body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-17 07:30:20"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-17 07:30:27"
},
{
"body": "/sig testing\r\n/kind cleanup\r\n/release-note-none",
"created_at": "2023-08-17 07:55:30"
},
{
"body": "/lgtm\r\n/approve\r\n/cc @kubernetes/release-managers ",
"created_at": "2023-08-18 14:19:04"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119997#issuecomment-1683990875\" title=\"Approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119997#\" title=\"Author self-approved\">pohly</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/hack/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-18 14:19:11"
},
{
"body": "LGTM label has been added. <details>Git tree hash: c7dfbe6733fbedf8795951210e3a7a88927d6369</details>",
"created_at": "2023-08-18 14:19:12"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:30:19",
"type": "milestoned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:30:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:30:20",
"type": "labeled"
},
{
"author": "pohly",
"created_at": "2023-08-17 07:30:20",
"type": "mentioned"
},
{
"author": "pohly",
"created_at": "2023-08-17 07:30:20",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:30:22",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:30:24",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:30:24",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:30:25",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:30:26",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:30:27",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:30:59",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:30:59",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:33",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:33",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:34",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:35",
"type": "unlabeled"
},
{
"author": "justaugustus",
"created_at": "2023-08-18 14:19:05",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-18 14:19:05",
"type": "subscribed"
},
{
"author": "Verolop",
"created_at": "2023-08-18 14:19:05",
"type": "subscribed"
},
{
"author": "puerco",
"created_at": "2023-08-18 14:19:05",
"type": "subscribed"
},
{
"author": "cpanato",
"created_at": "2023-08-18 14:19:05",
"type": "subscribed"
},
{
"author": "cici37",
"created_at": "2023-08-18 14:19:05",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 14:19:05",
"type": "review_requested"
},
{
"author": "palnabarun",
"created_at": "2023-08-18 14:19:05",
"type": "subscribed"
},
{
"author": "xmudrii",
"created_at": "2023-08-18 14:19:05",
"type": "subscribed"
},
{
"author": "k8s-release-robot",
"created_at": "2023-08-18 14:19:06",
"type": "subscribed"
},
{
"author": "jeremyrickard",
"created_at": "2023-08-18 14:19:06",
"type": "subscribed"
},
{
"author": "liggitt",
"created_at": "2023-08-18 14:19:09",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 14:19:10",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 14:19:12",
"type": "labeled"
}
] |
119,996 | Automated cherry pick of #119860: update to golangci-lint v1.54.1 + go-ruleguard v0.4.0 | open | 2023-08-17 07:03:21 | 2023-08-17 13:48:06 | null | [
"liggitt"
] | [
"kind/cleanup",
"lgtm",
"size/L",
"release-note-none",
"approved",
"cncf-cla: yes",
"sig/testing",
"do-not-merge/cherry-pick-not-approved",
"needs-priority",
"needs-triage"
] | pohly | [
{
"body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-17 07:03:23"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-17 07:03:29"
},
{
"body": "/sig testing\r\n/kind cleanup\r\n/release-note-none",
"created_at": "2023-08-17 07:55:24"
},
{
"body": "/lgtm\r\n/approve\r\n/cc @kubernetes/release-managers ",
"created_at": "2023-08-17 13:47:58"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119996#issuecomment-1682320401\" title=\"Approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119996#\" title=\"Author self-approved\">pohly</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/hack/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-17 13:48:05"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 322bfd0ce5e8f2c185f4461dc12ae152c4d7d198</details>",
"created_at": "2023-08-17 13:48:05"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:03:22",
"type": "milestoned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:03:22",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:03:23",
"type": "labeled"
},
{
"author": "pohly",
"created_at": "2023-08-17 07:03:23",
"type": "mentioned"
},
{
"author": "pohly",
"created_at": "2023-08-17 07:03:23",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:03:24",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:03:25",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:03:27",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:03:28",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:03:29",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:03:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:04:06",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:04:06",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:25",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:26",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:26",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:27",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:28",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:28",
"type": "unlabeled"
},
{
"author": "justaugustus",
"created_at": "2023-08-17 13:47:59",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-17 13:47:59",
"type": "subscribed"
},
{
"author": "Verolop",
"created_at": "2023-08-17 13:47:59",
"type": "subscribed"
},
{
"author": "puerco",
"created_at": "2023-08-17 13:47:59",
"type": "subscribed"
},
{
"author": "cpanato",
"created_at": "2023-08-17 13:47:59",
"type": "subscribed"
},
{
"author": "cici37",
"created_at": "2023-08-17 13:47:59",
"type": "subscribed"
},
{
"author": "palnabarun",
"created_at": "2023-08-17 13:47:59",
"type": "subscribed"
},
{
"author": "xmudrii",
"created_at": "2023-08-17 13:47:59",
"type": "subscribed"
},
{
"author": "k8s-release-robot",
"created_at": "2023-08-17 13:47:59",
"type": "subscribed"
},
{
"author": "jeremyrickard",
"created_at": "2023-08-17 13:47:59",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 13:48:00",
"type": "review_requested"
},
{
"author": "liggitt",
"created_at": "2023-08-17 13:48:03",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 13:48:04",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 13:48:06",
"type": "labeled"
}
] |
119,995 | Automated cherry pick of #119860: update to golangci-lint v1.54.1 + go-ruleguard v0.4.0 | open | 2023-08-17 06:55:05 | 2023-08-17 13:48:04 | null | [
"liggitt"
] | [
"kind/cleanup",
"lgtm",
"size/L",
"release-note-none",
"approved",
"cncf-cla: yes",
"sig/testing",
"do-not-merge/cherry-pick-not-approved",
"needs-priority",
"area/dependency",
"needs-triage"
] | pohly | [
{
"body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-17 06:55:08"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-17 06:55:15"
},
{
"body": "/sig testing\r\n/kind cleanup\r\n/release-note-none\r\n",
"created_at": "2023-08-17 07:55:09"
},
{
"body": "/lgtm\r\n/approve\r\n/cc @kubernetes/release-managers ",
"created_at": "2023-08-17 13:47:56"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119995#issuecomment-1682320336\" title=\"Approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119995#\" title=\"Author self-approved\">pohly</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.25/hack/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-17 13:48:02"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 017c48e55ec0821de25cc15997c590a06b3428b8</details>",
"created_at": "2023-08-17 13:48:04"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 06:55:07",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 06:55:08",
"type": "milestoned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 06:55:08",
"type": "labeled"
},
{
"author": "pohly",
"created_at": "2023-08-17 06:55:08",
"type": "mentioned"
},
{
"author": "pohly",
"created_at": "2023-08-17 06:55:08",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 06:55:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 06:55:10",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 06:55:13",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 06:55:13",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 06:55:14",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 06:55:15",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:00:22",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:00:22",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:00:22",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:00:22",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:11",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:11",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:11",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:12",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:13",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:55:14",
"type": "unlabeled"
},
{
"author": "justaugustus",
"created_at": "2023-08-17 13:47:57",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-17 13:47:57",
"type": "subscribed"
},
{
"author": "Verolop",
"created_at": "2023-08-17 13:47:57",
"type": "subscribed"
},
{
"author": "puerco",
"created_at": "2023-08-17 13:47:57",
"type": "subscribed"
},
{
"author": "cpanato",
"created_at": "2023-08-17 13:47:57",
"type": "subscribed"
},
{
"author": "cici37",
"created_at": "2023-08-17 13:47:57",
"type": "subscribed"
},
{
"author": "palnabarun",
"created_at": "2023-08-17 13:47:57",
"type": "subscribed"
},
{
"author": "xmudrii",
"created_at": "2023-08-17 13:47:57",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 13:47:57",
"type": "review_requested"
},
{
"author": "k8s-release-robot",
"created_at": "2023-08-17 13:47:57",
"type": "subscribed"
},
{
"author": "jeremyrickard",
"created_at": "2023-08-17 13:47:57",
"type": "subscribed"
},
{
"author": "liggitt",
"created_at": "2023-08-17 13:48:01",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 13:48:02",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 13:48:03",
"type": "labeled"
}
] |
119,994 | scheduler: remove deprecated v1beta3 KubeSchedulerConfiguration component config | closed | 2023-08-17 05:16:07 | 2023-08-24 22:31:23 | 2023-08-24 22:31:21 | [
"liggitt",
"kerthcet"
] | [
"area/test",
"kind/cleanup",
"sig/scheduling",
"lgtm",
"release-note",
"size/XXL",
"kind/api-change",
"approved",
"cncf-cla: yes",
"sig/testing",
"area/code-generation",
"needs-priority",
"api-review",
"needs-triage"
] | SataQiu | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-17 05:16:15"
},
{
"body": "/remove-sig api-machinery",
"created_at": "2023-08-17 16:36:09"
},
{
"body": "/cc @ahg-g @sanposhiho @kerthcet ",
"created_at": "2023-08-20 12:39:29"
},
{
"body": "LGTM label has been added. <details>Git tree hash: d4357e700e1fb02816406527cfc1d9cbde408b2d</details>",
"created_at": "2023-08-23 10:19:47"
},
{
"body": ":partying_face: \r\n/hold cancel\r\n/approve",
"created_at": "2023-08-23 15:18:38"
},
{
"body": "/label api-review",
"created_at": "2023-08-23 15:18:53"
},
{
"body": "/assign @liggitt\r\nfor api approve",
"created_at": "2023-08-24 09:12:04"
},
{
"body": "/approve",
"created_at": "2023-08-24 21:24:52"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119994#issuecomment-1690156278\" title=\"Approved\">alculquicondor</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119994#issuecomment-1692431168\" title=\"Approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119994#\" title=\"Author self-approved\">SataQiu</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/api/OWNERS)~~ [liggitt]\n- ~~[cmd/kube-scheduler/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kube-scheduler/OWNERS)~~ [alculquicondor,liggitt]\n- ~~[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/hack/OWNERS)~~ [SataQiu,liggitt]\n- ~~[pkg/generated/openapi/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/generated/openapi/OWNERS)~~ [liggitt]\n- ~~[pkg/scheduler/apis/config/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/apis/config/OWNERS)~~ [alculquicondor,liggitt]\n- ~~[staging/src/k8s.io/kube-scheduler/config/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kube-scheduler/config/OWNERS)~~ [liggitt]\n- ~~[test/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/OWNERS)~~ [SataQiu,liggitt]\n- ~~[vendor/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/vendor/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-24 21:25:19"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 05:16:08",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 05:16:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 05:16:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 05:16:11",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 05:16:13",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 05:16:14",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 05:16:15",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 05:16:44",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 05:16:44",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 05:16:57",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 05:16:58",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 05:16:59",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 05:17:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 05:17:01",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 05:17:01",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 05:17:02",
"type": "unlabeled"
},
{
"author": "SataQiu",
"created_at": "2023-08-17 05:27:56",
"type": "head_ref_force_pushed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:36:11",
"type": "unlabeled"
},
{
"author": "kerthcet",
"created_at": "2023-08-20 12:39:30",
"type": "mentioned"
},
{
"author": "kerthcet",
"created_at": "2023-08-20 12:39:30",
"type": "subscribed"
},
{
"author": "ahg-g",
"created_at": "2023-08-20 12:39:30",
"type": "mentioned"
},
{
"author": "ahg-g",
"created_at": "2023-08-20 12:39:30",
"type": "subscribed"
},
{
"author": "sanposhiho",
"created_at": "2023-08-20 12:39:30",
"type": "mentioned"
},
{
"author": "sanposhiho",
"created_at": "2023-08-20 12:39:30",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-20 12:39:30",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-20 12:39:31",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-20 12:39:31",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-23 10:19:41",
"type": "labeled"
},
{
"author": "kerthcet",
"created_at": "2023-08-23 10:19:44",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-23 10:19:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-23 15:19:14",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-23 15:19:30",
"type": "labeled"
},
{
"author": "liggitt",
"created_at": "2023-08-24 09:12:05",
"type": "mentioned"
},
{
"author": "liggitt",
"created_at": "2023-08-24 09:12:05",
"type": "subscribed"
},
{
"author": "liggitt",
"created_at": "2023-08-24 09:12:06",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 21:25:20",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 22:31:20",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 22:31:21",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 22:31:21",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 22:31:23",
"type": "milestoned"
}
] |
119,993 | Fix TestApplyToFallback variable reference error | open | 2023-08-17 04:40:07 | 2023-08-17 16:36:59 | null | [
"deads2k"
] | [
"kind/cleanup",
"area/apiserver",
"sig/api-machinery",
"size/XS",
"release-note-none",
"cncf-cla: yes",
"needs-priority",
"triage/accepted"
] | chymy | [
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119993#\" title=\"Author self-approved\">chymy</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [enj](https://github.com/enj) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/apiserver/pkg/server/options/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/server/options/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"enj\"]} -->",
"created_at": "2023-08-17 04:41:00"
},
{
"body": "/assign @deads2k\r\n/triage accepted \r\n",
"created_at": "2023-08-17 16:36:55"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 04:40:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 04:40:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 04:40:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 04:40:11",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 04:40:14",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 04:40:14",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 04:40:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 04:40:37",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 04:40:38",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 04:40:39",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 04:40:48",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 04:40:49",
"type": "review_requested"
},
{
"author": "deads2k",
"created_at": "2023-08-17 16:36:55",
"type": "mentioned"
},
{
"author": "deads2k",
"created_at": "2023-08-17 16:36:55",
"type": "subscribed"
},
{
"author": "deads2k",
"created_at": "2023-08-17 16:36:56",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:36:57",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:36:58",
"type": "unlabeled"
}
] |
119,992 | kubectl exec will wait for a command's background job to finish - when exec to pod on containerd | open | 2023-08-17 04:26:21 | 2023-08-23 17:53:43 | null | [] | [
"kind/bug",
"sig/node",
"sig/cli",
"needs-triage"
] | luong-komorebi | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-17 04:26:30"
},
{
"body": "/sig cli node\r\nfor triage",
"created_at": "2023-08-17 12:04:09"
},
{
"body": "Also happened when upgrade from eks version 1.21 to 1.25 - on the eks with dockerd runtime this is not the default behaviour. It only happens when running kubectl exec on a pod that is run on containerd runtime.",
"created_at": "2023-08-22 09:11:26"
},
{
"body": "Waiting for SIG CLI to give an opinion on this.",
"created_at": "2023-08-23 17:53:43"
}
] | [
{
"author": "luong-komorebi",
"created_at": "2023-08-17 04:26:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 04:26:28",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 04:26:29",
"type": "labeled"
},
{
"author": "luong-komorebi",
"created_at": "2023-08-17 04:28:18",
"type": "renamed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 12:04:10",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 12:04:11",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 12:04:12",
"type": "unlabeled"
}
] |
119,991 | HPA: Calculate sidecar container resource in pod autoscaler | open | 2023-08-17 03:19:43 | 2023-08-17 04:29:09 | null | [
"qingwave"
] | [
"priority/important-soon",
"sig/autoscaling",
"kind/feature",
"triage/accepted"
] | qingwave | [
{
"body": "/assign\r\n/sig autoscaling",
"created_at": "2023-08-17 03:20:49"
},
{
"body": "/triage accepted\r\n/priority important-soon",
"created_at": "2023-08-17 04:29:05"
}
] | [
{
"author": "qingwave",
"created_at": "2023-08-17 03:19:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 03:19:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 03:19:53",
"type": "labeled"
},
{
"author": "qingwave",
"created_at": "2023-08-17 03:20:51",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 03:20:52",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 03:20:53",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 04:29:07",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 04:29:08",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 04:29:08",
"type": "unlabeled"
}
] |
119,990 | Service- TopologyAwareHintsDisabled | closed | 2023-08-17 02:07:20 | 2023-08-24 01:26:42 | 2023-08-24 01:26:42 | [
"robscott"
] | [
"kind/bug",
"sig/network",
"needs-triage"
] | wt-1611 | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-17 02:07:30"
},
{
"body": "/sig network",
"created_at": "2023-08-17 12:03:41"
},
{
"body": "/assign",
"created_at": "2023-08-17 16:11:59"
},
{
"body": "Hi @wt-1611\r\n\r\nI’m not a maintainer, but there are a few things that I’ve noticed that might be helpful to you. \r\n\r\nFirst, from the error message on your `svc` object: `Insufficient Node information: allocatable CPU or zone not specified on one or more nodes` - nodes not reporting allocatable CPU can be what's causing this error. Allocatable CPU is used by EndpointSlice to calculate balanced allocations:\r\n\r\n```\r\nThe controller allocates a proportional amount of endpoints to each zone. This proportion is based on the allocatable CPU cores for nodes running in that zone\r\n```\r\n\r\nBut I think the bigger problem in your case is that all of your worker nodes are in one zone: `topology.kubernetes.io/zone=b` which makes this feature not relevant for your cluster - all the traffic will have to go to this zone B. Note, that control plane nodes are not taken into account according to the documentation: \r\n\r\n```\r\nThe EndpointSlice controller ignores nodes with the node-role.kubernetes.io/control-plane or node-role.kubernetes.io/master label set. This could be problematic if workloads are also running on those nodes.\r\n```\r\n\r\nhttps://kubernetes.io/docs/concepts/services-networking/topology-aware-routing/\r\n\r\nHope that helps",
"created_at": "2023-08-21 01:08:44"
},
{
"body": "> Hi @wt-1611\r\n> \r\n> I’m not a maintainer, but there are a few things that I’ve noticed that might be helpful to you.\r\n> \r\n> First, from the error message on your `svc` object: `Insufficient Node information: allocatable CPU or zone not specified on one or more nodes` - nodes not reporting allocatable CPU can be what's causing this error. Allocatable CPU is used by EndpointSlice to calculate balanced allocations:\r\n> \r\n> ```\r\n> The controller allocates a proportional amount of endpoints to each zone. This proportion is based on the allocatable CPU cores for nodes running in that zone\r\n> ```\r\n> \r\n> But I think the bigger problem in your case is that all of your worker nodes are in one zone: `topology.kubernetes.io/zone=b` which makes this feature not relevant for your cluster - all the traffic will have to go to this zone B. Note, that control plane nodes are not taken into account according to the documentation:\r\n> \r\n> ```\r\n> The EndpointSlice controller ignores nodes with the node-role.kubernetes.io/control-plane or node-role.kubernetes.io/master label set. This could be problematic if workloads are also running on those nodes.\r\n> ```\r\n> \r\n> https://kubernetes.io/docs/concepts/services-networking/topology-aware-routing/\r\n> \r\n> Hope that helps\r\n\r\nThis may be one of the reasons, for which I re-created a small cluster of three nodes, with only one master:\r\n\r\n```bash\r\n $ kubectl get nodes --show-labels\r\n\r\nNAME STATUS ROLES AGE VERSION LABELS\r\nnode1 Ready control-plane 28m v1.26.7 beta.kubernetes.io/arch=amd64,beta.kubernetes.io/os=linux,kubernetes.io/arch=amd64,kubernetes.io/hostname=node1,kubernetes.io/os=linux,node-role.kubernetes.io/control-plane=,node.kubernetes.io/exclude-from-external-load-balancers=,topology.kubernetes.io/zone=a\r\nnode2 Ready <none> 27m v1.26.7 beta.kubernetes.io/arch=amd64,beta.kubernetes.io/os=linux,kubernetes.io/arch=amd64,kubernetes.io/hostname=node2,kubernetes.io/os=linux,topology.kubernetes.io/zone=a\r\nnode3 Ready <none> 27m v1.26.7 beta.kubernetes.io/arch=amd64,beta.kubernetes.io/os=linux,kubernetes.io/arch=amd64,kubernetes.io/hostname=node3,kubernetes.io/os=linux,topology.kubernetes.io/zone=b\r\n\r\n` ` `\r\n\r\nBut it's the same warning:\r\n\r\n```bash\r\n\r\nWarning TopologyAwareHintsDisabled 7m18s (x7 over 7m57s) endpoint-slice-controller Insufficient Node information: allocatable CPU or zone not specified on one or more nodes, addressType: IPv4\r\n\r\n\r\n\r\n` ` `",
"created_at": "2023-08-21 02:59:02"
},
{
"body": "@olga-mir comments are spot on, good analysis by the way\r\n\r\n@wt-1611 can you please paste the Service and EndpointSlices generated, to see how many pods are running in each node?\r\nAre both nodes the same (in terms of resources)",
"created_at": "2023-08-21 12:59:46"
},
{
"body": "> @olga-mir comments are spot on, good analysis by the way\r\n> \r\n> @wt-1611 can you please paste the Service and EndpointSlices generated, to see how many pods are running in each node? Are both nodes the same (in terms of resources)\r\n\r\nMy cluster is now up to six nodes\r\n```bash\r\nNAME STATUS ROLES AGE VERSION LABELS\r\nnode1 Ready control-plane 46h v1.26.7 beta.kubernetes.io/arch=amd64,beta.kubernetes.io/os=linux,kubernetes.io/arch=amd64,kubernetes.io/hostname=node1,kubernetes.io/os=linux,node-role.kubernetes.io/control-plane=,node.kubernetes.io/exclude-from-external-load-balancers=,topology.kubernetes.io/zone=a\r\nnode2 Ready <none> 46h v1.26.7 beta.kubernetes.io/arch=amd64,beta.kubernetes.io/os=linux,kubernetes.io/arch=amd64,kubernetes.io/hostname=node2,kubernetes.io/os=linux,topology.kubernetes.io/zone=a\r\nnode5 Ready <none> 42h v1.26.7 beta.kubernetes.io/arch=amd64,beta.kubernetes.io/os=linux,kubernetes.io/arch=amd64,kubernetes.io/hostname=node5,kubernetes.io/os=linux,topology.kubernetes.io/zone=a\r\nnode6 Ready <none> 42h v1.26.7 beta.kubernetes.io/arch=amd64,beta.kubernetes.io/os=linux,kubernetes.io/arch=amd64,kubernetes.io/hostname=node6,kubernetes.io/os=linux,topology.kubernetes.io/zone=b\r\nnode7 Ready <none> 42h v1.26.7 beta.kubernetes.io/arch=amd64,beta.kubernetes.io/os=linux,kubernetes.io/arch=amd64,kubernetes.io/hostname=node7,kubernetes.io/os=linux,topology.kubernetes.io/zone=b\r\nnode8 Ready <none> 42h v1.26.7 beta.kubernetes.io/arch=amd64,beta.kubernetes.io/os=linux,kubernetes.io/arch=amd64,kubernetes.io/hostname=node8,kubernetes.io/os=linux,topology.kubernetes.io/zone=b\r\n```\r\nThis is the generated service and endpointslice\r\n```bash\r\n$ kubectl describe endpointslice topic-service-dbtr2\r\nName: topic-service-dbtr2\r\nNamespace: default\r\nLabels: endpointslice.kubernetes.io/managed-by=endpointslice-controller.k8s.io\r\n kubernetes.io/service-name=topic-service\r\nAnnotations: endpoints.kubernetes.io/last-change-trigger-time: 2023-08-23T01:14:41Z\r\nAddressType: IPv4\r\nPorts:\r\n Name Port Protocol\r\n ---- ---- --------\r\n <unset> 80 TCP\r\nEndpoints:\r\n - Addresses: 10.244.104.10\r\n Conditions:\r\n Ready: true\r\n Hostname: <unset>\r\n TargetRef: Pod/topic-pod-7679d666f7-g65h4\r\n NodeName: node2\r\n Zone: a\r\n - Addresses: 10.244.199.202\r\n Conditions:\r\n Ready: true\r\n Hostname: <unset>\r\n TargetRef: Pod/topic-pod-7679d666f7-q4p9f\r\n NodeName: node7\r\n Zone: b\r\n - Addresses: 10.244.139.11\r\n Conditions:\r\n Ready: true\r\n Hostname: <unset>\r\n TargetRef: Pod/topic-pod-7679d666f7-n9jbt\r\n NodeName: node6\r\n Zone: b\r\n - Addresses: 10.244.225.76\r\n Conditions:\r\n Ready: true\r\n Hostname: <unset>\r\n TargetRef: Pod/topic-pod-7679d666f7-dt7kw\r\n NodeName: node8\r\n Zone: b\r\n - Addresses: 10.244.33.141\r\n Conditions:\r\n Ready: true\r\n Hostname: <unset>\r\n TargetRef: Pod/topic-pod-7679d666f7-pqd82\r\n NodeName: node5\r\n Zone: a\r\n - Addresses: 10.244.104.11\r\n Conditions:\r\n Ready: true\r\n Hostname: <unset>\r\n TargetRef: Pod/topic-pod-7679d666f7-rbb4s\r\n NodeName: node2\r\n Zone: a\r\nEvents: <none>\r\n\r\n$ kubectl describe svc topic-service\r\nName: topic-service\r\nNamespace: default\r\nLabels: <none>\r\nAnnotations: service.kubernetes.io/topology-aware-hints: auto\r\nSelector: mytopic=topic-pod\r\nType: NodePort\r\nIP Family Policy: SingleStack\r\nIP Families: IPv4\r\nIP: 10.96.244.251\r\nIPs: 10.96.244.251\r\nPort: <unset> 10000/TCP\r\nTargetPort: 80/TCP\r\nNodePort: <unset> 30000/TCP\r\nEndpoints: 10.244.104.10:80,10.244.104.11:80,10.244.139.11:80 + 3 more...\r\nSession Affinity: None\r\nExternal Traffic Policy: Cluster\r\nEvents:\r\n Type Reason Age From Message\r\n ---- ------ ---- ---- -------\r\n Warning TopologyAwareHintsDisabled 7m33s (x16 over 7m41s) endpoint-slice-controller Insufficient Node information: allocatable CPU or zone not specified on one or more nodes, addressType: IPv4\r\n```\r\nThis is my node resource information\r\n```bash\r\n$ kubectl describe nodes | egrep -i -A9 'hostname:|Allocated resources:'\r\n Hostname: node1\r\nCapacity:\r\n cpu: 2\r\n ephemeral-storage: 104290556Ki\r\n hugepages-1Gi: 0\r\n hugepages-2Mi: 0\r\n memory: 4046872Ki\r\n pods: 110\r\nAllocatable:\r\n cpu: 2\r\n--\r\nAllocated resources:\r\n (Total limits may be over 100 percent, i.e., overcommitted.)\r\n Resource Requests Limits\r\n -------- -------- ------\r\n cpu 1 (50%) 0 (0%)\r\n memory 170Mi (4%) 170Mi (4%)\r\n ephemeral-storage 0 (0%) 0 (0%)\r\n hugepages-1Gi 0 (0%) 0 (0%)\r\n hugepages-2Mi 0 (0%) 0 (0%)\r\nEvents: <none>\r\n--\r\n Hostname: node2\r\nCapacity:\r\n cpu: 1\r\n ephemeral-storage: 104290556Ki\r\n hugepages-1Gi: 0\r\n hugepages-2Mi: 0\r\n memory: 4047004Ki\r\n pods: 110\r\nAllocatable:\r\n cpu: 1\r\n--\r\nAllocated resources:\r\n (Total limits may be over 100 percent, i.e., overcommitted.)\r\n Resource Requests Limits\r\n -------- -------- ------\r\n cpu 350m (35%) 0 (0%)\r\n memory 70Mi (1%) 170Mi (4%)\r\n ephemeral-storage 0 (0%) 0 (0%)\r\n hugepages-1Gi 0 (0%) 0 (0%)\r\n hugepages-2Mi 0 (0%) 0 (0%)\r\nEvents: <none>\r\n--\r\n Hostname: node5\r\nCapacity:\r\n cpu: 1\r\n ephemeral-storage: 104290556Ki\r\n hugepages-1Gi: 0\r\n hugepages-2Mi: 0\r\n memory: 4047004Ki\r\n pods: 110\r\nAllocatable:\r\n cpu: 1\r\n--\r\nAllocated resources:\r\n (Total limits may be over 100 percent, i.e., overcommitted.)\r\n Resource Requests Limits\r\n -------- -------- ------\r\n cpu 350m (35%) 0 (0%)\r\n memory 100Mi (2%) 0 (0%)\r\n ephemeral-storage 0 (0%) 0 (0%)\r\n hugepages-1Gi 0 (0%) 0 (0%)\r\n hugepages-2Mi 0 (0%) 0 (0%)\r\nEvents: <none>\r\n--\r\n Hostname: node6\r\nCapacity:\r\n cpu: 1\r\n ephemeral-storage: 104290556Ki\r\n hugepages-1Gi: 0\r\n hugepages-2Mi: 0\r\n memory: 4047004Ki\r\n pods: 110\r\nAllocatable:\r\n cpu: 1\r\n--\r\nAllocated resources:\r\n (Total limits may be over 100 percent, i.e., overcommitted.)\r\n Resource Requests Limits\r\n -------- -------- ------\r\n cpu 350m (35%) 0 (0%)\r\n memory 100Mi (2%) 0 (0%)\r\n ephemeral-storage 0 (0%) 0 (0%)\r\n hugepages-1Gi 0 (0%) 0 (0%)\r\n hugepages-2Mi 0 (0%) 0 (0%)\r\nEvents: <none>\r\n--\r\n Hostname: node7\r\nCapacity:\r\n cpu: 1\r\n ephemeral-storage: 104290556Ki\r\n hugepages-1Gi: 0\r\n hugepages-2Mi: 0\r\n memory: 4047004Ki\r\n pods: 110\r\nAllocatable:\r\n cpu: 1\r\n--\r\nAllocated resources:\r\n (Total limits may be over 100 percent, i.e., overcommitted.)\r\n Resource Requests Limits\r\n -------- -------- ------\r\n cpu 350m (35%) 0 (0%)\r\n memory 100Mi (2%) 0 (0%)\r\n ephemeral-storage 0 (0%) 0 (0%)\r\n hugepages-1Gi 0 (0%) 0 (0%)\r\n hugepages-2Mi 0 (0%) 0 (0%)\r\nEvents: <none>\r\n--\r\n Hostname: node8\r\nCapacity:\r\n cpu: 1\r\n ephemeral-storage: 104290556Ki\r\n hugepages-1Gi: 0\r\n hugepages-2Mi: 0\r\n memory: 4047004Ki\r\n pods: 110\r\nAllocatable:\r\n cpu: 1\r\n--\r\nAllocated resources:\r\n (Total limits may be over 100 percent, i.e., overcommitted.)\r\n Resource Requests Limits\r\n -------- -------- ------\r\n cpu 250m (25%) 0 (0%)\r\n memory 0 (0%) 0 (0%)\r\n ephemeral-storage 0 (0%) 0 (0%)\r\n hugepages-1Gi 0 (0%) 0 (0%)\r\n hugepages-2Mi 0 (0%) 0 (0%)\r\nEvents: <none>\r\n\r\n```\r\nI don't understand. What's the problem",
"created_at": "2023-08-23 01:39:06"
},
{
"body": "I increased the cpu on each node to 2 and booted successfully...\r\n\r\nDoes this allocatable cpu mean a cpu that is not being used at all?",
"created_at": "2023-08-23 02:07:01"
}
] | [
{
"author": "wt-1611",
"created_at": "2023-08-17 02:07:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 02:07:28",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 02:07:29",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 12:03:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 12:03:44",
"type": "unlabeled"
},
{
"author": "robscott",
"created_at": "2023-08-17 16:12:01",
"type": "assigned"
},
{
"author": "wt-1611",
"created_at": "2023-08-21 01:08:44",
"type": "mentioned"
},
{
"author": "wt-1611",
"created_at": "2023-08-21 01:08:45",
"type": "subscribed"
},
{
"author": "wt-1611",
"created_at": "2023-08-21 02:59:02",
"type": "mentioned"
},
{
"author": "wt-1611",
"created_at": "2023-08-21 02:59:02",
"type": "subscribed"
},
{
"author": "olga-mir",
"created_at": "2023-08-21 12:59:47",
"type": "mentioned"
},
{
"author": "olga-mir",
"created_at": "2023-08-21 12:59:47",
"type": "subscribed"
},
{
"author": "wt-1611",
"created_at": "2023-08-21 12:59:47",
"type": "mentioned"
},
{
"author": "wt-1611",
"created_at": "2023-08-21 12:59:47",
"type": "subscribed"
},
{
"author": "olga-mir",
"created_at": "2023-08-23 01:39:06",
"type": "mentioned"
},
{
"author": "olga-mir",
"created_at": "2023-08-23 01:39:06",
"type": "subscribed"
},
{
"author": "wt-1611",
"created_at": "2023-08-23 01:39:07",
"type": "mentioned"
},
{
"author": "wt-1611",
"created_at": "2023-08-23 01:39:07",
"type": "subscribed"
},
{
"author": "wt-1611",
"created_at": "2023-08-23 03:05:43",
"type": "closed"
},
{
"author": "wt-1611",
"created_at": "2023-08-23 03:08:52",
"type": "reopened"
},
{
"author": "wt-1611",
"created_at": "2023-08-24 01:26:42",
"type": "closed"
}
] |
119,989 | [e2e_auth] stop using deprecated framework.ExpectNotEqual | open | 2023-08-17 01:30:03 | 2023-08-22 07:14:55 | null | [
"carlory"
] | [
"area/test",
"kind/cleanup",
"lgtm",
"size/XS",
"release-note-none",
"sig/auth",
"cncf-cla: yes",
"sig/testing",
"ok-to-test",
"needs-priority",
"needs-triage"
] | bzsuni | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-17 01:30:11"
},
{
"body": "Hi @bzsuni. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-17 01:30:11"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119989#\" title=\"Author self-approved\">bzsuni</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [smarterclayton](https://github.com/smarterclayton) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[test/e2e/auth/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/auth/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"smarterclayton\"]} -->",
"created_at": "2023-08-17 01:30:34"
},
{
"body": "/release-label-none",
"created_at": "2023-08-22 02:07:10"
},
{
"body": "/ok-to-test\r\n/lgtm",
"created_at": "2023-08-22 02:08:25"
},
{
"body": "LGTM label has been added. <details>Git tree hash: e47ef3a8047301a70c1c560e516c5ea3123f0f5e</details>",
"created_at": "2023-08-22 02:08:33"
},
{
"body": "/release-note-none",
"created_at": "2023-08-22 02:09:05"
},
{
"body": "/test pull-kubernetes-integration",
"created_at": "2023-08-22 06:17:51"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:30:05",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:30:05",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:30:06",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:30:07",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:30:10",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:30:10",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:30:11",
"type": "labeled"
},
{
"author": "bzsuni",
"created_at": "2023-08-17 01:30:12",
"type": "mentioned"
},
{
"author": "bzsuni",
"created_at": "2023-08-17 01:30:12",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:30:12",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:30:34",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:30:34",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:30:34",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:30:35",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:30:36",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:30:37",
"type": "unlabeled"
},
{
"author": "bzsuni",
"created_at": "2023-08-22 01:54:15",
"type": "head_ref_force_pushed"
},
{
"author": "bzsuni",
"created_at": "2023-08-22 01:55:01",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 02:08:27",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 02:08:27",
"type": "unlabeled"
},
{
"author": "carlory",
"created_at": "2023-08-22 02:08:31",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 02:08:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 02:09:06",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 02:09:07",
"type": "unlabeled"
},
{
"author": "bzsuni",
"created_at": "2023-08-22 03:07:58",
"type": "mentioned"
},
{
"author": "bzsuni",
"created_at": "2023-08-22 03:07:59",
"type": "subscribed"
}
] |
119,988 | [e2e_app] stop using deprecated framework.ExpectNotEqual | open | 2023-08-17 01:24:25 | 2023-08-22 06:43:08 | null | [] | [
"area/test",
"kind/cleanup",
"size/M",
"release-note-none",
"sig/apps",
"cncf-cla: yes",
"sig/testing",
"ok-to-test",
"needs-priority",
"needs-triage"
] | bzsuni | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-17 01:24:34"
},
{
"body": "Hi @bzsuni. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-17 01:24:34"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119988#\" title=\"Author self-approved\">bzsuni</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [janetkuo](https://github.com/janetkuo) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[test/e2e/apps/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/apps/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"janetkuo\"]} -->",
"created_at": "2023-08-17 01:28:05"
},
{
"body": "/release-note-none\r\n/ok-to-test",
"created_at": "2023-08-22 02:18:29"
},
{
"body": "/test pull-kubernetes-node-e2e-containerd",
"created_at": "2023-08-22 06:17:14"
},
{
"body": "@bzsuni: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-node-e2e-containerd | 93832de6246cb9f13da9a91eb41d894a6faaadcf | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119988/pull-kubernetes-node-e2e-containerd/1693869928098041856/) | true | `/test pull-kubernetes-node-e2e-containerd`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119988). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Abzsuni). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"created_at": "2023-08-22 06:43:07"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:24:27",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:24:27",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:24:28",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:24:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:24:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:24:33",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:24:34",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:24:34",
"type": "labeled"
},
{
"author": "bzsuni",
"created_at": "2023-08-17 01:24:35",
"type": "mentioned"
},
{
"author": "bzsuni",
"created_at": "2023-08-17 01:24:35",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:28:05",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:28:05",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:28:05",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:28:06",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:28:06",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 01:28:07",
"type": "unlabeled"
},
{
"author": "bzsuni",
"created_at": "2023-08-22 02:09:00",
"type": "head_ref_force_pushed"
},
{
"author": "bzsuni",
"created_at": "2023-08-22 02:12:30",
"type": "head_ref_force_pushed"
},
{
"author": "bzsuni",
"created_at": "2023-08-22 02:12:56",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 02:18:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 02:18:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 02:18:31",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 02:18:31",
"type": "unlabeled"
},
{
"author": "bzsuni",
"created_at": "2023-08-22 03:13:01",
"type": "head_ref_force_pushed"
},
{
"author": "bzsuni",
"created_at": "2023-08-22 03:13:02",
"type": "review_requested"
},
{
"author": "bzsuni",
"created_at": "2023-08-22 03:38:58",
"type": "mentioned"
},
{
"author": "bzsuni",
"created_at": "2023-08-22 03:38:58",
"type": "subscribed"
},
{
"author": "bzsuni",
"created_at": "2023-08-22 06:43:08",
"type": "mentioned"
},
{
"author": "bzsuni",
"created_at": "2023-08-22 06:43:08",
"type": "subscribed"
}
] |
119,987 | sched framework: expose NodeInfo in all functions of PluginsRunner interface | open | 2023-08-17 00:11:15 | 2023-08-24 06:33:04 | null | [
"wackxu"
] | [
"sig/scheduling",
"sig/autoscaling",
"kind/feature",
"triage/accepted"
] | Huang-Wei | [
{
"body": "/sig scheduling",
"created_at": "2023-08-17 00:11:42"
},
{
"body": "/triage accepted",
"created_at": "2023-08-17 00:11:52"
},
{
"body": "I want to help fix this.\r\n/assign",
"created_at": "2023-08-17 01:06:02"
},
{
"body": "A reminder is pkg/scheduler/framework/autoscaler_contract, which we should involve cluster-autoscaler folks for interface changes that may impact their workflow. For this flow, it doesn't seem to be breaking as it involves PreFilter/Filter only.\r\n\r\nBut still @kubernetes/sig-autoscaling-misc ",
"created_at": "2023-08-17 20:50:54"
},
{
"body": "/assign",
"created_at": "2023-08-18 03:01:30"
},
{
"body": "> /assign\r\n\r\n@lowang-bh I'm already working on this problem，You can take a look at other issues to reduce unnecessary duplication of work",
"created_at": "2023-08-18 03:13:18"
},
{
"body": "@lowang-bh please note that @wackxu already self-assigned this. Could you negociate with @wackxu ?",
"created_at": "2023-08-18 15:50:17"
},
{
"body": "/unassign",
"created_at": "2023-08-19 00:36:42"
},
{
"body": "@Huang-Wei I have some questions about this.\r\n\r\n```\r\n// PluginsRunner abstracts operations to run some plugins.\r\n// This is used by preemption PostFilter plugins when evaluating the feasibility of\r\n// scheduling the pod on nodes when certain running pods get evicted.\r\ntype PluginsRunner interface {\r\n\t// RunPreScorePlugins runs the set of configured PreScore plugins. If any\r\n\t// of these plugins returns any status other than \"Success\", the given pod is rejected.\r\n\tRunPreScorePlugins(context.Context, *CycleState, *v1.Pod, []*v1.Node) *Status\r\n\t// RunScorePlugins runs the set of configured scoring plugins.\r\n\t// It returns a list that stores scores from each plugin and total score for each Node.\r\n\t// It also returns *Status, which is set to non-success if any of the plugins returns\r\n\t// a non-success status.\r\n\tRunScorePlugins(context.Context, *CycleState, *v1.Pod, []*v1.Node) ([]NodePluginScores, *Status)\r\n\t// RunFilterPlugins runs the set of configured Filter plugins for pod on\r\n\t// the given node. Note that for the node being evaluated, the passed nodeInfo\r\n\t// reference could be different from the one in NodeInfoSnapshot map (e.g., pods\r\n\t// considered to be running on the node could be different). For example, during\r\n\t// preemption, we may pass a copy of the original nodeInfo object that has some pods\r\n\t// removed from it to evaluate the possibility of preempting them to\r\n\t// schedule the target pod.\r\n\tRunFilterPlugins(context.Context, *CycleState, *v1.Pod, *NodeInfo) *Status\r\n\t// RunPreFilterExtensionAddPod calls the AddPod interface for the set of configured\r\n\t// PreFilter plugins. It returns directly if any of the plugins return any\r\n\t// status other than Success.\r\n\tRunPreFilterExtensionAddPod(ctx context.Context, state *CycleState, podToSchedule *v1.Pod, podInfoToAdd *PodInfo, nodeInfo *NodeInfo) *Status\r\n\t// RunPreFilterExtensionRemovePod calls the RemovePod interface for the set of configured\r\n\t// PreFilter plugins. It returns directly if any of the plugins return any\r\n\t// status other than Success.\r\n\tRunPreFilterExtensionRemovePod(ctx context.Context, state *CycleState, podToSchedule *v1.Pod, podInfoToRemove *PodInfo, nodeInfo *NodeInfo) *Status\r\n}\r\n```\r\nAccording to PluginsRunner comments and my understanding，It is usually called by in-tree or out-of-tree plugins to implement some functionalities, such as preemption or customer-defined functions. \r\n\r\nThe specific usage process is usually that users develop their own custom `PreScorePlugin` and `ScorePlugin`, and then call `RunPreScorePlugins` and `RunScorePlugins` . \r\n\r\n```\r\n// PreScorePlugin is an interface for \"PreScore\" plugin. PreScore is an\r\n// informational extension point. Plugins will be called with a list of nodes\r\n// that passed the filtering phase. A plugin may use this data to update internal\r\n// state or to generate logs/metrics.\r\ntype PreScorePlugin interface {\r\n\tPlugin\r\n\t// PreScore is called by the scheduling framework after a list of nodes\r\n\t// passed the filtering phase. All prescore plugins must return success or\r\n\t// the pod will be rejected\r\n\t// When it returns Skip status, other fields in status are just ignored,\r\n\t// and coupled Score plugin will be skipped in this scheduling cycle.\r\n\tPreScore(ctx context.Context, state *CycleState, pod *v1.Pod, nodes []*v1.Node) *Status\r\n}\r\n\r\n// ScorePlugin is an interface that must be implemented by \"Score\" plugins to rank\r\n// nodes that passed the filtering phase.\r\ntype ScorePlugin interface {\r\n\tPlugin\r\n\t// Score is called on each filtered node. It must return success and an integer\r\n\t// indicating the rank of the node. All scoring plugins must return success or\r\n\t// the pod will be rejected.\r\n\tScore(ctx context.Context, state *CycleState, p *v1.Pod, nodeName string) (int64, *Status)\r\n\r\n\t// ScoreExtensions returns a ScoreExtensions interface if it implements one, or nil if does not.\r\n\tScoreExtensions() ScoreExtensions\r\n}\r\n```\r\n\r\nSo If we update `RunPreScorePlugins` and `RunScorePlugins` to exposes NodeInfo, We should also update the plugin interface definition, such as `PreScorePlugin` . \r\n\r\nAnother question is that in the plugin implementation, we can get nodeInfo through `handle.SnapshotSharedLister().NodeInfos()`, So I'm thinking whether update `RunPreScorePlugins` and `RunScorePlugins` is necessary\r\n\r\n\r\n\r\n\r\n\r\n",
"created_at": "2023-08-23 08:21:20"
},
{
"body": "> So If we update RunPreScorePlugins and RunScorePlugins to exposes NodeInfo, We should also update the plugin interface definition, such as PreScorePlugin\r\n\r\nYes, please update those interfaces' signature.\r\n\r\n> So I'm thinking whether update RunPreScorePlugins and RunScorePlugins is necessary\r\n\r\nPlease change them to accept NodeInfo as well.\r\n",
"created_at": "2023-08-23 17:17:58"
},
{
"body": "cc @kubernetes/sig-scheduling-misc for awareness.",
"created_at": "2023-08-23 17:18:11"
},
{
"body": "I don't have any concerns.\r\n\r\nFYI @x13n for the upcoming interface changes.",
"created_at": "2023-08-23 17:25:52"
},
{
"body": "Also sounds good to me. \r\n\r\nFor discussion: another concern(out of the scope of this issue) about the `PluginsRunner`, since most of the plugins don't care about the `PluginsRunner`, maybe we should extract it from the Handle, which should contain most about the `data and some tools that plugins can use` as commented. And construct more smaller interfaces for combination, but this needs more works.",
"created_at": "2023-08-24 06:33:04"
}
] | [
{
"author": "Huang-Wei",
"created_at": "2023-08-17 00:11:15",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 00:11:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 00:11:22",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 00:11:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 00:11:44",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 00:11:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 00:11:55",
"type": "unlabeled"
},
{
"author": "wackxu",
"created_at": "2023-08-17 01:06:03",
"type": "assigned"
},
{
"author": "x13n",
"created_at": "2023-08-17 20:50:55",
"type": "subscribed"
},
{
"author": "gjtempleton",
"created_at": "2023-08-17 20:50:55",
"type": "subscribed"
},
{
"author": "MaciekPytel",
"created_at": "2023-08-17 20:50:55",
"type": "subscribed"
},
{
"author": "mwielgus",
"created_at": "2023-08-17 20:50:55",
"type": "subscribed"
},
{
"author": "towca",
"created_at": "2023-08-17 20:50:55",
"type": "subscribed"
},
{
"author": "BigDarkClown",
"created_at": "2023-08-17 20:50:55",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 20:50:56",
"type": "labeled"
},
{
"author": "lowang-bh",
"created_at": "2023-08-18 03:01:32",
"type": "assigned"
},
{
"author": "lowang-bh",
"created_at": "2023-08-18 03:13:18",
"type": "mentioned"
},
{
"author": "lowang-bh",
"created_at": "2023-08-18 03:13:18",
"type": "subscribed"
},
{
"author": "lowang-bh",
"created_at": "2023-08-18 15:50:17",
"type": "mentioned"
},
{
"author": "lowang-bh",
"created_at": "2023-08-18 15:50:17",
"type": "subscribed"
},
{
"author": "wackxu",
"created_at": "2023-08-18 15:50:18",
"type": "mentioned"
},
{
"author": "wackxu",
"created_at": "2023-08-18 15:50:18",
"type": "subscribed"
},
{
"author": "lowang-bh",
"created_at": "2023-08-19 00:36:43",
"type": "unassigned"
},
{
"author": "Huang-Wei",
"created_at": "2023-08-23 08:21:21",
"type": "mentioned"
},
{
"author": "Huang-Wei",
"created_at": "2023-08-23 08:21:21",
"type": "subscribed"
},
{
"author": "alculquicondor",
"created_at": "2023-08-23 17:18:12",
"type": "subscribed"
},
{
"author": "Huang-Wei",
"created_at": "2023-08-23 17:18:12",
"type": "subscribed"
},
{
"author": "damemi",
"created_at": "2023-08-23 17:18:12",
"type": "subscribed"
},
{
"author": "chendave",
"created_at": "2023-08-23 17:18:12",
"type": "subscribed"
},
{
"author": "denkensk",
"created_at": "2023-08-23 17:18:12",
"type": "subscribed"
},
{
"author": "kerthcet",
"created_at": "2023-08-23 17:18:12",
"type": "subscribed"
},
{
"author": "ahg-g",
"created_at": "2023-08-23 17:18:12",
"type": "subscribed"
},
{
"author": "sanposhiho",
"created_at": "2023-08-23 17:18:13",
"type": "subscribed"
},
{
"author": "x13n",
"created_at": "2023-08-23 17:25:52",
"type": "mentioned"
},
{
"author": "x13n",
"created_at": "2023-08-23 17:25:52",
"type": "subscribed"
}
] |
119,986 | Pass Pinned field to kubecontainer.Image | closed | 2023-08-16 23:55:27 | 2023-08-24 18:57:47 | 2023-08-18 03:20:39 | [
"SergeyKanzhelev"
] | [
"kind/bug",
"priority/important-soon",
"area/kubelet",
"lgtm",
"sig/node",
"size/M",
"release-note-none",
"approved",
"cncf-cla: yes",
"triage/accepted"
] | ruiwen-zhao | [
{
"body": "/sig node",
"created_at": "2023-08-16 23:55:44"
},
{
"body": "/cc @pacoxu @endocrimes ",
"created_at": "2023-08-16 23:56:42"
},
{
"body": "/retest",
"created_at": "2023-08-17 08:49:47"
},
{
"body": "/triage accepted\r\n/priority important-soon",
"created_at": "2023-08-17 08:51:18"
},
{
"body": "/cc @mrunalp ",
"created_at": "2023-08-17 18:11:38"
},
{
"body": "LGTM label has been added. <details>Git tree hash: ce1990e43b1b9982817d870072d4df115cbed23f</details>",
"created_at": "2023-08-18 00:22:45"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119986#pullrequestreview-1583673933\" title=\"Approved\">mrunalp</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119986#\" title=\"Author self-approved\">ruiwen-zhao</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119986#pullrequestreview-1583219019\" title=\"Approved\">samuelkarp</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119986#pullrequestreview-1583668813\" title=\"Approved\">SergeyKanzhelev</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/OWNERS)~~ [mrunalp]\n- ~~[staging/src/k8s.io/cri-api/pkg/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/cri-api/pkg/OWNERS)~~ [mrunalp]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-18 00:33:35"
},
{
"body": "/retest",
"created_at": "2023-08-18 01:35:30"
},
{
"body": "/release-note \"Fixes the bug when images pinned by the container runtime can be garbage collected by kubelet\"",
"created_at": "2023-08-18 20:38:50"
},
{
"body": "/release-note-edit ```Fixes the bug when images pinned by the container runtime can be garbage collected by kubelet```",
"created_at": "2023-08-18 20:39:51"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 23:55:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 23:55:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 23:55:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 23:55:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 23:55:34",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 23:55:35",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 23:55:36",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 23:55:46",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 23:55:47",
"type": "unlabeled"
},
{
"author": "endocrimes",
"created_at": "2023-08-16 23:56:42",
"type": "mentioned"
},
{
"author": "endocrimes",
"created_at": "2023-08-16 23:56:43",
"type": "subscribed"
},
{
"author": "pacoxu",
"created_at": "2023-08-16 23:56:43",
"type": "mentioned"
},
{
"author": "pacoxu",
"created_at": "2023-08-16 23:56:43",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 23:56:43",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 23:56:43",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 23:57:11",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 23:57:12",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 00:01:32",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 00:01:32",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 00:01:32",
"type": "labeled"
},
{
"author": "ruiwen-zhao",
"created_at": "2023-08-17 00:33:23",
"type": "head_ref_force_pushed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 00:33:25",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 00:33:26",
"type": "labeled"
},
{
"author": "ruiwen-zhao",
"created_at": "2023-08-17 01:35:22",
"type": "mentioned"
},
{
"author": "ruiwen-zhao",
"created_at": "2023-08-17 01:35:22",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 08:51:20",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 08:51:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 08:51:22",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 08:51:23",
"type": "unlabeled"
},
{
"author": "ruiwen-zhao",
"created_at": "2023-08-17 16:52:41",
"type": "review_requested"
},
{
"author": "mrunalp",
"created_at": "2023-08-17 18:11:38",
"type": "mentioned"
},
{
"author": "mrunalp",
"created_at": "2023-08-17 18:11:38",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 18:11:39",
"type": "review_requested"
},
{
"author": "SergeyKanzhelev",
"created_at": "2023-08-18 00:22:43",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 00:22:44",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 00:33:36",
"type": "labeled"
},
{
"author": "ruiwen-zhao",
"created_at": "2023-08-18 01:29:12",
"type": "mentioned"
},
{
"author": "ruiwen-zhao",
"created_at": "2023-08-18 01:29:12",
"type": "subscribed"
},
{
"author": "ruiwen-zhao",
"created_at": "2023-08-18 01:33:39",
"type": "mentioned"
},
{
"author": "ruiwen-zhao",
"created_at": "2023-08-18 01:33:39",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 03:20:39",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 03:20:39",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 03:20:39",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 03:20:41",
"type": "milestoned"
}
] |
119,985 | Default values of Kubelet's EvictionHard | open | 2023-08-16 21:02:11 | 2023-08-18 01:15:49 | null | [] | [
"sig/node",
"kind/feature",
"needs-triage"
] | vaibhav2107 | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 21:02:20"
},
{
"body": "/sig node",
"created_at": "2023-08-16 21:02:58"
},
{
"body": "/cc",
"created_at": "2023-08-16 21:26:50"
},
{
"body": "This behavior is expected. \r\n\r\nhttps://kubernetes.io/docs/concepts/scheduling-eviction/node-pressure-eviction/#hard-eviction-thresholds\r\n\r\nIn general it is recommend if you change one of those items you should change all the other ones. \r\n\r\n",
"created_at": "2023-08-17 23:58:07"
},
{
"body": "I realize I’m starting what you said but I don’t think this can be considered a bug. I’d say it’s a feature to allow for different fields for HardEviction.\r\n\r\n/remove-kind bug\r\n/kind feature",
"created_at": "2023-08-18 00:07:01"
},
{
"body": "can we add a switch to controll it continue on inheriting the default values or be set to zero?",
"created_at": "2023-08-18 01:15:49"
}
] | [
{
"author": "vaibhav2107",
"created_at": "2023-08-16 21:02:11",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 21:02:18",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 21:02:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 21:03:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 21:03:01",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 00:07:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 00:07:03",
"type": "unlabeled"
}
] |
119,984 | kubeadm: increase ut coverage for util/kubeconfig | closed | 2023-08-16 17:01:53 | 2023-08-18 07:52:31 | 2023-08-18 07:52:29 | [
"neolit123"
] | [
"kind/cleanup",
"lgtm",
"sig/cluster-lifecycle",
"size/L",
"release-note-none",
"approved",
"area/kubeadm",
"cncf-cla: yes",
"needs-priority",
"triage/accepted"
] | my-git9 | [
{
"body": "LGTM label has been added. <details>Git tree hash: 54a875dfba1515d9855a3dc03397604f691cc4fc</details>",
"created_at": "2023-08-18 07:03:07"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119984#\" title=\"Author self-approved\">my-git9</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119984#pullrequestreview-1583971228\" title=\"Approved\">neolit123</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[cmd/kubeadm/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/OWNERS)~~ [neolit123]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-18 07:03:30"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 17:01:55",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 17:01:56",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 17:01:57",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 17:01:59",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 17:02:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 17:02:01",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 17:02:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 17:02:33",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 17:02:35",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 17:02:36",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 17:02:45",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 17:02:45",
"type": "review_requested"
},
{
"author": "my-git9",
"created_at": "2023-08-17 01:32:29",
"type": "head_ref_force_pushed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 20:22:20",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 20:22:21",
"type": "unlabeled"
},
{
"author": "my-git9",
"created_at": "2023-08-18 01:44:58",
"type": "head_ref_force_pushed"
},
{
"author": "my-git9",
"created_at": "2023-08-18 02:01:24",
"type": "review_requested"
},
{
"author": "my-git9",
"created_at": "2023-08-18 05:37:57",
"type": "head_ref_force_pushed"
},
{
"author": "my-git9",
"created_at": "2023-08-18 05:38:41",
"type": "head_ref_force_pushed"
},
{
"author": "my-git9",
"created_at": "2023-08-18 05:41:32",
"type": "head_ref_force_pushed"
},
{
"author": "my-git9",
"created_at": "2023-08-18 05:42:28",
"type": "review_requested"
},
{
"author": "my-git9",
"created_at": "2023-08-18 06:50:13",
"type": "head_ref_force_pushed"
},
{
"author": "my-git9",
"created_at": "2023-08-18 06:50:14",
"type": "review_requested"
},
{
"author": "neolit123",
"created_at": "2023-08-18 07:03:05",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 07:03:06",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 07:03:31",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 07:52:29",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 07:52:29",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 07:52:29",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 07:52:31",
"type": "milestoned"
}
] |
119,983 | OpenAPI loading double-buffering (or triple-buffering) | open | 2023-08-16 16:06:43 | 2023-08-17 22:28:16 | null | [
"pegasas"
] | [
"sig/api-machinery",
"kind/feature",
"triage/accepted"
] | justinsb | [
{
"body": "/sig api-machinery\r\n/triage accepted",
"created_at": "2023-08-16 16:07:07"
},
{
"body": "cc @liggitt ",
"created_at": "2023-08-16 16:07:59"
},
{
"body": "I wants to follow this issue.\r\n/assign @pegasas",
"created_at": "2023-08-17 01:12:41"
},
{
"body": "Hi, @justinsb ,\r\n\r\nlooks like we no longer need [round_tripper](https://github.com/kubernetes/client-go/blob/master/discovery/cached/disk/round_tripper.go) and only keeps [cached_discovery](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/discovery/cached/disk/cached_discovery.go) as cache layer?",
"created_at": "2023-08-17 13:11:03"
},
{
"body": "You probably don't want to be assigned but CC, which you already are. \r\n\r\n> looks like we no longer need [round_tripper](https://github.com/kubernetes/client-go/blob/master/discovery/cached/disk/round_tripper.go) and only keeps [cached_discovery](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/discovery/cached/disk/cached_discovery.go) as cache layer?\r\n\r\nWhat makes you think that?",
"created_at": "2023-08-17 15:47:34"
},
{
"body": "Hi, @apelisse\r\n\r\nFor me, I would like to follow this issue and work on a PR on it.\r\nClearly, You are the expert and know better than me. \r\nIf you want to follow your own, that's OK.\r\n\r\n> What makes you think that?\r\n\r\n> While inspecting the code for https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/discovery/cached/disk/cached_discovery.go, it appears that we buffer the OpenAPI response _twice_ as a []byte, once in io.ReadAll when we are reading it for parsing, and once in the HTTP caching layer.\r\n> \r\n> Arguably we need 3x the memory because our json parser is not streaming, so we retain the []byte while we unmarshal into the OpenAPI types.\r\n> \r\n> Given we are writing it to disk anyway, we should probably just write to a temp file.\r\n\r\nI read @justinsb 's solution and found [round_tripper](https://github.com/kubernetes/client-go/blob/master/discovery/cached/disk/round_tripper.go) as HTTP caching layer. \r\n\r\n@apelisse Is this solution missing some important architectural thinking there? \r\n\r\n",
"created_at": "2023-08-17 16:16:53"
},
{
"body": "Yeah, you need the round-tripper. From my read in this, the most reasonable fix is to:\r\n1. Find out if gregones/httpcache can be updated or not (it's been archived so unlikely), decide if we want to fork it and how\r\n2. Update the cache saving mechanism to just write the data as it's read (instead of saving into a buffer), inside a temporary file (has to be in on the same disk though so that you can ...), rename the file once the read is complete.\r\n\r\nThe problematic line is probably [here](https://github.com/gregjones/httpcache/blob/master/httpcache.go#L535C20-L535C20), it's writing to a buffer which forces the double allocation.\r\n\r\nTo be honest, you would have to change the `cachingReadCloser`, change the `OnEOF` callback to do what you want (dancing around the `httputil.DumpResponse`), and figure out a way to workaround the `t.Cache.Set` API which, I would say, you can change under no circumstances.\r\n\r\nIt sounds pretty hard tbh.",
"created_at": "2023-08-17 22:28:15"
}
] | [
{
"author": "justinsb",
"created_at": "2023-08-16 16:06:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 16:06:50",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 16:06:52",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 16:07:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 16:07:10",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 16:07:11",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 16:07:11",
"type": "unlabeled"
},
{
"author": "liggitt",
"created_at": "2023-08-16 16:08:00",
"type": "mentioned"
},
{
"author": "liggitt",
"created_at": "2023-08-16 16:08:00",
"type": "subscribed"
},
{
"author": "pegasas",
"created_at": "2023-08-17 01:12:42",
"type": "mentioned"
},
{
"author": "pegasas",
"created_at": "2023-08-17 01:12:42",
"type": "subscribed"
},
{
"author": "pegasas",
"created_at": "2023-08-17 01:12:43",
"type": "assigned"
},
{
"author": "justinsb",
"created_at": "2023-08-17 13:11:04",
"type": "mentioned"
},
{
"author": "justinsb",
"created_at": "2023-08-17 13:11:04",
"type": "subscribed"
},
{
"author": "justinsb",
"created_at": "2023-08-17 16:16:54",
"type": "mentioned"
},
{
"author": "justinsb",
"created_at": "2023-08-17 16:16:54",
"type": "subscribed"
},
{
"author": "apelisse",
"created_at": "2023-08-17 16:16:54",
"type": "mentioned"
},
{
"author": "apelisse",
"created_at": "2023-08-17 16:16:54",
"type": "subscribed"
}
] |
119,982 | Automated cherry pick of #119977: Make gomaxprocs install optional, limit to tests | closed | 2023-08-16 15:08:56 | 2023-08-25 13:44:45 | 2023-08-17 07:48:20 | [
"dims"
] | [
"kind/cleanup",
"lgtm",
"release-note",
"size/S",
"cherry-pick-approved",
"approved",
"cncf-cla: yes",
"sig/testing",
"needs-priority",
"needs-triage"
] | liggitt | [
{
"body": "/assign @dims",
"created_at": "2023-08-16 15:09:03"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 15:09:10"
},
{
"body": "/kind cleanup\r\n/sig testing",
"created_at": "2023-08-16 21:17:51"
},
{
"body": "/approve\r\n/lgtm",
"created_at": "2023-08-16 22:18:56"
},
{
"body": "LGTM label has been added. <details>Git tree hash: de35c073d3e228f2b90b0cdd47ef77aeafe1d050</details>",
"created_at": "2023-08-16 22:19:01"
},
{
"body": "cc @kubernetes/release-managers @saschagrunert ",
"created_at": "2023-08-16 22:23:58"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119982#issuecomment-1681340837\" title=\"LGTM\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119982#\" title=\"Author self-approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119982#pullrequestreview-1581995791\" title=\"Approved\">saschagrunert</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/hack/OWNERS)~~ [dims,liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-17 07:47:37"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:09:02",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:09:03",
"type": "labeled"
},
{
"author": "liggitt",
"created_at": "2023-08-16 15:09:03",
"type": "mentioned"
},
{
"author": "liggitt",
"created_at": "2023-08-16 15:09:03",
"type": "subscribed"
},
{
"author": "dims",
"created_at": "2023-08-16 15:09:03",
"type": "mentioned"
},
{
"author": "dims",
"created_at": "2023-08-16 15:09:03",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:09:04",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:09:06",
"type": "labeled"
},
{
"author": "dims",
"created_at": "2023-08-16 15:09:06",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:09:07",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:09:08",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:09:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:09:10",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:09:35",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:09:36",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:10:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 21:17:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 21:17:54",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 21:17:55",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 21:17:56",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 21:36:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 21:36:41",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 22:19:00",
"type": "labeled"
},
{
"author": "saschagrunert",
"created_at": "2023-08-16 22:23:59",
"type": "mentioned"
},
{
"author": "saschagrunert",
"created_at": "2023-08-16 22:23:59",
"type": "subscribed"
},
{
"author": "justaugustus",
"created_at": "2023-08-16 22:23:59",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-16 22:23:59",
"type": "subscribed"
},
{
"author": "Verolop",
"created_at": "2023-08-16 22:23:59",
"type": "subscribed"
},
{
"author": "puerco",
"created_at": "2023-08-16 22:23:59",
"type": "subscribed"
},
{
"author": "cpanato",
"created_at": "2023-08-16 22:23:59",
"type": "subscribed"
},
{
"author": "cici37",
"created_at": "2023-08-16 22:24:00",
"type": "subscribed"
},
{
"author": "palnabarun",
"created_at": "2023-08-16 22:24:00",
"type": "subscribed"
},
{
"author": "xmudrii",
"created_at": "2023-08-16 22:24:00",
"type": "subscribed"
},
{
"author": "k8s-release-robot",
"created_at": "2023-08-16 22:24:00",
"type": "subscribed"
},
{
"author": "jeremyrickard",
"created_at": "2023-08-16 22:24:00",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-17 07:47:23",
"type": "unlabeled"
},
{
"author": "saschagrunert",
"created_at": "2023-08-17 07:47:23",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:48:20",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:48:20",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:48:20",
"type": "closed"
},
{
"author": "liggitt",
"created_at": "2023-08-25 13:44:45",
"type": "head_ref_deleted"
}
] |
119,981 | Tolerate more api types.go files to generate code | open | 2023-08-16 14:55:52 | 2023-08-21 07:32:36 | null | [
"sttts",
"wojtek-t"
] | [
"sig/api-machinery",
"size/XS",
"cncf-cla: yes",
"do-not-merge/release-note-label-needed",
"area/code-generation",
"ok-to-test",
"needs-priority",
"triage/accepted",
"do-not-merge/needs-kind"
] | poneding | [
{
"body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 14:55:54"
},
{
"body": "Hi @poneding. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-16 14:56:02"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119981#\" title=\"Author self-approved\">poneding</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [sttts](https://github.com/sttts) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/code-generator/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/code-generator/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"sttts\"]} -->",
"created_at": "2023-08-16 14:56:31"
},
{
"body": "/assign @wojtek-t\r\nThank you.\r\n/triage accepted",
"created_at": "2023-08-17 16:37:36"
},
{
"body": "/assign @sttts \r\n\r\nCan you please take a look - given you already responded on the issue?\r\n\r\n/ok-to-test",
"created_at": "2023-08-21 07:27:25"
},
{
"body": "@poneding: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-dependencies | fb1647cc21f86dcdf322d19fb41ad01de22c0151 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119981/pull-kubernetes-dependencies/1693525208066953216) | true | `/test pull-kubernetes-dependencies`\npull-kubernetes-e2e-kind-ipv6 | fb1647cc21f86dcdf322d19fb41ad01de22c0151 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119981/pull-kubernetes-e2e-kind-ipv6/1693525208272474112) | true | `/test pull-kubernetes-e2e-kind-ipv6`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119981). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Aponeding). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"created_at": "2023-08-21 07:32:35"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:55:55",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:55:55",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:55:57",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:55:59",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:56:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:56:01",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:56:01",
"type": "labeled"
},
{
"author": "poneding",
"created_at": "2023-08-16 14:56:02",
"type": "mentioned"
},
{
"author": "poneding",
"created_at": "2023-08-16 14:56:02",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:56:02",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:56:44",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:56:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:56:47",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:56:56",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:56:56",
"type": "review_requested"
},
{
"author": "wojtek-t",
"created_at": "2023-08-17 16:37:36",
"type": "mentioned"
},
{
"author": "wojtek-t",
"created_at": "2023-08-17 16:37:36",
"type": "subscribed"
},
{
"author": "wojtek-t",
"created_at": "2023-08-17 16:37:37",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:37:38",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:37:40",
"type": "unlabeled"
},
{
"author": "sttts",
"created_at": "2023-08-21 07:27:25",
"type": "mentioned"
},
{
"author": "sttts",
"created_at": "2023-08-21 07:27:25",
"type": "subscribed"
},
{
"author": "sttts",
"created_at": "2023-08-21 07:27:26",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 07:27:26",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 07:27:27",
"type": "unlabeled"
},
{
"author": "poneding",
"created_at": "2023-08-21 07:32:34",
"type": "mentioned"
},
{
"author": "poneding",
"created_at": "2023-08-21 07:32:34",
"type": "subscribed"
},
{
"author": "poneding",
"created_at": "2023-08-21 07:32:36",
"type": "mentioned"
},
{
"author": "poneding",
"created_at": "2023-08-21 07:32:36",
"type": "subscribed"
}
] |
119,980 | helm-operation failure - Waiting for Kubernetes API to be available with mass deployment (130+ apps) | closed | 2023-08-16 14:35:57 | 2023-08-17 12:03:17 | 2023-08-17 12:02:46 | [] | [
"kind/bug",
"sig/apps",
"needs-triage"
] | vynguyenchantal | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 14:36:06"
},
{
"body": "> Kubernetes version: v1.23.10\r\n\r\n< 1.24 is out of support, so core k8s cannot backport fixes for this version.\r\nhttps://kubernetes.io/releases/\r\n\r\nplease contact rancher / helm\r\nif the maintainers of those project confirm this is a core k8s bug, repen the issue.\r\nthis doesn't sound like a core k8s bug.\r\n\r\n/close\r\n/sig apps\r\n",
"created_at": "2023-08-17 12:02:41"
},
{
"body": "@neolit123: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119980#issuecomment-1682163888):\n\n>\r\n>> Kubernetes version: v1.23.10\r\n>\r\n>< 1.24 is out of support, so core k8s cannot backport fixes for this version.\r\n>\r\n>please contact rancher / helm\r\n>if the maintainers of those project confirm this is a core k8s bug, repen the issue.\r\n>this doesn't sound like a core k8s bug.\r\n>\r\n>/close\r\n>/sig apps\r\n>\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-17 12:02:46"
}
] | [
{
"author": "vynguyenchantal",
"created_at": "2023-08-16 14:35:57",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:36:04",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:36:06",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 12:02:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 12:02:44",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 12:02:46",
"type": "closed"
},
{
"author": "neolit123",
"created_at": "2023-08-17 12:02:47",
"type": "mentioned"
},
{
"author": "neolit123",
"created_at": "2023-08-17 12:02:47",
"type": "subscribed"
}
] |
119,979 | client-go: workqueue: Add IsQueued() method to the workqueue interface | open | 2023-08-16 14:23:46 | 2023-08-22 09:10:44 | null | [
"smarterclayton"
] | [
"sig/api-machinery",
"size/M",
"kind/api-change",
"kind/feature",
"release-note-none",
"sig/apps",
"cncf-cla: yes",
"ok-to-test",
"needs-priority",
"triage/accepted"
] | davidmccormick | [
{
"body": "Hi @davidmccormick. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-16 14:23:55"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119979#\" title=\"Author self-approved\">davidmccormick</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [deads2k](https://github.com/deads2k) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/controller/garbagecollector/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/garbagecollector/OWNERS)**\n- **[staging/src/k8s.io/client-go/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"deads2k\"]} -->",
"created_at": "2023-08-16 14:24:21"
},
{
"body": "@atiratree - could you please take a look? I'm trying to break up https://github.com/kubernetes/kubernetes/pull/112328 into easier to review and merge chunks?.",
"created_at": "2023-08-16 14:27:59"
},
{
"body": "/kind api-change",
"created_at": "2023-08-16 14:29:41"
},
{
"body": "/kind feature",
"created_at": "2023-08-16 14:35:48"
},
{
"body": "/ok-to-test\r\n/assign @smarterclayton\r\nCould you take a look? Thank you.\r\n/triage accepted",
"created_at": "2023-08-17 16:38:51"
},
{
"body": "@davidmccormick: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-conformance-kind-ga-only-parallel | e123ff186a6205e4e6d120a37aa89bbd66891bbe | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119979/pull-kubernetes-conformance-kind-ga-only-parallel/1692214431037001728) | true | `/test pull-kubernetes-conformance-kind-ga-only-parallel`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119979). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Adavidmccormick). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"created_at": "2023-08-17 17:10:48"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:23:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:23:49",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:23:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:23:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:23:54",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:23:54",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:23:55",
"type": "labeled"
},
{
"author": "davidmccormick",
"created_at": "2023-08-16 14:23:56",
"type": "mentioned"
},
{
"author": "davidmccormick",
"created_at": "2023-08-16 14:23:56",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:23:56",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:24:33",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:24:33",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:24:47",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:24:47",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:24:49",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:24:49",
"type": "unlabeled"
},
{
"author": "atiratree",
"created_at": "2023-08-16 14:27:59",
"type": "mentioned"
},
{
"author": "atiratree",
"created_at": "2023-08-16 14:27:59",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:29:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:29:45",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:35:49",
"type": "labeled"
},
{
"author": "smarterclayton",
"created_at": "2023-08-17 16:38:51",
"type": "mentioned"
},
{
"author": "smarterclayton",
"created_at": "2023-08-17 16:38:51",
"type": "subscribed"
},
{
"author": "smarterclayton",
"created_at": "2023-08-17 16:38:52",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:38:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:38:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:38:53",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:38:55",
"type": "unlabeled"
},
{
"author": "davidmccormick",
"created_at": "2023-08-17 17:10:48",
"type": "mentioned"
},
{
"author": "davidmccormick",
"created_at": "2023-08-17 17:10:48",
"type": "subscribed"
}
] |
119,978 | Non-strict condition for api types.go file to generate clientset etc. | closed | 2023-08-16 14:21:10 | 2023-08-22 20:07:34 | 2023-08-16 14:50:15 | [] | [
"area/kubectl",
"sig/api-machinery",
"size/XS",
"sig/cli",
"cncf-cla: yes",
"needs-ok-to-test",
"do-not-merge/release-note-label-needed",
"area/code-generation",
"needs-priority",
"do-not-merge/contains-merge-commits",
"triage/accepted",
"do-not-merge/needs-kind"
] | poneding | [
{
"body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 14:21:12"
},
{
"body": "Hi @poneding. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-16 14:21:19"
},
{
"body": "Adding label `do-not-merge/contains-merge-commits` because PR contains merge commits, which are not allowed in this repository.\nUse `git rebase` to reapply your commits on top of the target branch. Detailed instructions for doing so can be found [here](https://git.k8s.io/community/contributors/guide/github-workflow.md#4-keep-your-branch-in-sync).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 14:21:30"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119978#\" title=\"Author self-approved\">poneding</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [deads2k](https://github.com/deads2k) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/code-generator/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/code-generator/OWNERS)**\n- **[staging/src/k8s.io/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"deads2k\"]} -->",
"created_at": "2023-08-16 14:21:59"
},
{
"body": "/triage accepted",
"created_at": "2023-08-22 20:07:30"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:21:12",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:21:13",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:21:15",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:21:17",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:21:18",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:21:18",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:21:18",
"type": "labeled"
},
{
"author": "poneding",
"created_at": "2023-08-16 14:21:19",
"type": "mentioned"
},
{
"author": "poneding",
"created_at": "2023-08-16 14:21:20",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:21:20",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:21:29",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:21:46",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:21:47",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:21:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:21:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:21:49",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:22:13",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 14:22:13",
"type": "review_requested"
},
{
"author": "poneding",
"created_at": "2023-08-16 14:50:15",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 20:07:31",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 20:07:33",
"type": "unlabeled"
}
] |
119,977 | Make gomaxprocs install optional, limit to tests | closed | 2023-08-16 13:34:32 | 2023-08-16 15:24:29 | 2023-08-16 15:24:27 | [
"dims"
] | [
"kind/bug",
"kind/cleanup",
"lgtm",
"size/S",
"release-note-none",
"approved",
"cncf-cla: yes",
"sig/testing",
"needs-priority",
"needs-triage"
] | liggitt | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 13:34:40"
},
{
"body": "/sig testing\r\n/approve\r\n/lgtm",
"created_at": "2023-08-16 13:54:37"
},
{
"body": "LGTM label has been added. <details>Git tree hash: f0de70e97472d26802dcc3fa38f56b5f9298751e</details>",
"created_at": "2023-08-16 13:54:44"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119977#issuecomment-1680658925\" title=\"LGTM\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119977#\" title=\"Author self-approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/hack/OWNERS)~~ [dims,liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-16 13:55:00"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:34:34",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:34:34",
"type": "labeled"
},
{
"author": "dims",
"created_at": "2023-08-16 13:34:34",
"type": "mentioned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:34:34",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:34:34",
"type": "labeled"
},
{
"author": "dims",
"created_at": "2023-08-16 13:34:34",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:34:35",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:34:37",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:34:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:34:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:34:41",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:35:27",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:54:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:54:40",
"type": "unlabeled"
},
{
"author": "dims",
"created_at": "2023-08-16 13:54:42",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:54:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:24:27",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:24:27",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:24:27",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:24:29",
"type": "milestoned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:48:27",
"type": "referenced"
},
{
"author": "hswong3i",
"created_at": "2023-08-24 03:43:47",
"type": "referenced"
}
] |
119,976 | Project scoped repository can be used in different project if user has access to both projects | closed | 2023-08-16 13:25:33 | 2023-08-16 13:26:05 | 2023-08-16 13:25:51 | [] | [
"kind/bug",
"needs-sig",
"needs-triage"
] | nikParasyr | [
{
"body": "There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:\n- `/sig <group-name>`\n- `/wg <group-name>`\n- `/committee <group-name>`\n\nPlease see the [group list](https://git.k8s.io/community/sig-list.md) for a listing of the SIGs, working groups, and committees available.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 13:25:40"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 13:25:42"
},
{
"body": "wrong repo...",
"created_at": "2023-08-16 13:26:05"
}
] | [
{
"author": "nikParasyr",
"created_at": "2023-08-16 13:25:33",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:25:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:25:41",
"type": "labeled"
},
{
"author": "nikParasyr",
"created_at": "2023-08-16 13:25:52",
"type": "closed"
}
] |
119,975 | storage/util: move GetCurrentResourceVersionFromStorage | closed | 2023-08-16 12:58:46 | 2023-08-21 10:33:26 | 2023-08-21 09:49:48 | [
"wojtek-t"
] | [
"kind/cleanup",
"area/apiserver",
"lgtm",
"sig/api-machinery",
"size/L",
"release-note-none",
"approved",
"cncf-cla: yes",
"needs-priority",
"triage/accepted"
] | p0lyn0mial | [
{
"body": "/assign @wojtek-t ",
"created_at": "2023-08-16 12:58:57"
},
{
"body": "/assign @wojtek-t \r\nfor context\r\n/triage accepted",
"created_at": "2023-08-17 16:40:03"
},
{
"body": "/lgtm\r\n/approve\r\n\r\n/retest\r\n\r\nThanks!",
"created_at": "2023-08-21 07:26:19"
},
{
"body": "LGTM label has been added. <details>Git tree hash: da1e7ddac03c548818afd1b1d3210695c6612719</details>",
"created_at": "2023-08-21 07:26:25"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119975#\" title=\"Author self-approved\">p0lyn0mial</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119975#issuecomment-1685793554\" title=\"Approved\">wojtek-t</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/apiserver/pkg/storage/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/storage/OWNERS)~~ [wojtek-t]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-21 07:26:49"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:58:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:58:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:58:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:58:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:58:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:58:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:58:55",
"type": "labeled"
},
{
"author": "wojtek-t",
"created_at": "2023-08-16 12:58:58",
"type": "mentioned"
},
{
"author": "wojtek-t",
"created_at": "2023-08-16 12:58:58",
"type": "subscribed"
},
{
"author": "wojtek-t",
"created_at": "2023-08-16 12:58:59",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:59:35",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:59:35",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:59:37",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:00:00",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:00:00",
"type": "review_requested"
},
{
"author": "p0lyn0mial",
"created_at": "2023-08-16 13:23:50",
"type": "mentioned"
},
{
"author": "p0lyn0mial",
"created_at": "2023-08-16 13:23:50",
"type": "subscribed"
},
{
"author": "wojtek-t",
"created_at": "2023-08-17 16:40:04",
"type": "mentioned"
},
{
"author": "wojtek-t",
"created_at": "2023-08-17 16:40:04",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:40:05",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:40:07",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 07:26:24",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 07:26:50",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 09:49:48",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 09:49:48",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 09:49:48",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 09:49:50",
"type": "milestoned"
}
] |
119,974 | bump the busybox test version to resolve test failures | closed | 2023-08-16 12:33:04 | 2023-08-17 00:24:22 | 2023-08-16 19:44:14 | [
"dims"
] | [
"area/test",
"lgtm",
"sig/node",
"size/XS",
"release-note-none",
"approved",
"cncf-cla: yes",
"sig/testing",
"kind/failing-test",
"needs-priority",
"needs-triage"
] | tzneal | [
{
"body": "/test",
"created_at": "2023-08-16 12:33:09"
},
{
"body": "@tzneal: The `/test` command needs one or more targets.\nThe following commands are available to trigger required jobs:\n* `/test pull-cadvisor-e2e-kubernetes`\n* `/test pull-kubernetes-conformance-kind-ga-only-parallel`\n* `/test pull-kubernetes-coverage-unit`\n* `/test pull-kubernetes-dependencies`\n* `/test pull-kubernetes-dependencies-go-canary`\n* `/test pull-kubernetes-e2e-gce`\n* `/test pull-kubernetes-e2e-gce-100-performance`\n* `/test pull-kubernetes-e2e-gce-big-performance`\n* `/test pull-kubernetes-e2e-gce-canary`\n* `/test pull-kubernetes-e2e-gce-cos`\n* `/test pull-kubernetes-e2e-gce-cos-canary`\n* `/test pull-kubernetes-e2e-gce-cos-no-stage`\n* `/test pull-kubernetes-e2e-gce-network-proxy-http-connect`\n* `/test pull-kubernetes-e2e-gce-scale-performance-manual`\n* `/test pull-kubernetes-e2e-kind`\n* `/test pull-kubernetes-e2e-kind-ipv6`\n* `/test pull-kubernetes-integration`\n* `/test pull-kubernetes-integration-go-canary`\n* `/test pull-kubernetes-kubemark-e2e-gce-scale`\n* `/test pull-kubernetes-node-e2e-containerd`\n* `/test pull-kubernetes-typecheck`\n* `/test pull-kubernetes-unit`\n* `/test pull-kubernetes-unit-go-canary`\n* `/test pull-kubernetes-update`\n* `/test pull-kubernetes-verify`\n* `/test pull-kubernetes-verify-go-canary`\n\nThe following commands are available to trigger optional jobs:\n* `/test check-dependency-stats`\n* `/test pull-ci-kubernetes-unit-windows`\n* `/test pull-e2e-gce-cloud-provider-disabled`\n* `/test pull-kubernetes-conformance-image-test`\n* `/test pull-kubernetes-conformance-kind-ga-only`\n* `/test pull-kubernetes-conformance-kind-ipv6-parallel`\n* `/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e`\n* `/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e-features`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-eviction`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-features`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-serial`\n* `/test pull-kubernetes-cross`\n* `/test pull-kubernetes-e2e-autoscaling-hpa-cm`\n* `/test pull-kubernetes-e2e-autoscaling-hpa-cpu`\n* `/test pull-kubernetes-e2e-capz-azure-disk`\n* `/test pull-kubernetes-e2e-capz-azure-disk-vmss`\n* `/test pull-kubernetes-e2e-capz-azure-file`\n* `/test pull-kubernetes-e2e-capz-azure-file-vmss`\n* `/test pull-kubernetes-e2e-capz-conformance`\n* `/test pull-kubernetes-e2e-capz-windows`\n* `/test pull-kubernetes-e2e-capz-windows-alpha-feature-vpa`\n* `/test pull-kubernetes-e2e-capz-windows-alpha-features`\n* `/test pull-kubernetes-e2e-capz-windows-serial-slow-hpa`\n* `/test pull-kubernetes-e2e-containerd-gce`\n* `/test pull-kubernetes-e2e-ec2`\n* `/test pull-kubernetes-e2e-ec2-conformance`\n* `/test pull-kubernetes-e2e-gce-correctness`\n* `/test pull-kubernetes-e2e-gce-cos-alpha-features`\n* `/test pull-kubernetes-e2e-gce-cos-kubetest2`\n* `/test pull-kubernetes-e2e-gce-csi-serial`\n* `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\n* `/test pull-kubernetes-e2e-gce-kubelet-credential-provider`\n* `/test pull-kubernetes-e2e-gce-network-proxy-grpc`\n* `/test pull-kubernetes-e2e-gce-serial`\n* `/test pull-kubernetes-e2e-gce-storage-disruptive`\n* `/test pull-kubernetes-e2e-gce-storage-slow`\n* `/test pull-kubernetes-e2e-gce-storage-snapshot`\n* `/test pull-kubernetes-e2e-gci-gce-autoscaling`\n* `/test pull-kubernetes-e2e-gci-gce-ingress`\n* `/test pull-kubernetes-e2e-gci-gce-ipvs`\n* `/test pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2`\n* `/test pull-kubernetes-e2e-kind-alpha-features`\n* `/test pull-kubernetes-e2e-kind-canary`\n* `/test pull-kubernetes-e2e-kind-dual-canary`\n* `/test pull-kubernetes-e2e-kind-ipv6-canary`\n* `/test pull-kubernetes-e2e-kind-ipvs-dual-canary`\n* `/test pull-kubernetes-e2e-kind-kms`\n* `/test pull-kubernetes-e2e-kind-multizone`\n* `/test pull-kubernetes-e2e-kops-aws`\n* `/test pull-kubernetes-e2e-storage-kind-disruptive`\n* `/test pull-kubernetes-e2e-ubuntu-gce-network-policies`\n* `/test pull-kubernetes-integration-eks`\n* `/test pull-kubernetes-kind-dra`\n* `/test pull-kubernetes-kind-json-logging`\n* `/test pull-kubernetes-kind-text-logging`\n* `/test pull-kubernetes-kubemark-e2e-gce-big`\n* `/test pull-kubernetes-local-e2e`\n* `/test pull-kubernetes-node-arm64-e2e-containerd-ec2`\n* `/test pull-kubernetes-node-arm64-e2e-containerd-serial-ec2`\n* `/test pull-kubernetes-node-arm64-ubuntu-serial-gce`\n* `/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e`\n* `/test pull-kubernetes-node-crio-cgrpv2-e2e`\n* `/test pull-kubernetes-node-crio-cgrpv2-e2e-kubetest2`\n* `/test pull-kubernetes-node-crio-e2e`\n* `/test pull-kubernetes-node-crio-e2e-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-alpha-features`\n* `/test pull-kubernetes-node-e2e-containerd-ec2`\n* `/test pull-kubernetes-node-e2e-containerd-features`\n* `/test pull-kubernetes-node-e2e-containerd-features-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-serial-ec2`\n* `/test pull-kubernetes-node-e2e-containerd-sidecar-containers`\n* `/test pull-kubernetes-node-e2e-containerd-standalone-mode`\n* `/test pull-kubernetes-node-e2e-containerd-standalone-mode-all-alpha`\n* `/test pull-kubernetes-node-e2e-crio-dra`\n* `/test pull-kubernetes-node-kubelet-credential-provider`\n* `/test pull-kubernetes-node-kubelet-serial-containerd`\n* `/test pull-kubernetes-node-kubelet-serial-containerd-kubetest2`\n* `/test pull-kubernetes-node-kubelet-serial-cpu-manager`\n* `/test pull-kubernetes-node-kubelet-serial-cpu-manager-kubetest2`\n* `/test pull-kubernetes-node-kubelet-serial-crio-cgroupv1`\n* `/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2`\n* `/test pull-kubernetes-node-kubelet-serial-hugepages`\n* `/test pull-kubernetes-node-kubelet-serial-memory-manager`\n* `/test pull-kubernetes-node-kubelet-serial-pod-disruption-conditions`\n* `/test pull-kubernetes-node-kubelet-serial-topology-manager`\n* `/test pull-kubernetes-node-kubelet-serial-topology-manager-kubetest2`\n* `/test pull-kubernetes-node-memoryqos-cgrpv2`\n* `/test pull-kubernetes-node-swap-fedora`\n* `/test pull-kubernetes-node-swap-fedora-serial`\n* `/test pull-kubernetes-node-swap-ubuntu-serial`\n* `/test pull-kubernetes-unit-experimental`\n* `/test pull-kubernetes-verify-strict-lint`\n* `/test pull-publishing-bot-validate`\n\nUse `/test all` to run the following jobs that were automatically triggered:\n* `pull-kubernetes-conformance-kind-ga-only-parallel`\n* `pull-kubernetes-conformance-kind-ipv6-parallel`\n* `pull-kubernetes-dependencies`\n* `pull-kubernetes-e2e-gce`\n* `pull-kubernetes-e2e-kind`\n* `pull-kubernetes-e2e-kind-ipv6`\n* `pull-kubernetes-integration`\n* `pull-kubernetes-node-e2e-containerd`\n* `pull-kubernetes-typecheck`\n* `pull-kubernetes-unit`\n* `pull-kubernetes-verify`\n\n\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119974#issuecomment-1680520050):\n\n>/test\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 12:33:11"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 12:33:12"
},
{
"body": "/test pull-kubernetes-node-arm64-e2e-containerd-serial-ec2",
"created_at": "2023-08-16 12:33:43"
},
{
"body": "Looking into this test failure, looks like the `trap` builtin has changed semantics.",
"created_at": "2023-08-16 13:37:42"
},
{
"body": "ash in busybox has a new `sleep` built-in. We need the actual separate process for this test, so be specific about how we sleep.",
"created_at": "2023-08-16 13:52:36"
},
{
"body": "New builtin for ash was added last year, so its in this new image and wasn't in the old one. https://github.com/mirror/busybox/commit/58598eb7093561d914a6254697e137b815f1fdfc",
"created_at": "2023-08-16 14:01:07"
},
{
"body": "/approve\r\n/lgtm",
"created_at": "2023-08-16 16:06:06"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 96e11f9a6c0e6b4077b2def18f330961f978a7ef</details>",
"created_at": "2023-08-16 16:06:13"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119974#issuecomment-1680888733\" title=\"LGTM\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119974#\" title=\"Author self-approved\">tzneal</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e_node/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/OWNERS)~~ [dims]\n- ~~[test/utils/image/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/utils/image/OWNERS)~~ [dims]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-16 16:06:35"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:33:05",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:33:06",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:33:07",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:33:10",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:33:11",
"type": "labeled"
},
{
"author": "tzneal",
"created_at": "2023-08-16 12:33:12",
"type": "mentioned"
},
{
"author": "tzneal",
"created_at": "2023-08-16 12:33:12",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:33:13",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:33:18",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:33:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:33:51",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:33:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:33:54",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:33:55",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:34:06",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:34:06",
"type": "review_requested"
},
{
"author": "tzneal",
"created_at": "2023-08-16 12:58:57",
"type": "mentioned"
},
{
"author": "tzneal",
"created_at": "2023-08-16 12:58:57",
"type": "subscribed"
},
{
"author": "tzneal",
"created_at": "2023-08-16 13:52:07",
"type": "head_ref_force_pushed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:53:02",
"type": "labeled"
},
{
"author": "dims",
"created_at": "2023-08-16 16:06:11",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 16:06:12",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 16:06:36",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 19:44:14",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 19:44:14",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 19:44:14",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 19:44:15",
"type": "milestoned"
},
{
"author": "tzneal",
"created_at": "2023-08-17 00:24:22",
"type": "head_ref_deleted"
}
] |
119,973 | Bump busybox image | closed | 2023-08-16 11:36:57 | 2023-08-19 11:53:30 | 2023-08-19 11:53:24 | [
"dims"
] | [
"area/test",
"priority/critical-urgent",
"kind/cleanup",
"lgtm",
"size/XS",
"release-note-none",
"approved",
"cncf-cla: yes",
"sig/testing",
"triage/accepted"
] | mkumatag | [
{
"body": "/sig testing\r\n/release-note-none\r\n/triage accepted\r\n/priority critical-urgent",
"created_at": "2023-08-16 11:41:37"
},
{
"body": "/assign dims",
"created_at": "2023-08-16 11:42:11"
},
{
"body": "/approve\r\n/lgtm\r\n/retest",
"created_at": "2023-08-16 12:11:18"
},
{
"body": "LGTM label has been added. <details>Git tree hash: c4401ff9b47f48054c087be3a5ce95ac03f14ccd</details>",
"created_at": "2023-08-16 12:11:24"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119973#issuecomment-1680489186\" title=\"LGTM\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119973#\" title=\"Author self-approved\">mkumatag</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/utils/image/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/utils/image/OWNERS)~~ [dims,mkumatag]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-16 12:11:51"
},
{
"body": "/retest-required",
"created_at": "2023-08-16 13:10:40"
},
{
"body": "/retest-required",
"created_at": "2023-08-16 14:19:11"
},
{
"body": "I didn't see this one before I created https://github.com/kubernetes/kubernetes/pull/119974. I fixed the test there too, it's not a flake.",
"created_at": "2023-08-16 14:33:19"
},
{
"body": "@mkumatag: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-node-e2e-containerd | 79159014b414e75be556f78a903c8e31cd3bb326 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119973/pull-kubernetes-node-e2e-containerd/1691816889459675136/) | true | `/test pull-kubernetes-node-e2e-containerd`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119973). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Amkumatag). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"created_at": "2023-08-16 14:45:04"
},
{
"body": "this is already merged via https://github.com/kubernetes/kubernetes/pull/119974",
"created_at": "2023-08-19 11:53:22"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:36:59",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:36:59",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:37:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:37:02",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:37:04",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:37:05",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:37:07",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:37:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:37:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:37:32",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:37:43",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:37:43",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:37:57",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:41:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:41:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:41:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:41:40",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:41:41",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:41:41",
"type": "unlabeled"
},
{
"author": "dims",
"created_at": "2023-08-16 11:42:12",
"type": "assigned"
},
{
"author": "mkumatag",
"created_at": "2023-08-16 12:04:38",
"type": "mentioned"
},
{
"author": "mkumatag",
"created_at": "2023-08-16 12:04:38",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:11:22",
"type": "labeled"
},
{
"author": "mkumatag",
"created_at": "2023-08-16 12:36:51",
"type": "mentioned"
},
{
"author": "mkumatag",
"created_at": "2023-08-16 12:36:51",
"type": "subscribed"
},
{
"author": "mkumatag",
"created_at": "2023-08-16 13:35:49",
"type": "mentioned"
},
{
"author": "mkumatag",
"created_at": "2023-08-16 13:35:49",
"type": "subscribed"
},
{
"author": "mkumatag",
"created_at": "2023-08-16 14:45:04",
"type": "mentioned"
},
{
"author": "mkumatag",
"created_at": "2023-08-16 14:45:04",
"type": "subscribed"
},
{
"author": "mkumatag",
"created_at": "2023-08-19 11:53:24",
"type": "closed"
},
{
"author": "mkumatag",
"created_at": "2023-08-19 11:53:30",
"type": "head_ref_deleted"
}
] |
119,972 | storage/etcd: no-op, refactor watcher.Watch method signature | closed | 2023-08-16 11:35:42 | 2023-08-21 09:49:43 | 2023-08-21 09:49:41 | [
"enj",
"wojtek-t"
] | [
"kind/cleanup",
"area/apiserver",
"lgtm",
"sig/api-machinery",
"size/S",
"release-note-none",
"approved",
"cncf-cla: yes",
"needs-priority",
"triage/accepted"
] | p0lyn0mial | [
{
"body": "/assign @wojtek-t ",
"created_at": "2023-08-16 11:35:53"
},
{
"body": "/lgtm",
"created_at": "2023-08-16 12:17:12"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 43cdcec4e6081ca715bde8d2534d36379c45470c</details>",
"created_at": "2023-08-16 12:17:20"
},
{
"body": "/triage accepted",
"created_at": "2023-08-17 16:40:32"
},
{
"body": "/lgtm\r\n/approve",
"created_at": "2023-08-21 07:28:50"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119972#\" title=\"Author self-approved\">p0lyn0mial</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119972#issuecomment-1685796961\" title=\"Approved\">wojtek-t</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/apiserver/pkg/storage/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/storage/OWNERS)~~ [wojtek-t]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-21 07:29:18"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:35:44",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:35:44",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:35:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:35:47",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:35:50",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:35:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:35:52",
"type": "labeled"
},
{
"author": "wojtek-t",
"created_at": "2023-08-16 11:35:53",
"type": "mentioned"
},
{
"author": "wojtek-t",
"created_at": "2023-08-16 11:35:53",
"type": "subscribed"
},
{
"author": "wojtek-t",
"created_at": "2023-08-16 11:35:55",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:36:18",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:36:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:36:21",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:36:30",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:36:30",
"type": "review_requested"
},
{
"author": "enj",
"created_at": "2023-08-16 12:17:17",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:17:18",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:40:34",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:40:36",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 07:29:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 09:49:41",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 09:49:41",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 09:49:41",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 09:49:43",
"type": "milestoned"
}
] |
119,971 | chore: attach pod UID to event log | closed | 2023-08-16 11:33:43 | 2023-08-21 14:05:29 | 2023-08-21 11:13:23 | [
"alculquicondor",
"Huang-Wei",
"sanposhiho"
] | [
"sig/scheduling",
"lgtm",
"release-note",
"size/XS",
"kind/feature",
"approved",
"cncf-cla: yes",
"ok-to-test",
"needs-priority",
"needs-triage"
] | kwakubiney | [
{
"body": "<a href=\"https://easycla.lfx.linuxfoundation.org/#/?version=2\"><img src=\"https://s3.amazonaws.com/cla-project-logo-prod/cla-signed.svg\" alt=\"CLA Signed\" align=\"left\" height=\"28\" width=\"328\" ></a><br/><br />The committers listed above are authorized under a signed CLA.<ul><li>:white_check_mark: login: kwakubiney / name: kb (5752cbd8c76f1d9901be4c149e7b6d345380b218)</li></ul>",
"created_at": "2023-08-16 11:33:46"
},
{
"body": "Welcome @kwakubiney! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:",
"created_at": "2023-08-16 11:33:51"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 11:33:51"
},
{
"body": "Hi @kwakubiney. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-16 11:33:52"
},
{
"body": "We shouldn't do this. See https://github.com/kubernetes/kubernetes/issues/114882.\r\n[Previously](https://github.com/kubernetes/kubernetes/blob/release-1.19/pkg/scheduler/framework/plugins/defaultpreemption/default_preemption.go#L603-L604), we had Pod name + namespace name, and we intentionally removed them.\r\n",
"created_at": "2023-08-16 11:48:54"
},
{
"body": "> We shouldn't do this. See #114882.\r\n> [Previously](https://github.com/kubernetes/kubernetes/blob/release-1.19/pkg/scheduler/framework/plugins/defaultpreemption/default_preemption.go#L603-L604), we had Pod name + namespace name, and we intentionally removed them.\r\n\r\nI understand your sentiments, but the argument is outlined in the issue I linked. Pod namespace and name are confidential and making it obscure in the logs is important but also hurts debugging, and causes a lot of friction. UIDs are a safer bet and strikes a better balance. UIDs are not user-assignable & reduces friction when debugging issues.",
"created_at": "2023-08-16 12:00:00"
},
{
"body": "Maybe you linked a wrong one at the top?",
"created_at": "2023-08-16 13:15:48"
},
{
"body": "> Maybe you linked a wrong one at the top?\r\n\r\nAh yes. Typo fixed",
"created_at": "2023-08-16 13:40:20"
},
{
"body": "/ok-to-test",
"created_at": "2023-08-17 03:52:01"
},
{
"body": "@kwakubiney Please get your release note in the code block as the [template](https://github.com/kubernetes/kubernetes/blob/master/.github/PULL_REQUEST_TEMPLATE.md) does. Then, it'll be handled correctly\r\n\r\n<img width=\"171\" alt=\"Screenshot 2023-08-17 at 12 53 51\" src=\"https://github.com/kubernetes/kubernetes/assets/44139130/ac78fa88-a772-45e6-80f4-983654416690\">\r\n",
"created_at": "2023-08-17 03:54:26"
},
{
"body": "/retest",
"created_at": "2023-08-17 09:52:47"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 0a4f41ac8af32c8800af041428634d2da84335e4</details>",
"created_at": "2023-08-17 09:58:50"
},
{
"body": "/assign @Huang-Wei \r\n\r\nFor approval",
"created_at": "2023-08-17 09:58:55"
},
{
"body": "/assign @alculquicondor\r\nas Aldo was more involved in the original discussion.\r\n(there is a duplicate PR #120016)\r\n\r\ncc @mimowo",
"created_at": "2023-08-17 20:20:29"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119971#pullrequestreview-1584466827\" title=\"Approved\">alculquicondor</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119971#\" title=\"Author self-approved\">kwakubiney</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/scheduler/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/scheduler/OWNERS)~~ [alculquicondor]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-18 12:20:34"
},
{
"body": "/retest",
"created_at": "2023-08-21 09:43:07"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:33:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:33:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:33:46",
"type": "labeled"
},
{
"author": "kwakubiney",
"created_at": "2023-08-16 11:33:47",
"type": "mentioned"
},
{
"author": "kwakubiney",
"created_at": "2023-08-16 11:33:47",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:33:49",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:33:50",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:33:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:33:51",
"type": "labeled"
},
{
"author": "kwakubiney",
"created_at": "2023-08-16 11:33:51",
"type": "mentioned"
},
{
"author": "kwakubiney",
"created_at": "2023-08-16 11:33:51",
"type": "subscribed"
},
{
"author": "kwakubiney",
"created_at": "2023-08-16 11:33:52",
"type": "mentioned"
},
{
"author": "kwakubiney",
"created_at": "2023-08-16 11:33:52",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:33:52",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:34:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:34:21",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:34:47",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:34:47",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:37:05",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:37:05",
"type": "labeled"
},
{
"author": "kwakubiney",
"created_at": "2023-08-16 11:39:10",
"type": "renamed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 03:52:02",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 03:52:03",
"type": "unlabeled"
},
{
"author": "kwakubiney",
"created_at": "2023-08-17 03:54:27",
"type": "mentioned"
},
{
"author": "kwakubiney",
"created_at": "2023-08-17 03:54:27",
"type": "subscribed"
},
{
"author": "kwakubiney",
"created_at": "2023-08-17 04:20:22",
"type": "mentioned"
},
{
"author": "kwakubiney",
"created_at": "2023-08-17 04:20:22",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 09:52:06",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 09:52:06",
"type": "unlabeled"
},
{
"author": "sanposhiho",
"created_at": "2023-08-17 09:58:47",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 09:58:48",
"type": "labeled"
},
{
"author": "Huang-Wei",
"created_at": "2023-08-17 09:58:56",
"type": "mentioned"
},
{
"author": "Huang-Wei",
"created_at": "2023-08-17 09:58:56",
"type": "subscribed"
},
{
"author": "Huang-Wei",
"created_at": "2023-08-17 09:58:57",
"type": "assigned"
},
{
"author": "alculquicondor",
"created_at": "2023-08-17 20:20:29",
"type": "mentioned"
},
{
"author": "alculquicondor",
"created_at": "2023-08-17 20:20:29",
"type": "subscribed"
},
{
"author": "mimowo",
"created_at": "2023-08-17 20:20:29",
"type": "mentioned"
},
{
"author": "mimowo",
"created_at": "2023-08-17 20:20:29",
"type": "subscribed"
},
{
"author": "alculquicondor",
"created_at": "2023-08-17 20:20:30",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 12:20:35",
"type": "labeled"
},
{
"author": "kwakubiney",
"created_at": "2023-08-18 13:10:47",
"type": "mentioned"
},
{
"author": "kwakubiney",
"created_at": "2023-08-18 13:10:47",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 11:13:23",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 11:13:23",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 11:13:23",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 11:13:25",
"type": "milestoned"
},
{
"author": "kwakubiney",
"created_at": "2023-08-21 14:05:29",
"type": "head_ref_deleted"
}
] |
119,970 | Automated cherry pick of #119761: Statefulset should wait for new replicas when removing | open | 2023-08-16 11:31:08 | 2023-08-16 13:23:04 | null | [
"bertinatto"
] | [
"area/test",
"lgtm",
"size/M",
"kind/flake",
"sig/apps",
"approved",
"cncf-cla: yes",
"sig/testing",
"priority/important-longterm",
"do-not-merge/release-note-label-needed",
"do-not-merge/cherry-pick-not-approved",
"triage/accepted"
] | soltysh | [
{
"body": "@soltysh: All 'parent' PRs of a cherry-pick PR must have one of the \"release-note\" or \"release-note-action-required\" labels, or this PR must follow the standard/parent release note labeling requirement.\n\n<details>\n\nThe following parent PRs have neither the \"release-note\" nor the \"release-note-action-required\" labels: #119761.\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 11:31:10"
},
{
"body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 11:31:11"
},
{
"body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 11:31:11"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119970#\" title=\"Author self-approved\">soltysh</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e/apps/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/test/e2e/apps/OWNERS)~~ [soltysh]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-16 11:31:46"
},
{
"body": "/kind flake\r\n/sig apps\r\n/sig testing",
"created_at": "2023-08-16 13:14:13"
},
{
"body": "/triage accepted\r\n/priority important-longterm",
"created_at": "2023-08-16 13:19:40"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 8865d2938380503cad55c296cf8b7d4eaae94c10</details>",
"created_at": "2023-08-16 13:19:50"
},
{
"body": "@kubernetes/release-managers this feature is beta since 1.27, but the tests were not run until https://github.com/kubernetes/kubernetes/pull/119761 to make sure we don't regress and also to fix already identified problems this PR has two fixes:\r\n1. drops `Feature:... ` tag to ensure it's being run in pre-submits\r\n2. fixes problems identified in CI.",
"created_at": "2023-08-16 13:23:04"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:31:10",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:31:10",
"type": "labeled"
},
{
"author": "soltysh",
"created_at": "2023-08-16 11:31:11",
"type": "mentioned"
},
{
"author": "soltysh",
"created_at": "2023-08-16 11:31:11",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:31:12",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:31:13",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:31:15",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:31:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:31:17",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:31:18",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:31:46",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:31:46",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:31:46",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:31:47",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:31:47",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:31:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 11:31:49",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:14:15",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:14:17",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:19:41",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:19:42",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:19:43",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:19:44",
"type": "unlabeled"
},
{
"author": "bertinatto",
"created_at": "2023-08-16 13:19:47",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:19:48",
"type": "labeled"
},
{
"author": "justaugustus",
"created_at": "2023-08-16 13:23:04",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-16 13:23:05",
"type": "subscribed"
},
{
"author": "Verolop",
"created_at": "2023-08-16 13:23:05",
"type": "subscribed"
},
{
"author": "puerco",
"created_at": "2023-08-16 13:23:05",
"type": "subscribed"
},
{
"author": "cpanato",
"created_at": "2023-08-16 13:23:05",
"type": "subscribed"
},
{
"author": "cici37",
"created_at": "2023-08-16 13:23:05",
"type": "subscribed"
},
{
"author": "palnabarun",
"created_at": "2023-08-16 13:23:05",
"type": "subscribed"
},
{
"author": "xmudrii",
"created_at": "2023-08-16 13:23:05",
"type": "subscribed"
},
{
"author": "k8s-release-robot",
"created_at": "2023-08-16 13:23:05",
"type": "subscribed"
},
{
"author": "jeremyrickard",
"created_at": "2023-08-16 13:23:05",
"type": "subscribed"
}
] |
119,969 | Update CNI plugins to v1.3.0 | closed | 2023-08-16 10:51:18 | 2023-08-24 07:01:16 | 2023-08-23 19:41:57 | [
"dims",
"cpanato",
"haircommander",
"SergeyKanzhelev",
"xmudrii"
] | [
"area/test",
"kind/cleanup",
"lgtm",
"area/provider/gcp",
"sig/node",
"release-note",
"size/S",
"approved",
"cncf-cla: yes",
"sig/testing",
"sig/cloud-provider",
"needs-priority",
"needs-triage"
] | saschagrunert | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 10:51:26"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 8b649727c3afd2ca8c6e1bcdcaed6136a0b97d56</details>",
"created_at": "2023-08-16 10:57:30"
},
{
"body": "Ran:\r\n\r\n```console\r\nkpromo gh --org containernetworking --repo plugins --bucket k8s-artifacts-cni --release-dir release --tags v1.3.0\r\n```\r\n\r\n/retest ",
"created_at": "2023-08-16 11:12:20"
},
{
"body": "/retest ",
"created_at": "2023-08-16 11:39:35"
},
{
"body": "/assign @haircommander ",
"created_at": "2023-08-16 17:25:19"
},
{
"body": "/retest",
"created_at": "2023-08-17 08:33:43"
},
{
"body": "@saschagrunert: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-local-e2e | 79333684600b81d6aab972a5e7d5e64aba17c6c0 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119969/pull-kubernetes-local-e2e/1692081687292284928/) | false | `/test pull-kubernetes-local-e2e`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119969). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Asaschagrunert). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"created_at": "2023-08-17 10:52:37"
},
{
"body": "/skip\r\n\r\nThis job does not look healthy: https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-local-e2e",
"created_at": "2023-08-17 10:59:43"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 6bbb9960426d88e35cee11df9444323154130597</details>",
"created_at": "2023-08-17 19:43:10"
},
{
"body": "/assign @dims",
"created_at": "2023-08-23 16:09:00"
},
{
"body": "/approve\r\n/lgtm",
"created_at": "2023-08-23 18:40:42"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119969#pullrequestreview-1580332119\" title=\"LGTM\">cpanato</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119969#issuecomment-1690455184\" title=\"LGTM\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119969#pullrequestreview-1581107650\" title=\"LGTM\">haircommander</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119969#\" title=\"Author self-approved\">saschagrunert</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119969#pullrequestreview-1583350741\" title=\"Approved\">SergeyKanzhelev</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119969#pullrequestreview-1591876840\" title=\"Approved\">xmudrii</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[build/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/build/OWNERS)~~ [dims]\n- ~~[cluster/gce/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/OWNERS)~~ [dims]\n- ~~[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/hack/OWNERS)~~ [dims]\n- ~~[test/e2e_node/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e_node/OWNERS)~~ [SergeyKanzhelev,dims]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-23 18:41:05"
}
] | [
{
"author": "justaugustus",
"created_at": "2023-08-16 10:51:19",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-16 10:51:19",
"type": "subscribed"
},
{
"author": "cici37",
"created_at": "2023-08-16 10:51:19",
"type": "subscribed"
},
{
"author": "salaxander",
"created_at": "2023-08-16 10:51:19",
"type": "subscribed"
},
{
"author": "palnabarun",
"created_at": "2023-08-16 10:51:19",
"type": "subscribed"
},
{
"author": "Verolop",
"created_at": "2023-08-16 10:51:19",
"type": "subscribed"
},
{
"author": "marosset",
"created_at": "2023-08-16 10:51:19",
"type": "subscribed"
},
{
"author": "ameukam",
"created_at": "2023-08-16 10:51:19",
"type": "subscribed"
},
{
"author": "xmudrii",
"created_at": "2023-08-16 10:51:19",
"type": "subscribed"
},
{
"author": "ramrodo",
"created_at": "2023-08-16 10:51:19",
"type": "subscribed"
},
{
"author": "k8s-release-robot",
"created_at": "2023-08-16 10:51:19",
"type": "subscribed"
},
{
"author": "puerco",
"created_at": "2023-08-16 10:51:19",
"type": "subscribed"
},
{
"author": "jeremyrickard",
"created_at": "2023-08-16 10:51:19",
"type": "subscribed"
},
{
"author": "cpanato",
"created_at": "2023-08-16 10:51:19",
"type": "subscribed"
},
{
"author": "gracenng",
"created_at": "2023-08-16 10:51:19",
"type": "subscribed"
},
{
"author": "jimangel",
"created_at": "2023-08-16 10:51:19",
"type": "subscribed"
},
{
"author": "jrsapi",
"created_at": "2023-08-16 10:51:19",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 10:51:20",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 10:51:20",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 10:51:20",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 10:51:23",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 10:51:25",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 10:51:25",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 10:51:27",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 10:52:03",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 10:52:03",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 10:52:15",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 10:52:15",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 10:52:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 10:52:17",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 10:52:17",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 10:52:18",
"type": "unlabeled"
},
{
"author": "cpanato",
"created_at": "2023-08-16 10:57:27",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 10:57:29",
"type": "labeled"
},
{
"author": "saschagrunert",
"created_at": "2023-08-16 11:09:30",
"type": "mentioned"
},
{
"author": "saschagrunert",
"created_at": "2023-08-16 11:09:30",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-16 11:21:08",
"type": "mentioned"
},
{
"author": "saschagrunert",
"created_at": "2023-08-16 11:21:08",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-16 11:28:24",
"type": "mentioned"
},
{
"author": "saschagrunert",
"created_at": "2023-08-16 11:28:24",
"type": "subscribed"
},
{
"author": "haircommander",
"created_at": "2023-08-16 17:25:19",
"type": "mentioned"
},
{
"author": "haircommander",
"created_at": "2023-08-16 17:25:19",
"type": "subscribed"
},
{
"author": "haircommander",
"created_at": "2023-08-16 17:25:20",
"type": "assigned"
},
{
"author": "saschagrunert",
"created_at": "2023-08-17 07:51:02",
"type": "head_ref_force_pushed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:51:04",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:51:05",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:51:05",
"type": "review_requested"
},
{
"author": "saschagrunert",
"created_at": "2023-08-17 08:17:51",
"type": "mentioned"
},
{
"author": "saschagrunert",
"created_at": "2023-08-17 08:17:51",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-17 08:23:40",
"type": "mentioned"
},
{
"author": "saschagrunert",
"created_at": "2023-08-17 08:23:40",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-17 10:52:38",
"type": "mentioned"
},
{
"author": "saschagrunert",
"created_at": "2023-08-17 10:52:38",
"type": "subscribed"
},
{
"author": "SergeyKanzhelev",
"created_at": "2023-08-17 19:43:08",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 19:43:09",
"type": "labeled"
},
{
"author": "xmudrii",
"created_at": "2023-08-23 15:30:16",
"type": "assigned"
},
{
"author": "dims",
"created_at": "2023-08-23 16:09:01",
"type": "mentioned"
},
{
"author": "dims",
"created_at": "2023-08-23 16:09:01",
"type": "subscribed"
},
{
"author": "dims",
"created_at": "2023-08-23 16:09:01",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-23 18:41:06",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-23 19:41:57",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-23 19:41:57",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-23 19:41:57",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-23 19:41:59",
"type": "milestoned"
},
{
"author": "saschagrunert",
"created_at": "2023-08-24 07:01:16",
"type": "head_ref_deleted"
}
] |
119,968 | Replace stat syscall with statx | open | 2023-08-16 09:13:50 | 2023-08-21 02:47:26 | null | [] | [
"kind/bug",
"sig/storage",
"size/M",
"cncf-cla: yes",
"needs-ok-to-test",
"do-not-merge/release-note-label-needed",
"needs-priority",
"needs-triage"
] | j4ckstraw | [
{
"body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 09:13:52"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 09:13:58"
},
{
"body": "Hi @j4ckstraw. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-16 09:13:59"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119968#\" title=\"Author self-approved\">j4ckstraw</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [jsafrane](https://github.com/jsafrane) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/mount-utils/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/mount-utils/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"jsafrane\"]} -->",
"created_at": "2023-08-16 09:14:47"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:13:52",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:13:52",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:13:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:13:55",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:13:57",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:13:58",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:13:58",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:13:59",
"type": "labeled"
},
{
"author": "j4ckstraw",
"created_at": "2023-08-16 09:14:00",
"type": "mentioned"
},
{
"author": "j4ckstraw",
"created_at": "2023-08-16 09:14:00",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:14:23",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:14:25",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:14:35",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:14:35",
"type": "review_requested"
},
{
"author": "j4ckstraw",
"created_at": "2023-08-16 09:14:45",
"type": "head_ref_force_pushed"
},
{
"author": "j4ckstraw",
"created_at": "2023-08-17 02:17:15",
"type": "head_ref_force_pushed"
},
{
"author": "j4ckstraw",
"created_at": "2023-08-21 02:47:24",
"type": "review_requested"
},
{
"author": "j4ckstraw",
"created_at": "2023-08-21 02:47:26",
"type": "review_requested"
}
] |
119,967 | Pod and pvc is pending after the node has been replaced to a new node | open | 2023-08-16 09:01:22 | 2023-08-17 03:39:36 | null | [
"Huang-Wei"
] | [
"kind/bug",
"sig/scheduling",
"sig/autoscaling",
"needs-triage"
] | lance5890 | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 09:01:31"
},
{
"body": "/sig scheduling\r\n/sig autoscaling",
"created_at": "2023-08-16 09:01:53"
},
{
"body": "/assign @Huang-Wei ",
"created_at": "2023-08-16 12:35:48"
},
{
"body": "maybe related to https://github.com/kubernetes/kubernetes/issues/119770",
"created_at": "2023-08-17 03:39:14"
},
{
"body": "/assign @sanposhiho",
"created_at": "2023-08-17 03:39:35"
}
] | [
{
"author": "lance5890",
"created_at": "2023-08-16 09:01:22",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:01:28",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:01:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:01:55",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:01:56",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:01:56",
"type": "unlabeled"
},
{
"author": "Huang-Wei",
"created_at": "2023-08-16 12:35:48",
"type": "mentioned"
},
{
"author": "Huang-Wei",
"created_at": "2023-08-16 12:35:49",
"type": "subscribed"
},
{
"author": "Huang-Wei",
"created_at": "2023-08-16 12:35:50",
"type": "assigned"
},
{
"author": "sanposhiho",
"created_at": "2023-08-17 01:47:50",
"type": "mentioned"
},
{
"author": "sanposhiho",
"created_at": "2023-08-17 01:47:50",
"type": "subscribed"
},
{
"author": "sanposhiho",
"created_at": "2023-08-17 03:39:36",
"type": "mentioned"
},
{
"author": "sanposhiho",
"created_at": "2023-08-17 03:39:36",
"type": "subscribed"
}
] |
119,966 | e2e framework util subtle bug checking endpoints | closed | 2023-08-16 08:19:53 | 2023-08-16 16:33:10 | 2023-08-16 16:33:09 | [
"pohly",
"liggitt"
] | [
"kind/bug",
"area/test",
"lgtm",
"size/XS",
"release-note-none",
"approved",
"cncf-cla: yes",
"sig/testing",
"needs-priority",
"area/e2e-test-framework",
"needs-triage"
] | aojea | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 08:20:01"
},
{
"body": "/assign @pohly @liggitt ",
"created_at": "2023-08-16 08:20:13"
},
{
"body": "/test pull-kubernetes-e2e-kind-dual-canary\r\n/test pull-kubernetes-e2e-kind-ipv6-canary\r\n/test pull-kubernetes-e2e-kind-ipvs-dual-canary",
"created_at": "2023-08-16 08:20:53"
},
{
"body": "@aojea: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-e2e-kind-ipv6-canary | 8314122382c4d642ac09b5c39c65eabc93a489c5 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119966/pull-kubernetes-e2e-kind-ipv6-canary/1691726718257074176) | false | `/test pull-kubernetes-e2e-kind-ipv6-canary`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119966). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Aaojea). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"created_at": "2023-08-16 08:56:12"
},
{
"body": "/lgtm\r\n/approve",
"created_at": "2023-08-16 13:15:40"
},
{
"body": "LGTM label has been added. <details>Git tree hash: ab5c5b56f6ce6876e169d72c1c5b878366c9fb7c</details>",
"created_at": "2023-08-16 13:15:46"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119966#\" title=\"Author self-approved\">aojea</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119966#issuecomment-1680586378\" title=\"Approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119966#pullrequestreview-1580156705\" title=\"Approved\">neolit123</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e/framework/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/framework/OWNERS)~~ [aojea,liggitt,neolit123]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-16 13:16:00"
},
{
"body": "include this in https://github.com/kubernetes/kubernetes/pull/119964 ?",
"created_at": "2023-08-16 13:16:14"
},
{
"body": "> include this in #119964 ?\r\n\r\nyeah, I noticed my mistake when doing the backport, wthat PR is on hold waiting for this to merge",
"created_at": "2023-08-16 13:18:59"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:19:55",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:19:55",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:19:55",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:19:58",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:20:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:20:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:20:02",
"type": "labeled"
},
{
"author": "pohly",
"created_at": "2023-08-16 08:20:13",
"type": "mentioned"
},
{
"author": "pohly",
"created_at": "2023-08-16 08:20:13",
"type": "subscribed"
},
{
"author": "liggitt",
"created_at": "2023-08-16 08:20:13",
"type": "mentioned"
},
{
"author": "liggitt",
"created_at": "2023-08-16 08:20:13",
"type": "subscribed"
},
{
"author": "liggitt",
"created_at": "2023-08-16 08:20:14",
"type": "assigned"
},
{
"author": "pohly",
"created_at": "2023-08-16 08:20:15",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:20:42",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:20:43",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:20:56",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:21:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:21:10",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:21:11",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:21:12",
"type": "unlabeled"
},
{
"author": "aojea",
"created_at": "2023-08-16 08:56:13",
"type": "mentioned"
},
{
"author": "aojea",
"created_at": "2023-08-16 08:56:13",
"type": "subscribed"
},
{
"author": "neolit123",
"created_at": "2023-08-16 09:12:07",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:12:08",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:12:32",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:12:32",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:12:33",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 09:12:33",
"type": "review_requested"
},
{
"author": "neolit123",
"created_at": "2023-08-16 09:12:40",
"type": "unassigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 13:15:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 16:33:09",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 16:33:09",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 16:33:09",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 16:33:11",
"type": "milestoned"
}
] |
119,965 | Fix ignore annotations in list when bat format exists in metadata | open | 2023-08-16 08:14:24 | 2023-08-18 03:00:35 | null | [
"deads2k"
] | [
"kind/bug",
"release-note",
"size/M",
"kind/api-change",
"sig/cli",
"cncf-cla: yes",
"needs-priority",
"needs-triage"
] | cwdsuzhou | [
{
"body": "<a href=\"https://easycla.lfx.linuxfoundation.org/#/?version=2\"><img src=\"https://s3.amazonaws.com/cla-project-logo-prod/cla-signed.svg\" alt=\"CLA Signed\" align=\"left\" height=\"28\" width=\"328\" ></a><br/><br />The committers listed above are authorized under a signed CLA.<ul><li>:white_check_mark: login: cwdsuzhou / name: Weidong Cai (908d1e2689cc9d2389c3406bb19ea359f63ede1f)</li></ul>",
"created_at": "2023-08-16 08:14:28"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 08:14:33"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119965#\" title=\"Author self-approved\">cwdsuzhou</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [deads2k](https://github.com/deads2k) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/apimachinery/pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/apis/OWNERS)**\n- **[staging/src/k8s.io/cli-runtime/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/cli-runtime/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"deads2k\"]} -->",
"created_at": "2023-08-16 08:15:29"
},
{
"body": "Thanks for fixing this.",
"created_at": "2023-08-16 09:00:18"
},
{
"body": "/retest",
"created_at": "2023-08-17 02:36:46"
},
{
"body": "@cwdsuzhou: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-node-e2e-containerd | 908d1e2689cc9d2389c3406bb19ea359f63ede1f | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119965/pull-kubernetes-node-e2e-containerd/1692002511575060480/) | true | `/test pull-kubernetes-node-e2e-containerd`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119965). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Acwdsuzhou). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"created_at": "2023-08-17 03:03:34"
},
{
"body": "/assign @deads2k ",
"created_at": "2023-08-18 03:00:02"
},
{
"body": "sliently ping @deads2k for review",
"created_at": "2023-08-18 03:00:35"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:27",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:27",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:27",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:34",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:15:03",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:15:03",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:15:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:15:17",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:15:18",
"type": "unlabeled"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 08:19:31",
"type": "head_ref_force_pushed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:19:36",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:19:37",
"type": "labeled"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 08:20:15",
"type": "renamed"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 08:24:28",
"type": "mentioned"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 08:24:28",
"type": "subscribed"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 08:25:55",
"type": "mentioned"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 08:25:55",
"type": "subscribed"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 08:27:06",
"type": "mentioned"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 08:27:06",
"type": "subscribed"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 08:27:10",
"type": "mentioned"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 08:27:10",
"type": "subscribed"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 08:28:11",
"type": "mentioned"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 08:28:11",
"type": "subscribed"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 08:28:55",
"type": "mentioned"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 08:28:56",
"type": "subscribed"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 08:30:10",
"type": "mentioned"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 08:30:10",
"type": "subscribed"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 08:30:53",
"type": "head_ref_force_pushed"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 09:07:44",
"type": "mentioned"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 09:07:44",
"type": "subscribed"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 10:30:22",
"type": "head_ref_force_pushed"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 10:59:21",
"type": "mentioned"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-16 10:59:21",
"type": "subscribed"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-17 03:03:34",
"type": "mentioned"
},
{
"author": "cwdsuzhou",
"created_at": "2023-08-17 03:03:35",
"type": "subscribed"
},
{
"author": "deads2k",
"created_at": "2023-08-18 03:00:03",
"type": "mentioned"
},
{
"author": "deads2k",
"created_at": "2023-08-18 03:00:03",
"type": "subscribed"
},
{
"author": "deads2k",
"created_at": "2023-08-18 03:00:05",
"type": "assigned"
},
{
"author": "deads2k",
"created_at": "2023-08-18 03:00:35",
"type": "mentioned"
},
{
"author": "deads2k",
"created_at": "2023-08-18 03:00:35",
"type": "subscribed"
}
] |
119,964 | Automated cherry pick of #119928: e2e WaitForServiceEndpointsNum take into account the address | open | 2023-08-16 08:14:07 | 2023-08-21 08:43:10 | null | [
"liggitt"
] | [
"kind/bug",
"area/test",
"lgtm",
"size/M",
"release-note-none",
"approved",
"cncf-cla: yes",
"sig/testing",
"kind/failing-test",
"do-not-merge/cherry-pick-not-approved",
"needs-priority",
"area/e2e-test-framework",
"needs-triage"
] | aojea | [
{
"body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 08:14:11"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 08:14:16"
},
{
"body": "/kind bug\r\n/kind failing-test\r\n/assign @liggitt ",
"created_at": "2023-08-16 08:14:28"
},
{
"body": "/sig testing",
"created_at": "2023-08-16 08:14:42"
},
{
"body": "/hold",
"created_at": "2023-08-16 08:15:44"
},
{
"body": "> /hold\r\n\r\n/hold cancel\r\n\r\nincorporated https://github.com/kubernetes/kubernetes/pull/119966",
"created_at": "2023-08-19 14:19:42"
},
{
"body": "/lgtm\r\n/approve ",
"created_at": "2023-08-19 14:42:38"
},
{
"body": "LGTM label has been added. <details>Git tree hash: f3220b96c35d8517b1efa17016426f74f527a56d</details>",
"created_at": "2023-08-19 14:42:44"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119964#\" title=\"Author self-approved\">aojea</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119964#issuecomment-1685015787\" title=\"Approved\">liggitt</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e/framework/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/test/e2e/framework/OWNERS)~~ [aojea,liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-19 14:42:44"
},
{
"body": "ping @kubernetes/release-managers ",
"created_at": "2023-08-19 14:55:05"
},
{
"body": "/retest-required",
"created_at": "2023-08-21 07:46:55"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:09",
"type": "labeled"
},
{
"author": "aojea",
"created_at": "2023-08-16 08:14:10",
"type": "mentioned"
},
{
"author": "aojea",
"created_at": "2023-08-16 08:14:10",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:10",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:11",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:14",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:15",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:17",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:22",
"type": "labeled"
},
{
"author": "liggitt",
"created_at": "2023-08-16 08:14:29",
"type": "mentioned"
},
{
"author": "liggitt",
"created_at": "2023-08-16 08:14:29",
"type": "subscribed"
},
{
"author": "liggitt",
"created_at": "2023-08-16 08:14:30",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:31",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:33",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:44",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:46",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:50",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:54",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:14:54",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:15:03",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:15:03",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:15:15",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:15:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:15:46",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-19 14:19:43",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-19 14:42:42",
"type": "labeled"
},
{
"author": "justaugustus",
"created_at": "2023-08-19 14:55:06",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-19 14:55:06",
"type": "subscribed"
},
{
"author": "Verolop",
"created_at": "2023-08-19 14:55:06",
"type": "subscribed"
},
{
"author": "puerco",
"created_at": "2023-08-19 14:55:06",
"type": "subscribed"
},
{
"author": "cpanato",
"created_at": "2023-08-19 14:55:06",
"type": "subscribed"
},
{
"author": "cici37",
"created_at": "2023-08-19 14:55:06",
"type": "subscribed"
},
{
"author": "palnabarun",
"created_at": "2023-08-19 14:55:07",
"type": "subscribed"
},
{
"author": "xmudrii",
"created_at": "2023-08-19 14:55:07",
"type": "subscribed"
},
{
"author": "k8s-release-robot",
"created_at": "2023-08-19 14:55:07",
"type": "subscribed"
},
{
"author": "jeremyrickard",
"created_at": "2023-08-19 14:55:07",
"type": "subscribed"
},
{
"author": "aojea",
"created_at": "2023-08-19 14:58:02",
"type": "mentioned"
},
{
"author": "aojea",
"created_at": "2023-08-19 14:58:02",
"type": "subscribed"
},
{
"author": "aojea",
"created_at": "2023-08-19 15:13:46",
"type": "mentioned"
},
{
"author": "aojea",
"created_at": "2023-08-19 15:13:46",
"type": "subscribed"
}
] |
119,963 | dra: scheduler_perf test case with multiple claims per pod | open | 2023-08-16 06:36:58 | 2023-08-25 13:57:19 | null | [] | [
"area/test",
"kind/cleanup",
"size/L",
"release-note-none",
"approved",
"cncf-cla: yes",
"sig/testing",
"do-not-merge/hold",
"needs-priority",
"needs-triage"
] | pohly | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 06:37:06"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119963#\" title=\"Author self-approved\">pohly</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/integration/scheduler_perf/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/integration/scheduler_perf/OWNERS)~~ [pohly]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-16 06:37:46"
},
{
"body": "/hold\r\n\r\nFor another approver.\r\n",
"created_at": "2023-08-17 08:11:30"
},
{
"body": "/test pull-kubernetes-linter-hints-eks\r\n\r\nJust a test...",
"created_at": "2023-08-24 05:26:38"
},
{
"body": "/test pull-kubernetes-linter-hints-eks\r\n",
"created_at": "2023-08-24 08:34:32"
},
{
"body": "/test pull-kubernetes-linter-hints-eks",
"created_at": "2023-08-24 08:55:38"
},
{
"body": "/test pull-kubernetes-linter-hints-eks",
"created_at": "2023-08-24 14:32:11"
},
{
"body": "/test pull-kubernetes-linter-hints-eks",
"created_at": "2023-08-24 17:51:52"
},
{
"body": "/test pull-kubernetes-linter-hints-eks",
"created_at": "2023-08-25 05:31:37"
},
{
"body": "/test pull-kubernetes-linter-hints-eks\r\n/test pull-kubernetes-verify-strict-lint\r\n",
"created_at": "2023-08-25 13:57:03"
},
{
"body": "/test pull-kubernetes-linter-hints",
"created_at": "2023-08-25 13:57:19"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:37:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:37:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:37:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:37:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:37:05",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:37:06",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:37:07",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:37:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:37:33",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:37:34",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:37:46",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:37:59",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:37:59",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 08:11:31",
"type": "labeled"
}
] |
119,962 | api: change list type for node lists in PodSchedulingContext | closed | 2023-08-16 06:31:10 | 2023-08-23 16:35:30 | 2023-08-23 16:35:28 | [
"liggitt",
"apelisse"
] | [
"kind/cleanup",
"lgtm",
"sig/api-machinery",
"size/S",
"kind/api-change",
"release-note-none",
"approved",
"cncf-cla: yes",
"area/code-generation",
"needs-priority",
"triage/accepted"
] | pohly | [
{
"body": "/retest\r\n",
"created_at": "2023-08-16 07:15:30"
},
{
"body": "is that list very large? How come you have such performance problems?",
"created_at": "2023-08-16 18:02:29"
},
{
"body": "Yes, those lists can be large. In the worst case, every node in the cluster is listed, up to the size limit of 128 entries.",
"created_at": "2023-08-17 08:08:07"
},
{
"body": "Wait, I still don't get what's big? 128 node names in a list is not a lot? Do you have a lot of objects? How big are they? How often are they updated?",
"created_at": "2023-08-17 15:49:57"
},
{
"body": "Plenty of them (one per pod), and updated potentially multiple times per pod. It simply adds up. If you want to reproduce, run `go test -timeout=0 -count=1 -cpuprofile cpuprofile.out -memprofile memprofile.out -bench=BenchmarkPerfScheduling/.*Claim.* -benchtime=1ns -run=xxx ./test/integration/scheduler_perf` (needs etcd in PATH) and check out the CPU profile.\r\n\r\nThis patch helps identify which object is being updated:\r\n```patch\r\ncommit 03cbf5fa5e9a1779e51682032c81cc6b1a504f56\r\nAuthor: Patrick Ohly <[email protected]>\r\nDate: Thu Aug 10 15:45:52 2023 +0200\r\n\r\n WIP: wrap Update calls to make them visible in pprof\r\n\r\ndiff --git a/pkg/registry/resource/podschedulingcontext/storage/storage.go b/pkg/registry/resource/podschedulingcontext/storage/storage.go\r\nindex 9dab4ef6e66..dbcf364427a 100644\r\n--- a/pkg/registry/resource/podschedulingcontext/storage/storage.go\r\n+++ b/pkg/registry/resource/podschedulingcontext/storage/storage.go\r\n@@ -37,6 +37,10 @@ type REST struct {\r\n *genericregistry.Store\r\n }\r\n \r\n+func (r *REST) Update(ctx context.Context, name string, objInfo rest.UpdatedObjectInfo, createValidation rest.ValidateObjectFunc, updateValidation rest.ValidateObjectUpdateFunc, forceAllowCreate bool, options *metav1.UpdateOptions) (runtime.Object, bool, error) {\r\n+ return r.Store.Update(ctx, name, objInfo, createValidation, updateValidation, true, options)\r\n+}\r\n+\r\n // NewREST returns a RESTStorage object that will work against PodSchedulingContext.\r\n func NewREST(optsGetter generic.RESTOptionsGetter) (*REST, *StatusREST, error) {\r\n store := &genericregistry.Store{\r\ndiff --git a/pkg/registry/resource/resourceclaim/storage/storage.go b/pkg/registry/resource/resourceclaim/storage/storage.go\r\nindex 5784c6e309c..efca3844ceb 100644\r\n--- a/pkg/registry/resource/resourceclaim/storage/storage.go\r\n+++ b/pkg/registry/resource/resourceclaim/storage/storage.go\r\n@@ -37,6 +37,10 @@ type REST struct {\r\n *genericregistry.Store\r\n }\r\n \r\n+func (r *REST) Update(ctx context.Context, name string, objInfo rest.UpdatedObjectInfo, createValidation rest.ValidateObjectFunc, updateValidation rest.ValidateObjectUpdateFunc, forceAllowCreate bool, options *metav1.UpdateOptions) (runtime.Object, bool, error) {\r\n+ return r.Store.Update(ctx, name, objInfo, createValidation, updateValidation, true, options)\r\n+}\r\n+\r\n // NewREST returns a RESTStorage object that will work against ResourceClaims.\r\n func NewREST(optsGetter generic.RESTOptionsGetter) (*REST, *StatusREST, error) {\r\n store := &genericregistry.Store{\r\n```",
"created_at": "2023-08-17 16:00:09"
},
{
"body": "/assign @apelisse \r\nThank you!\r\n/triage accepted",
"created_at": "2023-08-17 16:41:41"
},
{
"body": "Here's the flamegraph from pprof from master:\r\n\r\n\r\n\r\nThe two `Update` calls at the top are for PodSchedulingContext.Spec and PodSchedulingContext.Status. Both spend most of their time in `FieldManager.Update`.\r\n\r\n\r\n",
"created_at": "2023-08-18 07:18:19"
},
{
"body": "I mean, yeah, we know it's not free. I'm just curious if this is an early optimization or what problem you're trying to solve?",
"created_at": "2023-08-18 15:36:57"
},
{
"body": "> I'm just curious if this is an early optimization or what problem you're trying to solve?\r\n\r\nI am trying to increase the pod scheduling rate for pods which use [DRA](https://github.com/kubernetes/enhancements/issues/3063). Because I don't want to do premature optimizations, I looked at CPU profiles and pprof output to determine which code is actually worth optimizing.\r\n\r\nbenchstat confirms that this PR is a noticeable improvement. Besides the slight API break, I can't think of a reason why `listType:atomic` shouldn't be used. Can you?",
"created_at": "2023-08-18 16:22:04"
},
{
"body": "> Can you?\r\n\r\nNo I can't. If you saying that only on person ever edits this it's fine. But if you have to do it, I'm concerned someone else will do the same thing for the same reason when they shouldn't, so I'm careful with the precedent we're setting here (and the probable underlying concern).",
"created_at": "2023-08-18 16:24:08"
},
{
"body": "That makes sense. I'm not sure where it could be documented for developers, but choosing the \"right\" `listType` is trickier than I thought. There is https://kubernetes.io/docs/reference/using-api/server-side-apply/#merge-strategy, but it doesn't describe these performance implications. I guess it simply hasn't come up before?\r\n",
"created_at": "2023-08-18 16:28:49"
},
{
"body": "There is one comment about topology changes:\r\n> When the listType, mapType, or structType changes from map/set/granular to atomic, the whole list, map, or struct of existing objects will end-up being owned by actors who owned an element of these types. This means that any further change to these objects would cause a conflict.\r\n\r\nIs that then an API break? I remember that clients are expected to \"force\" apply, so this wouldn't be a problem, right?\r\n\r\nI'm just trying to figure out what the answer would be for other types. For DRA, the other arguments (alpha API, SSA not used) make this a non-issue.",
"created_at": "2023-08-18 16:32:19"
},
{
"body": "Yeah, I think that's fine. Clients will just have to force to update, which is already what would happen if it was atomic anyway.",
"created_at": "2023-08-18 17:28:08"
},
{
"body": "@apelisse: can I get an /lgtm from you or should I ask someone who is more familiar with DRA? @bart0sh knows DRA, but not the API implementation side of it.\r\n\r\n",
"created_at": "2023-08-18 20:34:27"
},
{
"body": "/lgtm",
"created_at": "2023-08-22 16:33:28"
},
{
"body": "LGTM label has been added. <details>Git tree hash: b5c3ccd1cffad96956b333620393a3721fdf3330</details>",
"created_at": "2023-08-22 16:33:34"
},
{
"body": "/assign @liggitt \r\n\r\nFor API approval.\r\n\r\n@apelisse already checked that changing the list type isn't really a breaking API change (in general, and in particular in this case).",
"created_at": "2023-08-23 07:08:21"
},
{
"body": "Just testing the new jobs...\r\n\r\n/test pull-kubernetes-linter-hints\r\n",
"created_at": "2023-08-23 11:29:54"
},
{
"body": "/test pull-kubernetes-verify-strict-lint",
"created_at": "2023-08-23 11:30:42"
},
{
"body": "/approve",
"created_at": "2023-08-23 14:32:33"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119962#issuecomment-1690076656\" title=\"Approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119962#\" title=\"Author self-approved\">pohly</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/api/OWNERS)~~ [liggitt]\n- ~~[pkg/generated/openapi/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/generated/openapi/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/OWNERS)~~ [liggitt]\n- ~~[staging/src/k8s.io/client-go/applyconfigurations/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/applyconfigurations/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-23 14:32:53"
},
{
"body": "/test pull-kubernetes-linter-hints-eks",
"created_at": "2023-08-23 15:42:05"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:31:11",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:31:12",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:31:12",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:31:12",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:31:14",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:31:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:31:17",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:31:18",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:31:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:31:54",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:31:56",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:32:22",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:32:22",
"type": "review_requested"
},
{
"author": "pohly",
"created_at": "2023-08-16 06:56:21",
"type": "mentioned"
},
{
"author": "pohly",
"created_at": "2023-08-16 06:56:22",
"type": "subscribed"
},
{
"author": "pohly",
"created_at": "2023-08-16 07:29:40",
"type": "mentioned"
},
{
"author": "pohly",
"created_at": "2023-08-16 07:29:40",
"type": "subscribed"
},
{
"author": "pohly",
"created_at": "2023-08-16 07:37:36",
"type": "mentioned"
},
{
"author": "pohly",
"created_at": "2023-08-16 07:37:37",
"type": "subscribed"
},
{
"author": "pohly",
"created_at": "2023-08-17 08:10:29",
"type": "head_ref_force_pushed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 08:10:31",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 08:10:32",
"type": "labeled"
},
{
"author": "apelisse",
"created_at": "2023-08-17 16:41:41",
"type": "mentioned"
},
{
"author": "apelisse",
"created_at": "2023-08-17 16:41:41",
"type": "subscribed"
},
{
"author": "apelisse",
"created_at": "2023-08-17 16:41:43",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:41:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:41:45",
"type": "unlabeled"
},
{
"author": "apelisse",
"created_at": "2023-08-18 20:34:28",
"type": "mentioned"
},
{
"author": "apelisse",
"created_at": "2023-08-18 20:34:28",
"type": "subscribed"
},
{
"author": "bart0sh",
"created_at": "2023-08-18 20:34:28",
"type": "mentioned"
},
{
"author": "bart0sh",
"created_at": "2023-08-18 20:34:28",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 16:33:33",
"type": "labeled"
},
{
"author": "liggitt",
"created_at": "2023-08-23 07:08:22",
"type": "mentioned"
},
{
"author": "liggitt",
"created_at": "2023-08-23 07:08:22",
"type": "subscribed"
},
{
"author": "apelisse",
"created_at": "2023-08-23 07:08:22",
"type": "mentioned"
},
{
"author": "apelisse",
"created_at": "2023-08-23 07:08:22",
"type": "subscribed"
},
{
"author": "liggitt",
"created_at": "2023-08-23 07:08:23",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-23 14:32:54",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-23 16:35:28",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-23 16:35:28",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-23 16:35:28",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-23 16:35:30",
"type": "milestoned"
}
] |
119,961 | [e2e_apimachinery] stop using deprecated framework.ExpectNotEqual | open | 2023-08-16 04:51:28 | 2023-08-23 06:37:19 | null | [
"pohly",
"jiahuif"
] | [
"area/test",
"kind/cleanup",
"sig/api-machinery",
"size/M",
"cncf-cla: yes",
"sig/testing",
"do-not-merge/release-note-label-needed",
"ok-to-test",
"needs-priority",
"triage/accepted"
] | bzsuni | [
{
"body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 04:51:30"
},
{
"body": "Hi @bzsuni. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-16 04:51:37"
},
{
"body": "/ok-to-test\r\n/assign\r\n/assign @pohly\r\n/triage accepted",
"created_at": "2023-08-17 16:43:01"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119961#\" title=\"Author self-approved\">bzsuni</a>*\n**Once this PR has been reviewed and has the lgtm label**, please ask for approval from [pohly](https://github.com/pohly). For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[test/e2e/apimachinery/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/apimachinery/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"pohly\"]} -->",
"created_at": "2023-08-22 02:06:10"
},
{
"body": "> Can you do this change in all of `test/e2e` and `test/e2e_node`? Then we only need to review one PR.\r\n\r\nThank you for your comment. I wanted to use the directory module to divide it. Is it more organized?",
"created_at": "2023-08-23 03:11:20"
},
{
"body": "It depends on owners, complexity and size. In this case the change is more related to SIG Testing than any individual SIG, therefore it makes more sense for me to review and approve. It's ~100 lines that need to be changed, which is manageable for a single PR.\r\n",
"created_at": "2023-08-23 06:37:18"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:51:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:51:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:51:31",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:51:33",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:51:35",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:51:36",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:51:36",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:51:37",
"type": "labeled"
},
{
"author": "bzsuni",
"created_at": "2023-08-16 04:51:37",
"type": "mentioned"
},
{
"author": "bzsuni",
"created_at": "2023-08-16 04:51:37",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:52:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:52:22",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:52:23",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:52:24",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:52:32",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:52:32",
"type": "review_requested"
},
{
"author": "pohly",
"created_at": "2023-08-17 16:43:01",
"type": "mentioned"
},
{
"author": "pohly",
"created_at": "2023-08-17 16:43:01",
"type": "subscribed"
},
{
"author": "jiahuif",
"created_at": "2023-08-17 16:43:02",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:43:02",
"type": "labeled"
},
{
"author": "pohly",
"created_at": "2023-08-17 16:43:02",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:43:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:43:03",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:43:04",
"type": "unlabeled"
},
{
"author": "bzsuni",
"created_at": "2023-08-17 17:09:03",
"type": "mentioned"
},
{
"author": "bzsuni",
"created_at": "2023-08-17 17:09:03",
"type": "subscribed"
},
{
"author": "bzsuni",
"created_at": "2023-08-17 17:35:57",
"type": "mentioned"
},
{
"author": "bzsuni",
"created_at": "2023-08-17 17:35:57",
"type": "subscribed"
},
{
"author": "bzsuni",
"created_at": "2023-08-22 02:05:26",
"type": "head_ref_force_pushed"
}
] |
119,960 | Pod stays in "OutOfpods" state on a scaled out node created by cluster autoscaler. | open | 2023-08-16 04:10:07 | 2023-08-16 17:50:53 | null | [] | [
"kind/bug",
"sig/node",
"triage/accepted"
] | abhijit-dev82 | [
{
"body": "/sig scheduling\r\n/sig autoscaling",
"created_at": "2023-08-16 04:11:44"
},
{
"body": "/remove-sig scheduling\r\n/remove-sig autoscaling\r\n/sig node\r\n/sig networking\r\n\r\nI think the fix here should be to make kube-proxy part of the Node readiness checks.",
"created_at": "2023-08-16 12:19:06"
},
{
"body": "@alculquicondor: The label(s) `sig/networking` cannot be applied, because the repository doesn't have them.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119960#issuecomment-1680500663):\n\n>/remove-sig scheduling\r\n>/remove-sig autoscaling\r\n>/sig node\r\n>/sig networking\r\n>\r\n>I think the fix here should be to make kube-proxy part of the Node readiness checks.\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 12:19:10"
},
{
"body": "> I think the fix here should be to make kube-proxy part of the Node readiness checks.\r\n\r\nbut is this cluster using kube-proxy as an static pod? the issue says this is a vsphere cluster with vmware OS, I thought those were using antrea ...\r\n\r\nwhat happens if there are more static pods?\r\nyou have to add all the static pods as part of the node readiness check, that will solve the scheduling problem but will impact the node startup readiness\r\n",
"created_at": "2023-08-16 12:49:01"
},
{
"body": "I see, thanks for the clarification.\r\n\r\nBut more generally, any static pod would cause problems to scheduling.\r\n\r\n> you have to add all the static pods as part of the node readiness check, that will solve the scheduling problem but will impact the node startup readiness\r\n\r\nBut can a node really be considered ready if the static pods are not ready?",
"created_at": "2023-08-16 14:21:28"
},
{
"body": "/triage accepted",
"created_at": "2023-08-16 17:50:49"
}
] | [
{
"author": "abhijit-dev82",
"created_at": "2023-08-16 04:10:07",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:10:14",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:10:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:11:46",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:11:47",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:11:47",
"type": "unlabeled"
},
{
"author": "abhijit-dev82",
"created_at": "2023-08-16 04:46:33",
"type": "renamed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:19:08",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:19:09",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 12:19:09",
"type": "unlabeled"
},
{
"author": "alculquicondor",
"created_at": "2023-08-16 12:19:10",
"type": "mentioned"
},
{
"author": "alculquicondor",
"created_at": "2023-08-16 12:19:10",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 17:50:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 17:50:52",
"type": "unlabeled"
}
] |
119,959 | e2e_apps: stop using deprecated framework.ExpectConsistOf | closed | 2023-08-16 03:52:42 | 2023-08-22 08:20:08 | 2023-08-22 08:20:06 | [
"pohly",
"smarterclayton",
"carlory"
] | [
"area/test",
"kind/cleanup",
"lgtm",
"size/XS",
"release-note-none",
"sig/apps",
"approved",
"cncf-cla: yes",
"sig/testing",
"ok-to-test",
"needs-priority",
"needs-triage"
] | ty-dc | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 03:52:51"
},
{
"body": "Hi @ty-dc. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-16 03:52:52"
},
{
"body": "/ok-to-test",
"created_at": "2023-08-18 07:41:43"
},
{
"body": "/retest-required",
"created_at": "2023-08-18 08:23:38"
},
{
"body": "/retest-required",
"created_at": "2023-08-22 04:22:35"
},
{
"body": "Can you do the same change in all of test/e2e? Then we won't have to deal with another PR which does the same thing elsewhere.",
"created_at": "2023-08-22 06:15:59"
},
{
"body": "/release-note-none",
"created_at": "2023-08-22 06:16:19"
},
{
"body": "> Can you do the same change in all of test/e2e? Then we won't have to deal with another PR which does the same thing elsewhere.\r\n\r\nI tried doing this, but it looks like ExpectConsistOf only exists in this one file.",
"created_at": "2023-08-22 06:20:02"
},
{
"body": "/lgtm\r\n\r\n/assign @smarterclayton @pohly ",
"created_at": "2023-08-22 06:33:43"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 500d843c19f70d696ae2f181b9dd2719e004218d</details>",
"created_at": "2023-08-22 06:33:50"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119959#pullrequestreview-1588778711\" title=\"Approved\">pohly</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119959#\" title=\"Author self-approved\">ty-dc</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e/apps/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/apps/OWNERS)~~ [pohly]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-22 08:18:35"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:52:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:52:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:52:46",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:52:47",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:52:49",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:52:50",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:52:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:52:52",
"type": "labeled"
},
{
"author": "ty-dc",
"created_at": "2023-08-16 03:52:52",
"type": "mentioned"
},
{
"author": "ty-dc",
"created_at": "2023-08-16 03:52:52",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:53:19",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:53:19",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:53:33",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:53:34",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:53:35",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:53:36",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 07:41:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 07:41:46",
"type": "unlabeled"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:09:12",
"type": "mentioned"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:09:12",
"type": "subscribed"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:09:41",
"type": "mentioned"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:09:41",
"type": "subscribed"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:09:50",
"type": "mentioned"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:09:50",
"type": "subscribed"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:11:50",
"type": "mentioned"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:11:50",
"type": "subscribed"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:11:53",
"type": "mentioned"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:11:53",
"type": "subscribed"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:38:27",
"type": "mentioned"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:38:27",
"type": "subscribed"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:53:45",
"type": "mentioned"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:53:45",
"type": "subscribed"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:56:55",
"type": "mentioned"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:56:55",
"type": "subscribed"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:58:14",
"type": "mentioned"
},
{
"author": "ty-dc",
"created_at": "2023-08-18 08:58:14",
"type": "subscribed"
},
{
"author": "ty-dc",
"created_at": "2023-08-22 03:18:08",
"type": "head_ref_force_pushed"
},
{
"author": "ty-dc",
"created_at": "2023-08-22 03:47:11",
"type": "mentioned"
},
{
"author": "ty-dc",
"created_at": "2023-08-22 03:47:11",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 06:16:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 06:16:21",
"type": "unlabeled"
},
{
"author": "pohly",
"created_at": "2023-08-22 06:33:43",
"type": "mentioned"
},
{
"author": "pohly",
"created_at": "2023-08-22 06:33:43",
"type": "subscribed"
},
{
"author": "smarterclayton",
"created_at": "2023-08-22 06:33:44",
"type": "mentioned"
},
{
"author": "smarterclayton",
"created_at": "2023-08-22 06:33:44",
"type": "subscribed"
},
{
"author": "pohly",
"created_at": "2023-08-22 06:33:44",
"type": "assigned"
},
{
"author": "smarterclayton",
"created_at": "2023-08-22 06:33:45",
"type": "assigned"
},
{
"author": "carlory",
"created_at": "2023-08-22 06:33:48",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 06:33:49",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 08:18:36",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 08:20:06",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 08:20:06",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 08:20:06",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 08:20:08",
"type": "milestoned"
}
] |
119,958 | Drop v1.26.0 API testdata | closed | 2023-08-16 03:24:59 | 2023-08-17 14:41:25 | 2023-08-17 14:41:23 | [
"liggitt"
] | [
"kind/cleanup",
"lgtm",
"size/XXL",
"release-note-none",
"approved",
"cncf-cla: yes",
"sig/testing",
"needs-priority",
"needs-triage"
] | SataQiu | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 03:25:08"
},
{
"body": "/sig testing",
"created_at": "2023-08-16 03:26:01"
},
{
"body": "/retest",
"created_at": "2023-08-16 11:15:20"
},
{
"body": "/assign @liggitt",
"created_at": "2023-08-17 04:08:59"
},
{
"body": "/lgtm\r\n/approve",
"created_at": "2023-08-17 13:11:55"
},
{
"body": "LGTM label has been added. <details>Git tree hash: c07de505c48e70d0c084337300f936b18a6a41c0</details>",
"created_at": "2023-08-17 13:12:01"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119958#issuecomment-1682262875\" title=\"Approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119958#\" title=\"Author self-approved\">SataQiu</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-17 13:12:19"
},
{
"body": "/test pull-kubernetes-unit",
"created_at": "2023-08-17 13:55:29"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:25:01",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:25:02",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:25:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:25:04",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:25:06",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:25:07",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:25:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:25:37",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:25:37",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:26:04",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:26:05",
"type": "unlabeled"
},
{
"author": "SataQiu",
"created_at": "2023-08-16 03:51:05",
"type": "mentioned"
},
{
"author": "SataQiu",
"created_at": "2023-08-16 03:51:05",
"type": "subscribed"
},
{
"author": "SataQiu",
"created_at": "2023-08-16 04:11:47",
"type": "mentioned"
},
{
"author": "SataQiu",
"created_at": "2023-08-16 04:11:47",
"type": "subscribed"
},
{
"author": "liggitt",
"created_at": "2023-08-17 04:09:00",
"type": "mentioned"
},
{
"author": "liggitt",
"created_at": "2023-08-17 04:09:00",
"type": "subscribed"
},
{
"author": "liggitt",
"created_at": "2023-08-17 04:09:01",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 13:12:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 13:12:20",
"type": "labeled"
},
{
"author": "SataQiu",
"created_at": "2023-08-17 13:49:13",
"type": "mentioned"
},
{
"author": "SataQiu",
"created_at": "2023-08-17 13:49:13",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 14:41:23",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 14:41:23",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 14:41:23",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 14:41:25",
"type": "milestoned"
}
] |
119,957 | Add v1.28.0 API testdata | closed | 2023-08-16 03:13:41 | 2023-08-19 04:31:22 | 2023-08-19 04:31:20 | [
"liggitt"
] | [
"area/test",
"kind/cleanup",
"lgtm",
"size/XXL",
"release-note-none",
"approved",
"cncf-cla: yes",
"sig/testing",
"needs-priority",
"needs-triage"
] | SataQiu | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 03:13:50"
},
{
"body": "/sig testing\r\n\r\n",
"created_at": "2023-08-16 03:25:48"
},
{
"body": "/retest",
"created_at": "2023-08-17 01:36:54"
},
{
"body": "/assign @liggitt ",
"created_at": "2023-08-17 04:08:42"
},
{
"body": "verified the content of the v1.28.0 folder matches the content of the HEAD folder at the v1.28.0 tag\r\n\r\n/lgtm\r\n/approve",
"created_at": "2023-08-17 13:13:40"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 8928c7e5e42a510979ae5977d66aca064e4d6d9e</details>",
"created_at": "2023-08-17 13:13:46"
},
{
"body": "/hold\r\n\r\nlooking at the etcd test change",
"created_at": "2023-08-17 13:14:32"
},
{
"body": "rebased #120018\r\nPlease take a look @liggitt ",
"created_at": "2023-08-18 14:47:01"
},
{
"body": "/lgtm\r\n/approve",
"created_at": "2023-08-18 14:51:41"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 258bb5710499205248dfdc22f8147e3fc3ce43e6</details>",
"created_at": "2023-08-18 14:51:48"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119957#issuecomment-1684035964\" title=\"Approved\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119957#\" title=\"Author self-approved\">SataQiu</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/OWNERS)~~ [liggitt]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-18 14:52:06"
},
{
"body": "/hold cancel",
"created_at": "2023-08-18 14:54:16"
},
{
"body": "/test pull-kubernetes-integration",
"created_at": "2023-08-19 02:21:41"
},
{
"body": "/assign @liggitt ",
"created_at": "2023-08-19 02:56:29"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:13:44",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:13:44",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:13:46",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:13:46",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:13:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:13:49",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:13:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:14:40",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:14:40",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:25:50",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 03:25:52",
"type": "unlabeled"
},
{
"author": "SataQiu",
"created_at": "2023-08-16 03:40:43",
"type": "mentioned"
},
{
"author": "SataQiu",
"created_at": "2023-08-16 03:40:43",
"type": "subscribed"
},
{
"author": "SataQiu",
"created_at": "2023-08-16 04:12:30",
"type": "mentioned"
},
{
"author": "SataQiu",
"created_at": "2023-08-16 04:12:30",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:10:30",
"type": "labeled"
},
{
"author": "SataQiu",
"created_at": "2023-08-16 15:35:59",
"type": "mentioned"
},
{
"author": "SataQiu",
"created_at": "2023-08-16 15:35:59",
"type": "subscribed"
},
{
"author": "SataQiu",
"created_at": "2023-08-16 16:06:26",
"type": "mentioned"
},
{
"author": "SataQiu",
"created_at": "2023-08-16 16:06:26",
"type": "subscribed"
},
{
"author": "liggitt",
"created_at": "2023-08-17 04:08:42",
"type": "mentioned"
},
{
"author": "liggitt",
"created_at": "2023-08-17 04:08:42",
"type": "subscribed"
},
{
"author": "liggitt",
"created_at": "2023-08-17 04:08:43",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 13:13:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 13:14:06",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 13:14:34",
"type": "labeled"
},
{
"author": "SataQiu",
"created_at": "2023-08-18 14:45:32",
"type": "head_ref_force_pushed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 14:45:35",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 14:45:35",
"type": "review_requested"
},
{
"author": "liggitt",
"created_at": "2023-08-18 14:47:02",
"type": "mentioned"
},
{
"author": "liggitt",
"created_at": "2023-08-18 14:47:02",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 14:51:46",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-18 14:54:17",
"type": "unlabeled"
},
{
"author": "SataQiu",
"created_at": "2023-08-18 15:45:01",
"type": "mentioned"
},
{
"author": "SataQiu",
"created_at": "2023-08-18 15:45:02",
"type": "subscribed"
},
{
"author": "liggitt",
"created_at": "2023-08-19 02:56:30",
"type": "mentioned"
},
{
"author": "liggitt",
"created_at": "2023-08-19 02:56:30",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-19 04:31:20",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-19 04:31:20",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-19 04:31:20",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-19 04:31:22",
"type": "milestoned"
}
] |
119,956 | status.reason and status.message can be copied between different pod phases by kubelet | open | 2023-08-16 01:29:54 | 2023-08-16 18:12:21 | null | [] | [
"kind/bug",
"sig/node",
"triage/needs-information",
"needs-triage"
] | mlowery | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 01:30:02"
},
{
"body": "/sig node\r\n",
"created_at": "2023-08-16 01:32:07"
},
{
"body": "/triage needs-information\r\n\r\nIs this reproducible in >= 1.25 versions? And what does soft admit handler do? Could you please link to the doc?",
"created_at": "2023-08-16 17:54:15"
},
{
"body": "> Is this reproducible in >= 1.25 versions?\r\n\r\nI do not know. But checking the latest [code](https://github.com/kubernetes/kubernetes/blob/18290bfdc8fbe12921c7558c2fab1bb1447d07b5/pkg/kubelet/kubelet_pods.go#L1683-L1693) (the code I added logging to) shows it to be unchanged.\r\n\r\n> And what does soft admit handler do? Could you please link to the doc?\r\n\r\nI don't believe there is user-facing doc. It's a mechanism to stall or indefinitely delay the running of pods already scheduled and admitted to the node. Function `canRunPod`, which runs on every `syncPod` call, consults the soft admit handlers.",
"created_at": "2023-08-16 18:12:21"
}
] | [
{
"author": "mlowery",
"created_at": "2023-08-16 01:29:54",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 01:30:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 01:30:02",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 01:32:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 01:32:10",
"type": "unlabeled"
},
{
"author": "mlowery",
"created_at": "2023-08-16 16:23:30",
"type": "renamed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 17:54:17",
"type": "labeled"
}
] |
119,955 | Kubernetes 1.28 builds fail on Fedora 38, 39, and 40 (rawhide) | closed | 2023-08-15 22:37:21 | 2023-08-17 16:20:48 | 2023-08-17 14:39:52 | [] | [
"kind/bug",
"sig/release",
"needs-triage"
] | buckaroogeek | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-15 22:37:30"
},
{
"body": "Official Kubernetes packages are available from pkgs.k8s.io\r\n\r\nDo the `.spec` files from within https://github.com/kubernetes/release/tree/master/cmd/kubepkg/templates/latest/rpm work OK?",
"created_at": "2023-08-15 23:11:06"
},
{
"body": "It appears that the spec files from https://github.com/kubernetes/release/tree/master/cmd/kubepkg/templates/latest/rpm package up a prebuilt binary with associated configuration files. This is unlike the spec file used by Fedora which builds the target binaries with the version of golang each Fedora release includes. It will take some time to try one of these spec files but I do not see anything unusual so do not expect issues.\r\n\r\nIt could well be that something in the Fedora golang configuration or use of Kubernetes build tools in the spec file is the root cause. \r\n\r\nThese build error showed up in the ncpu routine that is new in 1.28.\r\n",
"created_at": "2023-08-15 23:29:43"
},
{
"body": "I recommend filing an issue against Fedora. So far as I know, the Kubernetes project does not maintain the Fedora package build code.",
"created_at": "2023-08-16 08:17:21"
},
{
"body": "Yeah, I assume the value of `GOPROXY` is not parsable in rawhide since they use go 1.21, we're still on 1.20.7:\r\n\r\nhttps://github.com/kubernetes/kubernetes/blob/b51ad13bf74bb65d2b2aa02e5d1c3c66eb7ff7c8/.go-version#L1\r\n\r\nThe other issue seems to be related to https://github.com/kubernetes/kubernetes/issues/119768",
"created_at": "2023-08-16 09:42:44"
},
{
"body": "> Yeah, I assume the value of GOPROXY is not parsable in rawhide since they use go 1.21, we're still on 1.20.7:\r\n\r\nthat doesn't make sense to me... go1.21 should honor any GOPROXY setting go1.20.x did, right?",
"created_at": "2023-08-16 13:21:38"
},
{
"body": "> > Yeah, I assume the value of GOPROXY is not parsable in rawhide since they use go 1.21, we're still on 1.20.7:\r\n> \r\n> that doesn't make sense to me... go1.21 should honor any GOPROXY setting go1.20.x did, right?\r\n\r\n@buckaroogeek can we get the value of `GOPROXY` within the rawhide build env? ",
"created_at": "2023-08-16 13:40:40"
},
{
"body": "I think the GOPROXY message is confusing, but might just be saying it was set in a way to disallow network fetches (non-empty, but doesn't contain entries). This is likely a duplicate of https://github.com/kubernetes/kubernetes/issues/119768, and would be resolved by https://github.com/kubernetes/kubernetes/pull/119977 (and the 1.28 cherry-pick - https://github.com/kubernetes/kubernetes/pull/119982)",
"created_at": "2023-08-16 13:43:13"
},
{
"body": "I am working with the Fedora go-sig and learned that the golang 1.21 package had dropped the go.env file by mistake so they rebuilt the package which will show up in rawhide sometime today. I will update this issue when the update comes through.\r\n\r\nInterestingly, I manually added export GOPROXY=https://proxy.golang.org,direct in the spec file. I sill get an error in the ncpu code but the message changed to:\r\n\r\n```\r\n+ GO111MODULE=on\r\n+ go install ./ncpu\r\ngo: downloading go.uber.org/automaxprocs v1.5.2\r\nncpu/main.go:23:2: go.uber.org/[email protected]: Get \"https://proxy.golang.org/go.uber.org/automaxprocs/@v/v1.5.2.zip\": dial tcp: lookup proxy.golang.org on [::1]:53: read udp [::1]:43710->[::1]:53: read: connection refused\r\n++ kube::log::errexit\r\n\r\n```\r\nIt seems like an IPv6 DNS lookup is being attempted and refused (no ipv6 on this workstation)? I can ```wget https://proxy.golang.org/go.uber.org/automaxprocs/@v/v1.5.2.zip``` without any problem.\r\n\r\nI will also note that I am on the team maintaining the Kubernetes rpm packages for Fedora.",
"created_at": "2023-08-16 14:26:11"
},
{
"body": "> It seems like an IPv6 DNS lookup is being attempted and refused (no ipv6 on this workstation)? I can `wget https://proxy.golang.org/go.uber.org/automaxprocs/@v/v1.5.2.zip` without any problem.\r\n> \r\n\r\nJust speculation. Should the go.uber.org/automaxprocs code be included in the ./vendor subdirectory? \r\n\r\n",
"created_at": "2023-08-16 15:49:27"
},
{
"body": "> Should the go.uber.org/automaxprocs code be included in the ./vendor subdirectory?\r\n\r\nno, `vendor` is for code that actually gets built/linked into released binaries\r\n\r\nthis module is only used to build an optional utility used to set up the environment when running some tests. https://github.com/kubernetes/kubernetes/pull/119977 and the [1.28 cherry-pick](https://github.com/kubernetes/kubernetes/pull/119982) will resolve the issue ",
"created_at": "2023-08-16 15:57:24"
},
{
"body": "/sig release\r\n",
"created_at": "2023-08-17 12:05:37"
},
{
"body": "https://github.com/kubernetes/kubernetes/pull/119982 is merged so HEAD of release-1.28 will build without trying to install this tool",
"created_at": "2023-08-17 14:39:49"
},
{
"body": "Thanks to all for the quick review and response. Much appreciated.\r\n\r\nbest regards",
"created_at": "2023-08-17 15:10:02"
},
{
"body": "> It is important to note that the spec file sets `export FORCE_HOST_GO=y`. Fedora 40/39 current provide golang 1.21.0; Fedora 38 provides golang 1.20.7.\r\n\r\nI will note that building Kubernetes on go minor versions other than what is tested is not really something I would recommend (other / latest go *patch* is fine). Kubernetes stays on supported go minor versions now, and will update the release-1.28 branch to go1.21 in the future once soak criteria are met.",
"created_at": "2023-08-17 15:44:21"
},
{
"body": "Thanks for the insights. The current spec file used to build the Kubernetes binaries in Fedora uses a ```BuildRequires``` setting to set the version of Go used in the build. For example:\r\n\r\n```\r\nBuildRequires: golang >= 1.20.7\r\n```\r\n\r\nThe value set is always equal to the 'built with' note in the Kubernetes change log. If the Fedora release has a newer version of Go (e.g. Go 1.21) then the maintainer has to make sure that the minor release present in Fedora contains the changes present in the 'built with' minor release. (hope I am being clear). ",
"created_at": "2023-08-17 16:20:47"
}
] | [
{
"author": "buckaroogeek",
"created_at": "2023-08-15 22:37:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 22:37:27",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 22:37:29",
"type": "labeled"
},
{
"author": "buckaroogeek",
"created_at": "2023-08-16 13:40:41",
"type": "mentioned"
},
{
"author": "buckaroogeek",
"created_at": "2023-08-16 13:40:41",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 12:05:38",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 12:05:40",
"type": "unlabeled"
},
{
"author": "liggitt",
"created_at": "2023-08-17 14:39:52",
"type": "closed"
}
] |
119,954 | applying a manifest with a null label TWICE results in different behaviour each time | closed | 2023-08-15 20:42:58 | 2023-08-16 18:53:22 | 2023-08-16 18:53:21 | [
"HirazawaUi"
] | [
"kind/bug",
"sig/api-machinery",
"triage/accepted"
] | rsalmond | [
{
"body": "/sig api-machinery\r\n/assign ",
"created_at": "2023-08-16 04:28:50"
},
{
"body": "Based on the comments in the [mergeMap](https://github.com/kubernetes/kubernetes/blob/63351cce1c1099c64c6c55d540b1e65e947632ad/staging/src/k8s.io/apimachinery/pkg/util/strategicpatch/patch.go#L1360-L1365), this seems to be the expected result\r\n\r\n@apelisse I'm not sure if this is a bug or not, but it does cause our results to be inconsistent between the twice apply, was that a conscious decision?",
"created_at": "2023-08-16 15:51:43"
},
{
"body": "I would think it was not. Most things in strategic-merge-patch were not conscious decision. I'll take a quick look.",
"created_at": "2023-08-16 15:59:16"
},
{
"body": "I want to see what happens if you run `kubectl apply` one more time. In json-merge-patch, which smp is inspired from, a null value (and in your example, your yaml is equivalent to `baz: null`) means that the field should be removed. The problem here is that you first have a `CREATE` request with the yaml, the null is deserialized as an empty string in the labels. And the second time, you have a PATCH using SMP, the null is interpreted as delete. What happens if you SMP with null again? I guess it's going to do nothing. I don't think there's anything to fix here.\r\n/triage accepted",
"created_at": "2023-08-16 16:05:21"
},
{
"body": "> What happens if you SMP with null again?\r\n\r\nJust tried it 3x, you're correct, the result stays the same.\r\n\r\n``` console\r\n$ k get po colorful -ojson | jq '.metadata.labels'\r\n{\r\n \"foo\": \"bar\"\r\n}\r\n```",
"created_at": "2023-08-16 16:22:29"
},
{
"body": "Interestingly, it says \"configured\" _every_ time.\r\n\r\n``` console\r\n$ k apply -f pod.yaml\r\npod/colorful configured\r\n\r\n$ k apply -f pod.yaml\r\npod/colorful configured\r\n\r\n$ k apply -f pod.yaml\r\npod/colorful configured\r\n```\r\n",
"created_at": "2023-08-16 16:23:22"
},
{
"body": "> Interestingly, it says \"configured\" every time.\r\n\r\nYeah, unsurprising to me. To kubectl, it looks like something needs to happen (it needs to send `baz: null`) and the \"configured\" logic is basically that simple (and inaccurate).\r\n\r\nI'm sorry but I don't think there's a bug worth fixing here :-(\r\n/close",
"created_at": "2023-08-16 18:53:17"
},
{
"body": "@apelisse: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119954#issuecomment-1681117813):\n\n>> Interestingly, it says \"configured\" every time.\r\n>\r\n>Yeah, unsurprising to me. To kubectl, it looks like something needs to happen (it needs to send `baz: null`) and the \"configured\" logic is basically that simple (and inaccurate).\r\n>\r\n>I'm sorry but I don't think there's a bug worth fixing here :-(\r\n>/close\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-16 18:53:22"
}
] | [
{
"author": "rsalmond",
"created_at": "2023-08-15 20:42:58",
"type": "labeled"
},
{
"author": "rdoherty-fastly",
"created_at": "2023-08-15 20:42:59",
"type": "mentioned"
},
{
"author": "rdoherty-fastly",
"created_at": "2023-08-15 20:42:59",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:46:05",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:46:07",
"type": "labeled"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-16 04:28:52",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:28:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 04:28:54",
"type": "unlabeled"
},
{
"author": "apelisse",
"created_at": "2023-08-16 15:51:43",
"type": "mentioned"
},
{
"author": "apelisse",
"created_at": "2023-08-16 15:51:43",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 16:05:23",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 16:05:24",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 18:53:21",
"type": "closed"
},
{
"author": "apelisse",
"created_at": "2023-08-16 18:53:22",
"type": "mentioned"
},
{
"author": "apelisse",
"created_at": "2023-08-16 18:53:22",
"type": "subscribed"
}
] |
119,953 | Automated cherry pick of #119778: fix: when PreFilter returns UnschedulableAndUnresolvable, copy the state in all nodes in statusmap | open | 2023-08-15 13:32:25 | 2023-08-16 07:13:58 | null | [
"Huang-Wei"
] | [
"kind/bug",
"sig/scheduling",
"lgtm",
"release-note",
"size/L",
"approved",
"cncf-cla: yes",
"do-not-merge/cherry-pick-not-approved",
"needs-priority",
"kind/regression",
"needs-triage"
] | sanposhiho | [
{
"body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-15 13:32:27"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-15 13:32:34"
},
{
"body": "/kind bug\r\n/kind regression",
"created_at": "2023-08-15 13:35:37"
},
{
"body": "/lgtm\r\n/approve\r\n\r\n/cc @kubernetes/release-managers ",
"created_at": "2023-08-16 07:13:31"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 5795606397d8135c28e28b6cba3452c0585f1507</details>",
"created_at": "2023-08-16 07:13:39"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119953#issuecomment-1680084334\" title=\"Approved\">Huang-Wei</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119953#\" title=\"Author self-approved\">sanposhiho</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/scheduler/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/pkg/scheduler/OWNERS)~~ [Huang-Wei]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-16 07:13:57"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:32:26",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:32:27",
"type": "milestoned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:32:27",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:32:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:32:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:32:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:32:33",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:32:34",
"type": "labeled"
},
{
"author": "sanposhiho",
"created_at": "2023-08-15 13:32:38",
"type": "renamed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:32:47",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:34:00",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:34:00",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:34:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:34:02",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:35:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:35:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:35:41",
"type": "unlabeled"
},
{
"author": "justaugustus",
"created_at": "2023-08-16 07:13:31",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-16 07:13:32",
"type": "subscribed"
},
{
"author": "Verolop",
"created_at": "2023-08-16 07:13:32",
"type": "subscribed"
},
{
"author": "puerco",
"created_at": "2023-08-16 07:13:32",
"type": "subscribed"
},
{
"author": "cpanato",
"created_at": "2023-08-16 07:13:32",
"type": "subscribed"
},
{
"author": "cici37",
"created_at": "2023-08-16 07:13:32",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:13:32",
"type": "review_requested"
},
{
"author": "palnabarun",
"created_at": "2023-08-16 07:13:32",
"type": "subscribed"
},
{
"author": "xmudrii",
"created_at": "2023-08-16 07:13:32",
"type": "subscribed"
},
{
"author": "k8s-release-robot",
"created_at": "2023-08-16 07:13:32",
"type": "subscribed"
},
{
"author": "jeremyrickard",
"created_at": "2023-08-16 07:13:32",
"type": "subscribed"
},
{
"author": "Huang-Wei",
"created_at": "2023-08-16 07:13:36",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:13:37",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:13:58",
"type": "labeled"
}
] |
119,952 | Automated cherry pick of #119778: fix: when PreFilter returns UnschedulableAndUnresolvable, copy the state in all nodes in statusmap | open | 2023-08-15 13:30:47 | 2023-08-16 07:12:58 | null | [
"Huang-Wei"
] | [
"kind/bug",
"sig/scheduling",
"lgtm",
"release-note",
"size/L",
"approved",
"cncf-cla: yes",
"do-not-merge/cherry-pick-not-approved",
"needs-priority",
"kind/regression",
"needs-triage"
] | sanposhiho | [
{
"body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-15 13:30:50"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-15 13:30:56"
},
{
"body": "/kind bug\r\n/kind regression",
"created_at": "2023-08-15 13:35:32"
},
{
"body": "/lgtm\r\n\r\n/cc @kubernetes/release-managers ",
"created_at": "2023-08-16 07:12:44"
},
{
"body": "/approve",
"created_at": "2023-08-16 07:12:51"
},
{
"body": "LGTM label has been added. <details>Git tree hash: aedcc63d9ea45fce1c9b0e852587998a87ff2259</details>",
"created_at": "2023-08-16 07:12:51"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119952#issuecomment-1680083542\" title=\"Approved\">Huang-Wei</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119952#\" title=\"Author self-approved\">sanposhiho</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/scheduler/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/pkg/scheduler/OWNERS)~~ [Huang-Wei]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-16 07:12:57"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:30:49",
"type": "milestoned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:30:49",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:30:49",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:30:52",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:30:54",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:30:55",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:30:56",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:30:57",
"type": "labeled"
},
{
"author": "sanposhiho",
"created_at": "2023-08-15 13:31:04",
"type": "renamed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:31:15",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:31:23",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:31:23",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:31:24",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:31:25",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:35:34",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:35:35",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:35:36",
"type": "unlabeled"
},
{
"author": "justaugustus",
"created_at": "2023-08-16 07:12:45",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-16 07:12:45",
"type": "subscribed"
},
{
"author": "Verolop",
"created_at": "2023-08-16 07:12:45",
"type": "subscribed"
},
{
"author": "puerco",
"created_at": "2023-08-16 07:12:45",
"type": "subscribed"
},
{
"author": "cpanato",
"created_at": "2023-08-16 07:12:45",
"type": "subscribed"
},
{
"author": "cici37",
"created_at": "2023-08-16 07:12:45",
"type": "subscribed"
},
{
"author": "palnabarun",
"created_at": "2023-08-16 07:12:45",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:12:46",
"type": "review_requested"
},
{
"author": "xmudrii",
"created_at": "2023-08-16 07:12:46",
"type": "subscribed"
},
{
"author": "k8s-release-robot",
"created_at": "2023-08-16 07:12:46",
"type": "subscribed"
},
{
"author": "jeremyrickard",
"created_at": "2023-08-16 07:12:46",
"type": "subscribed"
},
{
"author": "Huang-Wei",
"created_at": "2023-08-16 07:12:49",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:12:50",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:12:58",
"type": "labeled"
}
] |
119,951 | Automated cherry pick of #119778: fix: when PreFilter returns UnschedulableAndUnresolvable, copy the state in all nodes in statusmap | open | 2023-08-15 13:26:43 | 2023-08-16 07:12:39 | null | [
"Huang-Wei"
] | [
"kind/bug",
"sig/scheduling",
"lgtm",
"release-note",
"size/L",
"approved",
"cncf-cla: yes",
"do-not-merge/cherry-pick-not-approved",
"needs-priority",
"kind/regression",
"needs-triage"
] | sanposhiho | [
{
"body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-15 13:26:46"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-15 13:26:52"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119951#\" title=\"Author self-approved\">sanposhiho</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/scheduler/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/pkg/scheduler/OWNERS)~~ [sanposhiho]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-15 13:27:19"
},
{
"body": "/kind bug\r\n/kind regression",
"created_at": "2023-08-15 13:35:30"
},
{
"body": "/lgtm\r\n\r\n/cc @kubernetes/release-managers ",
"created_at": "2023-08-16 07:09:42"
},
{
"body": "LGTM label has been added. <details>Git tree hash: fcc8be5825087076280ba3e09c3657a6cde50b3c</details>",
"created_at": "2023-08-16 07:09:49"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:26:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:26:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:26:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:26:50",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:26:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:26:52",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:26:53",
"type": "labeled"
},
{
"author": "sanposhiho",
"created_at": "2023-08-15 13:27:18",
"type": "renamed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:27:18",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:27:19",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:27:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:27:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:27:20",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:27:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:35:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:35:33",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 13:35:33",
"type": "unlabeled"
},
{
"author": "justaugustus",
"created_at": "2023-08-16 07:09:43",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-16 07:09:43",
"type": "subscribed"
},
{
"author": "Verolop",
"created_at": "2023-08-16 07:09:43",
"type": "subscribed"
},
{
"author": "puerco",
"created_at": "2023-08-16 07:09:43",
"type": "subscribed"
},
{
"author": "cpanato",
"created_at": "2023-08-16 07:09:43",
"type": "subscribed"
},
{
"author": "cici37",
"created_at": "2023-08-16 07:09:43",
"type": "subscribed"
},
{
"author": "palnabarun",
"created_at": "2023-08-16 07:09:43",
"type": "subscribed"
},
{
"author": "xmudrii",
"created_at": "2023-08-16 07:09:43",
"type": "subscribed"
},
{
"author": "k8s-release-robot",
"created_at": "2023-08-16 07:09:44",
"type": "subscribed"
},
{
"author": "jeremyrickard",
"created_at": "2023-08-16 07:09:44",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:09:44",
"type": "review_requested"
},
{
"author": "Huang-Wei",
"created_at": "2023-08-16 07:09:47",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:09:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:10:22",
"type": "milestoned"
},
{
"author": "justaugustus",
"created_at": "2023-08-16 07:12:10",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-16 07:12:11",
"type": "subscribed"
},
{
"author": "Verolop",
"created_at": "2023-08-16 07:12:11",
"type": "subscribed"
},
{
"author": "puerco",
"created_at": "2023-08-16 07:12:11",
"type": "subscribed"
},
{
"author": "cpanato",
"created_at": "2023-08-16 07:12:11",
"type": "subscribed"
},
{
"author": "cici37",
"created_at": "2023-08-16 07:12:11",
"type": "subscribed"
},
{
"author": "palnabarun",
"created_at": "2023-08-16 07:12:11",
"type": "subscribed"
},
{
"author": "xmudrii",
"created_at": "2023-08-16 07:12:11",
"type": "subscribed"
},
{
"author": "k8s-release-robot",
"created_at": "2023-08-16 07:12:11",
"type": "subscribed"
},
{
"author": "jeremyrickard",
"created_at": "2023-08-16 07:12:11",
"type": "subscribed"
}
] |
119,950 | Explain why API server cache doesn't support multi index trigger functions | closed | 2023-08-15 11:55:38 | 2023-08-24 02:00:49 | 2023-08-24 02:00:49 | [
"wojtek-t"
] | [
"area/apiserver",
"sig/api-machinery",
"triage/accepted"
] | Sakuralbj | [
{
"body": "/retitle Explain why API server cache doesn't support multi index trigger functions",
"created_at": "2023-08-15 23:12:15"
},
{
"body": "/sig api-machinery",
"created_at": "2023-08-17 07:39:37"
},
{
"body": "/assign @wojtek-t \r\nfor the original author, from git praise\r\n/triage accepted",
"created_at": "2023-08-17 16:44:56"
},
{
"body": "I know the reason，thanks.",
"created_at": "2023-08-24 02:00:37"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:55:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:55:46",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 18:54:59",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 23:12:17",
"type": "renamed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:39:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 07:39:40",
"type": "unlabeled"
},
{
"author": "wojtek-t",
"created_at": "2023-08-17 16:44:56",
"type": "mentioned"
},
{
"author": "wojtek-t",
"created_at": "2023-08-17 16:44:56",
"type": "subscribed"
},
{
"author": "wojtek-t",
"created_at": "2023-08-17 16:44:57",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:44:58",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 16:44:59",
"type": "unlabeled"
},
{
"author": "Sakuralbj",
"created_at": "2023-08-24 02:00:49",
"type": "closed"
}
] |
119,949 | metrics: add exemplar support for counters | open | 2023-08-15 11:37:30 | 2023-08-24 16:34:50 | null | [
"logicalhan",
"dgrisonnet"
] | [
"sig/network",
"area/kube-proxy",
"area/cloudprovider",
"sig/node",
"size/L",
"kind/feature",
"release-note-none",
"cncf-cla: yes",
"sig/instrumentation",
"sig/architecture",
"do-not-merge/hold",
"sig/cloud-provider",
"needs-priority",
"triage/accepted"
] | rexagod | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Aug 15 10:37:05 UTC 2023.\n",
"created_at": "2023-08-15 11:37:34"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119949#\" title=\"Author self-approved\">rexagod</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [andrewsykim](https://github.com/andrewsykim), [ehashman](https://github.com/ehashman), [klueska](https://github.com/klueska) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/component-base/metrics/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/component-base/metrics/OWNERS)**\n- **[staging/src/k8s.io/dynamic-resource-allocation/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/dynamic-resource-allocation/OWNERS)**\n- **[staging/src/k8s.io/endpointslice/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/endpointslice/OWNERS)**\n- **[staging/src/k8s.io/kube-proxy/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kube-proxy/OWNERS)**\n- **[staging/src/k8s.io/kubelet/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubelet/OWNERS)**\n- **[staging/src/k8s.io/legacy-cloud-providers/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/legacy-cloud-providers/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"andrewsykim\",\"ehashman\",\"klueska\"]} -->",
"created_at": "2023-08-15 12:11:39"
},
{
"body": "/hold\r\nUntil https://github.com/kubernetes/kubernetes/pull/119949#discussion_r1294862644 is done.",
"created_at": "2023-08-15 16:50:59"
},
{
"body": "/triage accepted\r\n/assign @logicalhan ",
"created_at": "2023-08-24 16:33:22"
},
{
"body": "/assign @dgrisonnet ",
"created_at": "2023-08-24 16:33:29"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:37:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:37:33",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:37:33",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:37:35",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:37:36",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:37:36",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:37:36",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:37:37",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:37:37",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:37:39",
"type": "labeled"
},
{
"author": "rexagod",
"created_at": "2023-08-15 11:44:54",
"type": "mentioned"
},
{
"author": "rexagod",
"created_at": "2023-08-15 11:44:54",
"type": "subscribed"
},
{
"author": "rexagod",
"created_at": "2023-08-15 11:52:16",
"type": "head_ref_force_pushed"
},
{
"author": "rexagod",
"created_at": "2023-08-15 12:00:21",
"type": "mentioned"
},
{
"author": "rexagod",
"created_at": "2023-08-15 12:00:21",
"type": "subscribed"
},
{
"author": "rexagod",
"created_at": "2023-08-15 12:11:32",
"type": "head_ref_force_pushed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 12:11:38",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 12:11:38",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 12:11:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 12:11:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 12:11:41",
"type": "labeled"
},
{
"author": "rexagod",
"created_at": "2023-08-15 12:32:45",
"type": "mentioned"
},
{
"author": "rexagod",
"created_at": "2023-08-15 12:32:45",
"type": "subscribed"
},
{
"author": "rexagod",
"created_at": "2023-08-15 12:52:40",
"type": "mentioned"
},
{
"author": "rexagod",
"created_at": "2023-08-15 12:52:40",
"type": "subscribed"
},
{
"author": "rexagod",
"created_at": "2023-08-15 13:09:14",
"type": "mentioned"
},
{
"author": "rexagod",
"created_at": "2023-08-15 13:09:14",
"type": "subscribed"
},
{
"author": "rexagod",
"created_at": "2023-08-15 13:09:57",
"type": "mentioned"
},
{
"author": "rexagod",
"created_at": "2023-08-15 13:09:57",
"type": "subscribed"
},
{
"author": "rexagod",
"created_at": "2023-08-15 13:10:06",
"type": "mentioned"
},
{
"author": "rexagod",
"created_at": "2023-08-15 13:10:06",
"type": "subscribed"
},
{
"author": "rexagod",
"created_at": "2023-08-15 13:10:45",
"type": "head_ref_force_pushed"
},
{
"author": "rexagod",
"created_at": "2023-08-15 13:32:23",
"type": "mentioned"
},
{
"author": "rexagod",
"created_at": "2023-08-15 13:32:23",
"type": "subscribed"
},
{
"author": "rexagod",
"created_at": "2023-08-15 14:08:22",
"type": "mentioned"
},
{
"author": "rexagod",
"created_at": "2023-08-15 14:08:22",
"type": "subscribed"
},
{
"author": "rexagod",
"created_at": "2023-08-15 14:10:26",
"type": "mentioned"
},
{
"author": "rexagod",
"created_at": "2023-08-15 14:10:26",
"type": "subscribed"
},
{
"author": "rexagod",
"created_at": "2023-08-15 14:33:34",
"type": "mentioned"
},
{
"author": "rexagod",
"created_at": "2023-08-15 14:33:35",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 16:51:01",
"type": "labeled"
},
{
"author": "logicalhan",
"created_at": "2023-08-24 16:33:22",
"type": "mentioned"
},
{
"author": "logicalhan",
"created_at": "2023-08-24 16:33:22",
"type": "subscribed"
},
{
"author": "logicalhan",
"created_at": "2023-08-24 16:33:23",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 16:33:24",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 16:33:25",
"type": "unlabeled"
},
{
"author": "dgrisonnet",
"created_at": "2023-08-24 16:33:29",
"type": "mentioned"
},
{
"author": "dgrisonnet",
"created_at": "2023-08-24 16:33:29",
"type": "subscribed"
},
{
"author": "dgrisonnet",
"created_at": "2023-08-24 16:33:30",
"type": "assigned"
}
] |
119,948 | add UT for storageclass | closed | 2023-08-15 11:11:02 | 2023-08-24 02:45:19 | 2023-08-22 17:03:07 | [
"thockin",
"carlory"
] | [
"kind/cleanup",
"lgtm",
"sig/storage",
"size/L",
"release-note-none",
"approved",
"cncf-cla: yes",
"ok-to-test",
"needs-priority",
"needs-triage"
] | liyuerich | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Aug 15 10:37:05 UTC 2023.\n",
"created_at": "2023-08-15 11:11:05"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-15 11:11:09"
},
{
"body": "Hi @liyuerich. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-15 11:11:11"
},
{
"body": "/cc @carlory , could you please help to review this PR? ",
"created_at": "2023-08-15 11:12:51"
},
{
"body": "/cc @carlory , thanks your comments. could you please help to review again?",
"created_at": "2023-08-17 10:24:20"
},
{
"body": "/ok-to-test",
"created_at": "2023-08-17 10:30:56"
},
{
"body": "/release-note-label none",
"created_at": "2023-08-17 10:32:21"
},
{
"body": "/cc @carlory , thanks your comments. could you please help to review again?",
"created_at": "2023-08-17 10:55:02"
},
{
"body": "/retest",
"created_at": "2023-08-18 01:01:06"
},
{
"body": "/release-note none",
"created_at": "2023-08-18 06:45:14"
},
{
"body": "/retest-required",
"created_at": "2023-08-21 01:25:39"
},
{
"body": "/lgtm\r\n\r\n/assign @thockin ",
"created_at": "2023-08-21 05:26:56"
},
{
"body": "LGTM label has been added. <details>Git tree hash: bc281e4ea9390a21265f81475125b09266cc12e9</details>",
"created_at": "2023-08-21 05:27:06"
},
{
"body": "/release-note-none",
"created_at": "2023-08-22 02:54:22"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119948#\" title=\"Author self-approved\">liyuerich</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119948#pullrequestreview-1589796306\" title=\"Approved\">thockin</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/volume/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/OWNERS)~~ [thockin]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-22 15:59:59"
},
{
"body": "thanks @carlory and @thockin ",
"created_at": "2023-08-24 02:45:19"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:11:04",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:11:04",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:11:05",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:11:07",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:11:07",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:11:07",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:11:07",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:11:08",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:11:10",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 11:11:10",
"type": "labeled"
},
{
"author": "liyuerich",
"created_at": "2023-08-15 11:11:11",
"type": "mentioned"
},
{
"author": "liyuerich",
"created_at": "2023-08-15 11:11:11",
"type": "subscribed"
},
{
"author": "carlory",
"created_at": "2023-08-15 11:12:51",
"type": "mentioned"
},
{
"author": "carlory",
"created_at": "2023-08-15 11:12:51",
"type": "subscribed"
},
{
"author": "liyuerich",
"created_at": "2023-08-17 10:18:11",
"type": "head_ref_force_pushed"
},
{
"author": "carlory",
"created_at": "2023-08-17 10:24:20",
"type": "mentioned"
},
{
"author": "carlory",
"created_at": "2023-08-17 10:24:20",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 10:30:57",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 10:30:58",
"type": "unlabeled"
},
{
"author": "liyuerich",
"created_at": "2023-08-17 10:52:08",
"type": "head_ref_force_pushed"
},
{
"author": "carlory",
"created_at": "2023-08-17 10:55:02",
"type": "mentioned"
},
{
"author": "carlory",
"created_at": "2023-08-17 10:55:02",
"type": "subscribed"
},
{
"author": "liyuerich",
"created_at": "2023-08-17 11:44:46",
"type": "mentioned"
},
{
"author": "liyuerich",
"created_at": "2023-08-17 11:44:46",
"type": "subscribed"
},
{
"author": "liyuerich",
"created_at": "2023-08-17 11:47:23",
"type": "mentioned"
},
{
"author": "liyuerich",
"created_at": "2023-08-17 11:47:23",
"type": "subscribed"
},
{
"author": "liyuerich",
"created_at": "2023-08-17 11:51:17",
"type": "mentioned"
},
{
"author": "liyuerich",
"created_at": "2023-08-17 11:51:17",
"type": "subscribed"
},
{
"author": "liyuerich",
"created_at": "2023-08-18 01:53:12",
"type": "mentioned"
},
{
"author": "liyuerich",
"created_at": "2023-08-18 01:53:12",
"type": "subscribed"
},
{
"author": "liyuerich",
"created_at": "2023-08-18 05:51:49",
"type": "head_ref_force_pushed"
},
{
"author": "liyuerich",
"created_at": "2023-08-18 06:11:44",
"type": "renamed"
},
{
"author": "liyuerich",
"created_at": "2023-08-18 06:19:18",
"type": "mentioned"
},
{
"author": "liyuerich",
"created_at": "2023-08-18 06:19:19",
"type": "subscribed"
},
{
"author": "liyuerich",
"created_at": "2023-08-18 07:13:38",
"type": "head_ref_force_pushed"
},
{
"author": "liyuerich",
"created_at": "2023-08-18 14:19:01",
"type": "head_ref_force_pushed"
},
{
"author": "liyuerich",
"created_at": "2023-08-18 14:45:15",
"type": "mentioned"
},
{
"author": "liyuerich",
"created_at": "2023-08-18 14:45:15",
"type": "subscribed"
},
{
"author": "thockin",
"created_at": "2023-08-21 05:26:56",
"type": "mentioned"
},
{
"author": "thockin",
"created_at": "2023-08-21 05:26:56",
"type": "subscribed"
},
{
"author": "thockin",
"created_at": "2023-08-21 05:26:57",
"type": "assigned"
},
{
"author": "carlory",
"created_at": "2023-08-21 05:27:03",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 05:27:04",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 02:54:23",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 02:54:24",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 16:00:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 17:03:07",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 17:03:07",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 17:03:07",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 17:03:09",
"type": "milestoned"
},
{
"author": "liyuerich",
"created_at": "2023-08-24 02:44:53",
"type": "head_ref_deleted"
},
{
"author": "thockin",
"created_at": "2023-08-24 02:45:19",
"type": "mentioned"
},
{
"author": "thockin",
"created_at": "2023-08-24 02:45:19",
"type": "subscribed"
},
{
"author": "carlory",
"created_at": "2023-08-24 02:45:19",
"type": "mentioned"
},
{
"author": "carlory",
"created_at": "2023-08-24 02:45:20",
"type": "subscribed"
}
] |
119,947 | Add unit tests for subdomain match in keyring | open | 2023-08-15 10:19:01 | 2023-08-15 11:30:26 | null | [] | [
"kind/cleanup",
"size/S",
"release-note-none",
"cncf-cla: yes",
"needs-priority",
"needs-triage",
"do-not-merge/needs-sig"
] | saschagrunert | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Aug 15 04:36:57 UTC 2023.\n",
"created_at": "2023-08-15 10:19:05"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-15 10:19:09"
},
{
"body": "> I think one more negative case to explicitly show that wildcarding on the front doesn't apply to inputs that have more prefixed parts.\r\n\r\nI agree, added as suggested.",
"created_at": "2023-08-15 10:48:08"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119947#pullrequestreview-1578379927\" title=\"Approved\">njgibbon</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119947#\" title=\"Author self-approved\">saschagrunert</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [deads2k](https://github.com/deads2k) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/credentialprovider/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/credentialprovider/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"deads2k\"]} -->",
"created_at": "2023-08-15 11:30:26"
}
] | [
{
"author": "njgibbon",
"created_at": "2023-08-15 10:19:01",
"type": "mentioned"
},
{
"author": "njgibbon",
"created_at": "2023-08-15 10:19:01",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 10:19:02",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 10:19:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 10:19:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 10:19:06",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 10:19:06",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 10:19:06",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 10:19:07",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 10:19:08",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 10:19:10",
"type": "labeled"
},
{
"author": "saschagrunert",
"created_at": "2023-08-15 10:47:30",
"type": "head_ref_force_pushed"
}
] |
119,946 | kubeadm: `ignore-preflight-errors` flag will replace the value from config file | open | 2023-08-15 09:29:34 | 2023-08-20 14:36:35 | null | [] | [
"sig/cluster-lifecycle",
"release-note",
"size/M",
"kind/feature",
"area/kubeadm",
"cncf-cla: yes",
"do-not-merge/hold",
"needs-priority",
"needs-triage"
] | chendave | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Aug 15 04:36:57 UTC 2023.\n",
"created_at": "2023-08-15 09:29:37"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119946#\" title=\"Author self-approved\">chendave</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [pacoxu](https://github.com/pacoxu) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[cmd/kubeadm/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"pacoxu\"]} -->",
"created_at": "2023-08-15 09:29:39"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-15 09:29:41"
},
{
"body": "@chendave: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-node-e2e-containerd | c23125469460ee0d61db36d25c6296d6b2bf378e | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119946/pull-kubernetes-node-e2e-containerd/1691381613461508096/) | true | `/test pull-kubernetes-node-e2e-containerd`\npull-kubernetes-e2e-kind | c23125469460ee0d61db36d25c6296d6b2bf378e | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119946/pull-kubernetes-e2e-kind/1691381613281153024) | true | `/test pull-kubernetes-e2e-kind`\npull-kubernetes-unit | c23125469460ee0d61db36d25c6296d6b2bf378e | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119946/pull-kubernetes-unit/1691381613423759360) | true | `/test pull-kubernetes-unit`\npull-kubernetes-e2e-gce | c23125469460ee0d61db36d25c6296d6b2bf378e | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119946/pull-kubernetes-e2e-gce/1691381613188878336/) | true | `/test pull-kubernetes-e2e-gce`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119946). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Achendave). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"created_at": "2023-08-15 10:23:57"
},
{
"body": "/hold\r\n\r\nadding a feature gate.",
"created_at": "2023-08-16 03:12:31"
},
{
"body": "> /hold\r\n> \r\n> adding a feature gate.\r\n\r\n@chendave note how we added a deprecated FG here:\r\nhttps://github.com/kubernetes/kubeadm/issues/2346\r\n\r\nwe can use the same pattern IMO",
"created_at": "2023-08-20 14:36:34"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 09:29:35",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 09:29:35",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 09:29:35",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 09:29:38",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 09:29:39",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 09:29:39",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 09:29:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 09:29:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 09:29:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 09:29:42",
"type": "labeled"
},
{
"author": "chendave",
"created_at": "2023-08-15 10:00:54",
"type": "mentioned"
},
{
"author": "chendave",
"created_at": "2023-08-15 10:00:54",
"type": "subscribed"
},
{
"author": "chendave",
"created_at": "2023-08-15 10:06:37",
"type": "mentioned"
},
{
"author": "chendave",
"created_at": "2023-08-15 10:06:37",
"type": "subscribed"
},
{
"author": "chendave",
"created_at": "2023-08-15 10:10:21",
"type": "mentioned"
},
{
"author": "chendave",
"created_at": "2023-08-15 10:10:21",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 10:18:14",
"type": "labeled"
},
{
"author": "chendave",
"created_at": "2023-08-15 10:23:57",
"type": "mentioned"
},
{
"author": "chendave",
"created_at": "2023-08-15 10:23:57",
"type": "subscribed"
},
{
"author": "chendave",
"created_at": "2023-08-20 14:36:34",
"type": "mentioned"
},
{
"author": "chendave",
"created_at": "2023-08-20 14:36:35",
"type": "subscribed"
}
] |
119,945 | Fix hung volume wedge the kubelet | closed | 2023-08-15 06:29:37 | 2023-08-15 12:44:24 | 2023-08-15 12:44:23 | [] | [
"kind/bug",
"sig/storage",
"size/S",
"cncf-cla: yes",
"needs-ok-to-test",
"do-not-merge/release-note-label-needed",
"do-not-merge/work-in-progress",
"needs-priority",
"needs-triage"
] | j4ckstraw | [
{
"body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-15 06:29:39"
},
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Aug 15 04:36:57 UTC 2023.\n",
"created_at": "2023-08-15 06:29:41"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119945#\" title=\"Author self-approved\">j4ckstraw</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [saad-ali](https://github.com/saad-ali) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/mount-utils/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/mount-utils/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"saad-ali\"]} -->",
"created_at": "2023-08-15 06:29:43"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-15 06:29:45"
},
{
"body": "Welcome @j4ckstraw! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:",
"created_at": "2023-08-15 06:29:46"
},
{
"body": "Hi @j4ckstraw. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-15 06:29:46"
},
{
"body": "/ok-to-test",
"created_at": "2023-08-15 06:34:06"
},
{
"body": "@j4ckstraw: Cannot trigger testing until a trusted user reviews the PR and leaves an `/ok-to-test` message.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119945#issuecomment-1678486174):\n\n>/ok-to-test\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-15 06:34:20"
},
{
"body": "/close",
"created_at": "2023-08-15 12:44:17"
},
{
"body": "/close",
"created_at": "2023-08-15 12:44:24"
},
{
"body": "@j4ckstraw: Closed this PR.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119945#issuecomment-1678871678):\n\n>/close\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-15 12:44:24"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 06:29:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 06:29:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 06:29:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 06:29:42",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 06:29:43",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 06:29:43",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 06:29:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 06:29:44",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 06:29:46",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 06:29:46",
"type": "labeled"
},
{
"author": "j4ckstraw",
"created_at": "2023-08-15 06:29:47",
"type": "mentioned"
},
{
"author": "j4ckstraw",
"created_at": "2023-08-15 06:29:47",
"type": "mentioned"
},
{
"author": "j4ckstraw",
"created_at": "2023-08-15 06:29:47",
"type": "subscribed"
},
{
"author": "j4ckstraw",
"created_at": "2023-08-15 06:29:47",
"type": "subscribed"
},
{
"author": "j4ckstraw",
"created_at": "2023-08-15 06:34:21",
"type": "mentioned"
},
{
"author": "j4ckstraw",
"created_at": "2023-08-15 06:34:21",
"type": "subscribed"
},
{
"author": "j4ckstraw",
"created_at": "2023-08-15 08:37:50",
"type": "convert_to_draft"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 08:37:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 12:44:23",
"type": "closed"
},
{
"author": "j4ckstraw",
"created_at": "2023-08-15 12:44:24",
"type": "mentioned"
},
{
"author": "j4ckstraw",
"created_at": "2023-08-15 12:44:25",
"type": "subscribed"
}
] |
119,944 | [WIP] Adding backup code for removing finalizers to more Job End States. | open | 2023-08-15 00:22:46 | 2023-08-25 15:22:11 | null | [
"Sharpz7"
] | [
"kind/bug",
"size/M",
"sig/apps",
"cncf-cla: yes",
"do-not-merge/release-note-label-needed",
"do-not-merge/work-in-progress",
"ok-to-test",
"needs-priority",
"needs-triage",
"wg/batch"
] | Sharpz7 | [
{
"body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-15 00:22:48"
},
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 14 22:37:02 UTC 2023.\n",
"created_at": "2023-08-15 00:22:49"
},
{
"body": "<a href=\"https://easycla.lfx.linuxfoundation.org/#/?version=2\"><img src=\"https://s3.amazonaws.com/cla-project-logo-prod/cla-signed.svg\" alt=\"CLA Signed\" align=\"left\" height=\"28\" width=\"328\" ></a><br/><br />The committers listed above are authorized under a signed CLA.<ul><li>:white_check_mark: login: Sharpz7 / name: Adam McArthur (297f04b74aee0c3c2bcdf50378f3c611583ce602, cf32ae9453b0579a0e4036f619a3628829799e58, 601679446aea334bfab4ce012765e96dd1098fe0, aa9f38c36d894a0f558a8d75bf282b69546ef99c, ef6a0eb6d854e0cc2a9e316359bc610c621a4034, d08fc3a4d01e6e6416bb93f70c86bd7d35786ed7, f87cc43cdb0a41a3a3788c579a617fb41885e741, ff1659cb79823d58e0bb1cb78bc37d1d67ab1236, 5fb049ff473b58bfedf080c8fc2fd242ea5b26d4, 6ded53ce4dcac7653b5eb81188a009d721f94ea6, 70e2deb32f9d421768661893a10ce32983e03f6e, 22f4b1c56ad2895656e9701ac83bfc4087606567, 0bc0256093b543704e4ce3d64e57940b4164b3b2)</li></ul>",
"created_at": "2023-08-15 00:22:49"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119944#\" title=\"Author self-approved\">Sharpz7</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [janetkuo](https://github.com/janetkuo) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/controller/job/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/job/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"janetkuo\"]} -->",
"created_at": "2023-08-15 00:22:51"
},
{
"body": "Welcome @Sharpz7! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:",
"created_at": "2023-08-15 00:22:54"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-15 00:22:54"
},
{
"body": "Hi @Sharpz7. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-15 00:22:55"
},
{
"body": "@Sharpz7: The label(s) `/label wg-batch` cannot be applied. These labels are supported: `api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, official-cve-feed`. Is this label configured under `labels -> additional_labels` or `labels -> restricted_labels` in `plugin.yaml`?\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119944#issuecomment-1678267472):\n\n>/assign @alculquicondor \r\n>/label wg-batch\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-15 00:32:32"
},
{
"body": "/assign @Sharpz7 ",
"created_at": "2023-08-15 00:33:22"
},
{
"body": "/wg batch",
"created_at": "2023-08-15 00:33:59"
},
{
"body": "/ok-to-test\r\n/sig apps\r\n/kind bug",
"created_at": "2023-08-15 01:39:02"
},
{
"body": "/cc @alculquicondor ",
"created_at": "2023-08-16 18:38:34"
},
{
"body": "There still seems to be no test coverage of the new function (combined-coverage.html)\r\n\r\nhttps://drive.google.com/uc?id=1Y-m6xHK9-mInZU_X4my6xEbXO_knuK-U\r\n\r\nThis suggests to me that either my test needs changed or removed.\r\n",
"created_at": "2023-08-17 17:28:21"
},
{
"body": "> There still seems to be no test coverage of the new function (combined-coverage.html)\r\n> \r\n> https://drive.google.com/uc?id=1Y-m6xHK9-mInZU_X4my6xEbXO_knuK-U\r\n> \r\n> This suggests to me that either my test needs changed or removed.\r\n\r\nReading this, I think its hitting this function but we don't have pods in the job.\r\n\r\nI'm not exactly sure how clientset does with list and create of pods in the job controller. Usually we would populate pods with statuses in order to mock tests here but in this function you are getting the list of pods and looping over that. You may need to check on your test case if you are creating pods.",
"created_at": "2023-08-22 17:37:10"
},
{
"body": "Can you add a release-note?\r\n\r\n@alculquicondor can we get by with a none release note here?",
"created_at": "2023-08-22 18:00:02"
},
{
"body": "@alculquicondor I added your changes (It currently fails so I don't want to push it). \r\n\r\nIt seems that what I am creating is similar to `func TestWatchOrphanPods`. I did some debugging of the tests, and neither my test or that test hit `UpdateJob` or `DeleteJob`, which are the two places we do the backup. Does this sound right?",
"created_at": "2023-08-25 09:16:51"
},
{
"body": "I would suggest you push what you have, even if it fails, so we can look at the logs or try to repro.",
"created_at": "2023-08-25 13:31:12"
},
{
"body": "@alculquicondor Sorry If I didn't make it clear, that is what I have done. (Outside of commenting that line, do you want me to uncomment it?)\r\n\r\nBut I went through coverage checks and debug checks, that function with or without the commented out part never goes to `UpdateJob` \r\n\r\nI will uncomment just in case.",
"created_at": "2023-08-25 13:46:48"
},
{
"body": "@Sharpz7: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-node-e2e-containerd | 0bc0256093b543704e4ce3d64e57940b4164b3b2 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119944/pull-kubernetes-node-e2e-containerd/1695077703666896896/) | true | `/test pull-kubernetes-node-e2e-containerd`\npull-kubernetes-unit | 0bc0256093b543704e4ce3d64e57940b4164b3b2 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119944/pull-kubernetes-unit/1695077703612370944) | true | `/test pull-kubernetes-unit`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119944). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3ASharpz7). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"created_at": "2023-08-25 14:59:21"
},
{
"body": "```diff\r\ndiff --git a/pkg/controller/job/job_controller_test.go b/pkg/controller/job/job_controller_test.go\r\nindex b6de340000a..084d6f804f7 100644\r\n--- a/pkg/controller/job/job_controller_test.go\r\n+++ b/pkg/controller/job/job_controller_test.go\r\n@@ -5174,17 +5174,16 @@ func TestFinalizersRemovedExpectations(t *testing.T) {\r\n \r\n func TestBackupFinalizerRemoval(t *testing.T) {\r\n \t_, ctx := ktesting.NewTestContext(t)\r\n+\tctx, cancel := context.WithCancel(ctx)\r\n+\tdefer cancel()\r\n \tclientset := fake.NewSimpleClientset()\r\n \tsharedInformers := informers.NewSharedInformerFactory(clientset, controller.NoResyncPeriodFunc())\r\n \tmanager := NewController(ctx, sharedInformers.Core().V1().Pods(), sharedInformers.Batch().V1().Jobs(), clientset)\r\n \tmanager.podStoreSynced = alwaysReady\r\n \tmanager.jobStoreSynced = alwaysReady\r\n \r\n-\tstopCh := make(chan struct{})\r\n-\tdefer close(stopCh)\r\n-\tpodInformer := sharedInformers.Core().V1().Pods().Informer()\r\n-\tgo podInformer.Run(stopCh)\r\n-\tcache.WaitForCacheSync(stopCh, podInformer.HasSynced)\r\n+\tsharedInformers.Start(ctx.Done())\r\n+\tsharedInformers.WaitForCacheSync(ctx.Done())\r\n \r\n \t// 1. Create the controller but do not start the workers.\r\n \t// This is done above by initializing the manager and not calling manager.Run() yet.\r\n@@ -5217,9 +5216,6 @@ func TestBackupFinalizerRemoval(t *testing.T) {\r\n \r\n \tgo manager.Run(context.TODO(), 0)\r\n \r\n-\tctx, cancel := context.WithTimeout(context.Background(), wait.ForeverTestTimeout)\r\n-\tdefer cancel()\r\n-\r\n \tif err := wait.PollUntilContextTimeout(ctx, 100*time.Millisecond, wait.ForeverTestTimeout, true, func(ctx context.Context) (bool, error) {\r\n \t\tp, err := clientset.CoreV1().Pods(pod.Namespace).Get(ctx, pod.Name, metav1.GetOptions{})\r\n \t\tif err != nil {\r\n```",
"created_at": "2023-08-25 15:21:23"
},
{
"body": "You only started the Pod informer, but not the Job informer. The suggestion above starts all informers that are initialized.",
"created_at": "2023-08-25 15:22:11"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 00:22:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 00:22:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 00:22:48",
"type": "labeled"
},
{
"author": "Sharpz7",
"created_at": "2023-08-15 00:22:50",
"type": "mentioned"
},
{
"author": "Sharpz7",
"created_at": "2023-08-15 00:22:50",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 00:22:51",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 00:22:51",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 00:22:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 00:22:52",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 00:22:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 00:22:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 00:22:54",
"type": "labeled"
},
{
"author": "Sharpz7",
"created_at": "2023-08-15 00:22:54",
"type": "mentioned"
},
{
"author": "Sharpz7",
"created_at": "2023-08-15 00:22:54",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 00:22:55",
"type": "labeled"
},
{
"author": "Sharpz7",
"created_at": "2023-08-15 00:22:55",
"type": "mentioned"
},
{
"author": "Sharpz7",
"created_at": "2023-08-15 00:22:55",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 00:25:35",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 00:25:36",
"type": "labeled"
},
{
"author": "alculquicondor",
"created_at": "2023-08-15 00:32:31",
"type": "mentioned"
},
{
"author": "alculquicondor",
"created_at": "2023-08-15 00:32:31",
"type": "subscribed"
},
{
"author": "alculquicondor",
"created_at": "2023-08-15 00:32:32",
"type": "assigned"
},
{
"author": "alculquicondor",
"created_at": "2023-08-15 00:32:33",
"type": "mentioned"
},
{
"author": "alculquicondor",
"created_at": "2023-08-15 00:32:33",
"type": "subscribed"
},
{
"author": "Sharpz7",
"created_at": "2023-08-15 00:32:33",
"type": "mentioned"
},
{
"author": "Sharpz7",
"created_at": "2023-08-15 00:32:33",
"type": "subscribed"
},
{
"author": "Sharpz7",
"created_at": "2023-08-15 00:32:59",
"type": "mentioned"
},
{
"author": "Sharpz7",
"created_at": "2023-08-15 00:32:59",
"type": "subscribed"
},
{
"author": "alculquicondor",
"created_at": "2023-08-15 00:33:13",
"type": "mentioned"
},
{
"author": "alculquicondor",
"created_at": "2023-08-15 00:33:13",
"type": "subscribed"
},
{
"author": "alculquicondor",
"created_at": "2023-08-15 00:33:14",
"type": "unassigned"
},
{
"author": "Sharpz7",
"created_at": "2023-08-15 00:33:23",
"type": "mentioned"
},
{
"author": "Sharpz7",
"created_at": "2023-08-15 00:33:23",
"type": "subscribed"
},
{
"author": "Sharpz7",
"created_at": "2023-08-15 00:33:24",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 00:34:01",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 01:39:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 01:39:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 01:39:04",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 01:39:05",
"type": "unlabeled"
},
{
"author": "alculquicondor",
"created_at": "2023-08-16 18:38:34",
"type": "mentioned"
},
{
"author": "alculquicondor",
"created_at": "2023-08-16 18:38:34",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 18:38:35",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 17:19:58",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 17:19:59",
"type": "labeled"
},
{
"author": "Sharpz7",
"created_at": "2023-08-17 17:30:07",
"type": "review_requested"
},
{
"author": "Sharpz7",
"created_at": "2023-08-17 18:04:04",
"type": "mentioned"
},
{
"author": "Sharpz7",
"created_at": "2023-08-17 18:04:05",
"type": "subscribed"
},
{
"author": "Sharpz7",
"created_at": "2023-08-22 17:53:30",
"type": "mentioned"
},
{
"author": "Sharpz7",
"created_at": "2023-08-22 17:53:30",
"type": "subscribed"
},
{
"author": "alculquicondor",
"created_at": "2023-08-22 18:00:03",
"type": "mentioned"
},
{
"author": "alculquicondor",
"created_at": "2023-08-22 18:00:03",
"type": "subscribed"
},
{
"author": "alculquicondor",
"created_at": "2023-08-25 09:16:52",
"type": "mentioned"
},
{
"author": "alculquicondor",
"created_at": "2023-08-25 09:16:52",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-25 09:42:32",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-25 09:42:33",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-25 09:42:47",
"type": "labeled"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 10:07:06",
"type": "mentioned"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 10:07:06",
"type": "subscribed"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 10:23:10",
"type": "head_ref_force_pushed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-25 10:23:11",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-25 10:23:12",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-25 10:23:27",
"type": "unlabeled"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 10:36:25",
"type": "head_ref_force_pushed"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 10:58:01",
"type": "mentioned"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 10:58:01",
"type": "subscribed"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 11:08:04",
"type": "mentioned"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 11:08:04",
"type": "subscribed"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 11:12:14",
"type": "mentioned"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 11:12:15",
"type": "subscribed"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 11:31:25",
"type": "mentioned"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 11:31:25",
"type": "subscribed"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 11:31:28",
"type": "mentioned"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 11:31:28",
"type": "subscribed"
},
{
"author": "alculquicondor",
"created_at": "2023-08-25 13:46:49",
"type": "mentioned"
},
{
"author": "alculquicondor",
"created_at": "2023-08-25 13:46:49",
"type": "subscribed"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 14:16:23",
"type": "review_requested"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 14:16:29",
"type": "review_requested"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 14:42:34",
"type": "mentioned"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 14:42:34",
"type": "subscribed"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 14:59:21",
"type": "mentioned"
},
{
"author": "Sharpz7",
"created_at": "2023-08-25 14:59:21",
"type": "subscribed"
}
] |
119,943 | Automated cherry pick of #119769: Fix a bug that PostFilter plugin may not function if previous | open | 2023-08-14 16:52:03 | 2023-08-16 07:08:15 | null | [
"alculquicondor"
] | [
"area/test",
"sig/scheduling",
"lgtm",
"release-note",
"size/M",
"approved",
"cncf-cla: yes",
"sig/testing",
"do-not-merge/cherry-pick-not-approved",
"needs-priority",
"kind/regression",
"needs-triage"
] | Huang-Wei | [
{
"body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 16:52:05"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 16:52:13"
},
{
"body": "/hold for https://github.com/kubernetes/kubernetes/pull/119769 to merge first.\r\n\r\n/kind regression",
"created_at": "2023-08-14 16:52:34"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119943#\" title=\"Author self-approved\">Huang-Wei</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/scheduler/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/pkg/scheduler/OWNERS)~~ [Huang-Wei]\n- ~~[test/integration/scheduler/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/test/integration/scheduler/OWNERS)~~ [Huang-Wei]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-14 16:52:39"
},
{
"body": "/lgtm",
"created_at": "2023-08-14 17:00:50"
},
{
"body": "LGTM label has been added. <details>Git tree hash: ef3160a25a2336dfc752730a77ce1428662244b1</details>",
"created_at": "2023-08-14 17:01:59"
},
{
"body": "/retest",
"created_at": "2023-08-14 18:16:16"
},
{
"body": "/unhold\r\n(the original PR has been merged)\r\n\r\n/cc @kubernetes/release-managers ",
"created_at": "2023-08-16 07:08:14"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:05",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:05",
"type": "milestoned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:05",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:08",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:10",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:11",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:12",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:14",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:18",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:36",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:37",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:39",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:39",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:39",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:41",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:52:42",
"type": "unlabeled"
},
{
"author": "alculquicondor",
"created_at": "2023-08-14 17:00:55",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 17:01:58",
"type": "labeled"
},
{
"author": "Huang-Wei",
"created_at": "2023-08-14 17:32:36",
"type": "mentioned"
},
{
"author": "Huang-Wei",
"created_at": "2023-08-14 17:32:36",
"type": "subscribed"
},
{
"author": "zwpaper",
"created_at": "2023-08-15 16:03:53",
"type": "subscribed"
},
{
"author": "justaugustus",
"created_at": "2023-08-16 07:08:15",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-16 07:08:15",
"type": "subscribed"
},
{
"author": "Verolop",
"created_at": "2023-08-16 07:08:15",
"type": "subscribed"
},
{
"author": "puerco",
"created_at": "2023-08-16 07:08:15",
"type": "subscribed"
},
{
"author": "cpanato",
"created_at": "2023-08-16 07:08:15",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:08:15",
"type": "review_requested"
},
{
"author": "cici37",
"created_at": "2023-08-16 07:08:15",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:08:15",
"type": "unlabeled"
},
{
"author": "palnabarun",
"created_at": "2023-08-16 07:08:15",
"type": "subscribed"
},
{
"author": "xmudrii",
"created_at": "2023-08-16 07:08:15",
"type": "subscribed"
},
{
"author": "k8s-release-robot",
"created_at": "2023-08-16 07:08:16",
"type": "subscribed"
},
{
"author": "jeremyrickard",
"created_at": "2023-08-16 07:08:16",
"type": "subscribed"
}
] |
119,942 | Automated cherry pick of #119769: Fix a bug that PostFilter plugin may not function if previous | open | 2023-08-14 16:46:11 | 2023-08-16 07:07:32 | null | [
"alculquicondor"
] | [
"area/test",
"sig/scheduling",
"lgtm",
"release-note",
"size/M",
"approved",
"cncf-cla: yes",
"sig/testing",
"do-not-merge/cherry-pick-not-approved",
"needs-priority",
"kind/regression",
"needs-triage"
] | Huang-Wei | [
{
"body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 16:46:13"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 16:46:20"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119942#\" title=\"Author self-approved\">Huang-Wei</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/scheduler/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/pkg/scheduler/OWNERS)~~ [Huang-Wei]\n- ~~[test/integration/scheduler/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.28/test/integration/scheduler/OWNERS)~~ [Huang-Wei]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-14 16:46:44"
},
{
"body": "/hold for #119769 to merge first.\r\n\r\n/kind regression",
"created_at": "2023-08-14 16:47:20"
},
{
"body": "/lgtm",
"created_at": "2023-08-14 17:00:32"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 35d93850b7784a903eb9f4fee6183c5619f1947f</details>",
"created_at": "2023-08-14 17:00:39"
},
{
"body": "/retest",
"created_at": "2023-08-14 18:16:34"
},
{
"body": "/unhold\r\n(the original PR has been merged in master)\r\n\r\n/cc @kubernetes/release-managers \r\n/milestone v1.28",
"created_at": "2023-08-16 07:07:30"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:46:12",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:46:13",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:46:15",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:46:18",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:46:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:46:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:46:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:46:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:46:44",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:46:44",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:46:44",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:46:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:46:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:46:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:46:46",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:47:22",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:47:22",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:47:24",
"type": "unlabeled"
},
{
"author": "alculquicondor",
"created_at": "2023-08-14 17:00:37",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 17:00:38",
"type": "labeled"
},
{
"author": "Huang-Wei",
"created_at": "2023-08-14 17:47:43",
"type": "mentioned"
},
{
"author": "Huang-Wei",
"created_at": "2023-08-14 17:47:43",
"type": "subscribed"
},
{
"author": "justaugustus",
"created_at": "2023-08-16 07:07:31",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-16 07:07:31",
"type": "subscribed"
},
{
"author": "Verolop",
"created_at": "2023-08-16 07:07:31",
"type": "subscribed"
},
{
"author": "puerco",
"created_at": "2023-08-16 07:07:31",
"type": "subscribed"
},
{
"author": "cpanato",
"created_at": "2023-08-16 07:07:31",
"type": "subscribed"
},
{
"author": "cici37",
"created_at": "2023-08-16 07:07:31",
"type": "subscribed"
},
{
"author": "palnabarun",
"created_at": "2023-08-16 07:07:31",
"type": "subscribed"
},
{
"author": "xmudrii",
"created_at": "2023-08-16 07:07:31",
"type": "subscribed"
},
{
"author": "k8s-release-robot",
"created_at": "2023-08-16 07:07:32",
"type": "subscribed"
},
{
"author": "jeremyrickard",
"created_at": "2023-08-16 07:07:32",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:07:32",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:07:32",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:07:32",
"type": "milestoned"
}
] |
119,941 | Kubernetes Docker Config Json Globbing Not As Documented | open | 2023-08-14 15:23:55 | 2023-08-15 09:58:10 | null | [] | [
"kind/bug",
"sig/auth",
"sig/docs",
"needs-triage"
] | njgibbon | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 15:24:04"
},
{
"body": "/sig auth\r\n/sig docs",
"created_at": "2023-08-14 15:33:00"
},
{
"body": "I think it should be updated in the docs, that:\r\n\r\n- ~~Only one subdomain depth is supported~~ Only the same amount of dots + `*` are supported \r\n- The glob requires the dot separator\r\n\r\nAnything else?",
"created_at": "2023-08-15 07:56:57"
},
{
"body": "@saschagrunert - I think you can have multiple subdomains as long as you have a corresponding number of dots in your glob pattern. I think the core diff between the docs interpretation and the actual implementation is how the dots work.",
"created_at": "2023-08-15 09:52:00"
},
{
"body": "Yeah those are the tests for that: \r\n\r\nhttps://github.com/kubernetes/kubernetes/blob/6e0cb243d57592c917fe449dde20b0e246bc66be/pkg/credentialprovider/keyring_test.go#L75-L90",
"created_at": "2023-08-15 09:57:12"
}
] | [
{
"author": "njgibbon",
"created_at": "2023-08-14 15:23:55",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 15:24:01",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 15:24:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 15:33:01",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 15:33:02",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 15:33:03",
"type": "unlabeled"
},
{
"author": "saschagrunert",
"created_at": "2023-08-15 09:52:01",
"type": "mentioned"
},
{
"author": "saschagrunert",
"created_at": "2023-08-15 09:52:01",
"type": "subscribed"
},
{
"author": "saschagrunert",
"created_at": "2023-08-15 10:11:52",
"type": "referenced"
},
{
"author": "saschagrunert",
"created_at": "2023-08-15 10:18:57",
"type": "referenced"
},
{
"author": "saschagrunert",
"created_at": "2023-08-15 10:47:29",
"type": "referenced"
}
] |
119,939 | [kubectl] Lookup Host from kubeconfig when needed | closed | 2023-08-14 14:17:55 | 2023-08-16 19:44:08 | 2023-08-16 19:44:07 | [
"aojea",
"upodroid"
] | [
"area/test",
"kind/cleanup",
"lgtm",
"size/M",
"release-note-none",
"approved",
"sig/cli",
"cncf-cla: yes",
"sig/testing",
"needs-priority",
"needs-triage"
] | dims | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 14 10:38:09 UTC 2023.\n",
"created_at": "2023-08-14 14:17:58"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 14:18:03"
},
{
"body": "lookups add an additional dependency on the dns resolver that can cause flakes ",
"created_at": "2023-08-14 16:01:05"
},
{
"body": "/assign @aojea ",
"created_at": "2023-08-15 11:08:48"
},
{
"body": "@aojea we are not changing any existing e2e tests. if we see flakes, we will see it only on `kubetest2-ec2` based tests. let's try this please, happy to revisit this later. want to get green runs to make sure there isn't other things lurking behind this failure\r\n",
"created_at": "2023-08-16 15:18:17"
},
{
"body": "/retest",
"created_at": "2023-08-16 15:19:17"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119939#\" title=\"Author self-approved\">dims</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119939#pullrequestreview-1580889302\" title=\"Approved\">upodroid</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/kubectl/OWNERS)~~ [dims]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-16 15:25:53"
},
{
"body": "/lgtm",
"created_at": "2023-08-16 15:26:00"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 3a428c0e1e6798d75b85c056c0f8cca957fd6867</details>",
"created_at": "2023-08-16 15:26:08"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:17:57",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:17:57",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:17:57",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:18:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:18:01",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:18:02",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:18:02",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:18:02",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:18:02",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:18:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:18:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:18:04",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:18:04",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:19:05",
"type": "unlabeled"
},
{
"author": "dims",
"created_at": "2023-08-14 14:55:15",
"type": "mentioned"
},
{
"author": "dims",
"created_at": "2023-08-14 14:55:15",
"type": "subscribed"
},
{
"author": "aojea",
"created_at": "2023-08-15 11:08:48",
"type": "mentioned"
},
{
"author": "aojea",
"created_at": "2023-08-15 11:08:48",
"type": "subscribed"
},
{
"author": "aojea",
"created_at": "2023-08-15 11:08:49",
"type": "assigned"
},
{
"author": "aojea",
"created_at": "2023-08-16 15:18:18",
"type": "mentioned"
},
{
"author": "aojea",
"created_at": "2023-08-16 15:18:18",
"type": "subscribed"
},
{
"author": "upodroid",
"created_at": "2023-08-16 15:26:05",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:26:06",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 19:44:06",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 19:44:06",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 19:44:07",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 19:44:08",
"type": "milestoned"
}
] |
119,938 | kubeadm: increase ut for certs/certlist | closed | 2023-08-14 14:10:02 | 2023-08-16 08:22:40 | 2023-08-16 08:22:38 | [
"SataQiu"
] | [
"kind/cleanup",
"lgtm",
"sig/cluster-lifecycle",
"size/M",
"release-note-none",
"approved",
"area/kubeadm",
"cncf-cla: yes",
"needs-priority",
"needs-triage"
] | my-git9 | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 14 10:38:09 UTC 2023.\n",
"created_at": "2023-08-14 14:10:06"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 14:10:11"
},
{
"body": "/test pull-kubernetes-node-e2e-containerd",
"created_at": "2023-08-14 14:46:10"
},
{
"body": "thanks @my-git9 \r\n/lgtm\r\n/approve",
"created_at": "2023-08-16 07:05:50"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 5bf41b21af4cea336308f96bfc3adecd44838206</details>",
"created_at": "2023-08-16 07:05:56"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119938#\" title=\"Author self-approved\">my-git9</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119938#pullrequestreview-1578214361\" title=\"Approved\">neolit123</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119938#issuecomment-1680075336\" title=\"Approved\">SataQiu</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[cmd/kubeadm/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/OWNERS)~~ [SataQiu,neolit123]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-16 07:06:16"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:10:04",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:10:05",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:10:05",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:10:07",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:10:08",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:10:08",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:10:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:10:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:10:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:10:10",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:10:11",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:10:12",
"type": "labeled"
},
{
"author": "my-git9",
"created_at": "2023-08-14 14:10:48",
"type": "head_ref_force_pushed"
},
{
"author": "my-git9",
"created_at": "2023-08-14 14:38:10",
"type": "mentioned"
},
{
"author": "my-git9",
"created_at": "2023-08-14 14:38:10",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 09:13:18",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 09:13:24",
"type": "labeled"
},
{
"author": "my-git9",
"created_at": "2023-08-15 09:22:25",
"type": "head_ref_force_pushed"
},
{
"author": "my-git9",
"created_at": "2023-08-16 02:04:17",
"type": "head_ref_force_pushed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 02:04:19",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 02:04:20",
"type": "labeled"
},
{
"author": "my-git9",
"created_at": "2023-08-16 02:05:29",
"type": "review_requested"
},
{
"author": "my-git9",
"created_at": "2023-08-16 03:03:02",
"type": "mentioned"
},
{
"author": "my-git9",
"created_at": "2023-08-16 03:03:02",
"type": "subscribed"
},
{
"author": "my-git9",
"created_at": "2023-08-16 07:05:50",
"type": "mentioned"
},
{
"author": "my-git9",
"created_at": "2023-08-16 07:05:50",
"type": "subscribed"
},
{
"author": "SataQiu",
"created_at": "2023-08-16 07:05:54",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:05:55",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:22:38",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:22:38",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:22:38",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 08:22:40",
"type": "milestoned"
}
] |
119,937 | Make Kubernetes aware of the LoadBalancer behaviour | closed | 2023-08-14 12:30:14 | 2023-08-19 11:34:43 | 2023-08-17 21:00:28 | [
"thockin"
] | [
"area/test",
"sig/network",
"area/kube-proxy",
"lgtm",
"area/cloudprovider",
"sig/api-machinery",
"release-note",
"size/XXL",
"kind/api-change",
"kind/feature",
"sig/apps",
"approved",
"cncf-cla: yes",
"sig/testing",
"area/code-generation",
"area/ipvs",
"sig/cloud-provider",
"needs-priority",
"triage/accepted"
] | RyanAoh | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 14 10:38:09 UTC 2023.\n",
"created_at": "2023-08-14 12:30:17"
},
{
"body": "A copy of https://github.com/kubernetes/kubernetes/pull/118895, since it was reverted by https://github.com/kubernetes/kubernetes/pull/119876 for release resons.\r\nBTW fix https://github.com/kubernetes/kubernetes/pull/118895#discussion_r1265664692\r\n\r\n/milestone v1.29",
"created_at": "2023-08-14 12:34:36"
},
{
"body": "@RyanAoh: You must be a member of the [kubernetes/milestone-maintainers](https://github.com/orgs/kubernetes/teams/milestone-maintainers/members) GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119937#issuecomment-1677235218):\n\n>A copy of https://github.com/kubernetes/kubernetes/pull/118895, since it was reverted for release resons.\r\n>BTW fix https://github.com/kubernetes/kubernetes/pull/118895#discussion_r1265664692\r\n>\r\n>/milestone v1.29\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 12:34:37"
},
{
"body": "cc @thockin ",
"created_at": "2023-08-14 12:36:25"
},
{
"body": "Changelog suggestion:\r\n```markdown\r\nAdded a new `ipMode` field to the `.status` of Services where `type` is set to `LoadBalancer`.\r\nThe new field is behind the `LoadBalancerIPMode` feature gate.\r\n```",
"created_at": "2023-08-14 12:57:12"
},
{
"body": "/cc @aojea @danwinship \r\nsince you reviewed the original PR\r\n\r\n/triage accepted",
"created_at": "2023-08-15 20:06:59"
},
{
"body": "/test pull-kubernetes-e2e-gci-gce-ipvs",
"created_at": "2023-08-16 02:46:18"
},
{
"body": "LGTM label has been added. <details>Git tree hash: c28b55846c9e534c9899e15c35f6bdf1aeff35e8</details>",
"created_at": "2023-08-17 19:55:03"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119937#\" title=\"Author self-approved\">RyanAoh</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119937#pullrequestreview-1583367054\" title=\"LGTM\">thockin</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/api/OWNERS)~~ [thockin]\n- ~~[pkg/apis/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/OWNERS)~~ [thockin]\n- ~~[pkg/features/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/features/OWNERS)~~ [thockin]\n- ~~[pkg/generated/openapi/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/generated/openapi/OWNERS)~~ [thockin]\n- ~~[pkg/proxy/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/proxy/OWNERS)~~ [thockin]\n- ~~[pkg/registry/core/service/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/registry/core/service/OWNERS)~~ [thockin]\n- ~~[staging/src/k8s.io/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/OWNERS)~~ [thockin]\n- ~~[staging/src/k8s.io/client-go/applyconfigurations/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/applyconfigurations/OWNERS)~~ [thockin]\n- ~~[staging/src/k8s.io/cloud-provider/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/cloud-provider/OWNERS)~~ [thockin]\n- ~~[test/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/OWNERS)~~ [thockin]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-17 19:55:04"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:20",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:20",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:22",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:22",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:22",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:23",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:23",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:24",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:24",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:25",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:26",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:26",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:27",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:30:28",
"type": "labeled"
},
{
"author": "RyanAoh",
"created_at": "2023-08-14 12:34:38",
"type": "mentioned"
},
{
"author": "RyanAoh",
"created_at": "2023-08-14 12:34:38",
"type": "subscribed"
},
{
"author": "thockin",
"created_at": "2023-08-14 12:36:27",
"type": "mentioned"
},
{
"author": "thockin",
"created_at": "2023-08-14 12:36:27",
"type": "subscribed"
},
{
"author": "RyanAoh",
"created_at": "2023-08-14 13:21:33",
"type": "mentioned"
},
{
"author": "RyanAoh",
"created_at": "2023-08-14 13:21:33",
"type": "subscribed"
},
{
"author": "danwinship",
"created_at": "2023-08-15 20:06:59",
"type": "mentioned"
},
{
"author": "danwinship",
"created_at": "2023-08-15 20:07:00",
"type": "subscribed"
},
{
"author": "aojea",
"created_at": "2023-08-15 20:07:00",
"type": "mentioned"
},
{
"author": "aojea",
"created_at": "2023-08-15 20:07:00",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:19:36",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:19:36",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:39:16",
"type": "unlabeled"
},
{
"author": "thockin",
"created_at": "2023-08-17 19:55:01",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 19:55:02",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 19:55:04",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 21:00:28",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 21:00:28",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 21:00:28",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 21:00:30",
"type": "milestoned"
}
] |
119,940 | Advice on Accessing the Kubernetes API from a Pod | closed | 2023-08-14 11:47:11 | 2023-08-14 16:08:26 | 2023-08-14 16:08:26 | [] | [
"kind/support",
"needs-sig",
"needs-triage"
] | rgupta6 | [
{
"body": "This issue is currently awaiting triage.\n\nSIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the `triage/accepted` label.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 11:47:18"
},
{
"body": "/retitle Advice on Accessing the Kubernetes API from a Pod",
"created_at": "2023-08-14 14:50:50"
},
{
"body": "/transfer kubernetes\r\n",
"created_at": "2023-08-14 14:51:02"
},
{
"body": "There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:\n- `/sig <group-name>`\n- `/wg <group-name>`\n- `/committee <group-name>`\n\nPlease see the [group list](https://git.k8s.io/community/sig-list.md) for a listing of the SIGs, working groups, and committees available.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 14:51:11"
},
{
"body": "@rgupta6: GitHub is (still) not the right place for support requests.\r\n\r\nFor further help, you could ask on [Server Fault](https://serverfault.com/questions/tagged/kubernetes).\r\n\r\nYou can also post your question on the [Kubernetes Slack](http://slack.k8s.io/) or the [Discuss Kubernetes](https://discuss.kubernetes.io/) forum.",
"created_at": "2023-08-14 14:51:41"
},
{
"body": "/kind support",
"created_at": "2023-08-14 14:52:13"
},
{
"body": "a better place to ask would be on the support channels. please see:\r\nhttps://git.k8s.io/kubernetes/SUPPORT.md\r\n\r\n/kind support\r\n/close ",
"created_at": "2023-08-14 16:08:21"
},
{
"body": "@neolit123: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119940#issuecomment-1677626868):\n\n>a better place to ask would be on the support channels. please see:\r\n>https://git.k8s.io/kubernetes/SUPPORT.md\r\n>\r\n>/kind support\r\n>/close \n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 16:08:26"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 11:47:17",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:50:52",
"type": "renamed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:51:05",
"type": "transferred"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:51:10",
"type": "labeled"
},
{
"author": "rgupta6",
"created_at": "2023-08-14 14:51:41",
"type": "mentioned"
},
{
"author": "rgupta6",
"created_at": "2023-08-14 14:51:41",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 14:52:15",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:08:26",
"type": "closed"
},
{
"author": "neolit123",
"created_at": "2023-08-14 16:08:26",
"type": "mentioned"
},
{
"author": "neolit123",
"created_at": "2023-08-14 16:08:27",
"type": "subscribed"
}
] |
119,935 | kubeadm init fail | closed | 2023-08-14 08:49:09 | 2023-08-14 13:25:20 | 2023-08-14 13:25:07 | [] | [
"kind/support",
"needs-sig",
"needs-triage"
] | zhaoxueye | [
{
"body": "There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:\n- `/sig <group-name>`\n- `/wg <group-name>`\n- `/committee <group-name>`\n\nPlease see the [group list](https://git.k8s.io/community/sig-list.md) for a listing of the SIGs, working groups, and committees available.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 08:49:17"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 08:49:18"
},
{
"body": "/remove-kind failing-test\r\n\r\n/kind support",
"created_at": "2023-08-14 09:15:07"
},
{
"body": "All version is failed or just v1.28.0-rc.0?",
"created_at": "2023-08-14 09:43:43"
},
{
"body": "> All version is failed or just v1.28.0-rc.0?\r\nI only tested v1.28.0-rc.0\r\n",
"created_at": "2023-08-14 09:47:16"
},
{
"body": "### There is a compromise solution:\r\n1. run command: sudo kubeadm reset -f && sudo kubeadm init --v=100 --image-repository=registry.aliyuncs.com/google_containers --kubernetes-version=\"1.28.0-rc.0\" \r\n2. run command in /etc/kubernetes/manifests/kube-apiserver.yaml:spec:containers:command\r\n3. run command in /etc/kubernetes/manifests/etcd.yaml:spec:containers:command\r\n\r\n### But it also introduces a new problem:\r\nI0814 17:59:18.701916 3491063 round_trippers.go:466] curl -v -XGET -H \"Accept: application/json, */*\" -H \"User-Agent: kubeadm/v1.28.0 (linux/amd64) kubernetes/4571067\" 'https://192.168.0.106:6443/api/v1/nodes/zxy-virtual-machine?timeout=10s'\r\nI0814 17:59:18.708105 3491063 round_trippers.go:553] GET https://192.168.0.106:6443/api/v1/nodes/zxy-virtual-machine?timeout=10s 404 Not Found in 6 milliseconds\r\nI0814 17:59:18.708162 3491063 round_trippers.go:570] HTTP Statistics: GetConnection 0 ms ServerProcessing 5 ms Duration 6 ms\r\nI0814 17:59:18.708172 3491063 round_trippers.go:577] Response Headers:\r\nI0814 17:59:18.708180 3491063 round_trippers.go:580] Audit-Id: fc5e0e2e-938f-4cc4-8283-96474d50786a\r\nI0814 17:59:18.708186 3491063 round_trippers.go:580] Cache-Control: no-cache, private\r\nI0814 17:59:18.708192 3491063 round_trippers.go:580] Content-Type: application/json\r\nI0814 17:59:18.708197 3491063 round_trippers.go:580] X-Kubernetes-Pf-Flowschema-Uid: 84a5046b-70a7-4c94-8c67-fc32fb377c8c\r\nI0814 17:59:18.708202 3491063 round_trippers.go:580] X-Kubernetes-Pf-Prioritylevel-Uid: 0fde4d3c-51fe-48b1-9cb4-01308d5a6c85\r\nI0814 17:59:18.708215 3491063 round_trippers.go:580] Content-Length: 208\r\nI0814 17:59:18.708221 3491063 round_trippers.go:580] Date: Mon, 14 Aug 2023 09:59:18 GMT\r\nI0814 17:59:18.708269 3491063 request.go:1212] Response Body: {\"kind\":\"Status\",\"apiVersion\":\"v1\",\"metadata\":{},\"status\":\"Failure\",\"message\":\"nodes \\\"zxy-virtual-machine\\\" not found\",\"reason\":\"NotFound\",\"details\":{\"name\":\"zxy-virtual-machine\",\"kind\":\"nodes\"},\"code\":404}\r\n",
"created_at": "2023-08-14 10:00:42"
},
{
"body": "not foud /docs/concepts/cluster-administration/addons",
"created_at": "2023-08-14 10:12:37"
},
{
"body": "I have build the image of kind with kubernetes 1.28.0-rc.0 and it's working for me.\r\n\r\n```shell\r\nkind create cluster --image ghcr.io/liangyuanpeng/kindest/node:v0.20.0-v1.28.0-rc.0\r\n```\r\n\r\nIt's run wirh containerd and kubeadm. I'm curious about your other information,like:\r\n\r\n- kubelet log\r\n- what's version of kubeadm\r\n- what's your cri\r\n- OS\r\n\r\n",
"created_at": "2023-08-14 10:13:29"
},
{
"body": "> \r\n\r\n### kubelet log\r\nAug 14 18:33:43 zxy-virtual-machine systemd[1]: Stopping kubelet: The Kubernetes Node Agent...\r\nAug 14 18:33:43 zxy-virtual-machine systemd[1]: kubelet.service: Deactivated successfully.\r\nAug 14 18:33:43 zxy-virtual-machine systemd[1]: Stopped kubelet: The Kubernetes Node Agent.\r\nAug 14 18:33:43 zxy-virtual-machine systemd[1]: kubelet.service: Consumed 3.297s CPU time.\r\nAug 14 18:33:49 zxy-virtual-machine systemd[1]: Started kubelet: The Kubernetes Node Agent.\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.533953 3493230 server.go:467] \"Kubelet version\" kubeletVersion=\"v1.28.0-rc.0\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.534230 3493230 server.go:469] \"Golang settings\" GOGC=\"\" GOMAXPROCS=\"\" GOTRACEBACK=\"\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.534745 3493230 server.go:630] \"Standalone mode, no API client\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.553094 3493230 server.go:518] \"No api server defined - no events will be sent to API server\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.553786 3493230 server.go:725] \"--cgroups-per-qos enabled, but --cgroup-root was not specified. defaulting to /\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.555677 3493230 container_manager_linux.go:265] \"Container manager verified user specified cgroup-root exists\" cgroupRoot=[]\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.557518 3493230 container_manager_linux.go:270] \"Creating Container Manager object based on Node Config\" nodeConfig={\"RuntimeCgroupsName\":\"\",\"SystemCgroupsName\":\"\",\"KubeletCgroupsName\":\"\",\"KubeletOOMScoreAdj\":-999,\"ContainerRuntime\":\"\",\"CgroupsPerQOS\":true,\"CgroupRoot\":\"/\",\"CgroupDriver\":\"cgroupfs\",\"KubeletRootDir\":\"/var/lib/kubelet\",\"ProtectKernelDefaults\":false,\"KubeReservedCgroupName\":\"\",\"SystemReservedCgroupName\":\"\",\"ReservedSystemCPUs\":{},\"EnforceNodeAllocatable\":{\"pods\":{}},\"KubeReserved\":null,\"SystemReserved\":null,\"HardEvictionThresholds\":[],\"QOSReserved\":{},\"CPUManagerPolicy\":\"none\",\"CPUManagerPolicyOptions\":null,\"TopologyManagerScope\":\"container\",\"CPUManagerReconcilePeriod\":10000000000,\"ExperimentalMemoryManagerPolicy\":\"None\",\"ExperimentalMemoryManagerReservedMemory\":null,\"PodPidsLimit\":-1,\"EnforceCPULimits\":true,\"CPUCFSQuotaPeriod\":100000000,\"TopologyManagerPolicy\":\"none\",\"TopologyManagerPolicyOptions\":null}\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.557626 3493230 topology_manager.go:138] \"Creating topology manager with none policy\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.557646 3493230 container_manager_linux.go:301] \"Creating device plugin manager\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.557782 3493230 state_mem.go:36] \"Initialized new in-memory state store\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.557889 3493230 kubelet.go:399] \"Kubelet is running in standalone mode, will skip API server sync\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.559721 3493230 kuberuntime_manager.go:257] \"Container runtime initialized\" containerRuntime=\"containerd\" version=\"1.6.12-0ubuntu1~22.04.3\" apiVersion=\"v1\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.560652 3493230 volume_host.go:74] \"KubeClient is nil. Skip initialization of CSIDriverLister\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: W0814 18:33:50.560988 3493230 csi_plugin.go:189] kubernetes.io/csi: kubeclient not set, assuming standalone kubelet\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: W0814 18:33:50.561422 3493230 csi_plugin.go:266] Skipping CSINode initialization, kubelet running in standalone mode\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.562454 3493230 server.go:1232] \"Started kubelet\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.563159 3493230 kubelet.go:1579] \"No API server defined - no node status update will be sent\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.566486 3493230 fs_resource_analyzer.go:67] \"Starting FS ResourceAnalyzer\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.567004 3493230 server.go:162] \"Starting to listen\" address=\"0.0.0.0\" port=10250\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.569109 3493230 volume_manager.go:291] \"Starting Kubelet Volume Manager\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.569277 3493230 server.go:462] \"Adding debug handlers to kubelet server\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.567155 3493230 ratelimit.go:65] \"Setting rate limiting for podresources endpoint\" qps=100 burstTokens=10\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.574944 3493230 server.go:233] \"Starting to serve the podresources API\" endpoint=\"unix:/var/lib/kubelet/pod-resources/kubelet.sock\"\r\n_**Aug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: E0814 18:33:50.569573 3493230 cri_stats_provider.go:448] \"Failed to get the info of the filesystem with mountpoint\" err=\"unable to find data in memory cache\"**_ mountpoint=\"/var/lib/containerd/io.containerd.snapshotter.v1.overlayfs\"\r\n_**Aug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: E0814 18:33:50.576624 3493230 kubelet.go:1431] \"Image garbage collection failed once. Stats initialization may not have completed yet\" err=\"invalid capacity 0 on image filesystem\"**_\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.567035 3493230 server.go:194] \"Starting to listen read-only\" address=\"0.0.0.0\" port=10255\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.569914 3493230 desired_state_of_world_populator.go:151] \"Desired state populator starts to run\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.570702 3493230 reconciler_new.go:29] \"Reconciler: start to sync state\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.613596 3493230 kubelet_network_linux.go:50] \"Initialized iptables rules.\" protocol=\"IPv4\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.620924 3493230 kubelet_network_linux.go:50] \"Initialized iptables rules.\" protocol=\"IPv6\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.621705 3493230 status_manager.go:213] \"Kubernetes client is nil, not starting status manager\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.622375 3493230 kubelet.go:2303] \"Starting kubelet main sync loop\"\r\n_**Aug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: E0814 18:33:50.623737 3493230 kubelet.go:2327] \"Skipping pod synchronization\" err=\"[container runtime status check may not have completed yet, PLEG is not healthy: pleg has yet to be successful]\"**_\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.664478 3493230 cpu_manager.go:214] \"Starting CPU manager\" policy=\"none\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.664589 3493230 cpu_manager.go:215] \"Reconciling\" reconcilePeriod=\"10s\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.664621 3493230 state_mem.go:36] \"Initialized new in-memory state store\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.666444 3493230 policy_none.go:49] \"None policy: Start\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.669409 3493230 memory_manager.go:169] \"Starting memorymanager\" policy=\"None\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.670132 3493230 state_mem.go:35] \"Initializing new in-memory state store\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.674393 3493230 manager.go:471] \"Failed to read data from checkpoint\" checkpoint=\"kubelet_internal_checkpoint\" err=\"checkpoint is not found\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.676002 3493230 plugin_manager.go:118] \"Starting Kubelet Plugin Manager\"\r\nAug 14 18:33:50 zxy-virtual-machine kubelet[3493230]: I0814 18:33:50.681451 3493230 desired_state_of_world_populator.go:159] \"Finished populating initial desired state of world\"\r\n### kubeadm version\r\nkubeadm version: &version.Info{Major:\"1\", Minor:\"28+\", GitVersion:\"v1.28.0-rc.0\", GitCommit:\"45710678b3052440fa2d18f2c22f687565632d88\", GitTreeState:\"archive\", BuildDate:\"2023-08-07T07:00:06Z\", GoVersion:\"go1.20.6\", Compiler:\"gc\", Platform:\"linux/amd64\"}\r\n### OS\r\nLinux zxy-virtual-machine 5.19.0-50-generic #50-Ubuntu SMP PREEMPT_DYNAMIC Mon Jul 10 18:24:29 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux",
"created_at": "2023-08-14 10:38:35"
},
{
"body": "[-]poststarthook/rbac/bootstrap-roles failed: reason withheld",
"created_at": "2023-08-14 11:39:44"
},
{
"body": "a better place to ask would be on the support channels. please see:\r\nhttps://git.k8s.io/kubernetes/SUPPORT.md\r\n\r\n/kind support\r\n/close ",
"created_at": "2023-08-14 13:25:02"
},
{
"body": "@neolit123: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119935#issuecomment-1677312838):\n\n>a better place to ask would be on the support channels. please see:\r\n>https://git.k8s.io/kubernetes/SUPPORT.md\r\n>\r\n>/kind support\r\n>/close \n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 13:25:08"
},
{
"body": "for kubeadm try #kubeadm on k8s slack, as well.",
"created_at": "2023-08-14 13:25:20"
}
] | [
{
"author": "zhaoxueye",
"created_at": "2023-08-14 08:49:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:49:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:49:17",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 09:15:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 09:15:09",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 13:25:08",
"type": "closed"
},
{
"author": "neolit123",
"created_at": "2023-08-14 13:25:09",
"type": "mentioned"
},
{
"author": "neolit123",
"created_at": "2023-08-14 13:25:09",
"type": "subscribed"
}
] |
119,936 | Assistance Needed: FileNotFoundException when initializing Kubernetes C# client | closed | 2023-08-14 08:31:10 | 2023-08-14 16:09:45 | 2023-08-14 16:09:44 | [] | [
"kind/support",
"needs-sig",
"needs-triage"
] | DalwadiKomal | [
{
"body": "This issue is currently awaiting triage.\n\nSIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the `triage/accepted` label.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 08:31:17"
},
{
"body": "/retitle Assistance Needed: FileNotFoundException when initializing Kubernetes C# client\r\n",
"created_at": "2023-08-14 09:15:42"
},
{
"body": "/kind support\r\n\r\n/transfer kubernetes",
"created_at": "2023-08-14 11:31:46"
},
{
"body": "There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:\n- `/sig <group-name>`\n- `/wg <group-name>`\n- `/committee <group-name>`\n\nPlease see the [group list](https://git.k8s.io/community/sig-list.md) for a listing of the SIGs, working groups, and committees available.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 11:31:55"
},
{
"body": "@DalwadiKomal, _**GitHub is not the right place for support requests**_.\r\n\r\nFor help, you could ask on [Stack Exchange](https://stackexchange.com/) instead.\r\n\r\nYou can also post your question to the [Kubernetes Slack](http://slack.k8s.io/) or the [Discuss Kubernetes](https://discuss.kubernetes.io/) forum.\r\n",
"created_at": "2023-08-14 11:33:07"
},
{
"body": "a better place to ask would be on the support channels. please see:\r\nhttps://git.k8s.io/kubernetes/SUPPORT.md\r\n\r\nor maybe log an issue in the client repository.\r\nhttps://github.com/kubernetes-client/csharp\r\n\r\n/kind support\r\n/close ",
"created_at": "2023-08-14 16:09:40"
},
{
"body": "@neolit123: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119936#issuecomment-1677628833):\n\n>a better place to ask would be on the support channels. please see:\r\n>https://git.k8s.io/kubernetes/SUPPORT.md\r\n>\r\n>or maybe log an issue in the client repository.\r\n>https://github.com/kubernetes-client/csharp\r\n>\r\n>/kind support\r\n>/close \n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 16:09:45"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:31:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 09:15:43",
"type": "renamed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 11:31:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 11:31:49",
"type": "transferred"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 11:31:54",
"type": "labeled"
},
{
"author": "DalwadiKomal",
"created_at": "2023-08-14 11:33:08",
"type": "mentioned"
},
{
"author": "DalwadiKomal",
"created_at": "2023-08-14 11:33:08",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:09:45",
"type": "closed"
},
{
"author": "neolit123",
"created_at": "2023-08-14 16:09:46",
"type": "mentioned"
},
{
"author": "neolit123",
"created_at": "2023-08-14 16:09:46",
"type": "subscribed"
}
] |
119,934 | Fix broken links to testgrid dashboard | open | 2023-08-14 08:30:31 | 2023-08-24 05:17:56 | null | [
"KnVerey",
"chenliyo99",
"rjsadow"
] | [
"kind/cleanup",
"area/kubectl",
"lgtm",
"size/XS",
"area/release-eng",
"release-note-none",
"sig/cli",
"cncf-cla: yes",
"sig/release",
"ok-to-test",
"needs-priority",
"needs-triage"
] | letmerecall | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 14 04:35:10 UTC 2023.\n",
"created_at": "2023-08-14 08:30:36"
},
{
"body": "Welcome @letmerecall! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:",
"created_at": "2023-08-14 08:30:40"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 08:30:41"
},
{
"body": "Hi @letmerecall. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-14 08:30:41"
},
{
"body": "cc: @rjsadow ",
"created_at": "2023-08-17 16:59:15"
},
{
"body": "/ok-to-test\r\n/lgtm",
"created_at": "2023-08-17 20:51:04"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 8c4502e56c297d70219bb5ccb69580084eaba7e4</details>",
"created_at": "2023-08-17 20:51:11"
},
{
"body": "/retest",
"created_at": "2023-08-17 22:12:38"
},
{
"body": "/test pull-kubernetes-e2e-gce",
"created_at": "2023-08-18 01:19:28"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119934#\" title=\"Author self-approved\">letmerecall</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119934#pullrequestreview-1585632332\" title=\"Approved\">rjsadow</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [knverey](https://github.com/knverey) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"knverey\"]} -->",
"created_at": "2023-08-19 11:50:23"
},
{
"body": "/assign @KnVerey ",
"created_at": "2023-08-19 15:51:09"
},
{
"body": "/assign",
"created_at": "2023-08-24 05:17:55"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:30:34",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:30:34",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:30:34",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:30:37",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:30:38",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:30:38",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:30:38",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:30:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:30:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:30:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:30:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:30:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:30:40",
"type": "labeled"
},
{
"author": "letmerecall",
"created_at": "2023-08-14 08:30:41",
"type": "mentioned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:30:41",
"type": "unlabeled"
},
{
"author": "letmerecall",
"created_at": "2023-08-14 08:30:41",
"type": "subscribed"
},
{
"author": "letmerecall",
"created_at": "2023-08-14 08:30:41",
"type": "mentioned"
},
{
"author": "letmerecall",
"created_at": "2023-08-14 08:30:41",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 08:30:42",
"type": "labeled"
},
{
"author": "letmerecall",
"created_at": "2023-08-14 09:08:53",
"type": "renamed"
},
{
"author": "toVersus",
"created_at": "2023-08-14 12:13:07",
"type": "unsubscribed"
},
{
"author": "rjsadow",
"created_at": "2023-08-17 16:59:15",
"type": "mentioned"
},
{
"author": "rjsadow",
"created_at": "2023-08-17 16:59:15",
"type": "subscribed"
},
{
"author": "rjsadow",
"created_at": "2023-08-17 17:02:11",
"type": "mentioned"
},
{
"author": "rjsadow",
"created_at": "2023-08-17 17:02:12",
"type": "subscribed"
},
{
"author": "rjsadow",
"created_at": "2023-08-17 17:02:32",
"type": "unsubscribed"
},
{
"author": "ardaguclu",
"created_at": "2023-08-17 17:21:18",
"type": "unsubscribed"
},
{
"author": "letmerecall",
"created_at": "2023-08-17 18:54:58",
"type": "review_requested"
},
{
"author": "letmerecall",
"created_at": "2023-08-17 18:55:00",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 20:51:06",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 20:51:06",
"type": "unlabeled"
},
{
"author": "rjsadow",
"created_at": "2023-08-17 20:51:09",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-17 20:51:10",
"type": "labeled"
},
{
"author": "letmerecall",
"created_at": "2023-08-17 21:47:52",
"type": "mentioned"
},
{
"author": "letmerecall",
"created_at": "2023-08-17 21:47:52",
"type": "subscribed"
},
{
"author": "letmerecall",
"created_at": "2023-08-17 23:14:22",
"type": "mentioned"
},
{
"author": "letmerecall",
"created_at": "2023-08-17 23:14:22",
"type": "subscribed"
},
{
"author": "KnVerey",
"created_at": "2023-08-19 15:51:09",
"type": "mentioned"
},
{
"author": "KnVerey",
"created_at": "2023-08-19 15:51:09",
"type": "subscribed"
},
{
"author": "KnVerey",
"created_at": "2023-08-19 15:51:10",
"type": "assigned"
},
{
"author": "chenliyo99",
"created_at": "2023-08-24 05:17:56",
"type": "assigned"
}
] |
119,933 | Update cri-tools to v1.28.0 | open | 2023-08-14 07:57:14 | 2023-08-14 22:08:12 | null | [
"bobbypage"
] | [
"kind/cleanup",
"lgtm",
"area/provider/gcp",
"release-note",
"size/S",
"cncf-cla: yes",
"sig/cloud-provider",
"needs-priority",
"needs-triage"
] | saschagrunert | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 14 04:35:10 UTC 2023.\n",
"created_at": "2023-08-14 07:57:18"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119933#\" title=\"Author self-approved\">saschagrunert</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [dchen1107](https://github.com/dchen1107), [mikedanese](https://github.com/mikedanese) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[build/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/build/OWNERS)**\n- **[cluster/gce/gci/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/gci/OWNERS)**\n- **[cluster/gce/windows/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/windows/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"dchen1107\",\"mikedanese\"]} -->",
"created_at": "2023-08-14 07:57:20"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 07:57:22"
},
{
"body": "/lgtm",
"created_at": "2023-08-14 22:08:05"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 1c0b8801711cd3ae9b3642b758712eac9c269271</details>",
"created_at": "2023-08-14 22:08:11"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 07:57:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 07:57:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 07:57:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 07:57:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 07:57:20",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 07:57:20",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 07:57:20",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 07:57:20",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 07:57:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 07:57:23",
"type": "labeled"
},
{
"author": "toVersus",
"created_at": "2023-08-14 13:19:21",
"type": "unsubscribed"
},
{
"author": "bobbypage",
"created_at": "2023-08-14 22:08:09",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 22:08:10",
"type": "labeled"
}
] |
119,932 | Automated cherry pick of #119128: Issue 4230: remove readiness check for cache exclusion | open | 2023-08-14 05:44:36 | 2023-08-21 23:13:55 | null | [
"feiskyer"
] | [
"kind/bug",
"lgtm",
"area/cloudprovider",
"size/M",
"approved",
"cncf-cla: yes",
"do-not-merge/cherry-pick-not-approved",
"sig/cloud-provider",
"needs-priority",
"triage/accepted"
] | lzhecheng | [
{
"body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 05:44:38"
},
{
"body": "/lgtm",
"created_at": "2023-08-14 05:58:30"
},
{
"body": "LGTM label has been added. <details>Git tree hash: bbd015985b2c02d8b0d740424ba2f72c3e4666da</details>",
"created_at": "2023-08-14 05:58:37"
},
{
"body": "/triage accepted\r\n",
"created_at": "2023-08-14 15:32:59"
},
{
"body": "/approve",
"created_at": "2023-08-21 19:12:03"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119932#issuecomment-1686882313\" title=\"Approved\">andrewsykim</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119932#\" title=\"Author self-approved\">lzhecheng</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/legacy-cloud-providers/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.26/staging/src/k8s.io/legacy-cloud-providers/OWNERS)~~ [andrewsykim]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-21 19:16:37"
},
{
"body": "/cc kubernetes/release-managers",
"created_at": "2023-08-21 20:04:30"
},
{
"body": "Note: per the SIG meeting, we are not backporting to 1.25: https://github.com/kubernetes/kubernetes/pull/119128#issuecomment-1662533393",
"created_at": "2023-08-21 20:05:54"
},
{
"body": "/kind bug",
"created_at": "2023-08-21 23:13:51"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:38",
"type": "milestoned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:38",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:38",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:44",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:50",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:45:11",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:45:11",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:45:11",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:45:12",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:45:14",
"type": "unlabeled"
},
{
"author": "feiskyer",
"created_at": "2023-08-14 05:58:34",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:58:35",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 15:33:01",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 15:33:03",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 19:16:38",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 20:04:31",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 23:13:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 23:13:55",
"type": "unlabeled"
}
] |
119,931 | Automated cherry pick of #119128: Issue 4230: remove readiness check for cache exclusion | open | 2023-08-14 05:43:55 | 2023-08-21 23:14:02 | null | [
"feiskyer"
] | [
"kind/bug",
"lgtm",
"area/cloudprovider",
"size/M",
"approved",
"cncf-cla: yes",
"do-not-merge/cherry-pick-not-approved",
"sig/cloud-provider",
"needs-priority",
"triage/accepted"
] | lzhecheng | [
{
"body": "This cherry pick PR is for a release branch and has not yet been approved by [Release Managers](https://k8s.io/releases/release-managers).\nAdding the `do-not-merge/cherry-pick-not-approved` label.\n\nTo merge this cherry pick, it must first be approved (`/lgtm` + `/approve`) by the relevant OWNERS.\n\nIf you **didn't cherry-pick** this change to [**all supported release branches**](https://k8s.io/releases/patch-releases), please leave a comment describing why other cherry-picks are not needed to speed up the review process.\n\nIf you're not sure is it required to cherry-pick this change to all supported release branches, please consult the [cherry-pick guidelines](https://git.k8s.io/community/contributors/devel/sig-release/cherry-picks.md) document.\n\n**AFTER** it has been approved by code owners, please leave the following comment on a line **by itself, with no leading whitespace**: **/cc kubernetes/release-managers**\n\n(This command will request a cherry pick review from [Release Managers](https://github.com/orgs/kubernetes/teams/release-managers) and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)\n\nFor details on the patch release process and schedule, see the [Patch Releases](https://k8s.io/releases/patch-releases) page.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 05:43:58"
},
{
"body": "/lgtm",
"created_at": "2023-08-14 05:58:41"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 2fb24b09abc8e6ea227e23507a6b85891ec8aae2</details>",
"created_at": "2023-08-14 05:58:49"
},
{
"body": "/retest",
"created_at": "2023-08-14 09:26:24"
},
{
"body": "/triage accepted\r\n",
"created_at": "2023-08-14 15:33:17"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119931#pullrequestreview-1587695461\" title=\"Approved\">andrewsykim</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119931#\" title=\"Author self-approved\">lzhecheng</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/legacy-cloud-providers/OWNERS](https://github.com/kubernetes/kubernetes/blob/release-1.27/staging/src/k8s.io/legacy-cloud-providers/OWNERS)~~ [andrewsykim]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-21 19:16:24"
},
{
"body": "/cc kubernetes/release-managers",
"created_at": "2023-08-21 20:04:15"
},
{
"body": "Note: per the SIG meeting, we are not backporting to 1.25: https://github.com/kubernetes/kubernetes/pull/119128#issuecomment-1662533393",
"created_at": "2023-08-21 20:05:48"
},
{
"body": "/kind bug",
"created_at": "2023-08-21 23:13:58"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:43:57",
"type": "milestoned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:43:57",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:43:57",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:02",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:04",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:05",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:31",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:31",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:44:34",
"type": "unlabeled"
},
{
"author": "feiskyer",
"created_at": "2023-08-14 05:58:46",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 05:58:47",
"type": "labeled"
},
{
"author": "lzhecheng",
"created_at": "2023-08-14 06:12:03",
"type": "mentioned"
},
{
"author": "lzhecheng",
"created_at": "2023-08-14 06:12:03",
"type": "subscribed"
},
{
"author": "lzhecheng",
"created_at": "2023-08-14 06:19:27",
"type": "mentioned"
},
{
"author": "lzhecheng",
"created_at": "2023-08-14 06:19:28",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 15:33:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 15:33:21",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 19:16:25",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 20:04:16",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 23:14:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-21 23:14:02",
"type": "unlabeled"
}
] |
119,930 | Tolerate more api types.go files to generate code in code-generator kube_codegen.sh | open | 2023-08-14 03:13:57 | 2023-08-16 14:56:40 | null | [
"sttts",
"wojtek-t"
] | [
"sig/api-machinery",
"kind/feature",
"triage/accepted"
] | poneding | [
{
"body": "/sig api-machinery\r\n",
"created_at": "2023-08-14 16:10:16"
},
{
"body": "/triage accepted\r\n/assign @sttts @wojtek-t \r\n\r\nsince you are OWNERS of code-generator",
"created_at": "2023-08-15 20:02:08"
},
{
"body": "Sounds reasonable. Can you create a PR ?",
"created_at": "2023-08-16 10:28:57"
}
] | [
{
"author": "poneding",
"created_at": "2023-08-14 03:13:57",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 03:14:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 03:14:04",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:10:18",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:10:19",
"type": "unlabeled"
},
{
"author": "sttts",
"created_at": "2023-08-15 20:02:08",
"type": "mentioned"
},
{
"author": "sttts",
"created_at": "2023-08-15 20:02:09",
"type": "subscribed"
},
{
"author": "wojtek-t",
"created_at": "2023-08-15 20:02:09",
"type": "mentioned"
},
{
"author": "wojtek-t",
"created_at": "2023-08-15 20:02:09",
"type": "subscribed"
},
{
"author": "sttts",
"created_at": "2023-08-15 20:22:26",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:22:26",
"type": "labeled"
},
{
"author": "wojtek-t",
"created_at": "2023-08-15 20:22:26",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:22:42",
"type": "unlabeled"
},
{
"author": "poneding",
"created_at": "2023-08-16 14:56:40",
"type": "renamed"
}
] |
119,929 | fix: update min max scaling when select policy is disabled | open | 2023-08-13 21:08:34 | 2023-08-14 13:51:15 | null | [] | [
"kind/bug",
"area/test",
"sig/autoscaling",
"size/M",
"sig/apps",
"cncf-cla: yes",
"sig/testing",
"do-not-merge/release-note-label-needed",
"needs-priority",
"needs-triage"
] | AhmedGrati | [
{
"body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-13 21:08:36"
},
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Aug 13 16:37:03 UTC 2023.\n",
"created_at": "2023-08-13 21:08:38"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-13 21:08:41"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119929#\" title=\"Author self-approved\">AhmedGrati</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [mwielgus](https://github.com/mwielgus) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/controller/podautoscaler/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/podautoscaler/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"mwielgus\"]} -->",
"created_at": "2023-08-14 10:48:18"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 21:08:36",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 21:08:36",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 21:08:36",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 21:08:37",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 21:08:38",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 21:08:39",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 21:08:39",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 21:08:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 21:08:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 21:08:41",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 21:08:42",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 22:13:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 22:13:40",
"type": "labeled"
},
{
"author": "AhmedGrati",
"created_at": "2023-08-14 01:10:56",
"type": "mentioned"
},
{
"author": "AhmedGrati",
"created_at": "2023-08-14 01:10:57",
"type": "subscribed"
},
{
"author": "AhmedGrati",
"created_at": "2023-08-14 09:31:33",
"type": "head_ref_force_pushed"
},
{
"author": "AhmedGrati",
"created_at": "2023-08-14 10:41:32",
"type": "mentioned"
},
{
"author": "AhmedGrati",
"created_at": "2023-08-14 10:41:32",
"type": "subscribed"
},
{
"author": "AhmedGrati",
"created_at": "2023-08-14 10:48:12",
"type": "head_ref_force_pushed"
},
{
"author": "AhmedGrati",
"created_at": "2023-08-14 10:48:50",
"type": "head_ref_force_pushed"
},
{
"author": "AhmedGrati",
"created_at": "2023-08-14 11:09:43",
"type": "renamed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 11:09:45",
"type": "unlabeled"
}
] |
119,928 | e2e WaitForServiceEndpointsNum take into account the address family | closed | 2023-08-13 17:48:36 | 2023-08-16 07:24:29 | 2023-08-16 07:24:27 | [
"dims",
"liggitt"
] | [
"kind/bug",
"area/test",
"lgtm",
"size/M",
"release-note-none",
"approved",
"cncf-cla: yes",
"sig/testing",
"kind/failing-test",
"needs-priority",
"area/e2e-test-framework",
"kind/regression",
"needs-triage"
] | aojea | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Aug 13 16:37:03 UTC 2023.\n",
"created_at": "2023-08-13 17:48:40"
},
{
"body": "/test",
"created_at": "2023-08-13 17:48:41"
},
{
"body": "@aojea: The `/test` command needs one or more targets.\nThe following commands are available to trigger required jobs:\n* `/test pull-cadvisor-e2e-kubernetes`\n* `/test pull-kubernetes-conformance-kind-ga-only-parallel`\n* `/test pull-kubernetes-coverage-unit`\n* `/test pull-kubernetes-dependencies`\n* `/test pull-kubernetes-dependencies-go-canary`\n* `/test pull-kubernetes-e2e-gce`\n* `/test pull-kubernetes-e2e-gce-100-performance`\n* `/test pull-kubernetes-e2e-gce-big-performance`\n* `/test pull-kubernetes-e2e-gce-canary`\n* `/test pull-kubernetes-e2e-gce-cos`\n* `/test pull-kubernetes-e2e-gce-cos-canary`\n* `/test pull-kubernetes-e2e-gce-cos-no-stage`\n* `/test pull-kubernetes-e2e-gce-network-proxy-http-connect`\n* `/test pull-kubernetes-e2e-gce-scale-performance-manual`\n* `/test pull-kubernetes-e2e-kind`\n* `/test pull-kubernetes-e2e-kind-ipv6`\n* `/test pull-kubernetes-integration`\n* `/test pull-kubernetes-integration-go-canary`\n* `/test pull-kubernetes-kubemark-e2e-gce-scale`\n* `/test pull-kubernetes-node-e2e-containerd`\n* `/test pull-kubernetes-typecheck`\n* `/test pull-kubernetes-unit`\n* `/test pull-kubernetes-unit-go-canary`\n* `/test pull-kubernetes-update`\n* `/test pull-kubernetes-verify`\n* `/test pull-kubernetes-verify-go-canary`\n\nThe following commands are available to trigger optional jobs:\n* `/test check-dependency-stats`\n* `/test pull-ci-kubernetes-unit-windows`\n* `/test pull-e2e-gce-cloud-provider-disabled`\n* `/test pull-kubernetes-conformance-image-test`\n* `/test pull-kubernetes-conformance-kind-ga-only`\n* `/test pull-kubernetes-conformance-kind-ipv6-parallel`\n* `/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e`\n* `/test pull-kubernetes-cos-cgroupv1-containerd-node-e2e-features`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-eviction`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-features`\n* `/test pull-kubernetes-cos-cgroupv2-containerd-node-e2e-serial`\n* `/test pull-kubernetes-cross`\n* `/test pull-kubernetes-e2e-autoscaling-hpa-cm`\n* `/test pull-kubernetes-e2e-autoscaling-hpa-cpu`\n* `/test pull-kubernetes-e2e-capz-azure-disk`\n* `/test pull-kubernetes-e2e-capz-azure-disk-vmss`\n* `/test pull-kubernetes-e2e-capz-azure-file`\n* `/test pull-kubernetes-e2e-capz-azure-file-vmss`\n* `/test pull-kubernetes-e2e-capz-conformance`\n* `/test pull-kubernetes-e2e-capz-windows`\n* `/test pull-kubernetes-e2e-capz-windows-alpha-feature-vpa`\n* `/test pull-kubernetes-e2e-capz-windows-alpha-features`\n* `/test pull-kubernetes-e2e-capz-windows-serial-slow-hpa`\n* `/test pull-kubernetes-e2e-containerd-gce`\n* `/test pull-kubernetes-e2e-ec2`\n* `/test pull-kubernetes-e2e-gce-correctness`\n* `/test pull-kubernetes-e2e-gce-cos-alpha-features`\n* `/test pull-kubernetes-e2e-gce-cos-kubetest2`\n* `/test pull-kubernetes-e2e-gce-csi-serial`\n* `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\n* `/test pull-kubernetes-e2e-gce-kubelet-credential-provider`\n* `/test pull-kubernetes-e2e-gce-network-proxy-grpc`\n* `/test pull-kubernetes-e2e-gce-serial`\n* `/test pull-kubernetes-e2e-gce-storage-disruptive`\n* `/test pull-kubernetes-e2e-gce-storage-slow`\n* `/test pull-kubernetes-e2e-gce-storage-snapshot`\n* `/test pull-kubernetes-e2e-gci-gce-autoscaling`\n* `/test pull-kubernetes-e2e-gci-gce-ingress`\n* `/test pull-kubernetes-e2e-gci-gce-ipvs`\n* `/test pull-kubernetes-e2e-inplace-pod-resize-containerd-main-v2`\n* `/test pull-kubernetes-e2e-kind-alpha-features`\n* `/test pull-kubernetes-e2e-kind-canary`\n* `/test pull-kubernetes-e2e-kind-dual-canary`\n* `/test pull-kubernetes-e2e-kind-ipv6-canary`\n* `/test pull-kubernetes-e2e-kind-ipvs-dual-canary`\n* `/test pull-kubernetes-e2e-kind-kms`\n* `/test pull-kubernetes-e2e-kind-multizone`\n* `/test pull-kubernetes-e2e-kops-aws`\n* `/test pull-kubernetes-e2e-storage-kind-disruptive`\n* `/test pull-kubernetes-e2e-ubuntu-gce-network-policies`\n* `/test pull-kubernetes-integration-eks`\n* `/test pull-kubernetes-kind-dra`\n* `/test pull-kubernetes-kind-json-logging`\n* `/test pull-kubernetes-kind-text-logging`\n* `/test pull-kubernetes-kubemark-e2e-gce-big`\n* `/test pull-kubernetes-local-e2e`\n* `/test pull-kubernetes-node-arm64-e2e-containerd-ec2`\n* `/test pull-kubernetes-node-arm64-e2e-containerd-serial-ec2`\n* `/test pull-kubernetes-node-arm64-ubuntu-serial-gce`\n* `/test pull-kubernetes-node-crio-cgrpv1-evented-pleg-e2e`\n* `/test pull-kubernetes-node-crio-cgrpv2-e2e`\n* `/test pull-kubernetes-node-crio-cgrpv2-e2e-kubetest2`\n* `/test pull-kubernetes-node-crio-e2e`\n* `/test pull-kubernetes-node-crio-e2e-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-alpha-features`\n* `/test pull-kubernetes-node-e2e-containerd-ec2`\n* `/test pull-kubernetes-node-e2e-containerd-features`\n* `/test pull-kubernetes-node-e2e-containerd-features-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-kubetest2`\n* `/test pull-kubernetes-node-e2e-containerd-serial-ec2`\n* `/test pull-kubernetes-node-e2e-containerd-sidecar-containers`\n* `/test pull-kubernetes-node-e2e-containerd-standalone-mode`\n* `/test pull-kubernetes-node-e2e-containerd-standalone-mode-all-alpha`\n* `/test pull-kubernetes-node-e2e-crio-dra`\n* `/test pull-kubernetes-node-kubelet-credential-provider`\n* `/test pull-kubernetes-node-kubelet-serial-containerd`\n* `/test pull-kubernetes-node-kubelet-serial-containerd-kubetest2`\n* `/test pull-kubernetes-node-kubelet-serial-cpu-manager`\n* `/test pull-kubernetes-node-kubelet-serial-cpu-manager-kubetest2`\n* `/test pull-kubernetes-node-kubelet-serial-crio-cgroupv1`\n* `/test pull-kubernetes-node-kubelet-serial-crio-cgroupv2`\n* `/test pull-kubernetes-node-kubelet-serial-hugepages`\n* `/test pull-kubernetes-node-kubelet-serial-memory-manager`\n* `/test pull-kubernetes-node-kubelet-serial-pod-disruption-conditions`\n* `/test pull-kubernetes-node-kubelet-serial-topology-manager`\n* `/test pull-kubernetes-node-kubelet-serial-topology-manager-kubetest2`\n* `/test pull-kubernetes-node-memoryqos-cgrpv2`\n* `/test pull-kubernetes-node-swap-fedora`\n* `/test pull-kubernetes-node-swap-fedora-serial`\n* `/test pull-kubernetes-node-swap-ubuntu-serial`\n* `/test pull-kubernetes-unit-experimental`\n* `/test pull-kubernetes-verify-strict-lint`\n* `/test pull-publishing-bot-validate`\n\nUse `/test all` to run the following jobs that were automatically triggered:\n* `pull-kubernetes-conformance-kind-ga-only-parallel`\n* `pull-kubernetes-conformance-kind-ipv6-parallel`\n* `pull-kubernetes-dependencies`\n* `pull-kubernetes-e2e-gce`\n* `pull-kubernetes-e2e-kind`\n* `pull-kubernetes-e2e-kind-ipv6`\n* `pull-kubernetes-integration`\n* `pull-kubernetes-node-e2e-containerd`\n* `pull-kubernetes-typecheck`\n* `pull-kubernetes-unit`\n* `pull-kubernetes-verify`\n\n\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119928#issuecomment-1676422970):\n\n>/test\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-13 17:48:43"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-13 17:48:44"
},
{
"body": "/test pull-kubernetes-e2e-kind-dual-canary\r\n/test pull-kubernetes-e2e-kind-ipv6-canary\r\n/test pull-kubernetes-e2e-kind-ipvs-dual-canary",
"created_at": "2023-08-13 17:49:10"
},
{
"body": "> Kubernetes e2e suite: [It] [sig-storage] HostPath should give a volume the correct mode [LinuxOnly] [NodeConformance] expand_less\t\r\n\r\nfailures is unrelated, this is good, the dual stack test pass now\r\n\r\n/assign @liggitt @dims ",
"created_at": "2023-08-13 20:30:53"
},
{
"body": "i like it. \r\n\r\n/approve\r\n/lgtm",
"created_at": "2023-08-14 00:14:01"
},
{
"body": "LGTM label has been added. <details>Git tree hash: dbc756ca0e2b2d422c74dfd6846f2c5faa8efa9f</details>",
"created_at": "2023-08-14 00:14:07"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119928#\" title=\"Author self-approved\">aojea</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119928#issuecomment-1676506208\" title=\"LGTM\">dims</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/e2e/framework/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/framework/OWNERS)~~ [aojea,dims]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-14 00:14:07"
},
{
"body": "/test pull-kubernetes-e2e-kind-dual-canary\r\n/test pull-kubernetes-e2e-kind-ipv6-canary\r\n/test pull-kubernetes-e2e-kind-ipvs-dual-canary",
"created_at": "2023-08-14 16:54:13"
},
{
"body": "@aojea: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-e2e-kind-ipv6-canary | f91b2ec93dbf56ea05df11a0a1257d768dedbb19 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119928/pull-kubernetes-e2e-kind-ipv6-canary/1690782567483052032) | false | `/test pull-kubernetes-e2e-kind-ipv6-canary`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119928). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Aaojea). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"created_at": "2023-08-14 17:44:56"
},
{
"body": "> Kubernetes e2e suite: [It] [sig-network] Conntrack should be able to preserve UDP traffic when server pod cycles for a ClusterIP service expand_less\t\r\n/test pull-kubernetes-e2e-kind\r\n\r\n\r\n> k8s.io/kubernetes/pkg/kubelet/cm: dra expand_less\t3m0s\r\n> {Failed;Failed; === RUN TestUnprepareResouces/should_timeout\r\n> I0814 17:21:29.495010 43607 plugin.go:47] \"Register new DRA plugin\" name=\"test-cdi-device\" endpoint=\"/tmp/dra2994399569/server.sock\"\r\n> manager_test.go:1005: \r\n> \tError Trace:\t/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/kubelet/cm/dra/manager_test.go:1005\r\n> \tError: \tAn error is expected but got nil.\r\n> \tTest: \tTestUnprepareResouces/should_timeout\r\n> I0814 17:22:14.546518 43607 plugin.go:158] \"DeRegister DRA plugin\" name=\"test-cdi-device\"\r\n> --- FAIL: TestUnprepareResouces/should_timeout (45.05s)\r\n> ;=== RUN TestUnprepareResouces\r\n> --- FAIL: TestUnprepareResouces (45.07s)\r\n\r\n/test pull-kubernetes-e2e-kind\r\n",
"created_at": "2023-08-14 17:58:21"
},
{
"body": "```\r\n\r\n\r\nk8s.io/kubernetes/pkg/kubelet/cm: dra expand_less | 3m0s\r\n-- | --\r\n{Failed;Failed; === RUN TestUnprepareResouces/should_timeout I0814 17:21:29.495010 43607 plugin.go:47] \"Register new DRA plugin\" name=\"test-cdi-device\" endpoint=\"/tmp/dra2994399569/server.sock\" manager_test.go:1005: \tError Trace:\t/home/prow/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/kubelet/cm/dra/manager_test.go:1005 \tError: \tAn error is expected but got nil. \tTest: \tTestUnprepareResouces/should_timeout I0814 17:22:14.546518 43607 plugin.go:158] \"DeRegister DRA plugin\" name=\"test-cdi-device\" --- FAIL: TestUnprepareResouces/should_timeout (45.05s) ;=== RUN TestUnprepareResouces --- FAIL: TestUnprepareResouces (45.07s) ;}\r\n\r\n\r\n```\r\n\r\ndo we have an issue to track this flake?\r\n\r\n/retest\r\n\r\n",
"created_at": "2023-08-15 09:18:19"
},
{
"body": "I can't see it failing in https://storage.googleapis.com/k8s-triage/index.html?pr=1&test=TestUnprepareResouces 🤔 \r\n\r\n@pacoxu @pohly did you notice something with this unit test `TestUnprepareResouces` under `k8s.io/kubernetes/pkg/kubelet/cm: dra` ?\r\n\r\nIt failed twice in this PR that is completely unrelated",
"created_at": "2023-08-15 09:22:34"
},
{
"body": "> did you notice something with this unit test TestUnprepareResouces under k8s.io/kubernetes/pkg/kubelet/cm: dra ?\r\n\r\nYes, and a PR is pending: https://github.com/kubernetes/kubernetes/pull/119709\r\n\r\n",
"created_at": "2023-08-15 16:23:38"
},
{
"body": "/lgtm",
"created_at": "2023-08-16 01:30:39"
},
{
"body": "LGTM label has been added. <details>Git tree hash: d8e504ff8cb87e87f8c113923df78ac04d8f60d0</details>",
"created_at": "2023-08-16 01:30:45"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:48:37",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:48:38",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:48:38",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:48:38",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:48:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:48:40",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:48:41",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:48:41",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:48:41",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:48:42",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:48:42",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:48:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:48:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:48:43",
"type": "labeled"
},
{
"author": "aojea",
"created_at": "2023-08-13 17:48:44",
"type": "mentioned"
},
{
"author": "aojea",
"created_at": "2023-08-13 17:48:44",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:48:44",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:48:45",
"type": "labeled"
},
{
"author": "aojea",
"created_at": "2023-08-13 18:26:03",
"type": "mentioned"
},
{
"author": "aojea",
"created_at": "2023-08-13 18:26:03",
"type": "subscribed"
},
{
"author": "dims",
"created_at": "2023-08-13 20:30:53",
"type": "mentioned"
},
{
"author": "dims",
"created_at": "2023-08-13 20:30:53",
"type": "subscribed"
},
{
"author": "liggitt",
"created_at": "2023-08-13 20:30:53",
"type": "mentioned"
},
{
"author": "liggitt",
"created_at": "2023-08-13 20:30:53",
"type": "subscribed"
},
{
"author": "dims",
"created_at": "2023-08-13 20:30:54",
"type": "assigned"
},
{
"author": "liggitt",
"created_at": "2023-08-13 20:30:54",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 00:14:06",
"type": "labeled"
},
{
"author": "aojea",
"created_at": "2023-08-14 16:11:20",
"type": "head_ref_force_pushed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:11:22",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:11:22",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:11:23",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:11:23",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:11:23",
"type": "review_requested"
},
{
"author": "aojea",
"created_at": "2023-08-14 17:03:02",
"type": "head_ref_force_pushed"
},
{
"author": "aojea",
"created_at": "2023-08-14 17:35:23",
"type": "mentioned"
},
{
"author": "aojea",
"created_at": "2023-08-14 17:35:23",
"type": "subscribed"
},
{
"author": "aojea",
"created_at": "2023-08-14 17:44:57",
"type": "mentioned"
},
{
"author": "aojea",
"created_at": "2023-08-14 17:44:57",
"type": "subscribed"
},
{
"author": "pohly",
"created_at": "2023-08-15 09:22:34",
"type": "mentioned"
},
{
"author": "pohly",
"created_at": "2023-08-15 09:22:34",
"type": "subscribed"
},
{
"author": "pacoxu",
"created_at": "2023-08-15 09:22:34",
"type": "mentioned"
},
{
"author": "pacoxu",
"created_at": "2023-08-15 09:22:34",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 01:30:44",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:24:27",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:24:27",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:24:27",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:24:29",
"type": "milestoned"
}
] |
119,927 | Dual Stack tests are broken | closed | 2023-08-13 17:46:22 | 2023-08-16 07:24:28 | 2023-08-16 07:24:28 | [
"aojea"
] | [
"sig/network",
"sig/testing",
"kind/failing-test",
"needs-triage"
] | aojea | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-13 17:46:29"
}
] | [
{
"author": "aojea",
"created_at": "2023-08-13 17:46:22",
"type": "labeled"
},
{
"author": "aojea",
"created_at": "2023-08-13 17:46:23",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:46:24",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:46:24",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 17:46:28",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 07:24:28",
"type": "closed"
}
] |
119,926 | dynamically provision the PVs for cloud provider e2e tests | open | 2023-08-13 16:09:57 | 2023-08-16 16:23:21 | null | [] | [
"area/test",
"kind/cleanup",
"sig/storage",
"size/L",
"release-note-none",
"cncf-cla: yes",
"sig/testing",
"needs-priority",
"needs-triage"
] | HirazawaUi | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Aug 13 10:37:24 UTC 2023.\n",
"created_at": "2023-08-13 16:10:00"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119926#\" title=\"Author self-approved\">HirazawaUi</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [gnufied](https://github.com/gnufied) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[test/e2e/storage/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"gnufied\"]} -->",
"created_at": "2023-08-13 16:10:02"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-13 16:10:05"
},
{
"body": "Please guide me on using the comments starting with '/' to effect specific platforn tasks like testing and code execution.",
"created_at": "2023-08-13 17:34:52"
},
{
"body": "/retest",
"created_at": "2023-08-14 14:50:01"
},
{
"body": "> Please guide me on using the comments starting with '/' to effect specific platforn tasks like testing and code execution.\r\n\r\nYou might get something helpful from: https://prow.k8s.io/command-help?repo=kubernetes%2Fkubernetes",
"created_at": "2023-08-14 14:53:28"
},
{
"body": "/test pull-kubernetes-node-e2e-containerd",
"created_at": "2023-08-14 16:09:25"
},
{
"body": "/test pull-kubernetes-integration",
"created_at": "2023-08-16 15:25:10"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 16:09:58",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 16:09:58",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 16:09:58",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 16:10:01",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 16:10:02",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 16:10:02",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 16:10:02",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 16:10:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 16:10:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 16:10:04",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 16:10:04",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 16:10:05",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 16:10:07",
"type": "labeled"
},
{
"author": "msau42",
"created_at": "2023-08-13 16:11:50",
"type": "mentioned"
},
{
"author": "msau42",
"created_at": "2023-08-13 16:11:50",
"type": "subscribed"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-13 16:37:58",
"type": "mentioned"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-13 16:37:58",
"type": "subscribed"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-13 16:43:51",
"type": "mentioned"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-13 16:43:52",
"type": "subscribed"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-13 16:58:46",
"type": "mentioned"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-13 16:58:46",
"type": "subscribed"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-13 17:11:12",
"type": "mentioned"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-13 17:11:12",
"type": "subscribed"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-14 14:49:40",
"type": "head_ref_force_pushed"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-14 15:15:17",
"type": "mentioned"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-14 15:15:17",
"type": "subscribed"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-16 10:35:39",
"type": "head_ref_force_pushed"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-16 11:09:08",
"type": "mentioned"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-16 11:09:09",
"type": "subscribed"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-16 11:13:32",
"type": "head_ref_force_pushed"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-16 11:45:37",
"type": "mentioned"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-16 11:45:37",
"type": "subscribed"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-16 12:11:26",
"type": "mentioned"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-16 12:11:26",
"type": "subscribed"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-16 13:01:16",
"type": "head_ref_force_pushed"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-16 13:59:45",
"type": "mentioned"
},
{
"author": "HirazawaUi",
"created_at": "2023-08-16 13:59:45",
"type": "subscribed"
}
] |
119,925 | commit by harsh in read.me | closed | 2023-08-13 13:11:01 | 2023-08-13 16:54:18 | 2023-08-13 16:54:18 | [] | [
"size/XS",
"cncf-cla: no",
"needs-ok-to-test",
"do-not-merge/release-note-label-needed",
"needs-priority",
"needs-triage",
"do-not-merge/needs-sig",
"do-not-merge/needs-kind"
] | harsh2478 | [
{
"body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-13 13:11:03"
},
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Aug 13 10:37:24 UTC 2023.\n",
"created_at": "2023-08-13 13:11:04"
},
{
"body": " <a href=\"https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/18706487/20580498/119925/#/?version=2\"><img src=\"https://s3.amazonaws.com/cla-project-logo-prod/cla-not-signed.svg\" alt=\"CLA Not Signed\" align=\"left\" height=\"28\" width=\"328\"></a><br/><br /><ul><li><a href='https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/18706487/20580498/119925/#/?version=2' target='_blank'>:x:</a> - login: @harsh2478 . The commit (cd0c1ca821b33e96ca6c03dbdc7c4f0af9f766d7) is not authorized under a signed CLA. <a href='https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/18706487/20580498/119925/#/?version=2' target='_blank'>Please click here to be authorized</a>. For further assistance with EasyCLA, <a href='https://jira.linuxfoundation.org/servicedesk/customer/portal/4' target='_blank'>please submit a support request ticket</a>.</li></ul>",
"created_at": "2023-08-13 13:11:05"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119925#\" title=\"Author self-approved\">harsh2478</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [bentheelder](https://github.com/bentheelder) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/kubernetes/kubernetes/blob/master/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"bentheelder\"]} -->",
"created_at": "2023-08-13 13:11:07"
},
{
"body": "Welcome @harsh2478! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:",
"created_at": "2023-08-13 13:11:09"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-13 13:11:10"
},
{
"body": "Hi @harsh2478. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-13 13:11:10"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 13:11:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 13:11:04",
"type": "labeled"
},
{
"author": "harsh2478",
"created_at": "2023-08-13 13:11:05",
"type": "mentioned"
},
{
"author": "harsh2478",
"created_at": "2023-08-13 13:11:05",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 13:11:06",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 13:11:06",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 13:11:07",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 13:11:08",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 13:11:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 13:11:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 13:11:09",
"type": "labeled"
},
{
"author": "harsh2478",
"created_at": "2023-08-13 13:11:09",
"type": "mentioned"
},
{
"author": "harsh2478",
"created_at": "2023-08-13 13:11:09",
"type": "subscribed"
},
{
"author": "harsh2478",
"created_at": "2023-08-13 13:11:10",
"type": "mentioned"
},
{
"author": "harsh2478",
"created_at": "2023-08-13 13:11:10",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 13:11:11",
"type": "labeled"
},
{
"author": "dims",
"created_at": "2023-08-13 16:54:18",
"type": "closed"
},
{
"author": "toVersus",
"created_at": "2023-08-14 12:20:06",
"type": "unsubscribed"
}
] |
119,924 | chore(apimachinery): deprecate meta.UnsafeGuessKindToResource | open | 2023-08-13 11:36:23 | 2023-08-22 14:01:50 | null | [] | [
"area/test",
"kind/cleanup",
"area/kubectl",
"sig/api-machinery",
"release-note",
"size/L",
"sig/cli",
"cncf-cla: yes",
"sig/instrumentation",
"sig/testing",
"ok-to-test",
"needs-priority",
"area/dependency",
"kind/deprecation",
"triage/accepted"
] | pmalek | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Aug 13 10:37:24 UTC 2023.\n",
"created_at": "2023-08-13 11:36:27"
},
{
"body": "Hi @pmalek. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-13 11:36:32"
},
{
"body": "/ok-to-test",
"created_at": "2023-08-14 06:36:59"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119924#\" title=\"Author self-approved\">pmalek</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [liggitt](https://github.com/liggitt) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/kubernetes/kubernetes/blob/master/OWNERS)**\n- **[staging/src/k8s.io/apimachinery/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/OWNERS)**\n- **[staging/src/k8s.io/client-go/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/OWNERS)**\n- **[staging/src/k8s.io/kubectl/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/OWNERS)**\n- **[staging/src/k8s.io/metrics/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/metrics/OWNERS)**\n- **[test/integration/apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/integration/apiserver/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"liggitt\"]} -->",
"created_at": "2023-08-14 09:10:57"
},
{
"body": "/test pull-kubernetes-unit",
"created_at": "2023-08-14 09:28:28"
},
{
"body": "/retest-required",
"created_at": "2023-08-14 09:39:05"
},
{
"body": "I've checked locally an all UTs pass but there are some build related errors that I'm not sure what they are about. Can someone guide me how to approach this? https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119924/pull-kubernetes-unit/1691019004237320192\r\n\r\n",
"created_at": "2023-08-14 10:20:22"
},
{
"body": "/triage accepted",
"created_at": "2023-08-15 20:07:32"
},
{
"body": "@pmalek: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-integration | 4d1cf448e9c2b84b3fb5193d9a0102e51a32b863 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119924/pull-kubernetes-integration/1692863053776818176) | true | `/test pull-kubernetes-integration`\npull-kubernetes-e2e-gce | 4d1cf448e9c2b84b3fb5193d9a0102e51a32b863 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119924/pull-kubernetes-e2e-gce/1692863053739069440/) | true | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-conformance-kind-ipv6-parallel | 4d1cf448e9c2b84b3fb5193d9a0102e51a32b863 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119924/pull-kubernetes-conformance-kind-ipv6-parallel/1692863053638406144) | false | `/test pull-kubernetes-conformance-kind-ipv6-parallel`\npull-kubernetes-node-e2e-containerd | 4d1cf448e9c2b84b3fb5193d9a0102e51a32b863 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119924/pull-kubernetes-node-e2e-containerd/1692863054057836544/) | true | `/test pull-kubernetes-node-e2e-containerd`\npull-kubernetes-dependencies | 4d1cf448e9c2b84b3fb5193d9a0102e51a32b863 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119924/pull-kubernetes-dependencies/1692863053684543488) | true | `/test pull-kubernetes-dependencies`\npull-kubernetes-e2e-kind | 4d1cf448e9c2b84b3fb5193d9a0102e51a32b863 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119924/pull-kubernetes-e2e-kind/1692863053860704256) | true | `/test pull-kubernetes-e2e-kind`\npull-kubernetes-conformance-kind-ga-only-parallel | 4d1cf448e9c2b84b3fb5193d9a0102e51a32b863 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119924/pull-kubernetes-conformance-kind-ga-only-parallel/1692863053961367552) | true | `/test pull-kubernetes-conformance-kind-ga-only-parallel`\npull-kubernetes-e2e-kind-ipv6 | 4d1cf448e9c2b84b3fb5193d9a0102e51a32b863 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119924/pull-kubernetes-e2e-kind-ipv6/1692863053919424512) | true | `/test pull-kubernetes-e2e-kind-ipv6`\npull-kubernetes-verify | 4d1cf448e9c2b84b3fb5193d9a0102e51a32b863 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119924/pull-kubernetes-verify/1692863055307739136) | true | `/test pull-kubernetes-verify`\npull-kubernetes-unit | 4d1cf448e9c2b84b3fb5193d9a0102e51a32b863 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119924/pull-kubernetes-unit/1692863053999116288) | true | `/test pull-kubernetes-unit`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119924). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Apmalek). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"created_at": "2023-08-19 12:19:33"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 11:36:25",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 11:36:25",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 11:36:25",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 11:36:26",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 11:36:28",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 11:36:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 11:36:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 11:36:30",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 11:36:30",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 11:36:31",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 11:36:31",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 11:36:31",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 11:36:32",
"type": "labeled"
},
{
"author": "pmalek",
"created_at": "2023-08-13 11:36:32",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-13 11:36:32",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 11:36:32",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 11:36:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 11:36:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 06:37:01",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 06:37:02",
"type": "unlabeled"
},
{
"author": "pmalek",
"created_at": "2023-08-14 06:43:59",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 06:43:59",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 07:03:57",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 07:03:57",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 07:15:07",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 07:15:07",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 07:18:33",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 07:18:33",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 07:24:21",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 07:24:22",
"type": "subscribed"
},
{
"author": "Magnus6803",
"created_at": "2023-08-14 07:48:13",
"type": "unsubscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 09:10:56",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 09:10:57",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 09:10:58",
"type": "labeled"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:12:42",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:12:42",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:14:14",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:14:15",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:14:22",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:14:22",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:15:31",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:15:31",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:15:55",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:15:55",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:16:06",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:16:06",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:16:47",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:16:47",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:19:05",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:19:05",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:35:11",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:35:11",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:42:08",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:42:08",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:43:13",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:43:13",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:43:52",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:43:52",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:44:37",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:44:37",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:46:20",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:46:20",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:46:50",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:46:51",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:46:52",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 09:46:53",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 10:06:14",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 10:06:15",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-14 10:07:19",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-14 10:07:19",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:41:42",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:42:37",
"type": "unlabeled"
},
{
"author": "pmalek",
"created_at": "2023-08-19 11:40:10",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-19 11:40:11",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-19 11:40:27",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-19 11:40:27",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-19 11:41:13",
"type": "review_requested"
},
{
"author": "pmalek",
"created_at": "2023-08-19 11:41:36",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-19 11:41:36",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-19 11:41:50",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-19 11:41:50",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-19 11:43:29",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-19 11:43:29",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-19 11:43:57",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-19 11:43:57",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-19 11:44:13",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-19 11:44:13",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-19 11:44:27",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-19 11:44:27",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-19 12:08:19",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-19 12:08:19",
"type": "subscribed"
},
{
"author": "pmalek",
"created_at": "2023-08-19 12:19:33",
"type": "mentioned"
},
{
"author": "pmalek",
"created_at": "2023-08-19 12:19:33",
"type": "subscribed"
}
] |
119,923 | fix: Mount point may become local without calling `NodePublishVolume` after node rebooting | open | 2023-08-13 08:37:53 | 2023-08-25 12:36:31 | null | [
"jsafrane"
] | [
"kind/bug",
"area/kubelet",
"sig/node",
"size/S",
"cncf-cla: yes",
"do-not-merge/release-note-label-needed",
"needs-priority",
"needs-triage"
] | cvvz | [
{
"body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-13 08:37:54"
},
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sun Aug 13 04:36:57 UTC 2023.\n",
"created_at": "2023-08-13 08:37:56"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-13 08:38:00"
},
{
"body": "/assign @jsafrane ",
"created_at": "2023-08-14 11:52:29"
},
{
"body": "@jsafrane please triage this PR and set its priority, thanks.",
"created_at": "2023-08-14 11:57:49"
},
{
"body": "/retest",
"created_at": "2023-08-16 09:58:43"
},
{
"body": "@cvvz please check the failed unit tests - it was you who added them and expected that such a volume will be in ASW.\r\n\r\nPlease also make sure that the volume is cleaned up when it gets removed from DSW before it's mounted:\r\n\r\n1. Create a Pod with a volume.\r\n2. Stop kubelet.\r\n3. Force-delete the Pod.\r\n4. Start an replacement Pod that uses the volume.\r\n5. Start kubelet. Now the reconstructed volume will not be added to ASW, because it's in DSW.\r\n6. Remove the replacement Pod before the volume are mounted. We need the volume to get unmounted. It _should_ work, since the volume is in `skippedDuringReconstruction`... See https://github.com/kubernetes/kubernetes/pull/110670.\r\n\r\ncc @gnufied \r\n",
"created_at": "2023-08-16 12:31:16"
},
{
"body": "> Please also make sure that the volume is cleaned up when it gets removed from DSW before it's mounted\r\n\r\n@jsafrane I think your case can't be passed even though I haven't done any test yet. That is because volumes in `skippedDuringReconstruction` won't be processed if they are not in ASW: https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/volumemanager/reconciler/reconciler.go#L76-L84\r\n\r\nIMO https://github.com/kubernetes/kubernetes/pull/110670 which introduced `skippedDuringReconstruction` aims to solve the case mentioned in https://github.com/kubernetes/kubernetes/issues/96635#issuecomment-1145286675, not yours. cc @gnufied \r\n\r\nAnd I think the fix I made didn't impact https://github.com/kubernetes/kubernetes/pull/110670",
"created_at": "2023-08-25 09:06:46"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119923#\" title=\"Author self-approved\">cvvz</a>*\n**Once this PR has been reviewed and has the lgtm label**, please ask for approval from [jsafrane](https://github.com/jsafrane). For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pkg/kubelet/volumemanager/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/volumemanager/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"jsafrane\"]} -->",
"created_at": "2023-08-25 11:56:19"
},
{
"body": "> please check the failed unit tests - it was you who added them and expected that such a volume will be in ASW.\r\n\r\nI've fixed the unit test. It turns out the original change is not correct, please take another look, thanks!",
"created_at": "2023-08-25 11:59:54"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 08:37:54",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 08:37:54",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 08:37:55",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 08:37:57",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 08:37:57",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 08:37:58",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 08:37:58",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 08:37:58",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 08:37:59",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 08:38:01",
"type": "labeled"
},
{
"author": "cvvz",
"created_at": "2023-08-13 08:40:33",
"type": "renamed"
},
{
"author": "cvvz",
"created_at": "2023-08-13 09:05:40",
"type": "mentioned"
},
{
"author": "cvvz",
"created_at": "2023-08-13 09:05:41",
"type": "subscribed"
},
{
"author": "cvvz",
"created_at": "2023-08-13 09:16:11",
"type": "mentioned"
},
{
"author": "cvvz",
"created_at": "2023-08-13 09:16:12",
"type": "subscribed"
},
{
"author": "jsafrane",
"created_at": "2023-08-14 11:52:30",
"type": "mentioned"
},
{
"author": "jsafrane",
"created_at": "2023-08-14 11:52:30",
"type": "subscribed"
},
{
"author": "jsafrane",
"created_at": "2023-08-14 11:52:31",
"type": "assigned"
},
{
"author": "cvvz",
"created_at": "2023-08-14 11:53:10",
"type": "renamed"
},
{
"author": "jsafrane",
"created_at": "2023-08-14 11:57:49",
"type": "mentioned"
},
{
"author": "jsafrane",
"created_at": "2023-08-14 11:57:50",
"type": "subscribed"
},
{
"author": "cvvz",
"created_at": "2023-08-16 10:38:01",
"type": "mentioned"
},
{
"author": "cvvz",
"created_at": "2023-08-16 10:38:01",
"type": "subscribed"
},
{
"author": "gnufied",
"created_at": "2023-08-16 12:31:17",
"type": "mentioned"
},
{
"author": "gnufied",
"created_at": "2023-08-16 12:31:17",
"type": "subscribed"
},
{
"author": "cvvz",
"created_at": "2023-08-16 12:31:17",
"type": "mentioned"
},
{
"author": "cvvz",
"created_at": "2023-08-16 12:31:17",
"type": "subscribed"
},
{
"author": "jsafrane",
"created_at": "2023-08-25 09:07:03",
"type": "mentioned"
},
{
"author": "jsafrane",
"created_at": "2023-08-25 09:07:03",
"type": "subscribed"
},
{
"author": "gnufied",
"created_at": "2023-08-25 09:09:29",
"type": "mentioned"
},
{
"author": "gnufied",
"created_at": "2023-08-25 09:09:29",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-25 11:56:15",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-25 11:56:16",
"type": "labeled"
}
] |
119,922 | k8s三主两从 master1访问svc不通 ping pod的ip也不通 | closed | 2023-08-13 08:36:22 | 2023-08-17 16:21:50 | 2023-08-17 16:21:49 | [] | [
"kind/bug",
"sig/network",
"needs-triage"
] | shuangshuangaini | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-13 08:36:30"
},
{
"body": "/language zh-cn\r\n/sig network\r\n\r\n",
"created_at": "2023-08-13 18:17:18"
},
{
"body": "@utkarsh-singh1: The label(s) `language/zh-cn` cannot be applied, because the repository doesn't have them.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119922#issuecomment-1676428823):\n\n>/language zh-cn\r\n>/sig network\r\n>\r\n>\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-13 18:17:20"
},
{
"body": "从你发的问题，我获取不到任何有价值的东西。能否添加更多有关于本次问题的原因信息吗？",
"created_at": "2023-08-14 08:48:21"
},
{
"body": "Please use English to report the bug. We use English to collaborate.",
"created_at": "2023-08-14 11:33:37"
},
{
"body": "Google translate says \"master1 cannot access svc, nor can it ping the ip of pod. It is also possible to access svc through master2 and master3, and it is also possible to ping pod.\"",
"created_at": "2023-08-17 16:13:29"
},
{
"body": "Given that almost all of the requested details are missing, there's nothing we can do here. Please re-open with enough information to explain the problem.",
"created_at": "2023-08-17 16:21:49"
}
] | [
{
"author": "shuangshuangaini",
"created_at": "2023-08-13 08:36:22",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 08:36:28",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 08:36:30",
"type": "labeled"
},
{
"author": "toVersus",
"created_at": "2023-08-13 11:09:39",
"type": "unsubscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 18:17:20",
"type": "labeled"
},
{
"author": "utkarsh-singh1",
"created_at": "2023-08-13 18:17:21",
"type": "mentioned"
},
{
"author": "utkarsh-singh1",
"created_at": "2023-08-13 18:17:21",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 18:17:21",
"type": "unlabeled"
},
{
"author": "thockin",
"created_at": "2023-08-17 16:21:49",
"type": "closed"
}
] |
119,921 | Mount point may become local without calling `NodePublishVolume` after node rebooting | open | 2023-08-13 07:31:31 | 2023-08-16 17:29:01 | null | [] | [
"kind/bug",
"sig/storage",
"needs-triage"
] | cvvz | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-13 07:31:44"
},
{
"body": "Clusters with `NewVolumeManagerReconstruction` enabled is not impacted.",
"created_at": "2023-08-13 07:32:56"
},
{
"body": "/sig node storage\r\n(for triage)\r\n",
"created_at": "2023-08-14 16:11:09"
},
{
"body": "/remove-sig node\r\n\r\nsig-storage please triage this first. Thanks",
"created_at": "2023-08-16 17:28:59"
}
] | [
{
"author": "cvvz",
"created_at": "2023-08-13 07:31:31",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 07:31:42",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 07:31:43",
"type": "labeled"
},
{
"author": "cvvz",
"created_at": "2023-08-14 11:59:29",
"type": "renamed"
},
{
"author": "cvvz",
"created_at": "2023-08-14 11:59:42",
"type": "renamed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:11:11",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:11:12",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:11:12",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 17:29:01",
"type": "unlabeled"
}
] |
119,920 | Cannot connect to service of it's own from inside pod or from other pods on Kubernetes | open | 2023-08-13 06:41:06 | 2023-08-18 05:12:19 | null | [
"khenidak"
] | [
"kind/bug",
"sig/network",
"needs-triage"
] | Vivekdjango | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-13 06:41:14"
},
{
"body": "/sig network",
"created_at": "2023-08-13 18:21:19"
},
{
"body": "I think that this may be very specific to your environment, it is better if you reach out to AKS support\r\n\r\n/Cc @bridgetkromhout @khenidak ",
"created_at": "2023-08-13 18:47:37"
},
{
"body": "@Vivekdjango you can check if hair pin mode is enabled \r\nhttps://kubernetes.io/docs/tasks/debug/debug-application/debug-service/#a-pod-fails-to-reach-itself-via-the-service-ip\r\n",
"created_at": "2023-08-17 09:28:33"
},
{
"body": "Beside hair-pin there is another problem you can check: if you can trace traffic inside the POD, e.g. with `tcpdump`, check if packets have the POD-IP both as source and dest.\r\n\r\nThis will be the case if the source-ip (i.e. the POD-IP) is not masqueraded, and it will not work. This will _always_ happen for services with `externalTrafficPolicy: Local`, but I can see that your service doesn't use that. Another thing that may cause this sysctl net.bridge.bridge-nf-call-iptables. Verify that it's 1, or set it with:\r\n```\r\nsysctl -w net.bridge.bridge-nf-call-iptables=1\r\n```\r\nAnother thing to test is to set `--masquerade-all` to kube-proxy. It should normally not be necessary, but worth testing.",
"created_at": "2023-08-17 14:28:59"
},
{
"body": "/assign @khenidak ",
"created_at": "2023-08-17 16:14:09"
},
{
"body": "> Beside hair-pin there is another problem you can check: if you can trace traffic inside the POD, e.g. with `tcpdump`, check if packets have the POD-IP both as source and dest.\r\n> \r\n> This will be the case if the source-ip (i.e. the POD-IP) is not masqueraded, and it will not work. This will _always_ happen for services with `externalTrafficPolicy: Local`, but I can see that your service doesn't use that. Another thing that may cause this sysctl net.bridge.bridge-nf-call-iptables. Verify that it's 1, or set it with:\r\n> \r\n> ```\r\n> sysctl -w net.bridge.bridge-nf-call-iptables=1\r\n> ```\r\n> \r\n> Another thing to test is to set `--masquerade-all` to kube-proxy. It should normally not be necessary, but worth testing.\r\n\r\nSure definitely will try and update you the response",
"created_at": "2023-08-18 05:12:08"
},
{
"body": "> @Vivekdjango you can check if hair pin mode is enabled https://kubernetes.io/docs/tasks/debug/debug-application/debug-service/#a-pod-fails-to-reach-itself-via-the-service-ip\r\n\r\nSure thanks",
"created_at": "2023-08-18 05:12:19"
}
] | [
{
"author": "Vivekdjango",
"created_at": "2023-08-13 06:41:06",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 06:41:12",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 06:41:14",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 18:21:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 18:21:22",
"type": "unlabeled"
},
{
"author": "bridgetkromhout",
"created_at": "2023-08-13 18:47:37",
"type": "mentioned"
},
{
"author": "bridgetkromhout",
"created_at": "2023-08-13 18:47:37",
"type": "subscribed"
},
{
"author": "khenidak",
"created_at": "2023-08-13 18:47:37",
"type": "mentioned"
},
{
"author": "khenidak",
"created_at": "2023-08-13 18:47:37",
"type": "subscribed"
},
{
"author": "Vivekdjango",
"created_at": "2023-08-17 09:28:33",
"type": "mentioned"
},
{
"author": "Vivekdjango",
"created_at": "2023-08-17 09:28:33",
"type": "subscribed"
},
{
"author": "khenidak",
"created_at": "2023-08-17 16:14:10",
"type": "mentioned"
},
{
"author": "khenidak",
"created_at": "2023-08-17 16:14:10",
"type": "subscribed"
},
{
"author": "khenidak",
"created_at": "2023-08-17 16:14:11",
"type": "assigned"
},
{
"author": "Vivekdjango",
"created_at": "2023-08-18 05:12:19",
"type": "mentioned"
},
{
"author": "Vivekdjango",
"created_at": "2023-08-18 05:12:19",
"type": "subscribed"
}
] |
119,919 | volume was left over and kubelet repeat error: "orphaned pod xxx found, but error occurred when trying to remove the volumes dir: not a directory" | open | 2023-08-13 01:49:12 | 2023-08-22 07:43:32 | null | [] | [
"kind/bug",
"sig/storage",
"needs-triage"
] | cvvz | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-13 01:49:21"
},
{
"body": "### Kubelet logs during rebooting:\r\n[kubelet.log](https://github.com/kubernetes/kubernetes/files/12328604/kubelet.log)\r\n\r\n### Pod that in Terminating state:\r\n**Name**: deployment-azurefile-68644cc9b9-m8qp4\r\n**UID**: d57ef041-b3dc-4a74-b69d-68875c276e6a\r\n\r\n### This is what happened according to the logs:\r\nPod was added to DSW at the beginning \r\n```\r\nI0813 00:55:51.646047 1976 desired_state_of_world_populator.go:309] \"Added volume to desired state\" pod=\"default/deployment-azurefile-68644cc9b9-m8qp4\" volumeName=\"azurefile\" volumeSpecName=\"pvc-43776082-cdcb-4e64-aed0-a3882d64c83a\"\r\n```\r\nDuring reconstruction, volume would not be added to ASW nor be cleaned up since it was in DSW\r\n```\r\nI0813 00:55:51.765768 1976 reconstruct.go:95] \"Volume exists in desired state, marking as InUse\" podName=d57ef041-b3dc-4a74-b69d-68875c276e6a volumeSpecName=\"pvc-43776082-cdcb-4e64-aed0-a3882d64c83a\"\r\n```\r\nDuring reconcile, kubelet tried to mount the volume but not succeeded since CSI driver was not registered yet\r\n```\r\nE0813 00:55:52.444093 1976 nestedpendingoperations.go:348] Operation for \"{volumeName:kubernetes.io/csi/file.csi.azure.com^mc_weizhichen-127_weizhichen-127_eastus#f23e483901a524725b15f93#pvc-43776082-cdcb-4e64-aed0-a3882d64c83a###default podName: nodeName:}\" failed. No retries permitted until 2023-08-13 00:55:53.444079275 +0000 UTC m=+3.244964818 (durationBeforeRetry 1s). Error: MountVolume.MountDevice failed for volume \"pvc-43776082-cdcb-4e64-aed0-a3882d64c83a\" (UniqueName: \"kubernetes.io/csi/file.csi.azure.com^mc_weizhichen-127_weizhichen-127_eastus#f23e483901a524725b15f93#pvc-43776082-cdcb-4e64-aed0-a3882d64c83a###default\") pod \"deployment-azurefile-68644cc9b9-m8qp4\" (UID: \"d57ef041-b3dc-4a74-b69d-68875c276e6a\") : kubernetes.io/csi: attacher.MountDevice failed to create newCsiDriverClient: driver name file.csi.azure.com not found in the list of registered CSI drivers\r\n```\r\nPod was fully terminated and removed from etcd\r\n```\r\nI0813 00:55:53.163655 1976 status_manager.go:868] \"Pod fully terminated and removed from etcd\" pod=\"default/deployment-azurefile-68644cc9b9-m8qp4\"\r\n```\r\nPod was removed from DSW since pod was not in pod manager anymore\r\n```\r\nI0813 00:55:53.189460 1976 desired_state_of_world_populator.go:253] \"Removing volume from desired state\" pod=\"default/deployment-azurefile-68644cc9b9-m8qp4\" podUID=d57ef041-b3dc-4a74-b69d-68875c276e6a volumeName=\"pvc-43776082-cdcb-4e64-aed0-a3882d64c83a\"\r\n```\r\nNow, reconcile should UnmountVolume for the pod, however, since the volume was never successfully mounted in ASW, the state of the volume should be unmounted, so it won't unmount (call `NodeUnpublishVolume`) the volume.\r\n\r\n",
"created_at": "2023-08-13 02:06:28"
},
{
"body": "Looks like this error can be solved when enabling `NewVolumeManagerReconstruction`",
"created_at": "2023-08-13 05:30:13"
},
{
"body": "/sig storage\r\n",
"created_at": "2023-08-14 16:13:01"
},
{
"body": "Maybe its a normal phenomena, which I have seen this logs since early release of 1.13.",
"created_at": "2023-08-22 07:43:32"
}
] | [
{
"author": "cvvz",
"created_at": "2023-08-13 01:49:12",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 01:49:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 01:49:20",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:13:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 16:13:04",
"type": "unlabeled"
}
] |
119,918 | e2e: support admissionapi.LevelRestricted in test/e2e/framework/volume | open | 2023-08-12 21:13:25 | 2023-08-16 03:38:22 | null | [] | [
"area/test",
"kind/cleanup",
"size/S",
"release-note-none",
"cncf-cla: yes",
"sig/testing",
"ok-to-test",
"needs-priority",
"area/e2e-test-framework",
"needs-triage"
] | wafuwafu13 | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sat Aug 12 16:37:58 UTC 2023.\n",
"created_at": "2023-08-12 21:13:28"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119918#\" title=\"Author self-approved\">wafuwafu13</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [thockin](https://github.com/thockin) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[test/e2e/framework/volume/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/framework/volume/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"thockin\"]} -->",
"created_at": "2023-08-12 21:13:30"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-12 21:13:33"
},
{
"body": "Hi @wafuwafu13. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-12 21:13:33"
},
{
"body": "/ok-to-test",
"created_at": "2023-08-14 06:52:02"
},
{
"body": "/test pull-kubernetes-unit",
"created_at": "2023-08-16 02:58:03"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 21:13:26",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 21:13:26",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 21:13:27",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 21:13:29",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 21:13:30",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 21:13:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 21:13:30",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 21:13:31",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 21:13:31",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 21:13:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 21:13:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 21:13:33",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 21:13:33",
"type": "unlabeled"
},
{
"author": "wafuwafu13",
"created_at": "2023-08-12 21:13:33",
"type": "mentioned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 21:13:33",
"type": "labeled"
},
{
"author": "wafuwafu13",
"created_at": "2023-08-12 21:13:34",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 06:52:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 06:52:04",
"type": "unlabeled"
},
{
"author": "wafuwafu13",
"created_at": "2023-08-14 07:31:20",
"type": "mentioned"
},
{
"author": "wafuwafu13",
"created_at": "2023-08-14 07:31:21",
"type": "subscribed"
}
] |
119,917 | Job: Handle error returned from AddEventHandler function | open | 2023-08-12 18:44:37 | 2023-08-25 16:09:45 | null | [
"alculquicondor",
"atiratree"
] | [
"area/test",
"kind/cleanup",
"sig/api-machinery",
"size/L",
"release-note-none",
"sig/apps",
"cncf-cla: yes",
"sig/testing",
"needs-priority",
"triage/accepted"
] | tenzen-y | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sat Aug 12 16:37:58 UTC 2023.\n",
"created_at": "2023-08-12 18:44:41"
},
{
"body": "/assign @atiratree",
"created_at": "2023-08-15 19:18:45"
},
{
"body": "/cc @alexzielenski \r\n/triage accepted",
"created_at": "2023-08-15 20:08:18"
},
{
"body": "@atiratree Could you take a look at this PR? Thanks.",
"created_at": "2023-08-18 18:54:47"
},
{
"body": "@atiratree Thank you for the review.\r\n\r\n> looks fine, but I wonder if there is an issue/reason behind this change?\r\n\r\nThere isn't any issue. This is just a cleanup. I think in general, handling returned errors would be better.\r\n",
"created_at": "2023-08-23 01:54:35"
},
{
"body": "Rebased.\r\n",
"created_at": "2023-08-23 02:28:09"
},
{
"body": "ack\r\n/lgtm",
"created_at": "2023-08-24 11:06:58"
},
{
"body": "/assign @alculquicondor",
"created_at": "2023-08-24 13:13:39"
},
{
"body": "/approve",
"created_at": "2023-08-24 15:24:34"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119917#issuecomment-1691893584\" title=\"Approved\">alculquicondor</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119917#\" title=\"Author self-approved\">tenzen-y</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [soltysh](https://github.com/soltysh) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[cmd/kube-controller-manager/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/cmd/kube-controller-manager/OWNERS)**\n- ~~[pkg/controller/job/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/job/OWNERS)~~ [alculquicondor]\n- **[test/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"soltysh\"]} -->",
"created_at": "2023-08-24 15:24:59"
},
{
"body": "/lgtm cancel\r\nfor the follow ups.",
"created_at": "2023-08-24 15:25:02"
},
{
"body": "@alculquicondor I addressed all suggestions. PTAL.\r\n",
"created_at": "2023-08-25 16:09:45"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 18:44:38",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 18:44:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 18:44:39",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 18:44:42",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 18:44:42",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 18:44:42",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 18:44:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 18:44:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 18:44:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 18:44:44",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 18:44:44",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 18:44:45",
"type": "labeled"
},
{
"author": "atiratree",
"created_at": "2023-08-15 19:18:46",
"type": "mentioned"
},
{
"author": "atiratree",
"created_at": "2023-08-15 19:18:46",
"type": "subscribed"
},
{
"author": "atiratree",
"created_at": "2023-08-15 19:38:47",
"type": "assigned"
},
{
"author": "alexzielenski",
"created_at": "2023-08-15 20:08:18",
"type": "mentioned"
},
{
"author": "alexzielenski",
"created_at": "2023-08-15 20:08:18",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:20:30",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:20:31",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:48:08",
"type": "unlabeled"
},
{
"author": "atiratree",
"created_at": "2023-08-18 18:54:47",
"type": "mentioned"
},
{
"author": "atiratree",
"created_at": "2023-08-18 18:54:47",
"type": "subscribed"
},
{
"author": "atiratree",
"created_at": "2023-08-23 01:54:35",
"type": "mentioned"
},
{
"author": "atiratree",
"created_at": "2023-08-23 01:54:35",
"type": "subscribed"
},
{
"author": "tenzen-y",
"created_at": "2023-08-23 02:23:58",
"type": "mentioned"
},
{
"author": "tenzen-y",
"created_at": "2023-08-23 02:23:58",
"type": "subscribed"
},
{
"author": "tenzen-y",
"created_at": "2023-08-23 02:27:46",
"type": "head_ref_force_pushed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 11:07:03",
"type": "labeled"
},
{
"author": "alculquicondor",
"created_at": "2023-08-24 13:13:40",
"type": "mentioned"
},
{
"author": "alculquicondor",
"created_at": "2023-08-24 13:13:40",
"type": "subscribed"
},
{
"author": "alculquicondor",
"created_at": "2023-08-24 13:13:41",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 15:25:09",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 15:25:10",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 15:25:10",
"type": "review_requested"
},
{
"author": "alculquicondor",
"created_at": "2023-08-25 16:09:45",
"type": "mentioned"
},
{
"author": "alculquicondor",
"created_at": "2023-08-25 16:09:45",
"type": "subscribed"
}
] |
119,916 | log: get logger from context if existed | closed | 2023-08-12 14:07:19 | 2023-08-15 20:22:18 | 2023-08-14 06:13:43 | [] | [
"area/logging",
"sig/api-machinery",
"release-note",
"size/XS",
"kind/feature",
"cncf-cla: yes",
"sig/instrumentation",
"needs-ok-to-test",
"needs-priority",
"triage/accepted",
"wg/structured-logging"
] | zwpaper | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sat Aug 12 10:37:24 UTC 2023.\n",
"created_at": "2023-08-12 14:07:22"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119916#\" title=\"Author self-approved\">zwpaper</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [sttts](https://github.com/sttts) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/client-go/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"sttts\"]} -->",
"created_at": "2023-08-12 14:07:25"
},
{
"body": "Hi @zwpaper. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-12 14:07:28"
},
{
"body": "As far as I know, the migration of `staging/src/k8s.io/...` directories to contextual logging has not started yet, see this enhancements issue https://github.com/kubernetes/enhancements/issues/3077 for the process.\r\n\r\nOur general operation is to batch-migrate a directory.\r\n\r\n/sig instrumentation\r\n/area logging\r\n\r\n/cc @pohly ",
"created_at": "2023-08-14 02:38:01"
},
{
"body": "did not notice the KEP, is there any plan for migrating client-go? maybe I can help with continuing the PR, or should I wait for your schedule? @pohly ",
"created_at": "2023-08-14 03:04:38"
},
{
"body": "I did a prototype conversion before starting with contextual logging. I'll revive that at some point. But for now, let's discuss in the structured logging WG channel what we want to tackle next.\r\n\r\n@mengjiao-liu is right, a PR which changes just a few lines in a package is not how we do this. Is it okay to close this?\r\n",
"created_at": "2023-08-14 05:47:21"
},
{
"body": "yes, let me close this PR at this time.\r\n\r\n/close\r\n\r\nI would like to help with the migration, and I go through https://github.com/kubernetes/enhancements/issues/3077 and found it looks like the alpha is done, and beta is not yet planned? may I ask that is there any update on the beta, and where can I get started?",
"created_at": "2023-08-14 06:13:39"
},
{
"body": "@zwpaper: Closed this PR.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119916#issuecomment-1676738009):\n\n>yes, let me close this PR at this time.\r\n>\r\n>/close\r\n>\r\n>I would like to help with the migration, and I go through https://github.com/kubernetes/enhancements/issues/3077 and found it looks like the alpha is done, and beta is not yet planned? may I ask that is there any update on the beta, and where can I get started?\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 06:13:44"
},
{
"body": "@zwpaper please ping me on the #wg-structured-logging Slack channel and we can discuss there.\r\n",
"created_at": "2023-08-14 07:53:24"
},
{
"body": "/triage accepted",
"created_at": "2023-08-15 20:08:25"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 14:07:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 14:07:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 14:07:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 14:07:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 14:07:24",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 14:07:25",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 14:07:25",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 14:07:25",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 14:07:26",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 14:07:27",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 14:07:27",
"type": "labeled"
},
{
"author": "zwpaper",
"created_at": "2023-08-12 14:07:28",
"type": "mentioned"
},
{
"author": "zwpaper",
"created_at": "2023-08-12 14:07:28",
"type": "subscribed"
},
{
"author": "toVersus",
"created_at": "2023-08-12 23:24:31",
"type": "unsubscribed"
},
{
"author": "pohly",
"created_at": "2023-08-14 02:38:02",
"type": "mentioned"
},
{
"author": "pohly",
"created_at": "2023-08-14 02:38:02",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 02:38:02",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 02:38:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 02:38:04",
"type": "labeled"
},
{
"author": "pohly",
"created_at": "2023-08-14 03:04:38",
"type": "mentioned"
},
{
"author": "pohly",
"created_at": "2023-08-14 03:04:38",
"type": "subscribed"
},
{
"author": "mengjiao-liu",
"created_at": "2023-08-14 05:47:22",
"type": "mentioned"
},
{
"author": "mengjiao-liu",
"created_at": "2023-08-14 05:47:22",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 06:13:43",
"type": "closed"
},
{
"author": "zwpaper",
"created_at": "2023-08-14 06:13:45",
"type": "mentioned"
},
{
"author": "zwpaper",
"created_at": "2023-08-14 06:13:45",
"type": "subscribed"
},
{
"author": "zwpaper",
"created_at": "2023-08-14 07:53:25",
"type": "mentioned"
},
{
"author": "zwpaper",
"created_at": "2023-08-14 07:53:25",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:14:01",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:22:17",
"type": "unlabeled"
}
] |
119,915 | Add a kubectl rollout undo e2e test | open | 2023-08-12 12:54:16 | 2023-08-25 15:45:12 | null | [
"dims",
"atiratree"
] | [
"area/test",
"kind/cleanup",
"size/L",
"release-note-none",
"approved",
"sig/cli",
"cncf-cla: yes",
"sig/testing",
"needs-priority",
"needs-triage"
] | AxeZhan | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Sat Aug 12 10:37:24 UTC 2023.\n",
"created_at": "2023-08-12 12:54:20"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-12 12:54:24"
},
{
"body": "/cc @atiratree ",
"created_at": "2023-08-12 16:03:45"
},
{
"body": "thx for the update\r\n/lgtm",
"created_at": "2023-08-24 11:01:49"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 0fa4ad7da1626656900081138092e15a9905d95b</details>",
"created_at": "2023-08-24 11:01:57"
},
{
"body": "Let me do a squash :)",
"created_at": "2023-08-24 11:14:03"
},
{
"body": "/approve\r\n/lgtm",
"created_at": "2023-08-24 12:41:23"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119915#\" title=\"Author self-approved\">AxeZhan</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119915#issuecomment-1691602127\" title=\"LGTM\">dims</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[test/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/OWNERS)~~ [dims]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-24 12:41:47"
},
{
"body": "/hold\r\nFor new comments.",
"created_at": "2023-08-24 12:57:32"
},
{
"body": "New changes are detected. LGTM label has been removed.",
"created_at": "2023-08-24 14:21:48"
},
{
"body": "/hold cancel\r\n\r\nThanks",
"created_at": "2023-08-24 15:29:13"
},
{
"body": "@aojea Updated, PTAL",
"created_at": "2023-08-24 15:46:18"
},
{
"body": "@soltysh ",
"created_at": "2023-08-25 12:29:03"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 12:54:17",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 12:54:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 12:54:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 12:54:20",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 12:54:21",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 12:54:21",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 12:54:22",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 12:54:22",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 12:54:23",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 12:54:23",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 12:54:24",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 12:54:24",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 12:54:25",
"type": "labeled"
},
{
"author": "AxeZhan",
"created_at": "2023-08-12 13:28:27",
"type": "mentioned"
},
{
"author": "AxeZhan",
"created_at": "2023-08-12 13:28:27",
"type": "subscribed"
},
{
"author": "AxeZhan",
"created_at": "2023-08-12 13:44:16",
"type": "head_ref_force_pushed"
},
{
"author": "AxeZhan",
"created_at": "2023-08-12 14:12:21",
"type": "mentioned"
},
{
"author": "AxeZhan",
"created_at": "2023-08-12 14:12:21",
"type": "subscribed"
},
{
"author": "AxeZhan",
"created_at": "2023-08-12 14:13:08",
"type": "head_ref_force_pushed"
},
{
"author": "AxeZhan",
"created_at": "2023-08-12 14:26:53",
"type": "head_ref_force_pushed"
},
{
"author": "AxeZhan",
"created_at": "2023-08-12 14:32:41",
"type": "head_ref_force_pushed"
},
{
"author": "AxeZhan",
"created_at": "2023-08-12 15:02:47",
"type": "mentioned"
},
{
"author": "AxeZhan",
"created_at": "2023-08-12 15:02:47",
"type": "subscribed"
},
{
"author": "atiratree",
"created_at": "2023-08-12 16:03:45",
"type": "mentioned"
},
{
"author": "atiratree",
"created_at": "2023-08-12 16:03:46",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 16:03:46",
"type": "review_requested"
},
{
"author": "AxeZhan",
"created_at": "2023-08-22 08:32:53",
"type": "head_ref_force_pushed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 08:32:55",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-22 08:32:56",
"type": "labeled"
},
{
"author": "AxeZhan",
"created_at": "2023-08-22 14:40:18",
"type": "head_ref_force_pushed"
},
{
"author": "atiratree",
"created_at": "2023-08-24 11:01:54",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 11:01:55",
"type": "labeled"
},
{
"author": "AxeZhan",
"created_at": "2023-08-24 11:14:04",
"type": "head_ref_force_pushed"
},
{
"author": "dims",
"created_at": "2023-08-24 12:41:28",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 12:41:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 12:57:33",
"type": "labeled"
},
{
"author": "AxeZhan",
"created_at": "2023-08-24 13:38:16",
"type": "mentioned"
},
{
"author": "AxeZhan",
"created_at": "2023-08-24 13:38:16",
"type": "subscribed"
},
{
"author": "AxeZhan",
"created_at": "2023-08-24 14:21:14",
"type": "head_ref_force_pushed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 14:21:46",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 14:21:47",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 14:21:47",
"type": "review_requested"
},
{
"author": "AxeZhan",
"created_at": "2023-08-24 14:44:56",
"type": "head_ref_force_pushed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-24 15:29:15",
"type": "unlabeled"
},
{
"author": "aojea",
"created_at": "2023-08-24 15:46:18",
"type": "mentioned"
},
{
"author": "aojea",
"created_at": "2023-08-24 15:46:18",
"type": "subscribed"
},
{
"author": "AxeZhan",
"created_at": "2023-08-25 12:25:53",
"type": "head_ref_force_pushed"
},
{
"author": "soltysh",
"created_at": "2023-08-25 12:29:03",
"type": "mentioned"
},
{
"author": "soltysh",
"created_at": "2023-08-25 12:29:04",
"type": "subscribed"
},
{
"author": "AxeZhan",
"created_at": "2023-08-25 13:22:52",
"type": "mentioned"
},
{
"author": "AxeZhan",
"created_at": "2023-08-25 13:22:52",
"type": "subscribed"
},
{
"author": "AxeZhan",
"created_at": "2023-08-25 14:09:30",
"type": "mentioned"
},
{
"author": "AxeZhan",
"created_at": "2023-08-25 14:09:31",
"type": "subscribed"
},
{
"author": "AxeZhan",
"created_at": "2023-08-25 14:22:25",
"type": "mentioned"
},
{
"author": "AxeZhan",
"created_at": "2023-08-25 14:22:25",
"type": "subscribed"
},
{
"author": "AxeZhan",
"created_at": "2023-08-25 14:51:24",
"type": "mentioned"
},
{
"author": "AxeZhan",
"created_at": "2023-08-25 14:51:24",
"type": "subscribed"
},
{
"author": "AxeZhan",
"created_at": "2023-08-25 15:16:45",
"type": "mentioned"
},
{
"author": "AxeZhan",
"created_at": "2023-08-25 15:16:45",
"type": "subscribed"
}
] |
119,914 | Job: Change job controller methods receiver to pointer | closed | 2023-08-12 02:34:23 | 2023-08-16 06:14:08 | 2023-08-16 06:14:06 | [
"alculquicondor",
"kannon92",
"janetkuo",
"mimowo"
] | [
"kind/cleanup",
"lgtm",
"size/XS",
"release-note-none",
"sig/apps",
"approved",
"cncf-cla: yes",
"ok-to-test",
"needs-priority",
"needs-triage"
] | luohaha3123 | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Aug 11 22:38:14 UTC 2023.\n",
"created_at": "2023-08-12 02:34:26"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-12 02:34:31"
},
{
"body": "Hi @luohaha3123. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-12 02:34:31"
},
{
"body": "/assign @mimowo",
"created_at": "2023-08-12 02:37:18"
},
{
"body": "/assign @alculquicondor \n",
"created_at": "2023-08-12 06:35:29"
},
{
"body": "/ok-to-test",
"created_at": "2023-08-12 12:57:09"
},
{
"body": "/retest",
"created_at": "2023-08-12 13:39:14"
},
{
"body": "/sig apps",
"created_at": "2023-08-12 13:54:15"
},
{
"body": "/kind cleanup",
"created_at": "2023-08-12 13:54:44"
},
{
"body": "LGTM label has been added. <details>Git tree hash: f9341f575bdc88829c8cab67201379541005d4f4</details>",
"created_at": "2023-08-12 13:56:02"
},
{
"body": "/retest",
"created_at": "2023-08-12 14:23:55"
},
{
"body": "> Nice spot!\r\n> \r\n> /lgtm\r\n\r\nThank you!",
"created_at": "2023-08-12 14:34:24"
},
{
"body": "/assign @janetkuo",
"created_at": "2023-08-13 10:09:48"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119914#pullrequestreview-1576752775\" title=\"LGTM\">alculquicondor</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119914#\" title=\"Author self-approved\">luohaha3123</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/controller/job/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/job/OWNERS)~~ [alculquicondor]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-14 12:32:13"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 02:34:24",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 02:34:24",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 02:34:27",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 02:34:28",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 02:34:28",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 02:34:28",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 02:34:29",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 02:34:30",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 02:34:31",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 02:34:31",
"type": "labeled"
},
{
"author": "luohaha3123",
"created_at": "2023-08-12 02:34:31",
"type": "mentioned"
},
{
"author": "luohaha3123",
"created_at": "2023-08-12 02:34:31",
"type": "subscribed"
},
{
"author": "mimowo",
"created_at": "2023-08-12 02:37:19",
"type": "mentioned"
},
{
"author": "mimowo",
"created_at": "2023-08-12 02:37:19",
"type": "subscribed"
},
{
"author": "mimowo",
"created_at": "2023-08-12 02:37:19",
"type": "assigned"
},
{
"author": "alculquicondor",
"created_at": "2023-08-12 06:35:29",
"type": "mentioned"
},
{
"author": "alculquicondor",
"created_at": "2023-08-12 06:35:29",
"type": "subscribed"
},
{
"author": "alculquicondor",
"created_at": "2023-08-12 06:35:30",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 12:57:10",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 12:57:11",
"type": "unlabeled"
},
{
"author": "luohaha3123",
"created_at": "2023-08-12 13:28:31",
"type": "mentioned"
},
{
"author": "luohaha3123",
"created_at": "2023-08-12 13:28:31",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 13:54:46",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 13:54:47",
"type": "unlabeled"
},
{
"author": "kannon92",
"created_at": "2023-08-12 13:56:00",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-12 13:56:01",
"type": "labeled"
},
{
"author": "janetkuo",
"created_at": "2023-08-13 10:09:49",
"type": "assigned"
},
{
"author": "janetkuo",
"created_at": "2023-08-13 10:11:57",
"type": "mentioned"
},
{
"author": "janetkuo",
"created_at": "2023-08-13 10:11:57",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 12:32:14",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:14:06",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:14:06",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:14:06",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:14:08",
"type": "milestoned"
}
] |
119,913 | Dynamic provisioning stopped working after upgrade | open | 2023-08-11 22:15:47 | 2023-08-14 20:37:50 | null | [] | [
"kind/bug",
"needs-triage",
"sig/k8s-infra"
] | arthurala | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-11 22:15:55"
},
{
"body": "/sig k8s-infra",
"created_at": "2023-08-11 22:21:59"
},
{
"body": "does anyone have insight into issue or experienced same problem?",
"created_at": "2023-08-14 18:50:11"
},
{
"body": "Provision log = \r\nI0811 18:51:19.203915 1 leaderelection.go:185] attempting to acquire leader lease nfs-client-provisioner/cluster.local-nfs-client-provisioner...\r\nE0811 18:51:36.614372 1 event.go:259] Could not construct reference to: '&v1.Endpoints{TypeMeta:v1.TypeMeta{Kind:\"\", APIVersion:\"\"}, ObjectMeta:v1.ObjectMeta{Name:\"cluster.local-nfs-client-provisioner\", GenerateName:\"\", Namespace:\"nfs-client-provisioner\", SelfLink:\"\", UID:\"420983e9-525f-4f19-8178-4333c400aaf2\", ResourceVersion:\"442658895\", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:63726895467, loc:(*time.Location)(0x1956800)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string{\"control-plane.alpha.kubernetes.io/leader\":\"{\\\"holderIdentity\\\":\\\"nfs-client-provisioner-57f49ccf5b-jf8vd_0ee2b427-3878-11ee-8695-bab7f20f017d\\\",\\\"leaseDurationSeconds\\\":15,\\\"acquireTime\\\":\\\"2023-08-11T18:51:36Z\\\",\\\"renewTime\\\":\\\"2023-08-11T18:51:36Z\\\",\\\"leaderTransitions\\\":84}\"}, OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:\"\"}, Subsets:[]v1.EndpointSubset(nil)}' due to: 'selfLink was empty, can't make reference'. Will not report event: 'Normal' 'LeaderElection' 'nfs-client-provisioner-57f49ccf5b-jf8vd_0ee2b427-3878-11ee-8695-bab7f20f017d became leader'\r\nI0811 18:51:36.614457 1 leaderelection.go:194] successfully acquired lease nfs-client-provisioner/cluster.local-nfs-client-provisioner\r\nI0811 18:51:36.614507 1 controller.go:631] Starting provisioner controller cluster.local/nfs-client-provisioner_nfs-client-provisioner-57f49ccf5b-jf8vd_0ee2b427-3878-11ee-8695-bab7f20f017d!\r\nI0811 18:51:36.714726 1 controller.go:680] Started provisioner controller cluster.local/nfs-client-provisioner_nfs-client-provisioner-57f49ccf5b-jf8vd_0ee2b427-3878-11ee-8695-bab7f20f017d!\r\nI0811 18:51:36.715466 1 controller.go:987] provision \"report/data-0\" class \"nfs-client\": started\r\nE0811 18:51:36.719407 1 controller.go:1004] provision \"report/data-0\" class \"nfs-client\": unexpected error getting claim reference: selfLink was empty, can't make reference\r\nI0811 18:54:03.103016 1 controller.go:987] provision \"default/test001-pvc\" class \"nfs-client\": started\r\nE0811 18:54:03.111321 1 controller.go:1004] provision \"default/test001-pvc\" class \"nfs-client\": unexpected error getting claim reference: selfLink was empty, can't make reference\r\nI0811 19:06:36.619605 1 controller.go:987] provision \"default/test001-pvc\" class \"nfs-client\": started\r\n",
"created_at": "2023-08-14 20:37:50"
}
] | [
{
"author": "arthurala",
"created_at": "2023-08-11 22:15:47",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 22:15:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 22:15:54",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 22:22:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 22:22:01",
"type": "unlabeled"
}
] |
119,912 | WIP: Add a missing integration test for PodReplacementPolicy | open | 2023-08-11 21:05:41 | 2023-08-11 22:02:11 | null | [] | [
"area/test",
"size/L",
"kind/feature",
"release-note-none",
"sig/apps",
"cncf-cla: yes",
"sig/testing",
"do-not-merge/work-in-progress",
"needs-priority",
"needs-triage"
] | kannon92 | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Aug 11 16:37:41 UTC 2023.\n",
"created_at": "2023-08-11 21:05:45"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119912#\" title=\"Author self-approved\">kannon92</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [smarterclayton](https://github.com/smarterclayton) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[test/integration/job/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/integration/job/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"smarterclayton\"]} -->",
"created_at": "2023-08-11 21:05:47"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-11 21:05:49"
},
{
"body": "@kannon92: The following tests **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-unit | ad99363ec3c8c7df12449dbe2b6100db930569d3 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119912/pull-kubernetes-unit/1690107249671802880) | true | `/test pull-kubernetes-unit`\npull-kubernetes-e2e-gce | ad99363ec3c8c7df12449dbe2b6100db930569d3 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119912/pull-kubernetes-e2e-gce/1690107249315287040/) | true | `/test pull-kubernetes-e2e-gce`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119912). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Akannon92). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"created_at": "2023-08-11 22:02:10"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 21:05:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 21:05:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 21:05:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 21:05:44",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 21:05:46",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 21:05:47",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 21:05:47",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 21:05:47",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 21:05:47",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 21:05:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 21:05:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 21:05:50",
"type": "labeled"
},
{
"author": "kannon92",
"created_at": "2023-08-11 21:44:26",
"type": "mentioned"
},
{
"author": "kannon92",
"created_at": "2023-08-11 21:44:26",
"type": "subscribed"
},
{
"author": "kannon92",
"created_at": "2023-08-11 22:02:11",
"type": "mentioned"
},
{
"author": "kannon92",
"created_at": "2023-08-11 22:02:11",
"type": "subscribed"
}
] |
119,911 | kmsv2: enable KDF by default in v1.29 | open | 2023-08-11 19:57:42 | 2023-08-12 18:04:30 | null | [
"enj"
] | [
"priority/important-soon",
"sig/auth",
"triage/accepted"
] | enj | [
{
"body": "@enj i want to work on this issue can you guide me",
"created_at": "2023-08-12 17:17:24"
},
{
"body": "@yp969803 sorry, none of the KMS work is good for new contributors.",
"created_at": "2023-08-12 18:04:30"
}
] | [
{
"author": "enj",
"created_at": "2023-08-11 19:57:43",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 19:57:43",
"type": "milestoned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 19:57:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 19:57:44",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 19:57:44",
"type": "labeled"
},
{
"author": "enj",
"created_at": "2023-08-12 17:17:24",
"type": "mentioned"
},
{
"author": "enj",
"created_at": "2023-08-12 17:17:24",
"type": "subscribed"
},
{
"author": "yp969803",
"created_at": "2023-08-12 18:04:31",
"type": "mentioned"
},
{
"author": "yp969803",
"created_at": "2023-08-12 18:04:31",
"type": "subscribed"
}
] |
119,910 | Improve precision of Quantity.AsApproximateFloat64 | open | 2023-08-11 14:31:17 | 2023-08-17 11:06:27 | null | [] | [
"kind/cleanup",
"sig/api-machinery",
"size/M",
"release-note-none",
"cncf-cla: yes",
"needs-priority",
"triage/accepted"
] | intUnderflow | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Aug 11 10:38:14 UTC 2023.\n",
"created_at": "2023-08-11 14:31:21"
},
{
"body": "@intUnderflow: GitHub didn't allow me to request PR reviews from the following users: BoSunesen.\n\nNote that only [kubernetes members](https://github.com/orgs/kubernetes/people) and repo collaborators can review this PR, and authors cannot review their own PRs.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/pull/119910#issuecomment-1674891058):\n\n>/cc @BoSunesen\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-11 14:31:51"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119910#\" title=\"Author self-approved\">intUnderflow</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [liggitt](https://github.com/liggitt) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/apimachinery/pkg/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"liggitt\"]} -->",
"created_at": "2023-08-11 14:32:18"
},
{
"body": "/retest",
"created_at": "2023-08-11 15:09:44"
},
{
"body": "/retest",
"created_at": "2023-08-11 17:44:13"
},
{
"body": "/retest",
"created_at": "2023-08-11 21:09:53"
},
{
"body": "I'm pretty sure this is still an unrelated flake\r\n\r\n/retest",
"created_at": "2023-08-11 21:38:30"
},
{
"body": "/cc @thockin @smarterclayton \r\n/triage accepted",
"created_at": "2023-08-15 20:09:43"
},
{
"body": "Is there a bug or something that shows why this matters? I'm not super familiar with thise code, and it is used in just 1 or 2 places. Does this really matter?",
"created_at": "2023-08-15 22:46:18"
},
{
"body": "There was a bug we (@Uber) encountered as end users that made us stumble across this, @BoSunesen do you have context on what the bug was again?\r\n\r\nEven without that though in my opinion this is justifiable for inclusion on its own as a quality of life improvement, especially as we've already written the code for it.",
"created_at": "2023-08-17 11:06:10"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:31:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:31:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:31:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:31:20",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:31:22",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:31:24",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:31:25",
"type": "labeled"
},
{
"author": "BoSunesen",
"created_at": "2023-08-11 14:31:50",
"type": "mentioned"
},
{
"author": "BoSunesen",
"created_at": "2023-08-11 14:31:50",
"type": "subscribed"
},
{
"author": "BoSunesen",
"created_at": "2023-08-11 14:31:52",
"type": "mentioned"
},
{
"author": "BoSunesen",
"created_at": "2023-08-11 14:31:52",
"type": "subscribed"
},
{
"author": "intUnderflow",
"created_at": "2023-08-11 14:31:52",
"type": "mentioned"
},
{
"author": "intUnderflow",
"created_at": "2023-08-11 14:31:52",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:31:53",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:31:53",
"type": "review_requested"
},
{
"author": "intUnderflow",
"created_at": "2023-08-11 14:54:39",
"type": "mentioned"
},
{
"author": "intUnderflow",
"created_at": "2023-08-11 14:54:39",
"type": "subscribed"
},
{
"author": "BoSunesen",
"created_at": "2023-08-11 15:08:42",
"type": "mentioned"
},
{
"author": "BoSunesen",
"created_at": "2023-08-11 15:08:42",
"type": "subscribed"
},
{
"author": "intUnderflow",
"created_at": "2023-08-11 15:32:00",
"type": "mentioned"
},
{
"author": "intUnderflow",
"created_at": "2023-08-11 15:32:00",
"type": "subscribed"
},
{
"author": "intUnderflow",
"created_at": "2023-08-11 18:07:26",
"type": "mentioned"
},
{
"author": "intUnderflow",
"created_at": "2023-08-11 18:07:26",
"type": "subscribed"
},
{
"author": "intUnderflow",
"created_at": "2023-08-11 21:36:05",
"type": "mentioned"
},
{
"author": "intUnderflow",
"created_at": "2023-08-11 21:36:05",
"type": "subscribed"
},
{
"author": "smarterclayton",
"created_at": "2023-08-15 20:09:43",
"type": "mentioned"
},
{
"author": "smarterclayton",
"created_at": "2023-08-15 20:09:43",
"type": "subscribed"
},
{
"author": "thockin",
"created_at": "2023-08-15 20:09:43",
"type": "mentioned"
},
{
"author": "thockin",
"created_at": "2023-08-15 20:09:44",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:32:41",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:32:42",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:33:30",
"type": "unlabeled"
},
{
"author": "BoSunesen",
"created_at": "2023-08-17 11:06:10",
"type": "mentioned"
},
{
"author": "BoSunesen",
"created_at": "2023-08-17 11:06:10",
"type": "subscribed"
},
{
"author": "uber",
"created_at": "2023-08-17 11:06:27",
"type": "mentioned"
}
] |
119,909 | vendor: bump to runc 1.1.9 | open | 2023-08-11 14:17:48 | 2023-08-11 15:32:48 | null | [
"rphillips"
] | [
"priority/important-soon",
"kind/documentation",
"lgtm",
"sig/node",
"release-note",
"size/XS",
"cncf-cla: yes",
"do-not-merge/hold",
"area/dependency",
"triage/accepted"
] | haircommander | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Aug 11 10:38:14 UTC 2023.\n",
"created_at": "2023-08-11 14:17:53"
},
{
"body": "replaces https://github.com/kubernetes/kubernetes/pull/119465 (sorry @bzsuni) ",
"created_at": "2023-08-11 14:18:24"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119909#\" title=\"Author self-approved\">haircommander</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [sttts](https://github.com/sttts) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/kubernetes/kubernetes/blob/master/OWNERS)**\n- **[vendor/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/vendor/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"sttts\"]} -->",
"created_at": "2023-08-11 14:18:26"
},
{
"body": "This is important to fix https://github.com/kubernetes/kubernetes/issues/118916\r\n\r\n/triage accepted\r\n/priority important-soon\r\n/lgtm",
"created_at": "2023-08-11 14:21:35"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 7ec377ec450071fe6ae17d85578108573f579e44</details>",
"created_at": "2023-08-11 14:21:43"
},
{
"body": "/sig node",
"created_at": "2023-08-11 14:23:27"
},
{
"body": "flake\r\n\r\n/test pull-kubernetes-node-e2e-containerd",
"created_at": "2023-08-11 15:06:29"
},
{
"body": "/hold\r\n\r\nI'm pretty sure for this to work, we'll also need https://github.com/google/cadvisor/pull/3373",
"created_at": "2023-08-11 15:08:27"
},
{
"body": "@haircommander: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-e2e-gce | aee9d43dd8ae5a3d91e9ef2b33e7b70fb3b16264 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119909/pull-kubernetes-e2e-gce/1690004604378419200/) | true | `/test pull-kubernetes-e2e-gce`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119909). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3Ahaircommander). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"created_at": "2023-08-11 15:14:59"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:17:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:17:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:17:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:17:56",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:17:56",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:17:56",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:17:58",
"type": "labeled"
},
{
"author": "bzsuni",
"created_at": "2023-08-11 14:18:24",
"type": "mentioned"
},
{
"author": "bzsuni",
"created_at": "2023-08-11 14:18:24",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:18:38",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:18:39",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:18:39",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:18:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:21:37",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:21:38",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:21:39",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:21:40",
"type": "unlabeled"
},
{
"author": "rphillips",
"created_at": "2023-08-11 14:21:41",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:21:42",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:23:29",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 14:23:31",
"type": "unlabeled"
},
{
"author": "haircommander",
"created_at": "2023-08-11 14:47:02",
"type": "mentioned"
},
{
"author": "haircommander",
"created_at": "2023-08-11 14:47:02",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 15:08:29",
"type": "labeled"
},
{
"author": "haircommander",
"created_at": "2023-08-11 15:14:59",
"type": "mentioned"
},
{
"author": "haircommander",
"created_at": "2023-08-11 15:14:59",
"type": "subscribed"
}
] |
119,908 | Add ReleaseOnCancel to cloud-controller-manager LE config | open | 2023-08-11 12:58:45 | 2023-08-11 14:04:39 | null | [
"deads2k"
] | [
"kind/bug",
"area/cloudprovider",
"release-note",
"size/S",
"cncf-cla: yes",
"do-not-merge/work-in-progress",
"sig/cloud-provider",
"needs-priority",
"needs-triage"
] | JoelSpeed | [
{
"body": "Skipping CI for Draft Pull Request.\nIf you want CI signal for your change, please convert it to an actual PR.\nYou can still manually trigger a test run with `/test all`",
"created_at": "2023-08-11 12:58:47"
},
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Aug 11 10:38:14 UTC 2023.\n",
"created_at": "2023-08-11 12:58:49"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-11 12:58:53"
},
{
"body": "/test all",
"created_at": "2023-08-11 12:59:20"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119908#\" title=\"Author self-approved\">JoelSpeed</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [cheftako](https://github.com/cheftako) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/cloud-provider/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/cloud-provider/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"cheftako\"]} -->",
"created_at": "2023-08-11 12:59:34"
},
{
"body": "There [was a previous attempt to do this ](https://github.com/kubernetes/kubernetes/pull/94509#issuecomment-689106856) and seems @deads2k had some requirements, are we meeting these requirements now?\r\n\r\n/assign @deads2k \r\n\r\n",
"created_at": "2023-08-11 13:25:49"
},
{
"body": "@JoelSpeed: The following test **failed**, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:\n\nTest name | Commit | Details | Required | Rerun command\n--- | --- | --- | --- | ---\npull-kubernetes-e2e-kind-ipv6 | 4067e12f16c8650f2a7fd47eac90e7b4999a8308 | [link](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/119908/pull-kubernetes-e2e-kind-ipv6/1689984858798952448) | true | `/test pull-kubernetes-e2e-kind-ipv6`\n\n[Full PR test history](https://prow.k8s.io/pr-history?org=kubernetes&repo=kubernetes&pr=119908). [Your PR dashboard](https://prow.k8s.io/pr?query=is%3Apr%20state%3Aopen%20author%3AJoelSpeed). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/sig-testing/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->",
"created_at": "2023-08-11 13:33:53"
},
{
"body": "I spoke with @deads2k, @ingvagabund and @soltysh about this before and I believe the KCM has been working towards doing this and is, IIRC, vaguely ready for theirs.\r\n\r\nThis patch shouldn't affect the KCM, but, my intention was to set this up as a WIP and start testing out the patch in various cloud providers to see how they handle it. Taking inspiration from what they've done to make sure things are working wired up correctly for the CCM as well.",
"created_at": "2023-08-11 14:04:38"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:58:47",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:58:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:58:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:58:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:58:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:58:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:58:52",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:58:54",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:59:22",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:59:46",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:59:46",
"type": "review_requested"
},
{
"author": "deads2k",
"created_at": "2023-08-11 13:25:50",
"type": "mentioned"
},
{
"author": "deads2k",
"created_at": "2023-08-11 13:25:50",
"type": "subscribed"
},
{
"author": "deads2k",
"created_at": "2023-08-11 13:25:51",
"type": "assigned"
},
{
"author": "JoelSpeed",
"created_at": "2023-08-11 13:33:54",
"type": "mentioned"
},
{
"author": "JoelSpeed",
"created_at": "2023-08-11 13:33:54",
"type": "subscribed"
},
{
"author": "soltysh",
"created_at": "2023-08-11 14:04:39",
"type": "mentioned"
},
{
"author": "soltysh",
"created_at": "2023-08-11 14:04:39",
"type": "subscribed"
},
{
"author": "ingvagabund",
"created_at": "2023-08-11 14:04:39",
"type": "mentioned"
},
{
"author": "ingvagabund",
"created_at": "2023-08-11 14:04:39",
"type": "subscribed"
},
{
"author": "deads2k",
"created_at": "2023-08-11 14:04:39",
"type": "mentioned"
},
{
"author": "deads2k",
"created_at": "2023-08-11 14:04:39",
"type": "subscribed"
}
] |
119,907 | Fixing the "Service Account Token" link in the readme | closed | 2023-08-11 12:55:43 | 2023-08-16 09:12:41 | 2023-08-16 06:13:59 | [
"yliaog"
] | [
"kind/documentation",
"lgtm",
"sig/api-machinery",
"size/XS",
"release-note-none",
"approved",
"cncf-cla: yes",
"ok-to-test",
"needs-priority",
"triage/accepted"
] | Hii-Arpit | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Aug 11 10:38:14 UTC 2023.\n",
"created_at": "2023-08-11 12:55:46"
},
{
"body": "Hi @Hii-Arpit. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-11 12:55:52"
},
{
"body": "/kind documentation",
"created_at": "2023-08-11 12:59:43"
},
{
"body": "/release-note-none",
"created_at": "2023-08-11 13:01:23"
},
{
"body": "/ok-to-test",
"created_at": "2023-08-11 15:08:23"
},
{
"body": "/test pull-kubernetes-integration\r\n",
"created_at": "2023-08-11 21:13:28"
},
{
"body": "/lgtm\r\n/approve",
"created_at": "2023-08-11 21:15:25"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 3c35b3125866503715a0ed4b35e52b045bff6373</details>",
"created_at": "2023-08-11 21:15:33"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119907#\" title=\"Author self-approved\">Hii-Arpit</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119907#issuecomment-1675409737\" title=\"Approved\">yliaog</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[staging/src/k8s.io/client-go/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/OWNERS)~~ [yliaog]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-11 21:19:56"
},
{
"body": "/triage accepted",
"created_at": "2023-08-15 20:11:07"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:55:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:55:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:55:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:55:50",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:55:50",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:55:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:55:51",
"type": "labeled"
},
{
"author": "Hii-Arpit",
"created_at": "2023-08-11 12:55:52",
"type": "mentioned"
},
{
"author": "Hii-Arpit",
"created_at": "2023-08-11 12:55:52",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:55:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:56:18",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:56:20",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:56:44",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:56:44",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:59:45",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:59:47",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 13:01:31",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 13:01:31",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 15:08:25",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 15:08:26",
"type": "unlabeled"
},
{
"author": "Hii-Arpit",
"created_at": "2023-08-11 16:09:33",
"type": "mentioned"
},
{
"author": "Hii-Arpit",
"created_at": "2023-08-11 16:09:33",
"type": "subscribed"
},
{
"author": "yliaog",
"created_at": "2023-08-11 21:15:31",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 21:15:32",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 21:19:57",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:27:14",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:43:38",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:13:59",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:13:59",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:13:59",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:14:01",
"type": "milestoned"
}
] |
119,906 | Fixing the "Service Account Token" broken link in above readme | closed | 2023-08-11 12:21:11 | 2023-08-15 20:42:08 | 2023-08-11 12:41:53 | [] | [
"sig/api-machinery",
"size/XS",
"cncf-cla: yes",
"needs-ok-to-test",
"do-not-merge/release-note-label-needed",
"needs-priority",
"do-not-merge/contains-merge-commits",
"triage/accepted",
"do-not-merge/needs-kind"
] | Hii-Arpit | [
{
"body": "Adding the \"do-not-merge/release-note-label-needed\" label because no release-note block was detected, please follow our [release note process](https://git.k8s.io/community/contributors/guide/release-notes.md) to remove it.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-11 12:21:13"
},
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Aug 11 10:38:14 UTC 2023.\n",
"created_at": "2023-08-11 12:21:15"
},
{
"body": "Welcome @Hii-Arpit! <br><br>It looks like this is your first PR to <a href='https://github.com/kubernetes/kubernetes'>kubernetes/kubernetes</a> 🎉. Please refer to our [pull request process documentation](https://git.k8s.io/community/contributors/guide/pull-requests.md) to help your PR have a smooth ride to approval. <br><br>You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. [Here is the bot commands documentation](https://go.k8s.io/bot-commands). <br><br>You can also check if kubernetes/kubernetes has [its own contribution guidelines](https://github.com/kubernetes/kubernetes/tree/master/CONTRIBUTING.md). <br><br>You may want to refer to our [testing guide](https://git.k8s.io/community/contributors/devel/sig-testing/testing.md) if you run into trouble with your tests not passing. <br><br>If you are having difficulty getting your pull request seen, please follow the [recommended escalation practices](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#why-is-my-pull-request-not-getting-reviewed). Also, for tips and tricks in the contribution process you may want to read the [Kubernetes contributor cheat sheet](https://git.k8s.io/community/contributors/guide/contributor-cheatsheet/README.md). We want to make sure your contribution gets all the attention it needs! <br><br>Thank you, and welcome to Kubernetes. :smiley:",
"created_at": "2023-08-11 12:21:19"
},
{
"body": "Hi @Hii-Arpit. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n",
"created_at": "2023-08-11 12:21:20"
},
{
"body": "Adding label `do-not-merge/contains-merge-commits` because PR contains merge commits, which are not allowed in this repository.\nUse `git rebase` to reapply your commits on top of the target branch. Detailed instructions for doing so can be found [here](https://git.k8s.io/community/contributors/guide/github-workflow.md#4-keep-your-branch-in-sync).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-11 12:21:29"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119906#\" title=\"Author self-approved\">Hii-Arpit</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [caesarxuchao](https://github.com/caesarxuchao) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[staging/src/k8s.io/client-go/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"caesarxuchao\"]} -->",
"created_at": "2023-08-11 12:21:57"
},
{
"body": "/triage accepted",
"created_at": "2023-08-15 20:11:14"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:21:13",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:21:14",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:21:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:21:18",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:21:18",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:21:19",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:21:19",
"type": "labeled"
},
{
"author": "Hii-Arpit",
"created_at": "2023-08-11 12:21:19",
"type": "mentioned"
},
{
"author": "Hii-Arpit",
"created_at": "2023-08-11 12:21:19",
"type": "subscribed"
},
{
"author": "Hii-Arpit",
"created_at": "2023-08-11 12:21:20",
"type": "mentioned"
},
{
"author": "Hii-Arpit",
"created_at": "2023-08-11 12:21:20",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:21:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:21:29",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:21:45",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:21:45",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:22:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:22:11",
"type": "unlabeled"
},
{
"author": "Hii-Arpit",
"created_at": "2023-08-11 12:41:53",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:24:07",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-15 20:42:07",
"type": "unlabeled"
}
] |
119,905 | Cloud Controller Managers do not release leader election when shutting down | open | 2023-08-11 12:00:13 | 2023-08-22 17:00:17 | null | [] | [
"kind/bug",
"sig/cloud-provider",
"triage/accepted"
] | JoelSpeed | [
{
"body": "/triage accepted",
"created_at": "2023-08-16 15:53:15"
},
{
"body": "We had some discussion about this on the sig-cloud-provider last week, some questions came up that would be good to answer, adding those here so we don't forget:\r\n* If we use `ReleaseOnCancel` can we drop the `panic` that happens normally in `OnStoppedLeading`, usually via `klog.Fatalf`\r\n* How do we make sure that providers using the core libraries for cloud-provider `app`, are aware of the requirements of their code to be compatible with `ReleaseOnCancel`?\r\n* What happens with respect to the migration leader election that exists for migrating from KCM to CCMs. Does that need to be set up with `ReleaseOnCancel` too, what happens if we don't have the config synced there?",
"created_at": "2023-08-22 17:00:17"
}
] | [
{
"author": "JoelSpeed",
"created_at": "2023-08-11 12:00:13",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:00:16",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 12:00:21",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:53:17",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 15:53:18",
"type": "unlabeled"
}
] |
119,904 | Job: Replace deprecated workqueue function with supported one | closed | 2023-08-11 11:46:45 | 2023-08-16 06:14:42 | 2023-08-16 06:13:52 | [
"alculquicondor",
"mimowo"
] | [
"kind/cleanup",
"lgtm",
"size/XS",
"release-note-none",
"sig/apps",
"approved",
"cncf-cla: yes",
"needs-priority",
"needs-triage"
] | tenzen-y | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Aug 11 10:38:14 UTC 2023.\n",
"created_at": "2023-08-11 11:46:49"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-11 11:46:53"
},
{
"body": "/assign @mimowo \r\n",
"created_at": "2023-08-11 15:21:07"
},
{
"body": "/hold for code freeze term",
"created_at": "2023-08-11 15:22:13"
},
{
"body": "LGTM label has been added. <details>Git tree hash: 5dd6b316fbdaea6cd279ed77938ca2e456f37f4c</details>",
"created_at": "2023-08-11 16:08:54"
},
{
"body": "> I would just suggest replacing \"library\" with \"function\" in the title\r\n\r\nSGTM\r\n\r\n/retitle Job: Replace deprecated workqueue function with supported one\r\n",
"created_at": "2023-08-11 16:10:50"
},
{
"body": "/approve\r\n/hold cancel\r\n(It's not going to merge until the code-freeze is over)",
"created_at": "2023-08-11 17:03:07"
},
{
"body": "[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119904#issuecomment-1675102772\" title=\"Approved\">alculquicondor</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/119904#\" title=\"Author self-approved\">tenzen-y</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[pkg/controller/job/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/job/OWNERS)~~ [alculquicondor]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->",
"created_at": "2023-08-11 17:03:32"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:46:47",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:46:47",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:46:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:46:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:46:52",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:46:53",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:46:54",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:47:17",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:47:17",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:47:42",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:47:44",
"type": "unlabeled"
},
{
"author": "mimowo",
"created_at": "2023-08-11 15:21:07",
"type": "mentioned"
},
{
"author": "mimowo",
"created_at": "2023-08-11 15:21:07",
"type": "subscribed"
},
{
"author": "mimowo",
"created_at": "2023-08-11 15:21:08",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 15:22:14",
"type": "labeled"
},
{
"author": "alculquicondor",
"created_at": "2023-08-11 16:08:48",
"type": "assigned"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 16:08:52",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 16:10:52",
"type": "renamed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 17:03:09",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 17:03:33",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:13:52",
"type": "referenced"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:13:52",
"type": "merged"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:13:52",
"type": "closed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-16 06:13:55",
"type": "milestoned"
},
{
"author": "tenzen-y",
"created_at": "2023-08-16 06:14:42",
"type": "head_ref_deleted"
}
] |
119,903 | Scheduling of the number of pods for kubernetes workload | open | 2023-08-11 11:41:18 | 2023-08-16 15:14:40 | null | [] | [
"sig/scheduling",
"kind/feature",
"needs-triage"
] | dashanji | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-11 11:41:26"
},
{
"body": "/sig scheduling",
"created_at": "2023-08-11 13:33:28"
},
{
"body": "@claim I want to work on this issue please assign me",
"created_at": "2023-08-12 13:57:49"
},
{
"body": "Can anyone guide me how to start working on this issue",
"created_at": "2023-08-12 17:15:26"
},
{
"body": "@yp969803, Anybody is welcome to work on this issue.\r\n\r\nYou can use `/assign` tag to assign this issue to yourself",
"created_at": "2023-08-13 19:49:39"
},
{
"body": "This issue has not been accepted yet. I think we should wait for sig-scheduling‘s discussion first.",
"created_at": "2023-08-14 02:11:26"
},
{
"body": "Ok let's wait for it",
"created_at": "2023-08-14 14:49:32"
},
{
"body": "Thanks for bring this to the community @dashanji but I can't fully understand what you mean, can you embrace more? Like \r\n\r\n> After computing, the best scheduling order for producer deployment is 1 replica for node1 and 2 replicas for node2\r\n\r\nBut as you said above, we have 2 replicas for producer, but we have 3 here ... Do you mean the **second replica** here? And how this helps to reduce data copying costs.\r\n\r\nOne more thing, considering we usually deploy the HPA together with deployment, which will dynamically tune the replicas of deployment, specify the pod number might be problematic ...",
"created_at": "2023-08-15 09:46:33"
},
{
"body": "@kerthcet, sorry for the poor expression previously, I will show a demo next. \r\n\r\nAssume we have a kubernetes cluster with 3 worker nodes and the following consumer yaml is as follows.\r\n```yaml\r\napiVersion: apps/v1\r\nkind: Job\r\nmetadata:\r\n name: producer\r\nspec:\r\n selector:\r\n matchLabels:\r\n app: producer\r\n parallelism: 2\r\n template:\r\n metadata:\r\n labels:\r\n app: producer\r\n spec:\r\n containers:\r\n - name: producer\r\n image: producer\r\n```\r\nAssume the job will create one pod on Node1 and another pod on Node2. After the job is completed, we can get the data produced on Node1 is around 80%, and the data on Node2 is around 20%. Then we want to create three consumer workers to consume these data average. If three consumer workers are deployed on Node1, then we need to migrate the data on Node2 to the Node1 and the cost is 20%. If three consumer workers are deployed on Node2, the cost is 80%. As a result, the best scheduling order is two workers on Node1 and one worker on Node2.\r\n\r\nBased on the current kubernetes affinity/anti-affinity design, it looks like we can't achieve the above target. If there is something I missed, please feel free to correct me. \r\n\r\nAssuming we have a number field, then we can label Node1 with `kubernetes.io/name:node1` and Node2 with `kubernetes.io/name:node2` and apply the following consumer yaml.\r\n```yaml\r\napiVersion: apps/v1\r\nkind: Job\r\nmetadata:\r\n name: consumer\r\nspec:\r\n selector:\r\n matchLabels:\r\n app: consumer\r\n parallelism: 3\r\n template:\r\n metadata:\r\n labels:\r\n app: consumer\r\n spec:\r\n containers:\r\n - name: consumer\r\n image: consumer\r\n affinity:\r\n nodeAffinity:\r\n requiredDuringSchedulingIgnoredDuringExecution:\r\n nodeSelectorTerms:\r\n - matchExpressions:\r\n - key: kubernetes.io/name\r\n operator: In\r\n values:\r\n - node1\r\n # indicate the target number of pods that match the expressions\r\n num: 2\r\n requiredDuringSchedulingIgnoredDuringExecution:\r\n nodeSelectorTerms:\r\n - matchExpressions:\r\n - key: kubernetes.io/name\r\n operator: In\r\n values:\r\n - node2\r\n # indicate the target number of pods that match the expressions\r\n num: 1\r\n```\r\n\r\n\r\n\r\n",
"created_at": "2023-08-15 12:14:08"
},
{
"body": "Based on my understanding, you want the result `the best scheduling order is two workers on Node1 and one worker on Node2` b/c:\r\n- No need to migrate the data across nodes\r\n- Allocate more pods on the nodes with more data for faster data ingesting.\r\n\r\nWhat you present in the yaml is not right because we only accept one `requiredDuringSchedulingIgnoredDuringExecution` for nodeAffinity. So basically what you need is:\r\n- You want the spread scheduling, seems like topology spread\r\n- You have a prefer node where node affinity seems can help\r\n\r\nThen maybe we can bind podTopologySpread and nodeAffinity together, you can refer to https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/ for details. Pay attention to the `minDomains`, I guess 2 in your scenario and also the `maxSkew`.\r\n\r\nBut we can't specify the pod number explicitly. Does this helpful?",
"created_at": "2023-08-16 03:19:53"
},
{
"body": "@kerthcet Thanks a lot, the doc https://kubernetes.io/docs/concepts/scheduling-eviction/topology-spread-constraints/ makes sense to me.\r\n\r\nBased on the doc, we can bind the nodeAffinity and podTopologySpread together as follows.\r\n```yaml\r\napiVersion: apps/v1\r\nkind: Job\r\nmetadata:\r\n name: consumer\r\nspec:\r\n selector:\r\n matchLabels:\r\n app: consumer\r\n parallelism: 3\r\n template:\r\n metadata:\r\n labels:\r\n app: consumer\r\n spec:\r\n containers:\r\n - name: consumer\r\n image: consumer\r\n affinity:\r\n topologySpreadConstraints:\r\n - maxSkew: 2\r\n topologyKey: kubernetes.io/hostname\r\n whenUnsatisfiable: DoNotSchedule\r\n labelSelector:\r\n matchLabels:\r\n app: consumer\r\n nodeAffinity:\r\n requiredDuringSchedulingIgnoredDuringExecution:\r\n nodeSelectorTerms:\r\n - matchExpressions:\r\n - key: kubernetes.io/hostname\r\n operator: In\r\n values:\r\n - node1\r\n - node2\r\n```\r\n\r\nActually, it can't be specific, as the result could be `two workers on Node1 and one worker on Node2` or `one worker on Node1 and two workers on Node2`. Also, the way is a little tricky and it can't handle such an order of `three workers on Node1, two workers on Node2, one worker on Node3`.\r\n\r\nIMHO, maybe we need to extend the current design, I wonder if such a feature would benefit the community.\r\n",
"created_at": "2023-08-16 15:14:40"
}
] | [
{
"author": "dashanji",
"created_at": "2023-08-11 11:41:18",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:41:24",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:41:25",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 13:33:29",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 13:33:31",
"type": "unlabeled"
},
{
"author": "yp969803",
"created_at": "2023-08-13 19:49:40",
"type": "mentioned"
},
{
"author": "yp969803",
"created_at": "2023-08-13 19:49:40",
"type": "subscribed"
},
{
"author": "dashanji",
"created_at": "2023-08-15 09:46:33",
"type": "mentioned"
},
{
"author": "dashanji",
"created_at": "2023-08-15 09:46:33",
"type": "subscribed"
},
{
"author": "kerthcet",
"created_at": "2023-08-15 11:41:16",
"type": "mentioned"
},
{
"author": "kerthcet",
"created_at": "2023-08-15 11:41:16",
"type": "subscribed"
},
{
"author": "kerthcet",
"created_at": "2023-08-15 12:14:08",
"type": "mentioned"
},
{
"author": "kerthcet",
"created_at": "2023-08-15 12:14:08",
"type": "subscribed"
},
{
"author": "kerthcet",
"created_at": "2023-08-16 15:14:40",
"type": "mentioned"
},
{
"author": "kerthcet",
"created_at": "2023-08-16 15:14:40",
"type": "subscribed"
}
] |
119,902 | e2e: add test for verification of timestamp for new PVs | open | 2023-08-11 11:40:57 | 2023-08-16 10:09:39 | null | [] | [
"area/test",
"kind/cleanup",
"sig/storage",
"size/S",
"release-note-none",
"cncf-cla: yes",
"sig/testing",
"needs-priority",
"needs-triage"
] | RomanBednar | [
{
"body": "Please note that we're already in [Test Freeze](https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md#test-freeze) for the `release-1.28` branch. This means every merged PR will be automatically fast-forwarded via the periodic [ci-fast-forward](https://testgrid.k8s.io/sig-release-releng-blocking#git-repo-kubernetes-fast-forward) job to the release branch of the upcoming v1.28.0 release.\n\nFast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Aug 11 10:38:14 UTC 2023.\n",
"created_at": "2023-08-11 11:41:02"
},
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-11 11:41:06"
},
{
"body": "[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/119902#\" title=\"Author self-approved\">RomanBednar</a>*\n**Once this PR has been reviewed and has the lgtm label**, please assign [thockin](https://github.com/thockin) for approval. For more information see [the Kubernetes Code Review Process](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process).\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands?repo=kubernetes%2Fkubernetes).\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[test/e2e/storage/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"thockin\"]} -->",
"created_at": "2023-08-11 11:42:01"
},
{
"body": "/retest-required",
"created_at": "2023-08-16 09:38:22"
}
] | [
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:41:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:41:00",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:41:01",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:41:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:41:05",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:41:05",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:41:07",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:41:36",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:41:36",
"type": "review_requested"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:41:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:41:49",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:41:50",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:41:51",
"type": "unlabeled"
},
{
"author": "RomanBednar",
"created_at": "2023-08-11 12:09:43",
"type": "mentioned"
},
{
"author": "RomanBednar",
"created_at": "2023-08-11 12:09:43",
"type": "subscribed"
},
{
"author": "RomanBednar",
"created_at": "2023-08-11 12:11:20",
"type": "mentioned"
},
{
"author": "RomanBednar",
"created_at": "2023-08-11 12:11:20",
"type": "subscribed"
}
] |
119,901 | Kubelet.service failing to start in ubuntu 22.04 | closed | 2023-08-11 10:59:03 | 2023-08-14 06:34:07 | 2023-08-14 06:34:05 | [] | [
"kind/support",
"sig/cluster-lifecycle",
"needs-triage"
] | brf153 | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-11 10:59:11"
},
{
"body": "/remove-kind bug\r\n/kind support\r\n/sig cluster-lifecycle \r\n\r\nI would check first that you are correctly following the instructions to create the cluster\r\nhttps://kubernetes.io/docs/setup/production-environment/tools/kubeadm/create-cluster-kubeadm/",
"created_at": "2023-08-11 11:03:46"
},
{
"body": "@brf153: Those labels are not set on the issue: `kind/bug`\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119901#issuecomment-1674579779):\n\n>/remove-kind bug\n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-11 11:11:09"
},
{
"body": "@aojea I am running the command `sudo kubeadm init` . Initially it shows that the port 10250 is already in use. Now, when I do `sudo lsof -i :10250` it shows me:-\r\n```\r\nCOMMAND PID USER FD TYPE DEVICE SIZE/OFF NODE NAME\r\nkubelet 717241 root 15u IPv6 2492426 0t0 TCP *:10250 (LISTEN)\r\n```\r\n",
"created_at": "2023-08-11 11:20:14"
},
{
"body": "a better place to ask would be on the support channels. please see:\r\nhttps://git.k8s.io/kubernetes/SUPPORT.md\r\n\r\n/kind support\r\n/close ",
"created_at": "2023-08-14 06:34:01"
},
{
"body": "@neolit123: Closing this issue.\n\n<details>\n\nIn response to [this](https://github.com/kubernetes/kubernetes/issues/119901#issuecomment-1676756232):\n\n>a better place to ask would be on the support channels. please see:\r\n>https://git.k8s.io/kubernetes/SUPPORT.md\r\n>\r\n>/kind support\r\n>/close \n\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-14 06:34:06"
}
] | [
{
"author": "brf153",
"created_at": "2023-08-11 10:59:03",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 10:59:09",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 10:59:11",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:03:47",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:03:48",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:03:48",
"type": "unlabeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 11:03:49",
"type": "unlabeled"
},
{
"author": "brf153",
"created_at": "2023-08-11 11:11:09",
"type": "mentioned"
},
{
"author": "brf153",
"created_at": "2023-08-11 11:11:09",
"type": "subscribed"
},
{
"author": "aojea",
"created_at": "2023-08-11 11:20:14",
"type": "mentioned"
},
{
"author": "aojea",
"created_at": "2023-08-11 11:20:14",
"type": "subscribed"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-14 06:34:06",
"type": "closed"
},
{
"author": "neolit123",
"created_at": "2023-08-14 06:34:07",
"type": "mentioned"
},
{
"author": "neolit123",
"created_at": "2023-08-14 06:34:07",
"type": "subscribed"
}
] |
119,900 | Default topologySpreadConstraints are not working for StatefulSet pods | open | 2023-08-11 09:59:43 | 2023-08-16 03:27:09 | null | [] | [
"kind/bug",
"sig/scheduling",
"needs-triage"
] | amnk | [
{
"body": "This issue is currently awaiting triage.\n\nIf a SIG or subproject determines this is a relevant issue, they will accept it by applying the `triage/accepted` label and provide further guidance.\n\nThe `triage/accepted` label can be added by org members by writing `/triage accepted` in a comment.\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>",
"created_at": "2023-08-11 09:59:52"
},
{
"body": "/sig scheduling",
"created_at": "2023-08-13 19:48:06"
},
{
"body": "kubernetes 1.21 is out of support from the community, can you try with the 1.26 at least? We patched a lot since 1.21 ...\r\n\r\nOne thing to mention here is when rolling update, the topology spread is not respected because terminating pods are also taken into consideration in 1.21.",
"created_at": "2023-08-16 03:27:09"
}
] | [
{
"author": "amnk",
"created_at": "2023-08-11 09:59:43",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 09:59:50",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-11 09:59:51",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 19:48:07",
"type": "labeled"
},
{
"author": "k8s-ci-robot",
"created_at": "2023-08-13 19:48:08",
"type": "unlabeled"
}
] |