Allow running conversion after closing a previous PR.

#21
by rwightman HF staff - opened

Cannot run conversion after a previous PR was closed for valid reason.

Safetensors org

i agree with this, WDYT @Narsil ?

Looking at blame it looked like it was actually this way before. Right now I have a repo where someone did a conversion on one of two weight sets in the repo, I want to convert both open_clip + transformers together, but I'm blocked by the other PR that wasn't merged. Closing that PR doesn't help, I'm still blocked. So either this, or allowing the force arg to be passed to a checkbox would be required...

@julien-c @Narsil any thoughts, been a while... also have #37 to merge .. is there anyone maintaining this right now aside from restarting?

Safetensors org

We removed that because we received complaints about people closing PRs and still receiving automated conversions PRs (since it would relaunch automatically).

I can add a force button when triggering the job manually but it's still not going to rename the files automatically (since it's a dumb job that just converts every pickle file to the same name, it's not library aware).
At this point, what's the issue with converting on your end, it should only be a couple of lines script, no ?

@Narsil for this one, can live without but the button would have helped deal with some cases without writing and launching custom scripts... but for #37 is a bigger problem as every auto-convert launch that other people trigger for open_clip is renaming the weights wrong and I have to go in and manually fix them.

I can also add the button / fix the open_clip rename myself if given the permissions to modify the bot.

Ready to merge
This branch is ready to get merged automatically.

Sign up or log in to comment