Is SiglipImageProcessor configured correctly?
#9
by
karby
- opened
Hey, just checking if you are sure the current image scaling behavior is correct.
At the moment input images are scaled down ignoring the image aspect of the source, in contrast to Clip variants like clip-vit-large-patch14 or laion-CLIP-ViT-L-14-laion2B-s32B-b82K for example. Is that on purpose? Other implementations seem not to be in line with this.
original:
siglip:
clip-336:
laion-vit-h-14:
Let me know what you think.
PS: I think the configuration of the ImageProcessor scaling mode could be a bit less obscure. If anyone would fancy a rewrite to make this nicer I might not stop him.
EDIT: That's because scaling mode for SiglipImageProcessor can't be configured, size={"shortest_edge": 384} is not accepted.