Spaces:
Sleeping
Sleeping
| Pull Request Number: 4214 | |
| Title: Update data-slot for the error message in the select. | |
| Base Branch: canary | |
| Head Branch: update-select-data-slot | |
| Author: jubar | |
| URL: https://github.com/nextui-org/nextui/pull/4214 | |
| State: MERGED | |
| Created At: 2024-12-02T21:09:33Z | |
| Merged At: 2024-12-03T13:07:13Z | |
| Participants: jubar, jrgarciadev, wingkwong | |
| Description: | |
| All components use the data-slot="error-message" attribute, except for the select component. I observed this behavior when a test in my application started failing. | |
| Closes # | |
| 📝 Description | |
| ⛳️ Current behavior (updates) | |
| 🚀 New behavior | |
| 💣 Is this a breaking change (Yes/No): | |
| 📝 Additional Information | |
| Summary by CodeRabbit | |
| Chores | |
| Standardized the naming convention for the data-slot attribute to improve consistency. | |
| Minor code organization adjustments for clarity, including comment reordering and a TODO for future enhancements. | |
| Commits: | |
| - Update data-slot for the error message in the select. | |
| All components use the `data-slot="error-message"` attribute, except for the select component. I observed this behavior when a test in my application started failing.\n- refactor(select): refactors the data-slots attribute for the error message\n | |
| Labels: | |
| Comments: | |
| - changeset-bot: ### 🦋 Changeset detected | |
| Latest commit: d6171ea56259df2839bcf5a840adb47adfde48d2 | |
| **The changes in this PR will be included in the next version bump.** | |
| <details><summary>This PR includes changesets to release 2 packages</summary> | |
| | Name | Type | | |
| | ------------------ | ----- | | |
| | @nextui-org/select | Patch | | |
| | @nextui-org/react | Patch | | |
| </details> | |
| Not sure what this means? [Click here to learn what changesets are](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md). | |
| [Click here if you're a maintainer who wants to add another changeset to this PR](https://github.com/jubar/nextui/new/update-select-data-slot?filename=.changeset/bright-rabbits-jog.md&value=---%0A%22%40nextui-org%2Fselect%22%3A%20patch%0A---%0A%0AUpdate%20data-slot%20for%20the%20error%20message%20in%20the%20select.%0A) | |
| \n- vercel: @jubar is attempting to deploy a commit to the **NextUI Inc** Team on [Vercel](https://vercel.com). | |
| A member of the Team first needs to [authorize it](https://vercel.com/git/authorize?team=NextUI%20Inc&type=github&job=%7B%22headInfo%22%3A%7B%22sha%22%3A%229901e06aac6d6cdf2e27448a76e952a15aec4371%22%7D%2C%22id%22%3A%22QmadMcdsEU561Gz4kSP5dMbmVA9BFtiF6sZJv3vHWYPikL%22%2C%22org%22%3A%22nextui-org%22%2C%22prId%22%3A4214%2C%22repo%22%3A%22nextui%22%7D). | |
| \n- coderabbitai: <!-- This is an auto-generated comment: summarize by coderabbit.ai --> | |
| <!-- walkthrough_start --> | |
| ## Walkthrough | |
| The changes in this pull request focus on the `use-select.ts` file, specifically modifying the `getErrorMessageProps` function by updating the `data-slot` attribute from `"data-slot": "errorMessage"` to `"data-slot": "error-message"`. This adjustment standardizes the naming convention for data attributes. Additionally, there are minor code organization changes, including reordering comments and adding a TODO comment for future validation enhancements. Overall, the functionality and control flow of the component remain unchanged. | |
| ## Changes | |
| | File Path | Change Summary | | |
| |-----------------------------------------|---------------------------------------------------------------------------------------------------| | |
| | packages/components/select/src/use-select.ts | Updated `data-slot` attribute from `"errorMessage"` to `"error-message"`; minor code reorganization and comments added. | | |
| | .changeset/dirty-trainers-love.md | Updated `data-slot` attribute from "errorMessage" to "error-message" for consistency in the `@nextui-org/select` component. | | |
| ## Possibly related PRs | |
| - **#3598**: This PR modifies the `data-slot` attribute from "errorMessage" to "error-message" in the `@nextui-org/select` component, which directly relates to the change made in the main PR regarding the same attribute in the `use-select.ts` file. | |
| - **#4082**: This PR introduces changes to the `use-select.ts` file, specifically adding the `isInvalid` property and modifying the validation logic, which may relate to the overall structure and organization of the code in the main PR, although it focuses on different functionality. | |
| ## Suggested reviewers | |
| - jrgarciadev | |
| - wingkwong | |
| <!-- walkthrough_end --> | |
| --- | |
| <details> | |
| <summary>📜 Recent review details</summary> | |
| **Configuration used: .coderabbit.yaml** | |
| **Review profile: CHILL** | |
| <details> | |
| <summary>📥 Commits</summary> | |
| Reviewing files that changed from the base of the PR and between 9901e06aac6d6cdf2e27448a76e952a15aec4371 and d6171ea56259df2839bcf5a840adb47adfde48d2. | |
| </details> | |
| <details> | |
| <summary>📒 Files selected for processing (1)</summary> | |
| * `.changeset/dirty-trainers-love.md` (1 hunks) | |
| </details> | |
| <details> | |
| <summary>✅ Files skipped from review due to trivial changes (1)</summary> | |
| * .changeset/dirty-trainers-love.md | |
| </details> | |
| </details> | |
| <!-- internal state start --> | |
| <!-- FAHghAtBAEAqAWBLAztF0CGA7TBXALgPYQDmAplmQE4b5kAm0AxoQLasX4Bc0ADldEIAjAFZkm+RADcyqIQE9mhetQxChifADoMiaFAB8wY+CjGAxOegAFAErQAyrnYYq84wjJ9cAGx/QqMgBHXFl8aEl8HwZoACIAVV56Wi9k/AwIZB9CcIAzQgF8eC9qKgLoDmRkDHI0HCKvZDJoiVjoAHcMVGRcIVZNOkYFaFwmgRFe10wsRnREFSxJXMQY4YboLGchamgAFgAmAEZdrThivipEVldFfKZRwVyIpFQ7NFQiTHp6QKrpupYWGQKDoWCYikQ9XOoy8hCe6wABmkMlkcgBeWKlAoQSrVcixBGYfD4S5CAheDBMMp/FisXiESiLVCQ55eAByZAAHvh4gBJaA+RBCGhuU688KdVBYHIxIq0DpIaKYPxKOkMzioAiIQUALy8RXQtBJQvJABpWdAmi1wrT6YzwvRCLINjlze0kEx4ALZYRMNBcrofLhAnU/XRkBLNEgoV4YVQAOSoDC8XiCpi0RAMrQec4qZBUxC8SQMur0RDp8PPeXrN66VgfX2sZSIXKKdZW8Q2th2zgRX0YQUkHDtKMWrkgyEkS3pGauRgwoaKHLFAS29VM04ACUI7TIMio5pr9kdzul4X4hCk80avHELfL0BU6W1qECJDnk4t9yogUW0G28AYFe5RwhaHYSKqPZ/uU6xcpSNqAVg5ByGQn4XvSTT0KcACC3yaJmWADj48iHiuXjoNKpblhmJage6ZANIULzMIhtQjiqkIksouBMBSWCKMKZAYAA1p+nrYMh/rlOOEafnGqCgRy3J8tmwCeDYx5OlKOQBGQuTUBQvHTIoyC3kw95MNAADimibr07w9PqgHhJozDZE0yDmtgswuWCQZ5n65CUDQ/iBP0Mw7Pkq4MsaZJEFQDbQMJZBkLwrKIAIdioHcC7TIwgLmU0pzqfEtgADJSUxXi8L4oXBKEEbvNAADaZEALoABTwMSvDIFwAD0/UkFGvRaLS/WUNyuCIBABQkBNXL4NN/U1X4/UHMcACUqmGCYkAwBQjCgRgBDEEFqiDKqHCLDw/CCKInbSM6wwsCoNDqJoOh6LtpgwAgcxJjgJ1EKQFAXTEtLXdwAQYO0lrONcbj/oor2qB92i6PoEBGHtZjALwlLCTUsj9Wu9rIP14H4JTVBMP1MKZM0nZaPgfXALEHPAJY0DYbyoPBSkjA9C4SOgeJSGyDmqQtk8nFlPQPHOk2ZbLBWBGJYiDNUyzyCEss0TmvwVyuNqtyEPcwJIYIMbQAi5D4AAoj+BQALKyHiZDWGUvV67gYLFlgxXnMlKOseRHznAOdA0AHjwWkitAotk+CEkapLkv6ZSsLbsTIpkyexDwmLO1QbtVMTBJ9jneeovghdxFiVA4u7FcIkH6Di7UEbeR+eoR14hHhVOgIyIsBGVRayJErFZrKogQ6fq5I5FH6TYhoCwIRr2UXXOElLUv3kHrto0DGLhZYB0RJGTzLAL+UrkLlBg9ATBGUMa+cEZUDxS0ht5ghUHfFgRAOoaI4FAusVG5oeiekwIfQIBQ3qfjFmwd+eULSQiYEGYEtEngYDgAAeQACIEKur2N8H4ra5AIMGEoWBEK8TQVFaAUgBzzDAf+MggFgJUC3DuPc1BSKyC8J3Z0joXR71yPpCC6xLyqBVNQ/2BE2H4CXAIbIw1LIQPOGTTgql1JyJCv4QEXF/C5GyHDf+GiHxhV0DgTi8E3SjkopQOGjdoCIXoIKK2HBxYoHrHULiCteJHQEDJSQVt1SoGVveBgQdqqXERmbC2cdIFh2ZApexdIyhXitpAnwJtVHoI3iCQyS54Q6OUGQIQXQyCqQsFYbCPho5gI/qkcQBSY7qzjlyekVBLrlBqkINM0BOD4UlsAGAbJ+zNIut0z46wVBYNcK0npnI+kDIEEMkZYzJDOl3CGa4KhQwGlQCrXI2YOaxGMFACAxgxrpIYv1Ms/T5AQBJHY6gyAIDZBkFoVg9AuDs05tzXm/NwZCwRjcOOojkBS0fLfOW3FeJJj4LQWBzDEQAAFJpLRmnNSmTMJCEl0YsaBZkLJXxGEkDMeTzgJ3SPnHIqdiTpzoJnNgDcS5lw9m0T4xcyhN1xBXduqBRGYCuIlCgPR14Mk3qCcEJzziDzEgyUesdjqspNJWfehA/hESPuTDoUYWTrEFMKG49SuaNNmV0uVVdFkdJWQHBSTxekFE2d4YZD5dkrDhZMnmWq4qxhpYMHgDKk7Mo5dnAVrsW74irrGoV8ayBtBZAiHFi1pqzUAYS60JLuzH0uZzSZ2NcYHRmHHYGZ0wYxwhqgzgPAaBw2Fkk5GSg3pqA0Bjb6ZbfpXU0AAfXmMgQdgQrxkF3PQQd3d+lYxxv2gAnIugADIcMgK6ABsGBKSbvoJupg9Bcj7DIPsAA7LsXYAAODAZ7N1kEXQAVn2BgQ4j6MDiF2AAZjPYcedoB9qPk3YcX9QlH2bv2I+xdR79hXq/YuoQTBcjvqvbsFdz8hC7DPc/XIKhr30H2P+gDUAB34GHfQUd46VhTsHYdedQA=== --> | |
| <!-- internal state end --> | |
| <!-- tips_start --> | |
| --- | |
| Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? | |
| <details> | |
| <summary>❤️ Share</summary> | |
| - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) | |
| - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) | |
| - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) | |
| - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) | |
| </details> | |
| <details> | |
| <summary>🪧 Tips</summary> | |
| ### Chat | |
| There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): | |
| - Review comments: Directly reply to a review comment made by CodeRabbit. Example: | |
| - `I pushed a fix in commit <commit_id>, please review it.` | |
| - `Generate unit testing code for this file.` | |
| - `Open a follow-up GitHub issue for this discussion.` | |
| - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: | |
| - `@coderabbitai generate unit testing code for this file.` | |
| - `@coderabbitai modularize this function.` | |
| - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: | |
| - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` | |
| - `@coderabbitai read src/utils.ts and generate unit testing code.` | |
| - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` | |
| - `@coderabbitai help me debug CodeRabbit configuration file.` | |
| Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. | |
| ### CodeRabbit Commands (Invoked using PR comments) | |
| - `@coderabbitai pause` to pause the reviews on a PR. | |
| - `@coderabbitai resume` to resume the paused reviews. | |
| - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. | |
| - `@coderabbitai full review` to do a full review from scratch and review all the files again. | |
| - `@coderabbitai summary` to regenerate the summary of the PR. | |
| - `@coderabbitai resolve` resolve all the CodeRabbit review comments. | |
| - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. | |
| - `@coderabbitai help` to get help. | |
| ### Other keywords and placeholders | |
| - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. | |
| - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. | |
| - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. | |
| ### Documentation and Community | |
| - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. | |
| - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. | |
| - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements. | |
| </details> | |
| <!-- tips_end -->\n- jubar: > For better consistency, I'd suggest to change other data-slot in this file as well. e.g. `helperWrapper` -> `helper-wrapper` etc. | |
| Thanks for bringing this to my attention. I’ll work on it and update the PR shortly. | |
| \n | |
| Files Changed: | |
| - .changeset/dirty-trainers-love.md (added, 5 changes)\n Patch: @@ -0,0 +1,5 @@ | |
| +--- | |
| +"@nextui-org/select": patch | |
| +--- | |
| + | |
| +Update the data-slot attribute of the Select component from "errorMessage" to "error-message" to maintain consistency across all components.\n- packages/components/select/src/use-select.ts (modified, 2 changes)\n Patch: @@ -651,7 +651,7 @@ export function useSelect<T extends object>(originalProps: UseSelectProps<T>) { | |
| return { | |
| ...props, | |
| ...errorMessageProps, | |
| - "data-slot": "errorMessage", | |
| + "data-slot": "error-message", | |
| className: slots.errorMessage({class: clsx(classNames?.errorMessage, props?.className)}), | |
| }; | |
| },\n |