Spaces:
Sleeping
Sleeping
| Pull Request Number: 4253 | |
| Title: fix: rounded corner shadow bug | |
| Base Branch: main | |
| Head Branch: main | |
| Author: CORCTON | |
| URL: https://github.com/nextui-org/nextui/pull/4253 | |
| State: OPEN | |
| Created At: 2024-12-07T03:58:47Z | |
| Merged At: None | |
| Participants: CORCTON | |
| Description: | |
| Closes # | |
| 📝 Description | |
| This PR fixes the issue with the incorrect display of rounded corner shadows on the official website. The shadow was not being rendered correctly in certain browsers, and this update addresses that problem. | |
| ⛳️ Current behavior (updates) | |
| The rounded corner shadows on the website are displayed incorrectly in some browsers. This visual issue impacts the overall design and user experience. | |
| 🚀 New behavior | |
| After this fix, the rounded corner shadows are displayed correctly across all supported browsers. The visual appearance of the website is now consistent with the intended design. | |
| 💣 Is this a breaking change (Yes/No): | |
| No | |
| 📝 Additional Information | |
| This fix primarily affects the visual rendering of the rounded corner shadows on the website. No major changes to functionality or behavior were introduced. | |
| Commits: | |
| - fix: rounded corner shadow bug\n | |
| Labels: | |
| Comments: | |
| - changeset-bot: ### ⚠️ No Changeset found | |
| Latest commit: 5ff3ea84fce837d8bd46556b6aa7e56b7615f68c | |
| Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. **If these changes should result in a version bump, you need to add a changeset.** | |
| <details><summary>This PR includes no changesets</summary> | |
| When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types | |
| </details> | |
| [Click here to learn what changesets are, and how to add one](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md). | |
| [Click here if you're a maintainer who wants to add a changeset to this PR](https://github.com/CORCTON/nextui/new/main?filename=.changeset/nine-pillows-juggle.md&value=---%0A%22%40nextui-org%2Fdocs%22%3A%20patch%0A---%0A%0Afix%3A%20rounded%20corner%20shadow%20bug%0A) | |
| \n- vercel: [vc]: #Muj0gG6JrKNA4X/xeYicvTD2q+mGPvsCjWHz/Su/udw=:eyJpc01vbm9yZXBvIjp0cnVlLCJ0eXBlIjoiZ2l0aHViIiwicHJvamVjdHMiOlt7Im5hbWUiOiJuZXh0dWktc3Rvcnlib29rLXYyIiwicm9vdERpcmVjdG9yeSI6InBhY2thZ2VzL3N0b3J5Ym9vayIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9uZXh0dWktb3JnL25leHR1aS1zdG9yeWJvb2stdjIvQkFTYlRIRlVERDk4VGs3dFdhRDNISkFWYTlMNyIsInByZXZpZXdVcmwiOiJuZXh0dWktc3Rvcnlib29rLXYyLWdpdC1mb3JrLWNvcmN0b24tbWFpbi1uZXh0dWktb3JnLnZlcmNlbC5hcHAiLCJuZXh0Q29tbWl0U3RhdHVzIjoiREVQTE9ZRUQiLCJsaXZlRmVlZGJhY2siOnsicmVzb2x2ZWQiOjAsInVucmVzb2x2ZWQiOjAsInRvdGFsIjowLCJsaW5rIjoibmV4dHVpLXN0b3J5Ym9vay12Mi1naXQtZm9yay1jb3JjdG9uLW1haW4tbmV4dHVpLW9yZy52ZXJjZWwuYXBwIn19LHsibmFtZSI6Im5leHR1aS1kb2NzLXYyIiwicm9vdERpcmVjdG9yeSI6ImFwcHMvZG9jcyIsImluc3BlY3RvclVybCI6Imh0dHBzOi8vdmVyY2VsLmNvbS9uZXh0dWktb3JnL25leHR1aS1kb2NzLXYyL0VIdm5hMVFHUlJBRU51OTZjWUhLTGZMcXBVVVQiLCJwcmV2aWV3VXJsIjoibmV4dHVpLWRvY3MtdjItZ2l0LWZvcmstY29yY3Rvbi1tYWluLW5leHR1aS1vcmcudmVyY2VsLmFwcCIsIm5leHRDb21taXRTdGF0dXMiOiJERVBMT1lFRCIsImxpdmVGZWVkYmFjayI6eyJyZXNvbHZlZCI6MCwidW5yZXNvbHZlZCI6MCwidG90YWwiOjAsImxpbmsiOiJuZXh0dWktZG9jcy12Mi1naXQtZm9yay1jb3JjdG9uLW1haW4tbmV4dHVpLW9yZy52ZXJjZWwuYXBwIn19XX0= | |
| **The latest updates on your projects**. Learn more about [Vercel for Git ↗︎](https://vercel.link/github-learn-more) | |
| | Name | Status | Preview | Comments | Updated (UTC) | | |
| | :--- | :----- | :------ | :------- | :------ | | |
| | **nextui-docs-v2** | ✅ Ready ([Inspect](https://vercel.com/nextui-org/nextui-docs-v2/EHvna1QGRRAENu96cYHKLfLqpUUT)) | [Visit Preview](https://nextui-docs-v2-git-fork-corcton-main-nextui-org.vercel.app) | 💬 [**Add feedback**](https://vercel.live/open-feedback/nextui-docs-v2-git-fork-corcton-main-nextui-org.vercel.app?via=pr-comment-feedback-link) | Dec 7, 2024 4:04am | | |
| | **nextui-storybook-v2** | ✅ Ready ([Inspect](https://vercel.com/nextui-org/nextui-storybook-v2/BASbTHFUDD98Tk7tWaD3HJAVa9L7)) | [Visit Preview](https://nextui-storybook-v2-git-fork-corcton-main-nextui-org.vercel.app) | 💬 [**Add feedback**](https://vercel.live/open-feedback/nextui-storybook-v2-git-fork-corcton-main-nextui-org.vercel.app?via=pr-comment-feedback-link) | Dec 7, 2024 4:04am | | |
| \n- vercel: @CORCTON is attempting to deploy a commit to the **NextUI Inc** Team on [Vercel](https://vercel.com). | |
| A member of the Team first needs to [authorize it](https://vercel.com/git/authorize?team=NextUI%20Inc&type=github&job=%7B%22headInfo%22%3A%7B%22sha%22%3A%225ff3ea84fce837d8bd46556b6aa7e56b7615f68c%22%7D%2C%22id%22%3A%22QmTiUpwh13uVRkeyXdNL7m4ahaU86BPLWENZrayUFAhZgq%22%2C%22org%22%3A%22nextui-org%22%2C%22prId%22%3A4253%2C%22repo%22%3A%22nextui%22%7D). | |
| \n- coderabbitai: <!-- This is an auto-generated comment: summarize by coderabbit.ai --> | |
| <!-- walkthrough_start --> | |
| ## Walkthrough | |
| The pull request introduces updates to the `shopCartStyles` object in the `styles.ts` file, specifically enhancing the `imageWrapper` and `sizeOption` properties within the `modern` variant. The `imageWrapper` now includes an additional class for improved styling, while the `sizeOption` property has been modified to enhance accessibility with a new focus ring class. Other properties, including button styles, have also been adjusted for better visual presentation. The default variants remain unchanged. | |
| ## Changes | |
| | File Path | Change Summary | | |
| |---------------------------------------------|------------------------------------------------------------------------------------------------| | |
| | apps/docs/components/marketing/custom-themes/styles.ts | Modifications to `shopCartStyles`: updated `imageWrapper` with `rounded-3xl` and `shadow-lg`, added focus ring class to `sizeOption`, and adjusted button styles for font size and rounded appearance. Type export for `ShopCartProps` updated. | | |
| ## Possibly related PRs | |
| - **#3486**: Modifies the `title` style attribute within the `menuItem` component, potentially related to visual presentation changes. | |
| - **#3552**: Involves modifications to the CSS class applied to the `checkbox` component, connecting to the overall styling approach. | |
| - **#3691**: Enhances modal positioning and responsiveness, possibly related to accessibility improvements in focus ring styling. | |
| - **#3764**: Addresses hover effects for ghost buttons, relevant to the button styles updated in the main PR. | |
| - **#4105**: Focuses on managing overflow behavior in menu items, aligning with the theme of improving UI component styling. | |
| ## Suggested labels | |
| `👀 Status: To Review` | |
| ## Suggested reviewers | |
| - wingkwong | |
| - jrgarciadev | |
| <!-- walkthrough_end --> | |
| <!-- internal state start --> | |
| <!-- FAHghAtBAEAqAWBLAztF0CGA7TBXALgPYQDmAplmQE4b5kAm0AxoQLasX4Bc0ADldEIAjAFZkm+RADcyqIQE9mhetQxChifADoMiaFAB8wY+CjGAxOegAFAErQAyrnYYq84wjJ9cAGx/QqMgBHXFl8aEl8HwZoACIAM0QADx4qQlwsFUYWKkoBZHgMekIAd2ghXBJY6BKMVGRcIVZNOkYFaFxkamgAYQB5Wx7YPoA5TEy0VEQVLElEmLqbeyxnIW6AFgAmAFYAZi04eC9+RFZXRWExCWkvQniIpFQ7SYjCANlCHxlxyYavQJ8tBiRAeXkQWBygQk0HoKF4gIu9zSGSySly3QKRVKqEIOHwR0E8USTEQGH8JTIQmQmlu93xxzSV20hwZwmirBqi2QvHEiGJZJ8iiwhFar0ETCYuAE4OY1HwuhwQjSJS6VGQABpoNEiuCSGKMNApChcGS0BDcdTkHQIYp8bRMETxKL6YIZDQ/DDZIgSDhsIxOt0yEkeVREBQmGQtMYAJJ4gmSqiBWblMiFI2EAQnDNi/HoRJJTUu5GZGI5PLQTHFFU1aheYXhJMqQLZDNQqLyTUlJBMeCe/A0CQxeJpDku8HW1EYMJHSRMQmgmtUmkHTzQShlNZpxDZ8dpei4CNtW2PJbQCgNQKoO3hIvpEst9H5QpV1CuOulGFwhELCVSoGCzAmDSZBXw9BpeF4DNRSVbFqA1TAfG9LBdQXI0GlNDAILIVxsAjGpNF7MdZgoVEVGpH0o2AVdnmKWQ1xFM1+2UA8vGwRQlWwgBrFCe2wch4L9NBwhOM5QwA+JCElLocRwChCghFCXTQk1/EbagULuBdi1RMsMWfbF8PxdJwjJOhQywPU2OgM4RGzeIMmuXEyU0C4BE3DB0wETSXQpJc6AOABBehYUkJz/HBCSqDOUKcH4QgjVRcFYSYIEr0KG8T3zF4gIPUl/Ei6yFXlcEUINFgsEta1wgDAQgxDMMIUjaAApwU4MHINA/E6ftaEUgkUD+TlQOQN5wSYHxcESuMvGeArAniWtGsogAxOypXpAQVGKnx4JdZ4UsVViJVkLpGHtF0JL8UoUIAVVsAAZHgAG1nnMLY9gAXQACngfB8F4ZAuAAeiBkgCMaLQWFYIHKCSfBcEQCAMxIGGg3hxAgd4XwfCB97dgASkowwTEgGASPnDACGIcg8iBFt2E4Hh+EEUQnRuORFBYJs1A0bRdH0CAjFMGAEHQdBsDwIhSAoVRRShjhZlSDAygaFw3HKTnlFUdRNB0PRiZJsxgEwgGgeKJhkCBqHIMoWZLdEziyEkCyre6tgIHpDhLateRomQLR8EB4BYhD4BLGa6Npdp0VVdExFmHk/iPAJWEiUYvcWNQVhlD5RAUpiq83hdAADApCF4HpXHwBx8F92Ri5ZpkzQXUva79gPkAbxJok7btewIRBEIALzokvtpKJKICkVxSTthvEKVc5oAKn3EIsld40TuiRJngDwSkT5vlwXh6FSnMCWLtryAAdRoLCqAbwTS8QEe+l4GKG7ikNJDoifc2m6Axds5NiwA3aeoZsDMgcDyEk/I/AdhblfMgt8TbUAbsKMoY0JpkR+EUEK24sCmnGnUVAxdtIMAgLsJIPhH4+FxCQakKgFxBhQM7PUpd9IlAgD4EgDdiEgU1HJXCKFND1DbrqDeXhn6v3fgQz+aRv6KEKHIMgFBrI53mIwEEWDJqsTXGQMo/DSEkGRLwCAp95QQCehJKSU8UCICENEAAvP2UIH0uDmRIBALo5VT5uGLr3POvY8GoBsZ0AIKFV4oQKhgY6IEHGDxcgcPoG0+AKLlGGVAf8kAAKAVrXIYCZ6QM1A0HsmBSGRGiAEwBZEgKIFkbiapgkKh/VxBWNushNRpi8GsNRRQRDdWBG8ea0RoS8QsnRGUElkzUhHuMRgUSLKah0bCCyLcKjyAAEIECIKA+ZgC8GwEIJs9q2zWmgMCWUjBy9sLw0CAEO8WQID2TAh0/2LIalkHiJTHw+AABqRS57vDODKByW96AlMkB6FQ3zfBsPPlI2G6MG6e0jMYCwVgAq/NlgQwuC4VDEJoAXecdUoIxGzFjRxeczyzE0Jk4wIt5A8jPMGMl9AeDF1JVQG8TKvAOHgOXSu3LrAKNQE46AAKIGzBFeXZAIBa48k0mXCuVca512QAYAA3A3GUxcTaW3Npba2uJOD21cI7NhrsrTu1Rd7N5Hdi7B1DsAA2wsaWME0pTKWNNZaljYArbgARlYVmcHHDWShuY6z5vrQWoBSZKHYJoAA+tMZASbAhGgMQwJNVoq4CyMHGqA0BthEl2NhAAHOseIEZy27AAOz0HLUIeg6wABs2xtitqEK2jAGA61kE7UIOtraACMJbW3lrnK6+N8tk2pvTWQTNFJ6BJvJoYIAA== --> | |
| <!-- internal state end --> | |
| <!-- tips_start --> | |
| --- | |
| Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? | |
| <details> | |
| <summary>❤️ Share</summary> | |
| - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) | |
| - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) | |
| - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) | |
| - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) | |
| </details> | |
| <details> | |
| <summary>🪧 Tips</summary> | |
| ### Chat | |
| There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): | |
| - Review comments: Directly reply to a review comment made by CodeRabbit. Example: | |
| - `I pushed a fix in commit <commit_id>, please review it.` | |
| - `Generate unit testing code for this file.` | |
| - `Open a follow-up GitHub issue for this discussion.` | |
| - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: | |
| - `@coderabbitai generate unit testing code for this file.` | |
| - `@coderabbitai modularize this function.` | |
| - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: | |
| - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` | |
| - `@coderabbitai read src/utils.ts and generate unit testing code.` | |
| - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` | |
| - `@coderabbitai help me debug CodeRabbit configuration file.` | |
| Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. | |
| ### CodeRabbit Commands (Invoked using PR comments) | |
| - `@coderabbitai pause` to pause the reviews on a PR. | |
| - `@coderabbitai resume` to resume the paused reviews. | |
| - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. | |
| - `@coderabbitai full review` to do a full review from scratch and review all the files again. | |
| - `@coderabbitai summary` to regenerate the summary of the PR. | |
| - `@coderabbitai resolve` resolve all the CodeRabbit review comments. | |
| - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. | |
| - `@coderabbitai help` to get help. | |
| ### Other keywords and placeholders | |
| - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. | |
| - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. | |
| - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. | |
| ### Documentation and Community | |
| - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. | |
| - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. | |
| - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements. | |
| </details> | |
| <!-- tips_end -->\n | |
| Files Changed: | |
| - apps/docs/components/marketing/custom-themes/styles.ts (modified, 2 changes)\n Patch: @@ -87,7 +87,7 @@ export const shopCartStyles = tv({ | |
| "lg:scale-[1.3]", | |
| "before:rounded-3xl", | |
| "before:from-[#870172] before:to-[#18000E]", | |
| - "shadow-lg", | |
| + "shadow-lg rounded-3xl", | |
| ], | |
| img: "sm:scale-90 sm:left-0", | |
| title: "text-2xl",\n |