General feedback
#3
by
sgbaird
- opened
Is use of global necessary? (I remember this was a nuanced, especially in the context of moving from streamlit to gradio). EDIT: I'm seeing the if ... is None structure throughout, which mostly addresses my underlying concern about reuse. However, it looks like https://huggingface.co/spaces/AccelerationConsortium/OT-2-LCM/blob/main/app.py defines the client at the beginning, but also uses some global variables elsewhere. EDIT: https://www.gradio.app/guides/state-in-blocks (related: https://github.com/AccelerationConsortium/ac-training-lab/issues/77#issuecomment-2452121658)
Considerurl=None as default instead of N/A. Likewise for status/etc., consider using "offline" instead of N/A.