Split (1)

train · 534M rows

type stringclasses 14 values	public bool 1 class	payload stringlengths 2 428k	repo dict	actor dict	org dict	created_at timestamp[us]	id stringlengths 10 11	other stringlengths 31 69
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/Privatix/dapp-gui/pulls/comments/253766555","pull_request_review_id":199951950,"id":253766555,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1Mzc2NjU1NQ==","diff_hunk":"@@ -0,0 +1,340 @@\n+import * as React from 'react';\n+import i18n from 'i18next/init';\n+\n+import CopyToClipboard from 'common/copyToClipboard';\n+\n+import ModalPropTextSorter from 'common/sorters/sortingModalByPropText';\n+import DateSorter from 'common/sorters/sortingDate';\n+\n+import ContractStatusComponent from 'common/badges/contractStatus';\n+import ChannelStatus from 'common/badges/channelStatus';\n+import JobName from 'common/badges/jobName';\n+import JobStatusComponent from 'common/badges/jobStatus';\n+import UsageComponent from 'common/badges/channelUsage';\n+import OfferingStatusComponent from 'common/badges/offeringStatus';\n+import AvailabilityComponent from 'common/badges/availability';\n+import PgTime from 'common/etc/pgTime';\n+import LogsTime from 'common/etc/logsTime';\n+\n+export const Client = {\n+ header: i18n.t('tables:Client'),\n+ key: 'client',\n+ dataProps: { className: 'shortTableTextTd' },\n+ render: (client) => {\n+ const clientText = '0x' + client;\n+ return <div>\n+ <span className='shortTableText' title={clientText}>{clientText}</span>\n+ <CopyToClipboard text={clientText} />\n+ </div>;\n+ }\n+};\n+\n+export const ClientIP = {\n+ header: i18n.t('tables:ClientIP'),\n+ key: 'clientIP',\n+ sortable: false\n+};\n+\n+export const Agent = {\n+ header: i18n.t('tables:Agent'),\n+ key: 'agent',\n+ headerStyle: {textAlign: 'center'},\n+ dataProps: {className: 'text-center shortTableTextTd'},\n+ render: (agent) => {\n+ return <div>\n+ <span className='shortTableText' title={agent}>{agent}</span>\n+ <CopyToClipboard text={agent} />\n+ </div>;\n+ }\n+};\n+\n+export const Id = {\n+ header: i18n.t('tables:Id'),\n+ key: 'id',\n+ dataProps: { className: 'shortTableTextTd' },\n+ descSortFunction: ModalPropTextSorter.desc,\n+ ascSortFunction: ModalPropTextSorter.asc\n+};\n+export const CopyableId = {\n+ header: i18n.t('tables:Id'),\n+ key: 'id',\n+ sortable: false,\n+ dataProps: { className: 'shortTableTextTd' },\n+ render: id => (\n+ <div>\n+ <span className='shortTableText' title={id}>{id}</span>\n+ <CopyToClipboard text={id} />\n+ </div>\n+ )\n+};\n+\n+export const Offering = {\n+ header: i18n.t('tables:Offering'),\n+ key: 'offering',\n+ dataProps: { className: 'shortTableTextTd' },\n+ descSortFunction: ModalPropTextSorter.desc,\n+ ascSortFunction: ModalPropTextSorter.asc\n+};\n+\n+export const OfferingStatus = {\n+ header: i18n.t('tables:Status'),\n+ key: 'offerStatus',\n+ headerStyle: {textAlign: 'center'},\n+ dataProps: {className: 'text-center'},\n+ render: (offerStatus) => { return <OfferingStatusComponent status={offerStatus} />; }\n+};\n+\n+export const ContractStatus = {\n+ header: i18n.t('tables:ContractStatus'),\n+ key: 'contractStatus',\n+ headerStyle: {textAlign: 'center'},\n+ dataProps: {className: 'text-center'},\n+ render: status => <ContractStatusComponent contractStatus={status}/>\n+};\n+\n+export const ServiceStatus = {\n+ header: i18n.t('tables:ServiceStatus'),\n+ key: 'serviceStatus',\n+ headerStyle: {textAlign: 'center'},\n+ dataProps: {className: 'text-center'},\n+ render: status => <ChannelStatus serviceStatus={status}/>\n+};\n+\n+export const JobStatus = {\n+ header: i18n.t('tables:JobStatus'),\n+ key: 'jobStatus',\n+ sortable: false,\n+ render: (job) => {\n+ const jobTimeRaw = new Date(Date.parse(job.createdAt));\n+ const jobTime = jobTimeRaw.getHours() + ':' + (jobTimeRaw.getMinutes() < 10 ? '0' : '') + jobTimeRaw.getMinutes();\n+ return <div className='noWrap'><JobName jobtype={job.type} /><br /> (<JobStatusComponent status={job.status} /> {jobTime})</div>;\n+ }\n+};\n+\n+export const PlainUsage = {\n+ header: i18n.t('tables:Usage'),\n+ key: 'usage',\n+ headerStyle: {textAlign: 'center'},\n+ dataProps: { className: 'text-center'},\n+ sortable: false\n+};\n+\n+export const Usage = {\n+ header: i18n.t('tables:Usage'),\n+ key: 'usage',\n+ headerStyle: {textAlign: 'center'},\n+ dataProps: { className: 'text-center'},\n+ render: (usage) => { return <UsageComponent usage={usage} mode='unit' />; }\n+};\n+\n+export const CostPRIX = {\n+ header: i18n.t('tables:CostPRIX'),\n+ key: 'costPRIX',\n+ render: usage => <UsageComponent usage={usage} mode='prix' />\n+};\n+\n+export const IncomePRIX = {\n+ header: i18n.t('tables:IncomePRIX'),\n+ key: 'costPRIX',\n+ headerStyle: {textAlign: 'center'},\n+ dataProps: { className: 'text-center'},\n+ render: usage => <UsageComponent usage={usage} mode='prix' />\n+};\n+\n+export const Availability = {\n+ header: i18n.t('tables:Availability'),\n+ key: 'availability',\n+ headerStyle: {textAlign: 'center'},\n+ dataProps: {className: 'text-center'},\n+ render: availability => <AvailabilityComponent availability={availability} />\n+};\n+\n+export const Hash = {\n+ header: i18n.t('tables:Hash'),\n+ key: 'hash',\n+ headerStyle: {textAlign: 'center'},\n+ dataProps: { className: 'text-center shortTableTextTd'},\n+ descSortFunction: ModalPropTextSorter.desc,\n+ ascSortFunction: ModalPropTextSorter.asc\n+};\n+\n+export const Block = {\n+ header: i18n.t('tables:Block'),\n+ key: 'block'\n+};\n+\n+export const Country = {\n+ header: i18n.t('tables:Country'),\n+ key: 'country'\n+};\n+\n+export const Price = {\n+ header: i18n.t('tables:Price'),\n+ key: 'price'\n+};\n+\n+export const AvailableSupply = {\n+ header: i18n.t('tables:AvailableSupply'),\n+ key: 'availableSupply',\n+ headerStyle: {textAlign: 'center'},\n+ dataProps: { className: 'text-center'}\n+};\n+\n+export const Supply = {\n+ header: i18n.t('tables:Supply'),\n+ key: 'supply',\n+ headerStyle: {textAlign: 'center'},\n+ dataProps: { className: 'text-center'}\n+};\n+\n+export const ServiceName = {\n+ header: i18n.t('tables:ServiceName'),\n+ key: 'serviceName'\n+};\n+\n+export const Server = {\n+ header: i18n.t('tables:Server'),\n+ key: 'server',\n+ descSortFunction: ModalPropTextSorter.desc,\n+ ascSortFunction: ModalPropTextSorter.asc\n+};\n+\n+export const ServiceLastChanged = {","path":"src/common/tables/index.tsx","position":202,"original_position":202,"commit_id":"abc27edf3faf24ceced50a5458280a1387c31c63","original_commit_id":"abc27edf3faf24ceced50a5458280a1387c31c63","user":{"login":"codeclimate[bot]","id":36754821,"node_id":"MDM6Qm90MzY3NTQ4MjE=","avatar_url":"https://avatars0.githubusercontent.com/in/9403?v=4","gravatar_id":"","url":"https://api.github.com/users/codeclimate%5Bbot%5D","html_url":"https://github.com/apps/codeclimate","followers_url":"https://api.github.com/users/codeclimate%5Bbot%5D/followers","following_url":"https://api.github.com/users/codeclimate%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codeclimate%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codeclimate%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeclimate%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codeclimate%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codeclimate%5Bbot%5D/repos","events_url":"https://api.github.com/users/codeclimate%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codeclimate%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Similar blocks of code found in 2 locations. Consider refactoring.","created_at":"2019-02-05T08:20:47Z","updated_at":"2019-02-05T08:20:47Z","html_url":"https://github.com/Privatix/dapp-gui/pull/299#discussion_r253766555","pull_request_url":"https://api.github.com/repos/Privatix/dapp-gui/pulls/299","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Privatix/dapp-gui/pulls/comments/253766555"},"html":{"href":"https://github.com/Privatix/dapp-gui/pull/299#discussion_r253766555"},"pull_request":{"href":"https://api.github.com/repos/Privatix/dapp-gui/pulls/299"}}},"pull_request":{"url":"https://api.github.com/repos/Privatix/dapp-gui/pulls/299","id":250315413,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUwMzE1NDEz","html_url":"https://github.com/Privatix/dapp-gui/pull/299","diff_url":"https://github.com/Privatix/dapp-gui/pull/299.diff","patch_url":"https://github.com/Privatix/dapp-gui/pull/299.patch","issue_url":"https://api.github.com/repos/Privatix/dapp-gui/issues/299","number":299,"state":"open","locked":false,"title":"tables","user":{"login":"gonzazoid","id":12472060,"node_id":"MDQ6VXNlcjEyNDcyMDYw","avatar_url":"https://avatars1.githubusercontent.com/u/12472060?v=4","gravatar_id":"","url":"https://api.github.com/users/gonzazoid","html_url":"https://github.com/gonzazoid","followers_url":"https://api.github.com/users/gonzazoid/followers","following_url":"https://api.github.com/users/gonzazoid/following{/other_user}","gists_url":"https://api.github.com/users/gonzazoid/gists{/gist_id}","starred_url":"https://api.github.com/users/gonzazoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonzazoid/subscriptions","organizations_url":"https://api.github.com/users/gonzazoid/orgs","repos_url":"https://api.github.com/users/gonzazoid/repos","events_url":"https://api.github.com/users/gonzazoid/events{/privacy}","received_events_url":"https://api.github.com/users/gonzazoid/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-05T08:19:28Z","updated_at":"2019-02-05T08:20:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5e708d7514afd0cf8a1a307c759994f27d2cd5c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Vitold55","id":10572065,"node_id":"MDQ6VXNlcjEwNTcyMDY1","avatar_url":"https://avatars2.githubusercontent.com/u/10572065?v=4","gravatar_id":"","url":"https://api.github.com/users/Vitold55","html_url":"https://github.com/Vitold55","followers_url":"https://api.github.com/users/Vitold55/followers","following_url":"https://api.github.com/users/Vitold55/following{/other_user}","gists_url":"https://api.github.com/users/Vitold55/gists{/gist_id}","starred_url":"https://api.github.com/users/Vitold55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vitold55/subscriptions","organizations_url":"https://api.github.com/users/Vitold55/orgs","repos_url":"https://api.github.com/users/Vitold55/repos","events_url":"https://api.github.com/users/Vitold55/events{/privacy}","received_events_url":"https://api.github.com/users/Vitold55/received_events","type":"User","site_admin":false},{"login":"drew2a","id":13798583,"node_id":"MDQ6VXNlcjEzNzk4NTgz","avatar_url":"https://avatars3.githubusercontent.com/u/13798583?v=4","gravatar_id":"","url":"https://api.github.com/users/drew2a","html_url":"https://github.com/drew2a","followers_url":"https://api.github.com/users/drew2a/followers","following_url":"https://api.github.com/users/drew2a/following{/other_user}","gists_url":"https://api.github.com/users/drew2a/gists{/gist_id}","starred_url":"https://api.github.com/users/drew2a/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drew2a/subscriptions","organizations_url":"https://api.github.com/users/drew2a/orgs","repos_url":"https://api.github.com/users/drew2a/repos","events_url":"https://api.github.com/users/drew2a/events{/privacy}","received_events_url":"https://api.github.com/users/drew2a/received_events","type":"User","site_admin":false},{"login":"sofabeat","id":35256511,"node_id":"MDQ6VXNlcjM1MjU2NTEx","avatar_url":"https://avatars1.githubusercontent.com/u/35256511?v=4","gravatar_id":"","url":"https://api.github.com/users/sofabeat","html_url":"https://github.com/sofabeat","followers_url":"https://api.github.com/users/sofabeat/followers","following_url":"https://api.github.com/users/sofabeat/following{/other_user}","gists_url":"https://api.github.com/users/sofabeat/gists{/gist_id}","starred_url":"https://api.github.com/users/sofabeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sofabeat/subscriptions","organizations_url":"https://api.github.com/users/sofabeat/orgs","repos_url":"https://api.github.com/users/sofabeat/repos","events_url":"https://api.github.com/users/sofabeat/events{/privacy}","received_events_url":"https://api.github.com/users/sofabeat/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Privatix/dapp-gui/pulls/299/commits","review_comments_url":"https://api.github.com/repos/Privatix/dapp-gui/pulls/299/comments","review_comment_url":"https://api.github.com/repos/Privatix/dapp-gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Privatix/dapp-gui/issues/299/comments","statuses_url":"https://api.github.com/repos/Privatix/dapp-gui/statuses/abc27edf3faf24ceced50a5458280a1387c31c63","head":{"label":"Privatix:feature/ta-tables","ref":"feature/ta-tables","sha":"abc27edf3faf24ceced50a5458280a1387c31c63","user":{"login":"Privatix","id":30593351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNTkzMzUx","avatar_url":"https://avatars2.githubusercontent.com/u/30593351?v=4","gravatar_id":"","url":"https://api.github.com/users/Privatix","html_url":"https://github.com/Privatix","followers_url":"https://api.github.com/users/Privatix/followers","following_url":"https://api.github.com/users/Privatix/following{/other_user}","gists_url":"https://api.github.com/users/Privatix/gists{/gist_id}","starred_url":"https://api.github.com/users/Privatix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Privatix/subscriptions","organizations_url":"https://api.github.com/users/Privatix/orgs","repos_url":"https://api.github.com/users/Privatix/repos","events_url":"https://api.github.com/users/Privatix/events{/privacy}","received_events_url":"https://api.github.com/users/Privatix/received_events","type":"Organization","site_admin":false},"repo":{"id":122081212,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIwODEyMTI=","name":"dapp-gui","full_name":"Privatix/dapp-gui","private":false,"owner":{"login":"Privatix","id":30593351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNTkzMzUx","avatar_url":"https://avatars2.githubusercontent.com/u/30593351?v=4","gravatar_id":"","url":"https://api.github.com/users/Privatix","html_url":"https://github.com/Privatix","followers_url":"https://api.github.com/users/Privatix/followers","following_url":"https://api.github.com/users/Privatix/following{/other_user}","gists_url":"https://api.github.com/users/Privatix/gists{/gist_id}","starred_url":"https://api.github.com/users/Privatix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Privatix/subscriptions","organizations_url":"https://api.github.com/users/Privatix/orgs","repos_url":"https://api.github.com/users/Privatix/repos","events_url":"https://api.github.com/users/Privatix/events{/privacy}","received_events_url":"https://api.github.com/users/Privatix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Privatix/dapp-gui","description":"Front-end graphical user interface for Privatix core Dapp","fork":false,"url":"https://api.github.com/repos/Privatix/dapp-gui","forks_url":"https://api.github.com/repos/Privatix/dapp-gui/forks","keys_url":"https://api.github.com/repos/Privatix/dapp-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Privatix/dapp-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Privatix/dapp-gui/teams","hooks_url":"https://api.github.com/repos/Privatix/dapp-gui/hooks","issue_events_url":"https://api.github.com/repos/Privatix/dapp-gui/issues/events{/number}","events_url":"https://api.github.com/repos/Privatix/dapp-gui/events","assignees_url":"https://api.github.com/repos/Privatix/dapp-gui/assignees{/user}","branches_url":"https://api.github.com/repos/Privatix/dapp-gui/branches{/branch}","tags_url":"https://api.github.com/repos/Privatix/dapp-gui/tags","blobs_url":"https://api.github.com/repos/Privatix/dapp-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Privatix/dapp-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Privatix/dapp-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Privatix/dapp-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Privatix/dapp-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/Privatix/dapp-gui/languages","stargazers_url":"https://api.github.com/repos/Privatix/dapp-gui/stargazers","contributors_url":"https://api.github.com/repos/Privatix/dapp-gui/contributors","subscribers_url":"https://api.github.com/repos/Privatix/dapp-gui/subscribers","subscription_url":"https://api.github.com/repos/Privatix/dapp-gui/subscription","commits_url":"https://api.github.com/repos/Privatix/dapp-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Privatix/dapp-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Privatix/dapp-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Privatix/dapp-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Privatix/dapp-gui/contents/{+path}","compare_url":"https://api.github.com/repos/Privatix/dapp-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Privatix/dapp-gui/merges","archive_url":"https://api.github.com/repos/Privatix/dapp-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Privatix/dapp-gui/downloads","issues_url":"https://api.github.com/repos/Privatix/dapp-gui/issues{/number}","pulls_url":"https://api.github.com/repos/Privatix/dapp-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/Privatix/dapp-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/Privatix/dapp-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Privatix/dapp-gui/labels{/name}","releases_url":"https://api.github.com/repos/Privatix/dapp-gui/releases{/id}","deployments_url":"https://api.github.com/repos/Privatix/dapp-gui/deployments","created_at":"2018-02-19T15:23:48Z","updated_at":"2019-01-22T08:43:57Z","pushed_at":"2019-02-05T08:19:29Z","git_url":"git://github.com/Privatix/dapp-gui.git","ssh_url":"[email protected]:Privatix/dapp-gui.git","clone_url":"https://github.com/Privatix/dapp-gui.git","svn_url":"https://github.com/Privatix/dapp-gui","homepage":"","size":4522,"stargazers_count":7,"watchers_count":7,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":4,"open_issues":1,"watchers":7,"default_branch":"master"}},"base":{"label":"Privatix:develop","ref":"develop","sha":"5ab04baaa277dea465a2db0c513f3f7ffdd17526","user":{"login":"Privatix","id":30593351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNTkzMzUx","avatar_url":"https://avatars2.githubusercontent.com/u/30593351?v=4","gravatar_id":"","url":"https://api.github.com/users/Privatix","html_url":"https://github.com/Privatix","followers_url":"https://api.github.com/users/Privatix/followers","following_url":"https://api.github.com/users/Privatix/following{/other_user}","gists_url":"https://api.github.com/users/Privatix/gists{/gist_id}","starred_url":"https://api.github.com/users/Privatix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Privatix/subscriptions","organizations_url":"https://api.github.com/users/Privatix/orgs","repos_url":"https://api.github.com/users/Privatix/repos","events_url":"https://api.github.com/users/Privatix/events{/privacy}","received_events_url":"https://api.github.com/users/Privatix/received_events","type":"Organization","site_admin":false},"repo":{"id":122081212,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIwODEyMTI=","name":"dapp-gui","full_name":"Privatix/dapp-gui","private":false,"owner":{"login":"Privatix","id":30593351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNTkzMzUx","avatar_url":"https://avatars2.githubusercontent.com/u/30593351?v=4","gravatar_id":"","url":"https://api.github.com/users/Privatix","html_url":"https://github.com/Privatix","followers_url":"https://api.github.com/users/Privatix/followers","following_url":"https://api.github.com/users/Privatix/following{/other_user}","gists_url":"https://api.github.com/users/Privatix/gists{/gist_id}","starred_url":"https://api.github.com/users/Privatix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Privatix/subscriptions","organizations_url":"https://api.github.com/users/Privatix/orgs","repos_url":"https://api.github.com/users/Privatix/repos","events_url":"https://api.github.com/users/Privatix/events{/privacy}","received_events_url":"https://api.github.com/users/Privatix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Privatix/dapp-gui","description":"Front-end graphical user interface for Privatix core Dapp","fork":false,"url":"https://api.github.com/repos/Privatix/dapp-gui","forks_url":"https://api.github.com/repos/Privatix/dapp-gui/forks","keys_url":"https://api.github.com/repos/Privatix/dapp-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Privatix/dapp-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Privatix/dapp-gui/teams","hooks_url":"https://api.github.com/repos/Privatix/dapp-gui/hooks","issue_events_url":"https://api.github.com/repos/Privatix/dapp-gui/issues/events{/number}","events_url":"https://api.github.com/repos/Privatix/dapp-gui/events","assignees_url":"https://api.github.com/repos/Privatix/dapp-gui/assignees{/user}","branches_url":"https://api.github.com/repos/Privatix/dapp-gui/branches{/branch}","tags_url":"https://api.github.com/repos/Privatix/dapp-gui/tags","blobs_url":"https://api.github.com/repos/Privatix/dapp-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Privatix/dapp-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Privatix/dapp-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Privatix/dapp-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Privatix/dapp-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/Privatix/dapp-gui/languages","stargazers_url":"https://api.github.com/repos/Privatix/dapp-gui/stargazers","contributors_url":"https://api.github.com/repos/Privatix/dapp-gui/contributors","subscribers_url":"https://api.github.com/repos/Privatix/dapp-gui/subscribers","subscription_url":"https://api.github.com/repos/Privatix/dapp-gui/subscription","commits_url":"https://api.github.com/repos/Privatix/dapp-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Privatix/dapp-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Privatix/dapp-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Privatix/dapp-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Privatix/dapp-gui/contents/{+path}","compare_url":"https://api.github.com/repos/Privatix/dapp-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Privatix/dapp-gui/merges","archive_url":"https://api.github.com/repos/Privatix/dapp-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Privatix/dapp-gui/downloads","issues_url":"https://api.github.com/repos/Privatix/dapp-gui/issues{/number}","pulls_url":"https://api.github.com/repos/Privatix/dapp-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/Privatix/dapp-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/Privatix/dapp-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Privatix/dapp-gui/labels{/name}","releases_url":"https://api.github.com/repos/Privatix/dapp-gui/releases{/id}","deployments_url":"https://api.github.com/repos/Privatix/dapp-gui/deployments","created_at":"2018-02-19T15:23:48Z","updated_at":"2019-01-22T08:43:57Z","pushed_at":"2019-02-05T08:19:29Z","git_url":"git://github.com/Privatix/dapp-gui.git","ssh_url":"[email protected]:Privatix/dapp-gui.git","clone_url":"https://github.com/Privatix/dapp-gui.git","svn_url":"https://github.com/Privatix/dapp-gui","homepage":"","size":4522,"stargazers_count":7,"watchers_count":7,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":4,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Privatix/dapp-gui/pulls/299"},"html":{"href":"https://github.com/Privatix/dapp-gui/pull/299"},"issue":{"href":"https://api.github.com/repos/Privatix/dapp-gui/issues/299"},"comments":{"href":"https://api.github.com/repos/Privatix/dapp-gui/issues/299/comments"},"review_comments":{"href":"https://api.github.com/repos/Privatix/dapp-gui/pulls/299/comments"},"review_comment":{"href":"https://api.github.com/repos/Privatix/dapp-gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Privatix/dapp-gui/pulls/299/commits"},"statuses":{"href":"https://api.github.com/repos/Privatix/dapp-gui/statuses/abc27edf3faf24ceced50a5458280a1387c31c63"}},"author_association":"CONTRIBUTOR"}}	{ "id": 122081212, "name": "Privatix/dapp-gui", "url": "https://api.github.com/repos/Privatix/dapp-gui" }	{ "id": 36754821, "login": "codeclimate[bot]", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/36754821?", "url": "https://api.github.com/users/codeclimate[bot]" }	{ "id": 30593351, "login": "Privatix", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/30593351?", "url": "https://api.github.com/orgs/Privatix" }	2019-02-05T08:20:47	9009232982	{"actor":{"display_login":"codeclimate"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/Qiskit/qiskit-aer/pulls/comments/291722450","pull_request_review_id":247265258,"id":291722450,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MTcyMjQ1MA==","diff_hunk":"@@ -212,24 +216,65 @@ def approximate_noise_model(model, *,\n approx_noise_model._basis_gates = model._basis_gates\n return approx_noise_model\n \n+def pauli_operators():\n+ pauli_1_qubit = {\n+ 'X': [{'name': 'x', 'qubits': [0]}],\n+ 'Y': [{'name': 'y', 'qubits': [0]}],\n+ 'Z': [{'name': 'z', 'qubits': [0]}]\n+ }\n+ pauli_2_qubit = {\n+ 'XI': [{'name': 'x', 'qubits': [0]}, {'name': 'id', 'qubits': [1]}],","path":"qiskit/providers/aer/noise/utils/noise_transformation.py","position":35,"original_position":35,"commit_id":"afd60458b034d28be7b870c62befc523f411b6ca","original_commit_id":"afd60458b034d28be7b870c62befc523f411b6ca","user":{"login":"chriseclectic","id":2235104,"node_id":"MDQ6VXNlcjIyMzUxMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2235104?v=4","gravatar_id":"","url":"https://api.github.com/users/chriseclectic","html_url":"https://github.com/chriseclectic","followers_url":"https://api.github.com/users/chriseclectic/followers","following_url":"https://api.github.com/users/chriseclectic/following{/other_user}","gists_url":"https://api.github.com/users/chriseclectic/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseclectic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseclectic/subscriptions","organizations_url":"https://api.github.com/users/chriseclectic/orgs","repos_url":"https://api.github.com/users/chriseclectic/repos","events_url":"https://api.github.com/users/chriseclectic/events{/privacy}","received_events_url":"https://api.github.com/users/chriseclectic/received_events","type":"User","site_admin":false},"body":"Qubit 0 and 1 need to be swapped here. The convention used in other functions is eg:\r\n\r\n```\r\npauli_error([('XY', 1.0)]) --> QuantumError([([{'name': 'y', 'qubits': [0]}, {'name': 'x', 'qubits': [1]}], 1.0)])\r\n```","created_at":"2019-06-07T19:17:52Z","updated_at":"2019-06-07T19:17:52Z","html_url":"https://github.com/Qiskit/qiskit-aer/pull/223#discussion_r291722450","pull_request_url":"https://api.github.com/repos/Qiskit/qiskit-aer/pulls/223","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Qiskit/qiskit-aer/pulls/comments/291722450"},"html":{"href":"https://github.com/Qiskit/qiskit-aer/pull/223#discussion_r291722450"},"pull_request":{"href":"https://api.github.com/repos/Qiskit/qiskit-aer/pulls/223"}}},"pull_request":{"url":"https://api.github.com/repos/Qiskit/qiskit-aer/pulls/223","id":284981480,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0OTgxNDgw","html_url":"https://github.com/Qiskit/qiskit-aer/pull/223","diff_url":"https://github.com/Qiskit/qiskit-aer/pull/223.diff","patch_url":"https://github.com/Qiskit/qiskit-aer/pull/223.patch","issue_url":"https://api.github.com/repos/Qiskit/qiskit-aer/issues/223","number":223,"state":"open","locked":false,"title":"Noise transformation 2qubit","user":{"login":"gadial","id":11400,"node_id":"MDQ6VXNlcjExNDAw","avatar_url":"https://avatars0.githubusercontent.com/u/11400?v=4","gravatar_id":"","url":"https://api.github.com/users/gadial","html_url":"https://github.com/gadial","followers_url":"https://api.github.com/users/gadial/followers","following_url":"https://api.github.com/users/gadial/following{/other_user}","gists_url":"https://api.github.com/users/gadial/gists{/gist_id}","starred_url":"https://api.github.com/users/gadial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gadial/subscriptions","organizations_url":"https://api.github.com/users/gadial/orgs","repos_url":"https://api.github.com/users/gadial/repos","events_url":"https://api.github.com/users/gadial/events{/privacy}","received_events_url":"https://api.github.com/users/gadial/received_events","type":"User","site_admin":false},"body":"<!--\r\n⚠️ If you do not respect this template, your pull request will be closed.\r\n⚠️ Your pull request title should be short detailed and understandable for all.\r\n⚠️ Also, please add it in the CHANGELOG file under Unreleased section.\r\n⚠️ If your pull request fixes an open issue, please link to the issue.\r\n\r\n✅ I have added the tests to cover my changes.\r\n✅ I have updated the documentation accordingly.\r\n✅ I have read the CONTRIBUTING document.\r\n-->\r\n\r\n### Summary\r\nExtending the noise transformation module to support approximations of 2-qubit noises.\r\n\r\n\r\n### Details and comments\r\nThe module now throws exception only for 3-qubit or more errors; additionaly, support for premade 2-qubit Pauli and reset operators was added.\r\n\r\n","created_at":"2019-06-04T13:45:45Z","updated_at":"2019-06-07T19:17:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13fe0956e2e1d4267aeebc6f342b006c315126c0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"atilag","id":1304071,"node_id":"MDQ6VXNlcjEzMDQwNzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1304071?v=4","gravatar_id":"","url":"https://api.github.com/users/atilag","html_url":"https://github.com/atilag","followers_url":"https://api.github.com/users/atilag/followers","following_url":"https://api.github.com/users/atilag/following{/other_user}","gists_url":"https://api.github.com/users/atilag/gists{/gist_id}","starred_url":"https://api.github.com/users/atilag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atilag/subscriptions","organizations_url":"https://api.github.com/users/atilag/orgs","repos_url":"https://api.github.com/users/atilag/repos","events_url":"https://api.github.com/users/atilag/events{/privacy}","received_events_url":"https://api.github.com/users/atilag/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Qiskit/qiskit-aer/pulls/223/commits","review_comments_url":"https://api.github.com/repos/Qiskit/qiskit-aer/pulls/223/comments","review_comment_url":"https://api.github.com/repos/Qiskit/qiskit-aer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Qiskit/qiskit-aer/issues/223/comments","statuses_url":"https://api.github.com/repos/Qiskit/qiskit-aer/statuses/afd60458b034d28be7b870c62befc523f411b6ca","head":{"label":"gadial:noise_transformation_2qubit","ref":"noise_transformation_2qubit","sha":"afd60458b034d28be7b870c62befc523f411b6ca","user":{"login":"gadial","id":11400,"node_id":"MDQ6VXNlcjExNDAw","avatar_url":"https://avatars0.githubusercontent.com/u/11400?v=4","gravatar_id":"","url":"https://api.github.com/users/gadial","html_url":"https://github.com/gadial","followers_url":"https://api.github.com/users/gadial/followers","following_url":"https://api.github.com/users/gadial/following{/other_user}","gists_url":"https://api.github.com/users/gadial/gists{/gist_id}","starred_url":"https://api.github.com/users/gadial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gadial/subscriptions","organizations_url":"https://api.github.com/users/gadial/orgs","repos_url":"https://api.github.com/users/gadial/repos","events_url":"https://api.github.com/users/gadial/events{/privacy}","received_events_url":"https://api.github.com/users/gadial/received_events","type":"User","site_admin":false},"repo":{"id":163736595,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM3MzY1OTU=","name":"qiskit-aer","full_name":"gadial/qiskit-aer","private":false,"owner":{"login":"gadial","id":11400,"node_id":"MDQ6VXNlcjExNDAw","avatar_url":"https://avatars0.githubusercontent.com/u/11400?v=4","gravatar_id":"","url":"https://api.github.com/users/gadial","html_url":"https://github.com/gadial","followers_url":"https://api.github.com/users/gadial/followers","following_url":"https://api.github.com/users/gadial/following{/other_user}","gists_url":"https://api.github.com/users/gadial/gists{/gist_id}","starred_url":"https://api.github.com/users/gadial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gadial/subscriptions","organizations_url":"https://api.github.com/users/gadial/orgs","repos_url":"https://api.github.com/users/gadial/repos","events_url":"https://api.github.com/users/gadial/events{/privacy}","received_events_url":"https://api.github.com/users/gadial/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gadial/qiskit-aer","description":"Aer is a high performance simulator provider for quantum circuits","fork":true,"url":"https://api.github.com/repos/gadial/qiskit-aer","forks_url":"https://api.github.com/repos/gadial/qiskit-aer/forks","keys_url":"https://api.github.com/repos/gadial/qiskit-aer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gadial/qiskit-aer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gadial/qiskit-aer/teams","hooks_url":"https://api.github.com/repos/gadial/qiskit-aer/hooks","issue_events_url":"https://api.github.com/repos/gadial/qiskit-aer/issues/events{/number}","events_url":"https://api.github.com/repos/gadial/qiskit-aer/events","assignees_url":"https://api.github.com/repos/gadial/qiskit-aer/assignees{/user}","branches_url":"https://api.github.com/repos/gadial/qiskit-aer/branches{/branch}","tags_url":"https://api.github.com/repos/gadial/qiskit-aer/tags","blobs_url":"https://api.github.com/repos/gadial/qiskit-aer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gadial/qiskit-aer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gadial/qiskit-aer/git/refs{/sha}","trees_url":"https://api.github.com/repos/gadial/qiskit-aer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gadial/qiskit-aer/statuses/{sha}","languages_url":"https://api.github.com/repos/gadial/qiskit-aer/languages","stargazers_url":"https://api.github.com/repos/gadial/qiskit-aer/stargazers","contributors_url":"https://api.github.com/repos/gadial/qiskit-aer/contributors","subscribers_url":"https://api.github.com/repos/gadial/qiskit-aer/subscribers","subscription_url":"https://api.github.com/repos/gadial/qiskit-aer/subscription","commits_url":"https://api.github.com/repos/gadial/qiskit-aer/commits{/sha}","git_commits_url":"https://api.github.com/repos/gadial/qiskit-aer/git/commits{/sha}","comments_url":"https://api.github.com/repos/gadial/qiskit-aer/comments{/number}","issue_comment_url":"https://api.github.com/repos/gadial/qiskit-aer/issues/comments{/number}","contents_url":"https://api.github.com/repos/gadial/qiskit-aer/contents/{+path}","compare_url":"https://api.github.com/repos/gadial/qiskit-aer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gadial/qiskit-aer/merges","archive_url":"https://api.github.com/repos/gadial/qiskit-aer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gadial/qiskit-aer/downloads","issues_url":"https://api.github.com/repos/gadial/qiskit-aer/issues{/number}","pulls_url":"https://api.github.com/repos/gadial/qiskit-aer/pulls{/number}","milestones_url":"https://api.github.com/repos/gadial/qiskit-aer/milestones{/number}","notifications_url":"https://api.github.com/repos/gadial/qiskit-aer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gadial/qiskit-aer/labels{/name}","releases_url":"https://api.github.com/repos/gadial/qiskit-aer/releases{/id}","deployments_url":"https://api.github.com/repos/gadial/qiskit-aer/deployments","created_at":"2019-01-01T12:54:41Z","updated_at":"2019-05-30T12:24:32Z","pushed_at":"2019-06-04T13:44:12Z","git_url":"git://github.com/gadial/qiskit-aer.git","ssh_url":"[email protected]:gadial/qiskit-aer.git","clone_url":"https://github.com/gadial/qiskit-aer.git","svn_url":"https://github.com/gadial/qiskit-aer","homepage":"https://qiskit.org/aer","size":7634,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Qiskit:master","ref":"master","sha":"d964795b0a24b1d3287ba2ba2dda45d1dfed4a5d","user":{"login":"Qiskit","id":30696987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjk2OTg3","avatar_url":"https://avatars1.githubusercontent.com/u/30696987?v=4","gravatar_id":"","url":"https://api.github.com/users/Qiskit","html_url":"https://github.com/Qiskit","followers_url":"https://api.github.com/users/Qiskit/followers","following_url":"https://api.github.com/users/Qiskit/following{/other_user}","gists_url":"https://api.github.com/users/Qiskit/gists{/gist_id}","starred_url":"https://api.github.com/users/Qiskit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qiskit/subscriptions","organizations_url":"https://api.github.com/users/Qiskit/orgs","repos_url":"https://api.github.com/users/Qiskit/repos","events_url":"https://api.github.com/users/Qiskit/events{/privacy}","received_events_url":"https://api.github.com/users/Qiskit/received_events","type":"Organization","site_admin":false},"repo":{"id":162182953,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIxODI5NTM=","name":"qiskit-aer","full_name":"Qiskit/qiskit-aer","private":false,"owner":{"login":"Qiskit","id":30696987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjk2OTg3","avatar_url":"https://avatars1.githubusercontent.com/u/30696987?v=4","gravatar_id":"","url":"https://api.github.com/users/Qiskit","html_url":"https://github.com/Qiskit","followers_url":"https://api.github.com/users/Qiskit/followers","following_url":"https://api.github.com/users/Qiskit/following{/other_user}","gists_url":"https://api.github.com/users/Qiskit/gists{/gist_id}","starred_url":"https://api.github.com/users/Qiskit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qiskit/subscriptions","organizations_url":"https://api.github.com/users/Qiskit/orgs","repos_url":"https://api.github.com/users/Qiskit/repos","events_url":"https://api.github.com/users/Qiskit/events{/privacy}","received_events_url":"https://api.github.com/users/Qiskit/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Qiskit/qiskit-aer","description":"Aer is a high performance simulator for quantum circuits that includes noise models","fork":false,"url":"https://api.github.com/repos/Qiskit/qiskit-aer","forks_url":"https://api.github.com/repos/Qiskit/qiskit-aer/forks","keys_url":"https://api.github.com/repos/Qiskit/qiskit-aer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Qiskit/qiskit-aer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Qiskit/qiskit-aer/teams","hooks_url":"https://api.github.com/repos/Qiskit/qiskit-aer/hooks","issue_events_url":"https://api.github.com/repos/Qiskit/qiskit-aer/issues/events{/number}","events_url":"https://api.github.com/repos/Qiskit/qiskit-aer/events","assignees_url":"https://api.github.com/repos/Qiskit/qiskit-aer/assignees{/user}","branches_url":"https://api.github.com/repos/Qiskit/qiskit-aer/branches{/branch}","tags_url":"https://api.github.com/repos/Qiskit/qiskit-aer/tags","blobs_url":"https://api.github.com/repos/Qiskit/qiskit-aer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Qiskit/qiskit-aer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Qiskit/qiskit-aer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Qiskit/qiskit-aer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Qiskit/qiskit-aer/statuses/{sha}","languages_url":"https://api.github.com/repos/Qiskit/qiskit-aer/languages","stargazers_url":"https://api.github.com/repos/Qiskit/qiskit-aer/stargazers","contributors_url":"https://api.github.com/repos/Qiskit/qiskit-aer/contributors","subscribers_url":"https://api.github.com/repos/Qiskit/qiskit-aer/subscribers","subscription_url":"https://api.github.com/repos/Qiskit/qiskit-aer/subscription","commits_url":"https://api.github.com/repos/Qiskit/qiskit-aer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Qiskit/qiskit-aer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Qiskit/qiskit-aer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Qiskit/qiskit-aer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Qiskit/qiskit-aer/contents/{+path}","compare_url":"https://api.github.com/repos/Qiskit/qiskit-aer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Qiskit/qiskit-aer/merges","archive_url":"https://api.github.com/repos/Qiskit/qiskit-aer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Qiskit/qiskit-aer/downloads","issues_url":"https://api.github.com/repos/Qiskit/qiskit-aer/issues{/number}","pulls_url":"https://api.github.com/repos/Qiskit/qiskit-aer/pulls{/number}","milestones_url":"https://api.github.com/repos/Qiskit/qiskit-aer/milestones{/number}","notifications_url":"https://api.github.com/repos/Qiskit/qiskit-aer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Qiskit/qiskit-aer/labels{/name}","releases_url":"https://api.github.com/repos/Qiskit/qiskit-aer/releases{/id}","deployments_url":"https://api.github.com/repos/Qiskit/qiskit-aer/deployments","created_at":"2018-12-17T19:58:16Z","updated_at":"2019-06-07T18:59:04Z","pushed_at":"2019-06-07T19:08:33Z","git_url":"git://github.com/Qiskit/qiskit-aer.git","ssh_url":"[email protected]:Qiskit/qiskit-aer.git","clone_url":"https://github.com/Qiskit/qiskit-aer.git","svn_url":"https://github.com/Qiskit/qiskit-aer","homepage":"https://qiskit.org/aer","size":7587,"stargazers_count":67,"watchers_count":67,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":74,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":74,"open_issues":31,"watchers":67,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Qiskit/qiskit-aer/pulls/223"},"html":{"href":"https://github.com/Qiskit/qiskit-aer/pull/223"},"issue":{"href":"https://api.github.com/repos/Qiskit/qiskit-aer/issues/223"},"comments":{"href":"https://api.github.com/repos/Qiskit/qiskit-aer/issues/223/comments"},"review_comments":{"href":"https://api.github.com/repos/Qiskit/qiskit-aer/pulls/223/comments"},"review_comment":{"href":"https://api.github.com/repos/Qiskit/qiskit-aer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Qiskit/qiskit-aer/pulls/223/commits"},"statuses":{"href":"https://api.github.com/repos/Qiskit/qiskit-aer/statuses/afd60458b034d28be7b870c62befc523f411b6ca"}},"author_association":"CONTRIBUTOR"}}	{ "id": 162182953, "name": "Qiskit/qiskit-aer", "url": "https://api.github.com/repos/Qiskit/qiskit-aer" }	{ "id": 2235104, "login": "chriseclectic", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/2235104?", "url": "https://api.github.com/users/chriseclectic" }	{ "id": 30696987, "login": "Qiskit", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/30696987?", "url": "https://api.github.com/orgs/Qiskit" }	2019-06-07T19:17:52	9781280124	{"actor":{"display_login":"chriseclectic"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/ladjs/lad.sh/pulls/comments/358428990","pull_request_review_id":332819241,"id":358428990,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1ODQyODk5MA==","diff_hunk":"@@ -48,6 +48,43 @@ const User = new mongoose.Schema({\n lowercase: true,\n unique: true,\n validate: val => validator.isEmail(val)\n+ },\n+ full_email: {","path":"app/models/user.js","position":5,"original_position":5,"commit_id":"074bfd787961c5439ea40668798d6d0731c61517","original_commit_id":"2ae0504691549475b878f0b8891e3987f4665fed","user":{"login":"niftylettuce","id":523141,"node_id":"MDQ6VXNlcjUyMzE0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/523141?v=4","gravatar_id":"","url":"https://api.github.com/users/niftylettuce","html_url":"https://github.com/niftylettuce","followers_url":"https://api.github.com/users/niftylettuce/followers","following_url":"https://api.github.com/users/niftylettuce/following{/other_user}","gists_url":"https://api.github.com/users/niftylettuce/gists{/gist_id}","starred_url":"https://api.github.com/users/niftylettuce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niftylettuce/subscriptions","organizations_url":"https://api.github.com/users/niftylettuce/orgs","repos_url":"https://api.github.com/users/niftylettuce/repos","events_url":"https://api.github.com/users/niftylettuce/events{/privacy}","received_events_url":"https://api.github.com/users/niftylettuce/received_events","type":"User","site_admin":false},"body":"This was added by accident, remove `full_email` object declaration here.","created_at":"2019-12-16T19:44:29Z","updated_at":"2019-12-16T19:46:23Z","html_url":"https://github.com/ladjs/lad.sh/pull/3#discussion_r358428990","pull_request_url":"https://api.github.com/repos/ladjs/lad.sh/pulls/3","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ladjs/lad.sh/pulls/comments/358428990"},"html":{"href":"https://github.com/ladjs/lad.sh/pull/3#discussion_r358428990"},"pull_request":{"href":"https://api.github.com/repos/ladjs/lad.sh/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/ladjs/lad.sh/pulls/3","id":353727442,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzNzI3NDQy","html_url":"https://github.com/ladjs/lad.sh/pull/3","diff_url":"https://github.com/ladjs/lad.sh/pull/3.diff","patch_url":"https://github.com/ladjs/lad.sh/pull/3.patch","issue_url":"https://api.github.com/repos/ladjs/lad.sh/issues/3","number":3,"state":"open","locked":false,"title":"Initial 2FA OTP setup","user":{"login":"shaunwarman","id":1986128,"node_id":"MDQ6VXNlcjE5ODYxMjg=","avatar_url":"https://avatars0.githubusercontent.com/u/1986128?v=4","gravatar_id":"","url":"https://api.github.com/users/shaunwarman","html_url":"https://github.com/shaunwarman","followers_url":"https://api.github.com/users/shaunwarman/followers","following_url":"https://api.github.com/users/shaunwarman/following{/other_user}","gists_url":"https://api.github.com/users/shaunwarman/gists{/gist_id}","starred_url":"https://api.github.com/users/shaunwarman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaunwarman/subscriptions","organizations_url":"https://api.github.com/users/shaunwarman/orgs","repos_url":"https://api.github.com/users/shaunwarman/repos","events_url":"https://api.github.com/users/shaunwarman/events{/privacy}","received_events_url":"https://api.github.com/users/shaunwarman/received_events","type":"User","site_admin":false},"body":"Dirty version of initial OTP introduction. Things to think about:\r\n- Pulling out policy into `@ladjs/policies`\r\n- Pulling out passport items in `@ladjs/passport`\r\n- Recovery keys and fallback options (phone, email, etc)\r\n- Optimizations around QR codes, etc","created_at":"2019-12-16T19:39:21Z","updated_at":"2019-12-16T19:46:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed536033641499428f3d676d2447716758af4344","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ladjs/lad.sh/pulls/3/commits","review_comments_url":"https://api.github.com/repos/ladjs/lad.sh/pulls/3/comments","review_comment_url":"https://api.github.com/repos/ladjs/lad.sh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ladjs/lad.sh/issues/3/comments","statuses_url":"https://api.github.com/repos/ladjs/lad.sh/statuses/074bfd787961c5439ea40668798d6d0731c61517","head":{"label":"shaunwarman:2fa-otp-rb","ref":"2fa-otp-rb","sha":"074bfd787961c5439ea40668798d6d0731c61517","user":{"login":"shaunwarman","id":1986128,"node_id":"MDQ6VXNlcjE5ODYxMjg=","avatar_url":"https://avatars0.githubusercontent.com/u/1986128?v=4","gravatar_id":"","url":"https://api.github.com/users/shaunwarman","html_url":"https://github.com/shaunwarman","followers_url":"https://api.github.com/users/shaunwarman/followers","following_url":"https://api.github.com/users/shaunwarman/following{/other_user}","gists_url":"https://api.github.com/users/shaunwarman/gists{/gist_id}","starred_url":"https://api.github.com/users/shaunwarman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaunwarman/subscriptions","organizations_url":"https://api.github.com/users/shaunwarman/orgs","repos_url":"https://api.github.com/users/shaunwarman/repos","events_url":"https://api.github.com/users/shaunwarman/events{/privacy}","received_events_url":"https://api.github.com/users/shaunwarman/received_events","type":"User","site_admin":false},"repo":{"id":227404935,"node_id":"MDEwOlJlcG9zaXRvcnkyMjc0MDQ5MzU=","name":"lad.sh","full_name":"shaunwarman/lad.sh","private":false,"owner":{"login":"shaunwarman","id":1986128,"node_id":"MDQ6VXNlcjE5ODYxMjg=","avatar_url":"https://avatars0.githubusercontent.com/u/1986128?v=4","gravatar_id":"","url":"https://api.github.com/users/shaunwarman","html_url":"https://github.com/shaunwarman","followers_url":"https://api.github.com/users/shaunwarman/followers","following_url":"https://api.github.com/users/shaunwarman/following{/other_user}","gists_url":"https://api.github.com/users/shaunwarman/gists{/gist_id}","starred_url":"https://api.github.com/users/shaunwarman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaunwarman/subscriptions","organizations_url":"https://api.github.com/users/shaunwarman/orgs","repos_url":"https://api.github.com/users/shaunwarman/repos","events_url":"https://api.github.com/users/shaunwarman/events{/privacy}","received_events_url":"https://api.github.com/users/shaunwarman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shaunwarman/lad.sh","description":"Demo for Lad - The Best Node.js Framework","fork":true,"url":"https://api.github.com/repos/shaunwarman/lad.sh","forks_url":"https://api.github.com/repos/shaunwarman/lad.sh/forks","keys_url":"https://api.github.com/repos/shaunwarman/lad.sh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shaunwarman/lad.sh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shaunwarman/lad.sh/teams","hooks_url":"https://api.github.com/repos/shaunwarman/lad.sh/hooks","issue_events_url":"https://api.github.com/repos/shaunwarman/lad.sh/issues/events{/number}","events_url":"https://api.github.com/repos/shaunwarman/lad.sh/events","assignees_url":"https://api.github.com/repos/shaunwarman/lad.sh/assignees{/user}","branches_url":"https://api.github.com/repos/shaunwarman/lad.sh/branches{/branch}","tags_url":"https://api.github.com/repos/shaunwarman/lad.sh/tags","blobs_url":"https://api.github.com/repos/shaunwarman/lad.sh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shaunwarman/lad.sh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shaunwarman/lad.sh/git/refs{/sha}","trees_url":"https://api.github.com/repos/shaunwarman/lad.sh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shaunwarman/lad.sh/statuses/{sha}","languages_url":"https://api.github.com/repos/shaunwarman/lad.sh/languages","stargazers_url":"https://api.github.com/repos/shaunwarman/lad.sh/stargazers","contributors_url":"https://api.github.com/repos/shaunwarman/lad.sh/contributors","subscribers_url":"https://api.github.com/repos/shaunwarman/lad.sh/subscribers","subscription_url":"https://api.github.com/repos/shaunwarman/lad.sh/subscription","commits_url":"https://api.github.com/repos/shaunwarman/lad.sh/commits{/sha}","git_commits_url":"https://api.github.com/repos/shaunwarman/lad.sh/git/commits{/sha}","comments_url":"https://api.github.com/repos/shaunwarman/lad.sh/comments{/number}","issue_comment_url":"https://api.github.com/repos/shaunwarman/lad.sh/issues/comments{/number}","contents_url":"https://api.github.com/repos/shaunwarman/lad.sh/contents/{+path}","compare_url":"https://api.github.com/repos/shaunwarman/lad.sh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shaunwarman/lad.sh/merges","archive_url":"https://api.github.com/repos/shaunwarman/lad.sh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shaunwarman/lad.sh/downloads","issues_url":"https://api.github.com/repos/shaunwarman/lad.sh/issues{/number}","pulls_url":"https://api.github.com/repos/shaunwarman/lad.sh/pulls{/number}","milestones_url":"https://api.github.com/repos/shaunwarman/lad.sh/milestones{/number}","notifications_url":"https://api.github.com/repos/shaunwarman/lad.sh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shaunwarman/lad.sh/labels{/name}","releases_url":"https://api.github.com/repos/shaunwarman/lad.sh/releases{/id}","deployments_url":"https://api.github.com/repos/shaunwarman/lad.sh/deployments","created_at":"2019-12-11T15:59:14Z","updated_at":"2019-12-11T15:59:15Z","pushed_at":"2019-12-16T19:45:51Z","git_url":"git://github.com/shaunwarman/lad.sh.git","ssh_url":"[email protected]:shaunwarman/lad.sh.git","clone_url":"https://github.com/shaunwarman/lad.sh.git","svn_url":"https://github.com/shaunwarman/lad.sh","homepage":"https://lad.sh","size":4727,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ladjs:master","ref":"master","sha":"ebdf8ceac668e2ef4b1febf87ccc9115699d8dd9","user":{"login":"ladjs","id":30959108,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwOTU5MTA4","avatar_url":"https://avatars3.githubusercontent.com/u/30959108?v=4","gravatar_id":"","url":"https://api.github.com/users/ladjs","html_url":"https://github.com/ladjs","followers_url":"https://api.github.com/users/ladjs/followers","following_url":"https://api.github.com/users/ladjs/following{/other_user}","gists_url":"https://api.github.com/users/ladjs/gists{/gist_id}","starred_url":"https://api.github.com/users/ladjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ladjs/subscriptions","organizations_url":"https://api.github.com/users/ladjs/orgs","repos_url":"https://api.github.com/users/ladjs/repos","events_url":"https://api.github.com/users/ladjs/events{/privacy}","received_events_url":"https://api.github.com/users/ladjs/received_events","type":"Organization","site_admin":false},"repo":{"id":212038123,"node_id":"MDEwOlJlcG9zaXRvcnkyMTIwMzgxMjM=","name":"lad.sh","full_name":"ladjs/lad.sh","private":false,"owner":{"login":"ladjs","id":30959108,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwOTU5MTA4","avatar_url":"https://avatars3.githubusercontent.com/u/30959108?v=4","gravatar_id":"","url":"https://api.github.com/users/ladjs","html_url":"https://github.com/ladjs","followers_url":"https://api.github.com/users/ladjs/followers","following_url":"https://api.github.com/users/ladjs/following{/other_user}","gists_url":"https://api.github.com/users/ladjs/gists{/gist_id}","starred_url":"https://api.github.com/users/ladjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ladjs/subscriptions","organizations_url":"https://api.github.com/users/ladjs/orgs","repos_url":"https://api.github.com/users/ladjs/repos","events_url":"https://api.github.com/users/ladjs/events{/privacy}","received_events_url":"https://api.github.com/users/ladjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ladjs/lad.sh","description":"Demo for Lad - The Best Node.js Framework","fork":false,"url":"https://api.github.com/repos/ladjs/lad.sh","forks_url":"https://api.github.com/repos/ladjs/lad.sh/forks","keys_url":"https://api.github.com/repos/ladjs/lad.sh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ladjs/lad.sh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ladjs/lad.sh/teams","hooks_url":"https://api.github.com/repos/ladjs/lad.sh/hooks","issue_events_url":"https://api.github.com/repos/ladjs/lad.sh/issues/events{/number}","events_url":"https://api.github.com/repos/ladjs/lad.sh/events","assignees_url":"https://api.github.com/repos/ladjs/lad.sh/assignees{/user}","branches_url":"https://api.github.com/repos/ladjs/lad.sh/branches{/branch}","tags_url":"https://api.github.com/repos/ladjs/lad.sh/tags","blobs_url":"https://api.github.com/repos/ladjs/lad.sh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ladjs/lad.sh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ladjs/lad.sh/git/refs{/sha}","trees_url":"https://api.github.com/repos/ladjs/lad.sh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ladjs/lad.sh/statuses/{sha}","languages_url":"https://api.github.com/repos/ladjs/lad.sh/languages","stargazers_url":"https://api.github.com/repos/ladjs/lad.sh/stargazers","contributors_url":"https://api.github.com/repos/ladjs/lad.sh/contributors","subscribers_url":"https://api.github.com/repos/ladjs/lad.sh/subscribers","subscription_url":"https://api.github.com/repos/ladjs/lad.sh/subscription","commits_url":"https://api.github.com/repos/ladjs/lad.sh/commits{/sha}","git_commits_url":"https://api.github.com/repos/ladjs/lad.sh/git/commits{/sha}","comments_url":"https://api.github.com/repos/ladjs/lad.sh/comments{/number}","issue_comment_url":"https://api.github.com/repos/ladjs/lad.sh/issues/comments{/number}","contents_url":"https://api.github.com/repos/ladjs/lad.sh/contents/{+path}","compare_url":"https://api.github.com/repos/ladjs/lad.sh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ladjs/lad.sh/merges","archive_url":"https://api.github.com/repos/ladjs/lad.sh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ladjs/lad.sh/downloads","issues_url":"https://api.github.com/repos/ladjs/lad.sh/issues{/number}","pulls_url":"https://api.github.com/repos/ladjs/lad.sh/pulls{/number}","milestones_url":"https://api.github.com/repos/ladjs/lad.sh/milestones{/number}","notifications_url":"https://api.github.com/repos/ladjs/lad.sh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ladjs/lad.sh/labels{/name}","releases_url":"https://api.github.com/repos/ladjs/lad.sh/releases{/id}","deployments_url":"https://api.github.com/repos/ladjs/lad.sh/deployments","created_at":"2019-10-01T07:36:24Z","updated_at":"2019-12-16T05:16:03Z","pushed_at":"2019-12-16T19:45:52Z","git_url":"git://github.com/ladjs/lad.sh.git","ssh_url":"[email protected]:ladjs/lad.sh.git","clone_url":"https://github.com/ladjs/lad.sh.git","svn_url":"https://github.com/ladjs/lad.sh","homepage":"https://lad.sh","size":4422,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ladjs/lad.sh/pulls/3"},"html":{"href":"https://github.com/ladjs/lad.sh/pull/3"},"issue":{"href":"https://api.github.com/repos/ladjs/lad.sh/issues/3"},"comments":{"href":"https://api.github.com/repos/ladjs/lad.sh/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/ladjs/lad.sh/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/ladjs/lad.sh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ladjs/lad.sh/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/ladjs/lad.sh/statuses/074bfd787961c5439ea40668798d6d0731c61517"}},"author_association":"MEMBER"}}	{ "id": 212038123, "name": "ladjs/lad.sh", "url": "https://api.github.com/repos/ladjs/lad.sh" }	{ "id": 523141, "login": "niftylettuce", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/523141?", "url": "https://api.github.com/users/niftylettuce" }	{ "id": 30959108, "login": "ladjs", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/30959108?", "url": "https://api.github.com/orgs/ladjs" }	2019-12-16T19:44:29	11100693953	{"actor":{"display_login":"niftylettuce"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/pulls/comments/322374724","pull_request_review_id":285679914,"id":322374724,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMjM3NDcyNA==","diff_hunk":"@@ -1,26 +1,15 @@\n -- Change the values below if you are not installing via Docker (environment variable values come from .env file)\n \n -- name of the database\n-\\set db_name 'hederamirror'\n+\\set db_name 'mirror_node'\n --username\n-\\set db_user 'hederamirror'\n+\\set db_user 'mirror_node'\n --user password\n-\\set db_password 'mysecretpassword'\n---owner of the database (usually postgres)\n-\\set db_owner 'postgres'\n+\\set db_password 'mirror_node_pass'\n+\\set db_owner 'mirror_node'\n \n-CREATE DATABASE :db_name\n- WITH\n- OWNER = :db_owner\n- CONNECTION LIMIT = -1;\n+create user :db_user with login createrole password :'db_password';","path":"src/main/resources/postgres/postgresInit.sql","position":20,"original_position":20,"commit_id":"6fba513547bfe861d501a1bcc6b55573cedc1a2f","original_commit_id":"6fba513547bfe861d501a1bcc6b55573cedc1a2f","user":{"login":"mike-burrage-hedera","id":50885871,"node_id":"MDQ6VXNlcjUwODg1ODcx","avatar_url":"https://avatars3.githubusercontent.com/u/50885871?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-burrage-hedera","html_url":"https://github.com/mike-burrage-hedera","followers_url":"https://api.github.com/users/mike-burrage-hedera/followers","following_url":"https://api.github.com/users/mike-burrage-hedera/following{/other_user}","gists_url":"https://api.github.com/users/mike-burrage-hedera/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-burrage-hedera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-burrage-hedera/subscriptions","organizations_url":"https://api.github.com/users/mike-burrage-hedera/orgs","repos_url":"https://api.github.com/users/mike-burrage-hedera/repos","events_url":"https://api.github.com/users/mike-burrage-hedera/events{/privacy}","received_events_url":"https://api.github.com/users/mike-burrage-hedera/received_events","type":"User","site_admin":false},"body":"Yes - the old syntax was incorrect and 1 reason why the script didn't work.","created_at":"2019-09-09T17:55:16Z","updated_at":"2019-09-09T17:55:16Z","html_url":"https://github.com/hashgraph/hedera-mirror-node/pull/224#discussion_r322374724","pull_request_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/pulls/224","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hashgraph/hedera-mirror-node/pulls/comments/322374724"},"html":{"href":"https://github.com/hashgraph/hedera-mirror-node/pull/224#discussion_r322374724"},"pull_request":{"href":"https://api.github.com/repos/hashgraph/hedera-mirror-node/pulls/224"}},"in_reply_to_id":322362525},"pull_request":{"url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/pulls/224","id":315575823,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE1NTc1ODIz","html_url":"https://github.com/hashgraph/hedera-mirror-node/pull/224","diff_url":"https://github.com/hashgraph/hedera-mirror-node/pull/224.diff","patch_url":"https://github.com/hashgraph/hedera-mirror-node/pull/224.patch","issue_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/issues/224","number":224,"state":"open","locked":false,"title":"Remove references to db postgres and db user postgres","user":{"login":"mike-burrage-hedera","id":50885871,"node_id":"MDQ6VXNlcjUwODg1ODcx","avatar_url":"https://avatars3.githubusercontent.com/u/50885871?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-burrage-hedera","html_url":"https://github.com/mike-burrage-hedera","followers_url":"https://api.github.com/users/mike-burrage-hedera/followers","following_url":"https://api.github.com/users/mike-burrage-hedera/following{/other_user}","gists_url":"https://api.github.com/users/mike-burrage-hedera/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-burrage-hedera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-burrage-hedera/subscriptions","organizations_url":"https://api.github.com/users/mike-burrage-hedera/orgs","repos_url":"https://api.github.com/users/mike-burrage-hedera/repos","events_url":"https://api.github.com/users/mike-burrage-hedera/events{/privacy}","received_events_url":"https://api.github.com/users/mike-burrage-hedera/received_events","type":"User","site_admin":false},"body":"Detailed description:\r\n\r\n- Remove all references to database name and user `postgres`\r\n- Pick standard name for db and users and update README, env.sample, config.json.sample\r\n- Fix postgresInit.sql so that it properly creates (a non-`postgres`) database and user. Previously, it would incorrectly set the password. That user specified is the DB owner.\r\n\r\nWhich issue(s) this PR fixes:\r\nFixes #223 \r\n\r\nChecklist\r\n- [X] Documentation added\r\n- [ ] Tests updated","created_at":"2019-09-09T14:59:58Z","updated_at":"2019-09-09T17:55:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89b33b582da441a6d1b962470e87a3f5c7acc9da","assignee":{"login":"calvinchengx","id":95563,"node_id":"MDQ6VXNlcjk1NTYz","avatar_url":"https://avatars3.githubusercontent.com/u/95563?v=4","gravatar_id":"","url":"https://api.github.com/users/calvinchengx","html_url":"https://github.com/calvinchengx","followers_url":"https://api.github.com/users/calvinchengx/followers","following_url":"https://api.github.com/users/calvinchengx/following{/other_user}","gists_url":"https://api.github.com/users/calvinchengx/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinchengx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinchengx/subscriptions","organizations_url":"https://api.github.com/users/calvinchengx/orgs","repos_url":"https://api.github.com/users/calvinchengx/repos","events_url":"https://api.github.com/users/calvinchengx/events{/privacy}","received_events_url":"https://api.github.com/users/calvinchengx/received_events","type":"User","site_admin":false},"assignees":[{"login":"calvinchengx","id":95563,"node_id":"MDQ6VXNlcjk1NTYz","avatar_url":"https://avatars3.githubusercontent.com/u/95563?v=4","gravatar_id":"","url":"https://api.github.com/users/calvinchengx","html_url":"https://github.com/calvinchengx","followers_url":"https://api.github.com/users/calvinchengx/followers","following_url":"https://api.github.com/users/calvinchengx/following{/other_user}","gists_url":"https://api.github.com/users/calvinchengx/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinchengx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinchengx/subscriptions","organizations_url":"https://api.github.com/users/calvinchengx/orgs","repos_url":"https://api.github.com/users/calvinchengx/repos","events_url":"https://api.github.com/users/calvinchengx/events{/privacy}","received_events_url":"https://api.github.com/users/calvinchengx/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"calvinchengx","id":95563,"node_id":"MDQ6VXNlcjk1NTYz","avatar_url":"https://avatars3.githubusercontent.com/u/95563?v=4","gravatar_id":"","url":"https://api.github.com/users/calvinchengx","html_url":"https://github.com/calvinchengx","followers_url":"https://api.github.com/users/calvinchengx/followers","following_url":"https://api.github.com/users/calvinchengx/following{/other_user}","gists_url":"https://api.github.com/users/calvinchengx/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinchengx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinchengx/subscriptions","organizations_url":"https://api.github.com/users/calvinchengx/orgs","repos_url":"https://api.github.com/users/calvinchengx/repos","events_url":"https://api.github.com/users/calvinchengx/events{/privacy}","received_events_url":"https://api.github.com/users/calvinchengx/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/milestones/2","html_url":"https://github.com/hashgraph/hedera-mirror-node/milestone/2","labels_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/milestones/2/labels","id":4607727,"node_id":"MDk6TWlsZXN0b25lNDYwNzcyNw==","number":2,"title":"0.2.0","description":"OA.\r\nCritical features, performance and bug fixes for OA.\r\nCode freeze Wed 2019-09-11@5pm CT.\r\nFull end-to-end testing with critical fixes only after that point.\r\nInstall Sat 2019-09-14@9am CT.\r\n","creator":{"login":"steven-sheehy","id":17552371,"node_id":"MDQ6VXNlcjE3NTUyMzcx","avatar_url":"https://avatars3.githubusercontent.com/u/17552371?v=4","gravatar_id":"","url":"https://api.github.com/users/steven-sheehy","html_url":"https://github.com/steven-sheehy","followers_url":"https://api.github.com/users/steven-sheehy/followers","following_url":"https://api.github.com/users/steven-sheehy/following{/other_user}","gists_url":"https://api.github.com/users/steven-sheehy/gists{/gist_id}","starred_url":"https://api.github.com/users/steven-sheehy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steven-sheehy/subscriptions","organizations_url":"https://api.github.com/users/steven-sheehy/orgs","repos_url":"https://api.github.com/users/steven-sheehy/repos","events_url":"https://api.github.com/users/steven-sheehy/events{/privacy}","received_events_url":"https://api.github.com/users/steven-sheehy/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":27,"state":"open","created_at":"2019-08-27T17:57:31Z","updated_at":"2019-09-09T16:50:31Z","due_on":"2019-09-14T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/pulls/224/commits","review_comments_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/pulls/224/comments","review_comment_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/issues/224/comments","statuses_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/statuses/6fba513547bfe861d501a1bcc6b55573cedc1a2f","head":{"label":"hashgraph:223-postgres","ref":"223-postgres","sha":"6fba513547bfe861d501a1bcc6b55573cedc1a2f","user":{"login":"hashgraph","id":31002956,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMDAyOTU2","avatar_url":"https://avatars1.githubusercontent.com/u/31002956?v=4","gravatar_id":"","url":"https://api.github.com/users/hashgraph","html_url":"https://github.com/hashgraph","followers_url":"https://api.github.com/users/hashgraph/followers","following_url":"https://api.github.com/users/hashgraph/following{/other_user}","gists_url":"https://api.github.com/users/hashgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/hashgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashgraph/subscriptions","organizations_url":"https://api.github.com/users/hashgraph/orgs","repos_url":"https://api.github.com/users/hashgraph/repos","events_url":"https://api.github.com/users/hashgraph/events{/privacy}","received_events_url":"https://api.github.com/users/hashgraph/received_events","type":"Organization","site_admin":false},"repo":{"id":197364349,"node_id":"MDEwOlJlcG9zaXRvcnkxOTczNjQzNDk=","name":"hedera-mirror-node","full_name":"hashgraph/hedera-mirror-node","private":false,"owner":{"login":"hashgraph","id":31002956,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMDAyOTU2","avatar_url":"https://avatars1.githubusercontent.com/u/31002956?v=4","gravatar_id":"","url":"https://api.github.com/users/hashgraph","html_url":"https://github.com/hashgraph","followers_url":"https://api.github.com/users/hashgraph/followers","following_url":"https://api.github.com/users/hashgraph/following{/other_user}","gists_url":"https://api.github.com/users/hashgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/hashgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashgraph/subscriptions","organizations_url":"https://api.github.com/users/hashgraph/orgs","repos_url":"https://api.github.com/users/hashgraph/repos","events_url":"https://api.github.com/users/hashgraph/events{/privacy}","received_events_url":"https://api.github.com/users/hashgraph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hashgraph/hedera-mirror-node","description":"Hedera Mirror Node mirrors data from Hedera nodes and serves it via an API","fork":false,"url":"https://api.github.com/repos/hashgraph/hedera-mirror-node","forks_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/forks","keys_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/teams","hooks_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/hooks","issue_events_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/issues/events{/number}","events_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/events","assignees_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/assignees{/user}","branches_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/branches{/branch}","tags_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/tags","blobs_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/statuses/{sha}","languages_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/languages","stargazers_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/stargazers","contributors_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/contributors","subscribers_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/subscribers","subscription_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/subscription","commits_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/contents/{+path}","compare_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/merges","archive_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/downloads","issues_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/issues{/number}","pulls_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/pulls{/number}","milestones_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/milestones{/number}","notifications_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/labels{/name}","releases_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/releases{/id}","deployments_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/deployments","created_at":"2019-07-17T10:04:38Z","updated_at":"2019-09-09T16:03:37Z","pushed_at":"2019-09-09T16:50:31Z","git_url":"git://github.com/hashgraph/hedera-mirror-node.git","ssh_url":"[email protected]:hashgraph/hedera-mirror-node.git","clone_url":"https://github.com/hashgraph/hedera-mirror-node.git","svn_url":"https://github.com/hashgraph/hedera-mirror-node","homepage":"","size":19726,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":58,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":58,"watchers":6,"default_branch":"master"}},"base":{"label":"hashgraph:master","ref":"master","sha":"49094d564c4fa4e736e784cc934dfb1fd31abd68","user":{"login":"hashgraph","id":31002956,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMDAyOTU2","avatar_url":"https://avatars1.githubusercontent.com/u/31002956?v=4","gravatar_id":"","url":"https://api.github.com/users/hashgraph","html_url":"https://github.com/hashgraph","followers_url":"https://api.github.com/users/hashgraph/followers","following_url":"https://api.github.com/users/hashgraph/following{/other_user}","gists_url":"https://api.github.com/users/hashgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/hashgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashgraph/subscriptions","organizations_url":"https://api.github.com/users/hashgraph/orgs","repos_url":"https://api.github.com/users/hashgraph/repos","events_url":"https://api.github.com/users/hashgraph/events{/privacy}","received_events_url":"https://api.github.com/users/hashgraph/received_events","type":"Organization","site_admin":false},"repo":{"id":197364349,"node_id":"MDEwOlJlcG9zaXRvcnkxOTczNjQzNDk=","name":"hedera-mirror-node","full_name":"hashgraph/hedera-mirror-node","private":false,"owner":{"login":"hashgraph","id":31002956,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMDAyOTU2","avatar_url":"https://avatars1.githubusercontent.com/u/31002956?v=4","gravatar_id":"","url":"https://api.github.com/users/hashgraph","html_url":"https://github.com/hashgraph","followers_url":"https://api.github.com/users/hashgraph/followers","following_url":"https://api.github.com/users/hashgraph/following{/other_user}","gists_url":"https://api.github.com/users/hashgraph/gists{/gist_id}","starred_url":"https://api.github.com/users/hashgraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashgraph/subscriptions","organizations_url":"https://api.github.com/users/hashgraph/orgs","repos_url":"https://api.github.com/users/hashgraph/repos","events_url":"https://api.github.com/users/hashgraph/events{/privacy}","received_events_url":"https://api.github.com/users/hashgraph/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hashgraph/hedera-mirror-node","description":"Hedera Mirror Node mirrors data from Hedera nodes and serves it via an API","fork":false,"url":"https://api.github.com/repos/hashgraph/hedera-mirror-node","forks_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/forks","keys_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/teams","hooks_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/hooks","issue_events_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/issues/events{/number}","events_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/events","assignees_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/assignees{/user}","branches_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/branches{/branch}","tags_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/tags","blobs_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/statuses/{sha}","languages_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/languages","stargazers_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/stargazers","contributors_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/contributors","subscribers_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/subscribers","subscription_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/subscription","commits_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/contents/{+path}","compare_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/merges","archive_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/downloads","issues_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/issues{/number}","pulls_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/pulls{/number}","milestones_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/milestones{/number}","notifications_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/labels{/name}","releases_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/releases{/id}","deployments_url":"https://api.github.com/repos/hashgraph/hedera-mirror-node/deployments","created_at":"2019-07-17T10:04:38Z","updated_at":"2019-09-09T16:03:37Z","pushed_at":"2019-09-09T16:50:31Z","git_url":"git://github.com/hashgraph/hedera-mirror-node.git","ssh_url":"[email protected]:hashgraph/hedera-mirror-node.git","clone_url":"https://github.com/hashgraph/hedera-mirror-node.git","svn_url":"https://github.com/hashgraph/hedera-mirror-node","homepage":"","size":19726,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":58,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":58,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashgraph/hedera-mirror-node/pulls/224"},"html":{"href":"https://github.com/hashgraph/hedera-mirror-node/pull/224"},"issue":{"href":"https://api.github.com/repos/hashgraph/hedera-mirror-node/issues/224"},"comments":{"href":"https://api.github.com/repos/hashgraph/hedera-mirror-node/issues/224/comments"},"review_comments":{"href":"https://api.github.com/repos/hashgraph/hedera-mirror-node/pulls/224/comments"},"review_comment":{"href":"https://api.github.com/repos/hashgraph/hedera-mirror-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashgraph/hedera-mirror-node/pulls/224/commits"},"statuses":{"href":"https://api.github.com/repos/hashgraph/hedera-mirror-node/statuses/6fba513547bfe861d501a1bcc6b55573cedc1a2f"}},"author_association":"CONTRIBUTOR"}}	{ "id": 197364349, "name": "hashgraph/hedera-mirror-node", "url": "https://api.github.com/repos/hashgraph/hedera-mirror-node" }	{ "id": 50885871, "login": "mike-burrage-hedera", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/50885871?", "url": "https://api.github.com/users/mike-burrage-hedera" }	{ "id": 31002956, "login": "hashgraph", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/31002956?", "url": "https://api.github.com/orgs/hashgraph" }	2019-09-09T17:55:16	10378342185	{"actor":{"display_login":"mike-burrage-hedera"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/dojot/iotagent-mosca/pulls/comments/311030449","pull_request_review_id":271304324,"id":311030449,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMTAzMDQ0OQ==","diff_hunk":"@@ -0,0 +1,408 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>","path":"coverage/clover.xml","position":1,"original_position":1,"commit_id":"1eb51145ced3522092072f2cb16aebe15d95cc1b","original_commit_id":"1eb51145ced3522092072f2cb16aebe15d95cc1b","user":{"login":"mprevide","id":6900446,"node_id":"MDQ6VXNlcjY5MDA0NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/6900446?v=4","gravatar_id":"","url":"https://api.github.com/users/mprevide","html_url":"https://github.com/mprevide","followers_url":"https://api.github.com/users/mprevide/followers","following_url":"https://api.github.com/users/mprevide/following{/other_user}","gists_url":"https://api.github.com/users/mprevide/gists{/gist_id}","starred_url":"https://api.github.com/users/mprevide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprevide/subscriptions","organizations_url":"https://api.github.com/users/mprevide/orgs","repos_url":"https://api.github.com/users/mprevide/repos","events_url":"https://api.github.com/users/mprevide/events{/privacy}","received_events_url":"https://api.github.com/users/mprevide/received_events","type":"User","site_admin":false},"body":"Files within coverage/ really need to be versioned?","created_at":"2019-08-06T12:19:42Z","updated_at":"2019-08-06T12:19:42Z","html_url":"https://github.com/dojot/iotagent-mosca/pull/75#discussion_r311030449","pull_request_url":"https://api.github.com/repos/dojot/iotagent-mosca/pulls/75","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dojot/iotagent-mosca/pulls/comments/311030449"},"html":{"href":"https://github.com/dojot/iotagent-mosca/pull/75#discussion_r311030449"},"pull_request":{"href":"https://api.github.com/repos/dojot/iotagent-mosca/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/dojot/iotagent-mosca/pulls/75","id":304653503,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA0NjUzNTAz","html_url":"https://github.com/dojot/iotagent-mosca/pull/75","diff_url":"https://github.com/dojot/iotagent-mosca/pull/75.diff","patch_url":"https://github.com/dojot/iotagent-mosca/pull/75.patch","issue_url":"https://api.github.com/repos/dojot/iotagent-mosca/issues/75","number":75,"state":"open","locked":false,"title":"Unit tests","user":{"login":"nunesjoab","id":13135441,"node_id":"MDQ6VXNlcjEzMTM1NDQx","avatar_url":"https://avatars0.githubusercontent.com/u/13135441?v=4","gravatar_id":"","url":"https://api.github.com/users/nunesjoab","html_url":"https://github.com/nunesjoab","followers_url":"https://api.github.com/users/nunesjoab/followers","following_url":"https://api.github.com/users/nunesjoab/following{/other_user}","gists_url":"https://api.github.com/users/nunesjoab/gists{/gist_id}","starred_url":"https://api.github.com/users/nunesjoab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunesjoab/subscriptions","organizations_url":"https://api.github.com/users/nunesjoab/orgs","repos_url":"https://api.github.com/users/nunesjoab/repos","events_url":"https://api.github.com/users/nunesjoab/events{/privacy}","received_events_url":"https://api.github.com/users/nunesjoab/received_events","type":"User","site_admin":false},"body":"* Please check if the PR fulfills these requirements\r\n- [X] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n* What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)\r\nThis PR introduces a set of unit tests to iotagent-mosca\r\n\r\n\r\n* What is the current behavior? (You can also link to an open issue here)\r\n\r\n\r\n\r\n* What is the new behavior (if this is a feature change)?\r\n\r\n\r\n\r\n* Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)\r\n\r\n\r\n* Is there any issue related to this PR in other repository? (such as dojot/dojot)\r\ndojot/dojot/1187\r\n\r\n* Other information:\r\n","created_at":"2019-08-06T10:36:00Z","updated_at":"2019-08-06T12:19:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e14680563e684b802352e005cab4f38cc00b5c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dojot/iotagent-mosca/pulls/75/commits","review_comments_url":"https://api.github.com/repos/dojot/iotagent-mosca/pulls/75/comments","review_comment_url":"https://api.github.com/repos/dojot/iotagent-mosca/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dojot/iotagent-mosca/issues/75/comments","statuses_url":"https://api.github.com/repos/dojot/iotagent-mosca/statuses/1eb51145ced3522092072f2cb16aebe15d95cc1b","head":{"label":"nunesjoab:unit-tests","ref":"unit-tests","sha":"1eb51145ced3522092072f2cb16aebe15d95cc1b","user":{"login":"nunesjoab","id":13135441,"node_id":"MDQ6VXNlcjEzMTM1NDQx","avatar_url":"https://avatars0.githubusercontent.com/u/13135441?v=4","gravatar_id":"","url":"https://api.github.com/users/nunesjoab","html_url":"https://github.com/nunesjoab","followers_url":"https://api.github.com/users/nunesjoab/followers","following_url":"https://api.github.com/users/nunesjoab/following{/other_user}","gists_url":"https://api.github.com/users/nunesjoab/gists{/gist_id}","starred_url":"https://api.github.com/users/nunesjoab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunesjoab/subscriptions","organizations_url":"https://api.github.com/users/nunesjoab/orgs","repos_url":"https://api.github.com/users/nunesjoab/repos","events_url":"https://api.github.com/users/nunesjoab/events{/privacy}","received_events_url":"https://api.github.com/users/nunesjoab/received_events","type":"User","site_admin":false},"repo":{"id":196213298,"node_id":"MDEwOlJlcG9zaXRvcnkxOTYyMTMyOTg=","name":"iotagent-mosca","full_name":"nunesjoab/iotagent-mosca","private":false,"owner":{"login":"nunesjoab","id":13135441,"node_id":"MDQ6VXNlcjEzMTM1NDQx","avatar_url":"https://avatars0.githubusercontent.com/u/13135441?v=4","gravatar_id":"","url":"https://api.github.com/users/nunesjoab","html_url":"https://github.com/nunesjoab","followers_url":"https://api.github.com/users/nunesjoab/followers","following_url":"https://api.github.com/users/nunesjoab/following{/other_user}","gists_url":"https://api.github.com/users/nunesjoab/gists{/gist_id}","starred_url":"https://api.github.com/users/nunesjoab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunesjoab/subscriptions","organizations_url":"https://api.github.com/users/nunesjoab/orgs","repos_url":"https://api.github.com/users/nunesjoab/repos","events_url":"https://api.github.com/users/nunesjoab/events{/privacy}","received_events_url":"https://api.github.com/users/nunesjoab/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nunesjoab/iotagent-mosca","description":"Mosca-based iotagent for MQTT/JSON devices","fork":true,"url":"https://api.github.com/repos/nunesjoab/iotagent-mosca","forks_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/forks","keys_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/teams","hooks_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/hooks","issue_events_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/issues/events{/number}","events_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/events","assignees_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/assignees{/user}","branches_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/branches{/branch}","tags_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/tags","blobs_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/git/refs{/sha}","trees_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/statuses/{sha}","languages_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/languages","stargazers_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/stargazers","contributors_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/contributors","subscribers_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/subscribers","subscription_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/subscription","commits_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/commits{/sha}","git_commits_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/git/commits{/sha}","comments_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/comments{/number}","issue_comment_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/issues/comments{/number}","contents_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/contents/{+path}","compare_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/merges","archive_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/downloads","issues_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/issues{/number}","pulls_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/pulls{/number}","milestones_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/milestones{/number}","notifications_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/labels{/name}","releases_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/releases{/id}","deployments_url":"https://api.github.com/repos/nunesjoab/iotagent-mosca/deployments","created_at":"2019-07-10T13:45:58Z","updated_at":"2019-07-10T13:46:01Z","pushed_at":"2019-08-06T11:01:18Z","git_url":"git://github.com/nunesjoab/iotagent-mosca.git","ssh_url":"[email protected]:nunesjoab/iotagent-mosca.git","clone_url":"https://github.com/nunesjoab/iotagent-mosca.git","svn_url":"https://github.com/nunesjoab/iotagent-mosca","homepage":null,"size":533,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"dojot:development","ref":"development","sha":"a068922eafbdad4a28c52699d39cf45697c49bc5","user":{"login":"dojot","id":31219238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjE5MjM4","avatar_url":"https://avatars3.githubusercontent.com/u/31219238?v=4","gravatar_id":"","url":"https://api.github.com/users/dojot","html_url":"https://github.com/dojot","followers_url":"https://api.github.com/users/dojot/followers","following_url":"https://api.github.com/users/dojot/following{/other_user}","gists_url":"https://api.github.com/users/dojot/gists{/gist_id}","starred_url":"https://api.github.com/users/dojot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojot/subscriptions","organizations_url":"https://api.github.com/users/dojot/orgs","repos_url":"https://api.github.com/users/dojot/repos","events_url":"https://api.github.com/users/dojot/events{/privacy}","received_events_url":"https://api.github.com/users/dojot/received_events","type":"Organization","site_admin":false},"repo":{"id":125246413,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUyNDY0MTM=","name":"iotagent-mosca","full_name":"dojot/iotagent-mosca","private":false,"owner":{"login":"dojot","id":31219238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjE5MjM4","avatar_url":"https://avatars3.githubusercontent.com/u/31219238?v=4","gravatar_id":"","url":"https://api.github.com/users/dojot","html_url":"https://github.com/dojot","followers_url":"https://api.github.com/users/dojot/followers","following_url":"https://api.github.com/users/dojot/following{/other_user}","gists_url":"https://api.github.com/users/dojot/gists{/gist_id}","starred_url":"https://api.github.com/users/dojot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojot/subscriptions","organizations_url":"https://api.github.com/users/dojot/orgs","repos_url":"https://api.github.com/users/dojot/repos","events_url":"https://api.github.com/users/dojot/events{/privacy}","received_events_url":"https://api.github.com/users/dojot/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dojot/iotagent-mosca","description":"Mosca-based iotagent for MQTT/JSON devices","fork":false,"url":"https://api.github.com/repos/dojot/iotagent-mosca","forks_url":"https://api.github.com/repos/dojot/iotagent-mosca/forks","keys_url":"https://api.github.com/repos/dojot/iotagent-mosca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojot/iotagent-mosca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojot/iotagent-mosca/teams","hooks_url":"https://api.github.com/repos/dojot/iotagent-mosca/hooks","issue_events_url":"https://api.github.com/repos/dojot/iotagent-mosca/issues/events{/number}","events_url":"https://api.github.com/repos/dojot/iotagent-mosca/events","assignees_url":"https://api.github.com/repos/dojot/iotagent-mosca/assignees{/user}","branches_url":"https://api.github.com/repos/dojot/iotagent-mosca/branches{/branch}","tags_url":"https://api.github.com/repos/dojot/iotagent-mosca/tags","blobs_url":"https://api.github.com/repos/dojot/iotagent-mosca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojot/iotagent-mosca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojot/iotagent-mosca/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojot/iotagent-mosca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojot/iotagent-mosca/statuses/{sha}","languages_url":"https://api.github.com/repos/dojot/iotagent-mosca/languages","stargazers_url":"https://api.github.com/repos/dojot/iotagent-mosca/stargazers","contributors_url":"https://api.github.com/repos/dojot/iotagent-mosca/contributors","subscribers_url":"https://api.github.com/repos/dojot/iotagent-mosca/subscribers","subscription_url":"https://api.github.com/repos/dojot/iotagent-mosca/subscription","commits_url":"https://api.github.com/repos/dojot/iotagent-mosca/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojot/iotagent-mosca/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojot/iotagent-mosca/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojot/iotagent-mosca/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojot/iotagent-mosca/contents/{+path}","compare_url":"https://api.github.com/repos/dojot/iotagent-mosca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojot/iotagent-mosca/merges","archive_url":"https://api.github.com/repos/dojot/iotagent-mosca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojot/iotagent-mosca/downloads","issues_url":"https://api.github.com/repos/dojot/iotagent-mosca/issues{/number}","pulls_url":"https://api.github.com/repos/dojot/iotagent-mosca/pulls{/number}","milestones_url":"https://api.github.com/repos/dojot/iotagent-mosca/milestones{/number}","notifications_url":"https://api.github.com/repos/dojot/iotagent-mosca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojot/iotagent-mosca/labels{/name}","releases_url":"https://api.github.com/repos/dojot/iotagent-mosca/releases{/id}","deployments_url":"https://api.github.com/repos/dojot/iotagent-mosca/deployments","created_at":"2018-03-14T17:04:00Z","updated_at":"2019-08-05T12:33:35Z","pushed_at":"2019-08-06T11:01:19Z","git_url":"git://github.com/dojot/iotagent-mosca.git","ssh_url":"[email protected]:dojot/iotagent-mosca.git","clone_url":"https://github.com/dojot/iotagent-mosca.git","svn_url":"https://github.com/dojot/iotagent-mosca","homepage":null,"size":538,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":18,"open_issues":3,"watchers":0,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/dojot/iotagent-mosca/pulls/75"},"html":{"href":"https://github.com/dojot/iotagent-mosca/pull/75"},"issue":{"href":"https://api.github.com/repos/dojot/iotagent-mosca/issues/75"},"comments":{"href":"https://api.github.com/repos/dojot/iotagent-mosca/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/dojot/iotagent-mosca/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/dojot/iotagent-mosca/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dojot/iotagent-mosca/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/dojot/iotagent-mosca/statuses/1eb51145ced3522092072f2cb16aebe15d95cc1b"}},"author_association":"CONTRIBUTOR"}}	{ "id": 125246413, "name": "dojot/iotagent-mosca", "url": "https://api.github.com/repos/dojot/iotagent-mosca" }	{ "id": 6900446, "login": "mprevide", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/6900446?", "url": "https://api.github.com/users/mprevide" }	{ "id": 31219238, "login": "dojot", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/31219238?", "url": "https://api.github.com/orgs/dojot" }	2019-08-06T12:19:42	10156219923	{"actor":{"display_login":"mprevide"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/pulls/comments/324958052","pull_request_review_id":288990859,"id":324958052,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNDk1ODA1Mg==","diff_hunk":"@@ -5,6 +5,8 @@ permalink: /about/eboard\n published: true\n ---\n \n+{% assign showname = false %}","path":"eBoard.md","position":4,"original_position":4,"commit_id":"4867b51fa78f49284693d28c480c7b92f3184e28","original_commit_id":"e7dc58408bc1cdde4917fdcfbfbd4a0eb7986c49","user":{"login":"balloneij","id":10062962,"node_id":"MDQ6VXNlcjEwMDYyOTYy","avatar_url":"https://avatars2.githubusercontent.com/u/10062962?v=4","gravatar_id":"","url":"https://api.github.com/users/balloneij","html_url":"https://github.com/balloneij","followers_url":"https://api.github.com/users/balloneij/followers","following_url":"https://api.github.com/users/balloneij/following{/other_user}","gists_url":"https://api.github.com/users/balloneij/gists{/gist_id}","starred_url":"https://api.github.com/users/balloneij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloneij/subscriptions","organizations_url":"https://api.github.com/users/balloneij/orgs","repos_url":"https://api.github.com/users/balloneij/repos","events_url":"https://api.github.com/users/balloneij/events{/privacy}","received_events_url":"https://api.github.com/users/balloneij/received_events","type":"User","site_admin":false},"body":"[I suggest passing variables directly into the templates](https://jekyllrb.com/docs/includes/) `{% include note.html content=\"This is my sample note.\" %}`","created_at":"2019-09-17T02:31:27Z","updated_at":"2019-09-17T02:31:28Z","html_url":"https://github.com/msoe-sse/msoe-sse.github.io/pull/100#discussion_r324958052","pull_request_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/pulls/100","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/pulls/comments/324958052"},"html":{"href":"https://github.com/msoe-sse/msoe-sse.github.io/pull/100#discussion_r324958052"},"pull_request":{"href":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/pulls/100"}}},"pull_request":{"url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/pulls/100","id":317602707,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE3NjAyNzA3","html_url":"https://github.com/msoe-sse/msoe-sse.github.io/pull/100","diff_url":"https://github.com/msoe-sse/msoe-sse.github.io/pull/100.diff","patch_url":"https://github.com/msoe-sse/msoe-sse.github.io/pull/100.patch","issue_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/issues/100","number":100,"state":"open","locked":false,"title":"Add contacts","user":{"login":"IsenfireLDC","id":23425717,"node_id":"MDQ6VXNlcjIzNDI1NzE3","avatar_url":"https://avatars1.githubusercontent.com/u/23425717?v=4","gravatar_id":"","url":"https://api.github.com/users/IsenfireLDC","html_url":"https://github.com/IsenfireLDC","followers_url":"https://api.github.com/users/IsenfireLDC/followers","following_url":"https://api.github.com/users/IsenfireLDC/following{/other_user}","gists_url":"https://api.github.com/users/IsenfireLDC/gists{/gist_id}","starred_url":"https://api.github.com/users/IsenfireLDC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IsenfireLDC/subscriptions","organizations_url":"https://api.github.com/users/IsenfireLDC/orgs","repos_url":"https://api.github.com/users/IsenfireLDC/repos","events_url":"https://api.github.com/users/IsenfireLDC/events{/privacy}","received_events_url":"https://api.github.com/users/IsenfireLDC/received_events","type":"User","site_admin":false},"body":"Added contact information listed in #95 to the footer","created_at":"2019-09-15T01:52:56Z","updated_at":"2019-09-17T02:31:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08d9cf1d23d89db1f0b90d7d46e85c6588a08d86","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/pulls/100/commits","review_comments_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/pulls/100/comments","review_comment_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/issues/100/comments","statuses_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/statuses/4867b51fa78f49284693d28c480c7b92f3184e28","head":{"label":"msoe-sse:add_contacts","ref":"add_contacts","sha":"4867b51fa78f49284693d28c480c7b92f3184e28","user":{"login":"msoe-sse","id":31250830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjUwODMw","avatar_url":"https://avatars3.githubusercontent.com/u/31250830?v=4","gravatar_id":"","url":"https://api.github.com/users/msoe-sse","html_url":"https://github.com/msoe-sse","followers_url":"https://api.github.com/users/msoe-sse/followers","following_url":"https://api.github.com/users/msoe-sse/following{/other_user}","gists_url":"https://api.github.com/users/msoe-sse/gists{/gist_id}","starred_url":"https://api.github.com/users/msoe-sse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msoe-sse/subscriptions","organizations_url":"https://api.github.com/users/msoe-sse/orgs","repos_url":"https://api.github.com/users/msoe-sse/repos","events_url":"https://api.github.com/users/msoe-sse/events{/privacy}","received_events_url":"https://api.github.com/users/msoe-sse/received_events","type":"Organization","site_admin":false},"repo":{"id":131654124,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE2NTQxMjQ=","name":"msoe-sse.github.io","full_name":"msoe-sse/msoe-sse.github.io","private":false,"owner":{"login":"msoe-sse","id":31250830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjUwODMw","avatar_url":"https://avatars3.githubusercontent.com/u/31250830?v=4","gravatar_id":"","url":"https://api.github.com/users/msoe-sse","html_url":"https://github.com/msoe-sse","followers_url":"https://api.github.com/users/msoe-sse/followers","following_url":"https://api.github.com/users/msoe-sse/following{/other_user}","gists_url":"https://api.github.com/users/msoe-sse/gists{/gist_id}","starred_url":"https://api.github.com/users/msoe-sse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msoe-sse/subscriptions","organizations_url":"https://api.github.com/users/msoe-sse/orgs","repos_url":"https://api.github.com/users/msoe-sse/repos","events_url":"https://api.github.com/users/msoe-sse/events{/privacy}","received_events_url":"https://api.github.com/users/msoe-sse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/msoe-sse/msoe-sse.github.io","description":null,"fork":false,"url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io","forks_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/forks","keys_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/teams","hooks_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/hooks","issue_events_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/events","assignees_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/tags","blobs_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/languages","stargazers_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/stargazers","contributors_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/contributors","subscribers_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/subscribers","subscription_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/subscription","commits_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/merges","archive_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/downloads","issues_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/labels{/name}","releases_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/deployments","created_at":"2018-04-30T22:49:07Z","updated_at":"2019-09-09T23:09:27Z","pushed_at":"2019-09-17T02:12:10Z","git_url":"git://github.com/msoe-sse/msoe-sse.github.io.git","ssh_url":"[email protected]:msoe-sse/msoe-sse.github.io.git","clone_url":"https://github.com/msoe-sse/msoe-sse.github.io.git","svn_url":"https://github.com/msoe-sse/msoe-sse.github.io","homepage":null,"size":68129,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":17,"watchers":2,"default_branch":"master"}},"base":{"label":"msoe-sse:dev","ref":"dev","sha":"9cb8b215a0283749f559d51b7b9396cfd8ead083","user":{"login":"msoe-sse","id":31250830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjUwODMw","avatar_url":"https://avatars3.githubusercontent.com/u/31250830?v=4","gravatar_id":"","url":"https://api.github.com/users/msoe-sse","html_url":"https://github.com/msoe-sse","followers_url":"https://api.github.com/users/msoe-sse/followers","following_url":"https://api.github.com/users/msoe-sse/following{/other_user}","gists_url":"https://api.github.com/users/msoe-sse/gists{/gist_id}","starred_url":"https://api.github.com/users/msoe-sse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msoe-sse/subscriptions","organizations_url":"https://api.github.com/users/msoe-sse/orgs","repos_url":"https://api.github.com/users/msoe-sse/repos","events_url":"https://api.github.com/users/msoe-sse/events{/privacy}","received_events_url":"https://api.github.com/users/msoe-sse/received_events","type":"Organization","site_admin":false},"repo":{"id":131654124,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE2NTQxMjQ=","name":"msoe-sse.github.io","full_name":"msoe-sse/msoe-sse.github.io","private":false,"owner":{"login":"msoe-sse","id":31250830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjUwODMw","avatar_url":"https://avatars3.githubusercontent.com/u/31250830?v=4","gravatar_id":"","url":"https://api.github.com/users/msoe-sse","html_url":"https://github.com/msoe-sse","followers_url":"https://api.github.com/users/msoe-sse/followers","following_url":"https://api.github.com/users/msoe-sse/following{/other_user}","gists_url":"https://api.github.com/users/msoe-sse/gists{/gist_id}","starred_url":"https://api.github.com/users/msoe-sse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msoe-sse/subscriptions","organizations_url":"https://api.github.com/users/msoe-sse/orgs","repos_url":"https://api.github.com/users/msoe-sse/repos","events_url":"https://api.github.com/users/msoe-sse/events{/privacy}","received_events_url":"https://api.github.com/users/msoe-sse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/msoe-sse/msoe-sse.github.io","description":null,"fork":false,"url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io","forks_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/forks","keys_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/teams","hooks_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/hooks","issue_events_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/events","assignees_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/tags","blobs_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/languages","stargazers_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/stargazers","contributors_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/contributors","subscribers_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/subscribers","subscription_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/subscription","commits_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/merges","archive_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/downloads","issues_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/labels{/name}","releases_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/deployments","created_at":"2018-04-30T22:49:07Z","updated_at":"2019-09-09T23:09:27Z","pushed_at":"2019-09-17T02:12:10Z","git_url":"git://github.com/msoe-sse/msoe-sse.github.io.git","ssh_url":"[email protected]:msoe-sse/msoe-sse.github.io.git","clone_url":"https://github.com/msoe-sse/msoe-sse.github.io.git","svn_url":"https://github.com/msoe-sse/msoe-sse.github.io","homepage":null,"size":68129,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":17,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/pulls/100"},"html":{"href":"https://github.com/msoe-sse/msoe-sse.github.io/pull/100"},"issue":{"href":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/issues/100"},"comments":{"href":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/issues/100/comments"},"review_comments":{"href":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/pulls/100/comments"},"review_comment":{"href":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/pulls/100/commits"},"statuses":{"href":"https://api.github.com/repos/msoe-sse/msoe-sse.github.io/statuses/4867b51fa78f49284693d28c480c7b92f3184e28"}},"author_association":"NONE"}}	{ "id": 131654124, "name": "msoe-sse/msoe-sse.github.io", "url": "https://api.github.com/repos/msoe-sse/msoe-sse.github.io" }	{ "id": 10062962, "login": "balloneij", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/10062962?", "url": "https://api.github.com/users/balloneij" }	{ "id": 31250830, "login": "msoe-sse", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/31250830?", "url": "https://api.github.com/orgs/msoe-sse" }	2019-09-17T02:31:27	10429378386	{"actor":{"display_login":"balloneij"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/PolideaInternal/airflow/pulls/comments/259788560","pull_request_review_id":207349520,"id":259788560,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1OTc4ODU2MA==","diff_hunk":"@@ -0,0 +1,856 @@\n+# -- coding: utf-8 --\n+#\n+# Licensed to the Apache Software Foundation (ASF) under one\n+# or more contributor license agreements. See the NOTICE file\n+# distributed with this work for additional information\n+# regarding copyright ownership. The ASF licenses this file\n+# to you under the Apache License, Version 2.0 (the\n+# \"License\"); you may not use this file except in compliance\n+# with the License. You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing,\n+# software distributed under the License is distributed on an\n+# \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+# KIND, either express or implied. See the License for the\n+# specific language governing permissions and limitations\n+# under the License.\n+#\n+from copy import deepcopy\n+from datetime import date, time\n+\n+from airflow import AirflowException\n+from airflow.contrib.hooks.gcp_transfer_hook import GCPTransferServiceHook, \\\n+ GcpTransferJobsStatus\n+from airflow.models import BaseOperator\n+from airflow.utils.decorators import apply_defaults\n+\n+try:\n+ from airflow.contrib.hooks.aws_hook import AwsHook\n+except ImportError: # pragma: no cover\n+ AwsHook = None\n+\n+\n+class TransferJobPreprocessor:\n+\n+ def __init__(self, body, aws_conn_id='aws_default'):\n+ self.body = body\n+ self.aws_conn_id = aws_conn_id\n+\n+ def _inject_aws_credentials(self):\n+ if 'transferSpec' not in self.body or \\\n+ 'awsS3DataSource' not in self.body['transferSpec']:\n+ return\n+\n+ aws_hook = AwsHook(self.aws_conn_id)\n+ aws_credentials = aws_hook.get_credentials()\n+ aws_access_key_id = aws_credentials.access_key\n+ aws_secret_access_key = aws_credentials.secret_key\n+ self.body['transferSpec']['awsS3DataSource'][\"awsAccessKey\"] = {\n+ \"accessKeyId\": aws_access_key_id,\n+ \"secretAccessKey\": aws_secret_access_key\n+ }\n+\n+ def _reformat_date(self, field_key):\n+ if field_key not in self.body['schedule']:\n+ return\n+ if isinstance(self.body['schedule'][field_key], date):\n+ self.body['schedule'][field_key] = self.\\\n+ _convert_date(self.body['schedule'][field_key])\n+\n+ def _reformat_time(self, field_key):\n+ if field_key not in self.body['schedule']:\n+ return\n+ if isinstance(self.body['schedule'][field_key], time):\n+ self.body['schedule'][field_key] = self.\\\n+ _convert_time(self.body['schedule'][field_key])\n+\n+ def _reformat_schedule(self):\n+ if 'schedule' not in self.body:\n+ return\n+ self._reformat_date('scheduleStartDate')\n+ self._reformat_date('scheduleEndDate')\n+ self._reformat_time('startTimeOfDay')\n+\n+ def process_body(self):\n+ self._inject_aws_credentials()\n+ self._reformat_schedule()\n+ return self.body\n+\n+ @staticmethod\n+ def _convert_date(field_date):\n+ return {\n+ 'day': field_date.day,\n+ 'month': field_date.month,\n+ 'year': field_date.year\n+ }\n+\n+ @staticmethod\n+ def _convert_time(time):\n+ return {\n+ \"hours\": time.hour,\n+ \"minutes\": time.minute,\n+ \"seconds\": time.second,\n+ }\n+\n+\n+class TransferJobValidator:\n+\n+ def __init__(self, body):\n+ self.body = body\n+\n+ def _verify_data_source(self):\n+ if 'transferSpec' not in self.body:\n+ return\n+\n+ is_gcs = 'gcsDataSource' in self.body['transferSpec']\n+ is_aws_s3 = 'awsS3DataSource' in self.body['transferSpec']\n+ is_http = 'httpDataSource' in self.body['transferSpec']\n+\n+ if not is_gcs ^ is_aws_s3 ^ is_http:\n+ raise AirflowException(\"You must choose only one data source\")\n+\n+ def _restrict_aws_credentials(self):\n+ if 'transferSpec' in self.body and \\\n+ 'awsS3DataSource' in self.body['transferSpec'] and \\\n+ 'awsAccessKey' in self.body['transferSpec']['awsS3DataSource']:\n+ raise AirflowException(\"Credentials in body is not allowed. \"\n+ \"To store credentials, use connections.\")\n+\n+ def _restrict_empty_body(self):\n+ if not self.body:\n+ raise AirflowException(\"The required parameter 'body' \"\n+ \"is empty or None\")\n+\n+ def validate_body(self):\n+ self._restrict_empty_body()\n+ self._restrict_aws_credentials()\n+ self._verify_data_source()\n+\n+\n+class GcpTransferServiceJobCreateOperator(BaseOperator):\n+ \"\"\"\n+ Creates a transfer job that runs periodically.\n+\n+ .. warning::\n+\n+ This operator is NOT idempotent. If you run it many times, many transfer\n+ job will be created on the Google Cloud Platform.\n+\n+ .. seealso::\n+ For more information on how to use this operator, take a look at the guide:\n+ :ref:`howto/operator:GcpTransferServiceJobCreateOperator`\n+\n+ :param body: The request body, as described in\n+ https://cloud.google.com/storage-transfer/docs/reference/rest/v1/transferJobs/create#request-body\n+ With three additional improvements:\n+\n+ * dates can be given in the form datetime.date\n+ * times can be given in the form datetime.time\n+ * credentials to AWS should be stored in connection and\n+ selected by the aws_conn_id parameter\n+\n+ :type body: dict\n+ :param aws_conn_id: The connection ID used to retrieve credentials to\n+ Amazon Web Service.\n+ :type aws_conn_id: str\n+ :param gcp_conn_id: The connection ID used to connect to Google Cloud\n+ Platform.\n+ :type gcp_conn_id: str\n+ :param api_version: API version used (e.g. v1).\n+ :type api_version: str\n+ :return: Google Storage Transfer service object\n+ :rtype: dict\n+ \"\"\"\n+ # [START gcp_transfer_job_create_template_fields]\n+ template_fields = ('body', 'gcp_conn_id', 'aws_conn_id', )\n+ # [END gcp_transfer_job_create_template_fields]\n+\n+ @apply_defaults\n+ def __init__(self,\n+ body,\n+ aws_conn_id='aws_default',\n+ gcp_conn_id='google_cloud_default',\n+ api_version='v1',\n+ args,\n+ kwargs):\n+ super(GcpTransferServiceJobCreateOperator, self)\\\n+ .__init__(args, *kwargs)\n+ self.body = deepcopy(body)\n+ self.aws_conn_id = aws_conn_id\n+ self.gcp_conn_id = gcp_conn_id\n+ self.api_version = api_version\n+ self._validate_inputs()\n+\n+ def _validate_inputs(self):\n+ TransferJobValidator(\n+ body=self.body,\n+ ).validate_body()\n+\n+ def execute(self, context):\n+ TransferJobPreprocessor(\n+ body=self.body,\n+ aws_conn_id=self.aws_conn_id,\n+ ).process_body()\n+ hook = GCPTransferServiceHook(\n+ api_version=self.api_version,\n+ gcp_conn_id=self.gcp_conn_id,\n+ )\n+ return hook.create_transfer_job(\n+ body=self.body\n+ )\n+\n+\n+class GcpTransferServiceJobUpdateOperator(BaseOperator):\n+ \"\"\"\n+ Updates a transfer job that runs periodically.\n+\n+ .. seealso::\n+ For more information on how to use this operator, take a look at the guide:\n+ :ref:`howto/operator:GcpTransferServiceJobUpdateOperator`\n+\n+ :param job_name: Name of the job to be updated\n+ :type job_name: str\n+ :param body: The request body, as described in\n+ https://cloud.google.com/storage-transfer/docs/reference/rest/v1/transferJobs/patch#request-body\n+ With three additional improvements:\n+\n+ dates can be given in the form datetime.date\n+ * times can be given in the form datetime.time\n+ * credentials to Amazon Web Service should be stored in connection and\n+ indicated by the aws_conn_id parameter\n+\n+ :type body: dict\n+ :param aws_conn_id: The connection ID used to retrieve credentials to\n+ Amazon Web Service.\n+ :type aws_conn_id: str\n+ :param gcp_conn_id: The connection ID used to connect to Google Cloud\n+ Platform.\n+ :type gcp_conn_id: str\n+ :param api_version: API version used (e.g. v1).\n+ :type api_version: str\n+ :return: Google Storage Transfer service object\n+ :rtype: dict\n+ \"\"\"\n+ # [START gcp_transfer_job_update_template_fields]\n+ template_fields = ('job_name', 'body', 'gcp_conn_id', 'aws_conn_id', )\n+ # [END gcp_transfer_job_update_template_fields]\n+\n+ @apply_defaults\n+ def __init__(self,\n+ job_name,\n+ body,\n+ aws_conn_id='aws_default',\n+ gcp_conn_id='google_cloud_default',\n+ api_version='v1',\n+ args,\n+ kwargs):\n+ super(GcpTransferServiceJobUpdateOperator, self).__init__(args, *kwargs)\n+ self.job_name = job_name\n+ self.body = body\n+ self.gcp_conn_id = gcp_conn_id\n+ self.api_version = api_version\n+ self.aws_conn_id = aws_conn_id\n+ self._validate_inputs()\n+\n+ def _validate_inputs(self):\n+ TransferJobValidator(\n+ body=self.body,\n+ ).validate_body()\n+ if not self.job_name:\n+ raise AirflowException(\"The required parameter 'job_name' \"\n+ \"is empty or None\")\n+\n+ def execute(self, context):\n+ TransferJobPreprocessor(\n+ body=self.body,\n+ aws_conn_id=self.aws_conn_id,\n+ ).process_body()\n+ hook = GCPTransferServiceHook(\n+ api_version=self.api_version,\n+ gcp_conn_id=self.gcp_conn_id,\n+ )\n+ return hook.update_transfer_job(\n+ job_name=self.job_name,\n+ body=self.body,\n+ )\n+\n+\n+class GcpTransferServiceJobDeleteOperator(BaseOperator):\n+ \"\"\"\n+ Delete a transfer job.\n+\n+ .. seealso::\n+ For more information on how to use this operator, take a look at the guide:\n+ :ref:`howto/operator:GcpTransferServiceJobDeleteOperator`\n+\n+ :param job_name: The name of the operation resource to be cancelled.\n+ :type job_name: str Name of the transfer job. Required.\n+ :type gcp_conn_id: str\n+ :param project_id: Optional, Google Cloud Platform Project ID.\n+ :type project_id: str\n+ :param gcp_conn_id: The connection ID used to connect to Google Cloud\n+ Platform.\n+ :type gcp_conn_id: str\n+ :param api_version: API version used (e.g. v1).\n+ :type api_version: str\n+ \"\"\"\n+ # [START gcp_transfer_job_delete_template_fields]\n+ template_fields = ('job_name', 'project_id', 'gcp_conn_id', )\n+ # [END gcp_transfer_job_delete_template_fields]\n+\n+ @apply_defaults\n+ def __init__(self,\n+ job_name,\n+ gcp_conn_id='google_cloud_default',\n+ api_version='v1',\n+ project_id=None,\n+ args,\n+ *kwargs):\n+ super(GcpTransferServiceJobDeleteOperator, self)\\\n+ .__init__(args, *kwargs)\n+ self.job_name = job_name\n+ self.project_id = project_id\n+ self.gcp_conn_id = gcp_conn_id\n+ self.api_version = api_version\n+ self._validate_inputs()\n+\n+ def _validate_inputs(self):\n+ if not self.job_name:\n+ raise AirflowException(\"The required parameter 'job_name' \"\n+ \"is empty or None\")\n+\n+ def execute(self, context):\n+ self._validate_inputs()\n+ hook = GCPTransferServiceHook(\n+ api_version=self.api_version,\n+ gcp_conn_id=self.gcp_conn_id,\n+ )\n+ hook.delete_transfer_job(\n+ job_name=self.job_name,\n+ project_id=self.project_id\n+ )\n+\n+\n+class GcpTransferServiceOperationGetOperator(BaseOperator):\n+ \"\"\"\n+ Gets the latest state of a long-running operation in Google Storage Transfer\n+ Service.\n+\n+ .. seealso::\n+ For more information on how to use this operator, take a look at the guide:\n+ :ref:`howto/operator:GcpTransferServiceOperationGetOperator`\n+\n+ :param operation_name: Name of the transfer operation. Required.\n+ :type operation_name: str\n+ :param gcp_conn_id: The connection ID used to connect to Google\n+ Cloud Platform.\n+ :type gcp_conn_id: str\n+ :param api_version: API version used (e.g. v1).\n+ :type api_version: str\n+ :return: Google Storage Transfer service object\n+ :rtype: dict\n+ \"\"\"\n+ # [START gcp_transfer_operation_get_template_fields]\n+ template_fields = ('operation_name', 'gcp_conn_id', )\n+ # [END gcp_transfer_operation_get_template_fields]\n+\n+ @apply_defaults\n+ def __init__(self,\n+ operation_name,\n+ gcp_conn_id='google_cloud_default',\n+ api_version='v1',\n+ args,\n+ *kwargs):\n+ super(GcpTransferServiceOperationGetOperator, self).__init__(args, *kwargs)\n+ self.operation_name = operation_name\n+ self.gcp_conn_id = gcp_conn_id\n+ self.api_version = api_version\n+ self._validate_inputs()\n+\n+ def _validate_inputs(self):\n+ if not self.operation_name:\n+ raise AirflowException(\"The required parameter 'operation_name' \"\n+ \"is empty or None\")\n+\n+ def execute(self, context):\n+ hook = GCPTransferServiceHook(\n+ api_version=self.api_version,\n+ gcp_conn_id=self.gcp_conn_id,\n+ )\n+ operation = hook.get_transfer_operation(\n+ operation_name=self.operation_name,\n+ )\n+ self.log.info(operation)\n+ return operation\n+\n+\n+class GcpTransferServiceOperationsListOperator(BaseOperator):\n+ \"\"\"\n+ Lists long-running operations in Google Storage Transfer\n+ Service that match the specified filter.\n+\n+ .. seealso::\n+ For more information on how to use this operator, take a look at the guide:\n+ :ref:`howto/operator:GcpTransferServiceOperationsListOperator`\n+\n+ :param filter: A request filter, as described in\n+ https://cloud.google.com/storage-transfer/docs/reference/rest/v1/transferJobs/list#body.QUERY_PARAMETERS.filter\n+ :type filter: dict\n+ :param gcp_conn_id: The connection ID used to connect to Google\n+ Cloud Platform.\n+ :type gcp_conn_id: str\n+ :param api_version: API version used (e.g. v1).\n+ :type api_version: str\n+ :return: List of Transfer Jobs\n+ :rtype: dict[]\n+ \"\"\"\n+ # [START gcp_transfer_operations_list_template_fields]\n+ template_fields = ('filter', 'gcp_conn_id', )\n+ # [END gcp_transfer_operations_list_template_fields]\n+\n+ def __init__(self,\n+ filter,\n+ gcp_conn_id='google_cloud_default',\n+ api_version='v1',\n+ args,\n+ *kwargs):\n+ super(GcpTransferServiceOperationsListOperator, self).__init__(args, *kwargs)\n+ self.filter = filter\n+ self.gcp_conn_id = gcp_conn_id\n+ self.api_version = api_version\n+ self._validate_inputs()\n+\n+ def _validate_inputs(self):\n+ if not self.filter:\n+ raise AirflowException(\"The required parameter 'filter' \"\n+ \"is empty or None\")\n+\n+ def execute(self, context):\n+ hook = GCPTransferServiceHook(\n+ api_version=self.api_version,\n+ gcp_conn_id=self.gcp_conn_id,\n+ )\n+ operations_list = hook.list_transfer_operations(\n+ filter=self.filter\n+ )\n+ self.log.info(operations_list)\n+ return operations_list\n+\n+\n+class GcpTransferServiceOperationPauseOperator(BaseOperator):\n+ \"\"\"\n+ Pauses an transfer operation in Google Storage Transfer Service.\n+\n+ .. seealso::\n+ For more information on how to use this operator, take a look at the guide:\n+ :ref:`howto/operator:GcpTransferServiceOperationPauseOperator`\n+\n+ :param operation_name: Name of the transfer operation.\n+ :type operation_name: str\n+ :param gcp_conn_id: Optional, The connection ID used to connect to Google\n+ Cloud Platform.\n+ :type gcp_conn_id: str\n+ :param api_version: API version used (e.g. v1).\n+ :type api_version: str\n+ :return: Google Storage Transfer service object\n+ :rtype: dict\n+ \"\"\"\n+ # [START gcp_transfer_operation_pause_template_fields]\n+ template_fields = ('operation_name', 'gcp_conn_id', )\n+ # [END gcp_transfer_operation_pause_template_fields]\n+\n+ @apply_defaults\n+ def __init__(self,\n+ operation_name,\n+ gcp_conn_id='google_cloud_default',\n+ api_version='v1',\n+ args,\n+ *kwargs):\n+ super(GcpTransferServiceOperationPauseOperator, self).__init__(args, *kwargs)\n+ self.operation_name = operation_name\n+ self.gcp_conn_id = gcp_conn_id\n+ self.api_version = api_version\n+ self._validate_inputs()\n+\n+ def _validate_inputs(self):\n+ if not self.operation_name:\n+ raise AirflowException(\"The required parameter 'operation_name' \"\n+ \"is empty or None\")\n+\n+ def execute(self, context):\n+ hook = GCPTransferServiceHook(\n+ api_version=self.api_version,\n+ gcp_conn_id=self.gcp_conn_id,\n+ )\n+ hook.pause_transfer_operation(\n+ operation_name=self.operation_name\n+ )\n+\n+\n+class GcpTransferServiceOperationResumeOperator(BaseOperator):\n+ \"\"\"\n+ Resumes an transfer operation in Google Storage Transfer Service.\n+\n+ .. seealso::\n+ For more information on how to use this operator, take a look at the guide:\n+ :ref:`howto/operator:GcpTransferServiceOperationResumeOperator`\n+\n+ :param operation_name: Name of the transfer operation.\n+ :type operation_name: str\n+ :param gcp_conn_id: The connection ID used to connect to Google\n+ Cloud Platform.\n+ :param api_version: API version used (e.g. v1).\n+ :type api_version: str\n+ :type gcp_conn_id: str\n+ \"\"\"\n+ # [START gcp_transfer_operation_resume_template_fields]\n+ template_fields = ('operation_name', 'gcp_conn_id', 'api_version')\n+ # [END gcp_transfer_operation_resume_template_fields]\n+\n+ @apply_defaults\n+ def __init__(self,\n+ operation_name,\n+ gcp_conn_id='google_cloud_default',\n+ api_version='v1',\n+ args,\n+ *kwargs):\n+\n+ self.operation_name = operation_name\n+ self.gcp_conn_id = gcp_conn_id\n+ self.api_version = api_version\n+ self._validate_inputs()\n+ super(GcpTransferServiceOperationResumeOperator, self).__init__(args, *kwargs)\n+\n+ def _validate_inputs(self):\n+ if not self.operation_name:\n+ raise AirflowException(\"The required parameter 'operation_name' \"\n+ \"is empty or None\")\n+\n+ def execute(self, context):\n+ hook = GCPTransferServiceHook(\n+ api_version=self.api_version,\n+ gcp_conn_id=self.gcp_conn_id,\n+ )\n+\n+ hook.resume_transfer_operation(\n+ operation_name=self.operation_name\n+ )\n+\n+\n+class GcpTransferServiceOperationCancelOperator(BaseOperator):\n+ \"\"\"\n+ Cancels an transfer operation in Google Storage Transfer Service.\n+\n+ .. seealso::\n+ For more information on how to use this operator, take a look at the guide:\n+ :ref:`howto/operator:GcpTransferServiceOperationCancelOperator`\n+\n+ :param operation_name: Name of the transfer operation.\n+ :type operation_name: str\n+ :param api_version: API version used (e.g. v1).\n+ :type api_version: str\n+ :param gcp_conn_id: The connection ID used to connect to Google\n+ Cloud Platform.\n+ :type gcp_conn_id: str\n+ \"\"\"\n+ # [START gcp_transfer_operation_cancel_template_fields]\n+ template_fields = ('operation_name', 'gcp_conn_id', 'api_version',)\n+ # [END gcp_transfer_operation_cancel_template_fields]\n+\n+ @apply_defaults\n+ def __init__(self,\n+ operation_name,\n+ api_version='v1',\n+ gcp_conn_id='google_cloud_default',\n+ args,\n+ *kwargs):\n+ super(GcpTransferServiceOperationCancelOperator, self).__init__(args, kwargs)\n+ self.operation_name = operation_name\n+ self.api_version = api_version\n+ self.gcp_conn_id = gcp_conn_id\n+ self._validate_inputs()\n+\n+ def _validate_inputs(self):\n+ if not self.operation_name:\n+ raise AirflowException(\"The required parameter 'operation_name' \"\n+ \"is empty or None\")\n+\n+ def execute(self, context):\n+ hook = GCPTransferServiceHook(\n+ api_version=self.api_version,\n+ gcp_conn_id=self.gcp_conn_id,\n+ )\n+ hook.cancel_transfer_operation(\n+ operation_name=self.operation_name\n+ )\n+\n+\n+class S3ToGoogleCloudStorageTransferOperator(BaseOperator):\n+ \"\"\"\n+ Synchronizes an S3 bucket with a Google Cloud Storage bucket using the\n+ GCP Storage Transfer Service.\n+\n+ .. warning::\n+\n+ This operator is NOT idempotent. If you run it many times, many transfer\n+ job will be created on the Google Cloud Platform.\n+\n+ Example*:\n+\n+ .. code-block:: python\n+\n+ s3_to_gcs_transfer_op = S3ToGoogleCloudStorageTransferOperator(\n+ task_id='s3_to_gcs_transfer_example',\n+ s3_bucket='my-s3-bucket',\n+ project_id='my-gcp-project',\n+ gcs_bucket='my-gcs-bucket',\n+ dag=my_dag)\n+\n+ :param s3_bucket: The S3 bucket where to find the objects. (templated)\n+ :type s3_bucket: str\n+ :param gcs_bucket: The destination Google Cloud Storage bucket\n+ where you want to store the files. (templated)\n+ :type gcs_bucket: str\n+ :param project_id: Optional ID of the Google Cloud Platform Console project that\n+ owns the job\n+ :type project_id: str\n+ :param aws_conn_id: The source S3 connection\n+ :type aws_conn_id: str\n+ :param gcp_conn_id: The destination connection ID to use\n+ when connecting to Google Cloud Storage.\n+ :type gcp_conn_id: str\n+ :param delegate_to: The account to impersonate, if any.\n+ For this to work, the service account making the request must have\n+ domain-wide delegation enabled.\n+ :type delegate_to: str\n+ :param description: Optional transfer service job description\n+ :type description: str\n+ :param schedule: Optional transfer service schedule;\n+ If not set, run transfer job once as soon as the operator runs\n+ The format is described\n+ https://cloud.google.com/storage-transfer/docs/reference/rest/v1/transferJobs.\n+ With two additional improvements:\n+\n+ dates they can be passed as :class:`datetime.date`\n+ * times they can be passed as :class:`datetime.time`\n+\n+ :type schedule: dict\n+ :param object_conditions: Optional transfer service object conditions; see\n+ https://cloud.google.com/storage-transfer/docs/reference/rest/v1/TransferSpec\n+ :type object_conditions: dict\n+ :param transfer_options: Optional transfer service transfer options; see\n+ https://cloud.google.com/storage-transfer/docs/reference/rest/v1/TransferSpec\n+ :type transfer_options: dict\n+ :param wait: Wait for transfer to finish\n+ :type wait: bool\n+ \"\"\"\n+\n+ template_fields = ('gcp_conn_id', 's3_bucket', 'gcs_bucket', 'description',\n+ 'object_conditions')\n+ ui_color = '#e09411'\n+\n+ @apply_defaults\n+ def __init__(self,\n+ s3_bucket,\n+ gcs_bucket,\n+ project_id=None,\n+ aws_conn_id='aws_default',\n+ gcp_conn_id='google_cloud_default',\n+ delegate_to=None,\n+ description=None,\n+ schedule=None,\n+ object_conditions=None,\n+ transfer_options=None,\n+ wait=True,\n+ args,\n+ kwargs):\n+\n+ super(S3ToGoogleCloudStorageTransferOperator, self).__init__(\n+ args,\n+ **kwargs)","path":"airflow/contrib/operators/gcp_transfer_operator.py","position":672,"original_position":672,"commit_id":"b6fce66ab7be6dd2f2c8b01150d1fd658f52de3f","original_commit_id":"b6fce66ab7be6dd2f2c8b01150d1fd658f52de3f","user":{"login":"mik-laj","id":12058428,"node_id":"MDQ6VXNlcjEyMDU4NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/12058428?v=4","gravatar_id":"","url":"https://api.github.com/users/mik-laj","html_url":"https://github.com/mik-laj","followers_url":"https://api.github.com/users/mik-laj/followers","following_url":"https://api.github.com/users/mik-laj/following{/other_user}","gists_url":"https://api.github.com/users/mik-laj/gists{/gist_id}","starred_url":"https://api.github.com/users/mik-laj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mik-laj/subscriptions","organizations_url":"https://api.github.com/users/mik-laj/orgs","repos_url":"https://api.github.com/users/mik-laj/repos","events_url":"https://api.github.com/users/mik-laj/events{/privacy}","received_events_url":"https://api.github.com/users/mik-laj/received_events","type":"User","site_admin":false},"body":"The code has been formatted automatically.","created_at":"2019-02-25T11:46:39Z","updated_at":"2019-02-25T11:46:39Z","html_url":"https://github.com/PolideaInternal/airflow/pull/37#discussion_r259788560","pull_request_url":"https://api.github.com/repos/PolideaInternal/airflow/pulls/37","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PolideaInternal/airflow/pulls/comments/259788560"},"html":{"href":"https://github.com/PolideaInternal/airflow/pull/37#discussion_r259788560"},"pull_request":{"href":"https://api.github.com/repos/PolideaInternal/airflow/pulls/37"}},"in_reply_to_id":258498704},"pull_request":{"url":"https://api.github.com/repos/PolideaInternal/airflow/pulls/37","id":244373576,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ0MzczNTc2","html_url":"https://github.com/PolideaInternal/airflow/pull/37","diff_url":"https://github.com/PolideaInternal/airflow/pull/37.diff","patch_url":"https://github.com/PolideaInternal/airflow/pull/37.patch","issue_url":"https://api.github.com/repos/PolideaInternal/airflow/issues/37","number":37,"state":"open","locked":false,"title":"[AIRFLOW-3659] Create Google Cloud Transfer Service Operators","user":{"login":"mik-laj","id":12058428,"node_id":"MDQ6VXNlcjEyMDU4NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/12058428?v=4","gravatar_id":"","url":"https://api.github.com/users/mik-laj","html_url":"https://github.com/mik-laj","followers_url":"https://api.github.com/users/mik-laj/followers","following_url":"https://api.github.com/users/mik-laj/following{/other_user}","gists_url":"https://api.github.com/users/mik-laj/gists{/gist_id}","starred_url":"https://api.github.com/users/mik-laj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mik-laj/subscriptions","organizations_url":"https://api.github.com/users/mik-laj/orgs","repos_url":"https://api.github.com/users/mik-laj/repos","events_url":"https://api.github.com/users/mik-laj/events{/privacy}","received_events_url":"https://api.github.com/users/mik-laj/received_events","type":"User","site_admin":false},"body":"https://issues.apache.org/jira/browse/AIRFLOW-3659\r\n\r\nThese are the operators for the Google Cloud Transfer Service: \r\nSee: https://cloud.google.com/storage-transfer/docs/","created_at":"2019-01-14T09:03:25Z","updated_at":"2019-02-25T11:46:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d484e7905f5806f2d8e0e4802dd3a0aaa0399eb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1045114574,"node_id":"MDU6TGFiZWwxMDQ1MTE0NTc0","url":"https://api.github.com/repos/PolideaInternal/airflow/labels/feature","name":"feature","color":"00cc00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PolideaInternal/airflow/pulls/37/commits","review_comments_url":"https://api.github.com/repos/PolideaInternal/airflow/pulls/37/comments","review_comment_url":"https://api.github.com/repos/PolideaInternal/airflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolideaInternal/airflow/issues/37/comments","statuses_url":"https://api.github.com/repos/PolideaInternal/airflow/statuses/b6fce66ab7be6dd2f2c8b01150d1fd658f52de3f","head":{"label":"PolideaInternal:feature/gcp-transfer-operators","ref":"feature/gcp-transfer-operators","sha":"b6fce66ab7be6dd2f2c8b01150d1fd658f52de3f","user":{"login":"PolideaInternal","id":31278126,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjc4MTI2","avatar_url":"https://avatars2.githubusercontent.com/u/31278126?v=4","gravatar_id":"","url":"https://api.github.com/users/PolideaInternal","html_url":"https://github.com/PolideaInternal","followers_url":"https://api.github.com/users/PolideaInternal/followers","following_url":"https://api.github.com/users/PolideaInternal/following{/other_user}","gists_url":"https://api.github.com/users/PolideaInternal/gists{/gist_id}","starred_url":"https://api.github.com/users/PolideaInternal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolideaInternal/subscriptions","organizations_url":"https://api.github.com/users/PolideaInternal/orgs","repos_url":"https://api.github.com/users/PolideaInternal/repos","events_url":"https://api.github.com/users/PolideaInternal/events{/privacy}","received_events_url":"https://api.github.com/users/PolideaInternal/received_events","type":"Organization","site_admin":false},"repo":{"id":147329695,"node_id":"MDEwOlJlcG9zaXRvcnkxNDczMjk2OTU=","name":"airflow","full_name":"PolideaInternal/airflow","private":false,"owner":{"login":"PolideaInternal","id":31278126,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjc4MTI2","avatar_url":"https://avatars2.githubusercontent.com/u/31278126?v=4","gravatar_id":"","url":"https://api.github.com/users/PolideaInternal","html_url":"https://github.com/PolideaInternal","followers_url":"https://api.github.com/users/PolideaInternal/followers","following_url":"https://api.github.com/users/PolideaInternal/following{/other_user}","gists_url":"https://api.github.com/users/PolideaInternal/gists{/gist_id}","starred_url":"https://api.github.com/users/PolideaInternal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolideaInternal/subscriptions","organizations_url":"https://api.github.com/users/PolideaInternal/orgs","repos_url":"https://api.github.com/users/PolideaInternal/repos","events_url":"https://api.github.com/users/PolideaInternal/events{/privacy}","received_events_url":"https://api.github.com/users/PolideaInternal/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PolideaInternal/airflow","description":"Apache Airflow","fork":true,"url":"https://api.github.com/repos/PolideaInternal/airflow","forks_url":"https://api.github.com/repos/PolideaInternal/airflow/forks","keys_url":"https://api.github.com/repos/PolideaInternal/airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolideaInternal/airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolideaInternal/airflow/teams","hooks_url":"https://api.github.com/repos/PolideaInternal/airflow/hooks","issue_events_url":"https://api.github.com/repos/PolideaInternal/airflow/issues/events{/number}","events_url":"https://api.github.com/repos/PolideaInternal/airflow/events","assignees_url":"https://api.github.com/repos/PolideaInternal/airflow/assignees{/user}","branches_url":"https://api.github.com/repos/PolideaInternal/airflow/branches{/branch}","tags_url":"https://api.github.com/repos/PolideaInternal/airflow/tags","blobs_url":"https://api.github.com/repos/PolideaInternal/airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolideaInternal/airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolideaInternal/airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolideaInternal/airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolideaInternal/airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/PolideaInternal/airflow/languages","stargazers_url":"https://api.github.com/repos/PolideaInternal/airflow/stargazers","contributors_url":"https://api.github.com/repos/PolideaInternal/airflow/contributors","subscribers_url":"https://api.github.com/repos/PolideaInternal/airflow/subscribers","subscription_url":"https://api.github.com/repos/PolideaInternal/airflow/subscription","commits_url":"https://api.github.com/repos/PolideaInternal/airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolideaInternal/airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolideaInternal/airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolideaInternal/airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolideaInternal/airflow/contents/{+path}","compare_url":"https://api.github.com/repos/PolideaInternal/airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolideaInternal/airflow/merges","archive_url":"https://api.github.com/repos/PolideaInternal/airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolideaInternal/airflow/downloads","issues_url":"https://api.github.com/repos/PolideaInternal/airflow/issues{/number}","pulls_url":"https://api.github.com/repos/PolideaInternal/airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/PolideaInternal/airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/PolideaInternal/airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolideaInternal/airflow/labels{/name}","releases_url":"https://api.github.com/repos/PolideaInternal/airflow/releases{/id}","deployments_url":"https://api.github.com/repos/PolideaInternal/airflow/deployments","created_at":"2018-09-04T10:35:22Z","updated_at":"2019-02-23T14:43:41Z","pushed_at":"2019-02-25T08:38:15Z","git_url":"git://github.com/PolideaInternal/airflow.git","ssh_url":"[email protected]:PolideaInternal/airflow.git","clone_url":"https://github.com/PolideaInternal/airflow.git","svn_url":"https://github.com/PolideaInternal/airflow","homepage":"https://airflow.apache.org","size":31278,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":15,"watchers":1,"default_branch":"master"}},"base":{"label":"PolideaInternal:master","ref":"master","sha":"57c6665767d548eeb6bab5d2f12514e254c75e25","user":{"login":"PolideaInternal","id":31278126,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjc4MTI2","avatar_url":"https://avatars2.githubusercontent.com/u/31278126?v=4","gravatar_id":"","url":"https://api.github.com/users/PolideaInternal","html_url":"https://github.com/PolideaInternal","followers_url":"https://api.github.com/users/PolideaInternal/followers","following_url":"https://api.github.com/users/PolideaInternal/following{/other_user}","gists_url":"https://api.github.com/users/PolideaInternal/gists{/gist_id}","starred_url":"https://api.github.com/users/PolideaInternal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolideaInternal/subscriptions","organizations_url":"https://api.github.com/users/PolideaInternal/orgs","repos_url":"https://api.github.com/users/PolideaInternal/repos","events_url":"https://api.github.com/users/PolideaInternal/events{/privacy}","received_events_url":"https://api.github.com/users/PolideaInternal/received_events","type":"Organization","site_admin":false},"repo":{"id":147329695,"node_id":"MDEwOlJlcG9zaXRvcnkxNDczMjk2OTU=","name":"airflow","full_name":"PolideaInternal/airflow","private":false,"owner":{"login":"PolideaInternal","id":31278126,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjc4MTI2","avatar_url":"https://avatars2.githubusercontent.com/u/31278126?v=4","gravatar_id":"","url":"https://api.github.com/users/PolideaInternal","html_url":"https://github.com/PolideaInternal","followers_url":"https://api.github.com/users/PolideaInternal/followers","following_url":"https://api.github.com/users/PolideaInternal/following{/other_user}","gists_url":"https://api.github.com/users/PolideaInternal/gists{/gist_id}","starred_url":"https://api.github.com/users/PolideaInternal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolideaInternal/subscriptions","organizations_url":"https://api.github.com/users/PolideaInternal/orgs","repos_url":"https://api.github.com/users/PolideaInternal/repos","events_url":"https://api.github.com/users/PolideaInternal/events{/privacy}","received_events_url":"https://api.github.com/users/PolideaInternal/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PolideaInternal/airflow","description":"Apache Airflow","fork":true,"url":"https://api.github.com/repos/PolideaInternal/airflow","forks_url":"https://api.github.com/repos/PolideaInternal/airflow/forks","keys_url":"https://api.github.com/repos/PolideaInternal/airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolideaInternal/airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolideaInternal/airflow/teams","hooks_url":"https://api.github.com/repos/PolideaInternal/airflow/hooks","issue_events_url":"https://api.github.com/repos/PolideaInternal/airflow/issues/events{/number}","events_url":"https://api.github.com/repos/PolideaInternal/airflow/events","assignees_url":"https://api.github.com/repos/PolideaInternal/airflow/assignees{/user}","branches_url":"https://api.github.com/repos/PolideaInternal/airflow/branches{/branch}","tags_url":"https://api.github.com/repos/PolideaInternal/airflow/tags","blobs_url":"https://api.github.com/repos/PolideaInternal/airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolideaInternal/airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolideaInternal/airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolideaInternal/airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolideaInternal/airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/PolideaInternal/airflow/languages","stargazers_url":"https://api.github.com/repos/PolideaInternal/airflow/stargazers","contributors_url":"https://api.github.com/repos/PolideaInternal/airflow/contributors","subscribers_url":"https://api.github.com/repos/PolideaInternal/airflow/subscribers","subscription_url":"https://api.github.com/repos/PolideaInternal/airflow/subscription","commits_url":"https://api.github.com/repos/PolideaInternal/airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolideaInternal/airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolideaInternal/airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolideaInternal/airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolideaInternal/airflow/contents/{+path}","compare_url":"https://api.github.com/repos/PolideaInternal/airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolideaInternal/airflow/merges","archive_url":"https://api.github.com/repos/PolideaInternal/airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolideaInternal/airflow/downloads","issues_url":"https://api.github.com/repos/PolideaInternal/airflow/issues{/number}","pulls_url":"https://api.github.com/repos/PolideaInternal/airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/PolideaInternal/airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/PolideaInternal/airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolideaInternal/airflow/labels{/name}","releases_url":"https://api.github.com/repos/PolideaInternal/airflow/releases{/id}","deployments_url":"https://api.github.com/repos/PolideaInternal/airflow/deployments","created_at":"2018-09-04T10:35:22Z","updated_at":"2019-02-23T14:43:41Z","pushed_at":"2019-02-25T08:38:15Z","git_url":"git://github.com/PolideaInternal/airflow.git","ssh_url":"[email protected]:PolideaInternal/airflow.git","clone_url":"https://github.com/PolideaInternal/airflow.git","svn_url":"https://github.com/PolideaInternal/airflow","homepage":"https://airflow.apache.org","size":31278,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":15,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolideaInternal/airflow/pulls/37"},"html":{"href":"https://github.com/PolideaInternal/airflow/pull/37"},"issue":{"href":"https://api.github.com/repos/PolideaInternal/airflow/issues/37"},"comments":{"href":"https://api.github.com/repos/PolideaInternal/airflow/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/PolideaInternal/airflow/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/PolideaInternal/airflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolideaInternal/airflow/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/PolideaInternal/airflow/statuses/b6fce66ab7be6dd2f2c8b01150d1fd658f52de3f"}},"author_association":"MEMBER"}}	{ "id": 147329695, "name": "PolideaInternal/airflow", "url": "https://api.github.com/repos/PolideaInternal/airflow" }	{ "id": 12058428, "login": "mik-laj", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/12058428?", "url": "https://api.github.com/users/mik-laj" }	{ "id": 31278126, "login": "PolideaInternal", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/31278126?", "url": "https://api.github.com/orgs/PolideaInternal" }	2019-02-25T11:46:39	9129655369	{"actor":{"display_login":"mik-laj"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/SCons/scons/pulls/comments/365546227","pull_request_review_id":341544756,"id":365546227,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NTU0NjIyNw==","diff_hunk":"@@ -4451,98 +4446,90 @@ File('foo.c').srcnode().path # source path of the given source file.\n \n # Builders also return File objects:\n foo = env.Program('foo.c')\n-print(\"foo will be built in %s\"%foo.path)\n+print(\"foo will be built in\", foo.path)\n </literallayout>\n \n-<para>A\n-<emphasis>Dir</emphasis>\n-Node or\n-<emphasis>File</emphasis>\n-Node can also be used to create\n-file and subdirectory Nodes relative to the generating Node.\n-A\n-<emphasis>Dir</emphasis>\n-Node will place the new Nodes within the directory it represents.\n-A\n-<emphasis>File</emphasis>","path":"doc/man/scons.xml","position":94,"original_position":94,"commit_id":"5c708ef1fbc6767582ccb71f2dffc28e6efd11c8","original_commit_id":"5c708ef1fbc6767582ccb71f2dffc28e6efd11c8","user":{"login":"bdbaddog","id":82228,"node_id":"MDQ6VXNlcjgyMjI4","avatar_url":"https://avatars0.githubusercontent.com/u/82228?v=4","gravatar_id":"","url":"https://api.github.com/users/bdbaddog","html_url":"https://github.com/bdbaddog","followers_url":"https://api.github.com/users/bdbaddog/followers","following_url":"https://api.github.com/users/bdbaddog/following{/other_user}","gists_url":"https://api.github.com/users/bdbaddog/gists{/gist_id}","starred_url":"https://api.github.com/users/bdbaddog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdbaddog/subscriptions","organizations_url":"https://api.github.com/users/bdbaddog/orgs","repos_url":"https://api.github.com/users/bdbaddog/repos","events_url":"https://api.github.com/users/bdbaddog/events{/privacy}","received_events_url":"https://api.github.com/users/bdbaddog/received_events","type":"User","site_admin":false},"body":"I think this bit is worth retaining.","created_at":"2020-01-11T22:52:10Z","updated_at":"2020-01-11T22:52:10Z","html_url":"https://github.com/SCons/scons/pull/3522#discussion_r365546227","pull_request_url":"https://api.github.com/repos/SCons/scons/pulls/3522","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SCons/scons/pulls/comments/365546227"},"html":{"href":"https://github.com/SCons/scons/pull/3522#discussion_r365546227"},"pull_request":{"href":"https://api.github.com/repos/SCons/scons/pulls/3522"}}},"pull_request":{"url":"https://api.github.com/repos/SCons/scons/pulls/3522","id":361668614,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYxNjY4NjE0","html_url":"https://github.com/SCons/scons/pull/3522","diff_url":"https://github.com/SCons/scons/pull/3522.diff","patch_url":"https://github.com/SCons/scons/pull/3522.patch","issue_url":"https://api.github.com/repos/SCons/scons/issues/3522","number":3522,"state":"open","locked":false,"title":"Clean up some manpage duplication, File, Dir","user":{"login":"mwichmann","id":1242215,"node_id":"MDQ6VXNlcjEyNDIyMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1242215?v=4","gravatar_id":"","url":"https://api.github.com/users/mwichmann","html_url":"https://github.com/mwichmann","followers_url":"https://api.github.com/users/mwichmann/followers","following_url":"https://api.github.com/users/mwichmann/following{/other_user}","gists_url":"https://api.github.com/users/mwichmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mwichmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwichmann/subscriptions","organizations_url":"https://api.github.com/users/mwichmann/orgs","repos_url":"https://api.github.com/users/mwichmann/repos","events_url":"https://api.github.com/users/mwichmann/events{/privacy}","received_events_url":"https://api.github.com/users/mwichmann/received_events","type":"User","site_admin":false},"body":"Removed some dupes in the Construction Variables section - the `JAR` entries plus `File`, `Dir`.\r\n\r\nTweaked the `File` and `Dir` function entries, and the File and Directory Nodes section.\r\n\r\nThe end-to-end tests for `File` and `Dir` didn't test the case of supplying a list-of-strings (thus returning a list-of-nodes) to those two functions, added a primitive one.\r\n\r\nStill some unanswered questions. We could resolve these also in this PR, or just proceed with what's here now and maybe address these later.\r\n\r\n- should there be construction variable entries at all for File, Dir, Dirs, RDirs? They're really functions, but they're also entries in the consenv (as `SCons.Defaults.Variable_Method_Caller object`)\r\n- Why is there a `Dirs`? It's for passing a list of nodes, but `Dir` already accepts that.\r\n- How to handle the duplicated consvar entries for `HOST_ARCH`, `TARGET_ARCH`? The other dupes were identical; these consist of a generic description (which says only implemented on win32) and an MSVS description which is win32-specific.\r\n\r\nSigned-off-by: Mats Wichmann <[email protected]>\r\n\r\n## Contributor Checklist:\r\n\r\n* [X] I have created a new test or updated the unit tests to cover the new/changed functionality.\r\n* [ ] I have updated `master/src/CHANGES.txt` directory (and read the `README.txt` in that directory)\r\n* [X] I have updated the appropriate documentation\r\n","created_at":"2020-01-11T00:07:39Z","updated_at":"2020-01-11T22:52:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b23a7638262dd653d4a952047f99a128d2dc831d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SCons/scons/pulls/3522/commits","review_comments_url":"https://api.github.com/repos/SCons/scons/pulls/3522/comments","review_comment_url":"https://api.github.com/repos/SCons/scons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SCons/scons/issues/3522/comments","statuses_url":"https://api.github.com/repos/SCons/scons/statuses/5c708ef1fbc6767582ccb71f2dffc28e6efd11c8","head":{"label":"mwichmann:man-cvdups-and-dir","ref":"man-cvdups-and-dir","sha":"5c708ef1fbc6767582ccb71f2dffc28e6efd11c8","user":{"login":"mwichmann","id":1242215,"node_id":"MDQ6VXNlcjEyNDIyMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1242215?v=4","gravatar_id":"","url":"https://api.github.com/users/mwichmann","html_url":"https://github.com/mwichmann","followers_url":"https://api.github.com/users/mwichmann/followers","following_url":"https://api.github.com/users/mwichmann/following{/other_user}","gists_url":"https://api.github.com/users/mwichmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mwichmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwichmann/subscriptions","organizations_url":"https://api.github.com/users/mwichmann/orgs","repos_url":"https://api.github.com/users/mwichmann/repos","events_url":"https://api.github.com/users/mwichmann/events{/privacy}","received_events_url":"https://api.github.com/users/mwichmann/received_events","type":"User","site_admin":false},"repo":{"id":104681394,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ2ODEzOTQ=","name":"scons","full_name":"mwichmann/scons","private":false,"owner":{"login":"mwichmann","id":1242215,"node_id":"MDQ6VXNlcjEyNDIyMTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1242215?v=4","gravatar_id":"","url":"https://api.github.com/users/mwichmann","html_url":"https://github.com/mwichmann","followers_url":"https://api.github.com/users/mwichmann/followers","following_url":"https://api.github.com/users/mwichmann/following{/other_user}","gists_url":"https://api.github.com/users/mwichmann/gists{/gist_id}","starred_url":"https://api.github.com/users/mwichmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwichmann/subscriptions","organizations_url":"https://api.github.com/users/mwichmann/orgs","repos_url":"https://api.github.com/users/mwichmann/repos","events_url":"https://api.github.com/users/mwichmann/events{/privacy}","received_events_url":"https://api.github.com/users/mwichmann/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mwichmann/scons","description":"SCons - a software construction tool","fork":true,"url":"https://api.github.com/repos/mwichmann/scons","forks_url":"https://api.github.com/repos/mwichmann/scons/forks","keys_url":"https://api.github.com/repos/mwichmann/scons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwichmann/scons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwichmann/scons/teams","hooks_url":"https://api.github.com/repos/mwichmann/scons/hooks","issue_events_url":"https://api.github.com/repos/mwichmann/scons/issues/events{/number}","events_url":"https://api.github.com/repos/mwichmann/scons/events","assignees_url":"https://api.github.com/repos/mwichmann/scons/assignees{/user}","branches_url":"https://api.github.com/repos/mwichmann/scons/branches{/branch}","tags_url":"https://api.github.com/repos/mwichmann/scons/tags","blobs_url":"https://api.github.com/repos/mwichmann/scons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwichmann/scons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwichmann/scons/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwichmann/scons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwichmann/scons/statuses/{sha}","languages_url":"https://api.github.com/repos/mwichmann/scons/languages","stargazers_url":"https://api.github.com/repos/mwichmann/scons/stargazers","contributors_url":"https://api.github.com/repos/mwichmann/scons/contributors","subscribers_url":"https://api.github.com/repos/mwichmann/scons/subscribers","subscription_url":"https://api.github.com/repos/mwichmann/scons/subscription","commits_url":"https://api.github.com/repos/mwichmann/scons/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwichmann/scons/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwichmann/scons/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwichmann/scons/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwichmann/scons/contents/{+path}","compare_url":"https://api.github.com/repos/mwichmann/scons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwichmann/scons/merges","archive_url":"https://api.github.com/repos/mwichmann/scons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwichmann/scons/downloads","issues_url":"https://api.github.com/repos/mwichmann/scons/issues{/number}","pulls_url":"https://api.github.com/repos/mwichmann/scons/pulls{/number}","milestones_url":"https://api.github.com/repos/mwichmann/scons/milestones{/number}","notifications_url":"https://api.github.com/repos/mwichmann/scons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwichmann/scons/labels{/name}","releases_url":"https://api.github.com/repos/mwichmann/scons/releases{/id}","deployments_url":"https://api.github.com/repos/mwichmann/scons/deployments","created_at":"2017-09-24T22:44:25Z","updated_at":"2020-01-10T15:04:12Z","pushed_at":"2020-01-11T19:55:41Z","git_url":"git://github.com/mwichmann/scons.git","ssh_url":"[email protected]:mwichmann/scons.git","clone_url":"https://github.com/mwichmann/scons.git","svn_url":"https://github.com/mwichmann/scons","homepage":"http://scons.org","size":14140,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SCons:master","ref":"master","sha":"9340ef85fea770d01d416ac2dbc2f4991a67e027","user":{"login":"SCons","id":31353197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzUzMTk3","avatar_url":"https://avatars3.githubusercontent.com/u/31353197?v=4","gravatar_id":"","url":"https://api.github.com/users/SCons","html_url":"https://github.com/SCons","followers_url":"https://api.github.com/users/SCons/followers","following_url":"https://api.github.com/users/SCons/following{/other_user}","gists_url":"https://api.github.com/users/SCons/gists{/gist_id}","starred_url":"https://api.github.com/users/SCons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SCons/subscriptions","organizations_url":"https://api.github.com/users/SCons/orgs","repos_url":"https://api.github.com/users/SCons/repos","events_url":"https://api.github.com/users/SCons/events{/privacy}","received_events_url":"https://api.github.com/users/SCons/received_events","type":"Organization","site_admin":false},"repo":{"id":104670160,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ2NzAxNjA=","name":"scons","full_name":"SCons/scons","private":false,"owner":{"login":"SCons","id":31353197,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzUzMTk3","avatar_url":"https://avatars3.githubusercontent.com/u/31353197?v=4","gravatar_id":"","url":"https://api.github.com/users/SCons","html_url":"https://github.com/SCons","followers_url":"https://api.github.com/users/SCons/followers","following_url":"https://api.github.com/users/SCons/following{/other_user}","gists_url":"https://api.github.com/users/SCons/gists{/gist_id}","starred_url":"https://api.github.com/users/SCons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SCons/subscriptions","organizations_url":"https://api.github.com/users/SCons/orgs","repos_url":"https://api.github.com/users/SCons/repos","events_url":"https://api.github.com/users/SCons/events{/privacy}","received_events_url":"https://api.github.com/users/SCons/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SCons/scons","description":"SCons - a software construction tool","fork":false,"url":"https://api.github.com/repos/SCons/scons","forks_url":"https://api.github.com/repos/SCons/scons/forks","keys_url":"https://api.github.com/repos/SCons/scons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SCons/scons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SCons/scons/teams","hooks_url":"https://api.github.com/repos/SCons/scons/hooks","issue_events_url":"https://api.github.com/repos/SCons/scons/issues/events{/number}","events_url":"https://api.github.com/repos/SCons/scons/events","assignees_url":"https://api.github.com/repos/SCons/scons/assignees{/user}","branches_url":"https://api.github.com/repos/SCons/scons/branches{/branch}","tags_url":"https://api.github.com/repos/SCons/scons/tags","blobs_url":"https://api.github.com/repos/SCons/scons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SCons/scons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SCons/scons/git/refs{/sha}","trees_url":"https://api.github.com/repos/SCons/scons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SCons/scons/statuses/{sha}","languages_url":"https://api.github.com/repos/SCons/scons/languages","stargazers_url":"https://api.github.com/repos/SCons/scons/stargazers","contributors_url":"https://api.github.com/repos/SCons/scons/contributors","subscribers_url":"https://api.github.com/repos/SCons/scons/subscribers","subscription_url":"https://api.github.com/repos/SCons/scons/subscription","commits_url":"https://api.github.com/repos/SCons/scons/commits{/sha}","git_commits_url":"https://api.github.com/repos/SCons/scons/git/commits{/sha}","comments_url":"https://api.github.com/repos/SCons/scons/comments{/number}","issue_comment_url":"https://api.github.com/repos/SCons/scons/issues/comments{/number}","contents_url":"https://api.github.com/repos/SCons/scons/contents/{+path}","compare_url":"https://api.github.com/repos/SCons/scons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SCons/scons/merges","archive_url":"https://api.github.com/repos/SCons/scons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SCons/scons/downloads","issues_url":"https://api.github.com/repos/SCons/scons/issues{/number}","pulls_url":"https://api.github.com/repos/SCons/scons/pulls{/number}","milestones_url":"https://api.github.com/repos/SCons/scons/milestones{/number}","notifications_url":"https://api.github.com/repos/SCons/scons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SCons/scons/labels{/name}","releases_url":"https://api.github.com/repos/SCons/scons/releases{/id}","deployments_url":"https://api.github.com/repos/SCons/scons/deployments","created_at":"2017-09-24T19:23:46Z","updated_at":"2020-01-11T22:47:00Z","pushed_at":"2020-01-11T22:46:58Z","git_url":"git://github.com/SCons/scons.git","ssh_url":"[email protected]:SCons/scons.git","clone_url":"https://github.com/SCons/scons.git","svn_url":"https://github.com/SCons/scons","homepage":"http://scons.org","size":14730,"stargazers_count":709,"watchers_count":709,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":164,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":692,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":164,"open_issues":692,"watchers":709,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SCons/scons/pulls/3522"},"html":{"href":"https://github.com/SCons/scons/pull/3522"},"issue":{"href":"https://api.github.com/repos/SCons/scons/issues/3522"},"comments":{"href":"https://api.github.com/repos/SCons/scons/issues/3522/comments"},"review_comments":{"href":"https://api.github.com/repos/SCons/scons/pulls/3522/comments"},"review_comment":{"href":"https://api.github.com/repos/SCons/scons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SCons/scons/pulls/3522/commits"},"statuses":{"href":"https://api.github.com/repos/SCons/scons/statuses/5c708ef1fbc6767582ccb71f2dffc28e6efd11c8"}},"author_association":"COLLABORATOR"}}	{ "id": 104670160, "name": "SCons/scons", "url": "https://api.github.com/repos/SCons/scons" }	{ "id": 82228, "login": "bdbaddog", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/82228?", "url": "https://api.github.com/users/bdbaddog" }	{ "id": 31353197, "login": "SCons", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/31353197?", "url": "https://api.github.com/orgs/SCons" }	2020-01-11T22:52:10	11254340780	{"actor":{"display_login":"bdbaddog"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/Featuretools/featuretools/pulls/comments/320478744","pull_request_review_id":283261970,"id":320478744,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMDQ3ODc0NA==","diff_hunk":"@@ -485,6 +485,9 @@ def entity_from_dataframe(self,\n if time_index is not None and time_index == index:\n raise ValueError(\"time_index and index cannot be the same value, %s\" % (time_index))\n \n+ if vtypes.DatetimeTimeIndex in variable_types.values() and time_index is None:\n+ raise ValueError(\"'DatetimeTimeIndex' must be set using time_index parameter\")","path":"featuretools/entityset/entityset.py","position":5,"original_position":5,"commit_id":"a89be29c3e845e4144a44275b952808966d2d764","original_commit_id":"a89be29c3e845e4144a44275b952808966d2d764","user":{"login":"rwedge","id":5392142,"node_id":"MDQ6VXNlcjUzOTIxNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/5392142?v=4","gravatar_id":"","url":"https://api.github.com/users/rwedge","html_url":"https://github.com/rwedge","followers_url":"https://api.github.com/users/rwedge/followers","following_url":"https://api.github.com/users/rwedge/following{/other_user}","gists_url":"https://api.github.com/users/rwedge/gists{/gist_id}","starred_url":"https://api.github.com/users/rwedge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwedge/subscriptions","organizations_url":"https://api.github.com/users/rwedge/orgs","repos_url":"https://api.github.com/users/rwedge/repos","events_url":"https://api.github.com/users/rwedge/events{/privacy}","received_events_url":"https://api.github.com/users/rwedge/received_events","type":"User","site_admin":false},"body":"We should include the variable name in the error message to help the user track down the source of the problem","created_at":"2019-09-03T21:07:21Z","updated_at":"2019-09-03T21:07:21Z","html_url":"https://github.com/Featuretools/featuretools/pull/723#discussion_r320478744","pull_request_url":"https://api.github.com/repos/Featuretools/featuretools/pulls/723","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Featuretools/featuretools/pulls/comments/320478744"},"html":{"href":"https://github.com/Featuretools/featuretools/pull/723#discussion_r320478744"},"pull_request":{"href":"https://api.github.com/repos/Featuretools/featuretools/pulls/723"}}},"pull_request":{"url":"https://api.github.com/repos/Featuretools/featuretools/pulls/723","id":313753441,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEzNzUzNDQx","html_url":"https://github.com/Featuretools/featuretools/pull/723","diff_url":"https://github.com/Featuretools/featuretools/pull/723.diff","patch_url":"https://github.com/Featuretools/featuretools/pull/723.patch","issue_url":"https://api.github.com/repos/Featuretools/featuretools/issues/723","number":723,"state":"open","locked":false,"title":"Raise an error when DatetimeTimeIndex is a variable but time_index is empty","user":{"login":"christopherbunn","id":8752455,"node_id":"MDQ6VXNlcjg3NTI0NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/8752455?v=4","gravatar_id":"","url":"https://api.github.com/users/christopherbunn","html_url":"https://github.com/christopherbunn","followers_url":"https://api.github.com/users/christopherbunn/followers","following_url":"https://api.github.com/users/christopherbunn/following{/other_user}","gists_url":"https://api.github.com/users/christopherbunn/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherbunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherbunn/subscriptions","organizations_url":"https://api.github.com/users/christopherbunn/orgs","repos_url":"https://api.github.com/users/christopherbunn/repos","events_url":"https://api.github.com/users/christopherbunn/events{/privacy}","received_events_url":"https://api.github.com/users/christopherbunn/received_events","type":"User","site_admin":false},"body":"Added a ValueError message when a DatetimeTimeIndex is set as a variable but is not specified as a time_index\r\n\r\nfixes #497 ","created_at":"2019-09-03T20:30:31Z","updated_at":"2019-09-03T21:07:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"611b3cd1a075f2734b50f224eae1e76c4a0d6a7b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Featuretools/featuretools/pulls/723/commits","review_comments_url":"https://api.github.com/repos/Featuretools/featuretools/pulls/723/comments","review_comment_url":"https://api.github.com/repos/Featuretools/featuretools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Featuretools/featuretools/issues/723/comments","statuses_url":"https://api.github.com/repos/Featuretools/featuretools/statuses/a89be29c3e845e4144a44275b952808966d2d764","head":{"label":"Featuretools:raise-time-index","ref":"raise-time-index","sha":"a89be29c3e845e4144a44275b952808966d2d764","user":{"login":"Featuretools","id":31513623,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTEzNjIz","avatar_url":"https://avatars1.githubusercontent.com/u/31513623?v=4","gravatar_id":"","url":"https://api.github.com/users/Featuretools","html_url":"https://github.com/Featuretools","followers_url":"https://api.github.com/users/Featuretools/followers","following_url":"https://api.github.com/users/Featuretools/following{/other_user}","gists_url":"https://api.github.com/users/Featuretools/gists{/gist_id}","starred_url":"https://api.github.com/users/Featuretools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Featuretools/subscriptions","organizations_url":"https://api.github.com/users/Featuretools/orgs","repos_url":"https://api.github.com/users/Featuretools/repos","events_url":"https://api.github.com/users/Featuretools/events{/privacy}","received_events_url":"https://api.github.com/users/Featuretools/received_events","type":"Organization","site_admin":false},"repo":{"id":102908804,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI5MDg4MDQ=","name":"featuretools","full_name":"Featuretools/featuretools","private":false,"owner":{"login":"Featuretools","id":31513623,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTEzNjIz","avatar_url":"https://avatars1.githubusercontent.com/u/31513623?v=4","gravatar_id":"","url":"https://api.github.com/users/Featuretools","html_url":"https://github.com/Featuretools","followers_url":"https://api.github.com/users/Featuretools/followers","following_url":"https://api.github.com/users/Featuretools/following{/other_user}","gists_url":"https://api.github.com/users/Featuretools/gists{/gist_id}","starred_url":"https://api.github.com/users/Featuretools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Featuretools/subscriptions","organizations_url":"https://api.github.com/users/Featuretools/orgs","repos_url":"https://api.github.com/users/Featuretools/repos","events_url":"https://api.github.com/users/Featuretools/events{/privacy}","received_events_url":"https://api.github.com/users/Featuretools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Featuretools/featuretools","description":"An open source python library for automated feature engineering","fork":false,"url":"https://api.github.com/repos/Featuretools/featuretools","forks_url":"https://api.github.com/repos/Featuretools/featuretools/forks","keys_url":"https://api.github.com/repos/Featuretools/featuretools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Featuretools/featuretools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Featuretools/featuretools/teams","hooks_url":"https://api.github.com/repos/Featuretools/featuretools/hooks","issue_events_url":"https://api.github.com/repos/Featuretools/featuretools/issues/events{/number}","events_url":"https://api.github.com/repos/Featuretools/featuretools/events","assignees_url":"https://api.github.com/repos/Featuretools/featuretools/assignees{/user}","branches_url":"https://api.github.com/repos/Featuretools/featuretools/branches{/branch}","tags_url":"https://api.github.com/repos/Featuretools/featuretools/tags","blobs_url":"https://api.github.com/repos/Featuretools/featuretools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Featuretools/featuretools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Featuretools/featuretools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Featuretools/featuretools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Featuretools/featuretools/statuses/{sha}","languages_url":"https://api.github.com/repos/Featuretools/featuretools/languages","stargazers_url":"https://api.github.com/repos/Featuretools/featuretools/stargazers","contributors_url":"https://api.github.com/repos/Featuretools/featuretools/contributors","subscribers_url":"https://api.github.com/repos/Featuretools/featuretools/subscribers","subscription_url":"https://api.github.com/repos/Featuretools/featuretools/subscription","commits_url":"https://api.github.com/repos/Featuretools/featuretools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Featuretools/featuretools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Featuretools/featuretools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Featuretools/featuretools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Featuretools/featuretools/contents/{+path}","compare_url":"https://api.github.com/repos/Featuretools/featuretools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Featuretools/featuretools/merges","archive_url":"https://api.github.com/repos/Featuretools/featuretools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Featuretools/featuretools/downloads","issues_url":"https://api.github.com/repos/Featuretools/featuretools/issues{/number}","pulls_url":"https://api.github.com/repos/Featuretools/featuretools/pulls{/number}","milestones_url":"https://api.github.com/repos/Featuretools/featuretools/milestones{/number}","notifications_url":"https://api.github.com/repos/Featuretools/featuretools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Featuretools/featuretools/labels{/name}","releases_url":"https://api.github.com/repos/Featuretools/featuretools/releases{/id}","deployments_url":"https://api.github.com/repos/Featuretools/featuretools/deployments","created_at":"2017-09-08T22:15:17Z","updated_at":"2019-09-03T19:53:11Z","pushed_at":"2019-09-03T20:51:06Z","git_url":"git://github.com/Featuretools/featuretools.git","ssh_url":"[email protected]:Featuretools/featuretools.git","clone_url":"https://github.com/Featuretools/featuretools.git","svn_url":"https://github.com/Featuretools/featuretools","homepage":"https://www.featuretools.com","size":3568,"stargazers_count":4090,"watchers_count":4090,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":515,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":90,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":515,"open_issues":90,"watchers":4090,"default_branch":"master"}},"base":{"label":"Featuretools:master","ref":"master","sha":"7d9da1533a6cb7f81dc9feb521c44834c033c530","user":{"login":"Featuretools","id":31513623,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTEzNjIz","avatar_url":"https://avatars1.githubusercontent.com/u/31513623?v=4","gravatar_id":"","url":"https://api.github.com/users/Featuretools","html_url":"https://github.com/Featuretools","followers_url":"https://api.github.com/users/Featuretools/followers","following_url":"https://api.github.com/users/Featuretools/following{/other_user}","gists_url":"https://api.github.com/users/Featuretools/gists{/gist_id}","starred_url":"https://api.github.com/users/Featuretools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Featuretools/subscriptions","organizations_url":"https://api.github.com/users/Featuretools/orgs","repos_url":"https://api.github.com/users/Featuretools/repos","events_url":"https://api.github.com/users/Featuretools/events{/privacy}","received_events_url":"https://api.github.com/users/Featuretools/received_events","type":"Organization","site_admin":false},"repo":{"id":102908804,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI5MDg4MDQ=","name":"featuretools","full_name":"Featuretools/featuretools","private":false,"owner":{"login":"Featuretools","id":31513623,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTEzNjIz","avatar_url":"https://avatars1.githubusercontent.com/u/31513623?v=4","gravatar_id":"","url":"https://api.github.com/users/Featuretools","html_url":"https://github.com/Featuretools","followers_url":"https://api.github.com/users/Featuretools/followers","following_url":"https://api.github.com/users/Featuretools/following{/other_user}","gists_url":"https://api.github.com/users/Featuretools/gists{/gist_id}","starred_url":"https://api.github.com/users/Featuretools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Featuretools/subscriptions","organizations_url":"https://api.github.com/users/Featuretools/orgs","repos_url":"https://api.github.com/users/Featuretools/repos","events_url":"https://api.github.com/users/Featuretools/events{/privacy}","received_events_url":"https://api.github.com/users/Featuretools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Featuretools/featuretools","description":"An open source python library for automated feature engineering","fork":false,"url":"https://api.github.com/repos/Featuretools/featuretools","forks_url":"https://api.github.com/repos/Featuretools/featuretools/forks","keys_url":"https://api.github.com/repos/Featuretools/featuretools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Featuretools/featuretools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Featuretools/featuretools/teams","hooks_url":"https://api.github.com/repos/Featuretools/featuretools/hooks","issue_events_url":"https://api.github.com/repos/Featuretools/featuretools/issues/events{/number}","events_url":"https://api.github.com/repos/Featuretools/featuretools/events","assignees_url":"https://api.github.com/repos/Featuretools/featuretools/assignees{/user}","branches_url":"https://api.github.com/repos/Featuretools/featuretools/branches{/branch}","tags_url":"https://api.github.com/repos/Featuretools/featuretools/tags","blobs_url":"https://api.github.com/repos/Featuretools/featuretools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Featuretools/featuretools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Featuretools/featuretools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Featuretools/featuretools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Featuretools/featuretools/statuses/{sha}","languages_url":"https://api.github.com/repos/Featuretools/featuretools/languages","stargazers_url":"https://api.github.com/repos/Featuretools/featuretools/stargazers","contributors_url":"https://api.github.com/repos/Featuretools/featuretools/contributors","subscribers_url":"https://api.github.com/repos/Featuretools/featuretools/subscribers","subscription_url":"https://api.github.com/repos/Featuretools/featuretools/subscription","commits_url":"https://api.github.com/repos/Featuretools/featuretools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Featuretools/featuretools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Featuretools/featuretools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Featuretools/featuretools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Featuretools/featuretools/contents/{+path}","compare_url":"https://api.github.com/repos/Featuretools/featuretools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Featuretools/featuretools/merges","archive_url":"https://api.github.com/repos/Featuretools/featuretools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Featuretools/featuretools/downloads","issues_url":"https://api.github.com/repos/Featuretools/featuretools/issues{/number}","pulls_url":"https://api.github.com/repos/Featuretools/featuretools/pulls{/number}","milestones_url":"https://api.github.com/repos/Featuretools/featuretools/milestones{/number}","notifications_url":"https://api.github.com/repos/Featuretools/featuretools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Featuretools/featuretools/labels{/name}","releases_url":"https://api.github.com/repos/Featuretools/featuretools/releases{/id}","deployments_url":"https://api.github.com/repos/Featuretools/featuretools/deployments","created_at":"2017-09-08T22:15:17Z","updated_at":"2019-09-03T19:53:11Z","pushed_at":"2019-09-03T20:51:06Z","git_url":"git://github.com/Featuretools/featuretools.git","ssh_url":"[email protected]:Featuretools/featuretools.git","clone_url":"https://github.com/Featuretools/featuretools.git","svn_url":"https://github.com/Featuretools/featuretools","homepage":"https://www.featuretools.com","size":3568,"stargazers_count":4090,"watchers_count":4090,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":515,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":90,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":515,"open_issues":90,"watchers":4090,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Featuretools/featuretools/pulls/723"},"html":{"href":"https://github.com/Featuretools/featuretools/pull/723"},"issue":{"href":"https://api.github.com/repos/Featuretools/featuretools/issues/723"},"comments":{"href":"https://api.github.com/repos/Featuretools/featuretools/issues/723/comments"},"review_comments":{"href":"https://api.github.com/repos/Featuretools/featuretools/pulls/723/comments"},"review_comment":{"href":"https://api.github.com/repos/Featuretools/featuretools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Featuretools/featuretools/pulls/723/commits"},"statuses":{"href":"https://api.github.com/repos/Featuretools/featuretools/statuses/a89be29c3e845e4144a44275b952808966d2d764"}},"author_association":"NONE"}}	{ "id": 102908804, "name": "Featuretools/featuretools", "url": "https://api.github.com/repos/Featuretools/featuretools" }	{ "id": 5392142, "login": "rwedge", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/5392142?", "url": "https://api.github.com/users/rwedge" }	{ "id": 31513623, "login": "Featuretools", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/31513623?", "url": "https://api.github.com/orgs/Featuretools" }	2019-09-03T21:07:21	10340144499	{"actor":{"display_login":"rwedge"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/emotion-js/emotion/pulls/comments/341754757","pull_request_review_id":310700444,"id":341754757,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MTc1NDc1Nw==","diff_hunk":"@@ -11,7 +10,7 @@ export type StyledOptions = {\n target?: string\n }\n \n-export type StyledComponent<P> = React.StatelessFunctionalComponent<P> & {\n+export type StyledComponent<P> = StatelessFunctionalComponent<P> & {","path":"packages/styled-base/src/utils.js","position":13,"original_position":13,"commit_id":"87ecc7863b4a984c3e3a0ff8747630c28fe38cfe","original_commit_id":"87ecc7863b4a984c3e3a0ff8747630c28fe38cfe","user":{"login":"mitchellhamilton","id":11481355,"node_id":"MDQ6VXNlcjExNDgxMzU1","avatar_url":"https://avatars1.githubusercontent.com/u/11481355?v=4","gravatar_id":"","url":"https://api.github.com/users/mitchellhamilton","html_url":"https://github.com/mitchellhamilton","followers_url":"https://api.github.com/users/mitchellhamilton/followers","following_url":"https://api.github.com/users/mitchellhamilton/following{/other_user}","gists_url":"https://api.github.com/users/mitchellhamilton/gists{/gist_id}","starred_url":"https://api.github.com/users/mitchellhamilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitchellhamilton/subscriptions","organizations_url":"https://api.github.com/users/mitchellhamilton/orgs","repos_url":"https://api.github.com/users/mitchellhamilton/repos","events_url":"https://api.github.com/users/mitchellhamilton/events{/privacy}","received_events_url":"https://api.github.com/users/mitchellhamilton/received_events","type":"User","site_admin":false},"body":"Yes","created_at":"2019-11-01T21:16:52Z","updated_at":"2019-11-01T21:16:52Z","html_url":"https://github.com/emotion-js/emotion/pull/1588#discussion_r341754757","pull_request_url":"https://api.github.com/repos/emotion-js/emotion/pulls/1588","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/emotion-js/emotion/pulls/comments/341754757"},"html":{"href":"https://github.com/emotion-js/emotion/pull/1588#discussion_r341754757"},"pull_request":{"href":"https://api.github.com/repos/emotion-js/emotion/pulls/1588"}},"in_reply_to_id":341350141},"pull_request":{"url":"https://api.github.com/repos/emotion-js/emotion/pulls/1588","id":333714326,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMzNzE0MzI2","html_url":"https://github.com/emotion-js/emotion/pull/1588","diff_url":"https://github.com/emotion-js/emotion/pull/1588.diff","patch_url":"https://github.com/emotion-js/emotion/pull/1588.patch","issue_url":"https://api.github.com/repos/emotion-js/emotion/issues/1588","number":1588,"state":"open","locked":false,"title":"Make StyledComponent polymorphic","user":{"login":"FezVrasta","id":5382443,"node_id":"MDQ6VXNlcjUzODI0NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5382443?v=4","gravatar_id":"","url":"https://api.github.com/users/FezVrasta","html_url":"https://github.com/FezVrasta","followers_url":"https://api.github.com/users/FezVrasta/followers","following_url":"https://api.github.com/users/FezVrasta/following{/other_user}","gists_url":"https://api.github.com/users/FezVrasta/gists{/gist_id}","starred_url":"https://api.github.com/users/FezVrasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FezVrasta/subscriptions","organizations_url":"https://api.github.com/users/FezVrasta/orgs","repos_url":"https://api.github.com/users/FezVrasta/repos","events_url":"https://api.github.com/users/FezVrasta/events{/privacy}","received_events_url":"https://api.github.com/users/FezVrasta/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for your interest in the project. I appreciate bugs filed and PRs submitted!\r\n\r\nPlease make sure that you are familiar with and follow the Code of Conduct for\r\nthis project (found in the CODE_OF_CONDUCT.md file).\r\n\r\nAlso, please make sure you're familiar with and follow the instructions in the\r\ncontributing guidelines (found in the CONTRIBUTING.md file).\r\n\r\nIf you're new to contributing to open source projects, you might find this free\r\nvideo course helpful: http://kcd.im/pull-request\r\n\r\nPlease fill out the information below to expedite the review and (hopefully)\r\nmerge of your pull request!\r\n-->\r\n\r\n<!-- What changes are being made? (What feature/bug is being fixed here?) -->\r\nWhat:\r\n\r\nimplements/fixes #1587\r\n\r\n<!-- Why are these changes necessary? -->\r\nWhy:\r\n\r\nread #1587\r\n\r\n<!-- How were these changes implemented? -->\r\nHow:\r\n\r\n`StyledComponent` is now polymorphic (just for the `CreateStyled` function)\r\n\r\n<!-- Have you done all of these things? -->\r\nChecklist:\r\n<!-- add \"N/A\" to the end of each line that's irrelevant to your changes -->\r\n<!-- to check an item, place an \"x\" in the box like so: \"- [x] Documentation\" -->\r\n- [x] Documentation\r\n- [x] Tests\r\n- [x] Code complete\r\n- [x] Changeset <!-- This is necessary if your changes should release any packages. Run `yarn changeset` to create a changeset -->\r\n\r\n\r\n<!-- feel free to add additional comments -->\r\n","created_at":"2019-10-29T16:02:23Z","updated_at":"2019-11-01T21:16:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73d7406a3557a2cd94e3e883bae74b7ac18bfad4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Andarist","id":9800850,"node_id":"MDQ6VXNlcjk4MDA4NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/9800850?v=4","gravatar_id":"","url":"https://api.github.com/users/Andarist","html_url":"https://github.com/Andarist","followers_url":"https://api.github.com/users/Andarist/followers","following_url":"https://api.github.com/users/Andarist/following{/other_user}","gists_url":"https://api.github.com/users/Andarist/gists{/gist_id}","starred_url":"https://api.github.com/users/Andarist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Andarist/subscriptions","organizations_url":"https://api.github.com/users/Andarist/orgs","repos_url":"https://api.github.com/users/Andarist/repos","events_url":"https://api.github.com/users/Andarist/events{/privacy}","received_events_url":"https://api.github.com/users/Andarist/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/emotion-js/emotion/pulls/1588/commits","review_comments_url":"https://api.github.com/repos/emotion-js/emotion/pulls/1588/comments","review_comment_url":"https://api.github.com/repos/emotion-js/emotion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emotion-js/emotion/issues/1588/comments","statuses_url":"https://api.github.com/repos/emotion-js/emotion/statuses/87ecc7863b4a984c3e3a0ff8747630c28fe38cfe","head":{"label":"FezVrasta:fix/flow-type-improvements","ref":"fix/flow-type-improvements","sha":"87ecc7863b4a984c3e3a0ff8747630c28fe38cfe","user":{"login":"FezVrasta","id":5382443,"node_id":"MDQ6VXNlcjUzODI0NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5382443?v=4","gravatar_id":"","url":"https://api.github.com/users/FezVrasta","html_url":"https://github.com/FezVrasta","followers_url":"https://api.github.com/users/FezVrasta/followers","following_url":"https://api.github.com/users/FezVrasta/following{/other_user}","gists_url":"https://api.github.com/users/FezVrasta/gists{/gist_id}","starred_url":"https://api.github.com/users/FezVrasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FezVrasta/subscriptions","organizations_url":"https://api.github.com/users/FezVrasta/orgs","repos_url":"https://api.github.com/users/FezVrasta/repos","events_url":"https://api.github.com/users/FezVrasta/events{/privacy}","received_events_url":"https://api.github.com/users/FezVrasta/received_events","type":"User","site_admin":false},"repo":{"id":160834018,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA4MzQwMTg=","name":"emotion","full_name":"FezVrasta/emotion","private":false,"owner":{"login":"FezVrasta","id":5382443,"node_id":"MDQ6VXNlcjUzODI0NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/5382443?v=4","gravatar_id":"","url":"https://api.github.com/users/FezVrasta","html_url":"https://github.com/FezVrasta","followers_url":"https://api.github.com/users/FezVrasta/followers","following_url":"https://api.github.com/users/FezVrasta/following{/other_user}","gists_url":"https://api.github.com/users/FezVrasta/gists{/gist_id}","starred_url":"https://api.github.com/users/FezVrasta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FezVrasta/subscriptions","organizations_url":"https://api.github.com/users/FezVrasta/orgs","repos_url":"https://api.github.com/users/FezVrasta/repos","events_url":"https://api.github.com/users/FezVrasta/events{/privacy}","received_events_url":"https://api.github.com/users/FezVrasta/received_events","type":"User","site_admin":false},"html_url":"https://github.com/FezVrasta/emotion","description":"style as a function of state","fork":true,"url":"https://api.github.com/repos/FezVrasta/emotion","forks_url":"https://api.github.com/repos/FezVrasta/emotion/forks","keys_url":"https://api.github.com/repos/FezVrasta/emotion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FezVrasta/emotion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FezVrasta/emotion/teams","hooks_url":"https://api.github.com/repos/FezVrasta/emotion/hooks","issue_events_url":"https://api.github.com/repos/FezVrasta/emotion/issues/events{/number}","events_url":"https://api.github.com/repos/FezVrasta/emotion/events","assignees_url":"https://api.github.com/repos/FezVrasta/emotion/assignees{/user}","branches_url":"https://api.github.com/repos/FezVrasta/emotion/branches{/branch}","tags_url":"https://api.github.com/repos/FezVrasta/emotion/tags","blobs_url":"https://api.github.com/repos/FezVrasta/emotion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FezVrasta/emotion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FezVrasta/emotion/git/refs{/sha}","trees_url":"https://api.github.com/repos/FezVrasta/emotion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FezVrasta/emotion/statuses/{sha}","languages_url":"https://api.github.com/repos/FezVrasta/emotion/languages","stargazers_url":"https://api.github.com/repos/FezVrasta/emotion/stargazers","contributors_url":"https://api.github.com/repos/FezVrasta/emotion/contributors","subscribers_url":"https://api.github.com/repos/FezVrasta/emotion/subscribers","subscription_url":"https://api.github.com/repos/FezVrasta/emotion/subscription","commits_url":"https://api.github.com/repos/FezVrasta/emotion/commits{/sha}","git_commits_url":"https://api.github.com/repos/FezVrasta/emotion/git/commits{/sha}","comments_url":"https://api.github.com/repos/FezVrasta/emotion/comments{/number}","issue_comment_url":"https://api.github.com/repos/FezVrasta/emotion/issues/comments{/number}","contents_url":"https://api.github.com/repos/FezVrasta/emotion/contents/{+path}","compare_url":"https://api.github.com/repos/FezVrasta/emotion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FezVrasta/emotion/merges","archive_url":"https://api.github.com/repos/FezVrasta/emotion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FezVrasta/emotion/downloads","issues_url":"https://api.github.com/repos/FezVrasta/emotion/issues{/number}","pulls_url":"https://api.github.com/repos/FezVrasta/emotion/pulls{/number}","milestones_url":"https://api.github.com/repos/FezVrasta/emotion/milestones{/number}","notifications_url":"https://api.github.com/repos/FezVrasta/emotion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FezVrasta/emotion/labels{/name}","releases_url":"https://api.github.com/repos/FezVrasta/emotion/releases{/id}","deployments_url":"https://api.github.com/repos/FezVrasta/emotion/deployments","created_at":"2018-12-07T14:28:02Z","updated_at":"2019-07-09T11:30:38Z","pushed_at":"2019-11-01T00:48:06Z","git_url":"git://github.com/FezVrasta/emotion.git","ssh_url":"[email protected]:FezVrasta/emotion.git","clone_url":"https://github.com/FezVrasta/emotion.git","svn_url":"https://github.com/FezVrasta/emotion","homepage":"https://emotion.sh/","size":11521,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emotion-js:master","ref":"master","sha":"ed0a460a4f5c58ccf56c27c8a11d85a507c85055","user":{"login":"emotion-js","id":31557565,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTU3NTY1","avatar_url":"https://avatars0.githubusercontent.com/u/31557565?v=4","gravatar_id":"","url":"https://api.github.com/users/emotion-js","html_url":"https://github.com/emotion-js","followers_url":"https://api.github.com/users/emotion-js/followers","following_url":"https://api.github.com/users/emotion-js/following{/other_user}","gists_url":"https://api.github.com/users/emotion-js/gists{/gist_id}","starred_url":"https://api.github.com/users/emotion-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emotion-js/subscriptions","organizations_url":"https://api.github.com/users/emotion-js/orgs","repos_url":"https://api.github.com/users/emotion-js/repos","events_url":"https://api.github.com/users/emotion-js/events{/privacy}","received_events_url":"https://api.github.com/users/emotion-js/received_events","type":"Organization","site_admin":false},"repo":{"id":92570536,"node_id":"MDEwOlJlcG9zaXRvcnk5MjU3MDUzNg==","name":"emotion","full_name":"emotion-js/emotion","private":false,"owner":{"login":"emotion-js","id":31557565,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTU3NTY1","avatar_url":"https://avatars0.githubusercontent.com/u/31557565?v=4","gravatar_id":"","url":"https://api.github.com/users/emotion-js","html_url":"https://github.com/emotion-js","followers_url":"https://api.github.com/users/emotion-js/followers","following_url":"https://api.github.com/users/emotion-js/following{/other_user}","gists_url":"https://api.github.com/users/emotion-js/gists{/gist_id}","starred_url":"https://api.github.com/users/emotion-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emotion-js/subscriptions","organizations_url":"https://api.github.com/users/emotion-js/orgs","repos_url":"https://api.github.com/users/emotion-js/repos","events_url":"https://api.github.com/users/emotion-js/events{/privacy}","received_events_url":"https://api.github.com/users/emotion-js/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/emotion-js/emotion","description":"👩‍🎤 CSS-in-JS library designed for high performance style composition","fork":false,"url":"https://api.github.com/repos/emotion-js/emotion","forks_url":"https://api.github.com/repos/emotion-js/emotion/forks","keys_url":"https://api.github.com/repos/emotion-js/emotion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emotion-js/emotion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emotion-js/emotion/teams","hooks_url":"https://api.github.com/repos/emotion-js/emotion/hooks","issue_events_url":"https://api.github.com/repos/emotion-js/emotion/issues/events{/number}","events_url":"https://api.github.com/repos/emotion-js/emotion/events","assignees_url":"https://api.github.com/repos/emotion-js/emotion/assignees{/user}","branches_url":"https://api.github.com/repos/emotion-js/emotion/branches{/branch}","tags_url":"https://api.github.com/repos/emotion-js/emotion/tags","blobs_url":"https://api.github.com/repos/emotion-js/emotion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emotion-js/emotion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emotion-js/emotion/git/refs{/sha}","trees_url":"https://api.github.com/repos/emotion-js/emotion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emotion-js/emotion/statuses/{sha}","languages_url":"https://api.github.com/repos/emotion-js/emotion/languages","stargazers_url":"https://api.github.com/repos/emotion-js/emotion/stargazers","contributors_url":"https://api.github.com/repos/emotion-js/emotion/contributors","subscribers_url":"https://api.github.com/repos/emotion-js/emotion/subscribers","subscription_url":"https://api.github.com/repos/emotion-js/emotion/subscription","commits_url":"https://api.github.com/repos/emotion-js/emotion/commits{/sha}","git_commits_url":"https://api.github.com/repos/emotion-js/emotion/git/commits{/sha}","comments_url":"https://api.github.com/repos/emotion-js/emotion/comments{/number}","issue_comment_url":"https://api.github.com/repos/emotion-js/emotion/issues/comments{/number}","contents_url":"https://api.github.com/repos/emotion-js/emotion/contents/{+path}","compare_url":"https://api.github.com/repos/emotion-js/emotion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emotion-js/emotion/merges","archive_url":"https://api.github.com/repos/emotion-js/emotion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emotion-js/emotion/downloads","issues_url":"https://api.github.com/repos/emotion-js/emotion/issues{/number}","pulls_url":"https://api.github.com/repos/emotion-js/emotion/pulls{/number}","milestones_url":"https://api.github.com/repos/emotion-js/emotion/milestones{/number}","notifications_url":"https://api.github.com/repos/emotion-js/emotion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emotion-js/emotion/labels{/name}","releases_url":"https://api.github.com/repos/emotion-js/emotion/releases{/id}","deployments_url":"https://api.github.com/repos/emotion-js/emotion/deployments","created_at":"2017-05-27T04:23:45Z","updated_at":"2019-11-01T19:42:08Z","pushed_at":"2019-11-01T11:19:01Z","git_url":"git://github.com/emotion-js/emotion.git","ssh_url":"[email protected]:emotion-js/emotion.git","clone_url":"https://github.com/emotion-js/emotion.git","svn_url":"https://github.com/emotion-js/emotion","homepage":"https://emotion.sh/","size":11763,"stargazers_count":9221,"watchers_count":9221,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":595,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":121,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":595,"open_issues":121,"watchers":9221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emotion-js/emotion/pulls/1588"},"html":{"href":"https://github.com/emotion-js/emotion/pull/1588"},"issue":{"href":"https://api.github.com/repos/emotion-js/emotion/issues/1588"},"comments":{"href":"https://api.github.com/repos/emotion-js/emotion/issues/1588/comments"},"review_comments":{"href":"https://api.github.com/repos/emotion-js/emotion/pulls/1588/comments"},"review_comment":{"href":"https://api.github.com/repos/emotion-js/emotion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emotion-js/emotion/pulls/1588/commits"},"statuses":{"href":"https://api.github.com/repos/emotion-js/emotion/statuses/87ecc7863b4a984c3e3a0ff8747630c28fe38cfe"}},"author_association":"COLLABORATOR"}}	{ "id": 92570536, "name": "emotion-js/emotion", "url": "https://api.github.com/repos/emotion-js/emotion" }	{ "id": 11481355, "login": "mitchellhamilton", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/11481355?", "url": "https://api.github.com/users/mitchellhamilton" }	{ "id": 31557565, "login": "emotion-js", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/31557565?", "url": "https://api.github.com/orgs/emotion-js" }	2019-11-01T21:16:52	10769649846	{"actor":{"display_login":"mitchellhamilton"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/switchbrew/libnx/pulls/comments/260165344","pull_request_review_id":207807592,"id":260165344,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MDE2NTM0NA==","diff_hunk":"@@ -0,0 +1,183 @@\n+#include <string.h>\n+#include \"types.h\"\n+#include \"result.h\"\n+#include \"arm/atomics.h\"\n+#include \"kernel/ipc.h\"\n+#include \"kernel/shmem.h\"\n+#include \"kernel/rwlock.h\"\n+#include \"kernel/event.h\"\n+#include \"services/applet.h\"\n+#include \"services/hidsys.h\"\n+#include \"services/sm.h\"\n+\n+static Service g_hidsysSrv;\n+static u64 g_hidsysRefCnt;\n+\n+static u64 g_hidsysAppletResourceUserId = 0;\n+\n+Result hidsysInitialize(void) {\n+ atomicIncrement64(&g_hidsysRefCnt);\n+ \n+ if (serviceIsActive(&g_hidsysSrv)) \n+ return 0;\n+ \n+ Result rc = smGetService(&g_hidsysSrv, \"hid:sys\");\n+ if (R_FAILED(rc))\n+ return rc;\n+ \n+ rc = appletGetAppletResourceUserId(&g_hidsysAppletResourceUserId);\n+ if (R_FAILED(rc))\n+ g_hidsysAppletResourceUserId = 0;\n+\n+ return 0; \n+}\n+\n+void hidsysExit(void) {\n+ if (atomicDecrement64(&g_hidsysRefCnt) == 0) { \n+ serviceClose(&g_hidsysSrv);\n+ }\n+}\n+\n+Result hidsysEnableAppletToGetInput(bool enable) { \n+ IpcCommand c;\n+ ipcInitialize(&c);\n+\n+ struct {\n+ u64 magic;\n+ u64 cmdid;\n+ u8 permitInput;\n+ u64 appletResourceUserId;\n+ } raw;\n+\n+ raw = serviceIpcPrepareHeader(&g_hidsysSrv, &c, sizeof(raw));\n+\n+ raw->magic = SFCI_MAGIC;\n+ raw->cmdid = 503;\n+ raw->permitInput = enable != 0;\n+ raw->appletResourceUserId = g_hidsysAppletResourceUserId;\n+\n+ Result rc = serviceIpcDispatch(&g_hidsysSrv);\n+\n+ if (R_SUCCEEDED(rc)) {\n+ IpcParsedCommand r;\n+ struct {\n+ u64 magic;\n+ u64 result;\n+ } resp;\n+\n+ serviceIpcParse(&g_hidsysSrv, &r, sizeof(resp));\n+ resp = r.Raw;\n+\n+ rc = resp->result;\n+ }\n+\n+ return rc;\n+}\n+\n+static Result _hidsysCmdWithResIdAndPid(u64 cmd_id) {\n+ IpcCommand c;\n+ ipcInitialize(&c);\n+\n+ struct {\n+ u64 magic;\n+ u64 cmd_id;\n+ u64 AppletResourceUserId;\n+ } raw;\n+\n+ ipcSendPid(&c);\n+ raw = serviceIpcPrepareHeader(&g_hidsysSrv, &c, sizeof(raw));\n+\n+ raw->magic = SFCI_MAGIC;\n+ raw->cmd_id = cmd_id;\n+ raw->AppletResourceUserId = g_hidsysAppletResourceUserId;\n+\n+ Result rc = serviceIpcDispatch(&g_hidsysSrv);\n+\n+ if (R_SUCCEEDED(rc)) {\n+ IpcParsedCommand r;\n+ struct {\n+ u64 magic;\n+ u64 result;\n+ } resp;\n+\n+ serviceIpcParse(&g_hidsysSrv, &r, sizeof(resp));\n+ resp = r.Raw;\n+\n+ rc = resp->result;\n+ }\n+\n+ return rc;\n+}\n+\n+static Result _hidsysGetHandle(Handle* handle_out, u64 cmd_id) { \n+ IpcCommand c;\n+ ipcInitialize(&c);\n+\n+ struct {\n+ u64 magic;\n+ u64 cmd_id;\n+ u64 AppletResourceUserId;\n+ } raw;\n+\n+ ipcSendPid(&c);\n+ raw = serviceIpcPrepareHeader(&g_hidsysSrv, &c, sizeof(raw));\n+\n+ raw->magic = SFCI_MAGIC;\n+ raw->cmd_id = cmd_id;\n+ raw->AppletResourceUserId = g_hidsysAppletResourceUserId;\n+\n+ Result rc = serviceIpcDispatch(&g_hidsysSrv);\n+\n+ if (R_SUCCEEDED(rc)) {\n+ IpcParsedCommand r;\n+ struct {\n+ u64 magic;\n+ u64 result;\n+ } resp;\n+\n+ serviceIpcParse(&g_hidsysSrv, &r, sizeof(resp));\n+ resp = r.Raw;\n+\n+ rc = resp->result;\n+\n+ if (R_SUCCEEDED(rc)) {\n+ handle_out = r.Handles[0];\n+ }\n+ }\n+\n+ return rc;\n+}\n+\n+static Result _hidsysGetEvent(Event event_out, u64 cmd_id, bool autoclear) {\n+ Handle tmp_handle=0;\n+ Result rc = 0;\n+\n+ rc = _hidsysGetHandle(&tmp_handle, cmd_id);\n+ if (R_SUCCEEDED(rc)) eventLoadRemote(event_out, tmp_handle, autoclear);\n+ return rc;\n+}\n+\n+Result hidsysAcquireHomeButtonEventHandle(Event* event_out) {\n+ return _hidsysGetEvent(event_out, 101, false);\n+}\n+\n+//These functions don't seem to work in the overlaydisp applet context\n+Result hidsysAcquireCaptureButtonEventHandle(Event* event_out) {\n+ return _hidsysGetEvent(event_out, 141, false);\n+}\n+\n+Result hidsysAcquireSleepButtonEventHandle(Event* event_out) {\n+ return _hidsysGetEvent(event_out, 121, false);\n+}\n+\n+Result hidsysActivateHomeButton(void) {","path":"nx/source/services/hidsys.c","position":173,"original_position":173,"commit_id":"13e9da39627ea66d72397fd34cc200509fd0be13","original_commit_id":"13e9da39627ea66d72397fd34cc200509fd0be13","user":{"login":"yellows8","id":585494,"node_id":"MDQ6VXNlcjU4NTQ5NA==","avatar_url":"https://avatars0.githubusercontent.com/u/585494?v=4","gravatar_id":"","url":"https://api.github.com/users/yellows8","html_url":"https://github.com/yellows8","followers_url":"https://api.github.com/users/yellows8/followers","following_url":"https://api.github.com/users/yellows8/following{/other_user}","gists_url":"https://api.github.com/users/yellows8/gists{/gist_id}","starred_url":"https://api.github.com/users/yellows8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yellows8/subscriptions","organizations_url":"https://api.github.com/users/yellows8/orgs","repos_url":"https://api.github.com/users/yellows8/repos","events_url":"https://api.github.com/users/yellows8/events{/privacy}","received_events_url":"https://api.github.com/users/yellows8/received_events","type":"User","site_admin":false},"body":"Add these to the .h.","created_at":"2019-02-26T08:04:55Z","updated_at":"2019-02-26T08:04:56Z","html_url":"https://github.com/switchbrew/libnx/pull/242#discussion_r260165344","pull_request_url":"https://api.github.com/repos/switchbrew/libnx/pulls/242","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/switchbrew/libnx/pulls/comments/260165344"},"html":{"href":"https://github.com/switchbrew/libnx/pull/242#discussion_r260165344"},"pull_request":{"href":"https://api.github.com/repos/switchbrew/libnx/pulls/242"}}},"pull_request":{"url":"https://api.github.com/repos/switchbrew/libnx/pulls/242","id":255645434,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1NjQ1NDM0","html_url":"https://github.com/switchbrew/libnx/pull/242","diff_url":"https://github.com/switchbrew/libnx/pull/242.diff","patch_url":"https://github.com/switchbrew/libnx/pull/242.patch","issue_url":"https://api.github.com/repos/switchbrew/libnx/issues/242","number":242,"state":"open","locked":false,"title":"Add some functions from IOverlayAppletProxy and hid:sys","user":{"login":"exelix11","id":13405476,"node_id":"MDQ6VXNlcjEzNDA1NDc2","avatar_url":"https://avatars3.githubusercontent.com/u/13405476?v=4","gravatar_id":"","url":"https://api.github.com/users/exelix11","html_url":"https://github.com/exelix11","followers_url":"https://api.github.com/users/exelix11/followers","following_url":"https://api.github.com/users/exelix11/following{/other_user}","gists_url":"https://api.github.com/users/exelix11/gists{/gist_id}","starred_url":"https://api.github.com/users/exelix11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exelix11/subscriptions","organizations_url":"https://api.github.com/users/exelix11/orgs","repos_url":"https://api.github.com/users/exelix11/repos","events_url":"https://api.github.com/users/exelix11/events{/privacy}","received_events_url":"https://api.github.com/users/exelix11/received_events","type":"User","site_admin":false},"body":"I'm working on a custom overlay applet replacement, this implements some calls that provide functions specific to this system applet. All the functions in the headers are tested and working.","created_at":"2019-02-23T22:47:19Z","updated_at":"2019-02-26T08:04:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2380db08d023ab5f6760e37457a264830bc2cea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/switchbrew/libnx/pulls/242/commits","review_comments_url":"https://api.github.com/repos/switchbrew/libnx/pulls/242/comments","review_comment_url":"https://api.github.com/repos/switchbrew/libnx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/switchbrew/libnx/issues/242/comments","statuses_url":"https://api.github.com/repos/switchbrew/libnx/statuses/13e9da39627ea66d72397fd34cc200509fd0be13","head":{"label":"exelix11:master","ref":"master","sha":"13e9da39627ea66d72397fd34cc200509fd0be13","user":{"login":"exelix11","id":13405476,"node_id":"MDQ6VXNlcjEzNDA1NDc2","avatar_url":"https://avatars3.githubusercontent.com/u/13405476?v=4","gravatar_id":"","url":"https://api.github.com/users/exelix11","html_url":"https://github.com/exelix11","followers_url":"https://api.github.com/users/exelix11/followers","following_url":"https://api.github.com/users/exelix11/following{/other_user}","gists_url":"https://api.github.com/users/exelix11/gists{/gist_id}","starred_url":"https://api.github.com/users/exelix11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exelix11/subscriptions","organizations_url":"https://api.github.com/users/exelix11/orgs","repos_url":"https://api.github.com/users/exelix11/repos","events_url":"https://api.github.com/users/exelix11/events{/privacy}","received_events_url":"https://api.github.com/users/exelix11/received_events","type":"User","site_admin":false},"repo":{"id":172137231,"node_id":"MDEwOlJlcG9zaXRvcnkxNzIxMzcyMzE=","name":"libnx","full_name":"exelix11/libnx","private":false,"owner":{"login":"exelix11","id":13405476,"node_id":"MDQ6VXNlcjEzNDA1NDc2","avatar_url":"https://avatars3.githubusercontent.com/u/13405476?v=4","gravatar_id":"","url":"https://api.github.com/users/exelix11","html_url":"https://github.com/exelix11","followers_url":"https://api.github.com/users/exelix11/followers","following_url":"https://api.github.com/users/exelix11/following{/other_user}","gists_url":"https://api.github.com/users/exelix11/gists{/gist_id}","starred_url":"https://api.github.com/users/exelix11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exelix11/subscriptions","organizations_url":"https://api.github.com/users/exelix11/orgs","repos_url":"https://api.github.com/users/exelix11/repos","events_url":"https://api.github.com/users/exelix11/events{/privacy}","received_events_url":"https://api.github.com/users/exelix11/received_events","type":"User","site_admin":false},"html_url":"https://github.com/exelix11/libnx","description":"Library for Switch Homebrew","fork":true,"url":"https://api.github.com/repos/exelix11/libnx","forks_url":"https://api.github.com/repos/exelix11/libnx/forks","keys_url":"https://api.github.com/repos/exelix11/libnx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exelix11/libnx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exelix11/libnx/teams","hooks_url":"https://api.github.com/repos/exelix11/libnx/hooks","issue_events_url":"https://api.github.com/repos/exelix11/libnx/issues/events{/number}","events_url":"https://api.github.com/repos/exelix11/libnx/events","assignees_url":"https://api.github.com/repos/exelix11/libnx/assignees{/user}","branches_url":"https://api.github.com/repos/exelix11/libnx/branches{/branch}","tags_url":"https://api.github.com/repos/exelix11/libnx/tags","blobs_url":"https://api.github.com/repos/exelix11/libnx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exelix11/libnx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exelix11/libnx/git/refs{/sha}","trees_url":"https://api.github.com/repos/exelix11/libnx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exelix11/libnx/statuses/{sha}","languages_url":"https://api.github.com/repos/exelix11/libnx/languages","stargazers_url":"https://api.github.com/repos/exelix11/libnx/stargazers","contributors_url":"https://api.github.com/repos/exelix11/libnx/contributors","subscribers_url":"https://api.github.com/repos/exelix11/libnx/subscribers","subscription_url":"https://api.github.com/repos/exelix11/libnx/subscription","commits_url":"https://api.github.com/repos/exelix11/libnx/commits{/sha}","git_commits_url":"https://api.github.com/repos/exelix11/libnx/git/commits{/sha}","comments_url":"https://api.github.com/repos/exelix11/libnx/comments{/number}","issue_comment_url":"https://api.github.com/repos/exelix11/libnx/issues/comments{/number}","contents_url":"https://api.github.com/repos/exelix11/libnx/contents/{+path}","compare_url":"https://api.github.com/repos/exelix11/libnx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exelix11/libnx/merges","archive_url":"https://api.github.com/repos/exelix11/libnx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exelix11/libnx/downloads","issues_url":"https://api.github.com/repos/exelix11/libnx/issues{/number}","pulls_url":"https://api.github.com/repos/exelix11/libnx/pulls{/number}","milestones_url":"https://api.github.com/repos/exelix11/libnx/milestones{/number}","notifications_url":"https://api.github.com/repos/exelix11/libnx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exelix11/libnx/labels{/name}","releases_url":"https://api.github.com/repos/exelix11/libnx/releases{/id}","deployments_url":"https://api.github.com/repos/exelix11/libnx/deployments","created_at":"2019-02-22T21:30:28Z","updated_at":"2019-02-26T06:54:50Z","pushed_at":"2019-02-26T06:54:48Z","git_url":"git://github.com/exelix11/libnx.git","ssh_url":"[email protected]:exelix11/libnx.git","clone_url":"https://github.com/exelix11/libnx.git","svn_url":"https://github.com/exelix11/libnx","homepage":"https://switchbrew.github.io/libnx/","size":2928,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"switchbrew:master","ref":"master","sha":"4b8e501fdb0b6f4c98fc62543d7ecebbb98e0374","user":{"login":"switchbrew","id":31827450,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODI3NDUw","avatar_url":"https://avatars3.githubusercontent.com/u/31827450?v=4","gravatar_id":"","url":"https://api.github.com/users/switchbrew","html_url":"https://github.com/switchbrew","followers_url":"https://api.github.com/users/switchbrew/followers","following_url":"https://api.github.com/users/switchbrew/following{/other_user}","gists_url":"https://api.github.com/users/switchbrew/gists{/gist_id}","starred_url":"https://api.github.com/users/switchbrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/switchbrew/subscriptions","organizations_url":"https://api.github.com/users/switchbrew/orgs","repos_url":"https://api.github.com/users/switchbrew/repos","events_url":"https://api.github.com/users/switchbrew/events{/privacy}","received_events_url":"https://api.github.com/users/switchbrew/received_events","type":"Organization","site_admin":false},"repo":{"id":103794142,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM3OTQxNDI=","name":"libnx","full_name":"switchbrew/libnx","private":false,"owner":{"login":"switchbrew","id":31827450,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODI3NDUw","avatar_url":"https://avatars3.githubusercontent.com/u/31827450?v=4","gravatar_id":"","url":"https://api.github.com/users/switchbrew","html_url":"https://github.com/switchbrew","followers_url":"https://api.github.com/users/switchbrew/followers","following_url":"https://api.github.com/users/switchbrew/following{/other_user}","gists_url":"https://api.github.com/users/switchbrew/gists{/gist_id}","starred_url":"https://api.github.com/users/switchbrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/switchbrew/subscriptions","organizations_url":"https://api.github.com/users/switchbrew/orgs","repos_url":"https://api.github.com/users/switchbrew/repos","events_url":"https://api.github.com/users/switchbrew/events{/privacy}","received_events_url":"https://api.github.com/users/switchbrew/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/switchbrew/libnx","description":"Library for Switch Homebrew","fork":false,"url":"https://api.github.com/repos/switchbrew/libnx","forks_url":"https://api.github.com/repos/switchbrew/libnx/forks","keys_url":"https://api.github.com/repos/switchbrew/libnx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/switchbrew/libnx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/switchbrew/libnx/teams","hooks_url":"https://api.github.com/repos/switchbrew/libnx/hooks","issue_events_url":"https://api.github.com/repos/switchbrew/libnx/issues/events{/number}","events_url":"https://api.github.com/repos/switchbrew/libnx/events","assignees_url":"https://api.github.com/repos/switchbrew/libnx/assignees{/user}","branches_url":"https://api.github.com/repos/switchbrew/libnx/branches{/branch}","tags_url":"https://api.github.com/repos/switchbrew/libnx/tags","blobs_url":"https://api.github.com/repos/switchbrew/libnx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/switchbrew/libnx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/switchbrew/libnx/git/refs{/sha}","trees_url":"https://api.github.com/repos/switchbrew/libnx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/switchbrew/libnx/statuses/{sha}","languages_url":"https://api.github.com/repos/switchbrew/libnx/languages","stargazers_url":"https://api.github.com/repos/switchbrew/libnx/stargazers","contributors_url":"https://api.github.com/repos/switchbrew/libnx/contributors","subscribers_url":"https://api.github.com/repos/switchbrew/libnx/subscribers","subscription_url":"https://api.github.com/repos/switchbrew/libnx/subscription","commits_url":"https://api.github.com/repos/switchbrew/libnx/commits{/sha}","git_commits_url":"https://api.github.com/repos/switchbrew/libnx/git/commits{/sha}","comments_url":"https://api.github.com/repos/switchbrew/libnx/comments{/number}","issue_comment_url":"https://api.github.com/repos/switchbrew/libnx/issues/comments{/number}","contents_url":"https://api.github.com/repos/switchbrew/libnx/contents/{+path}","compare_url":"https://api.github.com/repos/switchbrew/libnx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/switchbrew/libnx/merges","archive_url":"https://api.github.com/repos/switchbrew/libnx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/switchbrew/libnx/downloads","issues_url":"https://api.github.com/repos/switchbrew/libnx/issues{/number}","pulls_url":"https://api.github.com/repos/switchbrew/libnx/pulls{/number}","milestones_url":"https://api.github.com/repos/switchbrew/libnx/milestones{/number}","notifications_url":"https://api.github.com/repos/switchbrew/libnx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/switchbrew/libnx/labels{/name}","releases_url":"https://api.github.com/repos/switchbrew/libnx/releases{/id}","deployments_url":"https://api.github.com/repos/switchbrew/libnx/deployments","created_at":"2017-09-17T01:12:38Z","updated_at":"2019-02-26T04:24:51Z","pushed_at":"2019-02-26T06:54:50Z","git_url":"git://github.com/switchbrew/libnx.git","ssh_url":"[email protected]:switchbrew/libnx.git","clone_url":"https://github.com/switchbrew/libnx.git","svn_url":"https://github.com/switchbrew/libnx","homepage":"https://switchbrew.github.io/libnx/","size":2923,"stargazers_count":568,"watchers_count":568,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":90,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":90,"open_issues":5,"watchers":568,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/switchbrew/libnx/pulls/242"},"html":{"href":"https://github.com/switchbrew/libnx/pull/242"},"issue":{"href":"https://api.github.com/repos/switchbrew/libnx/issues/242"},"comments":{"href":"https://api.github.com/repos/switchbrew/libnx/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/switchbrew/libnx/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/switchbrew/libnx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/switchbrew/libnx/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/switchbrew/libnx/statuses/13e9da39627ea66d72397fd34cc200509fd0be13"}},"author_association":"NONE"}}	{ "id": 103794142, "name": "switchbrew/libnx", "url": "https://api.github.com/repos/switchbrew/libnx" }	{ "id": 585494, "login": "yellows8", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/585494?", "url": "https://api.github.com/users/yellows8" }	{ "id": 31827450, "login": "switchbrew", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/31827450?", "url": "https://api.github.com/orgs/switchbrew" }	2019-02-26T08:04:55	9136389472	{"actor":{"display_login":"yellows8"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/XanaduAI/strawberryfields/pulls/comments/324433818","pull_request_review_id":288330523,"id":324433818,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNDQzMzgxOA==","diff_hunk":"@@ -19,335 +19,334 @@\n \n .. currentmodule:: strawberryfields.parameters\n \n-The :class:`Parameter` class encapsulates a parameter passed to the\n+The classes in this module encapsulate parameters passed to the\n quantum operations represented by :class:`.Operation`.\n-The parameter objects can represent a\n-\n-* number\n-* NumPy array\n-* value measured from the quantum register (:class:`.RegRefTransform`)\n-* TensorFlow object (:class:`tf.Variable` or :code:`tf.placeholder`)\n-\n-\n-The normal lifecycle of an Operation object and its associated Parameter instances is as follows:\n+There are three basic types of parameters:\n+\n+1. Numerical parameters (bound and fixed): An immediate, immutable numerical object\n+ (float, complex, int, array).\n+ NOTE: currently implemented as-is, not encapsulated in a class. This can be changed if necessary,\n+ in which case most of the top-level functions in this module would become Parameter methods.\n+2. Measured parameters (bound but not fixed): Certain quantum circuits/protocols require that\n+ Operations can be conditioned on measurement results obtained during the execution of the\n+ circuit. In this case the parameter value is not known/fixed until the measurement is made\n+ (or simulated). Represented by :class:`MeasuredParameter` instances.\n+ Constructed from the :class:`RegRef` instance storing the measurement\n+ result using the :meth:`RegRef.par` method.\n+3. Free parameters (not bound nor fixed): A parametrized circuit template is a circuit that\n+ depends on a number of unbound (free) parameters. These parameters need to be bound to fixed\n+ numerical values before the circuit can be executed on a hardware quantum device or a numeric\n+ simulator. Represented by :class:`FreeParameter` instances.\n+ Simulators with symbolic capability can accept a parametrized circuit as input (and should\n+ return symbolic expressions representing the measurement results, with the same free parameters,\n+ as output).\n+ Free parameters belong to a single :class:`Program` instance, are constructed using the\n+ :meth:`Program.args` method, and are bound using :meth:`Program.bind_args`.\n+\n+The Operations can accept parameters that are functions or algebraic combinations of any number of\n+these basic types of parameters, made possible by the measured and free parameters inheriting\n+:class:`sympy.Symbol`.\n+Binary arithmetic operations between sympy symbols and numpy arrays produces numpy object arrays\n+containing sympy symbols.\n+\n+\n+The normal lifecycle of an Operation object and its associated parameters is as follows:\n \n * An Operation instance is constructed, and given some input arguments.\n-\n-* :meth:`.Operation.__init__` converts the inputs into Parameter instances.\n- Plain :class:`.RegRef` instances are wrapped in a trivial :class:`.RegRefTransform`.\n- RegRefTransforms add their RegRef dependencies to the Parameter and consequently to the Operation.\n+ In :meth:`.Operation.__init__`,\n+ the RegRef dependencies of measured parameters are added to :attr:`Operation._measurement_deps`.\n \n * The Operation instance is applied using its :meth:`~ops.Operation.__or__`\n- method inside an :class:`.Program` context.\n+ method inside a :class:`.Program` context.\n This creates a :class:`.Command` instance that wraps\n- the Operation and the RegRefs it acts on, which is appended to the Program command queue.\n+ the Operation and the RegRefs it acts on, which is appended to :attr:`.Program.circuit`.\n \n * Before the Program is run, it is compiled and optimized for a specific backend. This involves\n checking that the Program only contains valid Operations, decomposing non-elementary Operations\n using :meth:`~ops.Operation.decompose`, and finally merging and commuting Commands inside\n the graph representing the quantum circuit.\n The circuit graph is built using the knowledge of which subsystems the Commands act and depend on.\n \n-* Merging two :class:`.Gate` instances of the same subclass involves\n+* Decompositions, merges and commutations often involve creation new Operations with algebraically\n+ transformed parameters.\n+ For example, merging two :class:`.Gate` instances of the same subclass involves\n adding their first parameters after equality-comparing the others. This is easily done if\n all the parameters have an immediate numerical value.\n- RegRefTransforms and TensorFlow objects are more complicated, but could in principle be handled.\n- For now, we simply don't merge Operations that depend on RegRefTransforms or TensorFlow objects.\n+ Measured and free parameters are handled symbolically by Sympy.\n \n * The compiled Program is run by a :class:`.BaseEngine` instance, which calls the\n- :meth:`~ops.Operation.apply` method of each Operation in turn.\n+ :meth:`apply` method of each Operation in turn.\n \n-* :meth:`Operation.apply` evaluates the numeric value of any RegRefTransform-based Parameters\n- using :meth:`Parameter.evaluate` (other types of Parameters are simply passed through).\n- The parameter values and the subsystem indices are passed to :meth:`Operation._apply`.\n-\n-* :meth:`~ops.Operation._apply` \"unwraps\" the Parameter instances. There are three different cases:\n-\n- 1. We still need to do some arithmetic, unwrap after it is done using `p.x`.\n- 2. No arithmetic required, use :func:`~parameters._unwrap`.\n- 3. No parameters are used, do nothing.\n-\n- Finally, :meth:`_apply` calls the appropriate backend API method using the unwrapped parameters.\n+* :meth:`apply` then calls :meth:`_apply` which is unique for each Operation subclass.\n+ It may perform additional numeric or symbolic transformations on the parameters, and\n+ then finally evaluates the numeric value of the parameters using :func:`par_evaluate`.\n+ The numeric parameter values are passed to the appropriate backend API method.\n It is up to the backend to either accept NumPy arrays and Tensorflow objects as parameters, or not.\n \n+\n What we cannot do at the moment:\n \n-* Use anything except integers and RegRefs (or Sequences thereof) as the subsystem parameter\n+* Use anything except integers and RegRefs (or Sequences thereof) as the subsystem argument\n for the :meth:`~ops.Operation.__or__` method.\n- Technically we could allow any Parameters or valid Parameter initializers that evaluate into an integer.\n-* Do arithmetic with RegRefTransforms.\n+ Technically we could allow any parameters that evaluate into an integer.\n \n-Parameter methods\n+\n+Functions\n+---------\n+\n+.. currentmodule:: strawberryfields.parameters\n+\n+.. autosummary::\n+ par_evaluate\n+ par_is_symbolic\n+ par_regref_deps\n+ par_str\n+\n+\n+Parameter classes\n -----------------\n \n-.. currentmodule:: strawberryfields.parameters.Parameter\n+.. autosummary::\n+ MeasuredParameter\n+ FreeParameter\n+\n+\n+Exceptions\n+----------\n \n .. autosummary::\n- evaluate\n+ ParameterError\n \n \n Code details\n ~~~~~~~~~~~~\n \n \"\"\"\n-import numbers\n+# pylint: disable=too-many-ancestors,unused-argument,protected-access\n+\n+from collections.abc import Sequence\n+import functools\n+import types\n \n-from unittest import mock\n import numpy as np\n+import sympy\n+import sympy.functions as sf\n+\n+\n+def wrap_mathfunc(func):\n+ \"\"\"Applies the wrapped sympy function elementwise to numpy arrays.\n+\n+ Required because the sympy math functions cannot deal with arrays.\n+ We implement no broadcasting; if the first argument is a numpy array, we assume\n+ all the arguments are arrays of the same shape.\n+ \"\"\"\n+ @functools.wraps(func)\n+ def wrapper(args):\n+ if isinstance(args[0], np.ndarray):\n+ # apply func elementwise, recursively, on the args\n+ return np.array([wrapper(k) for k in zip(args)])\n+ return func(args)\n+ return wrapper\n \n-from .program_utils import (RegRef, RegRefTransform)\n+# namespace of mathematical functions for manipulating Parameters\n+parfuncs = types.SimpleNamespace({name: wrap_mathfunc(getattr(sf, name)) for name in dir(sf) if name[0] != '_'})\n \n \n-try:\n- import tensorflow as tf\n- _tf_classes = (tf.Tensor, tf.Variable)\n-except ImportError:\n- tf = mock.MagicMock()\n- _tf_classes = tuple()\n \n+class ParameterError(RuntimeError):\n+ \"\"\"Exception raised when the Parameter classes encounter an illegal operation.\n+\n+ E.g., trying to use a measurement result before it is available.\n+ \"\"\"\n+\n+\n+def is_object_array(p):\n+ \"\"\"Returns True iff p is an object array.\"\"\"\n+ return isinstance(p, np.ndarray) and p.dtype == object\n \n-def _unwrap(params):\n- \"\"\"Unwrap a parameter sequence.\n+\n+def par_evaluate(params):\n+ \"\"\"Evaluate a parameter sequence.\n+\n+ Any parameters descending from sympy.Basic are evaluated, others are returned as is.\n+ Evaluation means that free and measured parameters are replaced by their numeric values.\n+ Numpy arrays are evaluated elementwise.\n+\n+ Alternatively, evaluates a single parameter and returns its value.\n \n Args:\n- params (Sequence[Parameter]): parameters to unwrap\n+ params (Sequence[Any]): parameters to evaluate\n \n Returns:\n- tuple[Number, array, Tensor, Variable]: unwrapped Parameters\n+ list[Any]: evaluated parameters\n+ \"\"\"\n+ scalar = False\n+ if not isinstance(params, Sequence):\n+ scalar = True\n+ params = [params]\n+\n+ def do_evaluate(p):\n+ if is_object_array(p):\n+ return np.array([do_evaluate(k) for k in p])\n+\n+ if not par_is_symbolic(p):\n+ return p\n+\n+ #p = p.evalf() # TODO sympy 1.4 has some bugs which prevent using this for now, workaround below","path":"strawberryfields/parameters.py","position":227,"original_position":227,"commit_id":"ee154a3b281c5fe89590aeb36cef6732f1d42471","original_commit_id":"ee154a3b281c5fe89590aeb36cef6732f1d42471","user":{"login":"josh146","id":2959003,"node_id":"MDQ6VXNlcjI5NTkwMDM=","avatar_url":"https://avatars0.githubusercontent.com/u/2959003?v=4","gravatar_id":"","url":"https://api.github.com/users/josh146","html_url":"https://github.com/josh146","followers_url":"https://api.github.com/users/josh146/followers","following_url":"https://api.github.com/users/josh146/following{/other_user}","gists_url":"https://api.github.com/users/josh146/gists{/gist_id}","starred_url":"https://api.github.com/users/josh146/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh146/subscriptions","organizations_url":"https://api.github.com/users/josh146/orgs","repos_url":"https://api.github.com/users/josh146/repos","events_url":"https://api.github.com/users/josh146/events{/privacy}","received_events_url":"https://api.github.com/users/josh146/received_events","type":"User","site_admin":false},"body":"Could you add the link to the issue here, so that we know when it can be uncommented?","created_at":"2019-09-14T18:27:55Z","updated_at":"2019-09-14T18:32:39Z","html_url":"https://github.com/XanaduAI/strawberryfields/pull/163#discussion_r324433818","pull_request_url":"https://api.github.com/repos/XanaduAI/strawberryfields/pulls/163","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/XanaduAI/strawberryfields/pulls/comments/324433818"},"html":{"href":"https://github.com/XanaduAI/strawberryfields/pull/163#discussion_r324433818"},"pull_request":{"href":"https://api.github.com/repos/XanaduAI/strawberryfields/pulls/163"}}},"pull_request":{"url":"https://api.github.com/repos/XanaduAI/strawberryfields/pulls/163","id":307752571,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA3NzUyNTcx","html_url":"https://github.com/XanaduAI/strawberryfields/pull/163","diff_url":"https://github.com/XanaduAI/strawberryfields/pull/163.diff","patch_url":"https://github.com/XanaduAI/strawberryfields/pull/163.patch","issue_url":"https://api.github.com/repos/XanaduAI/strawberryfields/issues/163","number":163,"state":"open","locked":false,"title":"Symbolic Operation parameters using SymPy","user":{"login":"smite","id":1044345,"node_id":"MDQ6VXNlcjEwNDQzNDU=","avatar_url":"https://avatars2.githubusercontent.com/u/1044345?v=4","gravatar_id":"","url":"https://api.github.com/users/smite","html_url":"https://github.com/smite","followers_url":"https://api.github.com/users/smite/followers","following_url":"https://api.github.com/users/smite/following{/other_user}","gists_url":"https://api.github.com/users/smite/gists{/gist_id}","starred_url":"https://api.github.com/users/smite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smite/subscriptions","organizations_url":"https://api.github.com/users/smite/orgs","repos_url":"https://api.github.com/users/smite/repos","events_url":"https://api.github.com/users/smite/events{/privacy}","received_events_url":"https://api.github.com/users/smite/received_events","type":"User","site_admin":false},"body":"Context:\r\n\r\nCurrently `Operation` instances can use either fixed or measured values as parameters through the `Parameter` class. Arbitrary algebraic transformations are provided by the `RegRefTransform` class.\r\n\r\nDescription of the Change:*\r\n\r\n `Parameter` class is replaced by `MeasuredParameter` and `FreeParameter`, both inheriting from `sympy.Symbol`. Fixed numeric parameters are handled by the built-in Python numeric classes and numpy arrays.\r\n\r\n* `Parameter`, `RegRefTransform` and `convert` are removed.\r\n\r\nBenefits:\r\n\r\n`Programs` can now have free parameters/arguments which are only bound to numerical values when the Program is executed, by supplying the actual argument values to the `Engine.run` method.\r\n\r\nSympy implements a wide array of algebraic manipulations and mathematical functions that act on the parameters, and handles the printing and evaluation of the symbolic expressions, making the implementation in `parameters.py` quite short.\r\n\r\nSince RegRefTransforms are replaced by compound symbolic expressions, they now can be easily converted to strings during Program serialization.\r\n\r\nOperations (gates) can now be decomposed symbolically. The only exception is `Decomposition` subclasses, since they use complicated numerical matrix decompositions.\r\n\r\nPossible Drawbacks:\r\n\r\nSympy comes with the occasional underdocumented/surprising feature, and also has its own set of bugs. However, all interaction with Sympy happens through the `strawberryfields.parameters` module.\r\n\r\nRelated GitHub Issues:\r\n\r\nResolves #61, closes #82 ","created_at":"2019-08-15T15:34:31Z","updated_at":"2019-09-14T18:32:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7eceebfa5198fc63fd5ad480ab8388841f2c1354","assignee":{"login":"smite","id":1044345,"node_id":"MDQ6VXNlcjEwNDQzNDU=","avatar_url":"https://avatars2.githubusercontent.com/u/1044345?v=4","gravatar_id":"","url":"https://api.github.com/users/smite","html_url":"https://github.com/smite","followers_url":"https://api.github.com/users/smite/followers","following_url":"https://api.github.com/users/smite/following{/other_user}","gists_url":"https://api.github.com/users/smite/gists{/gist_id}","starred_url":"https://api.github.com/users/smite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smite/subscriptions","organizations_url":"https://api.github.com/users/smite/orgs","repos_url":"https://api.github.com/users/smite/repos","events_url":"https://api.github.com/users/smite/events{/privacy}","received_events_url":"https://api.github.com/users/smite/received_events","type":"User","site_admin":false},"assignees":[{"login":"smite","id":1044345,"node_id":"MDQ6VXNlcjEwNDQzNDU=","avatar_url":"https://avatars2.githubusercontent.com/u/1044345?v=4","gravatar_id":"","url":"https://api.github.com/users/smite","html_url":"https://github.com/smite","followers_url":"https://api.github.com/users/smite/followers","following_url":"https://api.github.com/users/smite/following{/other_user}","gists_url":"https://api.github.com/users/smite/gists{/gist_id}","starred_url":"https://api.github.com/users/smite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smite/subscriptions","organizations_url":"https://api.github.com/users/smite/orgs","repos_url":"https://api.github.com/users/smite/repos","events_url":"https://api.github.com/users/smite/events{/privacy}","received_events_url":"https://api.github.com/users/smite/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":880109493,"node_id":"MDU6TGFiZWw4ODAxMDk0OTM=","url":"https://api.github.com/repos/XanaduAI/strawberryfields/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":1261811158,"node_id":"MDU6TGFiZWwxMjYxODExMTU4","url":"https://api.github.com/repos/XanaduAI/strawberryfields/labels/frontend","name":"frontend","color":"d17047","default":false},{"id":1340545426,"node_id":"MDU6TGFiZWwxMzQwNTQ1NDI2","url":"https://api.github.com/repos/XanaduAI/strawberryfields/labels/review-ready","name":"review-ready","color":"f7d460","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/XanaduAI/strawberryfields/pulls/163/commits","review_comments_url":"https://api.github.com/repos/XanaduAI/strawberryfields/pulls/163/comments","review_comment_url":"https://api.github.com/repos/XanaduAI/strawberryfields/pulls/comments{/number}","comments_url":"https://api.github.com/repos/XanaduAI/strawberryfields/issues/163/comments","statuses_url":"https://api.github.com/repos/XanaduAI/strawberryfields/statuses/ee154a3b281c5fe89590aeb36cef6732f1d42471","head":{"label":"XanaduAI:sympy_parameters","ref":"sympy_parameters","sha":"ee154a3b281c5fe89590aeb36cef6732f1d42471","user":{"login":"XanaduAI","id":31855630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODU1NjMw","avatar_url":"https://avatars3.githubusercontent.com/u/31855630?v=4","gravatar_id":"","url":"https://api.github.com/users/XanaduAI","html_url":"https://github.com/XanaduAI","followers_url":"https://api.github.com/users/XanaduAI/followers","following_url":"https://api.github.com/users/XanaduAI/following{/other_user}","gists_url":"https://api.github.com/users/XanaduAI/gists{/gist_id}","starred_url":"https://api.github.com/users/XanaduAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XanaduAI/subscriptions","organizations_url":"https://api.github.com/users/XanaduAI/orgs","repos_url":"https://api.github.com/users/XanaduAI/repos","events_url":"https://api.github.com/users/XanaduAI/events{/privacy}","received_events_url":"https://api.github.com/users/XanaduAI/received_events","type":"Organization","site_admin":false},"repo":{"id":126842861,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4NDI4NjE=","name":"strawberryfields","full_name":"XanaduAI/strawberryfields","private":false,"owner":{"login":"XanaduAI","id":31855630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODU1NjMw","avatar_url":"https://avatars3.githubusercontent.com/u/31855630?v=4","gravatar_id":"","url":"https://api.github.com/users/XanaduAI","html_url":"https://github.com/XanaduAI","followers_url":"https://api.github.com/users/XanaduAI/followers","following_url":"https://api.github.com/users/XanaduAI/following{/other_user}","gists_url":"https://api.github.com/users/XanaduAI/gists{/gist_id}","starred_url":"https://api.github.com/users/XanaduAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XanaduAI/subscriptions","organizations_url":"https://api.github.com/users/XanaduAI/orgs","repos_url":"https://api.github.com/users/XanaduAI/repos","events_url":"https://api.github.com/users/XanaduAI/events{/privacy}","received_events_url":"https://api.github.com/users/XanaduAI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/XanaduAI/strawberryfields","description":"Strawberry Fields is a full-stack Python library for designing, simulating, and optimizing continuous variable (CV) quantum optical circuits.","fork":false,"url":"https://api.github.com/repos/XanaduAI/strawberryfields","forks_url":"https://api.github.com/repos/XanaduAI/strawberryfields/forks","keys_url":"https://api.github.com/repos/XanaduAI/strawberryfields/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XanaduAI/strawberryfields/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XanaduAI/strawberryfields/teams","hooks_url":"https://api.github.com/repos/XanaduAI/strawberryfields/hooks","issue_events_url":"https://api.github.com/repos/XanaduAI/strawberryfields/issues/events{/number}","events_url":"https://api.github.com/repos/XanaduAI/strawberryfields/events","assignees_url":"https://api.github.com/repos/XanaduAI/strawberryfields/assignees{/user}","branches_url":"https://api.github.com/repos/XanaduAI/strawberryfields/branches{/branch}","tags_url":"https://api.github.com/repos/XanaduAI/strawberryfields/tags","blobs_url":"https://api.github.com/repos/XanaduAI/strawberryfields/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XanaduAI/strawberryfields/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XanaduAI/strawberryfields/git/refs{/sha}","trees_url":"https://api.github.com/repos/XanaduAI/strawberryfields/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XanaduAI/strawberryfields/statuses/{sha}","languages_url":"https://api.github.com/repos/XanaduAI/strawberryfields/languages","stargazers_url":"https://api.github.com/repos/XanaduAI/strawberryfields/stargazers","contributors_url":"https://api.github.com/repos/XanaduAI/strawberryfields/contributors","subscribers_url":"https://api.github.com/repos/XanaduAI/strawberryfields/subscribers","subscription_url":"https://api.github.com/repos/XanaduAI/strawberryfields/subscription","commits_url":"https://api.github.com/repos/XanaduAI/strawberryfields/commits{/sha}","git_commits_url":"https://api.github.com/repos/XanaduAI/strawberryfields/git/commits{/sha}","comments_url":"https://api.github.com/repos/XanaduAI/strawberryfields/comments{/number}","issue_comment_url":"https://api.github.com/repos/XanaduAI/strawberryfields/issues/comments{/number}","contents_url":"https://api.github.com/repos/XanaduAI/strawberryfields/contents/{+path}","compare_url":"https://api.github.com/repos/XanaduAI/strawberryfields/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XanaduAI/strawberryfields/merges","archive_url":"https://api.github.com/repos/XanaduAI/strawberryfields/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XanaduAI/strawberryfields/downloads","issues_url":"https://api.github.com/repos/XanaduAI/strawberryfields/issues{/number}","pulls_url":"https://api.github.com/repos/XanaduAI/strawberryfields/pulls{/number}","milestones_url":"https://api.github.com/repos/XanaduAI/strawberryfields/milestones{/number}","notifications_url":"https://api.github.com/repos/XanaduAI/strawberryfields/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XanaduAI/strawberryfields/labels{/name}","releases_url":"https://api.github.com/repos/XanaduAI/strawberryfields/releases{/id}","deployments_url":"https://api.github.com/repos/XanaduAI/strawberryfields/deployments","created_at":"2018-03-26T14:38:39Z","updated_at":"2019-09-14T03:00:16Z","pushed_at":"2019-09-14T17:32:46Z","git_url":"git://github.com/XanaduAI/strawberryfields.git","ssh_url":"[email protected]:XanaduAI/strawberryfields.git","clone_url":"https://github.com/XanaduAI/strawberryfields.git","svn_url":"https://github.com/XanaduAI/strawberryfields","homepage":"https://strawberryfields.readthedocs.io","size":10737,"stargazers_count":302,"watchers_count":302,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":71,"open_issues":21,"watchers":302,"default_branch":"master"}},"base":{"label":"XanaduAI:master","ref":"master","sha":"a8e1fe5df52846527bc5a1262517d6ab8280c6f2","user":{"login":"XanaduAI","id":31855630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODU1NjMw","avatar_url":"https://avatars3.githubusercontent.com/u/31855630?v=4","gravatar_id":"","url":"https://api.github.com/users/XanaduAI","html_url":"https://github.com/XanaduAI","followers_url":"https://api.github.com/users/XanaduAI/followers","following_url":"https://api.github.com/users/XanaduAI/following{/other_user}","gists_url":"https://api.github.com/users/XanaduAI/gists{/gist_id}","starred_url":"https://api.github.com/users/XanaduAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XanaduAI/subscriptions","organizations_url":"https://api.github.com/users/XanaduAI/orgs","repos_url":"https://api.github.com/users/XanaduAI/repos","events_url":"https://api.github.com/users/XanaduAI/events{/privacy}","received_events_url":"https://api.github.com/users/XanaduAI/received_events","type":"Organization","site_admin":false},"repo":{"id":126842861,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4NDI4NjE=","name":"strawberryfields","full_name":"XanaduAI/strawberryfields","private":false,"owner":{"login":"XanaduAI","id":31855630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODU1NjMw","avatar_url":"https://avatars3.githubusercontent.com/u/31855630?v=4","gravatar_id":"","url":"https://api.github.com/users/XanaduAI","html_url":"https://github.com/XanaduAI","followers_url":"https://api.github.com/users/XanaduAI/followers","following_url":"https://api.github.com/users/XanaduAI/following{/other_user}","gists_url":"https://api.github.com/users/XanaduAI/gists{/gist_id}","starred_url":"https://api.github.com/users/XanaduAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XanaduAI/subscriptions","organizations_url":"https://api.github.com/users/XanaduAI/orgs","repos_url":"https://api.github.com/users/XanaduAI/repos","events_url":"https://api.github.com/users/XanaduAI/events{/privacy}","received_events_url":"https://api.github.com/users/XanaduAI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/XanaduAI/strawberryfields","description":"Strawberry Fields is a full-stack Python library for designing, simulating, and optimizing continuous variable (CV) quantum optical circuits.","fork":false,"url":"https://api.github.com/repos/XanaduAI/strawberryfields","forks_url":"https://api.github.com/repos/XanaduAI/strawberryfields/forks","keys_url":"https://api.github.com/repos/XanaduAI/strawberryfields/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XanaduAI/strawberryfields/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XanaduAI/strawberryfields/teams","hooks_url":"https://api.github.com/repos/XanaduAI/strawberryfields/hooks","issue_events_url":"https://api.github.com/repos/XanaduAI/strawberryfields/issues/events{/number}","events_url":"https://api.github.com/repos/XanaduAI/strawberryfields/events","assignees_url":"https://api.github.com/repos/XanaduAI/strawberryfields/assignees{/user}","branches_url":"https://api.github.com/repos/XanaduAI/strawberryfields/branches{/branch}","tags_url":"https://api.github.com/repos/XanaduAI/strawberryfields/tags","blobs_url":"https://api.github.com/repos/XanaduAI/strawberryfields/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XanaduAI/strawberryfields/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XanaduAI/strawberryfields/git/refs{/sha}","trees_url":"https://api.github.com/repos/XanaduAI/strawberryfields/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XanaduAI/strawberryfields/statuses/{sha}","languages_url":"https://api.github.com/repos/XanaduAI/strawberryfields/languages","stargazers_url":"https://api.github.com/repos/XanaduAI/strawberryfields/stargazers","contributors_url":"https://api.github.com/repos/XanaduAI/strawberryfields/contributors","subscribers_url":"https://api.github.com/repos/XanaduAI/strawberryfields/subscribers","subscription_url":"https://api.github.com/repos/XanaduAI/strawberryfields/subscription","commits_url":"https://api.github.com/repos/XanaduAI/strawberryfields/commits{/sha}","git_commits_url":"https://api.github.com/repos/XanaduAI/strawberryfields/git/commits{/sha}","comments_url":"https://api.github.com/repos/XanaduAI/strawberryfields/comments{/number}","issue_comment_url":"https://api.github.com/repos/XanaduAI/strawberryfields/issues/comments{/number}","contents_url":"https://api.github.com/repos/XanaduAI/strawberryfields/contents/{+path}","compare_url":"https://api.github.com/repos/XanaduAI/strawberryfields/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XanaduAI/strawberryfields/merges","archive_url":"https://api.github.com/repos/XanaduAI/strawberryfields/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XanaduAI/strawberryfields/downloads","issues_url":"https://api.github.com/repos/XanaduAI/strawberryfields/issues{/number}","pulls_url":"https://api.github.com/repos/XanaduAI/strawberryfields/pulls{/number}","milestones_url":"https://api.github.com/repos/XanaduAI/strawberryfields/milestones{/number}","notifications_url":"https://api.github.com/repos/XanaduAI/strawberryfields/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XanaduAI/strawberryfields/labels{/name}","releases_url":"https://api.github.com/repos/XanaduAI/strawberryfields/releases{/id}","deployments_url":"https://api.github.com/repos/XanaduAI/strawberryfields/deployments","created_at":"2018-03-26T14:38:39Z","updated_at":"2019-09-14T03:00:16Z","pushed_at":"2019-09-14T17:32:46Z","git_url":"git://github.com/XanaduAI/strawberryfields.git","ssh_url":"[email protected]:XanaduAI/strawberryfields.git","clone_url":"https://github.com/XanaduAI/strawberryfields.git","svn_url":"https://github.com/XanaduAI/strawberryfields","homepage":"https://strawberryfields.readthedocs.io","size":10737,"stargazers_count":302,"watchers_count":302,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":71,"open_issues":21,"watchers":302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/XanaduAI/strawberryfields/pulls/163"},"html":{"href":"https://github.com/XanaduAI/strawberryfields/pull/163"},"issue":{"href":"https://api.github.com/repos/XanaduAI/strawberryfields/issues/163"},"comments":{"href":"https://api.github.com/repos/XanaduAI/strawberryfields/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/XanaduAI/strawberryfields/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/XanaduAI/strawberryfields/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/XanaduAI/strawberryfields/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/XanaduAI/strawberryfields/statuses/ee154a3b281c5fe89590aeb36cef6732f1d42471"}},"author_association":"COLLABORATOR"}}	{ "id": 126842861, "name": "XanaduAI/strawberryfields", "url": "https://api.github.com/repos/XanaduAI/strawberryfields" }	{ "id": 2959003, "login": "josh146", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/2959003?", "url": "https://api.github.com/users/josh146" }	{ "id": 31855630, "login": "XanaduAI", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/31855630?", "url": "https://api.github.com/orgs/XanaduAI" }	2019-09-14T18:27:55	10417071878	{"actor":{"display_login":"josh146"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/XanaduAI/pennylane/pulls/comments/336809910","pull_request_review_id":304293299,"id":336809910,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjgwOTkxMA==","diff_hunk":"@@ -37,3 +35,76 @@ The three measurement functions can be found here:\n \n :html:`</div>`\n \n+.. note::\n+\n+ Both :func:`~.pennylane.expval` and :func:`~.pennylane.var` support analytic\n+ differentiation. :func:`~.pennylane.sample`, however, returns stochastic\n+ results, and does not support differentiation.\n+\n+Multiple measurements\n+---------------------\n+\n+Quantum functions can also return multiple measurements, as long as each wire\n+is not measured more than once:\n+\n+.. code-block:: python\n+\n+ def my_quantum_function(x, y):\n+ qml.RZ(x, wires=0)\n+ qml.CNOT(wires=[0, 1])\n+ qml.RY(y, wires=1)\n+ return qml.expval(qml.PauliZ(1)), qml.var(qml.PauliX(0))\n+\n+You can also use list comprehensions, and other common Python patterns:\n+\n+.. code-block:: python\n+\n+ def my_quantum_function(x, y):\n+ qml.RZ(x, wires=0)\n+ qml.CNOT(wires=[0, 1])\n+ qml.RY(y, wires=1)\n+ return [qml.expval(qml.PauliZ(i)) for i in range(2)]\n+\n+Tensor observables\n+------------------\n+\n+PennyLane supports measuring the tensor product of observables, by using\n+the ``@`` notation. For example, to measure the expectation value of","path":"doc/introduction/measurements.rst","position":67,"original_position":67,"commit_id":"b53314ea1593c00d57f346b77a4be9eccbfd36e6","original_commit_id":"4a7a345a58f510ea1627805003cd709e59cec1d6","user":{"login":"josh146","id":2959003,"node_id":"MDQ6VXNlcjI5NTkwMDM=","avatar_url":"https://avatars0.githubusercontent.com/u/2959003?v=4","gravatar_id":"","url":"https://api.github.com/users/josh146","html_url":"https://github.com/josh146","followers_url":"https://api.github.com/users/josh146/followers","following_url":"https://api.github.com/users/josh146/following{/other_user}","gists_url":"https://api.github.com/users/josh146/gists{/gist_id}","starred_url":"https://api.github.com/users/josh146/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh146/subscriptions","organizations_url":"https://api.github.com/users/josh146/orgs","repos_url":"https://api.github.com/users/josh146/repos","events_url":"https://api.github.com/users/josh146/events{/privacy}","received_events_url":"https://api.github.com/users/josh146/received_events","type":"User","site_admin":false},"body":"I thought that might be confusing/overcomplicate - thoughts?","created_at":"2019-10-21T00:53:41Z","updated_at":"2019-10-21T00:53:41Z","html_url":"https://github.com/XanaduAI/pennylane/pull/372#discussion_r336809910","pull_request_url":"https://api.github.com/repos/XanaduAI/pennylane/pulls/372","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/XanaduAI/pennylane/pulls/comments/336809910"},"html":{"href":"https://github.com/XanaduAI/pennylane/pull/372#discussion_r336809910"},"pull_request":{"href":"https://api.github.com/repos/XanaduAI/pennylane/pulls/372"}},"in_reply_to_id":336803294},"pull_request":{"url":"https://api.github.com/repos/XanaduAI/pennylane/pulls/372","id":330156653,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMwMTU2NjUz","html_url":"https://github.com/XanaduAI/pennylane/pull/372","diff_url":"https://github.com/XanaduAI/pennylane/pull/372.diff","patch_url":"https://github.com/XanaduAI/pennylane/pull/372.patch","issue_url":"https://api.github.com/repos/XanaduAI/pennylane/issues/372","number":372,"state":"open","locked":false,"title":"Updates measurements page","user":{"login":"josh146","id":2959003,"node_id":"MDQ6VXNlcjI5NTkwMDM=","avatar_url":"https://avatars0.githubusercontent.com/u/2959003?v=4","gravatar_id":"","url":"https://api.github.com/users/josh146","html_url":"https://github.com/josh146","followers_url":"https://api.github.com/users/josh146/followers","following_url":"https://api.github.com/users/josh146/following{/other_user}","gists_url":"https://api.github.com/users/josh146/gists{/gist_id}","starred_url":"https://api.github.com/users/josh146/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh146/subscriptions","organizations_url":"https://api.github.com/users/josh146/orgs","repos_url":"https://api.github.com/users/josh146/repos","events_url":"https://api.github.com/users/josh146/events{/privacy}","received_events_url":"https://api.github.com/users/josh146/received_events","type":"User","site_admin":false},"body":"Description of the Change:\r\n\r\nUpdates the Using PennyLane/Measurement page with some features and common patterns that aren't mentioned anywhere else in the documentation:\r\n\r\n1. Adds a short example of multiple measurements\r\n\r\n2. Shows how to specify tensor observables\r\n\r\n3. Shows how to execute a QNode with differing number of shots (I put this here because it generally is used with the `sample()` function, maybe there is a better place for it?)\r\n\r\nBenefits: Briefly introduces tensor observables, multiple measurements, changing shots.\r\n\r\nPossible Drawbacks: n/a\r\n\r\nRelated GitHub Issues: n/a\r\n","created_at":"2019-10-20T20:48:12Z","updated_at":"2019-10-21T00:53:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbe3fac9fbb94db57f4b4539da78054724c3ae5e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mariaschuld","id":23052011,"node_id":"MDQ6VXNlcjIzMDUyMDEx","avatar_url":"https://avatars1.githubusercontent.com/u/23052011?v=4","gravatar_id":"","url":"https://api.github.com/users/mariaschuld","html_url":"https://github.com/mariaschuld","followers_url":"https://api.github.com/users/mariaschuld/followers","following_url":"https://api.github.com/users/mariaschuld/following{/other_user}","gists_url":"https://api.github.com/users/mariaschuld/gists{/gist_id}","starred_url":"https://api.github.com/users/mariaschuld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariaschuld/subscriptions","organizations_url":"https://api.github.com/users/mariaschuld/orgs","repos_url":"https://api.github.com/users/mariaschuld/repos","events_url":"https://api.github.com/users/mariaschuld/events{/privacy}","received_events_url":"https://api.github.com/users/mariaschuld/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":944740776,"node_id":"MDU6TGFiZWw5NDQ3NDA3NzY=","url":"https://api.github.com/repos/XanaduAI/pennylane/labels/documentation","name":"documentation","color":"27a31b","default":true},{"id":1325168635,"node_id":"MDU6TGFiZWwxMzI1MTY4NjM1","url":"https://api.github.com/repos/XanaduAI/pennylane/labels/review-ready","name":"review-ready","color":"7edbe5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/XanaduAI/pennylane/pulls/372/commits","review_comments_url":"https://api.github.com/repos/XanaduAI/pennylane/pulls/372/comments","review_comment_url":"https://api.github.com/repos/XanaduAI/pennylane/pulls/comments{/number}","comments_url":"https://api.github.com/repos/XanaduAI/pennylane/issues/372/comments","statuses_url":"https://api.github.com/repos/XanaduAI/pennylane/statuses/b53314ea1593c00d57f346b77a4be9eccbfd36e6","head":{"label":"XanaduAI:update_measure","ref":"update_measure","sha":"b53314ea1593c00d57f346b77a4be9eccbfd36e6","user":{"login":"XanaduAI","id":31855630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODU1NjMw","avatar_url":"https://avatars3.githubusercontent.com/u/31855630?v=4","gravatar_id":"","url":"https://api.github.com/users/XanaduAI","html_url":"https://github.com/XanaduAI","followers_url":"https://api.github.com/users/XanaduAI/followers","following_url":"https://api.github.com/users/XanaduAI/following{/other_user}","gists_url":"https://api.github.com/users/XanaduAI/gists{/gist_id}","starred_url":"https://api.github.com/users/XanaduAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XanaduAI/subscriptions","organizations_url":"https://api.github.com/users/XanaduAI/orgs","repos_url":"https://api.github.com/users/XanaduAI/repos","events_url":"https://api.github.com/users/XanaduAI/events{/privacy}","received_events_url":"https://api.github.com/users/XanaduAI/received_events","type":"Organization","site_admin":false},"repo":{"id":129936360,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk5MzYzNjA=","name":"pennylane","full_name":"XanaduAI/pennylane","private":false,"owner":{"login":"XanaduAI","id":31855630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODU1NjMw","avatar_url":"https://avatars3.githubusercontent.com/u/31855630?v=4","gravatar_id":"","url":"https://api.github.com/users/XanaduAI","html_url":"https://github.com/XanaduAI","followers_url":"https://api.github.com/users/XanaduAI/followers","following_url":"https://api.github.com/users/XanaduAI/following{/other_user}","gists_url":"https://api.github.com/users/XanaduAI/gists{/gist_id}","starred_url":"https://api.github.com/users/XanaduAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XanaduAI/subscriptions","organizations_url":"https://api.github.com/users/XanaduAI/orgs","repos_url":"https://api.github.com/users/XanaduAI/repos","events_url":"https://api.github.com/users/XanaduAI/events{/privacy}","received_events_url":"https://api.github.com/users/XanaduAI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/XanaduAI/pennylane","description":"PennyLane is a cross-platform Python library for quantum machine learning, automatic differentiation, and optimization of hybrid quantum-classical computations","fork":false,"url":"https://api.github.com/repos/XanaduAI/pennylane","forks_url":"https://api.github.com/repos/XanaduAI/pennylane/forks","keys_url":"https://api.github.com/repos/XanaduAI/pennylane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XanaduAI/pennylane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XanaduAI/pennylane/teams","hooks_url":"https://api.github.com/repos/XanaduAI/pennylane/hooks","issue_events_url":"https://api.github.com/repos/XanaduAI/pennylane/issues/events{/number}","events_url":"https://api.github.com/repos/XanaduAI/pennylane/events","assignees_url":"https://api.github.com/repos/XanaduAI/pennylane/assignees{/user}","branches_url":"https://api.github.com/repos/XanaduAI/pennylane/branches{/branch}","tags_url":"https://api.github.com/repos/XanaduAI/pennylane/tags","blobs_url":"https://api.github.com/repos/XanaduAI/pennylane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XanaduAI/pennylane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XanaduAI/pennylane/git/refs{/sha}","trees_url":"https://api.github.com/repos/XanaduAI/pennylane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XanaduAI/pennylane/statuses/{sha}","languages_url":"https://api.github.com/repos/XanaduAI/pennylane/languages","stargazers_url":"https://api.github.com/repos/XanaduAI/pennylane/stargazers","contributors_url":"https://api.github.com/repos/XanaduAI/pennylane/contributors","subscribers_url":"https://api.github.com/repos/XanaduAI/pennylane/subscribers","subscription_url":"https://api.github.com/repos/XanaduAI/pennylane/subscription","commits_url":"https://api.github.com/repos/XanaduAI/pennylane/commits{/sha}","git_commits_url":"https://api.github.com/repos/XanaduAI/pennylane/git/commits{/sha}","comments_url":"https://api.github.com/repos/XanaduAI/pennylane/comments{/number}","issue_comment_url":"https://api.github.com/repos/XanaduAI/pennylane/issues/comments{/number}","contents_url":"https://api.github.com/repos/XanaduAI/pennylane/contents/{+path}","compare_url":"https://api.github.com/repos/XanaduAI/pennylane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XanaduAI/pennylane/merges","archive_url":"https://api.github.com/repos/XanaduAI/pennylane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XanaduAI/pennylane/downloads","issues_url":"https://api.github.com/repos/XanaduAI/pennylane/issues{/number}","pulls_url":"https://api.github.com/repos/XanaduAI/pennylane/pulls{/number}","milestones_url":"https://api.github.com/repos/XanaduAI/pennylane/milestones{/number}","notifications_url":"https://api.github.com/repos/XanaduAI/pennylane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XanaduAI/pennylane/labels{/name}","releases_url":"https://api.github.com/repos/XanaduAI/pennylane/releases{/id}","deployments_url":"https://api.github.com/repos/XanaduAI/pennylane/deployments","created_at":"2018-04-17T16:45:42Z","updated_at":"2019-10-20T22:57:46Z","pushed_at":"2019-10-21T00:16:16Z","git_url":"git://github.com/XanaduAI/pennylane.git","ssh_url":"[email protected]:XanaduAI/pennylane.git","clone_url":"https://github.com/XanaduAI/pennylane.git","svn_url":"https://github.com/XanaduAI/pennylane","homepage":"https://pennylane.ai","size":20835,"stargazers_count":356,"watchers_count":356,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":84,"open_issues":29,"watchers":356,"default_branch":"master"}},"base":{"label":"XanaduAI:master","ref":"master","sha":"5bce2a09ae8a6b13d8d31e8e91579a59ea1dc4d1","user":{"login":"XanaduAI","id":31855630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODU1NjMw","avatar_url":"https://avatars3.githubusercontent.com/u/31855630?v=4","gravatar_id":"","url":"https://api.github.com/users/XanaduAI","html_url":"https://github.com/XanaduAI","followers_url":"https://api.github.com/users/XanaduAI/followers","following_url":"https://api.github.com/users/XanaduAI/following{/other_user}","gists_url":"https://api.github.com/users/XanaduAI/gists{/gist_id}","starred_url":"https://api.github.com/users/XanaduAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XanaduAI/subscriptions","organizations_url":"https://api.github.com/users/XanaduAI/orgs","repos_url":"https://api.github.com/users/XanaduAI/repos","events_url":"https://api.github.com/users/XanaduAI/events{/privacy}","received_events_url":"https://api.github.com/users/XanaduAI/received_events","type":"Organization","site_admin":false},"repo":{"id":129936360,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk5MzYzNjA=","name":"pennylane","full_name":"XanaduAI/pennylane","private":false,"owner":{"login":"XanaduAI","id":31855630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxODU1NjMw","avatar_url":"https://avatars3.githubusercontent.com/u/31855630?v=4","gravatar_id":"","url":"https://api.github.com/users/XanaduAI","html_url":"https://github.com/XanaduAI","followers_url":"https://api.github.com/users/XanaduAI/followers","following_url":"https://api.github.com/users/XanaduAI/following{/other_user}","gists_url":"https://api.github.com/users/XanaduAI/gists{/gist_id}","starred_url":"https://api.github.com/users/XanaduAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XanaduAI/subscriptions","organizations_url":"https://api.github.com/users/XanaduAI/orgs","repos_url":"https://api.github.com/users/XanaduAI/repos","events_url":"https://api.github.com/users/XanaduAI/events{/privacy}","received_events_url":"https://api.github.com/users/XanaduAI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/XanaduAI/pennylane","description":"PennyLane is a cross-platform Python library for quantum machine learning, automatic differentiation, and optimization of hybrid quantum-classical computations","fork":false,"url":"https://api.github.com/repos/XanaduAI/pennylane","forks_url":"https://api.github.com/repos/XanaduAI/pennylane/forks","keys_url":"https://api.github.com/repos/XanaduAI/pennylane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XanaduAI/pennylane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XanaduAI/pennylane/teams","hooks_url":"https://api.github.com/repos/XanaduAI/pennylane/hooks","issue_events_url":"https://api.github.com/repos/XanaduAI/pennylane/issues/events{/number}","events_url":"https://api.github.com/repos/XanaduAI/pennylane/events","assignees_url":"https://api.github.com/repos/XanaduAI/pennylane/assignees{/user}","branches_url":"https://api.github.com/repos/XanaduAI/pennylane/branches{/branch}","tags_url":"https://api.github.com/repos/XanaduAI/pennylane/tags","blobs_url":"https://api.github.com/repos/XanaduAI/pennylane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XanaduAI/pennylane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XanaduAI/pennylane/git/refs{/sha}","trees_url":"https://api.github.com/repos/XanaduAI/pennylane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XanaduAI/pennylane/statuses/{sha}","languages_url":"https://api.github.com/repos/XanaduAI/pennylane/languages","stargazers_url":"https://api.github.com/repos/XanaduAI/pennylane/stargazers","contributors_url":"https://api.github.com/repos/XanaduAI/pennylane/contributors","subscribers_url":"https://api.github.com/repos/XanaduAI/pennylane/subscribers","subscription_url":"https://api.github.com/repos/XanaduAI/pennylane/subscription","commits_url":"https://api.github.com/repos/XanaduAI/pennylane/commits{/sha}","git_commits_url":"https://api.github.com/repos/XanaduAI/pennylane/git/commits{/sha}","comments_url":"https://api.github.com/repos/XanaduAI/pennylane/comments{/number}","issue_comment_url":"https://api.github.com/repos/XanaduAI/pennylane/issues/comments{/number}","contents_url":"https://api.github.com/repos/XanaduAI/pennylane/contents/{+path}","compare_url":"https://api.github.com/repos/XanaduAI/pennylane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XanaduAI/pennylane/merges","archive_url":"https://api.github.com/repos/XanaduAI/pennylane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XanaduAI/pennylane/downloads","issues_url":"https://api.github.com/repos/XanaduAI/pennylane/issues{/number}","pulls_url":"https://api.github.com/repos/XanaduAI/pennylane/pulls{/number}","milestones_url":"https://api.github.com/repos/XanaduAI/pennylane/milestones{/number}","notifications_url":"https://api.github.com/repos/XanaduAI/pennylane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XanaduAI/pennylane/labels{/name}","releases_url":"https://api.github.com/repos/XanaduAI/pennylane/releases{/id}","deployments_url":"https://api.github.com/repos/XanaduAI/pennylane/deployments","created_at":"2018-04-17T16:45:42Z","updated_at":"2019-10-20T22:57:46Z","pushed_at":"2019-10-21T00:16:16Z","git_url":"git://github.com/XanaduAI/pennylane.git","ssh_url":"[email protected]:XanaduAI/pennylane.git","clone_url":"https://github.com/XanaduAI/pennylane.git","svn_url":"https://github.com/XanaduAI/pennylane","homepage":"https://pennylane.ai","size":20835,"stargazers_count":356,"watchers_count":356,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":84,"open_issues":29,"watchers":356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/XanaduAI/pennylane/pulls/372"},"html":{"href":"https://github.com/XanaduAI/pennylane/pull/372"},"issue":{"href":"https://api.github.com/repos/XanaduAI/pennylane/issues/372"},"comments":{"href":"https://api.github.com/repos/XanaduAI/pennylane/issues/372/comments"},"review_comments":{"href":"https://api.github.com/repos/XanaduAI/pennylane/pulls/372/comments"},"review_comment":{"href":"https://api.github.com/repos/XanaduAI/pennylane/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/XanaduAI/pennylane/pulls/372/commits"},"statuses":{"href":"https://api.github.com/repos/XanaduAI/pennylane/statuses/b53314ea1593c00d57f346b77a4be9eccbfd36e6"}},"author_association":"MEMBER"}}	{ "id": 129936360, "name": "XanaduAI/pennylane", "url": "https://api.github.com/repos/XanaduAI/pennylane" }	{ "id": 2959003, "login": "josh146", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/2959003?", "url": "https://api.github.com/users/josh146" }	{ "id": 31855630, "login": "XanaduAI", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/31855630?", "url": "https://api.github.com/orgs/XanaduAI" }	2019-10-21T00:53:41	10672015948	{"actor":{"display_login":"josh146"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/laudio/sync-db/pulls/comments/309062251","pull_request_review_id":268813851,"id":309062251,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwOTA2MjI1MQ==","diff_hunk":"@@ -0,0 +1,57 @@\n+var _db = require('@leapfrogtechnology/sync-db/lib/util/db');","path":"examples/node-app-mssql/src/index.js","position":1,"original_position":1,"commit_id":"01ca1b46fe30279be5fda643b9610815412244a3","original_commit_id":"01ca1b46fe30279be5fda643b9610815412244a3","user":{"login":"kabirbaidhya","id":3315763,"node_id":"MDQ6VXNlcjMzMTU3NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/3315763?v=4","gravatar_id":"","url":"https://api.github.com/users/kabirbaidhya","html_url":"https://github.com/kabirbaidhya","followers_url":"https://api.github.com/users/kabirbaidhya/followers","following_url":"https://api.github.com/users/kabirbaidhya/following{/other_user}","gists_url":"https://api.github.com/users/kabirbaidhya/gists{/gist_id}","starred_url":"https://api.github.com/users/kabirbaidhya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kabirbaidhya/subscriptions","organizations_url":"https://api.github.com/users/kabirbaidhya/orgs","repos_url":"https://api.github.com/users/kabirbaidhya/repos","events_url":"https://api.github.com/users/kabirbaidhya/events{/privacy}","received_events_url":"https://api.github.com/users/kabirbaidhya/received_events","type":"User","site_admin":false},"body":"Yes. This example should only use `sync-db` as a CLI not a library. \r\n\r\nUse Knex instead here for db operations.","created_at":"2019-07-31T06:52:04Z","updated_at":"2019-07-31T06:52:05Z","html_url":"https://github.com/laudio/sync-db/pull/5#discussion_r309062251","pull_request_url":"https://api.github.com/repos/laudio/sync-db/pulls/5","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/laudio/sync-db/pulls/comments/309062251"},"html":{"href":"https://github.com/laudio/sync-db/pull/5#discussion_r309062251"},"pull_request":{"href":"https://api.github.com/repos/laudio/sync-db/pulls/5"}},"in_reply_to_id":308834977},"pull_request":{"url":"https://api.github.com/repos/laudio/sync-db/pulls/5","id":302478081,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAyNDc4MDgx","html_url":"https://github.com/laudio/sync-db/pull/5","diff_url":"https://github.com/laudio/sync-db/pull/5.diff","patch_url":"https://github.com/laudio/sync-db/pull/5.patch","issue_url":"https://api.github.com/repos/laudio/sync-db/issues/5","number":5,"state":"open","locked":false,"title":"Add a node-mssql example","user":{"login":"shradayshakya","id":45987926,"node_id":"MDQ6VXNlcjQ1OTg3OTI2","avatar_url":"https://avatars2.githubusercontent.com/u/45987926?v=4","gravatar_id":"","url":"https://api.github.com/users/shradayshakya","html_url":"https://github.com/shradayshakya","followers_url":"https://api.github.com/users/shradayshakya/followers","following_url":"https://api.github.com/users/shradayshakya/following{/other_user}","gists_url":"https://api.github.com/users/shradayshakya/gists{/gist_id}","starred_url":"https://api.github.com/users/shradayshakya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shradayshakya/subscriptions","organizations_url":"https://api.github.com/users/shradayshakya/orgs","repos_url":"https://api.github.com/users/shradayshakya/repos","events_url":"https://api.github.com/users/shradayshakya/events{/privacy}","received_events_url":"https://api.github.com/users/shradayshakya/received_events","type":"User","site_admin":false},"body":"A simple node-mssql application to demonstrate usage of sync-db.","created_at":"2019-07-30T12:34:51Z","updated_at":"2019-07-31T06:52:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5863a1cd63ce82df55ef4950bb0e925952ce033","assignee":{"login":"shradayshakya","id":45987926,"node_id":"MDQ6VXNlcjQ1OTg3OTI2","avatar_url":"https://avatars2.githubusercontent.com/u/45987926?v=4","gravatar_id":"","url":"https://api.github.com/users/shradayshakya","html_url":"https://github.com/shradayshakya","followers_url":"https://api.github.com/users/shradayshakya/followers","following_url":"https://api.github.com/users/shradayshakya/following{/other_user}","gists_url":"https://api.github.com/users/shradayshakya/gists{/gist_id}","starred_url":"https://api.github.com/users/shradayshakya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shradayshakya/subscriptions","organizations_url":"https://api.github.com/users/shradayshakya/orgs","repos_url":"https://api.github.com/users/shradayshakya/repos","events_url":"https://api.github.com/users/shradayshakya/events{/privacy}","received_events_url":"https://api.github.com/users/shradayshakya/received_events","type":"User","site_admin":false},"assignees":[{"login":"shradayshakya","id":45987926,"node_id":"MDQ6VXNlcjQ1OTg3OTI2","avatar_url":"https://avatars2.githubusercontent.com/u/45987926?v=4","gravatar_id":"","url":"https://api.github.com/users/shradayshakya","html_url":"https://github.com/shradayshakya","followers_url":"https://api.github.com/users/shradayshakya/followers","following_url":"https://api.github.com/users/shradayshakya/following{/other_user}","gists_url":"https://api.github.com/users/shradayshakya/gists{/gist_id}","starred_url":"https://api.github.com/users/shradayshakya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shradayshakya/subscriptions","organizations_url":"https://api.github.com/users/shradayshakya/orgs","repos_url":"https://api.github.com/users/shradayshakya/repos","events_url":"https://api.github.com/users/shradayshakya/events{/privacy}","received_events_url":"https://api.github.com/users/shradayshakya/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/laudio/sync-db/pulls/5/commits","review_comments_url":"https://api.github.com/repos/laudio/sync-db/pulls/5/comments","review_comment_url":"https://api.github.com/repos/laudio/sync-db/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laudio/sync-db/issues/5/comments","statuses_url":"https://api.github.com/repos/laudio/sync-db/statuses/01ca1b46fe30279be5fda643b9610815412244a3","head":{"label":"laudio:node-mssql-example","ref":"node-mssql-example","sha":"01ca1b46fe30279be5fda643b9610815412244a3","user":{"login":"laudio","id":31930244,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTMwMjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/31930244?v=4","gravatar_id":"","url":"https://api.github.com/users/laudio","html_url":"https://github.com/laudio","followers_url":"https://api.github.com/users/laudio/followers","following_url":"https://api.github.com/users/laudio/following{/other_user}","gists_url":"https://api.github.com/users/laudio/gists{/gist_id}","starred_url":"https://api.github.com/users/laudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laudio/subscriptions","organizations_url":"https://api.github.com/users/laudio/orgs","repos_url":"https://api.github.com/users/laudio/repos","events_url":"https://api.github.com/users/laudio/events{/privacy}","received_events_url":"https://api.github.com/users/laudio/received_events","type":"Organization","site_admin":false},"repo":{"id":194331669,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQzMzE2Njk=","name":"sync-db","full_name":"laudio/sync-db","private":false,"owner":{"login":"laudio","id":31930244,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTMwMjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/31930244?v=4","gravatar_id":"","url":"https://api.github.com/users/laudio","html_url":"https://github.com/laudio","followers_url":"https://api.github.com/users/laudio/followers","following_url":"https://api.github.com/users/laudio/following{/other_user}","gists_url":"https://api.github.com/users/laudio/gists{/gist_id}","starred_url":"https://api.github.com/users/laudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laudio/subscriptions","organizations_url":"https://api.github.com/users/laudio/orgs","repos_url":"https://api.github.com/users/laudio/repos","events_url":"https://api.github.com/users/laudio/events{/privacy}","received_events_url":"https://api.github.com/users/laudio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/laudio/sync-db","description":"Database synchronization utility","fork":false,"url":"https://api.github.com/repos/laudio/sync-db","forks_url":"https://api.github.com/repos/laudio/sync-db/forks","keys_url":"https://api.github.com/repos/laudio/sync-db/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laudio/sync-db/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laudio/sync-db/teams","hooks_url":"https://api.github.com/repos/laudio/sync-db/hooks","issue_events_url":"https://api.github.com/repos/laudio/sync-db/issues/events{/number}","events_url":"https://api.github.com/repos/laudio/sync-db/events","assignees_url":"https://api.github.com/repos/laudio/sync-db/assignees{/user}","branches_url":"https://api.github.com/repos/laudio/sync-db/branches{/branch}","tags_url":"https://api.github.com/repos/laudio/sync-db/tags","blobs_url":"https://api.github.com/repos/laudio/sync-db/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laudio/sync-db/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laudio/sync-db/git/refs{/sha}","trees_url":"https://api.github.com/repos/laudio/sync-db/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laudio/sync-db/statuses/{sha}","languages_url":"https://api.github.com/repos/laudio/sync-db/languages","stargazers_url":"https://api.github.com/repos/laudio/sync-db/stargazers","contributors_url":"https://api.github.com/repos/laudio/sync-db/contributors","subscribers_url":"https://api.github.com/repos/laudio/sync-db/subscribers","subscription_url":"https://api.github.com/repos/laudio/sync-db/subscription","commits_url":"https://api.github.com/repos/laudio/sync-db/commits{/sha}","git_commits_url":"https://api.github.com/repos/laudio/sync-db/git/commits{/sha}","comments_url":"https://api.github.com/repos/laudio/sync-db/comments{/number}","issue_comment_url":"https://api.github.com/repos/laudio/sync-db/issues/comments{/number}","contents_url":"https://api.github.com/repos/laudio/sync-db/contents/{+path}","compare_url":"https://api.github.com/repos/laudio/sync-db/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laudio/sync-db/merges","archive_url":"https://api.github.com/repos/laudio/sync-db/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laudio/sync-db/downloads","issues_url":"https://api.github.com/repos/laudio/sync-db/issues{/number}","pulls_url":"https://api.github.com/repos/laudio/sync-db/pulls{/number}","milestones_url":"https://api.github.com/repos/laudio/sync-db/milestones{/number}","notifications_url":"https://api.github.com/repos/laudio/sync-db/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laudio/sync-db/labels{/name}","releases_url":"https://api.github.com/repos/laudio/sync-db/releases{/id}","deployments_url":"https://api.github.com/repos/laudio/sync-db/deployments","created_at":"2019-06-28T20:41:33Z","updated_at":"2019-07-14T05:54:48Z","pushed_at":"2019-07-30T12:34:52Z","git_url":"git://github.com/laudio/sync-db.git","ssh_url":"[email protected]:laudio/sync-db.git","clone_url":"https://github.com/laudio/sync-db.git","svn_url":"https://github.com/laudio/sync-db","homepage":null,"size":278,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"laudio:alpha","ref":"alpha","sha":"b6f352af74b2aaae189794e5010d3bd662dcadaa","user":{"login":"laudio","id":31930244,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTMwMjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/31930244?v=4","gravatar_id":"","url":"https://api.github.com/users/laudio","html_url":"https://github.com/laudio","followers_url":"https://api.github.com/users/laudio/followers","following_url":"https://api.github.com/users/laudio/following{/other_user}","gists_url":"https://api.github.com/users/laudio/gists{/gist_id}","starred_url":"https://api.github.com/users/laudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laudio/subscriptions","organizations_url":"https://api.github.com/users/laudio/orgs","repos_url":"https://api.github.com/users/laudio/repos","events_url":"https://api.github.com/users/laudio/events{/privacy}","received_events_url":"https://api.github.com/users/laudio/received_events","type":"Organization","site_admin":false},"repo":{"id":194331669,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQzMzE2Njk=","name":"sync-db","full_name":"laudio/sync-db","private":false,"owner":{"login":"laudio","id":31930244,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTMwMjQ0","avatar_url":"https://avatars0.githubusercontent.com/u/31930244?v=4","gravatar_id":"","url":"https://api.github.com/users/laudio","html_url":"https://github.com/laudio","followers_url":"https://api.github.com/users/laudio/followers","following_url":"https://api.github.com/users/laudio/following{/other_user}","gists_url":"https://api.github.com/users/laudio/gists{/gist_id}","starred_url":"https://api.github.com/users/laudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laudio/subscriptions","organizations_url":"https://api.github.com/users/laudio/orgs","repos_url":"https://api.github.com/users/laudio/repos","events_url":"https://api.github.com/users/laudio/events{/privacy}","received_events_url":"https://api.github.com/users/laudio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/laudio/sync-db","description":"Database synchronization utility","fork":false,"url":"https://api.github.com/repos/laudio/sync-db","forks_url":"https://api.github.com/repos/laudio/sync-db/forks","keys_url":"https://api.github.com/repos/laudio/sync-db/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laudio/sync-db/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laudio/sync-db/teams","hooks_url":"https://api.github.com/repos/laudio/sync-db/hooks","issue_events_url":"https://api.github.com/repos/laudio/sync-db/issues/events{/number}","events_url":"https://api.github.com/repos/laudio/sync-db/events","assignees_url":"https://api.github.com/repos/laudio/sync-db/assignees{/user}","branches_url":"https://api.github.com/repos/laudio/sync-db/branches{/branch}","tags_url":"https://api.github.com/repos/laudio/sync-db/tags","blobs_url":"https://api.github.com/repos/laudio/sync-db/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laudio/sync-db/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laudio/sync-db/git/refs{/sha}","trees_url":"https://api.github.com/repos/laudio/sync-db/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laudio/sync-db/statuses/{sha}","languages_url":"https://api.github.com/repos/laudio/sync-db/languages","stargazers_url":"https://api.github.com/repos/laudio/sync-db/stargazers","contributors_url":"https://api.github.com/repos/laudio/sync-db/contributors","subscribers_url":"https://api.github.com/repos/laudio/sync-db/subscribers","subscription_url":"https://api.github.com/repos/laudio/sync-db/subscription","commits_url":"https://api.github.com/repos/laudio/sync-db/commits{/sha}","git_commits_url":"https://api.github.com/repos/laudio/sync-db/git/commits{/sha}","comments_url":"https://api.github.com/repos/laudio/sync-db/comments{/number}","issue_comment_url":"https://api.github.com/repos/laudio/sync-db/issues/comments{/number}","contents_url":"https://api.github.com/repos/laudio/sync-db/contents/{+path}","compare_url":"https://api.github.com/repos/laudio/sync-db/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laudio/sync-db/merges","archive_url":"https://api.github.com/repos/laudio/sync-db/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laudio/sync-db/downloads","issues_url":"https://api.github.com/repos/laudio/sync-db/issues{/number}","pulls_url":"https://api.github.com/repos/laudio/sync-db/pulls{/number}","milestones_url":"https://api.github.com/repos/laudio/sync-db/milestones{/number}","notifications_url":"https://api.github.com/repos/laudio/sync-db/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laudio/sync-db/labels{/name}","releases_url":"https://api.github.com/repos/laudio/sync-db/releases{/id}","deployments_url":"https://api.github.com/repos/laudio/sync-db/deployments","created_at":"2019-06-28T20:41:33Z","updated_at":"2019-07-14T05:54:48Z","pushed_at":"2019-07-30T12:34:52Z","git_url":"git://github.com/laudio/sync-db.git","ssh_url":"[email protected]:laudio/sync-db.git","clone_url":"https://github.com/laudio/sync-db.git","svn_url":"https://github.com/laudio/sync-db","homepage":null,"size":278,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/laudio/sync-db/pulls/5"},"html":{"href":"https://github.com/laudio/sync-db/pull/5"},"issue":{"href":"https://api.github.com/repos/laudio/sync-db/issues/5"},"comments":{"href":"https://api.github.com/repos/laudio/sync-db/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/laudio/sync-db/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/laudio/sync-db/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laudio/sync-db/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/laudio/sync-db/statuses/01ca1b46fe30279be5fda643b9610815412244a3"}},"author_association":"COLLABORATOR"}}	{ "id": 194331669, "name": "laudio/sync-db", "url": "https://api.github.com/repos/laudio/sync-db" }	{ "id": 3315763, "login": "kabirbaidhya", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/3315763?", "url": "https://api.github.com/users/kabirbaidhya" }	{ "id": 31930244, "login": "laudio", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/31930244?", "url": "https://api.github.com/orgs/laudio" }	2019-07-31T06:52:04	10117572321	{"actor":{"display_login":"kabirbaidhya"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/process-engine/process_engine_core/pulls/comments/273818242","pull_request_review_id":224788544,"id":273818242,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MzgxODI0Mg==","diff_hunk":"@@ -0,0 +1,313 @@\n+import {InternalServerError} from '@essential-projects/errors_ts';\n+import {IIdentity} from '@essential-projects/iam_contracts';\n+\n+import {FlowNodeInstance, FlowNodeInstanceState, ProcessToken, ProcessTokenType} from '@process-engine/flow_node_instance.contracts';\n+import {\n+ IFlowNodeHandler,\n+ IFlowNodeInstanceResult,\n+ IProcessModelFacade,\n+ IProcessTokenFacade,\n+} from '@process-engine/process_engine_contracts';\n+import {Model} from '@process-engine/process_model.contracts';\n+\n+import {FlowNodeHandler} from '../flow_node_handler';\n+\n+/*\n+ This is the base handler for events.\n+ /\n+export abstract class EventHandler<TFlowNode extends Model.Base.FlowNode> extends FlowNodeHandler<TFlowNode> {\n+\n+ protected async beforeExecute(\n+ token: ProcessToken,\n+ processTokenFacade: IProcessTokenFacade,\n+ processModelFacade: IProcessModelFacade,\n+ identity: IIdentity,\n+ terminationCallback?: Function,\n+ ): Promise<void> {\n+ await super.beforeExecute(token, processTokenFacade, processModelFacade, identity);\n+ this._terminationSubscription = this.subscribeToProcessTermination(token, terminationCallback);\n+ }\n+\n+ public async execute(\n+ token: ProcessToken,\n+ processTokenFacade: IProcessTokenFacade,\n+ processModelFacade: IProcessModelFacade,\n+ identity: IIdentity,\n+ previousFlowNodeInstanceId?: string,\n+ ): Promise<void> {\n+\n+ return new Promise<void>(async(resolve: Function, reject: Function): Promise<void> => {\n+ try {\n+ this._previousFlowNodeInstanceId = previousFlowNodeInstanceId;\n+ token.flowNodeInstanceId = this.flowNodeInstanceId;\n+ let nextFlowNodes: Array<Model.Base.FlowNode>;\n+\n+ await this.beforeExecute(token, processTokenFacade, processModelFacade, identity, reject);\n+ nextFlowNodes = await this.executeInternally(token, processTokenFacade, processModelFacade, identity);\n+ await this.afterExecute(token, processTokenFacade, processModelFacade, identity);\n+\n+ const nextFlowNodesFound: boolean = nextFlowNodes && nextFlowNodes.length > 0;\n+ if (nextFlowNodesFound) {\n+\n+ const executeNextFlowNode: Function = async(nextFlowNode: Model.Base.FlowNode): Promise<void> => {\n+ const nextFlowNodeHandler: IFlowNodeHandler<Model.Base.FlowNode> =\n+ await this.flowNodeHandlerFactory.create<Model.Base.FlowNode>(nextFlowNode, token);\n+\n+ // If we must execute multiple branches, then each branch must get its own ProcessToken and Facade.\n+ const tokenForNextFlowNode: ProcessToken = nextFlowNodes.length > 1\n+ ? processTokenFacade.createProcessToken(token.payload)\n+ : token;\n+\n+ const processTokenFacadeForFlowNode: IProcessTokenFacade = nextFlowNodes.length > 1\n+ ? processTokenFacade.getProcessTokenFacadeForParallelBranch()\n+ : processTokenFacade;\n+\n+ tokenForNextFlowNode.flowNodeInstanceId = nextFlowNodeHandler.getInstanceId();\n+\n+ return nextFlowNodeHandler\n+ .execute(tokenForNextFlowNode, processTokenFacadeForFlowNode, processModelFacade, identity, this.flowNodeInstanceId);\n+ };\n+\n+ const nextFlowNodeExecutionPromises: Array<Promise<void>> = [];\n+ for (const nextFlowNode of nextFlowNodes) {\n+ nextFlowNodeExecutionPromises.push(executeNextFlowNode(nextFlowNode));\n+ }\n+\n+ await Promise.all(nextFlowNodeExecutionPromises);\n+ }\n+\n+ return resolve();\n+ } catch (error) {\n+\n+ token.payload = error;\n+\n+ const allResults: Array<IFlowNodeInstanceResult> = processTokenFacade.getAllResults();\n+ // This check is necessary to prevent duplicate entries, in case the Promise-Chain was broken further down the road.\n+ const noResultStoredYet: boolean = !allResults.some((entry: IFlowNodeInstanceResult) => entry.flowNodeInstanceId === this.flowNodeInstanceId);\n+ if (noResultStoredYet) {\n+ processTokenFacade.addResultForFlowNode(this.flowNode.id, this.flowNodeInstanceId, error);\n+ }\n+\n+ await this.afterExecute(token);\n+\n+ return reject(error);\n+ }\n+ });\n+ }\n+\n+ public async resume(\n+ flowNodeInstances: Array<FlowNodeInstance>,\n+ processTokenFacade: IProcessTokenFacade,\n+ processModelFacade: IProcessModelFacade,\n+ identity: IIdentity,\n+ ): Promise<void> {\n+\n+ return new Promise<void>(async(resolve: Function, reject: Function): Promise<void> => {\n+ try {\n+ const flowNodeInstance: FlowNodeInstance =\n+ flowNodeInstances.find((instance: FlowNodeInstance) => instance.flowNodeId === this.flowNode.id);\n+\n+ this._previousFlowNodeInstanceId = flowNodeInstance.previousFlowNodeInstanceId;\n+ this._flowNodeInstanceId = flowNodeInstance.id;\n+\n+ // With regards to ParallelGateways, we need to be able to handle multiple results here.\n+ let nextFlowNodes: Array<Model.Base.FlowNode>;","path":"src/runtime/flow_node_handler/event_handler/event_handler.ts","position":114,"original_position":114,"commit_id":"9a47e61e3dcb99fd9cc1b8e79b2dbb6b240e0dff","original_commit_id":"9a47e61e3dcb99fd9cc1b8e79b2dbb6b240e0dff","user":{"login":"SteffenKn","id":20394992,"node_id":"MDQ6VXNlcjIwMzk0OTky","avatar_url":"https://avatars2.githubusercontent.com/u/20394992?v=4","gravatar_id":"","url":"https://api.github.com/users/SteffenKn","html_url":"https://github.com/SteffenKn","followers_url":"https://api.github.com/users/SteffenKn/followers","following_url":"https://api.github.com/users/SteffenKn/following{/other_user}","gists_url":"https://api.github.com/users/SteffenKn/gists{/gist_id}","starred_url":"https://api.github.com/users/SteffenKn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteffenKn/subscriptions","organizations_url":"https://api.github.com/users/SteffenKn/orgs","repos_url":"https://api.github.com/users/SteffenKn/repos","events_url":"https://api.github.com/users/SteffenKn/events{/privacy}","received_events_url":"https://api.github.com/users/SteffenKn/received_events","type":"User","site_admin":false},"body":"Same as above\r\n\r\n```suggestion\r\n```","created_at":"2019-04-10T07:15:12Z","updated_at":"2019-04-10T07:23:18Z","html_url":"https://github.com/process-engine/process_engine_core/pull/270#discussion_r273818242","pull_request_url":"https://api.github.com/repos/process-engine/process_engine_core/pulls/270","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/process-engine/process_engine_core/pulls/comments/273818242"},"html":{"href":"https://github.com/process-engine/process_engine_core/pull/270#discussion_r273818242"},"pull_request":{"href":"https://api.github.com/repos/process-engine/process_engine_core/pulls/270"}}},"pull_request":{"url":"https://api.github.com/repos/process-engine/process_engine_core/pulls/270","id":266935894,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY2OTM1ODk0","html_url":"https://github.com/process-engine/process_engine_core/pull/270","diff_url":"https://github.com/process-engine/process_engine_core/pull/270.diff","patch_url":"https://github.com/process-engine/process_engine_core/pull/270.patch","issue_url":"https://api.github.com/repos/process-engine/process_engine_core/issues/270","number":270,"state":"open","locked":false,"title":"♻️ Refactor base flow node handlers","user":{"login":"ElRaptorus","id":15343316,"node_id":"MDQ6VXNlcjE1MzQzMzE2","avatar_url":"https://avatars1.githubusercontent.com/u/15343316?v=4","gravatar_id":"","url":"https://api.github.com/users/ElRaptorus","html_url":"https://github.com/ElRaptorus","followers_url":"https://api.github.com/users/ElRaptorus/followers","following_url":"https://api.github.com/users/ElRaptorus/following{/other_user}","gists_url":"https://api.github.com/users/ElRaptorus/gists{/gist_id}","starred_url":"https://api.github.com/users/ElRaptorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElRaptorus/subscriptions","organizations_url":"https://api.github.com/users/ElRaptorus/orgs","repos_url":"https://api.github.com/users/ElRaptorus/repos","events_url":"https://api.github.com/users/ElRaptorus/events{/privacy}","received_events_url":"https://api.github.com/users/ElRaptorus/received_events","type":"User","site_admin":false},"body":"Changes:\r\n\r\n1. Remove the `FlowNodeHandlerInterruptible` implementation.\r\n2. Keep only those hooks and functions in the base `FlowNodeHandler`, which are used by every* FlowNode.\r\n3. Create three base handlers for each FlowNodeType, each of which is derived from the base `FlowNodeHandler`:\r\n - `GatewayHandler` - Pretty much equivalent to the base handler\r\n - `EventHandler` - Like `GatewayHandler`, but also suspendable\r\n - `ActivityHandler` - Contains the BoundaryEvent handling previously employed by the `FlowNodeHandlerInterruptible` base handler\r\n - NOTE: BoundaryEvent handling requires some serious refactoring as well. But that will be done at a later date, since no concept exists for that yet.\r\n - All handlers use a customized implementation for execution and resumption\r\n4. Derive each FlowNodeHandler from the appropriate base Handler\r\n - i.e.: `EndEventHandler` from `EndEvent`, `UserTaskHandler` from `ActivityHandler`, etc.\r\n5. Move functionality for terminating ProcessInstances from base handler to `CallActivity` and `SubProcess` handlers, since only they need to be able to do it.\r\n6. Group all FlowNodeHandlers into subfolders named after their FlowNode type (`event_handlers`, `activity_handlers`, `gateway_handlers`) \r\n\r\nIssues:\r\n\r\nPart of https://github.com/process-engine/process_engine_runtime/issues/314\r\n\r\nPR: #270\r\n\r\n## How can others test the changes?\r\n\r\nThis is an internal refactoring. No changes should be visible to an outside observer.\r\n\r\n## PR-Checklist\r\n\r\nPlease check the boxes in this list after submitting your PR:\r\n\r\n- [x] You can merge this PR right now (if not, please prefix the title with \"WIP: \")\r\n- [x] I've tested all changes included in this PR.\r\n- [x] I've also reviewed this PR myself before submitting (e.g. for scrambled letters, typos, etc.).\r\n- [x] I've rebased the `develop` branch with my branch before finishing this PR.\r\n- [x] I've summarized all changes in a list above.\r\n- [x] I've mentioned all PRs, which relate to this one.\r\n- [x] I've prefixed my Pull Request title is according to [gitmoji guide](https://gitmoji.carloscuesta.me/).","created_at":"2019-04-03T08:12:17Z","updated_at":"2019-04-10T07:23:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb276f2ccd31180cebd0e75d2a7b4679e6707de2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rrrene","id":311914,"node_id":"MDQ6VXNlcjMxMTkxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/311914?v=4","gravatar_id":"","url":"https://api.github.com/users/rrrene","html_url":"https://github.com/rrrene","followers_url":"https://api.github.com/users/rrrene/followers","following_url":"https://api.github.com/users/rrrene/following{/other_user}","gists_url":"https://api.github.com/users/rrrene/gists{/gist_id}","starred_url":"https://api.github.com/users/rrrene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrrene/subscriptions","organizations_url":"https://api.github.com/users/rrrene/orgs","repos_url":"https://api.github.com/users/rrrene/repos","events_url":"https://api.github.com/users/rrrene/events{/privacy}","received_events_url":"https://api.github.com/users/rrrene/received_events","type":"User","site_admin":false},{"login":"christianbernds","id":14840597,"node_id":"MDQ6VXNlcjE0ODQwNTk3","avatar_url":"https://avatars2.githubusercontent.com/u/14840597?v=4","gravatar_id":"","url":"https://api.github.com/users/christianbernds","html_url":"https://github.com/christianbernds","followers_url":"https://api.github.com/users/christianbernds/followers","following_url":"https://api.github.com/users/christianbernds/following{/other_user}","gists_url":"https://api.github.com/users/christianbernds/gists{/gist_id}","starred_url":"https://api.github.com/users/christianbernds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianbernds/subscriptions","organizations_url":"https://api.github.com/users/christianbernds/orgs","repos_url":"https://api.github.com/users/christianbernds/repos","events_url":"https://api.github.com/users/christianbernds/events{/privacy}","received_events_url":"https://api.github.com/users/christianbernds/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/process-engine/process_engine_core/pulls/270/commits","review_comments_url":"https://api.github.com/repos/process-engine/process_engine_core/pulls/270/comments","review_comment_url":"https://api.github.com/repos/process-engine/process_engine_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/process-engine/process_engine_core/issues/270/comments","statuses_url":"https://api.github.com/repos/process-engine/process_engine_core/statuses/9a47e61e3dcb99fd9cc1b8e79b2dbb6b240e0dff","head":{"label":"process-engine:feature/refactor_base_flow_node_handlers","ref":"feature/refactor_base_flow_node_handlers","sha":"9a47e61e3dcb99fd9cc1b8e79b2dbb6b240e0dff","user":{"login":"process-engine","id":32196207,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTk2MjA3","avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":106316165,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYzMTYxNjU=","name":"process_engine_core","full_name":"process-engine/process_engine_core","private":false,"owner":{"login":"process-engine","id":32196207,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTk2MjA3","avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/process-engine/process_engine_core","description":"The heart of the ProcessEngine. Responsible for executing ProcessModels.","fork":false,"url":"https://api.github.com/repos/process-engine/process_engine_core","forks_url":"https://api.github.com/repos/process-engine/process_engine_core/forks","keys_url":"https://api.github.com/repos/process-engine/process_engine_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/process-engine/process_engine_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/process-engine/process_engine_core/teams","hooks_url":"https://api.github.com/repos/process-engine/process_engine_core/hooks","issue_events_url":"https://api.github.com/repos/process-engine/process_engine_core/issues/events{/number}","events_url":"https://api.github.com/repos/process-engine/process_engine_core/events","assignees_url":"https://api.github.com/repos/process-engine/process_engine_core/assignees{/user}","branches_url":"https://api.github.com/repos/process-engine/process_engine_core/branches{/branch}","tags_url":"https://api.github.com/repos/process-engine/process_engine_core/tags","blobs_url":"https://api.github.com/repos/process-engine/process_engine_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/process-engine/process_engine_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/process-engine/process_engine_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/process-engine/process_engine_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/process-engine/process_engine_core/statuses/{sha}","languages_url":"https://api.github.com/repos/process-engine/process_engine_core/languages","stargazers_url":"https://api.github.com/repos/process-engine/process_engine_core/stargazers","contributors_url":"https://api.github.com/repos/process-engine/process_engine_core/contributors","subscribers_url":"https://api.github.com/repos/process-engine/process_engine_core/subscribers","subscription_url":"https://api.github.com/repos/process-engine/process_engine_core/subscription","commits_url":"https://api.github.com/repos/process-engine/process_engine_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/process-engine/process_engine_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/process-engine/process_engine_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/process-engine/process_engine_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/process-engine/process_engine_core/contents/{+path}","compare_url":"https://api.github.com/repos/process-engine/process_engine_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/process-engine/process_engine_core/merges","archive_url":"https://api.github.com/repos/process-engine/process_engine_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/process-engine/process_engine_core/downloads","issues_url":"https://api.github.com/repos/process-engine/process_engine_core/issues{/number}","pulls_url":"https://api.github.com/repos/process-engine/process_engine_core/pulls{/number}","milestones_url":"https://api.github.com/repos/process-engine/process_engine_core/milestones{/number}","notifications_url":"https://api.github.com/repos/process-engine/process_engine_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/process-engine/process_engine_core/labels{/name}","releases_url":"https://api.github.com/repos/process-engine/process_engine_core/releases{/id}","deployments_url":"https://api.github.com/repos/process-engine/process_engine_core/deployments","created_at":"2017-10-09T17:49:54Z","updated_at":"2019-04-04T12:53:38Z","pushed_at":"2019-04-04T09:45:16Z","git_url":"git://github.com/process-engine/process_engine_core.git","ssh_url":"[email protected]:process-engine/process_engine_core.git","clone_url":"https://github.com/process-engine/process_engine_core.git","svn_url":"https://github.com/process-engine/process_engine_core","homepage":"","size":3167,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":6,"watchers":3,"default_branch":"develop"}},"base":{"label":"process-engine:develop","ref":"develop","sha":"39cb1ec2efcc2340a8cfab231bae4459c5082615","user":{"login":"process-engine","id":32196207,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTk2MjA3","avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":106316165,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYzMTYxNjU=","name":"process_engine_core","full_name":"process-engine/process_engine_core","private":false,"owner":{"login":"process-engine","id":32196207,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTk2MjA3","avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/process-engine/process_engine_core","description":"The heart of the ProcessEngine. Responsible for executing ProcessModels.","fork":false,"url":"https://api.github.com/repos/process-engine/process_engine_core","forks_url":"https://api.github.com/repos/process-engine/process_engine_core/forks","keys_url":"https://api.github.com/repos/process-engine/process_engine_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/process-engine/process_engine_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/process-engine/process_engine_core/teams","hooks_url":"https://api.github.com/repos/process-engine/process_engine_core/hooks","issue_events_url":"https://api.github.com/repos/process-engine/process_engine_core/issues/events{/number}","events_url":"https://api.github.com/repos/process-engine/process_engine_core/events","assignees_url":"https://api.github.com/repos/process-engine/process_engine_core/assignees{/user}","branches_url":"https://api.github.com/repos/process-engine/process_engine_core/branches{/branch}","tags_url":"https://api.github.com/repos/process-engine/process_engine_core/tags","blobs_url":"https://api.github.com/repos/process-engine/process_engine_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/process-engine/process_engine_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/process-engine/process_engine_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/process-engine/process_engine_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/process-engine/process_engine_core/statuses/{sha}","languages_url":"https://api.github.com/repos/process-engine/process_engine_core/languages","stargazers_url":"https://api.github.com/repos/process-engine/process_engine_core/stargazers","contributors_url":"https://api.github.com/repos/process-engine/process_engine_core/contributors","subscribers_url":"https://api.github.com/repos/process-engine/process_engine_core/subscribers","subscription_url":"https://api.github.com/repos/process-engine/process_engine_core/subscription","commits_url":"https://api.github.com/repos/process-engine/process_engine_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/process-engine/process_engine_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/process-engine/process_engine_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/process-engine/process_engine_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/process-engine/process_engine_core/contents/{+path}","compare_url":"https://api.github.com/repos/process-engine/process_engine_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/process-engine/process_engine_core/merges","archive_url":"https://api.github.com/repos/process-engine/process_engine_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/process-engine/process_engine_core/downloads","issues_url":"https://api.github.com/repos/process-engine/process_engine_core/issues{/number}","pulls_url":"https://api.github.com/repos/process-engine/process_engine_core/pulls{/number}","milestones_url":"https://api.github.com/repos/process-engine/process_engine_core/milestones{/number}","notifications_url":"https://api.github.com/repos/process-engine/process_engine_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/process-engine/process_engine_core/labels{/name}","releases_url":"https://api.github.com/repos/process-engine/process_engine_core/releases{/id}","deployments_url":"https://api.github.com/repos/process-engine/process_engine_core/deployments","created_at":"2017-10-09T17:49:54Z","updated_at":"2019-04-04T12:53:38Z","pushed_at":"2019-04-04T09:45:16Z","git_url":"git://github.com/process-engine/process_engine_core.git","ssh_url":"[email protected]:process-engine/process_engine_core.git","clone_url":"https://github.com/process-engine/process_engine_core.git","svn_url":"https://github.com/process-engine/process_engine_core","homepage":"","size":3167,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":6,"watchers":3,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/process-engine/process_engine_core/pulls/270"},"html":{"href":"https://github.com/process-engine/process_engine_core/pull/270"},"issue":{"href":"https://api.github.com/repos/process-engine/process_engine_core/issues/270"},"comments":{"href":"https://api.github.com/repos/process-engine/process_engine_core/issues/270/comments"},"review_comments":{"href":"https://api.github.com/repos/process-engine/process_engine_core/pulls/270/comments"},"review_comment":{"href":"https://api.github.com/repos/process-engine/process_engine_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/process-engine/process_engine_core/pulls/270/commits"},"statuses":{"href":"https://api.github.com/repos/process-engine/process_engine_core/statuses/9a47e61e3dcb99fd9cc1b8e79b2dbb6b240e0dff"}},"author_association":"MEMBER"}}	{ "id": 106316165, "name": "process-engine/process_engine_core", "url": "https://api.github.com/repos/process-engine/process_engine_core" }	{ "id": 20394992, "login": "SteffenKn", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/20394992?", "url": "https://api.github.com/users/SteffenKn" }	{ "id": 32196207, "login": "process-engine", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/32196207?", "url": "https://api.github.com/orgs/process-engine" }	2019-04-10T07:15:12	9413282653	{"actor":{"display_login":"SteffenKn"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/parcel-bundler/parcel/pulls/comments/288807031","pull_request_review_id":243564566,"id":288807031,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4ODgwNzAzMQ==","diff_hunk":"@@ -302,6 +316,12 @@ export default class WorkerFarm extends EventEmitter {\n );\n }\n \n+ createReverseHandle(fn: () => mixed) {\n+ let handle = new Handle();\n+ this.handles.set(handle.id, fn);\n+ return handle;","path":"packages/core/workers/src/WorkerFarm.js","position":117,"original_position":119,"commit_id":"9b6965e65416dc60d6b18b3471049e3f6786e2f1","original_commit_id":"a9fb1c9b23f1f6dd522454f005aac71bff8f3e38","user":{"login":"padmaia","id":2865858,"node_id":"MDQ6VXNlcjI4NjU4NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2865858?v=4","gravatar_id":"","url":"https://api.github.com/users/padmaia","html_url":"https://github.com/padmaia","followers_url":"https://api.github.com/users/padmaia/followers","following_url":"https://api.github.com/users/padmaia/following{/other_user}","gists_url":"https://api.github.com/users/padmaia/gists{/gist_id}","starred_url":"https://api.github.com/users/padmaia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padmaia/subscriptions","organizations_url":"https://api.github.com/users/padmaia/orgs","repos_url":"https://api.github.com/users/padmaia/repos","events_url":"https://api.github.com/users/padmaia/events{/privacy}","received_events_url":"https://api.github.com/users/padmaia/received_events","type":"User","site_admin":false},"body":"Discussed. Will cover this in a separate PR.","created_at":"2019-05-29T23:28:59Z","updated_at":"2019-05-29T23:29:00Z","html_url":"https://github.com/parcel-bundler/parcel/pull/3102#discussion_r288807031","pull_request_url":"https://api.github.com/repos/parcel-bundler/parcel/pulls/3102","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/parcel-bundler/parcel/pulls/comments/288807031"},"html":{"href":"https://github.com/parcel-bundler/parcel/pull/3102#discussion_r288807031"},"pull_request":{"href":"https://api.github.com/repos/parcel-bundler/parcel/pulls/3102"}},"in_reply_to_id":288714664},"pull_request":{"url":"https://api.github.com/repos/parcel-bundler/parcel/pulls/3102","id":282953100,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgyOTUzMTAw","html_url":"https://github.com/parcel-bundler/parcel/pull/3102","diff_url":"https://github.com/parcel-bundler/parcel/pull/3102.diff","patch_url":"https://github.com/parcel-bundler/parcel/pull/3102.patch","issue_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/3102","number":3102,"state":"open","locked":false,"title":"Add reverse handle functionality to WorkerFarm","user":{"login":"padmaia","id":2865858,"node_id":"MDQ6VXNlcjI4NjU4NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2865858?v=4","gravatar_id":"","url":"https://api.github.com/users/padmaia","html_url":"https://github.com/padmaia","followers_url":"https://api.github.com/users/padmaia/followers","following_url":"https://api.github.com/users/padmaia/following{/other_user}","gists_url":"https://api.github.com/users/padmaia/gists{/gist_id}","starred_url":"https://api.github.com/users/padmaia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padmaia/subscriptions","organizations_url":"https://api.github.com/users/padmaia/orgs","repos_url":"https://api.github.com/users/padmaia/repos","events_url":"https://api.github.com/users/padmaia/events{/privacy}","received_events_url":"https://api.github.com/users/padmaia/received_events","type":"User","site_admin":false},"body":"# ↪️ Pull Request\r\n\r\nReverse handles are functions defined in the main process that can be called in worker processes. We will need this functionality for config requests because the main process will be in charge of loading configuration for plugins, so that the graph can be used to avoid rework.\r\n\r\n## 🚨 Test instructions\r\n\r\n`yarn test`/`yarn flow`/`yarn lint`\r\n","created_at":"2019-05-28T18:50:12Z","updated_at":"2019-05-29T23:29:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9104518422526ad886dfb92a1597f9b5f4ab4506","assignee":null,"assignees":[],"requested_reviewers":[{"login":"devongovett","id":19409,"node_id":"MDQ6VXNlcjE5NDA5","avatar_url":"https://avatars0.githubusercontent.com/u/19409?v=4","gravatar_id":"","url":"https://api.github.com/users/devongovett","html_url":"https://github.com/devongovett","followers_url":"https://api.github.com/users/devongovett/followers","following_url":"https://api.github.com/users/devongovett/following{/other_user}","gists_url":"https://api.github.com/users/devongovett/gists{/gist_id}","starred_url":"https://api.github.com/users/devongovett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devongovett/subscriptions","organizations_url":"https://api.github.com/users/devongovett/orgs","repos_url":"https://api.github.com/users/devongovett/repos","events_url":"https://api.github.com/users/devongovett/events{/privacy}","received_events_url":"https://api.github.com/users/devongovett/received_events","type":"User","site_admin":false},{"login":"DeMoorJasper","id":2175521,"node_id":"MDQ6VXNlcjIxNzU1MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/2175521?v=4","gravatar_id":"","url":"https://api.github.com/users/DeMoorJasper","html_url":"https://github.com/DeMoorJasper","followers_url":"https://api.github.com/users/DeMoorJasper/followers","following_url":"https://api.github.com/users/DeMoorJasper/following{/other_user}","gists_url":"https://api.github.com/users/DeMoorJasper/gists{/gist_id}","starred_url":"https://api.github.com/users/DeMoorJasper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeMoorJasper/subscriptions","organizations_url":"https://api.github.com/users/DeMoorJasper/orgs","repos_url":"https://api.github.com/users/DeMoorJasper/repos","events_url":"https://api.github.com/users/DeMoorJasper/events{/privacy}","received_events_url":"https://api.github.com/users/DeMoorJasper/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1041764174,"node_id":"MDU6TGFiZWwxMDQxNzY0MTc0","url":"https://api.github.com/repos/parcel-bundler/parcel/labels/%E2%9C%A8%20Parcel%202","name":"✨ Parcel 2","color":"671db7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/parcel-bundler/parcel/pulls/3102/commits","review_comments_url":"https://api.github.com/repos/parcel-bundler/parcel/pulls/3102/comments","review_comment_url":"https://api.github.com/repos/parcel-bundler/parcel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/3102/comments","statuses_url":"https://api.github.com/repos/parcel-bundler/parcel/statuses/9b6965e65416dc60d6b18b3471049e3f6786e2f1","head":{"label":"parcel-bundler:reverse-handles","ref":"reverse-handles","sha":"9b6965e65416dc60d6b18b3471049e3f6786e2f1","user":{"login":"parcel-bundler","id":32607881,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjA3ODgx","avatar_url":"https://avatars1.githubusercontent.com/u/32607881?v=4","gravatar_id":"","url":"https://api.github.com/users/parcel-bundler","html_url":"https://github.com/parcel-bundler","followers_url":"https://api.github.com/users/parcel-bundler/followers","following_url":"https://api.github.com/users/parcel-bundler/following{/other_user}","gists_url":"https://api.github.com/users/parcel-bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/parcel-bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parcel-bundler/subscriptions","organizations_url":"https://api.github.com/users/parcel-bundler/orgs","repos_url":"https://api.github.com/users/parcel-bundler/repos","events_url":"https://api.github.com/users/parcel-bundler/events{/privacy}","received_events_url":"https://api.github.com/users/parcel-bundler/received_events","type":"Organization","site_admin":false},"repo":{"id":99598595,"node_id":"MDEwOlJlcG9zaXRvcnk5OTU5ODU5NQ==","name":"parcel","full_name":"parcel-bundler/parcel","private":false,"owner":{"login":"parcel-bundler","id":32607881,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjA3ODgx","avatar_url":"https://avatars1.githubusercontent.com/u/32607881?v=4","gravatar_id":"","url":"https://api.github.com/users/parcel-bundler","html_url":"https://github.com/parcel-bundler","followers_url":"https://api.github.com/users/parcel-bundler/followers","following_url":"https://api.github.com/users/parcel-bundler/following{/other_user}","gists_url":"https://api.github.com/users/parcel-bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/parcel-bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parcel-bundler/subscriptions","organizations_url":"https://api.github.com/users/parcel-bundler/orgs","repos_url":"https://api.github.com/users/parcel-bundler/repos","events_url":"https://api.github.com/users/parcel-bundler/events{/privacy}","received_events_url":"https://api.github.com/users/parcel-bundler/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/parcel-bundler/parcel","description":"📦🚀 Blazing fast, zero configuration web application bundler","fork":false,"url":"https://api.github.com/repos/parcel-bundler/parcel","forks_url":"https://api.github.com/repos/parcel-bundler/parcel/forks","keys_url":"https://api.github.com/repos/parcel-bundler/parcel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parcel-bundler/parcel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parcel-bundler/parcel/teams","hooks_url":"https://api.github.com/repos/parcel-bundler/parcel/hooks","issue_events_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/events{/number}","events_url":"https://api.github.com/repos/parcel-bundler/parcel/events","assignees_url":"https://api.github.com/repos/parcel-bundler/parcel/assignees{/user}","branches_url":"https://api.github.com/repos/parcel-bundler/parcel/branches{/branch}","tags_url":"https://api.github.com/repos/parcel-bundler/parcel/tags","blobs_url":"https://api.github.com/repos/parcel-bundler/parcel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parcel-bundler/parcel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parcel-bundler/parcel/git/refs{/sha}","trees_url":"https://api.github.com/repos/parcel-bundler/parcel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parcel-bundler/parcel/statuses/{sha}","languages_url":"https://api.github.com/repos/parcel-bundler/parcel/languages","stargazers_url":"https://api.github.com/repos/parcel-bundler/parcel/stargazers","contributors_url":"https://api.github.com/repos/parcel-bundler/parcel/contributors","subscribers_url":"https://api.github.com/repos/parcel-bundler/parcel/subscribers","subscription_url":"https://api.github.com/repos/parcel-bundler/parcel/subscription","commits_url":"https://api.github.com/repos/parcel-bundler/parcel/commits{/sha}","git_commits_url":"https://api.github.com/repos/parcel-bundler/parcel/git/commits{/sha}","comments_url":"https://api.github.com/repos/parcel-bundler/parcel/comments{/number}","issue_comment_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/comments{/number}","contents_url":"https://api.github.com/repos/parcel-bundler/parcel/contents/{+path}","compare_url":"https://api.github.com/repos/parcel-bundler/parcel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parcel-bundler/parcel/merges","archive_url":"https://api.github.com/repos/parcel-bundler/parcel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parcel-bundler/parcel/downloads","issues_url":"https://api.github.com/repos/parcel-bundler/parcel/issues{/number}","pulls_url":"https://api.github.com/repos/parcel-bundler/parcel/pulls{/number}","milestones_url":"https://api.github.com/repos/parcel-bundler/parcel/milestones{/number}","notifications_url":"https://api.github.com/repos/parcel-bundler/parcel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parcel-bundler/parcel/labels{/name}","releases_url":"https://api.github.com/repos/parcel-bundler/parcel/releases{/id}","deployments_url":"https://api.github.com/repos/parcel-bundler/parcel/deployments","created_at":"2017-08-07T16:36:47Z","updated_at":"2019-05-29T23:11:08Z","pushed_at":"2019-05-29T23:07:22Z","git_url":"git://github.com/parcel-bundler/parcel.git","ssh_url":"[email protected]:parcel-bundler/parcel.git","clone_url":"https://github.com/parcel-bundler/parcel.git","svn_url":"https://github.com/parcel-bundler/parcel","homepage":"https://parceljs.org","size":6584,"stargazers_count":31810,"watchers_count":31810,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1446,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":697,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1446,"open_issues":697,"watchers":31810,"default_branch":"master"}},"base":{"label":"parcel-bundler:v2","ref":"v2","sha":"c2465f00c49e13fc1a2006cba6c2d454a8831b81","user":{"login":"parcel-bundler","id":32607881,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjA3ODgx","avatar_url":"https://avatars1.githubusercontent.com/u/32607881?v=4","gravatar_id":"","url":"https://api.github.com/users/parcel-bundler","html_url":"https://github.com/parcel-bundler","followers_url":"https://api.github.com/users/parcel-bundler/followers","following_url":"https://api.github.com/users/parcel-bundler/following{/other_user}","gists_url":"https://api.github.com/users/parcel-bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/parcel-bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parcel-bundler/subscriptions","organizations_url":"https://api.github.com/users/parcel-bundler/orgs","repos_url":"https://api.github.com/users/parcel-bundler/repos","events_url":"https://api.github.com/users/parcel-bundler/events{/privacy}","received_events_url":"https://api.github.com/users/parcel-bundler/received_events","type":"Organization","site_admin":false},"repo":{"id":99598595,"node_id":"MDEwOlJlcG9zaXRvcnk5OTU5ODU5NQ==","name":"parcel","full_name":"parcel-bundler/parcel","private":false,"owner":{"login":"parcel-bundler","id":32607881,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjA3ODgx","avatar_url":"https://avatars1.githubusercontent.com/u/32607881?v=4","gravatar_id":"","url":"https://api.github.com/users/parcel-bundler","html_url":"https://github.com/parcel-bundler","followers_url":"https://api.github.com/users/parcel-bundler/followers","following_url":"https://api.github.com/users/parcel-bundler/following{/other_user}","gists_url":"https://api.github.com/users/parcel-bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/parcel-bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parcel-bundler/subscriptions","organizations_url":"https://api.github.com/users/parcel-bundler/orgs","repos_url":"https://api.github.com/users/parcel-bundler/repos","events_url":"https://api.github.com/users/parcel-bundler/events{/privacy}","received_events_url":"https://api.github.com/users/parcel-bundler/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/parcel-bundler/parcel","description":"📦🚀 Blazing fast, zero configuration web application bundler","fork":false,"url":"https://api.github.com/repos/parcel-bundler/parcel","forks_url":"https://api.github.com/repos/parcel-bundler/parcel/forks","keys_url":"https://api.github.com/repos/parcel-bundler/parcel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parcel-bundler/parcel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parcel-bundler/parcel/teams","hooks_url":"https://api.github.com/repos/parcel-bundler/parcel/hooks","issue_events_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/events{/number}","events_url":"https://api.github.com/repos/parcel-bundler/parcel/events","assignees_url":"https://api.github.com/repos/parcel-bundler/parcel/assignees{/user}","branches_url":"https://api.github.com/repos/parcel-bundler/parcel/branches{/branch}","tags_url":"https://api.github.com/repos/parcel-bundler/parcel/tags","blobs_url":"https://api.github.com/repos/parcel-bundler/parcel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parcel-bundler/parcel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parcel-bundler/parcel/git/refs{/sha}","trees_url":"https://api.github.com/repos/parcel-bundler/parcel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parcel-bundler/parcel/statuses/{sha}","languages_url":"https://api.github.com/repos/parcel-bundler/parcel/languages","stargazers_url":"https://api.github.com/repos/parcel-bundler/parcel/stargazers","contributors_url":"https://api.github.com/repos/parcel-bundler/parcel/contributors","subscribers_url":"https://api.github.com/repos/parcel-bundler/parcel/subscribers","subscription_url":"https://api.github.com/repos/parcel-bundler/parcel/subscription","commits_url":"https://api.github.com/repos/parcel-bundler/parcel/commits{/sha}","git_commits_url":"https://api.github.com/repos/parcel-bundler/parcel/git/commits{/sha}","comments_url":"https://api.github.com/repos/parcel-bundler/parcel/comments{/number}","issue_comment_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/comments{/number}","contents_url":"https://api.github.com/repos/parcel-bundler/parcel/contents/{+path}","compare_url":"https://api.github.com/repos/parcel-bundler/parcel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parcel-bundler/parcel/merges","archive_url":"https://api.github.com/repos/parcel-bundler/parcel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parcel-bundler/parcel/downloads","issues_url":"https://api.github.com/repos/parcel-bundler/parcel/issues{/number}","pulls_url":"https://api.github.com/repos/parcel-bundler/parcel/pulls{/number}","milestones_url":"https://api.github.com/repos/parcel-bundler/parcel/milestones{/number}","notifications_url":"https://api.github.com/repos/parcel-bundler/parcel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parcel-bundler/parcel/labels{/name}","releases_url":"https://api.github.com/repos/parcel-bundler/parcel/releases{/id}","deployments_url":"https://api.github.com/repos/parcel-bundler/parcel/deployments","created_at":"2017-08-07T16:36:47Z","updated_at":"2019-05-29T23:11:08Z","pushed_at":"2019-05-29T23:07:22Z","git_url":"git://github.com/parcel-bundler/parcel.git","ssh_url":"[email protected]:parcel-bundler/parcel.git","clone_url":"https://github.com/parcel-bundler/parcel.git","svn_url":"https://github.com/parcel-bundler/parcel","homepage":"https://parceljs.org","size":6584,"stargazers_count":31810,"watchers_count":31810,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1446,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":697,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1446,"open_issues":697,"watchers":31810,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/parcel-bundler/parcel/pulls/3102"},"html":{"href":"https://github.com/parcel-bundler/parcel/pull/3102"},"issue":{"href":"https://api.github.com/repos/parcel-bundler/parcel/issues/3102"},"comments":{"href":"https://api.github.com/repos/parcel-bundler/parcel/issues/3102/comments"},"review_comments":{"href":"https://api.github.com/repos/parcel-bundler/parcel/pulls/3102/comments"},"review_comment":{"href":"https://api.github.com/repos/parcel-bundler/parcel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/parcel-bundler/parcel/pulls/3102/commits"},"statuses":{"href":"https://api.github.com/repos/parcel-bundler/parcel/statuses/9b6965e65416dc60d6b18b3471049e3f6786e2f1"}},"author_association":"CONTRIBUTOR"}}	{ "id": 99598595, "name": "parcel-bundler/parcel", "url": "https://api.github.com/repos/parcel-bundler/parcel" }	{ "id": 2865858, "login": "padmaia", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/2865858?", "url": "https://api.github.com/users/padmaia" }	{ "id": 32607881, "login": "parcel-bundler", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/32607881?", "url": "https://api.github.com/orgs/parcel-bundler" }	2019-05-29T23:28:59	9723273214	{"actor":{"display_login":"padmaia"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/parcel-bundler/parcel/pulls/comments/305974521","pull_request_review_id":264981725,"id":305974521,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNTk3NDUyMQ==","diff_hunk":"@@ -30,43 +32,64 @@ export default class AssetGraphBuilder extends EventEmitter {\n requestGraph: RequestGraph;\n queue: PromiseQueue;\n controller: AbortController;\n- changedAssets: Map<string, Asset>;\n+ changedAssets: Map<string, Asset> = new Map();\n+ options: ParcelOptions;\n+ cacheKey: string;\n+ cache: Cache;\n+\n+ async init({config, options, entries, targets, assetRequest}: Opts) {\n+ this.options = options;\n+ let {minify, hot, scopeHoist} = options;\n+ this.cacheKey = md5FromObject({\n+ options: {minify, hot, scopeHoist},\n+ entries,\n+ targets","path":"packages/core/core/src/AssetGraphBuilder.js","position":36,"original_position":36,"commit_id":"b55ae100c50a8316ec7723e86b3f370f0916a155","original_commit_id":"b55ae100c50a8316ec7723e86b3f370f0916a155","user":{"login":"padmaia","id":2865858,"node_id":"MDQ6VXNlcjI4NjU4NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2865858?v=4","gravatar_id":"","url":"https://api.github.com/users/padmaia","html_url":"https://github.com/padmaia","followers_url":"https://api.github.com/users/padmaia/followers","following_url":"https://api.github.com/users/padmaia/following{/other_user}","gists_url":"https://api.github.com/users/padmaia/gists{/gist_id}","starred_url":"https://api.github.com/users/padmaia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padmaia/subscriptions","organizations_url":"https://api.github.com/users/padmaia/orgs","repos_url":"https://api.github.com/users/padmaia/repos","events_url":"https://api.github.com/users/padmaia/events{/privacy}","received_events_url":"https://api.github.com/users/padmaia/received_events","type":"User","site_admin":false},"body":"Would it make sense to eventually have different graphs per target? That way we wouldn't lose the entire graph when we add or remove a target? Seems like we still have to keep entries together in one graph since we might end up with shared bundles between entries, but targets seem like they could maybe be separated cleanly?\r\n\r\nAlso, I've been thinking that options could maybe be treated similarly to files. Requests could specify which options they care about like they specify which files they care about right now, and when they change we can invalidate only the nodes that are connected to those options. That way we don't have to resolve everything all over when the minify option is changed.","created_at":"2019-07-22T18:38:10Z","updated_at":"2019-07-22T18:48:11Z","html_url":"https://github.com/parcel-bundler/parcel/pull/3254#discussion_r305974521","pull_request_url":"https://api.github.com/repos/parcel-bundler/parcel/pulls/3254","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/parcel-bundler/parcel/pulls/comments/305974521"},"html":{"href":"https://github.com/parcel-bundler/parcel/pull/3254#discussion_r305974521"},"pull_request":{"href":"https://api.github.com/repos/parcel-bundler/parcel/pulls/3254"}}},"pull_request":{"url":"https://api.github.com/repos/parcel-bundler/parcel/pulls/3254","id":299660596,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk5NjYwNTk2","html_url":"https://github.com/parcel-bundler/parcel/pull/3254","diff_url":"https://github.com/parcel-bundler/parcel/pull/3254.diff","patch_url":"https://github.com/parcel-bundler/parcel/pull/3254.patch","issue_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/3254","number":3254,"state":"open","locked":false,"title":"Cache asset graph, bundle graph, and packager/optimizer results","user":{"login":"devongovett","id":19409,"node_id":"MDQ6VXNlcjE5NDA5","avatar_url":"https://avatars0.githubusercontent.com/u/19409?v=4","gravatar_id":"","url":"https://api.github.com/users/devongovett","html_url":"https://github.com/devongovett","followers_url":"https://api.github.com/users/devongovett/followers","following_url":"https://api.github.com/users/devongovett/following{/other_user}","gists_url":"https://api.github.com/users/devongovett/gists{/gist_id}","starred_url":"https://api.github.com/users/devongovett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devongovett/subscriptions","organizations_url":"https://api.github.com/users/devongovett/orgs","repos_url":"https://api.github.com/users/devongovett/repos","events_url":"https://api.github.com/users/devongovett/events{/privacy}","received_events_url":"https://api.github.com/users/devongovett/received_events","type":"User","site_admin":false},"body":"Currently, the Parcel cache only stores individual assets, but there are now a few other things that can be cached. This PR adds caching for the asset graph as a whole, the bundle graph, and the results of packaging and optimizing individual bundles.\r\n\r\n## Asset Graph\r\n\r\nWhen Parcel exits, it now writes the full asset graph and request graph into the cache. When it starts up again, it can simply load them from disk rather than rebuild them from scratch. Even with individual asset transformations cached, it was still slow to build the entire graph for large applications due to resolving and checking the cache individually for each asset.\r\n\r\nTo make this work, we also use the new watcher to store a snapshot of the current filesystem into the cache along side the graphs. When Parcel starts up, it loads the graphs, and checks with the watcher to see what files have changed since the snapshot. Then, it applies those changes to the graph just like it does in watch mode. This means that if nothing changes between parcel runs, no work will occur. If only one file changes, then only that file will be re-transformed.\r\n\r\nSince we store the entire graph in the cache now, and that includes the individual asset nodes (though not their contents), it raises the question of whether we need to store the individual assets at all. I guess the intermediary assets between pipelines might make that useful still, but there is some duplication now.\r\n\r\n## Bundle Graph\r\n\r\nWe also now cache the bundle graph. If the asset graph does not change, then the bundle graph will also not change, so we can just reuse the same bundle graph from the cache. This is currently really only a performance gain if you restart parcel without changing anything. Perhaps it won't be necessary if the new bundler is sufficiently fast as well. In the future, I could see us caching the bundle graph and somehow only rebuilding bundles that changed, but that requires further thought.\r\n\r\n## Packagers and Optimizers\r\n\r\nWe now cache the result of packaging and optimizing individual bundles. This is based on a hash of the bundle's asset graph, along with the parcel plugins + versions that were used to create it. Eventually, this should also include any third party configs used by those plugins, similar to what we're doing for transformers.\r\n\r\n## Performance\r\n\r\nI tested this on a relatively small app that just imported something from material-ui. Output size after minifying was ~86kb.\r\n\r\n* Uncached (v2): 5.96s\r\n* Cached (v2): 3.78s\r\n* Cached (cache-graph): 402ms\r\n\r\nAbout 200ms of the remaining time is actually just requiring plugins (specifically the reporter). Perhaps that will be reduced once we start bundling plugins for publishing.\r\n\r\n## Follow up\r\n\r\n* Garbage collection: this is needed in general, but this PR adds a bunch more things to the cache which will need to be garbage collected. Would be good to discuss this. One way to avoid it would be to not make the hash part of the cache key, and instead move it inside the cache entry and check it after retrieving. This would mean the cache key would not change every time. But perhaps there is a better way.\r\n* Third party config: we need third party config support like we have to transformers in all of our other plugins as well, and we need to track when that changes and invalidate bundling/packaging/optimizing.\r\n* Abstract watcher: we should probably abstract the watcher as part of the filesystem implementations so it works e.g. in the browser.","created_at":"2019-07-21T19:50:32Z","updated_at":"2019-07-22T18:48:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"113066c191c5ce59073e7e9fd8efa44702aa4980","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/parcel-bundler/parcel/pulls/3254/commits","review_comments_url":"https://api.github.com/repos/parcel-bundler/parcel/pulls/3254/comments","review_comment_url":"https://api.github.com/repos/parcel-bundler/parcel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/3254/comments","statuses_url":"https://api.github.com/repos/parcel-bundler/parcel/statuses/b55ae100c50a8316ec7723e86b3f370f0916a155","head":{"label":"parcel-bundler:cache-graph","ref":"cache-graph","sha":"b55ae100c50a8316ec7723e86b3f370f0916a155","user":{"login":"parcel-bundler","id":32607881,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjA3ODgx","avatar_url":"https://avatars1.githubusercontent.com/u/32607881?v=4","gravatar_id":"","url":"https://api.github.com/users/parcel-bundler","html_url":"https://github.com/parcel-bundler","followers_url":"https://api.github.com/users/parcel-bundler/followers","following_url":"https://api.github.com/users/parcel-bundler/following{/other_user}","gists_url":"https://api.github.com/users/parcel-bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/parcel-bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parcel-bundler/subscriptions","organizations_url":"https://api.github.com/users/parcel-bundler/orgs","repos_url":"https://api.github.com/users/parcel-bundler/repos","events_url":"https://api.github.com/users/parcel-bundler/events{/privacy}","received_events_url":"https://api.github.com/users/parcel-bundler/received_events","type":"Organization","site_admin":false},"repo":{"id":99598595,"node_id":"MDEwOlJlcG9zaXRvcnk5OTU5ODU5NQ==","name":"parcel","full_name":"parcel-bundler/parcel","private":false,"owner":{"login":"parcel-bundler","id":32607881,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjA3ODgx","avatar_url":"https://avatars1.githubusercontent.com/u/32607881?v=4","gravatar_id":"","url":"https://api.github.com/users/parcel-bundler","html_url":"https://github.com/parcel-bundler","followers_url":"https://api.github.com/users/parcel-bundler/followers","following_url":"https://api.github.com/users/parcel-bundler/following{/other_user}","gists_url":"https://api.github.com/users/parcel-bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/parcel-bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parcel-bundler/subscriptions","organizations_url":"https://api.github.com/users/parcel-bundler/orgs","repos_url":"https://api.github.com/users/parcel-bundler/repos","events_url":"https://api.github.com/users/parcel-bundler/events{/privacy}","received_events_url":"https://api.github.com/users/parcel-bundler/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/parcel-bundler/parcel","description":"📦🚀 Blazing fast, zero configuration web application bundler","fork":false,"url":"https://api.github.com/repos/parcel-bundler/parcel","forks_url":"https://api.github.com/repos/parcel-bundler/parcel/forks","keys_url":"https://api.github.com/repos/parcel-bundler/parcel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parcel-bundler/parcel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parcel-bundler/parcel/teams","hooks_url":"https://api.github.com/repos/parcel-bundler/parcel/hooks","issue_events_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/events{/number}","events_url":"https://api.github.com/repos/parcel-bundler/parcel/events","assignees_url":"https://api.github.com/repos/parcel-bundler/parcel/assignees{/user}","branches_url":"https://api.github.com/repos/parcel-bundler/parcel/branches{/branch}","tags_url":"https://api.github.com/repos/parcel-bundler/parcel/tags","blobs_url":"https://api.github.com/repos/parcel-bundler/parcel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parcel-bundler/parcel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parcel-bundler/parcel/git/refs{/sha}","trees_url":"https://api.github.com/repos/parcel-bundler/parcel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parcel-bundler/parcel/statuses/{sha}","languages_url":"https://api.github.com/repos/parcel-bundler/parcel/languages","stargazers_url":"https://api.github.com/repos/parcel-bundler/parcel/stargazers","contributors_url":"https://api.github.com/repos/parcel-bundler/parcel/contributors","subscribers_url":"https://api.github.com/repos/parcel-bundler/parcel/subscribers","subscription_url":"https://api.github.com/repos/parcel-bundler/parcel/subscription","commits_url":"https://api.github.com/repos/parcel-bundler/parcel/commits{/sha}","git_commits_url":"https://api.github.com/repos/parcel-bundler/parcel/git/commits{/sha}","comments_url":"https://api.github.com/repos/parcel-bundler/parcel/comments{/number}","issue_comment_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/comments{/number}","contents_url":"https://api.github.com/repos/parcel-bundler/parcel/contents/{+path}","compare_url":"https://api.github.com/repos/parcel-bundler/parcel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parcel-bundler/parcel/merges","archive_url":"https://api.github.com/repos/parcel-bundler/parcel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parcel-bundler/parcel/downloads","issues_url":"https://api.github.com/repos/parcel-bundler/parcel/issues{/number}","pulls_url":"https://api.github.com/repos/parcel-bundler/parcel/pulls{/number}","milestones_url":"https://api.github.com/repos/parcel-bundler/parcel/milestones{/number}","notifications_url":"https://api.github.com/repos/parcel-bundler/parcel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parcel-bundler/parcel/labels{/name}","releases_url":"https://api.github.com/repos/parcel-bundler/parcel/releases{/id}","deployments_url":"https://api.github.com/repos/parcel-bundler/parcel/deployments","created_at":"2017-08-07T16:36:47Z","updated_at":"2019-07-22T15:12:48Z","pushed_at":"2019-07-21T19:50:33Z","git_url":"git://github.com/parcel-bundler/parcel.git","ssh_url":"[email protected]:parcel-bundler/parcel.git","clone_url":"https://github.com/parcel-bundler/parcel.git","svn_url":"https://github.com/parcel-bundler/parcel","homepage":"https://parceljs.org","size":7261,"stargazers_count":32444,"watchers_count":32444,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1479,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":721,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1479,"open_issues":721,"watchers":32444,"default_branch":"master"}},"base":{"label":"parcel-bundler:v2","ref":"v2","sha":"d49457956bde88613f48574b22c35efb0f2e6b4a","user":{"login":"parcel-bundler","id":32607881,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjA3ODgx","avatar_url":"https://avatars1.githubusercontent.com/u/32607881?v=4","gravatar_id":"","url":"https://api.github.com/users/parcel-bundler","html_url":"https://github.com/parcel-bundler","followers_url":"https://api.github.com/users/parcel-bundler/followers","following_url":"https://api.github.com/users/parcel-bundler/following{/other_user}","gists_url":"https://api.github.com/users/parcel-bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/parcel-bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parcel-bundler/subscriptions","organizations_url":"https://api.github.com/users/parcel-bundler/orgs","repos_url":"https://api.github.com/users/parcel-bundler/repos","events_url":"https://api.github.com/users/parcel-bundler/events{/privacy}","received_events_url":"https://api.github.com/users/parcel-bundler/received_events","type":"Organization","site_admin":false},"repo":{"id":99598595,"node_id":"MDEwOlJlcG9zaXRvcnk5OTU5ODU5NQ==","name":"parcel","full_name":"parcel-bundler/parcel","private":false,"owner":{"login":"parcel-bundler","id":32607881,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNjA3ODgx","avatar_url":"https://avatars1.githubusercontent.com/u/32607881?v=4","gravatar_id":"","url":"https://api.github.com/users/parcel-bundler","html_url":"https://github.com/parcel-bundler","followers_url":"https://api.github.com/users/parcel-bundler/followers","following_url":"https://api.github.com/users/parcel-bundler/following{/other_user}","gists_url":"https://api.github.com/users/parcel-bundler/gists{/gist_id}","starred_url":"https://api.github.com/users/parcel-bundler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parcel-bundler/subscriptions","organizations_url":"https://api.github.com/users/parcel-bundler/orgs","repos_url":"https://api.github.com/users/parcel-bundler/repos","events_url":"https://api.github.com/users/parcel-bundler/events{/privacy}","received_events_url":"https://api.github.com/users/parcel-bundler/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/parcel-bundler/parcel","description":"📦🚀 Blazing fast, zero configuration web application bundler","fork":false,"url":"https://api.github.com/repos/parcel-bundler/parcel","forks_url":"https://api.github.com/repos/parcel-bundler/parcel/forks","keys_url":"https://api.github.com/repos/parcel-bundler/parcel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/parcel-bundler/parcel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/parcel-bundler/parcel/teams","hooks_url":"https://api.github.com/repos/parcel-bundler/parcel/hooks","issue_events_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/events{/number}","events_url":"https://api.github.com/repos/parcel-bundler/parcel/events","assignees_url":"https://api.github.com/repos/parcel-bundler/parcel/assignees{/user}","branches_url":"https://api.github.com/repos/parcel-bundler/parcel/branches{/branch}","tags_url":"https://api.github.com/repos/parcel-bundler/parcel/tags","blobs_url":"https://api.github.com/repos/parcel-bundler/parcel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/parcel-bundler/parcel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/parcel-bundler/parcel/git/refs{/sha}","trees_url":"https://api.github.com/repos/parcel-bundler/parcel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/parcel-bundler/parcel/statuses/{sha}","languages_url":"https://api.github.com/repos/parcel-bundler/parcel/languages","stargazers_url":"https://api.github.com/repos/parcel-bundler/parcel/stargazers","contributors_url":"https://api.github.com/repos/parcel-bundler/parcel/contributors","subscribers_url":"https://api.github.com/repos/parcel-bundler/parcel/subscribers","subscription_url":"https://api.github.com/repos/parcel-bundler/parcel/subscription","commits_url":"https://api.github.com/repos/parcel-bundler/parcel/commits{/sha}","git_commits_url":"https://api.github.com/repos/parcel-bundler/parcel/git/commits{/sha}","comments_url":"https://api.github.com/repos/parcel-bundler/parcel/comments{/number}","issue_comment_url":"https://api.github.com/repos/parcel-bundler/parcel/issues/comments{/number}","contents_url":"https://api.github.com/repos/parcel-bundler/parcel/contents/{+path}","compare_url":"https://api.github.com/repos/parcel-bundler/parcel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/parcel-bundler/parcel/merges","archive_url":"https://api.github.com/repos/parcel-bundler/parcel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/parcel-bundler/parcel/downloads","issues_url":"https://api.github.com/repos/parcel-bundler/parcel/issues{/number}","pulls_url":"https://api.github.com/repos/parcel-bundler/parcel/pulls{/number}","milestones_url":"https://api.github.com/repos/parcel-bundler/parcel/milestones{/number}","notifications_url":"https://api.github.com/repos/parcel-bundler/parcel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/parcel-bundler/parcel/labels{/name}","releases_url":"https://api.github.com/repos/parcel-bundler/parcel/releases{/id}","deployments_url":"https://api.github.com/repos/parcel-bundler/parcel/deployments","created_at":"2017-08-07T16:36:47Z","updated_at":"2019-07-22T15:12:48Z","pushed_at":"2019-07-21T19:50:33Z","git_url":"git://github.com/parcel-bundler/parcel.git","ssh_url":"[email protected]:parcel-bundler/parcel.git","clone_url":"https://github.com/parcel-bundler/parcel.git","svn_url":"https://github.com/parcel-bundler/parcel","homepage":"https://parceljs.org","size":7261,"stargazers_count":32444,"watchers_count":32444,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1479,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":721,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1479,"open_issues":721,"watchers":32444,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/parcel-bundler/parcel/pulls/3254"},"html":{"href":"https://github.com/parcel-bundler/parcel/pull/3254"},"issue":{"href":"https://api.github.com/repos/parcel-bundler/parcel/issues/3254"},"comments":{"href":"https://api.github.com/repos/parcel-bundler/parcel/issues/3254/comments"},"review_comments":{"href":"https://api.github.com/repos/parcel-bundler/parcel/pulls/3254/comments"},"review_comment":{"href":"https://api.github.com/repos/parcel-bundler/parcel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/parcel-bundler/parcel/pulls/3254/commits"},"statuses":{"href":"https://api.github.com/repos/parcel-bundler/parcel/statuses/b55ae100c50a8316ec7723e86b3f370f0916a155"}},"author_association":"MEMBER"}}	{ "id": 99598595, "name": "parcel-bundler/parcel", "url": "https://api.github.com/repos/parcel-bundler/parcel" }	{ "id": 2865858, "login": "padmaia", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/2865858?", "url": "https://api.github.com/users/padmaia" }	{ "id": 32607881, "login": "parcel-bundler", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/32607881?", "url": "https://api.github.com/orgs/parcel-bundler" }	2019-07-22T18:38:10	10060429035	{"actor":{"display_login":"padmaia"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/code-for-canada/project-thundercat/pulls/comments/265223378","pull_request_review_id":214075231,"id":265223378,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NTIyMzM3OA==","diff_hunk":"@@ -53,12 +78,84 @@ class Emib extends Component {\n }\n };\n \n- openPopup = () => {\n- this.setState({ showPopupBox: true });\n+ openSubmitPopup = () => {\n+ this.setState({ showSubmitPopup: true });\n };\n \n closePopup = () => {\n- this.setState({ showPopupBox: false });\n+ this.setState({ showSubmitPopup: false });","path":"frontend/src/components/eMIB/Emib.jsx","position":62,"original_position":62,"commit_id":"9aedfe75ef7f86484ffc3743dfa5771673e56bf2","original_commit_id":"9aedfe75ef7f86484ffc3743dfa5771673e56bf2","user":{"login":"caleybrock","id":4640747,"node_id":"MDQ6VXNlcjQ2NDA3NDc=","avatar_url":"https://avatars2.githubusercontent.com/u/4640747?v=4","gravatar_id":"","url":"https://api.github.com/users/caleybrock","html_url":"https://github.com/caleybrock","followers_url":"https://api.github.com/users/caleybrock/followers","following_url":"https://api.github.com/users/caleybrock/following{/other_user}","gists_url":"https://api.github.com/users/caleybrock/gists{/gist_id}","starred_url":"https://api.github.com/users/caleybrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caleybrock/subscriptions","organizations_url":"https://api.github.com/users/caleybrock/orgs","repos_url":"https://api.github.com/users/caleybrock/repos","events_url":"https://api.github.com/users/caleybrock/events{/privacy}","received_events_url":"https://api.github.com/users/caleybrock/received_events","type":"User","site_admin":false},"body":"I think there's actually no need to have multiple setState's in a row. You should be able to do this here and below:\r\n```\r\nthis.setState({\r\n showSubmitPopup: false,\r\n showQuitPopup: fase\r\n});\r\n```","created_at":"2019-03-13T16:40:10Z","updated_at":"2019-03-13T16:40:10Z","html_url":"https://github.com/code-for-canada/project-thundercat/pull/129#discussion_r265223378","pull_request_url":"https://api.github.com/repos/code-for-canada/project-thundercat/pulls/129","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/code-for-canada/project-thundercat/pulls/comments/265223378"},"html":{"href":"https://github.com/code-for-canada/project-thundercat/pull/129#discussion_r265223378"},"pull_request":{"href":"https://api.github.com/repos/code-for-canada/project-thundercat/pulls/129"}}},"pull_request":{"url":"https://api.github.com/repos/code-for-canada/project-thundercat/pulls/129","id":260794299,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwNzk0Mjk5","html_url":"https://github.com/code-for-canada/project-thundercat/pull/129","diff_url":"https://github.com/code-for-canada/project-thundercat/pull/129.diff","patch_url":"https://github.com/code-for-canada/project-thundercat/pull/129.patch","issue_url":"https://api.github.com/repos/code-for-canada/project-thundercat/issues/129","number":129,"state":"open","locked":false,"title":"[Quit Test Flow] Completed the Quit Test Flow","user":{"login":"fnormand01","id":23021242,"node_id":"MDQ6VXNlcjIzMDIxMjQy","avatar_url":"https://avatars1.githubusercontent.com/u/23021242?v=4","gravatar_id":"","url":"https://api.github.com/users/fnormand01","html_url":"https://github.com/fnormand01","followers_url":"https://api.github.com/users/fnormand01/followers","following_url":"https://api.github.com/users/fnormand01/following{/other_user}","gists_url":"https://api.github.com/users/fnormand01/gists{/gist_id}","starred_url":"https://api.github.com/users/fnormand01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fnormand01/subscriptions","organizations_url":"https://api.github.com/users/fnormand01/orgs","repos_url":"https://api.github.com/users/fnormand01/repos","events_url":"https://api.github.com/users/fnormand01/events{/privacy}","received_events_url":"https://api.github.com/users/fnormand01/received_events","type":"User","site_admin":false},"body":"# Description\r\n\r\nI completed the quit test flow by adding the generic popup box component when selecting the Quit test button. This popup box also contains an error/danger message, so I also used the generic system message component to get that.\r\n\r\n## Type of change\r\n- New feature (non-breaking change which adds functionality)\r\n- Code cleanliness or refactor\r\n\r\n## Screenshot\r\n\r\nEnglish Version:\r\n\r\n![image](https://user-images.githubusercontent.com/23021242/54286380-22949400-457a-11e9-9234-ea2f70a91801.png)\r\n\r\nFrench Version:\r\n\r\n![image](https://user-images.githubusercontent.com/23021242/54286419-33dda080-457a-11e9-8e0f-e3564b740521.png)\r\n\r\nWhen less than all the checkboxes are selected (the button still disabled):\r\n\r\n![image](https://user-images.githubusercontent.com/23021242/54286500-5a9bd700-457a-11e9-8852-30480d7e053a.png)\r\n\r\nWhen all checkboxes are selected (the button becomes enabled):\r\n\r\n![image](https://user-images.githubusercontent.com/23021242/54286586-8028e080-457a-11e9-8b31-51c6c54025a8.png)\r\n\r\n*Note that the translation hasn't been done in this PR, except for the buttons. This translation will be done in another PR.\r\n\r\n# Testing\r\n\r\nManual steps to reproduce this functionality:\r\n\r\n1. Start the eMIB sample test.\r\n2. Complete the pre-test process.\r\n3. Click Quit test and make sure that all buttons / checkboxes in the popup box work well.\r\n4. Also, make sure that the checkbox states are resetting when closing the popup box (check at least one checkbox before closing the popup box to test that)\r\n\r\nScreenshot of unit tests run passing:\r\n\r\n![image](https://user-images.githubusercontent.com/23021242/54287308-c894ce00-457b-11e9-8f21-c109cc27c8ad.png)\r\n\r\n# Checklist\r\n\r\nApplicable for all code changes.\r\n\r\n- [x] I have commented my code, particularly in hard-to-understand areas\r\n- [ ] ~~I have made corresponding changes to the documentation~~\r\n- [x] My changes generate no new compiler warnings\r\n- [ ] ~~My changes generate no new accessibility errors and/or warnings~~\r\n- [x] I have added tests that prove my fix is effective or that my feature works\r\n- [x] New and existing unit tests pass locally with my changes\r\n- [x] I have researched WCAG2.1 accessibility standards and met them in this PR (can be navigated using a keyboard)\r\n- [x] My changes look good on IE 10+, Firefox, and Chrome\r\n","created_at":"2019-03-13T14:36:59Z","updated_at":"2019-03-13T16:40:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78d0856a69eabecfd7695b8234a8374175a46169","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/code-for-canada/project-thundercat/pulls/129/commits","review_comments_url":"https://api.github.com/repos/code-for-canada/project-thundercat/pulls/129/comments","review_comment_url":"https://api.github.com/repos/code-for-canada/project-thundercat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/code-for-canada/project-thundercat/issues/129/comments","statuses_url":"https://api.github.com/repos/code-for-canada/project-thundercat/statuses/9aedfe75ef7f86484ffc3743dfa5771673e56bf2","head":{"label":"code-for-canada:building-quit-test-flow","ref":"building-quit-test-flow","sha":"9aedfe75ef7f86484ffc3743dfa5771673e56bf2","user":{"login":"code-for-canada","id":32721448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzIxNDQ4","avatar_url":"https://avatars0.githubusercontent.com/u/32721448?v=4","gravatar_id":"","url":"https://api.github.com/users/code-for-canada","html_url":"https://github.com/code-for-canada","followers_url":"https://api.github.com/users/code-for-canada/followers","following_url":"https://api.github.com/users/code-for-canada/following{/other_user}","gists_url":"https://api.github.com/users/code-for-canada/gists{/gist_id}","starred_url":"https://api.github.com/users/code-for-canada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-for-canada/subscriptions","organizations_url":"https://api.github.com/users/code-for-canada/orgs","repos_url":"https://api.github.com/users/code-for-canada/repos","events_url":"https://api.github.com/users/code-for-canada/events{/privacy}","received_events_url":"https://api.github.com/users/code-for-canada/received_events","type":"Organization","site_admin":false},"repo":{"id":163874364,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM4NzQzNjQ=","name":"project-thundercat","full_name":"code-for-canada/project-thundercat","private":false,"owner":{"login":"code-for-canada","id":32721448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzIxNDQ4","avatar_url":"https://avatars0.githubusercontent.com/u/32721448?v=4","gravatar_id":"","url":"https://api.github.com/users/code-for-canada","html_url":"https://github.com/code-for-canada","followers_url":"https://api.github.com/users/code-for-canada/followers","following_url":"https://api.github.com/users/code-for-canada/following{/other_user}","gists_url":"https://api.github.com/users/code-for-canada/gists{/gist_id}","starred_url":"https://api.github.com/users/code-for-canada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-for-canada/subscriptions","organizations_url":"https://api.github.com/users/code-for-canada/orgs","repos_url":"https://api.github.com/users/code-for-canada/repos","events_url":"https://api.github.com/users/code-for-canada/events{/privacy}","received_events_url":"https://api.github.com/users/code-for-canada/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/code-for-canada/project-thundercat","description":"Code for Canada + PSC partnership project","fork":true,"url":"https://api.github.com/repos/code-for-canada/project-thundercat","forks_url":"https://api.github.com/repos/code-for-canada/project-thundercat/forks","keys_url":"https://api.github.com/repos/code-for-canada/project-thundercat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-for-canada/project-thundercat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-for-canada/project-thundercat/teams","hooks_url":"https://api.github.com/repos/code-for-canada/project-thundercat/hooks","issue_events_url":"https://api.github.com/repos/code-for-canada/project-thundercat/issues/events{/number}","events_url":"https://api.github.com/repos/code-for-canada/project-thundercat/events","assignees_url":"https://api.github.com/repos/code-for-canada/project-thundercat/assignees{/user}","branches_url":"https://api.github.com/repos/code-for-canada/project-thundercat/branches{/branch}","tags_url":"https://api.github.com/repos/code-for-canada/project-thundercat/tags","blobs_url":"https://api.github.com/repos/code-for-canada/project-thundercat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-for-canada/project-thundercat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-for-canada/project-thundercat/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-for-canada/project-thundercat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-for-canada/project-thundercat/statuses/{sha}","languages_url":"https://api.github.com/repos/code-for-canada/project-thundercat/languages","stargazers_url":"https://api.github.com/repos/code-for-canada/project-thundercat/stargazers","contributors_url":"https://api.github.com/repos/code-for-canada/project-thundercat/contributors","subscribers_url":"https://api.github.com/repos/code-for-canada/project-thundercat/subscribers","subscription_url":"https://api.github.com/repos/code-for-canada/project-thundercat/subscription","commits_url":"https://api.github.com/repos/code-for-canada/project-thundercat/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-for-canada/project-thundercat/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-for-canada/project-thundercat/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-for-canada/project-thundercat/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-for-canada/project-thundercat/contents/{+path}","compare_url":"https://api.github.com/repos/code-for-canada/project-thundercat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-for-canada/project-thundercat/merges","archive_url":"https://api.github.com/repos/code-for-canada/project-thundercat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-for-canada/project-thundercat/downloads","issues_url":"https://api.github.com/repos/code-for-canada/project-thundercat/issues{/number}","pulls_url":"https://api.github.com/repos/code-for-canada/project-thundercat/pulls{/number}","milestones_url":"https://api.github.com/repos/code-for-canada/project-thundercat/milestones{/number}","notifications_url":"https://api.github.com/repos/code-for-canada/project-thundercat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-for-canada/project-thundercat/labels{/name}","releases_url":"https://api.github.com/repos/code-for-canada/project-thundercat/releases{/id}","deployments_url":"https://api.github.com/repos/code-for-canada/project-thundercat/deployments","created_at":"2019-01-02T18:17:10Z","updated_at":"2019-03-13T13:57:38Z","pushed_at":"2019-03-13T14:39:42Z","git_url":"git://github.com/code-for-canada/project-thundercat.git","ssh_url":"[email protected]:code-for-canada/project-thundercat.git","clone_url":"https://github.com/code-for-canada/project-thundercat.git","svn_url":"https://github.com/code-for-canada/project-thundercat","homepage":"","size":2729,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"code-for-canada:master","ref":"master","sha":"d0d05eb14c967d1309d42ef67a1beeb2efb33b24","user":{"login":"code-for-canada","id":32721448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzIxNDQ4","avatar_url":"https://avatars0.githubusercontent.com/u/32721448?v=4","gravatar_id":"","url":"https://api.github.com/users/code-for-canada","html_url":"https://github.com/code-for-canada","followers_url":"https://api.github.com/users/code-for-canada/followers","following_url":"https://api.github.com/users/code-for-canada/following{/other_user}","gists_url":"https://api.github.com/users/code-for-canada/gists{/gist_id}","starred_url":"https://api.github.com/users/code-for-canada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-for-canada/subscriptions","organizations_url":"https://api.github.com/users/code-for-canada/orgs","repos_url":"https://api.github.com/users/code-for-canada/repos","events_url":"https://api.github.com/users/code-for-canada/events{/privacy}","received_events_url":"https://api.github.com/users/code-for-canada/received_events","type":"Organization","site_admin":false},"repo":{"id":163874364,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM4NzQzNjQ=","name":"project-thundercat","full_name":"code-for-canada/project-thundercat","private":false,"owner":{"login":"code-for-canada","id":32721448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzIxNDQ4","avatar_url":"https://avatars0.githubusercontent.com/u/32721448?v=4","gravatar_id":"","url":"https://api.github.com/users/code-for-canada","html_url":"https://github.com/code-for-canada","followers_url":"https://api.github.com/users/code-for-canada/followers","following_url":"https://api.github.com/users/code-for-canada/following{/other_user}","gists_url":"https://api.github.com/users/code-for-canada/gists{/gist_id}","starred_url":"https://api.github.com/users/code-for-canada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-for-canada/subscriptions","organizations_url":"https://api.github.com/users/code-for-canada/orgs","repos_url":"https://api.github.com/users/code-for-canada/repos","events_url":"https://api.github.com/users/code-for-canada/events{/privacy}","received_events_url":"https://api.github.com/users/code-for-canada/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/code-for-canada/project-thundercat","description":"Code for Canada + PSC partnership project","fork":true,"url":"https://api.github.com/repos/code-for-canada/project-thundercat","forks_url":"https://api.github.com/repos/code-for-canada/project-thundercat/forks","keys_url":"https://api.github.com/repos/code-for-canada/project-thundercat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-for-canada/project-thundercat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-for-canada/project-thundercat/teams","hooks_url":"https://api.github.com/repos/code-for-canada/project-thundercat/hooks","issue_events_url":"https://api.github.com/repos/code-for-canada/project-thundercat/issues/events{/number}","events_url":"https://api.github.com/repos/code-for-canada/project-thundercat/events","assignees_url":"https://api.github.com/repos/code-for-canada/project-thundercat/assignees{/user}","branches_url":"https://api.github.com/repos/code-for-canada/project-thundercat/branches{/branch}","tags_url":"https://api.github.com/repos/code-for-canada/project-thundercat/tags","blobs_url":"https://api.github.com/repos/code-for-canada/project-thundercat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-for-canada/project-thundercat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-for-canada/project-thundercat/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-for-canada/project-thundercat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-for-canada/project-thundercat/statuses/{sha}","languages_url":"https://api.github.com/repos/code-for-canada/project-thundercat/languages","stargazers_url":"https://api.github.com/repos/code-for-canada/project-thundercat/stargazers","contributors_url":"https://api.github.com/repos/code-for-canada/project-thundercat/contributors","subscribers_url":"https://api.github.com/repos/code-for-canada/project-thundercat/subscribers","subscription_url":"https://api.github.com/repos/code-for-canada/project-thundercat/subscription","commits_url":"https://api.github.com/repos/code-for-canada/project-thundercat/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-for-canada/project-thundercat/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-for-canada/project-thundercat/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-for-canada/project-thundercat/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-for-canada/project-thundercat/contents/{+path}","compare_url":"https://api.github.com/repos/code-for-canada/project-thundercat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-for-canada/project-thundercat/merges","archive_url":"https://api.github.com/repos/code-for-canada/project-thundercat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-for-canada/project-thundercat/downloads","issues_url":"https://api.github.com/repos/code-for-canada/project-thundercat/issues{/number}","pulls_url":"https://api.github.com/repos/code-for-canada/project-thundercat/pulls{/number}","milestones_url":"https://api.github.com/repos/code-for-canada/project-thundercat/milestones{/number}","notifications_url":"https://api.github.com/repos/code-for-canada/project-thundercat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-for-canada/project-thundercat/labels{/name}","releases_url":"https://api.github.com/repos/code-for-canada/project-thundercat/releases{/id}","deployments_url":"https://api.github.com/repos/code-for-canada/project-thundercat/deployments","created_at":"2019-01-02T18:17:10Z","updated_at":"2019-03-13T13:57:38Z","pushed_at":"2019-03-13T14:39:42Z","git_url":"git://github.com/code-for-canada/project-thundercat.git","ssh_url":"[email protected]:code-for-canada/project-thundercat.git","clone_url":"https://github.com/code-for-canada/project-thundercat.git","svn_url":"https://github.com/code-for-canada/project-thundercat","homepage":"","size":2729,"stargazers_count":1,"watchers_count":1,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/code-for-canada/project-thundercat/pulls/129"},"html":{"href":"https://github.com/code-for-canada/project-thundercat/pull/129"},"issue":{"href":"https://api.github.com/repos/code-for-canada/project-thundercat/issues/129"},"comments":{"href":"https://api.github.com/repos/code-for-canada/project-thundercat/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/code-for-canada/project-thundercat/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/code-for-canada/project-thundercat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/code-for-canada/project-thundercat/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/code-for-canada/project-thundercat/statuses/9aedfe75ef7f86484ffc3743dfa5771673e56bf2"}},"author_association":"COLLABORATOR"}}	{ "id": 163874364, "name": "code-for-canada/project-thundercat", "url": "https://api.github.com/repos/code-for-canada/project-thundercat" }	{ "id": 4640747, "login": "caleybrock", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/4640747?", "url": "https://api.github.com/users/caleybrock" }	{ "id": 32721448, "login": "code-for-canada", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/32721448?", "url": "https://api.github.com/orgs/code-for-canada" }	2019-03-13T16:40:10	9236468532	{"actor":{"display_login":"caleybrock"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/pulls/comments/262368924","pull_request_review_id":210518857,"id":262368924,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MjM2ODkyNA==","diff_hunk":"@@ -1,136 +1,142 @@\n FROM python:3.6-alpine as base\n-\n-LABEL maintainer={{ cookiecutter.github_username }}\n-\n+#\n # USAGE:\n # cd sercices/{{ cookiecutter.project_slug }}\n # docker build -f Dockerfile -t {{ cookiecutter.project_slug }}:prod --target production ../../\n # docker run {{ cookiecutter.project_slug }}:prod\n #\n # REQUIRED: context expected at ``osparc-simcore/`` folder because we need access to osparc-simcore/packages\n \n-# non-root user 'scu'\n-RUN adduser -D -u 8004 scu\n+LABEL maintainer={{ cookiecutter.github_username }}\n+\n+# simcore-user uid=8004(scu) gid=8004(scu) groups=8004(scu)\n+RUN adduser -D -u 8004 -s /bin/sh -h /home/scu scu\n \n RUN apk add --no-cache \\\n su-exec\n \n-ENV HOME /home/scu\n-# TODO: Workaround for https://github.com/pypa/pip/issues/6197:\n-# - Added explicit --cache-dir that is removed at the end of the build\n-# - NOTE: After every PIP call, add rm -rf /tmp/.pipcache\n-ENV PIP /home/scu/.venv/bin/pip3 --cache-dir=/tmp/.pipcache\n+ENV PATH \"/home/scu/.local/bin:$PATH\"\n+\n+# All SC_ variables are customized\n+ENV SC_PIP pip3 --no-cache-dir\n+ENV SC_BUILD_TARGET base\n \n EXPOSE 8080\n \n-HEALTHCHECK --interval=30s \\\n- --timeout=120s \\\n- --start-period=30s \\\n- --retries=3 \\\n- CMD python3 ${HOME}/docker/healthcheck_curl_host.py \"http://localhost:8080/{{ cookiecutter.openapi_specs_version }}/\"\n \n # -------------------------- Build stage -------------------\n-# Common stage between production and development targets\n-#\n-# + /home/scu/ $HOME\n-# + packages\n-# ...\n-# + services/{{ cookiecutter.project_slug }}\n-# + src\n-# + tests\n+# Installs build/package management tools and third party dependencies\n #\n+# + /build WORKDIR\n #\n-# TODO: straight copying python packages bring unnecessary files (e.g. __pycache__) -> dockerignore!\n-# could copy and then python setup.py install OR git clone into the container.\n-# This applies for both\n-#\n-# SEE https://wiki.alpinelinux.org/wiki/Alpine_Linux_package_management\n-# SEE https://pip.pypa.io/en/stable/reference/pip_install\n-#\n+{# SEE https://wiki.alpinelinux.org/wiki/Alpine_Linux_package_management\n+# SEE https://pip.pypa.io/en/stable/reference/pip_install #}\n FROM base as build\n \n+ENV SC_BUILD_TARGET build\n+\n+{#TODO: install and uninstall lists#}\n RUN apk add --no-cache \\\n postgresql-dev \\\n libc-dev \\\n libffi-dev \\\n gcc \\\n git","path":"{{cookiecutter.project_slug}}/Dockerfile","position":74,"original_position":74,"commit_id":"3f1b9e39d466e7c6cd4670e5ec9b9c5aeb6cc986","original_commit_id":"3f1b9e39d466e7c6cd4670e5ec9b9c5aeb6cc986","user":{"login":"sanderegg","id":35365065,"node_id":"MDQ6VXNlcjM1MzY1MDY1","avatar_url":"https://avatars2.githubusercontent.com/u/35365065?v=4","gravatar_id":"","url":"https://api.github.com/users/sanderegg","html_url":"https://github.com/sanderegg","followers_url":"https://api.github.com/users/sanderegg/followers","following_url":"https://api.github.com/users/sanderegg/following{/other_user}","gists_url":"https://api.github.com/users/sanderegg/gists{/gist_id}","starred_url":"https://api.github.com/users/sanderegg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanderegg/subscriptions","organizations_url":"https://api.github.com/users/sanderegg/orgs","repos_url":"https://api.github.com/users/sanderegg/repos","events_url":"https://api.github.com/users/sanderegg/events{/privacy}","received_events_url":"https://api.github.com/users/sanderegg/received_events","type":"User","site_admin":false},"body":"I would tend to not bloat the service with things that are not necessary. It is easy to add whatever is needed later. I would either comment the unnecesary ones or delete them.","created_at":"2019-03-05T07:04:06Z","updated_at":"2019-03-05T07:04:06Z","html_url":"https://github.com/ITISFoundation/cookiecutter-simcore-pyservice/pull/6#discussion_r262368924","pull_request_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/pulls/6","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/pulls/comments/262368924"},"html":{"href":"https://github.com/ITISFoundation/cookiecutter-simcore-pyservice/pull/6#discussion_r262368924"},"pull_request":{"href":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/pulls/6"}},"in_reply_to_id":261669327},"pull_request":{"url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/pulls/6","id":251988428,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxOTg4NDI4","html_url":"https://github.com/ITISFoundation/cookiecutter-simcore-pyservice/pull/6","diff_url":"https://github.com/ITISFoundation/cookiecutter-simcore-pyservice/pull/6.diff","patch_url":"https://github.com/ITISFoundation/cookiecutter-simcore-pyservice/pull/6.patch","issue_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/issues/6","number":6,"state":"open","locked":false,"title":"Fix/integration","user":{"login":"pcrespov","id":32402063,"node_id":"MDQ6VXNlcjMyNDAyMDYz","avatar_url":"https://avatars3.githubusercontent.com/u/32402063?v=4","gravatar_id":"","url":"https://api.github.com/users/pcrespov","html_url":"https://github.com/pcrespov","followers_url":"https://api.github.com/users/pcrespov/followers","following_url":"https://api.github.com/users/pcrespov/following{/other_user}","gists_url":"https://api.github.com/users/pcrespov/gists{/gist_id}","starred_url":"https://api.github.com/users/pcrespov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcrespov/subscriptions","organizations_url":"https://api.github.com/users/pcrespov/orgs","repos_url":"https://api.github.com/users/pcrespov/repos","events_url":"https://api.github.com/users/pcrespov/events{/privacy}","received_events_url":"https://api.github.com/users/pcrespov/received_events","type":"User","site_admin":false},"body":"## What do these changes do?\r\n\r\nFixes while integrating cc in osparc-simcore development workflow\r\n\r\n## Related issue number\r\n\r\n## Checklist\r\n\r\n- [ ] I think the code is well written\r\n- [ ] Unit tests for the changes exist\r\n- [ ] Documentation reflects the changes\r\n- [ ] If you design a new module, add your user to .github/CODEOWNERS\r\n","created_at":"2019-02-11T16:55:22Z","updated_at":"2019-03-05T07:04:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9de5abc047eaf2064351782115b62285d77526bf","assignee":{"login":"sanderegg","id":35365065,"node_id":"MDQ6VXNlcjM1MzY1MDY1","avatar_url":"https://avatars2.githubusercontent.com/u/35365065?v=4","gravatar_id":"","url":"https://api.github.com/users/sanderegg","html_url":"https://github.com/sanderegg","followers_url":"https://api.github.com/users/sanderegg/followers","following_url":"https://api.github.com/users/sanderegg/following{/other_user}","gists_url":"https://api.github.com/users/sanderegg/gists{/gist_id}","starred_url":"https://api.github.com/users/sanderegg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanderegg/subscriptions","organizations_url":"https://api.github.com/users/sanderegg/orgs","repos_url":"https://api.github.com/users/sanderegg/repos","events_url":"https://api.github.com/users/sanderegg/events{/privacy}","received_events_url":"https://api.github.com/users/sanderegg/received_events","type":"User","site_admin":false},"assignees":[{"login":"sanderegg","id":35365065,"node_id":"MDQ6VXNlcjM1MzY1MDY1","avatar_url":"https://avatars2.githubusercontent.com/u/35365065?v=4","gravatar_id":"","url":"https://api.github.com/users/sanderegg","html_url":"https://github.com/sanderegg","followers_url":"https://api.github.com/users/sanderegg/followers","following_url":"https://api.github.com/users/sanderegg/following{/other_user}","gists_url":"https://api.github.com/users/sanderegg/gists{/gist_id}","starred_url":"https://api.github.com/users/sanderegg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanderegg/subscriptions","organizations_url":"https://api.github.com/users/sanderegg/orgs","repos_url":"https://api.github.com/users/sanderegg/repos","events_url":"https://api.github.com/users/sanderegg/events{/privacy}","received_events_url":"https://api.github.com/users/sanderegg/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1254431340,"node_id":"MDU6TGFiZWwxMjU0NDMxMzQw","url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/pulls/6/commits","review_comments_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/pulls/6/comments","review_comment_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/issues/6/comments","statuses_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/statuses/3f1b9e39d466e7c6cd4670e5ec9b9c5aeb6cc986","head":{"label":"pcrespov:fix/integration","ref":"fix/integration","sha":"3f1b9e39d466e7c6cd4670e5ec9b9c5aeb6cc986","user":{"login":"pcrespov","id":32402063,"node_id":"MDQ6VXNlcjMyNDAyMDYz","avatar_url":"https://avatars3.githubusercontent.com/u/32402063?v=4","gravatar_id":"","url":"https://api.github.com/users/pcrespov","html_url":"https://github.com/pcrespov","followers_url":"https://api.github.com/users/pcrespov/followers","following_url":"https://api.github.com/users/pcrespov/following{/other_user}","gists_url":"https://api.github.com/users/pcrespov/gists{/gist_id}","starred_url":"https://api.github.com/users/pcrespov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcrespov/subscriptions","organizations_url":"https://api.github.com/users/pcrespov/orgs","repos_url":"https://api.github.com/users/pcrespov/repos","events_url":"https://api.github.com/users/pcrespov/events{/privacy}","received_events_url":"https://api.github.com/users/pcrespov/received_events","type":"User","site_admin":false},"repo":{"id":152110139,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIxMTAxMzk=","name":"cookiecutter-simcore-pyservice","full_name":"pcrespov/cookiecutter-simcore-pyservice","private":false,"owner":{"login":"pcrespov","id":32402063,"node_id":"MDQ6VXNlcjMyNDAyMDYz","avatar_url":"https://avatars3.githubusercontent.com/u/32402063?v=4","gravatar_id":"","url":"https://api.github.com/users/pcrespov","html_url":"https://github.com/pcrespov","followers_url":"https://api.github.com/users/pcrespov/followers","following_url":"https://api.github.com/users/pcrespov/following{/other_user}","gists_url":"https://api.github.com/users/pcrespov/gists{/gist_id}","starred_url":"https://api.github.com/users/pcrespov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcrespov/subscriptions","organizations_url":"https://api.github.com/users/pcrespov/orgs","repos_url":"https://api.github.com/users/pcrespov/repos","events_url":"https://api.github.com/users/pcrespov/events{/privacy}","received_events_url":"https://api.github.com/users/pcrespov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pcrespov/cookiecutter-simcore-pyservice","description":"Cookiecutter template for osparc-simcore's python-based services","fork":true,"url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice","forks_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/forks","keys_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/teams","hooks_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/hooks","issue_events_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/issues/events{/number}","events_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/events","assignees_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/assignees{/user}","branches_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/branches{/branch}","tags_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/tags","blobs_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/statuses/{sha}","languages_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/languages","stargazers_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/stargazers","contributors_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/contributors","subscribers_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/subscribers","subscription_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/subscription","commits_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/contents/{+path}","compare_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/merges","archive_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/downloads","issues_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/issues{/number}","pulls_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/pulls{/number}","milestones_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/milestones{/number}","notifications_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/labels{/name}","releases_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/releases{/id}","deployments_url":"https://api.github.com/repos/pcrespov/cookiecutter-simcore-pyservice/deployments","created_at":"2018-10-08T16:15:44Z","updated_at":"2019-02-11T16:53:44Z","pushed_at":"2019-03-01T15:50:45Z","git_url":"git://github.com/pcrespov/cookiecutter-simcore-pyservice.git","ssh_url":"[email protected]:pcrespov/cookiecutter-simcore-pyservice.git","clone_url":"https://github.com/pcrespov/cookiecutter-simcore-pyservice.git","svn_url":"https://github.com/pcrespov/cookiecutter-simcore-pyservice","homepage":null,"size":122,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ITISFoundation:master","ref":"master","sha":"a3b56df79fb59df22d6d7f7e786b5310d35a3b93","user":{"login":"ITISFoundation","id":32800832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODAwODMy","avatar_url":"https://avatars0.githubusercontent.com/u/32800832?v=4","gravatar_id":"","url":"https://api.github.com/users/ITISFoundation","html_url":"https://github.com/ITISFoundation","followers_url":"https://api.github.com/users/ITISFoundation/followers","following_url":"https://api.github.com/users/ITISFoundation/following{/other_user}","gists_url":"https://api.github.com/users/ITISFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/ITISFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ITISFoundation/subscriptions","organizations_url":"https://api.github.com/users/ITISFoundation/orgs","repos_url":"https://api.github.com/users/ITISFoundation/repos","events_url":"https://api.github.com/users/ITISFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/ITISFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":151701223,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3MDEyMjM=","name":"cookiecutter-simcore-pyservice","full_name":"ITISFoundation/cookiecutter-simcore-pyservice","private":false,"owner":{"login":"ITISFoundation","id":32800832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODAwODMy","avatar_url":"https://avatars0.githubusercontent.com/u/32800832?v=4","gravatar_id":"","url":"https://api.github.com/users/ITISFoundation","html_url":"https://github.com/ITISFoundation","followers_url":"https://api.github.com/users/ITISFoundation/followers","following_url":"https://api.github.com/users/ITISFoundation/following{/other_user}","gists_url":"https://api.github.com/users/ITISFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/ITISFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ITISFoundation/subscriptions","organizations_url":"https://api.github.com/users/ITISFoundation/orgs","repos_url":"https://api.github.com/users/ITISFoundation/repos","events_url":"https://api.github.com/users/ITISFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/ITISFoundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ITISFoundation/cookiecutter-simcore-pyservice","description":"Cookiecutter template for osparc-simcore's python-based core services","fork":false,"url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice","forks_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/forks","keys_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/teams","hooks_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/hooks","issue_events_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/issues/events{/number}","events_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/events","assignees_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/assignees{/user}","branches_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/branches{/branch}","tags_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/tags","blobs_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/git/refs{/sha}","trees_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/statuses/{sha}","languages_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/languages","stargazers_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/stargazers","contributors_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/contributors","subscribers_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/subscribers","subscription_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/subscription","commits_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/commits{/sha}","git_commits_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/git/commits{/sha}","comments_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/comments{/number}","issue_comment_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/issues/comments{/number}","contents_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/contents/{+path}","compare_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/merges","archive_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/downloads","issues_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/issues{/number}","pulls_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/pulls{/number}","milestones_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/milestones{/number}","notifications_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/labels{/name}","releases_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/releases{/id}","deployments_url":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/deployments","created_at":"2018-10-05T09:52:29Z","updated_at":"2019-02-01T20:24:37Z","pushed_at":"2019-03-01T15:50:46Z","git_url":"git://github.com/ITISFoundation/cookiecutter-simcore-pyservice.git","ssh_url":"[email protected]:ITISFoundation/cookiecutter-simcore-pyservice.git","clone_url":"https://github.com/ITISFoundation/cookiecutter-simcore-pyservice.git","svn_url":"https://github.com/ITISFoundation/cookiecutter-simcore-pyservice","homepage":"","size":77,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/pulls/6"},"html":{"href":"https://github.com/ITISFoundation/cookiecutter-simcore-pyservice/pull/6"},"issue":{"href":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/issues/6"},"comments":{"href":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice/statuses/3f1b9e39d466e7c6cd4670e5ec9b9c5aeb6cc986"}},"author_association":"MEMBER"}}	{ "id": 151701223, "name": "ITISFoundation/cookiecutter-simcore-pyservice", "url": "https://api.github.com/repos/ITISFoundation/cookiecutter-simcore-pyservice" }	{ "id": 35365065, "login": "sanderegg", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/35365065?", "url": "https://api.github.com/users/sanderegg" }	{ "id": 32800832, "login": "ITISFoundation", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/32800832?", "url": "https://api.github.com/orgs/ITISFoundation" }	2019-03-05T07:04:06	9180311477	{"actor":{"display_login":"sanderegg"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/gismo/gismo/pulls/comments/257724522","pull_request_review_id":204824419,"id":257724522,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NzcyNDUyMg==","diff_hunk":"@@ -396,15 +462,37 @@ endif()\n \n set(ENV{CTEST_USE_LAUNCHERS_DEFAULT} 1)\n \n-function(update_gismo updcount)\n- ctest_update(RETURN_VALUE updcount)\n- if(UPDATE_MODULES)\n- execute_process(COMMAND \"${CTEST_UPDATE_COMMAND}\" \"submodule\" \"update\" \"--remote\"\n- WORKING_DIRECTORY ${gismo_SOURCE_DIR}\n- #RESULT_VARIABLE gresult\n- #OUTPUT_QUIET\n- )\n+macro(get_git_status res)\n+ execute_process(COMMAND ${CTEST_UPDATE_COMMAND} rev-parse --verify HEAD\n+ WORKING_DIRECTORY ${CTEST_SOURCE_DIRECTORY}\n+ OUTPUT_STRIP_TRAILING_WHITESPACE\n+ OUTPUT_VARIABLE gitHash)\n+ execute_process(COMMAND ${CTEST_UPDATE_COMMAND} submodule\n+ WORKING_DIRECTORY ${CTEST_SOURCE_DIRECTORY}\n+ OUTPUT_VARIABLE submoduleHashes)\n+ set(${res} \" ${gitHash} gismo\\n${submoduleHashes}\\n\")\n+endmacro(get_git_status)\n+\n+function(update_gismo ug_ucount)\n+ #this should be last.\n+ ctest_update(SOURCE ${CTEST_SOURCE_DIRECTORY} RETURN_VALUE updcount)","path":"cmake/ctest_script.cmake","position":125,"original_position":125,"commit_id":"6b10470bd5f682aefd3d98b250457962a153a187","original_commit_id":"6b10470bd5f682aefd3d98b250457962a153a187","user":{"login":"filiatra","id":3185717,"node_id":"MDQ6VXNlcjMxODU3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3185717?v=4","gravatar_id":"","url":"https://api.github.com/users/filiatra","html_url":"https://github.com/filiatra","followers_url":"https://api.github.com/users/filiatra/followers","following_url":"https://api.github.com/users/filiatra/following{/other_user}","gists_url":"https://api.github.com/users/filiatra/gists{/gist_id}","starred_url":"https://api.github.com/users/filiatra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filiatra/subscriptions","organizations_url":"https://api.github.com/users/filiatra/orgs","repos_url":"https://api.github.com/users/filiatra/repos","events_url":"https://api.github.com/users/filiatra/events{/privacy}","received_events_url":"https://api.github.com/users/filiatra/received_events","type":"User","site_admin":false},"body":"This should update the submodules not to HEAD, but detached mode..","created_at":"2019-02-18T14:49:25Z","updated_at":"2019-02-18T14:49:26Z","html_url":"https://github.com/gismo/gismo/pull/287#discussion_r257724522","pull_request_url":"https://api.github.com/repos/gismo/gismo/pulls/287","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gismo/gismo/pulls/comments/257724522"},"html":{"href":"https://github.com/gismo/gismo/pull/287#discussion_r257724522"},"pull_request":{"href":"https://api.github.com/repos/gismo/gismo/pulls/287"}},"in_reply_to_id":257714502},"pull_request":{"url":"https://api.github.com/repos/gismo/gismo/pulls/287","id":245889216,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ1ODg5MjE2","html_url":"https://github.com/gismo/gismo/pull/287","diff_url":"https://github.com/gismo/gismo/pull/287.diff","patch_url":"https://github.com/gismo/gismo/pull/287.patch","issue_url":"https://api.github.com/repos/gismo/gismo/issues/287","number":287,"state":"open","locked":false,"title":"Issue3","user":{"login":"codewerfer","id":29753931,"node_id":"MDQ6VXNlcjI5NzUzOTMx","avatar_url":"https://avatars2.githubusercontent.com/u/29753931?v=4","gravatar_id":"","url":"https://api.github.com/users/codewerfer","html_url":"https://github.com/codewerfer","followers_url":"https://api.github.com/users/codewerfer/followers","following_url":"https://api.github.com/users/codewerfer/following{/other_user}","gists_url":"https://api.github.com/users/codewerfer/gists{/gist_id}","starred_url":"https://api.github.com/users/codewerfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codewerfer/subscriptions","organizations_url":"https://api.github.com/users/codewerfer/orgs","repos_url":"https://api.github.com/users/codewerfer/repos","events_url":"https://api.github.com/users/codewerfer/events{/privacy}","received_events_url":"https://api.github.com/users/codewerfer/received_events","type":"User","site_admin":false},"body":"fix part of https://github.com/gismo/internal/issues/3\r\n\r\n* change branch to master for submodules at init. (this affects all cmake . builds)\r\n * add KEEPBRANCH parameter - ignores master branch\r\n * logic to change branch in every submodule individual","created_at":"2019-01-18T15:49:25Z","updated_at":"2019-02-18T14:49:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9945c66e55d01bc9e11e422008a581b0ca290964","assignee":{"login":"filiatra","id":3185717,"node_id":"MDQ6VXNlcjMxODU3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3185717?v=4","gravatar_id":"","url":"https://api.github.com/users/filiatra","html_url":"https://github.com/filiatra","followers_url":"https://api.github.com/users/filiatra/followers","following_url":"https://api.github.com/users/filiatra/following{/other_user}","gists_url":"https://api.github.com/users/filiatra/gists{/gist_id}","starred_url":"https://api.github.com/users/filiatra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filiatra/subscriptions","organizations_url":"https://api.github.com/users/filiatra/orgs","repos_url":"https://api.github.com/users/filiatra/repos","events_url":"https://api.github.com/users/filiatra/events{/privacy}","received_events_url":"https://api.github.com/users/filiatra/received_events","type":"User","site_admin":false},"assignees":[{"login":"filiatra","id":3185717,"node_id":"MDQ6VXNlcjMxODU3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3185717?v=4","gravatar_id":"","url":"https://api.github.com/users/filiatra","html_url":"https://github.com/filiatra","followers_url":"https://api.github.com/users/filiatra/followers","following_url":"https://api.github.com/users/filiatra/following{/other_user}","gists_url":"https://api.github.com/users/filiatra/gists{/gist_id}","starred_url":"https://api.github.com/users/filiatra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filiatra/subscriptions","organizations_url":"https://api.github.com/users/filiatra/orgs","repos_url":"https://api.github.com/users/filiatra/repos","events_url":"https://api.github.com/users/filiatra/events{/privacy}","received_events_url":"https://api.github.com/users/filiatra/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"filiatra","id":3185717,"node_id":"MDQ6VXNlcjMxODU3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3185717?v=4","gravatar_id":"","url":"https://api.github.com/users/filiatra","html_url":"https://github.com/filiatra","followers_url":"https://api.github.com/users/filiatra/followers","following_url":"https://api.github.com/users/filiatra/following{/other_user}","gists_url":"https://api.github.com/users/filiatra/gists{/gist_id}","starred_url":"https://api.github.com/users/filiatra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filiatra/subscriptions","organizations_url":"https://api.github.com/users/filiatra/orgs","repos_url":"https://api.github.com/users/filiatra/repos","events_url":"https://api.github.com/users/filiatra/events{/privacy}","received_events_url":"https://api.github.com/users/filiatra/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gismo/gismo/pulls/287/commits","review_comments_url":"https://api.github.com/repos/gismo/gismo/pulls/287/comments","review_comment_url":"https://api.github.com/repos/gismo/gismo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gismo/gismo/issues/287/comments","statuses_url":"https://api.github.com/repos/gismo/gismo/statuses/6b10470bd5f682aefd3d98b250457962a153a187","head":{"label":"gismo:issue3","ref":"issue3","sha":"6b10470bd5f682aefd3d98b250457962a153a187","user":{"login":"gismo","id":32823466,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODIzNDY2","avatar_url":"https://avatars2.githubusercontent.com/u/32823466?v=4","gravatar_id":"","url":"https://api.github.com/users/gismo","html_url":"https://github.com/gismo","followers_url":"https://api.github.com/users/gismo/followers","following_url":"https://api.github.com/users/gismo/following{/other_user}","gists_url":"https://api.github.com/users/gismo/gists{/gist_id}","starred_url":"https://api.github.com/users/gismo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gismo/subscriptions","organizations_url":"https://api.github.com/users/gismo/orgs","repos_url":"https://api.github.com/users/gismo/repos","events_url":"https://api.github.com/users/gismo/events{/privacy}","received_events_url":"https://api.github.com/users/gismo/received_events","type":"Organization","site_admin":false},"repo":{"id":35604128,"node_id":"MDEwOlJlcG9zaXRvcnkzNTYwNDEyOA==","name":"gismo","full_name":"gismo/gismo","private":false,"owner":{"login":"gismo","id":32823466,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODIzNDY2","avatar_url":"https://avatars2.githubusercontent.com/u/32823466?v=4","gravatar_id":"","url":"https://api.github.com/users/gismo","html_url":"https://github.com/gismo","followers_url":"https://api.github.com/users/gismo/followers","following_url":"https://api.github.com/users/gismo/following{/other_user}","gists_url":"https://api.github.com/users/gismo/gists{/gist_id}","starred_url":"https://api.github.com/users/gismo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gismo/subscriptions","organizations_url":"https://api.github.com/users/gismo/orgs","repos_url":"https://api.github.com/users/gismo/repos","events_url":"https://api.github.com/users/gismo/events{/privacy}","received_events_url":"https://api.github.com/users/gismo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gismo/gismo","description":"G+Smo (pronounced gismo or gizmo) is a C++ library for isogeometric analysis (IGA). Geometry plus simulation modules aims at the seamless integration of Computer-aided Design (CAD) and Finite Element Analysis (FEA).","fork":false,"url":"https://api.github.com/repos/gismo/gismo","forks_url":"https://api.github.com/repos/gismo/gismo/forks","keys_url":"https://api.github.com/repos/gismo/gismo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gismo/gismo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gismo/gismo/teams","hooks_url":"https://api.github.com/repos/gismo/gismo/hooks","issue_events_url":"https://api.github.com/repos/gismo/gismo/issues/events{/number}","events_url":"https://api.github.com/repos/gismo/gismo/events","assignees_url":"https://api.github.com/repos/gismo/gismo/assignees{/user}","branches_url":"https://api.github.com/repos/gismo/gismo/branches{/branch}","tags_url":"https://api.github.com/repos/gismo/gismo/tags","blobs_url":"https://api.github.com/repos/gismo/gismo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gismo/gismo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gismo/gismo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gismo/gismo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gismo/gismo/statuses/{sha}","languages_url":"https://api.github.com/repos/gismo/gismo/languages","stargazers_url":"https://api.github.com/repos/gismo/gismo/stargazers","contributors_url":"https://api.github.com/repos/gismo/gismo/contributors","subscribers_url":"https://api.github.com/repos/gismo/gismo/subscribers","subscription_url":"https://api.github.com/repos/gismo/gismo/subscription","commits_url":"https://api.github.com/repos/gismo/gismo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gismo/gismo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gismo/gismo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gismo/gismo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gismo/gismo/contents/{+path}","compare_url":"https://api.github.com/repos/gismo/gismo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gismo/gismo/merges","archive_url":"https://api.github.com/repos/gismo/gismo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gismo/gismo/downloads","issues_url":"https://api.github.com/repos/gismo/gismo/issues{/number}","pulls_url":"https://api.github.com/repos/gismo/gismo/pulls{/number}","milestones_url":"https://api.github.com/repos/gismo/gismo/milestones{/number}","notifications_url":"https://api.github.com/repos/gismo/gismo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gismo/gismo/labels{/name}","releases_url":"https://api.github.com/repos/gismo/gismo/releases{/id}","deployments_url":"https://api.github.com/repos/gismo/gismo/deployments","created_at":"2015-05-14T09:57:52Z","updated_at":"2019-02-15T16:42:36Z","pushed_at":"2019-02-18T14:14:57Z","git_url":"git://github.com/gismo/gismo.git","ssh_url":"[email protected]:gismo/gismo.git","clone_url":"https://github.com/gismo/gismo.git","svn_url":"https://github.com/gismo/gismo","homepage":"http://gs.jku.at/gismo","size":40061,"stargazers_count":62,"watchers_count":62,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":25,"open_issues":23,"watchers":62,"default_branch":"stable"}},"base":{"label":"gismo:stable","ref":"stable","sha":"f0ff51a90b41e979a4b8a6b10124614a3278e188","user":{"login":"gismo","id":32823466,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODIzNDY2","avatar_url":"https://avatars2.githubusercontent.com/u/32823466?v=4","gravatar_id":"","url":"https://api.github.com/users/gismo","html_url":"https://github.com/gismo","followers_url":"https://api.github.com/users/gismo/followers","following_url":"https://api.github.com/users/gismo/following{/other_user}","gists_url":"https://api.github.com/users/gismo/gists{/gist_id}","starred_url":"https://api.github.com/users/gismo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gismo/subscriptions","organizations_url":"https://api.github.com/users/gismo/orgs","repos_url":"https://api.github.com/users/gismo/repos","events_url":"https://api.github.com/users/gismo/events{/privacy}","received_events_url":"https://api.github.com/users/gismo/received_events","type":"Organization","site_admin":false},"repo":{"id":35604128,"node_id":"MDEwOlJlcG9zaXRvcnkzNTYwNDEyOA==","name":"gismo","full_name":"gismo/gismo","private":false,"owner":{"login":"gismo","id":32823466,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODIzNDY2","avatar_url":"https://avatars2.githubusercontent.com/u/32823466?v=4","gravatar_id":"","url":"https://api.github.com/users/gismo","html_url":"https://github.com/gismo","followers_url":"https://api.github.com/users/gismo/followers","following_url":"https://api.github.com/users/gismo/following{/other_user}","gists_url":"https://api.github.com/users/gismo/gists{/gist_id}","starred_url":"https://api.github.com/users/gismo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gismo/subscriptions","organizations_url":"https://api.github.com/users/gismo/orgs","repos_url":"https://api.github.com/users/gismo/repos","events_url":"https://api.github.com/users/gismo/events{/privacy}","received_events_url":"https://api.github.com/users/gismo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gismo/gismo","description":"G+Smo (pronounced gismo or gizmo) is a C++ library for isogeometric analysis (IGA). Geometry plus simulation modules aims at the seamless integration of Computer-aided Design (CAD) and Finite Element Analysis (FEA).","fork":false,"url":"https://api.github.com/repos/gismo/gismo","forks_url":"https://api.github.com/repos/gismo/gismo/forks","keys_url":"https://api.github.com/repos/gismo/gismo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gismo/gismo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gismo/gismo/teams","hooks_url":"https://api.github.com/repos/gismo/gismo/hooks","issue_events_url":"https://api.github.com/repos/gismo/gismo/issues/events{/number}","events_url":"https://api.github.com/repos/gismo/gismo/events","assignees_url":"https://api.github.com/repos/gismo/gismo/assignees{/user}","branches_url":"https://api.github.com/repos/gismo/gismo/branches{/branch}","tags_url":"https://api.github.com/repos/gismo/gismo/tags","blobs_url":"https://api.github.com/repos/gismo/gismo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gismo/gismo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gismo/gismo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gismo/gismo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gismo/gismo/statuses/{sha}","languages_url":"https://api.github.com/repos/gismo/gismo/languages","stargazers_url":"https://api.github.com/repos/gismo/gismo/stargazers","contributors_url":"https://api.github.com/repos/gismo/gismo/contributors","subscribers_url":"https://api.github.com/repos/gismo/gismo/subscribers","subscription_url":"https://api.github.com/repos/gismo/gismo/subscription","commits_url":"https://api.github.com/repos/gismo/gismo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gismo/gismo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gismo/gismo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gismo/gismo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gismo/gismo/contents/{+path}","compare_url":"https://api.github.com/repos/gismo/gismo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gismo/gismo/merges","archive_url":"https://api.github.com/repos/gismo/gismo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gismo/gismo/downloads","issues_url":"https://api.github.com/repos/gismo/gismo/issues{/number}","pulls_url":"https://api.github.com/repos/gismo/gismo/pulls{/number}","milestones_url":"https://api.github.com/repos/gismo/gismo/milestones{/number}","notifications_url":"https://api.github.com/repos/gismo/gismo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gismo/gismo/labels{/name}","releases_url":"https://api.github.com/repos/gismo/gismo/releases{/id}","deployments_url":"https://api.github.com/repos/gismo/gismo/deployments","created_at":"2015-05-14T09:57:52Z","updated_at":"2019-02-15T16:42:36Z","pushed_at":"2019-02-18T14:14:57Z","git_url":"git://github.com/gismo/gismo.git","ssh_url":"[email protected]:gismo/gismo.git","clone_url":"https://github.com/gismo/gismo.git","svn_url":"https://github.com/gismo/gismo","homepage":"http://gs.jku.at/gismo","size":40061,"stargazers_count":62,"watchers_count":62,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":25,"open_issues":23,"watchers":62,"default_branch":"stable"}},"_links":{"self":{"href":"https://api.github.com/repos/gismo/gismo/pulls/287"},"html":{"href":"https://github.com/gismo/gismo/pull/287"},"issue":{"href":"https://api.github.com/repos/gismo/gismo/issues/287"},"comments":{"href":"https://api.github.com/repos/gismo/gismo/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/gismo/gismo/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/gismo/gismo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gismo/gismo/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/gismo/gismo/statuses/6b10470bd5f682aefd3d98b250457962a153a187"}},"author_association":"MEMBER"}}	{ "id": 35604128, "name": "gismo/gismo", "url": "https://api.github.com/repos/gismo/gismo" }	{ "id": 3185717, "login": "filiatra", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/3185717?", "url": "https://api.github.com/users/filiatra" }	{ "id": 32823466, "login": "gismo", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/32823466?", "url": "https://api.github.com/orgs/gismo" }	2019-02-18T14:49:25	9087874886	{"actor":{"display_login":"filiatra"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/singnet/dev-portal/pulls/comments/267272140","pull_request_review_id":216635630,"id":267272140,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NzI3MjE0MA==","diff_hunk":"@@ -213,7 +213,7 @@ You need to specify the following parameters:\n * `SERVICE_DISPLAY_NAME` - Display name of your service. You can choose any name you want. \n * `PAYMENT_ADDRESS` - Ethereum account which will receive payments for this service. You should set it to your ethereum account. \n * `SERVICE_ENDPOINT` - Endpoint which will be used to connect to your service.\n-* `FIXED_PRICE` - Price in AGI for a single call to your service. We will set the price to 1 COG (remember that 1 AGI = 10^8 COGS).\n+* `FIXED_PRICE` - Price in AGI for a single call to your service. We will set the price to 10^-8 AGI (remember that 10^-8 AGI = 1 GOG).","path":"tutorials/publish/index.md","position":5,"original_position":5,"commit_id":"957571f007fb3cc1db08f027f273e6a577c79ae8","original_commit_id":"957571f007fb3cc1db08f027f273e6a577c79ae8","user":{"login":"arturgontijo","id":15108323,"node_id":"MDQ6VXNlcjE1MTA4MzIz","avatar_url":"https://avatars0.githubusercontent.com/u/15108323?v=4","gravatar_id":"","url":"https://api.github.com/users/arturgontijo","html_url":"https://github.com/arturgontijo","followers_url":"https://api.github.com/users/arturgontijo/followers","following_url":"https://api.github.com/users/arturgontijo/following{/other_user}","gists_url":"https://api.github.com/users/arturgontijo/gists{/gist_id}","starred_url":"https://api.github.com/users/arturgontijo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arturgontijo/subscriptions","organizations_url":"https://api.github.com/users/arturgontijo/orgs","repos_url":"https://api.github.com/users/arturgontijo/repos","events_url":"https://api.github.com/users/arturgontijo/events{/privacy}","received_events_url":"https://api.github.com/users/arturgontijo/received_events","type":"User","site_admin":false},"body":"`GOG -> COG`\r\n\r\nWe have some other parts of tutorial (7) that uses COGs, maybe we should change them too.","created_at":"2019-03-20T10:29:48Z","updated_at":"2019-03-20T10:31:31Z","html_url":"https://github.com/singnet/dev-portal/pull/42#discussion_r267272140","pull_request_url":"https://api.github.com/repos/singnet/dev-portal/pulls/42","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/singnet/dev-portal/pulls/comments/267272140"},"html":{"href":"https://github.com/singnet/dev-portal/pull/42#discussion_r267272140"},"pull_request":{"href":"https://api.github.com/repos/singnet/dev-portal/pulls/42"}}},"pull_request":{"url":"https://api.github.com/repos/singnet/dev-portal/pulls/42","id":262786810,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYyNzg2ODEw","html_url":"https://github.com/singnet/dev-portal/pull/42","diff_url":"https://github.com/singnet/dev-portal/pull/42.diff","patch_url":"https://github.com/singnet/dev-portal/pull/42.patch","issue_url":"https://api.github.com/repos/singnet/dev-portal/issues/42","number":42,"state":"open","locked":false,"title":"Replacing COGS by AGI in comment to make it more clear","user":{"login":"vsbogd","id":983480,"node_id":"MDQ6VXNlcjk4MzQ4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/983480?v=4","gravatar_id":"","url":"https://api.github.com/users/vsbogd","html_url":"https://github.com/vsbogd","followers_url":"https://api.github.com/users/vsbogd/followers","following_url":"https://api.github.com/users/vsbogd/following{/other_user}","gists_url":"https://api.github.com/users/vsbogd/gists{/gist_id}","starred_url":"https://api.github.com/users/vsbogd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsbogd/subscriptions","organizations_url":"https://api.github.com/users/vsbogd/orgs","repos_url":"https://api.github.com/users/vsbogd/repos","events_url":"https://api.github.com/users/vsbogd/events{/privacy}","received_events_url":"https://api.github.com/users/vsbogd/received_events","type":"User","site_admin":false},"body":"Two changes:\r\n- change the price setting description as after reading original text I had impression that user should use `--fixed-price 1` instead of `--fixed price 0.00000001`\r\n- add separate docker image with SingularityNET components source code for Amsterdam meetup","created_at":"2019-03-20T09:40:39Z","updated_at":"2019-03-20T10:31:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0252d2e6149a0092538f8d6d18534cef6c364d84","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/singnet/dev-portal/pulls/42/commits","review_comments_url":"https://api.github.com/repos/singnet/dev-portal/pulls/42/comments","review_comment_url":"https://api.github.com/repos/singnet/dev-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/singnet/dev-portal/issues/42/comments","statuses_url":"https://api.github.com/repos/singnet/dev-portal/statuses/957571f007fb3cc1db08f027f273e6a577c79ae8","head":{"label":"vsbogd:amsterdam-meetup-docker","ref":"amsterdam-meetup-docker","sha":"957571f007fb3cc1db08f027f273e6a577c79ae8","user":{"login":"vsbogd","id":983480,"node_id":"MDQ6VXNlcjk4MzQ4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/983480?v=4","gravatar_id":"","url":"https://api.github.com/users/vsbogd","html_url":"https://github.com/vsbogd","followers_url":"https://api.github.com/users/vsbogd/followers","following_url":"https://api.github.com/users/vsbogd/following{/other_user}","gists_url":"https://api.github.com/users/vsbogd/gists{/gist_id}","starred_url":"https://api.github.com/users/vsbogd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsbogd/subscriptions","organizations_url":"https://api.github.com/users/vsbogd/orgs","repos_url":"https://api.github.com/users/vsbogd/repos","events_url":"https://api.github.com/users/vsbogd/events{/privacy}","received_events_url":"https://api.github.com/users/vsbogd/received_events","type":"User","site_admin":false},"repo":{"id":162717617,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI3MTc2MTc=","name":"dev-portal","full_name":"vsbogd/dev-portal","private":false,"owner":{"login":"vsbogd","id":983480,"node_id":"MDQ6VXNlcjk4MzQ4MA==","avatar_url":"https://avatars0.githubusercontent.com/u/983480?v=4","gravatar_id":"","url":"https://api.github.com/users/vsbogd","html_url":"https://github.com/vsbogd","followers_url":"https://api.github.com/users/vsbogd/followers","following_url":"https://api.github.com/users/vsbogd/following{/other_user}","gists_url":"https://api.github.com/users/vsbogd/gists{/gist_id}","starred_url":"https://api.github.com/users/vsbogd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsbogd/subscriptions","organizations_url":"https://api.github.com/users/vsbogd/orgs","repos_url":"https://api.github.com/users/vsbogd/repos","events_url":"https://api.github.com/users/vsbogd/events{/privacy}","received_events_url":"https://api.github.com/users/vsbogd/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vsbogd/dev-portal","description":"The SingularityNET Developer Portal where you can find all our documentation, tutorials, and developer resources!","fork":true,"url":"https://api.github.com/repos/vsbogd/dev-portal","forks_url":"https://api.github.com/repos/vsbogd/dev-portal/forks","keys_url":"https://api.github.com/repos/vsbogd/dev-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vsbogd/dev-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vsbogd/dev-portal/teams","hooks_url":"https://api.github.com/repos/vsbogd/dev-portal/hooks","issue_events_url":"https://api.github.com/repos/vsbogd/dev-portal/issues/events{/number}","events_url":"https://api.github.com/repos/vsbogd/dev-portal/events","assignees_url":"https://api.github.com/repos/vsbogd/dev-portal/assignees{/user}","branches_url":"https://api.github.com/repos/vsbogd/dev-portal/branches{/branch}","tags_url":"https://api.github.com/repos/vsbogd/dev-portal/tags","blobs_url":"https://api.github.com/repos/vsbogd/dev-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vsbogd/dev-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vsbogd/dev-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/vsbogd/dev-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vsbogd/dev-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/vsbogd/dev-portal/languages","stargazers_url":"https://api.github.com/repos/vsbogd/dev-portal/stargazers","contributors_url":"https://api.github.com/repos/vsbogd/dev-portal/contributors","subscribers_url":"https://api.github.com/repos/vsbogd/dev-portal/subscribers","subscription_url":"https://api.github.com/repos/vsbogd/dev-portal/subscription","commits_url":"https://api.github.com/repos/vsbogd/dev-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/vsbogd/dev-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/vsbogd/dev-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/vsbogd/dev-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/vsbogd/dev-portal/contents/{+path}","compare_url":"https://api.github.com/repos/vsbogd/dev-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vsbogd/dev-portal/merges","archive_url":"https://api.github.com/repos/vsbogd/dev-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vsbogd/dev-portal/downloads","issues_url":"https://api.github.com/repos/vsbogd/dev-portal/issues{/number}","pulls_url":"https://api.github.com/repos/vsbogd/dev-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/vsbogd/dev-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/vsbogd/dev-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vsbogd/dev-portal/labels{/name}","releases_url":"https://api.github.com/repos/vsbogd/dev-portal/releases{/id}","deployments_url":"https://api.github.com/repos/vsbogd/dev-portal/deployments","created_at":"2018-12-21T13:30:48Z","updated_at":"2018-12-21T13:30:50Z","pushed_at":"2019-03-20T09:49:01Z","git_url":"git://github.com/vsbogd/dev-portal.git","ssh_url":"[email protected]:vsbogd/dev-portal.git","clone_url":"https://github.com/vsbogd/dev-portal.git","svn_url":"https://github.com/vsbogd/dev-portal","homepage":"https://dev.singularitynet.io","size":20290,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"singnet:master","ref":"master","sha":"26ad2c5769b274b3ee68f60de327c81cbe726d70","user":{"login":"singnet","id":32847093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODQ3MDkz","avatar_url":"https://avatars0.githubusercontent.com/u/32847093?v=4","gravatar_id":"","url":"https://api.github.com/users/singnet","html_url":"https://github.com/singnet","followers_url":"https://api.github.com/users/singnet/followers","following_url":"https://api.github.com/users/singnet/following{/other_user}","gists_url":"https://api.github.com/users/singnet/gists{/gist_id}","starred_url":"https://api.github.com/users/singnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singnet/subscriptions","organizations_url":"https://api.github.com/users/singnet/orgs","repos_url":"https://api.github.com/users/singnet/repos","events_url":"https://api.github.com/users/singnet/events{/privacy}","received_events_url":"https://api.github.com/users/singnet/received_events","type":"Organization","site_admin":false},"repo":{"id":155491258,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU0OTEyNTg=","name":"dev-portal","full_name":"singnet/dev-portal","private":false,"owner":{"login":"singnet","id":32847093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODQ3MDkz","avatar_url":"https://avatars0.githubusercontent.com/u/32847093?v=4","gravatar_id":"","url":"https://api.github.com/users/singnet","html_url":"https://github.com/singnet","followers_url":"https://api.github.com/users/singnet/followers","following_url":"https://api.github.com/users/singnet/following{/other_user}","gists_url":"https://api.github.com/users/singnet/gists{/gist_id}","starred_url":"https://api.github.com/users/singnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singnet/subscriptions","organizations_url":"https://api.github.com/users/singnet/orgs","repos_url":"https://api.github.com/users/singnet/repos","events_url":"https://api.github.com/users/singnet/events{/privacy}","received_events_url":"https://api.github.com/users/singnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/singnet/dev-portal","description":"The SingularityNET Developer Portal where you can find all our documentation, tutorials, and developer resources!","fork":false,"url":"https://api.github.com/repos/singnet/dev-portal","forks_url":"https://api.github.com/repos/singnet/dev-portal/forks","keys_url":"https://api.github.com/repos/singnet/dev-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/singnet/dev-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/singnet/dev-portal/teams","hooks_url":"https://api.github.com/repos/singnet/dev-portal/hooks","issue_events_url":"https://api.github.com/repos/singnet/dev-portal/issues/events{/number}","events_url":"https://api.github.com/repos/singnet/dev-portal/events","assignees_url":"https://api.github.com/repos/singnet/dev-portal/assignees{/user}","branches_url":"https://api.github.com/repos/singnet/dev-portal/branches{/branch}","tags_url":"https://api.github.com/repos/singnet/dev-portal/tags","blobs_url":"https://api.github.com/repos/singnet/dev-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/singnet/dev-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/singnet/dev-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/singnet/dev-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/singnet/dev-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/singnet/dev-portal/languages","stargazers_url":"https://api.github.com/repos/singnet/dev-portal/stargazers","contributors_url":"https://api.github.com/repos/singnet/dev-portal/contributors","subscribers_url":"https://api.github.com/repos/singnet/dev-portal/subscribers","subscription_url":"https://api.github.com/repos/singnet/dev-portal/subscription","commits_url":"https://api.github.com/repos/singnet/dev-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/singnet/dev-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/singnet/dev-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/singnet/dev-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/singnet/dev-portal/contents/{+path}","compare_url":"https://api.github.com/repos/singnet/dev-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/singnet/dev-portal/merges","archive_url":"https://api.github.com/repos/singnet/dev-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/singnet/dev-portal/downloads","issues_url":"https://api.github.com/repos/singnet/dev-portal/issues{/number}","pulls_url":"https://api.github.com/repos/singnet/dev-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/singnet/dev-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/singnet/dev-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/singnet/dev-portal/labels{/name}","releases_url":"https://api.github.com/repos/singnet/dev-portal/releases{/id}","deployments_url":"https://api.github.com/repos/singnet/dev-portal/deployments","created_at":"2018-10-31T03:12:20Z","updated_at":"2019-03-20T07:05:19Z","pushed_at":"2019-03-20T09:49:02Z","git_url":"git://github.com/singnet/dev-portal.git","ssh_url":"[email protected]:singnet/dev-portal.git","clone_url":"https://github.com/singnet/dev-portal.git","svn_url":"https://github.com/singnet/dev-portal","homepage":"https://dev.singularitynet.io","size":20321,"stargazers_count":28,"watchers_count":28,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":12,"open_issues":8,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/singnet/dev-portal/pulls/42"},"html":{"href":"https://github.com/singnet/dev-portal/pull/42"},"issue":{"href":"https://api.github.com/repos/singnet/dev-portal/issues/42"},"comments":{"href":"https://api.github.com/repos/singnet/dev-portal/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/singnet/dev-portal/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/singnet/dev-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/singnet/dev-portal/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/singnet/dev-portal/statuses/957571f007fb3cc1db08f027f273e6a577c79ae8"}},"author_association":"COLLABORATOR"}}	{ "id": 155491258, "name": "singnet/dev-portal", "url": "https://api.github.com/repos/singnet/dev-portal" }	{ "id": 15108323, "login": "arturgontijo", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/15108323?", "url": "https://api.github.com/users/arturgontijo" }	{ "id": 32847093, "login": "singnet", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/32847093?", "url": "https://api.github.com/orgs/singnet" }	2019-03-20T10:29:48	9278593595	{"actor":{"display_login":"arturgontijo"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/banzaicloud/istio-operator/pulls/comments/301909840","pull_request_review_id":259898553,"id":301909840,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMTkwOTg0MA==","diff_hunk":"@@ -117,6 +117,24 @@ func (r Reconciler) meshConfig() string {\n \treturn string(marshaledConfig)\n }\n \n+func (r Reconciler) getLocalityLBConfiguration() istiov1beta1.LocalityLBConfiguration {\n+\tvar localityLbConfiguration istiov1beta1.LocalityLBConfiguration\n+\n+\tif !util.PointerToBool(r.Config.Spec.LocalityLB.Enabled) {\n+\t\treturn localityLbConfiguration\n+\t}\n+\n+\tif r.Config.Spec.LocalityLB != nil {\n+\t\tlocalityLbConfiguration = r.Config.Spec.LocalityLB.DeepCopy()\n+\t\tlocalityLbConfiguration.Enabled = nil","path":"pkg/resources/common/configmap.go","position":22,"original_position":22,"commit_id":"f8d2ea619e23c59e5f2ba54155def8505b2c5cb2","original_commit_id":"f8d2ea619e23c59e5f2ba54155def8505b2c5cb2","user":{"login":"Laci21","id":11650801,"node_id":"MDQ6VXNlcjExNjUwODAx","avatar_url":"https://avatars0.githubusercontent.com/u/11650801?v=4","gravatar_id":"","url":"https://api.github.com/users/Laci21","html_url":"https://github.com/Laci21","followers_url":"https://api.github.com/users/Laci21/followers","following_url":"https://api.github.com/users/Laci21/following{/other_user}","gists_url":"https://api.github.com/users/Laci21/gists{/gist_id}","starred_url":"https://api.github.com/users/Laci21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Laci21/subscriptions","organizations_url":"https://api.github.com/users/Laci21/orgs","repos_url":"https://api.github.com/users/Laci21/repos","events_url":"https://api.github.com/users/Laci21/events{/privacy}","received_events_url":"https://api.github.com/users/Laci21/received_events","type":"User","site_admin":false},"body":"Why does it need to be set to `nil`?","created_at":"2019-07-10T06:54:44Z","updated_at":"2019-07-10T06:57:35Z","html_url":"https://github.com/banzaicloud/istio-operator/pull/258#discussion_r301909840","pull_request_url":"https://api.github.com/repos/banzaicloud/istio-operator/pulls/258","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/banzaicloud/istio-operator/pulls/comments/301909840"},"html":{"href":"https://github.com/banzaicloud/istio-operator/pull/258#discussion_r301909840"},"pull_request":{"href":"https://api.github.com/repos/banzaicloud/istio-operator/pulls/258"}}},"pull_request":{"url":"https://api.github.com/repos/banzaicloud/istio-operator/pulls/258","id":295957373,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk1OTU3Mzcz","html_url":"https://github.com/banzaicloud/istio-operator/pull/258","diff_url":"https://github.com/banzaicloud/istio-operator/pull/258.diff","patch_url":"https://github.com/banzaicloud/istio-operator/pull/258.patch","issue_url":"https://api.github.com/repos/banzaicloud/istio-operator/issues/258","number":258,"state":"open","locked":false,"title":"Add Locality Load Balancing support","user":{"login":"waynz0r","id":12624764,"node_id":"MDQ6VXNlcjEyNjI0NzY0","avatar_url":"https://avatars2.githubusercontent.com/u/12624764?v=4","gravatar_id":"","url":"https://api.github.com/users/waynz0r","html_url":"https://github.com/waynz0r","followers_url":"https://api.github.com/users/waynz0r/followers","following_url":"https://api.github.com/users/waynz0r/following{/other_user}","gists_url":"https://api.github.com/users/waynz0r/gists{/gist_id}","starred_url":"https://api.github.com/users/waynz0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waynz0r/subscriptions","organizations_url":"https://api.github.com/users/waynz0r/orgs","repos_url":"https://api.github.com/users/waynz0r/repos","events_url":"https://api.github.com/users/waynz0r/events{/privacy}","received_events_url":"https://api.github.com/users/waynz0r/received_events","type":"User","site_admin":false},"body":"\| Q \| A\r\n\| --------------- \| ---\r\n\| Bug fix? \| no\r\n\| New feature? \| yes\r\n\| API breaks? \| no\r\n\| Deprecations? \| no\r\n\| Related tickets \| \r\n\| License \| Apache 2.0\r\n\r\n\r\n### What's in this PR?\r\n\r\nAdds support for locality based load balancing in Istio\r\n\r\n### Checklist\r\n<!-- Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields. -->\r\n\r\n- [x] Implementation tested\r\n","created_at":"2019-07-09T23:44:58Z","updated_at":"2019-07-10T06:57:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b4035cca9bbb5d866a8c8259cb852775ba971bb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"martonsereg","id":1568469,"node_id":"MDQ6VXNlcjE1Njg0Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1568469?v=4","gravatar_id":"","url":"https://api.github.com/users/martonsereg","html_url":"https://github.com/martonsereg","followers_url":"https://api.github.com/users/martonsereg/followers","following_url":"https://api.github.com/users/martonsereg/following{/other_user}","gists_url":"https://api.github.com/users/martonsereg/gists{/gist_id}","starred_url":"https://api.github.com/users/martonsereg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martonsereg/subscriptions","organizations_url":"https://api.github.com/users/martonsereg/orgs","repos_url":"https://api.github.com/users/martonsereg/repos","events_url":"https://api.github.com/users/martonsereg/events{/privacy}","received_events_url":"https://api.github.com/users/martonsereg/received_events","type":"User","site_admin":false},{"login":"matyix","id":6003104,"node_id":"MDQ6VXNlcjYwMDMxMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6003104?v=4","gravatar_id":"","url":"https://api.github.com/users/matyix","html_url":"https://github.com/matyix","followers_url":"https://api.github.com/users/matyix/followers","following_url":"https://api.github.com/users/matyix/following{/other_user}","gists_url":"https://api.github.com/users/matyix/gists{/gist_id}","starred_url":"https://api.github.com/users/matyix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matyix/subscriptions","organizations_url":"https://api.github.com/users/matyix/orgs","repos_url":"https://api.github.com/users/matyix/repos","events_url":"https://api.github.com/users/matyix/events{/privacy}","received_events_url":"https://api.github.com/users/matyix/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/banzaicloud/istio-operator/pulls/258/commits","review_comments_url":"https://api.github.com/repos/banzaicloud/istio-operator/pulls/258/comments","review_comment_url":"https://api.github.com/repos/banzaicloud/istio-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/banzaicloud/istio-operator/issues/258/comments","statuses_url":"https://api.github.com/repos/banzaicloud/istio-operator/statuses/f8d2ea619e23c59e5f2ba54155def8505b2c5cb2","head":{"label":"banzaicloud:locality-lb","ref":"locality-lb","sha":"f8d2ea619e23c59e5f2ba54155def8505b2c5cb2","user":{"login":"banzaicloud","id":32848483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODQ4NDgz","avatar_url":"https://avatars2.githubusercontent.com/u/32848483?v=4","gravatar_id":"","url":"https://api.github.com/users/banzaicloud","html_url":"https://github.com/banzaicloud","followers_url":"https://api.github.com/users/banzaicloud/followers","following_url":"https://api.github.com/users/banzaicloud/following{/other_user}","gists_url":"https://api.github.com/users/banzaicloud/gists{/gist_id}","starred_url":"https://api.github.com/users/banzaicloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banzaicloud/subscriptions","organizations_url":"https://api.github.com/users/banzaicloud/orgs","repos_url":"https://api.github.com/users/banzaicloud/repos","events_url":"https://api.github.com/users/banzaicloud/events{/privacy}","received_events_url":"https://api.github.com/users/banzaicloud/received_events","type":"Organization","site_admin":false},"repo":{"id":168121795,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgxMjE3OTU=","name":"istio-operator","full_name":"banzaicloud/istio-operator","private":false,"owner":{"login":"banzaicloud","id":32848483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODQ4NDgz","avatar_url":"https://avatars2.githubusercontent.com/u/32848483?v=4","gravatar_id":"","url":"https://api.github.com/users/banzaicloud","html_url":"https://github.com/banzaicloud","followers_url":"https://api.github.com/users/banzaicloud/followers","following_url":"https://api.github.com/users/banzaicloud/following{/other_user}","gists_url":"https://api.github.com/users/banzaicloud/gists{/gist_id}","starred_url":"https://api.github.com/users/banzaicloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banzaicloud/subscriptions","organizations_url":"https://api.github.com/users/banzaicloud/orgs","repos_url":"https://api.github.com/users/banzaicloud/repos","events_url":"https://api.github.com/users/banzaicloud/events{/privacy}","received_events_url":"https://api.github.com/users/banzaicloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/banzaicloud/istio-operator","description":"An operator that manages Istio deployments on Kubernetes","fork":false,"url":"https://api.github.com/repos/banzaicloud/istio-operator","forks_url":"https://api.github.com/repos/banzaicloud/istio-operator/forks","keys_url":"https://api.github.com/repos/banzaicloud/istio-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/banzaicloud/istio-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/banzaicloud/istio-operator/teams","hooks_url":"https://api.github.com/repos/banzaicloud/istio-operator/hooks","issue_events_url":"https://api.github.com/repos/banzaicloud/istio-operator/issues/events{/number}","events_url":"https://api.github.com/repos/banzaicloud/istio-operator/events","assignees_url":"https://api.github.com/repos/banzaicloud/istio-operator/assignees{/user}","branches_url":"https://api.github.com/repos/banzaicloud/istio-operator/branches{/branch}","tags_url":"https://api.github.com/repos/banzaicloud/istio-operator/tags","blobs_url":"https://api.github.com/repos/banzaicloud/istio-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/banzaicloud/istio-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/banzaicloud/istio-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/banzaicloud/istio-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/banzaicloud/istio-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/banzaicloud/istio-operator/languages","stargazers_url":"https://api.github.com/repos/banzaicloud/istio-operator/stargazers","contributors_url":"https://api.github.com/repos/banzaicloud/istio-operator/contributors","subscribers_url":"https://api.github.com/repos/banzaicloud/istio-operator/subscribers","subscription_url":"https://api.github.com/repos/banzaicloud/istio-operator/subscription","commits_url":"https://api.github.com/repos/banzaicloud/istio-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/banzaicloud/istio-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/banzaicloud/istio-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/banzaicloud/istio-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/banzaicloud/istio-operator/contents/{+path}","compare_url":"https://api.github.com/repos/banzaicloud/istio-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/banzaicloud/istio-operator/merges","archive_url":"https://api.github.com/repos/banzaicloud/istio-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/banzaicloud/istio-operator/downloads","issues_url":"https://api.github.com/repos/banzaicloud/istio-operator/issues{/number}","pulls_url":"https://api.github.com/repos/banzaicloud/istio-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/banzaicloud/istio-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/banzaicloud/istio-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/banzaicloud/istio-operator/labels{/name}","releases_url":"https://api.github.com/repos/banzaicloud/istio-operator/releases{/id}","deployments_url":"https://api.github.com/repos/banzaicloud/istio-operator/deployments","created_at":"2019-01-29T08:50:59Z","updated_at":"2019-07-09T18:31:34Z","pushed_at":"2019-07-09T23:44:59Z","git_url":"git://github.com/banzaicloud/istio-operator.git","ssh_url":"[email protected]:banzaicloud/istio-operator.git","clone_url":"https://github.com/banzaicloud/istio-operator.git","svn_url":"https://github.com/banzaicloud/istio-operator","homepage":"","size":16467,"stargazers_count":288,"watchers_count":288,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":25,"open_issues":27,"watchers":288,"default_branch":"release-1.1"}},"base":{"label":"banzaicloud:istio-1.2.2","ref":"istio-1.2.2","sha":"304dd02c97f213aeaccef8a29cfe04578b551372","user":{"login":"banzaicloud","id":32848483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODQ4NDgz","avatar_url":"https://avatars2.githubusercontent.com/u/32848483?v=4","gravatar_id":"","url":"https://api.github.com/users/banzaicloud","html_url":"https://github.com/banzaicloud","followers_url":"https://api.github.com/users/banzaicloud/followers","following_url":"https://api.github.com/users/banzaicloud/following{/other_user}","gists_url":"https://api.github.com/users/banzaicloud/gists{/gist_id}","starred_url":"https://api.github.com/users/banzaicloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banzaicloud/subscriptions","organizations_url":"https://api.github.com/users/banzaicloud/orgs","repos_url":"https://api.github.com/users/banzaicloud/repos","events_url":"https://api.github.com/users/banzaicloud/events{/privacy}","received_events_url":"https://api.github.com/users/banzaicloud/received_events","type":"Organization","site_admin":false},"repo":{"id":168121795,"node_id":"MDEwOlJlcG9zaXRvcnkxNjgxMjE3OTU=","name":"istio-operator","full_name":"banzaicloud/istio-operator","private":false,"owner":{"login":"banzaicloud","id":32848483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODQ4NDgz","avatar_url":"https://avatars2.githubusercontent.com/u/32848483?v=4","gravatar_id":"","url":"https://api.github.com/users/banzaicloud","html_url":"https://github.com/banzaicloud","followers_url":"https://api.github.com/users/banzaicloud/followers","following_url":"https://api.github.com/users/banzaicloud/following{/other_user}","gists_url":"https://api.github.com/users/banzaicloud/gists{/gist_id}","starred_url":"https://api.github.com/users/banzaicloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banzaicloud/subscriptions","organizations_url":"https://api.github.com/users/banzaicloud/orgs","repos_url":"https://api.github.com/users/banzaicloud/repos","events_url":"https://api.github.com/users/banzaicloud/events{/privacy}","received_events_url":"https://api.github.com/users/banzaicloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/banzaicloud/istio-operator","description":"An operator that manages Istio deployments on Kubernetes","fork":false,"url":"https://api.github.com/repos/banzaicloud/istio-operator","forks_url":"https://api.github.com/repos/banzaicloud/istio-operator/forks","keys_url":"https://api.github.com/repos/banzaicloud/istio-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/banzaicloud/istio-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/banzaicloud/istio-operator/teams","hooks_url":"https://api.github.com/repos/banzaicloud/istio-operator/hooks","issue_events_url":"https://api.github.com/repos/banzaicloud/istio-operator/issues/events{/number}","events_url":"https://api.github.com/repos/banzaicloud/istio-operator/events","assignees_url":"https://api.github.com/repos/banzaicloud/istio-operator/assignees{/user}","branches_url":"https://api.github.com/repos/banzaicloud/istio-operator/branches{/branch}","tags_url":"https://api.github.com/repos/banzaicloud/istio-operator/tags","blobs_url":"https://api.github.com/repos/banzaicloud/istio-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/banzaicloud/istio-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/banzaicloud/istio-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/banzaicloud/istio-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/banzaicloud/istio-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/banzaicloud/istio-operator/languages","stargazers_url":"https://api.github.com/repos/banzaicloud/istio-operator/stargazers","contributors_url":"https://api.github.com/repos/banzaicloud/istio-operator/contributors","subscribers_url":"https://api.github.com/repos/banzaicloud/istio-operator/subscribers","subscription_url":"https://api.github.com/repos/banzaicloud/istio-operator/subscription","commits_url":"https://api.github.com/repos/banzaicloud/istio-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/banzaicloud/istio-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/banzaicloud/istio-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/banzaicloud/istio-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/banzaicloud/istio-operator/contents/{+path}","compare_url":"https://api.github.com/repos/banzaicloud/istio-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/banzaicloud/istio-operator/merges","archive_url":"https://api.github.com/repos/banzaicloud/istio-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/banzaicloud/istio-operator/downloads","issues_url":"https://api.github.com/repos/banzaicloud/istio-operator/issues{/number}","pulls_url":"https://api.github.com/repos/banzaicloud/istio-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/banzaicloud/istio-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/banzaicloud/istio-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/banzaicloud/istio-operator/labels{/name}","releases_url":"https://api.github.com/repos/banzaicloud/istio-operator/releases{/id}","deployments_url":"https://api.github.com/repos/banzaicloud/istio-operator/deployments","created_at":"2019-01-29T08:50:59Z","updated_at":"2019-07-09T18:31:34Z","pushed_at":"2019-07-09T23:44:59Z","git_url":"git://github.com/banzaicloud/istio-operator.git","ssh_url":"[email protected]:banzaicloud/istio-operator.git","clone_url":"https://github.com/banzaicloud/istio-operator.git","svn_url":"https://github.com/banzaicloud/istio-operator","homepage":"","size":16467,"stargazers_count":288,"watchers_count":288,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":25,"open_issues":27,"watchers":288,"default_branch":"release-1.1"}},"_links":{"self":{"href":"https://api.github.com/repos/banzaicloud/istio-operator/pulls/258"},"html":{"href":"https://github.com/banzaicloud/istio-operator/pull/258"},"issue":{"href":"https://api.github.com/repos/banzaicloud/istio-operator/issues/258"},"comments":{"href":"https://api.github.com/repos/banzaicloud/istio-operator/issues/258/comments"},"review_comments":{"href":"https://api.github.com/repos/banzaicloud/istio-operator/pulls/258/comments"},"review_comment":{"href":"https://api.github.com/repos/banzaicloud/istio-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/banzaicloud/istio-operator/pulls/258/commits"},"statuses":{"href":"https://api.github.com/repos/banzaicloud/istio-operator/statuses/f8d2ea619e23c59e5f2ba54155def8505b2c5cb2"}},"author_association":"MEMBER"}}	{ "id": 168121795, "name": "banzaicloud/istio-operator", "url": "https://api.github.com/repos/banzaicloud/istio-operator" }	{ "id": 11650801, "login": "Laci21", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/11650801?", "url": "https://api.github.com/users/Laci21" }	{ "id": 32848483, "login": "banzaicloud", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/32848483?", "url": "https://api.github.com/orgs/banzaicloud" }	2019-07-10T06:54:44	9981252426	{"actor":{"display_login":"Laci21"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/codesandbox/codesandbox-client/pulls/comments/358303372","pull_request_review_id":332659119,"id":358303372,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1ODMwMzM3Mg==","diff_hunk":"@@ -33,9 +33,9 @@ export const Tab = styled.div<{ active: boolean; isOver: boolean }>`\n ${props =>\n props.active\n ? css`\n- background-color: ${props.theme['tab.activeBackground'] \|\|\n- props.theme['editor.background'] \|\|\n- 'transparent'};\n+ background-color: ${props.theme['input.background'] \|\|","path":"packages/app/src/app/components/Preview/DevTools/Tabs/Tab/elements.ts","position":7,"original_position":7,"commit_id":"6f59d17937a788c5942f7ab96068bed659ab8521","original_commit_id":"b0edef2bf561627f31f8af113d36427c5a35f288","user":{"login":"siddharthkp","id":1863771,"node_id":"MDQ6VXNlcjE4NjM3NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1863771?v=4","gravatar_id":"","url":"https://api.github.com/users/siddharthkp","html_url":"https://github.com/siddharthkp","followers_url":"https://api.github.com/users/siddharthkp/followers","following_url":"https://api.github.com/users/siddharthkp/following{/other_user}","gists_url":"https://api.github.com/users/siddharthkp/gists{/gist_id}","starred_url":"https://api.github.com/users/siddharthkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siddharthkp/subscriptions","organizations_url":"https://api.github.com/users/siddharthkp/orgs","repos_url":"https://api.github.com/users/siddharthkp/repos","events_url":"https://api.github.com/users/siddharthkp/events{/privacy}","received_events_url":"https://api.github.com/users/siddharthkp/received_events","type":"User","site_admin":false},"body":"@CompuIves we moved the conversation to slack, so you're missing some context now :)","created_at":"2019-12-16T15:40:02Z","updated_at":"2019-12-16T15:40:02Z","html_url":"https://github.com/codesandbox/codesandbox-client/pull/3209#discussion_r358303372","pull_request_url":"https://api.github.com/repos/codesandbox/codesandbox-client/pulls/3209","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/codesandbox/codesandbox-client/pulls/comments/358303372"},"html":{"href":"https://github.com/codesandbox/codesandbox-client/pull/3209#discussion_r358303372"},"pull_request":{"href":"https://api.github.com/repos/codesandbox/codesandbox-client/pulls/3209"}},"in_reply_to_id":358274045},"pull_request":{"url":"https://api.github.com/repos/codesandbox/codesandbox-client/pulls/3209","id":353179559,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzMTc5NTU5","html_url":"https://github.com/codesandbox/codesandbox-client/pull/3209","diff_url":"https://github.com/codesandbox/codesandbox-client/pull/3209.diff","patch_url":"https://github.com/codesandbox/codesandbox-client/pull/3209.patch","issue_url":"https://api.github.com/repos/codesandbox/codesandbox-client/issues/3209","number":3209,"state":"open","locked":false,"title":"Update preview header","user":{"login":"SaraVieira","id":1051509,"node_id":"MDQ6VXNlcjEwNTE1MDk=","avatar_url":"https://avatars0.githubusercontent.com/u/1051509?v=4","gravatar_id":"","url":"https://api.github.com/users/SaraVieira","html_url":"https://github.com/SaraVieira","followers_url":"https://api.github.com/users/SaraVieira/followers","following_url":"https://api.github.com/users/SaraVieira/following{/other_user}","gists_url":"https://api.github.com/users/SaraVieira/gists{/gist_id}","starred_url":"https://api.github.com/users/SaraVieira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaraVieira/subscriptions","organizations_url":"https://api.github.com/users/SaraVieira/orgs","repos_url":"https://api.github.com/users/SaraVieira/repos","events_url":"https://api.github.com/users/SaraVieira/events{/privacy}","received_events_url":"https://api.github.com/users/SaraVieira/received_events","type":"User","site_admin":false},"body":"This PR updates the preview header to the new design you can see here:\r\n\r\nhttps://www.figma.com/file/Pn3qsrxzqFN0s6tB2eTbe6SC/IDE?node-id=1175%3A4920\r\n\r\nNew:\r\n\r\n![Screenshot 2019-12-14 at 15 13 24](https://user-images.githubusercontent.com/1051509/70849870-84c15300-1e84-11ea-8fd6-45bf4ac646ea.png)\r\n![Screenshot 2019-12-14 at 15 10 22](https://user-images.githubusercontent.com/1051509/70849871-84c15300-1e84-11ea-92fa-13cf079d5420.png)\r\n\r\n\r\nColors will never match because of vscode themes.\r\n","created_at":"2019-12-14T14:15:47Z","updated_at":"2019-12-16T15:40:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee14cba1bd3859793db2d6a80bf8284c440390a3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"CompuIves","id":587016,"node_id":"MDQ6VXNlcjU4NzAxNg==","avatar_url":"https://avatars3.githubusercontent.com/u/587016?v=4","gravatar_id":"","url":"https://api.github.com/users/CompuIves","html_url":"https://github.com/CompuIves","followers_url":"https://api.github.com/users/CompuIves/followers","following_url":"https://api.github.com/users/CompuIves/following{/other_user}","gists_url":"https://api.github.com/users/CompuIves/gists{/gist_id}","starred_url":"https://api.github.com/users/CompuIves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CompuIves/subscriptions","organizations_url":"https://api.github.com/users/CompuIves/orgs","repos_url":"https://api.github.com/users/CompuIves/repos","events_url":"https://api.github.com/users/CompuIves/events{/privacy}","received_events_url":"https://api.github.com/users/CompuIves/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codesandbox/codesandbox-client/pulls/3209/commits","review_comments_url":"https://api.github.com/repos/codesandbox/codesandbox-client/pulls/3209/comments","review_comment_url":"https://api.github.com/repos/codesandbox/codesandbox-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codesandbox/codesandbox-client/issues/3209/comments","statuses_url":"https://api.github.com/repos/codesandbox/codesandbox-client/statuses/6f59d17937a788c5942f7ab96068bed659ab8521","head":{"label":"codesandbox:update-preview-header","ref":"update-preview-header","sha":"6f59d17937a788c5942f7ab96068bed659ab8521","user":{"login":"codesandbox","id":32880324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODgwMzI0","avatar_url":"https://avatars3.githubusercontent.com/u/32880324?v=4","gravatar_id":"","url":"https://api.github.com/users/codesandbox","html_url":"https://github.com/codesandbox","followers_url":"https://api.github.com/users/codesandbox/followers","following_url":"https://api.github.com/users/codesandbox/following{/other_user}","gists_url":"https://api.github.com/users/codesandbox/gists{/gist_id}","starred_url":"https://api.github.com/users/codesandbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codesandbox/subscriptions","organizations_url":"https://api.github.com/users/codesandbox/orgs","repos_url":"https://api.github.com/users/codesandbox/repos","events_url":"https://api.github.com/users/codesandbox/events{/privacy}","received_events_url":"https://api.github.com/users/codesandbox/received_events","type":"Organization","site_admin":false},"repo":{"id":77455983,"node_id":"MDEwOlJlcG9zaXRvcnk3NzQ1NTk4Mw==","name":"codesandbox-client","full_name":"codesandbox/codesandbox-client","private":false,"owner":{"login":"codesandbox","id":32880324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODgwMzI0","avatar_url":"https://avatars3.githubusercontent.com/u/32880324?v=4","gravatar_id":"","url":"https://api.github.com/users/codesandbox","html_url":"https://github.com/codesandbox","followers_url":"https://api.github.com/users/codesandbox/followers","following_url":"https://api.github.com/users/codesandbox/following{/other_user}","gists_url":"https://api.github.com/users/codesandbox/gists{/gist_id}","starred_url":"https://api.github.com/users/codesandbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codesandbox/subscriptions","organizations_url":"https://api.github.com/users/codesandbox/orgs","repos_url":"https://api.github.com/users/codesandbox/repos","events_url":"https://api.github.com/users/codesandbox/events{/privacy}","received_events_url":"https://api.github.com/users/codesandbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codesandbox/codesandbox-client","description":"An online IDE for rapid web development","fork":false,"url":"https://api.github.com/repos/codesandbox/codesandbox-client","forks_url":"https://api.github.com/repos/codesandbox/codesandbox-client/forks","keys_url":"https://api.github.com/repos/codesandbox/codesandbox-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codesandbox/codesandbox-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codesandbox/codesandbox-client/teams","hooks_url":"https://api.github.com/repos/codesandbox/codesandbox-client/hooks","issue_events_url":"https://api.github.com/repos/codesandbox/codesandbox-client/issues/events{/number}","events_url":"https://api.github.com/repos/codesandbox/codesandbox-client/events","assignees_url":"https://api.github.com/repos/codesandbox/codesandbox-client/assignees{/user}","branches_url":"https://api.github.com/repos/codesandbox/codesandbox-client/branches{/branch}","tags_url":"https://api.github.com/repos/codesandbox/codesandbox-client/tags","blobs_url":"https://api.github.com/repos/codesandbox/codesandbox-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codesandbox/codesandbox-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codesandbox/codesandbox-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/codesandbox/codesandbox-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codesandbox/codesandbox-client/statuses/{sha}","languages_url":"https://api.github.com/repos/codesandbox/codesandbox-client/languages","stargazers_url":"https://api.github.com/repos/codesandbox/codesandbox-client/stargazers","contributors_url":"https://api.github.com/repos/codesandbox/codesandbox-client/contributors","subscribers_url":"https://api.github.com/repos/codesandbox/codesandbox-client/subscribers","subscription_url":"https://api.github.com/repos/codesandbox/codesandbox-client/subscription","commits_url":"https://api.github.com/repos/codesandbox/codesandbox-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/codesandbox/codesandbox-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/codesandbox/codesandbox-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/codesandbox/codesandbox-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/codesandbox/codesandbox-client/contents/{+path}","compare_url":"https://api.github.com/repos/codesandbox/codesandbox-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codesandbox/codesandbox-client/merges","archive_url":"https://api.github.com/repos/codesandbox/codesandbox-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codesandbox/codesandbox-client/downloads","issues_url":"https://api.github.com/repos/codesandbox/codesandbox-client/issues{/number}","pulls_url":"https://api.github.com/repos/codesandbox/codesandbox-client/pulls{/number}","milestones_url":"https://api.github.com/repos/codesandbox/codesandbox-client/milestones{/number}","notifications_url":"https://api.github.com/repos/codesandbox/codesandbox-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codesandbox/codesandbox-client/labels{/name}","releases_url":"https://api.github.com/repos/codesandbox/codesandbox-client/releases{/id}","deployments_url":"https://api.github.com/repos/codesandbox/codesandbox-client/deployments","created_at":"2016-12-27T13:04:17Z","updated_at":"2019-12-16T15:04:11Z","pushed_at":"2019-12-16T15:31:58Z","git_url":"git://github.com/codesandbox/codesandbox-client.git","ssh_url":"[email protected]:codesandbox/codesandbox-client.git","clone_url":"https://github.com/codesandbox/codesandbox-client.git","svn_url":"https://github.com/codesandbox/codesandbox-client","homepage":"https://codesandbox.io","size":271820,"stargazers_count":8728,"watchers_count":8728,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1248,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":490,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1248,"open_issues":490,"watchers":8728,"default_branch":"master"}},"base":{"label":"codesandbox:master","ref":"master","sha":"4cc2753db227aea49635cfdfadb14f17910450aa","user":{"login":"codesandbox","id":32880324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODgwMzI0","avatar_url":"https://avatars3.githubusercontent.com/u/32880324?v=4","gravatar_id":"","url":"https://api.github.com/users/codesandbox","html_url":"https://github.com/codesandbox","followers_url":"https://api.github.com/users/codesandbox/followers","following_url":"https://api.github.com/users/codesandbox/following{/other_user}","gists_url":"https://api.github.com/users/codesandbox/gists{/gist_id}","starred_url":"https://api.github.com/users/codesandbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codesandbox/subscriptions","organizations_url":"https://api.github.com/users/codesandbox/orgs","repos_url":"https://api.github.com/users/codesandbox/repos","events_url":"https://api.github.com/users/codesandbox/events{/privacy}","received_events_url":"https://api.github.com/users/codesandbox/received_events","type":"Organization","site_admin":false},"repo":{"id":77455983,"node_id":"MDEwOlJlcG9zaXRvcnk3NzQ1NTk4Mw==","name":"codesandbox-client","full_name":"codesandbox/codesandbox-client","private":false,"owner":{"login":"codesandbox","id":32880324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODgwMzI0","avatar_url":"https://avatars3.githubusercontent.com/u/32880324?v=4","gravatar_id":"","url":"https://api.github.com/users/codesandbox","html_url":"https://github.com/codesandbox","followers_url":"https://api.github.com/users/codesandbox/followers","following_url":"https://api.github.com/users/codesandbox/following{/other_user}","gists_url":"https://api.github.com/users/codesandbox/gists{/gist_id}","starred_url":"https://api.github.com/users/codesandbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codesandbox/subscriptions","organizations_url":"https://api.github.com/users/codesandbox/orgs","repos_url":"https://api.github.com/users/codesandbox/repos","events_url":"https://api.github.com/users/codesandbox/events{/privacy}","received_events_url":"https://api.github.com/users/codesandbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codesandbox/codesandbox-client","description":"An online IDE for rapid web development","fork":false,"url":"https://api.github.com/repos/codesandbox/codesandbox-client","forks_url":"https://api.github.com/repos/codesandbox/codesandbox-client/forks","keys_url":"https://api.github.com/repos/codesandbox/codesandbox-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codesandbox/codesandbox-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codesandbox/codesandbox-client/teams","hooks_url":"https://api.github.com/repos/codesandbox/codesandbox-client/hooks","issue_events_url":"https://api.github.com/repos/codesandbox/codesandbox-client/issues/events{/number}","events_url":"https://api.github.com/repos/codesandbox/codesandbox-client/events","assignees_url":"https://api.github.com/repos/codesandbox/codesandbox-client/assignees{/user}","branches_url":"https://api.github.com/repos/codesandbox/codesandbox-client/branches{/branch}","tags_url":"https://api.github.com/repos/codesandbox/codesandbox-client/tags","blobs_url":"https://api.github.com/repos/codesandbox/codesandbox-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codesandbox/codesandbox-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codesandbox/codesandbox-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/codesandbox/codesandbox-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codesandbox/codesandbox-client/statuses/{sha}","languages_url":"https://api.github.com/repos/codesandbox/codesandbox-client/languages","stargazers_url":"https://api.github.com/repos/codesandbox/codesandbox-client/stargazers","contributors_url":"https://api.github.com/repos/codesandbox/codesandbox-client/contributors","subscribers_url":"https://api.github.com/repos/codesandbox/codesandbox-client/subscribers","subscription_url":"https://api.github.com/repos/codesandbox/codesandbox-client/subscription","commits_url":"https://api.github.com/repos/codesandbox/codesandbox-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/codesandbox/codesandbox-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/codesandbox/codesandbox-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/codesandbox/codesandbox-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/codesandbox/codesandbox-client/contents/{+path}","compare_url":"https://api.github.com/repos/codesandbox/codesandbox-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codesandbox/codesandbox-client/merges","archive_url":"https://api.github.com/repos/codesandbox/codesandbox-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codesandbox/codesandbox-client/downloads","issues_url":"https://api.github.com/repos/codesandbox/codesandbox-client/issues{/number}","pulls_url":"https://api.github.com/repos/codesandbox/codesandbox-client/pulls{/number}","milestones_url":"https://api.github.com/repos/codesandbox/codesandbox-client/milestones{/number}","notifications_url":"https://api.github.com/repos/codesandbox/codesandbox-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codesandbox/codesandbox-client/labels{/name}","releases_url":"https://api.github.com/repos/codesandbox/codesandbox-client/releases{/id}","deployments_url":"https://api.github.com/repos/codesandbox/codesandbox-client/deployments","created_at":"2016-12-27T13:04:17Z","updated_at":"2019-12-16T15:04:11Z","pushed_at":"2019-12-16T15:31:58Z","git_url":"git://github.com/codesandbox/codesandbox-client.git","ssh_url":"[email protected]:codesandbox/codesandbox-client.git","clone_url":"https://github.com/codesandbox/codesandbox-client.git","svn_url":"https://github.com/codesandbox/codesandbox-client","homepage":"https://codesandbox.io","size":271820,"stargazers_count":8728,"watchers_count":8728,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1248,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":490,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1248,"open_issues":490,"watchers":8728,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codesandbox/codesandbox-client/pulls/3209"},"html":{"href":"https://github.com/codesandbox/codesandbox-client/pull/3209"},"issue":{"href":"https://api.github.com/repos/codesandbox/codesandbox-client/issues/3209"},"comments":{"href":"https://api.github.com/repos/codesandbox/codesandbox-client/issues/3209/comments"},"review_comments":{"href":"https://api.github.com/repos/codesandbox/codesandbox-client/pulls/3209/comments"},"review_comment":{"href":"https://api.github.com/repos/codesandbox/codesandbox-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codesandbox/codesandbox-client/pulls/3209/commits"},"statuses":{"href":"https://api.github.com/repos/codesandbox/codesandbox-client/statuses/6f59d17937a788c5942f7ab96068bed659ab8521"}},"author_association":"CONTRIBUTOR"}}	{ "id": 77455983, "name": "codesandbox/codesandbox-client", "url": "https://api.github.com/repos/codesandbox/codesandbox-client" }	{ "id": 1863771, "login": "siddharthkp", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/1863771?", "url": "https://api.github.com/users/siddharthkp" }	{ "id": 32880324, "login": "codesandbox", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/32880324?", "url": "https://api.github.com/orgs/codesandbox" }	2019-12-16T15:40:02	11098700062	{"actor":{"display_login":"siddharthkp"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/pulls/comments/334912323","pull_request_review_id":301856380,"id":334912323,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDkxMjMyMw==","diff_hunk":"@@ -0,0 +1,94 @@\n+from odoo import http\r\n+from odoo.http import request\r\n+\r\n+from odoo.tools.translate import _\r\n+\r\n+\r\n+class WebsiteLoanIssueSubscription(http.Controller):\r\n+\r\n+ @http.route(['/subscription/get_loan_issue'],\r\n+ type='json',\r\n+ auth=\"user\",\r\n+ methods=['POST'], website=True)\r\n+ def get_loan_issue(self, loan_issue_id, kw):\r\n+ loan_issue_obj = request.env['loan.issue']\r\n+ if loan_issue_id:\r\n+ loan_issue = loan_issue_obj.sudo().browse(int(loan_issue_id))\r\n+ return {\r\n+ loan_issue.id: {\r\n+ 'max_amount': loan_issue.maximum_amount_per_sub,\r\n+ 'face_value': loan_issue.face_value,\r\n+ }\r\n+ }\r\n+ else:\r\n+ return False\r\n+\r\n+ @http.route(['/page/loanissuesubscriptionform',\r\n+ '/loanissuesubscriptionform'],\r\n+ type='http', auth=\"user\", website=True)\r\n+ def display_loan_issue_subscription_page(self, kwargs):\r\n+ values = {}\r\n+ partner = request.env.user.partner_id\r\n+ is_company = partner.is_company\r\n+\r\n+ values = self.fill_values(values, is_company)\r\n+ values.update(kwargs=kwargs.items())\r\n+ return request.render(\r\n+ \"easy_my_coop_loan_website.loanissuesubscription\",\r\n+ values)\r\n+\r\n+ def get_loan_issues(self, is_company):\r\n+ loan_obj = request.env['loan.issue']\r\n+ loan_issues = loan_obj.sudo().get_web_issues(is_company)\r\n+\r\n+ return loan_issues\r\n+\r\n+ def fill_values(self, values, is_company):\r\n+ company = request.website.company_id\r\n+ loan_issues = self.get_loan_issues(is_company)\r\n+\r\n+ values['loan_issues'] = loan_issues\r\n+ values['company'] = company\r\n+\r\n+ if not values.get('loan_issue_id'):\r\n+ for loan_issue in loan_issues:\r\n+ if loan_issue.default_issue is True:\r\n+ values['loan_issue_id'] = loan_issue.id\r\n+ break\r\n+ if not values.get('loan_issue_id', False) and loan_issues:\r\n+ values['loan_issue_id'] = loan_issues[0].id\r\n+\r\n+ return values\r\n+\r\n+ def validation(self, loan_issue, kwargs):\r\n+ sub_amount = kwargs.get('subscription_amount')\r\n+ redirect = \"easy_my_coop_loan_website.loanissuesubscription\"\r\n+\r\n+ values = {}\r\n+ if not loan_issue:\r\n+ values[\"error_msg\"] = _(\"The selected loan issue is not found\")\r\n+ return request.render(redirect, values)\r\n+ if sub_amount:\r\n+ values[\"error_msg\"] = _(\"The amount shoud be of monetary type\")\r\n+ return request.render(redirect, values)\r\n+ return True\r\n+\r\n+ @http.route(['/subscription/subscribe_loan_issue'],\r\n+ type='http',\r\n+ auth=\"user\", website=True)\r\n+ def loan_issue_subscription(self, **kwargs):\r","path":"easy_my_coop_loan_website/controllers/main.py","position":79,"original_position":79,"commit_id":"a887ab6cc5bc6f2ea406c00c8795c15dd195edde","original_commit_id":"a887ab6cc5bc6f2ea406c00c8795c15dd195edde","user":{"login":"robinkeunen","id":3082119,"node_id":"MDQ6VXNlcjMwODIxMTk=","avatar_url":"https://avatars3.githubusercontent.com/u/3082119?v=4","gravatar_id":"","url":"https://api.github.com/users/robinkeunen","html_url":"https://github.com/robinkeunen","followers_url":"https://api.github.com/users/robinkeunen/followers","following_url":"https://api.github.com/users/robinkeunen/following{/other_user}","gists_url":"https://api.github.com/users/robinkeunen/gists{/gist_id}","starred_url":"https://api.github.com/users/robinkeunen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinkeunen/subscriptions","organizations_url":"https://api.github.com/users/robinkeunen/orgs","repos_url":"https://api.github.com/users/robinkeunen/repos","events_url":"https://api.github.com/users/robinkeunen/events{/privacy}","received_events_url":"https://api.github.com/users/robinkeunen/received_events","type":"User","site_admin":false},"body":"@remytms So what naming would be good for you?","created_at":"2019-10-15T12:11:39Z","updated_at":"2019-10-15T12:11:39Z","html_url":"https://github.com/coopiteasy/vertical-cooperative/pull/24#discussion_r334912323","pull_request_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/pulls/24","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/coopiteasy/vertical-cooperative/pulls/comments/334912323"},"html":{"href":"https://github.com/coopiteasy/vertical-cooperative/pull/24#discussion_r334912323"},"pull_request":{"href":"https://api.github.com/repos/coopiteasy/vertical-cooperative/pulls/24"}},"in_reply_to_id":334501125},"pull_request":{"url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/pulls/24","id":327733576,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3NzMzNTc2","html_url":"https://github.com/coopiteasy/vertical-cooperative/pull/24","diff_url":"https://github.com/coopiteasy/vertical-cooperative/pull/24.diff","patch_url":"https://github.com/coopiteasy/vertical-cooperative/pull/24.patch","issue_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/issues/24","number":24,"state":"open","locked":false,"title":"12.0 easy my coop bond","user":{"login":"houssine78","id":7766650,"node_id":"MDQ6VXNlcjc3NjY2NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/7766650?v=4","gravatar_id":"","url":"https://api.github.com/users/houssine78","html_url":"https://github.com/houssine78","followers_url":"https://api.github.com/users/houssine78/followers","following_url":"https://api.github.com/users/houssine78/following{/other_user}","gists_url":"https://api.github.com/users/houssine78/gists{/gist_id}","starred_url":"https://api.github.com/users/houssine78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houssine78/subscriptions","organizations_url":"https://api.github.com/users/houssine78/orgs","repos_url":"https://api.github.com/users/houssine78/repos","events_url":"https://api.github.com/users/houssine78/events{/privacy}","received_events_url":"https://api.github.com/users/houssine78/received_events","type":"User","site_admin":false},"body":"This PR bring most of the data model for bond issue management. Is a first version some functionalities may be added.","created_at":"2019-10-14T10:23:38Z","updated_at":"2019-10-15T12:11:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"095366686553da03064636095d8fb0e4fd8f5fd2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"remytms","id":17589077,"node_id":"MDQ6VXNlcjE3NTg5MDc3","avatar_url":"https://avatars3.githubusercontent.com/u/17589077?v=4","gravatar_id":"","url":"https://api.github.com/users/remytms","html_url":"https://github.com/remytms","followers_url":"https://api.github.com/users/remytms/followers","following_url":"https://api.github.com/users/remytms/following{/other_user}","gists_url":"https://api.github.com/users/remytms/gists{/gist_id}","starred_url":"https://api.github.com/users/remytms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remytms/subscriptions","organizations_url":"https://api.github.com/users/remytms/orgs","repos_url":"https://api.github.com/users/remytms/repos","events_url":"https://api.github.com/users/remytms/events{/privacy}","received_events_url":"https://api.github.com/users/remytms/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/pulls/24/commits","review_comments_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/pulls/24/comments","review_comment_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/issues/24/comments","statuses_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/statuses/a887ab6cc5bc6f2ea406c00c8795c15dd195edde","head":{"label":"coopiteasy:12.0_easy_my_coop_bond","ref":"12.0_easy_my_coop_bond","sha":"a887ab6cc5bc6f2ea406c00c8795c15dd195edde","user":{"login":"coopiteasy","id":32906427,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTA2NDI3","avatar_url":"https://avatars0.githubusercontent.com/u/32906427?v=4","gravatar_id":"","url":"https://api.github.com/users/coopiteasy","html_url":"https://github.com/coopiteasy","followers_url":"https://api.github.com/users/coopiteasy/followers","following_url":"https://api.github.com/users/coopiteasy/following{/other_user}","gists_url":"https://api.github.com/users/coopiteasy/gists{/gist_id}","starred_url":"https://api.github.com/users/coopiteasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coopiteasy/subscriptions","organizations_url":"https://api.github.com/users/coopiteasy/orgs","repos_url":"https://api.github.com/users/coopiteasy/repos","events_url":"https://api.github.com/users/coopiteasy/events{/privacy}","received_events_url":"https://api.github.com/users/coopiteasy/received_events","type":"Organization","site_admin":false},"repo":{"id":165234526,"node_id":"MDEwOlJlcG9zaXRvcnkxNjUyMzQ1MjY=","name":"vertical-cooperative","full_name":"coopiteasy/vertical-cooperative","private":false,"owner":{"login":"coopiteasy","id":32906427,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTA2NDI3","avatar_url":"https://avatars0.githubusercontent.com/u/32906427?v=4","gravatar_id":"","url":"https://api.github.com/users/coopiteasy","html_url":"https://github.com/coopiteasy","followers_url":"https://api.github.com/users/coopiteasy/followers","following_url":"https://api.github.com/users/coopiteasy/following{/other_user}","gists_url":"https://api.github.com/users/coopiteasy/gists{/gist_id}","starred_url":"https://api.github.com/users/coopiteasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coopiteasy/subscriptions","organizations_url":"https://api.github.com/users/coopiteasy/orgs","repos_url":"https://api.github.com/users/coopiteasy/repos","events_url":"https://api.github.com/users/coopiteasy/events{/privacy}","received_events_url":"https://api.github.com/users/coopiteasy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/coopiteasy/vertical-cooperative","description":"This repository gather odoo modules for cooperatives","fork":false,"url":"https://api.github.com/repos/coopiteasy/vertical-cooperative","forks_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/forks","keys_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/teams","hooks_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/hooks","issue_events_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/issues/events{/number}","events_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/events","assignees_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/assignees{/user}","branches_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/branches{/branch}","tags_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/tags","blobs_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/git/refs{/sha}","trees_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/statuses/{sha}","languages_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/languages","stargazers_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/stargazers","contributors_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/contributors","subscribers_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/subscribers","subscription_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/subscription","commits_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/commits{/sha}","git_commits_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/git/commits{/sha}","comments_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/comments{/number}","issue_comment_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/issues/comments{/number}","contents_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/contents/{+path}","compare_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/merges","archive_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/downloads","issues_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/issues{/number}","pulls_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/pulls{/number}","milestones_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/milestones{/number}","notifications_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/labels{/name}","releases_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/releases{/id}","deployments_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/deployments","created_at":"2019-01-11T11:40:40Z","updated_at":"2019-10-14T14:39:18Z","pushed_at":"2019-10-15T08:29:57Z","git_url":"git://github.com/coopiteasy/vertical-cooperative.git","ssh_url":"[email protected]:coopiteasy/vertical-cooperative.git","clone_url":"https://github.com/coopiteasy/vertical-cooperative.git","svn_url":"https://github.com/coopiteasy/vertical-cooperative","homepage":null,"size":2522,"stargazers_count":4,"watchers_count":4,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1,"open_issues":4,"watchers":4,"default_branch":"12.0"}},"base":{"label":"coopiteasy:12.0","ref":"12.0","sha":"7f9092fe3ec9edf43f380a519620c329d6a14f59","user":{"login":"coopiteasy","id":32906427,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTA2NDI3","avatar_url":"https://avatars0.githubusercontent.com/u/32906427?v=4","gravatar_id":"","url":"https://api.github.com/users/coopiteasy","html_url":"https://github.com/coopiteasy","followers_url":"https://api.github.com/users/coopiteasy/followers","following_url":"https://api.github.com/users/coopiteasy/following{/other_user}","gists_url":"https://api.github.com/users/coopiteasy/gists{/gist_id}","starred_url":"https://api.github.com/users/coopiteasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coopiteasy/subscriptions","organizations_url":"https://api.github.com/users/coopiteasy/orgs","repos_url":"https://api.github.com/users/coopiteasy/repos","events_url":"https://api.github.com/users/coopiteasy/events{/privacy}","received_events_url":"https://api.github.com/users/coopiteasy/received_events","type":"Organization","site_admin":false},"repo":{"id":165234526,"node_id":"MDEwOlJlcG9zaXRvcnkxNjUyMzQ1MjY=","name":"vertical-cooperative","full_name":"coopiteasy/vertical-cooperative","private":false,"owner":{"login":"coopiteasy","id":32906427,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyOTA2NDI3","avatar_url":"https://avatars0.githubusercontent.com/u/32906427?v=4","gravatar_id":"","url":"https://api.github.com/users/coopiteasy","html_url":"https://github.com/coopiteasy","followers_url":"https://api.github.com/users/coopiteasy/followers","following_url":"https://api.github.com/users/coopiteasy/following{/other_user}","gists_url":"https://api.github.com/users/coopiteasy/gists{/gist_id}","starred_url":"https://api.github.com/users/coopiteasy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coopiteasy/subscriptions","organizations_url":"https://api.github.com/users/coopiteasy/orgs","repos_url":"https://api.github.com/users/coopiteasy/repos","events_url":"https://api.github.com/users/coopiteasy/events{/privacy}","received_events_url":"https://api.github.com/users/coopiteasy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/coopiteasy/vertical-cooperative","description":"This repository gather odoo modules for cooperatives","fork":false,"url":"https://api.github.com/repos/coopiteasy/vertical-cooperative","forks_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/forks","keys_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/teams","hooks_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/hooks","issue_events_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/issues/events{/number}","events_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/events","assignees_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/assignees{/user}","branches_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/branches{/branch}","tags_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/tags","blobs_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/git/refs{/sha}","trees_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/statuses/{sha}","languages_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/languages","stargazers_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/stargazers","contributors_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/contributors","subscribers_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/subscribers","subscription_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/subscription","commits_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/commits{/sha}","git_commits_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/git/commits{/sha}","comments_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/comments{/number}","issue_comment_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/issues/comments{/number}","contents_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/contents/{+path}","compare_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/merges","archive_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/downloads","issues_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/issues{/number}","pulls_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/pulls{/number}","milestones_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/milestones{/number}","notifications_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/labels{/name}","releases_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/releases{/id}","deployments_url":"https://api.github.com/repos/coopiteasy/vertical-cooperative/deployments","created_at":"2019-01-11T11:40:40Z","updated_at":"2019-10-14T14:39:18Z","pushed_at":"2019-10-15T08:29:57Z","git_url":"git://github.com/coopiteasy/vertical-cooperative.git","ssh_url":"[email protected]:coopiteasy/vertical-cooperative.git","clone_url":"https://github.com/coopiteasy/vertical-cooperative.git","svn_url":"https://github.com/coopiteasy/vertical-cooperative","homepage":null,"size":2522,"stargazers_count":4,"watchers_count":4,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1,"open_issues":4,"watchers":4,"default_branch":"12.0"}},"_links":{"self":{"href":"https://api.github.com/repos/coopiteasy/vertical-cooperative/pulls/24"},"html":{"href":"https://github.com/coopiteasy/vertical-cooperative/pull/24"},"issue":{"href":"https://api.github.com/repos/coopiteasy/vertical-cooperative/issues/24"},"comments":{"href":"https://api.github.com/repos/coopiteasy/vertical-cooperative/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/coopiteasy/vertical-cooperative/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/coopiteasy/vertical-cooperative/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coopiteasy/vertical-cooperative/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/coopiteasy/vertical-cooperative/statuses/a887ab6cc5bc6f2ea406c00c8795c15dd195edde"}},"author_association":"CONTRIBUTOR"}}	{ "id": 165234526, "name": "coopiteasy/vertical-cooperative", "url": "https://api.github.com/repos/coopiteasy/vertical-cooperative" }	{ "id": 3082119, "login": "robinkeunen", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/3082119?", "url": "https://api.github.com/users/robinkeunen" }	{ "id": 32906427, "login": "coopiteasy", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/32906427?", "url": "https://api.github.com/orgs/coopiteasy" }	2019-10-15T12:11:39	10633237530	{"actor":{"display_login":"robinkeunen"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/vitessio/vitess/pulls/comments/306085119","pull_request_review_id":265119881,"id":306085119,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjA4NTExOQ==","diff_hunk":"@@ -218,6 +218,18 @@ func (agent *ActionAgent) changeCallback(ctx context.Context, oldTablet, newTabl\n \t\t\t\t\tdisallowQueryReason = \"master tablet with filtered replication on\"\n \t\t\t\t}\n \t\t\t}\n+\t\t\tif newTablet.Type == topodatapb.TabletType_REPLICA {\n+\t\t\t\treplicationDelay, healthErr := agent.HealthReporter.Report(true, true)","path":"go/vt/vttablet/tabletmanager/state_change.go","position":5,"original_position":5,"commit_id":"7d6f8fcc4b4ec9256b6b07029f518d5cb3cc6826","original_commit_id":"84452d22755753c1344a1b186d3afd3279ccca2f","user":{"login":"deepthi","id":388311,"node_id":"MDQ6VXNlcjM4ODMxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/388311?v=4","gravatar_id":"","url":"https://api.github.com/users/deepthi","html_url":"https://github.com/deepthi","followers_url":"https://api.github.com/users/deepthi/followers","following_url":"https://api.github.com/users/deepthi/following{/other_user}","gists_url":"https://api.github.com/users/deepthi/gists{/gist_id}","starred_url":"https://api.github.com/users/deepthi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepthi/subscriptions","organizations_url":"https://api.github.com/users/deepthi/orgs","repos_url":"https://api.github.com/users/deepthi/repos","events_url":"https://api.github.com/users/deepthi/events{/privacy}","received_events_url":"https://api.github.com/users/deepthi/received_events","type":"User","site_admin":false},"body":"I discussed this with @sougou and he's of the opinion that at this level in the code we should be calling low-level functions and not something like `runHealthCheckLocked`.","created_at":"2019-07-23T00:23:19Z","updated_at":"2019-07-23T00:23:20Z","html_url":"https://github.com/vitessio/vitess/pull/5000#discussion_r306085119","pull_request_url":"https://api.github.com/repos/vitessio/vitess/pulls/5000","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/comments/306085119"},"html":{"href":"https://github.com/vitessio/vitess/pull/5000#discussion_r306085119"},"pull_request":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/5000"}},"in_reply_to_id":304548690},"pull_request":{"url":"https://api.github.com/repos/vitessio/vitess/pulls/5000","id":297770334,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3NzcwMzM0","html_url":"https://github.com/vitessio/vitess/pull/5000","diff_url":"https://github.com/vitessio/vitess/pull/5000.diff","patch_url":"https://github.com/vitessio/vitess/pull/5000.patch","issue_url":"https://api.github.com/repos/vitessio/vitess/issues/5000","number":5000,"state":"open","locked":false,"title":"WIP: check replication lag on state change before starting query service","user":{"login":"deepthi","id":388311,"node_id":"MDQ6VXNlcjM4ODMxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/388311?v=4","gravatar_id":"","url":"https://api.github.com/users/deepthi","html_url":"https://github.com/deepthi","followers_url":"https://api.github.com/users/deepthi/followers","following_url":"https://api.github.com/users/deepthi/following{/other_user}","gists_url":"https://api.github.com/users/deepthi/gists{/gist_id}","starred_url":"https://api.github.com/users/deepthi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepthi/subscriptions","organizations_url":"https://api.github.com/users/deepthi/orgs","repos_url":"https://api.github.com/users/deepthi/repos","events_url":"https://api.github.com/users/deepthi/events{/privacy}","received_events_url":"https://api.github.com/users/deepthi/received_events","type":"User","site_admin":false},"body":"Fixes #4426 \r\nA possible fix has been implemented with unit tests. \r\n\r\nStill TODO: \r\nintegration test\r\ninclude other transitions besides the one this PR is currently handling?\r\n\r\nSigned-off-by: deepthi <[email protected]>","created_at":"2019-07-15T20:14:30Z","updated_at":"2019-07-23T00:23:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"935f689e9e3d1e415498c953449a9f5be9298b6a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rafael","id":24160,"node_id":"MDQ6VXNlcjI0MTYw","avatar_url":"https://avatars3.githubusercontent.com/u/24160?v=4","gravatar_id":"","url":"https://api.github.com/users/rafael","html_url":"https://github.com/rafael","followers_url":"https://api.github.com/users/rafael/followers","following_url":"https://api.github.com/users/rafael/following{/other_user}","gists_url":"https://api.github.com/users/rafael/gists{/gist_id}","starred_url":"https://api.github.com/users/rafael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafael/subscriptions","organizations_url":"https://api.github.com/users/rafael/orgs","repos_url":"https://api.github.com/users/rafael/repos","events_url":"https://api.github.com/users/rafael/events{/privacy}","received_events_url":"https://api.github.com/users/rafael/received_events","type":"User","site_admin":false},{"login":"dweitzman","id":100598,"node_id":"MDQ6VXNlcjEwMDU5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/100598?v=4","gravatar_id":"","url":"https://api.github.com/users/dweitzman","html_url":"https://github.com/dweitzman","followers_url":"https://api.github.com/users/dweitzman/followers","following_url":"https://api.github.com/users/dweitzman/following{/other_user}","gists_url":"https://api.github.com/users/dweitzman/gists{/gist_id}","starred_url":"https://api.github.com/users/dweitzman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dweitzman/subscriptions","organizations_url":"https://api.github.com/users/dweitzman/orgs","repos_url":"https://api.github.com/users/dweitzman/repos","events_url":"https://api.github.com/users/dweitzman/events{/privacy}","received_events_url":"https://api.github.com/users/dweitzman/received_events","type":"User","site_admin":false},{"login":"sougou","id":589370,"node_id":"MDQ6VXNlcjU4OTM3MA==","avatar_url":"https://avatars1.githubusercontent.com/u/589370?v=4","gravatar_id":"","url":"https://api.github.com/users/sougou","html_url":"https://github.com/sougou","followers_url":"https://api.github.com/users/sougou/followers","following_url":"https://api.github.com/users/sougou/following{/other_user}","gists_url":"https://api.github.com/users/sougou/gists{/gist_id}","starred_url":"https://api.github.com/users/sougou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sougou/subscriptions","organizations_url":"https://api.github.com/users/sougou/orgs","repos_url":"https://api.github.com/users/sougou/repos","events_url":"https://api.github.com/users/sougou/events{/privacy}","received_events_url":"https://api.github.com/users/sougou/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vitessio/vitess/pulls/5000/commits","review_comments_url":"https://api.github.com/repos/vitessio/vitess/pulls/5000/comments","review_comment_url":"https://api.github.com/repos/vitessio/vitess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vitessio/vitess/issues/5000/comments","statuses_url":"https://api.github.com/repos/vitessio/vitess/statuses/7d6f8fcc4b4ec9256b6b07029f518d5cb3cc6826","head":{"label":"planetscale:ds-4426","ref":"ds-4426","sha":"7d6f8fcc4b4ec9256b6b07029f518d5cb3cc6826","user":{"login":"planetscale","id":35612527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjEyNTI3","avatar_url":"https://avatars3.githubusercontent.com/u/35612527?v=4","gravatar_id":"","url":"https://api.github.com/users/planetscale","html_url":"https://github.com/planetscale","followers_url":"https://api.github.com/users/planetscale/followers","following_url":"https://api.github.com/users/planetscale/following{/other_user}","gists_url":"https://api.github.com/users/planetscale/gists{/gist_id}","starred_url":"https://api.github.com/users/planetscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/planetscale/subscriptions","organizations_url":"https://api.github.com/users/planetscale/orgs","repos_url":"https://api.github.com/users/planetscale/repos","events_url":"https://api.github.com/users/planetscale/events{/privacy}","received_events_url":"https://api.github.com/users/planetscale/received_events","type":"Organization","site_admin":false},"repo":{"id":133275023,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMyNzUwMjM=","name":"vitess","full_name":"planetscale/vitess","private":false,"owner":{"login":"planetscale","id":35612527,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjEyNTI3","avatar_url":"https://avatars3.githubusercontent.com/u/35612527?v=4","gravatar_id":"","url":"https://api.github.com/users/planetscale","html_url":"https://github.com/planetscale","followers_url":"https://api.github.com/users/planetscale/followers","following_url":"https://api.github.com/users/planetscale/following{/other_user}","gists_url":"https://api.github.com/users/planetscale/gists{/gist_id}","starred_url":"https://api.github.com/users/planetscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/planetscale/subscriptions","organizations_url":"https://api.github.com/users/planetscale/orgs","repos_url":"https://api.github.com/users/planetscale/repos","events_url":"https://api.github.com/users/planetscale/events{/privacy}","received_events_url":"https://api.github.com/users/planetscale/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/planetscale/vitess","description":"Vitess is a database clustering system for horizontal scaling of MySQL.","fork":true,"url":"https://api.github.com/repos/planetscale/vitess","forks_url":"https://api.github.com/repos/planetscale/vitess/forks","keys_url":"https://api.github.com/repos/planetscale/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/planetscale/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/planetscale/vitess/teams","hooks_url":"https://api.github.com/repos/planetscale/vitess/hooks","issue_events_url":"https://api.github.com/repos/planetscale/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/planetscale/vitess/events","assignees_url":"https://api.github.com/repos/planetscale/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/planetscale/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/planetscale/vitess/tags","blobs_url":"https://api.github.com/repos/planetscale/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/planetscale/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/planetscale/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/planetscale/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/planetscale/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/planetscale/vitess/languages","stargazers_url":"https://api.github.com/repos/planetscale/vitess/stargazers","contributors_url":"https://api.github.com/repos/planetscale/vitess/contributors","subscribers_url":"https://api.github.com/repos/planetscale/vitess/subscribers","subscription_url":"https://api.github.com/repos/planetscale/vitess/subscription","commits_url":"https://api.github.com/repos/planetscale/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/planetscale/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/planetscale/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/planetscale/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/planetscale/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/planetscale/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/planetscale/vitess/merges","archive_url":"https://api.github.com/repos/planetscale/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/planetscale/vitess/downloads","issues_url":"https://api.github.com/repos/planetscale/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/planetscale/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/planetscale/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/planetscale/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/planetscale/vitess/labels{/name}","releases_url":"https://api.github.com/repos/planetscale/vitess/releases{/id}","deployments_url":"https://api.github.com/repos/planetscale/vitess/deployments","created_at":"2018-05-13T21:17:34Z","updated_at":"2019-07-22T21:35:07Z","pushed_at":"2019-07-23T00:22:09Z","git_url":"git://github.com/planetscale/vitess.git","ssh_url":"[email protected]:planetscale/vitess.git","clone_url":"https://github.com/planetscale/vitess.git","svn_url":"https://github.com/planetscale/vitess","homepage":"http://vitess.io","size":103855,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"vitessio:master","ref":"master","sha":"dceeeba06754c806efe87937c906d0d606929153","user":{"login":"vitessio","id":33043890,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDQzODkw","avatar_url":"https://avatars1.githubusercontent.com/u/33043890?v=4","gravatar_id":"","url":"https://api.github.com/users/vitessio","html_url":"https://github.com/vitessio","followers_url":"https://api.github.com/users/vitessio/followers","following_url":"https://api.github.com/users/vitessio/following{/other_user}","gists_url":"https://api.github.com/users/vitessio/gists{/gist_id}","starred_url":"https://api.github.com/users/vitessio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitessio/subscriptions","organizations_url":"https://api.github.com/users/vitessio/orgs","repos_url":"https://api.github.com/users/vitessio/repos","events_url":"https://api.github.com/users/vitessio/events{/privacy}","received_events_url":"https://api.github.com/users/vitessio/received_events","type":"Organization","site_admin":false},"repo":{"id":11008207,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAwODIwNw==","name":"vitess","full_name":"vitessio/vitess","private":false,"owner":{"login":"vitessio","id":33043890,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDQzODkw","avatar_url":"https://avatars1.githubusercontent.com/u/33043890?v=4","gravatar_id":"","url":"https://api.github.com/users/vitessio","html_url":"https://github.com/vitessio","followers_url":"https://api.github.com/users/vitessio/followers","following_url":"https://api.github.com/users/vitessio/following{/other_user}","gists_url":"https://api.github.com/users/vitessio/gists{/gist_id}","starred_url":"https://api.github.com/users/vitessio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitessio/subscriptions","organizations_url":"https://api.github.com/users/vitessio/orgs","repos_url":"https://api.github.com/users/vitessio/repos","events_url":"https://api.github.com/users/vitessio/events{/privacy}","received_events_url":"https://api.github.com/users/vitessio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vitessio/vitess","description":"Vitess is a database clustering system for horizontal scaling of MySQL.","fork":false,"url":"https://api.github.com/repos/vitessio/vitess","forks_url":"https://api.github.com/repos/vitessio/vitess/forks","keys_url":"https://api.github.com/repos/vitessio/vitess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vitessio/vitess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vitessio/vitess/teams","hooks_url":"https://api.github.com/repos/vitessio/vitess/hooks","issue_events_url":"https://api.github.com/repos/vitessio/vitess/issues/events{/number}","events_url":"https://api.github.com/repos/vitessio/vitess/events","assignees_url":"https://api.github.com/repos/vitessio/vitess/assignees{/user}","branches_url":"https://api.github.com/repos/vitessio/vitess/branches{/branch}","tags_url":"https://api.github.com/repos/vitessio/vitess/tags","blobs_url":"https://api.github.com/repos/vitessio/vitess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vitessio/vitess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vitessio/vitess/git/refs{/sha}","trees_url":"https://api.github.com/repos/vitessio/vitess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vitessio/vitess/statuses/{sha}","languages_url":"https://api.github.com/repos/vitessio/vitess/languages","stargazers_url":"https://api.github.com/repos/vitessio/vitess/stargazers","contributors_url":"https://api.github.com/repos/vitessio/vitess/contributors","subscribers_url":"https://api.github.com/repos/vitessio/vitess/subscribers","subscription_url":"https://api.github.com/repos/vitessio/vitess/subscription","commits_url":"https://api.github.com/repos/vitessio/vitess/commits{/sha}","git_commits_url":"https://api.github.com/repos/vitessio/vitess/git/commits{/sha}","comments_url":"https://api.github.com/repos/vitessio/vitess/comments{/number}","issue_comment_url":"https://api.github.com/repos/vitessio/vitess/issues/comments{/number}","contents_url":"https://api.github.com/repos/vitessio/vitess/contents/{+path}","compare_url":"https://api.github.com/repos/vitessio/vitess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vitessio/vitess/merges","archive_url":"https://api.github.com/repos/vitessio/vitess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vitessio/vitess/downloads","issues_url":"https://api.github.com/repos/vitessio/vitess/issues{/number}","pulls_url":"https://api.github.com/repos/vitessio/vitess/pulls{/number}","milestones_url":"https://api.github.com/repos/vitessio/vitess/milestones{/number}","notifications_url":"https://api.github.com/repos/vitessio/vitess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vitessio/vitess/labels{/name}","releases_url":"https://api.github.com/repos/vitessio/vitess/releases{/id}","deployments_url":"https://api.github.com/repos/vitessio/vitess/deployments","created_at":"2013-06-27T21:20:28Z","updated_at":"2019-07-23T00:03:21Z","pushed_at":"2019-07-23T00:22:12Z","git_url":"git://github.com/vitessio/vitess.git","ssh_url":"[email protected]:vitessio/vitess.git","clone_url":"https://github.com/vitessio/vitess.git","svn_url":"https://github.com/vitessio/vitess","homepage":"http://vitess.io","size":103713,"stargazers_count":8366,"watchers_count":8366,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1079,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":350,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1079,"open_issues":350,"watchers":8366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/5000"},"html":{"href":"https://github.com/vitessio/vitess/pull/5000"},"issue":{"href":"https://api.github.com/repos/vitessio/vitess/issues/5000"},"comments":{"href":"https://api.github.com/repos/vitessio/vitess/issues/5000/comments"},"review_comments":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/5000/comments"},"review_comment":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vitessio/vitess/pulls/5000/commits"},"statuses":{"href":"https://api.github.com/repos/vitessio/vitess/statuses/7d6f8fcc4b4ec9256b6b07029f518d5cb3cc6826"}},"author_association":"COLLABORATOR"}}	{ "id": 11008207, "name": "vitessio/vitess", "url": "https://api.github.com/repos/vitessio/vitess" }	{ "id": 388311, "login": "deepthi", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/388311?", "url": "https://api.github.com/users/deepthi" }	{ "id": 33043890, "login": "vitessio", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/33043890?", "url": "https://api.github.com/orgs/vitessio" }	2019-07-23T00:23:19	10062273289	{"actor":{"display_login":"deepthi"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/kubeflow/testing/pulls/comments/353294698","pull_request_review_id":326288340,"id":353294698,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MzI5NDY5OA==","diff_hunk":"@@ -317,38 +315,41 @@ def cleanup_instance_groups(args):\n for s in results[\"items\"]:\n name = s[\"name\"]\n age = getAge(s[\"creationTimestamp\"])\n+ size = s[\"size\"]\n+ if size > 0:","path":"py/kubeflow/testing/cleanup_ci.py","position":43,"original_position":43,"commit_id":"d78afae9c7a644d1f128d5ff7f172f7cb9343d33","original_commit_id":"d78afae9c7a644d1f128d5ff7f172f7cb9343d33","user":{"login":"jlewi","id":777219,"node_id":"MDQ6VXNlcjc3NzIxOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},"body":"@gabrielwen Thanks. Looks like we do set the min pool size to zero\r\nhttps://github.com/kubeflow/manifests/blob/00fa81b956682ee835d75e21413c8008bf2bf170/gcp/deployment_manager_configs/cluster-kubeflow.yaml#L53\r\n\r\n","created_at":"2019-12-03T16:44:29Z","updated_at":"2019-12-03T16:44:29Z","html_url":"https://github.com/kubeflow/testing/pull/529#discussion_r353294698","pull_request_url":"https://api.github.com/repos/kubeflow/testing/pulls/529","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubeflow/testing/pulls/comments/353294698"},"html":{"href":"https://github.com/kubeflow/testing/pull/529#discussion_r353294698"},"pull_request":{"href":"https://api.github.com/repos/kubeflow/testing/pulls/529"}},"in_reply_to_id":351021424},"pull_request":{"url":"https://api.github.com/repos/kubeflow/testing/pulls/529","id":345435253,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1NDM1MjUz","html_url":"https://github.com/kubeflow/testing/pull/529","diff_url":"https://github.com/kubeflow/testing/pull/529.diff","patch_url":"https://github.com/kubeflow/testing/pull/529.patch","issue_url":"https://api.github.com/repos/kubeflow/testing/issues/529","number":529,"state":"open","locked":false,"title":"Gc instance groups based on usage","user":{"login":"gabrielwen","id":4784270,"node_id":"MDQ6VXNlcjQ3ODQyNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/4784270?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrielwen","html_url":"https://github.com/gabrielwen","followers_url":"https://api.github.com/users/gabrielwen/followers","following_url":"https://api.github.com/users/gabrielwen/following{/other_user}","gists_url":"https://api.github.com/users/gabrielwen/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielwen/subscriptions","organizations_url":"https://api.github.com/users/gabrielwen/orgs","repos_url":"https://api.github.com/users/gabrielwen/repos","events_url":"https://api.github.com/users/gabrielwen/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielwen/received_events","type":"User","site_admin":false},"body":"Fixes: #528 \r\nVerified this should work locally.;\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/testing/529)\n<!-- Reviewable:end -->\n","created_at":"2019-11-25T21:52:50Z","updated_at":"2019-12-03T16:44:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3330adfe05502bc2dfaebd47ff7b0a6c2a2ad210","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zhenghuiwang","id":8263977,"node_id":"MDQ6VXNlcjgyNjM5Nzc=","avatar_url":"https://avatars1.githubusercontent.com/u/8263977?v=4","gravatar_id":"","url":"https://api.github.com/users/zhenghuiwang","html_url":"https://github.com/zhenghuiwang","followers_url":"https://api.github.com/users/zhenghuiwang/followers","following_url":"https://api.github.com/users/zhenghuiwang/following{/other_user}","gists_url":"https://api.github.com/users/zhenghuiwang/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenghuiwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenghuiwang/subscriptions","organizations_url":"https://api.github.com/users/zhenghuiwang/orgs","repos_url":"https://api.github.com/users/zhenghuiwang/repos","events_url":"https://api.github.com/users/zhenghuiwang/events{/privacy}","received_events_url":"https://api.github.com/users/zhenghuiwang/received_events","type":"User","site_admin":false},{"login":"kunmingg","id":37601826,"node_id":"MDQ6VXNlcjM3NjAxODI2","avatar_url":"https://avatars2.githubusercontent.com/u/37601826?v=4","gravatar_id":"","url":"https://api.github.com/users/kunmingg","html_url":"https://github.com/kunmingg","followers_url":"https://api.github.com/users/kunmingg/followers","following_url":"https://api.github.com/users/kunmingg/following{/other_user}","gists_url":"https://api.github.com/users/kunmingg/gists{/gist_id}","starred_url":"https://api.github.com/users/kunmingg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kunmingg/subscriptions","organizations_url":"https://api.github.com/users/kunmingg/orgs","repos_url":"https://api.github.com/users/kunmingg/repos","events_url":"https://api.github.com/users/kunmingg/events{/privacy}","received_events_url":"https://api.github.com/users/kunmingg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":844255424,"node_id":"MDU6TGFiZWw4NDQyNTU0MjQ=","url":"https://api.github.com/repos/kubeflow/testing/labels/size/M","name":"size/M","color":"ededed","default":false,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeflow/testing/pulls/529/commits","review_comments_url":"https://api.github.com/repos/kubeflow/testing/pulls/529/comments","review_comment_url":"https://api.github.com/repos/kubeflow/testing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeflow/testing/issues/529/comments","statuses_url":"https://api.github.com/repos/kubeflow/testing/statuses/d78afae9c7a644d1f128d5ff7f172f7cb9343d33","head":{"label":"gabrielwen:gc-ig","ref":"gc-ig","sha":"d78afae9c7a644d1f128d5ff7f172f7cb9343d33","user":{"login":"gabrielwen","id":4784270,"node_id":"MDQ6VXNlcjQ3ODQyNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/4784270?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrielwen","html_url":"https://github.com/gabrielwen","followers_url":"https://api.github.com/users/gabrielwen/followers","following_url":"https://api.github.com/users/gabrielwen/following{/other_user}","gists_url":"https://api.github.com/users/gabrielwen/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielwen/subscriptions","organizations_url":"https://api.github.com/users/gabrielwen/orgs","repos_url":"https://api.github.com/users/gabrielwen/repos","events_url":"https://api.github.com/users/gabrielwen/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielwen/received_events","type":"User","site_admin":false},"repo":{"id":163897005,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM4OTcwMDU=","name":"testing","full_name":"gabrielwen/testing","private":false,"owner":{"login":"gabrielwen","id":4784270,"node_id":"MDQ6VXNlcjQ3ODQyNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/4784270?v=4","gravatar_id":"","url":"https://api.github.com/users/gabrielwen","html_url":"https://github.com/gabrielwen","followers_url":"https://api.github.com/users/gabrielwen/followers","following_url":"https://api.github.com/users/gabrielwen/following{/other_user}","gists_url":"https://api.github.com/users/gabrielwen/gists{/gist_id}","starred_url":"https://api.github.com/users/gabrielwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabrielwen/subscriptions","organizations_url":"https://api.github.com/users/gabrielwen/orgs","repos_url":"https://api.github.com/users/gabrielwen/repos","events_url":"https://api.github.com/users/gabrielwen/events{/privacy}","received_events_url":"https://api.github.com/users/gabrielwen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gabrielwen/testing","description":"Test infrastructure and tooling for Kubeflow.","fork":true,"url":"https://api.github.com/repos/gabrielwen/testing","forks_url":"https://api.github.com/repos/gabrielwen/testing/forks","keys_url":"https://api.github.com/repos/gabrielwen/testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabrielwen/testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabrielwen/testing/teams","hooks_url":"https://api.github.com/repos/gabrielwen/testing/hooks","issue_events_url":"https://api.github.com/repos/gabrielwen/testing/issues/events{/number}","events_url":"https://api.github.com/repos/gabrielwen/testing/events","assignees_url":"https://api.github.com/repos/gabrielwen/testing/assignees{/user}","branches_url":"https://api.github.com/repos/gabrielwen/testing/branches{/branch}","tags_url":"https://api.github.com/repos/gabrielwen/testing/tags","blobs_url":"https://api.github.com/repos/gabrielwen/testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabrielwen/testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabrielwen/testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabrielwen/testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabrielwen/testing/statuses/{sha}","languages_url":"https://api.github.com/repos/gabrielwen/testing/languages","stargazers_url":"https://api.github.com/repos/gabrielwen/testing/stargazers","contributors_url":"https://api.github.com/repos/gabrielwen/testing/contributors","subscribers_url":"https://api.github.com/repos/gabrielwen/testing/subscribers","subscription_url":"https://api.github.com/repos/gabrielwen/testing/subscription","commits_url":"https://api.github.com/repos/gabrielwen/testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabrielwen/testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabrielwen/testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabrielwen/testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabrielwen/testing/contents/{+path}","compare_url":"https://api.github.com/repos/gabrielwen/testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabrielwen/testing/merges","archive_url":"https://api.github.com/repos/gabrielwen/testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabrielwen/testing/downloads","issues_url":"https://api.github.com/repos/gabrielwen/testing/issues{/number}","pulls_url":"https://api.github.com/repos/gabrielwen/testing/pulls{/number}","milestones_url":"https://api.github.com/repos/gabrielwen/testing/milestones{/number}","notifications_url":"https://api.github.com/repos/gabrielwen/testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabrielwen/testing/labels{/name}","releases_url":"https://api.github.com/repos/gabrielwen/testing/releases{/id}","deployments_url":"https://api.github.com/repos/gabrielwen/testing/deployments","created_at":"2019-01-02T22:41:03Z","updated_at":"2019-11-25T21:14:58Z","pushed_at":"2019-11-26T21:33:57Z","git_url":"git://github.com/gabrielwen/testing.git","ssh_url":"[email protected]:gabrielwen/testing.git","clone_url":"https://github.com/gabrielwen/testing.git","svn_url":"https://github.com/gabrielwen/testing","homepage":null,"size":20133,"stargazers_count":0,"watchers_count":0,"language":"Jsonnet","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeflow:master","ref":"master","sha":"25b87a36f03c207f69abbc9e18500e9ac75647d0","user":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":119692762,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk2OTI3NjI=","name":"testing","full_name":"kubeflow/testing","private":false,"owner":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubeflow/testing","description":"Test infrastructure and tooling for Kubeflow.","fork":false,"url":"https://api.github.com/repos/kubeflow/testing","forks_url":"https://api.github.com/repos/kubeflow/testing/forks","keys_url":"https://api.github.com/repos/kubeflow/testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/testing/teams","hooks_url":"https://api.github.com/repos/kubeflow/testing/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/testing/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/testing/events","assignees_url":"https://api.github.com/repos/kubeflow/testing/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/testing/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/testing/tags","blobs_url":"https://api.github.com/repos/kubeflow/testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/testing/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/testing/languages","stargazers_url":"https://api.github.com/repos/kubeflow/testing/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/testing/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/testing/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/testing/subscription","commits_url":"https://api.github.com/repos/kubeflow/testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/testing/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/testing/merges","archive_url":"https://api.github.com/repos/kubeflow/testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/testing/downloads","issues_url":"https://api.github.com/repos/kubeflow/testing/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/testing/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/testing/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/testing/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/testing/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/testing/deployments","created_at":"2018-01-31T13:45:52Z","updated_at":"2019-11-22T21:26:47Z","pushed_at":"2019-12-02T10:53:31Z","git_url":"git://github.com/kubeflow/testing.git","ssh_url":"[email protected]:kubeflow/testing.git","clone_url":"https://github.com/kubeflow/testing.git","svn_url":"https://github.com/kubeflow/testing","homepage":null,"size":21711,"stargazers_count":26,"watchers_count":26,"language":"Jsonnet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":42,"open_issues":48,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeflow/testing/pulls/529"},"html":{"href":"https://github.com/kubeflow/testing/pull/529"},"issue":{"href":"https://api.github.com/repos/kubeflow/testing/issues/529"},"comments":{"href":"https://api.github.com/repos/kubeflow/testing/issues/529/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeflow/testing/pulls/529/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeflow/testing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeflow/testing/pulls/529/commits"},"statuses":{"href":"https://api.github.com/repos/kubeflow/testing/statuses/d78afae9c7a644d1f128d5ff7f172f7cb9343d33"}},"author_association":"CONTRIBUTOR"}}	{ "id": 119692762, "name": "kubeflow/testing", "url": "https://api.github.com/repos/kubeflow/testing" }	{ "id": 777219, "login": "jlewi", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/777219?", "url": "https://api.github.com/users/jlewi" }	{ "id": 33164907, "login": "kubeflow", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/33164907?", "url": "https://api.github.com/orgs/kubeflow" }	2019-12-03T16:44:29	11001563021	{"actor":{"display_login":"jlewi"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/kubeflow/pipelines/pulls/comments/289230072","pull_request_review_id":244100310,"id":289230072,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4OTIzMDA3Mg==","diff_hunk":"@@ -364,7 +364,7 @@ def test_py_param_substitutions(self):\n def test_type_checking_with_consistent_types(self):\n \"\"\"Test type check pipeline parameters against component metadata.\"\"\"\n @component\n- def a_op(field_m: {'GCSPath': {'path_type': 'file', 'file_type':'tsv'}}, field_o: 'Integer'):\n+ def a_op(field_m: {'GCSPath': {'path_type': 'file', 'file_type':'tsv'}}, field_o: Integer()):","path":"sdk/python/tests/compiler/compiler_tests.py","position":5,"original_position":5,"commit_id":"76d2955e03ce96d4fa67203183631722b461d855","original_commit_id":"76d2955e03ce96d4fa67203183631722b461d855","user":{"login":"Ark-kun","id":1829149,"node_id":"MDQ6VXNlcjE4MjkxNDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1829149?v=4","gravatar_id":"","url":"https://api.github.com/users/Ark-kun","html_url":"https://github.com/Ark-kun","followers_url":"https://api.github.com/users/Ark-kun/followers","following_url":"https://api.github.com/users/Ark-kun/following{/other_user}","gists_url":"https://api.github.com/users/Ark-kun/gists{/gist_id}","starred_url":"https://api.github.com/users/Ark-kun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ark-kun/subscriptions","organizations_url":"https://api.github.com/users/Ark-kun/orgs","repos_url":"https://api.github.com/users/Ark-kun/repos","events_url":"https://api.github.com/users/Ark-kun/events{/privacy}","received_events_url":"https://api.github.com/users/Ark-kun/received_events","type":"User","site_admin":false},"body":"I see.\r\nIs it OK if the \"schema-less\" 'Integer' will also be checked by the UI?","created_at":"2019-05-31T01:30:40Z","updated_at":"2019-05-31T01:30:40Z","html_url":"https://github.com/kubeflow/pipelines/pull/1407#discussion_r289230072","pull_request_url":"https://api.github.com/repos/kubeflow/pipelines/pulls/1407","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/comments/289230072"},"html":{"href":"https://github.com/kubeflow/pipelines/pull/1407#discussion_r289230072"},"pull_request":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/1407"}},"in_reply_to_id":289177197},"pull_request":{"url":"https://api.github.com/repos/kubeflow/pipelines/pulls/1407","id":283809081,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgzODA5MDgx","html_url":"https://github.com/kubeflow/pipelines/pull/1407","diff_url":"https://github.com/kubeflow/pipelines/pull/1407.diff","patch_url":"https://github.com/kubeflow/pipelines/pull/1407.patch","issue_url":"https://api.github.com/repos/kubeflow/pipelines/issues/1407","number":1407,"state":"open","locked":false,"title":"add default value type checking","user":{"login":"gaoning777","id":3826739,"node_id":"MDQ6VXNlcjM4MjY3Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/3826739?v=4","gravatar_id":"","url":"https://api.github.com/users/gaoning777","html_url":"https://github.com/gaoning777","followers_url":"https://api.github.com/users/gaoning777/followers","following_url":"https://api.github.com/users/gaoning777/following{/other_user}","gists_url":"https://api.github.com/users/gaoning777/gists{/gist_id}","starred_url":"https://api.github.com/users/gaoning777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaoning777/subscriptions","organizations_url":"https://api.github.com/users/gaoning777/orgs","repos_url":"https://api.github.com/users/gaoning777/repos","events_url":"https://api.github.com/users/gaoning777/events{/privacy}","received_events_url":"https://api.github.com/users/gaoning777/received_events","type":"User","site_admin":false},"body":"This enables the dsl compiler to type checking the default values if the type contains the json schema.\r\n<!-- Reviewable:start -->\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/pipelines/1407)\r\n<!-- Reviewable:end -->\r\n","created_at":"2019-05-30T20:53:01Z","updated_at":"2019-05-31T01:30:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f2b57af5bddefafa0d7179cf5e50f667f7622d0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hongye-sun","id":43763191,"node_id":"MDQ6VXNlcjQzNzYzMTkx","avatar_url":"https://avatars2.githubusercontent.com/u/43763191?v=4","gravatar_id":"","url":"https://api.github.com/users/hongye-sun","html_url":"https://github.com/hongye-sun","followers_url":"https://api.github.com/users/hongye-sun/followers","following_url":"https://api.github.com/users/hongye-sun/following{/other_user}","gists_url":"https://api.github.com/users/hongye-sun/gists{/gist_id}","starred_url":"https://api.github.com/users/hongye-sun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongye-sun/subscriptions","organizations_url":"https://api.github.com/users/hongye-sun/orgs","repos_url":"https://api.github.com/users/hongye-sun/repos","events_url":"https://api.github.com/users/hongye-sun/events{/privacy}","received_events_url":"https://api.github.com/users/hongye-sun/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":955884211,"node_id":"MDU6TGFiZWw5NTU4ODQyMTE=","url":"https://api.github.com/repos/kubeflow/pipelines/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeflow/pipelines/pulls/1407/commits","review_comments_url":"https://api.github.com/repos/kubeflow/pipelines/pulls/1407/comments","review_comment_url":"https://api.github.com/repos/kubeflow/pipelines/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeflow/pipelines/issues/1407/comments","statuses_url":"https://api.github.com/repos/kubeflow/pipelines/statuses/76d2955e03ce96d4fa67203183631722b461d855","head":{"label":"gaoning777:dsl-default-value-checking","ref":"dsl-default-value-checking","sha":"76d2955e03ce96d4fa67203183631722b461d855","user":{"login":"gaoning777","id":3826739,"node_id":"MDQ6VXNlcjM4MjY3Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/3826739?v=4","gravatar_id":"","url":"https://api.github.com/users/gaoning777","html_url":"https://github.com/gaoning777","followers_url":"https://api.github.com/users/gaoning777/followers","following_url":"https://api.github.com/users/gaoning777/following{/other_user}","gists_url":"https://api.github.com/users/gaoning777/gists{/gist_id}","starred_url":"https://api.github.com/users/gaoning777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaoning777/subscriptions","organizations_url":"https://api.github.com/users/gaoning777/orgs","repos_url":"https://api.github.com/users/gaoning777/repos","events_url":"https://api.github.com/users/gaoning777/events{/privacy}","received_events_url":"https://api.github.com/users/gaoning777/received_events","type":"User","site_admin":false},"repo":{"id":160415760,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA0MTU3NjA=","name":"pipelines","full_name":"gaoning777/pipelines","private":false,"owner":{"login":"gaoning777","id":3826739,"node_id":"MDQ6VXNlcjM4MjY3Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/3826739?v=4","gravatar_id":"","url":"https://api.github.com/users/gaoning777","html_url":"https://github.com/gaoning777","followers_url":"https://api.github.com/users/gaoning777/followers","following_url":"https://api.github.com/users/gaoning777/following{/other_user}","gists_url":"https://api.github.com/users/gaoning777/gists{/gist_id}","starred_url":"https://api.github.com/users/gaoning777/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaoning777/subscriptions","organizations_url":"https://api.github.com/users/gaoning777/orgs","repos_url":"https://api.github.com/users/gaoning777/repos","events_url":"https://api.github.com/users/gaoning777/events{/privacy}","received_events_url":"https://api.github.com/users/gaoning777/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gaoning777/pipelines","description":"Machine Learning Pipelines for Kubeflow","fork":true,"url":"https://api.github.com/repos/gaoning777/pipelines","forks_url":"https://api.github.com/repos/gaoning777/pipelines/forks","keys_url":"https://api.github.com/repos/gaoning777/pipelines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gaoning777/pipelines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gaoning777/pipelines/teams","hooks_url":"https://api.github.com/repos/gaoning777/pipelines/hooks","issue_events_url":"https://api.github.com/repos/gaoning777/pipelines/issues/events{/number}","events_url":"https://api.github.com/repos/gaoning777/pipelines/events","assignees_url":"https://api.github.com/repos/gaoning777/pipelines/assignees{/user}","branches_url":"https://api.github.com/repos/gaoning777/pipelines/branches{/branch}","tags_url":"https://api.github.com/repos/gaoning777/pipelines/tags","blobs_url":"https://api.github.com/repos/gaoning777/pipelines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gaoning777/pipelines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gaoning777/pipelines/git/refs{/sha}","trees_url":"https://api.github.com/repos/gaoning777/pipelines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gaoning777/pipelines/statuses/{sha}","languages_url":"https://api.github.com/repos/gaoning777/pipelines/languages","stargazers_url":"https://api.github.com/repos/gaoning777/pipelines/stargazers","contributors_url":"https://api.github.com/repos/gaoning777/pipelines/contributors","subscribers_url":"https://api.github.com/repos/gaoning777/pipelines/subscribers","subscription_url":"https://api.github.com/repos/gaoning777/pipelines/subscription","commits_url":"https://api.github.com/repos/gaoning777/pipelines/commits{/sha}","git_commits_url":"https://api.github.com/repos/gaoning777/pipelines/git/commits{/sha}","comments_url":"https://api.github.com/repos/gaoning777/pipelines/comments{/number}","issue_comment_url":"https://api.github.com/repos/gaoning777/pipelines/issues/comments{/number}","contents_url":"https://api.github.com/repos/gaoning777/pipelines/contents/{+path}","compare_url":"https://api.github.com/repos/gaoning777/pipelines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gaoning777/pipelines/merges","archive_url":"https://api.github.com/repos/gaoning777/pipelines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gaoning777/pipelines/downloads","issues_url":"https://api.github.com/repos/gaoning777/pipelines/issues{/number}","pulls_url":"https://api.github.com/repos/gaoning777/pipelines/pulls{/number}","milestones_url":"https://api.github.com/repos/gaoning777/pipelines/milestones{/number}","notifications_url":"https://api.github.com/repos/gaoning777/pipelines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gaoning777/pipelines/labels{/name}","releases_url":"https://api.github.com/repos/gaoning777/pipelines/releases{/id}","deployments_url":"https://api.github.com/repos/gaoning777/pipelines/deployments","created_at":"2018-12-04T20:36:54Z","updated_at":"2019-02-08T18:10:48Z","pushed_at":"2019-05-30T20:56:02Z","git_url":"git://github.com/gaoning777/pipelines.git","ssh_url":"[email protected]:gaoning777/pipelines.git","clone_url":"https://github.com/gaoning777/pipelines.git","svn_url":"https://github.com/gaoning777/pipelines","homepage":"","size":18082,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeflow:master","ref":"master","sha":"5f1b41171f934b568869e46c39a7f49ac4d336ad","user":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":133100880,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMxMDA4ODA=","name":"pipelines","full_name":"kubeflow/pipelines","private":false,"owner":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubeflow/pipelines","description":"Machine Learning Pipelines for Kubeflow","fork":false,"url":"https://api.github.com/repos/kubeflow/pipelines","forks_url":"https://api.github.com/repos/kubeflow/pipelines/forks","keys_url":"https://api.github.com/repos/kubeflow/pipelines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/pipelines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/pipelines/teams","hooks_url":"https://api.github.com/repos/kubeflow/pipelines/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/pipelines/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/pipelines/events","assignees_url":"https://api.github.com/repos/kubeflow/pipelines/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/pipelines/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/pipelines/tags","blobs_url":"https://api.github.com/repos/kubeflow/pipelines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/pipelines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/pipelines/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/pipelines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/pipelines/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/pipelines/languages","stargazers_url":"https://api.github.com/repos/kubeflow/pipelines/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/pipelines/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/pipelines/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/pipelines/subscription","commits_url":"https://api.github.com/repos/kubeflow/pipelines/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/pipelines/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/pipelines/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/pipelines/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/pipelines/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/pipelines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/pipelines/merges","archive_url":"https://api.github.com/repos/kubeflow/pipelines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/pipelines/downloads","issues_url":"https://api.github.com/repos/kubeflow/pipelines/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/pipelines/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/pipelines/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/pipelines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/pipelines/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/pipelines/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/pipelines/deployments","created_at":"2018-05-12T00:31:47Z","updated_at":"2019-05-31T01:02:40Z","pushed_at":"2019-05-31T01:02:30Z","git_url":"git://github.com/kubeflow/pipelines.git","ssh_url":"[email protected]:kubeflow/pipelines.git","clone_url":"https://github.com/kubeflow/pipelines.git","svn_url":"https://github.com/kubeflow/pipelines","homepage":"","size":119619,"stargazers_count":861,"watchers_count":861,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":213,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":276,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":213,"open_issues":276,"watchers":861,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/1407"},"html":{"href":"https://github.com/kubeflow/pipelines/pull/1407"},"issue":{"href":"https://api.github.com/repos/kubeflow/pipelines/issues/1407"},"comments":{"href":"https://api.github.com/repos/kubeflow/pipelines/issues/1407/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/1407/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeflow/pipelines/pulls/1407/commits"},"statuses":{"href":"https://api.github.com/repos/kubeflow/pipelines/statuses/76d2955e03ce96d4fa67203183631722b461d855"}},"author_association":"CONTRIBUTOR"}}	{ "id": 133100880, "name": "kubeflow/pipelines", "url": "https://api.github.com/repos/kubeflow/pipelines" }	{ "id": 1829149, "login": "Ark-kun", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/1829149?", "url": "https://api.github.com/users/Ark-kun" }	{ "id": 33164907, "login": "kubeflow", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/33164907?", "url": "https://api.github.com/orgs/kubeflow" }	2019-05-31T01:30:40	9731317586	{"actor":{"display_login":"Ark-kun"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/kubeflow/kfserving/pulls/comments/310811962","pull_request_review_id":271029275,"id":310811962,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMDgxMTk2Mg==","diff_hunk":"@@ -39,7 +39,8 @@\n \"requests>=2.22.0\",\n \"joblib>=0.13.2\",\n \"pandas>=0.24.2\",\n- \"numpy>=1.16.3\"\n+ \"numpy>=1.16.3\",\n+ \"dill>=0.3.0\"\n ],","path":"python/alibiexplainer/setup.py","position":7,"original_position":7,"commit_id":"e4be2c6f6b844c093ca5bd85048f3382c54e4f37","original_commit_id":"e4be2c6f6b844c093ca5bd85048f3382c54e4f37","user":{"login":"animeshsingh","id":3631320,"node_id":"MDQ6VXNlcjM2MzEzMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/3631320?v=4","gravatar_id":"","url":"https://api.github.com/users/animeshsingh","html_url":"https://github.com/animeshsingh","followers_url":"https://api.github.com/users/animeshsingh/followers","following_url":"https://api.github.com/users/animeshsingh/following{/other_user}","gists_url":"https://api.github.com/users/animeshsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/animeshsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/animeshsingh/subscriptions","organizations_url":"https://api.github.com/users/animeshsingh/orgs","repos_url":"https://api.github.com/users/animeshsingh/repos","events_url":"https://api.github.com/users/animeshsingh/events{/privacy}","received_events_url":"https://api.github.com/users/animeshsingh/received_events","type":"User","site_admin":false},"body":"What's the dill being used here for?","created_at":"2019-08-05T22:08:28Z","updated_at":"2019-08-05T22:08:54Z","html_url":"https://github.com/kubeflow/kfserving/pull/256#discussion_r310811962","pull_request_url":"https://api.github.com/repos/kubeflow/kfserving/pulls/256","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kfserving/pulls/comments/310811962"},"html":{"href":"https://github.com/kubeflow/kfserving/pull/256#discussion_r310811962"},"pull_request":{"href":"https://api.github.com/repos/kubeflow/kfserving/pulls/256"}}},"pull_request":{"url":"https://api.github.com/repos/kubeflow/kfserving/pulls/256","id":298964897,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk4OTY0ODk3","html_url":"https://github.com/kubeflow/kfserving/pull/256","diff_url":"https://github.com/kubeflow/kfserving/pull/256.diff","patch_url":"https://github.com/kubeflow/kfserving/pull/256.patch","issue_url":"https://api.github.com/repos/kubeflow/kfserving/issues/256","number":256,"state":"open","locked":false,"title":"Update Alibi Explainer to load pre-trained explainer","user":{"login":"cliveseldon","id":10563075,"node_id":"MDQ6VXNlcjEwNTYzMDc1","avatar_url":"https://avatars2.githubusercontent.com/u/10563075?v=4","gravatar_id":"","url":"https://api.github.com/users/cliveseldon","html_url":"https://github.com/cliveseldon","followers_url":"https://api.github.com/users/cliveseldon/followers","following_url":"https://api.github.com/users/cliveseldon/following{/other_user}","gists_url":"https://api.github.com/users/cliveseldon/gists{/gist_id}","starred_url":"https://api.github.com/users/cliveseldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cliveseldon/subscriptions","organizations_url":"https://api.github.com/users/cliveseldon/orgs","repos_url":"https://api.github.com/users/cliveseldon/repos","events_url":"https://api.github.com/users/cliveseldon/events{/privacy}","received_events_url":"https://api.github.com/users/cliveseldon/received_events","type":"User","site_admin":false},"body":"\r\nAllow AlibiExplainer to be started with a pre-trained explainer.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/kfserving/256)\n<!-- Reviewable:end -->\n","created_at":"2019-07-18T15:18:30Z","updated_at":"2019-08-05T22:08:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d09811ae27cdfa1686e8a28088ff3417744cfbbf","assignee":{"login":"ellis-bigelow","id":2585992,"node_id":"MDQ6VXNlcjI1ODU5OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2585992?v=4","gravatar_id":"","url":"https://api.github.com/users/ellis-bigelow","html_url":"https://github.com/ellis-bigelow","followers_url":"https://api.github.com/users/ellis-bigelow/followers","following_url":"https://api.github.com/users/ellis-bigelow/following{/other_user}","gists_url":"https://api.github.com/users/ellis-bigelow/gists{/gist_id}","starred_url":"https://api.github.com/users/ellis-bigelow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellis-bigelow/subscriptions","organizations_url":"https://api.github.com/users/ellis-bigelow/orgs","repos_url":"https://api.github.com/users/ellis-bigelow/repos","events_url":"https://api.github.com/users/ellis-bigelow/events{/privacy}","received_events_url":"https://api.github.com/users/ellis-bigelow/received_events","type":"User","site_admin":false},"assignees":[{"login":"ellis-bigelow","id":2585992,"node_id":"MDQ6VXNlcjI1ODU5OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2585992?v=4","gravatar_id":"","url":"https://api.github.com/users/ellis-bigelow","html_url":"https://github.com/ellis-bigelow","followers_url":"https://api.github.com/users/ellis-bigelow/followers","following_url":"https://api.github.com/users/ellis-bigelow/following{/other_user}","gists_url":"https://api.github.com/users/ellis-bigelow/gists{/gist_id}","starred_url":"https://api.github.com/users/ellis-bigelow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellis-bigelow/subscriptions","organizations_url":"https://api.github.com/users/ellis-bigelow/orgs","repos_url":"https://api.github.com/users/ellis-bigelow/repos","events_url":"https://api.github.com/users/ellis-bigelow/events{/privacy}","received_events_url":"https://api.github.com/users/ellis-bigelow/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bhupc","id":302338,"node_id":"MDQ6VXNlcjMwMjMzOA==","avatar_url":"https://avatars3.githubusercontent.com/u/302338?v=4","gravatar_id":"","url":"https://api.github.com/users/bhupc","html_url":"https://github.com/bhupc","followers_url":"https://api.github.com/users/bhupc/followers","following_url":"https://api.github.com/users/bhupc/following{/other_user}","gists_url":"https://api.github.com/users/bhupc/gists{/gist_id}","starred_url":"https://api.github.com/users/bhupc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhupc/subscriptions","organizations_url":"https://api.github.com/users/bhupc/orgs","repos_url":"https://api.github.com/users/bhupc/repos","events_url":"https://api.github.com/users/bhupc/events{/privacy}","received_events_url":"https://api.github.com/users/bhupc/received_events","type":"User","site_admin":false},{"login":"jinchihe","id":13673199,"node_id":"MDQ6VXNlcjEzNjczMTk5","avatar_url":"https://avatars2.githubusercontent.com/u/13673199?v=4","gravatar_id":"","url":"https://api.github.com/users/jinchihe","html_url":"https://github.com/jinchihe","followers_url":"https://api.github.com/users/jinchihe/followers","following_url":"https://api.github.com/users/jinchihe/following{/other_user}","gists_url":"https://api.github.com/users/jinchihe/gists{/gist_id}","starred_url":"https://api.github.com/users/jinchihe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinchihe/subscriptions","organizations_url":"https://api.github.com/users/jinchihe/orgs","repos_url":"https://api.github.com/users/jinchihe/repos","events_url":"https://api.github.com/users/jinchihe/events{/privacy}","received_events_url":"https://api.github.com/users/jinchihe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1292780671,"node_id":"MDU6TGFiZWwxMjkyNzgwNjcx","url":"https://api.github.com/repos/kubeflow/kfserving/labels/approved","name":"approved","color":"03db12","default":false},{"id":1292780631,"node_id":"MDU6TGFiZWwxMjkyNzgwNjMx","url":"https://api.github.com/repos/kubeflow/kfserving/labels/lgtm","name":"lgtm","color":"2efca4","default":false},{"id":1302934170,"node_id":"MDU6TGFiZWwxMzAyOTM0MTcw","url":"https://api.github.com/repos/kubeflow/kfserving/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeflow/kfserving/pulls/256/commits","review_comments_url":"https://api.github.com/repos/kubeflow/kfserving/pulls/256/comments","review_comment_url":"https://api.github.com/repos/kubeflow/kfserving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeflow/kfserving/issues/256/comments","statuses_url":"https://api.github.com/repos/kubeflow/kfserving/statuses/e4be2c6f6b844c093ca5bd85048f3382c54e4f37","head":{"label":"cliveseldon:explainer_update_jul","ref":"explainer_update_jul","sha":"e4be2c6f6b844c093ca5bd85048f3382c54e4f37","user":{"login":"cliveseldon","id":10563075,"node_id":"MDQ6VXNlcjEwNTYzMDc1","avatar_url":"https://avatars2.githubusercontent.com/u/10563075?v=4","gravatar_id":"","url":"https://api.github.com/users/cliveseldon","html_url":"https://github.com/cliveseldon","followers_url":"https://api.github.com/users/cliveseldon/followers","following_url":"https://api.github.com/users/cliveseldon/following{/other_user}","gists_url":"https://api.github.com/users/cliveseldon/gists{/gist_id}","starred_url":"https://api.github.com/users/cliveseldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cliveseldon/subscriptions","organizations_url":"https://api.github.com/users/cliveseldon/orgs","repos_url":"https://api.github.com/users/cliveseldon/repos","events_url":"https://api.github.com/users/cliveseldon/events{/privacy}","received_events_url":"https://api.github.com/users/cliveseldon/received_events","type":"User","site_admin":false},"repo":{"id":180375888,"node_id":"MDEwOlJlcG9zaXRvcnkxODAzNzU4ODg=","name":"kfserving","full_name":"cliveseldon/kfserving","private":false,"owner":{"login":"cliveseldon","id":10563075,"node_id":"MDQ6VXNlcjEwNTYzMDc1","avatar_url":"https://avatars2.githubusercontent.com/u/10563075?v=4","gravatar_id":"","url":"https://api.github.com/users/cliveseldon","html_url":"https://github.com/cliveseldon","followers_url":"https://api.github.com/users/cliveseldon/followers","following_url":"https://api.github.com/users/cliveseldon/following{/other_user}","gists_url":"https://api.github.com/users/cliveseldon/gists{/gist_id}","starred_url":"https://api.github.com/users/cliveseldon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cliveseldon/subscriptions","organizations_url":"https://api.github.com/users/cliveseldon/orgs","repos_url":"https://api.github.com/users/cliveseldon/repos","events_url":"https://api.github.com/users/cliveseldon/events{/privacy}","received_events_url":"https://api.github.com/users/cliveseldon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cliveseldon/kfserving","description":"Model serving related infrastructure in Kubeflow","fork":true,"url":"https://api.github.com/repos/cliveseldon/kfserving","forks_url":"https://api.github.com/repos/cliveseldon/kfserving/forks","keys_url":"https://api.github.com/repos/cliveseldon/kfserving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cliveseldon/kfserving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cliveseldon/kfserving/teams","hooks_url":"https://api.github.com/repos/cliveseldon/kfserving/hooks","issue_events_url":"https://api.github.com/repos/cliveseldon/kfserving/issues/events{/number}","events_url":"https://api.github.com/repos/cliveseldon/kfserving/events","assignees_url":"https://api.github.com/repos/cliveseldon/kfserving/assignees{/user}","branches_url":"https://api.github.com/repos/cliveseldon/kfserving/branches{/branch}","tags_url":"https://api.github.com/repos/cliveseldon/kfserving/tags","blobs_url":"https://api.github.com/repos/cliveseldon/kfserving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cliveseldon/kfserving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cliveseldon/kfserving/git/refs{/sha}","trees_url":"https://api.github.com/repos/cliveseldon/kfserving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cliveseldon/kfserving/statuses/{sha}","languages_url":"https://api.github.com/repos/cliveseldon/kfserving/languages","stargazers_url":"https://api.github.com/repos/cliveseldon/kfserving/stargazers","contributors_url":"https://api.github.com/repos/cliveseldon/kfserving/contributors","subscribers_url":"https://api.github.com/repos/cliveseldon/kfserving/subscribers","subscription_url":"https://api.github.com/repos/cliveseldon/kfserving/subscription","commits_url":"https://api.github.com/repos/cliveseldon/kfserving/commits{/sha}","git_commits_url":"https://api.github.com/repos/cliveseldon/kfserving/git/commits{/sha}","comments_url":"https://api.github.com/repos/cliveseldon/kfserving/comments{/number}","issue_comment_url":"https://api.github.com/repos/cliveseldon/kfserving/issues/comments{/number}","contents_url":"https://api.github.com/repos/cliveseldon/kfserving/contents/{+path}","compare_url":"https://api.github.com/repos/cliveseldon/kfserving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cliveseldon/kfserving/merges","archive_url":"https://api.github.com/repos/cliveseldon/kfserving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cliveseldon/kfserving/downloads","issues_url":"https://api.github.com/repos/cliveseldon/kfserving/issues{/number}","pulls_url":"https://api.github.com/repos/cliveseldon/kfserving/pulls{/number}","milestones_url":"https://api.github.com/repos/cliveseldon/kfserving/milestones{/number}","notifications_url":"https://api.github.com/repos/cliveseldon/kfserving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cliveseldon/kfserving/labels{/name}","releases_url":"https://api.github.com/repos/cliveseldon/kfserving/releases{/id}","deployments_url":"https://api.github.com/repos/cliveseldon/kfserving/deployments","created_at":"2019-04-09T13:42:08Z","updated_at":"2019-07-19T08:26:30Z","pushed_at":"2019-07-24T17:52:13Z","git_url":"git://github.com/cliveseldon/kfserving.git","ssh_url":"[email protected]:cliveseldon/kfserving.git","clone_url":"https://github.com/cliveseldon/kfserving.git","svn_url":"https://github.com/cliveseldon/kfserving","homepage":null,"size":79635,"stargazers_count":0,"watchers_count":0,"language":"Jsonnet","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeflow:master","ref":"master","sha":"cbd101f1586e9a1f2dadca9c5e1858c313fbade9","user":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":178075572,"node_id":"MDEwOlJlcG9zaXRvcnkxNzgwNzU1NzI=","name":"kfserving","full_name":"kubeflow/kfserving","private":false,"owner":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubeflow/kfserving","description":"Serverless Inferencing on Kubernetes","fork":false,"url":"https://api.github.com/repos/kubeflow/kfserving","forks_url":"https://api.github.com/repos/kubeflow/kfserving/forks","keys_url":"https://api.github.com/repos/kubeflow/kfserving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/kfserving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/kfserving/teams","hooks_url":"https://api.github.com/repos/kubeflow/kfserving/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/kfserving/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/kfserving/events","assignees_url":"https://api.github.com/repos/kubeflow/kfserving/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/kfserving/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/kfserving/tags","blobs_url":"https://api.github.com/repos/kubeflow/kfserving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/kfserving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/kfserving/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/kfserving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/kfserving/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/kfserving/languages","stargazers_url":"https://api.github.com/repos/kubeflow/kfserving/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/kfserving/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/kfserving/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/kfserving/subscription","commits_url":"https://api.github.com/repos/kubeflow/kfserving/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/kfserving/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/kfserving/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/kfserving/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/kfserving/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/kfserving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/kfserving/merges","archive_url":"https://api.github.com/repos/kubeflow/kfserving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/kfserving/downloads","issues_url":"https://api.github.com/repos/kubeflow/kfserving/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/kfserving/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/kfserving/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/kfserving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/kfserving/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/kfserving/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/kfserving/deployments","created_at":"2019-03-27T21:14:14Z","updated_at":"2019-08-05T11:55:02Z","pushed_at":"2019-08-05T19:13:19Z","git_url":"git://github.com/kubeflow/kfserving.git","ssh_url":"[email protected]:kubeflow/kfserving.git","clone_url":"https://github.com/kubeflow/kfserving.git","svn_url":"https://github.com/kubeflow/kfserving","homepage":"","size":247287,"stargazers_count":132,"watchers_count":132,"language":"Jsonnet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":47,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":40,"open_issues":47,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kfserving/pulls/256"},"html":{"href":"https://github.com/kubeflow/kfserving/pull/256"},"issue":{"href":"https://api.github.com/repos/kubeflow/kfserving/issues/256"},"comments":{"href":"https://api.github.com/repos/kubeflow/kfserving/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeflow/kfserving/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeflow/kfserving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeflow/kfserving/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/kubeflow/kfserving/statuses/e4be2c6f6b844c093ca5bd85048f3382c54e4f37"}},"author_association":"CONTRIBUTOR"}}	{ "id": 178075572, "name": "kubeflow/kfserving", "url": "https://api.github.com/repos/kubeflow/kfserving" }	{ "id": 3631320, "login": "animeshsingh", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/3631320?", "url": "https://api.github.com/users/animeshsingh" }	{ "id": 33164907, "login": "kubeflow", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/33164907?", "url": "https://api.github.com/orgs/kubeflow" }	2019-08-05T22:08:28	10152053712	{"actor":{"display_login":"animeshsingh"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/pulls/comments/359398627","pull_request_review_id":334041375,"id":359398627,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTM5ODYyNw==","diff_hunk":"@@ -0,0 +1,52 @@\n+import os\n+import numpy as np\n+from array import array\n+from sklearn.metrics import mean_absolute_error\n+from skmultiflow.data import RegressionGenerator\n+from skmultiflow.meta import AdaptiveRandomForestRegressor\n+\n+\n+def test_adaptive_random_forest_regressor():\n+ stream = RegressionGenerator(n_samples=500, n_features=20, n_informative=15, random_state=1)\n+ stream.prepare_for_use()\n+\n+ learner = AdaptiveRandomForestRegressor(random_state=1)\n+\n+ cnt = 0\n+ max_samples = 500\n+ y_pred = array('d')\n+ y_true = array('d')\n+ wait_samples = 10\n+\n+ while cnt < max_samples:\n+ X, y = stream.next_sample()\n+ # Test every n samples\n+ if (cnt % wait_samples == 0) and (cnt != 0):\n+ y_pred.append(learner.predict(X)[0])\n+ y_true.append(y[0])\n+ learner.partial_fit(X, y)\n+ cnt += 1\n+\n+ error = mean_absolute_error(y_true, y_pred)\n+ expected_error = 155.5787786499754\n+ assert (np.abs(expected_error - error) < 1)","path":"tests/meta/test_adaptive_random_forest_regressor.py","position":null,"original_position":32,"commit_id":"fe7062b44773577889a80291a02bf1bd641e6b45","original_commit_id":"74b2c2c66b1e088823bdbe0c493575067d1a843c","user":{"login":"AlbandeCrevoisier","id":19614225,"node_id":"MDQ6VXNlcjE5NjE0MjI1","avatar_url":"https://avatars2.githubusercontent.com/u/19614225?v=4","gravatar_id":"","url":"https://api.github.com/users/AlbandeCrevoisier","html_url":"https://github.com/AlbandeCrevoisier","followers_url":"https://api.github.com/users/AlbandeCrevoisier/followers","following_url":"https://api.github.com/users/AlbandeCrevoisier/following{/other_user}","gists_url":"https://api.github.com/users/AlbandeCrevoisier/gists{/gist_id}","starred_url":"https://api.github.com/users/AlbandeCrevoisier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlbandeCrevoisier/subscriptions","organizations_url":"https://api.github.com/users/AlbandeCrevoisier/orgs","repos_url":"https://api.github.com/users/AlbandeCrevoisier/repos","events_url":"https://api.github.com/users/AlbandeCrevoisier/events{/privacy}","received_events_url":"https://api.github.com/users/AlbandeCrevoisier/received_events","type":"User","site_admin":false},"body":"Update: the 'perceptron' version works fine without ADWIN...","created_at":"2019-12-18T15:12:44Z","updated_at":"2019-12-18T15:12:45Z","html_url":"https://github.com/scikit-multiflow/scikit-multiflow/pull/145#discussion_r359398627","pull_request_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/pulls/145","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/pulls/comments/359398627"},"html":{"href":"https://github.com/scikit-multiflow/scikit-multiflow/pull/145#discussion_r359398627"},"pull_request":{"href":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/pulls/145"}},"in_reply_to_id":331804260},"pull_request":{"url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/pulls/145","id":324164581,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI0MTY0NTgx","html_url":"https://github.com/scikit-multiflow/scikit-multiflow/pull/145","diff_url":"https://github.com/scikit-multiflow/scikit-multiflow/pull/145.diff","patch_url":"https://github.com/scikit-multiflow/scikit-multiflow/pull/145.patch","issue_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/issues/145","number":145,"state":"open","locked":false,"title":"Arf regressor","user":{"login":"AlbandeCrevoisier","id":19614225,"node_id":"MDQ6VXNlcjE5NjE0MjI1","avatar_url":"https://avatars2.githubusercontent.com/u/19614225?v=4","gravatar_id":"","url":"https://api.github.com/users/AlbandeCrevoisier","html_url":"https://github.com/AlbandeCrevoisier","followers_url":"https://api.github.com/users/AlbandeCrevoisier/followers","following_url":"https://api.github.com/users/AlbandeCrevoisier/following{/other_user}","gists_url":"https://api.github.com/users/AlbandeCrevoisier/gists{/gist_id}","starred_url":"https://api.github.com/users/AlbandeCrevoisier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlbandeCrevoisier/subscriptions","organizations_url":"https://api.github.com/users/AlbandeCrevoisier/orgs","repos_url":"https://api.github.com/users/AlbandeCrevoisier/repos","events_url":"https://api.github.com/users/AlbandeCrevoisier/events{/privacy}","received_events_url":"https://api.github.com/users/AlbandeCrevoisier/received_events","type":"User","site_admin":false},"body":"Changes proposed in this pull request:\r\n\r\n* Adding a regressor version of Adaptive random forest.\r\n* Renaming AdaptiveRandomForest in AdaptiveRandomForestClassifier for consistency.\r\n\r\n---\r\n\r\nChecklist\r\n\r\n- [x] Code complies with PEP-8 and is consistent with the framework.\r\n- [x] Code is properly documented.\r\n- [ ] Tests are included for new functionality or updated accordingly.\r\n- [ ] Travis CI build passes with no errors.\r\n- [ ] Test Coverage is maintained (threshold is -0.2%).\r\n- [x] Files changed (update, add, delete) are in the PR's scope (no extra files are included).\r\n\r\n[Issue 131](https://github.com/scikit-multiflow/scikit-multiflow/issues/131)\r\n\r\nI panicked & got stuck with the split file model, so eventually I backtracked to the simpler solution of copying the current ARF & modifying what needs be. I tried to document it as best I could, but might have missed something.\r\n\r\nThe testing is minimal, I don't really know how to write tests. Any suggestion?","created_at":"2019-10-03T11:12:29Z","updated_at":"2019-12-18T15:12:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1021957d7911165b23b4487410e99a2500e6e2b","assignee":{"login":"AlbandeCrevoisier","id":19614225,"node_id":"MDQ6VXNlcjE5NjE0MjI1","avatar_url":"https://avatars2.githubusercontent.com/u/19614225?v=4","gravatar_id":"","url":"https://api.github.com/users/AlbandeCrevoisier","html_url":"https://github.com/AlbandeCrevoisier","followers_url":"https://api.github.com/users/AlbandeCrevoisier/followers","following_url":"https://api.github.com/users/AlbandeCrevoisier/following{/other_user}","gists_url":"https://api.github.com/users/AlbandeCrevoisier/gists{/gist_id}","starred_url":"https://api.github.com/users/AlbandeCrevoisier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlbandeCrevoisier/subscriptions","organizations_url":"https://api.github.com/users/AlbandeCrevoisier/orgs","repos_url":"https://api.github.com/users/AlbandeCrevoisier/repos","events_url":"https://api.github.com/users/AlbandeCrevoisier/events{/privacy}","received_events_url":"https://api.github.com/users/AlbandeCrevoisier/received_events","type":"User","site_admin":false},"assignees":[{"login":"AlbandeCrevoisier","id":19614225,"node_id":"MDQ6VXNlcjE5NjE0MjI1","avatar_url":"https://avatars2.githubusercontent.com/u/19614225?v=4","gravatar_id":"","url":"https://api.github.com/users/AlbandeCrevoisier","html_url":"https://github.com/AlbandeCrevoisier","followers_url":"https://api.github.com/users/AlbandeCrevoisier/followers","following_url":"https://api.github.com/users/AlbandeCrevoisier/following{/other_user}","gists_url":"https://api.github.com/users/AlbandeCrevoisier/gists{/gist_id}","starred_url":"https://api.github.com/users/AlbandeCrevoisier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlbandeCrevoisier/subscriptions","organizations_url":"https://api.github.com/users/AlbandeCrevoisier/orgs","repos_url":"https://api.github.com/users/AlbandeCrevoisier/repos","events_url":"https://api.github.com/users/AlbandeCrevoisier/events{/privacy}","received_events_url":"https://api.github.com/users/AlbandeCrevoisier/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/pulls/145/commits","review_comments_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/pulls/145/comments","review_comment_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/issues/145/comments","statuses_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/statuses/fe7062b44773577889a80291a02bf1bd641e6b45","head":{"label":"AlbandeCrevoisier:arf_regressor","ref":"arf_regressor","sha":"fe7062b44773577889a80291a02bf1bd641e6b45","user":{"login":"AlbandeCrevoisier","id":19614225,"node_id":"MDQ6VXNlcjE5NjE0MjI1","avatar_url":"https://avatars2.githubusercontent.com/u/19614225?v=4","gravatar_id":"","url":"https://api.github.com/users/AlbandeCrevoisier","html_url":"https://github.com/AlbandeCrevoisier","followers_url":"https://api.github.com/users/AlbandeCrevoisier/followers","following_url":"https://api.github.com/users/AlbandeCrevoisier/following{/other_user}","gists_url":"https://api.github.com/users/AlbandeCrevoisier/gists{/gist_id}","starred_url":"https://api.github.com/users/AlbandeCrevoisier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlbandeCrevoisier/subscriptions","organizations_url":"https://api.github.com/users/AlbandeCrevoisier/orgs","repos_url":"https://api.github.com/users/AlbandeCrevoisier/repos","events_url":"https://api.github.com/users/AlbandeCrevoisier/events{/privacy}","received_events_url":"https://api.github.com/users/AlbandeCrevoisier/received_events","type":"User","site_admin":false},"repo":{"id":212405233,"node_id":"MDEwOlJlcG9zaXRvcnkyMTI0MDUyMzM=","name":"scikit-multiflow","full_name":"AlbandeCrevoisier/scikit-multiflow","private":false,"owner":{"login":"AlbandeCrevoisier","id":19614225,"node_id":"MDQ6VXNlcjE5NjE0MjI1","avatar_url":"https://avatars2.githubusercontent.com/u/19614225?v=4","gravatar_id":"","url":"https://api.github.com/users/AlbandeCrevoisier","html_url":"https://github.com/AlbandeCrevoisier","followers_url":"https://api.github.com/users/AlbandeCrevoisier/followers","following_url":"https://api.github.com/users/AlbandeCrevoisier/following{/other_user}","gists_url":"https://api.github.com/users/AlbandeCrevoisier/gists{/gist_id}","starred_url":"https://api.github.com/users/AlbandeCrevoisier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlbandeCrevoisier/subscriptions","organizations_url":"https://api.github.com/users/AlbandeCrevoisier/orgs","repos_url":"https://api.github.com/users/AlbandeCrevoisier/repos","events_url":"https://api.github.com/users/AlbandeCrevoisier/events{/privacy}","received_events_url":"https://api.github.com/users/AlbandeCrevoisier/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AlbandeCrevoisier/scikit-multiflow","description":"A machine learning framework for multi-output/multi-label and stream data. Inspired by MOA and MEKA, following scikit-learn's philosophy.","fork":true,"url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow","forks_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/forks","keys_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/teams","hooks_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/hooks","issue_events_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/issues/events{/number}","events_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/events","assignees_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/assignees{/user}","branches_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/branches{/branch}","tags_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/tags","blobs_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/statuses/{sha}","languages_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/languages","stargazers_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/stargazers","contributors_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/contributors","subscribers_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/subscribers","subscription_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/subscription","commits_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/contents/{+path}","compare_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/merges","archive_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/downloads","issues_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/issues{/number}","pulls_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/pulls{/number}","milestones_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/milestones{/number}","notifications_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/labels{/name}","releases_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/releases{/id}","deployments_url":"https://api.github.com/repos/AlbandeCrevoisier/scikit-multiflow/deployments","created_at":"2019-10-02T17:49:43Z","updated_at":"2019-12-17T16:20:51Z","pushed_at":"2019-12-18T10:57:52Z","git_url":"git://github.com/AlbandeCrevoisier/scikit-multiflow.git","ssh_url":"[email protected]:AlbandeCrevoisier/scikit-multiflow.git","clone_url":"https://github.com/AlbandeCrevoisier/scikit-multiflow.git","svn_url":"https://github.com/AlbandeCrevoisier/scikit-multiflow","homepage":"https://scikit-multiflow.github.io/","size":60809,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-multiflow:master","ref":"master","sha":"f33717b0807747651a2292f0645c7b78efe55dbc","user":{"login":"scikit-multiflow","id":33665217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/33665217?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-multiflow","html_url":"https://github.com/scikit-multiflow","followers_url":"https://api.github.com/users/scikit-multiflow/followers","following_url":"https://api.github.com/users/scikit-multiflow/following{/other_user}","gists_url":"https://api.github.com/users/scikit-multiflow/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-multiflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-multiflow/subscriptions","organizations_url":"https://api.github.com/users/scikit-multiflow/orgs","repos_url":"https://api.github.com/users/scikit-multiflow/repos","events_url":"https://api.github.com/users/scikit-multiflow/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-multiflow/received_events","type":"Organization","site_admin":false},"repo":{"id":110717885,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA3MTc4ODU=","name":"scikit-multiflow","full_name":"scikit-multiflow/scikit-multiflow","private":false,"owner":{"login":"scikit-multiflow","id":33665217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNjY1MjE3","avatar_url":"https://avatars0.githubusercontent.com/u/33665217?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-multiflow","html_url":"https://github.com/scikit-multiflow","followers_url":"https://api.github.com/users/scikit-multiflow/followers","following_url":"https://api.github.com/users/scikit-multiflow/following{/other_user}","gists_url":"https://api.github.com/users/scikit-multiflow/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-multiflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-multiflow/subscriptions","organizations_url":"https://api.github.com/users/scikit-multiflow/orgs","repos_url":"https://api.github.com/users/scikit-multiflow/repos","events_url":"https://api.github.com/users/scikit-multiflow/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-multiflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scikit-multiflow/scikit-multiflow","description":"A machine learning framework for multi-output/multi-label and stream data. Inspired by MOA and MEKA, following scikit-learn's philosophy.","fork":false,"url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow","forks_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/forks","keys_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/teams","hooks_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/hooks","issue_events_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/events","assignees_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/tags","blobs_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/languages","stargazers_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/stargazers","contributors_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/contributors","subscribers_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/subscribers","subscription_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/subscription","commits_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/merges","archive_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/downloads","issues_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/labels{/name}","releases_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/deployments","created_at":"2017-11-14T16:46:58Z","updated_at":"2019-12-18T03:26:40Z","pushed_at":"2019-12-18T10:57:54Z","git_url":"git://github.com/scikit-multiflow/scikit-multiflow.git","ssh_url":"[email protected]:scikit-multiflow/scikit-multiflow.git","clone_url":"https://github.com/scikit-multiflow/scikit-multiflow.git","svn_url":"https://github.com/scikit-multiflow/scikit-multiflow","homepage":"https://scikit-multiflow.github.io/","size":60762,"stargazers_count":224,"watchers_count":224,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":79,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":28,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":79,"open_issues":28,"watchers":224,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/pulls/145"},"html":{"href":"https://github.com/scikit-multiflow/scikit-multiflow/pull/145"},"issue":{"href":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/issues/145"},"comments":{"href":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-multiflow/scikit-multiflow/statuses/fe7062b44773577889a80291a02bf1bd641e6b45"}},"author_association":"COLLABORATOR"}}	{ "id": 110717885, "name": "scikit-multiflow/scikit-multiflow", "url": "https://api.github.com/repos/scikit-multiflow/scikit-multiflow" }	{ "id": 19614225, "login": "AlbandeCrevoisier", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/19614225?", "url": "https://api.github.com/users/AlbandeCrevoisier" }	{ "id": 33665217, "login": "scikit-multiflow", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/33665217?", "url": "https://api.github.com/orgs/scikit-multiflow" }	2019-12-18T15:12:44	11117602012	{"actor":{"display_login":"AlbandeCrevoisier"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/Guestlogix/traveler-ios/pulls/comments/292937408","pull_request_review_id":248783576,"id":292937408,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MjkzNzQwOA==","diff_hunk":"@@ -0,0 +1,76 @@\n+//\n+// ProductDetailViewController.swift\n+// TravelerKitUI\n+//\n+// Created by Omar Padierna on 2019-05-30.\n+// Copyright © 2019 GuestLogix. All rights reserved.\n+//\n+\n+import UIKit\n+import TravelerKit\n+\n+class ProductDetailViewController: UIViewController {\n+ public var product:Product?\n+\n+ private var productDetails:CatalogItemDetails?\n+\n+","path":"traveler-ios-ui/TravelerKitUI/ViewControllers/ProductDetailViewController.swift","position":17,"original_position":17,"commit_id":"443d5878b954b5504186d029302c1bc4fcddef9a","original_commit_id":"443d5878b954b5504186d029302c1bc4fcddef9a","user":{"login":"ata-n","id":926711,"node_id":"MDQ6VXNlcjkyNjcxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/926711?v=4","gravatar_id":"","url":"https://api.github.com/users/ata-n","html_url":"https://github.com/ata-n","followers_url":"https://api.github.com/users/ata-n/followers","following_url":"https://api.github.com/users/ata-n/following{/other_user}","gists_url":"https://api.github.com/users/ata-n/gists{/gist_id}","starred_url":"https://api.github.com/users/ata-n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ata-n/subscriptions","organizations_url":"https://api.github.com/users/ata-n/orgs","repos_url":"https://api.github.com/users/ata-n/repos","events_url":"https://api.github.com/users/ata-n/events{/privacy}","received_events_url":"https://api.github.com/users/ata-n/received_events","type":"User","site_admin":false},"body":"extra new line :)","created_at":"2019-06-12T14:14:17Z","updated_at":"2019-06-12T14:17:03Z","html_url":"https://github.com/Guestlogix/traveler-ios/pull/247#discussion_r292937408","pull_request_url":"https://api.github.com/repos/Guestlogix/traveler-ios/pulls/247","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Guestlogix/traveler-ios/pulls/comments/292937408"},"html":{"href":"https://github.com/Guestlogix/traveler-ios/pull/247#discussion_r292937408"},"pull_request":{"href":"https://api.github.com/repos/Guestlogix/traveler-ios/pulls/247"}}},"pull_request":{"url":"https://api.github.com/repos/Guestlogix/traveler-ios/pulls/247","id":284667823,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0NjY3ODIz","html_url":"https://github.com/Guestlogix/traveler-ios/pull/247","diff_url":"https://github.com/Guestlogix/traveler-ios/pull/247.diff","patch_url":"https://github.com/Guestlogix/traveler-ios/pull/247.patch","issue_url":"https://api.github.com/repos/Guestlogix/traveler-ios/issues/247","number":247,"state":"open","locked":false,"title":"Adds product detail functionality.","user":{"login":"OmarPadierna","id":15262041,"node_id":"MDQ6VXNlcjE1MjYyMDQx","avatar_url":"https://avatars1.githubusercontent.com/u/15262041?v=4","gravatar_id":"","url":"https://api.github.com/users/OmarPadierna","html_url":"https://github.com/OmarPadierna","followers_url":"https://api.github.com/users/OmarPadierna/followers","following_url":"https://api.github.com/users/OmarPadierna/following{/other_user}","gists_url":"https://api.github.com/users/OmarPadierna/gists{/gist_id}","starred_url":"https://api.github.com/users/OmarPadierna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OmarPadierna/subscriptions","organizations_url":"https://api.github.com/users/OmarPadierna/orgs","repos_url":"https://api.github.com/users/OmarPadierna/repos","events_url":"https://api.github.com/users/OmarPadierna/events{/privacy}","received_events_url":"https://api.github.com/users/OmarPadierna/received_events","type":"User","site_admin":false},"body":"Description\r\n\r\n\r\nIssues that should be CLOSED by merge of this PR:\r\n* Fixes #\r\n\r\nRelated issues that should be LINKED to this PR:\r\n* Connects #","created_at":"2019-06-03T17:55:51Z","updated_at":"2019-06-12T14:17:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f38ecb15346d16ac7889eeea5dafaed2a822133","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Guestlogix/traveler-ios/pulls/247/commits","review_comments_url":"https://api.github.com/repos/Guestlogix/traveler-ios/pulls/247/comments","review_comment_url":"https://api.github.com/repos/Guestlogix/traveler-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Guestlogix/traveler-ios/issues/247/comments","statuses_url":"https://api.github.com/repos/Guestlogix/traveler-ios/statuses/443d5878b954b5504186d029302c1bc4fcddef9a","head":{"label":"Guestlogix:feature/ProductDetail","ref":"feature/ProductDetail","sha":"443d5878b954b5504186d029302c1bc4fcddef9a","user":{"login":"Guestlogix","id":33725929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzI1OTI5","avatar_url":"https://avatars3.githubusercontent.com/u/33725929?v=4","gravatar_id":"","url":"https://api.github.com/users/Guestlogix","html_url":"https://github.com/Guestlogix","followers_url":"https://api.github.com/users/Guestlogix/followers","following_url":"https://api.github.com/users/Guestlogix/following{/other_user}","gists_url":"https://api.github.com/users/Guestlogix/gists{/gist_id}","starred_url":"https://api.github.com/users/Guestlogix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guestlogix/subscriptions","organizations_url":"https://api.github.com/users/Guestlogix/orgs","repos_url":"https://api.github.com/users/Guestlogix/repos","events_url":"https://api.github.com/users/Guestlogix/events{/privacy}","received_events_url":"https://api.github.com/users/Guestlogix/received_events","type":"Organization","site_admin":false},"repo":{"id":151112519,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExMTI1MTk=","name":"traveler-ios","full_name":"Guestlogix/traveler-ios","private":false,"owner":{"login":"Guestlogix","id":33725929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzI1OTI5","avatar_url":"https://avatars3.githubusercontent.com/u/33725929?v=4","gravatar_id":"","url":"https://api.github.com/users/Guestlogix","html_url":"https://github.com/Guestlogix","followers_url":"https://api.github.com/users/Guestlogix/followers","following_url":"https://api.github.com/users/Guestlogix/following{/other_user}","gists_url":"https://api.github.com/users/Guestlogix/gists{/gist_id}","starred_url":"https://api.github.com/users/Guestlogix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guestlogix/subscriptions","organizations_url":"https://api.github.com/users/Guestlogix/orgs","repos_url":"https://api.github.com/users/Guestlogix/repos","events_url":"https://api.github.com/users/Guestlogix/events{/privacy}","received_events_url":"https://api.github.com/users/Guestlogix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Guestlogix/traveler-ios","description":null,"fork":false,"url":"https://api.github.com/repos/Guestlogix/traveler-ios","forks_url":"https://api.github.com/repos/Guestlogix/traveler-ios/forks","keys_url":"https://api.github.com/repos/Guestlogix/traveler-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Guestlogix/traveler-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Guestlogix/traveler-ios/teams","hooks_url":"https://api.github.com/repos/Guestlogix/traveler-ios/hooks","issue_events_url":"https://api.github.com/repos/Guestlogix/traveler-ios/issues/events{/number}","events_url":"https://api.github.com/repos/Guestlogix/traveler-ios/events","assignees_url":"https://api.github.com/repos/Guestlogix/traveler-ios/assignees{/user}","branches_url":"https://api.github.com/repos/Guestlogix/traveler-ios/branches{/branch}","tags_url":"https://api.github.com/repos/Guestlogix/traveler-ios/tags","blobs_url":"https://api.github.com/repos/Guestlogix/traveler-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Guestlogix/traveler-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Guestlogix/traveler-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/Guestlogix/traveler-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Guestlogix/traveler-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/Guestlogix/traveler-ios/languages","stargazers_url":"https://api.github.com/repos/Guestlogix/traveler-ios/stargazers","contributors_url":"https://api.github.com/repos/Guestlogix/traveler-ios/contributors","subscribers_url":"https://api.github.com/repos/Guestlogix/traveler-ios/subscribers","subscription_url":"https://api.github.com/repos/Guestlogix/traveler-ios/subscription","commits_url":"https://api.github.com/repos/Guestlogix/traveler-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/Guestlogix/traveler-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/Guestlogix/traveler-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/Guestlogix/traveler-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/Guestlogix/traveler-ios/contents/{+path}","compare_url":"https://api.github.com/repos/Guestlogix/traveler-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Guestlogix/traveler-ios/merges","archive_url":"https://api.github.com/repos/Guestlogix/traveler-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Guestlogix/traveler-ios/downloads","issues_url":"https://api.github.com/repos/Guestlogix/traveler-ios/issues{/number}","pulls_url":"https://api.github.com/repos/Guestlogix/traveler-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/Guestlogix/traveler-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/Guestlogix/traveler-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Guestlogix/traveler-ios/labels{/name}","releases_url":"https://api.github.com/repos/Guestlogix/traveler-ios/releases{/id}","deployments_url":"https://api.github.com/repos/Guestlogix/traveler-ios/deployments","created_at":"2018-10-01T15:34:20Z","updated_at":"2019-06-11T18:33:02Z","pushed_at":"2019-06-12T13:51:45Z","git_url":"git://github.com/Guestlogix/traveler-ios.git","ssh_url":"[email protected]:Guestlogix/traveler-ios.git","clone_url":"https://github.com/Guestlogix/traveler-ios.git","svn_url":"https://github.com/Guestlogix/traveler-ios","homepage":null,"size":6730,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":27,"license":null,"forks":0,"open_issues":27,"watchers":1,"default_branch":"master"}},"base":{"label":"Guestlogix:master","ref":"master","sha":"0f8eeb4b57ac31d961a6d1c9c29e3464bdc3d8b6","user":{"login":"Guestlogix","id":33725929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzI1OTI5","avatar_url":"https://avatars3.githubusercontent.com/u/33725929?v=4","gravatar_id":"","url":"https://api.github.com/users/Guestlogix","html_url":"https://github.com/Guestlogix","followers_url":"https://api.github.com/users/Guestlogix/followers","following_url":"https://api.github.com/users/Guestlogix/following{/other_user}","gists_url":"https://api.github.com/users/Guestlogix/gists{/gist_id}","starred_url":"https://api.github.com/users/Guestlogix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guestlogix/subscriptions","organizations_url":"https://api.github.com/users/Guestlogix/orgs","repos_url":"https://api.github.com/users/Guestlogix/repos","events_url":"https://api.github.com/users/Guestlogix/events{/privacy}","received_events_url":"https://api.github.com/users/Guestlogix/received_events","type":"Organization","site_admin":false},"repo":{"id":151112519,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExMTI1MTk=","name":"traveler-ios","full_name":"Guestlogix/traveler-ios","private":false,"owner":{"login":"Guestlogix","id":33725929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzI1OTI5","avatar_url":"https://avatars3.githubusercontent.com/u/33725929?v=4","gravatar_id":"","url":"https://api.github.com/users/Guestlogix","html_url":"https://github.com/Guestlogix","followers_url":"https://api.github.com/users/Guestlogix/followers","following_url":"https://api.github.com/users/Guestlogix/following{/other_user}","gists_url":"https://api.github.com/users/Guestlogix/gists{/gist_id}","starred_url":"https://api.github.com/users/Guestlogix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Guestlogix/subscriptions","organizations_url":"https://api.github.com/users/Guestlogix/orgs","repos_url":"https://api.github.com/users/Guestlogix/repos","events_url":"https://api.github.com/users/Guestlogix/events{/privacy}","received_events_url":"https://api.github.com/users/Guestlogix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Guestlogix/traveler-ios","description":null,"fork":false,"url":"https://api.github.com/repos/Guestlogix/traveler-ios","forks_url":"https://api.github.com/repos/Guestlogix/traveler-ios/forks","keys_url":"https://api.github.com/repos/Guestlogix/traveler-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Guestlogix/traveler-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Guestlogix/traveler-ios/teams","hooks_url":"https://api.github.com/repos/Guestlogix/traveler-ios/hooks","issue_events_url":"https://api.github.com/repos/Guestlogix/traveler-ios/issues/events{/number}","events_url":"https://api.github.com/repos/Guestlogix/traveler-ios/events","assignees_url":"https://api.github.com/repos/Guestlogix/traveler-ios/assignees{/user}","branches_url":"https://api.github.com/repos/Guestlogix/traveler-ios/branches{/branch}","tags_url":"https://api.github.com/repos/Guestlogix/traveler-ios/tags","blobs_url":"https://api.github.com/repos/Guestlogix/traveler-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Guestlogix/traveler-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Guestlogix/traveler-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/Guestlogix/traveler-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Guestlogix/traveler-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/Guestlogix/traveler-ios/languages","stargazers_url":"https://api.github.com/repos/Guestlogix/traveler-ios/stargazers","contributors_url":"https://api.github.com/repos/Guestlogix/traveler-ios/contributors","subscribers_url":"https://api.github.com/repos/Guestlogix/traveler-ios/subscribers","subscription_url":"https://api.github.com/repos/Guestlogix/traveler-ios/subscription","commits_url":"https://api.github.com/repos/Guestlogix/traveler-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/Guestlogix/traveler-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/Guestlogix/traveler-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/Guestlogix/traveler-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/Guestlogix/traveler-ios/contents/{+path}","compare_url":"https://api.github.com/repos/Guestlogix/traveler-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Guestlogix/traveler-ios/merges","archive_url":"https://api.github.com/repos/Guestlogix/traveler-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Guestlogix/traveler-ios/downloads","issues_url":"https://api.github.com/repos/Guestlogix/traveler-ios/issues{/number}","pulls_url":"https://api.github.com/repos/Guestlogix/traveler-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/Guestlogix/traveler-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/Guestlogix/traveler-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Guestlogix/traveler-ios/labels{/name}","releases_url":"https://api.github.com/repos/Guestlogix/traveler-ios/releases{/id}","deployments_url":"https://api.github.com/repos/Guestlogix/traveler-ios/deployments","created_at":"2018-10-01T15:34:20Z","updated_at":"2019-06-11T18:33:02Z","pushed_at":"2019-06-12T13:51:45Z","git_url":"git://github.com/Guestlogix/traveler-ios.git","ssh_url":"[email protected]:Guestlogix/traveler-ios.git","clone_url":"https://github.com/Guestlogix/traveler-ios.git","svn_url":"https://github.com/Guestlogix/traveler-ios","homepage":null,"size":6730,"stargazers_count":1,"watchers_count":1,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":27,"license":null,"forks":0,"open_issues":27,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Guestlogix/traveler-ios/pulls/247"},"html":{"href":"https://github.com/Guestlogix/traveler-ios/pull/247"},"issue":{"href":"https://api.github.com/repos/Guestlogix/traveler-ios/issues/247"},"comments":{"href":"https://api.github.com/repos/Guestlogix/traveler-ios/issues/247/comments"},"review_comments":{"href":"https://api.github.com/repos/Guestlogix/traveler-ios/pulls/247/comments"},"review_comment":{"href":"https://api.github.com/repos/Guestlogix/traveler-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Guestlogix/traveler-ios/pulls/247/commits"},"statuses":{"href":"https://api.github.com/repos/Guestlogix/traveler-ios/statuses/443d5878b954b5504186d029302c1bc4fcddef9a"}},"author_association":"CONTRIBUTOR"}}	{ "id": 151112519, "name": "Guestlogix/traveler-ios", "url": "https://api.github.com/repos/Guestlogix/traveler-ios" }	{ "id": 926711, "login": "ata-n", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/926711?", "url": "https://api.github.com/users/ata-n" }	{ "id": 33725929, "login": "Guestlogix", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/33725929?", "url": "https://api.github.com/orgs/Guestlogix" }	2019-06-12T14:14:17	9807731200	{"actor":{"display_login":"ata-n"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/pulls/comments/259005711","pull_request_review_id":206398900,"id":259005711,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1OTAwNTcxMQ==","diff_hunk":"@@ -50,6 +48,8 @@ class PaymentService\n {\n use Translator;\n \n+ const CARD_METHODS = [];","path":"src/Services/PaymentService.php","position":13,"original_position":13,"commit_id":"4576e7b2d2fbd67ec0574180a2dc26bd866dda82","original_commit_id":"4576e7b2d2fbd67ec0574180a2dc26bd866dda82","user":{"login":"sixer1182","id":15432768,"node_id":"MDQ6VXNlcjE1NDMyNzY4","avatar_url":"https://avatars1.githubusercontent.com/u/15432768?v=4","gravatar_id":"","url":"https://api.github.com/users/sixer1182","html_url":"https://github.com/sixer1182","followers_url":"https://api.github.com/users/sixer1182/followers","following_url":"https://api.github.com/users/sixer1182/following{/other_user}","gists_url":"https://api.github.com/users/sixer1182/gists{/gist_id}","starred_url":"https://api.github.com/users/sixer1182/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sixer1182/subscriptions","organizations_url":"https://api.github.com/users/sixer1182/orgs","repos_url":"https://api.github.com/users/sixer1182/repos","events_url":"https://api.github.com/users/sixer1182/events{/privacy}","received_events_url":"https://api.github.com/users/sixer1182/received_events","type":"User","site_admin":false},"body":"Ist wahrscheinlich temporär, richtig?","created_at":"2019-02-21T16:23:48Z","updated_at":"2019-02-21T16:24:49Z","html_url":"https://github.com/heidelpay/plentymarkets-mgw-gateway/pull/4#discussion_r259005711","pull_request_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/pulls/4","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/pulls/comments/259005711"},"html":{"href":"https://github.com/heidelpay/plentymarkets-mgw-gateway/pull/4#discussion_r259005711"},"pull_request":{"href":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/pulls/4","id":254958937,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0OTU4OTM3","html_url":"https://github.com/heidelpay/plentymarkets-mgw-gateway/pull/4","diff_url":"https://github.com/heidelpay/plentymarkets-mgw-gateway/pull/4.diff","patch_url":"https://github.com/heidelpay/plentymarkets-mgw-gateway/pull/4.patch","issue_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/issues/4","number":4,"state":"open","locked":false,"title":"Plenty 50/create base config menu","user":{"login":"xBlack-Shadow","id":10667564,"node_id":"MDQ6VXNlcjEwNjY3NTY0","avatar_url":"https://avatars1.githubusercontent.com/u/10667564?v=4","gravatar_id":"","url":"https://api.github.com/users/xBlack-Shadow","html_url":"https://github.com/xBlack-Shadow","followers_url":"https://api.github.com/users/xBlack-Shadow/followers","following_url":"https://api.github.com/users/xBlack-Shadow/following{/other_user}","gists_url":"https://api.github.com/users/xBlack-Shadow/gists{/gist_id}","starred_url":"https://api.github.com/users/xBlack-Shadow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xBlack-Shadow/subscriptions","organizations_url":"https://api.github.com/users/xBlack-Shadow/orgs","repos_url":"https://api.github.com/users/xBlack-Shadow/repos","events_url":"https://api.github.com/users/xBlack-Shadow/events{/privacy}","received_events_url":"https://api.github.com/users/xBlack-Shadow/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-21T10:06:36Z","updated_at":"2019-02-21T16:24:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c857a8c7cc1578c39dfa1577f31c34dae792504","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/pulls/4/commits","review_comments_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/pulls/4/comments","review_comment_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/issues/4/comments","statuses_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/statuses/4576e7b2d2fbd67ec0574180a2dc26bd866dda82","head":{"label":"heidelpay:PLENTY-50/create-base-config-menu","ref":"PLENTY-50/create-base-config-menu","sha":"4576e7b2d2fbd67ec0574180a2dc26bd866dda82","user":{"login":"heidelpay","id":33725993,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzI1OTkz","avatar_url":"https://avatars1.githubusercontent.com/u/33725993?v=4","gravatar_id":"","url":"https://api.github.com/users/heidelpay","html_url":"https://github.com/heidelpay","followers_url":"https://api.github.com/users/heidelpay/followers","following_url":"https://api.github.com/users/heidelpay/following{/other_user}","gists_url":"https://api.github.com/users/heidelpay/gists{/gist_id}","starred_url":"https://api.github.com/users/heidelpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heidelpay/subscriptions","organizations_url":"https://api.github.com/users/heidelpay/orgs","repos_url":"https://api.github.com/users/heidelpay/repos","events_url":"https://api.github.com/users/heidelpay/events{/privacy}","received_events_url":"https://api.github.com/users/heidelpay/received_events","type":"Organization","site_admin":false},"repo":{"id":169376787,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkzNzY3ODc=","name":"plentymarkets-mgw-gateway","full_name":"heidelpay/plentymarkets-mgw-gateway","private":false,"owner":{"login":"heidelpay","id":33725993,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzI1OTkz","avatar_url":"https://avatars1.githubusercontent.com/u/33725993?v=4","gravatar_id":"","url":"https://api.github.com/users/heidelpay","html_url":"https://github.com/heidelpay","followers_url":"https://api.github.com/users/heidelpay/followers","following_url":"https://api.github.com/users/heidelpay/following{/other_user}","gists_url":"https://api.github.com/users/heidelpay/gists{/gist_id}","starred_url":"https://api.github.com/users/heidelpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heidelpay/subscriptions","organizations_url":"https://api.github.com/users/heidelpay/orgs","repos_url":"https://api.github.com/users/heidelpay/repos","events_url":"https://api.github.com/users/heidelpay/events{/privacy}","received_events_url":"https://api.github.com/users/heidelpay/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/heidelpay/plentymarkets-mgw-gateway","description":"For any issues or questions please get in touch with us via [email protected]","fork":false,"url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway","forks_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/forks","keys_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/teams","hooks_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/hooks","issue_events_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/issues/events{/number}","events_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/events","assignees_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/assignees{/user}","branches_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/branches{/branch}","tags_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/tags","blobs_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/languages","stargazers_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/stargazers","contributors_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/contributors","subscribers_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/subscribers","subscription_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/subscription","commits_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/contents/{+path}","compare_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/merges","archive_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/downloads","issues_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/issues{/number}","pulls_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/labels{/name}","releases_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/releases{/id}","deployments_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/deployments","created_at":"2019-02-06T08:45:56Z","updated_at":"2019-02-13T08:45:36Z","pushed_at":"2019-02-21T15:02:07Z","git_url":"git://github.com/heidelpay/plentymarkets-mgw-gateway.git","ssh_url":"[email protected]:heidelpay/plentymarkets-mgw-gateway.git","clone_url":"https://github.com/heidelpay/plentymarkets-mgw-gateway.git","svn_url":"https://github.com/heidelpay/plentymarkets-mgw-gateway","homepage":null,"size":1326,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"heidelpay:develop","ref":"develop","sha":"a58fc8b0070ca96d5dc06cdf67bbb91a542a0e19","user":{"login":"heidelpay","id":33725993,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzI1OTkz","avatar_url":"https://avatars1.githubusercontent.com/u/33725993?v=4","gravatar_id":"","url":"https://api.github.com/users/heidelpay","html_url":"https://github.com/heidelpay","followers_url":"https://api.github.com/users/heidelpay/followers","following_url":"https://api.github.com/users/heidelpay/following{/other_user}","gists_url":"https://api.github.com/users/heidelpay/gists{/gist_id}","starred_url":"https://api.github.com/users/heidelpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heidelpay/subscriptions","organizations_url":"https://api.github.com/users/heidelpay/orgs","repos_url":"https://api.github.com/users/heidelpay/repos","events_url":"https://api.github.com/users/heidelpay/events{/privacy}","received_events_url":"https://api.github.com/users/heidelpay/received_events","type":"Organization","site_admin":false},"repo":{"id":169376787,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkzNzY3ODc=","name":"plentymarkets-mgw-gateway","full_name":"heidelpay/plentymarkets-mgw-gateway","private":false,"owner":{"login":"heidelpay","id":33725993,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNzI1OTkz","avatar_url":"https://avatars1.githubusercontent.com/u/33725993?v=4","gravatar_id":"","url":"https://api.github.com/users/heidelpay","html_url":"https://github.com/heidelpay","followers_url":"https://api.github.com/users/heidelpay/followers","following_url":"https://api.github.com/users/heidelpay/following{/other_user}","gists_url":"https://api.github.com/users/heidelpay/gists{/gist_id}","starred_url":"https://api.github.com/users/heidelpay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heidelpay/subscriptions","organizations_url":"https://api.github.com/users/heidelpay/orgs","repos_url":"https://api.github.com/users/heidelpay/repos","events_url":"https://api.github.com/users/heidelpay/events{/privacy}","received_events_url":"https://api.github.com/users/heidelpay/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/heidelpay/plentymarkets-mgw-gateway","description":"For any issues or questions please get in touch with us via [email protected]","fork":false,"url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway","forks_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/forks","keys_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/teams","hooks_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/hooks","issue_events_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/issues/events{/number}","events_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/events","assignees_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/assignees{/user}","branches_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/branches{/branch}","tags_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/tags","blobs_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/languages","stargazers_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/stargazers","contributors_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/contributors","subscribers_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/subscribers","subscription_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/subscription","commits_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/contents/{+path}","compare_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/merges","archive_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/downloads","issues_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/issues{/number}","pulls_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/labels{/name}","releases_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/releases{/id}","deployments_url":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/deployments","created_at":"2019-02-06T08:45:56Z","updated_at":"2019-02-13T08:45:36Z","pushed_at":"2019-02-21T15:02:07Z","git_url":"git://github.com/heidelpay/plentymarkets-mgw-gateway.git","ssh_url":"[email protected]:heidelpay/plentymarkets-mgw-gateway.git","clone_url":"https://github.com/heidelpay/plentymarkets-mgw-gateway.git","svn_url":"https://github.com/heidelpay/plentymarkets-mgw-gateway","homepage":null,"size":1326,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/pulls/4"},"html":{"href":"https://github.com/heidelpay/plentymarkets-mgw-gateway/pull/4"},"issue":{"href":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/issues/4"},"comments":{"href":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway/statuses/4576e7b2d2fbd67ec0574180a2dc26bd866dda82"}},"author_association":"MEMBER"}}	{ "id": 169376787, "name": "heidelpay/plentymarkets-mgw-gateway", "url": "https://api.github.com/repos/heidelpay/plentymarkets-mgw-gateway" }	{ "id": 15432768, "login": "sixer1182", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/15432768?", "url": "https://api.github.com/users/sixer1182" }	{ "id": 33725993, "login": "heidelpay", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/33725993?", "url": "https://api.github.com/orgs/heidelpay" }	2019-02-21T16:23:48	9111644051	{"actor":{"display_login":"sixer1182"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/nimiq/keyguard-next/pulls/comments/281124873","pull_request_review_id":233897147,"id":281124873,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MTEyNDg3Mw==","diff_hunk":"@@ -153,10 +153,8 @@ <h1 data-i18n=\"remove-key-heading\" class=\"nq-h1\">Don't lose access</h1>\n <svg class=\"nq-icon\"><use xlink:href=\"../../../node_modules/@nimiq/style/nimiq-style.icons.svg#nq-arrow-left\"/></svg>\n </a>\n <h1 data-i18n=\"export-words-intro-heading\" class=\"nq-h1\">There is no password recovery!</h1>\n- <p class=\"nq-notice warning\" data-i18n=\"recovery-words-intro-text\">\n- The Recovery Words are the ONLY way to\n- restore your account in case you lose your\n- Login File or password.\n+ <p class=\"nq-notice warning\" data-i18n=\"remove-key-intro-text\">\n+ If you log out without saving your Account, you will irreversible lose access to it!","path":"src/request/remove-key/index.html","position":9,"original_position":9,"commit_id":"02f486493e30badc9fba306e3657e749ddedfac4","original_commit_id":"02f486493e30badc9fba306e3657e749ddedfac4","user":{"login":"sisou","id":1828163,"node_id":"MDQ6VXNlcjE4MjgxNjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1828163?v=4","gravatar_id":"","url":"https://api.github.com/users/sisou","html_url":"https://github.com/sisou","followers_url":"https://api.github.com/users/sisou/followers","following_url":"https://api.github.com/users/sisou/following{/other_user}","gists_url":"https://api.github.com/users/sisou/gists{/gist_id}","starred_url":"https://api.github.com/users/sisou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sisou/subscriptions","organizations_url":"https://api.github.com/users/sisou/orgs","repos_url":"https://api.github.com/users/sisou/repos","events_url":"https://api.github.com/users/sisou/events{/privacy}","received_events_url":"https://api.github.com/users/sisou/received_events","type":"User","site_admin":false},"body":"Grammar\r\n```suggestion\r\n If you log out without saving your Account, you will irreversibly lose access to it!\r\n```","created_at":"2019-05-06T09:58:08Z","updated_at":"2019-05-06T09:58:40Z","html_url":"https://github.com/nimiq/keyguard-next/pull/287#discussion_r281124873","pull_request_url":"https://api.github.com/repos/nimiq/keyguard-next/pulls/287","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/nimiq/keyguard-next/pulls/comments/281124873"},"html":{"href":"https://github.com/nimiq/keyguard-next/pull/287#discussion_r281124873"},"pull_request":{"href":"https://api.github.com/repos/nimiq/keyguard-next/pulls/287"}}},"pull_request":{"url":"https://api.github.com/repos/nimiq/keyguard-next/pulls/287","id":276116073,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc2MTE2MDcz","html_url":"https://github.com/nimiq/keyguard-next/pull/287","diff_url":"https://github.com/nimiq/keyguard-next/pull/287.diff","patch_url":"https://github.com/nimiq/keyguard-next/pull/287.patch","issue_url":"https://api.github.com/repos/nimiq/keyguard-next/issues/287","number":287,"state":"open","locked":false,"title":"Wording update","user":{"login":"nibhar","id":43245427,"node_id":"MDQ6VXNlcjQzMjQ1NDI3","avatar_url":"https://avatars3.githubusercontent.com/u/43245427?v=4","gravatar_id":"","url":"https://api.github.com/users/nibhar","html_url":"https://github.com/nibhar","followers_url":"https://api.github.com/users/nibhar/followers","following_url":"https://api.github.com/users/nibhar/following{/other_user}","gists_url":"https://api.github.com/users/nibhar/gists{/gist_id}","starred_url":"https://api.github.com/users/nibhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nibhar/subscriptions","organizations_url":"https://api.github.com/users/nibhar/orgs","repos_url":"https://api.github.com/users/nibhar/repos","events_url":"https://api.github.com/users/nibhar/events{/privacy}","received_events_url":"https://api.github.com/users/nibhar/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-05-06T09:16:53Z","updated_at":"2019-05-06T09:58:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"967d30d244a6e66b453e591032ef6fd1fbe3a83b","assignee":{"login":"nibhar","id":43245427,"node_id":"MDQ6VXNlcjQzMjQ1NDI3","avatar_url":"https://avatars3.githubusercontent.com/u/43245427?v=4","gravatar_id":"","url":"https://api.github.com/users/nibhar","html_url":"https://github.com/nibhar","followers_url":"https://api.github.com/users/nibhar/followers","following_url":"https://api.github.com/users/nibhar/following{/other_user}","gists_url":"https://api.github.com/users/nibhar/gists{/gist_id}","starred_url":"https://api.github.com/users/nibhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nibhar/subscriptions","organizations_url":"https://api.github.com/users/nibhar/orgs","repos_url":"https://api.github.com/users/nibhar/repos","events_url":"https://api.github.com/users/nibhar/events{/privacy}","received_events_url":"https://api.github.com/users/nibhar/received_events","type":"User","site_admin":false},"assignees":[{"login":"nibhar","id":43245427,"node_id":"MDQ6VXNlcjQzMjQ1NDI3","avatar_url":"https://avatars3.githubusercontent.com/u/43245427?v=4","gravatar_id":"","url":"https://api.github.com/users/nibhar","html_url":"https://github.com/nibhar","followers_url":"https://api.github.com/users/nibhar/followers","following_url":"https://api.github.com/users/nibhar/following{/other_user}","gists_url":"https://api.github.com/users/nibhar/gists{/gist_id}","starred_url":"https://api.github.com/users/nibhar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nibhar/subscriptions","organizations_url":"https://api.github.com/users/nibhar/orgs","repos_url":"https://api.github.com/users/nibhar/repos","events_url":"https://api.github.com/users/nibhar/events{/privacy}","received_events_url":"https://api.github.com/users/nibhar/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Bettelstab","id":3285528,"node_id":"MDQ6VXNlcjMyODU1Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/3285528?v=4","gravatar_id":"","url":"https://api.github.com/users/Bettelstab","html_url":"https://github.com/Bettelstab","followers_url":"https://api.github.com/users/Bettelstab/followers","following_url":"https://api.github.com/users/Bettelstab/following{/other_user}","gists_url":"https://api.github.com/users/Bettelstab/gists{/gist_id}","starred_url":"https://api.github.com/users/Bettelstab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bettelstab/subscriptions","organizations_url":"https://api.github.com/users/Bettelstab/orgs","repos_url":"https://api.github.com/users/Bettelstab/repos","events_url":"https://api.github.com/users/Bettelstab/events{/privacy}","received_events_url":"https://api.github.com/users/Bettelstab/received_events","type":"User","site_admin":false},{"login":"danimoh","id":6204514,"node_id":"MDQ6VXNlcjYyMDQ1MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6204514?v=4","gravatar_id":"","url":"https://api.github.com/users/danimoh","html_url":"https://github.com/danimoh","followers_url":"https://api.github.com/users/danimoh/followers","following_url":"https://api.github.com/users/danimoh/following{/other_user}","gists_url":"https://api.github.com/users/danimoh/gists{/gist_id}","starred_url":"https://api.github.com/users/danimoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danimoh/subscriptions","organizations_url":"https://api.github.com/users/danimoh/orgs","repos_url":"https://api.github.com/users/danimoh/repos","events_url":"https://api.github.com/users/danimoh/events{/privacy}","received_events_url":"https://api.github.com/users/danimoh/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nimiq/keyguard-next/pulls/287/commits","review_comments_url":"https://api.github.com/repos/nimiq/keyguard-next/pulls/287/comments","review_comment_url":"https://api.github.com/repos/nimiq/keyguard-next/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nimiq/keyguard-next/issues/287/comments","statuses_url":"https://api.github.com/repos/nimiq/keyguard-next/statuses/02f486493e30badc9fba306e3657e749ddedfac4","head":{"label":"nimiq:sebastian/wording-update","ref":"sebastian/wording-update","sha":"02f486493e30badc9fba306e3657e749ddedfac4","user":{"login":"nimiq","id":33815469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODE1NDY5","avatar_url":"https://avatars1.githubusercontent.com/u/33815469?v=4","gravatar_id":"","url":"https://api.github.com/users/nimiq","html_url":"https://github.com/nimiq","followers_url":"https://api.github.com/users/nimiq/followers","following_url":"https://api.github.com/users/nimiq/following{/other_user}","gists_url":"https://api.github.com/users/nimiq/gists{/gist_id}","starred_url":"https://api.github.com/users/nimiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimiq/subscriptions","organizations_url":"https://api.github.com/users/nimiq/orgs","repos_url":"https://api.github.com/users/nimiq/repos","events_url":"https://api.github.com/users/nimiq/events{/privacy}","received_events_url":"https://api.github.com/users/nimiq/received_events","type":"Organization","site_admin":false},"repo":{"id":139560932,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk1NjA5MzI=","name":"keyguard-next","full_name":"nimiq/keyguard-next","private":false,"owner":{"login":"nimiq","id":33815469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODE1NDY5","avatar_url":"https://avatars1.githubusercontent.com/u/33815469?v=4","gravatar_id":"","url":"https://api.github.com/users/nimiq","html_url":"https://github.com/nimiq","followers_url":"https://api.github.com/users/nimiq/followers","following_url":"https://api.github.com/users/nimiq/following{/other_user}","gists_url":"https://api.github.com/users/nimiq/gists{/gist_id}","starred_url":"https://api.github.com/users/nimiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimiq/subscriptions","organizations_url":"https://api.github.com/users/nimiq/orgs","repos_url":"https://api.github.com/users/nimiq/repos","events_url":"https://api.github.com/users/nimiq/events{/privacy}","received_events_url":"https://api.github.com/users/nimiq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nimiq/keyguard-next","description":null,"fork":false,"url":"https://api.github.com/repos/nimiq/keyguard-next","forks_url":"https://api.github.com/repos/nimiq/keyguard-next/forks","keys_url":"https://api.github.com/repos/nimiq/keyguard-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nimiq/keyguard-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nimiq/keyguard-next/teams","hooks_url":"https://api.github.com/repos/nimiq/keyguard-next/hooks","issue_events_url":"https://api.github.com/repos/nimiq/keyguard-next/issues/events{/number}","events_url":"https://api.github.com/repos/nimiq/keyguard-next/events","assignees_url":"https://api.github.com/repos/nimiq/keyguard-next/assignees{/user}","branches_url":"https://api.github.com/repos/nimiq/keyguard-next/branches{/branch}","tags_url":"https://api.github.com/repos/nimiq/keyguard-next/tags","blobs_url":"https://api.github.com/repos/nimiq/keyguard-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nimiq/keyguard-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nimiq/keyguard-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/nimiq/keyguard-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nimiq/keyguard-next/statuses/{sha}","languages_url":"https://api.github.com/repos/nimiq/keyguard-next/languages","stargazers_url":"https://api.github.com/repos/nimiq/keyguard-next/stargazers","contributors_url":"https://api.github.com/repos/nimiq/keyguard-next/contributors","subscribers_url":"https://api.github.com/repos/nimiq/keyguard-next/subscribers","subscription_url":"https://api.github.com/repos/nimiq/keyguard-next/subscription","commits_url":"https://api.github.com/repos/nimiq/keyguard-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/nimiq/keyguard-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/nimiq/keyguard-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/nimiq/keyguard-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/nimiq/keyguard-next/contents/{+path}","compare_url":"https://api.github.com/repos/nimiq/keyguard-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nimiq/keyguard-next/merges","archive_url":"https://api.github.com/repos/nimiq/keyguard-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nimiq/keyguard-next/downloads","issues_url":"https://api.github.com/repos/nimiq/keyguard-next/issues{/number}","pulls_url":"https://api.github.com/repos/nimiq/keyguard-next/pulls{/number}","milestones_url":"https://api.github.com/repos/nimiq/keyguard-next/milestones{/number}","notifications_url":"https://api.github.com/repos/nimiq/keyguard-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nimiq/keyguard-next/labels{/name}","releases_url":"https://api.github.com/repos/nimiq/keyguard-next/releases{/id}","deployments_url":"https://api.github.com/repos/nimiq/keyguard-next/deployments","created_at":"2018-07-03T09:35:36Z","updated_at":"2019-05-03T06:42:50Z","pushed_at":"2019-05-06T09:53:02Z","git_url":"git://github.com/nimiq/keyguard-next.git","ssh_url":"[email protected]:nimiq/keyguard-next.git","clone_url":"https://github.com/nimiq/keyguard-next.git","svn_url":"https://github.com/nimiq/keyguard-next","homepage":null,"size":3104,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":15,"watchers":4,"default_branch":"master"}},"base":{"label":"nimiq:master","ref":"master","sha":"08144193dec9f893506fb90871408df9b0890a4a","user":{"login":"nimiq","id":33815469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODE1NDY5","avatar_url":"https://avatars1.githubusercontent.com/u/33815469?v=4","gravatar_id":"","url":"https://api.github.com/users/nimiq","html_url":"https://github.com/nimiq","followers_url":"https://api.github.com/users/nimiq/followers","following_url":"https://api.github.com/users/nimiq/following{/other_user}","gists_url":"https://api.github.com/users/nimiq/gists{/gist_id}","starred_url":"https://api.github.com/users/nimiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimiq/subscriptions","organizations_url":"https://api.github.com/users/nimiq/orgs","repos_url":"https://api.github.com/users/nimiq/repos","events_url":"https://api.github.com/users/nimiq/events{/privacy}","received_events_url":"https://api.github.com/users/nimiq/received_events","type":"Organization","site_admin":false},"repo":{"id":139560932,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk1NjA5MzI=","name":"keyguard-next","full_name":"nimiq/keyguard-next","private":false,"owner":{"login":"nimiq","id":33815469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODE1NDY5","avatar_url":"https://avatars1.githubusercontent.com/u/33815469?v=4","gravatar_id":"","url":"https://api.github.com/users/nimiq","html_url":"https://github.com/nimiq","followers_url":"https://api.github.com/users/nimiq/followers","following_url":"https://api.github.com/users/nimiq/following{/other_user}","gists_url":"https://api.github.com/users/nimiq/gists{/gist_id}","starred_url":"https://api.github.com/users/nimiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nimiq/subscriptions","organizations_url":"https://api.github.com/users/nimiq/orgs","repos_url":"https://api.github.com/users/nimiq/repos","events_url":"https://api.github.com/users/nimiq/events{/privacy}","received_events_url":"https://api.github.com/users/nimiq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nimiq/keyguard-next","description":null,"fork":false,"url":"https://api.github.com/repos/nimiq/keyguard-next","forks_url":"https://api.github.com/repos/nimiq/keyguard-next/forks","keys_url":"https://api.github.com/repos/nimiq/keyguard-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nimiq/keyguard-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nimiq/keyguard-next/teams","hooks_url":"https://api.github.com/repos/nimiq/keyguard-next/hooks","issue_events_url":"https://api.github.com/repos/nimiq/keyguard-next/issues/events{/number}","events_url":"https://api.github.com/repos/nimiq/keyguard-next/events","assignees_url":"https://api.github.com/repos/nimiq/keyguard-next/assignees{/user}","branches_url":"https://api.github.com/repos/nimiq/keyguard-next/branches{/branch}","tags_url":"https://api.github.com/repos/nimiq/keyguard-next/tags","blobs_url":"https://api.github.com/repos/nimiq/keyguard-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nimiq/keyguard-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nimiq/keyguard-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/nimiq/keyguard-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nimiq/keyguard-next/statuses/{sha}","languages_url":"https://api.github.com/repos/nimiq/keyguard-next/languages","stargazers_url":"https://api.github.com/repos/nimiq/keyguard-next/stargazers","contributors_url":"https://api.github.com/repos/nimiq/keyguard-next/contributors","subscribers_url":"https://api.github.com/repos/nimiq/keyguard-next/subscribers","subscription_url":"https://api.github.com/repos/nimiq/keyguard-next/subscription","commits_url":"https://api.github.com/repos/nimiq/keyguard-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/nimiq/keyguard-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/nimiq/keyguard-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/nimiq/keyguard-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/nimiq/keyguard-next/contents/{+path}","compare_url":"https://api.github.com/repos/nimiq/keyguard-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nimiq/keyguard-next/merges","archive_url":"https://api.github.com/repos/nimiq/keyguard-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nimiq/keyguard-next/downloads","issues_url":"https://api.github.com/repos/nimiq/keyguard-next/issues{/number}","pulls_url":"https://api.github.com/repos/nimiq/keyguard-next/pulls{/number}","milestones_url":"https://api.github.com/repos/nimiq/keyguard-next/milestones{/number}","notifications_url":"https://api.github.com/repos/nimiq/keyguard-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nimiq/keyguard-next/labels{/name}","releases_url":"https://api.github.com/repos/nimiq/keyguard-next/releases{/id}","deployments_url":"https://api.github.com/repos/nimiq/keyguard-next/deployments","created_at":"2018-07-03T09:35:36Z","updated_at":"2019-05-03T06:42:50Z","pushed_at":"2019-05-06T09:53:02Z","git_url":"git://github.com/nimiq/keyguard-next.git","ssh_url":"[email protected]:nimiq/keyguard-next.git","clone_url":"https://github.com/nimiq/keyguard-next.git","svn_url":"https://github.com/nimiq/keyguard-next","homepage":null,"size":3104,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":15,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nimiq/keyguard-next/pulls/287"},"html":{"href":"https://github.com/nimiq/keyguard-next/pull/287"},"issue":{"href":"https://api.github.com/repos/nimiq/keyguard-next/issues/287"},"comments":{"href":"https://api.github.com/repos/nimiq/keyguard-next/issues/287/comments"},"review_comments":{"href":"https://api.github.com/repos/nimiq/keyguard-next/pulls/287/comments"},"review_comment":{"href":"https://api.github.com/repos/nimiq/keyguard-next/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nimiq/keyguard-next/pulls/287/commits"},"statuses":{"href":"https://api.github.com/repos/nimiq/keyguard-next/statuses/02f486493e30badc9fba306e3657e749ddedfac4"}},"author_association":"CONTRIBUTOR"}}	{ "id": 139560932, "name": "nimiq/keyguard-next", "url": "https://api.github.com/repos/nimiq/keyguard-next" }	{ "id": 1828163, "login": "sisou", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/1828163?", "url": "https://api.github.com/users/sisou" }	{ "id": 33815469, "login": "nimiq", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/33815469?", "url": "https://api.github.com/orgs/nimiq" }	2019-05-06T09:58:08	9568970878	{"actor":{"display_login":"sisou"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/pulls/comments/338067361","pull_request_review_id":305915950,"id":338067361,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzODA2NzM2MQ==","diff_hunk":"@@ -165,6 +168,201 @@ func (gp gressPolicy) delAddressSet(hashedAddressSet string) (string, string, b\n \treturn oldL3Match, gp.getL3MatchFromAddressSet(), true\n }\n \n+func (oc Controller) handlePeerPodSelectorAddUpdate(np namespacePolicy,\n+\taddressMap map[string]bool, addressSet string, obj interface{}) {\n+\n+\tpod := obj.(kapi.Pod)\n+\tpodAnnotation, err := util.UnmarshalPodAnnotation(pod.Annotations[\"ovn\"])\n+\tif err != nil {\n+\t\treturn\n+\t}\n+\tipAddress := podAnnotation.IP.IP.String()\n+\tif addressMap[ipAddress] {\n+\t\treturn\n+\t}\n+\n+\tnp.Lock()\n+\tdefer np.Unlock()\n+\tif np.deleted {\n+\t\treturn\n+\t}\n+\n+\taddressMap[ipAddress] = true\n+\taddresses := make([]string, 0, len(addressMap))\n+\tfor k := range addressMap {\n+\t\taddresses = append(addresses, k)\n+\t}\n+\toc.setAddressSet(addressSet, addresses)\n+\n+}\n+\n+func (oc Controller) handlePeerPodSelectorDelete(np namespacePolicy,\n+\taddressMap map[string]bool, addressSet string, obj interface{}) {\n+\n+\tpod := obj.(kapi.Pod)\n+\tpodAnnotation, err := util.UnmarshalPodAnnotation(pod.Annotations[\"ovn\"])\n+\tif err != nil {\n+\t\treturn\n+\t}\n+\tipAddress := podAnnotation.IP.IP.String()\n+\n+\tnp.Lock()\n+\tdefer np.Unlock()\n+\tif np.deleted {\n+\t\treturn\n+\t}\n+\n+\tif !addressMap[ipAddress] {\n+\t\treturn\n+\t}\n+\n+\tdelete(addressMap, ipAddress)\n+\n+\taddresses := make([]string, 0, len(addressMap))\n+\tfor k := range addressMap {\n+\t\taddresses = append(addresses, k)\n+\t}\n+\toc.setAddressSet(addressSet, addresses)\n+}\n+\n+func (oc Controller) handlePeerPodSelector(\n+\tpolicy knet.NetworkPolicy, podSelector metav1.LabelSelector,\n+\taddressSet string, addressMap map[string]bool, np namespacePolicy) {\n+\n+\th, err := oc.watchFactory.AddFilteredPodHandler(policy.Namespace,\n+\t\tpodSelector,\n+\t\tcache.ResourceEventHandlerFuncs{\n+\t\t\tAddFunc: func(obj interface{}) {\n+\t\t\t\toc.handlePeerPodSelectorAddUpdate(np, addressMap, addressSet, obj)\n+\t\t\t},\n+\t\t\tDeleteFunc: func(obj interface{}) {\n+\t\t\t\toc.handlePeerPodSelectorDelete(np, addressMap, addressSet, obj)\n+\t\t\t},\n+\t\t\tUpdateFunc: func(oldObj, newObj interface{}) {\n+\t\t\t\toc.handlePeerPodSelectorAddUpdate(np, addressMap, addressSet, newObj)\n+\t\t\t},\n+\t\t}, nil)\n+\tif err != nil {\n+\t\tlogrus.Errorf(\"error watching peer pods for policy %s in namespace %s: %v\",\n+\t\t\tpolicy.Name, policy.Namespace, err)\n+\t\treturn\n+\t}\n+\n+\tnp.podHandlerList = append(np.podHandlerList, h)\n+}\n+\n+func (oc Controller) handlePeerNamespaceAndPodSelector(\n+\tpolicy knet.NetworkPolicy,\n+\tnamespaceSelector metav1.LabelSelector,\n+\tpodSelector metav1.LabelSelector,\n+\taddressSet string,\n+\taddressMap map[string]bool,\n+\tnp namespacePolicy) {\n+\n+\tnamespaceHandler, err := oc.watchFactory.AddFilteredNamespaceHandler(\"\",\n+\t\tnamespaceSelector,\n+\t\tcache.ResourceEventHandlerFuncs{\n+\t\t\tAddFunc: func(obj interface{}) {\n+\t\t\t\tnamespace := obj.(*kapi.Namespace)\n+\t\t\t\tnp.Lock()\n+\t\t\t\talreadyDeleted := np.deleted","path":"go-controller/pkg/ovn/policy_common.go","position":112,"original_position":112,"commit_id":"9e9f81dbb1bfcf9a5817b087503e8e0089ef4876","original_commit_id":"9e9f81dbb1bfcf9a5817b087503e8e0089ef4876","user":{"login":"squeed","id":551378,"node_id":"MDQ6VXNlcjU1MTM3OA==","avatar_url":"https://avatars2.githubusercontent.com/u/551378?v=4","gravatar_id":"","url":"https://api.github.com/users/squeed","html_url":"https://github.com/squeed","followers_url":"https://api.github.com/users/squeed/followers","following_url":"https://api.github.com/users/squeed/following{/other_user}","gists_url":"https://api.github.com/users/squeed/gists{/gist_id}","starred_url":"https://api.github.com/users/squeed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squeed/subscriptions","organizations_url":"https://api.github.com/users/squeed/orgs","repos_url":"https://api.github.com/users/squeed/repos","events_url":"https://api.github.com/users/squeed/events{/privacy}","received_events_url":"https://api.github.com/users/squeed/received_events","type":"User","site_admin":false},"body":"Theoretically, you should be comparing the UIDs to ensure this isn't a new namespace. We can let this slide for now (I know this is a bigger refactor)","created_at":"2019-10-23T14:02:59Z","updated_at":"2019-10-23T14:02:59Z","html_url":"https://github.com/ovn-org/ovn-kubernetes/pull/874#discussion_r338067361","pull_request_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/pulls/874","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ovn-org/ovn-kubernetes/pulls/comments/338067361"},"html":{"href":"https://github.com/ovn-org/ovn-kubernetes/pull/874#discussion_r338067361"},"pull_request":{"href":"https://api.github.com/repos/ovn-org/ovn-kubernetes/pulls/874"}}},"pull_request":{"url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/pulls/874","id":331035715,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMxMDM1NzE1","html_url":"https://github.com/ovn-org/ovn-kubernetes/pull/874","diff_url":"https://github.com/ovn-org/ovn-kubernetes/pull/874.diff","patch_url":"https://github.com/ovn-org/ovn-kubernetes/pull/874.patch","issue_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/issues/874","number":874,"state":"open","locked":false,"title":"policy: simplify and consolidate some code","user":{"login":"dcbw","id":10926354,"node_id":"MDQ6VXNlcjEwOTI2MzU0","avatar_url":"https://avatars2.githubusercontent.com/u/10926354?v=4","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},"body":"Simplify and consolidate policy code.\r\n\r\n@squeed @girishmg @danwinship @alexanderConstantinescu @mccv1r0 @JacobTanenbaum ","created_at":"2019-10-22T14:47:17Z","updated_at":"2019-10-23T14:02:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"911438510c988e8cb5422dd44e93ab5d9933eeda","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/pulls/874/commits","review_comments_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/pulls/874/comments","review_comment_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/issues/874/comments","statuses_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/statuses/9e9f81dbb1bfcf9a5817b087503e8e0089ef4876","head":{"label":"dcbw:policy-simplify","ref":"policy-simplify","sha":"9e9f81dbb1bfcf9a5817b087503e8e0089ef4876","user":{"login":"dcbw","id":10926354,"node_id":"MDQ6VXNlcjEwOTI2MzU0","avatar_url":"https://avatars2.githubusercontent.com/u/10926354?v=4","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},"repo":{"id":98914640,"node_id":"MDEwOlJlcG9zaXRvcnk5ODkxNDY0MA==","name":"ovn-kubernetes","full_name":"dcbw/ovn-kubernetes","private":false,"owner":{"login":"dcbw","id":10926354,"node_id":"MDQ6VXNlcjEwOTI2MzU0","avatar_url":"https://avatars2.githubusercontent.com/u/10926354?v=4","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dcbw/ovn-kubernetes","description":"Kubernetes integration for OVN","fork":true,"url":"https://api.github.com/repos/dcbw/ovn-kubernetes","forks_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/forks","keys_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/teams","hooks_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/events","assignees_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/tags","blobs_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/languages","stargazers_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/subscription","commits_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/merges","archive_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/downloads","issues_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/dcbw/ovn-kubernetes/deployments","created_at":"2017-07-31T17:54:10Z","updated_at":"2019-05-02T21:55:39Z","pushed_at":"2019-10-23T02:00:28Z","git_url":"git://github.com/dcbw/ovn-kubernetes.git","ssh_url":"[email protected]:dcbw/ovn-kubernetes.git","clone_url":"https://github.com/dcbw/ovn-kubernetes.git","svn_url":"https://github.com/dcbw/ovn-kubernetes","homepage":null,"size":20244,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ovn-org:master","ref":"master","sha":"b771d381a291b820f5d6b07b154a9df3c5401030","user":{"login":"ovn-org","id":33884263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODg0MjYz","avatar_url":"https://avatars3.githubusercontent.com/u/33884263?v=4","gravatar_id":"","url":"https://api.github.com/users/ovn-org","html_url":"https://github.com/ovn-org","followers_url":"https://api.github.com/users/ovn-org/followers","following_url":"https://api.github.com/users/ovn-org/following{/other_user}","gists_url":"https://api.github.com/users/ovn-org/gists{/gist_id}","starred_url":"https://api.github.com/users/ovn-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovn-org/subscriptions","organizations_url":"https://api.github.com/users/ovn-org/orgs","repos_url":"https://api.github.com/users/ovn-org/repos","events_url":"https://api.github.com/users/ovn-org/events{/privacy}","received_events_url":"https://api.github.com/users/ovn-org/received_events","type":"Organization","site_admin":false},"repo":{"id":65489927,"node_id":"MDEwOlJlcG9zaXRvcnk2NTQ4OTkyNw==","name":"ovn-kubernetes","full_name":"ovn-org/ovn-kubernetes","private":false,"owner":{"login":"ovn-org","id":33884263,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODg0MjYz","avatar_url":"https://avatars3.githubusercontent.com/u/33884263?v=4","gravatar_id":"","url":"https://api.github.com/users/ovn-org","html_url":"https://github.com/ovn-org","followers_url":"https://api.github.com/users/ovn-org/followers","following_url":"https://api.github.com/users/ovn-org/following{/other_user}","gists_url":"https://api.github.com/users/ovn-org/gists{/gist_id}","starred_url":"https://api.github.com/users/ovn-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ovn-org/subscriptions","organizations_url":"https://api.github.com/users/ovn-org/orgs","repos_url":"https://api.github.com/users/ovn-org/repos","events_url":"https://api.github.com/users/ovn-org/events{/privacy}","received_events_url":"https://api.github.com/users/ovn-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ovn-org/ovn-kubernetes","description":"Kubernetes integration for OVN","fork":false,"url":"https://api.github.com/repos/ovn-org/ovn-kubernetes","forks_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/forks","keys_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/teams","hooks_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/hooks","issue_events_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/events","assignees_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/tags","blobs_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/languages","stargazers_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/stargazers","contributors_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/contributors","subscribers_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/subscribers","subscription_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/subscription","commits_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/merges","archive_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/downloads","issues_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/ovn-org/ovn-kubernetes/deployments","created_at":"2016-08-11T17:51:02Z","updated_at":"2019-10-22T20:47:35Z","pushed_at":"2019-10-23T10:14:00Z","git_url":"git://github.com/ovn-org/ovn-kubernetes.git","ssh_url":"[email protected]:ovn-org/ovn-kubernetes.git","clone_url":"https://github.com/ovn-org/ovn-kubernetes.git","svn_url":"https://github.com/ovn-org/ovn-kubernetes","homepage":null,"size":19905,"stargazers_count":302,"watchers_count":302,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":149,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":71,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":149,"open_issues":71,"watchers":302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ovn-org/ovn-kubernetes/pulls/874"},"html":{"href":"https://github.com/ovn-org/ovn-kubernetes/pull/874"},"issue":{"href":"https://api.github.com/repos/ovn-org/ovn-kubernetes/issues/874"},"comments":{"href":"https://api.github.com/repos/ovn-org/ovn-kubernetes/issues/874/comments"},"review_comments":{"href":"https://api.github.com/repos/ovn-org/ovn-kubernetes/pulls/874/comments"},"review_comment":{"href":"https://api.github.com/repos/ovn-org/ovn-kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ovn-org/ovn-kubernetes/pulls/874/commits"},"statuses":{"href":"https://api.github.com/repos/ovn-org/ovn-kubernetes/statuses/9e9f81dbb1bfcf9a5817b087503e8e0089ef4876"}},"author_association":"CONTRIBUTOR"}}	{ "id": 65489927, "name": "ovn-org/ovn-kubernetes", "url": "https://api.github.com/repos/ovn-org/ovn-kubernetes" }	{ "id": 551378, "login": "squeed", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/551378?", "url": "https://api.github.com/users/squeed" }	{ "id": 33884263, "login": "ovn-org", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/33884263?", "url": "https://api.github.com/orgs/ovn-org" }	2019-10-23T14:02:59	10696022081	{"actor":{"display_login":"squeed"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/pulls/comments/300293717","pull_request_review_id":257896069,"id":300293717,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMDI5MzcxNw==","diff_hunk":"@@ -0,0 +1,26 @@\n+package com.sun.tino.pomobox.view;\n+\n+import android.os.Bundle;\n+import android.support.annotation.NonNull;\n+import android.support.v4.app.Fragment;\n+import android.view.LayoutInflater;\n+import android.view.View;\n+import android.view.ViewGroup;\n+\n+public abstract class BaseFragment extends Fragment {\n+\n+ abstract int getLayoutId();\n+ abstract void onViewReady(View view);\n+\n+ @Override\n+ public void onCreate(Bundle savedInstanceState) {","path":"app/src/main/java/com/sun/tino/pomobox/view/BaseFragment.java","position":16,"original_position":16,"commit_id":"398f00757a5f8f59dd11a3258d52cf49cbb7223d","original_commit_id":"398f00757a5f8f59dd11a3258d52cf49cbb7223d","user":{"login":"quangcnv-1544","id":50895099,"node_id":"MDQ6VXNlcjUwODk1MDk5","avatar_url":"https://avatars2.githubusercontent.com/u/50895099?v=4","gravatar_id":"","url":"https://api.github.com/users/quangcnv-1544","html_url":"https://github.com/quangcnv-1544","followers_url":"https://api.github.com/users/quangcnv-1544/followers","following_url":"https://api.github.com/users/quangcnv-1544/following{/other_user}","gists_url":"https://api.github.com/users/quangcnv-1544/gists{/gist_id}","starred_url":"https://api.github.com/users/quangcnv-1544/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quangcnv-1544/subscriptions","organizations_url":"https://api.github.com/users/quangcnv-1544/orgs","repos_url":"https://api.github.com/users/quangcnv-1544/repos","events_url":"https://api.github.com/users/quangcnv-1544/events{/privacy}","received_events_url":"https://api.github.com/users/quangcnv-1544/received_events","type":"User","site_admin":false},"body":"override mà không làm gì thì Redundantly","created_at":"2019-07-04T08:46:30Z","updated_at":"2019-07-04T08:46:45Z","html_url":"https://github.com/awesome-academy/TimeManagement_01/pull/4#discussion_r300293717","pull_request_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/awesome-academy/TimeManagement_01/pulls/comments/300293717"},"html":{"href":"https://github.com/awesome-academy/TimeManagement_01/pull/4#discussion_r300293717"},"pull_request":{"href":"https://api.github.com/repos/awesome-academy/TimeManagement_01/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/pulls/4","id":294461385,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0NDYxMzg1","html_url":"https://github.com/awesome-academy/TimeManagement_01/pull/4","diff_url":"https://github.com/awesome-academy/TimeManagement_01/pull/4.diff","patch_url":"https://github.com/awesome-academy/TimeManagement_01/pull/4.patch","issue_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/issues/4","number":4,"state":"open","locked":false,"title":"home_screen_2","user":{"login":"tinobk","id":50605792,"node_id":"MDQ6VXNlcjUwNjA1Nzky","avatar_url":"https://avatars1.githubusercontent.com/u/50605792?v=4","gravatar_id":"","url":"https://api.github.com/users/tinobk","html_url":"https://github.com/tinobk","followers_url":"https://api.github.com/users/tinobk/followers","following_url":"https://api.github.com/users/tinobk/following{/other_user}","gists_url":"https://api.github.com/users/tinobk/gists{/gist_id}","starred_url":"https://api.github.com/users/tinobk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinobk/subscriptions","organizations_url":"https://api.github.com/users/tinobk/orgs","repos_url":"https://api.github.com/users/tinobk/repos","events_url":"https://api.github.com/users/tinobk/events{/privacy}","received_events_url":"https://api.github.com/users/tinobk/received_events","type":"User","site_admin":false},"body":"## [Pull request title] Create BaseFragment & Fragment View & Transaction\r\n\r\n### [Redmine link] https://edu-redmine.sun-asterisk.vn/issues/14503\r\n\r\n#### Screenshots (nếu có)\r\n![image](https://user-images.githubusercontent.com/50605792/60648651-8cf37c00-9e6a-11e9-88f1-0e967e92249a.png)\r\n![image](https://user-images.githubusercontent.com/50605792/60648660-9381f380-9e6a-11e9-867e-8285cedb2471.png)\r\n![image](https://user-images.githubusercontent.com/50605792/60648673-9a106b00-9e6a-11e9-82ec-91ba3f09a187.png)\r\n![image](https://user-images.githubusercontent.com/50605792/60648686-9e3c8880-9e6a-11e9-8619-a93b4f45f60b.png)\r\n![image](https://user-images.githubusercontent.com/50605792/60648691-a268a600-9e6a-11e9-9de8-57d55541bf2d.png)\r\n![image](https://user-images.githubusercontent.com/50605792/60648702-a5639680-9e6a-11e9-9d1c-34b68f474e71.png)\r\n![image](https://user-images.githubusercontent.com/50605792/60648706-a7c5f080-9e6a-11e9-98c1-337f63001d34.png)\r\n\r\n","created_at":"2019-07-04T07:47:40Z","updated_at":"2019-07-04T08:46:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8c1b5a36a6fb7cfc5a2f234c0f45e799f8a9f5e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/pulls/4/commits","review_comments_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/pulls/4/comments","review_comment_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/issues/4/comments","statuses_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/statuses/398f00757a5f8f59dd11a3258d52cf49cbb7223d","head":{"label":"tinobk:home_screen_2","ref":"home_screen_2","sha":"398f00757a5f8f59dd11a3258d52cf49cbb7223d","user":{"login":"tinobk","id":50605792,"node_id":"MDQ6VXNlcjUwNjA1Nzky","avatar_url":"https://avatars1.githubusercontent.com/u/50605792?v=4","gravatar_id":"","url":"https://api.github.com/users/tinobk","html_url":"https://github.com/tinobk","followers_url":"https://api.github.com/users/tinobk/followers","following_url":"https://api.github.com/users/tinobk/following{/other_user}","gists_url":"https://api.github.com/users/tinobk/gists{/gist_id}","starred_url":"https://api.github.com/users/tinobk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinobk/subscriptions","organizations_url":"https://api.github.com/users/tinobk/orgs","repos_url":"https://api.github.com/users/tinobk/repos","events_url":"https://api.github.com/users/tinobk/events{/privacy}","received_events_url":"https://api.github.com/users/tinobk/received_events","type":"User","site_admin":false},"repo":{"id":195000079,"node_id":"MDEwOlJlcG9zaXRvcnkxOTUwMDAwNzk=","name":"TimeManagement_01","full_name":"tinobk/TimeManagement_01","private":false,"owner":{"login":"tinobk","id":50605792,"node_id":"MDQ6VXNlcjUwNjA1Nzky","avatar_url":"https://avatars1.githubusercontent.com/u/50605792?v=4","gravatar_id":"","url":"https://api.github.com/users/tinobk","html_url":"https://github.com/tinobk","followers_url":"https://api.github.com/users/tinobk/followers","following_url":"https://api.github.com/users/tinobk/following{/other_user}","gists_url":"https://api.github.com/users/tinobk/gists{/gist_id}","starred_url":"https://api.github.com/users/tinobk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinobk/subscriptions","organizations_url":"https://api.github.com/users/tinobk/orgs","repos_url":"https://api.github.com/users/tinobk/repos","events_url":"https://api.github.com/users/tinobk/events{/privacy}","received_events_url":"https://api.github.com/users/tinobk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tinobk/TimeManagement_01","description":"For_Lab_TungTP","fork":true,"url":"https://api.github.com/repos/tinobk/TimeManagement_01","forks_url":"https://api.github.com/repos/tinobk/TimeManagement_01/forks","keys_url":"https://api.github.com/repos/tinobk/TimeManagement_01/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinobk/TimeManagement_01/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinobk/TimeManagement_01/teams","hooks_url":"https://api.github.com/repos/tinobk/TimeManagement_01/hooks","issue_events_url":"https://api.github.com/repos/tinobk/TimeManagement_01/issues/events{/number}","events_url":"https://api.github.com/repos/tinobk/TimeManagement_01/events","assignees_url":"https://api.github.com/repos/tinobk/TimeManagement_01/assignees{/user}","branches_url":"https://api.github.com/repos/tinobk/TimeManagement_01/branches{/branch}","tags_url":"https://api.github.com/repos/tinobk/TimeManagement_01/tags","blobs_url":"https://api.github.com/repos/tinobk/TimeManagement_01/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinobk/TimeManagement_01/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinobk/TimeManagement_01/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinobk/TimeManagement_01/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinobk/TimeManagement_01/statuses/{sha}","languages_url":"https://api.github.com/repos/tinobk/TimeManagement_01/languages","stargazers_url":"https://api.github.com/repos/tinobk/TimeManagement_01/stargazers","contributors_url":"https://api.github.com/repos/tinobk/TimeManagement_01/contributors","subscribers_url":"https://api.github.com/repos/tinobk/TimeManagement_01/subscribers","subscription_url":"https://api.github.com/repos/tinobk/TimeManagement_01/subscription","commits_url":"https://api.github.com/repos/tinobk/TimeManagement_01/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinobk/TimeManagement_01/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinobk/TimeManagement_01/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinobk/TimeManagement_01/issues/comments{/number}","contents_url":"https://api.github.com/repos/tinobk/TimeManagement_01/contents/{+path}","compare_url":"https://api.github.com/repos/tinobk/TimeManagement_01/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinobk/TimeManagement_01/merges","archive_url":"https://api.github.com/repos/tinobk/TimeManagement_01/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinobk/TimeManagement_01/downloads","issues_url":"https://api.github.com/repos/tinobk/TimeManagement_01/issues{/number}","pulls_url":"https://api.github.com/repos/tinobk/TimeManagement_01/pulls{/number}","milestones_url":"https://api.github.com/repos/tinobk/TimeManagement_01/milestones{/number}","notifications_url":"https://api.github.com/repos/tinobk/TimeManagement_01/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinobk/TimeManagement_01/labels{/name}","releases_url":"https://api.github.com/repos/tinobk/TimeManagement_01/releases{/id}","deployments_url":"https://api.github.com/repos/tinobk/TimeManagement_01/deployments","created_at":"2019-07-03T07:15:35Z","updated_at":"2019-07-03T07:15:38Z","pushed_at":"2019-07-04T08:35:01Z","git_url":"git://github.com/tinobk/TimeManagement_01.git","ssh_url":"[email protected]:tinobk/TimeManagement_01.git","clone_url":"https://github.com/tinobk/TimeManagement_01.git","svn_url":"https://github.com/tinobk/TimeManagement_01","homepage":null,"size":702,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"awesome-academy:develop","ref":"develop","sha":"3c3bede0eda56b8a532ee00e21fbb14f504aa83b","user":{"login":"awesome-academy","id":33895223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODk1MjIz","avatar_url":"https://avatars0.githubusercontent.com/u/33895223?v=4","gravatar_id":"","url":"https://api.github.com/users/awesome-academy","html_url":"https://github.com/awesome-academy","followers_url":"https://api.github.com/users/awesome-academy/followers","following_url":"https://api.github.com/users/awesome-academy/following{/other_user}","gists_url":"https://api.github.com/users/awesome-academy/gists{/gist_id}","starred_url":"https://api.github.com/users/awesome-academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesome-academy/subscriptions","organizations_url":"https://api.github.com/users/awesome-academy/orgs","repos_url":"https://api.github.com/users/awesome-academy/repos","events_url":"https://api.github.com/users/awesome-academy/events{/privacy}","received_events_url":"https://api.github.com/users/awesome-academy/received_events","type":"Organization","site_admin":false},"repo":{"id":194834411,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQ4MzQ0MTE=","name":"TimeManagement_01","full_name":"awesome-academy/TimeManagement_01","private":false,"owner":{"login":"awesome-academy","id":33895223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODk1MjIz","avatar_url":"https://avatars0.githubusercontent.com/u/33895223?v=4","gravatar_id":"","url":"https://api.github.com/users/awesome-academy","html_url":"https://github.com/awesome-academy","followers_url":"https://api.github.com/users/awesome-academy/followers","following_url":"https://api.github.com/users/awesome-academy/following{/other_user}","gists_url":"https://api.github.com/users/awesome-academy/gists{/gist_id}","starred_url":"https://api.github.com/users/awesome-academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesome-academy/subscriptions","organizations_url":"https://api.github.com/users/awesome-academy/orgs","repos_url":"https://api.github.com/users/awesome-academy/repos","events_url":"https://api.github.com/users/awesome-academy/events{/privacy}","received_events_url":"https://api.github.com/users/awesome-academy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/awesome-academy/TimeManagement_01","description":"For_Lab_TungTP","fork":false,"url":"https://api.github.com/repos/awesome-academy/TimeManagement_01","forks_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/forks","keys_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/teams","hooks_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/hooks","issue_events_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/issues/events{/number}","events_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/events","assignees_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/assignees{/user}","branches_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/branches{/branch}","tags_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/tags","blobs_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/git/refs{/sha}","trees_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/statuses/{sha}","languages_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/languages","stargazers_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/stargazers","contributors_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/contributors","subscribers_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/subscribers","subscription_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/subscription","commits_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/commits{/sha}","git_commits_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/git/commits{/sha}","comments_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/comments{/number}","issue_comment_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/issues/comments{/number}","contents_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/contents/{+path}","compare_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/merges","archive_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/downloads","issues_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/issues{/number}","pulls_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/pulls{/number}","milestones_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/milestones{/number}","notifications_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/labels{/name}","releases_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/releases{/id}","deployments_url":"https://api.github.com/repos/awesome-academy/TimeManagement_01/deployments","created_at":"2019-07-02T09:39:05Z","updated_at":"2019-07-04T04:50:37Z","pushed_at":"2019-07-04T08:35:03Z","git_url":"git://github.com/awesome-academy/TimeManagement_01.git","ssh_url":"[email protected]:awesome-academy/TimeManagement_01.git","clone_url":"https://github.com/awesome-academy/TimeManagement_01.git","svn_url":"https://github.com/awesome-academy/TimeManagement_01","homepage":null,"size":697,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/awesome-academy/TimeManagement_01/pulls/4"},"html":{"href":"https://github.com/awesome-academy/TimeManagement_01/pull/4"},"issue":{"href":"https://api.github.com/repos/awesome-academy/TimeManagement_01/issues/4"},"comments":{"href":"https://api.github.com/repos/awesome-academy/TimeManagement_01/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/awesome-academy/TimeManagement_01/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/awesome-academy/TimeManagement_01/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awesome-academy/TimeManagement_01/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/awesome-academy/TimeManagement_01/statuses/398f00757a5f8f59dd11a3258d52cf49cbb7223d"}},"author_association":"CONTRIBUTOR"}}	{ "id": 194834411, "name": "awesome-academy/TimeManagement_01", "url": "https://api.github.com/repos/awesome-academy/TimeManagement_01" }	{ "id": 50895099, "login": "quangcnv-1544", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/50895099?", "url": "https://api.github.com/users/quangcnv-1544" }	{ "id": 33895223, "login": "awesome-academy", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/33895223?", "url": "https://api.github.com/orgs/awesome-academy" }	2019-07-04T08:46:30	9948371938	{"actor":{"display_login":"quangcnv-1544"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/pulls/comments/307081433","pull_request_review_id":266359225,"id":307081433,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzA4MTQzMw==","diff_hunk":"@@ -0,0 +1,72 @@\n+<div class=\"modal fade\" id=\"form-edit-user\" tabindex=\"-1\" role=\"dialog\" aria-labelledby=\"exampleModalLabel\" aria-hidden=\"true\">\n+ <div class=\"modal-dialog modal-dialog-centered\" role=\"document\">\n+ <div class=\"modal-content\">\n+ <div class=\"modal-header border-bottom-0\">\n+ <h5 class=\"modal-title\" id=\"exampleModalLabel\">Sửa thông tin cá nhân</h5>\n+ <button type=\"button\" class=\"close\" data-dismiss=\"modal\" aria-label=\"Close\">\n+ <span aria-hidden=\"true\">×</span>\n+ </button>\n+ </div>\n+ <div class=\"modal-body\">\n+ <%= form_for(resource, as: resource_name, url: registration_path(resource_name), html: {method: :put}) do \|f\| %>\n+\n+ <div class=\"avatar text-center\">\n+ <img class=\"card-img-top rounded-circle img-responsive\" src=\"https://mdbootstrap.com/img/Photos/Avatars/img%20%281%29.jpg\" alt=\"Card image\" style=\"width:50%\">\n+ <div class=\"change-avatar-profile text-center gambar\">\n+ <span>Đổi ảnh đại diện</span>","path":"app/views/devise/registrations/edit.html..erb","position":16,"original_position":16,"commit_id":"d802772875c2f45009310da81cdb61b6706dea29","original_commit_id":"d802772875c2f45009310da81cdb61b6706dea29","user":{"login":"hungct-1121","id":49508133,"node_id":"MDQ6VXNlcjQ5NTA4MTMz","avatar_url":"https://avatars1.githubusercontent.com/u/49508133?v=4","gravatar_id":"","url":"https://api.github.com/users/hungct-1121","html_url":"https://github.com/hungct-1121","followers_url":"https://api.github.com/users/hungct-1121/followers","following_url":"https://api.github.com/users/hungct-1121/following{/other_user}","gists_url":"https://api.github.com/users/hungct-1121/gists{/gist_id}","starred_url":"https://api.github.com/users/hungct-1121/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hungct-1121/subscriptions","organizations_url":"https://api.github.com/users/hungct-1121/orgs","repos_url":"https://api.github.com/users/hungct-1121/repos","events_url":"https://api.github.com/users/hungct-1121/events{/privacy}","received_events_url":"https://api.github.com/users/hungct-1121/received_events","type":"User","site_admin":false},"body":"i18n","created_at":"2019-07-25T01:18:11Z","updated_at":"2019-07-25T01:18:35Z","html_url":"https://github.com/awesome-academy/ruby-intern-2019-chat-app/pull/7#discussion_r307081433","pull_request_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/pulls/7","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/pulls/comments/307081433"},"html":{"href":"https://github.com/awesome-academy/ruby-intern-2019-chat-app/pull/7#discussion_r307081433"},"pull_request":{"href":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/pulls/7","id":300613498,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwNjEzNDk4","html_url":"https://github.com/awesome-academy/ruby-intern-2019-chat-app/pull/7","diff_url":"https://github.com/awesome-academy/ruby-intern-2019-chat-app/pull/7.diff","patch_url":"https://github.com/awesome-academy/ruby-intern-2019-chat-app/pull/7.patch","issue_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/issues/7","number":7,"state":"open","locked":false,"title":"Add Friend","user":{"login":"hungbnb-0923","id":52640415,"node_id":"MDQ6VXNlcjUyNjQwNDE1","avatar_url":"https://avatars0.githubusercontent.com/u/52640415?v=4","gravatar_id":"","url":"https://api.github.com/users/hungbnb-0923","html_url":"https://github.com/hungbnb-0923","followers_url":"https://api.github.com/users/hungbnb-0923/followers","following_url":"https://api.github.com/users/hungbnb-0923/following{/other_user}","gists_url":"https://api.github.com/users/hungbnb-0923/gists{/gist_id}","starred_url":"https://api.github.com/users/hungbnb-0923/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hungbnb-0923/subscriptions","organizations_url":"https://api.github.com/users/hungbnb-0923/orgs","repos_url":"https://api.github.com/users/hungbnb-0923/repos","events_url":"https://api.github.com/users/hungbnb-0923/events{/privacy}","received_events_url":"https://api.github.com/users/hungbnb-0923/received_events","type":"User","site_admin":false},"body":"![image](https://user-images.githubusercontent.com/52640415/61777616-6a300400-ae27-11e9-8878-c10d8c2c9552.png)\r\nhttps://edu-redmine.sun-asterisk.vn/issues/15191/edit","created_at":"2019-07-24T08:25:39Z","updated_at":"2019-07-25T01:18:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4401b393a6892cc44e394cc66ae044d1bd700b6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/pulls/7/commits","review_comments_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/pulls/7/comments","review_comment_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/issues/7/comments","statuses_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/statuses/d802772875c2f45009310da81cdb61b6706dea29","head":{"label":"hungbnb-0923:add_friend","ref":"add_friend","sha":"d802772875c2f45009310da81cdb61b6706dea29","user":{"login":"hungbnb-0923","id":52640415,"node_id":"MDQ6VXNlcjUyNjQwNDE1","avatar_url":"https://avatars0.githubusercontent.com/u/52640415?v=4","gravatar_id":"","url":"https://api.github.com/users/hungbnb-0923","html_url":"https://github.com/hungbnb-0923","followers_url":"https://api.github.com/users/hungbnb-0923/followers","following_url":"https://api.github.com/users/hungbnb-0923/following{/other_user}","gists_url":"https://api.github.com/users/hungbnb-0923/gists{/gist_id}","starred_url":"https://api.github.com/users/hungbnb-0923/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hungbnb-0923/subscriptions","organizations_url":"https://api.github.com/users/hungbnb-0923/orgs","repos_url":"https://api.github.com/users/hungbnb-0923/repos","events_url":"https://api.github.com/users/hungbnb-0923/events{/privacy}","received_events_url":"https://api.github.com/users/hungbnb-0923/received_events","type":"User","site_admin":false},"repo":{"id":197560726,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc1NjA3MjY=","name":"ruby-intern-2019-chat-app","full_name":"hungbnb-0923/ruby-intern-2019-chat-app","private":false,"owner":{"login":"hungbnb-0923","id":52640415,"node_id":"MDQ6VXNlcjUyNjQwNDE1","avatar_url":"https://avatars0.githubusercontent.com/u/52640415?v=4","gravatar_id":"","url":"https://api.github.com/users/hungbnb-0923","html_url":"https://github.com/hungbnb-0923","followers_url":"https://api.github.com/users/hungbnb-0923/followers","following_url":"https://api.github.com/users/hungbnb-0923/following{/other_user}","gists_url":"https://api.github.com/users/hungbnb-0923/gists{/gist_id}","starred_url":"https://api.github.com/users/hungbnb-0923/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hungbnb-0923/subscriptions","organizations_url":"https://api.github.com/users/hungbnb-0923/orgs","repos_url":"https://api.github.com/users/hungbnb-0923/repos","events_url":"https://api.github.com/users/hungbnb-0923/events{/privacy}","received_events_url":"https://api.github.com/users/hungbnb-0923/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hungbnb-0923/ruby-intern-2019-chat-app","description":null,"fork":true,"url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app","forks_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/forks","keys_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/teams","hooks_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/hooks","issue_events_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/issues/events{/number}","events_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/events","assignees_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/assignees{/user}","branches_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/branches{/branch}","tags_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/tags","blobs_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/statuses/{sha}","languages_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/languages","stargazers_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/stargazers","contributors_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/contributors","subscribers_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/subscribers","subscription_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/subscription","commits_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/contents/{+path}","compare_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/merges","archive_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/downloads","issues_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/issues{/number}","pulls_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/pulls{/number}","milestones_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/milestones{/number}","notifications_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/labels{/name}","releases_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/releases{/id}","deployments_url":"https://api.github.com/repos/hungbnb-0923/ruby-intern-2019-chat-app/deployments","created_at":"2019-07-18T09:56:14Z","updated_at":"2019-07-18T09:56:16Z","pushed_at":"2019-07-24T16:50:11Z","git_url":"git://github.com/hungbnb-0923/ruby-intern-2019-chat-app.git","ssh_url":"[email protected]:hungbnb-0923/ruby-intern-2019-chat-app.git","clone_url":"https://github.com/hungbnb-0923/ruby-intern-2019-chat-app.git","svn_url":"https://github.com/hungbnb-0923/ruby-intern-2019-chat-app","homepage":null,"size":99,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awesome-academy:master","ref":"master","sha":"71d49c68815f43a0858c432cc20a979a47d52359","user":{"login":"awesome-academy","id":33895223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODk1MjIz","avatar_url":"https://avatars0.githubusercontent.com/u/33895223?v=4","gravatar_id":"","url":"https://api.github.com/users/awesome-academy","html_url":"https://github.com/awesome-academy","followers_url":"https://api.github.com/users/awesome-academy/followers","following_url":"https://api.github.com/users/awesome-academy/following{/other_user}","gists_url":"https://api.github.com/users/awesome-academy/gists{/gist_id}","starred_url":"https://api.github.com/users/awesome-academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesome-academy/subscriptions","organizations_url":"https://api.github.com/users/awesome-academy/orgs","repos_url":"https://api.github.com/users/awesome-academy/repos","events_url":"https://api.github.com/users/awesome-academy/events{/privacy}","received_events_url":"https://api.github.com/users/awesome-academy/received_events","type":"Organization","site_admin":false},"repo":{"id":197554828,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc1NTQ4Mjg=","name":"ruby-intern-2019-chat-app","full_name":"awesome-academy/ruby-intern-2019-chat-app","private":false,"owner":{"login":"awesome-academy","id":33895223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODk1MjIz","avatar_url":"https://avatars0.githubusercontent.com/u/33895223?v=4","gravatar_id":"","url":"https://api.github.com/users/awesome-academy","html_url":"https://github.com/awesome-academy","followers_url":"https://api.github.com/users/awesome-academy/followers","following_url":"https://api.github.com/users/awesome-academy/following{/other_user}","gists_url":"https://api.github.com/users/awesome-academy/gists{/gist_id}","starred_url":"https://api.github.com/users/awesome-academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesome-academy/subscriptions","organizations_url":"https://api.github.com/users/awesome-academy/orgs","repos_url":"https://api.github.com/users/awesome-academy/repos","events_url":"https://api.github.com/users/awesome-academy/events{/privacy}","received_events_url":"https://api.github.com/users/awesome-academy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/awesome-academy/ruby-intern-2019-chat-app","description":null,"fork":false,"url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app","forks_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/forks","keys_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/teams","hooks_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/hooks","issue_events_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/issues/events{/number}","events_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/events","assignees_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/assignees{/user}","branches_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/branches{/branch}","tags_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/tags","blobs_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/statuses/{sha}","languages_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/languages","stargazers_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/stargazers","contributors_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/contributors","subscribers_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/subscribers","subscription_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/subscription","commits_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/contents/{+path}","compare_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/merges","archive_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/downloads","issues_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/issues{/number}","pulls_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/pulls{/number}","milestones_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/milestones{/number}","notifications_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/labels{/name}","releases_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/releases{/id}","deployments_url":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/deployments","created_at":"2019-07-18T09:21:42Z","updated_at":"2019-07-24T09:13:32Z","pushed_at":"2019-07-24T16:50:12Z","git_url":"git://github.com/awesome-academy/ruby-intern-2019-chat-app.git","ssh_url":"[email protected]:awesome-academy/ruby-intern-2019-chat-app.git","clone_url":"https://github.com/awesome-academy/ruby-intern-2019-chat-app.git","svn_url":"https://github.com/awesome-academy/ruby-intern-2019-chat-app","homepage":null,"size":96,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":null,"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/pulls/7"},"html":{"href":"https://github.com/awesome-academy/ruby-intern-2019-chat-app/pull/7"},"issue":{"href":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/issues/7"},"comments":{"href":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app/statuses/d802772875c2f45009310da81cdb61b6706dea29"}},"author_association":"NONE"}}	{ "id": 197554828, "name": "awesome-academy/ruby-intern-2019-chat-app", "url": "https://api.github.com/repos/awesome-academy/ruby-intern-2019-chat-app" }	{ "id": 49508133, "login": "hungct-1121", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/49508133?", "url": "https://api.github.com/users/hungct-1121" }	{ "id": 33895223, "login": "awesome-academy", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/33895223?", "url": "https://api.github.com/orgs/awesome-academy" }	2019-07-25T01:18:11	10079458014	{"actor":{"display_login":"hungct-1121"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/tock/tock/pulls/comments/364876880","pull_request_review_id":340702755,"id":364876880,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NDg3Njg4MA==","diff_hunk":"@@ -15,13 +15,14 @@\n //! ```\n \n // Author: Philip Levis <[email protected]>\n-// Last modified: 12/21/2019\n+// Last modified: 1/08/2020","path":"boards/components/src/console.rs","position":5,"original_position":5,"commit_id":"1eed3d7d78d3f6f049af58c5d6988b82e5f428c3","original_commit_id":"ad3db0d020cf68cffa578cbc96aee51693403665","user":{"login":"hudson-ayers","id":32688905,"node_id":"MDQ6VXNlcjMyNjg4OTA1","avatar_url":"https://avatars0.githubusercontent.com/u/32688905?v=4","gravatar_id":"","url":"https://api.github.com/users/hudson-ayers","html_url":"https://github.com/hudson-ayers","followers_url":"https://api.github.com/users/hudson-ayers/followers","following_url":"https://api.github.com/users/hudson-ayers/following{/other_user}","gists_url":"https://api.github.com/users/hudson-ayers/gists{/gist_id}","starred_url":"https://api.github.com/users/hudson-ayers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hudson-ayers/subscriptions","organizations_url":"https://api.github.com/users/hudson-ayers/orgs","repos_url":"https://api.github.com/users/hudson-ayers/repos","events_url":"https://api.github.com/users/hudson-ayers/events{/privacy}","received_events_url":"https://api.github.com/users/hudson-ayers/received_events","type":"User","site_admin":false},"body":"Sorry, github won't let me place a review comment on a section of the file that you didn't touch, I meant that the example usage of the UartMuxComponent a few lines above this line is now out-of-date","created_at":"2020-01-09T17:48:52Z","updated_at":"2020-01-09T17:48:52Z","html_url":"https://github.com/tock/tock/pull/1522#discussion_r364876880","pull_request_url":"https://api.github.com/repos/tock/tock/pulls/1522","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tock/tock/pulls/comments/364876880"},"html":{"href":"https://github.com/tock/tock/pull/1522#discussion_r364876880"},"pull_request":{"href":"https://api.github.com/repos/tock/tock/pulls/1522"}},"in_reply_to_id":364561725},"pull_request":{"url":"https://api.github.com/repos/tock/tock/pulls/1522","id":359775141,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU5Nzc1MTQx","html_url":"https://github.com/tock/tock/pull/1522","diff_url":"https://github.com/tock/tock/pull/1522.diff","patch_url":"https://github.com/tock/tock/pull/1522.patch","issue_url":"https://api.github.com/repos/tock/tock/issues/1522","number":1522,"state":"open","locked":false,"title":"Transitions virtual UART to use a deferred callback","user":{"login":"phil-levis","id":4306795,"node_id":"MDQ6VXNlcjQzMDY3OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4306795?v=4","gravatar_id":"","url":"https://api.github.com/users/phil-levis","html_url":"https://github.com/phil-levis","followers_url":"https://api.github.com/users/phil-levis/followers","following_url":"https://api.github.com/users/phil-levis/following{/other_user}","gists_url":"https://api.github.com/users/phil-levis/gists{/gist_id}","starred_url":"https://api.github.com/users/phil-levis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phil-levis/subscriptions","organizations_url":"https://api.github.com/users/phil-levis/orgs","repos_url":"https://api.github.com/users/phil-levis/repos","events_url":"https://api.github.com/users/phil-levis/events{/privacy}","received_events_url":"https://api.github.com/users/phil-levis/received_events","type":"User","site_admin":false},"body":"Transitions virtual UART to use a deferred callback to trigger operations. In response to #1496 \r\n\r\nThis is only implemented on imix -- other boards need to make a similar\r\nchange to their reset_handler. This should probably be factored out to\r\na component.\r\n\r\nPutting this out for some initial feedback before I polish it fully.\r\n\r\n### Pull Request Overview\r\n\r\nThis fixes the bug in #1496\r\n\r\n\r\n### Testing Strategy\r\n\r\nThis pull request was tested by compiling and running multiiple printing apps on imix.\r\n\r\n\r\n### TODO or Help Wanted\r\n\r\nThis pull request still needs support for other boards.\r\n\r\n\r\n### Documentation Updated\r\n\r\n- [X] Updated the relevant files in `/docs`, or no updates are required.\r\n\r\n### Formatting\r\n\r\n- [ ] Ran `make formatall`.\r\n","created_at":"2020-01-07T00:54:17Z","updated_at":"2020-01-09T17:48:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22e0acf1adc3fc9ed34436cf9a9d0671779da160","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alevy","id":4689,"node_id":"MDQ6VXNlcjQ2ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/4689?v=4","gravatar_id":"","url":"https://api.github.com/users/alevy","html_url":"https://github.com/alevy","followers_url":"https://api.github.com/users/alevy/followers","following_url":"https://api.github.com/users/alevy/following{/other_user}","gists_url":"https://api.github.com/users/alevy/gists{/gist_id}","starred_url":"https://api.github.com/users/alevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alevy/subscriptions","organizations_url":"https://api.github.com/users/alevy/orgs","repos_url":"https://api.github.com/users/alevy/repos","events_url":"https://api.github.com/users/alevy/events{/privacy}","received_events_url":"https://api.github.com/users/alevy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tock/tock/pulls/1522/commits","review_comments_url":"https://api.github.com/repos/tock/tock/pulls/1522/comments","review_comment_url":"https://api.github.com/repos/tock/tock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tock/tock/issues/1522/comments","statuses_url":"https://api.github.com/repos/tock/tock/statuses/1eed3d7d78d3f6f049af58c5d6988b82e5f428c3","head":{"label":"tock:virtual_uart_reentrant_callback_fix","ref":"virtual_uart_reentrant_callback_fix","sha":"1eed3d7d78d3f6f049af58c5d6988b82e5f428c3","user":{"login":"tock","id":34076064,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MDc2MDY0","avatar_url":"https://avatars1.githubusercontent.com/u/34076064?v=4","gravatar_id":"","url":"https://api.github.com/users/tock","html_url":"https://github.com/tock","followers_url":"https://api.github.com/users/tock/followers","following_url":"https://api.github.com/users/tock/following{/other_user}","gists_url":"https://api.github.com/users/tock/gists{/gist_id}","starred_url":"https://api.github.com/users/tock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tock/subscriptions","organizations_url":"https://api.github.com/users/tock/orgs","repos_url":"https://api.github.com/users/tock/repos","events_url":"https://api.github.com/users/tock/events{/privacy}","received_events_url":"https://api.github.com/users/tock/received_events","type":"Organization","site_admin":false},"repo":{"id":36428094,"node_id":"MDEwOlJlcG9zaXRvcnkzNjQyODA5NA==","name":"tock","full_name":"tock/tock","private":false,"owner":{"login":"tock","id":34076064,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MDc2MDY0","avatar_url":"https://avatars1.githubusercontent.com/u/34076064?v=4","gravatar_id":"","url":"https://api.github.com/users/tock","html_url":"https://github.com/tock","followers_url":"https://api.github.com/users/tock/followers","following_url":"https://api.github.com/users/tock/following{/other_user}","gists_url":"https://api.github.com/users/tock/gists{/gist_id}","starred_url":"https://api.github.com/users/tock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tock/subscriptions","organizations_url":"https://api.github.com/users/tock/orgs","repos_url":"https://api.github.com/users/tock/repos","events_url":"https://api.github.com/users/tock/events{/privacy}","received_events_url":"https://api.github.com/users/tock/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tock/tock","description":"A secure embedded operating system for microcontrollers","fork":false,"url":"https://api.github.com/repos/tock/tock","forks_url":"https://api.github.com/repos/tock/tock/forks","keys_url":"https://api.github.com/repos/tock/tock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tock/tock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tock/tock/teams","hooks_url":"https://api.github.com/repos/tock/tock/hooks","issue_events_url":"https://api.github.com/repos/tock/tock/issues/events{/number}","events_url":"https://api.github.com/repos/tock/tock/events","assignees_url":"https://api.github.com/repos/tock/tock/assignees{/user}","branches_url":"https://api.github.com/repos/tock/tock/branches{/branch}","tags_url":"https://api.github.com/repos/tock/tock/tags","blobs_url":"https://api.github.com/repos/tock/tock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tock/tock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tock/tock/git/refs{/sha}","trees_url":"https://api.github.com/repos/tock/tock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tock/tock/statuses/{sha}","languages_url":"https://api.github.com/repos/tock/tock/languages","stargazers_url":"https://api.github.com/repos/tock/tock/stargazers","contributors_url":"https://api.github.com/repos/tock/tock/contributors","subscribers_url":"https://api.github.com/repos/tock/tock/subscribers","subscription_url":"https://api.github.com/repos/tock/tock/subscription","commits_url":"https://api.github.com/repos/tock/tock/commits{/sha}","git_commits_url":"https://api.github.com/repos/tock/tock/git/commits{/sha}","comments_url":"https://api.github.com/repos/tock/tock/comments{/number}","issue_comment_url":"https://api.github.com/repos/tock/tock/issues/comments{/number}","contents_url":"https://api.github.com/repos/tock/tock/contents/{+path}","compare_url":"https://api.github.com/repos/tock/tock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tock/tock/merges","archive_url":"https://api.github.com/repos/tock/tock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tock/tock/downloads","issues_url":"https://api.github.com/repos/tock/tock/issues{/number}","pulls_url":"https://api.github.com/repos/tock/tock/pulls{/number}","milestones_url":"https://api.github.com/repos/tock/tock/milestones{/number}","notifications_url":"https://api.github.com/repos/tock/tock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tock/tock/labels{/name}","releases_url":"https://api.github.com/repos/tock/tock/releases{/id}","deployments_url":"https://api.github.com/repos/tock/tock/deployments","created_at":"2015-05-28T09:26:47Z","updated_at":"2020-01-09T16:08:42Z","pushed_at":"2020-01-09T17:27:57Z","git_url":"git://github.com/tock/tock.git","ssh_url":"[email protected]:tock/tock.git","clone_url":"https://github.com/tock/tock.git","svn_url":"https://github.com/tock/tock","homepage":"https://www.tockos.org","size":142569,"stargazers_count":1607,"watchers_count":1607,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":217,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":93,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":217,"open_issues":93,"watchers":1607,"default_branch":"master"}},"base":{"label":"tock:master","ref":"master","sha":"7c48ee048b062908f3072da069cc2cb280055ec8","user":{"login":"tock","id":34076064,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MDc2MDY0","avatar_url":"https://avatars1.githubusercontent.com/u/34076064?v=4","gravatar_id":"","url":"https://api.github.com/users/tock","html_url":"https://github.com/tock","followers_url":"https://api.github.com/users/tock/followers","following_url":"https://api.github.com/users/tock/following{/other_user}","gists_url":"https://api.github.com/users/tock/gists{/gist_id}","starred_url":"https://api.github.com/users/tock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tock/subscriptions","organizations_url":"https://api.github.com/users/tock/orgs","repos_url":"https://api.github.com/users/tock/repos","events_url":"https://api.github.com/users/tock/events{/privacy}","received_events_url":"https://api.github.com/users/tock/received_events","type":"Organization","site_admin":false},"repo":{"id":36428094,"node_id":"MDEwOlJlcG9zaXRvcnkzNjQyODA5NA==","name":"tock","full_name":"tock/tock","private":false,"owner":{"login":"tock","id":34076064,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MDc2MDY0","avatar_url":"https://avatars1.githubusercontent.com/u/34076064?v=4","gravatar_id":"","url":"https://api.github.com/users/tock","html_url":"https://github.com/tock","followers_url":"https://api.github.com/users/tock/followers","following_url":"https://api.github.com/users/tock/following{/other_user}","gists_url":"https://api.github.com/users/tock/gists{/gist_id}","starred_url":"https://api.github.com/users/tock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tock/subscriptions","organizations_url":"https://api.github.com/users/tock/orgs","repos_url":"https://api.github.com/users/tock/repos","events_url":"https://api.github.com/users/tock/events{/privacy}","received_events_url":"https://api.github.com/users/tock/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tock/tock","description":"A secure embedded operating system for microcontrollers","fork":false,"url":"https://api.github.com/repos/tock/tock","forks_url":"https://api.github.com/repos/tock/tock/forks","keys_url":"https://api.github.com/repos/tock/tock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tock/tock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tock/tock/teams","hooks_url":"https://api.github.com/repos/tock/tock/hooks","issue_events_url":"https://api.github.com/repos/tock/tock/issues/events{/number}","events_url":"https://api.github.com/repos/tock/tock/events","assignees_url":"https://api.github.com/repos/tock/tock/assignees{/user}","branches_url":"https://api.github.com/repos/tock/tock/branches{/branch}","tags_url":"https://api.github.com/repos/tock/tock/tags","blobs_url":"https://api.github.com/repos/tock/tock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tock/tock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tock/tock/git/refs{/sha}","trees_url":"https://api.github.com/repos/tock/tock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tock/tock/statuses/{sha}","languages_url":"https://api.github.com/repos/tock/tock/languages","stargazers_url":"https://api.github.com/repos/tock/tock/stargazers","contributors_url":"https://api.github.com/repos/tock/tock/contributors","subscribers_url":"https://api.github.com/repos/tock/tock/subscribers","subscription_url":"https://api.github.com/repos/tock/tock/subscription","commits_url":"https://api.github.com/repos/tock/tock/commits{/sha}","git_commits_url":"https://api.github.com/repos/tock/tock/git/commits{/sha}","comments_url":"https://api.github.com/repos/tock/tock/comments{/number}","issue_comment_url":"https://api.github.com/repos/tock/tock/issues/comments{/number}","contents_url":"https://api.github.com/repos/tock/tock/contents/{+path}","compare_url":"https://api.github.com/repos/tock/tock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tock/tock/merges","archive_url":"https://api.github.com/repos/tock/tock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tock/tock/downloads","issues_url":"https://api.github.com/repos/tock/tock/issues{/number}","pulls_url":"https://api.github.com/repos/tock/tock/pulls{/number}","milestones_url":"https://api.github.com/repos/tock/tock/milestones{/number}","notifications_url":"https://api.github.com/repos/tock/tock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tock/tock/labels{/name}","releases_url":"https://api.github.com/repos/tock/tock/releases{/id}","deployments_url":"https://api.github.com/repos/tock/tock/deployments","created_at":"2015-05-28T09:26:47Z","updated_at":"2020-01-09T16:08:42Z","pushed_at":"2020-01-09T17:27:57Z","git_url":"git://github.com/tock/tock.git","ssh_url":"[email protected]:tock/tock.git","clone_url":"https://github.com/tock/tock.git","svn_url":"https://github.com/tock/tock","homepage":"https://www.tockos.org","size":142569,"stargazers_count":1607,"watchers_count":1607,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":217,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":93,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":217,"open_issues":93,"watchers":1607,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tock/tock/pulls/1522"},"html":{"href":"https://github.com/tock/tock/pull/1522"},"issue":{"href":"https://api.github.com/repos/tock/tock/issues/1522"},"comments":{"href":"https://api.github.com/repos/tock/tock/issues/1522/comments"},"review_comments":{"href":"https://api.github.com/repos/tock/tock/pulls/1522/comments"},"review_comment":{"href":"https://api.github.com/repos/tock/tock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tock/tock/pulls/1522/commits"},"statuses":{"href":"https://api.github.com/repos/tock/tock/statuses/1eed3d7d78d3f6f049af58c5d6988b82e5f428c3"}},"author_association":"COLLABORATOR"}}	{ "id": 36428094, "name": "tock/tock", "url": "https://api.github.com/repos/tock/tock" }	{ "id": 32688905, "login": "hudson-ayers", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/32688905?", "url": "https://api.github.com/users/hudson-ayers" }	{ "id": 34076064, "login": "tock", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/34076064?", "url": "https://api.github.com/orgs/tock" }	2020-01-09T17:48:52	11240152224	{"actor":{"display_login":"hudson-ayers"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/pulls/comments/350837239","pull_request_review_id":323102580,"id":350837239,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MDgzNzIzOQ==","diff_hunk":"@@ -56,80 +38,156 @@ protected function slug( $string ) {\n \t * @since 1.0\n \t /\n \tpublic function show_missing_application_credentials_notice() {\n-\t\tset_transient( $this->slug( 'show-missing-application-credentials' ), '1', DAY_IN_SECONDS );\n-\t}\n \n-\t/\n-\t Renders (echoes) the missing application credentials admin notice.\n-\t \n-\t @since 1.0\n-\t \n-\t /\n-\tpublic function render_missing_application_credentials_notice() {\n-\t\tTribe__Admin__Notices::instance()->render_paragraph(\n+\t\t/** @var \\Tribe__Settings $settings */\n+\t\t$settings = tribe( 'settings' );\n+\n+\t\t// Bail if user cannot change settings.\n+\t\tif ( ! current_user_can( $settings->requiredCap ) ) {\n+\t\t\treturn;\n+\t\t}\n+\n+\t\t// Bail if previously dismissed this notice.\n+\t\tif ( Tribe__Admin__Notices::instance()->has_user_dimissed( $this->slug( 'missing-application-credentials' ) ) ) {\n+\t\t\treturn;\n+\t\t}\n+\n+\t\t// Bail if the Application Credentials are Saved.\n+\t\t$options = tribe( 'tickets.hubspot' )->get_all_options();","path":"src/Tribe/Admin/Notices.php","position":70,"original_position":70,"commit_id":"e93e25cb777fc70f251ab71226a41dc163145151","original_commit_id":"e93e25cb777fc70f251ab71226a41dc163145151","user":{"login":"sc0ttkclark","id":709662,"node_id":"MDQ6VXNlcjcwOTY2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/709662?v=4","gravatar_id":"","url":"https://api.github.com/users/sc0ttkclark","html_url":"https://github.com/sc0ttkclark","followers_url":"https://api.github.com/users/sc0ttkclark/followers","following_url":"https://api.github.com/users/sc0ttkclark/following{/other_user}","gists_url":"https://api.github.com/users/sc0ttkclark/gists{/gist_id}","starred_url":"https://api.github.com/users/sc0ttkclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sc0ttkclark/subscriptions","organizations_url":"https://api.github.com/users/sc0ttkclark/orgs","repos_url":"https://api.github.com/users/sc0ttkclark/repos","events_url":"https://api.github.com/users/sc0ttkclark/events{/privacy}","received_events_url":"https://api.github.com/users/sc0ttkclark/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n\t\t$options = tribe( 'tickets.hubspot' )->get_all_options();\r\n\r\n```","created_at":"2019-11-26T16:09:32Z","updated_at":"2019-11-26T16:09:32Z","html_url":"https://github.com/mt-support/tribe-ext-hubspot/pull/13#discussion_r350837239","pull_request_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/pulls/13","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/pulls/comments/350837239"},"html":{"href":"https://github.com/mt-support/tribe-ext-hubspot/pull/13#discussion_r350837239"},"pull_request":{"href":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/pulls/13","id":344627395,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ0NjI3Mzk1","html_url":"https://github.com/mt-support/tribe-ext-hubspot/pull/13","diff_url":"https://github.com/mt-support/tribe-ext-hubspot/pull/13.diff","patch_url":"https://github.com/mt-support/tribe-ext-hubspot/pull/13.patch","issue_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/issues/13","number":13,"state":"open","locked":false,"title":"Feature/135919 rsvp edd tpp contact subscription","user":{"login":"jesseeproductions","id":8312466,"node_id":"MDQ6VXNlcjgzMTI0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/8312466?v=4","gravatar_id":"","url":"https://api.github.com/users/jesseeproductions","html_url":"https://github.com/jesseeproductions","followers_url":"https://api.github.com/users/jesseeproductions/followers","following_url":"https://api.github.com/users/jesseeproductions/following{/other_user}","gists_url":"https://api.github.com/users/jesseeproductions/gists{/gist_id}","starred_url":"https://api.github.com/users/jesseeproductions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesseeproductions/subscriptions","organizations_url":"https://api.github.com/users/jesseeproductions/orgs","repos_url":"https://api.github.com/users/jesseeproductions/repos","events_url":"https://api.github.com/users/jesseeproductions/events{/privacy}","received_events_url":"https://api.github.com/users/jesseeproductions/received_events","type":"User","site_admin":false},"body":"_Ref:_ [C#135919](https://central.tri.be/issues/135919)","created_at":"2019-11-22T17:42:09Z","updated_at":"2019-11-26T16:09:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f052e4d348c194a35ada3dc1140e7ef9ccaa1e18","assignee":{"login":"jesseeproductions","id":8312466,"node_id":"MDQ6VXNlcjgzMTI0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/8312466?v=4","gravatar_id":"","url":"https://api.github.com/users/jesseeproductions","html_url":"https://github.com/jesseeproductions","followers_url":"https://api.github.com/users/jesseeproductions/followers","following_url":"https://api.github.com/users/jesseeproductions/following{/other_user}","gists_url":"https://api.github.com/users/jesseeproductions/gists{/gist_id}","starred_url":"https://api.github.com/users/jesseeproductions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesseeproductions/subscriptions","organizations_url":"https://api.github.com/users/jesseeproductions/orgs","repos_url":"https://api.github.com/users/jesseeproductions/repos","events_url":"https://api.github.com/users/jesseeproductions/events{/privacy}","received_events_url":"https://api.github.com/users/jesseeproductions/received_events","type":"User","site_admin":false},"assignees":[{"login":"jesseeproductions","id":8312466,"node_id":"MDQ6VXNlcjgzMTI0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/8312466?v=4","gravatar_id":"","url":"https://api.github.com/users/jesseeproductions","html_url":"https://github.com/jesseeproductions","followers_url":"https://api.github.com/users/jesseeproductions/followers","following_url":"https://api.github.com/users/jesseeproductions/following{/other_user}","gists_url":"https://api.github.com/users/jesseeproductions/gists{/gist_id}","starred_url":"https://api.github.com/users/jesseeproductions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesseeproductions/subscriptions","organizations_url":"https://api.github.com/users/jesseeproductions/orgs","repos_url":"https://api.github.com/users/jesseeproductions/repos","events_url":"https://api.github.com/users/jesseeproductions/events{/privacy}","received_events_url":"https://api.github.com/users/jesseeproductions/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1593522093,"node_id":"MDU6TGFiZWwxNTkzNTIyMDkz","url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/labels/code%20review","name":"code review","color":"bfe5bf","default":false,"description":""}],"milestone":{"url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/milestones/1","html_url":"https://github.com/mt-support/tribe-ext-hubspot/milestone/1","labels_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/milestones/1/labels","id":4733219,"node_id":"MDk6TWlsZXN0b25lNDczMzIxOQ==","number":1,"title":"HubSpot 1.0","description":null,"creator":{"login":"jesseeproductions","id":8312466,"node_id":"MDQ6VXNlcjgzMTI0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/8312466?v=4","gravatar_id":"","url":"https://api.github.com/users/jesseeproductions","html_url":"https://github.com/jesseeproductions","followers_url":"https://api.github.com/users/jesseeproductions/followers","following_url":"https://api.github.com/users/jesseeproductions/following{/other_user}","gists_url":"https://api.github.com/users/jesseeproductions/gists{/gist_id}","starred_url":"https://api.github.com/users/jesseeproductions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jesseeproductions/subscriptions","organizations_url":"https://api.github.com/users/jesseeproductions/orgs","repos_url":"https://api.github.com/users/jesseeproductions/repos","events_url":"https://api.github.com/users/jesseeproductions/events{/privacy}","received_events_url":"https://api.github.com/users/jesseeproductions/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":9,"state":"open","created_at":"2019-10-08T16:41:33Z","updated_at":"2019-11-22T17:42:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/pulls/13/commits","review_comments_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/pulls/13/comments","review_comment_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/issues/13/comments","statuses_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/statuses/e93e25cb777fc70f251ab71226a41dc163145151","head":{"label":"mt-support:feature/135919-rsvp-edd-tpp-contact-subscription","ref":"feature/135919-rsvp-edd-tpp-contact-subscription","sha":"e93e25cb777fc70f251ab71226a41dc163145151","user":{"login":"mt-support","id":34141340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTQxMzQw","avatar_url":"https://avatars1.githubusercontent.com/u/34141340?v=4","gravatar_id":"","url":"https://api.github.com/users/mt-support","html_url":"https://github.com/mt-support","followers_url":"https://api.github.com/users/mt-support/followers","following_url":"https://api.github.com/users/mt-support/following{/other_user}","gists_url":"https://api.github.com/users/mt-support/gists{/gist_id}","starred_url":"https://api.github.com/users/mt-support/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mt-support/subscriptions","organizations_url":"https://api.github.com/users/mt-support/orgs","repos_url":"https://api.github.com/users/mt-support/repos","events_url":"https://api.github.com/users/mt-support/events{/privacy}","received_events_url":"https://api.github.com/users/mt-support/received_events","type":"Organization","site_admin":false},"repo":{"id":212617183,"node_id":"MDEwOlJlcG9zaXRvcnkyMTI2MTcxODM=","name":"tribe-ext-hubspot","full_name":"mt-support/tribe-ext-hubspot","private":false,"owner":{"login":"mt-support","id":34141340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTQxMzQw","avatar_url":"https://avatars1.githubusercontent.com/u/34141340?v=4","gravatar_id":"","url":"https://api.github.com/users/mt-support","html_url":"https://github.com/mt-support","followers_url":"https://api.github.com/users/mt-support/followers","following_url":"https://api.github.com/users/mt-support/following{/other_user}","gists_url":"https://api.github.com/users/mt-support/gists{/gist_id}","starred_url":"https://api.github.com/users/mt-support/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mt-support/subscriptions","organizations_url":"https://api.github.com/users/mt-support/orgs","repos_url":"https://api.github.com/users/mt-support/repos","events_url":"https://api.github.com/users/mt-support/events{/privacy}","received_events_url":"https://api.github.com/users/mt-support/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mt-support/tribe-ext-hubspot","description":"HubSpot Extension for Event Tickets and Event Tickets Plus","fork":false,"url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot","forks_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/forks","keys_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/teams","hooks_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/hooks","issue_events_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/issues/events{/number}","events_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/events","assignees_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/assignees{/user}","branches_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/branches{/branch}","tags_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/tags","blobs_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/git/refs{/sha}","trees_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/statuses/{sha}","languages_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/languages","stargazers_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/stargazers","contributors_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/contributors","subscribers_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/subscribers","subscription_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/subscription","commits_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/commits{/sha}","git_commits_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/git/commits{/sha}","comments_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/comments{/number}","issue_comment_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/issues/comments{/number}","contents_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/contents/{+path}","compare_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/merges","archive_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/downloads","issues_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/issues{/number}","pulls_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/pulls{/number}","milestones_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/milestones{/number}","notifications_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/labels{/name}","releases_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/releases{/id}","deployments_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/deployments","created_at":"2019-10-03T15:44:27Z","updated_at":"2019-11-18T22:47:53Z","pushed_at":"2019-11-22T17:42:09Z","git_url":"git://github.com/mt-support/tribe-ext-hubspot.git","ssh_url":"[email protected]:mt-support/tribe-ext-hubspot.git","clone_url":"https://github.com/mt-support/tribe-ext-hubspot.git","svn_url":"https://github.com/mt-support/tribe-ext-hubspot","homepage":null,"size":269,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"mt-support:feature/137288-initial-authorization-queue","ref":"feature/137288-initial-authorization-queue","sha":"43993f4ebfb2a506dc413100862ad54f9914bab0","user":{"login":"mt-support","id":34141340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTQxMzQw","avatar_url":"https://avatars1.githubusercontent.com/u/34141340?v=4","gravatar_id":"","url":"https://api.github.com/users/mt-support","html_url":"https://github.com/mt-support","followers_url":"https://api.github.com/users/mt-support/followers","following_url":"https://api.github.com/users/mt-support/following{/other_user}","gists_url":"https://api.github.com/users/mt-support/gists{/gist_id}","starred_url":"https://api.github.com/users/mt-support/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mt-support/subscriptions","organizations_url":"https://api.github.com/users/mt-support/orgs","repos_url":"https://api.github.com/users/mt-support/repos","events_url":"https://api.github.com/users/mt-support/events{/privacy}","received_events_url":"https://api.github.com/users/mt-support/received_events","type":"Organization","site_admin":false},"repo":{"id":212617183,"node_id":"MDEwOlJlcG9zaXRvcnkyMTI2MTcxODM=","name":"tribe-ext-hubspot","full_name":"mt-support/tribe-ext-hubspot","private":false,"owner":{"login":"mt-support","id":34141340,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTQxMzQw","avatar_url":"https://avatars1.githubusercontent.com/u/34141340?v=4","gravatar_id":"","url":"https://api.github.com/users/mt-support","html_url":"https://github.com/mt-support","followers_url":"https://api.github.com/users/mt-support/followers","following_url":"https://api.github.com/users/mt-support/following{/other_user}","gists_url":"https://api.github.com/users/mt-support/gists{/gist_id}","starred_url":"https://api.github.com/users/mt-support/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mt-support/subscriptions","organizations_url":"https://api.github.com/users/mt-support/orgs","repos_url":"https://api.github.com/users/mt-support/repos","events_url":"https://api.github.com/users/mt-support/events{/privacy}","received_events_url":"https://api.github.com/users/mt-support/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mt-support/tribe-ext-hubspot","description":"HubSpot Extension for Event Tickets and Event Tickets Plus","fork":false,"url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot","forks_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/forks","keys_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/teams","hooks_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/hooks","issue_events_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/issues/events{/number}","events_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/events","assignees_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/assignees{/user}","branches_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/branches{/branch}","tags_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/tags","blobs_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/git/refs{/sha}","trees_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/statuses/{sha}","languages_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/languages","stargazers_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/stargazers","contributors_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/contributors","subscribers_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/subscribers","subscription_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/subscription","commits_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/commits{/sha}","git_commits_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/git/commits{/sha}","comments_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/comments{/number}","issue_comment_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/issues/comments{/number}","contents_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/contents/{+path}","compare_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/merges","archive_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/downloads","issues_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/issues{/number}","pulls_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/pulls{/number}","milestones_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/milestones{/number}","notifications_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/labels{/name}","releases_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/releases{/id}","deployments_url":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/deployments","created_at":"2019-10-03T15:44:27Z","updated_at":"2019-11-18T22:47:53Z","pushed_at":"2019-11-22T17:42:09Z","git_url":"git://github.com/mt-support/tribe-ext-hubspot.git","ssh_url":"[email protected]:mt-support/tribe-ext-hubspot.git","clone_url":"https://github.com/mt-support/tribe-ext-hubspot.git","svn_url":"https://github.com/mt-support/tribe-ext-hubspot","homepage":null,"size":269,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/pulls/13"},"html":{"href":"https://github.com/mt-support/tribe-ext-hubspot/pull/13"},"issue":{"href":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/issues/13"},"comments":{"href":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/mt-support/tribe-ext-hubspot/statuses/e93e25cb777fc70f251ab71226a41dc163145151"}},"author_association":"COLLABORATOR"}}	{ "id": 212617183, "name": "mt-support/tribe-ext-hubspot", "url": "https://api.github.com/repos/mt-support/tribe-ext-hubspot" }	{ "id": 709662, "login": "sc0ttkclark", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/709662?", "url": "https://api.github.com/users/sc0ttkclark" }	{ "id": 34141340, "login": "mt-support", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/34141340?", "url": "https://api.github.com/orgs/mt-support" }	2019-11-26T16:09:32	10952257972	{"actor":{"display_login":"sc0ttkclark"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/prestosql/presto/pulls/comments/360623143","pull_request_review_id":335583788,"id":360623143,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MDYyMzE0Mw==","diff_hunk":"@@ -377,16 +436,28 @@ public int getIndex()\n return regularColumnMappings.stream()\n .map(columnMapping -> {\n HiveColumnHandle columnHandle = columnMapping.getHiveColumnHandle();\n- if (!doCoercion \|\| !columnMapping.getCoercionFrom().isPresent()) {\n+ if (!doCoercion \|\| !columnMapping.getBaseTypeCoercionFrom().isPresent()) {\n return columnHandle;\n }\n+ HiveType fromHiveTypeBase = columnMapping.getBaseTypeCoercionFrom().get();\n+\n+ Optional<HiveColumnProjectionInfo> newColumnProjectionInfo = columnHandle.getHiveColumnProjectionInfo().map(projectedColumn -> {\n+ HiveType fromHiveType = fromHiveTypeBase.getHiveTypeForDereferences(projectedColumn.getDereferenceIndices()).get();","path":"presto-hive/src/main/java/io/prestosql/plugin/hive/HivePageSourceProvider.java","position":300,"original_position":306,"commit_id":"c7948599efb1d4ad2978b39bf28ff893711c02b9","original_commit_id":"4d4bda8b8b82dd1a92f9a807b42a54a030c51b30","user":{"login":"phd3","id":6829746,"node_id":"MDQ6VXNlcjY4Mjk3NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/6829746?v=4","gravatar_id":"","url":"https://api.github.com/users/phd3","html_url":"https://github.com/phd3","followers_url":"https://api.github.com/users/phd3/followers","following_url":"https://api.github.com/users/phd3/following{/other_user}","gists_url":"https://api.github.com/users/phd3/gists{/gist_id}","starred_url":"https://api.github.com/users/phd3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phd3/subscriptions","organizations_url":"https://api.github.com/users/phd3/orgs","repos_url":"https://api.github.com/users/phd3/repos","events_url":"https://api.github.com/users/phd3/events{/privacy}","received_events_url":"https://api.github.com/users/phd3/received_events","type":"User","site_admin":false},"body":"https://github.com/prestosql/presto/pull/1720#issuecomment-568143233","created_at":"2019-12-21T02:16:43Z","updated_at":"2019-12-21T02:16:43Z","html_url":"https://github.com/prestosql/presto/pull/1720#discussion_r360623143","pull_request_url":"https://api.github.com/repos/prestosql/presto/pulls/1720","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/prestosql/presto/pulls/comments/360623143"},"html":{"href":"https://github.com/prestosql/presto/pull/1720#discussion_r360623143"},"pull_request":{"href":"https://api.github.com/repos/prestosql/presto/pulls/1720"}},"in_reply_to_id":358521042},"pull_request":{"url":"https://api.github.com/repos/prestosql/presto/pulls/1720","id":327001930,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3MDAxOTMw","html_url":"https://github.com/prestosql/presto/pull/1720","diff_url":"https://github.com/prestosql/presto/pull/1720.diff","patch_url":"https://github.com/prestosql/presto/pull/1720.patch","issue_url":"https://api.github.com/repos/prestosql/presto/issues/1720","number":1720,"state":"open","locked":false,"title":"Dereference projections and predicate pushdown in Hive","user":{"login":"phd3","id":6829746,"node_id":"MDQ6VXNlcjY4Mjk3NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/6829746?v=4","gravatar_id":"","url":"https://api.github.com/users/phd3","html_url":"https://github.com/phd3","followers_url":"https://api.github.com/users/phd3/followers","following_url":"https://api.github.com/users/phd3/following{/other_user}","gists_url":"https://api.github.com/users/phd3/gists{/gist_id}","starred_url":"https://api.github.com/users/phd3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phd3/subscriptions","organizations_url":"https://api.github.com/users/phd3/orgs","repos_url":"https://api.github.com/users/phd3/repos","events_url":"https://api.github.com/users/phd3/events{/privacy}","received_events_url":"https://api.github.com/users/phd3/received_events","type":"User","site_admin":false},"body":"(required by #1953)\r\n\r\nThis PR includes the following major changes:\r\n\r\n1. Add support for projected columns in Hive\r\n\r\n* Page sources need to be supplied projected columns representing internal fields from a struct column. We modify `HiveColumnHandle` to include this information about column subfield access. Right now, the `HiveColumnProjectionInfo` simply stores a chain of dereferences, but that can later be extended to support other types of partial columns (eg. subscripts)\r\n\r\n* Internal page sources in Hive Connector may or may not be able to push down projected column reads, depending on the formats. Reader page sources or record cursor can provide the partial projections they'll apply, and the rest is \"adapted\" by the HivePageSource or HiveReaderProjectionsAdaptingRecordCursor.\r\n\r\n* By default, the readers only read base columns for projected columns. For example, column \"a\" will be read for a projection \"a.x\". This is implemented through `ReaderProjections#projectBaseColumns`\r\n\r\n2. Pushdown for Dereferences in Hive:\r\n\r\n* The goal is to pushdown dereference expressions to Hive Connector for projections and predicates both.\r\n\r\n* As described in #1953, creating partial column handles in `HiveMetadata#applyProjection` will give us both predicate and projection pushdown into Hive through iterative optimization. \r\n\r\n* `HiveMetadata#applyProjection` extracts longest simple dereference chains and variables from input expressions and provies new columnhandles for them. All the columnhandles returned by this method are unique.\r\n\r\n3. Projection and Predicate pushdown of subfields in Columnar Sources:\r\n\r\n* In case of Columnar formats (eg. ORC, Parquet), the partial columns can be read without reading entire columns, which is the primary motive here. \r\n\r\n* We implement p`rojectSufficientColumns` for such page sources to leverage, which lets the pagesource only read the required superset columns. Say we have a column C of type `RowType`. The query asks for a set of subcolumns S from column C. Then the superset columns here is the smallest set of columns from S such that all columns in S can be derived using identity or dereference expressions. i.e when S = {\"a.b.c\", \"a.d\" and \"a.b.c.x\"}, the reader will read create columns {\"a.b.c\", \"a.d\"}. The HivePageSource will adapt for \".x\" for the third column.\r\n\r\n* ORC pagesource has been changed to leverage this pushdown. Parquet change is not taken care of yet. \r\n","created_at":"2019-10-11T02:31:06Z","updated_at":"2019-12-21T02:16:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f876ee6c0e39b6d04b366090641b0a1d2364a194","assignee":{"login":"phd3","id":6829746,"node_id":"MDQ6VXNlcjY4Mjk3NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/6829746?v=4","gravatar_id":"","url":"https://api.github.com/users/phd3","html_url":"https://github.com/phd3","followers_url":"https://api.github.com/users/phd3/followers","following_url":"https://api.github.com/users/phd3/following{/other_user}","gists_url":"https://api.github.com/users/phd3/gists{/gist_id}","starred_url":"https://api.github.com/users/phd3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phd3/subscriptions","organizations_url":"https://api.github.com/users/phd3/orgs","repos_url":"https://api.github.com/users/phd3/repos","events_url":"https://api.github.com/users/phd3/events{/privacy}","received_events_url":"https://api.github.com/users/phd3/received_events","type":"User","site_admin":false},"assignees":[{"login":"phd3","id":6829746,"node_id":"MDQ6VXNlcjY4Mjk3NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/6829746?v=4","gravatar_id":"","url":"https://api.github.com/users/phd3","html_url":"https://github.com/phd3","followers_url":"https://api.github.com/users/phd3/followers","following_url":"https://api.github.com/users/phd3/following{/other_user}","gists_url":"https://api.github.com/users/phd3/gists{/gist_id}","starred_url":"https://api.github.com/users/phd3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phd3/subscriptions","organizations_url":"https://api.github.com/users/phd3/orgs","repos_url":"https://api.github.com/users/phd3/repos","events_url":"https://api.github.com/users/phd3/events{/privacy}","received_events_url":"https://api.github.com/users/phd3/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"wagnermarkd","id":1380466,"node_id":"MDQ6VXNlcjEzODA0NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1380466?v=4","gravatar_id":"","url":"https://api.github.com/users/wagnermarkd","html_url":"https://github.com/wagnermarkd","followers_url":"https://api.github.com/users/wagnermarkd/followers","following_url":"https://api.github.com/users/wagnermarkd/following{/other_user}","gists_url":"https://api.github.com/users/wagnermarkd/gists{/gist_id}","starred_url":"https://api.github.com/users/wagnermarkd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wagnermarkd/subscriptions","organizations_url":"https://api.github.com/users/wagnermarkd/orgs","repos_url":"https://api.github.com/users/wagnermarkd/repos","events_url":"https://api.github.com/users/wagnermarkd/events{/privacy}","received_events_url":"https://api.github.com/users/wagnermarkd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1202580151,"node_id":"MDU6TGFiZWwxMjAyNTgwMTUx","url":"https://api.github.com/repos/prestosql/presto/labels/cla-signed","name":"cla-signed","color":"ededed","default":false,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/prestosql/presto/pulls/1720/commits","review_comments_url":"https://api.github.com/repos/prestosql/presto/pulls/1720/comments","review_comment_url":"https://api.github.com/repos/prestosql/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestosql/presto/issues/1720/comments","statuses_url":"https://api.github.com/repos/prestosql/presto/statuses/c7948599efb1d4ad2978b39bf28ff893711c02b9","head":{"label":"phd3:hive-deref-pushdown","ref":"hive-deref-pushdown","sha":"c7948599efb1d4ad2978b39bf28ff893711c02b9","user":{"login":"phd3","id":6829746,"node_id":"MDQ6VXNlcjY4Mjk3NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/6829746?v=4","gravatar_id":"","url":"https://api.github.com/users/phd3","html_url":"https://github.com/phd3","followers_url":"https://api.github.com/users/phd3/followers","following_url":"https://api.github.com/users/phd3/following{/other_user}","gists_url":"https://api.github.com/users/phd3/gists{/gist_id}","starred_url":"https://api.github.com/users/phd3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phd3/subscriptions","organizations_url":"https://api.github.com/users/phd3/orgs","repos_url":"https://api.github.com/users/phd3/repos","events_url":"https://api.github.com/users/phd3/events{/privacy}","received_events_url":"https://api.github.com/users/phd3/received_events","type":"User","site_admin":false},"repo":{"id":184480879,"node_id":"MDEwOlJlcG9zaXRvcnkxODQ0ODA4Nzk=","name":"presto-1","full_name":"phd3/presto-1","private":false,"owner":{"login":"phd3","id":6829746,"node_id":"MDQ6VXNlcjY4Mjk3NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/6829746?v=4","gravatar_id":"","url":"https://api.github.com/users/phd3","html_url":"https://github.com/phd3","followers_url":"https://api.github.com/users/phd3/followers","following_url":"https://api.github.com/users/phd3/following{/other_user}","gists_url":"https://api.github.com/users/phd3/gists{/gist_id}","starred_url":"https://api.github.com/users/phd3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phd3/subscriptions","organizations_url":"https://api.github.com/users/phd3/orgs","repos_url":"https://api.github.com/users/phd3/repos","events_url":"https://api.github.com/users/phd3/events{/privacy}","received_events_url":"https://api.github.com/users/phd3/received_events","type":"User","site_admin":false},"html_url":"https://github.com/phd3/presto-1","description":"Official home of Presto, the distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/phd3/presto-1","forks_url":"https://api.github.com/repos/phd3/presto-1/forks","keys_url":"https://api.github.com/repos/phd3/presto-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phd3/presto-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phd3/presto-1/teams","hooks_url":"https://api.github.com/repos/phd3/presto-1/hooks","issue_events_url":"https://api.github.com/repos/phd3/presto-1/issues/events{/number}","events_url":"https://api.github.com/repos/phd3/presto-1/events","assignees_url":"https://api.github.com/repos/phd3/presto-1/assignees{/user}","branches_url":"https://api.github.com/repos/phd3/presto-1/branches{/branch}","tags_url":"https://api.github.com/repos/phd3/presto-1/tags","blobs_url":"https://api.github.com/repos/phd3/presto-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phd3/presto-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phd3/presto-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/phd3/presto-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phd3/presto-1/statuses/{sha}","languages_url":"https://api.github.com/repos/phd3/presto-1/languages","stargazers_url":"https://api.github.com/repos/phd3/presto-1/stargazers","contributors_url":"https://api.github.com/repos/phd3/presto-1/contributors","subscribers_url":"https://api.github.com/repos/phd3/presto-1/subscribers","subscription_url":"https://api.github.com/repos/phd3/presto-1/subscription","commits_url":"https://api.github.com/repos/phd3/presto-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/phd3/presto-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/phd3/presto-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/phd3/presto-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/phd3/presto-1/contents/{+path}","compare_url":"https://api.github.com/repos/phd3/presto-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phd3/presto-1/merges","archive_url":"https://api.github.com/repos/phd3/presto-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phd3/presto-1/downloads","issues_url":"https://api.github.com/repos/phd3/presto-1/issues{/number}","pulls_url":"https://api.github.com/repos/phd3/presto-1/pulls{/number}","milestones_url":"https://api.github.com/repos/phd3/presto-1/milestones{/number}","notifications_url":"https://api.github.com/repos/phd3/presto-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phd3/presto-1/labels{/name}","releases_url":"https://api.github.com/repos/phd3/presto-1/releases{/id}","deployments_url":"https://api.github.com/repos/phd3/presto-1/deployments","created_at":"2019-05-01T20:59:39Z","updated_at":"2019-08-27T16:56:54Z","pushed_at":"2019-12-21T01:28:51Z","git_url":"git://github.com/phd3/presto-1.git","ssh_url":"[email protected]:phd3/presto-1.git","clone_url":"https://github.com/phd3/presto-1.git","svn_url":"https://github.com/phd3/presto-1","homepage":"https://prestosql.io","size":85066,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestosql:master","ref":"master","sha":"d577b548c34b8448d7ece2a1e284de3193e03622","user":{"login":"prestosql","id":34147222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTQ3MjIy","avatar_url":"https://avatars3.githubusercontent.com/u/34147222?v=4","gravatar_id":"","url":"https://api.github.com/users/prestosql","html_url":"https://github.com/prestosql","followers_url":"https://api.github.com/users/prestosql/followers","following_url":"https://api.github.com/users/prestosql/following{/other_user}","gists_url":"https://api.github.com/users/prestosql/gists{/gist_id}","starred_url":"https://api.github.com/users/prestosql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestosql/subscriptions","organizations_url":"https://api.github.com/users/prestosql/orgs","repos_url":"https://api.github.com/users/prestosql/repos","events_url":"https://api.github.com/users/prestosql/events{/privacy}","received_events_url":"https://api.github.com/users/prestosql/received_events","type":"Organization","site_admin":false},"repo":{"id":166515022,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY1MTUwMjI=","name":"presto","full_name":"prestosql/presto","private":false,"owner":{"login":"prestosql","id":34147222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTQ3MjIy","avatar_url":"https://avatars3.githubusercontent.com/u/34147222?v=4","gravatar_id":"","url":"https://api.github.com/users/prestosql","html_url":"https://github.com/prestosql","followers_url":"https://api.github.com/users/prestosql/followers","following_url":"https://api.github.com/users/prestosql/following{/other_user}","gists_url":"https://api.github.com/users/prestosql/gists{/gist_id}","starred_url":"https://api.github.com/users/prestosql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestosql/subscriptions","organizations_url":"https://api.github.com/users/prestosql/orgs","repos_url":"https://api.github.com/users/prestosql/repos","events_url":"https://api.github.com/users/prestosql/events{/privacy}","received_events_url":"https://api.github.com/users/prestosql/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prestosql/presto","description":"Official home of the community managed version of Presto, the distributed SQL query engine for big data, under the auspices of the Presto Software Foundation.","fork":false,"url":"https://api.github.com/repos/prestosql/presto","forks_url":"https://api.github.com/repos/prestosql/presto/forks","keys_url":"https://api.github.com/repos/prestosql/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestosql/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestosql/presto/teams","hooks_url":"https://api.github.com/repos/prestosql/presto/hooks","issue_events_url":"https://api.github.com/repos/prestosql/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestosql/presto/events","assignees_url":"https://api.github.com/repos/prestosql/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestosql/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestosql/presto/tags","blobs_url":"https://api.github.com/repos/prestosql/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestosql/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestosql/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestosql/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestosql/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestosql/presto/languages","stargazers_url":"https://api.github.com/repos/prestosql/presto/stargazers","contributors_url":"https://api.github.com/repos/prestosql/presto/contributors","subscribers_url":"https://api.github.com/repos/prestosql/presto/subscribers","subscription_url":"https://api.github.com/repos/prestosql/presto/subscription","commits_url":"https://api.github.com/repos/prestosql/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestosql/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestosql/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestosql/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestosql/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestosql/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestosql/presto/merges","archive_url":"https://api.github.com/repos/prestosql/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestosql/presto/downloads","issues_url":"https://api.github.com/repos/prestosql/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestosql/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestosql/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestosql/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestosql/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestosql/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestosql/presto/deployments","created_at":"2019-01-19T06:38:14Z","updated_at":"2019-12-20T23:29:41Z","pushed_at":"2019-12-21T01:28:53Z","git_url":"git://github.com/prestosql/presto.git","ssh_url":"[email protected]:prestosql/presto.git","clone_url":"https://github.com/prestosql/presto.git","svn_url":"https://github.com/prestosql/presto","homepage":"https://prestosql.io","size":85003,"stargazers_count":790,"watchers_count":790,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":349,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":489,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":349,"open_issues":489,"watchers":790,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestosql/presto/pulls/1720"},"html":{"href":"https://github.com/prestosql/presto/pull/1720"},"issue":{"href":"https://api.github.com/repos/prestosql/presto/issues/1720"},"comments":{"href":"https://api.github.com/repos/prestosql/presto/issues/1720/comments"},"review_comments":{"href":"https://api.github.com/repos/prestosql/presto/pulls/1720/comments"},"review_comment":{"href":"https://api.github.com/repos/prestosql/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestosql/presto/pulls/1720/commits"},"statuses":{"href":"https://api.github.com/repos/prestosql/presto/statuses/c7948599efb1d4ad2978b39bf28ff893711c02b9"}},"author_association":"CONTRIBUTOR"}}	{ "id": 166515022, "name": "prestosql/presto", "url": "https://api.github.com/repos/prestosql/presto" }	{ "id": 6829746, "login": "phd3", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/6829746?", "url": "https://api.github.com/users/phd3" }	{ "id": 34147222, "login": "prestosql", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/34147222?", "url": "https://api.github.com/orgs/prestosql" }	2019-12-21T02:16:43	11139140089	{"actor":{"display_login":"phd3"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/prestosql/presto/pulls/comments/288487498","pull_request_review_id":243156433,"id":288487498,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4ODQ4NzQ5OA==","diff_hunk":"@@ -156,4 +157,14 @@ public Expression rewriteExtract(Extract node, Void context, ExpressionTreeRewri\n throw new UnsupportedOperationException(\"not yet implemented: \" + node.getField());\n }\n }\n+\n+ private static boolean isLiteral(Expression expression)\n+ {\n+ // Current IR has no way to represent typed constants, so it encodes them as Cast(Literal)\n+ if (expression instanceof Cast && ((Cast) expression).getExpression() instanceof Literal) {\n+ return true;","path":"presto-main/src/main/java/io/prestosql/sql/planner/iterative/rule/CanonicalizeExpressionRewriter.java","position":35,"original_position":35,"commit_id":"245bfd267d972b4dfc505483a22532e195ad4d4c","original_commit_id":"245bfd267d972b4dfc505483a22532e195ad4d4c","user":{"login":"findepi","id":144328,"node_id":"MDQ6VXNlcjE0NDMyOA==","avatar_url":"https://avatars0.githubusercontent.com/u/144328?v=4","gravatar_id":"","url":"https://api.github.com/users/findepi","html_url":"https://github.com/findepi","followers_url":"https://api.github.com/users/findepi/followers","following_url":"https://api.github.com/users/findepi/following{/other_user}","gists_url":"https://api.github.com/users/findepi/gists{/gist_id}","starred_url":"https://api.github.com/users/findepi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/findepi/subscriptions","organizations_url":"https://api.github.com/users/findepi/orgs","repos_url":"https://api.github.com/users/findepi/repos","events_url":"https://api.github.com/users/findepi/events{/privacy}","received_events_url":"https://api.github.com/users/findepi/received_events","type":"User","site_admin":false},"body":"Sure. Please expand your comment. `// Current IR has no way to represent typed constants, so it encodes them as Cast(Literal` sounds like these other cases are being overlooked, rather than consciously ignored.","created_at":"2019-05-29T09:59:00Z","updated_at":"2019-05-29T09:59:01Z","html_url":"https://github.com/prestosql/presto/pull/834#discussion_r288487498","pull_request_url":"https://api.github.com/repos/prestosql/presto/pulls/834","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/prestosql/presto/pulls/comments/288487498"},"html":{"href":"https://github.com/prestosql/presto/pull/834#discussion_r288487498"},"pull_request":{"href":"https://api.github.com/repos/prestosql/presto/pulls/834"}},"in_reply_to_id":288297075},"pull_request":{"url":"https://api.github.com/repos/prestosql/presto/pulls/834","id":282910279,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgyOTEwMjc5","html_url":"https://github.com/prestosql/presto/pull/834","diff_url":"https://github.com/prestosql/presto/pull/834.diff","patch_url":"https://github.com/prestosql/presto/pull/834.patch","issue_url":"https://api.github.com/repos/prestosql/presto/issues/834","number":834,"state":"open","locked":false,"title":"Canonicalize expressions involving typed literals","user":{"login":"martint","id":14387,"node_id":"MDQ6VXNlcjE0Mzg3","avatar_url":"https://avatars3.githubusercontent.com/u/14387?v=4","gravatar_id":"","url":"https://api.github.com/users/martint","html_url":"https://github.com/martint","followers_url":"https://api.github.com/users/martint/followers","following_url":"https://api.github.com/users/martint/following{/other_user}","gists_url":"https://api.github.com/users/martint/gists{/gist_id}","starred_url":"https://api.github.com/users/martint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martint/subscriptions","organizations_url":"https://api.github.com/users/martint/orgs","repos_url":"https://api.github.com/users/martint/repos","events_url":"https://api.github.com/users/martint/events{/privacy}","received_events_url":"https://api.github.com/users/martint/received_events","type":"User","site_admin":false},"body":"The current IR doesn't have a way to represent typed constants, so\r\nit encodes them as Cast(Literal). This change extends the canonicalization\r\nof comparison and arithmetic expressions to take that into account.","created_at":"2019-05-28T16:35:22Z","updated_at":"2019-05-29T09:59:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4bb09a794e421a24b8556c80ad7da8110d33f79","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1202580151,"node_id":"MDU6TGFiZWwxMjAyNTgwMTUx","url":"https://api.github.com/repos/prestosql/presto/labels/cla-signed","name":"cla-signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestosql/presto/pulls/834/commits","review_comments_url":"https://api.github.com/repos/prestosql/presto/pulls/834/comments","review_comment_url":"https://api.github.com/repos/prestosql/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestosql/presto/issues/834/comments","statuses_url":"https://api.github.com/repos/prestosql/presto/statuses/245bfd267d972b4dfc505483a22532e195ad4d4c","head":{"label":"martint:canonicalize","ref":"canonicalize","sha":"245bfd267d972b4dfc505483a22532e195ad4d4c","user":{"login":"martint","id":14387,"node_id":"MDQ6VXNlcjE0Mzg3","avatar_url":"https://avatars3.githubusercontent.com/u/14387?v=4","gravatar_id":"","url":"https://api.github.com/users/martint","html_url":"https://github.com/martint","followers_url":"https://api.github.com/users/martint/followers","following_url":"https://api.github.com/users/martint/following{/other_user}","gists_url":"https://api.github.com/users/martint/gists{/gist_id}","starred_url":"https://api.github.com/users/martint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martint/subscriptions","organizations_url":"https://api.github.com/users/martint/orgs","repos_url":"https://api.github.com/users/martint/repos","events_url":"https://api.github.com/users/martint/events{/privacy}","received_events_url":"https://api.github.com/users/martint/received_events","type":"User","site_admin":false},"repo":{"id":166516150,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY1MTYxNTA=","name":"presto","full_name":"martint/presto","private":false,"owner":{"login":"martint","id":14387,"node_id":"MDQ6VXNlcjE0Mzg3","avatar_url":"https://avatars3.githubusercontent.com/u/14387?v=4","gravatar_id":"","url":"https://api.github.com/users/martint","html_url":"https://github.com/martint","followers_url":"https://api.github.com/users/martint/followers","following_url":"https://api.github.com/users/martint/following{/other_user}","gists_url":"https://api.github.com/users/martint/gists{/gist_id}","starred_url":"https://api.github.com/users/martint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martint/subscriptions","organizations_url":"https://api.github.com/users/martint/orgs","repos_url":"https://api.github.com/users/martint/repos","events_url":"https://api.github.com/users/martint/events{/privacy}","received_events_url":"https://api.github.com/users/martint/received_events","type":"User","site_admin":false},"html_url":"https://github.com/martint/presto","description":"Distributed SQL query engine for big data ","fork":true,"url":"https://api.github.com/repos/martint/presto","forks_url":"https://api.github.com/repos/martint/presto/forks","keys_url":"https://api.github.com/repos/martint/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martint/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martint/presto/teams","hooks_url":"https://api.github.com/repos/martint/presto/hooks","issue_events_url":"https://api.github.com/repos/martint/presto/issues/events{/number}","events_url":"https://api.github.com/repos/martint/presto/events","assignees_url":"https://api.github.com/repos/martint/presto/assignees{/user}","branches_url":"https://api.github.com/repos/martint/presto/branches{/branch}","tags_url":"https://api.github.com/repos/martint/presto/tags","blobs_url":"https://api.github.com/repos/martint/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martint/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martint/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/martint/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martint/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/martint/presto/languages","stargazers_url":"https://api.github.com/repos/martint/presto/stargazers","contributors_url":"https://api.github.com/repos/martint/presto/contributors","subscribers_url":"https://api.github.com/repos/martint/presto/subscribers","subscription_url":"https://api.github.com/repos/martint/presto/subscription","commits_url":"https://api.github.com/repos/martint/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/martint/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/martint/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/martint/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/martint/presto/contents/{+path}","compare_url":"https://api.github.com/repos/martint/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martint/presto/merges","archive_url":"https://api.github.com/repos/martint/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martint/presto/downloads","issues_url":"https://api.github.com/repos/martint/presto/issues{/number}","pulls_url":"https://api.github.com/repos/martint/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/martint/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/martint/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martint/presto/labels{/name}","releases_url":"https://api.github.com/repos/martint/presto/releases{/id}","deployments_url":"https://api.github.com/repos/martint/presto/deployments","created_at":"2019-01-19T06:51:51Z","updated_at":"2019-05-14T14:35:02Z","pushed_at":"2019-05-29T06:01:26Z","git_url":"git://github.com/martint/presto.git","ssh_url":"[email protected]:martint/presto.git","clone_url":"https://github.com/martint/presto.git","svn_url":"https://github.com/martint/presto","homepage":"https://prestosql.io","size":76820,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestosql:master","ref":"master","sha":"d85eea45eae255ad5701006ecd3f10fa79947ec2","user":{"login":"prestosql","id":34147222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTQ3MjIy","avatar_url":"https://avatars3.githubusercontent.com/u/34147222?v=4","gravatar_id":"","url":"https://api.github.com/users/prestosql","html_url":"https://github.com/prestosql","followers_url":"https://api.github.com/users/prestosql/followers","following_url":"https://api.github.com/users/prestosql/following{/other_user}","gists_url":"https://api.github.com/users/prestosql/gists{/gist_id}","starred_url":"https://api.github.com/users/prestosql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestosql/subscriptions","organizations_url":"https://api.github.com/users/prestosql/orgs","repos_url":"https://api.github.com/users/prestosql/repos","events_url":"https://api.github.com/users/prestosql/events{/privacy}","received_events_url":"https://api.github.com/users/prestosql/received_events","type":"Organization","site_admin":false},"repo":{"id":166515022,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY1MTUwMjI=","name":"presto","full_name":"prestosql/presto","private":false,"owner":{"login":"prestosql","id":34147222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTQ3MjIy","avatar_url":"https://avatars3.githubusercontent.com/u/34147222?v=4","gravatar_id":"","url":"https://api.github.com/users/prestosql","html_url":"https://github.com/prestosql","followers_url":"https://api.github.com/users/prestosql/followers","following_url":"https://api.github.com/users/prestosql/following{/other_user}","gists_url":"https://api.github.com/users/prestosql/gists{/gist_id}","starred_url":"https://api.github.com/users/prestosql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestosql/subscriptions","organizations_url":"https://api.github.com/users/prestosql/orgs","repos_url":"https://api.github.com/users/prestosql/repos","events_url":"https://api.github.com/users/prestosql/events{/privacy}","received_events_url":"https://api.github.com/users/prestosql/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prestosql/presto","description":"Official home of Presto, the distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestosql/presto","forks_url":"https://api.github.com/repos/prestosql/presto/forks","keys_url":"https://api.github.com/repos/prestosql/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestosql/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestosql/presto/teams","hooks_url":"https://api.github.com/repos/prestosql/presto/hooks","issue_events_url":"https://api.github.com/repos/prestosql/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestosql/presto/events","assignees_url":"https://api.github.com/repos/prestosql/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestosql/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestosql/presto/tags","blobs_url":"https://api.github.com/repos/prestosql/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestosql/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestosql/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestosql/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestosql/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestosql/presto/languages","stargazers_url":"https://api.github.com/repos/prestosql/presto/stargazers","contributors_url":"https://api.github.com/repos/prestosql/presto/contributors","subscribers_url":"https://api.github.com/repos/prestosql/presto/subscribers","subscription_url":"https://api.github.com/repos/prestosql/presto/subscription","commits_url":"https://api.github.com/repos/prestosql/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestosql/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestosql/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestosql/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestosql/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestosql/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestosql/presto/merges","archive_url":"https://api.github.com/repos/prestosql/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestosql/presto/downloads","issues_url":"https://api.github.com/repos/prestosql/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestosql/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestosql/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestosql/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestosql/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestosql/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestosql/presto/deployments","created_at":"2019-01-19T06:38:14Z","updated_at":"2019-05-29T09:56:50Z","pushed_at":"2019-05-29T09:56:39Z","git_url":"git://github.com/prestosql/presto.git","ssh_url":"[email protected]:prestosql/presto.git","clone_url":"https://github.com/prestosql/presto.git","svn_url":"https://github.com/prestosql/presto","homepage":"https://prestosql.io","size":76914,"stargazers_count":393,"watchers_count":393,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":164,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":200,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":164,"open_issues":200,"watchers":393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestosql/presto/pulls/834"},"html":{"href":"https://github.com/prestosql/presto/pull/834"},"issue":{"href":"https://api.github.com/repos/prestosql/presto/issues/834"},"comments":{"href":"https://api.github.com/repos/prestosql/presto/issues/834/comments"},"review_comments":{"href":"https://api.github.com/repos/prestosql/presto/pulls/834/comments"},"review_comment":{"href":"https://api.github.com/repos/prestosql/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestosql/presto/pulls/834/commits"},"statuses":{"href":"https://api.github.com/repos/prestosql/presto/statuses/245bfd267d972b4dfc505483a22532e195ad4d4c"}},"author_association":"MEMBER"}}	{ "id": 166515022, "name": "prestosql/presto", "url": "https://api.github.com/repos/prestosql/presto" }	{ "id": 144328, "login": "findepi", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/144328?", "url": "https://api.github.com/users/findepi" }	{ "id": 34147222, "login": "prestosql", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/34147222?", "url": "https://api.github.com/orgs/prestosql" }	2019-05-29T09:59:00	9717783284	{"actor":{"display_login":"findepi"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/prestosql/presto/pulls/comments/332820915","pull_request_review_id":299159990,"id":332820915,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMjgyMDkxNQ==","diff_hunk":"@@ -849,4 +859,59 @@ private static String typedNull(String prestoType)\n {\n return format(\"CAST(NULL AS %s)\", prestoType);\n }\n+\n+ private static List<ColumnInfo> getDescribeOutputColumnInfoList(ResultSet resultSet)\n+ throws SQLException\n+ {\n+ ImmutableList.Builder<ColumnInfo> list = ImmutableList.builder();\n+ while (resultSet.next()) {\n+ String columnName = resultSet.getString(\"Column Name\");\n+ String catalog = resultSet.getString(\"Catalog\");\n+ String schema = resultSet.getString(\"Schema\");\n+ String table = resultSet.getString(\"Table\");\n+ ClientTypeSignature clientTypeSignature = getClientTypeSignatureFromTypeString(resultSet.getString(\"Type\"));\n+ ColumnInfo.Builder builder = new ColumnInfo.Builder()\n+ .setColumnName(columnName)\n+ .setColumnLabel(columnName)\n+ .setCatalogName(catalog)\n+ .setSchemaName(schema)\n+ .setTableName(table)\n+ .setColumnTypeSignature(clientTypeSignature)\n+ .setNullable(ColumnInfo.Nullable.UNKNOWN);\n+ setTypeInfo(builder, clientTypeSignature);\n+ list.add(builder.build());\n+ }\n+ return list.build();\n+ }\n+\n+ private static ClientTypeSignature getClientTypeSignatureFromTypeString(String type)\n+ {\n+ String topLevelTypeRegexPattern = \"^(.+?)\\\$(.+)\\\$$\";\n+ Pattern pattern = Pattern.compile(topLevelTypeRegexPattern);\n+ Matcher matcher = pattern.matcher(type);\n+ String topLevelType;\n+ List<ClientTypeSignatureParameter> arguments = new ArrayList<>();\n+ if (matcher.find()) {\n+ topLevelType = matcher.group(1);\n+ String typeParameters = matcher.group(2);\n+ if (topLevelType.equals(\"decimal\")) {\n+ String[] precisionAndScaleArray = typeParameters.split(\",\");\n+ long precision = Long.parseLong(precisionAndScaleArray[0]);\n+ arguments.add(ClientTypeSignatureParameter.ofLong(precision));\n+ long scale = Long.parseLong(precisionAndScaleArray[1]);\n+ arguments.add(ClientTypeSignatureParameter.ofLong(scale));\n+ }\n+ else if (topLevelType.equals(\"char\") \|\| topLevelType.equals(\"varchar\")) {\n+ long precision = Long.parseLong(typeParameters);\n+ arguments.add(new ClientTypeSignatureParameter(ParameterKind.LONG, precision));\n+ }\n+ }\n+ else {\n+ topLevelType = type;\n+ if (topLevelType.equals(\"varchar\")) {\n+ arguments.add(new ClientTypeSignatureParameter(ParameterKind.LONG, (long) Integer.MAX_VALUE));","path":"presto-jdbc/src/main/java/io/prestosql/jdbc/PrestoPreparedStatement.java","position":97,"original_position":97,"commit_id":"836846e244ef59b877b8d6b5bbdef3135edee0a8","original_commit_id":"836846e244ef59b877b8d6b5bbdef3135edee0a8","user":{"login":"ebyhr","id":6237050,"node_id":"MDQ6VXNlcjYyMzcwNTA=","avatar_url":"https://avatars2.githubusercontent.com/u/6237050?v=4","gravatar_id":"","url":"https://api.github.com/users/ebyhr","html_url":"https://github.com/ebyhr","followers_url":"https://api.github.com/users/ebyhr/followers","following_url":"https://api.github.com/users/ebyhr/following{/other_user}","gists_url":"https://api.github.com/users/ebyhr/gists{/gist_id}","starred_url":"https://api.github.com/users/ebyhr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebyhr/subscriptions","organizations_url":"https://api.github.com/users/ebyhr/orgs","repos_url":"https://api.github.com/users/ebyhr/repos","events_url":"https://api.github.com/users/ebyhr/events{/privacy}","received_events_url":"https://api.github.com/users/ebyhr/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n arguments.add(ClientTypeSignatureParameter.ofLong(Integer.MAX_VALUE));\r\n```","created_at":"2019-10-09T04:02:32Z","updated_at":"2019-10-09T04:02:33Z","html_url":"https://github.com/prestosql/presto/pull/1656#discussion_r332820915","pull_request_url":"https://api.github.com/repos/prestosql/presto/pulls/1656","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/prestosql/presto/pulls/comments/332820915"},"html":{"href":"https://github.com/prestosql/presto/pull/1656#discussion_r332820915"},"pull_request":{"href":"https://api.github.com/repos/prestosql/presto/pulls/1656"}}},"pull_request":{"url":"https://api.github.com/repos/prestosql/presto/pulls/1656","id":324037637,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI0MDM3NjM3","html_url":"https://github.com/prestosql/presto/pull/1656","diff_url":"https://github.com/prestosql/presto/pull/1656.diff","patch_url":"https://github.com/prestosql/presto/pull/1656.patch","issue_url":"https://api.github.com/repos/prestosql/presto/issues/1656","number":1656,"state":"open","locked":false,"title":"Implement JDBC PreparedStatement.getMetaData","user":{"login":"Terry93","id":8072956,"node_id":"MDQ6VXNlcjgwNzI5NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/8072956?v=4","gravatar_id":"","url":"https://api.github.com/users/Terry93","html_url":"https://github.com/Terry93","followers_url":"https://api.github.com/users/Terry93/followers","following_url":"https://api.github.com/users/Terry93/following{/other_user}","gists_url":"https://api.github.com/users/Terry93/gists{/gist_id}","starred_url":"https://api.github.com/users/Terry93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Terry93/subscriptions","organizations_url":"https://api.github.com/users/Terry93/orgs","repos_url":"https://api.github.com/users/Terry93/repos","events_url":"https://api.github.com/users/Terry93/events{/privacy}","received_events_url":"https://api.github.com/users/Terry93/received_events","type":"User","site_admin":false},"body":"Please help review and leave comments if I did anything thing not appropriate or not following the best practice (especially I might not do a very well-cover unit test, so feel free to point out).\r\n\r\nAlso per [DESCRIBE OUTPUT](https://prestosql.io/docs/current/sql/describe-output.html), we should also incorporate information such as `Type Size` and `Aliased`?","created_at":"2019-10-03T04:25:42Z","updated_at":"2019-10-09T04:02:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"177d29aa7146fd4dab34563b5b155559e89fc5e7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1202580151,"node_id":"MDU6TGFiZWwxMjAyNTgwMTUx","url":"https://api.github.com/repos/prestosql/presto/labels/cla-signed","name":"cla-signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestosql/presto/pulls/1656/commits","review_comments_url":"https://api.github.com/repos/prestosql/presto/pulls/1656/comments","review_comment_url":"https://api.github.com/repos/prestosql/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestosql/presto/issues/1656/comments","statuses_url":"https://api.github.com/repos/prestosql/presto/statuses/836846e244ef59b877b8d6b5bbdef3135edee0a8","head":{"label":"Terry93:jdbc-describe-output","ref":"jdbc-describe-output","sha":"836846e244ef59b877b8d6b5bbdef3135edee0a8","user":{"login":"Terry93","id":8072956,"node_id":"MDQ6VXNlcjgwNzI5NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/8072956?v=4","gravatar_id":"","url":"https://api.github.com/users/Terry93","html_url":"https://github.com/Terry93","followers_url":"https://api.github.com/users/Terry93/followers","following_url":"https://api.github.com/users/Terry93/following{/other_user}","gists_url":"https://api.github.com/users/Terry93/gists{/gist_id}","starred_url":"https://api.github.com/users/Terry93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Terry93/subscriptions","organizations_url":"https://api.github.com/users/Terry93/orgs","repos_url":"https://api.github.com/users/Terry93/repos","events_url":"https://api.github.com/users/Terry93/events{/privacy}","received_events_url":"https://api.github.com/users/Terry93/received_events","type":"User","site_admin":false},"repo":{"id":210724824,"node_id":"MDEwOlJlcG9zaXRvcnkyMTA3MjQ4MjQ=","name":"presto","full_name":"Terry93/presto","private":false,"owner":{"login":"Terry93","id":8072956,"node_id":"MDQ6VXNlcjgwNzI5NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/8072956?v=4","gravatar_id":"","url":"https://api.github.com/users/Terry93","html_url":"https://github.com/Terry93","followers_url":"https://api.github.com/users/Terry93/followers","following_url":"https://api.github.com/users/Terry93/following{/other_user}","gists_url":"https://api.github.com/users/Terry93/gists{/gist_id}","starred_url":"https://api.github.com/users/Terry93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Terry93/subscriptions","organizations_url":"https://api.github.com/users/Terry93/orgs","repos_url":"https://api.github.com/users/Terry93/repos","events_url":"https://api.github.com/users/Terry93/events{/privacy}","received_events_url":"https://api.github.com/users/Terry93/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Terry93/presto","description":"Official home of the community managed version of Presto, the distributed SQL query engine for big data, under the auspices of the Presto Software Foundation.","fork":true,"url":"https://api.github.com/repos/Terry93/presto","forks_url":"https://api.github.com/repos/Terry93/presto/forks","keys_url":"https://api.github.com/repos/Terry93/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Terry93/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Terry93/presto/teams","hooks_url":"https://api.github.com/repos/Terry93/presto/hooks","issue_events_url":"https://api.github.com/repos/Terry93/presto/issues/events{/number}","events_url":"https://api.github.com/repos/Terry93/presto/events","assignees_url":"https://api.github.com/repos/Terry93/presto/assignees{/user}","branches_url":"https://api.github.com/repos/Terry93/presto/branches{/branch}","tags_url":"https://api.github.com/repos/Terry93/presto/tags","blobs_url":"https://api.github.com/repos/Terry93/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Terry93/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Terry93/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/Terry93/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Terry93/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/Terry93/presto/languages","stargazers_url":"https://api.github.com/repos/Terry93/presto/stargazers","contributors_url":"https://api.github.com/repos/Terry93/presto/contributors","subscribers_url":"https://api.github.com/repos/Terry93/presto/subscribers","subscription_url":"https://api.github.com/repos/Terry93/presto/subscription","commits_url":"https://api.github.com/repos/Terry93/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/Terry93/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/Terry93/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/Terry93/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/Terry93/presto/contents/{+path}","compare_url":"https://api.github.com/repos/Terry93/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Terry93/presto/merges","archive_url":"https://api.github.com/repos/Terry93/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Terry93/presto/downloads","issues_url":"https://api.github.com/repos/Terry93/presto/issues{/number}","pulls_url":"https://api.github.com/repos/Terry93/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/Terry93/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/Terry93/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Terry93/presto/labels{/name}","releases_url":"https://api.github.com/repos/Terry93/presto/releases{/id}","deployments_url":"https://api.github.com/repos/Terry93/presto/deployments","created_at":"2019-09-25T00:53:45Z","updated_at":"2019-10-03T01:42:01Z","pushed_at":"2019-10-09T00:54:42Z","git_url":"git://github.com/Terry93/presto.git","ssh_url":"[email protected]:Terry93/presto.git","clone_url":"https://github.com/Terry93/presto.git","svn_url":"https://github.com/Terry93/presto","homepage":"https://prestosql.io","size":80922,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestosql:master","ref":"master","sha":"7db98e68d84387b1e6e1a0c36336884802f12d58","user":{"login":"prestosql","id":34147222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTQ3MjIy","avatar_url":"https://avatars3.githubusercontent.com/u/34147222?v=4","gravatar_id":"","url":"https://api.github.com/users/prestosql","html_url":"https://github.com/prestosql","followers_url":"https://api.github.com/users/prestosql/followers","following_url":"https://api.github.com/users/prestosql/following{/other_user}","gists_url":"https://api.github.com/users/prestosql/gists{/gist_id}","starred_url":"https://api.github.com/users/prestosql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestosql/subscriptions","organizations_url":"https://api.github.com/users/prestosql/orgs","repos_url":"https://api.github.com/users/prestosql/repos","events_url":"https://api.github.com/users/prestosql/events{/privacy}","received_events_url":"https://api.github.com/users/prestosql/received_events","type":"Organization","site_admin":false},"repo":{"id":166515022,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY1MTUwMjI=","name":"presto","full_name":"prestosql/presto","private":false,"owner":{"login":"prestosql","id":34147222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTQ3MjIy","avatar_url":"https://avatars3.githubusercontent.com/u/34147222?v=4","gravatar_id":"","url":"https://api.github.com/users/prestosql","html_url":"https://github.com/prestosql","followers_url":"https://api.github.com/users/prestosql/followers","following_url":"https://api.github.com/users/prestosql/following{/other_user}","gists_url":"https://api.github.com/users/prestosql/gists{/gist_id}","starred_url":"https://api.github.com/users/prestosql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestosql/subscriptions","organizations_url":"https://api.github.com/users/prestosql/orgs","repos_url":"https://api.github.com/users/prestosql/repos","events_url":"https://api.github.com/users/prestosql/events{/privacy}","received_events_url":"https://api.github.com/users/prestosql/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prestosql/presto","description":"Official home of the community managed version of Presto, the distributed SQL query engine for big data, under the auspices of the Presto Software Foundation.","fork":false,"url":"https://api.github.com/repos/prestosql/presto","forks_url":"https://api.github.com/repos/prestosql/presto/forks","keys_url":"https://api.github.com/repos/prestosql/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestosql/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestosql/presto/teams","hooks_url":"https://api.github.com/repos/prestosql/presto/hooks","issue_events_url":"https://api.github.com/repos/prestosql/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestosql/presto/events","assignees_url":"https://api.github.com/repos/prestosql/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestosql/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestosql/presto/tags","blobs_url":"https://api.github.com/repos/prestosql/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestosql/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestosql/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestosql/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestosql/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestosql/presto/languages","stargazers_url":"https://api.github.com/repos/prestosql/presto/stargazers","contributors_url":"https://api.github.com/repos/prestosql/presto/contributors","subscribers_url":"https://api.github.com/repos/prestosql/presto/subscribers","subscription_url":"https://api.github.com/repos/prestosql/presto/subscription","commits_url":"https://api.github.com/repos/prestosql/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestosql/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestosql/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestosql/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestosql/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestosql/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestosql/presto/merges","archive_url":"https://api.github.com/repos/prestosql/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestosql/presto/downloads","issues_url":"https://api.github.com/repos/prestosql/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestosql/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestosql/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestosql/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestosql/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestosql/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestosql/presto/deployments","created_at":"2019-01-19T06:38:14Z","updated_at":"2019-10-09T02:56:18Z","pushed_at":"2019-10-09T02:56:16Z","git_url":"git://github.com/prestosql/presto.git","ssh_url":"[email protected]:prestosql/presto.git","clone_url":"https://github.com/prestosql/presto.git","svn_url":"https://github.com/prestosql/presto","homepage":"https://prestosql.io","size":81083,"stargazers_count":646,"watchers_count":646,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":263,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":373,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":263,"open_issues":373,"watchers":646,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestosql/presto/pulls/1656"},"html":{"href":"https://github.com/prestosql/presto/pull/1656"},"issue":{"href":"https://api.github.com/repos/prestosql/presto/issues/1656"},"comments":{"href":"https://api.github.com/repos/prestosql/presto/issues/1656/comments"},"review_comments":{"href":"https://api.github.com/repos/prestosql/presto/pulls/1656/comments"},"review_comment":{"href":"https://api.github.com/repos/prestosql/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestosql/presto/pulls/1656/commits"},"statuses":{"href":"https://api.github.com/repos/prestosql/presto/statuses/836846e244ef59b877b8d6b5bbdef3135edee0a8"}},"author_association":"NONE"}}	{ "id": 166515022, "name": "prestosql/presto", "url": "https://api.github.com/repos/prestosql/presto" }	{ "id": 6237050, "login": "ebyhr", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/6237050?", "url": "https://api.github.com/users/ebyhr" }	{ "id": 34147222, "login": "prestosql", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/34147222?", "url": "https://api.github.com/orgs/prestosql" }	2019-10-09T04:02:32	10588933389	{"actor":{"display_login":"ebyhr"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/iotexproject/iotex-election/pulls/comments/285700281","pull_request_review_id":239636798,"id":285700281,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NTcwMDI4MQ==","diff_hunk":"@@ -243,6 +235,27 @@ func (ec committee) Status() STATUS {\n \t}\n }\n \n+func (ec committee) SyncInSplit(tipHeight uint64) error {","path":"committee/committee.go","position":30,"original_position":30,"commit_id":"5a2c356bb89251b2cdc9263fd29ca4e622c02c71","original_commit_id":"5a2c356bb89251b2cdc9263fd29ca4e622c02c71","user":{"login":"zjshen14","id":35021395,"node_id":"MDQ6VXNlcjM1MDIxMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/35021395?v=4","gravatar_id":"","url":"https://api.github.com/users/zjshen14","html_url":"https://github.com/zjshen14","followers_url":"https://api.github.com/users/zjshen14/followers","following_url":"https://api.github.com/users/zjshen14/following{/other_user}","gists_url":"https://api.github.com/users/zjshen14/gists{/gist_id}","starred_url":"https://api.github.com/users/zjshen14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjshen14/subscriptions","organizations_url":"https://api.github.com/users/zjshen14/orgs","repos_url":"https://api.github.com/users/zjshen14/repos","events_url":"https://api.github.com/users/zjshen14/events{/privacy}","received_events_url":"https://api.github.com/users/zjshen14/received_events","type":"User","site_admin":false},"body":"SyncInBatch","created_at":"2019-05-20T17:43:36Z","updated_at":"2019-05-20T17:47:49Z","html_url":"https://github.com/iotexproject/iotex-election/pull/71#discussion_r285700281","pull_request_url":"https://api.github.com/repos/iotexproject/iotex-election/pulls/71","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/iotexproject/iotex-election/pulls/comments/285700281"},"html":{"href":"https://github.com/iotexproject/iotex-election/pull/71#discussion_r285700281"},"pull_request":{"href":"https://api.github.com/repos/iotexproject/iotex-election/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/iotexproject/iotex-election/pulls/71","id":280066618,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgwMDY2NjE4","html_url":"https://github.com/iotexproject/iotex-election/pull/71","diff_url":"https://github.com/iotexproject/iotex-election/pull/71.diff","patch_url":"https://github.com/iotexproject/iotex-election/pull/71.patch","issue_url":"https://api.github.com/repos/iotexproject/iotex-election/issues/71","number":71,"state":"open","locked":false,"title":"Move fetch result from ethereum out of start lifecyle #70","user":{"login":"lzxm160","id":5837417,"node_id":"MDQ6VXNlcjU4Mzc0MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5837417?v=4","gravatar_id":"","url":"https://api.github.com/users/lzxm160","html_url":"https://github.com/lzxm160","followers_url":"https://api.github.com/users/lzxm160/followers","following_url":"https://api.github.com/users/lzxm160/following{/other_user}","gists_url":"https://api.github.com/users/lzxm160/gists{/gist_id}","starred_url":"https://api.github.com/users/lzxm160/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzxm160/subscriptions","organizations_url":"https://api.github.com/users/lzxm160/orgs","repos_url":"https://api.github.com/users/lzxm160/repos","events_url":"https://api.github.com/users/lzxm160/events{/privacy}","received_events_url":"https://api.github.com/users/lzxm160/received_events","type":"User","site_admin":false},"body":"work on #70 \r\n1、Avoid fetching and storing eth data in Start() to unblock blockchain server start earlier\r\n2、Replacing batchFetch + batchStore with batchFetchAndStore to improve data availability latency\r\nAvoid lock as much as possible to avoid blocking read APIs","created_at":"2019-05-18T00:49:52Z","updated_at":"2019-05-20T17:47:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0f1e5c0b0681855ad86805cddf53d8a11bc1fef","assignee":null,"assignees":[],"requested_reviewers":[{"login":"CoderZhi","id":35643171,"node_id":"MDQ6VXNlcjM1NjQzMTcx","avatar_url":"https://avatars2.githubusercontent.com/u/35643171?v=4","gravatar_id":"","url":"https://api.github.com/users/CoderZhi","html_url":"https://github.com/CoderZhi","followers_url":"https://api.github.com/users/CoderZhi/followers","following_url":"https://api.github.com/users/CoderZhi/following{/other_user}","gists_url":"https://api.github.com/users/CoderZhi/gists{/gist_id}","starred_url":"https://api.github.com/users/CoderZhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoderZhi/subscriptions","organizations_url":"https://api.github.com/users/CoderZhi/orgs","repos_url":"https://api.github.com/users/CoderZhi/repos","events_url":"https://api.github.com/users/CoderZhi/events{/privacy}","received_events_url":"https://api.github.com/users/CoderZhi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iotexproject/iotex-election/pulls/71/commits","review_comments_url":"https://api.github.com/repos/iotexproject/iotex-election/pulls/71/comments","review_comment_url":"https://api.github.com/repos/iotexproject/iotex-election/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iotexproject/iotex-election/issues/71/comments","statuses_url":"https://api.github.com/repos/iotexproject/iotex-election/statuses/5a2c356bb89251b2cdc9263fd29ca4e622c02c71","head":{"label":"lzxm160:702","ref":"702","sha":"5a2c356bb89251b2cdc9263fd29ca4e622c02c71","user":{"login":"lzxm160","id":5837417,"node_id":"MDQ6VXNlcjU4Mzc0MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5837417?v=4","gravatar_id":"","url":"https://api.github.com/users/lzxm160","html_url":"https://github.com/lzxm160","followers_url":"https://api.github.com/users/lzxm160/followers","following_url":"https://api.github.com/users/lzxm160/following{/other_user}","gists_url":"https://api.github.com/users/lzxm160/gists{/gist_id}","starred_url":"https://api.github.com/users/lzxm160/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzxm160/subscriptions","organizations_url":"https://api.github.com/users/lzxm160/orgs","repos_url":"https://api.github.com/users/lzxm160/repos","events_url":"https://api.github.com/users/lzxm160/events{/privacy}","received_events_url":"https://api.github.com/users/lzxm160/received_events","type":"User","site_admin":false},"repo":{"id":185729775,"node_id":"MDEwOlJlcG9zaXRvcnkxODU3Mjk3NzU=","name":"iotex-election","full_name":"lzxm160/iotex-election","private":false,"owner":{"login":"lzxm160","id":5837417,"node_id":"MDQ6VXNlcjU4Mzc0MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5837417?v=4","gravatar_id":"","url":"https://api.github.com/users/lzxm160","html_url":"https://github.com/lzxm160","followers_url":"https://api.github.com/users/lzxm160/followers","following_url":"https://api.github.com/users/lzxm160/following{/other_user}","gists_url":"https://api.github.com/users/lzxm160/gists{/gist_id}","starred_url":"https://api.github.com/users/lzxm160/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzxm160/subscriptions","organizations_url":"https://api.github.com/users/lzxm160/orgs","repos_url":"https://api.github.com/users/lzxm160/repos","events_url":"https://api.github.com/users/lzxm160/events{/privacy}","received_events_url":"https://api.github.com/users/lzxm160/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lzxm160/iotex-election","description":"The Ethereum-to-IoTeX Bridge that syncs smart contract states to IoTeX blockchain","fork":true,"url":"https://api.github.com/repos/lzxm160/iotex-election","forks_url":"https://api.github.com/repos/lzxm160/iotex-election/forks","keys_url":"https://api.github.com/repos/lzxm160/iotex-election/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lzxm160/iotex-election/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lzxm160/iotex-election/teams","hooks_url":"https://api.github.com/repos/lzxm160/iotex-election/hooks","issue_events_url":"https://api.github.com/repos/lzxm160/iotex-election/issues/events{/number}","events_url":"https://api.github.com/repos/lzxm160/iotex-election/events","assignees_url":"https://api.github.com/repos/lzxm160/iotex-election/assignees{/user}","branches_url":"https://api.github.com/repos/lzxm160/iotex-election/branches{/branch}","tags_url":"https://api.github.com/repos/lzxm160/iotex-election/tags","blobs_url":"https://api.github.com/repos/lzxm160/iotex-election/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lzxm160/iotex-election/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lzxm160/iotex-election/git/refs{/sha}","trees_url":"https://api.github.com/repos/lzxm160/iotex-election/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lzxm160/iotex-election/statuses/{sha}","languages_url":"https://api.github.com/repos/lzxm160/iotex-election/languages","stargazers_url":"https://api.github.com/repos/lzxm160/iotex-election/stargazers","contributors_url":"https://api.github.com/repos/lzxm160/iotex-election/contributors","subscribers_url":"https://api.github.com/repos/lzxm160/iotex-election/subscribers","subscription_url":"https://api.github.com/repos/lzxm160/iotex-election/subscription","commits_url":"https://api.github.com/repos/lzxm160/iotex-election/commits{/sha}","git_commits_url":"https://api.github.com/repos/lzxm160/iotex-election/git/commits{/sha}","comments_url":"https://api.github.com/repos/lzxm160/iotex-election/comments{/number}","issue_comment_url":"https://api.github.com/repos/lzxm160/iotex-election/issues/comments{/number}","contents_url":"https://api.github.com/repos/lzxm160/iotex-election/contents/{+path}","compare_url":"https://api.github.com/repos/lzxm160/iotex-election/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lzxm160/iotex-election/merges","archive_url":"https://api.github.com/repos/lzxm160/iotex-election/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lzxm160/iotex-election/downloads","issues_url":"https://api.github.com/repos/lzxm160/iotex-election/issues{/number}","pulls_url":"https://api.github.com/repos/lzxm160/iotex-election/pulls{/number}","milestones_url":"https://api.github.com/repos/lzxm160/iotex-election/milestones{/number}","notifications_url":"https://api.github.com/repos/lzxm160/iotex-election/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lzxm160/iotex-election/labels{/name}","releases_url":"https://api.github.com/repos/lzxm160/iotex-election/releases{/id}","deployments_url":"https://api.github.com/repos/lzxm160/iotex-election/deployments","created_at":"2019-05-09T05:06:37Z","updated_at":"2019-05-18T00:12:27Z","pushed_at":"2019-05-18T00:48:25Z","git_url":"git://github.com/lzxm160/iotex-election.git","ssh_url":"[email protected]:lzxm160/iotex-election.git","clone_url":"https://github.com/lzxm160/iotex-election.git","svn_url":"https://github.com/lzxm160/iotex-election","homepage":"https://iotex.io","size":10409,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iotexproject:master","ref":"master","sha":"94dece6692b327b2df32934b0fe5b7667ef63d0a","user":{"login":"iotexproject","id":34317526,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzE3NTI2","avatar_url":"https://avatars3.githubusercontent.com/u/34317526?v=4","gravatar_id":"","url":"https://api.github.com/users/iotexproject","html_url":"https://github.com/iotexproject","followers_url":"https://api.github.com/users/iotexproject/followers","following_url":"https://api.github.com/users/iotexproject/following{/other_user}","gists_url":"https://api.github.com/users/iotexproject/gists{/gist_id}","starred_url":"https://api.github.com/users/iotexproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotexproject/subscriptions","organizations_url":"https://api.github.com/users/iotexproject/orgs","repos_url":"https://api.github.com/users/iotexproject/repos","events_url":"https://api.github.com/users/iotexproject/events{/privacy}","received_events_url":"https://api.github.com/users/iotexproject/received_events","type":"Organization","site_admin":false},"repo":{"id":167877620,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc4Nzc2MjA=","name":"iotex-election","full_name":"iotexproject/iotex-election","private":false,"owner":{"login":"iotexproject","id":34317526,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzE3NTI2","avatar_url":"https://avatars3.githubusercontent.com/u/34317526?v=4","gravatar_id":"","url":"https://api.github.com/users/iotexproject","html_url":"https://github.com/iotexproject","followers_url":"https://api.github.com/users/iotexproject/followers","following_url":"https://api.github.com/users/iotexproject/following{/other_user}","gists_url":"https://api.github.com/users/iotexproject/gists{/gist_id}","starred_url":"https://api.github.com/users/iotexproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotexproject/subscriptions","organizations_url":"https://api.github.com/users/iotexproject/orgs","repos_url":"https://api.github.com/users/iotexproject/repos","events_url":"https://api.github.com/users/iotexproject/events{/privacy}","received_events_url":"https://api.github.com/users/iotexproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iotexproject/iotex-election","description":"The Ethereum-to-IoTeX Bridge that syncs smart contract states to IoTeX blockchain","fork":false,"url":"https://api.github.com/repos/iotexproject/iotex-election","forks_url":"https://api.github.com/repos/iotexproject/iotex-election/forks","keys_url":"https://api.github.com/repos/iotexproject/iotex-election/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iotexproject/iotex-election/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iotexproject/iotex-election/teams","hooks_url":"https://api.github.com/repos/iotexproject/iotex-election/hooks","issue_events_url":"https://api.github.com/repos/iotexproject/iotex-election/issues/events{/number}","events_url":"https://api.github.com/repos/iotexproject/iotex-election/events","assignees_url":"https://api.github.com/repos/iotexproject/iotex-election/assignees{/user}","branches_url":"https://api.github.com/repos/iotexproject/iotex-election/branches{/branch}","tags_url":"https://api.github.com/repos/iotexproject/iotex-election/tags","blobs_url":"https://api.github.com/repos/iotexproject/iotex-election/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iotexproject/iotex-election/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iotexproject/iotex-election/git/refs{/sha}","trees_url":"https://api.github.com/repos/iotexproject/iotex-election/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iotexproject/iotex-election/statuses/{sha}","languages_url":"https://api.github.com/repos/iotexproject/iotex-election/languages","stargazers_url":"https://api.github.com/repos/iotexproject/iotex-election/stargazers","contributors_url":"https://api.github.com/repos/iotexproject/iotex-election/contributors","subscribers_url":"https://api.github.com/repos/iotexproject/iotex-election/subscribers","subscription_url":"https://api.github.com/repos/iotexproject/iotex-election/subscription","commits_url":"https://api.github.com/repos/iotexproject/iotex-election/commits{/sha}","git_commits_url":"https://api.github.com/repos/iotexproject/iotex-election/git/commits{/sha}","comments_url":"https://api.github.com/repos/iotexproject/iotex-election/comments{/number}","issue_comment_url":"https://api.github.com/repos/iotexproject/iotex-election/issues/comments{/number}","contents_url":"https://api.github.com/repos/iotexproject/iotex-election/contents/{+path}","compare_url":"https://api.github.com/repos/iotexproject/iotex-election/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iotexproject/iotex-election/merges","archive_url":"https://api.github.com/repos/iotexproject/iotex-election/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iotexproject/iotex-election/downloads","issues_url":"https://api.github.com/repos/iotexproject/iotex-election/issues{/number}","pulls_url":"https://api.github.com/repos/iotexproject/iotex-election/pulls{/number}","milestones_url":"https://api.github.com/repos/iotexproject/iotex-election/milestones{/number}","notifications_url":"https://api.github.com/repos/iotexproject/iotex-election/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iotexproject/iotex-election/labels{/name}","releases_url":"https://api.github.com/repos/iotexproject/iotex-election/releases{/id}","deployments_url":"https://api.github.com/repos/iotexproject/iotex-election/deployments","created_at":"2019-01-28T01:03:19Z","updated_at":"2019-05-17T22:18:01Z","pushed_at":"2019-05-18T00:49:53Z","git_url":"git://github.com/iotexproject/iotex-election.git","ssh_url":"[email protected]:iotexproject/iotex-election.git","clone_url":"https://github.com/iotexproject/iotex-election.git","svn_url":"https://github.com/iotexproject/iotex-election","homepage":"https://iotex.io","size":442,"stargazers_count":3,"watchers_count":3,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":2,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iotexproject/iotex-election/pulls/71"},"html":{"href":"https://github.com/iotexproject/iotex-election/pull/71"},"issue":{"href":"https://api.github.com/repos/iotexproject/iotex-election/issues/71"},"comments":{"href":"https://api.github.com/repos/iotexproject/iotex-election/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/iotexproject/iotex-election/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/iotexproject/iotex-election/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iotexproject/iotex-election/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/iotexproject/iotex-election/statuses/5a2c356bb89251b2cdc9263fd29ca4e622c02c71"}},"author_association":"COLLABORATOR"}}	{ "id": 167877620, "name": "iotexproject/iotex-election", "url": "https://api.github.com/repos/iotexproject/iotex-election" }	{ "id": 35021395, "login": "zjshen14", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/35021395?", "url": "https://api.github.com/users/zjshen14" }	{ "id": 34317526, "login": "iotexproject", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/34317526?", "url": "https://api.github.com/orgs/iotexproject" }	2019-05-20T17:43:36	9661349287	{"actor":{"display_login":"zjshen14"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/comments/339570859","pull_request_review_id":307857737,"id":339570859,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzOTU3MDg1OQ==","diff_hunk":"@@ -0,0 +1,132 @@\n+// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent\n+// permitted by law, all liability for your use of the code is disclaimed. This source code is governed by Apache\n+// License 2.0 that can be found in the LICENSE file.\n+\n+package action\n+\n+import (\n+\t\"encoding/hex\"\n+\t\"math/big\"\n+\t\"strings\"\n+\n+\t\"github.com/ethereum/go-ethereum/accounts/abi\"\n+\t\"github.com/spf13/cobra\"\n+\t\"go.uber.org/zap\"\n+\n+\t\"github.com/iotexproject/iotex-address/address\"\n+\n+\t\"github.com/iotexproject/iotex-core/action/protocol/poll\"\n+\t\"github.com/iotexproject/iotex-core/ioctl/cmd/alias\"\n+\t\"github.com/iotexproject/iotex-core/ioctl/output\"\n+\t\"github.com/iotexproject/iotex-core/ioctl/util\"\n+\t\"github.com/iotexproject/iotex-core/pkg/log\"\n+)\n+\n+var autoStake bool","path":"ioctl/cmd/action/actionstake.go","position":25,"original_position":25,"commit_id":"5270a7c9969e01289aa2942e7edb1c4bc307aba6","original_commit_id":"5270a7c9969e01289aa2942e7edb1c4bc307aba6","user":{"login":"golangcibot","id":42910462,"node_id":"MDQ6VXNlcjQyOTEwNDYy","avatar_url":"https://avatars1.githubusercontent.com/u/42910462?v=4","gravatar_id":"","url":"https://api.github.com/users/golangcibot","html_url":"https://github.com/golangcibot","followers_url":"https://api.github.com/users/golangcibot/followers","following_url":"https://api.github.com/users/golangcibot/following{/other_user}","gists_url":"https://api.github.com/users/golangcibot/gists{/gist_id}","starred_url":"https://api.github.com/users/golangcibot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golangcibot/subscriptions","organizations_url":"https://api.github.com/users/golangcibot/orgs","repos_url":"https://api.github.com/users/golangcibot/repos","events_url":"https://api.github.com/users/golangcibot/events{/privacy}","received_events_url":"https://api.github.com/users/golangcibot/received_events","type":"User","site_admin":false},"body":"`autoStake` is a global variable (from `gochecknoglobals`)","created_at":"2019-10-28T13:47:50Z","updated_at":"2019-10-28T13:47:52Z","html_url":"https://github.com/iotexproject/iotex-core/pull/1575#discussion_r339570859","pull_request_url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/1575","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/comments/339570859"},"html":{"href":"https://github.com/iotexproject/iotex-core/pull/1575#discussion_r339570859"},"pull_request":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/1575"}}},"pull_request":{"url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/1575","id":333123721,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMzMTIzNzIx","html_url":"https://github.com/iotexproject/iotex-core/pull/1575","diff_url":"https://github.com/iotexproject/iotex-core/pull/1575.diff","patch_url":"https://github.com/iotexproject/iotex-core/pull/1575.patch","issue_url":"https://api.github.com/repos/iotexproject/iotex-core/issues/1575","number":1575,"state":"open","locked":false,"title":"add stack & restake cmd for ioctl","user":{"login":"Frankonly","id":35358771,"node_id":"MDQ6VXNlcjM1MzU4Nzcx","avatar_url":"https://avatars1.githubusercontent.com/u/35358771?v=4","gravatar_id":"","url":"https://api.github.com/users/Frankonly","html_url":"https://github.com/Frankonly","followers_url":"https://api.github.com/users/Frankonly/followers","following_url":"https://api.github.com/users/Frankonly/following{/other_user}","gists_url":"https://api.github.com/users/Frankonly/gists{/gist_id}","starred_url":"https://api.github.com/users/Frankonly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frankonly/subscriptions","organizations_url":"https://api.github.com/users/Frankonly/orgs","repos_url":"https://api.github.com/users/Frankonly/repos","events_url":"https://api.github.com/users/Frankonly/events{/privacy}","received_events_url":"https://api.github.com/users/Frankonly/received_events","type":"User","site_admin":false},"body":"draft PR without test","created_at":"2019-10-28T13:44:57Z","updated_at":"2019-10-28T13:47:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07d6f8d575568473ca3d26043457432a63c65605","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/1575/commits","review_comments_url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/1575/comments","review_comment_url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iotexproject/iotex-core/issues/1575/comments","statuses_url":"https://api.github.com/repos/iotexproject/iotex-core/statuses/5270a7c9969e01289aa2942e7edb1c4bc307aba6","head":{"label":"Frankonly:stake","ref":"stake","sha":"5270a7c9969e01289aa2942e7edb1c4bc307aba6","user":{"login":"Frankonly","id":35358771,"node_id":"MDQ6VXNlcjM1MzU4Nzcx","avatar_url":"https://avatars1.githubusercontent.com/u/35358771?v=4","gravatar_id":"","url":"https://api.github.com/users/Frankonly","html_url":"https://github.com/Frankonly","followers_url":"https://api.github.com/users/Frankonly/followers","following_url":"https://api.github.com/users/Frankonly/following{/other_user}","gists_url":"https://api.github.com/users/Frankonly/gists{/gist_id}","starred_url":"https://api.github.com/users/Frankonly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frankonly/subscriptions","organizations_url":"https://api.github.com/users/Frankonly/orgs","repos_url":"https://api.github.com/users/Frankonly/repos","events_url":"https://api.github.com/users/Frankonly/events{/privacy}","received_events_url":"https://api.github.com/users/Frankonly/received_events","type":"User","site_admin":false},"repo":{"id":183294396,"node_id":"MDEwOlJlcG9zaXRvcnkxODMyOTQzOTY=","name":"iotex-core","full_name":"Frankonly/iotex-core","private":false,"owner":{"login":"Frankonly","id":35358771,"node_id":"MDQ6VXNlcjM1MzU4Nzcx","avatar_url":"https://avatars1.githubusercontent.com/u/35358771?v=4","gravatar_id":"","url":"https://api.github.com/users/Frankonly","html_url":"https://github.com/Frankonly","followers_url":"https://api.github.com/users/Frankonly/followers","following_url":"https://api.github.com/users/Frankonly/following{/other_user}","gists_url":"https://api.github.com/users/Frankonly/gists{/gist_id}","starred_url":"https://api.github.com/users/Frankonly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frankonly/subscriptions","organizations_url":"https://api.github.com/users/Frankonly/orgs","repos_url":"https://api.github.com/users/Frankonly/repos","events_url":"https://api.github.com/users/Frankonly/events{/privacy}","received_events_url":"https://api.github.com/users/Frankonly/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Frankonly/iotex-core","description":"Official Go implementation of the IoTeX protocol","fork":true,"url":"https://api.github.com/repos/Frankonly/iotex-core","forks_url":"https://api.github.com/repos/Frankonly/iotex-core/forks","keys_url":"https://api.github.com/repos/Frankonly/iotex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Frankonly/iotex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Frankonly/iotex-core/teams","hooks_url":"https://api.github.com/repos/Frankonly/iotex-core/hooks","issue_events_url":"https://api.github.com/repos/Frankonly/iotex-core/issues/events{/number}","events_url":"https://api.github.com/repos/Frankonly/iotex-core/events","assignees_url":"https://api.github.com/repos/Frankonly/iotex-core/assignees{/user}","branches_url":"https://api.github.com/repos/Frankonly/iotex-core/branches{/branch}","tags_url":"https://api.github.com/repos/Frankonly/iotex-core/tags","blobs_url":"https://api.github.com/repos/Frankonly/iotex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Frankonly/iotex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Frankonly/iotex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Frankonly/iotex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Frankonly/iotex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Frankonly/iotex-core/languages","stargazers_url":"https://api.github.com/repos/Frankonly/iotex-core/stargazers","contributors_url":"https://api.github.com/repos/Frankonly/iotex-core/contributors","subscribers_url":"https://api.github.com/repos/Frankonly/iotex-core/subscribers","subscription_url":"https://api.github.com/repos/Frankonly/iotex-core/subscription","commits_url":"https://api.github.com/repos/Frankonly/iotex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Frankonly/iotex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Frankonly/iotex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Frankonly/iotex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Frankonly/iotex-core/contents/{+path}","compare_url":"https://api.github.com/repos/Frankonly/iotex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Frankonly/iotex-core/merges","archive_url":"https://api.github.com/repos/Frankonly/iotex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Frankonly/iotex-core/downloads","issues_url":"https://api.github.com/repos/Frankonly/iotex-core/issues{/number}","pulls_url":"https://api.github.com/repos/Frankonly/iotex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Frankonly/iotex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Frankonly/iotex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Frankonly/iotex-core/labels{/name}","releases_url":"https://api.github.com/repos/Frankonly/iotex-core/releases{/id}","deployments_url":"https://api.github.com/repos/Frankonly/iotex-core/deployments","created_at":"2019-04-24T19:31:42Z","updated_at":"2019-10-28T11:17:29Z","pushed_at":"2019-10-28T13:44:25Z","git_url":"git://github.com/Frankonly/iotex-core.git","ssh_url":"[email protected]:Frankonly/iotex-core.git","clone_url":"https://github.com/Frankonly/iotex-core.git","svn_url":"https://github.com/Frankonly/iotex-core","homepage":"https://iotex.io","size":67818,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iotexproject:master","ref":"master","sha":"69c03b7191a0a9b17c3bf07f7aed5e717c1e1d06","user":{"login":"iotexproject","id":34317526,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzE3NTI2","avatar_url":"https://avatars3.githubusercontent.com/u/34317526?v=4","gravatar_id":"","url":"https://api.github.com/users/iotexproject","html_url":"https://github.com/iotexproject","followers_url":"https://api.github.com/users/iotexproject/followers","following_url":"https://api.github.com/users/iotexproject/following{/other_user}","gists_url":"https://api.github.com/users/iotexproject/gists{/gist_id}","starred_url":"https://api.github.com/users/iotexproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotexproject/subscriptions","organizations_url":"https://api.github.com/users/iotexproject/orgs","repos_url":"https://api.github.com/users/iotexproject/repos","events_url":"https://api.github.com/users/iotexproject/events{/privacy}","received_events_url":"https://api.github.com/users/iotexproject/received_events","type":"Organization","site_admin":false},"repo":{"id":130281002,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAyODEwMDI=","name":"iotex-core","full_name":"iotexproject/iotex-core","private":false,"owner":{"login":"iotexproject","id":34317526,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzE3NTI2","avatar_url":"https://avatars3.githubusercontent.com/u/34317526?v=4","gravatar_id":"","url":"https://api.github.com/users/iotexproject","html_url":"https://github.com/iotexproject","followers_url":"https://api.github.com/users/iotexproject/followers","following_url":"https://api.github.com/users/iotexproject/following{/other_user}","gists_url":"https://api.github.com/users/iotexproject/gists{/gist_id}","starred_url":"https://api.github.com/users/iotexproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotexproject/subscriptions","organizations_url":"https://api.github.com/users/iotexproject/orgs","repos_url":"https://api.github.com/users/iotexproject/repos","events_url":"https://api.github.com/users/iotexproject/events{/privacy}","received_events_url":"https://api.github.com/users/iotexproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iotexproject/iotex-core","description":"Official implementation of IoTeX blockchain protocol in Go.","fork":false,"url":"https://api.github.com/repos/iotexproject/iotex-core","forks_url":"https://api.github.com/repos/iotexproject/iotex-core/forks","keys_url":"https://api.github.com/repos/iotexproject/iotex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iotexproject/iotex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iotexproject/iotex-core/teams","hooks_url":"https://api.github.com/repos/iotexproject/iotex-core/hooks","issue_events_url":"https://api.github.com/repos/iotexproject/iotex-core/issues/events{/number}","events_url":"https://api.github.com/repos/iotexproject/iotex-core/events","assignees_url":"https://api.github.com/repos/iotexproject/iotex-core/assignees{/user}","branches_url":"https://api.github.com/repos/iotexproject/iotex-core/branches{/branch}","tags_url":"https://api.github.com/repos/iotexproject/iotex-core/tags","blobs_url":"https://api.github.com/repos/iotexproject/iotex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iotexproject/iotex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iotexproject/iotex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/iotexproject/iotex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iotexproject/iotex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/iotexproject/iotex-core/languages","stargazers_url":"https://api.github.com/repos/iotexproject/iotex-core/stargazers","contributors_url":"https://api.github.com/repos/iotexproject/iotex-core/contributors","subscribers_url":"https://api.github.com/repos/iotexproject/iotex-core/subscribers","subscription_url":"https://api.github.com/repos/iotexproject/iotex-core/subscription","commits_url":"https://api.github.com/repos/iotexproject/iotex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/iotexproject/iotex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/iotexproject/iotex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/iotexproject/iotex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/iotexproject/iotex-core/contents/{+path}","compare_url":"https://api.github.com/repos/iotexproject/iotex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iotexproject/iotex-core/merges","archive_url":"https://api.github.com/repos/iotexproject/iotex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iotexproject/iotex-core/downloads","issues_url":"https://api.github.com/repos/iotexproject/iotex-core/issues{/number}","pulls_url":"https://api.github.com/repos/iotexproject/iotex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/iotexproject/iotex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/iotexproject/iotex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iotexproject/iotex-core/labels{/name}","releases_url":"https://api.github.com/repos/iotexproject/iotex-core/releases{/id}","deployments_url":"https://api.github.com/repos/iotexproject/iotex-core/deployments","created_at":"2018-04-19T22:56:20Z","updated_at":"2019-10-26T07:31:36Z","pushed_at":"2019-10-28T13:44:58Z","git_url":"git://github.com/iotexproject/iotex-core.git","ssh_url":"[email protected]:iotexproject/iotex-core.git","clone_url":"https://github.com/iotexproject/iotex-core.git","svn_url":"https://github.com/iotexproject/iotex-core","homepage":"https://iotex.io","size":67964,"stargazers_count":294,"watchers_count":294,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":33,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":137,"open_issues":33,"watchers":294,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/1575"},"html":{"href":"https://github.com/iotexproject/iotex-core/pull/1575"},"issue":{"href":"https://api.github.com/repos/iotexproject/iotex-core/issues/1575"},"comments":{"href":"https://api.github.com/repos/iotexproject/iotex-core/issues/1575/comments"},"review_comments":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/1575/comments"},"review_comment":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/1575/commits"},"statuses":{"href":"https://api.github.com/repos/iotexproject/iotex-core/statuses/5270a7c9969e01289aa2942e7edb1c4bc307aba6"}},"author_association":"COLLABORATOR"}}	{ "id": 130281002, "name": "iotexproject/iotex-core", "url": "https://api.github.com/repos/iotexproject/iotex-core" }	{ "id": 42910462, "login": "golangcibot", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/42910462?", "url": "https://api.github.com/users/golangcibot" }	{ "id": 34317526, "login": "iotexproject", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/34317526?", "url": "https://api.github.com/orgs/iotexproject" }	2019-10-28T13:47:50	10728377197	{"actor":{"display_login":"golangcibot"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/iotexproject/iotex-analytics/pulls/comments/364511788","pull_request_review_id":340229726,"id":364511788,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NDUxMTc4OA==","diff_hunk":"@@ -443,6 +444,119 @@ func (p Protocol) GetXrc20ByAddress(addr string, numPerPage, page uint64) (cons\n \treturn\n }\n \n+// GetXrc20HolderCount gets xrc20 holders's address\n+func (p Protocol) GetXrc20HolderCount(addr string) (count int, err error) {\n+\tif _, ok := p.indexer.Registry.Find(actions.ProtocolID); !ok {\n+\t\treturn 0, errors.New(\"actions protocol is unregistered\")\n+\t}\n+\n+\tdb := p.indexer.Store.GetDB()\n+\tgetQuery := fmt.Sprintf(selectXrc20AllHistory, actions.Xrc20HistoryTableName, addr)\n+\tstmt, err := db.Prepare(getQuery)\n+\tif err != nil {\n+\t\treturn 0, errors.Wrap(err, \"failed to prepare get query\")\n+\t}\n+\tdefer stmt.Close()\n+\n+\trows, err := stmt.Query()\n+\tif err != nil {\n+\t\treturn 0, errors.Wrap(err, \"failed to execute get query\")\n+\t}\n+\n+\tvar ret actions.Xrc20History\n+\tparsedRows, err := s.ParseSQLRows(rows, &ret)\n+\tif err != nil {\n+\t\treturn 0, errors.Wrap(err, \"failed to parse results\")\n+\t}\n+\tif len(parsedRows) == 0 {\n+\t\terr = indexprotocol.ErrNotExist\n+\t\treturn 0, err\n+\t}\n+\tallHolder := make(map[string]bool, 0)\n+\tfor _, parsedRow := range parsedRows {\n+\t\tcon := &Xrc20Info{}\n+\t\tr := parsedRow.(*actions.Xrc20History)\n+\t\tcon.From, con.To, _, err = parseContractData(r.Topics, r.Data)\n+\t\tif err != nil {\n+\t\t\tcontinue\n+\t\t}\n+\t\tfmt.Println(con.From, \":\", con.To)\n+\t\tif _, ok := allHolder[con.From]; !ok {\n+\t\t\tcount++\n+\t\t\tallHolder[con.From] = true\n+\t\t}\n+\t\tif _, ok := allHolder[con.To]; !ok {\n+\t\t\tcount++\n+\t\t\tallHolder[con.To] = true\n+\t\t}","path":"queryprotocol/actions/protocol.go","position":56,"original_position":56,"commit_id":"c6f66a1a744e3a150b0e8dfd38eacf419faae5c4","original_commit_id":"c6f66a1a744e3a150b0e8dfd38eacf419faae5c4","user":{"login":"CoderZhi","id":35643171,"node_id":"MDQ6VXNlcjM1NjQzMTcx","avatar_url":"https://avatars2.githubusercontent.com/u/35643171?v=4","gravatar_id":"","url":"https://api.github.com/users/CoderZhi","html_url":"https://github.com/CoderZhi","followers_url":"https://api.github.com/users/CoderZhi/followers","following_url":"https://api.github.com/users/CoderZhi/following{/other_user}","gists_url":"https://api.github.com/users/CoderZhi/gists{/gist_id}","starred_url":"https://api.github.com/users/CoderZhi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoderZhi/subscriptions","organizations_url":"https://api.github.com/users/CoderZhi/orgs","repos_url":"https://api.github.com/users/CoderZhi/repos","events_url":"https://api.github.com/users/CoderZhi/events{/privacy}","received_events_url":"https://api.github.com/users/CoderZhi/received_events","type":"User","site_admin":false},"body":"this will be very inefficient. If this number is used frequently, we shouldn't calculate them on the fly.","created_at":"2020-01-09T00:36:18Z","updated_at":"2020-01-09T00:36:59Z","html_url":"https://github.com/iotexproject/iotex-analytics/pull/154#discussion_r364511788","pull_request_url":"https://api.github.com/repos/iotexproject/iotex-analytics/pulls/154","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/iotexproject/iotex-analytics/pulls/comments/364511788"},"html":{"href":"https://github.com/iotexproject/iotex-analytics/pull/154#discussion_r364511788"},"pull_request":{"href":"https://api.github.com/repos/iotexproject/iotex-analytics/pulls/154"}}},"pull_request":{"url":"https://api.github.com/repos/iotexproject/iotex-analytics/pulls/154","id":359482205,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU5NDgyMjA1","html_url":"https://github.com/iotexproject/iotex-analytics/pull/154","diff_url":"https://github.com/iotexproject/iotex-analytics/pull/154.diff","patch_url":"https://github.com/iotexproject/iotex-analytics/pull/154.patch","issue_url":"https://api.github.com/repos/iotexproject/iotex-analytics/issues/154","number":154,"state":"open","locked":false,"title":"get all addresses holder for an xrc20 token address 152","user":{"login":"lzxm160","id":5837417,"node_id":"MDQ6VXNlcjU4Mzc0MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5837417?v=4","gravatar_id":"","url":"https://api.github.com/users/lzxm160","html_url":"https://github.com/lzxm160","followers_url":"https://api.github.com/users/lzxm160/followers","following_url":"https://api.github.com/users/lzxm160/following{/other_user}","gists_url":"https://api.github.com/users/lzxm160/gists{/gist_id}","starred_url":"https://api.github.com/users/lzxm160/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzxm160/subscriptions","organizations_url":"https://api.github.com/users/lzxm160/orgs","repos_url":"https://api.github.com/users/lzxm160/repos","events_url":"https://api.github.com/users/lzxm160/events{/privacy}","received_events_url":"https://api.github.com/users/lzxm160/received_events","type":"User","site_admin":false},"body":"work on #152 \r\n1.\r\n```\r\nquery {\r\n xrc20 {\r\n holdersCount (tokenAddress:\"io14j96vg9pkx28htpgt2jx0tf3v9etpg4j9h384m\")\r\n }\r\n}\r\n```\r\n2.\r\n```\r\nquery {\r\n xrc20 {\r\n byTokenAddress(tokenAddress:\"io14j96vg9pkx28htpgt2jx0tf3v9etpg4j9h384m\", pagination:{first:3,skip:0}) {\r\n exist\r\n count\r\n addresses\r\n }\r\n }\r\n}\r\n```","created_at":"2020-01-06T10:25:25Z","updated_at":"2020-01-09T00:36:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a162198d87a5c9b046a8b096deed1fa19f7b9a1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lizhefeng","id":15241597,"node_id":"MDQ6VXNlcjE1MjQxNTk3","avatar_url":"https://avatars1.githubusercontent.com/u/15241597?v=4","gravatar_id":"","url":"https://api.github.com/users/lizhefeng","html_url":"https://github.com/lizhefeng","followers_url":"https://api.github.com/users/lizhefeng/followers","following_url":"https://api.github.com/users/lizhefeng/following{/other_user}","gists_url":"https://api.github.com/users/lizhefeng/gists{/gist_id}","starred_url":"https://api.github.com/users/lizhefeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizhefeng/subscriptions","organizations_url":"https://api.github.com/users/lizhefeng/orgs","repos_url":"https://api.github.com/users/lizhefeng/repos","events_url":"https://api.github.com/users/lizhefeng/events{/privacy}","received_events_url":"https://api.github.com/users/lizhefeng/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iotexproject/iotex-analytics/pulls/154/commits","review_comments_url":"https://api.github.com/repos/iotexproject/iotex-analytics/pulls/154/comments","review_comment_url":"https://api.github.com/repos/iotexproject/iotex-analytics/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iotexproject/iotex-analytics/issues/154/comments","statuses_url":"https://api.github.com/repos/iotexproject/iotex-analytics/statuses/c6f66a1a744e3a150b0e8dfd38eacf419faae5c4","head":{"label":"lzxm160:1522","ref":"1522","sha":"c6f66a1a744e3a150b0e8dfd38eacf419faae5c4","user":{"login":"lzxm160","id":5837417,"node_id":"MDQ6VXNlcjU4Mzc0MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5837417?v=4","gravatar_id":"","url":"https://api.github.com/users/lzxm160","html_url":"https://github.com/lzxm160","followers_url":"https://api.github.com/users/lzxm160/followers","following_url":"https://api.github.com/users/lzxm160/following{/other_user}","gists_url":"https://api.github.com/users/lzxm160/gists{/gist_id}","starred_url":"https://api.github.com/users/lzxm160/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzxm160/subscriptions","organizations_url":"https://api.github.com/users/lzxm160/orgs","repos_url":"https://api.github.com/users/lzxm160/repos","events_url":"https://api.github.com/users/lzxm160/events{/privacy}","received_events_url":"https://api.github.com/users/lzxm160/received_events","type":"User","site_admin":false},"repo":{"id":196895033,"node_id":"MDEwOlJlcG9zaXRvcnkxOTY4OTUwMzM=","name":"iotex-analytics","full_name":"lzxm160/iotex-analytics","private":false,"owner":{"login":"lzxm160","id":5837417,"node_id":"MDQ6VXNlcjU4Mzc0MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/5837417?v=4","gravatar_id":"","url":"https://api.github.com/users/lzxm160","html_url":"https://github.com/lzxm160","followers_url":"https://api.github.com/users/lzxm160/followers","following_url":"https://api.github.com/users/lzxm160/following{/other_user}","gists_url":"https://api.github.com/users/lzxm160/gists{/gist_id}","starred_url":"https://api.github.com/users/lzxm160/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzxm160/subscriptions","organizations_url":"https://api.github.com/users/lzxm160/orgs","repos_url":"https://api.github.com/users/lzxm160/repos","events_url":"https://api.github.com/users/lzxm160/events{/privacy}","received_events_url":"https://api.github.com/users/lzxm160/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lzxm160/iotex-analytics","description":"The independent service that analyzes data from IoTeX blockchain","fork":true,"url":"https://api.github.com/repos/lzxm160/iotex-analytics","forks_url":"https://api.github.com/repos/lzxm160/iotex-analytics/forks","keys_url":"https://api.github.com/repos/lzxm160/iotex-analytics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lzxm160/iotex-analytics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lzxm160/iotex-analytics/teams","hooks_url":"https://api.github.com/repos/lzxm160/iotex-analytics/hooks","issue_events_url":"https://api.github.com/repos/lzxm160/iotex-analytics/issues/events{/number}","events_url":"https://api.github.com/repos/lzxm160/iotex-analytics/events","assignees_url":"https://api.github.com/repos/lzxm160/iotex-analytics/assignees{/user}","branches_url":"https://api.github.com/repos/lzxm160/iotex-analytics/branches{/branch}","tags_url":"https://api.github.com/repos/lzxm160/iotex-analytics/tags","blobs_url":"https://api.github.com/repos/lzxm160/iotex-analytics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lzxm160/iotex-analytics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lzxm160/iotex-analytics/git/refs{/sha}","trees_url":"https://api.github.com/repos/lzxm160/iotex-analytics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lzxm160/iotex-analytics/statuses/{sha}","languages_url":"https://api.github.com/repos/lzxm160/iotex-analytics/languages","stargazers_url":"https://api.github.com/repos/lzxm160/iotex-analytics/stargazers","contributors_url":"https://api.github.com/repos/lzxm160/iotex-analytics/contributors","subscribers_url":"https://api.github.com/repos/lzxm160/iotex-analytics/subscribers","subscription_url":"https://api.github.com/repos/lzxm160/iotex-analytics/subscription","commits_url":"https://api.github.com/repos/lzxm160/iotex-analytics/commits{/sha}","git_commits_url":"https://api.github.com/repos/lzxm160/iotex-analytics/git/commits{/sha}","comments_url":"https://api.github.com/repos/lzxm160/iotex-analytics/comments{/number}","issue_comment_url":"https://api.github.com/repos/lzxm160/iotex-analytics/issues/comments{/number}","contents_url":"https://api.github.com/repos/lzxm160/iotex-analytics/contents/{+path}","compare_url":"https://api.github.com/repos/lzxm160/iotex-analytics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lzxm160/iotex-analytics/merges","archive_url":"https://api.github.com/repos/lzxm160/iotex-analytics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lzxm160/iotex-analytics/downloads","issues_url":"https://api.github.com/repos/lzxm160/iotex-analytics/issues{/number}","pulls_url":"https://api.github.com/repos/lzxm160/iotex-analytics/pulls{/number}","milestones_url":"https://api.github.com/repos/lzxm160/iotex-analytics/milestones{/number}","notifications_url":"https://api.github.com/repos/lzxm160/iotex-analytics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lzxm160/iotex-analytics/labels{/name}","releases_url":"https://api.github.com/repos/lzxm160/iotex-analytics/releases{/id}","deployments_url":"https://api.github.com/repos/lzxm160/iotex-analytics/deployments","created_at":"2019-07-14T23:57:44Z","updated_at":"2020-01-06T07:29:14Z","pushed_at":"2020-01-07T04:12:31Z","git_url":"git://github.com/lzxm160/iotex-analytics.git","ssh_url":"[email protected]:lzxm160/iotex-analytics.git","clone_url":"https://github.com/lzxm160/iotex-analytics.git","svn_url":"https://github.com/lzxm160/iotex-analytics","homepage":"https://analytics.iotexscan.io","size":18984,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iotexproject:master","ref":"master","sha":"a8ed4553ce92dbe06bc26cf76e6f9ac07bb277e0","user":{"login":"iotexproject","id":34317526,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzE3NTI2","avatar_url":"https://avatars3.githubusercontent.com/u/34317526?v=4","gravatar_id":"","url":"https://api.github.com/users/iotexproject","html_url":"https://github.com/iotexproject","followers_url":"https://api.github.com/users/iotexproject/followers","following_url":"https://api.github.com/users/iotexproject/following{/other_user}","gists_url":"https://api.github.com/users/iotexproject/gists{/gist_id}","starred_url":"https://api.github.com/users/iotexproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotexproject/subscriptions","organizations_url":"https://api.github.com/users/iotexproject/orgs","repos_url":"https://api.github.com/users/iotexproject/repos","events_url":"https://api.github.com/users/iotexproject/events{/privacy}","received_events_url":"https://api.github.com/users/iotexproject/received_events","type":"Organization","site_admin":false},"repo":{"id":183526875,"node_id":"MDEwOlJlcG9zaXRvcnkxODM1MjY4NzU=","name":"iotex-analytics","full_name":"iotexproject/iotex-analytics","private":false,"owner":{"login":"iotexproject","id":34317526,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzE3NTI2","avatar_url":"https://avatars3.githubusercontent.com/u/34317526?v=4","gravatar_id":"","url":"https://api.github.com/users/iotexproject","html_url":"https://github.com/iotexproject","followers_url":"https://api.github.com/users/iotexproject/followers","following_url":"https://api.github.com/users/iotexproject/following{/other_user}","gists_url":"https://api.github.com/users/iotexproject/gists{/gist_id}","starred_url":"https://api.github.com/users/iotexproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotexproject/subscriptions","organizations_url":"https://api.github.com/users/iotexproject/orgs","repos_url":"https://api.github.com/users/iotexproject/repos","events_url":"https://api.github.com/users/iotexproject/events{/privacy}","received_events_url":"https://api.github.com/users/iotexproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iotexproject/iotex-analytics","description":"The independent service that analyzes data from IoTeX blockchain","fork":false,"url":"https://api.github.com/repos/iotexproject/iotex-analytics","forks_url":"https://api.github.com/repos/iotexproject/iotex-analytics/forks","keys_url":"https://api.github.com/repos/iotexproject/iotex-analytics/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iotexproject/iotex-analytics/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iotexproject/iotex-analytics/teams","hooks_url":"https://api.github.com/repos/iotexproject/iotex-analytics/hooks","issue_events_url":"https://api.github.com/repos/iotexproject/iotex-analytics/issues/events{/number}","events_url":"https://api.github.com/repos/iotexproject/iotex-analytics/events","assignees_url":"https://api.github.com/repos/iotexproject/iotex-analytics/assignees{/user}","branches_url":"https://api.github.com/repos/iotexproject/iotex-analytics/branches{/branch}","tags_url":"https://api.github.com/repos/iotexproject/iotex-analytics/tags","blobs_url":"https://api.github.com/repos/iotexproject/iotex-analytics/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iotexproject/iotex-analytics/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iotexproject/iotex-analytics/git/refs{/sha}","trees_url":"https://api.github.com/repos/iotexproject/iotex-analytics/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iotexproject/iotex-analytics/statuses/{sha}","languages_url":"https://api.github.com/repos/iotexproject/iotex-analytics/languages","stargazers_url":"https://api.github.com/repos/iotexproject/iotex-analytics/stargazers","contributors_url":"https://api.github.com/repos/iotexproject/iotex-analytics/contributors","subscribers_url":"https://api.github.com/repos/iotexproject/iotex-analytics/subscribers","subscription_url":"https://api.github.com/repos/iotexproject/iotex-analytics/subscription","commits_url":"https://api.github.com/repos/iotexproject/iotex-analytics/commits{/sha}","git_commits_url":"https://api.github.com/repos/iotexproject/iotex-analytics/git/commits{/sha}","comments_url":"https://api.github.com/repos/iotexproject/iotex-analytics/comments{/number}","issue_comment_url":"https://api.github.com/repos/iotexproject/iotex-analytics/issues/comments{/number}","contents_url":"https://api.github.com/repos/iotexproject/iotex-analytics/contents/{+path}","compare_url":"https://api.github.com/repos/iotexproject/iotex-analytics/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iotexproject/iotex-analytics/merges","archive_url":"https://api.github.com/repos/iotexproject/iotex-analytics/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iotexproject/iotex-analytics/downloads","issues_url":"https://api.github.com/repos/iotexproject/iotex-analytics/issues{/number}","pulls_url":"https://api.github.com/repos/iotexproject/iotex-analytics/pulls{/number}","milestones_url":"https://api.github.com/repos/iotexproject/iotex-analytics/milestones{/number}","notifications_url":"https://api.github.com/repos/iotexproject/iotex-analytics/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iotexproject/iotex-analytics/labels{/name}","releases_url":"https://api.github.com/repos/iotexproject/iotex-analytics/releases{/id}","deployments_url":"https://api.github.com/repos/iotexproject/iotex-analytics/deployments","created_at":"2019-04-26T00:09:00Z","updated_at":"2020-01-07T04:05:10Z","pushed_at":"2020-01-07T04:12:32Z","git_url":"git://github.com/iotexproject/iotex-analytics.git","ssh_url":"[email protected]:iotexproject/iotex-analytics.git","clone_url":"https://github.com/iotexproject/iotex-analytics.git","svn_url":"https://github.com/iotexproject/iotex-analytics","homepage":"https://analytics.iotexscan.io","size":18656,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":9,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iotexproject/iotex-analytics/pulls/154"},"html":{"href":"https://github.com/iotexproject/iotex-analytics/pull/154"},"issue":{"href":"https://api.github.com/repos/iotexproject/iotex-analytics/issues/154"},"comments":{"href":"https://api.github.com/repos/iotexproject/iotex-analytics/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/iotexproject/iotex-analytics/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/iotexproject/iotex-analytics/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iotexproject/iotex-analytics/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/iotexproject/iotex-analytics/statuses/c6f66a1a744e3a150b0e8dfd38eacf419faae5c4"}},"author_association":"COLLABORATOR"}}	{ "id": 183526875, "name": "iotexproject/iotex-analytics", "url": "https://api.github.com/repos/iotexproject/iotex-analytics" }	{ "id": 35643171, "login": "CoderZhi", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/35643171?", "url": "https://api.github.com/users/CoderZhi" }	{ "id": 34317526, "login": "iotexproject", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/34317526?", "url": "https://api.github.com/orgs/iotexproject" }	2020-01-09T00:36:18	11233276028	{"actor":{"display_login":"CoderZhi"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/transcom/mymove/pulls/comments/258297122","pull_request_review_id":205531370,"id":258297122,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1ODI5NzEyMg==","diff_hunk":"@@ -15,3 +16,15 @@ export function getTspForShipment(label, shipmentId) {\n // Selectors\n \n export const selectTspById = (state, tspId) => state.entities.transportationServiceProviders[tspId] \|\| {}; // eslint-disable-line security/detect-object-injection\n+\n+export function selectTransportationServiceProviderForShipment(state, shipmentId) {\n+ const transportationServiceProviderId = get(\n+ state,\n+ `entities.shipments.${shipmentId}.transportation_service_provider_id`,\n+ );\n+ if (transportationServiceProviderId) {\n+ return selectTspById(state, transportationServiceProviderId);\n+ } else {\n+ return [];","path":"src/shared/Entities/modules/transportationServiceProviders.js","position":20,"original_position":20,"commit_id":"0884b9590621ce84477b784defafc8b3706abc50","original_commit_id":"0884b9590621ce84477b784defafc8b3706abc50","user":{"login":"sarboc","id":4434681,"node_id":"MDQ6VXNlcjQ0MzQ2ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/4434681?v=4","gravatar_id":"","url":"https://api.github.com/users/sarboc","html_url":"https://github.com/sarboc","followers_url":"https://api.github.com/users/sarboc/followers","following_url":"https://api.github.com/users/sarboc/following{/other_user}","gists_url":"https://api.github.com/users/sarboc/gists{/gist_id}","starred_url":"https://api.github.com/users/sarboc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarboc/subscriptions","organizations_url":"https://api.github.com/users/sarboc/orgs","repos_url":"https://api.github.com/users/sarboc/repos","events_url":"https://api.github.com/users/sarboc/events{/privacy}","received_events_url":"https://api.github.com/users/sarboc/received_events","type":"User","site_admin":false},"body":"I think you would want to return an empty object, not an empty array, if we can't find the info in the state.","created_at":"2019-02-20T01:10:37Z","updated_at":"2019-02-20T01:12:05Z","html_url":"https://github.com/transcom/mymove/pull/1760#discussion_r258297122","pull_request_url":"https://api.github.com/repos/transcom/mymove/pulls/1760","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/transcom/mymove/pulls/comments/258297122"},"html":{"href":"https://github.com/transcom/mymove/pull/1760#discussion_r258297122"},"pull_request":{"href":"https://api.github.com/repos/transcom/mymove/pulls/1760"}}},"pull_request":{"url":"https://api.github.com/repos/transcom/mymove/pulls/1760","id":254451548,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0NDUxNTQ4","html_url":"https://github.com/transcom/mymove/pull/1760","diff_url":"https://github.com/transcom/mymove/pull/1760.diff","patch_url":"https://github.com/transcom/mymove/pull/1760.patch","issue_url":"https://api.github.com/repos/transcom/mymove/issues/1760","number":1760,"state":"open","locked":false,"title":"SM 160935424 tsp contact info move summary sidebar","user":{"login":"LeDeep","id":3522044,"node_id":"MDQ6VXNlcjM1MjIwNDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3522044?v=4","gravatar_id":"","url":"https://api.github.com/users/LeDeep","html_url":"https://github.com/LeDeep","followers_url":"https://api.github.com/users/LeDeep/followers","following_url":"https://api.github.com/users/LeDeep/following{/other_user}","gists_url":"https://api.github.com/users/LeDeep/gists{/gist_id}","starred_url":"https://api.github.com/users/LeDeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeDeep/subscriptions","organizations_url":"https://api.github.com/users/LeDeep/orgs","repos_url":"https://api.github.com/users/LeDeep/repos","events_url":"https://api.github.com/users/LeDeep/events{/privacy}","received_events_url":"https://api.github.com/users/LeDeep/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nAdd TSP contact info to the service member move summary page. Before this PR, service members had no authorization to make requests against the public API endpoints for `Shipments`. In order to show the TSP contact info on the service member move summary page, the `shipments` and `transportationServiceProviders` handlers are updated to `FetchShipment` when the session has a `ServiceMemberID`.\r\n\r\n## Setup\r\n\r\nAdd any steps or code to run in this section to help others prepare to run your code:\r\n\r\n```sh\r\nmake db_dev_e2e_populate\r\nmake server_run\r\nmake client_run\r\n```\r\nGo to any move that is in an `ACCEPTED, APPROVED, IN_TRANSIT, DELIVERED, or COMPLETED` state and you will see the TSP's contact info on the right hand side. Go to any move that is NOT in one of the mentioned states, and you will NOT see any TSP contact info on the right hand side.\r\n\r\n## Code Review Verification Steps\r\n\r\n* [ ] Request review from a member of a different team.\r\n* [ ] Have the Pivotal acceptance criteria been met for this change?\r\n\r\n## References\r\n\r\n* [Pivotal story](https://www.pivotaltracker.com/story/show/160935424) for this change\r\n\r\n## Screenshots\r\n\r\n\r\n![feb-19-2019 15-48-57](https://user-images.githubusercontent.com/3522044/53055798-f0ea4a80-345d-11e9-982d-976bedc9a89b.gif)\r\n\r\n","created_at":"2019-02-19T23:50:38Z","updated_at":"2019-02-20T01:12:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9310e99f6c2b9624ecc6861b33bc6c07a5144ba","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Ryan-Koch","id":4325613,"node_id":"MDQ6VXNlcjQzMjU2MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/4325613?v=4","gravatar_id":"","url":"https://api.github.com/users/Ryan-Koch","html_url":"https://github.com/Ryan-Koch","followers_url":"https://api.github.com/users/Ryan-Koch/followers","following_url":"https://api.github.com/users/Ryan-Koch/following{/other_user}","gists_url":"https://api.github.com/users/Ryan-Koch/gists{/gist_id}","starred_url":"https://api.github.com/users/Ryan-Koch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ryan-Koch/subscriptions","organizations_url":"https://api.github.com/users/Ryan-Koch/orgs","repos_url":"https://api.github.com/users/Ryan-Koch/repos","events_url":"https://api.github.com/users/Ryan-Koch/events{/privacy}","received_events_url":"https://api.github.com/users/Ryan-Koch/received_events","type":"User","site_admin":false},{"login":"reggieriser","id":4960757,"node_id":"MDQ6VXNlcjQ5NjA3NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/4960757?v=4","gravatar_id":"","url":"https://api.github.com/users/reggieriser","html_url":"https://github.com/reggieriser","followers_url":"https://api.github.com/users/reggieriser/followers","following_url":"https://api.github.com/users/reggieriser/following{/other_user}","gists_url":"https://api.github.com/users/reggieriser/gists{/gist_id}","starred_url":"https://api.github.com/users/reggieriser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reggieriser/subscriptions","organizations_url":"https://api.github.com/users/reggieriser/orgs","repos_url":"https://api.github.com/users/reggieriser/repos","events_url":"https://api.github.com/users/reggieriser/events{/privacy}","received_events_url":"https://api.github.com/users/reggieriser/received_events","type":"User","site_admin":false},{"login":"rdhariwal","id":5003421,"node_id":"MDQ6VXNlcjUwMDM0MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/5003421?v=4","gravatar_id":"","url":"https://api.github.com/users/rdhariwal","html_url":"https://github.com/rdhariwal","followers_url":"https://api.github.com/users/rdhariwal/followers","following_url":"https://api.github.com/users/rdhariwal/following{/other_user}","gists_url":"https://api.github.com/users/rdhariwal/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhariwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhariwal/subscriptions","organizations_url":"https://api.github.com/users/rdhariwal/orgs","repos_url":"https://api.github.com/users/rdhariwal/repos","events_url":"https://api.github.com/users/rdhariwal/events{/privacy}","received_events_url":"https://api.github.com/users/rdhariwal/received_events","type":"User","site_admin":false},{"login":"kimallen","id":13249580,"node_id":"MDQ6VXNlcjEzMjQ5NTgw","avatar_url":"https://avatars2.githubusercontent.com/u/13249580?v=4","gravatar_id":"","url":"https://api.github.com/users/kimallen","html_url":"https://github.com/kimallen","followers_url":"https://api.github.com/users/kimallen/followers","following_url":"https://api.github.com/users/kimallen/following{/other_user}","gists_url":"https://api.github.com/users/kimallen/gists{/gist_id}","starred_url":"https://api.github.com/users/kimallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kimallen/subscriptions","organizations_url":"https://api.github.com/users/kimallen/orgs","repos_url":"https://api.github.com/users/kimallen/repos","events_url":"https://api.github.com/users/kimallen/events{/privacy}","received_events_url":"https://api.github.com/users/kimallen/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/transcom/mymove/pulls/1760/commits","review_comments_url":"https://api.github.com/repos/transcom/mymove/pulls/1760/comments","review_comment_url":"https://api.github.com/repos/transcom/mymove/pulls/comments{/number}","comments_url":"https://api.github.com/repos/transcom/mymove/issues/1760/comments","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/0884b9590621ce84477b784defafc8b3706abc50","head":{"label":"transcom:sm-160935424-tsp-contact-info-move-summary-sidebar","ref":"sm-160935424-tsp-contact-info-move-summary-sidebar","sha":"0884b9590621ce84477b784defafc8b3706abc50","user":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"repo":{"id":114694829,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2OTQ4Mjk=","name":"mymove","full_name":"transcom/mymove","private":false,"owner":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/transcom/mymove","description":"MyMove Personal Property Prototype","fork":false,"url":"https://api.github.com/repos/transcom/mymove","forks_url":"https://api.github.com/repos/transcom/mymove/forks","keys_url":"https://api.github.com/repos/transcom/mymove/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transcom/mymove/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transcom/mymove/teams","hooks_url":"https://api.github.com/repos/transcom/mymove/hooks","issue_events_url":"https://api.github.com/repos/transcom/mymove/issues/events{/number}","events_url":"https://api.github.com/repos/transcom/mymove/events","assignees_url":"https://api.github.com/repos/transcom/mymove/assignees{/user}","branches_url":"https://api.github.com/repos/transcom/mymove/branches{/branch}","tags_url":"https://api.github.com/repos/transcom/mymove/tags","blobs_url":"https://api.github.com/repos/transcom/mymove/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transcom/mymove/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transcom/mymove/git/refs{/sha}","trees_url":"https://api.github.com/repos/transcom/mymove/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/{sha}","languages_url":"https://api.github.com/repos/transcom/mymove/languages","stargazers_url":"https://api.github.com/repos/transcom/mymove/stargazers","contributors_url":"https://api.github.com/repos/transcom/mymove/contributors","subscribers_url":"https://api.github.com/repos/transcom/mymove/subscribers","subscription_url":"https://api.github.com/repos/transcom/mymove/subscription","commits_url":"https://api.github.com/repos/transcom/mymove/commits{/sha}","git_commits_url":"https://api.github.com/repos/transcom/mymove/git/commits{/sha}","comments_url":"https://api.github.com/repos/transcom/mymove/comments{/number}","issue_comment_url":"https://api.github.com/repos/transcom/mymove/issues/comments{/number}","contents_url":"https://api.github.com/repos/transcom/mymove/contents/{+path}","compare_url":"https://api.github.com/repos/transcom/mymove/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transcom/mymove/merges","archive_url":"https://api.github.com/repos/transcom/mymove/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transcom/mymove/downloads","issues_url":"https://api.github.com/repos/transcom/mymove/issues{/number}","pulls_url":"https://api.github.com/repos/transcom/mymove/pulls{/number}","milestones_url":"https://api.github.com/repos/transcom/mymove/milestones{/number}","notifications_url":"https://api.github.com/repos/transcom/mymove/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transcom/mymove/labels{/name}","releases_url":"https://api.github.com/repos/transcom/mymove/releases{/id}","deployments_url":"https://api.github.com/repos/transcom/mymove/deployments","created_at":"2017-12-18T22:41:12Z","updated_at":"2019-02-19T20:56:26Z","pushed_at":"2019-02-20T01:08:07Z","git_url":"git://github.com/transcom/mymove.git","ssh_url":"[email protected]:transcom/mymove.git","clone_url":"https://github.com/transcom/mymove.git","svn_url":"https://github.com/transcom/mymove","homepage":"https://move.mil","size":36991,"stargazers_count":19,"watchers_count":19,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":32,"watchers":19,"default_branch":"master"}},"base":{"label":"transcom:master","ref":"master","sha":"e8e375af185b0197ff5491f0c9e8cd779909caf1","user":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"repo":{"id":114694829,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2OTQ4Mjk=","name":"mymove","full_name":"transcom/mymove","private":false,"owner":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/transcom/mymove","description":"MyMove Personal Property Prototype","fork":false,"url":"https://api.github.com/repos/transcom/mymove","forks_url":"https://api.github.com/repos/transcom/mymove/forks","keys_url":"https://api.github.com/repos/transcom/mymove/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transcom/mymove/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transcom/mymove/teams","hooks_url":"https://api.github.com/repos/transcom/mymove/hooks","issue_events_url":"https://api.github.com/repos/transcom/mymove/issues/events{/number}","events_url":"https://api.github.com/repos/transcom/mymove/events","assignees_url":"https://api.github.com/repos/transcom/mymove/assignees{/user}","branches_url":"https://api.github.com/repos/transcom/mymove/branches{/branch}","tags_url":"https://api.github.com/repos/transcom/mymove/tags","blobs_url":"https://api.github.com/repos/transcom/mymove/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transcom/mymove/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transcom/mymove/git/refs{/sha}","trees_url":"https://api.github.com/repos/transcom/mymove/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/{sha}","languages_url":"https://api.github.com/repos/transcom/mymove/languages","stargazers_url":"https://api.github.com/repos/transcom/mymove/stargazers","contributors_url":"https://api.github.com/repos/transcom/mymove/contributors","subscribers_url":"https://api.github.com/repos/transcom/mymove/subscribers","subscription_url":"https://api.github.com/repos/transcom/mymove/subscription","commits_url":"https://api.github.com/repos/transcom/mymove/commits{/sha}","git_commits_url":"https://api.github.com/repos/transcom/mymove/git/commits{/sha}","comments_url":"https://api.github.com/repos/transcom/mymove/comments{/number}","issue_comment_url":"https://api.github.com/repos/transcom/mymove/issues/comments{/number}","contents_url":"https://api.github.com/repos/transcom/mymove/contents/{+path}","compare_url":"https://api.github.com/repos/transcom/mymove/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transcom/mymove/merges","archive_url":"https://api.github.com/repos/transcom/mymove/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transcom/mymove/downloads","issues_url":"https://api.github.com/repos/transcom/mymove/issues{/number}","pulls_url":"https://api.github.com/repos/transcom/mymove/pulls{/number}","milestones_url":"https://api.github.com/repos/transcom/mymove/milestones{/number}","notifications_url":"https://api.github.com/repos/transcom/mymove/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transcom/mymove/labels{/name}","releases_url":"https://api.github.com/repos/transcom/mymove/releases{/id}","deployments_url":"https://api.github.com/repos/transcom/mymove/deployments","created_at":"2017-12-18T22:41:12Z","updated_at":"2019-02-19T20:56:26Z","pushed_at":"2019-02-20T01:08:07Z","git_url":"git://github.com/transcom/mymove.git","ssh_url":"[email protected]:transcom/mymove.git","clone_url":"https://github.com/transcom/mymove.git","svn_url":"https://github.com/transcom/mymove","homepage":"https://move.mil","size":36991,"stargazers_count":19,"watchers_count":19,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":32,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/transcom/mymove/pulls/1760"},"html":{"href":"https://github.com/transcom/mymove/pull/1760"},"issue":{"href":"https://api.github.com/repos/transcom/mymove/issues/1760"},"comments":{"href":"https://api.github.com/repos/transcom/mymove/issues/1760/comments"},"review_comments":{"href":"https://api.github.com/repos/transcom/mymove/pulls/1760/comments"},"review_comment":{"href":"https://api.github.com/repos/transcom/mymove/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/transcom/mymove/pulls/1760/commits"},"statuses":{"href":"https://api.github.com/repos/transcom/mymove/statuses/0884b9590621ce84477b784defafc8b3706abc50"}},"author_association":"CONTRIBUTOR"}}	{ "id": 114694829, "name": "transcom/mymove", "url": "https://api.github.com/repos/transcom/mymove" }	{ "id": 4434681, "login": "sarboc", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/4434681?", "url": "https://api.github.com/users/sarboc" }	{ "id": 34352343, "login": "transcom", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/34352343?", "url": "https://api.github.com/orgs/transcom" }	2019-02-20T01:10:37	9098729481	{"actor":{"display_login":"sarboc"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/transcom/mymove/pulls/comments/334152900","pull_request_review_id":300898033,"id":334152900,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDE1MjkwMA==","diff_hunk":"@@ -0,0 +1,40 @@\n+package models\n+\n+import (\n+\t\"time\"\n+\n+\t\"github.com/gobuffalo/pop\"\n+\t\"github.com/gobuffalo/validate\"\n+\t\"github.com/gobuffalo/validate/validators\"\n+\t\"github.com/gofrs/uuid\"\n+)\n+\n+// ReDomesticAccessorialPrice model struct\n+type ReDomesticAccessorialPrice struct {\n+\tID uuid.UUID `json:\"id\" db:\"id\"`\n+\tContractID uuid.UUID `json:\"contract_id\" db:\"contract_id\"`\n+\tServiceID uuid.UUID `json:\"service_id\" db:\"service_id\"`\n+\tServiceSchedule int `json:\"service_schedule\" db:\"service_schedule\"`","path":"pkg/models/re_domestic_accessorial_price.go","position":17,"original_position":17,"commit_id":"46ea9e740213cd613e43e70d8c8600dd1dcef2c4","original_commit_id":"46ea9e740213cd613e43e70d8c8600dd1dcef2c4","user":{"login":"reggieriser","id":4960757,"node_id":"MDQ6VXNlcjQ5NjA3NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/4960757?v=4","gravatar_id":"","url":"https://api.github.com/users/reggieriser","html_url":"https://github.com/reggieriser","followers_url":"https://api.github.com/users/reggieriser/followers","following_url":"https://api.github.com/users/reggieriser/following{/other_user}","gists_url":"https://api.github.com/users/reggieriser/gists{/gist_id}","starred_url":"https://api.github.com/users/reggieriser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reggieriser/subscriptions","organizations_url":"https://api.github.com/users/reggieriser/orgs","repos_url":"https://api.github.com/users/reggieriser/repos","events_url":"https://api.github.com/users/reggieriser/events{/privacy}","received_events_url":"https://api.github.com/users/reggieriser/received_events","type":"User","site_admin":false},"body":"This is noted as `services_schedule` in the migration (and the doc), so we need to fix one or the other. It looks like they use both names in the pricing spreadsheet, so I'm not sure that one makes more sense than the other.","created_at":"2019-10-11T19:58:28Z","updated_at":"2019-10-11T19:58:28Z","html_url":"https://github.com/transcom/mymove/pull/2798#discussion_r334152900","pull_request_url":"https://api.github.com/repos/transcom/mymove/pulls/2798","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/transcom/mymove/pulls/comments/334152900"},"html":{"href":"https://github.com/transcom/mymove/pull/2798#discussion_r334152900"},"pull_request":{"href":"https://api.github.com/repos/transcom/mymove/pulls/2798"}}},"pull_request":{"url":"https://api.github.com/repos/transcom/mymove/pulls/2798","id":327051614,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI3MDUxNjE0","html_url":"https://github.com/transcom/mymove/pull/2798","diff_url":"https://github.com/transcom/mymove/pull/2798.diff","patch_url":"https://github.com/transcom/mymove/pull/2798.patch","issue_url":"https://api.github.com/repos/transcom/mymove/issues/2798","number":2798,"state":"open","locked":false,"title":"Add tables for rate engine misc pricing","user":{"login":"LeDeep","id":3522044,"node_id":"MDQ6VXNlcjM1MjIwNDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3522044?v=4","gravatar_id":"","url":"https://api.github.com/users/LeDeep","html_url":"https://github.com/LeDeep","followers_url":"https://api.github.com/users/LeDeep/followers","following_url":"https://api.github.com/users/LeDeep/following{/other_user}","gists_url":"https://api.github.com/users/LeDeep/gists{/gist_id}","starred_url":"https://api.github.com/users/LeDeep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeDeep/subscriptions","organizations_url":"https://api.github.com/users/LeDeep/orgs","repos_url":"https://api.github.com/users/LeDeep/repos","events_url":"https://api.github.com/users/LeDeep/events{/privacy}","received_events_url":"https://api.github.com/users/LeDeep/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nAdds models and migration for rate engine miscellaneous pricing.\r\n\r\n## Setup\r\n\r\n```sh\r\nmake db_dev_migrate\r\n```\r\n\r\n## References\r\n\r\n* [Pivotal story](https://www.pivotaltracker.com/story/show/168357752) for this change\r\n* See this [document](https://docs.google.com/document/d/1yLU-QBxuRTmZSzhZAm4LqAqxAnESVIxMGGeR9xHRZlM/edit#heading=h.9l0h5vto7dvv) for writeup of data model.","created_at":"2019-10-11T06:37:05Z","updated_at":"2019-10-11T19:58:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c5315223d18d9059888a9a52ef505068b770efb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SirenaBorracha","id":16230705,"node_id":"MDQ6VXNlcjE2MjMwNzA1","avatar_url":"https://avatars2.githubusercontent.com/u/16230705?v=4","gravatar_id":"","url":"https://api.github.com/users/SirenaBorracha","html_url":"https://github.com/SirenaBorracha","followers_url":"https://api.github.com/users/SirenaBorracha/followers","following_url":"https://api.github.com/users/SirenaBorracha/following{/other_user}","gists_url":"https://api.github.com/users/SirenaBorracha/gists{/gist_id}","starred_url":"https://api.github.com/users/SirenaBorracha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SirenaBorracha/subscriptions","organizations_url":"https://api.github.com/users/SirenaBorracha/orgs","repos_url":"https://api.github.com/users/SirenaBorracha/repos","events_url":"https://api.github.com/users/SirenaBorracha/events{/privacy}","received_events_url":"https://api.github.com/users/SirenaBorracha/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1243276916,"node_id":"MDU6TGFiZWwxMjQzMjc2OTE2","url":"https://api.github.com/repos/transcom/mymove/labels/A-Team","name":"A-Team","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/transcom/mymove/pulls/2798/commits","review_comments_url":"https://api.github.com/repos/transcom/mymove/pulls/2798/comments","review_comment_url":"https://api.github.com/repos/transcom/mymove/pulls/comments{/number}","comments_url":"https://api.github.com/repos/transcom/mymove/issues/2798/comments","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/46ea9e740213cd613e43e70d8c8600dd1dcef2c4","head":{"label":"transcom:rate-engine-misc-pricing-models","ref":"rate-engine-misc-pricing-models","sha":"46ea9e740213cd613e43e70d8c8600dd1dcef2c4","user":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"repo":{"id":114694829,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2OTQ4Mjk=","name":"mymove","full_name":"transcom/mymove","private":false,"owner":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/transcom/mymove","description":"MyMove Personal Property Prototype","fork":false,"url":"https://api.github.com/repos/transcom/mymove","forks_url":"https://api.github.com/repos/transcom/mymove/forks","keys_url":"https://api.github.com/repos/transcom/mymove/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transcom/mymove/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transcom/mymove/teams","hooks_url":"https://api.github.com/repos/transcom/mymove/hooks","issue_events_url":"https://api.github.com/repos/transcom/mymove/issues/events{/number}","events_url":"https://api.github.com/repos/transcom/mymove/events","assignees_url":"https://api.github.com/repos/transcom/mymove/assignees{/user}","branches_url":"https://api.github.com/repos/transcom/mymove/branches{/branch}","tags_url":"https://api.github.com/repos/transcom/mymove/tags","blobs_url":"https://api.github.com/repos/transcom/mymove/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transcom/mymove/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transcom/mymove/git/refs{/sha}","trees_url":"https://api.github.com/repos/transcom/mymove/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/{sha}","languages_url":"https://api.github.com/repos/transcom/mymove/languages","stargazers_url":"https://api.github.com/repos/transcom/mymove/stargazers","contributors_url":"https://api.github.com/repos/transcom/mymove/contributors","subscribers_url":"https://api.github.com/repos/transcom/mymove/subscribers","subscription_url":"https://api.github.com/repos/transcom/mymove/subscription","commits_url":"https://api.github.com/repos/transcom/mymove/commits{/sha}","git_commits_url":"https://api.github.com/repos/transcom/mymove/git/commits{/sha}","comments_url":"https://api.github.com/repos/transcom/mymove/comments{/number}","issue_comment_url":"https://api.github.com/repos/transcom/mymove/issues/comments{/number}","contents_url":"https://api.github.com/repos/transcom/mymove/contents/{+path}","compare_url":"https://api.github.com/repos/transcom/mymove/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transcom/mymove/merges","archive_url":"https://api.github.com/repos/transcom/mymove/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transcom/mymove/downloads","issues_url":"https://api.github.com/repos/transcom/mymove/issues{/number}","pulls_url":"https://api.github.com/repos/transcom/mymove/pulls{/number}","milestones_url":"https://api.github.com/repos/transcom/mymove/milestones{/number}","notifications_url":"https://api.github.com/repos/transcom/mymove/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transcom/mymove/labels{/name}","releases_url":"https://api.github.com/repos/transcom/mymove/releases{/id}","deployments_url":"https://api.github.com/repos/transcom/mymove/deployments","created_at":"2017-12-18T22:41:12Z","updated_at":"2019-10-11T18:29:12Z","pushed_at":"2019-10-11T19:47:35Z","git_url":"git://github.com/transcom/mymove.git","ssh_url":"[email protected]:transcom/mymove.git","clone_url":"https://github.com/transcom/mymove.git","svn_url":"https://github.com/transcom/mymove","homepage":"https://move.mil","size":105413,"stargazers_count":21,"watchers_count":21,"language":"TSQL","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":16,"open_issues":21,"watchers":21,"default_branch":"master"}},"base":{"label":"transcom:master","ref":"master","sha":"50a3ca53696a56d49b5611335c01dff2fe8d880e","user":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"repo":{"id":114694829,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2OTQ4Mjk=","name":"mymove","full_name":"transcom/mymove","private":false,"owner":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/transcom/mymove","description":"MyMove Personal Property Prototype","fork":false,"url":"https://api.github.com/repos/transcom/mymove","forks_url":"https://api.github.com/repos/transcom/mymove/forks","keys_url":"https://api.github.com/repos/transcom/mymove/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transcom/mymove/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transcom/mymove/teams","hooks_url":"https://api.github.com/repos/transcom/mymove/hooks","issue_events_url":"https://api.github.com/repos/transcom/mymove/issues/events{/number}","events_url":"https://api.github.com/repos/transcom/mymove/events","assignees_url":"https://api.github.com/repos/transcom/mymove/assignees{/user}","branches_url":"https://api.github.com/repos/transcom/mymove/branches{/branch}","tags_url":"https://api.github.com/repos/transcom/mymove/tags","blobs_url":"https://api.github.com/repos/transcom/mymove/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transcom/mymove/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transcom/mymove/git/refs{/sha}","trees_url":"https://api.github.com/repos/transcom/mymove/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/{sha}","languages_url":"https://api.github.com/repos/transcom/mymove/languages","stargazers_url":"https://api.github.com/repos/transcom/mymove/stargazers","contributors_url":"https://api.github.com/repos/transcom/mymove/contributors","subscribers_url":"https://api.github.com/repos/transcom/mymove/subscribers","subscription_url":"https://api.github.com/repos/transcom/mymove/subscription","commits_url":"https://api.github.com/repos/transcom/mymove/commits{/sha}","git_commits_url":"https://api.github.com/repos/transcom/mymove/git/commits{/sha}","comments_url":"https://api.github.com/repos/transcom/mymove/comments{/number}","issue_comment_url":"https://api.github.com/repos/transcom/mymove/issues/comments{/number}","contents_url":"https://api.github.com/repos/transcom/mymove/contents/{+path}","compare_url":"https://api.github.com/repos/transcom/mymove/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transcom/mymove/merges","archive_url":"https://api.github.com/repos/transcom/mymove/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transcom/mymove/downloads","issues_url":"https://api.github.com/repos/transcom/mymove/issues{/number}","pulls_url":"https://api.github.com/repos/transcom/mymove/pulls{/number}","milestones_url":"https://api.github.com/repos/transcom/mymove/milestones{/number}","notifications_url":"https://api.github.com/repos/transcom/mymove/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transcom/mymove/labels{/name}","releases_url":"https://api.github.com/repos/transcom/mymove/releases{/id}","deployments_url":"https://api.github.com/repos/transcom/mymove/deployments","created_at":"2017-12-18T22:41:12Z","updated_at":"2019-10-11T18:29:12Z","pushed_at":"2019-10-11T19:47:35Z","git_url":"git://github.com/transcom/mymove.git","ssh_url":"[email protected]:transcom/mymove.git","clone_url":"https://github.com/transcom/mymove.git","svn_url":"https://github.com/transcom/mymove","homepage":"https://move.mil","size":105413,"stargazers_count":21,"watchers_count":21,"language":"TSQL","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":16,"open_issues":21,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/transcom/mymove/pulls/2798"},"html":{"href":"https://github.com/transcom/mymove/pull/2798"},"issue":{"href":"https://api.github.com/repos/transcom/mymove/issues/2798"},"comments":{"href":"https://api.github.com/repos/transcom/mymove/issues/2798/comments"},"review_comments":{"href":"https://api.github.com/repos/transcom/mymove/pulls/2798/comments"},"review_comment":{"href":"https://api.github.com/repos/transcom/mymove/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/transcom/mymove/pulls/2798/commits"},"statuses":{"href":"https://api.github.com/repos/transcom/mymove/statuses/46ea9e740213cd613e43e70d8c8600dd1dcef2c4"}},"author_association":"CONTRIBUTOR"}}	{ "id": 114694829, "name": "transcom/mymove", "url": "https://api.github.com/repos/transcom/mymove" }	{ "id": 4960757, "login": "reggieriser", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/4960757?", "url": "https://api.github.com/users/reggieriser" }	{ "id": 34352343, "login": "transcom", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/34352343?", "url": "https://api.github.com/orgs/transcom" }	2019-10-11T19:58:28	10613797829	{"actor":{"display_login":"reggieriser"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/pulls/comments/265703672","pull_request_review_id":214661108,"id":265703672,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NTcwMzY3Mg==","diff_hunk":"@@ -0,0 +1,289 @@\n+#### Database storing Food events ####\n+default persistent_.mas_food_database = {}\n+\n+\n+#### Making a menu area, and types ####\n+init 1 python in mas_food:\n+ #The food db\n+ food_db = dict()\n+\n+ #Menu dimensions/options\n+ FOOD_X = 680\n+ FOOD_Y = 40\n+ FOOD_W = 560\n+ FOOD_H = 640\n+ FOOD_XALIGN = -0.05\n+ FOOD_AREA = (FOOD_X, FOOD_Y, FOOD_W, FOOD_H)\n+ FOOD_RETURN = \"Nothing\"\n+\n+#### Starting Event for I'm Eating ####\n+init 5 python:\n+ addEvent(\n+ Event(\n+ persistent.event_database,\n+ eventlabel=\"monika_imeating\",\n+ category=['you'],\n+ prompt=\"I'm Eating\",\n+ pool=True,\n+ unlocked=True\n+ )\n+ )\n+\n+label monika_imeating:\n+ if mas_getEV('monika_imeating').shown_count == 0:\n+ m 1eua \"You know, although I don't get hungry, I still miss enjoying good food.\"\n+ m 4eub \"Like Natsuki's cupcakes.\"\n+ m 4eua \"For a bunch of lines of code, they were pretty tasty.\"\n+ m 3hua \"Are you eating anything right now, [player]?\"\n+ else:\n+ m 3eud \"I could really go for something to eat right now.\"\n+ m 1eub \"How about you, [player]?\"\n+ m 1eua \"Do you want anything to eat?\"\n+\n+ python:\n+ import store.mas_food as mas_food\n+\n+ #Build the list of food items\n+ food_menu_items = [\n+ (ev.prompt, ev.eventlabel, False, False)\n+ for ev_label, ev in mas_food.food_db.iteritems()\n+ if 'food' in ev.category\n+ ]\n+\n+ #Sort said list\n+ food_menu_items.sort()\n+\n+ #Create the 'Nothing' option\n+ final_item = (mas_food.FOOD_RETURN, False, False, False, 20)\n+\n+ #Display the scrollable\n+ show monika at t21\n+ call screen mas_gen_scrollable_menu(food_menu_items, mas_food.FOOD_AREA, mas_food.FOOD_XALIGN, final_item=final_item)\n+ show monika at t11\n+\n+ #Calling appropriate label (or exiting out)\n+ if _return:\n+ $ pushEvent(_return)\n+ $ mas_food_current = _return\n+ else:\n+ m 1eub \"Well alright.\"\n+ m 1eua \"Just let me know if you change your mind.\"\n+ m 1hua\"I don't mind waiting for you to come back.\"\n+ return\n+\n+init 5 python:\n+ addEvent(\n+ Event(\n+ persistent._mas_food_database,\n+ eventlabel='mas_food_pizza',\n+ prompt='Pizza',\n+ category=['food'],\n+ unlocked=True\n+ ),\n+ code=\"FOO\"\n+ )\n+\n+label mas_food_pizza:\n+ m 1hua \"Pizza is such a great treat!\"\n+ m 1lud \"It's usually not the healthiest food, of course.\"\n+ m 1eua \"However, I think on occasion, it's fine to just treat yourself, you know?\"\n+ m 3eua \"I think it's really interesting that pizza was created almost by accident.\"\n+ m 3eub \"Italian bakery workers would use excess dough and left-over ingredients from their days of work to feed the poor.\"\n+ m 1eub \"Who would have thought that they were making what would become one of the most popular foods today?\"\n+ m 1eua \"As I'm sure you guessed I always order a vegetarian pizza myself, but I want you to know that I would never judge you if you're eating a slice with pepperoni, sausage or any other meat, [player].\"\n+ m 1hua \"What always matters to me is that you're happy!\"\n+ return\n+\n+init 5 python:\n+ addEvent(\n+ Event(\n+ persistent._mas_food_database,\n+ eventlabel='mas_food_salad',\n+ prompt='Salad',\n+ category=['food'],\n+ unlocked=True\n+ ),\n+ code=\"FOO\"\n+ )\n+\n+label mas_food_salad:\n+ m 1hua \"That's great to hear, [player]!\"\n+ m 1eua \"I'm so glad to hear that you are taking care of yourself and eating healthy.\"\n+ m 3eua \"Salads are definitely one of my personal favorite foods.\"\n+ m 1eub \"There are so many things you can do with them.\"\n+ m 3eub \"Like all of the different kinds of lettuce, dressings and toppings there are to choose from.\"\n+ m 1eua \"If you like to keep it simple, a little bit of shredded cheese sprinkled on top is always really good!\"\n+ m \"Would you ever make me a salad, [player]?\"\n+ m 1sub \"The thought of you preparing one of my favorite meals is so surreal.\"\n+ m 1eub \"That would really make me feel loved, my dear.\"\n+return\n+\n+#### Start Of The I'm Drinking Event ####\n+init 5 python:\n+ addEvent(\n+ Event(\n+ persistent.event_database,\n+ eventlabel=\"monika_imdrinking\",\n+ category=['you'],\n+ prompt=\"I'm Drinking\",\n+ pool=True,\n+ unlocked=True\n+ )\n+ )\n+\n+label monika_imdrinking:\n+ if mas_getEV('monika_imdrinking').shown_count == 0:\n+ m 1eua \"Hey, [player]...\"\n+ m 4eub \"Remember how I told you earlier to make sure you're staying hydrated?\"\n+ m 4eua \"I just wanted to know if you listened.\"\n+ m 3hua \"Are you drinking anything at the moment, [player]?\"\n+ else:\n+ m 3hub \"You know, I'm getting a little thirsty.\"\n+ m 3eua \"How about you, [player]?\"\n+ m 1eub \"Are you having anything to drink?\"\n+\n+ python:\n+ import store.mas_food as mas_food\n+\n+ #Build the drink list\n+ food_menu_items = [\n+ (ev.prompt, ev.eventlabel, False, False)\n+ for ev_label, ev in mas_food.food_db.iteritems()\n+ if 'drink' in ev.category\n+ ]\n+\n+ #Sort the drink list\n+ food_menu_items.sort()\n+\n+ #Create the 'Nothin' option\n+ final_item = (mas_food.FOOD_RETURN, False, False, False, 20)\n+\n+ #Display the scrollable\n+ show monika at t21\n+ call screen mas_gen_scrollable_menu(food_menu_items, mas_food.FOOD_AREA, mas_food.FOOD_XALIGN, final_item=final_item)\n+ show monika at t11\n+\n+ #Call appropriate label (or exit dlg)\n+ if _return:\n+ $ pushEvent(_return)\n+ $ mas_food_current = _return\n+ else:\n+ m 1lud \"Promise me you'll get a glass of water at least.\"\n+ m 1eud \"I just want to make sure you're staying healthy and hydrated, my love.\"\n+ m 1eua \"Even if that means waiting for you while you get it.\"\n+ return\n+\n+\n+init 5 python:\n+ addEvent(\n+ Event(\n+ persistent._mas_food_database,\n+ eventlabel='mas_food_coffee',\n+ prompt='Coffee',\n+ category=['drink'],\n+ unlocked=True\n+ ),\n+ code=\"FOO\"\n+ )\n+\n+label mas_food_coffee:\n+ if mas_getEV(persistent._mas_acs_enable_coffee).shown_count == 0:\n+ m 1eua \"That sounds wonderful!\"\n+ m \"I really miss having coffee.\"\n+ m 3eub \"I would always have a cup before and after school.\"\n+ m 3hub \"Maybe even sometimes during class.\"\n+ m 2hub \"Who knows, maybe you and I could share a glass, [player].\"\n+ else:\n+ m \"That's really cool, [player]!\"\n+ m \"I'm so glad you gave me some earlier.\"\n+ m \"Now we can drink some together.\"\n+ return\n+\n+init 5 python:\n+ addEvent(\n+ Event(\n+ persistent._mas_food_database,\n+ eventlabel='mas_food_water',\n+ prompt='Water',\n+ category=['drink'],\n+ unlocked=True\n+ ),\n+ code=\"FOO\"\n+ )\n+\n+label mas_food_water:\n+ m 1eua \"I'm really happy to hear that, [player]!\"\n+ m 1eub \"Water is probably the healthiest thing that you could drink.\"\n+ m 3eua \"Seeing how we can only live for a few days without it.\"\n+ m 3eud \"Just promise you get plenty to drink each day.\"\n+ m 2lud \"I don't want you getting sick because you didn't drink any.\"\n+ m 2eua \"Even if it's just a glass or two, do it for me.\"\n+ return\n+\n+init 5 python:\n+ addEvent(\n+ Event(\n+ persistent._mas_food_database,\n+ eventlabel='mas_food_milk',\n+ prompt='Milk',\n+ category=['drink'],\n+ unlocked=True\n+ ),\n+ code=\"FOO\"\n+ )\n+\n+label mas_food_milk:\n+ m 1eub \"You know, I've never really drank a lot milk before.\"\n+ m 3eub \"It wasn't because I didn't like it either.\"","path":"Monika After Story/game/script-food.rpy","position":237,"original_position":237,"commit_id":"b95e723c51a085e8298e8a1d3c5441eafbf4e0cf","original_commit_id":"b95e723c51a085e8298e8a1d3c5441eafbf4e0cf","user":{"login":"Rai99","id":38822045,"node_id":"MDQ6VXNlcjM4ODIyMDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/38822045?v=4","gravatar_id":"","url":"https://api.github.com/users/Rai99","html_url":"https://github.com/Rai99","followers_url":"https://api.github.com/users/Rai99/followers","following_url":"https://api.github.com/users/Rai99/following{/other_user}","gists_url":"https://api.github.com/users/Rai99/gists{/gist_id}","starred_url":"https://api.github.com/users/Rai99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rai99/subscriptions","organizations_url":"https://api.github.com/users/Rai99/orgs","repos_url":"https://api.github.com/users/Rai99/repos","events_url":"https://api.github.com/users/Rai99/events{/privacy}","received_events_url":"https://api.github.com/users/Rai99/received_events","type":"User","site_admin":false},"body":"I think mouth `d` fits here better. (eud)","created_at":"2019-03-14T18:14:51Z","updated_at":"2019-03-14T18:28:28Z","html_url":"https://github.com/Monika-After-Story/MonikaModDev/pull/3834#discussion_r265703672","pull_request_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/pulls/3834","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/pulls/comments/265703672"},"html":{"href":"https://github.com/Monika-After-Story/MonikaModDev/pull/3834#discussion_r265703672"},"pull_request":{"href":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/pulls/3834"}}},"pull_request":{"url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/pulls/3834","id":255590049,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1NTkwMDQ5","html_url":"https://github.com/Monika-After-Story/MonikaModDev/pull/3834","diff_url":"https://github.com/Monika-After-Story/MonikaModDev/pull/3834.diff","patch_url":"https://github.com/Monika-After-Story/MonikaModDev/pull/3834.patch","issue_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/issues/3834","number":3834,"state":"open","locked":false,"title":"script-food topic","user":{"login":"Ulvsblakk","id":35550690,"node_id":"MDQ6VXNlcjM1NTUwNjkw","avatar_url":"https://avatars3.githubusercontent.com/u/35550690?v=4","gravatar_id":"","url":"https://api.github.com/users/Ulvsblakk","html_url":"https://github.com/Ulvsblakk","followers_url":"https://api.github.com/users/Ulvsblakk/followers","following_url":"https://api.github.com/users/Ulvsblakk/following{/other_user}","gists_url":"https://api.github.com/users/Ulvsblakk/gists{/gist_id}","starred_url":"https://api.github.com/users/Ulvsblakk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ulvsblakk/subscriptions","organizations_url":"https://api.github.com/users/Ulvsblakk/orgs","repos_url":"https://api.github.com/users/Ulvsblakk/repos","events_url":"https://api.github.com/users/Ulvsblakk/events{/privacy}","received_events_url":"https://api.github.com/users/Ulvsblakk/received_events","type":"User","site_admin":false},"body":"Made a database for food topics. Edited the dialogue a little bit. Can still add more, but I am finished for tonight. \r\nAlso changed it to be a pool type topic so it does not show up on the main talk menu. Thank you for the advice and suggestions everyone. ","created_at":"2019-02-23T04:34:46Z","updated_at":"2019-03-14T18:28:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6da83336ce8948637a0e9a117758fba4710a56f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":774347502,"node_id":"MDU6TGFiZWw3NzQzNDc1MDI=","url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/labels/awaiting%20changes","name":"awaiting changes","color":"95edc1","default":false},{"id":853464710,"node_id":"MDU6TGFiZWw4NTM0NjQ3MTA=","url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/labels/awaiting%20code%20review","name":"awaiting code review","color":"bfdadc","default":false},{"id":767155876,"node_id":"MDU6TGFiZWw3NjcxNTU4NzY=","url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/labels/awaiting%20review","name":"awaiting review","color":"f9d0c4","default":false},{"id":774321827,"node_id":"MDU6TGFiZWw3NzQzMjE4Mjc=","url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/labels/awaiting%20testing","name":"awaiting testing","color":"870608","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/pulls/3834/commits","review_comments_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/pulls/3834/comments","review_comment_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/issues/3834/comments","statuses_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/statuses/b95e723c51a085e8298e8a1d3c5441eafbf4e0cf","head":{"label":"Ulvsblakk:master","ref":"master","sha":"b95e723c51a085e8298e8a1d3c5441eafbf4e0cf","user":{"login":"Ulvsblakk","id":35550690,"node_id":"MDQ6VXNlcjM1NTUwNjkw","avatar_url":"https://avatars3.githubusercontent.com/u/35550690?v=4","gravatar_id":"","url":"https://api.github.com/users/Ulvsblakk","html_url":"https://github.com/Ulvsblakk","followers_url":"https://api.github.com/users/Ulvsblakk/followers","following_url":"https://api.github.com/users/Ulvsblakk/following{/other_user}","gists_url":"https://api.github.com/users/Ulvsblakk/gists{/gist_id}","starred_url":"https://api.github.com/users/Ulvsblakk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ulvsblakk/subscriptions","organizations_url":"https://api.github.com/users/Ulvsblakk/orgs","repos_url":"https://api.github.com/users/Ulvsblakk/repos","events_url":"https://api.github.com/users/Ulvsblakk/events{/privacy}","received_events_url":"https://api.github.com/users/Ulvsblakk/received_events","type":"User","site_admin":false},"repo":{"id":117935999,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc5MzU5OTk=","name":"MonikaModDev","full_name":"Ulvsblakk/MonikaModDev","private":false,"owner":{"login":"Ulvsblakk","id":35550690,"node_id":"MDQ6VXNlcjM1NTUwNjkw","avatar_url":"https://avatars3.githubusercontent.com/u/35550690?v=4","gravatar_id":"","url":"https://api.github.com/users/Ulvsblakk","html_url":"https://github.com/Ulvsblakk","followers_url":"https://api.github.com/users/Ulvsblakk/followers","following_url":"https://api.github.com/users/Ulvsblakk/following{/other_user}","gists_url":"https://api.github.com/users/Ulvsblakk/gists{/gist_id}","starred_url":"https://api.github.com/users/Ulvsblakk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ulvsblakk/subscriptions","organizations_url":"https://api.github.com/users/Ulvsblakk/orgs","repos_url":"https://api.github.com/users/Ulvsblakk/repos","events_url":"https://api.github.com/users/Ulvsblakk/events{/privacy}","received_events_url":"https://api.github.com/users/Ulvsblakk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Ulvsblakk/MonikaModDev","description":"DDLC fan mod to extend Monika","fork":true,"url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev","forks_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/forks","keys_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/teams","hooks_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/hooks","issue_events_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/issues/events{/number}","events_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/events","assignees_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/assignees{/user}","branches_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/branches{/branch}","tags_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/tags","blobs_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/statuses/{sha}","languages_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/languages","stargazers_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/stargazers","contributors_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/contributors","subscribers_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/subscribers","subscription_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/subscription","commits_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/contents/{+path}","compare_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/merges","archive_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/downloads","issues_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/issues{/number}","pulls_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/pulls{/number}","milestones_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/milestones{/number}","notifications_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/labels{/name}","releases_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/releases{/id}","deployments_url":"https://api.github.com/repos/Ulvsblakk/MonikaModDev/deployments","created_at":"2018-01-18T05:18:40Z","updated_at":"2019-03-14T03:19:29Z","pushed_at":"2019-03-14T03:19:21Z","git_url":"git://github.com/Ulvsblakk/MonikaModDev.git","ssh_url":"[email protected]:Ulvsblakk/MonikaModDev.git","clone_url":"https://github.com/Ulvsblakk/MonikaModDev.git","svn_url":"https://github.com/Ulvsblakk/MonikaModDev","homepage":"http://www.monikaafterstory.com/","size":725023,"stargazers_count":1,"watchers_count":1,"language":"Ren'Py","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Monika-After-Story:content","ref":"content","sha":"700634595bb500b415a906c66a75e4573ec092c7","user":{"login":"Monika-After-Story","id":34377339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0Mzc3MzM5","avatar_url":"https://avatars3.githubusercontent.com/u/34377339?v=4","gravatar_id":"","url":"https://api.github.com/users/Monika-After-Story","html_url":"https://github.com/Monika-After-Story","followers_url":"https://api.github.com/users/Monika-After-Story/followers","following_url":"https://api.github.com/users/Monika-After-Story/following{/other_user}","gists_url":"https://api.github.com/users/Monika-After-Story/gists{/gist_id}","starred_url":"https://api.github.com/users/Monika-After-Story/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Monika-After-Story/subscriptions","organizations_url":"https://api.github.com/users/Monika-After-Story/orgs","repos_url":"https://api.github.com/users/Monika-After-Story/repos","events_url":"https://api.github.com/users/Monika-After-Story/events{/privacy}","received_events_url":"https://api.github.com/users/Monika-After-Story/received_events","type":"Organization","site_admin":false},"repo":{"id":104920864,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQ5MjA4NjQ=","name":"MonikaModDev","full_name":"Monika-After-Story/MonikaModDev","private":false,"owner":{"login":"Monika-After-Story","id":34377339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0Mzc3MzM5","avatar_url":"https://avatars3.githubusercontent.com/u/34377339?v=4","gravatar_id":"","url":"https://api.github.com/users/Monika-After-Story","html_url":"https://github.com/Monika-After-Story","followers_url":"https://api.github.com/users/Monika-After-Story/followers","following_url":"https://api.github.com/users/Monika-After-Story/following{/other_user}","gists_url":"https://api.github.com/users/Monika-After-Story/gists{/gist_id}","starred_url":"https://api.github.com/users/Monika-After-Story/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Monika-After-Story/subscriptions","organizations_url":"https://api.github.com/users/Monika-After-Story/orgs","repos_url":"https://api.github.com/users/Monika-After-Story/repos","events_url":"https://api.github.com/users/Monika-After-Story/events{/privacy}","received_events_url":"https://api.github.com/users/Monika-After-Story/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Monika-After-Story/MonikaModDev","description":"DDLC fan mod to extend Monika","fork":false,"url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev","forks_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/forks","keys_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/teams","hooks_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/hooks","issue_events_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/issues/events{/number}","events_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/events","assignees_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/assignees{/user}","branches_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/branches{/branch}","tags_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/tags","blobs_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/git/refs{/sha}","trees_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/statuses/{sha}","languages_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/languages","stargazers_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/stargazers","contributors_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/contributors","subscribers_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/subscribers","subscription_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/subscription","commits_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/commits{/sha}","git_commits_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/git/commits{/sha}","comments_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/comments{/number}","issue_comment_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/issues/comments{/number}","contents_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/contents/{+path}","compare_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/merges","archive_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/downloads","issues_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/issues{/number}","pulls_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/pulls{/number}","milestones_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/milestones{/number}","notifications_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/labels{/name}","releases_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/releases{/id}","deployments_url":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/deployments","created_at":"2017-09-26T18:07:02Z","updated_at":"2019-03-13T03:31:15Z","pushed_at":"2019-03-14T03:19:24Z","git_url":"git://github.com/Monika-After-Story/MonikaModDev.git","ssh_url":"[email protected]:Monika-After-Story/MonikaModDev.git","clone_url":"https://github.com/Monika-After-Story/MonikaModDev.git","svn_url":"https://github.com/Monika-After-Story/MonikaModDev","homepage":"http://www.monikaafterstory.com/","size":729221,"stargazers_count":508,"watchers_count":508,"language":"Ren'Py","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":334,"mirror_url":null,"archived":false,"open_issues_count":203,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":334,"open_issues":203,"watchers":508,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/pulls/3834"},"html":{"href":"https://github.com/Monika-After-Story/MonikaModDev/pull/3834"},"issue":{"href":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/issues/3834"},"comments":{"href":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/issues/3834/comments"},"review_comments":{"href":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/pulls/3834/comments"},"review_comment":{"href":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/pulls/3834/commits"},"statuses":{"href":"https://api.github.com/repos/Monika-After-Story/MonikaModDev/statuses/b95e723c51a085e8298e8a1d3c5441eafbf4e0cf"}},"author_association":"CONTRIBUTOR"}}	{ "id": 104920864, "name": "Monika-After-Story/MonikaModDev", "url": "https://api.github.com/repos/Monika-After-Story/MonikaModDev" }	{ "id": 38822045, "login": "Rai99", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/38822045?", "url": "https://api.github.com/users/Rai99" }	{ "id": 34377339, "login": "Monika-After-Story", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/34377339?", "url": "https://api.github.com/orgs/Monika-After-Story" }	2019-03-14T18:14:51	9245447712	{"actor":{"display_login":"Rai99"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/iov-one/weave/pulls/comments/281088695","pull_request_review_id":233851615,"id":281088695,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MTA4ODY5NQ==","diff_hunk":"@@ -124,3 +112,47 @@ func (m UpdateElectorateMsg) Validate() error {\n \t}\n \treturn nil\n }\n+\n+func (CreateElectorateUpdateProposalMsg) Path() string {\n+\treturn pathCreateElectorateUpdateProposalMsg\n+}\n+\n+func (m CreateElectorateUpdateProposalMsg) Validate() error {\n+\tfor i, v := range m.DiffElectors {\n+\t\tif v.Weight > maxWeight {\n+\t\t\treturn errors.Wrap(errors.ErrInvalidInput, \"must not be greater max weight\")\n+\t\t}\n+\t\tif err := v.Address.Validate(); err != nil {\n+\t\t\treturn errors.Wrapf(err, \"address at position: %d\", i)\n+\t\t}\n+\t}\n+\treturn validateCreateProposal(&m)\n+}\n+\n+type commonCreateProposalData interface {\n+\tGetTitle() string\n+\tGetDescription() string\n+\tGetElectorateID() []byte\n+\tGetStartTime() weave.UnixTime\n+\tGetAuthor() weave.Address\n+}\n+\n+func validateCreateProposal(m commonCreateProposalData) error {\n+\terr := m.GetAuthor().Validate()","path":"x/gov/msg.go","position":93,"original_position":93,"commit_id":"a4c9850e373761cab8cedc11ae785f3362588b1d","original_commit_id":"a4c9850e373761cab8cedc11ae785f3362588b1d","user":{"login":"husio","id":1517,"node_id":"MDQ6VXNlcjE1MTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1517?v=4","gravatar_id":"","url":"https://api.github.com/users/husio","html_url":"https://github.com/husio","followers_url":"https://api.github.com/users/husio/followers","following_url":"https://api.github.com/users/husio/following{/other_user}","gists_url":"https://api.github.com/users/husio/gists{/gist_id}","starred_url":"https://api.github.com/users/husio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/husio/subscriptions","organizations_url":"https://api.github.com/users/husio/orgs","repos_url":"https://api.github.com/users/husio/repos","events_url":"https://api.github.com/users/husio/events{/privacy}","received_events_url":"https://api.github.com/users/husio/received_events","type":"User","site_admin":false},"body":"This is unusual when reading this code. There is an `err` created here, but it is not checked straight away. Instead, it is (maybe) used later. Weirdly it can be ignored if some earlier validation rule fails.\r\nI think it is much better to keep author validation result close to where it is used. Maybe `switch` is not the right construct to use here?","created_at":"2019-05-06T07:50:52Z","updated_at":"2019-05-06T07:51:44Z","html_url":"https://github.com/iov-one/weave/pull/581#discussion_r281088695","pull_request_url":"https://api.github.com/repos/iov-one/weave/pulls/581","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/iov-one/weave/pulls/comments/281088695"},"html":{"href":"https://github.com/iov-one/weave/pull/581#discussion_r281088695"},"pull_request":{"href":"https://api.github.com/repos/iov-one/weave/pulls/581"}}},"pull_request":{"url":"https://api.github.com/repos/iov-one/weave/pulls/581","id":275751667,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc1NzUxNjY3","html_url":"https://github.com/iov-one/weave/pull/581","diff_url":"https://github.com/iov-one/weave/pull/581.diff","patch_url":"https://github.com/iov-one/weave/pull/581.patch","issue_url":"https://api.github.com/repos/iov-one/weave/issues/581","number":581,"state":"open","locked":false,"title":"Update electorate via gov proposal","user":{"login":"alpe","id":28003,"node_id":"MDQ6VXNlcjI4MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/28003?v=4","gravatar_id":"","url":"https://api.github.com/users/alpe","html_url":"https://github.com/alpe","followers_url":"https://api.github.com/users/alpe/followers","following_url":"https://api.github.com/users/alpe/following{/other_user}","gists_url":"https://api.github.com/users/alpe/gists{/gist_id}","starred_url":"https://api.github.com/users/alpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alpe/subscriptions","organizations_url":"https://api.github.com/users/alpe/orgs","repos_url":"https://api.github.com/users/alpe/repos","events_url":"https://api.github.com/users/alpe/events{/privacy}","received_events_url":"https://api.github.com/users/alpe/received_events","type":"User","site_admin":false},"body":"Initial version with lot of duplication and hard coded logic.\r\n","created_at":"2019-05-03T15:21:02Z","updated_at":"2019-05-06T07:51:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79ea410c0e639a2269c0fd4df0db8c0c7a45a1fa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iov-one/weave/pulls/581/commits","review_comments_url":"https://api.github.com/repos/iov-one/weave/pulls/581/comments","review_comment_url":"https://api.github.com/repos/iov-one/weave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iov-one/weave/issues/581/comments","statuses_url":"https://api.github.com/repos/iov-one/weave/statuses/a4c9850e373761cab8cedc11ae785f3362588b1d","head":{"label":"iov-one:update_electorate_459","ref":"update_electorate_459","sha":"a4c9850e373761cab8cedc11ae785f3362588b1d","user":{"login":"iov-one","id":34400253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDAwMjUz","avatar_url":"https://avatars2.githubusercontent.com/u/34400253?v=4","gravatar_id":"","url":"https://api.github.com/users/iov-one","html_url":"https://github.com/iov-one","followers_url":"https://api.github.com/users/iov-one/followers","following_url":"https://api.github.com/users/iov-one/following{/other_user}","gists_url":"https://api.github.com/users/iov-one/gists{/gist_id}","starred_url":"https://api.github.com/users/iov-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iov-one/subscriptions","organizations_url":"https://api.github.com/users/iov-one/orgs","repos_url":"https://api.github.com/users/iov-one/repos","events_url":"https://api.github.com/users/iov-one/events{/privacy}","received_events_url":"https://api.github.com/users/iov-one/received_events","type":"Organization","site_admin":false},"repo":{"id":118366160,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgzNjYxNjA=","name":"weave","full_name":"iov-one/weave","private":false,"owner":{"login":"iov-one","id":34400253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDAwMjUz","avatar_url":"https://avatars2.githubusercontent.com/u/34400253?v=4","gravatar_id":"","url":"https://api.github.com/users/iov-one","html_url":"https://github.com/iov-one","followers_url":"https://api.github.com/users/iov-one/followers","following_url":"https://api.github.com/users/iov-one/following{/other_user}","gists_url":"https://api.github.com/users/iov-one/gists{/gist_id}","starred_url":"https://api.github.com/users/iov-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iov-one/subscriptions","organizations_url":"https://api.github.com/users/iov-one/orgs","repos_url":"https://api.github.com/users/iov-one/repos","events_url":"https://api.github.com/users/iov-one/events{/privacy}","received_events_url":"https://api.github.com/users/iov-one/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iov-one/weave","description":"Easy-to-use framework to build Tendermint ABCI applications","fork":false,"url":"https://api.github.com/repos/iov-one/weave","forks_url":"https://api.github.com/repos/iov-one/weave/forks","keys_url":"https://api.github.com/repos/iov-one/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iov-one/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iov-one/weave/teams","hooks_url":"https://api.github.com/repos/iov-one/weave/hooks","issue_events_url":"https://api.github.com/repos/iov-one/weave/issues/events{/number}","events_url":"https://api.github.com/repos/iov-one/weave/events","assignees_url":"https://api.github.com/repos/iov-one/weave/assignees{/user}","branches_url":"https://api.github.com/repos/iov-one/weave/branches{/branch}","tags_url":"https://api.github.com/repos/iov-one/weave/tags","blobs_url":"https://api.github.com/repos/iov-one/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iov-one/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iov-one/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/iov-one/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iov-one/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/iov-one/weave/languages","stargazers_url":"https://api.github.com/repos/iov-one/weave/stargazers","contributors_url":"https://api.github.com/repos/iov-one/weave/contributors","subscribers_url":"https://api.github.com/repos/iov-one/weave/subscribers","subscription_url":"https://api.github.com/repos/iov-one/weave/subscription","commits_url":"https://api.github.com/repos/iov-one/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/iov-one/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/iov-one/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/iov-one/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/iov-one/weave/contents/{+path}","compare_url":"https://api.github.com/repos/iov-one/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iov-one/weave/merges","archive_url":"https://api.github.com/repos/iov-one/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iov-one/weave/downloads","issues_url":"https://api.github.com/repos/iov-one/weave/issues{/number}","pulls_url":"https://api.github.com/repos/iov-one/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/iov-one/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/iov-one/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iov-one/weave/labels{/name}","releases_url":"https://api.github.com/repos/iov-one/weave/releases{/id}","deployments_url":"https://api.github.com/repos/iov-one/weave/deployments","created_at":"2018-01-21T19:24:31Z","updated_at":"2019-05-03T08:07:16Z","pushed_at":"2019-05-03T15:21:02Z","git_url":"git://github.com/iov-one/weave.git","ssh_url":"[email protected]:iov-one/weave.git","clone_url":"https://github.com/iov-one/weave.git","svn_url":"https://github.com/iov-one/weave","homepage":null,"size":3402,"stargazers_count":1091,"watchers_count":1091,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":95,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":95,"watchers":1091,"default_branch":"master"}},"base":{"label":"iov-one:master","ref":"master","sha":"fee0e5ed1d3bbbb1bdb98e303168bf5071e45cf0","user":{"login":"iov-one","id":34400253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDAwMjUz","avatar_url":"https://avatars2.githubusercontent.com/u/34400253?v=4","gravatar_id":"","url":"https://api.github.com/users/iov-one","html_url":"https://github.com/iov-one","followers_url":"https://api.github.com/users/iov-one/followers","following_url":"https://api.github.com/users/iov-one/following{/other_user}","gists_url":"https://api.github.com/users/iov-one/gists{/gist_id}","starred_url":"https://api.github.com/users/iov-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iov-one/subscriptions","organizations_url":"https://api.github.com/users/iov-one/orgs","repos_url":"https://api.github.com/users/iov-one/repos","events_url":"https://api.github.com/users/iov-one/events{/privacy}","received_events_url":"https://api.github.com/users/iov-one/received_events","type":"Organization","site_admin":false},"repo":{"id":118366160,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgzNjYxNjA=","name":"weave","full_name":"iov-one/weave","private":false,"owner":{"login":"iov-one","id":34400253,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDAwMjUz","avatar_url":"https://avatars2.githubusercontent.com/u/34400253?v=4","gravatar_id":"","url":"https://api.github.com/users/iov-one","html_url":"https://github.com/iov-one","followers_url":"https://api.github.com/users/iov-one/followers","following_url":"https://api.github.com/users/iov-one/following{/other_user}","gists_url":"https://api.github.com/users/iov-one/gists{/gist_id}","starred_url":"https://api.github.com/users/iov-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iov-one/subscriptions","organizations_url":"https://api.github.com/users/iov-one/orgs","repos_url":"https://api.github.com/users/iov-one/repos","events_url":"https://api.github.com/users/iov-one/events{/privacy}","received_events_url":"https://api.github.com/users/iov-one/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iov-one/weave","description":"Easy-to-use framework to build Tendermint ABCI applications","fork":false,"url":"https://api.github.com/repos/iov-one/weave","forks_url":"https://api.github.com/repos/iov-one/weave/forks","keys_url":"https://api.github.com/repos/iov-one/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iov-one/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iov-one/weave/teams","hooks_url":"https://api.github.com/repos/iov-one/weave/hooks","issue_events_url":"https://api.github.com/repos/iov-one/weave/issues/events{/number}","events_url":"https://api.github.com/repos/iov-one/weave/events","assignees_url":"https://api.github.com/repos/iov-one/weave/assignees{/user}","branches_url":"https://api.github.com/repos/iov-one/weave/branches{/branch}","tags_url":"https://api.github.com/repos/iov-one/weave/tags","blobs_url":"https://api.github.com/repos/iov-one/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iov-one/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iov-one/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/iov-one/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iov-one/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/iov-one/weave/languages","stargazers_url":"https://api.github.com/repos/iov-one/weave/stargazers","contributors_url":"https://api.github.com/repos/iov-one/weave/contributors","subscribers_url":"https://api.github.com/repos/iov-one/weave/subscribers","subscription_url":"https://api.github.com/repos/iov-one/weave/subscription","commits_url":"https://api.github.com/repos/iov-one/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/iov-one/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/iov-one/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/iov-one/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/iov-one/weave/contents/{+path}","compare_url":"https://api.github.com/repos/iov-one/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iov-one/weave/merges","archive_url":"https://api.github.com/repos/iov-one/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iov-one/weave/downloads","issues_url":"https://api.github.com/repos/iov-one/weave/issues{/number}","pulls_url":"https://api.github.com/repos/iov-one/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/iov-one/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/iov-one/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iov-one/weave/labels{/name}","releases_url":"https://api.github.com/repos/iov-one/weave/releases{/id}","deployments_url":"https://api.github.com/repos/iov-one/weave/deployments","created_at":"2018-01-21T19:24:31Z","updated_at":"2019-05-03T08:07:16Z","pushed_at":"2019-05-03T15:21:02Z","git_url":"git://github.com/iov-one/weave.git","ssh_url":"[email protected]:iov-one/weave.git","clone_url":"https://github.com/iov-one/weave.git","svn_url":"https://github.com/iov-one/weave","homepage":null,"size":3402,"stargazers_count":1091,"watchers_count":1091,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":95,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":21,"open_issues":95,"watchers":1091,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iov-one/weave/pulls/581"},"html":{"href":"https://github.com/iov-one/weave/pull/581"},"issue":{"href":"https://api.github.com/repos/iov-one/weave/issues/581"},"comments":{"href":"https://api.github.com/repos/iov-one/weave/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/iov-one/weave/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/iov-one/weave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iov-one/weave/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/iov-one/weave/statuses/a4c9850e373761cab8cedc11ae785f3362588b1d"}},"author_association":"MEMBER"}}	{ "id": 118366160, "name": "iov-one/weave", "url": "https://api.github.com/repos/iov-one/weave" }	{ "id": 1517, "login": "husio", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/1517?", "url": "https://api.github.com/users/husio" }	{ "id": 34400253, "login": "iov-one", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/34400253?", "url": "https://api.github.com/orgs/iov-one" }	2019-05-06T07:50:52	9568245590	{"actor":{"display_login":"husio"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/keras-team/keras-docs-ko/pulls/comments/336734732","pull_request_review_id":304210451,"id":336734732,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjczNDczMg==","diff_hunk":"@@ -5,69 +5,66 @@\n keras.layers.LocallyConnected1D(filters, kernel_size, strides=1, padding='valid', data_format=None, activation=None, use_bias=True, kernel_initializer='glorot_uniform', bias_initializer='zeros', kernel_regularizer=None, bias_regularizer=None, activity_regularizer=None, kernel_constraint=None, bias_constraint=None)\n ```\n \n-1D 인풋용 국소 연결 레이어.\n+입력값<sub>input</sub>이 1D인 부분 연결<sub>locally connectded</sub> 층<sub>Layer</sub>.\n \n-`LocallyConnected1D` 레이어는 `Conv1D` 레이어와 비슷한 방식으로 작동하지만\n-가중치가 공유되지 않는다는 점에서 다른데,\n-이는 인풋의 각 부분에 각기 다른 필터 세트가 적용된다는 \n-의미입니다.\n+`LocallyConnected1D` 층은 `Conv1D` 층과 비슷하지만\n+노드끼리 가중치를<sub>weight</sub> 공유하지 않는다는 차이점이 있습니다.\n+다시 말해, 각 노드에 다른 필터를 적용한다는 의미입니다.\n \n __예시__\n \n ```python\n-# 공유되지 않은 길이 3의 1D 컨볼루션 가중치를 10개의 시간 단계와\n-# 64개의 아웃풋 필터로 이루어진 시퀀스에 적용합니다.\n+# 10개의 시간단계와 64개의 출력값을 갖고\n+# 노드별로 다른 가중치를 사용하는 창 길이가 3인 1D 합성곱 층을 \n+# `Sequential`에 추가합니다.\n model = Sequential()\n model.add(LocallyConnected1D(64, 3, input_shape=(10, 32)))\n # 현재 model.output_shape == (None, 8, 64)\n-# 그 위에 새로운 conv1d를 추가합니다\n+# 새로운 conv1d를 추가합니다","path":"sources/layers/local.md","position":null,"original_position":27,"commit_id":"d386795ee9ab4705b029cab4b059a2d97b93eed8","original_commit_id":"cdd324971b4b61a6bd083a46f5b79aad2e80de4f","user":{"login":"Naruu","id":23354017,"node_id":"MDQ6VXNlcjIzMzU0MDE3","avatar_url":"https://avatars1.githubusercontent.com/u/23354017?v=4","gravatar_id":"","url":"https://api.github.com/users/Naruu","html_url":"https://github.com/Naruu","followers_url":"https://api.github.com/users/Naruu/followers","following_url":"https://api.github.com/users/Naruu/following{/other_user}","gists_url":"https://api.github.com/users/Naruu/gists{/gist_id}","starred_url":"https://api.github.com/users/Naruu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Naruu/subscriptions","organizations_url":"https://api.github.com/users/Naruu/orgs","repos_url":"https://api.github.com/users/Naruu/repos","events_url":"https://api.github.com/users/Naruu/events{/privacy}","received_events_url":"https://api.github.com/users/Naruu/received_events","type":"User","site_admin":false},"body":"수정했습니다 감사합니다!","created_at":"2019-10-19T12:06:49Z","updated_at":"2019-10-19T12:06:49Z","html_url":"https://github.com/keras-team/keras-docs-ko/pull/152#discussion_r336734732","pull_request_url":"https://api.github.com/repos/keras-team/keras-docs-ko/pulls/152","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/keras-team/keras-docs-ko/pulls/comments/336734732"},"html":{"href":"https://github.com/keras-team/keras-docs-ko/pull/152#discussion_r336734732"},"pull_request":{"href":"https://api.github.com/repos/keras-team/keras-docs-ko/pulls/152"}},"in_reply_to_id":336723130},"pull_request":{"url":"https://api.github.com/repos/keras-team/keras-docs-ko/pulls/152","id":325933918,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI1OTMzOTE4","html_url":"https://github.com/keras-team/keras-docs-ko/pull/152","diff_url":"https://github.com/keras-team/keras-docs-ko/pull/152.diff","patch_url":"https://github.com/keras-team/keras-docs-ko/pull/152.patch","issue_url":"https://api.github.com/repos/keras-team/keras-docs-ko/issues/152","number":152,"state":"open","locked":false,"title":"Update local.md - Words update","user":{"login":"Naruu","id":23354017,"node_id":"MDQ6VXNlcjIzMzU0MDE3","avatar_url":"https://avatars1.githubusercontent.com/u/23354017?v=4","gravatar_id":"","url":"https://api.github.com/users/Naruu","html_url":"https://github.com/Naruu","followers_url":"https://api.github.com/users/Naruu/followers","following_url":"https://api.github.com/users/Naruu/following{/other_user}","gists_url":"https://api.github.com/users/Naruu/gists{/gist_id}","starred_url":"https://api.github.com/users/Naruu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Naruu/subscriptions","organizations_url":"https://api.github.com/users/Naruu/orgs","repos_url":"https://api.github.com/users/Naruu/repos","events_url":"https://api.github.com/users/Naruu/events{/privacy}","received_events_url":"https://api.github.com/users/Naruu/received_events","type":"User","site_admin":false},"body":"1.Changed words:\r\n인풋, 아웃풋 -> 입력값, 출력값\r\ninitializer, regularizer: 초기값 설정 함수, 정규화 함수 -> 초기화 함수, 규제함수\r\nconstraint : 제약함수 -> 제약\r\nlocally connecte : 국소 연결 -> 부분 연결\r\nstride: 보폭 -> 스트라이드\r\nlayer: 레이어 -> 층\r\n\r\n2. Added subscript\r\ntensor, bias 등","created_at":"2019-10-08T19:49:52Z","updated_at":"2019-10-19T12:06:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fd892e0ad7c585150ebd1cd809714a550494e51","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keras-team/keras-docs-ko/pulls/152/commits","review_comments_url":"https://api.github.com/repos/keras-team/keras-docs-ko/pulls/152/comments","review_comment_url":"https://api.github.com/repos/keras-team/keras-docs-ko/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keras-team/keras-docs-ko/issues/152/comments","statuses_url":"https://api.github.com/repos/keras-team/keras-docs-ko/statuses/d386795ee9ab4705b029cab4b059a2d97b93eed8","head":{"label":"Naruu:patch-6","ref":"patch-6","sha":"d386795ee9ab4705b029cab4b059a2d97b93eed8","user":{"login":"Naruu","id":23354017,"node_id":"MDQ6VXNlcjIzMzU0MDE3","avatar_url":"https://avatars1.githubusercontent.com/u/23354017?v=4","gravatar_id":"","url":"https://api.github.com/users/Naruu","html_url":"https://github.com/Naruu","followers_url":"https://api.github.com/users/Naruu/followers","following_url":"https://api.github.com/users/Naruu/following{/other_user}","gists_url":"https://api.github.com/users/Naruu/gists{/gist_id}","starred_url":"https://api.github.com/users/Naruu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Naruu/subscriptions","organizations_url":"https://api.github.com/users/Naruu/orgs","repos_url":"https://api.github.com/users/Naruu/repos","events_url":"https://api.github.com/users/Naruu/events{/privacy}","received_events_url":"https://api.github.com/users/Naruu/received_events","type":"User","site_admin":false},"repo":{"id":208550971,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg1NTA5NzE=","name":"keras-docs-ko","full_name":"Naruu/keras-docs-ko","private":false,"owner":{"login":"Naruu","id":23354017,"node_id":"MDQ6VXNlcjIzMzU0MDE3","avatar_url":"https://avatars1.githubusercontent.com/u/23354017?v=4","gravatar_id":"","url":"https://api.github.com/users/Naruu","html_url":"https://github.com/Naruu","followers_url":"https://api.github.com/users/Naruu/followers","following_url":"https://api.github.com/users/Naruu/following{/other_user}","gists_url":"https://api.github.com/users/Naruu/gists{/gist_id}","starred_url":"https://api.github.com/users/Naruu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Naruu/subscriptions","organizations_url":"https://api.github.com/users/Naruu/orgs","repos_url":"https://api.github.com/users/Naruu/repos","events_url":"https://api.github.com/users/Naruu/events{/privacy}","received_events_url":"https://api.github.com/users/Naruu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Naruu/keras-docs-ko","description":"Korean translation of the Keras documentation.","fork":true,"url":"https://api.github.com/repos/Naruu/keras-docs-ko","forks_url":"https://api.github.com/repos/Naruu/keras-docs-ko/forks","keys_url":"https://api.github.com/repos/Naruu/keras-docs-ko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Naruu/keras-docs-ko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Naruu/keras-docs-ko/teams","hooks_url":"https://api.github.com/repos/Naruu/keras-docs-ko/hooks","issue_events_url":"https://api.github.com/repos/Naruu/keras-docs-ko/issues/events{/number}","events_url":"https://api.github.com/repos/Naruu/keras-docs-ko/events","assignees_url":"https://api.github.com/repos/Naruu/keras-docs-ko/assignees{/user}","branches_url":"https://api.github.com/repos/Naruu/keras-docs-ko/branches{/branch}","tags_url":"https://api.github.com/repos/Naruu/keras-docs-ko/tags","blobs_url":"https://api.github.com/repos/Naruu/keras-docs-ko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Naruu/keras-docs-ko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Naruu/keras-docs-ko/git/refs{/sha}","trees_url":"https://api.github.com/repos/Naruu/keras-docs-ko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Naruu/keras-docs-ko/statuses/{sha}","languages_url":"https://api.github.com/repos/Naruu/keras-docs-ko/languages","stargazers_url":"https://api.github.com/repos/Naruu/keras-docs-ko/stargazers","contributors_url":"https://api.github.com/repos/Naruu/keras-docs-ko/contributors","subscribers_url":"https://api.github.com/repos/Naruu/keras-docs-ko/subscribers","subscription_url":"https://api.github.com/repos/Naruu/keras-docs-ko/subscription","commits_url":"https://api.github.com/repos/Naruu/keras-docs-ko/commits{/sha}","git_commits_url":"https://api.github.com/repos/Naruu/keras-docs-ko/git/commits{/sha}","comments_url":"https://api.github.com/repos/Naruu/keras-docs-ko/comments{/number}","issue_comment_url":"https://api.github.com/repos/Naruu/keras-docs-ko/issues/comments{/number}","contents_url":"https://api.github.com/repos/Naruu/keras-docs-ko/contents/{+path}","compare_url":"https://api.github.com/repos/Naruu/keras-docs-ko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Naruu/keras-docs-ko/merges","archive_url":"https://api.github.com/repos/Naruu/keras-docs-ko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Naruu/keras-docs-ko/downloads","issues_url":"https://api.github.com/repos/Naruu/keras-docs-ko/issues{/number}","pulls_url":"https://api.github.com/repos/Naruu/keras-docs-ko/pulls{/number}","milestones_url":"https://api.github.com/repos/Naruu/keras-docs-ko/milestones{/number}","notifications_url":"https://api.github.com/repos/Naruu/keras-docs-ko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Naruu/keras-docs-ko/labels{/name}","releases_url":"https://api.github.com/repos/Naruu/keras-docs-ko/releases{/id}","deployments_url":"https://api.github.com/repos/Naruu/keras-docs-ko/deployments","created_at":"2019-09-15T06:17:04Z","updated_at":"2019-09-15T06:17:05Z","pushed_at":"2019-10-19T12:06:31Z","git_url":"git://github.com/Naruu/keras-docs-ko.git","ssh_url":"[email protected]:Naruu/keras-docs-ko.git","clone_url":"https://github.com/Naruu/keras-docs-ko.git","svn_url":"https://github.com/Naruu/keras-docs-ko","homepage":null,"size":569,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"keras-team:master","ref":"master","sha":"070fc0b8a525208b897cec5174870c6fc38fbd05","user":{"login":"keras-team","id":34455048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDU1MDQ4","avatar_url":"https://avatars0.githubusercontent.com/u/34455048?v=4","gravatar_id":"","url":"https://api.github.com/users/keras-team","html_url":"https://github.com/keras-team","followers_url":"https://api.github.com/users/keras-team/followers","following_url":"https://api.github.com/users/keras-team/following{/other_user}","gists_url":"https://api.github.com/users/keras-team/gists{/gist_id}","starred_url":"https://api.github.com/users/keras-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keras-team/subscriptions","organizations_url":"https://api.github.com/users/keras-team/orgs","repos_url":"https://api.github.com/users/keras-team/repos","events_url":"https://api.github.com/users/keras-team/events{/privacy}","received_events_url":"https://api.github.com/users/keras-team/received_events","type":"Organization","site_admin":false},"repo":{"id":166692539,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY2OTI1Mzk=","name":"keras-docs-ko","full_name":"keras-team/keras-docs-ko","private":false,"owner":{"login":"keras-team","id":34455048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NDU1MDQ4","avatar_url":"https://avatars0.githubusercontent.com/u/34455048?v=4","gravatar_id":"","url":"https://api.github.com/users/keras-team","html_url":"https://github.com/keras-team","followers_url":"https://api.github.com/users/keras-team/followers","following_url":"https://api.github.com/users/keras-team/following{/other_user}","gists_url":"https://api.github.com/users/keras-team/gists{/gist_id}","starred_url":"https://api.github.com/users/keras-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keras-team/subscriptions","organizations_url":"https://api.github.com/users/keras-team/orgs","repos_url":"https://api.github.com/users/keras-team/repos","events_url":"https://api.github.com/users/keras-team/events{/privacy}","received_events_url":"https://api.github.com/users/keras-team/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keras-team/keras-docs-ko","description":"Korean translation of the Keras documentation.","fork":false,"url":"https://api.github.com/repos/keras-team/keras-docs-ko","forks_url":"https://api.github.com/repos/keras-team/keras-docs-ko/forks","keys_url":"https://api.github.com/repos/keras-team/keras-docs-ko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keras-team/keras-docs-ko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keras-team/keras-docs-ko/teams","hooks_url":"https://api.github.com/repos/keras-team/keras-docs-ko/hooks","issue_events_url":"https://api.github.com/repos/keras-team/keras-docs-ko/issues/events{/number}","events_url":"https://api.github.com/repos/keras-team/keras-docs-ko/events","assignees_url":"https://api.github.com/repos/keras-team/keras-docs-ko/assignees{/user}","branches_url":"https://api.github.com/repos/keras-team/keras-docs-ko/branches{/branch}","tags_url":"https://api.github.com/repos/keras-team/keras-docs-ko/tags","blobs_url":"https://api.github.com/repos/keras-team/keras-docs-ko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keras-team/keras-docs-ko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keras-team/keras-docs-ko/git/refs{/sha}","trees_url":"https://api.github.com/repos/keras-team/keras-docs-ko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keras-team/keras-docs-ko/statuses/{sha}","languages_url":"https://api.github.com/repos/keras-team/keras-docs-ko/languages","stargazers_url":"https://api.github.com/repos/keras-team/keras-docs-ko/stargazers","contributors_url":"https://api.github.com/repos/keras-team/keras-docs-ko/contributors","subscribers_url":"https://api.github.com/repos/keras-team/keras-docs-ko/subscribers","subscription_url":"https://api.github.com/repos/keras-team/keras-docs-ko/subscription","commits_url":"https://api.github.com/repos/keras-team/keras-docs-ko/commits{/sha}","git_commits_url":"https://api.github.com/repos/keras-team/keras-docs-ko/git/commits{/sha}","comments_url":"https://api.github.com/repos/keras-team/keras-docs-ko/comments{/number}","issue_comment_url":"https://api.github.com/repos/keras-team/keras-docs-ko/issues/comments{/number}","contents_url":"https://api.github.com/repos/keras-team/keras-docs-ko/contents/{+path}","compare_url":"https://api.github.com/repos/keras-team/keras-docs-ko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keras-team/keras-docs-ko/merges","archive_url":"https://api.github.com/repos/keras-team/keras-docs-ko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keras-team/keras-docs-ko/downloads","issues_url":"https://api.github.com/repos/keras-team/keras-docs-ko/issues{/number}","pulls_url":"https://api.github.com/repos/keras-team/keras-docs-ko/pulls{/number}","milestones_url":"https://api.github.com/repos/keras-team/keras-docs-ko/milestones{/number}","notifications_url":"https://api.github.com/repos/keras-team/keras-docs-ko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keras-team/keras-docs-ko/labels{/name}","releases_url":"https://api.github.com/repos/keras-team/keras-docs-ko/releases{/id}","deployments_url":"https://api.github.com/repos/keras-team/keras-docs-ko/deployments","created_at":"2019-01-20T18:03:55Z","updated_at":"2019-10-19T05:41:45Z","pushed_at":"2019-10-19T12:06:32Z","git_url":"git://github.com/keras-team/keras-docs-ko.git","ssh_url":"[email protected]:keras-team/keras-docs-ko.git","clone_url":"https://github.com/keras-team/keras-docs-ko.git","svn_url":"https://github.com/keras-team/keras-docs-ko","homepage":null,"size":578,"stargazers_count":72,"watchers_count":72,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":62,"license":null,"forks":51,"open_issues":62,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keras-team/keras-docs-ko/pulls/152"},"html":{"href":"https://github.com/keras-team/keras-docs-ko/pull/152"},"issue":{"href":"https://api.github.com/repos/keras-team/keras-docs-ko/issues/152"},"comments":{"href":"https://api.github.com/repos/keras-team/keras-docs-ko/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/keras-team/keras-docs-ko/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/keras-team/keras-docs-ko/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keras-team/keras-docs-ko/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/keras-team/keras-docs-ko/statuses/d386795ee9ab4705b029cab4b059a2d97b93eed8"}},"author_association":"CONTRIBUTOR"}}	{ "id": 166692539, "name": "keras-team/keras-docs-ko", "url": "https://api.github.com/repos/keras-team/keras-docs-ko" }	{ "id": 23354017, "login": "Naruu", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/23354017?", "url": "https://api.github.com/users/Naruu" }	{ "id": 34455048, "login": "keras-team", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/34455048?", "url": "https://api.github.com/orgs/keras-team" }	2019-10-19T12:06:49	10667395299	{"actor":{"display_login":"Naruu"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/pulls/comments/282776940","pull_request_review_id":235963944,"id":282776940,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4Mjc3Njk0MA==","diff_hunk":"@@ -82,28 +205,42 @@ def import_tile_type(db, write_cur, tile_types, site_types, tile_type_name):\n tile_types[tile_type_name] = write_cur.lastrowid\n \n wires = {}\n- for wire in tile_type.get_wires():\n+ for wire, wire_rc_element in tile_type.get_wires().items():\n+ capacitance = 0.0","path":"xc7/utils/prjxray_form_channels.py","position":152,"original_position":152,"commit_id":"800b4ec764ebe71d15528a6e6c90ed849246fd2f","original_commit_id":"800b4ec764ebe71d15528a6e6c90ed849246fd2f","user":{"login":"mkurc-ant","id":47315577,"node_id":"MDQ6VXNlcjQ3MzE1NTc3","avatar_url":"https://avatars3.githubusercontent.com/u/47315577?v=4","gravatar_id":"","url":"https://api.github.com/users/mkurc-ant","html_url":"https://github.com/mkurc-ant","followers_url":"https://api.github.com/users/mkurc-ant/followers","following_url":"https://api.github.com/users/mkurc-ant/following{/other_user}","gists_url":"https://api.github.com/users/mkurc-ant/gists{/gist_id}","starred_url":"https://api.github.com/users/mkurc-ant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkurc-ant/subscriptions","organizations_url":"https://api.github.com/users/mkurc-ant/orgs","repos_url":"https://api.github.com/users/mkurc-ant/repos","events_url":"https://api.github.com/users/mkurc-ant/events{/privacy}","received_events_url":"https://api.github.com/users/mkurc-ant/received_events","type":"User","site_admin":false},"body":"Shouldn't we insert here some reasonable dummy variables other than zero ? Zeros might trigger some assertions in the VPR or lead to some math exceptions / corner cases.","created_at":"2019-05-10T07:39:28Z","updated_at":"2019-05-10T07:39:28Z","html_url":"https://github.com/SymbiFlow/symbiflow-arch-defs/pull/708#discussion_r282776940","pull_request_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/pulls/708","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/pulls/comments/282776940"},"html":{"href":"https://github.com/SymbiFlow/symbiflow-arch-defs/pull/708#discussion_r282776940"},"pull_request":{"href":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/pulls/708"}}},"pull_request":{"url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/pulls/708","id":277522801,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc3NTIyODAx","html_url":"https://github.com/SymbiFlow/symbiflow-arch-defs/pull/708","diff_url":"https://github.com/SymbiFlow/symbiflow-arch-defs/pull/708.diff","patch_url":"https://github.com/SymbiFlow/symbiflow-arch-defs/pull/708.patch","issue_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/issues/708","number":708,"state":"open","locked":false,"title":"Initial xc7 route timing import.","user":{"login":"litghost","id":537074,"node_id":"MDQ6VXNlcjUzNzA3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/537074?v=4","gravatar_id":"","url":"https://api.github.com/users/litghost","html_url":"https://github.com/litghost","followers_url":"https://api.github.com/users/litghost/followers","following_url":"https://api.github.com/users/litghost/following{/other_user}","gists_url":"https://api.github.com/users/litghost/gists{/gist_id}","starred_url":"https://api.github.com/users/litghost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/litghost/subscriptions","organizations_url":"https://api.github.com/users/litghost/orgs","repos_url":"https://api.github.com/users/litghost/repos","events_url":"https://api.github.com/users/litghost/events{/privacy}","received_events_url":"https://api.github.com/users/litghost/received_events","type":"User","site_admin":false},"body":"This is the initial 7-series routing import, which currently just writes 0 delays for all routing, but will use timing information from prjxray-db once present.","created_at":"2019-05-09T19:43:17Z","updated_at":"2019-05-10T07:39:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cace16de21d434fb7391d0e5e7847ef520073846","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mithro","id":21212,"node_id":"MDQ6VXNlcjIxMjEy","avatar_url":"https://avatars2.githubusercontent.com/u/21212?v=4","gravatar_id":"","url":"https://api.github.com/users/mithro","html_url":"https://github.com/mithro","followers_url":"https://api.github.com/users/mithro/followers","following_url":"https://api.github.com/users/mithro/following{/other_user}","gists_url":"https://api.github.com/users/mithro/gists{/gist_id}","starred_url":"https://api.github.com/users/mithro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mithro/subscriptions","organizations_url":"https://api.github.com/users/mithro/orgs","repos_url":"https://api.github.com/users/mithro/repos","events_url":"https://api.github.com/users/mithro/events{/privacy}","received_events_url":"https://api.github.com/users/mithro/received_events","type":"User","site_admin":false},{"login":"HackerFoo","id":1069462,"node_id":"MDQ6VXNlcjEwNjk0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1069462?v=4","gravatar_id":"","url":"https://api.github.com/users/HackerFoo","html_url":"https://github.com/HackerFoo","followers_url":"https://api.github.com/users/HackerFoo/followers","following_url":"https://api.github.com/users/HackerFoo/following{/other_user}","gists_url":"https://api.github.com/users/HackerFoo/gists{/gist_id}","starred_url":"https://api.github.com/users/HackerFoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HackerFoo/subscriptions","organizations_url":"https://api.github.com/users/HackerFoo/orgs","repos_url":"https://api.github.com/users/HackerFoo/repos","events_url":"https://api.github.com/users/HackerFoo/events{/privacy}","received_events_url":"https://api.github.com/users/HackerFoo/received_events","type":"User","site_admin":false},{"login":"elmsfu","id":7052058,"node_id":"MDQ6VXNlcjcwNTIwNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/7052058?v=4","gravatar_id":"","url":"https://api.github.com/users/elmsfu","html_url":"https://github.com/elmsfu","followers_url":"https://api.github.com/users/elmsfu/followers","following_url":"https://api.github.com/users/elmsfu/following{/other_user}","gists_url":"https://api.github.com/users/elmsfu/gists{/gist_id}","starred_url":"https://api.github.com/users/elmsfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elmsfu/subscriptions","organizations_url":"https://api.github.com/users/elmsfu/orgs","repos_url":"https://api.github.com/users/elmsfu/repos","events_url":"https://api.github.com/users/elmsfu/events{/privacy}","received_events_url":"https://api.github.com/users/elmsfu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":853275585,"node_id":"MDU6TGFiZWw4NTMyNzU1ODU=","url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/labels/lang-python","name":"lang-python","color":"fbca04","default":false},{"id":901263460,"node_id":"MDU6TGFiZWw5MDEyNjM0NjA=","url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/labels/third-party","name":"third-party","color":"ededed","default":false},{"id":861273269,"node_id":"MDU6TGFiZWw4NjEyNzMyNjk=","url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/labels/type-utils","name":"type-utils","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/pulls/708/commits","review_comments_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/pulls/708/comments","review_comment_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/issues/708/comments","statuses_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/statuses/800b4ec764ebe71d15528a6e6c90ed849246fd2f","head":{"label":"litghost:route_timing","ref":"route_timing","sha":"800b4ec764ebe71d15528a6e6c90ed849246fd2f","user":{"login":"litghost","id":537074,"node_id":"MDQ6VXNlcjUzNzA3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/537074?v=4","gravatar_id":"","url":"https://api.github.com/users/litghost","html_url":"https://github.com/litghost","followers_url":"https://api.github.com/users/litghost/followers","following_url":"https://api.github.com/users/litghost/following{/other_user}","gists_url":"https://api.github.com/users/litghost/gists{/gist_id}","starred_url":"https://api.github.com/users/litghost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/litghost/subscriptions","organizations_url":"https://api.github.com/users/litghost/orgs","repos_url":"https://api.github.com/users/litghost/repos","events_url":"https://api.github.com/users/litghost/events{/privacy}","received_events_url":"https://api.github.com/users/litghost/received_events","type":"User","site_admin":false},"repo":{"id":142636957,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI2MzY5NTc=","name":"symbiflow-arch-defs","full_name":"litghost/symbiflow-arch-defs","private":false,"owner":{"login":"litghost","id":537074,"node_id":"MDQ6VXNlcjUzNzA3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/537074?v=4","gravatar_id":"","url":"https://api.github.com/users/litghost","html_url":"https://github.com/litghost","followers_url":"https://api.github.com/users/litghost/followers","following_url":"https://api.github.com/users/litghost/following{/other_user}","gists_url":"https://api.github.com/users/litghost/gists{/gist_id}","starred_url":"https://api.github.com/users/litghost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/litghost/subscriptions","organizations_url":"https://api.github.com/users/litghost/orgs","repos_url":"https://api.github.com/users/litghost/repos","events_url":"https://api.github.com/users/litghost/events{/privacy}","received_events_url":"https://api.github.com/users/litghost/received_events","type":"User","site_admin":false},"html_url":"https://github.com/litghost/symbiflow-arch-defs","description":"FOSS architecture definitions of FPGA hardware useful for doing PnR device generation.","fork":true,"url":"https://api.github.com/repos/litghost/symbiflow-arch-defs","forks_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/forks","keys_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/teams","hooks_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/hooks","issue_events_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/issues/events{/number}","events_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/events","assignees_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/assignees{/user}","branches_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/branches{/branch}","tags_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/tags","blobs_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/git/refs{/sha}","trees_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/statuses/{sha}","languages_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/languages","stargazers_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/stargazers","contributors_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/contributors","subscribers_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/subscribers","subscription_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/subscription","commits_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/commits{/sha}","git_commits_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/git/commits{/sha}","comments_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/comments{/number}","issue_comment_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/issues/comments{/number}","contents_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/contents/{+path}","compare_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/merges","archive_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/downloads","issues_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/issues{/number}","pulls_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/pulls{/number}","milestones_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/milestones{/number}","notifications_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/labels{/name}","releases_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/releases{/id}","deployments_url":"https://api.github.com/repos/litghost/symbiflow-arch-defs/deployments","created_at":"2018-07-28T01:26:36Z","updated_at":"2019-04-08T21:23:25Z","pushed_at":"2019-05-10T01:06:40Z","git_url":"git://github.com/litghost/symbiflow-arch-defs.git","ssh_url":"[email protected]:litghost/symbiflow-arch-defs.git","clone_url":"https://github.com/litghost/symbiflow-arch-defs.git","svn_url":"https://github.com/litghost/symbiflow-arch-defs","homepage":"https://symbiflow.github.io/","size":3327,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SymbiFlow:master","ref":"master","sha":"5fbb149e1638223e9ea57ed65476ab8777febcdd","user":{"login":"SymbiFlow","id":34549754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTQ5NzU0","avatar_url":"https://avatars0.githubusercontent.com/u/34549754?v=4","gravatar_id":"","url":"https://api.github.com/users/SymbiFlow","html_url":"https://github.com/SymbiFlow","followers_url":"https://api.github.com/users/SymbiFlow/followers","following_url":"https://api.github.com/users/SymbiFlow/following{/other_user}","gists_url":"https://api.github.com/users/SymbiFlow/gists{/gist_id}","starred_url":"https://api.github.com/users/SymbiFlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SymbiFlow/subscriptions","organizations_url":"https://api.github.com/users/SymbiFlow/orgs","repos_url":"https://api.github.com/users/SymbiFlow/repos","events_url":"https://api.github.com/users/SymbiFlow/events{/privacy}","received_events_url":"https://api.github.com/users/SymbiFlow/received_events","type":"Organization","site_admin":false},"repo":{"id":111006976,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEwMDY5NzY=","name":"symbiflow-arch-defs","full_name":"SymbiFlow/symbiflow-arch-defs","private":false,"owner":{"login":"SymbiFlow","id":34549754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTQ5NzU0","avatar_url":"https://avatars0.githubusercontent.com/u/34549754?v=4","gravatar_id":"","url":"https://api.github.com/users/SymbiFlow","html_url":"https://github.com/SymbiFlow","followers_url":"https://api.github.com/users/SymbiFlow/followers","following_url":"https://api.github.com/users/SymbiFlow/following{/other_user}","gists_url":"https://api.github.com/users/SymbiFlow/gists{/gist_id}","starred_url":"https://api.github.com/users/SymbiFlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SymbiFlow/subscriptions","organizations_url":"https://api.github.com/users/SymbiFlow/orgs","repos_url":"https://api.github.com/users/SymbiFlow/repos","events_url":"https://api.github.com/users/SymbiFlow/events{/privacy}","received_events_url":"https://api.github.com/users/SymbiFlow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SymbiFlow/symbiflow-arch-defs","description":"FOSS architecture definitions of FPGA hardware useful for doing PnR device generation.","fork":false,"url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs","forks_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/forks","keys_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/teams","hooks_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/hooks","issue_events_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/issues/events{/number}","events_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/events","assignees_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/assignees{/user}","branches_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/branches{/branch}","tags_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/tags","blobs_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/git/refs{/sha}","trees_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/statuses/{sha}","languages_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/languages","stargazers_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/stargazers","contributors_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/contributors","subscribers_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/subscribers","subscription_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/subscription","commits_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/commits{/sha}","git_commits_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/git/commits{/sha}","comments_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/comments{/number}","issue_comment_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/issues/comments{/number}","contents_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/contents/{+path}","compare_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/merges","archive_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/downloads","issues_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/issues{/number}","pulls_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/pulls{/number}","milestones_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/milestones{/number}","notifications_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/labels{/name}","releases_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/releases{/id}","deployments_url":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/deployments","created_at":"2017-11-16T18:23:49Z","updated_at":"2019-05-09T21:35:05Z","pushed_at":"2019-05-10T05:15:32Z","git_url":"git://github.com/SymbiFlow/symbiflow-arch-defs.git","ssh_url":"[email protected]:SymbiFlow/symbiflow-arch-defs.git","clone_url":"https://github.com/SymbiFlow/symbiflow-arch-defs.git","svn_url":"https://github.com/SymbiFlow/symbiflow-arch-defs","homepage":"https://symbiflow.github.io/","size":3218,"stargazers_count":51,"watchers_count":51,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":175,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":28,"open_issues":175,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/pulls/708"},"html":{"href":"https://github.com/SymbiFlow/symbiflow-arch-defs/pull/708"},"issue":{"href":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/issues/708"},"comments":{"href":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/issues/708/comments"},"review_comments":{"href":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/pulls/708/comments"},"review_comment":{"href":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/pulls/708/commits"},"statuses":{"href":"https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs/statuses/800b4ec764ebe71d15528a6e6c90ed849246fd2f"}},"author_association":"CONTRIBUTOR"}}	{ "id": 111006976, "name": "SymbiFlow/symbiflow-arch-defs", "url": "https://api.github.com/repos/SymbiFlow/symbiflow-arch-defs" }	{ "id": 47315577, "login": "mkurc-ant", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/47315577?", "url": "https://api.github.com/users/mkurc-ant" }	{ "id": 34549754, "login": "SymbiFlow", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/34549754?", "url": "https://api.github.com/orgs/SymbiFlow" }	2019-05-10T07:39:28	9599781021	{"actor":{"display_login":"mkurc-ant"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/microROS/microros.github.io/pulls/comments/264037672","pull_request_review_id":212601520,"id":264037672,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NDAzNzY3Mg==","diff_hunk":"@@ -0,0 +1,1167 @@\n+---\n+title: NuttX Getting Started\n+permalink: /docs/tutorials/advanced/nuttx_getting_started/\n+---\n+\n+This document wants to be a small guideline for rapidly start using\n+the defconfig files for NuttX, OFERA project has created.\n+\n+# Example list\n+\n+\n+## Olimex STM32-E407\n+\n+- [NSH over USB](#How-to-execute-NSH-over-USB-under-Olimex-STM32-E407)\n+- [NSH over UART](#How-to-use-NSH-over-UART)\n+- [Auxiliar UART port](#How-to-use-an-auxiliary-UART)\n+- [BMP180 through I2C](#How-to-execute-BMP180-example)\n+- [HIH6130 through I2C](#How-to-execute-HIH6130-example)\n+- [UDP echo server](#How-to-execute-UDPEcho-server-example)\n+- [TCP echo server](#How-to-execute-TCP-Echo-server-example)\n+- [MRF24J40-6LowPan through SPI](#How-to-use-MRF24j40-6LowPan)\n+- [ADC](#How-to-use-the-ADC-demo)\n+- [Telemetry](#How-to-execute-telemetry-app)\n+- [Power Manager](#How-to-execute-Power-Manager-example)\n+- [SD Card](#How-to-use-a-micro-SD-Card-in-the-Olimex-STM32-E407-board)\n+- [Micro XRCE-DDS through serial](#How-to-execute-Micro-XRCE-DDS)\n+- [micro-ROS demo](#How-to-use-micro-ROS-demo)\n+\n+\n+\n+## STM32L Discovery\n+\n+- [NSH through UART](#How-to-execute-NSH-under-STM32L-Discovery)\n+- [BMP180 through I2C](#How-to-execute-BMP180-example)\n+- [HIH6130 through I2C](#How-to-execute-HIH6130-example)\n+- [Power Manager](#How-to-execute-Power-Manager-example)\n+- [Micro XRCE-DDS through serial](#How-to-execute-Micro-XRCE-DDS)\n+\n+\n+\n+# Repositories to be used\n+\n+For the examples listed below, please make use of the branch called `master` for this two repositories:\n+\n+- [NuttX](https://github.com/microROS/Nuttx) fork, where NuttX RTOS is stored.\n+- [Apps](https://github.com/microROS/apps) fork, whee NuttX applications and examples are placed.\n+\n+----------------------\n+\n+# How to configure and flash a board\n+\n+We have developed two scripts that will help you to configure and flash the board. Go to the `NuttX` folder and write the next commands:\n+\n+- To configure: `$ ./scripts/configure.sh <board_model> <example_to_set>`\n+- To compile: `make`\n+- To flash: `./scripts/flash.sh <board_model>`, where the script expects `olimex-stm32-e407` or `stm32l1`.","path":"_docs/tutorials/advanced/nuttx_getting_started/index.md","position":56,"original_position":56,"commit_id":"72a3eb40efb80101d475081d1ef571b8042cfcb7","original_commit_id":"72a3eb40efb80101d475081d1ef571b8042cfcb7","user":{"login":"iluetkeb","id":289154,"node_id":"MDQ6VXNlcjI4OTE1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/289154?v=4","gravatar_id":"","url":"https://api.github.com/users/iluetkeb","html_url":"https://github.com/iluetkeb","followers_url":"https://api.github.com/users/iluetkeb/followers","following_url":"https://api.github.com/users/iluetkeb/following{/other_user}","gists_url":"https://api.github.com/users/iluetkeb/gists{/gist_id}","starred_url":"https://api.github.com/users/iluetkeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iluetkeb/subscriptions","organizations_url":"https://api.github.com/users/iluetkeb/orgs","repos_url":"https://api.github.com/users/iluetkeb/repos","events_url":"https://api.github.com/users/iluetkeb/events{/privacy}","received_events_url":"https://api.github.com/users/iluetkeb/received_events","type":"User","site_admin":false},"body":"Maybe we want to add an option to select the right JTAG adapter.\r\n\r\nAlternatively, we can also detect which adapter is being used by examining then USB ids. This would be preferable, but is of course a bit more work.","created_at":"2019-03-10T13:02:35Z","updated_at":"2019-03-10T13:11:12Z","html_url":"https://github.com/microROS/microros.github.io/pull/13#discussion_r264037672","pull_request_url":"https://api.github.com/repos/microROS/microros.github.io/pulls/13","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/microROS/microros.github.io/pulls/comments/264037672"},"html":{"href":"https://github.com/microROS/microros.github.io/pull/13#discussion_r264037672"},"pull_request":{"href":"https://api.github.com/repos/microROS/microros.github.io/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/microROS/microros.github.io/pulls/13","id":257360383,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3MzYwMzgz","html_url":"https://github.com/microROS/microros.github.io/pull/13","diff_url":"https://github.com/microROS/microros.github.io/pull/13.diff","patch_url":"https://github.com/microROS/microros.github.io/pull/13.patch","issue_url":"https://api.github.com/repos/microROS/microros.github.io/issues/13","number":13,"state":"open","locked":false,"title":"Feature/getting started","user":{"login":"imuguruza","id":7628788,"node_id":"MDQ6VXNlcjc2Mjg3ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/7628788?v=4","gravatar_id":"","url":"https://api.github.com/users/imuguruza","html_url":"https://github.com/imuguruza","followers_url":"https://api.github.com/users/imuguruza/followers","following_url":"https://api.github.com/users/imuguruza/following{/other_user}","gists_url":"https://api.github.com/users/imuguruza/gists{/gist_id}","starred_url":"https://api.github.com/users/imuguruza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imuguruza/subscriptions","organizations_url":"https://api.github.com/users/imuguruza/orgs","repos_url":"https://api.github.com/users/imuguruza/repos","events_url":"https://api.github.com/users/imuguruza/events{/privacy}","received_events_url":"https://api.github.com/users/imuguruza/received_events","type":"User","site_admin":false},"body":"Start adding \"getting started\" section, we need to complete the instructions and urls to dockerfiles","created_at":"2019-03-01T08:37:03Z","updated_at":"2019-03-10T13:11:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df24f14a23e97c95902198a06154329d34b10a44","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/microROS/microros.github.io/pulls/13/commits","review_comments_url":"https://api.github.com/repos/microROS/microros.github.io/pulls/13/comments","review_comment_url":"https://api.github.com/repos/microROS/microros.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/microROS/microros.github.io/issues/13/comments","statuses_url":"https://api.github.com/repos/microROS/microros.github.io/statuses/72a3eb40efb80101d475081d1ef571b8042cfcb7","head":{"label":"microROS:feature/getting_started","ref":"feature/getting_started","sha":"72a3eb40efb80101d475081d1ef571b8042cfcb7","user":{"login":"microROS","id":34708703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzA4NzAz","avatar_url":"https://avatars0.githubusercontent.com/u/34708703?v=4","gravatar_id":"","url":"https://api.github.com/users/microROS","html_url":"https://github.com/microROS","followers_url":"https://api.github.com/users/microROS/followers","following_url":"https://api.github.com/users/microROS/following{/other_user}","gists_url":"https://api.github.com/users/microROS/gists{/gist_id}","starred_url":"https://api.github.com/users/microROS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microROS/subscriptions","organizations_url":"https://api.github.com/users/microROS/orgs","repos_url":"https://api.github.com/users/microROS/repos","events_url":"https://api.github.com/users/microROS/events{/privacy}","received_events_url":"https://api.github.com/users/microROS/received_events","type":"Organization","site_admin":false},"repo":{"id":122340276,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIzNDAyNzY=","name":"microros.github.io","full_name":"microROS/microros.github.io","private":false,"owner":{"login":"microROS","id":34708703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzA4NzAz","avatar_url":"https://avatars0.githubusercontent.com/u/34708703?v=4","gravatar_id":"","url":"https://api.github.com/users/microROS","html_url":"https://github.com/microROS","followers_url":"https://api.github.com/users/microROS/followers","following_url":"https://api.github.com/users/microROS/following{/other_user}","gists_url":"https://api.github.com/users/microROS/gists{/gist_id}","starred_url":"https://api.github.com/users/microROS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microROS/subscriptions","organizations_url":"https://api.github.com/users/microROS/orgs","repos_url":"https://api.github.com/users/microROS/repos","events_url":"https://api.github.com/users/microROS/events{/privacy}","received_events_url":"https://api.github.com/users/microROS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microROS/microros.github.io","description":"A platform for seamless integration of resource constrained devices in the ROS ecosystem.","fork":false,"url":"https://api.github.com/repos/microROS/microros.github.io","forks_url":"https://api.github.com/repos/microROS/microros.github.io/forks","keys_url":"https://api.github.com/repos/microROS/microros.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microROS/microros.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microROS/microros.github.io/teams","hooks_url":"https://api.github.com/repos/microROS/microros.github.io/hooks","issue_events_url":"https://api.github.com/repos/microROS/microros.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/microROS/microros.github.io/events","assignees_url":"https://api.github.com/repos/microROS/microros.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/microROS/microros.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/microROS/microros.github.io/tags","blobs_url":"https://api.github.com/repos/microROS/microros.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microROS/microros.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microROS/microros.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/microROS/microros.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microROS/microros.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/microROS/microros.github.io/languages","stargazers_url":"https://api.github.com/repos/microROS/microros.github.io/stargazers","contributors_url":"https://api.github.com/repos/microROS/microros.github.io/contributors","subscribers_url":"https://api.github.com/repos/microROS/microros.github.io/subscribers","subscription_url":"https://api.github.com/repos/microROS/microros.github.io/subscription","commits_url":"https://api.github.com/repos/microROS/microros.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/microROS/microros.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/microROS/microros.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/microROS/microros.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/microROS/microros.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/microROS/microros.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microROS/microros.github.io/merges","archive_url":"https://api.github.com/repos/microROS/microros.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microROS/microros.github.io/downloads","issues_url":"https://api.github.com/repos/microROS/microros.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/microROS/microros.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/microROS/microros.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/microROS/microros.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microROS/microros.github.io/labels{/name}","releases_url":"https://api.github.com/repos/microROS/microros.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/microROS/microros.github.io/deployments","created_at":"2018-02-21T13:31:55Z","updated_at":"2019-03-06T08:59:03Z","pushed_at":"2019-03-06T09:40:10Z","git_url":"git://github.com/microROS/microros.github.io.git","ssh_url":"[email protected]:microROS/microros.github.io.git","clone_url":"https://github.com/microROS/microros.github.io.git","svn_url":"https://github.com/microROS/microros.github.io","homepage":"https://microros.github.io","size":24976,"stargazers_count":33,"watchers_count":33,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":3,"watchers":33,"default_branch":"master"}},"base":{"label":"microROS:master","ref":"master","sha":"b561850bec2d001b97a61efeba53e027ee124db8","user":{"login":"microROS","id":34708703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzA4NzAz","avatar_url":"https://avatars0.githubusercontent.com/u/34708703?v=4","gravatar_id":"","url":"https://api.github.com/users/microROS","html_url":"https://github.com/microROS","followers_url":"https://api.github.com/users/microROS/followers","following_url":"https://api.github.com/users/microROS/following{/other_user}","gists_url":"https://api.github.com/users/microROS/gists{/gist_id}","starred_url":"https://api.github.com/users/microROS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microROS/subscriptions","organizations_url":"https://api.github.com/users/microROS/orgs","repos_url":"https://api.github.com/users/microROS/repos","events_url":"https://api.github.com/users/microROS/events{/privacy}","received_events_url":"https://api.github.com/users/microROS/received_events","type":"Organization","site_admin":false},"repo":{"id":122340276,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIzNDAyNzY=","name":"microros.github.io","full_name":"microROS/microros.github.io","private":false,"owner":{"login":"microROS","id":34708703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzA4NzAz","avatar_url":"https://avatars0.githubusercontent.com/u/34708703?v=4","gravatar_id":"","url":"https://api.github.com/users/microROS","html_url":"https://github.com/microROS","followers_url":"https://api.github.com/users/microROS/followers","following_url":"https://api.github.com/users/microROS/following{/other_user}","gists_url":"https://api.github.com/users/microROS/gists{/gist_id}","starred_url":"https://api.github.com/users/microROS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microROS/subscriptions","organizations_url":"https://api.github.com/users/microROS/orgs","repos_url":"https://api.github.com/users/microROS/repos","events_url":"https://api.github.com/users/microROS/events{/privacy}","received_events_url":"https://api.github.com/users/microROS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/microROS/microros.github.io","description":"A platform for seamless integration of resource constrained devices in the ROS ecosystem.","fork":false,"url":"https://api.github.com/repos/microROS/microros.github.io","forks_url":"https://api.github.com/repos/microROS/microros.github.io/forks","keys_url":"https://api.github.com/repos/microROS/microros.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microROS/microros.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microROS/microros.github.io/teams","hooks_url":"https://api.github.com/repos/microROS/microros.github.io/hooks","issue_events_url":"https://api.github.com/repos/microROS/microros.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/microROS/microros.github.io/events","assignees_url":"https://api.github.com/repos/microROS/microros.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/microROS/microros.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/microROS/microros.github.io/tags","blobs_url":"https://api.github.com/repos/microROS/microros.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microROS/microros.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microROS/microros.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/microROS/microros.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microROS/microros.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/microROS/microros.github.io/languages","stargazers_url":"https://api.github.com/repos/microROS/microros.github.io/stargazers","contributors_url":"https://api.github.com/repos/microROS/microros.github.io/contributors","subscribers_url":"https://api.github.com/repos/microROS/microros.github.io/subscribers","subscription_url":"https://api.github.com/repos/microROS/microros.github.io/subscription","commits_url":"https://api.github.com/repos/microROS/microros.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/microROS/microros.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/microROS/microros.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/microROS/microros.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/microROS/microros.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/microROS/microros.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microROS/microros.github.io/merges","archive_url":"https://api.github.com/repos/microROS/microros.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microROS/microros.github.io/downloads","issues_url":"https://api.github.com/repos/microROS/microros.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/microROS/microros.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/microROS/microros.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/microROS/microros.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microROS/microros.github.io/labels{/name}","releases_url":"https://api.github.com/repos/microROS/microros.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/microROS/microros.github.io/deployments","created_at":"2018-02-21T13:31:55Z","updated_at":"2019-03-06T08:59:03Z","pushed_at":"2019-03-06T09:40:10Z","git_url":"git://github.com/microROS/microros.github.io.git","ssh_url":"[email protected]:microROS/microros.github.io.git","clone_url":"https://github.com/microROS/microros.github.io.git","svn_url":"https://github.com/microROS/microros.github.io","homepage":"https://microros.github.io","size":24976,"stargazers_count":33,"watchers_count":33,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":3,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/microROS/microros.github.io/pulls/13"},"html":{"href":"https://github.com/microROS/microros.github.io/pull/13"},"issue":{"href":"https://api.github.com/repos/microROS/microros.github.io/issues/13"},"comments":{"href":"https://api.github.com/repos/microROS/microros.github.io/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/microROS/microros.github.io/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/microROS/microros.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/microROS/microros.github.io/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/microROS/microros.github.io/statuses/72a3eb40efb80101d475081d1ef571b8042cfcb7"}},"author_association":"CONTRIBUTOR"}}	{ "id": 122340276, "name": "microROS/microros.github.io", "url": "https://api.github.com/repos/microROS/microros.github.io" }	{ "id": 289154, "login": "iluetkeb", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/289154?", "url": "https://api.github.com/users/iluetkeb" }	{ "id": 34708703, "login": "microROS", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/34708703?", "url": "https://api.github.com/orgs/microROS" }	2019-03-10T13:02:35	9213565213	{"actor":{"display_login":"iluetkeb"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/comments/264100342","pull_request_review_id":212671215,"id":264100342,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NDEwMDM0Mg==","diff_hunk":"@@ -0,0 +1,350 @@\n+// Copyright (c) 2019 WSO2 Inc. (http://www.wso2.org) All Rights Reserved.\n+//\n+// WSO2 Inc. licenses this file to you under the Apache License,\n+// Version 2.0 (the \"License\"); you may not use this file except\n+// in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+// http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing,\n+// software distributed under the License is distributed on an\n+// \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+// KIND, either express or implied. See the License for the\n+// specific language governing permissions and limitations\n+// under the License.\n+\n+import ballerina/config;\n+import ballerina/internal;\n+import ballerina/io;\n+import ballerina/math;\n+import ballerina/runtime;\n+import ballerina/task;\n+import ballerina/time;\n+\n+# Abstract Snapshotable to be referenced by all snapshotable objects.\n+public type Snapshotable abstract object {\n+\n+ # Function to return the current state of a snapshotable object.\n+ # + return - A `map<any>` that represents the current state of\n+ # the snapshotable instance.\n+ public function saveState() returns map<any>;\n+\n+ # Function to restore a previous state intoa a snapshotable object.\n+ # + state - A `map<any>` state that can be used to restore\n+ # snapshotable instance to a previous state.\n+ public function restoreState(map<any> state);\n+};\n+\n+// Global variables to be used with snapshot persistence.\n+task:Timer? persistTimer = ();\n+map<map<any>> streamsPersistanceState = {};\n+map<Snapshotable> snapshotables = {};\n+string persistanceDirectory = \"snapshots\";\n+int persistanceIntervalInMillis = 30000;\n+boolean stateLoaded = false;\n+map<boolean> loadedStates = {};\n+\n+# Native function to deserialize a serialized snapshot.\n+# + str - A `string` of serialized content.\n+# + return - A deserialized `map<any>` state.\n+extern function deserialize(string str) returns map<any>;\n+\n+# Native function to serialize a snapshot.\n+# + data - A `map<any>` state to be serialized.\n+# + return - A `string` of serialized state.\n+extern function serialize(map<any> data) returns string;\n+\n+# Function to read given number of characters from an io:ReadableCharacterChannel.\n+# + rch - A `ReadableCharacterChannel` instance.\n+# + numberOfCharacters - A `int` indicating number of chars to read.\n+# + return - A `string` of content or an `error`.\n+function readCharacters(io:ReadableCharacterChannel rch, int numberOfCharacters) returns string\|error {\n+ return rch.read(numberOfCharacters);\n+}\n+\n+# Function to read all characters as a string from an io:ReadableCharacterChannel.\n+# + rch - A `ReadableCharacterChannel` instance.\n+# + return - A `string` of content or an `error`.\n+function readAllCharacters(io:ReadableCharacterChannel rch) returns string\|error? {\n+ int fixedSize = 128;\n+ boolean isDone = false;\n+ string result = \"\";\n+ while (!isDone) {\n+ var readResult = readCharacters(rch, fixedSize);\n+ if (readResult is string) {\n+ result = result + readResult;\n+ } else {\n+ if (<string>readResult.detail()[\"message\"] == \"io.EOF\") {\n+ isDone = true;\n+ } else {\n+ return readResult;\n+ }\n+ }\n+ }\n+ return result;\n+}\n+\n+# Function to write a string to a file using an io:WritableCharacterChannel.\n+# + wch - A `WritableCharacterChannel` instance.\n+# + content - The `string` content to be written.\n+# + startOffset - A `int` indicating start offset.\n+# + return - A `int` indicating number of chars got written or an `error`.\n+function writeCharacters(io:WritableCharacterChannel wch, string content, int startOffset) returns int\|error? {\n+ return wch.write(content, startOffset);\n+}\n+\n+# Function to initialize an io:ReadableCharacterChannel.\n+# + filePath - A `string` path to the file.\n+# + encoding - A `string` indicating the encoding type.\n+# + return - The `ReadableCharacterChannel` which got initilized.\n+function createReadableCharacterChannel(string filePath, string encoding) returns io:ReadableCharacterChannel? {\n+ io:ReadableCharacterChannel? rch = ();\n+ io:ReadableByteChannel\|error byteChannel = trap io:openReadableFile(filePath);\n+ if (byteChannel is io:ReadableByteChannel) {\n+ rch = untaint new io:ReadableCharacterChannel(byteChannel, encoding);\n+ }\n+ return rch;\n+}\n+\n+# Function to initialize an io:WritableCharacterChannel.\n+# + filePath - A `string` path to the file.\n+# + encoding - A `string` indicating the encoding type.\n+# + return - The `WritableCharacterChannel` which got initilized.\n+function createWritableCharacterChannel(string filePath, string encoding) returns io:WritableCharacterChannel? {\n+ io:WritableCharacterChannel? wch = ();\n+ io:WritableByteChannel\|error byteChannel = trap io:openWritableFile(filePath);\n+ if (byteChannel is io:WritableByteChannel) {\n+ wch = untaint new io:WritableCharacterChannel(byteChannel, encoding);\n+ }\n+ return wch;\n+}\n+\n+# Function to close writable/readable character channels.\n+# + c - Character channel to be closed.\n+function closeCharChannel(any c) {\n+ if (c is io:ReadableCharacterChannel) {\n+ var err = c.close();\n+ } else if (c is io:WritableCharacterChannel) {\n+ var err = c.close();\n+ }\n+}\n+\n+# Function to read a text file.\n+# + filePath - A `string` path to the file.\n+# + encoding - A `string` indicating the encoding type.\n+# + return - The `string` content of the file.\n+function readFile(string filePath, string encoding) returns string {\n+ string content = \"\";\n+ io:ReadableCharacterChannel? rch = createReadableCharacterChannel(filePath, encoding);\n+ if (rch is io:ReadableCharacterChannel) {\n+ string\|error? c = readAllCharacters(rch);\n+ closeCharChannel(rch);\n+ if (c is string) {\n+ content = c;\n+ }\n+ }\n+ return content;\n+}\n+\n+# Function to write text to a file.\n+# + filePath - A `string` path to the file.\n+# + encoding - A `string` indicating the encoding type.\n+# + content - A `string` content to be written.\n+# + return - An `int` indicating how many chars got written.\n+function writeToFile(string filePath, string encoding, string content) returns int {\n+ int written = 0;\n+ io:WritableCharacterChannel? wch = createWritableCharacterChannel(filePath, encoding);\n+ if (wch is io:WritableCharacterChannel) {\n+ int\|error? i = writeCharacters(wch, content, 0);\n+ closeCharChannel(wch);\n+ if (i is int) {\n+ written = i;\n+ }\n+ }\n+ return written;\n+}\n+\n+# Function to serialize a Snapshotable state and write that to given file.\n+# + persistancePath - A `string` path of the persistance directory.\n+# + return - An `error` if state cannot be written to a file.\n+function writeStateToFile(string persistancePath) returns error? {\n+ string? snapshotFile = ();\n+ time:Time ct = time:currentTime();\n+ int currentTimeMillis = ct.time;\n+ internal:Path pPath = new(persistancePath);\n+ if (!pPath.exists()) {\n+ error? e = pPath.createDirectory();\n+ }\n+ internal:Path path = pPath.resolve(string.convert(currentTimeMillis));\n+ if (!path.exists()) {\n+ error? e = path.createFile();\n+ if (e is ()) {\n+ snapshotFile = path.getPathValue();\n+ }\n+ }\n+ if (snapshotFile is string) {\n+ string serialized = serialize(streamsPersistanceState);\n+ int written = writeToFile(snapshotFile, \"UTF8\", serialized);\n+ if (written > 0) {\n+ return;\n+ } else {\n+ error e = error(\"Error while writing streaming state to a file.\");\n+ return e;\n+ }\n+ } else {\n+ error e = error(\"Error while creating snapshot file: \" + path.getPathValue());\n+ return e;\n+ }\n+}\n+\n+# Function to log a persitance error.\n+# + error - The `error` occured while persisting the state.\n+function persitanceError(error e) {\n+ io:println(\"[ERROR] failed to persist state: \", e.detail());\n+}\n+\n+# Function to get all snapshot files in persistance path\n+# + persistancePath - A `string` path of the persistance directory.\n+# + return - An `array` containing absolute paths of all snapshot files.\n+function getSnapshotFiles(string persistancePath) returns string[] {\n+ string[] snapshotFiles = [];\n+ internal:Path path = new(persistancePath);\n+ if (path.exists()) {\n+ var files = path.list();\n+ int[] timestamps = [];\n+ if (files is internal:Path[]) {\n+ foreach internal:Path p in files {\n+ int\|error t = int.convert(p.getName());\n+ if (t is int) {\n+ timestamps[timestamps.length()] = t;\n+ }\n+ }\n+ }\n+ IntSort s = new;\n+ s.sort(timestamps);\n+ foreach int t in timestamps {\n+ internal:Path sf = path.resolve(string.convert(t));\n+ snapshotFiles[snapshotFiles.length()] = sf.getPathValue();\n+ }\n+ }\n+ return snapshotFiles;\n+}\n+\n+# Function to get latest snapshot file in persistance path\n+# + persistancePath - A `string` path of the persistance directory.\n+# + return - A `string` absolute path of the latest snapshot file.\n+function getLatestSnapshotFile(string persistancePath) returns string? {\n+ string[] files = getSnapshotFiles(persistancePath);\n+ string? latestFile = ();\n+ if (files.length() > 0) {\n+ latestFile = files[files.length() - 1];\n+ }\n+ return latestFile;\n+}\n+\n+# Function to purge/delete old snapshot files from persistance path\n+# + persistancePath - A `string` path of the directory where the states should get persisted.\n+function purgeOldSnapshotFiles(string persistancePath) {\n+ int revisionsToKeep = 5;\n+ string[] files = getSnapshotFiles(persistancePath);\n+ if (files.length() > revisionsToKeep) {\n+ int i = 0;\n+ while (i < (files.length() - revisionsToKeep)) {\n+ string f = files[i];\n+ internal:Path p = new(f);\n+ if (p.exists()) {\n+ error? e = p.delete();\n+ if (e is error) {\n+ io:println(\"couldn't delete snapshot \", p.getPathValue(), \". \", e.detail());\n+ }\n+ }\n+ i += 1;\n+ }\n+ }\n+}\n+\n+# Function to restore a persisted snapshotable states from a file.\n+function restoreStates() {\n+ if (!stateLoaded) {\n+ string? lastSnapshotFile = getLatestSnapshotFile(persistanceDirectory);\n+ if (lastSnapshotFile is string) {\n+ string stateStr = readFile(lastSnapshotFile, \"UTF8\");\n+ var retrievedState = trap deserialize(stateStr);\n+ if (retrievedState is map<map<any>>) {\n+ streamsPersistanceState = retrievedState;\n+ stateLoaded = true;\n+ }\n+ }\n+ }\n+ foreach var (k, v) in streamsPersistanceState {\n+ boolean loaded = loadedStates[k] ?: false;\n+ if (!loaded) {\n+ Snapshotable? s = snapshotables[k];\n+ if (s is Snapshotable) {\n+ s.restoreState(v);\n+ loadedStates[k] = true;\n+ }\n+ }\n+ }\n+}\n+\n+# Function to iterate through all the snapshotables, and persist their states into a file.\n+# + return - An `error` if the state cannot be persisted into a file.\n+function persistStatesAndPurgeOldSnapshots() returns error? {\n+ foreach var (k, v) in snapshotables {\n+ streamsPersistanceState[k] = v.saveState();\n+ }\n+ error? e = writeStateToFile(persistanceDirectory);\n+ purgeOldSnapshotFiles(persistanceDirectory);\n+ return e;\n+}\n+\n+# Function to initilize a Timer task and start periodic snapshotting.\n+function startPersisting() {\n+ (function () returns error?) onTriggerFunction = persistStatesAndPurgeOldSnapshots;\n+ function (error) onErrorFunction = persitanceError;\n+ persistTimer = new task:Timer(onTriggerFunction, onErrorFunction, persistanceIntervalInMillis,\n+ delay = persistanceIntervalInMillis);\n+ persistTimer.start();\n+}\n+\n+# Function to restore state of a given object.\n+# + k - An unique `string` identifier for the snapshotable reference.\n+# + o - The snapshotable reference to be restored.\n+public function restoreState(string k, any o) {","path":"stdlib/streams/src/main/ballerina/streams/snapshot.bal","position":315,"original_position":315,"commit_id":"7c5a79fae2c712ad812ecbf71e0ee9b6e4b78a06","original_commit_id":"7c5a79fae2c712ad812ecbf71e0ee9b6e4b78a06","user":{"login":"MaryamZi","id":8376983,"node_id":"MDQ6VXNlcjgzNzY5ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/8376983?v=4","gravatar_id":"","url":"https://api.github.com/users/MaryamZi","html_url":"https://github.com/MaryamZi","followers_url":"https://api.github.com/users/MaryamZi/followers","following_url":"https://api.github.com/users/MaryamZi/following{/other_user}","gists_url":"https://api.github.com/users/MaryamZi/gists{/gist_id}","starred_url":"https://api.github.com/users/MaryamZi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaryamZi/subscriptions","organizations_url":"https://api.github.com/users/MaryamZi/orgs","repos_url":"https://api.github.com/users/MaryamZi/repos","events_url":"https://api.github.com/users/MaryamZi/events{/privacy}","received_events_url":"https://api.github.com/users/MaryamZi/received_events","type":"User","site_admin":false},"body":"Can we improve the parameter names? Since these are public functions too?","created_at":"2019-03-11T06:11:37Z","updated_at":"2019-03-11T06:13:02Z","html_url":"https://github.com/ballerina-platform/ballerina-lang/pull/13724#discussion_r264100342","pull_request_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/13724","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/comments/264100342"},"html":{"href":"https://github.com/ballerina-platform/ballerina-lang/pull/13724#discussion_r264100342"},"pull_request":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/13724"}}},"pull_request":{"url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/13724","id":254529561,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0NTI5NTYx","html_url":"https://github.com/ballerina-platform/ballerina-lang/pull/13724","diff_url":"https://github.com/ballerina-platform/ballerina-lang/pull/13724.diff","patch_url":"https://github.com/ballerina-platform/ballerina-lang/pull/13724.patch","issue_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/13724","number":13724,"state":"open","locked":false,"title":"Introduce state persistence for Ballerina streams","user":{"login":"grainier","id":3824254,"node_id":"MDQ6VXNlcjM4MjQyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3824254?v=4","gravatar_id":"","url":"https://api.github.com/users/grainier","html_url":"https://github.com/grainier","followers_url":"https://api.github.com/users/grainier/followers","following_url":"https://api.github.com/users/grainier/following{/other_user}","gists_url":"https://api.github.com/users/grainier/gists{/gist_id}","starred_url":"https://api.github.com/users/grainier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grainier/subscriptions","organizations_url":"https://api.github.com/users/grainier/orgs","repos_url":"https://api.github.com/users/grainier/repos","events_url":"https://api.github.com/users/grainier/events{/privacy}","received_events_url":"https://api.github.com/users/grainier/received_events","type":"User","site_admin":false},"body":"## Purpose\r\nThis PR will introduce state persistence for Ballerina streams so that it will allow persisting the in-memory state of Ballerina streams (windows, aggregators, etc..) and recover in case of a failure.\r\n\r\n## Approach\r\nThis introduces an abstract Snapshotable object with saveState and restoreState methods, and any other object (windows and aggregators) which refers (implements) that will get snapshotted periodically, allowing it to recover in case of a failure.\r\n\r\n## Documentation\r\nThis feature can be enabled and customized by using the following config params;\r\n - \"b7a.streaming.persistence.enabled\" default = false\r\n - \"b7a.streaming.persistence.directory\" default = \"snapshots\"\r\n - \"b7a.streaming.persistence.interval\" default = 30 seconds\r\n\r\n## Automation tests\r\n - Unit tests provided.\r\n\r\n## Security checks\r\n - Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes\r\n - Ran FindSecurityBugs plugin and verified report? yes\r\n - Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes\r\n\r\n\r\n","created_at":"2019-02-20T07:36:46Z","updated_at":"2019-03-11T06:13:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"300c2b5c7f8a85992d10abbe431f0603b75568ae","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rdhananjaya","id":1496990,"node_id":"MDQ6VXNlcjE0OTY5OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1496990?v=4","gravatar_id":"","url":"https://api.github.com/users/rdhananjaya","html_url":"https://github.com/rdhananjaya","followers_url":"https://api.github.com/users/rdhananjaya/followers","following_url":"https://api.github.com/users/rdhananjaya/following{/other_user}","gists_url":"https://api.github.com/users/rdhananjaya/gists{/gist_id}","starred_url":"https://api.github.com/users/rdhananjaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdhananjaya/subscriptions","organizations_url":"https://api.github.com/users/rdhananjaya/orgs","repos_url":"https://api.github.com/users/rdhananjaya/repos","events_url":"https://api.github.com/users/rdhananjaya/events{/privacy}","received_events_url":"https://api.github.com/users/rdhananjaya/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":828131123,"node_id":"MDU6TGFiZWw4MjgxMzExMjM=","url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/labels/Component/Compiler","name":"Component/Compiler","color":"0b6664","default":false},{"id":927339469,"node_id":"MDU6TGFiZWw5MjczMzk0Njk=","url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/labels/Component/Streams","name":"Component/Streams","color":"006b75","default":false},{"id":684576184,"node_id":"MDU6TGFiZWw2ODQ1NzYxODQ=","url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/labels/Type/New%20Feature","name":"Type/New Feature","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/13724/commits","review_comments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/13724/comments","review_comment_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/13724/comments","statuses_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/statuses/7c5a79fae2c712ad812ecbf71e0ee9b6e4b78a06","head":{"label":"grainier:state-persistence","ref":"state-persistence","sha":"7c5a79fae2c712ad812ecbf71e0ee9b6e4b78a06","user":{"login":"grainier","id":3824254,"node_id":"MDQ6VXNlcjM4MjQyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3824254?v=4","gravatar_id":"","url":"https://api.github.com/users/grainier","html_url":"https://github.com/grainier","followers_url":"https://api.github.com/users/grainier/followers","following_url":"https://api.github.com/users/grainier/following{/other_user}","gists_url":"https://api.github.com/users/grainier/gists{/gist_id}","starred_url":"https://api.github.com/users/grainier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grainier/subscriptions","organizations_url":"https://api.github.com/users/grainier/orgs","repos_url":"https://api.github.com/users/grainier/repos","events_url":"https://api.github.com/users/grainier/events{/privacy}","received_events_url":"https://api.github.com/users/grainier/received_events","type":"User","site_admin":false},"repo":{"id":119517754,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk1MTc3NTQ=","name":"ballerina","full_name":"grainier/ballerina","private":false,"owner":{"login":"grainier","id":3824254,"node_id":"MDQ6VXNlcjM4MjQyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3824254?v=4","gravatar_id":"","url":"https://api.github.com/users/grainier","html_url":"https://github.com/grainier","followers_url":"https://api.github.com/users/grainier/followers","following_url":"https://api.github.com/users/grainier/following{/other_user}","gists_url":"https://api.github.com/users/grainier/gists{/gist_id}","starred_url":"https://api.github.com/users/grainier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grainier/subscriptions","organizations_url":"https://api.github.com/users/grainier/orgs","repos_url":"https://api.github.com/users/grainier/repos","events_url":"https://api.github.com/users/grainier/events{/privacy}","received_events_url":"https://api.github.com/users/grainier/received_events","type":"User","site_admin":false},"html_url":"https://github.com/grainier/ballerina","description":"Ballerina is a new programming language for integration built on a sequence diagram metaphor.","fork":true,"url":"https://api.github.com/repos/grainier/ballerina","forks_url":"https://api.github.com/repos/grainier/ballerina/forks","keys_url":"https://api.github.com/repos/grainier/ballerina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grainier/ballerina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grainier/ballerina/teams","hooks_url":"https://api.github.com/repos/grainier/ballerina/hooks","issue_events_url":"https://api.github.com/repos/grainier/ballerina/issues/events{/number}","events_url":"https://api.github.com/repos/grainier/ballerina/events","assignees_url":"https://api.github.com/repos/grainier/ballerina/assignees{/user}","branches_url":"https://api.github.com/repos/grainier/ballerina/branches{/branch}","tags_url":"https://api.github.com/repos/grainier/ballerina/tags","blobs_url":"https://api.github.com/repos/grainier/ballerina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grainier/ballerina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grainier/ballerina/git/refs{/sha}","trees_url":"https://api.github.com/repos/grainier/ballerina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grainier/ballerina/statuses/{sha}","languages_url":"https://api.github.com/repos/grainier/ballerina/languages","stargazers_url":"https://api.github.com/repos/grainier/ballerina/stargazers","contributors_url":"https://api.github.com/repos/grainier/ballerina/contributors","subscribers_url":"https://api.github.com/repos/grainier/ballerina/subscribers","subscription_url":"https://api.github.com/repos/grainier/ballerina/subscription","commits_url":"https://api.github.com/repos/grainier/ballerina/commits{/sha}","git_commits_url":"https://api.github.com/repos/grainier/ballerina/git/commits{/sha}","comments_url":"https://api.github.com/repos/grainier/ballerina/comments{/number}","issue_comment_url":"https://api.github.com/repos/grainier/ballerina/issues/comments{/number}","contents_url":"https://api.github.com/repos/grainier/ballerina/contents/{+path}","compare_url":"https://api.github.com/repos/grainier/ballerina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grainier/ballerina/merges","archive_url":"https://api.github.com/repos/grainier/ballerina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grainier/ballerina/downloads","issues_url":"https://api.github.com/repos/grainier/ballerina/issues{/number}","pulls_url":"https://api.github.com/repos/grainier/ballerina/pulls{/number}","milestones_url":"https://api.github.com/repos/grainier/ballerina/milestones{/number}","notifications_url":"https://api.github.com/repos/grainier/ballerina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grainier/ballerina/labels{/name}","releases_url":"https://api.github.com/repos/grainier/ballerina/releases{/id}","deployments_url":"https://api.github.com/repos/grainier/ballerina/deployments","created_at":"2018-01-30T10:03:08Z","updated_at":"2018-07-17T07:33:47Z","pushed_at":"2019-03-11T05:38:32Z","git_url":"git://github.com/grainier/ballerina.git","ssh_url":"[email protected]:grainier/ballerina.git","clone_url":"https://github.com/grainier/ballerina.git","svn_url":"https://github.com/grainier/ballerina","homepage":"","size":321270,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ballerina-platform:master","ref":"master","sha":"26f8f3fc59dfc5efeeef155ce30e519f2d032c90","user":{"login":"ballerina-platform","id":34733518,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzMzNTE4","avatar_url":"https://avatars2.githubusercontent.com/u/34733518?v=4","gravatar_id":"","url":"https://api.github.com/users/ballerina-platform","html_url":"https://github.com/ballerina-platform","followers_url":"https://api.github.com/users/ballerina-platform/followers","following_url":"https://api.github.com/users/ballerina-platform/following{/other_user}","gists_url":"https://api.github.com/users/ballerina-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/ballerina-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ballerina-platform/subscriptions","organizations_url":"https://api.github.com/users/ballerina-platform/orgs","repos_url":"https://api.github.com/users/ballerina-platform/repos","events_url":"https://api.github.com/users/ballerina-platform/events{/privacy}","received_events_url":"https://api.github.com/users/ballerina-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":73930305,"node_id":"MDEwOlJlcG9zaXRvcnk3MzkzMDMwNQ==","name":"ballerina-lang","full_name":"ballerina-platform/ballerina-lang","private":false,"owner":{"login":"ballerina-platform","id":34733518,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzMzNTE4","avatar_url":"https://avatars2.githubusercontent.com/u/34733518?v=4","gravatar_id":"","url":"https://api.github.com/users/ballerina-platform","html_url":"https://github.com/ballerina-platform","followers_url":"https://api.github.com/users/ballerina-platform/followers","following_url":"https://api.github.com/users/ballerina-platform/following{/other_user}","gists_url":"https://api.github.com/users/ballerina-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/ballerina-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ballerina-platform/subscriptions","organizations_url":"https://api.github.com/users/ballerina-platform/orgs","repos_url":"https://api.github.com/users/ballerina-platform/repos","events_url":"https://api.github.com/users/ballerina-platform/events{/privacy}","received_events_url":"https://api.github.com/users/ballerina-platform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ballerina-platform/ballerina-lang","description":"Ballerina is a compiled, transactional, statically and strongly typed programming language with textual and graphical syntaxes.","fork":false,"url":"https://api.github.com/repos/ballerina-platform/ballerina-lang","forks_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/forks","keys_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/teams","hooks_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/hooks","issue_events_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/events{/number}","events_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/events","assignees_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/assignees{/user}","branches_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/branches{/branch}","tags_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/tags","blobs_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/refs{/sha}","trees_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/statuses/{sha}","languages_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/languages","stargazers_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/stargazers","contributors_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/contributors","subscribers_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/subscribers","subscription_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/subscription","commits_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/commits{/sha}","git_commits_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/commits{/sha}","comments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/comments{/number}","issue_comment_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/comments{/number}","contents_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/contents/{+path}","compare_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/merges","archive_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/downloads","issues_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues{/number}","pulls_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls{/number}","milestones_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/milestones{/number}","notifications_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/labels{/name}","releases_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/releases{/id}","deployments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/deployments","created_at":"2016-11-16T14:58:44Z","updated_at":"2019-03-11T05:10:43Z","pushed_at":"2019-03-11T06:12:55Z","git_url":"git://github.com/ballerina-platform/ballerina-lang.git","ssh_url":"[email protected]:ballerina-platform/ballerina-lang.git","clone_url":"https://github.com/ballerina-platform/ballerina-lang.git","svn_url":"https://github.com/ballerina-platform/ballerina-lang","homepage":"https://ballerina.io/","size":323620,"stargazers_count":1683,"watchers_count":1683,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":424,"mirror_url":null,"archived":false,"open_issues_count":885,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":424,"open_issues":885,"watchers":1683,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/13724"},"html":{"href":"https://github.com/ballerina-platform/ballerina-lang/pull/13724"},"issue":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/13724"},"comments":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/13724/comments"},"review_comments":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/13724/comments"},"review_comment":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/13724/commits"},"statuses":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/statuses/7c5a79fae2c712ad812ecbf71e0ee9b6e4b78a06"}},"author_association":"CONTRIBUTOR"}}	{ "id": 73930305, "name": "ballerina-platform/ballerina-lang", "url": "https://api.github.com/repos/ballerina-platform/ballerina-lang" }	{ "id": 8376983, "login": "MaryamZi", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/8376983?", "url": "https://api.github.com/users/MaryamZi" }	{ "id": 34733518, "login": "ballerina-platform", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/34733518?", "url": "https://api.github.com/orgs/ballerina-platform" }	2019-03-11T06:11:37	9215973026	{"actor":{"display_login":"MaryamZi"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/strimzi/strimzi.github.io/pulls/comments/281646032","pull_request_review_id":234516464,"id":281646032,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MTY0NjAzMg==","diff_hunk":"@@ -0,0 +1,319 @@\n+---\n+layout: post\n+title: \"Accessing Kafka: Part 4 - Load Balancers\"\n+date: 2019-05-06\n+author: jakub_scholz\n+---\n+\n+In the fourth part of this blog post series we will look at exposing Kafka using load balancers.\n+This post will explain how to use load balancers in public cloud environments and how they can be used with Kafka.\n+\n+<!--more-->\n+\n+_This post is part of a bigger series about different ways to access a Kafka cluster powered by Strimzi.\n+The other parts published so far are:_\n+\n+* _[Part 1 - Introduction](https://strimzi.io/2019/04/17/accessing-kafka-part-1.html)_\n+* _[Part 2 - Node Ports](https://strimzi.io/2019/04/23/accessing-kafka-part-2.html)_\n+* _[Part 3 - OpenShift Routes](https://strimzi.io/2019/04/30/accessing-kafka-part-3.html)_\n+* _Part 4 - Load Balancers (this post)_\n+\n+# Load balancers\n+\n+Load balancers automatically distribute incoming traffic across multiple targets.\n+Different implementations do the traffic distribution on different level:\n+\n+* Layer 7 load balancers can distribute the traffic on the level of individual requests (for example HTTP requests)\n+* Layer 4 load balancers distribute the TCP connections\n+\n+Load balancers are available in most public and private clouds.\n+Examples of load balancers are Elastic Load Balancing services from Amazon AWS, Azure Load Balancer in Microsoft Azure public cloud or Google Cloud Load Balancing service from Google.\n+Load balancing services are also available in OpenStack.\n+If you run your Kubernetes or OpenShift cluster on bare metal, you might not have load balancers available on demand.\n+In that case, using node ports, OpenShift Routes or Ingress might be a better option for you.\n+\n+Do not get scared by the long list of different load balancing services.\n+Most of them are very well integrated with Kubernetes.\n+When the Kubernetes service as configured with the type `Loadbalancer`, Kubernetes will automatically create the load balancer through the cloud provider, which understands the different services offered by given cloud.\n+Thanks to that the Kubernetes applications - including Strimzi - do not need to understand the differences and should work everywhere where the cloud infrastructure and Kubernetes are properly integrated.\n+\n+# Using load balancers in Strimzi\n+\n+Since none of the common load balancing services supports the Kafka protocol, Strimzi always uses the Layer 4 load balancing.\n+Since Layer 4 works on the TCP level, it means that the load balancer will always take the whole TCP connection and direct it to one of the targets.\n+That has some advantages - you can for example decide whether TLS encryption should be enabled or disabled.\n+\n+To give Kafka clients access to the individual brokers, Strimzi creates a separate service with `type=Loadbalancer` for each broker.\n+As a result, each broker will get a separate load balancer _(despite the Kubernetes service being of a load balancer type, the load balancer is still a separate entity manages by the infrastructure / cloud)_.\n+A Kafka cluster with N brokers will need N+1 load balancers.\n+\n+![Accessing Kafka using load balancers]({{ \"/assets/2019-05-06-per-pod-load-balancers.png\" }})\n+\n+On the beginning of this post we defined load balancer as something what _distribute incoming traffic across multiple targets_.\n+However, as you can set from the diagram above, the per-broker load balancers have only one target and are technically not load balancing.\n+That is true, but in most cases the actual implementation is a bit more complicated.\n+\n+When Kubernetes create the load balancer, they usually target it to all nodes of your Kubernetes cluster and not only to the nodes where your application is actually running.\n+That means that although the TCP connections will always end on the same node in the same broker, they might be routed through the other nodes of your cluster.\n+When the connection is sent by the load balancer to the node which does not host the Kafka broker, the `kube-proxy` component of Kubernetes will forward it to the right node where the broker runs.\n+This can lead to some delays since some fo the connections might be routed through more hops then absolutely necessary.\n+\n+![Routing of connections through `kube-proxy`]({{ \"/assets/2019-05-06-connection-routing.png\" }})\n+\n+The only exception is the bootstrap load balancer which is distributing the connections to all brokers in your Kafka cluster.\n+\n+You can very easily configure Strimzi Kafka operator to expose your Kafka cluster using load balancers by selecting the `loadbalancer` type in the external listener:\n+\n+```yaml\n+apiVersion: kafka.strimzi.io/v1beta1\n+kind: Kafka\n+metadata:\n+ name: my-cluster\n+spec:\n+ kafka:\n+ # ...\n+ listeners:\n+ # ...\n+ external:\n+ type: loadbalancer\n+ # ...\n+```\n+\n+Similarly to the node port external listener, also with load balancers TLS is enabled by default.\n+If you don't want to use TLS encryption, you can easily disable it:\n+\n+```yaml\n+ # ...\n+ listeners:\n+ external:\n+ type: loadbalancer\n+ tls: false\n+ # ...\n+```\n+\n+After Strimzi creates the load balancer type Kubernetes services, the load balancers will be automatically created.\n+Most clouds will automatically assign the load balancer some DNS name and IP addresses.\n+These will be automatically propagated into the `status` section of the Kubernetes service.\n+Strimzi will read it from there and use it to configure the advertised address in the Kafka brokers.\n+When available, Strimzi currently always prefers the DNS name over the IP address.\n+The reason is that the IP addresses are often volatile while the DNS name is fixes for the whole lifetime of the load balancer (this applies at least to Amazon AWS ELB load balancers).\n+But if the load balancer has only an IP address, Strimzi will of course use it.\n+\n+As a user, you should always use the bootstrap load balancer address for the initial connection.\n+You can get the address form the `status` section with following command (replace `my-cluster` with the name of your cluster):\n+\n+```\n+kubectl get service my-cluster-kafka-external-bootstrap -o=jsonpath='{.status.loadBalancer.ingress[0].hostname}{\"\\n\"}'\n+```\n+\n+In case there is no hostname set, you can also try the IP address (replace `my-cluster` with the name of your cluster):\n+\n+```\n+kubectl get service my-cluster-kafka-external-bootstrap -o=jsonpath='{.status.loadBalancer.ingress[0].ip}{\"\\n\"}'\n+```\n+\n+The DNS or IP returned by one of these commands can be used in your clients as the bootstrap address.\n+The load balancers use always the port `9094` to expose Apache Kafka.\n+For more details, see the [Strimzi documentation](https://strimzi.io/docs/latest/full.html#proc-accessing-kafka-using-loadbalancers-deployment-configuration-kafka).\n+\n+# Customizations\n+\n+## Advertised hostnames and ports\n+\n+In the section above, I explained how Strimzi will always prefer to use the DNS name over the IP address when configuring the advertised listener address in Kafka brokers.\n+Sometimes, this might be a problem - for example when for whatever reason the DNS resolution doesn't work for your Kafka clients.\n+In that case you can override the advertised hostnames in the `Kafka` custom resource.\n+\n+```yaml\n+# ...\n+listeners:\n+ external:\n+ type: loadbalancer\n+ overrides:\n+ brokers:\n+ - broker: 0\n+ advertisedHost: 216.58.201.78\n+ - broker: 1\n+ advertisedHost: 104.215.148.63\n+ - broker: 2\n+ advertisedHost: 40.112.72.205\n+# ...\n+```\n+\n+I hope that in one of the future versions we will give users a more comfortable option to choose between the IP address and hostname.\n+But this feature might be useful to handle also different kinds of network configurations and translations.\n+If needed, you can also use it to override the node port numbers as well.\n+\n+```yaml\n+# ...\n+listeners:\n+ external:\n+ type: route\n+ authentication:\n+ type: tls\n+ overrides:\n+ brokers:\n+ - broker: 0\n+ advertisedHost: 216.58.201.78\n+ advertisedPort: 12340\n+ - broker: 1\n+ advertisedHost: 104.215.148.63\n+ advertisedPort: 12341\n+ - broker: 2\n+ advertisedHost: 40.112.72.205\n+ advertisedPort: 12342\n+# ...\n+```\n+\n+Just keep in mind that the `advertisedPort` option doesn't really change the port used in the load balancer it self.\n+It changes only the port number used in the advertised listener inside the Kafka broker.\n+\n+## Internal load balancers\n+\n+Many cloud providers differentiate between public and internal load balancers.\n+The public load balancers will get a public IP addresses and DNS names and will be accessible from the whole internal.\n+On the other hand the internal load balancers will only use private IP addresses and hostnames and will be available only from certain private network (for example from other machines in the same Amazon AWS VPC).\n+\n+Often, you want to share you Kafka cluster managed by Strimzi with applications running outside of your Kubernetes or OpenShift cluster but not necessarily with the whole world.\n+In such case the internal load balancers might be handy.\n+\n+Kubernetes will usually always try to create a public load balancer by default.\n+And users can use special annotations to indicate that given Kubernetes service with load balancer type should have the load balancer created as internal.\n+\n+For example:\n+\n+* For Google Cloud, use the annotation `cloud.google.com/load-balancer-type: \"Internal\"`\n+* On Microsoft Azure use `service.beta.kubernetes.io/azure-load-balancer-internal: \"true\"`\n+* Amazon AWS is using `service.beta.kubernetes.io/aws-load-balancer-internal: 0.0.0.0/0`\n+* And OpenStack uses `service.beta.kubernetes.io/openstack-internal-load-balancer: \"true\"`\n+\n+As you can see, most of these are completely different.\n+So instead of integrating all of these into Strimzi, we decided to just give you the option to specify the annotations for the services which Strimzi creates.\n+Thanks to that you can use these annotations even if we never heard about the cloud provider where you use Strimzi.\n+The annotations can be specified in the `template` property in `Kafka.spec.kafka`.\n+The following example shows the OpenStack annotations:\n+\n+```yaml\n+apiVersion: kafka.strimzi.io/v1beta1\n+kind: Kafka\n+metadata:\n+ name: my-cluster\n+spec:\n+ kafka:\n+ # ...\n+ template:\n+ externalBootstrapService:\n+ metadata:\n+ annotations:\n+ service.beta.kubernetes.io/openstack-internal-load-balancer: \"true\"\n+ perPodService:\n+ metadata:\n+ annotations:\n+ service.beta.kubernetes.io/openstack-internal-load-balancer: \"true\"\n+ # ...\n+```\n+\n+You can specify different annotations for the bootstrap and the per-broker services.\n+After you specify these annotations, they will be passed by Strimzi to the Kubernetes services and the load balancers will be created accordingly.\n+\n+## DNS annotations\n+\n+This feature will be available only since Strimzi 0.12.0.\n+\n+Many users are using some additional tools such as [ExternalDNS](https://github.com/kubernetes-incubator/external-dns) to automatically manage DNS records for their load balancers.\n+External DNS is using annotations on load balancer type services (and `Ingress` resources - more about that next time) to manage their DNS names.\n+It supports many different DNs services such as Amazon AWS Route53, Google Cloud DNS, Azure DNS etc.\n+\n+Strimzi lets you assign these annotations through the `Kafka` custom resource using a field called `dnsAnnotations`.\n+The main difference between the template annotations mentioned in previous section is that the `dnsAnnotations` allow you to configure the annotation per each broker. Where as the `perPodService` option of the `template` field will set the annotations to all services.\n+\n+Using the DNS annotations is simple:\n+\n+```yaml\n+# ...\n+listeners:\n+ external:\n+ type: loadbalancer\n+ overrides:\n+ bootstrap:\n+ dnsAnnotations:\n+ external-dns.alpha.kubernetes.io/hostname: kafka-bootstrap.mydomain.com.\n+ external-dns.alpha.kubernetes.io/ttl: \"60\"\n+ brokers:\n+ - broker: 0\n+ dnsAnnotations:\n+ external-dns.alpha.kubernetes.io/hostname: kafka-broker-0.mydomain.com.\n+ external-dns.alpha.kubernetes.io/ttl: \"60\"\n+ - broker: 1\n+ dnsAnnotations:\n+ external-dns.alpha.kubernetes.io/hostname: kafka-broker-1.mydomain.com.\n+ external-dns.alpha.kubernetes.io/ttl: \"60\"\n+ - broker: 2\n+ dnsAnnotations:\n+ external-dns.alpha.kubernetes.io/hostname: kafka-broker-2.mydomain.com.\n+ external-dns.alpha.kubernetes.io/ttl: \"60\"\n+# ...\n+```\n+\n+Yet again, Strimzi lets you configure the annotations directly.\n+That gives you more freedom and hopefully makes this feature usable even when you use some other tool then External DNS.\n+It also lets you configure other options then just the DNS names, such as the time-to-live of the DNS records etc.\n+\n+Please note that the addresses used in the annotations will not be added to the TLS certificates or configured in the advertised listeners of the Kafka brokers.\n+To do so, you need to combine them with the advertised name configuration described in one of the previous section:\n+\n+```yaml\n+# ...\n+listeners:\n+ external:\n+ type: loadbalancer\n+ overrides:\n+ bootstrap:\n+ dnsAnnotations:\n+ external-dns.alpha.kubernetes.io/hostname: kafka-bootstrap.mydomain.com.\n+ address: kafka-bootstrap.mydomain.com\n+ brokers:\n+ - broker: 0\n+ dnsAnnotations:\n+ external-dns.alpha.kubernetes.io/hostname: kafka-broker-0.mydomain.com.\n+ advertisedHost: kafka-broker-0.mydomain.com\n+ - broker: 1\n+ dnsAnnotations:\n+ external-dns.alpha.kubernetes.io/hostname: kafka-broker-1.mydomain.com.\n+ advertisedHost: kafka-broker-1.mydomain.com\n+ - broker: 2\n+ dnsAnnotations:\n+ external-dns.alpha.kubernetes.io/hostname: kafka-broker-2.mydomain.com.\n+ advertisedHost: kafka-broker-2.mydomain.com\n+# ...\n+```\n+\n+# Pros and cons\n+\n+The integration of load balancers into Kubernetes and OpenShift is very good and makes them very easy to use.\n+Strimzi can use the power of Kubernetes to provision them on many different public and private clouds.\n+Thanks to the TCP routing, you can freely decide whether you want to use TLS encryption or not.\n+\n+The load balancers are also something what stands between the applications and the nodes of the Kubernetes cluster.\n+It minimizes the attach surface and many admins would prefer load balancers over node ports for security reasons.\n+\n+Load balancers usually deliver a very good performance.\n+The typical load balancer is a service which runs outside of your cluster.\n+So you do not need to be afraid of how much performance does it need, how much load will it put on your cluster and so on.\n+However, there are some things to keep in mind:\n+\n+* In most cases Kubernetes will configure them to load balance across all cluster nodes.\n+So despite there being only one broker where the traffic will arrive at the end, different connections might be routed to the broker in through different cluster nodes and then forwarded through the `kube-proxy` to the right node where the Kafka broker actually runs.\n+This would not happen for example with node ports, where the advertised address points directly to the node where the broker is running.\n+* The load balancer it self is yet another service which the connection needs to go through.\n+That might add a little bit of latency\n+\n+Another aspect which you should consider is the price.\n+In public clouds, the load balancers are normally not for free.\n+Usually you have to pay some fixed fee per instance which depends only on how long does the load balancer exist plus some fee for every transferred gigabyte.\n+Strimzi always requires N+1 load balancers (where N is the number of brokers) - one for each broker + one for the bootstrapping.\n+So you will always need multiple load balancers and the fees can easily add up.\n+Especially when you realize, that with Kafka in most cases the load balancer does't even balance the load because for most of the load balancers, there is only single broker behind them.","path":"_posts/2019-05-06-accessing-kafka-part-4.md","position":316,"original_position":316,"commit_id":"f4f1a1a7559684a7253c0665f8768d208e1c2286","original_commit_id":"f4f1a1a7559684a7253c0665f8768d208e1c2286","user":{"login":"tombentley","id":879487,"node_id":"MDQ6VXNlcjg3OTQ4Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/879487?v=4","gravatar_id":"","url":"https://api.github.com/users/tombentley","html_url":"https://github.com/tombentley","followers_url":"https://api.github.com/users/tombentley/followers","following_url":"https://api.github.com/users/tombentley/following{/other_user}","gists_url":"https://api.github.com/users/tombentley/gists{/gist_id}","starred_url":"https://api.github.com/users/tombentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tombentley/subscriptions","organizations_url":"https://api.github.com/users/tombentley/orgs","repos_url":"https://api.github.com/users/tombentley/repos","events_url":"https://api.github.com/users/tombentley/events{/privacy}","received_events_url":"https://api.github.com/users/tombentley/received_events","type":"User","site_admin":false},"body":"```suggestion\r\nAnd N of those load balancers don't even balance any load because there is only a single broker behind them.\r\n```","created_at":"2019-05-07T14:04:34Z","updated_at":"2019-05-07T14:04:52Z","html_url":"https://github.com/strimzi/strimzi.github.io/pull/64#discussion_r281646032","pull_request_url":"https://api.github.com/repos/strimzi/strimzi.github.io/pulls/64","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi.github.io/pulls/comments/281646032"},"html":{"href":"https://github.com/strimzi/strimzi.github.io/pull/64#discussion_r281646032"},"pull_request":{"href":"https://api.github.com/repos/strimzi/strimzi.github.io/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/strimzi/strimzi.github.io/pulls/64","id":276032708,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc2MDMyNzA4","html_url":"https://github.com/strimzi/strimzi.github.io/pull/64","diff_url":"https://github.com/strimzi/strimzi.github.io/pull/64.diff","patch_url":"https://github.com/strimzi/strimzi.github.io/pull/64.patch","issue_url":"https://api.github.com/repos/strimzi/strimzi.github.io/issues/64","number":64,"state":"open","locked":false,"title":"Accessing Kafka: Part 4 - Load Balancers","user":{"login":"scholzj","id":5658439,"node_id":"MDQ6VXNlcjU2NTg0Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5658439?v=4","gravatar_id":"","url":"https://api.github.com/users/scholzj","html_url":"https://github.com/scholzj","followers_url":"https://api.github.com/users/scholzj/followers","following_url":"https://api.github.com/users/scholzj/following{/other_user}","gists_url":"https://api.github.com/users/scholzj/gists{/gist_id}","starred_url":"https://api.github.com/users/scholzj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholzj/subscriptions","organizations_url":"https://api.github.com/users/scholzj/orgs","repos_url":"https://api.github.com/users/scholzj/repos","events_url":"https://api.github.com/users/scholzj/events{/privacy}","received_events_url":"https://api.github.com/users/scholzj/received_events","type":"User","site_admin":false},"body":"This is the 4th part of the _Accessing Kafka_ series. Don't be worried about the date set for the post (6th May) - I will change it after the reviews are finished and its ready for publishing.","created_at":"2019-05-05T22:52:17Z","updated_at":"2019-05-07T14:04:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ebd66fc35913b3492e7fc765c34ab9a19be2e66","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/strimzi/strimzi.github.io/pulls/64/commits","review_comments_url":"https://api.github.com/repos/strimzi/strimzi.github.io/pulls/64/comments","review_comment_url":"https://api.github.com/repos/strimzi/strimzi.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strimzi/strimzi.github.io/issues/64/comments","statuses_url":"https://api.github.com/repos/strimzi/strimzi.github.io/statuses/f4f1a1a7559684a7253c0665f8768d208e1c2286","head":{"label":"strimzi:accessing-kafka-part-4","ref":"accessing-kafka-part-4","sha":"f4f1a1a7559684a7253c0665f8768d208e1c2286","user":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"repo":{"id":115119636,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUxMTk2MzY=","name":"strimzi.github.io","full_name":"strimzi/strimzi.github.io","private":false,"owner":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/strimzi/strimzi.github.io","description":"Strimzi web site project","fork":false,"url":"https://api.github.com/repos/strimzi/strimzi.github.io","forks_url":"https://api.github.com/repos/strimzi/strimzi.github.io/forks","keys_url":"https://api.github.com/repos/strimzi/strimzi.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strimzi/strimzi.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strimzi/strimzi.github.io/teams","hooks_url":"https://api.github.com/repos/strimzi/strimzi.github.io/hooks","issue_events_url":"https://api.github.com/repos/strimzi/strimzi.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/strimzi/strimzi.github.io/events","assignees_url":"https://api.github.com/repos/strimzi/strimzi.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/strimzi/strimzi.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/strimzi/strimzi.github.io/tags","blobs_url":"https://api.github.com/repos/strimzi/strimzi.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strimzi/strimzi.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strimzi/strimzi.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/strimzi/strimzi.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strimzi/strimzi.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/strimzi/strimzi.github.io/languages","stargazers_url":"https://api.github.com/repos/strimzi/strimzi.github.io/stargazers","contributors_url":"https://api.github.com/repos/strimzi/strimzi.github.io/contributors","subscribers_url":"https://api.github.com/repos/strimzi/strimzi.github.io/subscribers","subscription_url":"https://api.github.com/repos/strimzi/strimzi.github.io/subscription","commits_url":"https://api.github.com/repos/strimzi/strimzi.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/strimzi/strimzi.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/strimzi/strimzi.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/strimzi/strimzi.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/strimzi/strimzi.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/strimzi/strimzi.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strimzi/strimzi.github.io/merges","archive_url":"https://api.github.com/repos/strimzi/strimzi.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strimzi/strimzi.github.io/downloads","issues_url":"https://api.github.com/repos/strimzi/strimzi.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/strimzi/strimzi.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/strimzi/strimzi.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/strimzi/strimzi.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strimzi/strimzi.github.io/labels{/name}","releases_url":"https://api.github.com/repos/strimzi/strimzi.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/strimzi/strimzi.github.io/deployments","created_at":"2017-12-22T13:53:41Z","updated_at":"2019-05-05T16:01:14Z","pushed_at":"2019-05-05T22:52:18Z","git_url":"git://github.com/strimzi/strimzi.github.io.git","ssh_url":"[email protected]:strimzi/strimzi.github.io.git","clone_url":"https://github.com/strimzi/strimzi.github.io.git","svn_url":"https://github.com/strimzi/strimzi.github.io","homepage":"http://strimzi.io","size":6674,"stargazers_count":4,"watchers_count":4,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":3,"watchers":4,"default_branch":"master"}},"base":{"label":"strimzi:master","ref":"master","sha":"94805a579066dac31d73bfc7a3d13318a7eb8637","user":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"repo":{"id":115119636,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUxMTk2MzY=","name":"strimzi.github.io","full_name":"strimzi/strimzi.github.io","private":false,"owner":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/strimzi/strimzi.github.io","description":"Strimzi web site project","fork":false,"url":"https://api.github.com/repos/strimzi/strimzi.github.io","forks_url":"https://api.github.com/repos/strimzi/strimzi.github.io/forks","keys_url":"https://api.github.com/repos/strimzi/strimzi.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strimzi/strimzi.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strimzi/strimzi.github.io/teams","hooks_url":"https://api.github.com/repos/strimzi/strimzi.github.io/hooks","issue_events_url":"https://api.github.com/repos/strimzi/strimzi.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/strimzi/strimzi.github.io/events","assignees_url":"https://api.github.com/repos/strimzi/strimzi.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/strimzi/strimzi.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/strimzi/strimzi.github.io/tags","blobs_url":"https://api.github.com/repos/strimzi/strimzi.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strimzi/strimzi.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strimzi/strimzi.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/strimzi/strimzi.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strimzi/strimzi.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/strimzi/strimzi.github.io/languages","stargazers_url":"https://api.github.com/repos/strimzi/strimzi.github.io/stargazers","contributors_url":"https://api.github.com/repos/strimzi/strimzi.github.io/contributors","subscribers_url":"https://api.github.com/repos/strimzi/strimzi.github.io/subscribers","subscription_url":"https://api.github.com/repos/strimzi/strimzi.github.io/subscription","commits_url":"https://api.github.com/repos/strimzi/strimzi.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/strimzi/strimzi.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/strimzi/strimzi.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/strimzi/strimzi.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/strimzi/strimzi.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/strimzi/strimzi.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strimzi/strimzi.github.io/merges","archive_url":"https://api.github.com/repos/strimzi/strimzi.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strimzi/strimzi.github.io/downloads","issues_url":"https://api.github.com/repos/strimzi/strimzi.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/strimzi/strimzi.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/strimzi/strimzi.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/strimzi/strimzi.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strimzi/strimzi.github.io/labels{/name}","releases_url":"https://api.github.com/repos/strimzi/strimzi.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/strimzi/strimzi.github.io/deployments","created_at":"2017-12-22T13:53:41Z","updated_at":"2019-05-05T16:01:14Z","pushed_at":"2019-05-05T22:52:18Z","git_url":"git://github.com/strimzi/strimzi.github.io.git","ssh_url":"[email protected]:strimzi/strimzi.github.io.git","clone_url":"https://github.com/strimzi/strimzi.github.io.git","svn_url":"https://github.com/strimzi/strimzi.github.io","homepage":"http://strimzi.io","size":6674,"stargazers_count":4,"watchers_count":4,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi.github.io/pulls/64"},"html":{"href":"https://github.com/strimzi/strimzi.github.io/pull/64"},"issue":{"href":"https://api.github.com/repos/strimzi/strimzi.github.io/issues/64"},"comments":{"href":"https://api.github.com/repos/strimzi/strimzi.github.io/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/strimzi/strimzi.github.io/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/strimzi/strimzi.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strimzi/strimzi.github.io/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/strimzi/strimzi.github.io/statuses/f4f1a1a7559684a7253c0665f8768d208e1c2286"}},"author_association":"MEMBER"}}	{ "id": 115119636, "name": "strimzi/strimzi.github.io", "url": "https://api.github.com/repos/strimzi/strimzi.github.io" }	{ "id": 879487, "login": "tombentley", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/879487?", "url": "https://api.github.com/users/tombentley" }	{ "id": 34767428, "login": "strimzi", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/34767428?", "url": "https://api.github.com/orgs/strimzi" }	2019-05-07T14:04:34	9578522453	{"actor":{"display_login":"tombentley"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/textileio/go-textile/pulls/comments/328806773","pull_request_review_id":293977870,"id":328806773,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyODgwNjc3Mw==","diff_hunk":"@@ -329,11 +330,16 @@ An access token is required to register, and should be obtained separately from\n \n \t// daemon\n \tdaemonCmd := appCmd.Command(\"daemon\", \"Start a node daemon session\")\n-\tdaemonRepo := daemonCmd.Flag(\"repo\", \"Specify a custom repository path\").Short('r').String()\n+\tdaemonBaseRepo := daemonCmd.Flag(\"base-repo\", \"Specify a custom path to the base repo directory\").Short('b').String()\n+\tdaemonAccountSeed := daemonCmd.Flag(\"account-seed\", \"Specify an existing acconut seed\").Short('a').String()","path":"cmd/cmd.go","position":14,"original_position":14,"commit_id":"fab07ef0e4e09b032b730550fa04758ff9426708","original_commit_id":"2522e1775fea72d92da043a92e3ad060ad92b8e7","user":{"login":"sanderpick","id":361000,"node_id":"MDQ6VXNlcjM2MTAwMA==","avatar_url":"https://avatars0.githubusercontent.com/u/361000?v=4","gravatar_id":"","url":"https://api.github.com/users/sanderpick","html_url":"https://github.com/sanderpick","followers_url":"https://api.github.com/users/sanderpick/followers","following_url":"https://api.github.com/users/sanderpick/following{/other_user}","gists_url":"https://api.github.com/users/sanderpick/gists{/gist_id}","starred_url":"https://api.github.com/users/sanderpick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanderpick/subscriptions","organizations_url":"https://api.github.com/users/sanderpick/orgs","repos_url":"https://api.github.com/users/sanderpick/repos","events_url":"https://api.github.com/users/sanderpick/events{/privacy}","received_events_url":"https://api.github.com/users/sanderpick/received_events","type":"User","site_admin":false},"body":"can this be address? it sounds insecure to have to paste the private key into the terminal on daemon start","created_at":"2019-09-26T20:16:05Z","updated_at":"2019-09-26T20:21:03Z","html_url":"https://github.com/textileio/go-textile/pull/904#discussion_r328806773","pull_request_url":"https://api.github.com/repos/textileio/go-textile/pulls/904","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/textileio/go-textile/pulls/comments/328806773"},"html":{"href":"https://github.com/textileio/go-textile/pull/904#discussion_r328806773"},"pull_request":{"href":"https://api.github.com/repos/textileio/go-textile/pulls/904"}}},"pull_request":{"url":"https://api.github.com/repos/textileio/go-textile/pulls/904","id":321835475,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIxODM1NDc1","html_url":"https://github.com/textileio/go-textile/pull/904","diff_url":"https://github.com/textileio/go-textile/pull/904.diff","patch_url":"https://github.com/textileio/go-textile/pull/904.patch","issue_url":"https://api.github.com/repos/textileio/go-textile/issues/904","number":904,"state":"open","locked":false,"title":"Use base repo and account seed in cli","user":{"login":"asutula","id":528969,"node_id":"MDQ6VXNlcjUyODk2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/528969?v=4","gravatar_id":"","url":"https://api.github.com/users/asutula","html_url":"https://github.com/asutula","followers_url":"https://api.github.com/users/asutula/followers","following_url":"https://api.github.com/users/asutula/following{/other_user}","gists_url":"https://api.github.com/users/asutula/gists{/gist_id}","starred_url":"https://api.github.com/users/asutula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asutula/subscriptions","organizations_url":"https://api.github.com/users/asutula/orgs","repos_url":"https://api.github.com/users/asutula/repos","events_url":"https://api.github.com/users/asutula/events{/privacy}","received_events_url":"https://api.github.com/users/asutula/received_events","type":"User","site_admin":false},"body":"Gets the CLI in line with how the programatic API deals with repo locations:\r\n\r\n- Removes `repo` flag from `init` and uses `base-repo` instead. It's optional and defaults to `~/.textile/repo`.\r\n- The `daemon` flag now uses `base-repo` instead of `repo` with the same default.\r\n- The `daemon` flag takes an optional `account-seed` flag to specify which account to use. If left out, it defaults to the first sub directory inside `base-repo`\r\n- Same thing for `migrate` flag","created_at":"2019-09-26T17:48:11Z","updated_at":"2019-09-26T20:21:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d21e0434a02d02fdd41bf1a66ab52c0f6f73d5e0","assignee":{"login":"asutula","id":528969,"node_id":"MDQ6VXNlcjUyODk2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/528969?v=4","gravatar_id":"","url":"https://api.github.com/users/asutula","html_url":"https://github.com/asutula","followers_url":"https://api.github.com/users/asutula/followers","following_url":"https://api.github.com/users/asutula/following{/other_user}","gists_url":"https://api.github.com/users/asutula/gists{/gist_id}","starred_url":"https://api.github.com/users/asutula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asutula/subscriptions","organizations_url":"https://api.github.com/users/asutula/orgs","repos_url":"https://api.github.com/users/asutula/repos","events_url":"https://api.github.com/users/asutula/events{/privacy}","received_events_url":"https://api.github.com/users/asutula/received_events","type":"User","site_admin":false},"assignees":[{"login":"asutula","id":528969,"node_id":"MDQ6VXNlcjUyODk2OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/528969?v=4","gravatar_id":"","url":"https://api.github.com/users/asutula","html_url":"https://github.com/asutula","followers_url":"https://api.github.com/users/asutula/followers","following_url":"https://api.github.com/users/asutula/following{/other_user}","gists_url":"https://api.github.com/users/asutula/gists{/gist_id}","starred_url":"https://api.github.com/users/asutula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asutula/subscriptions","organizations_url":"https://api.github.com/users/asutula/orgs","repos_url":"https://api.github.com/users/asutula/repos","events_url":"https://api.github.com/users/asutula/events{/privacy}","received_events_url":"https://api.github.com/users/asutula/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"andrewxhill","id":370259,"node_id":"MDQ6VXNlcjM3MDI1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/370259?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewxhill","html_url":"https://github.com/andrewxhill","followers_url":"https://api.github.com/users/andrewxhill/followers","following_url":"https://api.github.com/users/andrewxhill/following{/other_user}","gists_url":"https://api.github.com/users/andrewxhill/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewxhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewxhill/subscriptions","organizations_url":"https://api.github.com/users/andrewxhill/orgs","repos_url":"https://api.github.com/users/andrewxhill/repos","events_url":"https://api.github.com/users/andrewxhill/events{/privacy}","received_events_url":"https://api.github.com/users/andrewxhill/received_events","type":"User","site_admin":false},{"login":"carsonfarmer","id":1220613,"node_id":"MDQ6VXNlcjEyMjA2MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1220613?v=4","gravatar_id":"","url":"https://api.github.com/users/carsonfarmer","html_url":"https://github.com/carsonfarmer","followers_url":"https://api.github.com/users/carsonfarmer/followers","following_url":"https://api.github.com/users/carsonfarmer/following{/other_user}","gists_url":"https://api.github.com/users/carsonfarmer/gists{/gist_id}","starred_url":"https://api.github.com/users/carsonfarmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carsonfarmer/subscriptions","organizations_url":"https://api.github.com/users/carsonfarmer/orgs","repos_url":"https://api.github.com/users/carsonfarmer/repos","events_url":"https://api.github.com/users/carsonfarmer/events{/privacy}","received_events_url":"https://api.github.com/users/carsonfarmer/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/textileio/go-textile/pulls/904/commits","review_comments_url":"https://api.github.com/repos/textileio/go-textile/pulls/904/comments","review_comment_url":"https://api.github.com/repos/textileio/go-textile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/textileio/go-textile/issues/904/comments","statuses_url":"https://api.github.com/repos/textileio/go-textile/statuses/fab07ef0e4e09b032b730550fa04758ff9426708","head":{"label":"textileio:asutula/cmd-updates","ref":"asutula/cmd-updates","sha":"fab07ef0e4e09b032b730550fa04758ff9426708","user":{"login":"textileio","id":35050041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDUwMDQx","avatar_url":"https://avatars3.githubusercontent.com/u/35050041?v=4","gravatar_id":"","url":"https://api.github.com/users/textileio","html_url":"https://github.com/textileio","followers_url":"https://api.github.com/users/textileio/followers","following_url":"https://api.github.com/users/textileio/following{/other_user}","gists_url":"https://api.github.com/users/textileio/gists{/gist_id}","starred_url":"https://api.github.com/users/textileio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textileio/subscriptions","organizations_url":"https://api.github.com/users/textileio/orgs","repos_url":"https://api.github.com/users/textileio/repos","events_url":"https://api.github.com/users/textileio/events{/privacy}","received_events_url":"https://api.github.com/users/textileio/received_events","type":"Organization","site_admin":false},"repo":{"id":124269776,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQyNjk3NzY=","name":"go-textile","full_name":"textileio/go-textile","private":false,"owner":{"login":"textileio","id":35050041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDUwMDQx","avatar_url":"https://avatars3.githubusercontent.com/u/35050041?v=4","gravatar_id":"","url":"https://api.github.com/users/textileio","html_url":"https://github.com/textileio","followers_url":"https://api.github.com/users/textileio/followers","following_url":"https://api.github.com/users/textileio/following{/other_user}","gists_url":"https://api.github.com/users/textileio/gists{/gist_id}","starred_url":"https://api.github.com/users/textileio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textileio/subscriptions","organizations_url":"https://api.github.com/users/textileio/orgs","repos_url":"https://api.github.com/users/textileio/repos","events_url":"https://api.github.com/users/textileio/events{/privacy}","received_events_url":"https://api.github.com/users/textileio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/textileio/go-textile","description":"Textile is a set of tools and infrastructure for building composable apps and services on the IPFS network","fork":false,"url":"https://api.github.com/repos/textileio/go-textile","forks_url":"https://api.github.com/repos/textileio/go-textile/forks","keys_url":"https://api.github.com/repos/textileio/go-textile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/textileio/go-textile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/textileio/go-textile/teams","hooks_url":"https://api.github.com/repos/textileio/go-textile/hooks","issue_events_url":"https://api.github.com/repos/textileio/go-textile/issues/events{/number}","events_url":"https://api.github.com/repos/textileio/go-textile/events","assignees_url":"https://api.github.com/repos/textileio/go-textile/assignees{/user}","branches_url":"https://api.github.com/repos/textileio/go-textile/branches{/branch}","tags_url":"https://api.github.com/repos/textileio/go-textile/tags","blobs_url":"https://api.github.com/repos/textileio/go-textile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/textileio/go-textile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/textileio/go-textile/git/refs{/sha}","trees_url":"https://api.github.com/repos/textileio/go-textile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/textileio/go-textile/statuses/{sha}","languages_url":"https://api.github.com/repos/textileio/go-textile/languages","stargazers_url":"https://api.github.com/repos/textileio/go-textile/stargazers","contributors_url":"https://api.github.com/repos/textileio/go-textile/contributors","subscribers_url":"https://api.github.com/repos/textileio/go-textile/subscribers","subscription_url":"https://api.github.com/repos/textileio/go-textile/subscription","commits_url":"https://api.github.com/repos/textileio/go-textile/commits{/sha}","git_commits_url":"https://api.github.com/repos/textileio/go-textile/git/commits{/sha}","comments_url":"https://api.github.com/repos/textileio/go-textile/comments{/number}","issue_comment_url":"https://api.github.com/repos/textileio/go-textile/issues/comments{/number}","contents_url":"https://api.github.com/repos/textileio/go-textile/contents/{+path}","compare_url":"https://api.github.com/repos/textileio/go-textile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/textileio/go-textile/merges","archive_url":"https://api.github.com/repos/textileio/go-textile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/textileio/go-textile/downloads","issues_url":"https://api.github.com/repos/textileio/go-textile/issues{/number}","pulls_url":"https://api.github.com/repos/textileio/go-textile/pulls{/number}","milestones_url":"https://api.github.com/repos/textileio/go-textile/milestones{/number}","notifications_url":"https://api.github.com/repos/textileio/go-textile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/textileio/go-textile/labels{/name}","releases_url":"https://api.github.com/repos/textileio/go-textile/releases{/id}","deployments_url":"https://api.github.com/repos/textileio/go-textile/deployments","created_at":"2018-03-07T17:19:30Z","updated_at":"2019-09-24T16:08:04Z","pushed_at":"2019-09-26T20:20:21Z","git_url":"git://github.com/textileio/go-textile.git","ssh_url":"[email protected]:textileio/go-textile.git","clone_url":"https://github.com/textileio/go-textile.git","svn_url":"https://github.com/textileio/go-textile","homepage":"https://textile.io","size":88364,"stargazers_count":298,"watchers_count":298,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":116,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":34,"open_issues":116,"watchers":298,"default_branch":"master"}},"base":{"label":"textileio:asutula/scope-repo-with-account-address","ref":"asutula/scope-repo-with-account-address","sha":"ee853d6b3354894872a5d5a85bc209797b1f05b3","user":{"login":"textileio","id":35050041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDUwMDQx","avatar_url":"https://avatars3.githubusercontent.com/u/35050041?v=4","gravatar_id":"","url":"https://api.github.com/users/textileio","html_url":"https://github.com/textileio","followers_url":"https://api.github.com/users/textileio/followers","following_url":"https://api.github.com/users/textileio/following{/other_user}","gists_url":"https://api.github.com/users/textileio/gists{/gist_id}","starred_url":"https://api.github.com/users/textileio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textileio/subscriptions","organizations_url":"https://api.github.com/users/textileio/orgs","repos_url":"https://api.github.com/users/textileio/repos","events_url":"https://api.github.com/users/textileio/events{/privacy}","received_events_url":"https://api.github.com/users/textileio/received_events","type":"Organization","site_admin":false},"repo":{"id":124269776,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQyNjk3NzY=","name":"go-textile","full_name":"textileio/go-textile","private":false,"owner":{"login":"textileio","id":35050041,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDUwMDQx","avatar_url":"https://avatars3.githubusercontent.com/u/35050041?v=4","gravatar_id":"","url":"https://api.github.com/users/textileio","html_url":"https://github.com/textileio","followers_url":"https://api.github.com/users/textileio/followers","following_url":"https://api.github.com/users/textileio/following{/other_user}","gists_url":"https://api.github.com/users/textileio/gists{/gist_id}","starred_url":"https://api.github.com/users/textileio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/textileio/subscriptions","organizations_url":"https://api.github.com/users/textileio/orgs","repos_url":"https://api.github.com/users/textileio/repos","events_url":"https://api.github.com/users/textileio/events{/privacy}","received_events_url":"https://api.github.com/users/textileio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/textileio/go-textile","description":"Textile is a set of tools and infrastructure for building composable apps and services on the IPFS network","fork":false,"url":"https://api.github.com/repos/textileio/go-textile","forks_url":"https://api.github.com/repos/textileio/go-textile/forks","keys_url":"https://api.github.com/repos/textileio/go-textile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/textileio/go-textile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/textileio/go-textile/teams","hooks_url":"https://api.github.com/repos/textileio/go-textile/hooks","issue_events_url":"https://api.github.com/repos/textileio/go-textile/issues/events{/number}","events_url":"https://api.github.com/repos/textileio/go-textile/events","assignees_url":"https://api.github.com/repos/textileio/go-textile/assignees{/user}","branches_url":"https://api.github.com/repos/textileio/go-textile/branches{/branch}","tags_url":"https://api.github.com/repos/textileio/go-textile/tags","blobs_url":"https://api.github.com/repos/textileio/go-textile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/textileio/go-textile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/textileio/go-textile/git/refs{/sha}","trees_url":"https://api.github.com/repos/textileio/go-textile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/textileio/go-textile/statuses/{sha}","languages_url":"https://api.github.com/repos/textileio/go-textile/languages","stargazers_url":"https://api.github.com/repos/textileio/go-textile/stargazers","contributors_url":"https://api.github.com/repos/textileio/go-textile/contributors","subscribers_url":"https://api.github.com/repos/textileio/go-textile/subscribers","subscription_url":"https://api.github.com/repos/textileio/go-textile/subscription","commits_url":"https://api.github.com/repos/textileio/go-textile/commits{/sha}","git_commits_url":"https://api.github.com/repos/textileio/go-textile/git/commits{/sha}","comments_url":"https://api.github.com/repos/textileio/go-textile/comments{/number}","issue_comment_url":"https://api.github.com/repos/textileio/go-textile/issues/comments{/number}","contents_url":"https://api.github.com/repos/textileio/go-textile/contents/{+path}","compare_url":"https://api.github.com/repos/textileio/go-textile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/textileio/go-textile/merges","archive_url":"https://api.github.com/repos/textileio/go-textile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/textileio/go-textile/downloads","issues_url":"https://api.github.com/repos/textileio/go-textile/issues{/number}","pulls_url":"https://api.github.com/repos/textileio/go-textile/pulls{/number}","milestones_url":"https://api.github.com/repos/textileio/go-textile/milestones{/number}","notifications_url":"https://api.github.com/repos/textileio/go-textile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/textileio/go-textile/labels{/name}","releases_url":"https://api.github.com/repos/textileio/go-textile/releases{/id}","deployments_url":"https://api.github.com/repos/textileio/go-textile/deployments","created_at":"2018-03-07T17:19:30Z","updated_at":"2019-09-24T16:08:04Z","pushed_at":"2019-09-26T20:20:21Z","git_url":"git://github.com/textileio/go-textile.git","ssh_url":"[email protected]:textileio/go-textile.git","clone_url":"https://github.com/textileio/go-textile.git","svn_url":"https://github.com/textileio/go-textile","homepage":"https://textile.io","size":88364,"stargazers_count":298,"watchers_count":298,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":116,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":34,"open_issues":116,"watchers":298,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/textileio/go-textile/pulls/904"},"html":{"href":"https://github.com/textileio/go-textile/pull/904"},"issue":{"href":"https://api.github.com/repos/textileio/go-textile/issues/904"},"comments":{"href":"https://api.github.com/repos/textileio/go-textile/issues/904/comments"},"review_comments":{"href":"https://api.github.com/repos/textileio/go-textile/pulls/904/comments"},"review_comment":{"href":"https://api.github.com/repos/textileio/go-textile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/textileio/go-textile/pulls/904/commits"},"statuses":{"href":"https://api.github.com/repos/textileio/go-textile/statuses/fab07ef0e4e09b032b730550fa04758ff9426708"}},"author_association":"MEMBER"}}	{ "id": 124269776, "name": "textileio/go-textile", "url": "https://api.github.com/repos/textileio/go-textile" }	{ "id": 361000, "login": "sanderpick", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/361000?", "url": "https://api.github.com/users/sanderpick" }	{ "id": 35050041, "login": "textileio", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/35050041?", "url": "https://api.github.com/orgs/textileio" }	2019-09-26T20:16:05	10505069137	{"actor":{"display_login":"sanderpick"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/endpass/endpass-core/pulls/comments/335292348","pull_request_review_id":302339719,"id":335292348,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNTI5MjM0OA==","diff_hunk":"@@ -0,0 +1,113 @@\n+<script>\n+import ThemeMixin from '@/mixins/ThemeMixin';\n+\n+export default {\n+ name: 'VTabs',\n+\n+ provide() {\n+ return {\n+ addTab: this.addTab,\n+ selectTab: this.selectTab,","path":"packages/ui/src/kit/VTabs/VTabs.vue","position":10,"original_position":10,"commit_id":"278ea0e12dfc851433482a9f6550654cab0cb36e","original_commit_id":"278ea0e12dfc851433482a9f6550654cab0cb36e","user":{"login":"kazurus","id":32077191,"node_id":"MDQ6VXNlcjMyMDc3MTkx","avatar_url":"https://avatars1.githubusercontent.com/u/32077191?v=4","gravatar_id":"","url":"https://api.github.com/users/kazurus","html_url":"https://github.com/kazurus","followers_url":"https://api.github.com/users/kazurus/followers","following_url":"https://api.github.com/users/kazurus/following{/other_user}","gists_url":"https://api.github.com/users/kazurus/gists{/gist_id}","starred_url":"https://api.github.com/users/kazurus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazurus/subscriptions","organizations_url":"https://api.github.com/users/kazurus/orgs","repos_url":"https://api.github.com/users/kazurus/repos","events_url":"https://api.github.com/users/kazurus/events{/privacy}","received_events_url":"https://api.github.com/users/kazurus/received_events","type":"User","site_admin":false},"body":"вроде не используется","created_at":"2019-10-16T06:12:32Z","updated_at":"2019-10-16T06:16:13Z","html_url":"https://github.com/endpass/endpass-core/pull/266#discussion_r335292348","pull_request_url":"https://api.github.com/repos/endpass/endpass-core/pulls/266","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/endpass/endpass-core/pulls/comments/335292348"},"html":{"href":"https://github.com/endpass/endpass-core/pull/266#discussion_r335292348"},"pull_request":{"href":"https://api.github.com/repos/endpass/endpass-core/pulls/266"}}},"pull_request":{"url":"https://api.github.com/repos/endpass/endpass-core/pulls/266","id":328164191,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4MTY0MTkx","html_url":"https://github.com/endpass/endpass-core/pull/266","diff_url":"https://github.com/endpass/endpass-core/pull/266.diff","patch_url":"https://github.com/endpass/endpass-core/pull/266.patch","issue_url":"https://api.github.com/repos/endpass/endpass-core/issues/266","number":266,"state":"open","locked":false,"title":"feat(ui): add VTabs component to kit","user":{"login":"lamartire","id":13414205,"node_id":"MDQ6VXNlcjEzNDE0MjA1","avatar_url":"https://avatars0.githubusercontent.com/u/13414205?v=4","gravatar_id":"","url":"https://api.github.com/users/lamartire","html_url":"https://github.com/lamartire","followers_url":"https://api.github.com/users/lamartire/followers","following_url":"https://api.github.com/users/lamartire/following{/other_user}","gists_url":"https://api.github.com/users/lamartire/gists{/gist_id}","starred_url":"https://api.github.com/users/lamartire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamartire/subscriptions","organizations_url":"https://api.github.com/users/lamartire/orgs","repos_url":"https://api.github.com/users/lamartire/repos","events_url":"https://api.github.com/users/lamartire/events{/privacy}","received_events_url":"https://api.github.com/users/lamartire/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-15T09:18:22Z","updated_at":"2019-10-16T06:16:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e03677cf363b3d0b6966d09e74ef6c6f972f6cb3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/endpass/endpass-core/pulls/266/commits","review_comments_url":"https://api.github.com/repos/endpass/endpass-core/pulls/266/comments","review_comment_url":"https://api.github.com/repos/endpass/endpass-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endpass/endpass-core/issues/266/comments","statuses_url":"https://api.github.com/repos/endpass/endpass-core/statuses/278ea0e12dfc851433482a9f6550654cab0cb36e","head":{"label":"lamartire:feat-tabs-component","ref":"feat-tabs-component","sha":"278ea0e12dfc851433482a9f6550654cab0cb36e","user":{"login":"lamartire","id":13414205,"node_id":"MDQ6VXNlcjEzNDE0MjA1","avatar_url":"https://avatars0.githubusercontent.com/u/13414205?v=4","gravatar_id":"","url":"https://api.github.com/users/lamartire","html_url":"https://github.com/lamartire","followers_url":"https://api.github.com/users/lamartire/followers","following_url":"https://api.github.com/users/lamartire/following{/other_user}","gists_url":"https://api.github.com/users/lamartire/gists{/gist_id}","starred_url":"https://api.github.com/users/lamartire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamartire/subscriptions","organizations_url":"https://api.github.com/users/lamartire/orgs","repos_url":"https://api.github.com/users/lamartire/repos","events_url":"https://api.github.com/users/lamartire/events{/privacy}","received_events_url":"https://api.github.com/users/lamartire/received_events","type":"User","site_admin":false},"repo":{"id":168489742,"node_id":"MDEwOlJlcG9zaXRvcnkxNjg0ODk3NDI=","name":"endpass-core","full_name":"lamartire/endpass-core","private":false,"owner":{"login":"lamartire","id":13414205,"node_id":"MDQ6VXNlcjEzNDE0MjA1","avatar_url":"https://avatars0.githubusercontent.com/u/13414205?v=4","gravatar_id":"","url":"https://api.github.com/users/lamartire","html_url":"https://github.com/lamartire","followers_url":"https://api.github.com/users/lamartire/followers","following_url":"https://api.github.com/users/lamartire/following{/other_user}","gists_url":"https://api.github.com/users/lamartire/gists{/gist_id}","starred_url":"https://api.github.com/users/lamartire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamartire/subscriptions","organizations_url":"https://api.github.com/users/lamartire/orgs","repos_url":"https://api.github.com/users/lamartire/repos","events_url":"https://api.github.com/users/lamartire/events{/privacy}","received_events_url":"https://api.github.com/users/lamartire/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lamartire/endpass-core","description":"Common packages for Endpass","fork":true,"url":"https://api.github.com/repos/lamartire/endpass-core","forks_url":"https://api.github.com/repos/lamartire/endpass-core/forks","keys_url":"https://api.github.com/repos/lamartire/endpass-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lamartire/endpass-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lamartire/endpass-core/teams","hooks_url":"https://api.github.com/repos/lamartire/endpass-core/hooks","issue_events_url":"https://api.github.com/repos/lamartire/endpass-core/issues/events{/number}","events_url":"https://api.github.com/repos/lamartire/endpass-core/events","assignees_url":"https://api.github.com/repos/lamartire/endpass-core/assignees{/user}","branches_url":"https://api.github.com/repos/lamartire/endpass-core/branches{/branch}","tags_url":"https://api.github.com/repos/lamartire/endpass-core/tags","blobs_url":"https://api.github.com/repos/lamartire/endpass-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lamartire/endpass-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lamartire/endpass-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/lamartire/endpass-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lamartire/endpass-core/statuses/{sha}","languages_url":"https://api.github.com/repos/lamartire/endpass-core/languages","stargazers_url":"https://api.github.com/repos/lamartire/endpass-core/stargazers","contributors_url":"https://api.github.com/repos/lamartire/endpass-core/contributors","subscribers_url":"https://api.github.com/repos/lamartire/endpass-core/subscribers","subscription_url":"https://api.github.com/repos/lamartire/endpass-core/subscription","commits_url":"https://api.github.com/repos/lamartire/endpass-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/lamartire/endpass-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/lamartire/endpass-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/lamartire/endpass-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/lamartire/endpass-core/contents/{+path}","compare_url":"https://api.github.com/repos/lamartire/endpass-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lamartire/endpass-core/merges","archive_url":"https://api.github.com/repos/lamartire/endpass-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lamartire/endpass-core/downloads","issues_url":"https://api.github.com/repos/lamartire/endpass-core/issues{/number}","pulls_url":"https://api.github.com/repos/lamartire/endpass-core/pulls{/number}","milestones_url":"https://api.github.com/repos/lamartire/endpass-core/milestones{/number}","notifications_url":"https://api.github.com/repos/lamartire/endpass-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lamartire/endpass-core/labels{/name}","releases_url":"https://api.github.com/repos/lamartire/endpass-core/releases{/id}","deployments_url":"https://api.github.com/repos/lamartire/endpass-core/deployments","created_at":"2019-01-31T08:26:41Z","updated_at":"2019-10-15T08:08:43Z","pushed_at":"2019-10-15T15:36:41Z","git_url":"git://github.com/lamartire/endpass-core.git","ssh_url":"[email protected]:lamartire/endpass-core.git","clone_url":"https://github.com/lamartire/endpass-core.git","svn_url":"https://github.com/lamartire/endpass-core","homepage":null,"size":21289,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"endpass:master","ref":"master","sha":"48f7be36ab1653c7639636954173476ef1eecba7","user":{"login":"endpass","id":35308615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzA4NjE1","avatar_url":"https://avatars3.githubusercontent.com/u/35308615?v=4","gravatar_id":"","url":"https://api.github.com/users/endpass","html_url":"https://github.com/endpass","followers_url":"https://api.github.com/users/endpass/followers","following_url":"https://api.github.com/users/endpass/following{/other_user}","gists_url":"https://api.github.com/users/endpass/gists{/gist_id}","starred_url":"https://api.github.com/users/endpass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endpass/subscriptions","organizations_url":"https://api.github.com/users/endpass/orgs","repos_url":"https://api.github.com/users/endpass/repos","events_url":"https://api.github.com/users/endpass/events{/privacy}","received_events_url":"https://api.github.com/users/endpass/received_events","type":"Organization","site_admin":false},"repo":{"id":159542463,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk1NDI0NjM=","name":"endpass-core","full_name":"endpass/endpass-core","private":false,"owner":{"login":"endpass","id":35308615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzA4NjE1","avatar_url":"https://avatars3.githubusercontent.com/u/35308615?v=4","gravatar_id":"","url":"https://api.github.com/users/endpass","html_url":"https://github.com/endpass","followers_url":"https://api.github.com/users/endpass/followers","following_url":"https://api.github.com/users/endpass/following{/other_user}","gists_url":"https://api.github.com/users/endpass/gists{/gist_id}","starred_url":"https://api.github.com/users/endpass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endpass/subscriptions","organizations_url":"https://api.github.com/users/endpass/orgs","repos_url":"https://api.github.com/users/endpass/repos","events_url":"https://api.github.com/users/endpass/events{/privacy}","received_events_url":"https://api.github.com/users/endpass/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/endpass/endpass-core","description":"Common packages for Endpass","fork":false,"url":"https://api.github.com/repos/endpass/endpass-core","forks_url":"https://api.github.com/repos/endpass/endpass-core/forks","keys_url":"https://api.github.com/repos/endpass/endpass-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endpass/endpass-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endpass/endpass-core/teams","hooks_url":"https://api.github.com/repos/endpass/endpass-core/hooks","issue_events_url":"https://api.github.com/repos/endpass/endpass-core/issues/events{/number}","events_url":"https://api.github.com/repos/endpass/endpass-core/events","assignees_url":"https://api.github.com/repos/endpass/endpass-core/assignees{/user}","branches_url":"https://api.github.com/repos/endpass/endpass-core/branches{/branch}","tags_url":"https://api.github.com/repos/endpass/endpass-core/tags","blobs_url":"https://api.github.com/repos/endpass/endpass-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endpass/endpass-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endpass/endpass-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/endpass/endpass-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endpass/endpass-core/statuses/{sha}","languages_url":"https://api.github.com/repos/endpass/endpass-core/languages","stargazers_url":"https://api.github.com/repos/endpass/endpass-core/stargazers","contributors_url":"https://api.github.com/repos/endpass/endpass-core/contributors","subscribers_url":"https://api.github.com/repos/endpass/endpass-core/subscribers","subscription_url":"https://api.github.com/repos/endpass/endpass-core/subscription","commits_url":"https://api.github.com/repos/endpass/endpass-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/endpass/endpass-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/endpass/endpass-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/endpass/endpass-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/endpass/endpass-core/contents/{+path}","compare_url":"https://api.github.com/repos/endpass/endpass-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endpass/endpass-core/merges","archive_url":"https://api.github.com/repos/endpass/endpass-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endpass/endpass-core/downloads","issues_url":"https://api.github.com/repos/endpass/endpass-core/issues{/number}","pulls_url":"https://api.github.com/repos/endpass/endpass-core/pulls{/number}","milestones_url":"https://api.github.com/repos/endpass/endpass-core/milestones{/number}","notifications_url":"https://api.github.com/repos/endpass/endpass-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endpass/endpass-core/labels{/name}","releases_url":"https://api.github.com/repos/endpass/endpass-core/releases{/id}","deployments_url":"https://api.github.com/repos/endpass/endpass-core/deployments","created_at":"2018-11-28T17:51:49Z","updated_at":"2019-10-11T13:55:08Z","pushed_at":"2019-10-15T15:36:42Z","git_url":"git://github.com/endpass/endpass-core.git","ssh_url":"[email protected]:endpass/endpass-core.git","clone_url":"https://github.com/endpass/endpass-core.git","svn_url":"https://github.com/endpass/endpass-core","homepage":null,"size":25136,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":5,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endpass/endpass-core/pulls/266"},"html":{"href":"https://github.com/endpass/endpass-core/pull/266"},"issue":{"href":"https://api.github.com/repos/endpass/endpass-core/issues/266"},"comments":{"href":"https://api.github.com/repos/endpass/endpass-core/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/endpass/endpass-core/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/endpass/endpass-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endpass/endpass-core/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/endpass/endpass-core/statuses/278ea0e12dfc851433482a9f6550654cab0cb36e"}},"author_association":"CONTRIBUTOR"}}	{ "id": 159542463, "name": "endpass/endpass-core", "url": "https://api.github.com/repos/endpass/endpass-core" }	{ "id": 32077191, "login": "kazurus", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/32077191?", "url": "https://api.github.com/users/kazurus" }	{ "id": 35308615, "login": "endpass", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/35308615?", "url": "https://api.github.com/orgs/endpass" }	2019-10-16T06:12:32	10640078686	{"actor":{"display_login":"kazurus"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/loki-project/loki/pulls/comments/351083253","pull_request_review_id":323413185,"id":351083253,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MTA4MzI1Mw==","diff_hunk":"@@ -936,8 +927,9 @@ namespace service_nodes\n uint64_t const block_height = cryptonote::get_block_height(block);\n \n crypto::public_key key;\n- auto info_ptr = std::make_shared<service_node_info>();\n+ auto info_ptr = std::make_shared<service_node_info>();\n service_node_info &info = *info_ptr;\n+ info = {};","path":"src/cryptonote_core/service_node_list.cpp","position":null,"original_position":55,"commit_id":"9b28451f7d726257deb65c035aef60bc603b0d88","original_commit_id":"5613e9a06a04c4e337e78307b9e997e18c757a23","user":{"login":"Doy-lee","id":12163539,"node_id":"MDQ6VXNlcjEyMTYzNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/12163539?v=4","gravatar_id":"","url":"https://api.github.com/users/Doy-lee","html_url":"https://github.com/Doy-lee","followers_url":"https://api.github.com/users/Doy-lee/followers","following_url":"https://api.github.com/users/Doy-lee/following{/other_user}","gists_url":"https://api.github.com/users/Doy-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/Doy-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Doy-lee/subscriptions","organizations_url":"https://api.github.com/users/Doy-lee/orgs","repos_url":"https://api.github.com/users/Doy-lee/repos","events_url":"https://api.github.com/users/Doy-lee/events{/privacy}","received_events_url":"https://api.github.com/users/Doy-lee/received_events","type":"User","site_admin":false},"body":"And updated","created_at":"2019-11-27T03:38:42Z","updated_at":"2019-11-27T03:38:43Z","html_url":"https://github.com/loki-project/loki/pull/934#discussion_r351083253","pull_request_url":"https://api.github.com/repos/loki-project/loki/pulls/934","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/loki-project/loki/pulls/comments/351083253"},"html":{"href":"https://github.com/loki-project/loki/pull/934#discussion_r351083253"},"pull_request":{"href":"https://api.github.com/repos/loki-project/loki/pulls/934"}},"in_reply_to_id":351072282},"pull_request":{"url":"https://api.github.com/repos/loki-project/loki/pulls/934","id":345452933,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ1NDUyOTMz","html_url":"https://github.com/loki-project/loki/pull/934","diff_url":"https://github.com/loki-project/loki/pull/934.diff","patch_url":"https://github.com/loki-project/loki/pull/934.patch","issue_url":"https://api.github.com/repos/loki-project/loki/issues/934","number":934,"state":"open","locked":false,"title":"Aggegrate init service node info instead of setting members individually","user":{"login":"Doy-lee","id":12163539,"node_id":"MDQ6VXNlcjEyMTYzNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/12163539?v=4","gravatar_id":"","url":"https://api.github.com/users/Doy-lee","html_url":"https://github.com/Doy-lee","followers_url":"https://api.github.com/users/Doy-lee/followers","following_url":"https://api.github.com/users/Doy-lee/following{/other_user}","gists_url":"https://api.github.com/users/Doy-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/Doy-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Doy-lee/subscriptions","organizations_url":"https://api.github.com/users/Doy-lee/orgs","repos_url":"https://api.github.com/users/Doy-lee/repos","events_url":"https://api.github.com/users/Doy-lee/events{/privacy}","received_events_url":"https://api.github.com/users/Doy-lee/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-11-25T22:40:13Z","updated_at":"2019-11-27T03:38:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa6bab5efda520066b9082c1b050a4038dc18d9d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/loki-project/loki/pulls/934/commits","review_comments_url":"https://api.github.com/repos/loki-project/loki/pulls/934/comments","review_comment_url":"https://api.github.com/repos/loki-project/loki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/loki-project/loki/issues/934/comments","statuses_url":"https://api.github.com/repos/loki-project/loki/statuses/9b28451f7d726257deb65c035aef60bc603b0d88","head":{"label":"Doy-lee:AggregateInitializeInfo","ref":"AggregateInitializeInfo","sha":"9b28451f7d726257deb65c035aef60bc603b0d88","user":{"login":"Doy-lee","id":12163539,"node_id":"MDQ6VXNlcjEyMTYzNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/12163539?v=4","gravatar_id":"","url":"https://api.github.com/users/Doy-lee","html_url":"https://github.com/Doy-lee","followers_url":"https://api.github.com/users/Doy-lee/followers","following_url":"https://api.github.com/users/Doy-lee/following{/other_user}","gists_url":"https://api.github.com/users/Doy-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/Doy-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Doy-lee/subscriptions","organizations_url":"https://api.github.com/users/Doy-lee/orgs","repos_url":"https://api.github.com/users/Doy-lee/repos","events_url":"https://api.github.com/users/Doy-lee/events{/privacy}","received_events_url":"https://api.github.com/users/Doy-lee/received_events","type":"User","site_admin":false},"repo":{"id":128874675,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4NzQ2NzU=","name":"loki","full_name":"Doy-lee/loki","private":false,"owner":{"login":"Doy-lee","id":12163539,"node_id":"MDQ6VXNlcjEyMTYzNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/12163539?v=4","gravatar_id":"","url":"https://api.github.com/users/Doy-lee","html_url":"https://github.com/Doy-lee","followers_url":"https://api.github.com/users/Doy-lee/followers","following_url":"https://api.github.com/users/Doy-lee/following{/other_user}","gists_url":"https://api.github.com/users/Doy-lee/gists{/gist_id}","starred_url":"https://api.github.com/users/Doy-lee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Doy-lee/subscriptions","organizations_url":"https://api.github.com/users/Doy-lee/orgs","repos_url":"https://api.github.com/users/Doy-lee/repos","events_url":"https://api.github.com/users/Doy-lee/events{/privacy}","received_events_url":"https://api.github.com/users/Doy-lee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Doy-lee/loki","description":"Loki: Trade and communicate with freedom","fork":true,"url":"https://api.github.com/repos/Doy-lee/loki","forks_url":"https://api.github.com/repos/Doy-lee/loki/forks","keys_url":"https://api.github.com/repos/Doy-lee/loki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Doy-lee/loki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Doy-lee/loki/teams","hooks_url":"https://api.github.com/repos/Doy-lee/loki/hooks","issue_events_url":"https://api.github.com/repos/Doy-lee/loki/issues/events{/number}","events_url":"https://api.github.com/repos/Doy-lee/loki/events","assignees_url":"https://api.github.com/repos/Doy-lee/loki/assignees{/user}","branches_url":"https://api.github.com/repos/Doy-lee/loki/branches{/branch}","tags_url":"https://api.github.com/repos/Doy-lee/loki/tags","blobs_url":"https://api.github.com/repos/Doy-lee/loki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Doy-lee/loki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Doy-lee/loki/git/refs{/sha}","trees_url":"https://api.github.com/repos/Doy-lee/loki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Doy-lee/loki/statuses/{sha}","languages_url":"https://api.github.com/repos/Doy-lee/loki/languages","stargazers_url":"https://api.github.com/repos/Doy-lee/loki/stargazers","contributors_url":"https://api.github.com/repos/Doy-lee/loki/contributors","subscribers_url":"https://api.github.com/repos/Doy-lee/loki/subscribers","subscription_url":"https://api.github.com/repos/Doy-lee/loki/subscription","commits_url":"https://api.github.com/repos/Doy-lee/loki/commits{/sha}","git_commits_url":"https://api.github.com/repos/Doy-lee/loki/git/commits{/sha}","comments_url":"https://api.github.com/repos/Doy-lee/loki/comments{/number}","issue_comment_url":"https://api.github.com/repos/Doy-lee/loki/issues/comments{/number}","contents_url":"https://api.github.com/repos/Doy-lee/loki/contents/{+path}","compare_url":"https://api.github.com/repos/Doy-lee/loki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Doy-lee/loki/merges","archive_url":"https://api.github.com/repos/Doy-lee/loki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Doy-lee/loki/downloads","issues_url":"https://api.github.com/repos/Doy-lee/loki/issues{/number}","pulls_url":"https://api.github.com/repos/Doy-lee/loki/pulls{/number}","milestones_url":"https://api.github.com/repos/Doy-lee/loki/milestones{/number}","notifications_url":"https://api.github.com/repos/Doy-lee/loki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Doy-lee/loki/labels{/name}","releases_url":"https://api.github.com/repos/Doy-lee/loki/releases{/id}","deployments_url":"https://api.github.com/repos/Doy-lee/loki/deployments","created_at":"2018-04-10T04:41:40Z","updated_at":"2019-11-04T05:46:52Z","pushed_at":"2019-11-27T03:38:05Z","git_url":"git://github.com/Doy-lee/loki.git","ssh_url":"[email protected]:Doy-lee/loki.git","clone_url":"https://github.com/Doy-lee/loki.git","svn_url":"https://github.com/Doy-lee/loki","homepage":"https://loki.network","size":177129,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"loki-project:dev","ref":"dev","sha":"40946bd92f71a47b855f0947998a91a32a6fd172","user":{"login":"loki-project","id":35471049,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NDcxMDQ5","avatar_url":"https://avatars0.githubusercontent.com/u/35471049?v=4","gravatar_id":"","url":"https://api.github.com/users/loki-project","html_url":"https://github.com/loki-project","followers_url":"https://api.github.com/users/loki-project/followers","following_url":"https://api.github.com/users/loki-project/following{/other_user}","gists_url":"https://api.github.com/users/loki-project/gists{/gist_id}","starred_url":"https://api.github.com/users/loki-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loki-project/subscriptions","organizations_url":"https://api.github.com/users/loki-project/orgs","repos_url":"https://api.github.com/users/loki-project/repos","events_url":"https://api.github.com/users/loki-project/events{/privacy}","received_events_url":"https://api.github.com/users/loki-project/received_events","type":"Organization","site_admin":false},"repo":{"id":117603764,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc2MDM3NjQ=","name":"loki","full_name":"loki-project/loki","private":false,"owner":{"login":"loki-project","id":35471049,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NDcxMDQ5","avatar_url":"https://avatars0.githubusercontent.com/u/35471049?v=4","gravatar_id":"","url":"https://api.github.com/users/loki-project","html_url":"https://github.com/loki-project","followers_url":"https://api.github.com/users/loki-project/followers","following_url":"https://api.github.com/users/loki-project/following{/other_user}","gists_url":"https://api.github.com/users/loki-project/gists{/gist_id}","starred_url":"https://api.github.com/users/loki-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loki-project/subscriptions","organizations_url":"https://api.github.com/users/loki-project/orgs","repos_url":"https://api.github.com/users/loki-project/repos","events_url":"https://api.github.com/users/loki-project/events{/privacy}","received_events_url":"https://api.github.com/users/loki-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/loki-project/loki","description":"Loki core repository, containing lokid and loki cli wallets ","fork":true,"url":"https://api.github.com/repos/loki-project/loki","forks_url":"https://api.github.com/repos/loki-project/loki/forks","keys_url":"https://api.github.com/repos/loki-project/loki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loki-project/loki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loki-project/loki/teams","hooks_url":"https://api.github.com/repos/loki-project/loki/hooks","issue_events_url":"https://api.github.com/repos/loki-project/loki/issues/events{/number}","events_url":"https://api.github.com/repos/loki-project/loki/events","assignees_url":"https://api.github.com/repos/loki-project/loki/assignees{/user}","branches_url":"https://api.github.com/repos/loki-project/loki/branches{/branch}","tags_url":"https://api.github.com/repos/loki-project/loki/tags","blobs_url":"https://api.github.com/repos/loki-project/loki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loki-project/loki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loki-project/loki/git/refs{/sha}","trees_url":"https://api.github.com/repos/loki-project/loki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loki-project/loki/statuses/{sha}","languages_url":"https://api.github.com/repos/loki-project/loki/languages","stargazers_url":"https://api.github.com/repos/loki-project/loki/stargazers","contributors_url":"https://api.github.com/repos/loki-project/loki/contributors","subscribers_url":"https://api.github.com/repos/loki-project/loki/subscribers","subscription_url":"https://api.github.com/repos/loki-project/loki/subscription","commits_url":"https://api.github.com/repos/loki-project/loki/commits{/sha}","git_commits_url":"https://api.github.com/repos/loki-project/loki/git/commits{/sha}","comments_url":"https://api.github.com/repos/loki-project/loki/comments{/number}","issue_comment_url":"https://api.github.com/repos/loki-project/loki/issues/comments{/number}","contents_url":"https://api.github.com/repos/loki-project/loki/contents/{+path}","compare_url":"https://api.github.com/repos/loki-project/loki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loki-project/loki/merges","archive_url":"https://api.github.com/repos/loki-project/loki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loki-project/loki/downloads","issues_url":"https://api.github.com/repos/loki-project/loki/issues{/number}","pulls_url":"https://api.github.com/repos/loki-project/loki/pulls{/number}","milestones_url":"https://api.github.com/repos/loki-project/loki/milestones{/number}","notifications_url":"https://api.github.com/repos/loki-project/loki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loki-project/loki/labels{/name}","releases_url":"https://api.github.com/repos/loki-project/loki/releases{/id}","deployments_url":"https://api.github.com/repos/loki-project/loki/deployments","created_at":"2018-01-15T22:50:09Z","updated_at":"2019-11-20T07:01:11Z","pushed_at":"2019-11-27T03:38:07Z","git_url":"git://github.com/loki-project/loki.git","ssh_url":"[email protected]:loki-project/loki.git","clone_url":"https://github.com/loki-project/loki.git","svn_url":"https://github.com/loki-project/loki","homepage":"https://loki.network","size":166214,"stargazers_count":110,"watchers_count":110,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":78,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":65,"open_issues":78,"watchers":110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/loki-project/loki/pulls/934"},"html":{"href":"https://github.com/loki-project/loki/pull/934"},"issue":{"href":"https://api.github.com/repos/loki-project/loki/issues/934"},"comments":{"href":"https://api.github.com/repos/loki-project/loki/issues/934/comments"},"review_comments":{"href":"https://api.github.com/repos/loki-project/loki/pulls/934/comments"},"review_comment":{"href":"https://api.github.com/repos/loki-project/loki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/loki-project/loki/pulls/934/commits"},"statuses":{"href":"https://api.github.com/repos/loki-project/loki/statuses/9b28451f7d726257deb65c035aef60bc603b0d88"}},"author_association":"COLLABORATOR"}}	{ "id": 117603764, "name": "loki-project/loki", "url": "https://api.github.com/repos/loki-project/loki" }	{ "id": 12163539, "login": "Doy-lee", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/12163539?", "url": "https://api.github.com/users/Doy-lee" }	{ "id": 35471049, "login": "loki-project", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/35471049?", "url": "https://api.github.com/orgs/loki-project" }	2019-11-27T03:38:42	10956573674	{"actor":{"display_login":"Doy-lee"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/nf-core/rnaseq/pulls/comments/320392169","pull_request_review_id":283150654,"id":320392169,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMDM5MjE2OQ==","diff_hunk":"@@ -46,3 +46,5 @@ script:\n - nextflow run ${TRAVIS_BUILD_DIR} -profile test,docker --pseudo_aligner salmon\n # Run with Salmon and no alignment\n - nextflow run ${TRAVIS_BUILD_DIR} -profile test,docker --pseudo_aligner salmon --skipAlignment\n+ # Run with --fc_count_type transcript\n+ - nextflow run ${TRAVIS_BUILD_DIR} -profile test,docker --fc_count_type transcript","path":".travis.yml","position":5,"original_position":5,"commit_id":"4ccef987fe0894932caf638f4fea5649f3a767d2","original_commit_id":"4058af5d60385cdaf0cd29051f9c138c4ff34d81","user":{"login":"lpantano","id":1621788,"node_id":"MDQ6VXNlcjE2MjE3ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1621788?v=4","gravatar_id":"","url":"https://api.github.com/users/lpantano","html_url":"https://github.com/lpantano","followers_url":"https://api.github.com/users/lpantano/followers","following_url":"https://api.github.com/users/lpantano/following{/other_user}","gists_url":"https://api.github.com/users/lpantano/gists{/gist_id}","starred_url":"https://api.github.com/users/lpantano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpantano/subscriptions","organizations_url":"https://api.github.com/users/lpantano/orgs","repos_url":"https://api.github.com/users/lpantano/repos","events_url":"https://api.github.com/users/lpantano/events{/privacy}","received_events_url":"https://api.github.com/users/lpantano/received_events","type":"User","site_admin":false},"body":"I added a better comment in the travis file.","created_at":"2019-09-03T17:32:30Z","updated_at":"2019-09-03T17:32:30Z","html_url":"https://github.com/nf-core/rnaseq/pull/273#discussion_r320392169","pull_request_url":"https://api.github.com/repos/nf-core/rnaseq/pulls/273","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nf-core/rnaseq/pulls/comments/320392169"},"html":{"href":"https://github.com/nf-core/rnaseq/pull/273#discussion_r320392169"},"pull_request":{"href":"https://api.github.com/repos/nf-core/rnaseq/pulls/273"}},"in_reply_to_id":319693217},"pull_request":{"url":"https://api.github.com/repos/nf-core/rnaseq/pulls/273","id":312810797,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEyODEwNzk3","html_url":"https://github.com/nf-core/rnaseq/pull/273","diff_url":"https://github.com/nf-core/rnaseq/pull/273.diff","patch_url":"https://github.com/nf-core/rnaseq/pull/273.patch","issue_url":"https://api.github.com/repos/nf-core/rnaseq/issues/273","number":273,"state":"open","locked":false,"title":"Patch to be compatible with nuclear RNA ","user":{"login":"lpantano","id":1621788,"node_id":"MDQ6VXNlcjE2MjE3ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1621788?v=4","gravatar_id":"","url":"https://api.github.com/users/lpantano","html_url":"https://github.com/lpantano","followers_url":"https://api.github.com/users/lpantano/followers","following_url":"https://api.github.com/users/lpantano/following{/other_user}","gists_url":"https://api.github.com/users/lpantano/gists{/gist_id}","starred_url":"https://api.github.com/users/lpantano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpantano/subscriptions","organizations_url":"https://api.github.com/users/lpantano/orgs","repos_url":"https://api.github.com/users/lpantano/repos","events_url":"https://api.github.com/users/lpantano/events{/privacy}","received_events_url":"https://api.github.com/users/lpantano/received_events","type":"User","site_admin":false},"body":"This PR contains an addition to allow to assign reads to other `type` different than `exon`. For instance, RNA from nuclear samples have a lot of introns, and they are missed here.\r\n\r\nAs well, I fixed an old `seqCenter` reference and cleaned the names of samples for the `rRNA` column in multiqc.\r\n\r\n## PR checklist\r\n - [x] This comment contains a description of changes (with reason)\r\n - [x] If you've fixed a bug or added code that should be tested, add tests!\r\n - [ ] If necessary, also make a PR on the [nf-core/rnaseq branch on the nf-core/test-datasets repo]( https://github.com/nf-core/test-datasets/pull/new/nf-core/rnaseq)\r\n - [x] Ensure the test suite passes (`nextflow run . -profile test,docker`).\r\n - [x] Make sure your code lints (`nf-core lint .`).\r\n - [x] Documentation in `docs` is updated\r\n - [x] `CHANGELOG.md` is updated\r\n - [ ] `README.md` is updated\r\n\r\nLearn more about contributing: https://github.com/nf-core/rnaseq/tree/master/.github/CONTRIBUTING.md\r\n","created_at":"2019-08-30T16:38:24Z","updated_at":"2019-09-03T17:32:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cc02129b2827a0197c1aca93d77b74afbf36ecb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nf-core/rnaseq/pulls/273/commits","review_comments_url":"https://api.github.com/repos/nf-core/rnaseq/pulls/273/comments","review_comment_url":"https://api.github.com/repos/nf-core/rnaseq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nf-core/rnaseq/issues/273/comments","statuses_url":"https://api.github.com/repos/nf-core/rnaseq/statuses/4ccef987fe0894932caf638f4fea5649f3a767d2","head":{"label":"pilm-bioinformatics:patch_nuclear","ref":"patch_nuclear","sha":"4ccef987fe0894932caf638f4fea5649f3a767d2","user":{"login":"pilm-bioinformatics","id":49921985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTIxOTg1","avatar_url":"https://avatars2.githubusercontent.com/u/49921985?v=4","gravatar_id":"","url":"https://api.github.com/users/pilm-bioinformatics","html_url":"https://github.com/pilm-bioinformatics","followers_url":"https://api.github.com/users/pilm-bioinformatics/followers","following_url":"https://api.github.com/users/pilm-bioinformatics/following{/other_user}","gists_url":"https://api.github.com/users/pilm-bioinformatics/gists{/gist_id}","starred_url":"https://api.github.com/users/pilm-bioinformatics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilm-bioinformatics/subscriptions","organizations_url":"https://api.github.com/users/pilm-bioinformatics/orgs","repos_url":"https://api.github.com/users/pilm-bioinformatics/repos","events_url":"https://api.github.com/users/pilm-bioinformatics/events{/privacy}","received_events_url":"https://api.github.com/users/pilm-bioinformatics/received_events","type":"Organization","site_admin":false},"repo":{"id":184627290,"node_id":"MDEwOlJlcG9zaXRvcnkxODQ2MjcyOTA=","name":"pipelines-nf-rnaseq","full_name":"pilm-bioinformatics/pipelines-nf-rnaseq","private":false,"owner":{"login":"pilm-bioinformatics","id":49921985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ5OTIxOTg1","avatar_url":"https://avatars2.githubusercontent.com/u/49921985?v=4","gravatar_id":"","url":"https://api.github.com/users/pilm-bioinformatics","html_url":"https://github.com/pilm-bioinformatics","followers_url":"https://api.github.com/users/pilm-bioinformatics/followers","following_url":"https://api.github.com/users/pilm-bioinformatics/following{/other_user}","gists_url":"https://api.github.com/users/pilm-bioinformatics/gists{/gist_id}","starred_url":"https://api.github.com/users/pilm-bioinformatics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilm-bioinformatics/subscriptions","organizations_url":"https://api.github.com/users/pilm-bioinformatics/orgs","repos_url":"https://api.github.com/users/pilm-bioinformatics/repos","events_url":"https://api.github.com/users/pilm-bioinformatics/events{/privacy}","received_events_url":"https://api.github.com/users/pilm-bioinformatics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pilm-bioinformatics/pipelines-nf-rnaseq","description":"RNA sequencing analysis pipeline using STAR or HISAT2, with gene counts and quality control","fork":true,"url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq","forks_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/forks","keys_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/teams","hooks_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/hooks","issue_events_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/issues/events{/number}","events_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/events","assignees_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/assignees{/user}","branches_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/branches{/branch}","tags_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/tags","blobs_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/git/refs{/sha}","trees_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/statuses/{sha}","languages_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/languages","stargazers_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/stargazers","contributors_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/contributors","subscribers_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/subscribers","subscription_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/subscription","commits_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/commits{/sha}","git_commits_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/git/commits{/sha}","comments_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/comments{/number}","issue_comment_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/issues/comments{/number}","contents_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/contents/{+path}","compare_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/merges","archive_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/downloads","issues_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/issues{/number}","pulls_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/pulls{/number}","milestones_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/milestones{/number}","notifications_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/labels{/name}","releases_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/releases{/id}","deployments_url":"https://api.github.com/repos/pilm-bioinformatics/pipelines-nf-rnaseq/deployments","created_at":"2019-05-02T18:00:01Z","updated_at":"2019-06-20T18:21:08Z","pushed_at":"2019-09-03T17:32:17Z","git_url":"git://github.com/pilm-bioinformatics/pipelines-nf-rnaseq.git","ssh_url":"[email protected]:pilm-bioinformatics/pipelines-nf-rnaseq.git","clone_url":"https://github.com/pilm-bioinformatics/pipelines-nf-rnaseq.git","svn_url":"https://github.com/pilm-bioinformatics/pipelines-nf-rnaseq","homepage":"https://pilm-bioinformatics.github.io/pipelines-nf-rnaseq/.","size":51635,"stargazers_count":0,"watchers_count":0,"language":"Nextflow","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nf-core:dev","ref":"dev","sha":"45da2622066683fd9cfcfbe57bbf0cbe12d284e2","user":{"login":"nf-core","id":35520196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTIwMTk2","avatar_url":"https://avatars0.githubusercontent.com/u/35520196?v=4","gravatar_id":"","url":"https://api.github.com/users/nf-core","html_url":"https://github.com/nf-core","followers_url":"https://api.github.com/users/nf-core/followers","following_url":"https://api.github.com/users/nf-core/following{/other_user}","gists_url":"https://api.github.com/users/nf-core/gists{/gist_id}","starred_url":"https://api.github.com/users/nf-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nf-core/subscriptions","organizations_url":"https://api.github.com/users/nf-core/orgs","repos_url":"https://api.github.com/users/nf-core/repos","events_url":"https://api.github.com/users/nf-core/events{/privacy}","received_events_url":"https://api.github.com/users/nf-core/received_events","type":"Organization","site_admin":false},"repo":{"id":127293091,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcyOTMwOTE=","name":"rnaseq","full_name":"nf-core/rnaseq","private":false,"owner":{"login":"nf-core","id":35520196,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTIwMTk2","avatar_url":"https://avatars0.githubusercontent.com/u/35520196?v=4","gravatar_id":"","url":"https://api.github.com/users/nf-core","html_url":"https://github.com/nf-core","followers_url":"https://api.github.com/users/nf-core/followers","following_url":"https://api.github.com/users/nf-core/following{/other_user}","gists_url":"https://api.github.com/users/nf-core/gists{/gist_id}","starred_url":"https://api.github.com/users/nf-core/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nf-core/subscriptions","organizations_url":"https://api.github.com/users/nf-core/orgs","repos_url":"https://api.github.com/users/nf-core/repos","events_url":"https://api.github.com/users/nf-core/events{/privacy}","received_events_url":"https://api.github.com/users/nf-core/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nf-core/rnaseq","description":"RNA sequencing analysis pipeline using STAR or HISAT2, with gene counts and quality control","fork":true,"url":"https://api.github.com/repos/nf-core/rnaseq","forks_url":"https://api.github.com/repos/nf-core/rnaseq/forks","keys_url":"https://api.github.com/repos/nf-core/rnaseq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nf-core/rnaseq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nf-core/rnaseq/teams","hooks_url":"https://api.github.com/repos/nf-core/rnaseq/hooks","issue_events_url":"https://api.github.com/repos/nf-core/rnaseq/issues/events{/number}","events_url":"https://api.github.com/repos/nf-core/rnaseq/events","assignees_url":"https://api.github.com/repos/nf-core/rnaseq/assignees{/user}","branches_url":"https://api.github.com/repos/nf-core/rnaseq/branches{/branch}","tags_url":"https://api.github.com/repos/nf-core/rnaseq/tags","blobs_url":"https://api.github.com/repos/nf-core/rnaseq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nf-core/rnaseq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nf-core/rnaseq/git/refs{/sha}","trees_url":"https://api.github.com/repos/nf-core/rnaseq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nf-core/rnaseq/statuses/{sha}","languages_url":"https://api.github.com/repos/nf-core/rnaseq/languages","stargazers_url":"https://api.github.com/repos/nf-core/rnaseq/stargazers","contributors_url":"https://api.github.com/repos/nf-core/rnaseq/contributors","subscribers_url":"https://api.github.com/repos/nf-core/rnaseq/subscribers","subscription_url":"https://api.github.com/repos/nf-core/rnaseq/subscription","commits_url":"https://api.github.com/repos/nf-core/rnaseq/commits{/sha}","git_commits_url":"https://api.github.com/repos/nf-core/rnaseq/git/commits{/sha}","comments_url":"https://api.github.com/repos/nf-core/rnaseq/comments{/number}","issue_comment_url":"https://api.github.com/repos/nf-core/rnaseq/issues/comments{/number}","contents_url":"https://api.github.com/repos/nf-core/rnaseq/contents/{+path}","compare_url":"https://api.github.com/repos/nf-core/rnaseq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nf-core/rnaseq/merges","archive_url":"https://api.github.com/repos/nf-core/rnaseq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nf-core/rnaseq/downloads","issues_url":"https://api.github.com/repos/nf-core/rnaseq/issues{/number}","pulls_url":"https://api.github.com/repos/nf-core/rnaseq/pulls{/number}","milestones_url":"https://api.github.com/repos/nf-core/rnaseq/milestones{/number}","notifications_url":"https://api.github.com/repos/nf-core/rnaseq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nf-core/rnaseq/labels{/name}","releases_url":"https://api.github.com/repos/nf-core/rnaseq/releases{/id}","deployments_url":"https://api.github.com/repos/nf-core/rnaseq/deployments","created_at":"2018-03-29T13:10:58Z","updated_at":"2019-09-02T06:03:21Z","pushed_at":"2019-09-03T17:32:18Z","git_url":"git://github.com/nf-core/rnaseq.git","ssh_url":"[email protected]:nf-core/rnaseq.git","clone_url":"https://github.com/nf-core/rnaseq.git","svn_url":"https://github.com/nf-core/rnaseq","homepage":"http://nf-co.re","size":51583,"stargazers_count":128,"watchers_count":128,"language":"Nextflow","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":39,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":80,"open_issues":39,"watchers":128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nf-core/rnaseq/pulls/273"},"html":{"href":"https://github.com/nf-core/rnaseq/pull/273"},"issue":{"href":"https://api.github.com/repos/nf-core/rnaseq/issues/273"},"comments":{"href":"https://api.github.com/repos/nf-core/rnaseq/issues/273/comments"},"review_comments":{"href":"https://api.github.com/repos/nf-core/rnaseq/pulls/273/comments"},"review_comment":{"href":"https://api.github.com/repos/nf-core/rnaseq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nf-core/rnaseq/pulls/273/commits"},"statuses":{"href":"https://api.github.com/repos/nf-core/rnaseq/statuses/4ccef987fe0894932caf638f4fea5649f3a767d2"}},"author_association":"NONE"}}	{ "id": 127293091, "name": "nf-core/rnaseq", "url": "https://api.github.com/repos/nf-core/rnaseq" }	{ "id": 1621788, "login": "lpantano", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/1621788?", "url": "https://api.github.com/users/lpantano" }	{ "id": 35520196, "login": "nf-core", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/35520196?", "url": "https://api.github.com/orgs/nf-core" }	2019-09-03T17:32:30	10338704564	{"actor":{"display_login":"lpantano"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/knative/eventing/pulls/comments/290575764","pull_request_review_id":245801471,"id":290575764,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MDU3NTc2NA==","diff_hunk":"@@ -52,22 +52,34 @@ var (\n \n // ContainerSourceSpec defines the desired state of ContainerSource\n type ContainerSourceSpec struct {\n+\t// Template describes the pods that will be created\n+\t// +optional\n+\tTemplate corev1.PodTemplateSpec `json:\"template,omitempty\"`\n+\n \t// Image is the image to run inside of the container.\n+\t// This field is to be deprecated. Use `Template` instead.\n+\t// When `Template` is set, this field is ignored.\n \t// +kubebuilder:validation:MinLength=1\n \tImage string `json:\"image,omitempty\"`","path":"pkg/apis/sources/v1alpha1/containersource_types.go","position":null,"original_position":12,"commit_id":"c6bb6220128fc77d0d201c6013039d37d2ae5037","original_commit_id":"ab600221052016daa8cb7efe8b7304cd72f33f8d","user":{"login":"jingweno","id":169064,"node_id":"MDQ6VXNlcjE2OTA2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/169064?v=4","gravatar_id":"","url":"https://api.github.com/users/jingweno","html_url":"https://github.com/jingweno","followers_url":"https://api.github.com/users/jingweno/followers","following_url":"https://api.github.com/users/jingweno/following{/other_user}","gists_url":"https://api.github.com/users/jingweno/gists{/gist_id}","starred_url":"https://api.github.com/users/jingweno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingweno/subscriptions","organizations_url":"https://api.github.com/users/jingweno/orgs","repos_url":"https://api.github.com/users/jingweno/repos","events_url":"https://api.github.com/users/jingweno/events{/privacy}","received_events_url":"https://api.github.com/users/jingweno/received_events","type":"User","site_admin":false},"body":"Good call. Done in https://github.com/knative/eventing/pull/1321/commits/c6bb6220128fc77d0d201c6013039d37d2ae5037.","created_at":"2019-06-05T04:13:22Z","updated_at":"2019-06-05T04:13:23Z","html_url":"https://github.com/knative/eventing/pull/1321#discussion_r290575764","pull_request_url":"https://api.github.com/repos/knative/eventing/pulls/1321","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/knative/eventing/pulls/comments/290575764"},"html":{"href":"https://github.com/knative/eventing/pull/1321#discussion_r290575764"},"pull_request":{"href":"https://api.github.com/repos/knative/eventing/pulls/1321"}},"in_reply_to_id":290346024},"pull_request":{"url":"https://api.github.com/repos/knative/eventing/pulls/1321","id":284414116,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg0NDE0MTE2","html_url":"https://github.com/knative/eventing/pull/1321","diff_url":"https://github.com/knative/eventing/pull/1321.diff","patch_url":"https://github.com/knative/eventing/pull/1321.patch","issue_url":"https://api.github.com/repos/knative/eventing/issues/1321","number":1321,"state":"open","locked":false,"title":"Support `PodTemplateSpec` for `ContainerSource`","user":{"login":"jingweno","id":169064,"node_id":"MDQ6VXNlcjE2OTA2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/169064?v=4","gravatar_id":"","url":"https://api.github.com/users/jingweno","html_url":"https://github.com/jingweno","followers_url":"https://api.github.com/users/jingweno/followers","following_url":"https://api.github.com/users/jingweno/following{/other_user}","gists_url":"https://api.github.com/users/jingweno/gists{/gist_id}","starred_url":"https://api.github.com/users/jingweno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingweno/subscriptions","organizations_url":"https://api.github.com/users/jingweno/orgs","repos_url":"https://api.github.com/users/jingweno/repos","events_url":"https://api.github.com/users/jingweno/events{/privacy}","received_events_url":"https://api.github.com/users/jingweno/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/knative/eventing/issues/1151\r\n\r\n## Proposed Changes\r\n\r\nAdd a `Template` field of type `PodTemplateSpec` to `ContainerSourceSpec`. This allows creating a container source with pod template like a Deployment, including mounting a secret for the container source.\r\n\r\nAs an example, [heartbeats-send.yaml](https://github.com/knative/eventing-sources/blob/ba5124e6c776bc27cae7789a14f7b05434f38c88/samples/heartbeats/heartbeats-sender.yaml) can be rewritten as the following to mount a secret:\r\n\r\n```yaml\r\napiVersion: sources.eventing.knative.dev/v1alpha1\r\nkind: ContainerSource\r\nmetadata:\r\n name: heartbeats-sender\r\nspec:\r\n template:\r\n spec:\r\n containers:\r\n - image: github.com/knative/eventing-sources/cmd/heartbeats/\r\n args:\r\n - '--label=\"<3\"'\r\n - '--period=2'\r\n env:\r\n - name: POD_NAME\r\n valueFrom:\r\n fieldRef:\r\n fieldPath: metadata.name\r\n - name: POD_NAMESPACE\r\n valueFrom:\r\n fieldRef:\r\n fieldPath: metadata.namespace\r\n volumeMounts:\r\n - name: foo\r\n mountPath: \"/etc/foo\"\r\n readOnly: true\r\n volumes:\r\n - name: foo\r\n secret:\r\n secretName: mysecret\r\n sink:\r\n apiVersion: serving.knative.dev/v1alpha1\r\n kind: Service\r\n name: heartbeats-receiver\r\n```\r\n\r\nExisting fields `image`, `args`, `env` and `serviceAccountName` are marked as deprecated and for backward compatibilities they continue to exist. If both `template` and these fields exist, `template` is preferred. In future release, the deprecated fields should be removed.\r\n\r\nRelease Note*\r\n\r\n<!-- Enter your extended release note in the below block. If the PR requires\r\nadditional action from users switching to the new release, include the string\r\n\"action required\". If no release note is required, write \"NONE\". -->\r\n\r\n```release-note\r\nUsers are encouraged to migrate existing container sources to use `template` instead of `image`, `args`, `env` and `serviceAccountName`. In future release, `image`, `args`, `env` and `serviceAccountName` will be removed.\r\n```\r\n","created_at":"2019-06-03T05:03:42Z","updated_at":"2019-06-05T04:13:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de4f00b8cb8d3f30aba92957967b9b07e609f060","assignee":{"login":"evankanderson","id":7959095,"node_id":"MDQ6VXNlcjc5NTkwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/7959095?v=4","gravatar_id":"","url":"https://api.github.com/users/evankanderson","html_url":"https://github.com/evankanderson","followers_url":"https://api.github.com/users/evankanderson/followers","following_url":"https://api.github.com/users/evankanderson/following{/other_user}","gists_url":"https://api.github.com/users/evankanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/evankanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evankanderson/subscriptions","organizations_url":"https://api.github.com/users/evankanderson/orgs","repos_url":"https://api.github.com/users/evankanderson/repos","events_url":"https://api.github.com/users/evankanderson/events{/privacy}","received_events_url":"https://api.github.com/users/evankanderson/received_events","type":"User","site_admin":false},"assignees":[{"login":"evankanderson","id":7959095,"node_id":"MDQ6VXNlcjc5NTkwOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/7959095?v=4","gravatar_id":"","url":"https://api.github.com/users/evankanderson","html_url":"https://github.com/evankanderson","followers_url":"https://api.github.com/users/evankanderson/followers","following_url":"https://api.github.com/users/evankanderson/following{/other_user}","gists_url":"https://api.github.com/users/evankanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/evankanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evankanderson/subscriptions","organizations_url":"https://api.github.com/users/evankanderson/orgs","repos_url":"https://api.github.com/users/evankanderson/repos","events_url":"https://api.github.com/users/evankanderson/events{/privacy}","received_events_url":"https://api.github.com/users/evankanderson/received_events","type":"User","site_admin":false},{"login":"n3wscott","id":32305648,"node_id":"MDQ6VXNlcjMyMzA1NjQ4","avatar_url":"https://avatars3.githubusercontent.com/u/32305648?v=4","gravatar_id":"","url":"https://api.github.com/users/n3wscott","html_url":"https://github.com/n3wscott","followers_url":"https://api.github.com/users/n3wscott/followers","following_url":"https://api.github.com/users/n3wscott/following{/other_user}","gists_url":"https://api.github.com/users/n3wscott/gists{/gist_id}","starred_url":"https://api.github.com/users/n3wscott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n3wscott/subscriptions","organizations_url":"https://api.github.com/users/n3wscott/orgs","repos_url":"https://api.github.com/users/n3wscott/repos","events_url":"https://api.github.com/users/n3wscott/events{/privacy}","received_events_url":"https://api.github.com/users/n3wscott/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Harwayne","id":227171,"node_id":"MDQ6VXNlcjIyNzE3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/227171?v=4","gravatar_id":"","url":"https://api.github.com/users/Harwayne","html_url":"https://github.com/Harwayne","followers_url":"https://api.github.com/users/Harwayne/followers","following_url":"https://api.github.com/users/Harwayne/following{/other_user}","gists_url":"https://api.github.com/users/Harwayne/gists{/gist_id}","starred_url":"https://api.github.com/users/Harwayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Harwayne/subscriptions","organizations_url":"https://api.github.com/users/Harwayne/orgs","repos_url":"https://api.github.com/users/Harwayne/repos","events_url":"https://api.github.com/users/Harwayne/events{/privacy}","received_events_url":"https://api.github.com/users/Harwayne/received_events","type":"User","site_admin":false},{"login":"vaikas-google","id":11279988,"node_id":"MDQ6VXNlcjExMjc5OTg4","avatar_url":"https://avatars3.githubusercontent.com/u/11279988?v=4","gravatar_id":"","url":"https://api.github.com/users/vaikas-google","html_url":"https://github.com/vaikas-google","followers_url":"https://api.github.com/users/vaikas-google/followers","following_url":"https://api.github.com/users/vaikas-google/following{/other_user}","gists_url":"https://api.github.com/users/vaikas-google/gists{/gist_id}","starred_url":"https://api.github.com/users/vaikas-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaikas-google/subscriptions","organizations_url":"https://api.github.com/users/vaikas-google/orgs","repos_url":"https://api.github.com/users/vaikas-google/repos","events_url":"https://api.github.com/users/vaikas-google/events{/privacy}","received_events_url":"https://api.github.com/users/vaikas-google/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":897406231,"node_id":"MDU6TGFiZWw4OTc0MDYyMzE=","url":"https://api.github.com/repos/knative/eventing/labels/approved","name":"approved","color":"ededed","default":false},{"id":1096308746,"node_id":"MDU6TGFiZWwxMDk2MzA4NzQ2","url":"https://api.github.com/repos/knative/eventing/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false},{"id":1337314197,"node_id":"MDU6TGFiZWwxMzM3MzE0MTk3","url":"https://api.github.com/repos/knative/eventing/labels/ok-to-test","name":"ok-to-test","color":"ededed","default":false},{"id":914079600,"node_id":"MDU6TGFiZWw5MTQwNzk2MDA=","url":"https://api.github.com/repos/knative/eventing/labels/size/XL","name":"size/XL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/knative/eventing/pulls/1321/commits","review_comments_url":"https://api.github.com/repos/knative/eventing/pulls/1321/comments","review_comment_url":"https://api.github.com/repos/knative/eventing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/eventing/issues/1321/comments","statuses_url":"https://api.github.com/repos/knative/eventing/statuses/c6bb6220128fc77d0d201c6013039d37d2ae5037","head":{"label":"jingweno:container_template","ref":"container_template","sha":"c6bb6220128fc77d0d201c6013039d37d2ae5037","user":{"login":"jingweno","id":169064,"node_id":"MDQ6VXNlcjE2OTA2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/169064?v=4","gravatar_id":"","url":"https://api.github.com/users/jingweno","html_url":"https://github.com/jingweno","followers_url":"https://api.github.com/users/jingweno/followers","following_url":"https://api.github.com/users/jingweno/following{/other_user}","gists_url":"https://api.github.com/users/jingweno/gists{/gist_id}","starred_url":"https://api.github.com/users/jingweno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingweno/subscriptions","organizations_url":"https://api.github.com/users/jingweno/orgs","repos_url":"https://api.github.com/users/jingweno/repos","events_url":"https://api.github.com/users/jingweno/events{/privacy}","received_events_url":"https://api.github.com/users/jingweno/received_events","type":"User","site_admin":false},"repo":{"id":189935268,"node_id":"MDEwOlJlcG9zaXRvcnkxODk5MzUyNjg=","name":"eventing","full_name":"jingweno/eventing","private":false,"owner":{"login":"jingweno","id":169064,"node_id":"MDQ6VXNlcjE2OTA2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/169064?v=4","gravatar_id":"","url":"https://api.github.com/users/jingweno","html_url":"https://github.com/jingweno","followers_url":"https://api.github.com/users/jingweno/followers","following_url":"https://api.github.com/users/jingweno/following{/other_user}","gists_url":"https://api.github.com/users/jingweno/gists{/gist_id}","starred_url":"https://api.github.com/users/jingweno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingweno/subscriptions","organizations_url":"https://api.github.com/users/jingweno/orgs","repos_url":"https://api.github.com/users/jingweno/repos","events_url":"https://api.github.com/users/jingweno/events{/privacy}","received_events_url":"https://api.github.com/users/jingweno/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jingweno/eventing","description":"Open source specification and implementation of Knative event binding and delivery","fork":true,"url":"https://api.github.com/repos/jingweno/eventing","forks_url":"https://api.github.com/repos/jingweno/eventing/forks","keys_url":"https://api.github.com/repos/jingweno/eventing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jingweno/eventing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jingweno/eventing/teams","hooks_url":"https://api.github.com/repos/jingweno/eventing/hooks","issue_events_url":"https://api.github.com/repos/jingweno/eventing/issues/events{/number}","events_url":"https://api.github.com/repos/jingweno/eventing/events","assignees_url":"https://api.github.com/repos/jingweno/eventing/assignees{/user}","branches_url":"https://api.github.com/repos/jingweno/eventing/branches{/branch}","tags_url":"https://api.github.com/repos/jingweno/eventing/tags","blobs_url":"https://api.github.com/repos/jingweno/eventing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jingweno/eventing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jingweno/eventing/git/refs{/sha}","trees_url":"https://api.github.com/repos/jingweno/eventing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jingweno/eventing/statuses/{sha}","languages_url":"https://api.github.com/repos/jingweno/eventing/languages","stargazers_url":"https://api.github.com/repos/jingweno/eventing/stargazers","contributors_url":"https://api.github.com/repos/jingweno/eventing/contributors","subscribers_url":"https://api.github.com/repos/jingweno/eventing/subscribers","subscription_url":"https://api.github.com/repos/jingweno/eventing/subscription","commits_url":"https://api.github.com/repos/jingweno/eventing/commits{/sha}","git_commits_url":"https://api.github.com/repos/jingweno/eventing/git/commits{/sha}","comments_url":"https://api.github.com/repos/jingweno/eventing/comments{/number}","issue_comment_url":"https://api.github.com/repos/jingweno/eventing/issues/comments{/number}","contents_url":"https://api.github.com/repos/jingweno/eventing/contents/{+path}","compare_url":"https://api.github.com/repos/jingweno/eventing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jingweno/eventing/merges","archive_url":"https://api.github.com/repos/jingweno/eventing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jingweno/eventing/downloads","issues_url":"https://api.github.com/repos/jingweno/eventing/issues{/number}","pulls_url":"https://api.github.com/repos/jingweno/eventing/pulls{/number}","milestones_url":"https://api.github.com/repos/jingweno/eventing/milestones{/number}","notifications_url":"https://api.github.com/repos/jingweno/eventing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jingweno/eventing/labels{/name}","releases_url":"https://api.github.com/repos/jingweno/eventing/releases{/id}","deployments_url":"https://api.github.com/repos/jingweno/eventing/deployments","created_at":"2019-06-03T04:40:06Z","updated_at":"2019-06-03T04:40:10Z","pushed_at":"2019-06-05T04:12:58Z","git_url":"git://github.com/jingweno/eventing.git","ssh_url":"[email protected]:jingweno/eventing.git","clone_url":"https://github.com/jingweno/eventing.git","svn_url":"https://github.com/jingweno/eventing","homepage":"","size":25366,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"3168580d51a1dcebeb56b075ccec5d97e5022b66","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":124951822,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ5NTE4MjI=","name":"eventing","full_name":"knative/eventing","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/eventing","description":"Open source specification and implementation of Knative event binding and delivery","fork":false,"url":"https://api.github.com/repos/knative/eventing","forks_url":"https://api.github.com/repos/knative/eventing/forks","keys_url":"https://api.github.com/repos/knative/eventing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/eventing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/eventing/teams","hooks_url":"https://api.github.com/repos/knative/eventing/hooks","issue_events_url":"https://api.github.com/repos/knative/eventing/issues/events{/number}","events_url":"https://api.github.com/repos/knative/eventing/events","assignees_url":"https://api.github.com/repos/knative/eventing/assignees{/user}","branches_url":"https://api.github.com/repos/knative/eventing/branches{/branch}","tags_url":"https://api.github.com/repos/knative/eventing/tags","blobs_url":"https://api.github.com/repos/knative/eventing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/eventing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/eventing/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/eventing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/eventing/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/eventing/languages","stargazers_url":"https://api.github.com/repos/knative/eventing/stargazers","contributors_url":"https://api.github.com/repos/knative/eventing/contributors","subscribers_url":"https://api.github.com/repos/knative/eventing/subscribers","subscription_url":"https://api.github.com/repos/knative/eventing/subscription","commits_url":"https://api.github.com/repos/knative/eventing/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/eventing/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/eventing/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/eventing/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/eventing/contents/{+path}","compare_url":"https://api.github.com/repos/knative/eventing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/eventing/merges","archive_url":"https://api.github.com/repos/knative/eventing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/eventing/downloads","issues_url":"https://api.github.com/repos/knative/eventing/issues{/number}","pulls_url":"https://api.github.com/repos/knative/eventing/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/eventing/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/eventing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/eventing/labels{/name}","releases_url":"https://api.github.com/repos/knative/eventing/releases{/id}","deployments_url":"https://api.github.com/repos/knative/eventing/deployments","created_at":"2018-03-12T21:08:29Z","updated_at":"2019-06-04T23:19:45Z","pushed_at":"2019-06-05T04:13:00Z","git_url":"git://github.com/knative/eventing.git","ssh_url":"[email protected]:knative/eventing.git","clone_url":"https://github.com/knative/eventing.git","svn_url":"https://github.com/knative/eventing","homepage":"","size":25396,"stargazers_count":505,"watchers_count":505,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":192,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":157,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":192,"open_issues":157,"watchers":505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/eventing/pulls/1321"},"html":{"href":"https://github.com/knative/eventing/pull/1321"},"issue":{"href":"https://api.github.com/repos/knative/eventing/issues/1321"},"comments":{"href":"https://api.github.com/repos/knative/eventing/issues/1321/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/eventing/pulls/1321/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/eventing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/eventing/pulls/1321/commits"},"statuses":{"href":"https://api.github.com/repos/knative/eventing/statuses/c6bb6220128fc77d0d201c6013039d37d2ae5037"}},"author_association":"NONE"}}	{ "id": 124951822, "name": "knative/eventing", "url": "https://api.github.com/repos/knative/eventing" }	{ "id": 169064, "login": "jingweno", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/169064?", "url": "https://api.github.com/users/jingweno" }	{ "id": 35583233, "login": "knative", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/35583233?", "url": "https://api.github.com/orgs/knative" }	2019-06-05T04:13:22	9760216814	{"actor":{"display_login":"jingweno"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/knative/test-infra/pulls/comments/262254892","pull_request_review_id":210371871,"id":262254892,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MjI1NDg5Mg==","diff_hunk":"@@ -0,0 +1,153 @@\n+/\n+Copyright 2018 The Knative Authors\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+ http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+/\n+\n+// slack_notification.go sends notifications to slack channels\n+\n+package main\n+\n+import (\n+\t\"io/ioutil\"\n+\t\"strings\"\n+\t\"time\"\n+\t\"log\"\n+\t\"fmt\"\n+\t\"encoding/json\"\n+\n+\t\"net/http\"\n+\t\"net/url\"\n+\n+\t\"github.com/knative/test-infra/shared/testgrid\"\n+)\n+\n+const (\n+\tslackChatPostMessageURL = \"https://slack.com/api/chat.postMessage\"\n+\t// default filter for testgrid link\n+\ttestgridFilter = \"exclude-non-failed-tests=20\"\n+)\n+\n+var (\n+\tslackUsername = \"Knative bot\"\n+\tslackTokenStr string","path":"tools/flaky-test-reporter/slack_notification.go","position":43,"original_position":43,"commit_id":"67743e414afb610b1de04a7e22527acdfca8ebed","original_commit_id":"67743e414afb610b1de04a7e22527acdfca8ebed","user":{"login":"srinivashegde86","id":2238582,"node_id":"MDQ6VXNlcjIyMzg1ODI=","avatar_url":"https://avatars1.githubusercontent.com/u/2238582?v=4","gravatar_id":"","url":"https://api.github.com/users/srinivashegde86","html_url":"https://github.com/srinivashegde86","followers_url":"https://api.github.com/users/srinivashegde86/followers","following_url":"https://api.github.com/users/srinivashegde86/following{/other_user}","gists_url":"https://api.github.com/users/srinivashegde86/gists{/gist_id}","starred_url":"https://api.github.com/users/srinivashegde86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srinivashegde86/subscriptions","organizations_url":"https://api.github.com/users/srinivashegde86/orgs","repos_url":"https://api.github.com/users/srinivashegde86/repos","events_url":"https://api.github.com/users/srinivashegde86/events{/privacy}","received_events_url":"https://api.github.com/users/srinivashegde86/received_events","type":"User","site_admin":false},"body":"these two can be part of the slack client","created_at":"2019-03-04T21:39:53Z","updated_at":"2019-03-04T21:44:04Z","html_url":"https://github.com/knative/test-infra/pull/541#discussion_r262254892","pull_request_url":"https://api.github.com/repos/knative/test-infra/pulls/541","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/knative/test-infra/pulls/comments/262254892"},"html":{"href":"https://github.com/knative/test-infra/pull/541#discussion_r262254892"},"pull_request":{"href":"https://api.github.com/repos/knative/test-infra/pulls/541"}}},"pull_request":{"url":"https://api.github.com/repos/knative/test-infra/pulls/541","id":257570613,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3NTcwNjEz","html_url":"https://github.com/knative/test-infra/pull/541","diff_url":"https://github.com/knative/test-infra/pull/541.diff","patch_url":"https://github.com/knative/test-infra/pull/541.patch","issue_url":"https://api.github.com/repos/knative/test-infra/issues/541","number":541,"state":"open","locked":false,"title":"Flaky test reporting(part #5) Automatic Slack notification for flaky tests","user":{"login":"chaodaiG","id":45011425,"node_id":"MDQ6VXNlcjQ1MDExNDI1","avatar_url":"https://avatars0.githubusercontent.com/u/45011425?v=4","gravatar_id":"","url":"https://api.github.com/users/chaodaiG","html_url":"https://github.com/chaodaiG","followers_url":"https://api.github.com/users/chaodaiG/followers","following_url":"https://api.github.com/users/chaodaiG/following{/other_user}","gists_url":"https://api.github.com/users/chaodaiG/gists{/gist_id}","starred_url":"https://api.github.com/users/chaodaiG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaodaiG/subscriptions","organizations_url":"https://api.github.com/users/chaodaiG/orgs","repos_url":"https://api.github.com/users/chaodaiG/repos","events_url":"https://api.github.com/users/chaodaiG/events{/privacy}","received_events_url":"https://api.github.com/users/chaodaiG/received_events","type":"User","site_admin":false},"body":"Send Slack notification to channels, based on test results collected from most recent continuous flows and data structure defined in [PR465](https://github.com/knative/test-infra/pull/465).\r\n\r\nPart of: #132","created_at":"2019-03-01T20:21:35Z","updated_at":"2019-03-04T21:44:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2bb9d3d5d30f2bcce34b85495cf59bcb80177d1d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"adrcunha","id":35786489,"node_id":"MDQ6VXNlcjM1Nzg2NDg5","avatar_url":"https://avatars3.githubusercontent.com/u/35786489?v=4","gravatar_id":"","url":"https://api.github.com/users/adrcunha","html_url":"https://github.com/adrcunha","followers_url":"https://api.github.com/users/adrcunha/followers","following_url":"https://api.github.com/users/adrcunha/following{/other_user}","gists_url":"https://api.github.com/users/adrcunha/gists{/gist_id}","starred_url":"https://api.github.com/users/adrcunha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrcunha/subscriptions","organizations_url":"https://api.github.com/users/adrcunha/orgs","repos_url":"https://api.github.com/users/adrcunha/repos","events_url":"https://api.github.com/users/adrcunha/events{/privacy}","received_events_url":"https://api.github.com/users/adrcunha/received_events","type":"User","site_admin":false},{"login":"jessiezcc","id":37942702,"node_id":"MDQ6VXNlcjM3OTQyNzAy","avatar_url":"https://avatars2.githubusercontent.com/u/37942702?v=4","gravatar_id":"","url":"https://api.github.com/users/jessiezcc","html_url":"https://github.com/jessiezcc","followers_url":"https://api.github.com/users/jessiezcc/followers","following_url":"https://api.github.com/users/jessiezcc/following{/other_user}","gists_url":"https://api.github.com/users/jessiezcc/gists{/gist_id}","starred_url":"https://api.github.com/users/jessiezcc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessiezcc/subscriptions","organizations_url":"https://api.github.com/users/jessiezcc/orgs","repos_url":"https://api.github.com/users/jessiezcc/repos","events_url":"https://api.github.com/users/jessiezcc/events{/privacy}","received_events_url":"https://api.github.com/users/jessiezcc/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":993222908,"node_id":"MDU6TGFiZWw5OTMyMjI5MDg=","url":"https://api.github.com/repos/knative/test-infra/labels/approved","name":"approved","color":"ededed","default":false},{"id":993222917,"node_id":"MDU6TGFiZWw5OTMyMjI5MTc=","url":"https://api.github.com/repos/knative/test-infra/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/knative/test-infra/pulls/541/commits","review_comments_url":"https://api.github.com/repos/knative/test-infra/pulls/541/comments","review_comment_url":"https://api.github.com/repos/knative/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/test-infra/issues/541/comments","statuses_url":"https://api.github.com/repos/knative/test-infra/statuses/67743e414afb610b1de04a7e22527acdfca8ebed","head":{"label":"chaodaiG:slack_flaky_test","ref":"slack_flaky_test","sha":"67743e414afb610b1de04a7e22527acdfca8ebed","user":{"login":"chaodaiG","id":45011425,"node_id":"MDQ6VXNlcjQ1MDExNDI1","avatar_url":"https://avatars0.githubusercontent.com/u/45011425?v=4","gravatar_id":"","url":"https://api.github.com/users/chaodaiG","html_url":"https://github.com/chaodaiG","followers_url":"https://api.github.com/users/chaodaiG/followers","following_url":"https://api.github.com/users/chaodaiG/following{/other_user}","gists_url":"https://api.github.com/users/chaodaiG/gists{/gist_id}","starred_url":"https://api.github.com/users/chaodaiG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaodaiG/subscriptions","organizations_url":"https://api.github.com/users/chaodaiG/orgs","repos_url":"https://api.github.com/users/chaodaiG/repos","events_url":"https://api.github.com/users/chaodaiG/events{/privacy}","received_events_url":"https://api.github.com/users/chaodaiG/received_events","type":"User","site_admin":false},"repo":{"id":159388501,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkzODg1MDE=","name":"test-infra","full_name":"chaodaiG/test-infra","private":false,"owner":{"login":"chaodaiG","id":45011425,"node_id":"MDQ6VXNlcjQ1MDExNDI1","avatar_url":"https://avatars0.githubusercontent.com/u/45011425?v=4","gravatar_id":"","url":"https://api.github.com/users/chaodaiG","html_url":"https://github.com/chaodaiG","followers_url":"https://api.github.com/users/chaodaiG/followers","following_url":"https://api.github.com/users/chaodaiG/following{/other_user}","gists_url":"https://api.github.com/users/chaodaiG/gists{/gist_id}","starred_url":"https://api.github.com/users/chaodaiG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaodaiG/subscriptions","organizations_url":"https://api.github.com/users/chaodaiG/orgs","repos_url":"https://api.github.com/users/chaodaiG/repos","events_url":"https://api.github.com/users/chaodaiG/events{/privacy}","received_events_url":"https://api.github.com/users/chaodaiG/received_events","type":"User","site_admin":false},"html_url":"https://github.com/chaodaiG/test-infra","description":"Test infrastructure for the Knative project.","fork":true,"url":"https://api.github.com/repos/chaodaiG/test-infra","forks_url":"https://api.github.com/repos/chaodaiG/test-infra/forks","keys_url":"https://api.github.com/repos/chaodaiG/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaodaiG/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaodaiG/test-infra/teams","hooks_url":"https://api.github.com/repos/chaodaiG/test-infra/hooks","issue_events_url":"https://api.github.com/repos/chaodaiG/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/chaodaiG/test-infra/events","assignees_url":"https://api.github.com/repos/chaodaiG/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/chaodaiG/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/chaodaiG/test-infra/tags","blobs_url":"https://api.github.com/repos/chaodaiG/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaodaiG/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaodaiG/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaodaiG/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaodaiG/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/chaodaiG/test-infra/languages","stargazers_url":"https://api.github.com/repos/chaodaiG/test-infra/stargazers","contributors_url":"https://api.github.com/repos/chaodaiG/test-infra/contributors","subscribers_url":"https://api.github.com/repos/chaodaiG/test-infra/subscribers","subscription_url":"https://api.github.com/repos/chaodaiG/test-infra/subscription","commits_url":"https://api.github.com/repos/chaodaiG/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaodaiG/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaodaiG/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaodaiG/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaodaiG/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/chaodaiG/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaodaiG/test-infra/merges","archive_url":"https://api.github.com/repos/chaodaiG/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaodaiG/test-infra/downloads","issues_url":"https://api.github.com/repos/chaodaiG/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/chaodaiG/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/chaodaiG/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/chaodaiG/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaodaiG/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/chaodaiG/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/chaodaiG/test-infra/deployments","created_at":"2018-11-27T19:31:52Z","updated_at":"2019-03-01T18:02:19Z","pushed_at":"2019-03-04T18:18:40Z","git_url":"git://github.com/chaodaiG/test-infra.git","ssh_url":"[email protected]:chaodaiG/test-infra.git","clone_url":"https://github.com/chaodaiG/test-infra.git","svn_url":"https://github.com/chaodaiG/test-infra","homepage":null,"size":10853,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"10a817f5514fdee63630b14929c09b67a0e43169","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":136082371,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwODIzNzE=","name":"test-infra","full_name":"knative/test-infra","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/test-infra","description":"Test infrastructure for the Knative project.","fork":false,"url":"https://api.github.com/repos/knative/test-infra","forks_url":"https://api.github.com/repos/knative/test-infra/forks","keys_url":"https://api.github.com/repos/knative/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/test-infra/teams","hooks_url":"https://api.github.com/repos/knative/test-infra/hooks","issue_events_url":"https://api.github.com/repos/knative/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/knative/test-infra/events","assignees_url":"https://api.github.com/repos/knative/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/knative/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/knative/test-infra/tags","blobs_url":"https://api.github.com/repos/knative/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/test-infra/languages","stargazers_url":"https://api.github.com/repos/knative/test-infra/stargazers","contributors_url":"https://api.github.com/repos/knative/test-infra/contributors","subscribers_url":"https://api.github.com/repos/knative/test-infra/subscribers","subscription_url":"https://api.github.com/repos/knative/test-infra/subscription","commits_url":"https://api.github.com/repos/knative/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/knative/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/test-infra/merges","archive_url":"https://api.github.com/repos/knative/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/test-infra/downloads","issues_url":"https://api.github.com/repos/knative/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/knative/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/knative/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/knative/test-infra/deployments","created_at":"2018-06-04T21:01:06Z","updated_at":"2019-03-04T00:23:30Z","pushed_at":"2019-03-04T19:17:47Z","git_url":"git://github.com/knative/test-infra.git","ssh_url":"[email protected]:knative/test-infra.git","clone_url":"https://github.com/knative/test-infra.git","svn_url":"https://github.com/knative/test-infra","homepage":null,"size":10803,"stargazers_count":28,"watchers_count":28,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":46,"open_issues":54,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/test-infra/pulls/541"},"html":{"href":"https://github.com/knative/test-infra/pull/541"},"issue":{"href":"https://api.github.com/repos/knative/test-infra/issues/541"},"comments":{"href":"https://api.github.com/repos/knative/test-infra/issues/541/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/test-infra/pulls/541/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/test-infra/pulls/541/commits"},"statuses":{"href":"https://api.github.com/repos/knative/test-infra/statuses/67743e414afb610b1de04a7e22527acdfca8ebed"}},"author_association":"CONTRIBUTOR"}}	{ "id": 136082371, "name": "knative/test-infra", "url": "https://api.github.com/repos/knative/test-infra" }	{ "id": 2238582, "login": "srinivashegde86", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/2238582?", "url": "https://api.github.com/users/srinivashegde86" }	{ "id": 35583233, "login": "knative", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/35583233?", "url": "https://api.github.com/orgs/knative" }	2019-03-04T21:39:53	9177985667	{"actor":{"display_login":"srinivashegde86"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/devopsloft/devopsloft/pulls/comments/252973711","pull_request_review_id":198976271,"id":252973711,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1Mjk3MzcxMQ==","diff_hunk":"@@ -57,7 +42,8 @@ Vagrant.configure(\"2\") do \|config\|\n \t\tstage.vm.box = \"dummy\"\n \t\tstage.vm.box_url = \"https://github.com/mitchellh/vagrant-aws/raw/master/dummy.box\"\n \t\tstage.vm.provision \"file\", source: \".\", destination: \"$HOME/devopsloft\"\n-\t\tstage.vm.provision :ansible do \|ansible\|\n+\t\tstage.vm.provision :ansible_local do \|ansible\|\n+\t\t\tansible.provisioning_path = \"/../home/ubuntu/devopsloft\"","path":"Vagrantfile","position":43,"original_position":43,"commit_id":"6c392de39cec14fac05fde5662b66949ccdbe6f6","original_commit_id":"6c392de39cec14fac05fde5662b66949ccdbe6f6","user":{"login":"ynixon","id":27818726,"node_id":"MDQ6VXNlcjI3ODE4NzI2","avatar_url":"https://avatars3.githubusercontent.com/u/27818726?v=4","gravatar_id":"","url":"https://api.github.com/users/ynixon","html_url":"https://github.com/ynixon","followers_url":"https://api.github.com/users/ynixon/followers","following_url":"https://api.github.com/users/ynixon/following{/other_user}","gists_url":"https://api.github.com/users/ynixon/gists{/gist_id}","starred_url":"https://api.github.com/users/ynixon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ynixon/subscriptions","organizations_url":"https://api.github.com/users/ynixon/orgs","repos_url":"https://api.github.com/users/ynixon/repos","events_url":"https://api.github.com/users/ynixon/events{/privacy}","received_events_url":"https://api.github.com/users/ynixon/received_events","type":"User","site_admin":false},"body":"yes, but it does not work, look at the output:\r\n```\r\n==> stage: Running provisioner: file...\r\n stage: C:/devopsloft/. => /home/ubuntu/devopsloft\r\n==> stage: Running provisioner: ansible_local...\r\n`playbook` does not exist on the guest: /$HOME/devopsloft/playbooks/bootstrap-infra.yml\r\n```","created_at":"2019-02-01T08:57:38Z","updated_at":"2019-02-01T08:57:38Z","html_url":"https://github.com/devopsloft/devopsloft/pull/160#discussion_r252973711","pull_request_url":"https://api.github.com/repos/devopsloft/devopsloft/pulls/160","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/devopsloft/devopsloft/pulls/comments/252973711"},"html":{"href":"https://github.com/devopsloft/devopsloft/pull/160#discussion_r252973711"},"pull_request":{"href":"https://api.github.com/repos/devopsloft/devopsloft/pulls/160"}},"in_reply_to_id":252801711},"pull_request":{"url":"https://api.github.com/repos/devopsloft/devopsloft/pulls/160","id":249268853,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ5MjY4ODUz","html_url":"https://github.com/devopsloft/devopsloft/pull/160","diff_url":"https://github.com/devopsloft/devopsloft/pull/160.diff","patch_url":"https://github.com/devopsloft/devopsloft/pull/160.patch","issue_url":"https://api.github.com/repos/devopsloft/devopsloft/issues/160","number":160,"state":"open","locked":false,"title":"moving to ansible_local - so windows hosts can privision without ansible","user":{"login":"ynixon","id":27818726,"node_id":"MDQ6VXNlcjI3ODE4NzI2","avatar_url":"https://avatars3.githubusercontent.com/u/27818726?v=4","gravatar_id":"","url":"https://api.github.com/users/ynixon","html_url":"https://github.com/ynixon","followers_url":"https://api.github.com/users/ynixon/followers","following_url":"https://api.github.com/users/ynixon/following{/other_user}","gists_url":"https://api.github.com/users/ynixon/gists{/gist_id}","starred_url":"https://api.github.com/users/ynixon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ynixon/subscriptions","organizations_url":"https://api.github.com/users/ynixon/orgs","repos_url":"https://api.github.com/users/ynixon/repos","events_url":"https://api.github.com/users/ynixon/events{/privacy}","received_events_url":"https://api.github.com/users/ynixon/received_events","type":"User","site_admin":false},"body":"#144 ","created_at":"2019-01-31T14:34:00Z","updated_at":"2019-02-01T08:57:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66b80ce843408d0cafe50ba6c8f86bc40132c4d3","assignee":{"login":"ynixon","id":27818726,"node_id":"MDQ6VXNlcjI3ODE4NzI2","avatar_url":"https://avatars3.githubusercontent.com/u/27818726?v=4","gravatar_id":"","url":"https://api.github.com/users/ynixon","html_url":"https://github.com/ynixon","followers_url":"https://api.github.com/users/ynixon/followers","following_url":"https://api.github.com/users/ynixon/following{/other_user}","gists_url":"https://api.github.com/users/ynixon/gists{/gist_id}","starred_url":"https://api.github.com/users/ynixon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ynixon/subscriptions","organizations_url":"https://api.github.com/users/ynixon/orgs","repos_url":"https://api.github.com/users/ynixon/repos","events_url":"https://api.github.com/users/ynixon/events{/privacy}","received_events_url":"https://api.github.com/users/ynixon/received_events","type":"User","site_admin":false},"assignees":[{"login":"ynixon","id":27818726,"node_id":"MDQ6VXNlcjI3ODE4NzI2","avatar_url":"https://avatars3.githubusercontent.com/u/27818726?v=4","gravatar_id":"","url":"https://api.github.com/users/ynixon","html_url":"https://github.com/ynixon","followers_url":"https://api.github.com/users/ynixon/followers","following_url":"https://api.github.com/users/ynixon/following{/other_user}","gists_url":"https://api.github.com/users/ynixon/gists{/gist_id}","starred_url":"https://api.github.com/users/ynixon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ynixon/subscriptions","organizations_url":"https://api.github.com/users/ynixon/orgs","repos_url":"https://api.github.com/users/ynixon/repos","events_url":"https://api.github.com/users/ynixon/events{/privacy}","received_events_url":"https://api.github.com/users/ynixon/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":816374394,"node_id":"MDU6TGFiZWw4MTYzNzQzOTQ=","url":"https://api.github.com/repos/devopsloft/devopsloft/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":{"url":"https://api.github.com/repos/devopsloft/devopsloft/milestones/13","html_url":"https://github.com/devopsloft/devopsloft/milestone/13","labels_url":"https://api.github.com/repos/devopsloft/devopsloft/milestones/13/labels","id":3962549,"node_id":"MDk6TWlsZXN0b25lMzk2MjU0OQ==","number":13,"title":"0.0.12","description":"","creator":{"login":"Balex3000","id":23415765,"node_id":"MDQ6VXNlcjIzNDE1NzY1","avatar_url":"https://avatars0.githubusercontent.com/u/23415765?v=4","gravatar_id":"","url":"https://api.github.com/users/Balex3000","html_url":"https://github.com/Balex3000","followers_url":"https://api.github.com/users/Balex3000/followers","following_url":"https://api.github.com/users/Balex3000/following{/other_user}","gists_url":"https://api.github.com/users/Balex3000/gists{/gist_id}","starred_url":"https://api.github.com/users/Balex3000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Balex3000/subscriptions","organizations_url":"https://api.github.com/users/Balex3000/orgs","repos_url":"https://api.github.com/users/Balex3000/repos","events_url":"https://api.github.com/users/Balex3000/events{/privacy}","received_events_url":"https://api.github.com/users/Balex3000/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":7,"state":"open","created_at":"2019-01-11T13:30:00Z","updated_at":"2019-02-01T05:01:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/devopsloft/devopsloft/pulls/160/commits","review_comments_url":"https://api.github.com/repos/devopsloft/devopsloft/pulls/160/comments","review_comment_url":"https://api.github.com/repos/devopsloft/devopsloft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/devopsloft/devopsloft/issues/160/comments","statuses_url":"https://api.github.com/repos/devopsloft/devopsloft/statuses/6c392de39cec14fac05fde5662b66949ccdbe6f6","head":{"label":"ynixon:ansible-local","ref":"ansible-local","sha":"6c392de39cec14fac05fde5662b66949ccdbe6f6","user":{"login":"ynixon","id":27818726,"node_id":"MDQ6VXNlcjI3ODE4NzI2","avatar_url":"https://avatars3.githubusercontent.com/u/27818726?v=4","gravatar_id":"","url":"https://api.github.com/users/ynixon","html_url":"https://github.com/ynixon","followers_url":"https://api.github.com/users/ynixon/followers","following_url":"https://api.github.com/users/ynixon/following{/other_user}","gists_url":"https://api.github.com/users/ynixon/gists{/gist_id}","starred_url":"https://api.github.com/users/ynixon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ynixon/subscriptions","organizations_url":"https://api.github.com/users/ynixon/orgs","repos_url":"https://api.github.com/users/ynixon/repos","events_url":"https://api.github.com/users/ynixon/events{/privacy}","received_events_url":"https://api.github.com/users/ynixon/received_events","type":"User","site_admin":false},"repo":{"id":163203717,"node_id":"MDEwOlJlcG9zaXRvcnkxNjMyMDM3MTc=","name":"devopsloft","full_name":"ynixon/devopsloft","private":false,"owner":{"login":"ynixon","id":27818726,"node_id":"MDQ6VXNlcjI3ODE4NzI2","avatar_url":"https://avatars3.githubusercontent.com/u/27818726?v=4","gravatar_id":"","url":"https://api.github.com/users/ynixon","html_url":"https://github.com/ynixon","followers_url":"https://api.github.com/users/ynixon/followers","following_url":"https://api.github.com/users/ynixon/following{/other_user}","gists_url":"https://api.github.com/users/ynixon/gists{/gist_id}","starred_url":"https://api.github.com/users/ynixon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ynixon/subscriptions","organizations_url":"https://api.github.com/users/ynixon/orgs","repos_url":"https://api.github.com/users/ynixon/repos","events_url":"https://api.github.com/users/ynixon/events{/privacy}","received_events_url":"https://api.github.com/users/ynixon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ynixon/devopsloft","description":"Drive our Career Path into DevOps - This application is developed by the DevOps Loft community https://www.facebook.com/devopsloft/","fork":true,"url":"https://api.github.com/repos/ynixon/devopsloft","forks_url":"https://api.github.com/repos/ynixon/devopsloft/forks","keys_url":"https://api.github.com/repos/ynixon/devopsloft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ynixon/devopsloft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ynixon/devopsloft/teams","hooks_url":"https://api.github.com/repos/ynixon/devopsloft/hooks","issue_events_url":"https://api.github.com/repos/ynixon/devopsloft/issues/events{/number}","events_url":"https://api.github.com/repos/ynixon/devopsloft/events","assignees_url":"https://api.github.com/repos/ynixon/devopsloft/assignees{/user}","branches_url":"https://api.github.com/repos/ynixon/devopsloft/branches{/branch}","tags_url":"https://api.github.com/repos/ynixon/devopsloft/tags","blobs_url":"https://api.github.com/repos/ynixon/devopsloft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ynixon/devopsloft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ynixon/devopsloft/git/refs{/sha}","trees_url":"https://api.github.com/repos/ynixon/devopsloft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ynixon/devopsloft/statuses/{sha}","languages_url":"https://api.github.com/repos/ynixon/devopsloft/languages","stargazers_url":"https://api.github.com/repos/ynixon/devopsloft/stargazers","contributors_url":"https://api.github.com/repos/ynixon/devopsloft/contributors","subscribers_url":"https://api.github.com/repos/ynixon/devopsloft/subscribers","subscription_url":"https://api.github.com/repos/ynixon/devopsloft/subscription","commits_url":"https://api.github.com/repos/ynixon/devopsloft/commits{/sha}","git_commits_url":"https://api.github.com/repos/ynixon/devopsloft/git/commits{/sha}","comments_url":"https://api.github.com/repos/ynixon/devopsloft/comments{/number}","issue_comment_url":"https://api.github.com/repos/ynixon/devopsloft/issues/comments{/number}","contents_url":"https://api.github.com/repos/ynixon/devopsloft/contents/{+path}","compare_url":"https://api.github.com/repos/ynixon/devopsloft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ynixon/devopsloft/merges","archive_url":"https://api.github.com/repos/ynixon/devopsloft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ynixon/devopsloft/downloads","issues_url":"https://api.github.com/repos/ynixon/devopsloft/issues{/number}","pulls_url":"https://api.github.com/repos/ynixon/devopsloft/pulls{/number}","milestones_url":"https://api.github.com/repos/ynixon/devopsloft/milestones{/number}","notifications_url":"https://api.github.com/repos/ynixon/devopsloft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ynixon/devopsloft/labels{/name}","releases_url":"https://api.github.com/repos/ynixon/devopsloft/releases{/id}","deployments_url":"https://api.github.com/repos/ynixon/devopsloft/deployments","created_at":"2018-12-26T17:42:20Z","updated_at":"2019-01-31T14:26:48Z","pushed_at":"2019-01-31T14:32:18Z","git_url":"git://github.com/ynixon/devopsloft.git","ssh_url":"[email protected]:ynixon/devopsloft.git","clone_url":"https://github.com/ynixon/devopsloft.git","svn_url":"https://github.com/ynixon/devopsloft","homepage":"https://www.devopsloft.io","size":744,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"devopsloft:master","ref":"master","sha":"21d32aa4a0d3d84dda054a25bcd0336ebf15958f","user":{"login":"devopsloft","id":35807698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1ODA3Njk4","avatar_url":"https://avatars0.githubusercontent.com/u/35807698?v=4","gravatar_id":"","url":"https://api.github.com/users/devopsloft","html_url":"https://github.com/devopsloft","followers_url":"https://api.github.com/users/devopsloft/followers","following_url":"https://api.github.com/users/devopsloft/following{/other_user}","gists_url":"https://api.github.com/users/devopsloft/gists{/gist_id}","starred_url":"https://api.github.com/users/devopsloft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devopsloft/subscriptions","organizations_url":"https://api.github.com/users/devopsloft/orgs","repos_url":"https://api.github.com/users/devopsloft/repos","events_url":"https://api.github.com/users/devopsloft/events{/privacy}","received_events_url":"https://api.github.com/users/devopsloft/received_events","type":"Organization","site_admin":false},"repo":{"id":118925221,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg5MjUyMjE=","name":"devopsloft","full_name":"devopsloft/devopsloft","private":false,"owner":{"login":"devopsloft","id":35807698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1ODA3Njk4","avatar_url":"https://avatars0.githubusercontent.com/u/35807698?v=4","gravatar_id":"","url":"https://api.github.com/users/devopsloft","html_url":"https://github.com/devopsloft","followers_url":"https://api.github.com/users/devopsloft/followers","following_url":"https://api.github.com/users/devopsloft/following{/other_user}","gists_url":"https://api.github.com/users/devopsloft/gists{/gist_id}","starred_url":"https://api.github.com/users/devopsloft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devopsloft/subscriptions","organizations_url":"https://api.github.com/users/devopsloft/orgs","repos_url":"https://api.github.com/users/devopsloft/repos","events_url":"https://api.github.com/users/devopsloft/events{/privacy}","received_events_url":"https://api.github.com/users/devopsloft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/devopsloft/devopsloft","description":"Drive our Career Path into DevOps - This application is developed by the DevOps Loft community https://www.facebook.com/devopsloft/","fork":false,"url":"https://api.github.com/repos/devopsloft/devopsloft","forks_url":"https://api.github.com/repos/devopsloft/devopsloft/forks","keys_url":"https://api.github.com/repos/devopsloft/devopsloft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devopsloft/devopsloft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devopsloft/devopsloft/teams","hooks_url":"https://api.github.com/repos/devopsloft/devopsloft/hooks","issue_events_url":"https://api.github.com/repos/devopsloft/devopsloft/issues/events{/number}","events_url":"https://api.github.com/repos/devopsloft/devopsloft/events","assignees_url":"https://api.github.com/repos/devopsloft/devopsloft/assignees{/user}","branches_url":"https://api.github.com/repos/devopsloft/devopsloft/branches{/branch}","tags_url":"https://api.github.com/repos/devopsloft/devopsloft/tags","blobs_url":"https://api.github.com/repos/devopsloft/devopsloft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devopsloft/devopsloft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devopsloft/devopsloft/git/refs{/sha}","trees_url":"https://api.github.com/repos/devopsloft/devopsloft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devopsloft/devopsloft/statuses/{sha}","languages_url":"https://api.github.com/repos/devopsloft/devopsloft/languages","stargazers_url":"https://api.github.com/repos/devopsloft/devopsloft/stargazers","contributors_url":"https://api.github.com/repos/devopsloft/devopsloft/contributors","subscribers_url":"https://api.github.com/repos/devopsloft/devopsloft/subscribers","subscription_url":"https://api.github.com/repos/devopsloft/devopsloft/subscription","commits_url":"https://api.github.com/repos/devopsloft/devopsloft/commits{/sha}","git_commits_url":"https://api.github.com/repos/devopsloft/devopsloft/git/commits{/sha}","comments_url":"https://api.github.com/repos/devopsloft/devopsloft/comments{/number}","issue_comment_url":"https://api.github.com/repos/devopsloft/devopsloft/issues/comments{/number}","contents_url":"https://api.github.com/repos/devopsloft/devopsloft/contents/{+path}","compare_url":"https://api.github.com/repos/devopsloft/devopsloft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devopsloft/devopsloft/merges","archive_url":"https://api.github.com/repos/devopsloft/devopsloft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devopsloft/devopsloft/downloads","issues_url":"https://api.github.com/repos/devopsloft/devopsloft/issues{/number}","pulls_url":"https://api.github.com/repos/devopsloft/devopsloft/pulls{/number}","milestones_url":"https://api.github.com/repos/devopsloft/devopsloft/milestones{/number}","notifications_url":"https://api.github.com/repos/devopsloft/devopsloft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devopsloft/devopsloft/labels{/name}","releases_url":"https://api.github.com/repos/devopsloft/devopsloft/releases{/id}","deployments_url":"https://api.github.com/repos/devopsloft/devopsloft/deployments","created_at":"2018-01-25T14:44:54Z","updated_at":"2019-01-30T17:40:34Z","pushed_at":"2019-01-31T18:37:55Z","git_url":"git://github.com/devopsloft/devopsloft.git","ssh_url":"[email protected]:devopsloft/devopsloft.git","clone_url":"https://github.com/devopsloft/devopsloft.git","svn_url":"https://github.com/devopsloft/devopsloft","homepage":"https://www.devopsloft.io","size":740,"stargazers_count":12,"watchers_count":12,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":70,"license":null,"forks":61,"open_issues":70,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/devopsloft/devopsloft/pulls/160"},"html":{"href":"https://github.com/devopsloft/devopsloft/pull/160"},"issue":{"href":"https://api.github.com/repos/devopsloft/devopsloft/issues/160"},"comments":{"href":"https://api.github.com/repos/devopsloft/devopsloft/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/devopsloft/devopsloft/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/devopsloft/devopsloft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/devopsloft/devopsloft/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/devopsloft/devopsloft/statuses/6c392de39cec14fac05fde5662b66949ccdbe6f6"}},"author_association":"NONE"}}	{ "id": 118925221, "name": "devopsloft/devopsloft", "url": "https://api.github.com/repos/devopsloft/devopsloft" }	{ "id": 27818726, "login": "ynixon", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/27818726?", "url": "https://api.github.com/users/ynixon" }	{ "id": 35807698, "login": "devopsloft", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/35807698?", "url": "https://api.github.com/orgs/devopsloft" }	2019-02-01T08:57:38	8991304260	{"actor":{"display_login":"ynixon"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/openeuropa/oe_content/pulls/comments/346785091","pull_request_review_id":317566797,"id":346785091,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0Njc4NTA5MQ==","diff_hunk":"@@ -109,11 +109,21 @@ public function process($text, $langcode) {\n continue;\n }\n \n+ // If an anchor is set on the source url, we extract it here.\n+ $anchor = '';\n+ if (strpos($href, '#') !== FALSE) {\n+ $explodedHref = explode('#', $href);\n+ if (isset($explodedHref[1]) && !empty($explodedHref[1])) {","path":"modules/oe_content_persistent/src/Plugin/Filter/FilterPurl.php","position":8,"original_position":8,"commit_id":"197b5a38bc069d0b93f16513290ff3cf865e207d","original_commit_id":"197b5a38bc069d0b93f16513290ff3cf865e207d","user":{"login":"haringsrob","id":866743,"node_id":"MDQ6VXNlcjg2Njc0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/866743?v=4","gravatar_id":"","url":"https://api.github.com/users/haringsrob","html_url":"https://github.com/haringsrob","followers_url":"https://api.github.com/users/haringsrob/followers","following_url":"https://api.github.com/users/haringsrob/following{/other_user}","gists_url":"https://api.github.com/users/haringsrob/gists{/gist_id}","starred_url":"https://api.github.com/users/haringsrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haringsrob/subscriptions","organizations_url":"https://api.github.com/users/haringsrob/orgs","repos_url":"https://api.github.com/users/haringsrob/repos","events_url":"https://api.github.com/users/haringsrob/events{/privacy}","received_events_url":"https://api.github.com/users/haringsrob/received_events","type":"User","site_admin":false},"body":"I think isset can be replaced by empty, but I know I had some issues with this in the past. So for safety I included both.","created_at":"2019-11-15T11:42:06Z","updated_at":"2019-11-15T11:42:57Z","html_url":"https://github.com/openeuropa/oe_content/pull/136#discussion_r346785091","pull_request_url":"https://api.github.com/repos/openeuropa/oe_content/pulls/136","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openeuropa/oe_content/pulls/comments/346785091"},"html":{"href":"https://github.com/openeuropa/oe_content/pull/136#discussion_r346785091"},"pull_request":{"href":"https://api.github.com/repos/openeuropa/oe_content/pulls/136"}}},"pull_request":{"url":"https://api.github.com/repos/openeuropa/oe_content/pulls/136","id":341429407,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQxNDI5NDA3","html_url":"https://github.com/openeuropa/oe_content/pull/136","diff_url":"https://github.com/openeuropa/oe_content/pull/136.diff","patch_url":"https://github.com/openeuropa/oe_content/pull/136.patch","issue_url":"https://api.github.com/repos/openeuropa/oe_content/issues/136","number":136,"state":"open","locked":false,"title":"Extract and reuse anchor.","user":{"login":"haringsrob","id":866743,"node_id":"MDQ6VXNlcjg2Njc0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/866743?v=4","gravatar_id":"","url":"https://api.github.com/users/haringsrob","html_url":"https://github.com/haringsrob","followers_url":"https://api.github.com/users/haringsrob/followers","following_url":"https://api.github.com/users/haringsrob/following{/other_user}","gists_url":"https://api.github.com/users/haringsrob/gists{/gist_id}","starred_url":"https://api.github.com/users/haringsrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haringsrob/subscriptions","organizations_url":"https://api.github.com/users/haringsrob/orgs","repos_url":"https://api.github.com/users/haringsrob/repos","events_url":"https://api.github.com/users/haringsrob/events{/privacy}","received_events_url":"https://api.github.com/users/haringsrob/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nCurrently anchors are removed from the new url. This change reuses it.\r\n\r\n","created_at":"2019-11-15T11:41:27Z","updated_at":"2019-11-15T11:42:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad5c9abeaf0499af48233920e0eb1aa7c888a26d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openeuropa/oe_content/pulls/136/commits","review_comments_url":"https://api.github.com/repos/openeuropa/oe_content/pulls/136/comments","review_comment_url":"https://api.github.com/repos/openeuropa/oe_content/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openeuropa/oe_content/issues/136/comments","statuses_url":"https://api.github.com/repos/openeuropa/oe_content/statuses/197b5a38bc069d0b93f16513290ff3cf865e207d","head":{"label":"haringsrob:link-anchors","ref":"link-anchors","sha":"197b5a38bc069d0b93f16513290ff3cf865e207d","user":{"login":"haringsrob","id":866743,"node_id":"MDQ6VXNlcjg2Njc0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/866743?v=4","gravatar_id":"","url":"https://api.github.com/users/haringsrob","html_url":"https://github.com/haringsrob","followers_url":"https://api.github.com/users/haringsrob/followers","following_url":"https://api.github.com/users/haringsrob/following{/other_user}","gists_url":"https://api.github.com/users/haringsrob/gists{/gist_id}","starred_url":"https://api.github.com/users/haringsrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haringsrob/subscriptions","organizations_url":"https://api.github.com/users/haringsrob/orgs","repos_url":"https://api.github.com/users/haringsrob/repos","events_url":"https://api.github.com/users/haringsrob/events{/privacy}","received_events_url":"https://api.github.com/users/haringsrob/received_events","type":"User","site_admin":false},"repo":{"id":193900551,"node_id":"MDEwOlJlcG9zaXRvcnkxOTM5MDA1NTE=","name":"oe_content","full_name":"haringsrob/oe_content","private":false,"owner":{"login":"haringsrob","id":866743,"node_id":"MDQ6VXNlcjg2Njc0Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/866743?v=4","gravatar_id":"","url":"https://api.github.com/users/haringsrob","html_url":"https://github.com/haringsrob","followers_url":"https://api.github.com/users/haringsrob/followers","following_url":"https://api.github.com/users/haringsrob/following{/other_user}","gists_url":"https://api.github.com/users/haringsrob/gists{/gist_id}","starred_url":"https://api.github.com/users/haringsrob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haringsrob/subscriptions","organizations_url":"https://api.github.com/users/haringsrob/orgs","repos_url":"https://api.github.com/users/haringsrob/repos","events_url":"https://api.github.com/users/haringsrob/events{/privacy}","received_events_url":"https://api.github.com/users/haringsrob/received_events","type":"User","site_admin":false},"html_url":"https://github.com/haringsrob/oe_content","description":"Drupal module that contains the corporate entity types in Drupal.","fork":true,"url":"https://api.github.com/repos/haringsrob/oe_content","forks_url":"https://api.github.com/repos/haringsrob/oe_content/forks","keys_url":"https://api.github.com/repos/haringsrob/oe_content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haringsrob/oe_content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haringsrob/oe_content/teams","hooks_url":"https://api.github.com/repos/haringsrob/oe_content/hooks","issue_events_url":"https://api.github.com/repos/haringsrob/oe_content/issues/events{/number}","events_url":"https://api.github.com/repos/haringsrob/oe_content/events","assignees_url":"https://api.github.com/repos/haringsrob/oe_content/assignees{/user}","branches_url":"https://api.github.com/repos/haringsrob/oe_content/branches{/branch}","tags_url":"https://api.github.com/repos/haringsrob/oe_content/tags","blobs_url":"https://api.github.com/repos/haringsrob/oe_content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haringsrob/oe_content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haringsrob/oe_content/git/refs{/sha}","trees_url":"https://api.github.com/repos/haringsrob/oe_content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haringsrob/oe_content/statuses/{sha}","languages_url":"https://api.github.com/repos/haringsrob/oe_content/languages","stargazers_url":"https://api.github.com/repos/haringsrob/oe_content/stargazers","contributors_url":"https://api.github.com/repos/haringsrob/oe_content/contributors","subscribers_url":"https://api.github.com/repos/haringsrob/oe_content/subscribers","subscription_url":"https://api.github.com/repos/haringsrob/oe_content/subscription","commits_url":"https://api.github.com/repos/haringsrob/oe_content/commits{/sha}","git_commits_url":"https://api.github.com/repos/haringsrob/oe_content/git/commits{/sha}","comments_url":"https://api.github.com/repos/haringsrob/oe_content/comments{/number}","issue_comment_url":"https://api.github.com/repos/haringsrob/oe_content/issues/comments{/number}","contents_url":"https://api.github.com/repos/haringsrob/oe_content/contents/{+path}","compare_url":"https://api.github.com/repos/haringsrob/oe_content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haringsrob/oe_content/merges","archive_url":"https://api.github.com/repos/haringsrob/oe_content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haringsrob/oe_content/downloads","issues_url":"https://api.github.com/repos/haringsrob/oe_content/issues{/number}","pulls_url":"https://api.github.com/repos/haringsrob/oe_content/pulls{/number}","milestones_url":"https://api.github.com/repos/haringsrob/oe_content/milestones{/number}","notifications_url":"https://api.github.com/repos/haringsrob/oe_content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haringsrob/oe_content/labels{/name}","releases_url":"https://api.github.com/repos/haringsrob/oe_content/releases{/id}","deployments_url":"https://api.github.com/repos/haringsrob/oe_content/deployments","created_at":"2019-06-26T12:31:49Z","updated_at":"2019-06-26T12:32:56Z","pushed_at":"2019-11-15T11:40:42Z","git_url":"git://github.com/haringsrob/oe_content.git","ssh_url":"[email protected]:haringsrob/oe_content.git","clone_url":"https://github.com/haringsrob/oe_content.git","svn_url":"https://github.com/haringsrob/oe_content","homepage":null,"size":376,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openeuropa:master","ref":"master","sha":"aa9c35173961dac2251cba716fbcf3084e781562","user":{"login":"openeuropa","id":35874187,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1ODc0MTg3","avatar_url":"https://avatars0.githubusercontent.com/u/35874187?v=4","gravatar_id":"","url":"https://api.github.com/users/openeuropa","html_url":"https://github.com/openeuropa","followers_url":"https://api.github.com/users/openeuropa/followers","following_url":"https://api.github.com/users/openeuropa/following{/other_user}","gists_url":"https://api.github.com/users/openeuropa/gists{/gist_id}","starred_url":"https://api.github.com/users/openeuropa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openeuropa/subscriptions","organizations_url":"https://api.github.com/users/openeuropa/orgs","repos_url":"https://api.github.com/users/openeuropa/repos","events_url":"https://api.github.com/users/openeuropa/events{/privacy}","received_events_url":"https://api.github.com/users/openeuropa/received_events","type":"Organization","site_admin":false},"repo":{"id":143298557,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyOTg1NTc=","name":"oe_content","full_name":"openeuropa/oe_content","private":false,"owner":{"login":"openeuropa","id":35874187,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1ODc0MTg3","avatar_url":"https://avatars0.githubusercontent.com/u/35874187?v=4","gravatar_id":"","url":"https://api.github.com/users/openeuropa","html_url":"https://github.com/openeuropa","followers_url":"https://api.github.com/users/openeuropa/followers","following_url":"https://api.github.com/users/openeuropa/following{/other_user}","gists_url":"https://api.github.com/users/openeuropa/gists{/gist_id}","starred_url":"https://api.github.com/users/openeuropa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openeuropa/subscriptions","organizations_url":"https://api.github.com/users/openeuropa/orgs","repos_url":"https://api.github.com/users/openeuropa/repos","events_url":"https://api.github.com/users/openeuropa/events{/privacy}","received_events_url":"https://api.github.com/users/openeuropa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openeuropa/oe_content","description":"Drupal module that contains the corporate entity types in Drupal.","fork":false,"url":"https://api.github.com/repos/openeuropa/oe_content","forks_url":"https://api.github.com/repos/openeuropa/oe_content/forks","keys_url":"https://api.github.com/repos/openeuropa/oe_content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openeuropa/oe_content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openeuropa/oe_content/teams","hooks_url":"https://api.github.com/repos/openeuropa/oe_content/hooks","issue_events_url":"https://api.github.com/repos/openeuropa/oe_content/issues/events{/number}","events_url":"https://api.github.com/repos/openeuropa/oe_content/events","assignees_url":"https://api.github.com/repos/openeuropa/oe_content/assignees{/user}","branches_url":"https://api.github.com/repos/openeuropa/oe_content/branches{/branch}","tags_url":"https://api.github.com/repos/openeuropa/oe_content/tags","blobs_url":"https://api.github.com/repos/openeuropa/oe_content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openeuropa/oe_content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openeuropa/oe_content/git/refs{/sha}","trees_url":"https://api.github.com/repos/openeuropa/oe_content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openeuropa/oe_content/statuses/{sha}","languages_url":"https://api.github.com/repos/openeuropa/oe_content/languages","stargazers_url":"https://api.github.com/repos/openeuropa/oe_content/stargazers","contributors_url":"https://api.github.com/repos/openeuropa/oe_content/contributors","subscribers_url":"https://api.github.com/repos/openeuropa/oe_content/subscribers","subscription_url":"https://api.github.com/repos/openeuropa/oe_content/subscription","commits_url":"https://api.github.com/repos/openeuropa/oe_content/commits{/sha}","git_commits_url":"https://api.github.com/repos/openeuropa/oe_content/git/commits{/sha}","comments_url":"https://api.github.com/repos/openeuropa/oe_content/comments{/number}","issue_comment_url":"https://api.github.com/repos/openeuropa/oe_content/issues/comments{/number}","contents_url":"https://api.github.com/repos/openeuropa/oe_content/contents/{+path}","compare_url":"https://api.github.com/repos/openeuropa/oe_content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openeuropa/oe_content/merges","archive_url":"https://api.github.com/repos/openeuropa/oe_content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openeuropa/oe_content/downloads","issues_url":"https://api.github.com/repos/openeuropa/oe_content/issues{/number}","pulls_url":"https://api.github.com/repos/openeuropa/oe_content/pulls{/number}","milestones_url":"https://api.github.com/repos/openeuropa/oe_content/milestones{/number}","notifications_url":"https://api.github.com/repos/openeuropa/oe_content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openeuropa/oe_content/labels{/name}","releases_url":"https://api.github.com/repos/openeuropa/oe_content/releases{/id}","deployments_url":"https://api.github.com/repos/openeuropa/oe_content/deployments","created_at":"2018-08-02T13:29:12Z","updated_at":"2019-11-14T12:06:46Z","pushed_at":"2019-11-15T11:41:28Z","git_url":"git://github.com/openeuropa/oe_content.git","ssh_url":"[email protected]:openeuropa/oe_content.git","clone_url":"https://github.com/openeuropa/oe_content.git","svn_url":"https://github.com/openeuropa/oe_content","homepage":null,"size":650,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openeuropa/oe_content/pulls/136"},"html":{"href":"https://github.com/openeuropa/oe_content/pull/136"},"issue":{"href":"https://api.github.com/repos/openeuropa/oe_content/issues/136"},"comments":{"href":"https://api.github.com/repos/openeuropa/oe_content/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/openeuropa/oe_content/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/openeuropa/oe_content/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openeuropa/oe_content/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/openeuropa/oe_content/statuses/197b5a38bc069d0b93f16513290ff3cf865e207d"}},"author_association":"NONE"}}	{ "id": 143298557, "name": "openeuropa/oe_content", "url": "https://api.github.com/repos/openeuropa/oe_content" }	{ "id": 866743, "login": "haringsrob", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/866743?", "url": "https://api.github.com/users/haringsrob" }	{ "id": 35874187, "login": "openeuropa", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/35874187?", "url": "https://api.github.com/orgs/openeuropa" }	2019-11-15T11:42:06	10871205854	{"actor":{"display_login":"haringsrob"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/pulls/comments/341111253","pull_request_review_id":309844431,"id":341111253,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MTExMTI1Mw==","diff_hunk":"@@ -109,9 +129,10 @@ unit_tested:\n For the \"fix\" answer below, check if the fix for the vulnerability involves\n adding or improving an automated test to ensure this doesn't happen again.\n Must be just \"true\" or \"false\".\n- answer:\n- code:\n- fix:\n+ answer: no unit test found","path":"cves/CVE-2015-5351.yml","position":131,"original_position":131,"commit_id":"56073ee873ac4610ef9cdac9c08da87f8bae3e47","original_commit_id":"56073ee873ac4610ef9cdac9c08da87f8bae3e47","user":{"login":"heartemoji","id":18746512,"node_id":"MDQ6VXNlcjE4NzQ2NTEy","avatar_url":"https://avatars2.githubusercontent.com/u/18746512?v=4","gravatar_id":"","url":"https://api.github.com/users/heartemoji","html_url":"https://github.com/heartemoji","followers_url":"https://api.github.com/users/heartemoji/followers","following_url":"https://api.github.com/users/heartemoji/following{/other_user}","gists_url":"https://api.github.com/users/heartemoji/gists{/gist_id}","starred_url":"https://api.github.com/users/heartemoji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heartemoji/subscriptions","organizations_url":"https://api.github.com/users/heartemoji/orgs","repos_url":"https://api.github.com/users/heartemoji/repos","events_url":"https://api.github.com/users/heartemoji/events{/privacy}","received_events_url":"https://api.github.com/users/heartemoji/received_events","type":"User","site_admin":false},"body":"It might be a good idea to list the places that you looked for evidence of unit tests in case someone in the future wants to do a bit more research.","created_at":"2019-10-31T12:35:12Z","updated_at":"2019-10-31T12:35:12Z","html_url":"https://github.com/VulnerabilityHistoryProject/tomcat-vulnerabilities/pull/51#discussion_r341111253","pull_request_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/pulls/51","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/pulls/comments/341111253"},"html":{"href":"https://github.com/VulnerabilityHistoryProject/tomcat-vulnerabilities/pull/51#discussion_r341111253"},"pull_request":{"href":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/pulls/51","id":332381725,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMyMzgxNzI1","html_url":"https://github.com/VulnerabilityHistoryProject/tomcat-vulnerabilities/pull/51","diff_url":"https://github.com/VulnerabilityHistoryProject/tomcat-vulnerabilities/pull/51.diff","patch_url":"https://github.com/VulnerabilityHistoryProject/tomcat-vulnerabilities/pull/51.patch","issue_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/issues/51","number":51,"state":"open","locked":false,"title":"CVE-2015-5351","user":{"login":"etiano417","id":23348516,"node_id":"MDQ6VXNlcjIzMzQ4NTE2","avatar_url":"https://avatars2.githubusercontent.com/u/23348516?v=4","gravatar_id":"","url":"https://api.github.com/users/etiano417","html_url":"https://github.com/etiano417","followers_url":"https://api.github.com/users/etiano417/followers","following_url":"https://api.github.com/users/etiano417/following{/other_user}","gists_url":"https://api.github.com/users/etiano417/gists{/gist_id}","starred_url":"https://api.github.com/users/etiano417/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etiano417/subscriptions","organizations_url":"https://api.github.com/users/etiano417/orgs","repos_url":"https://api.github.com/users/etiano417/repos","events_url":"https://api.github.com/users/etiano417/events{/privacy}","received_events_url":"https://api.github.com/users/etiano417/received_events","type":"User","site_admin":false},"body":" - Added curated content to CVE-2015-5351.yml fields\r\n - Fixed announced date","created_at":"2019-10-25T07:39:25Z","updated_at":"2019-10-31T12:35:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e52f6c8a6dfc488959861765248dd76fb89a3f2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1285465928,"node_id":"MDU6TGFiZWwxMjg1NDY1OTI4","url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/labels/Cohort%20J","name":"Cohort J","color":"94f7b0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/pulls/51/commits","review_comments_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/pulls/51/comments","review_comment_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/issues/51/comments","statuses_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/statuses/56073ee873ac4610ef9cdac9c08da87f8bae3e47","head":{"label":"etiano417:dev","ref":"dev","sha":"56073ee873ac4610ef9cdac9c08da87f8bae3e47","user":{"login":"etiano417","id":23348516,"node_id":"MDQ6VXNlcjIzMzQ4NTE2","avatar_url":"https://avatars2.githubusercontent.com/u/23348516?v=4","gravatar_id":"","url":"https://api.github.com/users/etiano417","html_url":"https://github.com/etiano417","followers_url":"https://api.github.com/users/etiano417/followers","following_url":"https://api.github.com/users/etiano417/following{/other_user}","gists_url":"https://api.github.com/users/etiano417/gists{/gist_id}","starred_url":"https://api.github.com/users/etiano417/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etiano417/subscriptions","organizations_url":"https://api.github.com/users/etiano417/orgs","repos_url":"https://api.github.com/users/etiano417/repos","events_url":"https://api.github.com/users/etiano417/events{/privacy}","received_events_url":"https://api.github.com/users/etiano417/received_events","type":"User","site_admin":false},"repo":{"id":216136801,"node_id":"MDEwOlJlcG9zaXRvcnkyMTYxMzY4MDE=","name":"tomcat-vulnerabilities","full_name":"etiano417/tomcat-vulnerabilities","private":false,"owner":{"login":"etiano417","id":23348516,"node_id":"MDQ6VXNlcjIzMzQ4NTE2","avatar_url":"https://avatars2.githubusercontent.com/u/23348516?v=4","gravatar_id":"","url":"https://api.github.com/users/etiano417","html_url":"https://github.com/etiano417","followers_url":"https://api.github.com/users/etiano417/followers","following_url":"https://api.github.com/users/etiano417/following{/other_user}","gists_url":"https://api.github.com/users/etiano417/gists{/gist_id}","starred_url":"https://api.github.com/users/etiano417/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etiano417/subscriptions","organizations_url":"https://api.github.com/users/etiano417/orgs","repos_url":"https://api.github.com/users/etiano417/repos","events_url":"https://api.github.com/users/etiano417/events{/privacy}","received_events_url":"https://api.github.com/users/etiano417/received_events","type":"User","site_admin":false},"html_url":"https://github.com/etiano417/tomcat-vulnerabilities","description":"Curated vulnerability data for vulnerabilityhistory.org","fork":true,"url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities","forks_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/forks","keys_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/teams","hooks_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/hooks","issue_events_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/issues/events{/number}","events_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/events","assignees_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/assignees{/user}","branches_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/branches{/branch}","tags_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/tags","blobs_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/git/refs{/sha}","trees_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/statuses/{sha}","languages_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/languages","stargazers_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/stargazers","contributors_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/contributors","subscribers_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/subscribers","subscription_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/subscription","commits_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/commits{/sha}","git_commits_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/git/commits{/sha}","comments_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/comments{/number}","issue_comment_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/issues/comments{/number}","contents_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/contents/{+path}","compare_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/merges","archive_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/downloads","issues_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/issues{/number}","pulls_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/pulls{/number}","milestones_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/milestones{/number}","notifications_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/labels{/name}","releases_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/releases{/id}","deployments_url":"https://api.github.com/repos/etiano417/tomcat-vulnerabilities/deployments","created_at":"2019-10-19T02:16:19Z","updated_at":"2019-10-19T02:16:20Z","pushed_at":"2019-10-25T08:23:46Z","git_url":"git://github.com/etiano417/tomcat-vulnerabilities.git","ssh_url":"[email protected]:etiano417/tomcat-vulnerabilities.git","clone_url":"https://github.com/etiano417/tomcat-vulnerabilities.git","svn_url":"https://github.com/etiano417/tomcat-vulnerabilities","homepage":null,"size":1519,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"VulnerabilityHistoryProject:dev","ref":"dev","sha":"55f2976d0b7e27ecbc6371c6105d06b6782bf84c","user":{"login":"VulnerabilityHistoryProject","id":35928658,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1OTI4NjU4","avatar_url":"https://avatars3.githubusercontent.com/u/35928658?v=4","gravatar_id":"","url":"https://api.github.com/users/VulnerabilityHistoryProject","html_url":"https://github.com/VulnerabilityHistoryProject","followers_url":"https://api.github.com/users/VulnerabilityHistoryProject/followers","following_url":"https://api.github.com/users/VulnerabilityHistoryProject/following{/other_user}","gists_url":"https://api.github.com/users/VulnerabilityHistoryProject/gists{/gist_id}","starred_url":"https://api.github.com/users/VulnerabilityHistoryProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VulnerabilityHistoryProject/subscriptions","organizations_url":"https://api.github.com/users/VulnerabilityHistoryProject/orgs","repos_url":"https://api.github.com/users/VulnerabilityHistoryProject/repos","events_url":"https://api.github.com/users/VulnerabilityHistoryProject/events{/privacy}","received_events_url":"https://api.github.com/users/VulnerabilityHistoryProject/received_events","type":"Organization","site_admin":false},"repo":{"id":166920755,"node_id":"MDEwOlJlcG9zaXRvcnkxNjY5MjA3NTU=","name":"tomcat-vulnerabilities","full_name":"VulnerabilityHistoryProject/tomcat-vulnerabilities","private":false,"owner":{"login":"VulnerabilityHistoryProject","id":35928658,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1OTI4NjU4","avatar_url":"https://avatars3.githubusercontent.com/u/35928658?v=4","gravatar_id":"","url":"https://api.github.com/users/VulnerabilityHistoryProject","html_url":"https://github.com/VulnerabilityHistoryProject","followers_url":"https://api.github.com/users/VulnerabilityHistoryProject/followers","following_url":"https://api.github.com/users/VulnerabilityHistoryProject/following{/other_user}","gists_url":"https://api.github.com/users/VulnerabilityHistoryProject/gists{/gist_id}","starred_url":"https://api.github.com/users/VulnerabilityHistoryProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VulnerabilityHistoryProject/subscriptions","organizations_url":"https://api.github.com/users/VulnerabilityHistoryProject/orgs","repos_url":"https://api.github.com/users/VulnerabilityHistoryProject/repos","events_url":"https://api.github.com/users/VulnerabilityHistoryProject/events{/privacy}","received_events_url":"https://api.github.com/users/VulnerabilityHistoryProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/VulnerabilityHistoryProject/tomcat-vulnerabilities","description":"Curated vulnerability data for vulnerabilityhistory.org","fork":false,"url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities","forks_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/forks","keys_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/teams","hooks_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/hooks","issue_events_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/issues/events{/number}","events_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/events","assignees_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/assignees{/user}","branches_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/branches{/branch}","tags_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/tags","blobs_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/git/refs{/sha}","trees_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/statuses/{sha}","languages_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/languages","stargazers_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/stargazers","contributors_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/contributors","subscribers_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/subscribers","subscription_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/subscription","commits_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/commits{/sha}","git_commits_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/git/commits{/sha}","comments_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/comments{/number}","issue_comment_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/issues/comments{/number}","contents_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/contents/{+path}","compare_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/merges","archive_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/downloads","issues_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/issues{/number}","pulls_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/pulls{/number}","milestones_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/milestones{/number}","notifications_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/labels{/name}","releases_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/releases{/id}","deployments_url":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/deployments","created_at":"2019-01-22T03:27:27Z","updated_at":"2019-06-24T20:19:55Z","pushed_at":"2019-10-31T12:14:15Z","git_url":"git://github.com/VulnerabilityHistoryProject/tomcat-vulnerabilities.git","ssh_url":"[email protected]:VulnerabilityHistoryProject/tomcat-vulnerabilities.git","clone_url":"https://github.com/VulnerabilityHistoryProject/tomcat-vulnerabilities.git","svn_url":"https://github.com/VulnerabilityHistoryProject/tomcat-vulnerabilities","homepage":null,"size":1697,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":30,"license":null,"forks":68,"open_issues":30,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/pulls/51"},"html":{"href":"https://github.com/VulnerabilityHistoryProject/tomcat-vulnerabilities/pull/51"},"issue":{"href":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/issues/51"},"comments":{"href":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities/statuses/56073ee873ac4610ef9cdac9c08da87f8bae3e47"}},"author_association":"NONE"}}	{ "id": 166920755, "name": "VulnerabilityHistoryProject/tomcat-vulnerabilities", "url": "https://api.github.com/repos/VulnerabilityHistoryProject/tomcat-vulnerabilities" }	{ "id": 18746512, "login": "heartemoji", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/18746512?", "url": "https://api.github.com/users/heartemoji" }	{ "id": 35928658, "login": "VulnerabilityHistoryProject", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/35928658?", "url": "https://api.github.com/orgs/VulnerabilityHistoryProject" }	2019-10-31T12:35:12	10757073195	{"actor":{"display_login":"heartemoji"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/kiali/kiali-bot/pulls/comments/307504443","pull_request_review_id":266889611,"id":307504443,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzUwNDQ0Mw==","diff_hunk":"@@ -0,0 +1,6 @@\n+APP_ID=1000\n+KIALI_BOT_USER=kiali-bot\n+BACKEND_REPO_NAME=kiali-backend\n+FRONTEND_REPO_NAME=kiali-frontend","path":".env.tests","position":4,"original_position":4,"commit_id":"5a7064b12d5eb39a2e84b41ea89b0f9eca72aa92","original_commit_id":"5a7064b12d5eb39a2e84b41ea89b0f9eca72aa92","user":{"login":"josejulio","id":3845764,"node_id":"MDQ6VXNlcjM4NDU3NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3845764?v=4","gravatar_id":"","url":"https://api.github.com/users/josejulio","html_url":"https://github.com/josejulio","followers_url":"https://api.github.com/users/josejulio/followers","following_url":"https://api.github.com/users/josejulio/following{/other_user}","gists_url":"https://api.github.com/users/josejulio/gists{/gist_id}","starred_url":"https://api.github.com/users/josejulio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josejulio/subscriptions","organizations_url":"https://api.github.com/users/josejulio/orgs","repos_url":"https://api.github.com/users/josejulio/repos","events_url":"https://api.github.com/users/josejulio/events{/privacy}","received_events_url":"https://api.github.com/users/josejulio/received_events","type":"User","site_admin":false},"body":"What are these repositories?","created_at":"2019-07-25T21:15:17Z","updated_at":"2019-07-25T21:15:17Z","html_url":"https://github.com/kiali/kiali-bot/pull/4#discussion_r307504443","pull_request_url":"https://api.github.com/repos/kiali/kiali-bot/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali-bot/pulls/comments/307504443"},"html":{"href":"https://github.com/kiali/kiali-bot/pull/4#discussion_r307504443"},"pull_request":{"href":"https://api.github.com/repos/kiali/kiali-bot/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/kiali/kiali-bot/pulls/4","id":301309375,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxMzA5Mzc1","html_url":"https://github.com/kiali/kiali-bot/pull/4","diff_url":"https://github.com/kiali/kiali-bot/pull/4.diff","patch_url":"https://github.com/kiali/kiali-bot/pull/4.patch","issue_url":"https://api.github.com/repos/kiali/kiali-bot/issues/4","number":4,"state":"open","locked":false,"title":"KIALI-3082 Github bot to require QE involvement on PRs","user":{"login":"israel-hdez","id":23639005,"node_id":"MDQ6VXNlcjIzNjM5MDA1","avatar_url":"https://avatars3.githubusercontent.com/u/23639005?v=4","gravatar_id":"","url":"https://api.github.com/users/israel-hdez","html_url":"https://github.com/israel-hdez","followers_url":"https://api.github.com/users/israel-hdez/followers","following_url":"https://api.github.com/users/israel-hdez/following{/other_user}","gists_url":"https://api.github.com/users/israel-hdez/gists{/gist_id}","starred_url":"https://api.github.com/users/israel-hdez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/israel-hdez/subscriptions","organizations_url":"https://api.github.com/users/israel-hdez/orgs","repos_url":"https://api.github.com/users/israel-hdez/repos","events_url":"https://api.github.com/users/israel-hdez/events{/privacy}","received_events_url":"https://api.github.com/users/israel-hdez/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/KIALI-3082\n\nThe main ask in KIALI-3082 is to ensure that one of the reviewers is from the QE team. This PR is adding checks to ensure that a PR have been approved by users in a list of mandatory reviewers. It doesn't need to be QE, but the initial intention is that the list is formed only of QE people.\n\nA config file in the repository is used to specify the list and control if the checks are enabled (it's disabled by default).\n","created_at":"2019-07-25T21:01:52Z","updated_at":"2019-07-25T21:15:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"daf56f0a20ae7ee09c83130e6dccf0891e951a5b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiali/kiali-bot/pulls/4/commits","review_comments_url":"https://api.github.com/repos/kiali/kiali-bot/pulls/4/comments","review_comment_url":"https://api.github.com/repos/kiali/kiali-bot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiali/kiali-bot/issues/4/comments","statuses_url":"https://api.github.com/repos/kiali/kiali-bot/statuses/5a7064b12d5eb39a2e84b41ea89b0f9eca72aa92","head":{"label":"israel-hdez:kiali-3082","ref":"kiali-3082","sha":"5a7064b12d5eb39a2e84b41ea89b0f9eca72aa92","user":{"login":"israel-hdez","id":23639005,"node_id":"MDQ6VXNlcjIzNjM5MDA1","avatar_url":"https://avatars3.githubusercontent.com/u/23639005?v=4","gravatar_id":"","url":"https://api.github.com/users/israel-hdez","html_url":"https://github.com/israel-hdez","followers_url":"https://api.github.com/users/israel-hdez/followers","following_url":"https://api.github.com/users/israel-hdez/following{/other_user}","gists_url":"https://api.github.com/users/israel-hdez/gists{/gist_id}","starred_url":"https://api.github.com/users/israel-hdez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/israel-hdez/subscriptions","organizations_url":"https://api.github.com/users/israel-hdez/orgs","repos_url":"https://api.github.com/users/israel-hdez/repos","events_url":"https://api.github.com/users/israel-hdez/events{/privacy}","received_events_url":"https://api.github.com/users/israel-hdez/received_events","type":"User","site_admin":false},"repo":{"id":192577141,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI1NzcxNDE=","name":"kiali-bot","full_name":"israel-hdez/kiali-bot","private":false,"owner":{"login":"israel-hdez","id":23639005,"node_id":"MDQ6VXNlcjIzNjM5MDA1","avatar_url":"https://avatars3.githubusercontent.com/u/23639005?v=4","gravatar_id":"","url":"https://api.github.com/users/israel-hdez","html_url":"https://github.com/israel-hdez","followers_url":"https://api.github.com/users/israel-hdez/followers","following_url":"https://api.github.com/users/israel-hdez/following{/other_user}","gists_url":"https://api.github.com/users/israel-hdez/gists{/gist_id}","starred_url":"https://api.github.com/users/israel-hdez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/israel-hdez/subscriptions","organizations_url":"https://api.github.com/users/israel-hdez/orgs","repos_url":"https://api.github.com/users/israel-hdez/repos","events_url":"https://api.github.com/users/israel-hdez/events{/privacy}","received_events_url":"https://api.github.com/users/israel-hdez/received_events","type":"User","site_admin":false},"html_url":"https://github.com/israel-hdez/kiali-bot","description":"A bot to manage the workflow for Kiali Project","fork":true,"url":"https://api.github.com/repos/israel-hdez/kiali-bot","forks_url":"https://api.github.com/repos/israel-hdez/kiali-bot/forks","keys_url":"https://api.github.com/repos/israel-hdez/kiali-bot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/israel-hdez/kiali-bot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/israel-hdez/kiali-bot/teams","hooks_url":"https://api.github.com/repos/israel-hdez/kiali-bot/hooks","issue_events_url":"https://api.github.com/repos/israel-hdez/kiali-bot/issues/events{/number}","events_url":"https://api.github.com/repos/israel-hdez/kiali-bot/events","assignees_url":"https://api.github.com/repos/israel-hdez/kiali-bot/assignees{/user}","branches_url":"https://api.github.com/repos/israel-hdez/kiali-bot/branches{/branch}","tags_url":"https://api.github.com/repos/israel-hdez/kiali-bot/tags","blobs_url":"https://api.github.com/repos/israel-hdez/kiali-bot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/israel-hdez/kiali-bot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/israel-hdez/kiali-bot/git/refs{/sha}","trees_url":"https://api.github.com/repos/israel-hdez/kiali-bot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/israel-hdez/kiali-bot/statuses/{sha}","languages_url":"https://api.github.com/repos/israel-hdez/kiali-bot/languages","stargazers_url":"https://api.github.com/repos/israel-hdez/kiali-bot/stargazers","contributors_url":"https://api.github.com/repos/israel-hdez/kiali-bot/contributors","subscribers_url":"https://api.github.com/repos/israel-hdez/kiali-bot/subscribers","subscription_url":"https://api.github.com/repos/israel-hdez/kiali-bot/subscription","commits_url":"https://api.github.com/repos/israel-hdez/kiali-bot/commits{/sha}","git_commits_url":"https://api.github.com/repos/israel-hdez/kiali-bot/git/commits{/sha}","comments_url":"https://api.github.com/repos/israel-hdez/kiali-bot/comments{/number}","issue_comment_url":"https://api.github.com/repos/israel-hdez/kiali-bot/issues/comments{/number}","contents_url":"https://api.github.com/repos/israel-hdez/kiali-bot/contents/{+path}","compare_url":"https://api.github.com/repos/israel-hdez/kiali-bot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/israel-hdez/kiali-bot/merges","archive_url":"https://api.github.com/repos/israel-hdez/kiali-bot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/israel-hdez/kiali-bot/downloads","issues_url":"https://api.github.com/repos/israel-hdez/kiali-bot/issues{/number}","pulls_url":"https://api.github.com/repos/israel-hdez/kiali-bot/pulls{/number}","milestones_url":"https://api.github.com/repos/israel-hdez/kiali-bot/milestones{/number}","notifications_url":"https://api.github.com/repos/israel-hdez/kiali-bot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/israel-hdez/kiali-bot/labels{/name}","releases_url":"https://api.github.com/repos/israel-hdez/kiali-bot/releases{/id}","deployments_url":"https://api.github.com/repos/israel-hdez/kiali-bot/deployments","created_at":"2019-06-18T16:34:12Z","updated_at":"2019-07-16T17:59:19Z","pushed_at":"2019-07-25T21:10:23Z","git_url":"git://github.com/israel-hdez/kiali-bot.git","ssh_url":"[email protected]:israel-hdez/kiali-bot.git","clone_url":"https://github.com/israel-hdez/kiali-bot.git","svn_url":"https://github.com/israel-hdez/kiali-bot","homepage":"","size":360,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiali:master","ref":"master","sha":"06f9d1c7803e86b881d9ff9b9c9ddbbae59281e3","user":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"repo":{"id":177878258,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc4NzgyNTg=","name":"kiali-bot","full_name":"kiali/kiali-bot","private":false,"owner":{"login":"kiali","id":36001875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDAxODc1","avatar_url":"https://avatars2.githubusercontent.com/u/36001875?v=4","gravatar_id":"","url":"https://api.github.com/users/kiali","html_url":"https://github.com/kiali","followers_url":"https://api.github.com/users/kiali/followers","following_url":"https://api.github.com/users/kiali/following{/other_user}","gists_url":"https://api.github.com/users/kiali/gists{/gist_id}","starred_url":"https://api.github.com/users/kiali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiali/subscriptions","organizations_url":"https://api.github.com/users/kiali/orgs","repos_url":"https://api.github.com/users/kiali/repos","events_url":"https://api.github.com/users/kiali/events{/privacy}","received_events_url":"https://api.github.com/users/kiali/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kiali/kiali-bot","description":"A bot to manage the workflow for Kiali Project","fork":false,"url":"https://api.github.com/repos/kiali/kiali-bot","forks_url":"https://api.github.com/repos/kiali/kiali-bot/forks","keys_url":"https://api.github.com/repos/kiali/kiali-bot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiali/kiali-bot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiali/kiali-bot/teams","hooks_url":"https://api.github.com/repos/kiali/kiali-bot/hooks","issue_events_url":"https://api.github.com/repos/kiali/kiali-bot/issues/events{/number}","events_url":"https://api.github.com/repos/kiali/kiali-bot/events","assignees_url":"https://api.github.com/repos/kiali/kiali-bot/assignees{/user}","branches_url":"https://api.github.com/repos/kiali/kiali-bot/branches{/branch}","tags_url":"https://api.github.com/repos/kiali/kiali-bot/tags","blobs_url":"https://api.github.com/repos/kiali/kiali-bot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiali/kiali-bot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiali/kiali-bot/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiali/kiali-bot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiali/kiali-bot/statuses/{sha}","languages_url":"https://api.github.com/repos/kiali/kiali-bot/languages","stargazers_url":"https://api.github.com/repos/kiali/kiali-bot/stargazers","contributors_url":"https://api.github.com/repos/kiali/kiali-bot/contributors","subscribers_url":"https://api.github.com/repos/kiali/kiali-bot/subscribers","subscription_url":"https://api.github.com/repos/kiali/kiali-bot/subscription","commits_url":"https://api.github.com/repos/kiali/kiali-bot/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiali/kiali-bot/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiali/kiali-bot/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiali/kiali-bot/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiali/kiali-bot/contents/{+path}","compare_url":"https://api.github.com/repos/kiali/kiali-bot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiali/kiali-bot/merges","archive_url":"https://api.github.com/repos/kiali/kiali-bot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiali/kiali-bot/downloads","issues_url":"https://api.github.com/repos/kiali/kiali-bot/issues{/number}","pulls_url":"https://api.github.com/repos/kiali/kiali-bot/pulls{/number}","milestones_url":"https://api.github.com/repos/kiali/kiali-bot/milestones{/number}","notifications_url":"https://api.github.com/repos/kiali/kiali-bot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiali/kiali-bot/labels{/name}","releases_url":"https://api.github.com/repos/kiali/kiali-bot/releases{/id}","deployments_url":"https://api.github.com/repos/kiali/kiali-bot/deployments","created_at":"2019-03-26T22:30:16Z","updated_at":"2019-06-26T16:26:09Z","pushed_at":"2019-07-25T21:10:24Z","git_url":"git://github.com/kiali/kiali-bot.git","ssh_url":"[email protected]:kiali/kiali-bot.git","clone_url":"https://github.com/kiali/kiali-bot.git","svn_url":"https://github.com/kiali/kiali-bot","homepage":"","size":360,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiali/kiali-bot/pulls/4"},"html":{"href":"https://github.com/kiali/kiali-bot/pull/4"},"issue":{"href":"https://api.github.com/repos/kiali/kiali-bot/issues/4"},"comments":{"href":"https://api.github.com/repos/kiali/kiali-bot/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/kiali/kiali-bot/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/kiali/kiali-bot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiali/kiali-bot/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/kiali/kiali-bot/statuses/5a7064b12d5eb39a2e84b41ea89b0f9eca72aa92"}},"author_association":"COLLABORATOR"}}	{ "id": 177878258, "name": "kiali/kiali-bot", "url": "https://api.github.com/repos/kiali/kiali-bot" }	{ "id": 3845764, "login": "josejulio", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/3845764?", "url": "https://api.github.com/users/josejulio" }	{ "id": 36001875, "login": "kiali", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/36001875?", "url": "https://api.github.com/orgs/kiali" }	2019-07-25T21:15:17	10086608811	{"actor":{"display_login":"josejulio"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/pulls/comments/316976743","pull_request_review_id":278799105,"id":316976743,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNjk3Njc0Mw==","diff_hunk":"@@ -131,23 +133,19 @@ func (d Driver) DeleteVolume(ctx context.Context, req csi.DeleteVolumeRequest)\n \t}\n \n \tvolumeID := req.VolumeId\n-\tresourceGroupName, accountName, fileShareName, err := getFileShareInfo(volumeID)\n+\tshareURL, err := d.getShareUrl(volumeID)\n \tif err != nil {\n-\t\tklog.Errorf(\"getFileShareInfo(%s) in DeleteVolume failed with error: %v\", volumeID, err)\n+\t\t// According to CSI Driver Sanity Tester, should succeed when an invalid volume id is used","path":"pkg/azurefile/controllerserver.go","position":8,"original_position":17,"commit_id":"433a4d2a8721988bb21acb02cafaa814a7c41d87","original_commit_id":"440c66af2e5efb3f3c9dd1fe02d11f88dcfd2018","user":{"login":"ZeroMagic","id":12582312,"node_id":"MDQ6VXNlcjEyNTgyMzEy","avatar_url":"https://avatars3.githubusercontent.com/u/12582312?v=4","gravatar_id":"","url":"https://api.github.com/users/ZeroMagic","html_url":"https://github.com/ZeroMagic","followers_url":"https://api.github.com/users/ZeroMagic/followers","following_url":"https://api.github.com/users/ZeroMagic/following{/other_user}","gists_url":"https://api.github.com/users/ZeroMagic/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroMagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroMagic/subscriptions","organizations_url":"https://api.github.com/users/ZeroMagic/orgs","repos_url":"https://api.github.com/users/ZeroMagic/repos","events_url":"https://api.github.com/users/ZeroMagic/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroMagic/received_events","type":"User","site_admin":false},"body":"done.","created_at":"2019-08-23T05:14:02Z","updated_at":"2019-08-23T05:14:02Z","html_url":"https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/112#discussion_r316976743","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/pulls/112","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/pulls/comments/316976743"},"html":{"href":"https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/112#discussion_r316976743"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/pulls/112"}},"in_reply_to_id":316974206},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/pulls/112","id":310214907,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEwMjE0OTA3","html_url":"https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/112","diff_url":"https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/112.diff","patch_url":"https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/112.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/issues/112","number":112,"state":"open","locked":false,"title":"feat: implement DeleteSnapshot","user":{"login":"ZeroMagic","id":12582312,"node_id":"MDQ6VXNlcjEyNTgyMzEy","avatar_url":"https://avatars3.githubusercontent.com/u/12582312?v=4","gravatar_id":"","url":"https://api.github.com/users/ZeroMagic","html_url":"https://github.com/ZeroMagic","followers_url":"https://api.github.com/users/ZeroMagic/followers","following_url":"https://api.github.com/users/ZeroMagic/following{/other_user}","gists_url":"https://api.github.com/users/ZeroMagic/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroMagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroMagic/subscriptions","organizations_url":"https://api.github.com/users/ZeroMagic/orgs","repos_url":"https://api.github.com/users/ZeroMagic/repos","events_url":"https://api.github.com/users/ZeroMagic/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroMagic/received_events","type":"User","site_admin":false},"body":"What type of PR is this?\r\n/kind feature\r\n\r\nWhat this PR does / why we need it:\r\n- implement DeleteSnapshot\r\n- use `shareURL` to delete fileshare instead of `fileServiceClient`. Then we can use `x-ms-delete-snapshots=include` to delete all share snapshots with the share.\r\n- enable `csi.ControllerServiceCapability_RPC_CREATE_DELETE_SNAPSHOT`\r\n- change the way to run sanity test in CI\r\n\r\nWhich issue(s) this PR fixes:\r\n<!-- \r\nAutomatically closes linked issue when PR is merged.\r\nUsage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.\r\n_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_\r\n-->\r\nFixes #18 \r\n\r\nSpecial notes for your reviewer:\r\n\r\n\r\nRelease note:\r\n```\r\nimplement DeleteSnapshot\r\n```\r\n","created_at":"2019-08-23T03:13:56Z","updated_at":"2019-08-23T05:14:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21ad8dc226cd19672b26c9a8c3816667c73cc0bb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"feiskyer","id":676637,"node_id":"MDQ6VXNlcjY3NjYzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/676637?v=4","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1261543097,"node_id":"MDU6TGFiZWwxMjYxNTQzMDk3","url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":1145477699,"node_id":"MDU6TGFiZWwxMTQ1NDc3Njk5","url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/labels/kind/feature","name":"kind/feature","color":"c7def8","default":false},{"id":1261524619,"node_id":"MDU6TGFiZWwxMjYxNTI0NjE5","url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/pulls/112/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/pulls/112/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/issues/112/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/statuses/433a4d2a8721988bb21acb02cafaa814a7c41d87","head":{"label":"ZeroMagic:delete_snapshot","ref":"delete_snapshot","sha":"433a4d2a8721988bb21acb02cafaa814a7c41d87","user":{"login":"ZeroMagic","id":12582312,"node_id":"MDQ6VXNlcjEyNTgyMzEy","avatar_url":"https://avatars3.githubusercontent.com/u/12582312?v=4","gravatar_id":"","url":"https://api.github.com/users/ZeroMagic","html_url":"https://github.com/ZeroMagic","followers_url":"https://api.github.com/users/ZeroMagic/followers","following_url":"https://api.github.com/users/ZeroMagic/following{/other_user}","gists_url":"https://api.github.com/users/ZeroMagic/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroMagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroMagic/subscriptions","organizations_url":"https://api.github.com/users/ZeroMagic/orgs","repos_url":"https://api.github.com/users/ZeroMagic/repos","events_url":"https://api.github.com/users/ZeroMagic/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroMagic/received_events","type":"User","site_admin":false},"repo":{"id":193823791,"node_id":"MDEwOlJlcG9zaXRvcnkxOTM4MjM3OTE=","name":"azurefile-csi-driver","full_name":"ZeroMagic/azurefile-csi-driver","private":false,"owner":{"login":"ZeroMagic","id":12582312,"node_id":"MDQ6VXNlcjEyNTgyMzEy","avatar_url":"https://avatars3.githubusercontent.com/u/12582312?v=4","gravatar_id":"","url":"https://api.github.com/users/ZeroMagic","html_url":"https://github.com/ZeroMagic","followers_url":"https://api.github.com/users/ZeroMagic/followers","following_url":"https://api.github.com/users/ZeroMagic/following{/other_user}","gists_url":"https://api.github.com/users/ZeroMagic/gists{/gist_id}","starred_url":"https://api.github.com/users/ZeroMagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZeroMagic/subscriptions","organizations_url":"https://api.github.com/users/ZeroMagic/orgs","repos_url":"https://api.github.com/users/ZeroMagic/repos","events_url":"https://api.github.com/users/ZeroMagic/events{/privacy}","received_events_url":"https://api.github.com/users/ZeroMagic/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ZeroMagic/azurefile-csi-driver","description":"Azure file Container Storage Interface (CSI) Storage Plugin","fork":true,"url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver","forks_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/forks","keys_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/teams","hooks_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/hooks","issue_events_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/issues/events{/number}","events_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/events","assignees_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/assignees{/user}","branches_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/branches{/branch}","tags_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/tags","blobs_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/languages","stargazers_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/stargazers","contributors_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/contributors","subscribers_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/subscribers","subscription_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/subscription","commits_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/contents/{+path}","compare_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/merges","archive_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/downloads","issues_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/issues{/number}","pulls_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/labels{/name}","releases_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/releases{/id}","deployments_url":"https://api.github.com/repos/ZeroMagic/azurefile-csi-driver/deployments","created_at":"2019-06-26T03:34:50Z","updated_at":"2019-08-22T03:47:08Z","pushed_at":"2019-08-23T05:13:28Z","git_url":"git://github.com/ZeroMagic/azurefile-csi-driver.git","ssh_url":"[email protected]:ZeroMagic/azurefile-csi-driver.git","clone_url":"https://github.com/ZeroMagic/azurefile-csi-driver.git","svn_url":"https://github.com/ZeroMagic/azurefile-csi-driver","homepage":null,"size":65748,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"5dff87e49e275761cbe4409ac3885adaf3c8d022","user":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":159793611,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk3OTM2MTE=","name":"azurefile-csi-driver","full_name":"kubernetes-sigs/azurefile-csi-driver","private":false,"owner":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes-sigs/azurefile-csi-driver","description":"Azure file Container Storage Interface (CSI) Storage Plugin","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver","forks_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/deployments","created_at":"2018-11-30T08:38:55Z","updated_at":"2019-08-22T03:26:36Z","pushed_at":"2019-08-23T05:13:30Z","git_url":"git://github.com/kubernetes-sigs/azurefile-csi-driver.git","ssh_url":"[email protected]:kubernetes-sigs/azurefile-csi-driver.git","clone_url":"https://github.com/kubernetes-sigs/azurefile-csi-driver.git","svn_url":"https://github.com/kubernetes-sigs/azurefile-csi-driver","homepage":null,"size":65746,"stargazers_count":12,"watchers_count":12,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":12,"open_issues":12,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/pulls/112"},"html":{"href":"https://github.com/kubernetes-sigs/azurefile-csi-driver/pull/112"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/issues/112"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/issues/112/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/pulls/112/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/pulls/112/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver/statuses/433a4d2a8721988bb21acb02cafaa814a7c41d87"}},"author_association":"COLLABORATOR"}}	{ "id": 159793611, "name": "kubernetes-sigs/azurefile-csi-driver", "url": "https://api.github.com/repos/kubernetes-sigs/azurefile-csi-driver" }	{ "id": 12582312, "login": "ZeroMagic", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/12582312?", "url": "https://api.github.com/users/ZeroMagic" }	{ "id": 36015203, "login": "kubernetes-sigs", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/36015203?", "url": "https://api.github.com/orgs/kubernetes-sigs" }	2019-08-23T05:14:02	10268174003	{"actor":{"display_login":"ZeroMagic"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/pulls/comments/328356624","pull_request_review_id":293385247,"id":328356624,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyODM1NjYyNA==","diff_hunk":"@@ -334,25 +319,42 @@ func BooleanValue(b bool) Value {\n func (v Value) String() string {","path":"value/value.go","position":62,"original_position":62,"commit_id":"87845e2729c09cc988b7c2b6c57ad3a8b1582586","original_commit_id":"87845e2729c09cc988b7c2b6c57ad3a8b1582586","user":{"login":"lavalamp","id":647318,"node_id":"MDQ6VXNlcjY0NzMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"body":"This code should never be called from a performance-critical path.","created_at":"2019-09-25T21:51:33Z","updated_at":"2019-09-25T21:51:33Z","html_url":"https://github.com/kubernetes-sigs/structured-merge-diff/pull/108#discussion_r328356624","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/pulls/108","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/pulls/comments/328356624"},"html":{"href":"https://github.com/kubernetes-sigs/structured-merge-diff/pull/108#discussion_r328356624"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/pulls/108","id":321368921,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIxMzY4OTIx","html_url":"https://github.com/kubernetes-sigs/structured-merge-diff/pull/108","diff_url":"https://github.com/kubernetes-sigs/structured-merge-diff/pull/108.diff","patch_url":"https://github.com/kubernetes-sigs/structured-merge-diff/pull/108.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/issues/108","number":108,"state":"open","locked":false,"title":"Improve performance","user":{"login":"apelisse","id":1929644,"node_id":"MDQ6VXNlcjE5Mjk2NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1929644?v=4","gravatar_id":"","url":"https://api.github.com/users/apelisse","html_url":"https://github.com/apelisse","followers_url":"https://api.github.com/users/apelisse/followers","following_url":"https://api.github.com/users/apelisse/following{/other_user}","gists_url":"https://api.github.com/users/apelisse/gists{/gist_id}","starred_url":"https://api.github.com/users/apelisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apelisse/subscriptions","organizations_url":"https://api.github.com/users/apelisse/orgs","repos_url":"https://api.github.com/users/apelisse/repos","events_url":"https://api.github.com/users/apelisse/events{/privacy}","received_events_url":"https://api.github.com/users/apelisse/received_events","type":"User","site_admin":false},"body":"Various improvements to allocations (up to 50% for update, 40% for FromUnstructured):\r\n```\r\nbenchmark old ns/op new ns/op delta\r\nBenchmarkFieldSet/insert-20-12 20178 19847 -1.64%\r\nBenchmarkFieldSet/has-20-12 721 710 -1.53%\r\nBenchmarkFieldSet/serialize-20-12 14198 14171 -0.19%\r\nBenchmarkFieldSet/deserialize-20-12 34374 35060 +2.00%\r\nBenchmarkFieldSet/union-20-12 11807 12268 +3.90%\r\nBenchmarkFieldSet/intersection-20-12 5041 5334 +5.81%\r\nBenchmarkFieldSet/difference-20-12 8918 9034 +1.30%\r\nBenchmarkFieldSet/insert-50-12 60155 59311 -1.40%\r\nBenchmarkFieldSet/has-50-12 829 813 -1.93%\r\nBenchmarkFieldSet/serialize-50-12 34321 33114 -3.52%\r\nBenchmarkFieldSet/deserialize-50-12 80336 79841 -0.62%\r\nBenchmarkFieldSet/union-50-12 30503 32520 +6.61%\r\nBenchmarkFieldSet/intersection-50-12 10552 10948 +3.75%\r\nBenchmarkFieldSet/difference-50-12 23098 23697 +2.59%\r\nBenchmarkFieldSet/insert-100-12 142519 145677 +2.22%\r\nBenchmarkFieldSet/has-100-12 1032 1010 -2.13%\r\nBenchmarkFieldSet/serialize-100-12 93235 90891 -2.51%\r\nBenchmarkFieldSet/deserialize-100-12 196329 193819 -1.28%\r\nBenchmarkFieldSet/union-100-12 52364 54112 +3.34%\r\nBenchmarkFieldSet/intersection-100-12 17147 16596 -3.21%\r\nBenchmarkFieldSet/difference-100-12 41190 41098 -0.22%\r\nBenchmarkFieldSet/insert-500-12 671973 686997 +2.24%\r\nBenchmarkFieldSet/has-500-12 1048 1130 +7.82%\r\nBenchmarkFieldSet/serialize-500-12 479285 465530 -2.87%\r\nBenchmarkFieldSet/deserialize-500-12 837894 828525 -1.12%\r\nBenchmarkFieldSet/union-500-12 236866 266410 +12.47%\r\nBenchmarkFieldSet/intersection-500-12 118440 116428 -1.70%\r\nBenchmarkFieldSet/difference-500-12 239103 215492 -9.87%\r\nBenchmarkFieldSet/insert-1000-12 1361049 1434539 +5.40%\r\nBenchmarkFieldSet/has-1000-12 1199 1164 -2.92%\r\nBenchmarkFieldSet/serialize-1000-12 989911 1037991 +4.86%\r\nBenchmarkFieldSet/deserialize-1000-12 1690249 1730177 +2.36%\r\nBenchmarkFieldSet/union-1000-12 450585 497112 +10.33%\r\nBenchmarkFieldSet/intersection-1000-12 191047 200137 +4.76%\r\nBenchmarkFieldSet/difference-1000-12 377929 407488 +7.82%\r\nBenchmarkDeducedSimple-12 117303 101274 -13.66%\r\nBenchmarkDeducedNested-12 318361 258506 -18.80%\r\nBenchmarkDeducedNestedAcrossVersion-12 317505 267320 -15.81%\r\nBenchmarkLeafConflictAcrossVersion-12 115084 98086 -14.77%\r\nBenchmarkMultipleApplierRecursiveRealConversion-12 1649080 1585240 -3.87%\r\nBenchmarkOperations/Pod/Update-12 351283 176133 -49.86%\r\nBenchmarkOperations/Pod/Apply-12 516962 473135 -8.48%\r\nBenchmarkOperations/Node/Update-12 569627 238850 -58.07%\r\nBenchmarkOperations/Node/Apply-12 755372 697876 -7.61%\r\nBenchmarkOperations/Endpoints/Update-12 56002 33171 -40.77%\r\nBenchmarkOperations/Endpoints/Apply-12 2081751 2082352 +0.03%\r\nBenchmarkFromUnstructured/Pod-12 202841 137831 -32.05%\r\nBenchmarkFromUnstructured/Node-12 327686 205776 -37.20%\r\nBenchmarkFromUnstructured/Endpoints-12 7909537 4781613 -39.55%\r\n\r\nbenchmark old allocs new allocs delta\r\nBenchmarkFieldSet/insert-20-12 78 78 +0.00%\r\nBenchmarkFieldSet/has-20-12 2 2 +0.00%\r\nBenchmarkFieldSet/serialize-20-12 23 23 +0.00%\r\nBenchmarkFieldSet/deserialize-20-12 216 216 +0.00%\r\nBenchmarkFieldSet/union-20-12 53 53 +0.00%\r\nBenchmarkFieldSet/intersection-20-12 29 29 +0.00%\r\nBenchmarkFieldSet/difference-20-12 42 42 +0.00%\r\nBenchmarkFieldSet/insert-50-12 246 246 +0.00%\r\nBenchmarkFieldSet/has-50-12 2 2 +0.00%\r\nBenchmarkFieldSet/serialize-50-12 48 47 -2.08%\r\nBenchmarkFieldSet/deserialize-50-12 621 618 -0.48%\r\nBenchmarkFieldSet/union-50-12 134 135 +0.75%\r\nBenchmarkFieldSet/intersection-50-12 61 62 +1.64%\r\nBenchmarkFieldSet/difference-50-12 101 102 +0.99%\r\nBenchmarkFieldSet/insert-100-12 813 813 +0.00%\r\nBenchmarkFieldSet/has-100-12 3 3 +0.00%\r\nBenchmarkFieldSet/serialize-100-12 93 93 +0.00%\r\nBenchmarkFieldSet/deserialize-100-12 2158 2158 +0.00%\r\nBenchmarkFieldSet/union-100-12 258 257 -0.39%\r\nBenchmarkFieldSet/intersection-100-12 125 124 -0.80%\r\nBenchmarkFieldSet/difference-100-12 215 215 +0.00%\r\nBenchmarkFieldSet/insert-500-12 4140 4143 +0.07%\r\nBenchmarkFieldSet/has-500-12 3 3 +0.00%\r\nBenchmarkFieldSet/serialize-500-12 470 470 +0.00%\r\nBenchmarkFieldSet/deserialize-500-12 10787 10788 +0.01%\r\nBenchmarkFieldSet/union-500-12 1469 1469 +0.00%\r\nBenchmarkFieldSet/intersection-500-12 739 739 +0.00%\r\nBenchmarkFieldSet/difference-500-12 1162 1160 -0.17%\r\nBenchmarkFieldSet/insert-1000-12 8981 8977 -0.04%\r\nBenchmarkFieldSet/has-1000-12 3 3 +0.00%\r\nBenchmarkFieldSet/serialize-1000-12 998 998 +0.00%\r\nBenchmarkFieldSet/deserialize-1000-12 23496 23450 -0.20%\r\nBenchmarkFieldSet/union-1000-12 2847 2853 +0.21%\r\nBenchmarkFieldSet/intersection-1000-12 1325 1330 +0.38%\r\nBenchmarkFieldSet/difference-1000-12 2237 2238 +0.04%\r\nBenchmarkDeducedSimple-12 572 506 -11.54%\r\nBenchmarkDeducedNested-12 1562 1271 -18.63%\r\nBenchmarkDeducedNestedAcrossVersion-12 1630 1338 -17.91%\r\nBenchmarkLeafConflictAcrossVersion-12 544 493 -9.38%\r\nBenchmarkMultipleApplierRecursiveRealConversion-12 5268 4903 -6.93%\r\nBenchmarkOperations/Pod/Update-12 843 404 -52.08%\r\nBenchmarkOperations/Pod/Apply-12 1179 1047 -11.20%\r\nBenchmarkOperations/Node/Update-12 1155 536 -53.59%\r\nBenchmarkOperations/Node/Apply-12 1876 1667 -11.14%\r\nBenchmarkOperations/Endpoints/Update-12 100 73 -27.00%\r\nBenchmarkOperations/Endpoints/Apply-12 3143 3141 -0.06%\r\nBenchmarkFromUnstructured/Pod-12 477 321 -32.70%\r\nBenchmarkFromUnstructured/Node-12 1107 797 -28.00%\r\nBenchmarkFromUnstructured/Endpoints-12 21114 13075 -38.07%\r\n```","created_at":"2019-09-25T17:59:12Z","updated_at":"2019-09-25T21:51:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"250607362f30d16373a87659b439086d637b7bf2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jennybuckley","id":31416425,"node_id":"MDQ6VXNlcjMxNDE2NDI1","avatar_url":"https://avatars2.githubusercontent.com/u/31416425?v=4","gravatar_id":"","url":"https://api.github.com/users/jennybuckley","html_url":"https://github.com/jennybuckley","followers_url":"https://api.github.com/users/jennybuckley/followers","following_url":"https://api.github.com/users/jennybuckley/following{/other_user}","gists_url":"https://api.github.com/users/jennybuckley/gists{/gist_id}","starred_url":"https://api.github.com/users/jennybuckley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennybuckley/subscriptions","organizations_url":"https://api.github.com/users/jennybuckley/orgs","repos_url":"https://api.github.com/users/jennybuckley/repos","events_url":"https://api.github.com/users/jennybuckley/events{/privacy}","received_events_url":"https://api.github.com/users/jennybuckley/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1048482651,"node_id":"MDU6TGFiZWwxMDQ4NDgyNjUx","url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1048481802,"node_id":"MDU6TGFiZWwxMDQ4NDgxODAy","url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":1048485293,"node_id":"MDU6TGFiZWwxMDQ4NDg1Mjkz","url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/pulls/108/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/pulls/108/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/issues/108/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/statuses/87845e2729c09cc988b7c2b6c57ad3a8b1582586","head":{"label":"apelisse:improve-performance","ref":"improve-performance","sha":"87845e2729c09cc988b7c2b6c57ad3a8b1582586","user":{"login":"apelisse","id":1929644,"node_id":"MDQ6VXNlcjE5Mjk2NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1929644?v=4","gravatar_id":"","url":"https://api.github.com/users/apelisse","html_url":"https://github.com/apelisse","followers_url":"https://api.github.com/users/apelisse/followers","following_url":"https://api.github.com/users/apelisse/following{/other_user}","gists_url":"https://api.github.com/users/apelisse/gists{/gist_id}","starred_url":"https://api.github.com/users/apelisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apelisse/subscriptions","organizations_url":"https://api.github.com/users/apelisse/orgs","repos_url":"https://api.github.com/users/apelisse/repos","events_url":"https://api.github.com/users/apelisse/events{/privacy}","received_events_url":"https://api.github.com/users/apelisse/received_events","type":"User","site_admin":false},"repo":{"id":152504368,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI1MDQzNjg=","name":"structured-merge-diff","full_name":"apelisse/structured-merge-diff","private":false,"owner":{"login":"apelisse","id":1929644,"node_id":"MDQ6VXNlcjE5Mjk2NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1929644?v=4","gravatar_id":"","url":"https://api.github.com/users/apelisse","html_url":"https://github.com/apelisse","followers_url":"https://api.github.com/users/apelisse/followers","following_url":"https://api.github.com/users/apelisse/following{/other_user}","gists_url":"https://api.github.com/users/apelisse/gists{/gist_id}","starred_url":"https://api.github.com/users/apelisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apelisse/subscriptions","organizations_url":"https://api.github.com/users/apelisse/orgs","repos_url":"https://api.github.com/users/apelisse/repos","events_url":"https://api.github.com/users/apelisse/events{/privacy}","received_events_url":"https://api.github.com/users/apelisse/received_events","type":"User","site_admin":false},"html_url":"https://github.com/apelisse/structured-merge-diff","description":"Test cases and implementation for \"server-side apply\"","fork":true,"url":"https://api.github.com/repos/apelisse/structured-merge-diff","forks_url":"https://api.github.com/repos/apelisse/structured-merge-diff/forks","keys_url":"https://api.github.com/repos/apelisse/structured-merge-diff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apelisse/structured-merge-diff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apelisse/structured-merge-diff/teams","hooks_url":"https://api.github.com/repos/apelisse/structured-merge-diff/hooks","issue_events_url":"https://api.github.com/repos/apelisse/structured-merge-diff/issues/events{/number}","events_url":"https://api.github.com/repos/apelisse/structured-merge-diff/events","assignees_url":"https://api.github.com/repos/apelisse/structured-merge-diff/assignees{/user}","branches_url":"https://api.github.com/repos/apelisse/structured-merge-diff/branches{/branch}","tags_url":"https://api.github.com/repos/apelisse/structured-merge-diff/tags","blobs_url":"https://api.github.com/repos/apelisse/structured-merge-diff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apelisse/structured-merge-diff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apelisse/structured-merge-diff/git/refs{/sha}","trees_url":"https://api.github.com/repos/apelisse/structured-merge-diff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apelisse/structured-merge-diff/statuses/{sha}","languages_url":"https://api.github.com/repos/apelisse/structured-merge-diff/languages","stargazers_url":"https://api.github.com/repos/apelisse/structured-merge-diff/stargazers","contributors_url":"https://api.github.com/repos/apelisse/structured-merge-diff/contributors","subscribers_url":"https://api.github.com/repos/apelisse/structured-merge-diff/subscribers","subscription_url":"https://api.github.com/repos/apelisse/structured-merge-diff/subscription","commits_url":"https://api.github.com/repos/apelisse/structured-merge-diff/commits{/sha}","git_commits_url":"https://api.github.com/repos/apelisse/structured-merge-diff/git/commits{/sha}","comments_url":"https://api.github.com/repos/apelisse/structured-merge-diff/comments{/number}","issue_comment_url":"https://api.github.com/repos/apelisse/structured-merge-diff/issues/comments{/number}","contents_url":"https://api.github.com/repos/apelisse/structured-merge-diff/contents/{+path}","compare_url":"https://api.github.com/repos/apelisse/structured-merge-diff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apelisse/structured-merge-diff/merges","archive_url":"https://api.github.com/repos/apelisse/structured-merge-diff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apelisse/structured-merge-diff/downloads","issues_url":"https://api.github.com/repos/apelisse/structured-merge-diff/issues{/number}","pulls_url":"https://api.github.com/repos/apelisse/structured-merge-diff/pulls{/number}","milestones_url":"https://api.github.com/repos/apelisse/structured-merge-diff/milestones{/number}","notifications_url":"https://api.github.com/repos/apelisse/structured-merge-diff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apelisse/structured-merge-diff/labels{/name}","releases_url":"https://api.github.com/repos/apelisse/structured-merge-diff/releases{/id}","deployments_url":"https://api.github.com/repos/apelisse/structured-merge-diff/deployments","created_at":"2018-10-10T23:54:23Z","updated_at":"2018-10-10T23:54:25Z","pushed_at":"2019-09-25T18:13:12Z","git_url":"git://github.com/apelisse/structured-merge-diff.git","ssh_url":"[email protected]:apelisse/structured-merge-diff.git","clone_url":"https://github.com/apelisse/structured-merge-diff.git","svn_url":"https://github.com/apelisse/structured-merge-diff","homepage":"","size":580,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"b04768683e36f30f54fba658d1d1b02d67f4b542","user":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":147731189,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc3MzExODk=","name":"structured-merge-diff","full_name":"kubernetes-sigs/structured-merge-diff","private":false,"owner":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes-sigs/structured-merge-diff","description":"Test cases and implementation for \"server-side apply\"","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff","forks_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/deployments","created_at":"2018-09-06T20:42:49Z","updated_at":"2019-09-25T17:48:08Z","pushed_at":"2019-09-25T18:32:54Z","git_url":"git://github.com/kubernetes-sigs/structured-merge-diff.git","ssh_url":"[email protected]:kubernetes-sigs/structured-merge-diff.git","clone_url":"https://github.com/kubernetes-sigs/structured-merge-diff.git","svn_url":"https://github.com/kubernetes-sigs/structured-merge-diff","homepage":"","size":542,"stargazers_count":16,"watchers_count":16,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":8,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/pulls/108"},"html":{"href":"https://github.com/kubernetes-sigs/structured-merge-diff/pull/108"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/issues/108"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/structured-merge-diff/statuses/87845e2729c09cc988b7c2b6c57ad3a8b1582586"}},"author_association":"CONTRIBUTOR"}}	{ "id": 147731189, "name": "kubernetes-sigs/structured-merge-diff", "url": "https://api.github.com/repos/kubernetes-sigs/structured-merge-diff" }	{ "id": 647318, "login": "lavalamp", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/647318?", "url": "https://api.github.com/users/lavalamp" }	{ "id": 36015203, "login": "kubernetes-sigs", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/36015203?", "url": "https://api.github.com/orgs/kubernetes-sigs" }	2019-09-25T21:51:33	10496515705	{"actor":{"display_login":"lavalamp"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/pulls/comments/318134644","pull_request_review_id":280265311,"id":318134644,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxODEzNDY0NA==","diff_hunk":"@@ -90,6 +92,25 @@ class ChatDetailsPresenter @Inject constructor(\n navigator.toFavoriteMessageList(chatRoomId)\n }\n \n+ fun leave(chatRoomId: String, chatRoomType: String) {\n+ launchUI(strategy) {\n+ try {\n+ retryIO(\"leaveChat($chatRoomId, $chatRoomType\") {\n+ client.leaveChat(chatRoomId, roomTypeOf(chatRoomType))\n+ }\n+ view.showMessage(R.string.left_chat)\n+ navigator.toChatRooms()","path":"app/src/main/java/chat/rocket/android/chatdetails/presentation/ChatDetailsPresenter.kt","position":26,"original_position":26,"commit_id":"99a6a1adb0dab62e0baf7d7e26821d1aa7f5e47d","original_commit_id":"99a6a1adb0dab62e0baf7d7e26821d1aa7f5e47d","user":{"login":"Shailesh351","id":18264684,"node_id":"MDQ6VXNlcjE4MjY0Njg0","avatar_url":"https://avatars0.githubusercontent.com/u/18264684?v=4","gravatar_id":"","url":"https://api.github.com/users/Shailesh351","html_url":"https://github.com/Shailesh351","followers_url":"https://api.github.com/users/Shailesh351/followers","following_url":"https://api.github.com/users/Shailesh351/following{/other_user}","gists_url":"https://api.github.com/users/Shailesh351/gists{/gist_id}","starred_url":"https://api.github.com/users/Shailesh351/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shailesh351/subscriptions","organizations_url":"https://api.github.com/users/Shailesh351/orgs","repos_url":"https://api.github.com/users/Shailesh351/repos","events_url":"https://api.github.com/users/Shailesh351/events{/privacy}","received_events_url":"https://api.github.com/users/Shailesh351/received_events","type":"User","site_admin":false},"body":"Yes @ear-dev I will try to fix this in this PR only. Then we can merge.","created_at":"2019-08-27T15:04:32Z","updated_at":"2019-08-27T15:04:32Z","html_url":"https://github.com/WideChat/Rocket.Chat.Android/pull/614#discussion_r318134644","pull_request_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/pulls/614","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/pulls/comments/318134644"},"html":{"href":"https://github.com/WideChat/Rocket.Chat.Android/pull/614#discussion_r318134644"},"pull_request":{"href":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/pulls/614"}},"in_reply_to_id":316322473},"pull_request":{"url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/pulls/614","id":306522730,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2NTIyNzMw","html_url":"https://github.com/WideChat/Rocket.Chat.Android/pull/614","diff_url":"https://github.com/WideChat/Rocket.Chat.Android/pull/614.diff","patch_url":"https://github.com/WideChat/Rocket.Chat.Android/pull/614.patch","issue_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/issues/614","number":614,"state":"open","locked":false,"title":"[NEW] Add leave chat option in chat details","user":{"login":"Shailesh351","id":18264684,"node_id":"MDQ6VXNlcjE4MjY0Njg0","avatar_url":"https://avatars0.githubusercontent.com/u/18264684?v=4","gravatar_id":"","url":"https://api.github.com/users/Shailesh351","html_url":"https://github.com/Shailesh351","followers_url":"https://api.github.com/users/Shailesh351/followers","following_url":"https://api.github.com/users/Shailesh351/following{/other_user}","gists_url":"https://api.github.com/users/Shailesh351/gists{/gist_id}","starred_url":"https://api.github.com/users/Shailesh351/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shailesh351/subscriptions","organizations_url":"https://api.github.com/users/Shailesh351/orgs","repos_url":"https://api.github.com/users/Shailesh351/repos","events_url":"https://api.github.com/users/Shailesh351/events{/privacy}","received_events_url":"https://api.github.com/users/Shailesh351/received_events","type":"User","site_admin":false},"body":"Closes #537\r\n\r\n![Screenshot_20190812-195807](https://user-images.githubusercontent.com/18264684/62872772-cd80c800-bd3b-11e9-874b-5c5d9d095aa4.jpg)\r\n","created_at":"2019-08-12T14:31:33Z","updated_at":"2019-08-27T15:04:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"148277bbb3986eb6b56e66f90185d21e4a8a5cd0","assignee":{"login":"Shailesh351","id":18264684,"node_id":"MDQ6VXNlcjE4MjY0Njg0","avatar_url":"https://avatars0.githubusercontent.com/u/18264684?v=4","gravatar_id":"","url":"https://api.github.com/users/Shailesh351","html_url":"https://github.com/Shailesh351","followers_url":"https://api.github.com/users/Shailesh351/followers","following_url":"https://api.github.com/users/Shailesh351/following{/other_user}","gists_url":"https://api.github.com/users/Shailesh351/gists{/gist_id}","starred_url":"https://api.github.com/users/Shailesh351/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shailesh351/subscriptions","organizations_url":"https://api.github.com/users/Shailesh351/orgs","repos_url":"https://api.github.com/users/Shailesh351/repos","events_url":"https://api.github.com/users/Shailesh351/events{/privacy}","received_events_url":"https://api.github.com/users/Shailesh351/received_events","type":"User","site_admin":false},"assignees":[{"login":"Shailesh351","id":18264684,"node_id":"MDQ6VXNlcjE4MjY0Njg0","avatar_url":"https://avatars0.githubusercontent.com/u/18264684?v=4","gravatar_id":"","url":"https://api.github.com/users/Shailesh351","html_url":"https://github.com/Shailesh351","followers_url":"https://api.github.com/users/Shailesh351/followers","following_url":"https://api.github.com/users/Shailesh351/following{/other_user}","gists_url":"https://api.github.com/users/Shailesh351/gists{/gist_id}","starred_url":"https://api.github.com/users/Shailesh351/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shailesh351/subscriptions","organizations_url":"https://api.github.com/users/Shailesh351/orgs","repos_url":"https://api.github.com/users/Shailesh351/repos","events_url":"https://api.github.com/users/Shailesh351/events{/privacy}","received_events_url":"https://api.github.com/users/Shailesh351/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bizzbyster","id":4001792,"node_id":"MDQ6VXNlcjQwMDE3OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/4001792?v=4","gravatar_id":"","url":"https://api.github.com/users/bizzbyster","html_url":"https://github.com/bizzbyster","followers_url":"https://api.github.com/users/bizzbyster/followers","following_url":"https://api.github.com/users/bizzbyster/following{/other_user}","gists_url":"https://api.github.com/users/bizzbyster/gists{/gist_id}","starred_url":"https://api.github.com/users/bizzbyster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bizzbyster/subscriptions","organizations_url":"https://api.github.com/users/bizzbyster/orgs","repos_url":"https://api.github.com/users/bizzbyster/repos","events_url":"https://api.github.com/users/bizzbyster/events{/privacy}","received_events_url":"https://api.github.com/users/bizzbyster/received_events","type":"User","site_admin":false},{"login":"jaytat0","id":8495373,"node_id":"MDQ6VXNlcjg0OTUzNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/8495373?v=4","gravatar_id":"","url":"https://api.github.com/users/jaytat0","html_url":"https://github.com/jaytat0","followers_url":"https://api.github.com/users/jaytat0/followers","following_url":"https://api.github.com/users/jaytat0/following{/other_user}","gists_url":"https://api.github.com/users/jaytat0/gists{/gist_id}","starred_url":"https://api.github.com/users/jaytat0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaytat0/subscriptions","organizations_url":"https://api.github.com/users/jaytat0/orgs","repos_url":"https://api.github.com/users/jaytat0/repos","events_url":"https://api.github.com/users/jaytat0/events{/privacy}","received_events_url":"https://api.github.com/users/jaytat0/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/pulls/614/commits","review_comments_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/pulls/614/comments","review_comment_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/issues/614/comments","statuses_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/statuses/99a6a1adb0dab62e0baf7d7e26821d1aa7f5e47d","head":{"label":"Shailesh351:sb_leave_chat","ref":"sb_leave_chat","sha":"99a6a1adb0dab62e0baf7d7e26821d1aa7f5e47d","user":{"login":"Shailesh351","id":18264684,"node_id":"MDQ6VXNlcjE4MjY0Njg0","avatar_url":"https://avatars0.githubusercontent.com/u/18264684?v=4","gravatar_id":"","url":"https://api.github.com/users/Shailesh351","html_url":"https://github.com/Shailesh351","followers_url":"https://api.github.com/users/Shailesh351/followers","following_url":"https://api.github.com/users/Shailesh351/following{/other_user}","gists_url":"https://api.github.com/users/Shailesh351/gists{/gist_id}","starred_url":"https://api.github.com/users/Shailesh351/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shailesh351/subscriptions","organizations_url":"https://api.github.com/users/Shailesh351/orgs","repos_url":"https://api.github.com/users/Shailesh351/repos","events_url":"https://api.github.com/users/Shailesh351/events{/privacy}","received_events_url":"https://api.github.com/users/Shailesh351/received_events","type":"User","site_admin":false},"repo":{"id":121782145,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3ODIxNDU=","name":"Rocket.Chat.Android","full_name":"Shailesh351/Rocket.Chat.Android","private":false,"owner":{"login":"Shailesh351","id":18264684,"node_id":"MDQ6VXNlcjE4MjY0Njg0","avatar_url":"https://avatars0.githubusercontent.com/u/18264684?v=4","gravatar_id":"","url":"https://api.github.com/users/Shailesh351","html_url":"https://github.com/Shailesh351","followers_url":"https://api.github.com/users/Shailesh351/followers","following_url":"https://api.github.com/users/Shailesh351/following{/other_user}","gists_url":"https://api.github.com/users/Shailesh351/gists{/gist_id}","starred_url":"https://api.github.com/users/Shailesh351/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shailesh351/subscriptions","organizations_url":"https://api.github.com/users/Shailesh351/orgs","repos_url":"https://api.github.com/users/Shailesh351/repos","events_url":"https://api.github.com/users/Shailesh351/events{/privacy}","received_events_url":"https://api.github.com/users/Shailesh351/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Shailesh351/Rocket.Chat.Android","description":"Rocket.Chat Native Android Application","fork":true,"url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android","forks_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/forks","keys_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/teams","hooks_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/hooks","issue_events_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/issues/events{/number}","events_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/events","assignees_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/assignees{/user}","branches_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/branches{/branch}","tags_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/tags","blobs_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/statuses/{sha}","languages_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/languages","stargazers_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/stargazers","contributors_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/contributors","subscribers_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/subscribers","subscription_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/subscription","commits_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/contents/{+path}","compare_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/merges","archive_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/downloads","issues_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/issues{/number}","pulls_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/pulls{/number}","milestones_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/milestones{/number}","notifications_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/labels{/name}","releases_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/releases{/id}","deployments_url":"https://api.github.com/repos/Shailesh351/Rocket.Chat.Android/deployments","created_at":"2018-02-16T17:54:17Z","updated_at":"2019-07-03T17:13:47Z","pushed_at":"2019-08-26T18:33:53Z","git_url":"git://github.com/Shailesh351/Rocket.Chat.Android.git","ssh_url":"[email protected]:Shailesh351/Rocket.Chat.Android.git","clone_url":"https://github.com/Shailesh351/Rocket.Chat.Android.git","svn_url":"https://github.com/Shailesh351/Rocket.Chat.Android","homepage":"https://rocket.chat","size":21314,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":0,"watchers":0,"default_branch":"veranda"}},"base":{"label":"WideChat:veranda","ref":"veranda","sha":"3c8f75416133b805aadd7b2f667772ae0d3aeb55","user":{"login":"WideChat","id":36538368,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTM4MzY4","avatar_url":"https://avatars2.githubusercontent.com/u/36538368?v=4","gravatar_id":"","url":"https://api.github.com/users/WideChat","html_url":"https://github.com/WideChat","followers_url":"https://api.github.com/users/WideChat/followers","following_url":"https://api.github.com/users/WideChat/following{/other_user}","gists_url":"https://api.github.com/users/WideChat/gists{/gist_id}","starred_url":"https://api.github.com/users/WideChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WideChat/subscriptions","organizations_url":"https://api.github.com/users/WideChat/orgs","repos_url":"https://api.github.com/users/WideChat/repos","events_url":"https://api.github.com/users/WideChat/events{/privacy}","received_events_url":"https://api.github.com/users/WideChat/received_events","type":"Organization","site_admin":false},"repo":{"id":121754060,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE3NTQwNjA=","name":"Rocket.Chat.Android","full_name":"WideChat/Rocket.Chat.Android","private":false,"owner":{"login":"WideChat","id":36538368,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTM4MzY4","avatar_url":"https://avatars2.githubusercontent.com/u/36538368?v=4","gravatar_id":"","url":"https://api.github.com/users/WideChat","html_url":"https://github.com/WideChat","followers_url":"https://api.github.com/users/WideChat/followers","following_url":"https://api.github.com/users/WideChat/following{/other_user}","gists_url":"https://api.github.com/users/WideChat/gists{/gist_id}","starred_url":"https://api.github.com/users/WideChat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WideChat/subscriptions","organizations_url":"https://api.github.com/users/WideChat/orgs","repos_url":"https://api.github.com/users/WideChat/repos","events_url":"https://api.github.com/users/WideChat/events{/privacy}","received_events_url":"https://api.github.com/users/WideChat/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WideChat/Rocket.Chat.Android","description":"Rocket.Chat Native Android Application","fork":true,"url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android","forks_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/forks","keys_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/teams","hooks_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/hooks","issue_events_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/issues/events{/number}","events_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/events","assignees_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/assignees{/user}","branches_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/branches{/branch}","tags_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/tags","blobs_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/statuses/{sha}","languages_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/languages","stargazers_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/stargazers","contributors_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/contributors","subscribers_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/subscribers","subscription_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/subscription","commits_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/contents/{+path}","compare_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/merges","archive_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/downloads","issues_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/issues{/number}","pulls_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/pulls{/number}","milestones_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/milestones{/number}","notifications_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/labels{/name}","releases_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/releases{/id}","deployments_url":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/deployments","created_at":"2018-02-16T13:31:30Z","updated_at":"2019-08-26T19:35:16Z","pushed_at":"2019-08-26T19:35:14Z","git_url":"git://github.com/WideChat/Rocket.Chat.Android.git","ssh_url":"[email protected]:WideChat/Rocket.Chat.Android.git","clone_url":"https://github.com/WideChat/Rocket.Chat.Android.git","svn_url":"https://github.com/WideChat/Rocket.Chat.Android","homepage":"https://rocket.chat","size":27909,"stargazers_count":11,"watchers_count":11,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":163,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":163,"watchers":11,"default_branch":"veranda"}},"_links":{"self":{"href":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/pulls/614"},"html":{"href":"https://github.com/WideChat/Rocket.Chat.Android/pull/614"},"issue":{"href":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/issues/614"},"comments":{"href":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/issues/614/comments"},"review_comments":{"href":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/pulls/614/comments"},"review_comment":{"href":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/pulls/614/commits"},"statuses":{"href":"https://api.github.com/repos/WideChat/Rocket.Chat.Android/statuses/99a6a1adb0dab62e0baf7d7e26821d1aa7f5e47d"}},"author_association":"COLLABORATOR"}}	{ "id": 121754060, "name": "WideChat/Rocket.Chat.Android", "url": "https://api.github.com/repos/WideChat/Rocket.Chat.Android" }	{ "id": 18264684, "login": "Shailesh351", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/18264684?", "url": "https://api.github.com/users/Shailesh351" }	{ "id": 36538368, "login": "WideChat", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/36538368?", "url": "https://api.github.com/orgs/WideChat" }	2019-08-27T20:34:32	10292775074	{"actor":{"display_login":"Shailesh351"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/dddwa/dddperth-website/pulls/comments/307985883","pull_request_review_id":267490412,"id":307985883,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzk4NTg4Mw==","diff_hunk":"@@ -0,0 +1,181 @@\n+import { Moment } from 'moment'\n+import React from 'react'\n+import { Session } from '../../config/types'\n+import dateTimeProvider from './dateTimeProvider'\n+\n+type SessionId = string // UUID\n+\n+export interface SessionGroup {\n+ timeStart: Moment\n+ timeEnd: Moment\n+ sessions: Session[]\n+}\n+\n+interface SessionGroups {\n+ allSessionGroups: SessionGroup[]\n+ currentSessionGroup?: SessionGroup\n+ previousSessionGroup?: SessionGroup\n+ nextSessionGroup?: SessionGroup\n+ pastSessionGroups?: SessionGroup[]\n+ futureSessionGroups?: SessionGroup[]\n+}\n+\n+function getSessionById(sessions: Session[], ids: SessionId[]) {\n+ return sessions.filter(session => ids.includes(session.Id))\n+}\n+\n+// Creates the session groups.\n+// Important: Order is assumed to be correct.\n+function createSessionGroups(conferenceDate: Moment, sessions: Session[]): SessionGroup[] {","path":"components/utils/useSessionGroups.ts","position":29,"original_position":29,"commit_id":"f5fa43bc62816edfadf4286e94ab32e1fe92cc77","original_commit_id":"3bb252b7fa3c6015e424607cdaeba7b190d32dc5","user":{"login":"antonjb","id":1066856,"node_id":"MDQ6VXNlcjEwNjY4NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1066856?v=4","gravatar_id":"","url":"https://api.github.com/users/antonjb","html_url":"https://github.com/antonjb","followers_url":"https://api.github.com/users/antonjb/followers","following_url":"https://api.github.com/users/antonjb/following{/other_user}","gists_url":"https://api.github.com/users/antonjb/gists{/gist_id}","starred_url":"https://api.github.com/users/antonjb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonjb/subscriptions","organizations_url":"https://api.github.com/users/antonjb/orgs","repos_url":"https://api.github.com/users/antonjb/repos","events_url":"https://api.github.com/users/antonjb/events{/privacy}","received_events_url":"https://api.github.com/users/antonjb/received_events","type":"User","site_admin":false},"body":"Good point, not the best home for this. Ideally it would set the agenda page up too but I'm not sure how to structure that yet with breaks etc. Perhaps more thought is needed on the data structure","created_at":"2019-07-28T05:25:12Z","updated_at":"2019-07-28T05:25:12Z","html_url":"https://github.com/dddwa/dddperth-website/pull/214#discussion_r307985883","pull_request_url":"https://api.github.com/repos/dddwa/dddperth-website/pulls/214","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dddwa/dddperth-website/pulls/comments/307985883"},"html":{"href":"https://github.com/dddwa/dddperth-website/pull/214#discussion_r307985883"},"pull_request":{"href":"https://api.github.com/repos/dddwa/dddperth-website/pulls/214"}},"in_reply_to_id":307984602},"pull_request":{"url":"https://api.github.com/repos/dddwa/dddperth-website/pulls/214","id":301552679,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAxNTUyNjc5","html_url":"https://github.com/dddwa/dddperth-website/pull/214","diff_url":"https://github.com/dddwa/dddperth-website/pull/214.diff","patch_url":"https://github.com/dddwa/dddperth-website/pull/214.patch","issue_url":"https://api.github.com/repos/dddwa/dddperth-website/issues/214","number":214,"state":"open","locked":false,"title":"RFC: Adds session feedback page","user":{"login":"antonjb","id":1066856,"node_id":"MDQ6VXNlcjEwNjY4NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1066856?v=4","gravatar_id":"","url":"https://api.github.com/users/antonjb","html_url":"https://github.com/antonjb","followers_url":"https://api.github.com/users/antonjb/followers","following_url":"https://api.github.com/users/antonjb/following{/other_user}","gists_url":"https://api.github.com/users/antonjb/gists{/gist_id}","starred_url":"https://api.github.com/users/antonjb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonjb/subscriptions","organizations_url":"https://api.github.com/users/antonjb/orgs","repos_url":"https://api.github.com/users/antonjb/repos","events_url":"https://api.github.com/users/antonjb/events{/privacy}","received_events_url":"https://api.github.com/users/antonjb/received_events","type":"User","site_admin":false},"body":"Would like feedback on the approach I have taken for this. Things that I\r\nhave introduced:\r\n\r\nuseSession hook\r\nhandles front end loading of Sessions. Added to Agenda and Feedback page\r\nMostly similar to what we have no but in hook form with reducer. Also\r\nhouses the loading code for SSR. I feel like this could be joined together\r\nsomehow because they're repeating. Any input would be good. Suspect CSR\r\nsupports async so it might basically be there\r\n\r\nuseSessionGroup hook\r\nThis is probably the biggest thing I need eyes on. The purpose is to keep\r\nthe sessions in groups and then be able to know what the past sessions,\r\nprevious sessions, current sessions, next sessions and future sessions are.\r\nThe gaps made this more difficult than I would have liked\r\n\r\nHow I see this being used:\r\n* Show the previous sessions on the feedback page (done)\r\n* Past sessions in a show/hide under the previous session on feedback page (done)\r\n* Show the next sessions at the top of the agenda page without needing to hunt for it (todo)\r\n\r\nThe code for calculating it seems like it could use improvement. I have\r\ntried several variations on this and trying to memoize it because of how\r\nfrequently it runs. The current version is great for memoization but maybe\r\na little gross. Setting up groups also leaves a little to be desired.\r\n\r\nuseForm hook\r\nHook that handles changing in form and calling a submit callback.\r\n\r\nstorageKey helper\r\nSmall helper function when we are using local storage\r\n\r\nFinally is the feedback page. I have added test buttons here to be able to\r\njump between times to see the sessions. I have gone with the traffic like\r\napproach but need input on how to display that.\r\n\r\nTL;DR\r\n* Hooks all the things\r\n* Can I improve useSessionGroups? Particularly the logic calculating the state\r\n* Feedback page - what do we think?","created_at":"2019-07-26T13:58:46Z","updated_at":"2019-07-28T05:25:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e049c9d8ba8cf96f759421f4955f4a56a234ef94","assignee":null,"assignees":[],"requested_reviewers":[{"login":"aidanmorgan","id":820072,"node_id":"MDQ6VXNlcjgyMDA3Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/820072?v=4","gravatar_id":"","url":"https://api.github.com/users/aidanmorgan","html_url":"https://github.com/aidanmorgan","followers_url":"https://api.github.com/users/aidanmorgan/followers","following_url":"https://api.github.com/users/aidanmorgan/following{/other_user}","gists_url":"https://api.github.com/users/aidanmorgan/gists{/gist_id}","starred_url":"https://api.github.com/users/aidanmorgan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidanmorgan/subscriptions","organizations_url":"https://api.github.com/users/aidanmorgan/orgs","repos_url":"https://api.github.com/users/aidanmorgan/repos","events_url":"https://api.github.com/users/aidanmorgan/events{/privacy}","received_events_url":"https://api.github.com/users/aidanmorgan/received_events","type":"User","site_admin":false},{"login":"mzaatar","id":4103517,"node_id":"MDQ6VXNlcjQxMDM1MTc=","avatar_url":"https://avatars2.githubusercontent.com/u/4103517?v=4","gravatar_id":"","url":"https://api.github.com/users/mzaatar","html_url":"https://github.com/mzaatar","followers_url":"https://api.github.com/users/mzaatar/followers","following_url":"https://api.github.com/users/mzaatar/following{/other_user}","gists_url":"https://api.github.com/users/mzaatar/gists{/gist_id}","starred_url":"https://api.github.com/users/mzaatar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzaatar/subscriptions","organizations_url":"https://api.github.com/users/mzaatar/orgs","repos_url":"https://api.github.com/users/mzaatar/repos","events_url":"https://api.github.com/users/mzaatar/events{/privacy}","received_events_url":"https://api.github.com/users/mzaatar/received_events","type":"User","site_admin":false},{"login":"amykapernick","id":15953185,"node_id":"MDQ6VXNlcjE1OTUzMTg1","avatar_url":"https://avatars2.githubusercontent.com/u/15953185?v=4","gravatar_id":"","url":"https://api.github.com/users/amykapernick","html_url":"https://github.com/amykapernick","followers_url":"https://api.github.com/users/amykapernick/followers","following_url":"https://api.github.com/users/amykapernick/following{/other_user}","gists_url":"https://api.github.com/users/amykapernick/gists{/gist_id}","starred_url":"https://api.github.com/users/amykapernick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amykapernick/subscriptions","organizations_url":"https://api.github.com/users/amykapernick/orgs","repos_url":"https://api.github.com/users/amykapernick/repos","events_url":"https://api.github.com/users/amykapernick/events{/privacy}","received_events_url":"https://api.github.com/users/amykapernick/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dddwa/dddperth-website/pulls/214/commits","review_comments_url":"https://api.github.com/repos/dddwa/dddperth-website/pulls/214/comments","review_comment_url":"https://api.github.com/repos/dddwa/dddperth-website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dddwa/dddperth-website/issues/214/comments","statuses_url":"https://api.github.com/repos/dddwa/dddperth-website/statuses/f5fa43bc62816edfadf4286e94ab32e1fe92cc77","head":{"label":"dddwa:feature/209_user-facing-voting","ref":"feature/209_user-facing-voting","sha":"f5fa43bc62816edfadf4286e94ab32e1fe92cc77","user":{"login":"dddwa","id":36904874,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2OTA0ODc0","avatar_url":"https://avatars0.githubusercontent.com/u/36904874?v=4","gravatar_id":"","url":"https://api.github.com/users/dddwa","html_url":"https://github.com/dddwa","followers_url":"https://api.github.com/users/dddwa/followers","following_url":"https://api.github.com/users/dddwa/following{/other_user}","gists_url":"https://api.github.com/users/dddwa/gists{/gist_id}","starred_url":"https://api.github.com/users/dddwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dddwa/subscriptions","organizations_url":"https://api.github.com/users/dddwa/orgs","repos_url":"https://api.github.com/users/dddwa/repos","events_url":"https://api.github.com/users/dddwa/events{/privacy}","received_events_url":"https://api.github.com/users/dddwa/received_events","type":"Organization","site_admin":false},"repo":{"id":123206060,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMyMDYwNjA=","name":"dddperth-website","full_name":"dddwa/dddperth-website","private":false,"owner":{"login":"dddwa","id":36904874,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2OTA0ODc0","avatar_url":"https://avatars0.githubusercontent.com/u/36904874?v=4","gravatar_id":"","url":"https://api.github.com/users/dddwa","html_url":"https://github.com/dddwa","followers_url":"https://api.github.com/users/dddwa/followers","following_url":"https://api.github.com/users/dddwa/following{/other_user}","gists_url":"https://api.github.com/users/dddwa/gists{/gist_id}","starred_url":"https://api.github.com/users/dddwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dddwa/subscriptions","organizations_url":"https://api.github.com/users/dddwa/orgs","repos_url":"https://api.github.com/users/dddwa/repos","events_url":"https://api.github.com/users/dddwa/events{/privacy}","received_events_url":"https://api.github.com/users/dddwa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dddwa/dddperth-website","description":"The website for the DDD Perth conference.","fork":false,"url":"https://api.github.com/repos/dddwa/dddperth-website","forks_url":"https://api.github.com/repos/dddwa/dddperth-website/forks","keys_url":"https://api.github.com/repos/dddwa/dddperth-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dddwa/dddperth-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dddwa/dddperth-website/teams","hooks_url":"https://api.github.com/repos/dddwa/dddperth-website/hooks","issue_events_url":"https://api.github.com/repos/dddwa/dddperth-website/issues/events{/number}","events_url":"https://api.github.com/repos/dddwa/dddperth-website/events","assignees_url":"https://api.github.com/repos/dddwa/dddperth-website/assignees{/user}","branches_url":"https://api.github.com/repos/dddwa/dddperth-website/branches{/branch}","tags_url":"https://api.github.com/repos/dddwa/dddperth-website/tags","blobs_url":"https://api.github.com/repos/dddwa/dddperth-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dddwa/dddperth-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dddwa/dddperth-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/dddwa/dddperth-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dddwa/dddperth-website/statuses/{sha}","languages_url":"https://api.github.com/repos/dddwa/dddperth-website/languages","stargazers_url":"https://api.github.com/repos/dddwa/dddperth-website/stargazers","contributors_url":"https://api.github.com/repos/dddwa/dddperth-website/contributors","subscribers_url":"https://api.github.com/repos/dddwa/dddperth-website/subscribers","subscription_url":"https://api.github.com/repos/dddwa/dddperth-website/subscription","commits_url":"https://api.github.com/repos/dddwa/dddperth-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/dddwa/dddperth-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/dddwa/dddperth-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/dddwa/dddperth-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/dddwa/dddperth-website/contents/{+path}","compare_url":"https://api.github.com/repos/dddwa/dddperth-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dddwa/dddperth-website/merges","archive_url":"https://api.github.com/repos/dddwa/dddperth-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dddwa/dddperth-website/downloads","issues_url":"https://api.github.com/repos/dddwa/dddperth-website/issues{/number}","pulls_url":"https://api.github.com/repos/dddwa/dddperth-website/pulls{/number}","milestones_url":"https://api.github.com/repos/dddwa/dddperth-website/milestones{/number}","notifications_url":"https://api.github.com/repos/dddwa/dddperth-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dddwa/dddperth-website/labels{/name}","releases_url":"https://api.github.com/repos/dddwa/dddperth-website/releases{/id}","deployments_url":"https://api.github.com/repos/dddwa/dddperth-website/deployments","created_at":"2018-02-28T00:31:52Z","updated_at":"2019-07-27T16:33:09Z","pushed_at":"2019-07-27T23:44:36Z","git_url":"git://github.com/dddwa/dddperth-website.git","ssh_url":"[email protected]:dddwa/dddperth-website.git","clone_url":"https://github.com/dddwa/dddperth-website.git","svn_url":"https://github.com/dddwa/dddperth-website","homepage":null,"size":14045,"stargazers_count":9,"watchers_count":9,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":8,"watchers":9,"default_branch":"master"}},"base":{"label":"dddwa:master","ref":"master","sha":"66bf8e77f8c81d8d211132431d4d2e727e04e475","user":{"login":"dddwa","id":36904874,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2OTA0ODc0","avatar_url":"https://avatars0.githubusercontent.com/u/36904874?v=4","gravatar_id":"","url":"https://api.github.com/users/dddwa","html_url":"https://github.com/dddwa","followers_url":"https://api.github.com/users/dddwa/followers","following_url":"https://api.github.com/users/dddwa/following{/other_user}","gists_url":"https://api.github.com/users/dddwa/gists{/gist_id}","starred_url":"https://api.github.com/users/dddwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dddwa/subscriptions","organizations_url":"https://api.github.com/users/dddwa/orgs","repos_url":"https://api.github.com/users/dddwa/repos","events_url":"https://api.github.com/users/dddwa/events{/privacy}","received_events_url":"https://api.github.com/users/dddwa/received_events","type":"Organization","site_admin":false},"repo":{"id":123206060,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMyMDYwNjA=","name":"dddperth-website","full_name":"dddwa/dddperth-website","private":false,"owner":{"login":"dddwa","id":36904874,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2OTA0ODc0","avatar_url":"https://avatars0.githubusercontent.com/u/36904874?v=4","gravatar_id":"","url":"https://api.github.com/users/dddwa","html_url":"https://github.com/dddwa","followers_url":"https://api.github.com/users/dddwa/followers","following_url":"https://api.github.com/users/dddwa/following{/other_user}","gists_url":"https://api.github.com/users/dddwa/gists{/gist_id}","starred_url":"https://api.github.com/users/dddwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dddwa/subscriptions","organizations_url":"https://api.github.com/users/dddwa/orgs","repos_url":"https://api.github.com/users/dddwa/repos","events_url":"https://api.github.com/users/dddwa/events{/privacy}","received_events_url":"https://api.github.com/users/dddwa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dddwa/dddperth-website","description":"The website for the DDD Perth conference.","fork":false,"url":"https://api.github.com/repos/dddwa/dddperth-website","forks_url":"https://api.github.com/repos/dddwa/dddperth-website/forks","keys_url":"https://api.github.com/repos/dddwa/dddperth-website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dddwa/dddperth-website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dddwa/dddperth-website/teams","hooks_url":"https://api.github.com/repos/dddwa/dddperth-website/hooks","issue_events_url":"https://api.github.com/repos/dddwa/dddperth-website/issues/events{/number}","events_url":"https://api.github.com/repos/dddwa/dddperth-website/events","assignees_url":"https://api.github.com/repos/dddwa/dddperth-website/assignees{/user}","branches_url":"https://api.github.com/repos/dddwa/dddperth-website/branches{/branch}","tags_url":"https://api.github.com/repos/dddwa/dddperth-website/tags","blobs_url":"https://api.github.com/repos/dddwa/dddperth-website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dddwa/dddperth-website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dddwa/dddperth-website/git/refs{/sha}","trees_url":"https://api.github.com/repos/dddwa/dddperth-website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dddwa/dddperth-website/statuses/{sha}","languages_url":"https://api.github.com/repos/dddwa/dddperth-website/languages","stargazers_url":"https://api.github.com/repos/dddwa/dddperth-website/stargazers","contributors_url":"https://api.github.com/repos/dddwa/dddperth-website/contributors","subscribers_url":"https://api.github.com/repos/dddwa/dddperth-website/subscribers","subscription_url":"https://api.github.com/repos/dddwa/dddperth-website/subscription","commits_url":"https://api.github.com/repos/dddwa/dddperth-website/commits{/sha}","git_commits_url":"https://api.github.com/repos/dddwa/dddperth-website/git/commits{/sha}","comments_url":"https://api.github.com/repos/dddwa/dddperth-website/comments{/number}","issue_comment_url":"https://api.github.com/repos/dddwa/dddperth-website/issues/comments{/number}","contents_url":"https://api.github.com/repos/dddwa/dddperth-website/contents/{+path}","compare_url":"https://api.github.com/repos/dddwa/dddperth-website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dddwa/dddperth-website/merges","archive_url":"https://api.github.com/repos/dddwa/dddperth-website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dddwa/dddperth-website/downloads","issues_url":"https://api.github.com/repos/dddwa/dddperth-website/issues{/number}","pulls_url":"https://api.github.com/repos/dddwa/dddperth-website/pulls{/number}","milestones_url":"https://api.github.com/repos/dddwa/dddperth-website/milestones{/number}","notifications_url":"https://api.github.com/repos/dddwa/dddperth-website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dddwa/dddperth-website/labels{/name}","releases_url":"https://api.github.com/repos/dddwa/dddperth-website/releases{/id}","deployments_url":"https://api.github.com/repos/dddwa/dddperth-website/deployments","created_at":"2018-02-28T00:31:52Z","updated_at":"2019-07-27T16:33:09Z","pushed_at":"2019-07-27T23:44:36Z","git_url":"git://github.com/dddwa/dddperth-website.git","ssh_url":"[email protected]:dddwa/dddperth-website.git","clone_url":"https://github.com/dddwa/dddperth-website.git","svn_url":"https://github.com/dddwa/dddperth-website","homepage":null,"size":14045,"stargazers_count":9,"watchers_count":9,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":8,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dddwa/dddperth-website/pulls/214"},"html":{"href":"https://github.com/dddwa/dddperth-website/pull/214"},"issue":{"href":"https://api.github.com/repos/dddwa/dddperth-website/issues/214"},"comments":{"href":"https://api.github.com/repos/dddwa/dddperth-website/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/dddwa/dddperth-website/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/dddwa/dddperth-website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dddwa/dddperth-website/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/dddwa/dddperth-website/statuses/f5fa43bc62816edfadf4286e94ab32e1fe92cc77"}},"author_association":"CONTRIBUTOR"}}	{ "id": 123206060, "name": "dddwa/dddperth-website", "url": "https://api.github.com/repos/dddwa/dddperth-website" }	{ "id": 1066856, "login": "antonjb", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/1066856?", "url": "https://api.github.com/users/antonjb" }	{ "id": 36904874, "login": "dddwa", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/36904874?", "url": "https://api.github.com/orgs/dddwa" }	2019-07-28T05:25:12	10097405049	{"actor":{"display_login":"antonjb"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/pulls/comments/255353775","pull_request_review_id":201919952,"id":255353775,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NTM1Mzc3NQ==","diff_hunk":"@@ -0,0 +1,39 @@\n+/*\n+ Copyright 2018 Google LLC\n+ \n+ Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ \n+ http://www.apache.org/licenses/LICENSE-2.0\n+ \n+ Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ /\n+\n+/***************************************\n+ Provider configuration\n+ ***************************************/\n+provider \"google\" {\n+ version = \"~> 1.20.0\"\n+\n+ # credentials = \"${file(local.credentials_file_path)}\"","path":"examples/basic_bq/main.tf","position":23,"original_position":23,"commit_id":"d9602c1648ea2d4ce35ba12c77f48d5196eabf80","original_commit_id":"d9602c1648ea2d4ce35ba12c77f48d5196eabf80","user":{"login":"tdigangi","id":38962493,"node_id":"MDQ6VXNlcjM4OTYyNDkz","avatar_url":"https://avatars3.githubusercontent.com/u/38962493?v=4","gravatar_id":"","url":"https://api.github.com/users/tdigangi","html_url":"https://github.com/tdigangi","followers_url":"https://api.github.com/users/tdigangi/followers","following_url":"https://api.github.com/users/tdigangi/following{/other_user}","gists_url":"https://api.github.com/users/tdigangi/gists{/gist_id}","starred_url":"https://api.github.com/users/tdigangi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdigangi/subscriptions","organizations_url":"https://api.github.com/users/tdigangi/orgs","repos_url":"https://api.github.com/users/tdigangi/repos","events_url":"https://api.github.com/users/tdigangi/events{/privacy}","received_events_url":"https://api.github.com/users/tdigangi/received_events","type":"User","site_admin":false},"body":"Will be dropped in the next release","created_at":"2019-02-10T20:22:30Z","updated_at":"2019-02-10T20:22:30Z","html_url":"https://github.com/terraform-google-modules/terraform-google-bigquery/pull/3#discussion_r255353775","pull_request_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/pulls/comments/255353775"},"html":{"href":"https://github.com/terraform-google-modules/terraform-google-bigquery/pull/3#discussion_r255353775"},"pull_request":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/pulls/3"}},"in_reply_to_id":251551738},"pull_request":{"url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/pulls/3","id":245634026,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ1NjM0MDI2","html_url":"https://github.com/terraform-google-modules/terraform-google-bigquery/pull/3","diff_url":"https://github.com/terraform-google-modules/terraform-google-bigquery/pull/3.diff","patch_url":"https://github.com/terraform-google-modules/terraform-google-bigquery/pull/3.patch","issue_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/issues/3","number":3,"state":"open","locked":false,"title":"bq v0.0.1","user":{"login":"tdigangi","id":38962493,"node_id":"MDQ6VXNlcjM4OTYyNDkz","avatar_url":"https://avatars3.githubusercontent.com/u/38962493?v=4","gravatar_id":"","url":"https://api.github.com/users/tdigangi","html_url":"https://github.com/tdigangi","followers_url":"https://api.github.com/users/tdigangi/followers","following_url":"https://api.github.com/users/tdigangi/following{/other_user}","gists_url":"https://api.github.com/users/tdigangi/gists{/gist_id}","starred_url":"https://api.github.com/users/tdigangi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdigangi/subscriptions","organizations_url":"https://api.github.com/users/tdigangi/orgs","repos_url":"https://api.github.com/users/tdigangi/repos","events_url":"https://api.github.com/users/tdigangi/events{/privacy}","received_events_url":"https://api.github.com/users/tdigangi/received_events","type":"User","site_admin":false},"body":"@morgante this module is ready for peer review.","created_at":"2019-01-17T20:24:48Z","updated_at":"2019-02-10T20:22:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3fba578aeb4f6860d1f6a8689c2c1988361d385","assignee":null,"assignees":[],"requested_reviewers":[{"login":"morgante","id":1627801,"node_id":"MDQ6VXNlcjE2Mjc4MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1627801?v=4","gravatar_id":"","url":"https://api.github.com/users/morgante","html_url":"https://github.com/morgante","followers_url":"https://api.github.com/users/morgante/followers","following_url":"https://api.github.com/users/morgante/following{/other_user}","gists_url":"https://api.github.com/users/morgante/gists{/gist_id}","starred_url":"https://api.github.com/users/morgante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morgante/subscriptions","organizations_url":"https://api.github.com/users/morgante/orgs","repos_url":"https://api.github.com/users/morgante/repos","events_url":"https://api.github.com/users/morgante/events{/privacy}","received_events_url":"https://api.github.com/users/morgante/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/pulls/3/commits","review_comments_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/pulls/3/comments","review_comment_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/issues/3/comments","statuses_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/statuses/d9602c1648ea2d4ce35ba12c77f48d5196eabf80","head":{"label":"tdigangi:master","ref":"master","sha":"d9602c1648ea2d4ce35ba12c77f48d5196eabf80","user":{"login":"tdigangi","id":38962493,"node_id":"MDQ6VXNlcjM4OTYyNDkz","avatar_url":"https://avatars3.githubusercontent.com/u/38962493?v=4","gravatar_id":"","url":"https://api.github.com/users/tdigangi","html_url":"https://github.com/tdigangi","followers_url":"https://api.github.com/users/tdigangi/followers","following_url":"https://api.github.com/users/tdigangi/following{/other_user}","gists_url":"https://api.github.com/users/tdigangi/gists{/gist_id}","starred_url":"https://api.github.com/users/tdigangi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdigangi/subscriptions","organizations_url":"https://api.github.com/users/tdigangi/orgs","repos_url":"https://api.github.com/users/tdigangi/repos","events_url":"https://api.github.com/users/tdigangi/events{/privacy}","received_events_url":"https://api.github.com/users/tdigangi/received_events","type":"User","site_admin":false},"repo":{"id":153645368,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2NDUzNjg=","name":"terraform-google-bigquery","full_name":"tdigangi/terraform-google-bigquery","private":false,"owner":{"login":"tdigangi","id":38962493,"node_id":"MDQ6VXNlcjM4OTYyNDkz","avatar_url":"https://avatars3.githubusercontent.com/u/38962493?v=4","gravatar_id":"","url":"https://api.github.com/users/tdigangi","html_url":"https://github.com/tdigangi","followers_url":"https://api.github.com/users/tdigangi/followers","following_url":"https://api.github.com/users/tdigangi/following{/other_user}","gists_url":"https://api.github.com/users/tdigangi/gists{/gist_id}","starred_url":"https://api.github.com/users/tdigangi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdigangi/subscriptions","organizations_url":"https://api.github.com/users/tdigangi/orgs","repos_url":"https://api.github.com/users/tdigangi/repos","events_url":"https://api.github.com/users/tdigangi/events{/privacy}","received_events_url":"https://api.github.com/users/tdigangi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tdigangi/terraform-google-bigquery","description":null,"fork":true,"url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery","forks_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/forks","keys_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/teams","hooks_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/hooks","issue_events_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/issues/events{/number}","events_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/events","assignees_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/assignees{/user}","branches_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/branches{/branch}","tags_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/tags","blobs_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/statuses/{sha}","languages_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/languages","stargazers_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/stargazers","contributors_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/contributors","subscribers_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/subscribers","subscription_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/subscription","commits_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/contents/{+path}","compare_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/merges","archive_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/downloads","issues_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/issues{/number}","pulls_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/pulls{/number}","milestones_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/milestones{/number}","notifications_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/labels{/name}","releases_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/releases{/id}","deployments_url":"https://api.github.com/repos/tdigangi/terraform-google-bigquery/deployments","created_at":"2018-10-18T15:19:44Z","updated_at":"2019-01-28T17:44:53Z","pushed_at":"2019-01-28T17:44:51Z","git_url":"git://github.com/tdigangi/terraform-google-bigquery.git","ssh_url":"[email protected]:tdigangi/terraform-google-bigquery.git","clone_url":"https://github.com/tdigangi/terraform-google-bigquery.git","svn_url":"https://github.com/tdigangi/terraform-google-bigquery","homepage":null,"size":60,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-google-modules:master","ref":"master","sha":"e13731620fa8f786c489e8dfedf3e0e9155427a0","user":{"login":"terraform-google-modules","id":37194493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTk0NDkz","avatar_url":"https://avatars3.githubusercontent.com/u/37194493?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-google-modules","html_url":"https://github.com/terraform-google-modules","followers_url":"https://api.github.com/users/terraform-google-modules/followers","following_url":"https://api.github.com/users/terraform-google-modules/following{/other_user}","gists_url":"https://api.github.com/users/terraform-google-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-google-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-google-modules/subscriptions","organizations_url":"https://api.github.com/users/terraform-google-modules/orgs","repos_url":"https://api.github.com/users/terraform-google-modules/repos","events_url":"https://api.github.com/users/terraform-google-modules/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-google-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":153479195,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM0NzkxOTU=","name":"terraform-google-bigquery","full_name":"terraform-google-modules/terraform-google-bigquery","private":false,"owner":{"login":"terraform-google-modules","id":37194493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTk0NDkz","avatar_url":"https://avatars3.githubusercontent.com/u/37194493?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-google-modules","html_url":"https://github.com/terraform-google-modules","followers_url":"https://api.github.com/users/terraform-google-modules/followers","following_url":"https://api.github.com/users/terraform-google-modules/following{/other_user}","gists_url":"https://api.github.com/users/terraform-google-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-google-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-google-modules/subscriptions","organizations_url":"https://api.github.com/users/terraform-google-modules/orgs","repos_url":"https://api.github.com/users/terraform-google-modules/repos","events_url":"https://api.github.com/users/terraform-google-modules/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-google-modules/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/terraform-google-modules/terraform-google-bigquery","description":null,"fork":false,"url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery","forks_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/forks","keys_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/teams","hooks_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/hooks","issue_events_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/events","assignees_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/tags","blobs_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/languages","stargazers_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/stargazers","contributors_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/contributors","subscribers_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/subscribers","subscription_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/subscription","commits_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/merges","archive_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/downloads","issues_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/labels{/name}","releases_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/deployments","created_at":"2018-10-17T15:20:30Z","updated_at":"2018-10-17T15:20:34Z","pushed_at":"2019-01-28T17:44:52Z","git_url":"git://github.com/terraform-google-modules/terraform-google-bigquery.git","ssh_url":"[email protected]:terraform-google-modules/terraform-google-bigquery.git","clone_url":"https://github.com/terraform-google-modules/terraform-google-bigquery.git","svn_url":"https://github.com/terraform-google-modules/terraform-google-bigquery","homepage":null,"size":4,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/pulls/3"},"html":{"href":"https://github.com/terraform-google-modules/terraform-google-bigquery/pull/3"},"issue":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/issues/3"},"comments":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery/statuses/d9602c1648ea2d4ce35ba12c77f48d5196eabf80"}},"author_association":"NONE"}}	{ "id": 153479195, "name": "terraform-google-modules/terraform-google-bigquery", "url": "https://api.github.com/repos/terraform-google-modules/terraform-google-bigquery" }	{ "id": 38962493, "login": "tdigangi", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/38962493?", "url": "https://api.github.com/users/tdigangi" }	{ "id": 37194493, "login": "terraform-google-modules", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/37194493?", "url": "https://api.github.com/orgs/terraform-google-modules" }	2019-02-10T20:22:30	9040932886	{"actor":{"display_login":"tdigangi"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/pulls/comments/258476794","pull_request_review_id":205746665,"id":258476794,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1ODQ3Njc5NA==","diff_hunk":"@@ -49,10 +48,10 @@ def test_run_inference(self, resnet_8_batch_model_downloader,\n print(\"Downloaded model files:\", resnet_8_batch_model_downloader)\r\n \r\n # Starting docker with ie-serving\r\n- result = start_server_batch_model\r\n- print(\"docker starting status:\", result)\r\n- time.sleep(15) # Waiting for inference service to load models\r\n- assert result == 0, \"docker container was not started successfully\"\r\n+ container = start_server_batch_model\r\n+ running, logs = wait_endpoint_setup(container)\r\n+ print(\"Logs from container: \", logs)\r","path":"tests/functional/test_batching.py","position":28,"original_position":28,"commit_id":"7a8015c889e405cb9d0d7daf4f1d0253876b67be","original_commit_id":"7a8015c889e405cb9d0d7daf4f1d0253876b67be","user":{"login":"pawel-pieniazek","id":12857071,"node_id":"MDQ6VXNlcjEyODU3MDcx","avatar_url":"https://avatars0.githubusercontent.com/u/12857071?v=4","gravatar_id":"","url":"https://api.github.com/users/pawel-pieniazek","html_url":"https://github.com/pawel-pieniazek","followers_url":"https://api.github.com/users/pawel-pieniazek/followers","following_url":"https://api.github.com/users/pawel-pieniazek/following{/other_user}","gists_url":"https://api.github.com/users/pawel-pieniazek/gists{/gist_id}","starred_url":"https://api.github.com/users/pawel-pieniazek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawel-pieniazek/subscriptions","organizations_url":"https://api.github.com/users/pawel-pieniazek/orgs","repos_url":"https://api.github.com/users/pawel-pieniazek/repos","events_url":"https://api.github.com/users/pawel-pieniazek/events{/privacy}","received_events_url":"https://api.github.com/users/pawel-pieniazek/received_events","type":"User","site_admin":false},"body":"or maybe this wait, should be part of start_server?\r\nBecause I see too many Repeated lines here","created_at":"2019-02-20T13:19:39Z","updated_at":"2019-02-20T13:23:16Z","html_url":"https://github.com/IntelAI/OpenVINO-model-server/pull/20#discussion_r258476794","pull_request_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/pulls/20","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/pulls/comments/258476794"},"html":{"href":"https://github.com/IntelAI/OpenVINO-model-server/pull/20#discussion_r258476794"},"pull_request":{"href":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/pulls/20"}},"in_reply_to_id":258475946},"pull_request":{"url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/pulls/20","id":251934835,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUxOTM0ODM1","html_url":"https://github.com/IntelAI/OpenVINO-model-server/pull/20","diff_url":"https://github.com/IntelAI/OpenVINO-model-server/pull/20.diff","patch_url":"https://github.com/IntelAI/OpenVINO-model-server/pull/20.patch","issue_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/issues/20","number":20,"state":"open","locked":false,"title":"Model version policy, Tensorflow, functional tests","user":{"login":"mareklevv","id":33313556,"node_id":"MDQ6VXNlcjMzMzEzNTU2","avatar_url":"https://avatars2.githubusercontent.com/u/33313556?v=4","gravatar_id":"","url":"https://api.github.com/users/mareklevv","html_url":"https://github.com/mareklevv","followers_url":"https://api.github.com/users/mareklevv/followers","following_url":"https://api.github.com/users/mareklevv/following{/other_user}","gists_url":"https://api.github.com/users/mareklevv/gists{/gist_id}","starred_url":"https://api.github.com/users/mareklevv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mareklevv/subscriptions","organizations_url":"https://api.github.com/users/mareklevv/orgs","repos_url":"https://api.github.com/users/mareklevv/repos","events_url":"https://api.github.com/users/mareklevv/events{/privacy}","received_events_url":"https://api.github.com/users/mareklevv/received_events","type":"User","site_admin":false},"body":"Summary of changes:\r\n- add model version policy\r\n- upgrade Tensorflow version\r\n- update readme\r\n- change way of creating Inference Engine(remove warning about deprecated function)\r\n- change way of starting docker images in functional tests\r\n- increase unit tests coverage to 79%","created_at":"2019-02-11T14:32:39Z","updated_at":"2019-02-20T13:23:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"840f4d88807beeacdf3c0f747f11bf53f7ac0742","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dtrawins","id":20400806,"node_id":"MDQ6VXNlcjIwNDAwODA2","avatar_url":"https://avatars2.githubusercontent.com/u/20400806?v=4","gravatar_id":"","url":"https://api.github.com/users/dtrawins","html_url":"https://github.com/dtrawins","followers_url":"https://api.github.com/users/dtrawins/followers","following_url":"https://api.github.com/users/dtrawins/following{/other_user}","gists_url":"https://api.github.com/users/dtrawins/gists{/gist_id}","starred_url":"https://api.github.com/users/dtrawins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtrawins/subscriptions","organizations_url":"https://api.github.com/users/dtrawins/orgs","repos_url":"https://api.github.com/users/dtrawins/repos","events_url":"https://api.github.com/users/dtrawins/events{/privacy}","received_events_url":"https://api.github.com/users/dtrawins/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/pulls/20/commits","review_comments_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/pulls/20/comments","review_comment_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/issues/20/comments","statuses_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/statuses/7a8015c889e405cb9d0d7daf4f1d0253876b67be","head":{"label":"IntelAI:model_version_policy","ref":"model_version_policy","sha":"7a8015c889e405cb9d0d7daf4f1d0253876b67be","user":{"login":"IntelAI","id":37351515,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzUxNTE1","avatar_url":"https://avatars3.githubusercontent.com/u/37351515?v=4","gravatar_id":"","url":"https://api.github.com/users/IntelAI","html_url":"https://github.com/IntelAI","followers_url":"https://api.github.com/users/IntelAI/followers","following_url":"https://api.github.com/users/IntelAI/following{/other_user}","gists_url":"https://api.github.com/users/IntelAI/gists{/gist_id}","starred_url":"https://api.github.com/users/IntelAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntelAI/subscriptions","organizations_url":"https://api.github.com/users/IntelAI/orgs","repos_url":"https://api.github.com/users/IntelAI/repos","events_url":"https://api.github.com/users/IntelAI/events{/privacy}","received_events_url":"https://api.github.com/users/IntelAI/received_events","type":"Organization","site_admin":false},"repo":{"id":150458335,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA0NTgzMzU=","name":"OpenVINO-model-server","full_name":"IntelAI/OpenVINO-model-server","private":false,"owner":{"login":"IntelAI","id":37351515,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzUxNTE1","avatar_url":"https://avatars3.githubusercontent.com/u/37351515?v=4","gravatar_id":"","url":"https://api.github.com/users/IntelAI","html_url":"https://github.com/IntelAI","followers_url":"https://api.github.com/users/IntelAI/followers","following_url":"https://api.github.com/users/IntelAI/following{/other_user}","gists_url":"https://api.github.com/users/IntelAI/gists{/gist_id}","starred_url":"https://api.github.com/users/IntelAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntelAI/subscriptions","organizations_url":"https://api.github.com/users/IntelAI/orgs","repos_url":"https://api.github.com/users/IntelAI/repos","events_url":"https://api.github.com/users/IntelAI/events{/privacy}","received_events_url":"https://api.github.com/users/IntelAI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/IntelAI/OpenVINO-model-server","description":"Inference model server implementation with Intel performance optimizations and TensorFlow Serving API","fork":false,"url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server","forks_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/forks","keys_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/teams","hooks_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/hooks","issue_events_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/issues/events{/number}","events_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/events","assignees_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/assignees{/user}","branches_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/branches{/branch}","tags_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/tags","blobs_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/statuses/{sha}","languages_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/languages","stargazers_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/stargazers","contributors_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/contributors","subscribers_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/subscribers","subscription_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/subscription","commits_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/contents/{+path}","compare_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/merges","archive_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/downloads","issues_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/issues{/number}","pulls_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/pulls{/number}","milestones_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/milestones{/number}","notifications_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/labels{/name}","releases_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/releases{/id}","deployments_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/deployments","created_at":"2018-09-26T16:40:53Z","updated_at":"2019-02-18T07:44:40Z","pushed_at":"2019-02-20T10:29:44Z","git_url":"git://github.com/IntelAI/OpenVINO-model-server.git","ssh_url":"[email protected]:IntelAI/OpenVINO-model-server.git","clone_url":"https://github.com/IntelAI/OpenVINO-model-server.git","svn_url":"https://github.com/IntelAI/OpenVINO-model-server","homepage":"","size":2549,"stargazers_count":69,"watchers_count":69,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":3,"watchers":69,"default_branch":"master"}},"base":{"label":"IntelAI:master","ref":"master","sha":"561344a19efbce644d936ca43d779fef2793ca12","user":{"login":"IntelAI","id":37351515,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzUxNTE1","avatar_url":"https://avatars3.githubusercontent.com/u/37351515?v=4","gravatar_id":"","url":"https://api.github.com/users/IntelAI","html_url":"https://github.com/IntelAI","followers_url":"https://api.github.com/users/IntelAI/followers","following_url":"https://api.github.com/users/IntelAI/following{/other_user}","gists_url":"https://api.github.com/users/IntelAI/gists{/gist_id}","starred_url":"https://api.github.com/users/IntelAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntelAI/subscriptions","organizations_url":"https://api.github.com/users/IntelAI/orgs","repos_url":"https://api.github.com/users/IntelAI/repos","events_url":"https://api.github.com/users/IntelAI/events{/privacy}","received_events_url":"https://api.github.com/users/IntelAI/received_events","type":"Organization","site_admin":false},"repo":{"id":150458335,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA0NTgzMzU=","name":"OpenVINO-model-server","full_name":"IntelAI/OpenVINO-model-server","private":false,"owner":{"login":"IntelAI","id":37351515,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzUxNTE1","avatar_url":"https://avatars3.githubusercontent.com/u/37351515?v=4","gravatar_id":"","url":"https://api.github.com/users/IntelAI","html_url":"https://github.com/IntelAI","followers_url":"https://api.github.com/users/IntelAI/followers","following_url":"https://api.github.com/users/IntelAI/following{/other_user}","gists_url":"https://api.github.com/users/IntelAI/gists{/gist_id}","starred_url":"https://api.github.com/users/IntelAI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntelAI/subscriptions","organizations_url":"https://api.github.com/users/IntelAI/orgs","repos_url":"https://api.github.com/users/IntelAI/repos","events_url":"https://api.github.com/users/IntelAI/events{/privacy}","received_events_url":"https://api.github.com/users/IntelAI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/IntelAI/OpenVINO-model-server","description":"Inference model server implementation with Intel performance optimizations and TensorFlow Serving API","fork":false,"url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server","forks_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/forks","keys_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/teams","hooks_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/hooks","issue_events_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/issues/events{/number}","events_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/events","assignees_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/assignees{/user}","branches_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/branches{/branch}","tags_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/tags","blobs_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/statuses/{sha}","languages_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/languages","stargazers_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/stargazers","contributors_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/contributors","subscribers_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/subscribers","subscription_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/subscription","commits_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/contents/{+path}","compare_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/merges","archive_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/downloads","issues_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/issues{/number}","pulls_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/pulls{/number}","milestones_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/milestones{/number}","notifications_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/labels{/name}","releases_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/releases{/id}","deployments_url":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/deployments","created_at":"2018-09-26T16:40:53Z","updated_at":"2019-02-18T07:44:40Z","pushed_at":"2019-02-20T10:29:44Z","git_url":"git://github.com/IntelAI/OpenVINO-model-server.git","ssh_url":"[email protected]:IntelAI/OpenVINO-model-server.git","clone_url":"https://github.com/IntelAI/OpenVINO-model-server.git","svn_url":"https://github.com/IntelAI/OpenVINO-model-server","homepage":"","size":2549,"stargazers_count":69,"watchers_count":69,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":3,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/pulls/20"},"html":{"href":"https://github.com/IntelAI/OpenVINO-model-server/pull/20"},"issue":{"href":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/issues/20"},"comments":{"href":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/IntelAI/OpenVINO-model-server/statuses/7a8015c889e405cb9d0d7daf4f1d0253876b67be"}},"author_association":"COLLABORATOR"}}	{ "id": 150458335, "name": "IntelAI/OpenVINO-model-server", "url": "https://api.github.com/repos/IntelAI/OpenVINO-model-server" }	{ "id": 12857071, "login": "pawel-pieniazek", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/12857071?", "url": "https://api.github.com/users/pawel-pieniazek" }	{ "id": 37351515, "login": "IntelAI", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/37351515?", "url": "https://api.github.com/orgs/IntelAI" }	2019-02-20T13:19:39	9102273847	{"actor":{"display_login":"pawel-pieniazek"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/tari-project/tari/pulls/comments/269263658","pull_request_review_id":219095357,"id":269263658,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2OTI2MzY1OA==","diff_hunk":"@@ -0,0 +1,175 @@\n+# RFC-0711/MessageSerialisation\n+\n+## Message Serialization\n+\n+![status: draft](theme/images/status-draft.svg)\n+\n+Maintainer(s): [Cayle Sharrock](https://github.com/CjS77)\n+\n+# License\n+\n+[ The 3-Clause BSD License](https://opensource.org/licenses/BSD-3-Clause).\n+\n+Copyright 2019. The Tari Development Community\n+\n+Redistribution and use in source and binary forms, with or without modification, are permitted provided that the\n+following conditions are met:\n+\n+1. Redistributions of this document must retain the above copyright notice, this list of conditions and the following\n+ disclaimer.\n+2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following\n+ disclaimer in the documentation and/or other materials provided with the distribution.\n+3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote products\n+ derived from this software without specific prior written permission.\n+\n+THIS DOCUMENT IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS \"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES,\n+INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE\n+DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,\n+SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR\n+SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,\n+WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF\n+THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.\n+\n+## Language\n+\n+The key words \"MUST\", \"MUST NOT\", \"REQUIRED\", \"SHALL\", \"SHALL NOT\", \"SHOULD\", \"SHOULD NOT\", \"RECOMMENDED\",\n+\"NOT RECOMMENDED\", \"MAY\", and \"OPTIONAL\" in this document are to be interpreted as described in\n+[BCP 14](https://tools.ietf.org/html/bcp14) (covering RFC2119 and RFC8174) when, and only when, they appear in all capitals, as\n+shown here.\n+\n+## Disclaimer\n+\n+The purpose of this document and its content is for information purposes only and may be subject to change or update\n+without notice.\n+\n+This document may include preliminary concepts that may or may not be in the process of being developed by the Tari\n+community. The release of this document is intended solely for review and discussion by the community regarding the\n+technological merits of the potential system outlined herein.\n+\n+## Goals\n+\n+This document describes the message serialisation formats for message payloads used in the Tari network.\n+\n+## Related RFCs\n+\n+[RFC-0710: The Tari Communication Network and Network Communication Protocol](RFC-0170_NetworkCommunicationProtocol.md)\n+\n+## Description\n+\n+One way of interpreting the Tari network is that it is a large peer-to-peer messaging application. The entities chatting\n+on the network include\n+\n+* Users\n+* Wallets\n+* Base nodes\n+* Validator nodes\n+\n+The types of messages that these entities send might include\n+\n+* Text messages\n+* Transaction messages\n+* Block propagation messages\n+* Asset creation instructions\n+* Asset state change instructions\n+* State Checkpoint messages\n+\n+For successful communication to occur, the following needs to happen:\n+\n+* The message is translated from its memory storage format into a standard payload format that will be transported over\n+ the wire.\n+* The communication module wraps the payload into a message format, which may entail any/all of\n+ * adding a message header to describe the type of payload,\n+ * encrypting the message,\n+ * signing the message, and\n+ * adding destination /recipient metadata.\n+* The communication module then sends the message over the wire.\n+* The recipient receives the message and unwraps it, possibly performing any/all of the following:\n+ * decryption,\n+ * verifying signatures,\n+ * extracting the payload,\n+ * passing the serialised payload to modules that are interesting in that particular message type\n+* The message is deserialised into the correct data structure for use by the receiving software\n+\n+This document only covers the first and last steps: _viz_: serialising data from in-memory objects to a format that can\n+be transmitted over the wire. The other steps are handled by the Tari communication protocol.\n+\n+In addition to machine-to-machine communication, we also standardise on human-to-machine communication. Use cases for\n+this include\n+\n+* Handcrafting instructions or transactions. The ideal format here is a very human-readable format.\n+* Copying transactions or instructions from cold wallets. The ideal format here is a compact but easy-to-copy format.\n+* Peer-to-peer text messaging. This is just a special case of what has already been described, with the message\n+ structure containing a unicode `message_text` field.\n+\n+When sending a message from a human to the network, the following happens:\n+\n+* The message is deserialised into the native structure.\n+* The deserialisation acts as an automatic validation step.\n+* Additional validation can be performed.\n+* The usual machine-to-machine process is followed as described above.\n+\n+### Binary serialisation formats\n+\n+The ideal properties for binary serialisation formats are:\n+\n+* Widely used across multiple platforms and languages, but with excellent Rust support.\n+* Compact binary representation\n+* Serialisation \"Just Works\"(TM) with little or no additional coding overhead.\n+\n+Several candidates fulfil these properties to some degree.\n+\n+#### [ASN.1](http://www.itu.int/ITU-T/asn1/index.html)\n+\n+* Pros:\n+ * Very mature (was developed in the 80s)\n+ * Large number of implementations\n+ * Dovetails into ZMQ nicely\n+* Cons:\n+ * Limited Rust / Serde support\n+ * Requires schema (additional coding overhead if no automated tools for this exist)\n+\n+\n+#### [Message Pack](http://msgpack.org/)\n+\n+* Pros:\n+ * Very compact\n+ * Fast\n+ * Multiple language support\n+ * Good Rust / SerDe support\n+ * Dovetails into ZMQ nicely\n+* Cons:\n+ * No metadata support\n+\n+#### [Protobuf](https://code.google.com/p/protobuf/)\n+\n+Similar to [Message Pack](#message-pack), but also requires schema's to be written and compiled. Serialisation performance and size\n+is similar to Message Pack. Can work with ZMQ but is better designed to be used with gRPC.\n+\n+#### [Cap'n Proto](http://kentonv.github.io/capnproto/)\n+\n+Similar to [Protobuf](#protobuf), but claims to be much faster. Rust is supported.\n+\n+### Serialisation in Tari\n+\n+Deciding between these protocols is largely a matter of preference, since there isn't that much to choose between them.\n+Given that ZMQ is used in other places in the Tari network; MessagePack looks to be a good fit while offering a compact\n+data structure and highly performant de/serialisation. In Rust in particular, there's first-class support for Message\n+Pack in serde.\n+\n+For human-readable formats, it makes little sense to deviate from JSON. For copy-paste semantics, the extra compression\n+that Base64 offers over raw hex or Base58 makes it attractive.","path":"RFC/src/RFC-0171_MessageSerialisation.md","position":160,"original_position":160,"commit_id":"b465ee2faefaba81a7cb40723fa74bfd8d0c7eeb","original_commit_id":"29cf91762ad312f0bebba70fd13420a0149cf7fd","user":{"login":"CjS77","id":7573551,"node_id":"MDQ6VXNlcjc1NzM1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/7573551?v=4","gravatar_id":"","url":"https://api.github.com/users/CjS77","html_url":"https://github.com/CjS77","followers_url":"https://api.github.com/users/CjS77/followers","following_url":"https://api.github.com/users/CjS77/following{/other_user}","gists_url":"https://api.github.com/users/CjS77/gists{/gist_id}","starred_url":"https://api.github.com/users/CjS77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CjS77/subscriptions","organizations_url":"https://api.github.com/users/CjS77/orgs","repos_url":"https://api.github.com/users/CjS77/repos","events_url":"https://api.github.com/users/CjS77/events{/privacy}","received_events_url":"https://api.github.com/users/CjS77/received_events","type":"User","site_admin":false},"body":"Base64 is more for encoding into QR codes and copy-paste; so it's not meant to be human-readable, just ASCII-friendly. Base64 lines up on word boundaries better, in addition to squeezing a bit more info into every character. From [Wikipedia](https://en.wikipedia.org/wiki/Base58):\r\n\r\n> In contrast to Base64, the digits of the [Base58] encoding do not line up well with byte boundaries of the original data. For this reason, the method is well-suited to encode large integers, but not designed to encode longer portions of binary data.\r\n\r\nThe only real drawback to Base64 is that a double-click won't select the whole string if there are `+` or `/` in it ","created_at":"2019-03-26T18:49:49Z","updated_at":"2019-03-26T18:49:49Z","html_url":"https://github.com/tari-project/tari/pull/182#discussion_r269263658","pull_request_url":"https://api.github.com/repos/tari-project/tari/pulls/182","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tari-project/tari/pulls/comments/269263658"},"html":{"href":"https://github.com/tari-project/tari/pull/182#discussion_r269263658"},"pull_request":{"href":"https://api.github.com/repos/tari-project/tari/pulls/182"}},"in_reply_to_id":269026186},"pull_request":{"url":"https://api.github.com/repos/tari-project/tari/pulls/182","id":264140209,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY0MTQwMjA5","html_url":"https://github.com/tari-project/tari/pull/182","diff_url":"https://github.com/tari-project/tari/pull/182.diff","patch_url":"https://github.com/tari-project/tari/pull/182.patch","issue_url":"https://api.github.com/repos/tari-project/tari/issues/182","number":182,"state":"open","locked":false,"title":"WIP: Serialisation RFC","user":{"login":"CjS77","id":7573551,"node_id":"MDQ6VXNlcjc1NzM1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/7573551?v=4","gravatar_id":"","url":"https://api.github.com/users/CjS77","html_url":"https://github.com/CjS77","followers_url":"https://api.github.com/users/CjS77/followers","following_url":"https://api.github.com/users/CjS77/following{/other_user}","gists_url":"https://api.github.com/users/CjS77/gists{/gist_id}","starred_url":"https://api.github.com/users/CjS77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CjS77/subscriptions","organizations_url":"https://api.github.com/users/CjS77/orgs","repos_url":"https://api.github.com/users/CjS77/repos","events_url":"https://api.github.com/users/CjS77/events{/privacy}","received_events_url":"https://api.github.com/users/CjS77/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nThis document describes the message serialisation formats for message payloads used in the Tari network.\r\n\r\n## Motivation and Context\r\nThere are several different user and message types that will need to communicate over the Tari network. These messages need to be converted into a format that can be sent over the wire and/or be read and processed by humans.\r\n\r\n## How Has This Been Tested?\r\nN/A\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n* [ ] Bug fix (non-breaking change which fixes an issue)\r\n* [x] New feature (non-breaking change which adds functionality)\r\n* [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n* [ ] Feature refactor (No new feature or functional changes, but performance or technical debt improvements)\r\n* [ ] New Tests\r\n* [x] Documentation\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n* [x] I'm merging against the `development` branch\r\n* [x] I ran `cargo-fmt --all` before pushing\r\n* [x] My change requires a change to the documentation.\r\n* [x] I have updated the documentation accordingly.\r\n* [ ] I have added tests to cover my changes.\r\n","created_at":"2019-03-25T14:19:50Z","updated_at":"2019-03-26T18:49:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"670f8a159e55e964cee7ebc784640b8d23c135d4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1189345533,"node_id":"MDU6TGFiZWwxMTg5MzQ1NTMz","url":"https://api.github.com/repos/tari-project/tari/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tari-project/tari/pulls/182/commits","review_comments_url":"https://api.github.com/repos/tari-project/tari/pulls/182/comments","review_comment_url":"https://api.github.com/repos/tari-project/tari/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tari-project/tari/issues/182/comments","statuses_url":"https://api.github.com/repos/tari-project/tari/statuses/b465ee2faefaba81a7cb40723fa74bfd8d0c7eeb","head":{"label":"tari-project:serialization","ref":"serialization","sha":"b465ee2faefaba81a7cb40723fa74bfd8d0c7eeb","user":{"login":"tari-project","id":37560539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NTYwNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/37560539?v=4","gravatar_id":"","url":"https://api.github.com/users/tari-project","html_url":"https://github.com/tari-project","followers_url":"https://api.github.com/users/tari-project/followers","following_url":"https://api.github.com/users/tari-project/following{/other_user}","gists_url":"https://api.github.com/users/tari-project/gists{/gist_id}","starred_url":"https://api.github.com/users/tari-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tari-project/subscriptions","organizations_url":"https://api.github.com/users/tari-project/orgs","repos_url":"https://api.github.com/users/tari-project/repos","events_url":"https://api.github.com/users/tari-project/events{/privacy}","received_events_url":"https://api.github.com/users/tari-project/received_events","type":"Organization","site_admin":false},"repo":{"id":136459099,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY0NTkwOTk=","name":"tari","full_name":"tari-project/tari","private":false,"owner":{"login":"tari-project","id":37560539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NTYwNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/37560539?v=4","gravatar_id":"","url":"https://api.github.com/users/tari-project","html_url":"https://github.com/tari-project","followers_url":"https://api.github.com/users/tari-project/followers","following_url":"https://api.github.com/users/tari-project/following{/other_user}","gists_url":"https://api.github.com/users/tari-project/gists{/gist_id}","starred_url":"https://api.github.com/users/tari-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tari-project/subscriptions","organizations_url":"https://api.github.com/users/tari-project/orgs","repos_url":"https://api.github.com/users/tari-project/repos","events_url":"https://api.github.com/users/tari-project/events{/privacy}","received_events_url":"https://api.github.com/users/tari-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tari-project/tari","description":"The Tari protocol","fork":false,"url":"https://api.github.com/repos/tari-project/tari","forks_url":"https://api.github.com/repos/tari-project/tari/forks","keys_url":"https://api.github.com/repos/tari-project/tari/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tari-project/tari/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tari-project/tari/teams","hooks_url":"https://api.github.com/repos/tari-project/tari/hooks","issue_events_url":"https://api.github.com/repos/tari-project/tari/issues/events{/number}","events_url":"https://api.github.com/repos/tari-project/tari/events","assignees_url":"https://api.github.com/repos/tari-project/tari/assignees{/user}","branches_url":"https://api.github.com/repos/tari-project/tari/branches{/branch}","tags_url":"https://api.github.com/repos/tari-project/tari/tags","blobs_url":"https://api.github.com/repos/tari-project/tari/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tari-project/tari/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tari-project/tari/git/refs{/sha}","trees_url":"https://api.github.com/repos/tari-project/tari/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tari-project/tari/statuses/{sha}","languages_url":"https://api.github.com/repos/tari-project/tari/languages","stargazers_url":"https://api.github.com/repos/tari-project/tari/stargazers","contributors_url":"https://api.github.com/repos/tari-project/tari/contributors","subscribers_url":"https://api.github.com/repos/tari-project/tari/subscribers","subscription_url":"https://api.github.com/repos/tari-project/tari/subscription","commits_url":"https://api.github.com/repos/tari-project/tari/commits{/sha}","git_commits_url":"https://api.github.com/repos/tari-project/tari/git/commits{/sha}","comments_url":"https://api.github.com/repos/tari-project/tari/comments{/number}","issue_comment_url":"https://api.github.com/repos/tari-project/tari/issues/comments{/number}","contents_url":"https://api.github.com/repos/tari-project/tari/contents/{+path}","compare_url":"https://api.github.com/repos/tari-project/tari/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tari-project/tari/merges","archive_url":"https://api.github.com/repos/tari-project/tari/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tari-project/tari/downloads","issues_url":"https://api.github.com/repos/tari-project/tari/issues{/number}","pulls_url":"https://api.github.com/repos/tari-project/tari/pulls{/number}","milestones_url":"https://api.github.com/repos/tari-project/tari/milestones{/number}","notifications_url":"https://api.github.com/repos/tari-project/tari/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tari-project/tari/labels{/name}","releases_url":"https://api.github.com/repos/tari-project/tari/releases{/id}","deployments_url":"https://api.github.com/repos/tari-project/tari/deployments","created_at":"2018-06-07T10:09:08Z","updated_at":"2019-03-26T18:21:34Z","pushed_at":"2019-03-26T18:41:12Z","git_url":"git://github.com/tari-project/tari.git","ssh_url":"[email protected]:tari-project/tari.git","clone_url":"https://github.com/tari-project/tari.git","svn_url":"https://github.com/tari-project/tari","homepage":"https://tari.com","size":1718,"stargazers_count":42,"watchers_count":42,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":79,"license":null,"forks":8,"open_issues":79,"watchers":42,"default_branch":"development"}},"base":{"label":"tari-project:development","ref":"development","sha":"c59619995631e4f6b58b47c509225c0c246bc87c","user":{"login":"tari-project","id":37560539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NTYwNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/37560539?v=4","gravatar_id":"","url":"https://api.github.com/users/tari-project","html_url":"https://github.com/tari-project","followers_url":"https://api.github.com/users/tari-project/followers","following_url":"https://api.github.com/users/tari-project/following{/other_user}","gists_url":"https://api.github.com/users/tari-project/gists{/gist_id}","starred_url":"https://api.github.com/users/tari-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tari-project/subscriptions","organizations_url":"https://api.github.com/users/tari-project/orgs","repos_url":"https://api.github.com/users/tari-project/repos","events_url":"https://api.github.com/users/tari-project/events{/privacy}","received_events_url":"https://api.github.com/users/tari-project/received_events","type":"Organization","site_admin":false},"repo":{"id":136459099,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY0NTkwOTk=","name":"tari","full_name":"tari-project/tari","private":false,"owner":{"login":"tari-project","id":37560539,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NTYwNTM5","avatar_url":"https://avatars1.githubusercontent.com/u/37560539?v=4","gravatar_id":"","url":"https://api.github.com/users/tari-project","html_url":"https://github.com/tari-project","followers_url":"https://api.github.com/users/tari-project/followers","following_url":"https://api.github.com/users/tari-project/following{/other_user}","gists_url":"https://api.github.com/users/tari-project/gists{/gist_id}","starred_url":"https://api.github.com/users/tari-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tari-project/subscriptions","organizations_url":"https://api.github.com/users/tari-project/orgs","repos_url":"https://api.github.com/users/tari-project/repos","events_url":"https://api.github.com/users/tari-project/events{/privacy}","received_events_url":"https://api.github.com/users/tari-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tari-project/tari","description":"The Tari protocol","fork":false,"url":"https://api.github.com/repos/tari-project/tari","forks_url":"https://api.github.com/repos/tari-project/tari/forks","keys_url":"https://api.github.com/repos/tari-project/tari/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tari-project/tari/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tari-project/tari/teams","hooks_url":"https://api.github.com/repos/tari-project/tari/hooks","issue_events_url":"https://api.github.com/repos/tari-project/tari/issues/events{/number}","events_url":"https://api.github.com/repos/tari-project/tari/events","assignees_url":"https://api.github.com/repos/tari-project/tari/assignees{/user}","branches_url":"https://api.github.com/repos/tari-project/tari/branches{/branch}","tags_url":"https://api.github.com/repos/tari-project/tari/tags","blobs_url":"https://api.github.com/repos/tari-project/tari/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tari-project/tari/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tari-project/tari/git/refs{/sha}","trees_url":"https://api.github.com/repos/tari-project/tari/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tari-project/tari/statuses/{sha}","languages_url":"https://api.github.com/repos/tari-project/tari/languages","stargazers_url":"https://api.github.com/repos/tari-project/tari/stargazers","contributors_url":"https://api.github.com/repos/tari-project/tari/contributors","subscribers_url":"https://api.github.com/repos/tari-project/tari/subscribers","subscription_url":"https://api.github.com/repos/tari-project/tari/subscription","commits_url":"https://api.github.com/repos/tari-project/tari/commits{/sha}","git_commits_url":"https://api.github.com/repos/tari-project/tari/git/commits{/sha}","comments_url":"https://api.github.com/repos/tari-project/tari/comments{/number}","issue_comment_url":"https://api.github.com/repos/tari-project/tari/issues/comments{/number}","contents_url":"https://api.github.com/repos/tari-project/tari/contents/{+path}","compare_url":"https://api.github.com/repos/tari-project/tari/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tari-project/tari/merges","archive_url":"https://api.github.com/repos/tari-project/tari/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tari-project/tari/downloads","issues_url":"https://api.github.com/repos/tari-project/tari/issues{/number}","pulls_url":"https://api.github.com/repos/tari-project/tari/pulls{/number}","milestones_url":"https://api.github.com/repos/tari-project/tari/milestones{/number}","notifications_url":"https://api.github.com/repos/tari-project/tari/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tari-project/tari/labels{/name}","releases_url":"https://api.github.com/repos/tari-project/tari/releases{/id}","deployments_url":"https://api.github.com/repos/tari-project/tari/deployments","created_at":"2018-06-07T10:09:08Z","updated_at":"2019-03-26T18:21:34Z","pushed_at":"2019-03-26T18:41:12Z","git_url":"git://github.com/tari-project/tari.git","ssh_url":"[email protected]:tari-project/tari.git","clone_url":"https://github.com/tari-project/tari.git","svn_url":"https://github.com/tari-project/tari","homepage":"https://tari.com","size":1718,"stargazers_count":42,"watchers_count":42,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":79,"license":null,"forks":8,"open_issues":79,"watchers":42,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/tari-project/tari/pulls/182"},"html":{"href":"https://github.com/tari-project/tari/pull/182"},"issue":{"href":"https://api.github.com/repos/tari-project/tari/issues/182"},"comments":{"href":"https://api.github.com/repos/tari-project/tari/issues/182/comments"},"review_comments":{"href":"https://api.github.com/repos/tari-project/tari/pulls/182/comments"},"review_comment":{"href":"https://api.github.com/repos/tari-project/tari/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tari-project/tari/pulls/182/commits"},"statuses":{"href":"https://api.github.com/repos/tari-project/tari/statuses/b465ee2faefaba81a7cb40723fa74bfd8d0c7eeb"}},"author_association":"CONTRIBUTOR"}}	{ "id": 136459099, "name": "tari-project/tari", "url": "https://api.github.com/repos/tari-project/tari" }	{ "id": 7573551, "login": "CjS77", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/7573551?", "url": "https://api.github.com/users/CjS77" }	{ "id": 37560539, "login": "tari-project", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/37560539?", "url": "https://api.github.com/orgs/tari-project" }	2019-03-26T18:49:49	9318850314	{"actor":{"display_login":"CjS77"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/pulls/comments/261941751","pull_request_review_id":209997075,"id":261941751,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MTk0MTc1MQ==","diff_hunk":"@@ -507,52 +594,125 @@ public HttpResponseMessage SignImage(SignaturePostedDataEntity postedData)\n }\n \n /// <summary>\n- /// Sign document with stamp\n+ /// Save optical signature\n /// </summary>\n- /// <param name=\"postedData\"></param>\n- /// <returns>Signed document info</returns>\n+ /// <param name=\"postedData\">SignaturePostedDataEntity</param>\n+ /// <returns>Signature preview image</returns>\n [HttpPost]\n- [Route(\"signature/signStamp\")]\n- public HttpResponseMessage SignStamp(SignaturePostedDataEntity postedData)\n+ [Route(\"signature/saveOpticalCode\")]\n+ public HttpResponseMessage SaveOpticalCode([FromBody]dynamic postedData)\n {\n- string password = \"\";\n- string xmlPath = DirectoryUtils.DataDirectory.StampDirectory.XmlPath;\n try\n {\n- // get/set parameters\n- string documentGuid = postedData.guid;\n- password = postedData.password;\n- SignatureDataEntity[] signaturesData = postedData.signaturesData;\n-\n- SignatureOptionsCollection signsCollection = new SignatureOptionsCollection();\n- // mimeType should now be something like \"image/png\" if the document is image\n- if (SupportedImageFormats.Contains(Path.GetExtension(documentGuid)))\n+ OpticalXmlEntity opticalCodeData = JsonConvert.DeserializeObject<OpticalXmlEntity>(postedData.properties.ToString());\n+ string signatureType = postedData.signatureType;\n+ // initiate signature data wrapper with default values\n+ SignatureDataEntity signaturesData = new SignatureDataEntity();\n+ signaturesData.ImageHeight = 200;\n+ signaturesData.ImageWidth = 270;\n+ signaturesData.Left = 0;\n+ signaturesData.Top = 0;\n+ signaturesData.setHorizontalAlignment(HorizontalAlignment.Center);\n+ signaturesData.setVerticalAlignment(VerticalAlignment.Center);\n+ // initiate signer object\n+ string previewPath;\n+ string xmlPath;\n+ QrCodeSigner qrSigner;\n+ BarCodeSigner barCodeSigner;\n+ // initiate signature options collection\n+ SignatureOptionsCollection collection = new SignatureOptionsCollection();\n+ // check optical signature type\n+ if (signatureType.Equals(\"qrCode\"))\n {\n- signaturesData[0].DocumentType = \"image\";\n+ qrSigner = new QrCodeSigner(opticalCodeData, signaturesData);\n+ // get preview path\n+ previewPath = DirectoryUtils.DataDirectory.QrCodeDirectory.PreviewPath;\n+ // get xml file path\n+ xmlPath = DirectoryUtils.DataDirectory.QrCodeDirectory.XmlPath;\n+ // generate unique file names for preview image and xml file\n+ collection.Add(qrSigner.SignImage());\n }\n-\n- for (int i = 0; i < signaturesData.Length; i++)\n+ else\n+ {\n+ barCodeSigner = new BarCodeSigner(opticalCodeData, signaturesData);\n+ // get preview path\n+ previewPath = DirectoryUtils.DataDirectory.BarcodeDirectory.PreviewPath;\n+ // get xml file path\n+ xmlPath = DirectoryUtils.DataDirectory.BarcodeDirectory.XmlPath;\n+ // generate unique file names for preview image and xml file\n+ collection.Add(barCodeSigner.SignImage());\n+ }\n+ string[] listOfFiles = Directory.GetFiles(previewPath);\n+ string fileName = \"\";\n+ string filePath = \"\";\n+ if (!String.IsNullOrEmpty(opticalCodeData.imageGuid))\n+ {\n+ filePath = opticalCodeData.imageGuid;\n+ fileName = Path.GetFileNameWithoutExtension(opticalCodeData.imageGuid);\n+ }\n+ else\n {\n- if (signaturesData[i].isDeleted)\n+ for (int i = 0; i <= listOfFiles.Length; i++)\n {\n- continue;\n+ int number = i + 1;","path":"src/Products/Signature/Controllers/SignatureApiController.cs","position":534,"original_position":534,"commit_id":"735e6bb0f162bc958239653c2c499a6e0d275115","original_commit_id":"735e6bb0f162bc958239653c2c499a6e0d275115","user":{"login":"codacy-bot","id":19940114,"node_id":"MDQ6VXNlcjE5OTQwMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://app.codacy.com/assets/images/favicon.png) Issue found: [Remove this unused 'number' local variable.](https://app.codacy.com/app/GroupDocs/GroupDocs.Total-for-NET-MVC/pullRequest?prid=3206091)","created_at":"2019-03-04T07:15:04Z","updated_at":"2019-03-04T07:15:04Z","html_url":"https://github.com/groupdocs-total/GroupDocs.Total-for-NET-MVC/pull/36#discussion_r261941751","pull_request_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/pulls/36","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/pulls/comments/261941751"},"html":{"href":"https://github.com/groupdocs-total/GroupDocs.Total-for-NET-MVC/pull/36#discussion_r261941751"},"pull_request":{"href":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/pulls/36","id":257833939,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU3ODMzOTM5","html_url":"https://github.com/groupdocs-total/GroupDocs.Total-for-NET-MVC/pull/36","diff_url":"https://github.com/groupdocs-total/GroupDocs.Total-for-NET-MVC/pull/36.diff","patch_url":"https://github.com/groupdocs-total/GroupDocs.Total-for-NET-MVC/pull/36.patch","issue_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/issues/36","number":36,"state":"open","locked":false,"title":"New signature","user":{"login":"Pavel-Teplitsky","id":2689279,"node_id":"MDQ6VXNlcjI2ODkyNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2689279?v=4","gravatar_id":"","url":"https://api.github.com/users/Pavel-Teplitsky","html_url":"https://github.com/Pavel-Teplitsky","followers_url":"https://api.github.com/users/Pavel-Teplitsky/followers","following_url":"https://api.github.com/users/Pavel-Teplitsky/following{/other_user}","gists_url":"https://api.github.com/users/Pavel-Teplitsky/gists{/gist_id}","starred_url":"https://api.github.com/users/Pavel-Teplitsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pavel-Teplitsky/subscriptions","organizations_url":"https://api.github.com/users/Pavel-Teplitsky/orgs","repos_url":"https://api.github.com/users/Pavel-Teplitsky/repos","events_url":"https://api.github.com/users/Pavel-Teplitsky/events{/privacy}","received_events_url":"https://api.github.com/users/Pavel-Teplitsky/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-04T07:07:51Z","updated_at":"2019-03-04T07:15:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c7cfce3b8a6429d18e9aeb4f982ac2e9d28bc4f","assignee":{"login":"egorovpavel","id":737110,"node_id":"MDQ6VXNlcjczNzExMA==","avatar_url":"https://avatars3.githubusercontent.com/u/737110?v=4","gravatar_id":"","url":"https://api.github.com/users/egorovpavel","html_url":"https://github.com/egorovpavel","followers_url":"https://api.github.com/users/egorovpavel/followers","following_url":"https://api.github.com/users/egorovpavel/following{/other_user}","gists_url":"https://api.github.com/users/egorovpavel/gists{/gist_id}","starred_url":"https://api.github.com/users/egorovpavel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egorovpavel/subscriptions","organizations_url":"https://api.github.com/users/egorovpavel/orgs","repos_url":"https://api.github.com/users/egorovpavel/repos","events_url":"https://api.github.com/users/egorovpavel/events{/privacy}","received_events_url":"https://api.github.com/users/egorovpavel/received_events","type":"User","site_admin":false},"assignees":[{"login":"egorovpavel","id":737110,"node_id":"MDQ6VXNlcjczNzExMA==","avatar_url":"https://avatars3.githubusercontent.com/u/737110?v=4","gravatar_id":"","url":"https://api.github.com/users/egorovpavel","html_url":"https://github.com/egorovpavel","followers_url":"https://api.github.com/users/egorovpavel/followers","following_url":"https://api.github.com/users/egorovpavel/following{/other_user}","gists_url":"https://api.github.com/users/egorovpavel/gists{/gist_id}","starred_url":"https://api.github.com/users/egorovpavel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egorovpavel/subscriptions","organizations_url":"https://api.github.com/users/egorovpavel/orgs","repos_url":"https://api.github.com/users/egorovpavel/repos","events_url":"https://api.github.com/users/egorovpavel/events{/privacy}","received_events_url":"https://api.github.com/users/egorovpavel/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"egorovpavel","id":737110,"node_id":"MDQ6VXNlcjczNzExMA==","avatar_url":"https://avatars3.githubusercontent.com/u/737110?v=4","gravatar_id":"","url":"https://api.github.com/users/egorovpavel","html_url":"https://github.com/egorovpavel","followers_url":"https://api.github.com/users/egorovpavel/followers","following_url":"https://api.github.com/users/egorovpavel/following{/other_user}","gists_url":"https://api.github.com/users/egorovpavel/gists{/gist_id}","starred_url":"https://api.github.com/users/egorovpavel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egorovpavel/subscriptions","organizations_url":"https://api.github.com/users/egorovpavel/orgs","repos_url":"https://api.github.com/users/egorovpavel/repos","events_url":"https://api.github.com/users/egorovpavel/events{/privacy}","received_events_url":"https://api.github.com/users/egorovpavel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":982521114,"node_id":"MDU6TGFiZWw5ODI1MjExMTQ=","url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/pulls/36/commits","review_comments_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/pulls/36/comments","review_comment_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/issues/36/comments","statuses_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/statuses/735e6bb0f162bc958239653c2c499a6e0d275115","head":{"label":"groupdocs-total:new-signature","ref":"new-signature","sha":"735e6bb0f162bc958239653c2c499a6e0d275115","user":{"login":"groupdocs-total","id":37705979,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzA1OTc5","avatar_url":"https://avatars0.githubusercontent.com/u/37705979?v=4","gravatar_id":"","url":"https://api.github.com/users/groupdocs-total","html_url":"https://github.com/groupdocs-total","followers_url":"https://api.github.com/users/groupdocs-total/followers","following_url":"https://api.github.com/users/groupdocs-total/following{/other_user}","gists_url":"https://api.github.com/users/groupdocs-total/gists{/gist_id}","starred_url":"https://api.github.com/users/groupdocs-total/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groupdocs-total/subscriptions","organizations_url":"https://api.github.com/users/groupdocs-total/orgs","repos_url":"https://api.github.com/users/groupdocs-total/repos","events_url":"https://api.github.com/users/groupdocs-total/events{/privacy}","received_events_url":"https://api.github.com/users/groupdocs-total/received_events","type":"Organization","site_admin":false},"repo":{"id":139564335,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk1NjQzMzU=","name":"GroupDocs.Total-for-NET-MVC","full_name":"groupdocs-total/GroupDocs.Total-for-NET-MVC","private":false,"owner":{"login":"groupdocs-total","id":37705979,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzA1OTc5","avatar_url":"https://avatars0.githubusercontent.com/u/37705979?v=4","gravatar_id":"","url":"https://api.github.com/users/groupdocs-total","html_url":"https://github.com/groupdocs-total","followers_url":"https://api.github.com/users/groupdocs-total/followers","following_url":"https://api.github.com/users/groupdocs-total/following{/other_user}","gists_url":"https://api.github.com/users/groupdocs-total/gists{/gist_id}","starred_url":"https://api.github.com/users/groupdocs-total/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groupdocs-total/subscriptions","organizations_url":"https://api.github.com/users/groupdocs-total/orgs","repos_url":"https://api.github.com/users/groupdocs-total/repos","events_url":"https://api.github.com/users/groupdocs-total/events{/privacy}","received_events_url":"https://api.github.com/users/groupdocs-total/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/groupdocs-total/GroupDocs.Total-for-NET-MVC","description":"GroupDocs.Total for .NET MVC Example","fork":false,"url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC","forks_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/forks","keys_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/teams","hooks_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/hooks","issue_events_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/issues/events{/number}","events_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/events","assignees_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/assignees{/user}","branches_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/branches{/branch}","tags_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/tags","blobs_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/git/refs{/sha}","trees_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/statuses/{sha}","languages_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/languages","stargazers_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/stargazers","contributors_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/contributors","subscribers_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/subscribers","subscription_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/subscription","commits_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/commits{/sha}","git_commits_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/git/commits{/sha}","comments_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/comments{/number}","issue_comment_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/issues/comments{/number}","contents_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/contents/{+path}","compare_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/merges","archive_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/downloads","issues_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/issues{/number}","pulls_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/pulls{/number}","milestones_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/milestones{/number}","notifications_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/labels{/name}","releases_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/releases{/id}","deployments_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/deployments","created_at":"2018-07-03T10:04:07Z","updated_at":"2019-02-19T12:20:48Z","pushed_at":"2019-03-04T07:07:52Z","git_url":"git://github.com/groupdocs-total/GroupDocs.Total-for-NET-MVC.git","ssh_url":"[email protected]:groupdocs-total/GroupDocs.Total-for-NET-MVC.git","clone_url":"https://github.com/groupdocs-total/GroupDocs.Total-for-NET-MVC.git","svn_url":"https://github.com/groupdocs-total/GroupDocs.Total-for-NET-MVC","homepage":"https://products.groupdocs.com/total/net","size":128908,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"groupdocs-total:master","ref":"master","sha":"cb0abbfe3ad4a3e562faedbff751ebb336112aca","user":{"login":"groupdocs-total","id":37705979,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzA1OTc5","avatar_url":"https://avatars0.githubusercontent.com/u/37705979?v=4","gravatar_id":"","url":"https://api.github.com/users/groupdocs-total","html_url":"https://github.com/groupdocs-total","followers_url":"https://api.github.com/users/groupdocs-total/followers","following_url":"https://api.github.com/users/groupdocs-total/following{/other_user}","gists_url":"https://api.github.com/users/groupdocs-total/gists{/gist_id}","starred_url":"https://api.github.com/users/groupdocs-total/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groupdocs-total/subscriptions","organizations_url":"https://api.github.com/users/groupdocs-total/orgs","repos_url":"https://api.github.com/users/groupdocs-total/repos","events_url":"https://api.github.com/users/groupdocs-total/events{/privacy}","received_events_url":"https://api.github.com/users/groupdocs-total/received_events","type":"Organization","site_admin":false},"repo":{"id":139564335,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk1NjQzMzU=","name":"GroupDocs.Total-for-NET-MVC","full_name":"groupdocs-total/GroupDocs.Total-for-NET-MVC","private":false,"owner":{"login":"groupdocs-total","id":37705979,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzA1OTc5","avatar_url":"https://avatars0.githubusercontent.com/u/37705979?v=4","gravatar_id":"","url":"https://api.github.com/users/groupdocs-total","html_url":"https://github.com/groupdocs-total","followers_url":"https://api.github.com/users/groupdocs-total/followers","following_url":"https://api.github.com/users/groupdocs-total/following{/other_user}","gists_url":"https://api.github.com/users/groupdocs-total/gists{/gist_id}","starred_url":"https://api.github.com/users/groupdocs-total/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/groupdocs-total/subscriptions","organizations_url":"https://api.github.com/users/groupdocs-total/orgs","repos_url":"https://api.github.com/users/groupdocs-total/repos","events_url":"https://api.github.com/users/groupdocs-total/events{/privacy}","received_events_url":"https://api.github.com/users/groupdocs-total/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/groupdocs-total/GroupDocs.Total-for-NET-MVC","description":"GroupDocs.Total for .NET MVC Example","fork":false,"url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC","forks_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/forks","keys_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/teams","hooks_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/hooks","issue_events_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/issues/events{/number}","events_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/events","assignees_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/assignees{/user}","branches_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/branches{/branch}","tags_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/tags","blobs_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/git/refs{/sha}","trees_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/statuses/{sha}","languages_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/languages","stargazers_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/stargazers","contributors_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/contributors","subscribers_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/subscribers","subscription_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/subscription","commits_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/commits{/sha}","git_commits_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/git/commits{/sha}","comments_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/comments{/number}","issue_comment_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/issues/comments{/number}","contents_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/contents/{+path}","compare_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/merges","archive_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/downloads","issues_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/issues{/number}","pulls_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/pulls{/number}","milestones_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/milestones{/number}","notifications_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/labels{/name}","releases_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/releases{/id}","deployments_url":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/deployments","created_at":"2018-07-03T10:04:07Z","updated_at":"2019-02-19T12:20:48Z","pushed_at":"2019-03-04T07:07:52Z","git_url":"git://github.com/groupdocs-total/GroupDocs.Total-for-NET-MVC.git","ssh_url":"[email protected]:groupdocs-total/GroupDocs.Total-for-NET-MVC.git","clone_url":"https://github.com/groupdocs-total/GroupDocs.Total-for-NET-MVC.git","svn_url":"https://github.com/groupdocs-total/GroupDocs.Total-for-NET-MVC","homepage":"https://products.groupdocs.com/total/net","size":128908,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/pulls/36"},"html":{"href":"https://github.com/groupdocs-total/GroupDocs.Total-for-NET-MVC/pull/36"},"issue":{"href":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/issues/36"},"comments":{"href":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC/statuses/735e6bb0f162bc958239653c2c499a6e0d275115"}},"author_association":"CONTRIBUTOR"}}	{ "id": 139564335, "name": "groupdocs-total/GroupDocs.Total-for-NET-MVC", "url": "https://api.github.com/repos/groupdocs-total/GroupDocs.Total-for-NET-MVC" }	{ "id": 19940114, "login": "codacy-bot", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/19940114?", "url": "https://api.github.com/users/codacy-bot" }	{ "id": 37705979, "login": "groupdocs-total", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/37705979?", "url": "https://api.github.com/orgs/groupdocs-total" }	2019-03-04T07:15:04	9172479912	{"actor":{"display_login":"codacy-bot"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/oasislabs/tutorials/pulls/comments/330686266","pull_request_review_id":296415292,"id":330686266,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMDY4NjI2Ng==","diff_hunk":"@@ -29,16 +29,16 @@ impl Ballot {\n }\n }\n \n- /// Returns the candidates being voted upon.\n- pub fn candidates(&self, _ctx: &Context) -> Vec<&str> {\n- self.candidates.iter().map(String::as_ref).collect()\n- }\n-\n /// Returns the description of this ballot.\n pub fn description(&self, _ctx: &Context) -> &str {\n &self.description\n }\n \n+ /// Returns the candidates being voted upon.\n+ pub fn candidates(&self, _ctx: &Context) -> Vec<&str> {\n+ self.candidates.iter().map(String::as_ref).collect()","path":"ballot/service/src/main.rs","position":16,"original_position":16,"commit_id":"93fdd6a4aaaa36a1ef869af9248ea8aaa5c2a065","original_commit_id":"93fdd6a4aaaa36a1ef869af9248ea8aaa5c2a065","user":{"login":"nhynes","id":2353785,"node_id":"MDQ6VXNlcjIzNTM3ODU=","avatar_url":"https://avatars2.githubusercontent.com/u/2353785?v=4","gravatar_id":"","url":"https://api.github.com/users/nhynes","html_url":"https://github.com/nhynes","followers_url":"https://api.github.com/users/nhynes/followers","following_url":"https://api.github.com/users/nhynes/following{/other_user}","gists_url":"https://api.github.com/users/nhynes/gists{/gist_id}","starred_url":"https://api.github.com/users/nhynes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nhynes/subscriptions","organizations_url":"https://api.github.com/users/nhynes/orgs","repos_url":"https://api.github.com/users/nhynes/repos","events_url":"https://api.github.com/users/nhynes/events{/privacy}","received_events_url":"https://api.github.com/users/nhynes/received_events","type":"User","site_admin":false},"body":"```rust\r\npub fn candidates(&self, _ctx: &Context) -> &[String] {\r\n &self.candidates\r\n}\r\n```\r\n\r\nit's simple and efficient--no copying, no allocation","created_at":"2019-10-02T17:49:43Z","updated_at":"2019-10-02T17:49:43Z","html_url":"https://github.com/oasislabs/tutorials/pull/46#discussion_r330686266","pull_request_url":"https://api.github.com/repos/oasislabs/tutorials/pulls/46","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oasislabs/tutorials/pulls/comments/330686266"},"html":{"href":"https://github.com/oasislabs/tutorials/pull/46#discussion_r330686266"},"pull_request":{"href":"https://api.github.com/repos/oasislabs/tutorials/pulls/46"}},"in_reply_to_id":330658263},"pull_request":{"url":"https://api.github.com/repos/oasislabs/tutorials/pulls/46","id":323515989,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIzNTE1OTg5","html_url":"https://github.com/oasislabs/tutorials/pull/46","diff_url":"https://github.com/oasislabs/tutorials/pull/46.diff","patch_url":"https://github.com/oasislabs/tutorials/pull/46.patch","issue_url":"https://api.github.com/repos/oasislabs/tutorials/issues/46","number":46,"state":"open","locked":false,"title":"Resolve Secret Ballot issues","user":{"login":"ennsharma","id":8357258,"node_id":"MDQ6VXNlcjgzNTcyNTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8357258?v=4","gravatar_id":"","url":"https://api.github.com/users/ennsharma","html_url":"https://github.com/ennsharma","followers_url":"https://api.github.com/users/ennsharma/followers","following_url":"https://api.github.com/users/ennsharma/following{/other_user}","gists_url":"https://api.github.com/users/ennsharma/gists{/gist_id}","starred_url":"https://api.github.com/users/ennsharma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ennsharma/subscriptions","organizations_url":"https://api.github.com/users/ennsharma/orgs","repos_url":"https://api.github.com/users/ennsharma/repos","events_url":"https://api.github.com/users/ennsharma/events{/privacy}","received_events_url":"https://api.github.com/users/ennsharma/received_events","type":"User","site_admin":false},"body":"This PR fixes several issues with the Secret Ballot tutorial application, namely:\r\n\r\n- [x] Imports appropriate dependencies needed to get `oasis deploy` to deploy instances of the ballot service.\r\n- [x] Add client-side tests beyond deploy test that run with `oasis test`.\r\n","created_at":"2019-10-01T23:22:12Z","updated_at":"2019-10-02T17:49:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a08855a3116de4b94e9cac89e7db48d03ad41ee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oasislabs/tutorials/pulls/46/commits","review_comments_url":"https://api.github.com/repos/oasislabs/tutorials/pulls/46/comments","review_comment_url":"https://api.github.com/repos/oasislabs/tutorials/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oasislabs/tutorials/issues/46/comments","statuses_url":"https://api.github.com/repos/oasislabs/tutorials/statuses/93fdd6a4aaaa36a1ef869af9248ea8aaa5c2a065","head":{"label":"oasislabs:ennsharma/sb-testing","ref":"ennsharma/sb-testing","sha":"93fdd6a4aaaa36a1ef869af9248ea8aaa5c2a065","user":{"login":"oasislabs","id":37714332,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzE0MzMy","avatar_url":"https://avatars0.githubusercontent.com/u/37714332?v=4","gravatar_id":"","url":"https://api.github.com/users/oasislabs","html_url":"https://github.com/oasislabs","followers_url":"https://api.github.com/users/oasislabs/followers","following_url":"https://api.github.com/users/oasislabs/following{/other_user}","gists_url":"https://api.github.com/users/oasislabs/gists{/gist_id}","starred_url":"https://api.github.com/users/oasislabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oasislabs/subscriptions","organizations_url":"https://api.github.com/users/oasislabs/orgs","repos_url":"https://api.github.com/users/oasislabs/repos","events_url":"https://api.github.com/users/oasislabs/events{/privacy}","received_events_url":"https://api.github.com/users/oasislabs/received_events","type":"Organization","site_admin":false},"repo":{"id":197277210,"node_id":"MDEwOlJlcG9zaXRvcnkxOTcyNzcyMTA=","name":"tutorials","full_name":"oasislabs/tutorials","private":false,"owner":{"login":"oasislabs","id":37714332,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzE0MzMy","avatar_url":"https://avatars0.githubusercontent.com/u/37714332?v=4","gravatar_id":"","url":"https://api.github.com/users/oasislabs","html_url":"https://github.com/oasislabs","followers_url":"https://api.github.com/users/oasislabs/followers","following_url":"https://api.github.com/users/oasislabs/following{/other_user}","gists_url":"https://api.github.com/users/oasislabs/gists{/gist_id}","starred_url":"https://api.github.com/users/oasislabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oasislabs/subscriptions","organizations_url":"https://api.github.com/users/oasislabs/orgs","repos_url":"https://api.github.com/users/oasislabs/repos","events_url":"https://api.github.com/users/oasislabs/events{/privacy}","received_events_url":"https://api.github.com/users/oasislabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oasislabs/tutorials","description":"The examples and tutorials that we expose to external developers","fork":false,"url":"https://api.github.com/repos/oasislabs/tutorials","forks_url":"https://api.github.com/repos/oasislabs/tutorials/forks","keys_url":"https://api.github.com/repos/oasislabs/tutorials/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oasislabs/tutorials/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oasislabs/tutorials/teams","hooks_url":"https://api.github.com/repos/oasislabs/tutorials/hooks","issue_events_url":"https://api.github.com/repos/oasislabs/tutorials/issues/events{/number}","events_url":"https://api.github.com/repos/oasislabs/tutorials/events","assignees_url":"https://api.github.com/repos/oasislabs/tutorials/assignees{/user}","branches_url":"https://api.github.com/repos/oasislabs/tutorials/branches{/branch}","tags_url":"https://api.github.com/repos/oasislabs/tutorials/tags","blobs_url":"https://api.github.com/repos/oasislabs/tutorials/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oasislabs/tutorials/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oasislabs/tutorials/git/refs{/sha}","trees_url":"https://api.github.com/repos/oasislabs/tutorials/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oasislabs/tutorials/statuses/{sha}","languages_url":"https://api.github.com/repos/oasislabs/tutorials/languages","stargazers_url":"https://api.github.com/repos/oasislabs/tutorials/stargazers","contributors_url":"https://api.github.com/repos/oasislabs/tutorials/contributors","subscribers_url":"https://api.github.com/repos/oasislabs/tutorials/subscribers","subscription_url":"https://api.github.com/repos/oasislabs/tutorials/subscription","commits_url":"https://api.github.com/repos/oasislabs/tutorials/commits{/sha}","git_commits_url":"https://api.github.com/repos/oasislabs/tutorials/git/commits{/sha}","comments_url":"https://api.github.com/repos/oasislabs/tutorials/comments{/number}","issue_comment_url":"https://api.github.com/repos/oasislabs/tutorials/issues/comments{/number}","contents_url":"https://api.github.com/repos/oasislabs/tutorials/contents/{+path}","compare_url":"https://api.github.com/repos/oasislabs/tutorials/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oasislabs/tutorials/merges","archive_url":"https://api.github.com/repos/oasislabs/tutorials/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oasislabs/tutorials/downloads","issues_url":"https://api.github.com/repos/oasislabs/tutorials/issues{/number}","pulls_url":"https://api.github.com/repos/oasislabs/tutorials/pulls{/number}","milestones_url":"https://api.github.com/repos/oasislabs/tutorials/milestones{/number}","notifications_url":"https://api.github.com/repos/oasislabs/tutorials/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oasislabs/tutorials/labels{/name}","releases_url":"https://api.github.com/repos/oasislabs/tutorials/releases{/id}","deployments_url":"https://api.github.com/repos/oasislabs/tutorials/deployments","created_at":"2019-07-16T22:36:33Z","updated_at":"2019-09-20T23:05:45Z","pushed_at":"2019-10-02T17:38:37Z","git_url":"git://github.com/oasislabs/tutorials.git","ssh_url":"[email protected]:oasislabs/tutorials.git","clone_url":"https://github.com/oasislabs/tutorials.git","svn_url":"https://github.com/oasislabs/tutorials","homepage":null,"size":575,"stargazers_count":1,"watchers_count":1,"language":"Vue","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":11,"watchers":1,"default_branch":"master"}},"base":{"label":"oasislabs:master","ref":"master","sha":"e42d0db66bd69be92aa61998aa95be64633003ef","user":{"login":"oasislabs","id":37714332,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzE0MzMy","avatar_url":"https://avatars0.githubusercontent.com/u/37714332?v=4","gravatar_id":"","url":"https://api.github.com/users/oasislabs","html_url":"https://github.com/oasislabs","followers_url":"https://api.github.com/users/oasislabs/followers","following_url":"https://api.github.com/users/oasislabs/following{/other_user}","gists_url":"https://api.github.com/users/oasislabs/gists{/gist_id}","starred_url":"https://api.github.com/users/oasislabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oasislabs/subscriptions","organizations_url":"https://api.github.com/users/oasislabs/orgs","repos_url":"https://api.github.com/users/oasislabs/repos","events_url":"https://api.github.com/users/oasislabs/events{/privacy}","received_events_url":"https://api.github.com/users/oasislabs/received_events","type":"Organization","site_admin":false},"repo":{"id":197277210,"node_id":"MDEwOlJlcG9zaXRvcnkxOTcyNzcyMTA=","name":"tutorials","full_name":"oasislabs/tutorials","private":false,"owner":{"login":"oasislabs","id":37714332,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NzE0MzMy","avatar_url":"https://avatars0.githubusercontent.com/u/37714332?v=4","gravatar_id":"","url":"https://api.github.com/users/oasislabs","html_url":"https://github.com/oasislabs","followers_url":"https://api.github.com/users/oasislabs/followers","following_url":"https://api.github.com/users/oasislabs/following{/other_user}","gists_url":"https://api.github.com/users/oasislabs/gists{/gist_id}","starred_url":"https://api.github.com/users/oasislabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oasislabs/subscriptions","organizations_url":"https://api.github.com/users/oasislabs/orgs","repos_url":"https://api.github.com/users/oasislabs/repos","events_url":"https://api.github.com/users/oasislabs/events{/privacy}","received_events_url":"https://api.github.com/users/oasislabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oasislabs/tutorials","description":"The examples and tutorials that we expose to external developers","fork":false,"url":"https://api.github.com/repos/oasislabs/tutorials","forks_url":"https://api.github.com/repos/oasislabs/tutorials/forks","keys_url":"https://api.github.com/repos/oasislabs/tutorials/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oasislabs/tutorials/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oasislabs/tutorials/teams","hooks_url":"https://api.github.com/repos/oasislabs/tutorials/hooks","issue_events_url":"https://api.github.com/repos/oasislabs/tutorials/issues/events{/number}","events_url":"https://api.github.com/repos/oasislabs/tutorials/events","assignees_url":"https://api.github.com/repos/oasislabs/tutorials/assignees{/user}","branches_url":"https://api.github.com/repos/oasislabs/tutorials/branches{/branch}","tags_url":"https://api.github.com/repos/oasislabs/tutorials/tags","blobs_url":"https://api.github.com/repos/oasislabs/tutorials/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oasislabs/tutorials/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oasislabs/tutorials/git/refs{/sha}","trees_url":"https://api.github.com/repos/oasislabs/tutorials/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oasislabs/tutorials/statuses/{sha}","languages_url":"https://api.github.com/repos/oasislabs/tutorials/languages","stargazers_url":"https://api.github.com/repos/oasislabs/tutorials/stargazers","contributors_url":"https://api.github.com/repos/oasislabs/tutorials/contributors","subscribers_url":"https://api.github.com/repos/oasislabs/tutorials/subscribers","subscription_url":"https://api.github.com/repos/oasislabs/tutorials/subscription","commits_url":"https://api.github.com/repos/oasislabs/tutorials/commits{/sha}","git_commits_url":"https://api.github.com/repos/oasislabs/tutorials/git/commits{/sha}","comments_url":"https://api.github.com/repos/oasislabs/tutorials/comments{/number}","issue_comment_url":"https://api.github.com/repos/oasislabs/tutorials/issues/comments{/number}","contents_url":"https://api.github.com/repos/oasislabs/tutorials/contents/{+path}","compare_url":"https://api.github.com/repos/oasislabs/tutorials/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oasislabs/tutorials/merges","archive_url":"https://api.github.com/repos/oasislabs/tutorials/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oasislabs/tutorials/downloads","issues_url":"https://api.github.com/repos/oasislabs/tutorials/issues{/number}","pulls_url":"https://api.github.com/repos/oasislabs/tutorials/pulls{/number}","milestones_url":"https://api.github.com/repos/oasislabs/tutorials/milestones{/number}","notifications_url":"https://api.github.com/repos/oasislabs/tutorials/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oasislabs/tutorials/labels{/name}","releases_url":"https://api.github.com/repos/oasislabs/tutorials/releases{/id}","deployments_url":"https://api.github.com/repos/oasislabs/tutorials/deployments","created_at":"2019-07-16T22:36:33Z","updated_at":"2019-09-20T23:05:45Z","pushed_at":"2019-10-02T17:38:37Z","git_url":"git://github.com/oasislabs/tutorials.git","ssh_url":"[email protected]:oasislabs/tutorials.git","clone_url":"https://github.com/oasislabs/tutorials.git","svn_url":"https://github.com/oasislabs/tutorials","homepage":null,"size":575,"stargazers_count":1,"watchers_count":1,"language":"Vue","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oasislabs/tutorials/pulls/46"},"html":{"href":"https://github.com/oasislabs/tutorials/pull/46"},"issue":{"href":"https://api.github.com/repos/oasislabs/tutorials/issues/46"},"comments":{"href":"https://api.github.com/repos/oasislabs/tutorials/issues/46/comments"},"review_comments":{"href":"https://api.github.com/repos/oasislabs/tutorials/pulls/46/comments"},"review_comment":{"href":"https://api.github.com/repos/oasislabs/tutorials/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oasislabs/tutorials/pulls/46/commits"},"statuses":{"href":"https://api.github.com/repos/oasislabs/tutorials/statuses/93fdd6a4aaaa36a1ef869af9248ea8aaa5c2a065"}},"author_association":"MEMBER"}}	{ "id": 197277210, "name": "oasislabs/tutorials", "url": "https://api.github.com/repos/oasislabs/tutorials" }	{ "id": 2353785, "login": "nhynes", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/2353785?", "url": "https://api.github.com/users/nhynes" }	{ "id": 37714332, "login": "oasislabs", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/37714332?", "url": "https://api.github.com/orgs/oasislabs" }	2019-10-02T17:49:43	10544844235	{"actor":{"display_login":"nhynes"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/AudiusProject/audius-protocol/pulls/comments/323383670","pull_request_review_id":286940408,"id":323383670,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMzM4MzY3MA==","diff_hunk":"@@ -0,0 +1,55 @@\n+const Utils = require('../utils')\n+\n+const TEN_SECONDS = 10000\n+const MAX_TRIES = 3\n+\n+/** Check if the user's primary creator node is healthy /\n+const checkPrimaryHealthy = async (libs, primary, tries) => {\n+ const healthy = await Utils.isHealthy(primary)\n+ if (healthy) return healthy\n+ else {\n+ if (tries === 0) {\n+ return false\n+ }\n+ await Utils.wait(TEN_SECONDS)\n+ return checkPrimaryHealthy(libs, primary, tries - 1)\n+ }\n+}\n+\n+/* Gets new endpoints from a user's secondaries */\n+const getNewEndpoints = async (libs, secondaries) => {\n+ for (const secondary of secondaries) {\n+ const { status, userBlockNumber } = await libs.creatorNode.getSyncStatus(secondary)","path":"libs/src/sanityChecks/rolloverNodes.js","position":22,"original_position":22,"commit_id":"56bae5cab2cc5ca5a2bfb73eb1c7149987c0717a","original_commit_id":"56bae5cab2cc5ca5a2bfb73eb1c7149987c0717a","user":{"login":"hareeshnagaraj","id":3180560,"node_id":"MDQ6VXNlcjMxODA1NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/3180560?v=4","gravatar_id":"","url":"https://api.github.com/users/hareeshnagaraj","html_url":"https://github.com/hareeshnagaraj","followers_url":"https://api.github.com/users/hareeshnagaraj/followers","following_url":"https://api.github.com/users/hareeshnagaraj/following{/other_user}","gists_url":"https://api.github.com/users/hareeshnagaraj/gists{/gist_id}","starred_url":"https://api.github.com/users/hareeshnagaraj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hareeshnagaraj/subscriptions","organizations_url":"https://api.github.com/users/hareeshnagaraj/orgs","repos_url":"https://api.github.com/users/hareeshnagaraj/repos","events_url":"https://api.github.com/users/hareeshnagaraj/events{/privacy}","received_events_url":"https://api.github.com/users/hareeshnagaraj/received_events","type":"User","site_admin":false},"body":"where is status.blocknumber defined? the sync_status endpoint returns `return successResponse({ walletPublicKey, latestBlockNumber })` - is it in the middleware somewhere? also, how does this comparison represent the latest known blocknumber across nodes?","created_at":"2019-09-11T18:06:45Z","updated_at":"2019-09-11T18:09:17Z","html_url":"https://github.com/AudiusProject/audius-protocol/pull/36#discussion_r323383670","pull_request_url":"https://api.github.com/repos/AudiusProject/audius-protocol/pulls/36","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/AudiusProject/audius-protocol/pulls/comments/323383670"},"html":{"href":"https://github.com/AudiusProject/audius-protocol/pull/36#discussion_r323383670"},"pull_request":{"href":"https://api.github.com/repos/AudiusProject/audius-protocol/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/AudiusProject/audius-protocol/pulls/36","id":315024702,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE1MDI0NzAy","html_url":"https://github.com/AudiusProject/audius-protocol/pull/36","diff_url":"https://github.com/AudiusProject/audius-protocol/pull/36.diff","patch_url":"https://github.com/AudiusProject/audius-protocol/pull/36.patch","issue_url":"https://api.github.com/repos/AudiusProject/audius-protocol/issues/36","number":36,"state":"open","locked":false,"title":"Nodesync Improvements","user":{"login":"SidSethi","id":3323835,"node_id":"MDQ6VXNlcjMzMjM4MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3323835?v=4","gravatar_id":"","url":"https://api.github.com/users/SidSethi","html_url":"https://github.com/SidSethi","followers_url":"https://api.github.com/users/SidSethi/followers","following_url":"https://api.github.com/users/SidSethi/following{/other_user}","gists_url":"https://api.github.com/users/SidSethi/gists{/gist_id}","starred_url":"https://api.github.com/users/SidSethi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SidSethi/subscriptions","organizations_url":"https://api.github.com/users/SidSethi/orgs","repos_url":"https://api.github.com/users/SidSethi/repos","events_url":"https://api.github.com/users/SidSethi/events{/privacy}","received_events_url":"https://api.github.com/users/SidSethi/received_events","type":"User","site_admin":false},"body":"Includes\r\n---\r\n- [x] Init libs + discprov connection from creatornode\r\n- [x] block writes to secondaries in pre-middleware\r\n- [x] debounce sync with optional immediate flag\r\n- [x] call secondary syncs in post-middleware\r\n- [x] clean up cnode sync logic + refactor (try-catch, separate fn)\r\n- [x] clean up libs sync logic\r\n- [x] add blocknumber to cnode (add to table, update on all write ops)\r\n- [x] restructure cnode audiusUser + track metadata/create/update flows\r\n - [x] libs\r\n- [x] block sync on outdated blocknumber\r\n\r\nTodo\r\n---\r\n- [ ] failover should check for secondaries that meet blocknumber requirements before allowing them to become primary\r\n - [ ] discprov to expose trackBlockNumber with getUsers query\r\n- [x] circle ci tests are breaking even though all pass locally\r\n- [ ] e2e setup script + tests","created_at":"2019-09-06T16:20:56Z","updated_at":"2019-09-11T18:09:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20e01045cd1cc750ddfc13e123de128ba16cce30","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AudiusProject/audius-protocol/pulls/36/commits","review_comments_url":"https://api.github.com/repos/AudiusProject/audius-protocol/pulls/36/comments","review_comment_url":"https://api.github.com/repos/AudiusProject/audius-protocol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AudiusProject/audius-protocol/issues/36/comments","statuses_url":"https://api.github.com/repos/AudiusProject/audius-protocol/statuses/56bae5cab2cc5ca5a2bfb73eb1c7149987c0717a","head":{"label":"AudiusProject:ss-node-sync-improvements","ref":"ss-node-sync-improvements","sha":"56bae5cab2cc5ca5a2bfb73eb1c7149987c0717a","user":{"login":"AudiusProject","id":38231615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjMxNjE1","avatar_url":"https://avatars0.githubusercontent.com/u/38231615?v=4","gravatar_id":"","url":"https://api.github.com/users/AudiusProject","html_url":"https://github.com/AudiusProject","followers_url":"https://api.github.com/users/AudiusProject/followers","following_url":"https://api.github.com/users/AudiusProject/following{/other_user}","gists_url":"https://api.github.com/users/AudiusProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AudiusProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AudiusProject/subscriptions","organizations_url":"https://api.github.com/users/AudiusProject/orgs","repos_url":"https://api.github.com/users/AudiusProject/repos","events_url":"https://api.github.com/users/AudiusProject/events{/privacy}","received_events_url":"https://api.github.com/users/AudiusProject/received_events","type":"Organization","site_admin":false},"repo":{"id":201821771,"node_id":"MDEwOlJlcG9zaXRvcnkyMDE4MjE3NzE=","name":"audius-protocol","full_name":"AudiusProject/audius-protocol","private":false,"owner":{"login":"AudiusProject","id":38231615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjMxNjE1","avatar_url":"https://avatars0.githubusercontent.com/u/38231615?v=4","gravatar_id":"","url":"https://api.github.com/users/AudiusProject","html_url":"https://github.com/AudiusProject","followers_url":"https://api.github.com/users/AudiusProject/followers","following_url":"https://api.github.com/users/AudiusProject/following{/other_user}","gists_url":"https://api.github.com/users/AudiusProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AudiusProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AudiusProject/subscriptions","organizations_url":"https://api.github.com/users/AudiusProject/orgs","repos_url":"https://api.github.com/users/AudiusProject/repos","events_url":"https://api.github.com/users/AudiusProject/events{/privacy}","received_events_url":"https://api.github.com/users/AudiusProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AudiusProject/audius-protocol","description":"Audius gives everyone the freedom to share, monetize, and listen to any audio content.","fork":false,"url":"https://api.github.com/repos/AudiusProject/audius-protocol","forks_url":"https://api.github.com/repos/AudiusProject/audius-protocol/forks","keys_url":"https://api.github.com/repos/AudiusProject/audius-protocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AudiusProject/audius-protocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AudiusProject/audius-protocol/teams","hooks_url":"https://api.github.com/repos/AudiusProject/audius-protocol/hooks","issue_events_url":"https://api.github.com/repos/AudiusProject/audius-protocol/issues/events{/number}","events_url":"https://api.github.com/repos/AudiusProject/audius-protocol/events","assignees_url":"https://api.github.com/repos/AudiusProject/audius-protocol/assignees{/user}","branches_url":"https://api.github.com/repos/AudiusProject/audius-protocol/branches{/branch}","tags_url":"https://api.github.com/repos/AudiusProject/audius-protocol/tags","blobs_url":"https://api.github.com/repos/AudiusProject/audius-protocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AudiusProject/audius-protocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AudiusProject/audius-protocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/AudiusProject/audius-protocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AudiusProject/audius-protocol/statuses/{sha}","languages_url":"https://api.github.com/repos/AudiusProject/audius-protocol/languages","stargazers_url":"https://api.github.com/repos/AudiusProject/audius-protocol/stargazers","contributors_url":"https://api.github.com/repos/AudiusProject/audius-protocol/contributors","subscribers_url":"https://api.github.com/repos/AudiusProject/audius-protocol/subscribers","subscription_url":"https://api.github.com/repos/AudiusProject/audius-protocol/subscription","commits_url":"https://api.github.com/repos/AudiusProject/audius-protocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/AudiusProject/audius-protocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/AudiusProject/audius-protocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/AudiusProject/audius-protocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/AudiusProject/audius-protocol/contents/{+path}","compare_url":"https://api.github.com/repos/AudiusProject/audius-protocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AudiusProject/audius-protocol/merges","archive_url":"https://api.github.com/repos/AudiusProject/audius-protocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AudiusProject/audius-protocol/downloads","issues_url":"https://api.github.com/repos/AudiusProject/audius-protocol/issues{/number}","pulls_url":"https://api.github.com/repos/AudiusProject/audius-protocol/pulls{/number}","milestones_url":"https://api.github.com/repos/AudiusProject/audius-protocol/milestones{/number}","notifications_url":"https://api.github.com/repos/AudiusProject/audius-protocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AudiusProject/audius-protocol/labels{/name}","releases_url":"https://api.github.com/repos/AudiusProject/audius-protocol/releases{/id}","deployments_url":"https://api.github.com/repos/AudiusProject/audius-protocol/deployments","created_at":"2019-08-11T22:31:43Z","updated_at":"2019-09-11T01:38:39Z","pushed_at":"2019-09-11T16:53:26Z","git_url":"git://github.com/AudiusProject/audius-protocol.git","ssh_url":"[email protected]:AudiusProject/audius-protocol.git","clone_url":"https://github.com/AudiusProject/audius-protocol.git","svn_url":"https://github.com/AudiusProject/audius-protocol","homepage":"","size":9488,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":3,"watchers":13,"default_branch":"master"}},"base":{"label":"AudiusProject:master","ref":"master","sha":"54bb8c3e049488c0a63c5ba4d16f27facf798099","user":{"login":"AudiusProject","id":38231615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjMxNjE1","avatar_url":"https://avatars0.githubusercontent.com/u/38231615?v=4","gravatar_id":"","url":"https://api.github.com/users/AudiusProject","html_url":"https://github.com/AudiusProject","followers_url":"https://api.github.com/users/AudiusProject/followers","following_url":"https://api.github.com/users/AudiusProject/following{/other_user}","gists_url":"https://api.github.com/users/AudiusProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AudiusProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AudiusProject/subscriptions","organizations_url":"https://api.github.com/users/AudiusProject/orgs","repos_url":"https://api.github.com/users/AudiusProject/repos","events_url":"https://api.github.com/users/AudiusProject/events{/privacy}","received_events_url":"https://api.github.com/users/AudiusProject/received_events","type":"Organization","site_admin":false},"repo":{"id":201821771,"node_id":"MDEwOlJlcG9zaXRvcnkyMDE4MjE3NzE=","name":"audius-protocol","full_name":"AudiusProject/audius-protocol","private":false,"owner":{"login":"AudiusProject","id":38231615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MjMxNjE1","avatar_url":"https://avatars0.githubusercontent.com/u/38231615?v=4","gravatar_id":"","url":"https://api.github.com/users/AudiusProject","html_url":"https://github.com/AudiusProject","followers_url":"https://api.github.com/users/AudiusProject/followers","following_url":"https://api.github.com/users/AudiusProject/following{/other_user}","gists_url":"https://api.github.com/users/AudiusProject/gists{/gist_id}","starred_url":"https://api.github.com/users/AudiusProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AudiusProject/subscriptions","organizations_url":"https://api.github.com/users/AudiusProject/orgs","repos_url":"https://api.github.com/users/AudiusProject/repos","events_url":"https://api.github.com/users/AudiusProject/events{/privacy}","received_events_url":"https://api.github.com/users/AudiusProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AudiusProject/audius-protocol","description":"Audius gives everyone the freedom to share, monetize, and listen to any audio content.","fork":false,"url":"https://api.github.com/repos/AudiusProject/audius-protocol","forks_url":"https://api.github.com/repos/AudiusProject/audius-protocol/forks","keys_url":"https://api.github.com/repos/AudiusProject/audius-protocol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AudiusProject/audius-protocol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AudiusProject/audius-protocol/teams","hooks_url":"https://api.github.com/repos/AudiusProject/audius-protocol/hooks","issue_events_url":"https://api.github.com/repos/AudiusProject/audius-protocol/issues/events{/number}","events_url":"https://api.github.com/repos/AudiusProject/audius-protocol/events","assignees_url":"https://api.github.com/repos/AudiusProject/audius-protocol/assignees{/user}","branches_url":"https://api.github.com/repos/AudiusProject/audius-protocol/branches{/branch}","tags_url":"https://api.github.com/repos/AudiusProject/audius-protocol/tags","blobs_url":"https://api.github.com/repos/AudiusProject/audius-protocol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AudiusProject/audius-protocol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AudiusProject/audius-protocol/git/refs{/sha}","trees_url":"https://api.github.com/repos/AudiusProject/audius-protocol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AudiusProject/audius-protocol/statuses/{sha}","languages_url":"https://api.github.com/repos/AudiusProject/audius-protocol/languages","stargazers_url":"https://api.github.com/repos/AudiusProject/audius-protocol/stargazers","contributors_url":"https://api.github.com/repos/AudiusProject/audius-protocol/contributors","subscribers_url":"https://api.github.com/repos/AudiusProject/audius-protocol/subscribers","subscription_url":"https://api.github.com/repos/AudiusProject/audius-protocol/subscription","commits_url":"https://api.github.com/repos/AudiusProject/audius-protocol/commits{/sha}","git_commits_url":"https://api.github.com/repos/AudiusProject/audius-protocol/git/commits{/sha}","comments_url":"https://api.github.com/repos/AudiusProject/audius-protocol/comments{/number}","issue_comment_url":"https://api.github.com/repos/AudiusProject/audius-protocol/issues/comments{/number}","contents_url":"https://api.github.com/repos/AudiusProject/audius-protocol/contents/{+path}","compare_url":"https://api.github.com/repos/AudiusProject/audius-protocol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AudiusProject/audius-protocol/merges","archive_url":"https://api.github.com/repos/AudiusProject/audius-protocol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AudiusProject/audius-protocol/downloads","issues_url":"https://api.github.com/repos/AudiusProject/audius-protocol/issues{/number}","pulls_url":"https://api.github.com/repos/AudiusProject/audius-protocol/pulls{/number}","milestones_url":"https://api.github.com/repos/AudiusProject/audius-protocol/milestones{/number}","notifications_url":"https://api.github.com/repos/AudiusProject/audius-protocol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AudiusProject/audius-protocol/labels{/name}","releases_url":"https://api.github.com/repos/AudiusProject/audius-protocol/releases{/id}","deployments_url":"https://api.github.com/repos/AudiusProject/audius-protocol/deployments","created_at":"2019-08-11T22:31:43Z","updated_at":"2019-09-11T01:38:39Z","pushed_at":"2019-09-11T16:53:26Z","git_url":"git://github.com/AudiusProject/audius-protocol.git","ssh_url":"[email protected]:AudiusProject/audius-protocol.git","clone_url":"https://github.com/AudiusProject/audius-protocol.git","svn_url":"https://github.com/AudiusProject/audius-protocol","homepage":"","size":9488,"stargazers_count":13,"watchers_count":13,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":3,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AudiusProject/audius-protocol/pulls/36"},"html":{"href":"https://github.com/AudiusProject/audius-protocol/pull/36"},"issue":{"href":"https://api.github.com/repos/AudiusProject/audius-protocol/issues/36"},"comments":{"href":"https://api.github.com/repos/AudiusProject/audius-protocol/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/AudiusProject/audius-protocol/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/AudiusProject/audius-protocol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AudiusProject/audius-protocol/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/AudiusProject/audius-protocol/statuses/56bae5cab2cc5ca5a2bfb73eb1c7149987c0717a"}},"author_association":"MEMBER"}}	{ "id": 201821771, "name": "AudiusProject/audius-protocol", "url": "https://api.github.com/repos/AudiusProject/audius-protocol" }	{ "id": 3180560, "login": "hareeshnagaraj", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/3180560?", "url": "https://api.github.com/users/hareeshnagaraj" }	{ "id": 38231615, "login": "AudiusProject", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/38231615?", "url": "https://api.github.com/orgs/AudiusProject" }	2019-09-11T18:06:45	10396420891	{"actor":{"display_login":"hareeshnagaraj"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/pulls/comments/337313703","pull_request_review_id":304942491,"id":337313703,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNzMxMzcwMw==","diff_hunk":"@@ -0,0 +1,108 @@\n+package main\n+\n+import (\n+\t\"flag\"\n+\t\"log\"\n+\t\"time\"\n+\n+\tqlcchain \"github.com/qlcchain/qlc-go-sdk\"\n+\t\"github.com/qlcchain/qlc-go-sdk/pkg/types\"\n+)\n+\n+func main() {\n+\tvar endPoint string\n+\tflag.StringVar(&endPoint, \"endpoint\", \"ws://127.0.0.1:29736\", \"RPC Server endpoint\")\n+\tflag.Parse()\n+\n+\tclient, err := qlcchain.NewQLCClient(endPoint)\n+\tif err != nil {\n+\t\tlog.Println(err)\n+\t\treturn\n+\t}\n+\tdefer client.Close()\n+\n+\tch := make(chan types.StateBlock)\n+\tsubscribe, err := client.Ledger.NewBlock(ch)\n+\tif err != nil {\n+\t\tlog.Println(err)\n+\t\treturn\n+\t}\n+\n+\tgo func() {\n+\t\ttime.Sleep(30 time.Second)\n+\t\tif err := client.Ledger.Unsubscribe(subscribe); err != nil {\n+\t\t\tlog.Println(err)\n+\t\t\treturn\n+\t\t}\n+\t\t// if err := subscribe.Close(); err != nil {","path":"example/pubsub/main.go","position":37,"original_position":37,"commit_id":"4ff41e3208a26178716501be59ffc8f1478a511d","original_commit_id":"4ff41e3208a26178716501be59ffc8f1478a511d","user":{"login":"golangcibot","id":42910462,"node_id":"MDQ6VXNlcjQyOTEwNDYy","avatar_url":"https://avatars1.githubusercontent.com/u/42910462?v=4","gravatar_id":"","url":"https://api.github.com/users/golangcibot","html_url":"https://github.com/golangcibot","followers_url":"https://api.github.com/users/golangcibot/followers","following_url":"https://api.github.com/users/golangcibot/following{/other_user}","gists_url":"https://api.github.com/users/golangcibot/gists{/gist_id}","starred_url":"https://api.github.com/users/golangcibot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golangcibot/subscriptions","organizations_url":"https://api.github.com/users/golangcibot/orgs","repos_url":"https://api.github.com/users/golangcibot/repos","events_url":"https://api.github.com/users/golangcibot/events{/privacy}","received_events_url":"https://api.github.com/users/golangcibot/received_events","type":"User","site_admin":false},"body":"commentedOutCode: may want to remove commented-out code (from `gocritic`)","created_at":"2019-10-22T02:40:44Z","updated_at":"2019-10-22T02:40:45Z","html_url":"https://github.com/qlcchain/qlc-go-sdk/pull/31#discussion_r337313703","pull_request_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/pulls/31","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/qlcchain/qlc-go-sdk/pulls/comments/337313703"},"html":{"href":"https://github.com/qlcchain/qlc-go-sdk/pull/31#discussion_r337313703"},"pull_request":{"href":"https://api.github.com/repos/qlcchain/qlc-go-sdk/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/pulls/31","id":330260129,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMwMjYwMTI5","html_url":"https://github.com/qlcchain/qlc-go-sdk/pull/31","diff_url":"https://github.com/qlcchain/qlc-go-sdk/pull/31.diff","patch_url":"https://github.com/qlcchain/qlc-go-sdk/pull/31.patch","issue_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/issues/31","number":31,"state":"open","locked":false,"title":"feat: add pub-sub api","user":{"login":"zengchen221","id":18064741,"node_id":"MDQ6VXNlcjE4MDY0NzQx","avatar_url":"https://avatars2.githubusercontent.com/u/18064741?v=4","gravatar_id":"","url":"https://api.github.com/users/zengchen221","html_url":"https://github.com/zengchen221","followers_url":"https://api.github.com/users/zengchen221/followers","following_url":"https://api.github.com/users/zengchen221/following{/other_user}","gists_url":"https://api.github.com/users/zengchen221/gists{/gist_id}","starred_url":"https://api.github.com/users/zengchen221/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zengchen221/subscriptions","organizations_url":"https://api.github.com/users/zengchen221/orgs","repos_url":"https://api.github.com/users/zengchen221/repos","events_url":"https://api.github.com/users/zengchen221/events{/privacy}","received_events_url":"https://api.github.com/users/zengchen221/received_events","type":"User","site_admin":false},"body":"### Proposed changes in this pull request\r\n\r\n- add pub-sub api\r\n- pub-sub example\r\n- fix #29\r\n\r\n### Type\r\n- [ ] Bug fix: (Link to the issue #{issue No.})\r\n- [x] Feature (Non-breaking change)\r\n- [ ] Feature (Breaking change)\r\n- [ ] Documentation Improvement\r\n\r\n### Checklist\r\nWrite a small comment explaining if its `N/A` (not applicable)\r\n\r\n- [ ] Read the [CONTRIBUTION](https://github.com/qlcchain/qlc.go/blob/master/CONTRIBUTING.md).\r\n- [ ] All the tests are passing after the introduction of new changes.\r\n- [ ] Added tests respective to the part of code I have written.\r\n- [ ] Added proper documentation where ever applicable.\r\n- [ ] Code has been written according to [Golang-Style-Guide](https://github.com/qlcchain/qlc.go/blob/master/CONTRIBUTING.md#code-standard)\r\n\r\n### Extra information\r\nAny extra information related to this pull request.\r\n","created_at":"2019-10-21T07:33:33Z","updated_at":"2019-10-22T02:40:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3c79cc352592cb3f51657bd6380e4f18dcf3a5e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/pulls/31/commits","review_comments_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/pulls/31/comments","review_comment_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/issues/31/comments","statuses_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/statuses/4ff41e3208a26178716501be59ffc8f1478a511d","head":{"label":"qlcchain:feature/pub-sub","ref":"feature/pub-sub","sha":"4ff41e3208a26178716501be59ffc8f1478a511d","user":{"login":"qlcchain","id":38906240,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTA2MjQw","avatar_url":"https://avatars3.githubusercontent.com/u/38906240?v=4","gravatar_id":"","url":"https://api.github.com/users/qlcchain","html_url":"https://github.com/qlcchain","followers_url":"https://api.github.com/users/qlcchain/followers","following_url":"https://api.github.com/users/qlcchain/following{/other_user}","gists_url":"https://api.github.com/users/qlcchain/gists{/gist_id}","starred_url":"https://api.github.com/users/qlcchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qlcchain/subscriptions","organizations_url":"https://api.github.com/users/qlcchain/orgs","repos_url":"https://api.github.com/users/qlcchain/repos","events_url":"https://api.github.com/users/qlcchain/events{/privacy}","received_events_url":"https://api.github.com/users/qlcchain/received_events","type":"Organization","site_admin":false},"repo":{"id":175533427,"node_id":"MDEwOlJlcG9zaXRvcnkxNzU1MzM0Mjc=","name":"qlc-go-sdk","full_name":"qlcchain/qlc-go-sdk","private":false,"owner":{"login":"qlcchain","id":38906240,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTA2MjQw","avatar_url":"https://avatars3.githubusercontent.com/u/38906240?v=4","gravatar_id":"","url":"https://api.github.com/users/qlcchain","html_url":"https://github.com/qlcchain","followers_url":"https://api.github.com/users/qlcchain/followers","following_url":"https://api.github.com/users/qlcchain/following{/other_user}","gists_url":"https://api.github.com/users/qlcchain/gists{/gist_id}","starred_url":"https://api.github.com/users/qlcchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qlcchain/subscriptions","organizations_url":"https://api.github.com/users/qlcchain/orgs","repos_url":"https://api.github.com/users/qlcchain/repos","events_url":"https://api.github.com/users/qlcchain/events{/privacy}","received_events_url":"https://api.github.com/users/qlcchain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qlcchain/qlc-go-sdk","description":"QLC Chain Golang SDK","fork":false,"url":"https://api.github.com/repos/qlcchain/qlc-go-sdk","forks_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/forks","keys_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/teams","hooks_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/hooks","issue_events_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/events","assignees_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/tags","blobs_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/languages","stargazers_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/stargazers","contributors_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/contributors","subscribers_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/subscribers","subscription_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/subscription","commits_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/merges","archive_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/downloads","issues_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/labels{/name}","releases_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/deployments","created_at":"2019-03-14T02:25:53Z","updated_at":"2019-10-21T13:21:51Z","pushed_at":"2019-10-22T02:39:14Z","git_url":"git://github.com/qlcchain/qlc-go-sdk.git","ssh_url":"[email protected]:qlcchain/qlc-go-sdk.git","clone_url":"https://github.com/qlcchain/qlc-go-sdk.git","svn_url":"https://github.com/qlcchain/qlc-go-sdk","homepage":"https://docs.qlcchain.online","size":283,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"qlcchain:master","ref":"master","sha":"fdc465a23eec79bcee99f6e01970ec0c5ed21556","user":{"login":"qlcchain","id":38906240,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTA2MjQw","avatar_url":"https://avatars3.githubusercontent.com/u/38906240?v=4","gravatar_id":"","url":"https://api.github.com/users/qlcchain","html_url":"https://github.com/qlcchain","followers_url":"https://api.github.com/users/qlcchain/followers","following_url":"https://api.github.com/users/qlcchain/following{/other_user}","gists_url":"https://api.github.com/users/qlcchain/gists{/gist_id}","starred_url":"https://api.github.com/users/qlcchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qlcchain/subscriptions","organizations_url":"https://api.github.com/users/qlcchain/orgs","repos_url":"https://api.github.com/users/qlcchain/repos","events_url":"https://api.github.com/users/qlcchain/events{/privacy}","received_events_url":"https://api.github.com/users/qlcchain/received_events","type":"Organization","site_admin":false},"repo":{"id":175533427,"node_id":"MDEwOlJlcG9zaXRvcnkxNzU1MzM0Mjc=","name":"qlc-go-sdk","full_name":"qlcchain/qlc-go-sdk","private":false,"owner":{"login":"qlcchain","id":38906240,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTA2MjQw","avatar_url":"https://avatars3.githubusercontent.com/u/38906240?v=4","gravatar_id":"","url":"https://api.github.com/users/qlcchain","html_url":"https://github.com/qlcchain","followers_url":"https://api.github.com/users/qlcchain/followers","following_url":"https://api.github.com/users/qlcchain/following{/other_user}","gists_url":"https://api.github.com/users/qlcchain/gists{/gist_id}","starred_url":"https://api.github.com/users/qlcchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qlcchain/subscriptions","organizations_url":"https://api.github.com/users/qlcchain/orgs","repos_url":"https://api.github.com/users/qlcchain/repos","events_url":"https://api.github.com/users/qlcchain/events{/privacy}","received_events_url":"https://api.github.com/users/qlcchain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qlcchain/qlc-go-sdk","description":"QLC Chain Golang SDK","fork":false,"url":"https://api.github.com/repos/qlcchain/qlc-go-sdk","forks_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/forks","keys_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/teams","hooks_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/hooks","issue_events_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/events","assignees_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/tags","blobs_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/languages","stargazers_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/stargazers","contributors_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/contributors","subscribers_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/subscribers","subscription_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/subscription","commits_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/merges","archive_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/downloads","issues_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/labels{/name}","releases_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/qlcchain/qlc-go-sdk/deployments","created_at":"2019-03-14T02:25:53Z","updated_at":"2019-10-21T13:21:51Z","pushed_at":"2019-10-22T02:39:14Z","git_url":"git://github.com/qlcchain/qlc-go-sdk.git","ssh_url":"[email protected]:qlcchain/qlc-go-sdk.git","clone_url":"https://github.com/qlcchain/qlc-go-sdk.git","svn_url":"https://github.com/qlcchain/qlc-go-sdk","homepage":"https://docs.qlcchain.online","size":283,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qlcchain/qlc-go-sdk/pulls/31"},"html":{"href":"https://github.com/qlcchain/qlc-go-sdk/pull/31"},"issue":{"href":"https://api.github.com/repos/qlcchain/qlc-go-sdk/issues/31"},"comments":{"href":"https://api.github.com/repos/qlcchain/qlc-go-sdk/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/qlcchain/qlc-go-sdk/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/qlcchain/qlc-go-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qlcchain/qlc-go-sdk/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/qlcchain/qlc-go-sdk/statuses/4ff41e3208a26178716501be59ffc8f1478a511d"}},"author_association":"CONTRIBUTOR"}}	{ "id": 175533427, "name": "qlcchain/qlc-go-sdk", "url": "https://api.github.com/repos/qlcchain/qlc-go-sdk" }	{ "id": 42910462, "login": "golangcibot", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/42910462?", "url": "https://api.github.com/users/golangcibot" }	{ "id": 38906240, "login": "qlcchain", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/38906240?", "url": "https://api.github.com/orgs/qlcchain" }	2019-10-22T02:40:44	10681851977	{"actor":{"display_login":"golangcibot"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/comments/358855636","pull_request_review_id":333358712,"id":358855636,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1ODg1NTYzNg==","diff_hunk":"@@ -121,6 +187,26 @@ class CollectionEditor extends EntityMixinLit(LitElement) {\n \t\t\t\talign-self: flex-start;\n \t\t\t\tmargin: 0.55rem 1.5rem;\n \t\t\t}\n+\t\t\t.d2l-add-activity-dialog {\n+\t\t\t\tmin-height: 500px;\n+\t\t\t}\n+\t\t\t.d2l-add-activity-dialog-header {\n+\t\t\t\tdisplay: flex;","path":"components/d2l-activity-collection-editor/d2l-activity-collection-editor.js","position":132,"original_position":132,"commit_id":"1281b836f1f34d099564042baffedc9cc66e9505","original_commit_id":"1281b836f1f34d099564042baffedc9cc66e9505","user":{"login":"m6jones","id":13232226,"node_id":"MDQ6VXNlcjEzMjMyMjI2","avatar_url":"https://avatars1.githubusercontent.com/u/13232226?v=4","gravatar_id":"","url":"https://api.github.com/users/m6jones","html_url":"https://github.com/m6jones","followers_url":"https://api.github.com/users/m6jones/followers","following_url":"https://api.github.com/users/m6jones/following{/other_user}","gists_url":"https://api.github.com/users/m6jones/gists{/gist_id}","starred_url":"https://api.github.com/users/m6jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m6jones/subscriptions","organizations_url":"https://api.github.com/users/m6jones/orgs","repos_url":"https://api.github.com/users/m6jones/repos","events_url":"https://api.github.com/users/m6jones/events{/privacy}","received_events_url":"https://api.github.com/users/m6jones/received_events","type":"User","site_admin":false},"body":"Alpha sort the css","created_at":"2019-12-17T15:26:18Z","updated_at":"2019-12-17T15:26:18Z","html_url":"https://github.com/BrightspaceHypermediaComponents/activities/pull/551#discussion_r358855636","pull_request_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/551","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/comments/358855636"},"html":{"href":"https://github.com/BrightspaceHypermediaComponents/activities/pull/551#discussion_r358855636"},"pull_request":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/551"}}},"pull_request":{"url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/551","id":353767969,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUzNzY3OTY5","html_url":"https://github.com/BrightspaceHypermediaComponents/activities/pull/551","diff_url":"https://github.com/BrightspaceHypermediaComponents/activities/pull/551.diff","patch_url":"https://github.com/BrightspaceHypermediaComponents/activities/pull/551.patch","issue_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues/551","number":551,"state":"open","locked":false,"title":"add \"add-activity\" functionality for collection-edit.","user":{"login":"jlai-d2l","id":10850030,"node_id":"MDQ6VXNlcjEwODUwMDMw","avatar_url":"https://avatars2.githubusercontent.com/u/10850030?v=4","gravatar_id":"","url":"https://api.github.com/users/jlai-d2l","html_url":"https://github.com/jlai-d2l","followers_url":"https://api.github.com/users/jlai-d2l/followers","following_url":"https://api.github.com/users/jlai-d2l/following{/other_user}","gists_url":"https://api.github.com/users/jlai-d2l/gists{/gist_id}","starred_url":"https://api.github.com/users/jlai-d2l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlai-d2l/subscriptions","organizations_url":"https://api.github.com/users/jlai-d2l/orgs","repos_url":"https://api.github.com/users/jlai-d2l/repos","events_url":"https://api.github.com/users/jlai-d2l/events{/privacy}","received_events_url":"https://api.github.com/users/jlai-d2l/received_events","type":"User","site_admin":false},"body":"Requires: https://github.com/BrightspaceHypermediaComponents/siren-sdk/pull/110\r\n\r\nScreenshots\r\n![image](https://user-images.githubusercontent.com/10850030/71002923-3abbb580-20ae-11ea-9f87-a82224ead995.png)\r\n![image](https://user-images.githubusercontent.com/10850030/71003147-9d14b600-20ae-11ea-8334-92b679197b35.png)\r\n\r\n","created_at":"2019-12-16T21:06:25Z","updated_at":"2019-12-17T15:26:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb38c909a3e412af9176077f7e2c0a24452d6663","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/551/commits","review_comments_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/551/comments","review_comment_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues/551/comments","statuses_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/statuses/1281b836f1f34d099564042baffedc9cc66e9505","head":{"label":"BrightspaceHypermediaComponents:jlai/add-activities","ref":"jlai/add-activities","sha":"1281b836f1f34d099564042baffedc9cc66e9505","user":{"login":"BrightspaceHypermediaComponents","id":38923320,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTIzMzIw","avatar_url":"https://avatars0.githubusercontent.com/u/38923320?v=4","gravatar_id":"","url":"https://api.github.com/users/BrightspaceHypermediaComponents","html_url":"https://github.com/BrightspaceHypermediaComponents","followers_url":"https://api.github.com/users/BrightspaceHypermediaComponents/followers","following_url":"https://api.github.com/users/BrightspaceHypermediaComponents/following{/other_user}","gists_url":"https://api.github.com/users/BrightspaceHypermediaComponents/gists{/gist_id}","starred_url":"https://api.github.com/users/BrightspaceHypermediaComponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrightspaceHypermediaComponents/subscriptions","organizations_url":"https://api.github.com/users/BrightspaceHypermediaComponents/orgs","repos_url":"https://api.github.com/users/BrightspaceHypermediaComponents/repos","events_url":"https://api.github.com/users/BrightspaceHypermediaComponents/events{/privacy}","received_events_url":"https://api.github.com/users/BrightspaceHypermediaComponents/received_events","type":"Organization","site_admin":false},"repo":{"id":153316014,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMzMTYwMTQ=","name":"activities","full_name":"BrightspaceHypermediaComponents/activities","private":false,"owner":{"login":"BrightspaceHypermediaComponents","id":38923320,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTIzMzIw","avatar_url":"https://avatars0.githubusercontent.com/u/38923320?v=4","gravatar_id":"","url":"https://api.github.com/users/BrightspaceHypermediaComponents","html_url":"https://github.com/BrightspaceHypermediaComponents","followers_url":"https://api.github.com/users/BrightspaceHypermediaComponents/followers","following_url":"https://api.github.com/users/BrightspaceHypermediaComponents/following{/other_user}","gists_url":"https://api.github.com/users/BrightspaceHypermediaComponents/gists{/gist_id}","starred_url":"https://api.github.com/users/BrightspaceHypermediaComponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrightspaceHypermediaComponents/subscriptions","organizations_url":"https://api.github.com/users/BrightspaceHypermediaComponents/orgs","repos_url":"https://api.github.com/users/BrightspaceHypermediaComponents/repos","events_url":"https://api.github.com/users/BrightspaceHypermediaComponents/events{/privacy}","received_events_url":"https://api.github.com/users/BrightspaceHypermediaComponents/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BrightspaceHypermediaComponents/activities","description":null,"fork":false,"url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities","forks_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/forks","keys_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/teams","hooks_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/hooks","issue_events_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues/events{/number}","events_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/events","assignees_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/assignees{/user}","branches_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/branches{/branch}","tags_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/tags","blobs_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/statuses/{sha}","languages_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/languages","stargazers_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/stargazers","contributors_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/contributors","subscribers_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/subscribers","subscription_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/subscription","commits_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/contents/{+path}","compare_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/merges","archive_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/downloads","issues_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues{/number}","pulls_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls{/number}","milestones_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/milestones{/number}","notifications_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/labels{/name}","releases_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/releases{/id}","deployments_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/deployments","created_at":"2018-10-16T16:14:04Z","updated_at":"2019-12-16T22:05:17Z","pushed_at":"2019-12-17T14:56:53Z","git_url":"git://github.com/BrightspaceHypermediaComponents/activities.git","ssh_url":"[email protected]:BrightspaceHypermediaComponents/activities.git","clone_url":"https://github.com/BrightspaceHypermediaComponents/activities.git","svn_url":"https://github.com/BrightspaceHypermediaComponents/activities","homepage":null,"size":4104,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":9,"watchers":3,"default_branch":"master"}},"base":{"label":"BrightspaceHypermediaComponents:master","ref":"master","sha":"25174395ecc160c345e13c9fcd1007b3b473c7ea","user":{"login":"BrightspaceHypermediaComponents","id":38923320,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTIzMzIw","avatar_url":"https://avatars0.githubusercontent.com/u/38923320?v=4","gravatar_id":"","url":"https://api.github.com/users/BrightspaceHypermediaComponents","html_url":"https://github.com/BrightspaceHypermediaComponents","followers_url":"https://api.github.com/users/BrightspaceHypermediaComponents/followers","following_url":"https://api.github.com/users/BrightspaceHypermediaComponents/following{/other_user}","gists_url":"https://api.github.com/users/BrightspaceHypermediaComponents/gists{/gist_id}","starred_url":"https://api.github.com/users/BrightspaceHypermediaComponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrightspaceHypermediaComponents/subscriptions","organizations_url":"https://api.github.com/users/BrightspaceHypermediaComponents/orgs","repos_url":"https://api.github.com/users/BrightspaceHypermediaComponents/repos","events_url":"https://api.github.com/users/BrightspaceHypermediaComponents/events{/privacy}","received_events_url":"https://api.github.com/users/BrightspaceHypermediaComponents/received_events","type":"Organization","site_admin":false},"repo":{"id":153316014,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMzMTYwMTQ=","name":"activities","full_name":"BrightspaceHypermediaComponents/activities","private":false,"owner":{"login":"BrightspaceHypermediaComponents","id":38923320,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTIzMzIw","avatar_url":"https://avatars0.githubusercontent.com/u/38923320?v=4","gravatar_id":"","url":"https://api.github.com/users/BrightspaceHypermediaComponents","html_url":"https://github.com/BrightspaceHypermediaComponents","followers_url":"https://api.github.com/users/BrightspaceHypermediaComponents/followers","following_url":"https://api.github.com/users/BrightspaceHypermediaComponents/following{/other_user}","gists_url":"https://api.github.com/users/BrightspaceHypermediaComponents/gists{/gist_id}","starred_url":"https://api.github.com/users/BrightspaceHypermediaComponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrightspaceHypermediaComponents/subscriptions","organizations_url":"https://api.github.com/users/BrightspaceHypermediaComponents/orgs","repos_url":"https://api.github.com/users/BrightspaceHypermediaComponents/repos","events_url":"https://api.github.com/users/BrightspaceHypermediaComponents/events{/privacy}","received_events_url":"https://api.github.com/users/BrightspaceHypermediaComponents/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BrightspaceHypermediaComponents/activities","description":null,"fork":false,"url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities","forks_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/forks","keys_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/teams","hooks_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/hooks","issue_events_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues/events{/number}","events_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/events","assignees_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/assignees{/user}","branches_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/branches{/branch}","tags_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/tags","blobs_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/refs{/sha}","trees_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/statuses/{sha}","languages_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/languages","stargazers_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/stargazers","contributors_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/contributors","subscribers_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/subscribers","subscription_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/subscription","commits_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/commits{/sha}","git_commits_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/git/commits{/sha}","comments_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/comments{/number}","issue_comment_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues/comments{/number}","contents_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/contents/{+path}","compare_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/merges","archive_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/downloads","issues_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues{/number}","pulls_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls{/number}","milestones_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/milestones{/number}","notifications_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/labels{/name}","releases_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/releases{/id}","deployments_url":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/deployments","created_at":"2018-10-16T16:14:04Z","updated_at":"2019-12-16T22:05:17Z","pushed_at":"2019-12-17T14:56:53Z","git_url":"git://github.com/BrightspaceHypermediaComponents/activities.git","ssh_url":"[email protected]:BrightspaceHypermediaComponents/activities.git","clone_url":"https://github.com/BrightspaceHypermediaComponents/activities.git","svn_url":"https://github.com/BrightspaceHypermediaComponents/activities","homepage":null,"size":4104,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":9,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/551"},"html":{"href":"https://github.com/BrightspaceHypermediaComponents/activities/pull/551"},"issue":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues/551"},"comments":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/issues/551/comments"},"review_comments":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/551/comments"},"review_comment":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/pulls/551/commits"},"statuses":{"href":"https://api.github.com/repos/BrightspaceHypermediaComponents/activities/statuses/1281b836f1f34d099564042baffedc9cc66e9505"}},"author_association":"CONTRIBUTOR"}}	{ "id": 153316014, "name": "BrightspaceHypermediaComponents/activities", "url": "https://api.github.com/repos/BrightspaceHypermediaComponents/activities" }	{ "id": 13232226, "login": "m6jones", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/13232226?", "url": "https://api.github.com/users/m6jones" }	{ "id": 38923320, "login": "BrightspaceHypermediaComponents", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/38923320?", "url": "https://api.github.com/orgs/BrightspaceHypermediaComponents" }	2019-12-17T15:26:18	11108258849	{"actor":{"display_login":"m6jones"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/gitgitgadget/git/pulls/comments/339001153","pull_request_review_id":307135184,"id":339001153,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzOTAwMTE1Mw==","diff_hunk":"@@ -355,15 +355,19 @@ static inline int needs_hiding(const char path)\n \tif (!path)\n \t\treturn 0;\n \n-\tfor (basename = path; path; path++)\n-\t\tif (is_dir_sep(path)) {\n-\t\t\tdo {\n-\t\t\t\tpath++;\n-\t\t\t} while (is_dir_sep(path));\n-\t\t\t/ ignore trailing slashes /\n-\t\t\tif (path)\n-\t\t\t\tbasename = path;\n-\t\t}\n+\t/* find last non-empty path component /\n+\tfor (basename = path; path; path++) {\n+ \t\tif (!is_dir_sep(*path))\n+\t\t\tcontinue;\n+\n+\t\tif (!path[1])\n+\t\t\tbreak;\n+\n+\t\tif (is_dir_sep(path[1]))\n+\t\t\tcontinue;\n+\n+\t\tbasename = path + 1;","path":"compat/mingw.c","position":24,"original_position":24,"commit_id":"41ed248f68f26be968822d9539ff16b85a316202","original_commit_id":"41ed248f68f26be968822d9539ff16b85a316202","user":{"login":"dscho","id":127790,"node_id":"MDQ6VXNlcjEyNzc5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/127790?v=4","gravatar_id":"","url":"https://api.github.com/users/dscho","html_url":"https://github.com/dscho","followers_url":"https://api.github.com/users/dscho/followers","following_url":"https://api.github.com/users/dscho/following{/other_user}","gists_url":"https://api.github.com/users/dscho/gists{/gist_id}","starred_url":"https://api.github.com/users/dscho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dscho/subscriptions","organizations_url":"https://api.github.com/users/dscho/orgs","repos_url":"https://api.github.com/users/dscho/repos","events_url":"https://api.github.com/users/dscho/events{/privacy}","received_events_url":"https://api.github.com/users/dscho/received_events","type":"User","site_admin":false},"body":"> I'm fine with whatever code you like more.\r\n> \r\n> > [git-for-windows#2371](https://github.com/git-for-windows/git/pull/2371)\r\n> \r\n> It's a pity the patch is no longer mine. Boasting rights, you know.\r\n\r\nSorry, I meant to give you credit via that footer. Would you like a `Co-authored-by:` footer instead? The analysis is essentially yours...","created_at":"2019-10-25T11:11:40Z","updated_at":"2019-10-25T11:11:41Z","html_url":"https://github.com/gitgitgadget/git/pull/414#discussion_r339001153","pull_request_url":"https://api.github.com/repos/gitgitgadget/git/pulls/414","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gitgitgadget/git/pulls/comments/339001153"},"html":{"href":"https://github.com/gitgitgadget/git/pull/414#discussion_r339001153"},"pull_request":{"href":"https://api.github.com/repos/gitgitgadget/git/pulls/414"}},"in_reply_to_id":338571650},"pull_request":{"url":"https://api.github.com/repos/gitgitgadget/git/pulls/414","id":330968254,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMwOTY4MjU0","html_url":"https://github.com/gitgitgadget/git/pull/414","diff_url":"https://github.com/gitgitgadget/git/pull/414.diff","patch_url":"https://github.com/gitgitgadget/git/pull/414.patch","issue_url":"https://api.github.com/repos/gitgitgadget/git/issues/414","number":414,"state":"open","locked":false,"title":"mingw: Fix crash in needs_hiding()","user":{"login":"SyntevoAlex","id":45797751,"node_id":"MDQ6VXNlcjQ1Nzk3NzUx","avatar_url":"https://avatars3.githubusercontent.com/u/45797751?v=4","gravatar_id":"","url":"https://api.github.com/users/SyntevoAlex","html_url":"https://github.com/SyntevoAlex","followers_url":"https://api.github.com/users/SyntevoAlex/followers","following_url":"https://api.github.com/users/SyntevoAlex/following{/other_user}","gists_url":"https://api.github.com/users/SyntevoAlex/gists{/gist_id}","starred_url":"https://api.github.com/users/SyntevoAlex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SyntevoAlex/subscriptions","organizations_url":"https://api.github.com/users/SyntevoAlex/orgs","repos_url":"https://api.github.com/users/SyntevoAlex/repos","events_url":"https://api.github.com/users/SyntevoAlex/events{/privacy}","received_events_url":"https://api.github.com/users/SyntevoAlex/received_events","type":"User","site_admin":false},"body":"For strings ending with slash, loop jumped over terminating null.\r\n\r\nSigned-off-by: Alexandr Miloslavskiy <[email protected]>","created_at":"2019-10-22T12:37:08Z","updated_at":"2019-10-25T11:11:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53179ac3a7fe22009a56ba6ea14dddf2573aecc3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gitgitgadget/git/pulls/414/commits","review_comments_url":"https://api.github.com/repos/gitgitgadget/git/pulls/414/comments","review_comment_url":"https://api.github.com/repos/gitgitgadget/git/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gitgitgadget/git/issues/414/comments","statuses_url":"https://api.github.com/repos/gitgitgadget/git/statuses/41ed248f68f26be968822d9539ff16b85a316202","head":{"label":"SyntevoAlex:#0201_crash_in_needs_hiding","ref":"#0201_crash_in_needs_hiding","sha":"41ed248f68f26be968822d9539ff16b85a316202","user":{"login":"SyntevoAlex","id":45797751,"node_id":"MDQ6VXNlcjQ1Nzk3NzUx","avatar_url":"https://avatars3.githubusercontent.com/u/45797751?v=4","gravatar_id":"","url":"https://api.github.com/users/SyntevoAlex","html_url":"https://github.com/SyntevoAlex","followers_url":"https://api.github.com/users/SyntevoAlex/followers","following_url":"https://api.github.com/users/SyntevoAlex/following{/other_user}","gists_url":"https://api.github.com/users/SyntevoAlex/gists{/gist_id}","starred_url":"https://api.github.com/users/SyntevoAlex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SyntevoAlex/subscriptions","organizations_url":"https://api.github.com/users/SyntevoAlex/orgs","repos_url":"https://api.github.com/users/SyntevoAlex/repos","events_url":"https://api.github.com/users/SyntevoAlex/events{/privacy}","received_events_url":"https://api.github.com/users/SyntevoAlex/received_events","type":"User","site_admin":false},"repo":{"id":208848256,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg4NDgyNTY=","name":"git","full_name":"SyntevoAlex/git","private":false,"owner":{"login":"SyntevoAlex","id":45797751,"node_id":"MDQ6VXNlcjQ1Nzk3NzUx","avatar_url":"https://avatars3.githubusercontent.com/u/45797751?v=4","gravatar_id":"","url":"https://api.github.com/users/SyntevoAlex","html_url":"https://github.com/SyntevoAlex","followers_url":"https://api.github.com/users/SyntevoAlex/followers","following_url":"https://api.github.com/users/SyntevoAlex/following{/other_user}","gists_url":"https://api.github.com/users/SyntevoAlex/gists{/gist_id}","starred_url":"https://api.github.com/users/SyntevoAlex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SyntevoAlex/subscriptions","organizations_url":"https://api.github.com/users/SyntevoAlex/orgs","repos_url":"https://api.github.com/users/SyntevoAlex/repos","events_url":"https://api.github.com/users/SyntevoAlex/events{/privacy}","received_events_url":"https://api.github.com/users/SyntevoAlex/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SyntevoAlex/git","description":"Git Source Code Mirror - This is a publish-only repository and all pull requests are ignored. Please follow Documentation/SubmittingPatches procedure for any of your improvements.","fork":true,"url":"https://api.github.com/repos/SyntevoAlex/git","forks_url":"https://api.github.com/repos/SyntevoAlex/git/forks","keys_url":"https://api.github.com/repos/SyntevoAlex/git/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SyntevoAlex/git/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SyntevoAlex/git/teams","hooks_url":"https://api.github.com/repos/SyntevoAlex/git/hooks","issue_events_url":"https://api.github.com/repos/SyntevoAlex/git/issues/events{/number}","events_url":"https://api.github.com/repos/SyntevoAlex/git/events","assignees_url":"https://api.github.com/repos/SyntevoAlex/git/assignees{/user}","branches_url":"https://api.github.com/repos/SyntevoAlex/git/branches{/branch}","tags_url":"https://api.github.com/repos/SyntevoAlex/git/tags","blobs_url":"https://api.github.com/repos/SyntevoAlex/git/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SyntevoAlex/git/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SyntevoAlex/git/git/refs{/sha}","trees_url":"https://api.github.com/repos/SyntevoAlex/git/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SyntevoAlex/git/statuses/{sha}","languages_url":"https://api.github.com/repos/SyntevoAlex/git/languages","stargazers_url":"https://api.github.com/repos/SyntevoAlex/git/stargazers","contributors_url":"https://api.github.com/repos/SyntevoAlex/git/contributors","subscribers_url":"https://api.github.com/repos/SyntevoAlex/git/subscribers","subscription_url":"https://api.github.com/repos/SyntevoAlex/git/subscription","commits_url":"https://api.github.com/repos/SyntevoAlex/git/commits{/sha}","git_commits_url":"https://api.github.com/repos/SyntevoAlex/git/git/commits{/sha}","comments_url":"https://api.github.com/repos/SyntevoAlex/git/comments{/number}","issue_comment_url":"https://api.github.com/repos/SyntevoAlex/git/issues/comments{/number}","contents_url":"https://api.github.com/repos/SyntevoAlex/git/contents/{+path}","compare_url":"https://api.github.com/repos/SyntevoAlex/git/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SyntevoAlex/git/merges","archive_url":"https://api.github.com/repos/SyntevoAlex/git/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SyntevoAlex/git/downloads","issues_url":"https://api.github.com/repos/SyntevoAlex/git/issues{/number}","pulls_url":"https://api.github.com/repos/SyntevoAlex/git/pulls{/number}","milestones_url":"https://api.github.com/repos/SyntevoAlex/git/milestones{/number}","notifications_url":"https://api.github.com/repos/SyntevoAlex/git/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SyntevoAlex/git/labels{/name}","releases_url":"https://api.github.com/repos/SyntevoAlex/git/releases{/id}","deployments_url":"https://api.github.com/repos/SyntevoAlex/git/deployments","created_at":"2019-09-16T16:35:11Z","updated_at":"2019-09-19T13:00:04Z","pushed_at":"2019-10-23T07:10:16Z","git_url":"git://github.com/SyntevoAlex/git.git","ssh_url":"[email protected]:SyntevoAlex/git.git","clone_url":"https://github.com/SyntevoAlex/git.git","svn_url":"https://github.com/SyntevoAlex/git","homepage":"","size":162596,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gitgitgadget:master","ref":"master","sha":"d966095db01190a2196e31195ea6fa0c722aa732","user":{"login":"gitgitgadget","id":39071191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDcxMTkx","avatar_url":"https://avatars2.githubusercontent.com/u/39071191?v=4","gravatar_id":"","url":"https://api.github.com/users/gitgitgadget","html_url":"https://github.com/gitgitgadget","followers_url":"https://api.github.com/users/gitgitgadget/followers","following_url":"https://api.github.com/users/gitgitgadget/following{/other_user}","gists_url":"https://api.github.com/users/gitgitgadget/gists{/gist_id}","starred_url":"https://api.github.com/users/gitgitgadget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitgitgadget/subscriptions","organizations_url":"https://api.github.com/users/gitgitgadget/orgs","repos_url":"https://api.github.com/users/gitgitgadget/repos","events_url":"https://api.github.com/users/gitgitgadget/events{/privacy}","received_events_url":"https://api.github.com/users/gitgitgadget/received_events","type":"Organization","site_admin":false},"repo":{"id":135437869,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU0Mzc4Njk=","name":"git","full_name":"gitgitgadget/git","private":false,"owner":{"login":"gitgitgadget","id":39071191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MDcxMTkx","avatar_url":"https://avatars2.githubusercontent.com/u/39071191?v=4","gravatar_id":"","url":"https://api.github.com/users/gitgitgadget","html_url":"https://github.com/gitgitgadget","followers_url":"https://api.github.com/users/gitgitgadget/followers","following_url":"https://api.github.com/users/gitgitgadget/following{/other_user}","gists_url":"https://api.github.com/users/gitgitgadget/gists{/gist_id}","starred_url":"https://api.github.com/users/gitgitgadget/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitgitgadget/subscriptions","organizations_url":"https://api.github.com/users/gitgitgadget/orgs","repos_url":"https://api.github.com/users/gitgitgadget/repos","events_url":"https://api.github.com/users/gitgitgadget/events{/privacy}","received_events_url":"https://api.github.com/users/gitgitgadget/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gitgitgadget/git","description":"GitGitGadget's Git fork. Open Pull Requests here to submit them to the Git mailing list","fork":true,"url":"https://api.github.com/repos/gitgitgadget/git","forks_url":"https://api.github.com/repos/gitgitgadget/git/forks","keys_url":"https://api.github.com/repos/gitgitgadget/git/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gitgitgadget/git/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gitgitgadget/git/teams","hooks_url":"https://api.github.com/repos/gitgitgadget/git/hooks","issue_events_url":"https://api.github.com/repos/gitgitgadget/git/issues/events{/number}","events_url":"https://api.github.com/repos/gitgitgadget/git/events","assignees_url":"https://api.github.com/repos/gitgitgadget/git/assignees{/user}","branches_url":"https://api.github.com/repos/gitgitgadget/git/branches{/branch}","tags_url":"https://api.github.com/repos/gitgitgadget/git/tags","blobs_url":"https://api.github.com/repos/gitgitgadget/git/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gitgitgadget/git/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gitgitgadget/git/git/refs{/sha}","trees_url":"https://api.github.com/repos/gitgitgadget/git/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gitgitgadget/git/statuses/{sha}","languages_url":"https://api.github.com/repos/gitgitgadget/git/languages","stargazers_url":"https://api.github.com/repos/gitgitgadget/git/stargazers","contributors_url":"https://api.github.com/repos/gitgitgadget/git/contributors","subscribers_url":"https://api.github.com/repos/gitgitgadget/git/subscribers","subscription_url":"https://api.github.com/repos/gitgitgadget/git/subscription","commits_url":"https://api.github.com/repos/gitgitgadget/git/commits{/sha}","git_commits_url":"https://api.github.com/repos/gitgitgadget/git/git/commits{/sha}","comments_url":"https://api.github.com/repos/gitgitgadget/git/comments{/number}","issue_comment_url":"https://api.github.com/repos/gitgitgadget/git/issues/comments{/number}","contents_url":"https://api.github.com/repos/gitgitgadget/git/contents/{+path}","compare_url":"https://api.github.com/repos/gitgitgadget/git/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gitgitgadget/git/merges","archive_url":"https://api.github.com/repos/gitgitgadget/git/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gitgitgadget/git/downloads","issues_url":"https://api.github.com/repos/gitgitgadget/git/issues{/number}","pulls_url":"https://api.github.com/repos/gitgitgadget/git/pulls{/number}","milestones_url":"https://api.github.com/repos/gitgitgadget/git/milestones{/number}","notifications_url":"https://api.github.com/repos/gitgitgadget/git/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gitgitgadget/git/labels{/name}","releases_url":"https://api.github.com/repos/gitgitgadget/git/releases{/id}","deployments_url":"https://api.github.com/repos/gitgitgadget/git/deployments","created_at":"2018-05-30T12:14:54Z","updated_at":"2019-10-24T22:26:18Z","pushed_at":"2019-10-25T09:01:46Z","git_url":"git://github.com/gitgitgadget/git.git","ssh_url":"[email protected]:gitgitgadget/git.git","clone_url":"https://github.com/gitgitgadget/git.git","svn_url":"https://github.com/gitgitgadget/git","homepage":"https://gitgitgadget.github.io/","size":151433,"stargazers_count":12,"watchers_count":12,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":131,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":131,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gitgitgadget/git/pulls/414"},"html":{"href":"https://github.com/gitgitgadget/git/pull/414"},"issue":{"href":"https://api.github.com/repos/gitgitgadget/git/issues/414"},"comments":{"href":"https://api.github.com/repos/gitgitgadget/git/issues/414/comments"},"review_comments":{"href":"https://api.github.com/repos/gitgitgadget/git/pulls/414/comments"},"review_comment":{"href":"https://api.github.com/repos/gitgitgadget/git/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gitgitgadget/git/pulls/414/commits"},"statuses":{"href":"https://api.github.com/repos/gitgitgadget/git/statuses/41ed248f68f26be968822d9539ff16b85a316202"}},"author_association":"NONE"}}	{ "id": 135437869, "name": "gitgitgadget/git", "url": "https://api.github.com/repos/gitgitgadget/git" }	{ "id": 127790, "login": "dscho", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/127790?", "url": "https://api.github.com/users/dscho" }	{ "id": 39071191, "login": "gitgitgadget", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/39071191?", "url": "https://api.github.com/orgs/gitgitgadget" }	2019-10-25T11:11:40	10713427591	{"actor":{"display_login":"dscho"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/codespell-project/codespell/pulls/comments/287596495","pull_request_review_id":242038258,"id":287596495,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NzU5NjQ5NQ==","diff_hunk":"@@ -726,13 +727,15 @@ allowe->allowed, allow,\n allpication->application\n allready->already\n allredy->already\n+allright->all right, alright,\n alls->all, falls,\n allso->also\n allthough->although\n alltime->all-time\n alltogehter->altogether, all together,\n alltogether->altogether, all together,\n allways->always\n+allwos->allows","path":"codespell_lib/data/dictionary.txt","position":20,"original_position":20,"commit_id":"4b0303ff5f5f5ad9b7127052d8752cd37550752c","original_commit_id":"4b0303ff5f5f5ad9b7127052d8752cd37550752c","user":{"login":"peternewman","id":6216436,"node_id":"MDQ6VXNlcjYyMTY0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/6216436?v=4","gravatar_id":"","url":"https://api.github.com/users/peternewman","html_url":"https://github.com/peternewman","followers_url":"https://api.github.com/users/peternewman/followers","following_url":"https://api.github.com/users/peternewman/following{/other_user}","gists_url":"https://api.github.com/users/peternewman/gists{/gist_id}","starred_url":"https://api.github.com/users/peternewman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peternewman/subscriptions","organizations_url":"https://api.github.com/users/peternewman/orgs","repos_url":"https://api.github.com/users/peternewman/repos","events_url":"https://api.github.com/users/peternewman/events{/privacy}","received_events_url":"https://api.github.com/users/peternewman/received_events","type":"User","site_admin":false},"body":"Add the singular please.","created_at":"2019-05-26T12:46:39Z","updated_at":"2019-05-26T12:56:55Z","html_url":"https://github.com/codespell-project/codespell/pull/765#discussion_r287596495","pull_request_url":"https://api.github.com/repos/codespell-project/codespell/pulls/765","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/codespell-project/codespell/pulls/comments/287596495"},"html":{"href":"https://github.com/codespell-project/codespell/pull/765#discussion_r287596495"},"pull_request":{"href":"https://api.github.com/repos/codespell-project/codespell/pulls/765"}}},"pull_request":{"url":"https://api.github.com/repos/codespell-project/codespell/pulls/765","id":233156326,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMTU2MzI2","html_url":"https://github.com/codespell-project/codespell/pull/765","diff_url":"https://github.com/codespell-project/codespell/pull/765.diff","patch_url":"https://github.com/codespell-project/codespell/pull/765.patch","issue_url":"https://api.github.com/repos/codespell-project/codespell/issues/765","number":765,"state":"open","locked":false,"title":"Typos from LibreOffice Nov. 2018","user":{"login":"Gelma","id":356659,"node_id":"MDQ6VXNlcjM1NjY1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/356659?v=4","gravatar_id":"","url":"https://api.github.com/users/Gelma","html_url":"https://github.com/Gelma","followers_url":"https://api.github.com/users/Gelma/followers","following_url":"https://api.github.com/users/Gelma/following{/other_user}","gists_url":"https://api.github.com/users/Gelma/gists{/gist_id}","starred_url":"https://api.github.com/users/Gelma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gelma/subscriptions","organizations_url":"https://api.github.com/users/Gelma/orgs","repos_url":"https://api.github.com/users/Gelma/repos","events_url":"https://api.github.com/users/Gelma/events{/privacy}","received_events_url":"https://api.github.com/users/Gelma/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-23T10:20:50Z","updated_at":"2019-05-26T12:56:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"785bd9083aa35486c4d1cd4d88e381fcaa4503e3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1377192297,"node_id":"MDU6TGFiZWwxMzc3MTkyMjk3","url":"https://api.github.com/repos/codespell-project/codespell/labels/dictionary","name":"dictionary","color":"bdf760","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/codespell-project/codespell/pulls/765/commits","review_comments_url":"https://api.github.com/repos/codespell-project/codespell/pulls/765/comments","review_comment_url":"https://api.github.com/repos/codespell-project/codespell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codespell-project/codespell/issues/765/comments","statuses_url":"https://api.github.com/repos/codespell-project/codespell/statuses/4b0303ff5f5f5ad9b7127052d8752cd37550752c","head":{"label":"Gelma:23nov18","ref":"23nov18","sha":"4b0303ff5f5f5ad9b7127052d8752cd37550752c","user":{"login":"Gelma","id":356659,"node_id":"MDQ6VXNlcjM1NjY1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/356659?v=4","gravatar_id":"","url":"https://api.github.com/users/Gelma","html_url":"https://github.com/Gelma","followers_url":"https://api.github.com/users/Gelma/followers","following_url":"https://api.github.com/users/Gelma/following{/other_user}","gists_url":"https://api.github.com/users/Gelma/gists{/gist_id}","starred_url":"https://api.github.com/users/Gelma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gelma/subscriptions","organizations_url":"https://api.github.com/users/Gelma/orgs","repos_url":"https://api.github.com/users/Gelma/repos","events_url":"https://api.github.com/users/Gelma/events{/privacy}","received_events_url":"https://api.github.com/users/Gelma/received_events","type":"User","site_admin":false},"repo":{"id":133706761,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM3MDY3NjE=","name":"codespell","full_name":"Gelma/codespell","private":false,"owner":{"login":"Gelma","id":356659,"node_id":"MDQ6VXNlcjM1NjY1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/356659?v=4","gravatar_id":"","url":"https://api.github.com/users/Gelma","html_url":"https://github.com/Gelma","followers_url":"https://api.github.com/users/Gelma/followers","following_url":"https://api.github.com/users/Gelma/following{/other_user}","gists_url":"https://api.github.com/users/Gelma/gists{/gist_id}","starred_url":"https://api.github.com/users/Gelma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gelma/subscriptions","organizations_url":"https://api.github.com/users/Gelma/orgs","repos_url":"https://api.github.com/users/Gelma/repos","events_url":"https://api.github.com/users/Gelma/events{/privacy}","received_events_url":"https://api.github.com/users/Gelma/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Gelma/codespell","description":"check code for common misspellings","fork":true,"url":"https://api.github.com/repos/Gelma/codespell","forks_url":"https://api.github.com/repos/Gelma/codespell/forks","keys_url":"https://api.github.com/repos/Gelma/codespell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Gelma/codespell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Gelma/codespell/teams","hooks_url":"https://api.github.com/repos/Gelma/codespell/hooks","issue_events_url":"https://api.github.com/repos/Gelma/codespell/issues/events{/number}","events_url":"https://api.github.com/repos/Gelma/codespell/events","assignees_url":"https://api.github.com/repos/Gelma/codespell/assignees{/user}","branches_url":"https://api.github.com/repos/Gelma/codespell/branches{/branch}","tags_url":"https://api.github.com/repos/Gelma/codespell/tags","blobs_url":"https://api.github.com/repos/Gelma/codespell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Gelma/codespell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Gelma/codespell/git/refs{/sha}","trees_url":"https://api.github.com/repos/Gelma/codespell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Gelma/codespell/statuses/{sha}","languages_url":"https://api.github.com/repos/Gelma/codespell/languages","stargazers_url":"https://api.github.com/repos/Gelma/codespell/stargazers","contributors_url":"https://api.github.com/repos/Gelma/codespell/contributors","subscribers_url":"https://api.github.com/repos/Gelma/codespell/subscribers","subscription_url":"https://api.github.com/repos/Gelma/codespell/subscription","commits_url":"https://api.github.com/repos/Gelma/codespell/commits{/sha}","git_commits_url":"https://api.github.com/repos/Gelma/codespell/git/commits{/sha}","comments_url":"https://api.github.com/repos/Gelma/codespell/comments{/number}","issue_comment_url":"https://api.github.com/repos/Gelma/codespell/issues/comments{/number}","contents_url":"https://api.github.com/repos/Gelma/codespell/contents/{+path}","compare_url":"https://api.github.com/repos/Gelma/codespell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Gelma/codespell/merges","archive_url":"https://api.github.com/repos/Gelma/codespell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Gelma/codespell/downloads","issues_url":"https://api.github.com/repos/Gelma/codespell/issues{/number}","pulls_url":"https://api.github.com/repos/Gelma/codespell/pulls{/number}","milestones_url":"https://api.github.com/repos/Gelma/codespell/milestones{/number}","notifications_url":"https://api.github.com/repos/Gelma/codespell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Gelma/codespell/labels{/name}","releases_url":"https://api.github.com/repos/Gelma/codespell/releases{/id}","deployments_url":"https://api.github.com/repos/Gelma/codespell/deployments","created_at":"2018-05-16T18:17:58Z","updated_at":"2018-05-16T18:18:00Z","pushed_at":"2019-05-26T09:44:52Z","git_url":"git://github.com/Gelma/codespell.git","ssh_url":"[email protected]:Gelma/codespell.git","clone_url":"https://github.com/Gelma/codespell.git","svn_url":"https://github.com/Gelma/codespell","homepage":"","size":5449,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codespell-project:master","ref":"master","sha":"8c890de9654f8469b10688c4ca71d7bef5d5428e","user":{"login":"codespell-project","id":39140587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQwNTg3","avatar_url":"https://avatars1.githubusercontent.com/u/39140587?v=4","gravatar_id":"","url":"https://api.github.com/users/codespell-project","html_url":"https://github.com/codespell-project","followers_url":"https://api.github.com/users/codespell-project/followers","following_url":"https://api.github.com/users/codespell-project/following{/other_user}","gists_url":"https://api.github.com/users/codespell-project/gists{/gist_id}","starred_url":"https://api.github.com/users/codespell-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codespell-project/subscriptions","organizations_url":"https://api.github.com/users/codespell-project/orgs","repos_url":"https://api.github.com/users/codespell-project/repos","events_url":"https://api.github.com/users/codespell-project/events{/privacy}","received_events_url":"https://api.github.com/users/codespell-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1303538,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAzNTM4","name":"codespell","full_name":"codespell-project/codespell","private":false,"owner":{"login":"codespell-project","id":39140587,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQwNTg3","avatar_url":"https://avatars1.githubusercontent.com/u/39140587?v=4","gravatar_id":"","url":"https://api.github.com/users/codespell-project","html_url":"https://github.com/codespell-project","followers_url":"https://api.github.com/users/codespell-project/followers","following_url":"https://api.github.com/users/codespell-project/following{/other_user}","gists_url":"https://api.github.com/users/codespell-project/gists{/gist_id}","starred_url":"https://api.github.com/users/codespell-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codespell-project/subscriptions","organizations_url":"https://api.github.com/users/codespell-project/orgs","repos_url":"https://api.github.com/users/codespell-project/repos","events_url":"https://api.github.com/users/codespell-project/events{/privacy}","received_events_url":"https://api.github.com/users/codespell-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codespell-project/codespell","description":"check code for common misspellings","fork":false,"url":"https://api.github.com/repos/codespell-project/codespell","forks_url":"https://api.github.com/repos/codespell-project/codespell/forks","keys_url":"https://api.github.com/repos/codespell-project/codespell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codespell-project/codespell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codespell-project/codespell/teams","hooks_url":"https://api.github.com/repos/codespell-project/codespell/hooks","issue_events_url":"https://api.github.com/repos/codespell-project/codespell/issues/events{/number}","events_url":"https://api.github.com/repos/codespell-project/codespell/events","assignees_url":"https://api.github.com/repos/codespell-project/codespell/assignees{/user}","branches_url":"https://api.github.com/repos/codespell-project/codespell/branches{/branch}","tags_url":"https://api.github.com/repos/codespell-project/codespell/tags","blobs_url":"https://api.github.com/repos/codespell-project/codespell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codespell-project/codespell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codespell-project/codespell/git/refs{/sha}","trees_url":"https://api.github.com/repos/codespell-project/codespell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codespell-project/codespell/statuses/{sha}","languages_url":"https://api.github.com/repos/codespell-project/codespell/languages","stargazers_url":"https://api.github.com/repos/codespell-project/codespell/stargazers","contributors_url":"https://api.github.com/repos/codespell-project/codespell/contributors","subscribers_url":"https://api.github.com/repos/codespell-project/codespell/subscribers","subscription_url":"https://api.github.com/repos/codespell-project/codespell/subscription","commits_url":"https://api.github.com/repos/codespell-project/codespell/commits{/sha}","git_commits_url":"https://api.github.com/repos/codespell-project/codespell/git/commits{/sha}","comments_url":"https://api.github.com/repos/codespell-project/codespell/comments{/number}","issue_comment_url":"https://api.github.com/repos/codespell-project/codespell/issues/comments{/number}","contents_url":"https://api.github.com/repos/codespell-project/codespell/contents/{+path}","compare_url":"https://api.github.com/repos/codespell-project/codespell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codespell-project/codespell/merges","archive_url":"https://api.github.com/repos/codespell-project/codespell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codespell-project/codespell/downloads","issues_url":"https://api.github.com/repos/codespell-project/codespell/issues{/number}","pulls_url":"https://api.github.com/repos/codespell-project/codespell/pulls{/number}","milestones_url":"https://api.github.com/repos/codespell-project/codespell/milestones{/number}","notifications_url":"https://api.github.com/repos/codespell-project/codespell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codespell-project/codespell/labels{/name}","releases_url":"https://api.github.com/repos/codespell-project/codespell/releases{/id}","deployments_url":"https://api.github.com/repos/codespell-project/codespell/deployments","created_at":"2011-01-28T17:23:32Z","updated_at":"2019-05-25T01:21:25Z","pushed_at":"2019-05-26T09:44:54Z","git_url":"git://github.com/codespell-project/codespell.git","ssh_url":"[email protected]:codespell-project/codespell.git","clone_url":"https://github.com/codespell-project/codespell.git","svn_url":"https://github.com/codespell-project/codespell","homepage":"","size":4174,"stargazers_count":204,"watchers_count":204,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":188,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":67,"open_issues":188,"watchers":204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codespell-project/codespell/pulls/765"},"html":{"href":"https://github.com/codespell-project/codespell/pull/765"},"issue":{"href":"https://api.github.com/repos/codespell-project/codespell/issues/765"},"comments":{"href":"https://api.github.com/repos/codespell-project/codespell/issues/765/comments"},"review_comments":{"href":"https://api.github.com/repos/codespell-project/codespell/pulls/765/comments"},"review_comment":{"href":"https://api.github.com/repos/codespell-project/codespell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codespell-project/codespell/pulls/765/commits"},"statuses":{"href":"https://api.github.com/repos/codespell-project/codespell/statuses/4b0303ff5f5f5ad9b7127052d8752cd37550752c"}},"author_association":"CONTRIBUTOR"}}	{ "id": 1303538, "name": "codespell-project/codespell", "url": "https://api.github.com/repos/codespell-project/codespell" }	{ "id": 6216436, "login": "peternewman", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/6216436?", "url": "https://api.github.com/users/peternewman" }	{ "id": 39140587, "login": "codespell-project", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/39140587?", "url": "https://api.github.com/orgs/codespell-project" }	2019-05-26T12:46:39	9699290536	{"actor":{"display_login":"peternewman"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/harmony-one/harmony/pulls/comments/304557257","pull_request_review_id":263209995,"id":304557257,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNDU1NzI1Nw==","diff_hunk":"@@ -288,6 +286,43 @@ var BigMaxUint64 = new(big.Int).SetBytes([]byte{\n \t255, 255, 255, 255, 255, 255, 255, 255,\n })\n \n+// validateNewShardState_v2 validate whether the new shard state root matches\n+func (node Node) validateNewShardState_v2(block types.Block, stakeInfo map[common.Address]structs.StakeInfo) error {\n+\t// Common case first – blocks without resharding proposal\n+\theader := block.Header()\n+\tif header.ShardStateHash == (common.Hash{}) {\n+\t\t// No new shard state was proposed\n+\t\tif core.IsEpochLastBlock(block) {\n+\t\t\t// TODO invoke view change\n+\t\t\treturn errors.New(\"beacon leader did not propose resharding\")\n+\t\t}\n+\t\t// We aren't expecting to reshard, so proceed to sign\n+\t\treturn nil\n+\t}\n+\tshardState := &types.ShardState{}\n+\terr := rlp.DecodeBytes(header.ShardState, shardState)\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\tproposed := *shardState\n+\tnextEpoch := new(big.Int).Add(block.Header().Epoch, common.Big1)\n+\texpected, err := core.CalculateNewShardState(","path":"node/node_handler.go","position":37,"original_position":37,"commit_id":"24b69cb377ee8d7849c86a54ec1763f216c17a46","original_commit_id":"24b69cb377ee8d7849c86a54ec1763f216c17a46","user":{"login":"chaosma","id":3767044,"node_id":"MDQ6VXNlcjM3NjcwNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3767044?v=4","gravatar_id":"","url":"https://api.github.com/users/chaosma","html_url":"https://github.com/chaosma","followers_url":"https://api.github.com/users/chaosma/followers","following_url":"https://api.github.com/users/chaosma/following{/other_user}","gists_url":"https://api.github.com/users/chaosma/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosma/subscriptions","organizations_url":"https://api.github.com/users/chaosma/orgs","repos_url":"https://api.github.com/users/chaosma/repos","events_url":"https://api.github.com/users/chaosma/events{/privacy}","received_events_url":"https://api.github.com/users/chaosma/received_events","type":"User","site_admin":false},"body":"It is still manually set, but abstract into an API, so we don't need to change this code later","created_at":"2019-07-17T17:36:51Z","updated_at":"2019-07-17T17:36:52Z","html_url":"https://github.com/harmony-one/harmony/pull/1219#discussion_r304557257","pull_request_url":"https://api.github.com/repos/harmony-one/harmony/pulls/1219","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/harmony-one/harmony/pulls/comments/304557257"},"html":{"href":"https://github.com/harmony-one/harmony/pull/1219#discussion_r304557257"},"pull_request":{"href":"https://api.github.com/repos/harmony-one/harmony/pulls/1219"}},"in_reply_to_id":304153091},"pull_request":{"url":"https://api.github.com/repos/harmony-one/harmony/pulls/1219","id":297435795,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3NDM1Nzk1","html_url":"https://github.com/harmony-one/harmony/pull/1219","diff_url":"https://github.com/harmony-one/harmony/pull/1219.diff","patch_url":"https://github.com/harmony-one/harmony/pull/1219.patch","issue_url":"https://api.github.com/repos/harmony-one/harmony/issues/1219","number":1219,"state":"open","locked":false,"title":"resharding: new node join/leave","user":{"login":"chaosma","id":3767044,"node_id":"MDQ6VXNlcjM3NjcwNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3767044?v=4","gravatar_id":"","url":"https://api.github.com/users/chaosma","html_url":"https://github.com/chaosma","followers_url":"https://api.github.com/users/chaosma/followers","following_url":"https://api.github.com/users/chaosma/following{/other_user}","gists_url":"https://api.github.com/users/chaosma/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosma/subscriptions","organizations_url":"https://api.github.com/users/chaosma/orgs","repos_url":"https://api.github.com/users/chaosma/repos","events_url":"https://api.github.com/users/chaosma/events{/privacy}","received_events_url":"https://api.github.com/users/chaosma/received_events","type":"User","site_admin":false},"body":"new node can join and leave; but leader should stay in the same shard","created_at":"2019-07-14T23:18:41Z","updated_at":"2019-07-17T17:36:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bba118eadff05099160c7c66f0c3690981ca5482","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/harmony-one/harmony/pulls/1219/commits","review_comments_url":"https://api.github.com/repos/harmony-one/harmony/pulls/1219/comments","review_comment_url":"https://api.github.com/repos/harmony-one/harmony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/harmony-one/harmony/issues/1219/comments","statuses_url":"https://api.github.com/repos/harmony-one/harmony/statuses/24b69cb377ee8d7849c86a54ec1763f216c17a46","head":{"label":"chaosma:chao-wip","ref":"chao-wip","sha":"24b69cb377ee8d7849c86a54ec1763f216c17a46","user":{"login":"chaosma","id":3767044,"node_id":"MDQ6VXNlcjM3NjcwNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3767044?v=4","gravatar_id":"","url":"https://api.github.com/users/chaosma","html_url":"https://github.com/chaosma","followers_url":"https://api.github.com/users/chaosma/followers","following_url":"https://api.github.com/users/chaosma/following{/other_user}","gists_url":"https://api.github.com/users/chaosma/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosma/subscriptions","organizations_url":"https://api.github.com/users/chaosma/orgs","repos_url":"https://api.github.com/users/chaosma/repos","events_url":"https://api.github.com/users/chaosma/events{/privacy}","received_events_url":"https://api.github.com/users/chaosma/received_events","type":"User","site_admin":false},"repo":{"id":180232683,"node_id":"MDEwOlJlcG9zaXRvcnkxODAyMzI2ODM=","name":"harmony","full_name":"chaosma/harmony","private":false,"owner":{"login":"chaosma","id":3767044,"node_id":"MDQ6VXNlcjM3NjcwNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3767044?v=4","gravatar_id":"","url":"https://api.github.com/users/chaosma","html_url":"https://github.com/chaosma","followers_url":"https://api.github.com/users/chaosma/followers","following_url":"https://api.github.com/users/chaosma/following{/other_user}","gists_url":"https://api.github.com/users/chaosma/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosma/subscriptions","organizations_url":"https://api.github.com/users/chaosma/orgs","repos_url":"https://api.github.com/users/chaosma/repos","events_url":"https://api.github.com/users/chaosma/events{/privacy}","received_events_url":"https://api.github.com/users/chaosma/received_events","type":"User","site_admin":false},"html_url":"https://github.com/chaosma/harmony","description":"The core protocol of harmony","fork":true,"url":"https://api.github.com/repos/chaosma/harmony","forks_url":"https://api.github.com/repos/chaosma/harmony/forks","keys_url":"https://api.github.com/repos/chaosma/harmony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaosma/harmony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaosma/harmony/teams","hooks_url":"https://api.github.com/repos/chaosma/harmony/hooks","issue_events_url":"https://api.github.com/repos/chaosma/harmony/issues/events{/number}","events_url":"https://api.github.com/repos/chaosma/harmony/events","assignees_url":"https://api.github.com/repos/chaosma/harmony/assignees{/user}","branches_url":"https://api.github.com/repos/chaosma/harmony/branches{/branch}","tags_url":"https://api.github.com/repos/chaosma/harmony/tags","blobs_url":"https://api.github.com/repos/chaosma/harmony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaosma/harmony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaosma/harmony/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaosma/harmony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaosma/harmony/statuses/{sha}","languages_url":"https://api.github.com/repos/chaosma/harmony/languages","stargazers_url":"https://api.github.com/repos/chaosma/harmony/stargazers","contributors_url":"https://api.github.com/repos/chaosma/harmony/contributors","subscribers_url":"https://api.github.com/repos/chaosma/harmony/subscribers","subscription_url":"https://api.github.com/repos/chaosma/harmony/subscription","commits_url":"https://api.github.com/repos/chaosma/harmony/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaosma/harmony/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaosma/harmony/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaosma/harmony/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaosma/harmony/contents/{+path}","compare_url":"https://api.github.com/repos/chaosma/harmony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaosma/harmony/merges","archive_url":"https://api.github.com/repos/chaosma/harmony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaosma/harmony/downloads","issues_url":"https://api.github.com/repos/chaosma/harmony/issues{/number}","pulls_url":"https://api.github.com/repos/chaosma/harmony/pulls{/number}","milestones_url":"https://api.github.com/repos/chaosma/harmony/milestones{/number}","notifications_url":"https://api.github.com/repos/chaosma/harmony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaosma/harmony/labels{/name}","releases_url":"https://api.github.com/repos/chaosma/harmony/releases{/id}","deployments_url":"https://api.github.com/repos/chaosma/harmony/deployments","created_at":"2019-04-08T21:04:48Z","updated_at":"2019-06-28T05:59:39Z","pushed_at":"2019-07-14T22:58:27Z","git_url":"git://github.com/chaosma/harmony.git","ssh_url":"[email protected]:chaosma/harmony.git","clone_url":"https://github.com/chaosma/harmony.git","svn_url":"https://github.com/chaosma/harmony","homepage":"https://harmony.one","size":12539,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"harmony-one:master","ref":"master","sha":"a15a43df364366b95827b694c64a7f35c1716ca4","user":{"login":"harmony-one","id":39147399,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ3Mzk5","avatar_url":"https://avatars2.githubusercontent.com/u/39147399?v=4","gravatar_id":"","url":"https://api.github.com/users/harmony-one","html_url":"https://github.com/harmony-one","followers_url":"https://api.github.com/users/harmony-one/followers","following_url":"https://api.github.com/users/harmony-one/following{/other_user}","gists_url":"https://api.github.com/users/harmony-one/gists{/gist_id}","starred_url":"https://api.github.com/users/harmony-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harmony-one/subscriptions","organizations_url":"https://api.github.com/users/harmony-one/orgs","repos_url":"https://api.github.com/users/harmony-one/repos","events_url":"https://api.github.com/users/harmony-one/events{/privacy}","received_events_url":"https://api.github.com/users/harmony-one/received_events","type":"Organization","site_admin":false},"repo":{"id":134344706,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQzNDQ3MDY=","name":"harmony","full_name":"harmony-one/harmony","private":false,"owner":{"login":"harmony-one","id":39147399,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ3Mzk5","avatar_url":"https://avatars2.githubusercontent.com/u/39147399?v=4","gravatar_id":"","url":"https://api.github.com/users/harmony-one","html_url":"https://github.com/harmony-one","followers_url":"https://api.github.com/users/harmony-one/followers","following_url":"https://api.github.com/users/harmony-one/following{/other_user}","gists_url":"https://api.github.com/users/harmony-one/gists{/gist_id}","starred_url":"https://api.github.com/users/harmony-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harmony-one/subscriptions","organizations_url":"https://api.github.com/users/harmony-one/orgs","repos_url":"https://api.github.com/users/harmony-one/repos","events_url":"https://api.github.com/users/harmony-one/events{/privacy}","received_events_url":"https://api.github.com/users/harmony-one/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/harmony-one/harmony","description":"The core protocol of harmony","fork":false,"url":"https://api.github.com/repos/harmony-one/harmony","forks_url":"https://api.github.com/repos/harmony-one/harmony/forks","keys_url":"https://api.github.com/repos/harmony-one/harmony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harmony-one/harmony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harmony-one/harmony/teams","hooks_url":"https://api.github.com/repos/harmony-one/harmony/hooks","issue_events_url":"https://api.github.com/repos/harmony-one/harmony/issues/events{/number}","events_url":"https://api.github.com/repos/harmony-one/harmony/events","assignees_url":"https://api.github.com/repos/harmony-one/harmony/assignees{/user}","branches_url":"https://api.github.com/repos/harmony-one/harmony/branches{/branch}","tags_url":"https://api.github.com/repos/harmony-one/harmony/tags","blobs_url":"https://api.github.com/repos/harmony-one/harmony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harmony-one/harmony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harmony-one/harmony/git/refs{/sha}","trees_url":"https://api.github.com/repos/harmony-one/harmony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harmony-one/harmony/statuses/{sha}","languages_url":"https://api.github.com/repos/harmony-one/harmony/languages","stargazers_url":"https://api.github.com/repos/harmony-one/harmony/stargazers","contributors_url":"https://api.github.com/repos/harmony-one/harmony/contributors","subscribers_url":"https://api.github.com/repos/harmony-one/harmony/subscribers","subscription_url":"https://api.github.com/repos/harmony-one/harmony/subscription","commits_url":"https://api.github.com/repos/harmony-one/harmony/commits{/sha}","git_commits_url":"https://api.github.com/repos/harmony-one/harmony/git/commits{/sha}","comments_url":"https://api.github.com/repos/harmony-one/harmony/comments{/number}","issue_comment_url":"https://api.github.com/repos/harmony-one/harmony/issues/comments{/number}","contents_url":"https://api.github.com/repos/harmony-one/harmony/contents/{+path}","compare_url":"https://api.github.com/repos/harmony-one/harmony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harmony-one/harmony/merges","archive_url":"https://api.github.com/repos/harmony-one/harmony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harmony-one/harmony/downloads","issues_url":"https://api.github.com/repos/harmony-one/harmony/issues{/number}","pulls_url":"https://api.github.com/repos/harmony-one/harmony/pulls{/number}","milestones_url":"https://api.github.com/repos/harmony-one/harmony/milestones{/number}","notifications_url":"https://api.github.com/repos/harmony-one/harmony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harmony-one/harmony/labels{/name}","releases_url":"https://api.github.com/repos/harmony-one/harmony/releases{/id}","deployments_url":"https://api.github.com/repos/harmony-one/harmony/deployments","created_at":"2018-05-22T01:37:50Z","updated_at":"2019-07-15T23:05:14Z","pushed_at":"2019-07-17T07:07:32Z","git_url":"git://github.com/harmony-one/harmony.git","ssh_url":"[email protected]:harmony-one/harmony.git","clone_url":"https://github.com/harmony-one/harmony.git","svn_url":"https://github.com/harmony-one/harmony","homepage":"https://harmony.one","size":12554,"stargazers_count":170,"watchers_count":170,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":122,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":45,"open_issues":122,"watchers":170,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/harmony-one/harmony/pulls/1219"},"html":{"href":"https://github.com/harmony-one/harmony/pull/1219"},"issue":{"href":"https://api.github.com/repos/harmony-one/harmony/issues/1219"},"comments":{"href":"https://api.github.com/repos/harmony-one/harmony/issues/1219/comments"},"review_comments":{"href":"https://api.github.com/repos/harmony-one/harmony/pulls/1219/comments"},"review_comment":{"href":"https://api.github.com/repos/harmony-one/harmony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/harmony-one/harmony/pulls/1219/commits"},"statuses":{"href":"https://api.github.com/repos/harmony-one/harmony/statuses/24b69cb377ee8d7849c86a54ec1763f216c17a46"}},"author_association":"CONTRIBUTOR"}}	{ "id": 134344706, "name": "harmony-one/harmony", "url": "https://api.github.com/repos/harmony-one/harmony" }	{ "id": 3767044, "login": "chaosma", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/3767044?", "url": "https://api.github.com/users/chaosma" }	{ "id": 39147399, "login": "harmony-one", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/39147399?", "url": "https://api.github.com/orgs/harmony-one" }	2019-07-17T17:36:51	10031192345	{"actor":{"display_login":"chaosma"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/harmony-one/harmony/pulls/comments/305475637","pull_request_review_id":264367525,"id":305475637,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNTQ3NTYzNw==","diff_hunk":"@@ -1752,7 +1752,11 @@ func (bc *BlockChain) WriteShardStateBytes(\n \t\treturn err\n \t}\n \tcacheKey := string(epoch.Bytes())\n-\tbc.shardStateCache.Add(cacheKey, shardState)\n+\tdecodeShardState := types.ShardState{}\n+\tif err := rlp.DecodeBytes(shardState, &decodeShardState); err != nil {\n+\t\treturn err\n+\t}\n+\tbc.shardStateCache.Add(cacheKey, decodeShardState)","path":"core/blockchain.go","position":18,"original_position":9,"commit_id":"840793a15b27d9428a5875d51026cd10d8eef6ad","original_commit_id":"03f08c89af7019eb43dd967f3f9d3d8fc3ff6bb7","user":{"login":"chaosma","id":3767044,"node_id":"MDQ6VXNlcjM3NjcwNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3767044?v=4","gravatar_id":"","url":"https://api.github.com/users/chaosma","html_url":"https://github.com/chaosma","followers_url":"https://api.github.com/users/chaosma/followers","following_url":"https://api.github.com/users/chaosma/following{/other_user}","gists_url":"https://api.github.com/users/chaosma/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosma/subscriptions","organizations_url":"https://api.github.com/users/chaosma/orgs","repos_url":"https://api.github.com/users/chaosma/repos","events_url":"https://api.github.com/users/chaosma/events{/privacy}","received_events_url":"https://api.github.com/users/chaosma/received_events","type":"User","site_admin":false},"body":"good point. done","created_at":"2019-07-19T18:29:35Z","updated_at":"2019-07-19T18:29:35Z","html_url":"https://github.com/harmony-one/harmony/pull/1219#discussion_r305475637","pull_request_url":"https://api.github.com/repos/harmony-one/harmony/pulls/1219","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/harmony-one/harmony/pulls/comments/305475637"},"html":{"href":"https://github.com/harmony-one/harmony/pull/1219#discussion_r305475637"},"pull_request":{"href":"https://api.github.com/repos/harmony-one/harmony/pulls/1219"}},"in_reply_to_id":305035973},"pull_request":{"url":"https://api.github.com/repos/harmony-one/harmony/pulls/1219","id":297435795,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3NDM1Nzk1","html_url":"https://github.com/harmony-one/harmony/pull/1219","diff_url":"https://github.com/harmony-one/harmony/pull/1219.diff","patch_url":"https://github.com/harmony-one/harmony/pull/1219.patch","issue_url":"https://api.github.com/repos/harmony-one/harmony/issues/1219","number":1219,"state":"open","locked":false,"title":"resharding: new node join/leave","user":{"login":"chaosma","id":3767044,"node_id":"MDQ6VXNlcjM3NjcwNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3767044?v=4","gravatar_id":"","url":"https://api.github.com/users/chaosma","html_url":"https://github.com/chaosma","followers_url":"https://api.github.com/users/chaosma/followers","following_url":"https://api.github.com/users/chaosma/following{/other_user}","gists_url":"https://api.github.com/users/chaosma/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosma/subscriptions","organizations_url":"https://api.github.com/users/chaosma/orgs","repos_url":"https://api.github.com/users/chaosma/repos","events_url":"https://api.github.com/users/chaosma/events{/privacy}","received_events_url":"https://api.github.com/users/chaosma/received_events","type":"User","site_admin":false},"body":"new node can join and leave; but leader should stay in the same shard","created_at":"2019-07-14T23:18:41Z","updated_at":"2019-07-19T18:29:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e77e0a1499c73d09673556d01e6e5c559817c6e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/harmony-one/harmony/pulls/1219/commits","review_comments_url":"https://api.github.com/repos/harmony-one/harmony/pulls/1219/comments","review_comment_url":"https://api.github.com/repos/harmony-one/harmony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/harmony-one/harmony/issues/1219/comments","statuses_url":"https://api.github.com/repos/harmony-one/harmony/statuses/840793a15b27d9428a5875d51026cd10d8eef6ad","head":{"label":"chaosma:chao-wip","ref":"chao-wip","sha":"840793a15b27d9428a5875d51026cd10d8eef6ad","user":{"login":"chaosma","id":3767044,"node_id":"MDQ6VXNlcjM3NjcwNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3767044?v=4","gravatar_id":"","url":"https://api.github.com/users/chaosma","html_url":"https://github.com/chaosma","followers_url":"https://api.github.com/users/chaosma/followers","following_url":"https://api.github.com/users/chaosma/following{/other_user}","gists_url":"https://api.github.com/users/chaosma/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosma/subscriptions","organizations_url":"https://api.github.com/users/chaosma/orgs","repos_url":"https://api.github.com/users/chaosma/repos","events_url":"https://api.github.com/users/chaosma/events{/privacy}","received_events_url":"https://api.github.com/users/chaosma/received_events","type":"User","site_admin":false},"repo":{"id":180232683,"node_id":"MDEwOlJlcG9zaXRvcnkxODAyMzI2ODM=","name":"harmony","full_name":"chaosma/harmony","private":false,"owner":{"login":"chaosma","id":3767044,"node_id":"MDQ6VXNlcjM3NjcwNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3767044?v=4","gravatar_id":"","url":"https://api.github.com/users/chaosma","html_url":"https://github.com/chaosma","followers_url":"https://api.github.com/users/chaosma/followers","following_url":"https://api.github.com/users/chaosma/following{/other_user}","gists_url":"https://api.github.com/users/chaosma/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosma/subscriptions","organizations_url":"https://api.github.com/users/chaosma/orgs","repos_url":"https://api.github.com/users/chaosma/repos","events_url":"https://api.github.com/users/chaosma/events{/privacy}","received_events_url":"https://api.github.com/users/chaosma/received_events","type":"User","site_admin":false},"html_url":"https://github.com/chaosma/harmony","description":"The core protocol of harmony","fork":true,"url":"https://api.github.com/repos/chaosma/harmony","forks_url":"https://api.github.com/repos/chaosma/harmony/forks","keys_url":"https://api.github.com/repos/chaosma/harmony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chaosma/harmony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chaosma/harmony/teams","hooks_url":"https://api.github.com/repos/chaosma/harmony/hooks","issue_events_url":"https://api.github.com/repos/chaosma/harmony/issues/events{/number}","events_url":"https://api.github.com/repos/chaosma/harmony/events","assignees_url":"https://api.github.com/repos/chaosma/harmony/assignees{/user}","branches_url":"https://api.github.com/repos/chaosma/harmony/branches{/branch}","tags_url":"https://api.github.com/repos/chaosma/harmony/tags","blobs_url":"https://api.github.com/repos/chaosma/harmony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chaosma/harmony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chaosma/harmony/git/refs{/sha}","trees_url":"https://api.github.com/repos/chaosma/harmony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chaosma/harmony/statuses/{sha}","languages_url":"https://api.github.com/repos/chaosma/harmony/languages","stargazers_url":"https://api.github.com/repos/chaosma/harmony/stargazers","contributors_url":"https://api.github.com/repos/chaosma/harmony/contributors","subscribers_url":"https://api.github.com/repos/chaosma/harmony/subscribers","subscription_url":"https://api.github.com/repos/chaosma/harmony/subscription","commits_url":"https://api.github.com/repos/chaosma/harmony/commits{/sha}","git_commits_url":"https://api.github.com/repos/chaosma/harmony/git/commits{/sha}","comments_url":"https://api.github.com/repos/chaosma/harmony/comments{/number}","issue_comment_url":"https://api.github.com/repos/chaosma/harmony/issues/comments{/number}","contents_url":"https://api.github.com/repos/chaosma/harmony/contents/{+path}","compare_url":"https://api.github.com/repos/chaosma/harmony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chaosma/harmony/merges","archive_url":"https://api.github.com/repos/chaosma/harmony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chaosma/harmony/downloads","issues_url":"https://api.github.com/repos/chaosma/harmony/issues{/number}","pulls_url":"https://api.github.com/repos/chaosma/harmony/pulls{/number}","milestones_url":"https://api.github.com/repos/chaosma/harmony/milestones{/number}","notifications_url":"https://api.github.com/repos/chaosma/harmony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chaosma/harmony/labels{/name}","releases_url":"https://api.github.com/repos/chaosma/harmony/releases{/id}","deployments_url":"https://api.github.com/repos/chaosma/harmony/deployments","created_at":"2019-04-08T21:04:48Z","updated_at":"2019-06-28T05:59:39Z","pushed_at":"2019-07-19T08:33:22Z","git_url":"git://github.com/chaosma/harmony.git","ssh_url":"[email protected]:chaosma/harmony.git","clone_url":"https://github.com/chaosma/harmony.git","svn_url":"https://github.com/chaosma/harmony","homepage":"https://harmony.one","size":12642,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"harmony-one:master","ref":"master","sha":"42b8a5c23fe12122065ab93d960507fac93a9be5","user":{"login":"harmony-one","id":39147399,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ3Mzk5","avatar_url":"https://avatars2.githubusercontent.com/u/39147399?v=4","gravatar_id":"","url":"https://api.github.com/users/harmony-one","html_url":"https://github.com/harmony-one","followers_url":"https://api.github.com/users/harmony-one/followers","following_url":"https://api.github.com/users/harmony-one/following{/other_user}","gists_url":"https://api.github.com/users/harmony-one/gists{/gist_id}","starred_url":"https://api.github.com/users/harmony-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harmony-one/subscriptions","organizations_url":"https://api.github.com/users/harmony-one/orgs","repos_url":"https://api.github.com/users/harmony-one/repos","events_url":"https://api.github.com/users/harmony-one/events{/privacy}","received_events_url":"https://api.github.com/users/harmony-one/received_events","type":"Organization","site_admin":false},"repo":{"id":134344706,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQzNDQ3MDY=","name":"harmony","full_name":"harmony-one/harmony","private":false,"owner":{"login":"harmony-one","id":39147399,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTQ3Mzk5","avatar_url":"https://avatars2.githubusercontent.com/u/39147399?v=4","gravatar_id":"","url":"https://api.github.com/users/harmony-one","html_url":"https://github.com/harmony-one","followers_url":"https://api.github.com/users/harmony-one/followers","following_url":"https://api.github.com/users/harmony-one/following{/other_user}","gists_url":"https://api.github.com/users/harmony-one/gists{/gist_id}","starred_url":"https://api.github.com/users/harmony-one/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harmony-one/subscriptions","organizations_url":"https://api.github.com/users/harmony-one/orgs","repos_url":"https://api.github.com/users/harmony-one/repos","events_url":"https://api.github.com/users/harmony-one/events{/privacy}","received_events_url":"https://api.github.com/users/harmony-one/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/harmony-one/harmony","description":"The core protocol of harmony","fork":false,"url":"https://api.github.com/repos/harmony-one/harmony","forks_url":"https://api.github.com/repos/harmony-one/harmony/forks","keys_url":"https://api.github.com/repos/harmony-one/harmony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harmony-one/harmony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harmony-one/harmony/teams","hooks_url":"https://api.github.com/repos/harmony-one/harmony/hooks","issue_events_url":"https://api.github.com/repos/harmony-one/harmony/issues/events{/number}","events_url":"https://api.github.com/repos/harmony-one/harmony/events","assignees_url":"https://api.github.com/repos/harmony-one/harmony/assignees{/user}","branches_url":"https://api.github.com/repos/harmony-one/harmony/branches{/branch}","tags_url":"https://api.github.com/repos/harmony-one/harmony/tags","blobs_url":"https://api.github.com/repos/harmony-one/harmony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harmony-one/harmony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harmony-one/harmony/git/refs{/sha}","trees_url":"https://api.github.com/repos/harmony-one/harmony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harmony-one/harmony/statuses/{sha}","languages_url":"https://api.github.com/repos/harmony-one/harmony/languages","stargazers_url":"https://api.github.com/repos/harmony-one/harmony/stargazers","contributors_url":"https://api.github.com/repos/harmony-one/harmony/contributors","subscribers_url":"https://api.github.com/repos/harmony-one/harmony/subscribers","subscription_url":"https://api.github.com/repos/harmony-one/harmony/subscription","commits_url":"https://api.github.com/repos/harmony-one/harmony/commits{/sha}","git_commits_url":"https://api.github.com/repos/harmony-one/harmony/git/commits{/sha}","comments_url":"https://api.github.com/repos/harmony-one/harmony/comments{/number}","issue_comment_url":"https://api.github.com/repos/harmony-one/harmony/issues/comments{/number}","contents_url":"https://api.github.com/repos/harmony-one/harmony/contents/{+path}","compare_url":"https://api.github.com/repos/harmony-one/harmony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harmony-one/harmony/merges","archive_url":"https://api.github.com/repos/harmony-one/harmony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harmony-one/harmony/downloads","issues_url":"https://api.github.com/repos/harmony-one/harmony/issues{/number}","pulls_url":"https://api.github.com/repos/harmony-one/harmony/pulls{/number}","milestones_url":"https://api.github.com/repos/harmony-one/harmony/milestones{/number}","notifications_url":"https://api.github.com/repos/harmony-one/harmony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harmony-one/harmony/labels{/name}","releases_url":"https://api.github.com/repos/harmony-one/harmony/releases{/id}","deployments_url":"https://api.github.com/repos/harmony-one/harmony/deployments","created_at":"2018-05-22T01:37:50Z","updated_at":"2019-07-19T03:56:16Z","pushed_at":"2019-07-19T08:33:23Z","git_url":"git://github.com/harmony-one/harmony.git","ssh_url":"[email protected]:harmony-one/harmony.git","clone_url":"https://github.com/harmony-one/harmony.git","svn_url":"https://github.com/harmony-one/harmony","homepage":"https://harmony.one","size":12654,"stargazers_count":171,"watchers_count":171,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":118,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":45,"open_issues":118,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/harmony-one/harmony/pulls/1219"},"html":{"href":"https://github.com/harmony-one/harmony/pull/1219"},"issue":{"href":"https://api.github.com/repos/harmony-one/harmony/issues/1219"},"comments":{"href":"https://api.github.com/repos/harmony-one/harmony/issues/1219/comments"},"review_comments":{"href":"https://api.github.com/repos/harmony-one/harmony/pulls/1219/comments"},"review_comment":{"href":"https://api.github.com/repos/harmony-one/harmony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/harmony-one/harmony/pulls/1219/commits"},"statuses":{"href":"https://api.github.com/repos/harmony-one/harmony/statuses/840793a15b27d9428a5875d51026cd10d8eef6ad"}},"author_association":"CONTRIBUTOR"}}	{ "id": 134344706, "name": "harmony-one/harmony", "url": "https://api.github.com/repos/harmony-one/harmony" }	{ "id": 3767044, "login": "chaosma", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/3767044?", "url": "https://api.github.com/users/chaosma" }	{ "id": 39147399, "login": "harmony-one", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/39147399?", "url": "https://api.github.com/orgs/harmony-one" }	2019-07-19T18:29:35	10047767165	{"actor":{"display_login":"chaosma"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments/266031992","pull_request_review_id":215099784,"id":266031992,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NjAzMTk5Mg==","diff_hunk":"@@ -0,0 +1,73 @@\n+// @flow\n+/* global module /\n+\n+\n+const RFB = require('@novnc/novnc/core/rfb').default;\n+\n+class VncClient {\n+ rfb = undefined;\n+\n+ canvasId = undefined;\n+\n+ socketUrl = undefined;\n+\n+ connected = undefined;\n+\n+ disconnected = undefined;\n+\n+ askPassword = undefined;\n+\n+ constructor(canvasId: string, socketUrl: string, connected: Function, disconnected: Function, askPassword: Function) {\n+ this.canvasId = canvasId;\n+ this.socketUrl = socketUrl;\n+ this.connected = connected;\n+ this.disconnected = disconnected;\n+ this.askPassword = askPassword;\n+ }\n+\n+ connect = () => {\n+ if (this.canvasId != null && this.socketUrl != null) {\n+ const rfb = new RFB(document.getElementById(this.canvasId), this.socketUrl);\n+ rfb.addEventListener('connect', this.onConnect);\n+ rfb.addEventListener('disconnect', (e) => {\n+ const error = e.detail.clean ? undefined : t('Something went wrong, connection is closed');\n+ if (this.disconnected != null) {\n+ this.disconnected(error);\n+ }\n+ });\n+ rfb.addEventListener('credentialsrequired',\n+ () => {\n+ if (this.askPassword != null) {\n+ this.askPassword().then(password => rfb.sendCredentials({ password }));\n+ }\n+ });\n+ rfb.scaleViewport = false;\n+ rfb.resizeSession = false;\n+ this.rfb = rfb;\n+ }\n+ }\n+\n+ onConnect = () => {\n+ if (this.rfb != null) {\n+ this.rfb.focus();\n+ if (this.connected != null) {\n+ this.connected();\n+ }\n+ }\n+ }\n+\n+ toggleScale = (expanded: boolean) => {\n+ if (this.rfb != null) {\n+ this.rfb.scaleViewport = expanded;\n+ this.rfb.resizeSession = expanded;\n+ }\n+ }\n+\n+ canResize = true;\n+\n+ getDisplayStyle = () => ({})","path":"web/html/src/manager/virtualization/guests/console/vnc-client.js","position":null,"original_position":68,"commit_id":"9cdab09a59a76ec4e0fa343d6ed44ba8e17964b3","original_commit_id":"9988f4eda7a81aa0c9db18b8be55711b773727e4","user":{"login":"cbosdo","id":397931,"node_id":"MDQ6VXNlcjM5NzkzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/397931?v=4","gravatar_id":"","url":"https://api.github.com/users/cbosdo","html_url":"https://github.com/cbosdo","followers_url":"https://api.github.com/users/cbosdo/followers","following_url":"https://api.github.com/users/cbosdo/following{/other_user}","gists_url":"https://api.github.com/users/cbosdo/gists{/gist_id}","starred_url":"https://api.github.com/users/cbosdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbosdo/subscriptions","organizations_url":"https://api.github.com/users/cbosdo/orgs","repos_url":"https://api.github.com/users/cbosdo/repos","events_url":"https://api.github.com/users/cbosdo/events{/privacy}","received_events_url":"https://api.github.com/users/cbosdo/received_events","type":"User","site_admin":false},"body":"Function removed: this is now a class definition in the css file.","created_at":"2019-03-15T15:29:11Z","updated_at":"2019-03-15T15:29:11Z","html_url":"https://github.com/uyuni-project/uyuni/pull/417#discussion_r266031992","pull_request_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/417","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments/266031992"},"html":{"href":"https://github.com/uyuni-project/uyuni/pull/417#discussion_r266031992"},"pull_request":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/417"}},"in_reply_to_id":265841190},"pull_request":{"url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/417","id":240084632,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMDg0NjMy","html_url":"https://github.com/uyuni-project/uyuni/pull/417","diff_url":"https://github.com/uyuni-project/uyuni/pull/417.diff","patch_url":"https://github.com/uyuni-project/uyuni/pull/417.patch","issue_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/417","number":417,"state":"open","locked":false,"title":"Virt console","user":{"login":"cbosdo","id":397931,"node_id":"MDQ6VXNlcjM5NzkzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/397931?v=4","gravatar_id":"","url":"https://api.github.com/users/cbosdo","html_url":"https://github.com/cbosdo","followers_url":"https://api.github.com/users/cbosdo/followers","following_url":"https://api.github.com/users/cbosdo/following{/other_user}","gists_url":"https://api.github.com/users/cbosdo/gists{/gist_id}","starred_url":"https://api.github.com/users/cbosdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbosdo/subscriptions","organizations_url":"https://api.github.com/users/cbosdo/orgs","repos_url":"https://api.github.com/users/cbosdo/repos","events_url":"https://api.github.com/users/cbosdo/events{/privacy}","received_events_url":"https://api.github.com/users/cbosdo/received_events","type":"User","site_admin":false},"body":"## What does this PR change?\r\n\r\nAdd a page to display the VNC or Spice console for the virtual machine.\r\n\r\n## GUI diff\r\n\r\nBefore:\r\n\r\nNo way to show the display of the VM\r\n\r\nAfter:\r\n\r\nA button is added to the VM actions to open a new tab/page showing the VNC or Spice display.\r\n\r\n- [x] DONE\r\n\r\n## Documentation\r\n- [doc-susemanager](https://github.com/SUSE/doc-susemanager) PR or issue was created (GitHub automatic link expected below)\r\n\r\n- [x] DONE\r\n\r\n## Test coverage\r\n- Unit tests were added\r\n- Cucumber tests were added\r\n\r\n- [x] DONE*\r\n\r\n## Links\r\n\r\n- [x] [Upstream spice-html5 review and npmjs publication](https://lists.freedesktop.org/archives/spice-devel/2019-February/047929.html)\r\n- [X] WebSockify JWT Token Plugin SLE and openSUSE Submit Requests","created_at":"2018-12-20T08:13:37Z","updated_at":"2019-03-15T15:29:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96775519bb244934643396ceafaf6661b43fb2ad","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cbbayburt","id":1103552,"node_id":"MDQ6VXNlcjExMDM1NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1103552?v=4","gravatar_id":"","url":"https://api.github.com/users/cbbayburt","html_url":"https://github.com/cbbayburt","followers_url":"https://api.github.com/users/cbbayburt/followers","following_url":"https://api.github.com/users/cbbayburt/following{/other_user}","gists_url":"https://api.github.com/users/cbbayburt/gists{/gist_id}","starred_url":"https://api.github.com/users/cbbayburt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbbayburt/subscriptions","organizations_url":"https://api.github.com/users/cbbayburt/orgs","repos_url":"https://api.github.com/users/cbbayburt/repos","events_url":"https://api.github.com/users/cbbayburt/events{/privacy}","received_events_url":"https://api.github.com/users/cbbayburt/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/417/commits","review_comments_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/417/comments","review_comment_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/417/comments","statuses_url":"https://api.github.com/repos/uyuni-project/uyuni/statuses/9cdab09a59a76ec4e0fa343d6ed44ba8e17964b3","head":{"label":"cbosdo:virt-console","ref":"virt-console","sha":"9cdab09a59a76ec4e0fa343d6ed44ba8e17964b3","user":{"login":"cbosdo","id":397931,"node_id":"MDQ6VXNlcjM5NzkzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/397931?v=4","gravatar_id":"","url":"https://api.github.com/users/cbosdo","html_url":"https://github.com/cbosdo","followers_url":"https://api.github.com/users/cbosdo/followers","following_url":"https://api.github.com/users/cbosdo/following{/other_user}","gists_url":"https://api.github.com/users/cbosdo/gists{/gist_id}","starred_url":"https://api.github.com/users/cbosdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbosdo/subscriptions","organizations_url":"https://api.github.com/users/cbosdo/orgs","repos_url":"https://api.github.com/users/cbosdo/repos","events_url":"https://api.github.com/users/cbosdo/events{/privacy}","received_events_url":"https://api.github.com/users/cbosdo/received_events","type":"User","site_admin":false},"repo":{"id":145391487,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUzOTE0ODc=","name":"uyuni","full_name":"cbosdo/uyuni","private":false,"owner":{"login":"cbosdo","id":397931,"node_id":"MDQ6VXNlcjM5NzkzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/397931?v=4","gravatar_id":"","url":"https://api.github.com/users/cbosdo","html_url":"https://github.com/cbosdo","followers_url":"https://api.github.com/users/cbosdo/followers","following_url":"https://api.github.com/users/cbosdo/following{/other_user}","gists_url":"https://api.github.com/users/cbosdo/gists{/gist_id}","starred_url":"https://api.github.com/users/cbosdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbosdo/subscriptions","organizations_url":"https://api.github.com/users/cbosdo/orgs","repos_url":"https://api.github.com/users/cbosdo/repos","events_url":"https://api.github.com/users/cbosdo/events{/privacy}","received_events_url":"https://api.github.com/users/cbosdo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cbosdo/uyuni","description":"Source code for Uyuni","fork":true,"url":"https://api.github.com/repos/cbosdo/uyuni","forks_url":"https://api.github.com/repos/cbosdo/uyuni/forks","keys_url":"https://api.github.com/repos/cbosdo/uyuni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbosdo/uyuni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbosdo/uyuni/teams","hooks_url":"https://api.github.com/repos/cbosdo/uyuni/hooks","issue_events_url":"https://api.github.com/repos/cbosdo/uyuni/issues/events{/number}","events_url":"https://api.github.com/repos/cbosdo/uyuni/events","assignees_url":"https://api.github.com/repos/cbosdo/uyuni/assignees{/user}","branches_url":"https://api.github.com/repos/cbosdo/uyuni/branches{/branch}","tags_url":"https://api.github.com/repos/cbosdo/uyuni/tags","blobs_url":"https://api.github.com/repos/cbosdo/uyuni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbosdo/uyuni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbosdo/uyuni/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbosdo/uyuni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbosdo/uyuni/statuses/{sha}","languages_url":"https://api.github.com/repos/cbosdo/uyuni/languages","stargazers_url":"https://api.github.com/repos/cbosdo/uyuni/stargazers","contributors_url":"https://api.github.com/repos/cbosdo/uyuni/contributors","subscribers_url":"https://api.github.com/repos/cbosdo/uyuni/subscribers","subscription_url":"https://api.github.com/repos/cbosdo/uyuni/subscription","commits_url":"https://api.github.com/repos/cbosdo/uyuni/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbosdo/uyuni/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbosdo/uyuni/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbosdo/uyuni/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbosdo/uyuni/contents/{+path}","compare_url":"https://api.github.com/repos/cbosdo/uyuni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbosdo/uyuni/merges","archive_url":"https://api.github.com/repos/cbosdo/uyuni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbosdo/uyuni/downloads","issues_url":"https://api.github.com/repos/cbosdo/uyuni/issues{/number}","pulls_url":"https://api.github.com/repos/cbosdo/uyuni/pulls{/number}","milestones_url":"https://api.github.com/repos/cbosdo/uyuni/milestones{/number}","notifications_url":"https://api.github.com/repos/cbosdo/uyuni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbosdo/uyuni/labels{/name}","releases_url":"https://api.github.com/repos/cbosdo/uyuni/releases{/id}","deployments_url":"https://api.github.com/repos/cbosdo/uyuni/deployments","created_at":"2018-08-20T08:50:54Z","updated_at":"2018-08-20T08:52:04Z","pushed_at":"2019-03-15T13:24:11Z","git_url":"git://github.com/cbosdo/uyuni.git","ssh_url":"[email protected]:cbosdo/uyuni.git","clone_url":"https://github.com/cbosdo/uyuni.git","svn_url":"https://github.com/cbosdo/uyuni","homepage":"https://www.uyuni-project.org/","size":797851,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uyuni-project:master","ref":"master","sha":"7000c534f69887f5d3cab98e167baf67a5c6e120","user":{"login":"uyuni-project","id":39272261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjcyMjYx","avatar_url":"https://avatars0.githubusercontent.com/u/39272261?v=4","gravatar_id":"","url":"https://api.github.com/users/uyuni-project","html_url":"https://github.com/uyuni-project","followers_url":"https://api.github.com/users/uyuni-project/followers","following_url":"https://api.github.com/users/uyuni-project/following{/other_user}","gists_url":"https://api.github.com/users/uyuni-project/gists{/gist_id}","starred_url":"https://api.github.com/users/uyuni-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uyuni-project/subscriptions","organizations_url":"https://api.github.com/users/uyuni-project/orgs","repos_url":"https://api.github.com/users/uyuni-project/repos","events_url":"https://api.github.com/users/uyuni-project/events{/privacy}","received_events_url":"https://api.github.com/users/uyuni-project/received_events","type":"Organization","site_admin":false},"repo":{"id":143291989,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyOTE5ODk=","name":"uyuni","full_name":"uyuni-project/uyuni","private":false,"owner":{"login":"uyuni-project","id":39272261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjcyMjYx","avatar_url":"https://avatars0.githubusercontent.com/u/39272261?v=4","gravatar_id":"","url":"https://api.github.com/users/uyuni-project","html_url":"https://github.com/uyuni-project","followers_url":"https://api.github.com/users/uyuni-project/followers","following_url":"https://api.github.com/users/uyuni-project/following{/other_user}","gists_url":"https://api.github.com/users/uyuni-project/gists{/gist_id}","starred_url":"https://api.github.com/users/uyuni-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uyuni-project/subscriptions","organizations_url":"https://api.github.com/users/uyuni-project/orgs","repos_url":"https://api.github.com/users/uyuni-project/repos","events_url":"https://api.github.com/users/uyuni-project/events{/privacy}","received_events_url":"https://api.github.com/users/uyuni-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/uyuni-project/uyuni","description":"Source code for Uyuni","fork":false,"url":"https://api.github.com/repos/uyuni-project/uyuni","forks_url":"https://api.github.com/repos/uyuni-project/uyuni/forks","keys_url":"https://api.github.com/repos/uyuni-project/uyuni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uyuni-project/uyuni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uyuni-project/uyuni/teams","hooks_url":"https://api.github.com/repos/uyuni-project/uyuni/hooks","issue_events_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/events{/number}","events_url":"https://api.github.com/repos/uyuni-project/uyuni/events","assignees_url":"https://api.github.com/repos/uyuni-project/uyuni/assignees{/user}","branches_url":"https://api.github.com/repos/uyuni-project/uyuni/branches{/branch}","tags_url":"https://api.github.com/repos/uyuni-project/uyuni/tags","blobs_url":"https://api.github.com/repos/uyuni-project/uyuni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uyuni-project/uyuni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uyuni-project/uyuni/git/refs{/sha}","trees_url":"https://api.github.com/repos/uyuni-project/uyuni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uyuni-project/uyuni/statuses/{sha}","languages_url":"https://api.github.com/repos/uyuni-project/uyuni/languages","stargazers_url":"https://api.github.com/repos/uyuni-project/uyuni/stargazers","contributors_url":"https://api.github.com/repos/uyuni-project/uyuni/contributors","subscribers_url":"https://api.github.com/repos/uyuni-project/uyuni/subscribers","subscription_url":"https://api.github.com/repos/uyuni-project/uyuni/subscription","commits_url":"https://api.github.com/repos/uyuni-project/uyuni/commits{/sha}","git_commits_url":"https://api.github.com/repos/uyuni-project/uyuni/git/commits{/sha}","comments_url":"https://api.github.com/repos/uyuni-project/uyuni/comments{/number}","issue_comment_url":"https://api.github.com/repos/uyuni-project/uyuni/issues/comments{/number}","contents_url":"https://api.github.com/repos/uyuni-project/uyuni/contents/{+path}","compare_url":"https://api.github.com/repos/uyuni-project/uyuni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uyuni-project/uyuni/merges","archive_url":"https://api.github.com/repos/uyuni-project/uyuni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uyuni-project/uyuni/downloads","issues_url":"https://api.github.com/repos/uyuni-project/uyuni/issues{/number}","pulls_url":"https://api.github.com/repos/uyuni-project/uyuni/pulls{/number}","milestones_url":"https://api.github.com/repos/uyuni-project/uyuni/milestones{/number}","notifications_url":"https://api.github.com/repos/uyuni-project/uyuni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uyuni-project/uyuni/labels{/name}","releases_url":"https://api.github.com/repos/uyuni-project/uyuni/releases{/id}","deployments_url":"https://api.github.com/repos/uyuni-project/uyuni/deployments","created_at":"2018-08-02T12:31:20Z","updated_at":"2019-03-15T15:17:32Z","pushed_at":"2019-03-15T15:17:25Z","git_url":"git://github.com/uyuni-project/uyuni.git","ssh_url":"[email protected]:uyuni-project/uyuni.git","clone_url":"https://github.com/uyuni-project/uyuni.git","svn_url":"https://github.com/uyuni-project/uyuni","homepage":"https://www.uyuni-project.org/","size":798298,"stargazers_count":48,"watchers_count":48,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":32,"open_issues":62,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/417"},"html":{"href":"https://github.com/uyuni-project/uyuni/pull/417"},"issue":{"href":"https://api.github.com/repos/uyuni-project/uyuni/issues/417"},"comments":{"href":"https://api.github.com/repos/uyuni-project/uyuni/issues/417/comments"},"review_comments":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/417/comments"},"review_comment":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uyuni-project/uyuni/pulls/417/commits"},"statuses":{"href":"https://api.github.com/repos/uyuni-project/uyuni/statuses/9cdab09a59a76ec4e0fa343d6ed44ba8e17964b3"}},"author_association":"CONTRIBUTOR"}}	{ "id": 143291989, "name": "uyuni-project/uyuni", "url": "https://api.github.com/repos/uyuni-project/uyuni" }	{ "id": 397931, "login": "cbosdo", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/397931?", "url": "https://api.github.com/users/cbosdo" }	{ "id": 39272261, "login": "uyuni-project", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/39272261?", "url": "https://api.github.com/orgs/uyuni-project" }	2019-03-15T15:29:11	9251774665	{"actor":{"display_login":"cbosdo"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/asappresearch/flambe/pulls/comments/356343550","pull_request_review_id":330226513,"id":356343550,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NjM0MzU1MA==","diff_hunk":"@@ -28,6 +32,10 @@ jobs:\n - image: python:3.6","path":".circleci/config.yml","position":12,"original_position":12,"commit_id":"e98778c0eb10486924beb239cef8405eaa5ecfea","original_commit_id":"e98778c0eb10486924beb239cef8405eaa5ecfea","user":{"login":"jeremyasapp","id":33673620,"node_id":"MDQ6VXNlcjMzNjczNjIw","avatar_url":"https://avatars1.githubusercontent.com/u/33673620?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremyasapp","html_url":"https://github.com/jeremyasapp","followers_url":"https://api.github.com/users/jeremyasapp/followers","following_url":"https://api.github.com/users/jeremyasapp/following{/other_user}","gists_url":"https://api.github.com/users/jeremyasapp/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyasapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyasapp/subscriptions","organizations_url":"https://api.github.com/users/jeremyasapp/orgs","repos_url":"https://api.github.com/users/jeremyasapp/repos","events_url":"https://api.github.com/users/jeremyasapp/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyasapp/received_events","type":"User","site_admin":false},"body":"isn't this a problem?","created_at":"2019-12-11T00:03:33Z","updated_at":"2019-12-11T00:03:42Z","html_url":"https://github.com/asappresearch/flambe/pull/175#discussion_r356343550","pull_request_url":"https://api.github.com/repos/asappresearch/flambe/pulls/175","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/asappresearch/flambe/pulls/comments/356343550"},"html":{"href":"https://github.com/asappresearch/flambe/pull/175#discussion_r356343550"},"pull_request":{"href":"https://api.github.com/repos/asappresearch/flambe/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/asappresearch/flambe/pulls/175","id":351542995,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUxNTQyOTk1","html_url":"https://github.com/asappresearch/flambe/pull/175","diff_url":"https://github.com/asappresearch/flambe/pull/175.diff","patch_url":"https://github.com/asappresearch/flambe/pull/175.patch","issue_url":"https://api.github.com/repos/asappresearch/flambe/issues/175","number":175,"state":"open","locked":false,"title":"Adding tests for python 3.7","user":{"login":"iitzco-asapp","id":44784672,"node_id":"MDQ6VXNlcjQ0Nzg0Njcy","avatar_url":"https://avatars0.githubusercontent.com/u/44784672?v=4","gravatar_id":"","url":"https://api.github.com/users/iitzco-asapp","html_url":"https://github.com/iitzco-asapp","followers_url":"https://api.github.com/users/iitzco-asapp/followers","following_url":"https://api.github.com/users/iitzco-asapp/following{/other_user}","gists_url":"https://api.github.com/users/iitzco-asapp/gists{/gist_id}","starred_url":"https://api.github.com/users/iitzco-asapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iitzco-asapp/subscriptions","organizations_url":"https://api.github.com/users/iitzco-asapp/orgs","repos_url":"https://api.github.com/users/iitzco-asapp/repos","events_url":"https://api.github.com/users/iitzco-asapp/events{/privacy}","received_events_url":"https://api.github.com/users/iitzco-asapp/received_events","type":"User","site_admin":false},"body":"- `tox` now must execute test suite in `3.7`\r\n- CCI was fixed so that it can install requirements in `3.7`\r\n\r\nThe python:3.6 image we are using already contains both python 3.6 and python 3.7","created_at":"2019-12-10T18:57:40Z","updated_at":"2019-12-11T00:03:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45d279b0a7f6498a114ff39e1164866235847479","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/asappresearch/flambe/pulls/175/commits","review_comments_url":"https://api.github.com/repos/asappresearch/flambe/pulls/175/comments","review_comment_url":"https://api.github.com/repos/asappresearch/flambe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/asappresearch/flambe/issues/175/comments","statuses_url":"https://api.github.com/repos/asappresearch/flambe/statuses/e98778c0eb10486924beb239cef8405eaa5ecfea","head":{"label":"asappresearch:3.7__itzco","ref":"3.7__itzco","sha":"e98778c0eb10486924beb239cef8405eaa5ecfea","user":{"login":"asappresearch","id":39382690,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzgyNjkw","avatar_url":"https://avatars1.githubusercontent.com/u/39382690?v=4","gravatar_id":"","url":"https://api.github.com/users/asappresearch","html_url":"https://github.com/asappresearch","followers_url":"https://api.github.com/users/asappresearch/followers","following_url":"https://api.github.com/users/asappresearch/following{/other_user}","gists_url":"https://api.github.com/users/asappresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/asappresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asappresearch/subscriptions","organizations_url":"https://api.github.com/users/asappresearch/orgs","repos_url":"https://api.github.com/users/asappresearch/repos","events_url":"https://api.github.com/users/asappresearch/events{/privacy}","received_events_url":"https://api.github.com/users/asappresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":199525869,"node_id":"MDEwOlJlcG9zaXRvcnkxOTk1MjU4Njk=","name":"flambe","full_name":"asappresearch/flambe","private":false,"owner":{"login":"asappresearch","id":39382690,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzgyNjkw","avatar_url":"https://avatars1.githubusercontent.com/u/39382690?v=4","gravatar_id":"","url":"https://api.github.com/users/asappresearch","html_url":"https://github.com/asappresearch","followers_url":"https://api.github.com/users/asappresearch/followers","following_url":"https://api.github.com/users/asappresearch/following{/other_user}","gists_url":"https://api.github.com/users/asappresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/asappresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asappresearch/subscriptions","organizations_url":"https://api.github.com/users/asappresearch/orgs","repos_url":"https://api.github.com/users/asappresearch/repos","events_url":"https://api.github.com/users/asappresearch/events{/privacy}","received_events_url":"https://api.github.com/users/asappresearch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/asappresearch/flambe","description":"An ML framework to accelerate research and its path to production.","fork":false,"url":"https://api.github.com/repos/asappresearch/flambe","forks_url":"https://api.github.com/repos/asappresearch/flambe/forks","keys_url":"https://api.github.com/repos/asappresearch/flambe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asappresearch/flambe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asappresearch/flambe/teams","hooks_url":"https://api.github.com/repos/asappresearch/flambe/hooks","issue_events_url":"https://api.github.com/repos/asappresearch/flambe/issues/events{/number}","events_url":"https://api.github.com/repos/asappresearch/flambe/events","assignees_url":"https://api.github.com/repos/asappresearch/flambe/assignees{/user}","branches_url":"https://api.github.com/repos/asappresearch/flambe/branches{/branch}","tags_url":"https://api.github.com/repos/asappresearch/flambe/tags","blobs_url":"https://api.github.com/repos/asappresearch/flambe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asappresearch/flambe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asappresearch/flambe/git/refs{/sha}","trees_url":"https://api.github.com/repos/asappresearch/flambe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asappresearch/flambe/statuses/{sha}","languages_url":"https://api.github.com/repos/asappresearch/flambe/languages","stargazers_url":"https://api.github.com/repos/asappresearch/flambe/stargazers","contributors_url":"https://api.github.com/repos/asappresearch/flambe/contributors","subscribers_url":"https://api.github.com/repos/asappresearch/flambe/subscribers","subscription_url":"https://api.github.com/repos/asappresearch/flambe/subscription","commits_url":"https://api.github.com/repos/asappresearch/flambe/commits{/sha}","git_commits_url":"https://api.github.com/repos/asappresearch/flambe/git/commits{/sha}","comments_url":"https://api.github.com/repos/asappresearch/flambe/comments{/number}","issue_comment_url":"https://api.github.com/repos/asappresearch/flambe/issues/comments{/number}","contents_url":"https://api.github.com/repos/asappresearch/flambe/contents/{+path}","compare_url":"https://api.github.com/repos/asappresearch/flambe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asappresearch/flambe/merges","archive_url":"https://api.github.com/repos/asappresearch/flambe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asappresearch/flambe/downloads","issues_url":"https://api.github.com/repos/asappresearch/flambe/issues{/number}","pulls_url":"https://api.github.com/repos/asappresearch/flambe/pulls{/number}","milestones_url":"https://api.github.com/repos/asappresearch/flambe/milestones{/number}","notifications_url":"https://api.github.com/repos/asappresearch/flambe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asappresearch/flambe/labels{/name}","releases_url":"https://api.github.com/repos/asappresearch/flambe/releases{/id}","deployments_url":"https://api.github.com/repos/asappresearch/flambe/deployments","created_at":"2019-07-29T20:57:45Z","updated_at":"2019-12-09T14:03:25Z","pushed_at":"2019-12-10T23:58:24Z","git_url":"git://github.com/asappresearch/flambe.git","ssh_url":"[email protected]:asappresearch/flambe.git","clone_url":"https://github.com/asappresearch/flambe.git","svn_url":"https://github.com/asappresearch/flambe","homepage":"https://flambe.ai","size":13175,"stargazers_count":130,"watchers_count":130,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21,"open_issues":26,"watchers":130,"default_branch":"master"}},"base":{"label":"asappresearch:master","ref":"master","sha":"810cb8c710905a3f7b7cfc76210eb50984d9663e","user":{"login":"asappresearch","id":39382690,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzgyNjkw","avatar_url":"https://avatars1.githubusercontent.com/u/39382690?v=4","gravatar_id":"","url":"https://api.github.com/users/asappresearch","html_url":"https://github.com/asappresearch","followers_url":"https://api.github.com/users/asappresearch/followers","following_url":"https://api.github.com/users/asappresearch/following{/other_user}","gists_url":"https://api.github.com/users/asappresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/asappresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asappresearch/subscriptions","organizations_url":"https://api.github.com/users/asappresearch/orgs","repos_url":"https://api.github.com/users/asappresearch/repos","events_url":"https://api.github.com/users/asappresearch/events{/privacy}","received_events_url":"https://api.github.com/users/asappresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":199525869,"node_id":"MDEwOlJlcG9zaXRvcnkxOTk1MjU4Njk=","name":"flambe","full_name":"asappresearch/flambe","private":false,"owner":{"login":"asappresearch","id":39382690,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzgyNjkw","avatar_url":"https://avatars1.githubusercontent.com/u/39382690?v=4","gravatar_id":"","url":"https://api.github.com/users/asappresearch","html_url":"https://github.com/asappresearch","followers_url":"https://api.github.com/users/asappresearch/followers","following_url":"https://api.github.com/users/asappresearch/following{/other_user}","gists_url":"https://api.github.com/users/asappresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/asappresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asappresearch/subscriptions","organizations_url":"https://api.github.com/users/asappresearch/orgs","repos_url":"https://api.github.com/users/asappresearch/repos","events_url":"https://api.github.com/users/asappresearch/events{/privacy}","received_events_url":"https://api.github.com/users/asappresearch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/asappresearch/flambe","description":"An ML framework to accelerate research and its path to production.","fork":false,"url":"https://api.github.com/repos/asappresearch/flambe","forks_url":"https://api.github.com/repos/asappresearch/flambe/forks","keys_url":"https://api.github.com/repos/asappresearch/flambe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asappresearch/flambe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asappresearch/flambe/teams","hooks_url":"https://api.github.com/repos/asappresearch/flambe/hooks","issue_events_url":"https://api.github.com/repos/asappresearch/flambe/issues/events{/number}","events_url":"https://api.github.com/repos/asappresearch/flambe/events","assignees_url":"https://api.github.com/repos/asappresearch/flambe/assignees{/user}","branches_url":"https://api.github.com/repos/asappresearch/flambe/branches{/branch}","tags_url":"https://api.github.com/repos/asappresearch/flambe/tags","blobs_url":"https://api.github.com/repos/asappresearch/flambe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asappresearch/flambe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asappresearch/flambe/git/refs{/sha}","trees_url":"https://api.github.com/repos/asappresearch/flambe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asappresearch/flambe/statuses/{sha}","languages_url":"https://api.github.com/repos/asappresearch/flambe/languages","stargazers_url":"https://api.github.com/repos/asappresearch/flambe/stargazers","contributors_url":"https://api.github.com/repos/asappresearch/flambe/contributors","subscribers_url":"https://api.github.com/repos/asappresearch/flambe/subscribers","subscription_url":"https://api.github.com/repos/asappresearch/flambe/subscription","commits_url":"https://api.github.com/repos/asappresearch/flambe/commits{/sha}","git_commits_url":"https://api.github.com/repos/asappresearch/flambe/git/commits{/sha}","comments_url":"https://api.github.com/repos/asappresearch/flambe/comments{/number}","issue_comment_url":"https://api.github.com/repos/asappresearch/flambe/issues/comments{/number}","contents_url":"https://api.github.com/repos/asappresearch/flambe/contents/{+path}","compare_url":"https://api.github.com/repos/asappresearch/flambe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asappresearch/flambe/merges","archive_url":"https://api.github.com/repos/asappresearch/flambe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asappresearch/flambe/downloads","issues_url":"https://api.github.com/repos/asappresearch/flambe/issues{/number}","pulls_url":"https://api.github.com/repos/asappresearch/flambe/pulls{/number}","milestones_url":"https://api.github.com/repos/asappresearch/flambe/milestones{/number}","notifications_url":"https://api.github.com/repos/asappresearch/flambe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asappresearch/flambe/labels{/name}","releases_url":"https://api.github.com/repos/asappresearch/flambe/releases{/id}","deployments_url":"https://api.github.com/repos/asappresearch/flambe/deployments","created_at":"2019-07-29T20:57:45Z","updated_at":"2019-12-09T14:03:25Z","pushed_at":"2019-12-10T23:58:24Z","git_url":"git://github.com/asappresearch/flambe.git","ssh_url":"[email protected]:asappresearch/flambe.git","clone_url":"https://github.com/asappresearch/flambe.git","svn_url":"https://github.com/asappresearch/flambe","homepage":"https://flambe.ai","size":13175,"stargazers_count":130,"watchers_count":130,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":26,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21,"open_issues":26,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/asappresearch/flambe/pulls/175"},"html":{"href":"https://github.com/asappresearch/flambe/pull/175"},"issue":{"href":"https://api.github.com/repos/asappresearch/flambe/issues/175"},"comments":{"href":"https://api.github.com/repos/asappresearch/flambe/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/asappresearch/flambe/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/asappresearch/flambe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/asappresearch/flambe/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/asappresearch/flambe/statuses/e98778c0eb10486924beb239cef8405eaa5ecfea"}},"author_association":"COLLABORATOR"}}	{ "id": 199525869, "name": "asappresearch/flambe", "url": "https://api.github.com/repos/asappresearch/flambe" }	{ "id": 33673620, "login": "jeremyasapp", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/33673620?", "url": "https://api.github.com/users/jeremyasapp" }	{ "id": 39382690, "login": "asappresearch", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/39382690?", "url": "https://api.github.com/orgs/asappresearch" }	2019-12-11T00:03:33	11059535907	{"actor":{"display_login":"jeremyasapp"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/sakura-editor/sakura/pulls/comments/283071520","pull_request_review_id":236349810,"id":283071520,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MzA3MTUyMA==","diff_hunk":"@@ -53,6 +55,18 @@ if(BUILD_GTEST)\n \t# Build GoogleTest from source code.\n \ttarget_link_libraries(${project_name} PRIVATE gtest)\n \ttarget_link_libraries(${project_name} PRIVATE gtest_main)\n+elseif(MSVC)\n+\t# Build without GoogleTest for MSVC(use NuGet package).","path":"tests/unittests/CMakeLists.txt","position":18,"original_position":18,"commit_id":"9312d4d7b50d48b0848aad0de01084d1ed0338bb","original_commit_id":"9312d4d7b50d48b0848aad0de01084d1ed0338bb","user":{"login":"beru","id":1131125,"node_id":"MDQ6VXNlcjExMzExMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1131125?v=4","gravatar_id":"","url":"https://api.github.com/users/beru","html_url":"https://github.com/beru","followers_url":"https://api.github.com/users/beru/followers","following_url":"https://api.github.com/users/beru/following{/other_user}","gists_url":"https://api.github.com/users/beru/gists{/gist_id}","starred_url":"https://api.github.com/users/beru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beru/subscriptions","organizations_url":"https://api.github.com/users/beru/orgs","repos_url":"https://api.github.com/users/beru/repos","events_url":"https://api.github.com/users/beru/events{/privacy}","received_events_url":"https://api.github.com/users/beru/received_events","type":"User","site_admin":false},"body":"このコメントですが直訳すると以下のように読めてしまいます。\r\n\r\n`MSVCの場合は GoogleTest 無しでビルドする (NuGet パッケージを使用する)`\r\n or\r\n`MSVC向けのGoogleTest 無しでビルドする (NuGet パッケージを使用する)` <br>\r\n\r\n実際に伝えたいのは、\r\n`GoogleTest をソースコードからビルドしない` と\r\n`MSVCの場合は NuGet パッケージを使用する`\r\nだと思いますので、\r\n\r\n`# GoogleTest won't be built from source`\r\n及び、\r\n`# Uses NuGet package in the case of MSVC.`\r\nとするのはどうでしょうか？\r\n","created_at":"2019-05-10T23:56:14Z","updated_at":"2019-05-10T23:56:14Z","html_url":"https://github.com/sakura-editor/sakura/pull/898#discussion_r283071520","pull_request_url":"https://api.github.com/repos/sakura-editor/sakura/pulls/898","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/comments/283071520"},"html":{"href":"https://github.com/sakura-editor/sakura/pull/898#discussion_r283071520"},"pull_request":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/898"}}},"pull_request":{"url":"https://api.github.com/repos/sakura-editor/sakura/pulls/898","id":276001158,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc2MDAxMTU4","html_url":"https://github.com/sakura-editor/sakura/pull/898","diff_url":"https://github.com/sakura-editor/sakura/pull/898.diff","patch_url":"https://github.com/sakura-editor/sakura/pull/898.patch","issue_url":"https://api.github.com/repos/sakura-editor/sakura/issues/898","number":898,"state":"open","locked":false,"title":"[WIP] テストのビルドにパッケージを使ってビルド時間を短縮する(-G=Visual Studio(MSVC)版) ","user":{"login":"berryzplus","id":3253151,"node_id":"MDQ6VXNlcjMyNTMxNTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3253151?v=4","gravatar_id":"","url":"https://api.github.com/users/berryzplus","html_url":"https://github.com/berryzplus","followers_url":"https://api.github.com/users/berryzplus/followers","following_url":"https://api.github.com/users/berryzplus/following{/other_user}","gists_url":"https://api.github.com/users/berryzplus/gists{/gist_id}","starred_url":"https://api.github.com/users/berryzplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berryzplus/subscriptions","organizations_url":"https://api.github.com/users/berryzplus/orgs","repos_url":"https://api.github.com/users/berryzplus/repos","events_url":"https://api.github.com/users/berryzplus/events{/privacy}","received_events_url":"https://api.github.com/users/berryzplus/received_events","type":"User","site_admin":false},"body":"## 目的\r\nMSVC向けテストのビルド時間を短縮します。\r\n\r\n## 前提\r\n1. MinGW向けのビルド時間短縮は #894 で実施済み。\r\n2. MinGWと同じ方法でビルド時間短縮を行いたいが、MSVC向けのGTestライブラリを「システムライブラリ」としてインストールするのはあまり一般的ではない。\r\n3. CMakeのGeneratorが `Visual Studio*` なら NuGetパッケージの取り込みは簡単にできる。\r\n4. MSVC向けのGTestライブラリはNuGetパッケージとして提供されている。\r\n5. NuGetパッケージを取得するにはNuGet.exeが必要。\r\n\r\n## 変更内容\r\n1. `BUILD_GTEST=OFF`の処理に分岐を入れてMSVCならNuGetパッケージを使うように変更。NuGet.exeを探してrestoreし、NuGet.targetsをtarget_link_librariesする処理を入れた。\r\n2. MSVC向けテストプロジェクトを作成する`BUILD_GTEST`の値をONからOFFに変更。\r\n3. 他用途に使いまわす可能性がある「NuGet.exeを探す処理」をパッケージ化して`FindNuGet.cmake`を作成。CMake公式の`FindPerl.cmake`をコピペして作った関係でライセンスはBSD 3 Clauseとしてある。\r\n4. NuGet版GTestを探す処理をパッケージ化して`FindNuGetGTest.cmake`を作成。現段階では必ずしも分離する必要はないが、`-G=Ninja`の場合に処理を拡張する必要があるので先に分離した。`FindNuGet.cmake`と同様にCMake公式の`FindPerl.cmake`をコピペして作った関係でライセンスはBSD 3 Clauseとしてある。\r\n\r\n\r\n## メリット\r\nMSVC版でGooleTestをビルドする必要がなくなるため、ビルドがわずかに速くなります。\r\nGoogleTestをビルドしないので、ログ出力が若干短くなります。\r\n他の有用なライブラリを取り込む際に参考にできる実績を作ることができます。\r\n\r\n## デメリット\r\nMSVC版で本当にシステムライブラリを使いたい場合に対応できなくなります。\r\nNuGet.exeがシステムにない場合を考慮してnuget.exe(約5MB)を取り込むのでgit cloneのサイズが大きくなります。\r\n\r\n## 備考\r\n主目的「ビルド時間を短縮する」の効果は、言うほどないと思っています。(数十秒程度:sob:\r\n「PR出します」って言っといてださないのもアレなので、ちょっと残念な感じの効果ですがないよりましだろうってことで出してみます。\r\n\r\nこのPRの後継として`ソリューション全体のCMake化(-G Ninja対応)`を予定しています。作業過程として一旦この形にしたことを共有しておくことが、全体理解の助けになるんじゃないかという期待もあります。","created_at":"2019-05-05T14:32:28Z","updated_at":"2019-05-10T23:56:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07d115307921dc0fb46257ecc936879a52a39599","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sakura-editor/sakura/pulls/898/commits","review_comments_url":"https://api.github.com/repos/sakura-editor/sakura/pulls/898/comments","review_comment_url":"https://api.github.com/repos/sakura-editor/sakura/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sakura-editor/sakura/issues/898/comments","statuses_url":"https://api.github.com/repos/sakura-editor/sakura/statuses/9312d4d7b50d48b0848aad0de01084d1ed0338bb","head":{"label":"berryzplus:feature/use_gtest_package_for_MSVC","ref":"feature/use_gtest_package_for_MSVC","sha":"9312d4d7b50d48b0848aad0de01084d1ed0338bb","user":{"login":"berryzplus","id":3253151,"node_id":"MDQ6VXNlcjMyNTMxNTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3253151?v=4","gravatar_id":"","url":"https://api.github.com/users/berryzplus","html_url":"https://github.com/berryzplus","followers_url":"https://api.github.com/users/berryzplus/followers","following_url":"https://api.github.com/users/berryzplus/following{/other_user}","gists_url":"https://api.github.com/users/berryzplus/gists{/gist_id}","starred_url":"https://api.github.com/users/berryzplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berryzplus/subscriptions","organizations_url":"https://api.github.com/users/berryzplus/orgs","repos_url":"https://api.github.com/users/berryzplus/repos","events_url":"https://api.github.com/users/berryzplus/events{/privacy}","received_events_url":"https://api.github.com/users/berryzplus/received_events","type":"User","site_admin":false},"repo":{"id":135163149,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUxNjMxNDk=","name":"sakura","full_name":"berryzplus/sakura","private":false,"owner":{"login":"berryzplus","id":3253151,"node_id":"MDQ6VXNlcjMyNTMxNTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3253151?v=4","gravatar_id":"","url":"https://api.github.com/users/berryzplus","html_url":"https://github.com/berryzplus","followers_url":"https://api.github.com/users/berryzplus/followers","following_url":"https://api.github.com/users/berryzplus/following{/other_user}","gists_url":"https://api.github.com/users/berryzplus/gists{/gist_id}","starred_url":"https://api.github.com/users/berryzplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berryzplus/subscriptions","organizations_url":"https://api.github.com/users/berryzplus/orgs","repos_url":"https://api.github.com/users/berryzplus/repos","events_url":"https://api.github.com/users/berryzplus/events{/privacy}","received_events_url":"https://api.github.com/users/berryzplus/received_events","type":"User","site_admin":false},"html_url":"https://github.com/berryzplus/sakura","description":"A Japanese Text Editor. forked repository.","fork":true,"url":"https://api.github.com/repos/berryzplus/sakura","forks_url":"https://api.github.com/repos/berryzplus/sakura/forks","keys_url":"https://api.github.com/repos/berryzplus/sakura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/berryzplus/sakura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/berryzplus/sakura/teams","hooks_url":"https://api.github.com/repos/berryzplus/sakura/hooks","issue_events_url":"https://api.github.com/repos/berryzplus/sakura/issues/events{/number}","events_url":"https://api.github.com/repos/berryzplus/sakura/events","assignees_url":"https://api.github.com/repos/berryzplus/sakura/assignees{/user}","branches_url":"https://api.github.com/repos/berryzplus/sakura/branches{/branch}","tags_url":"https://api.github.com/repos/berryzplus/sakura/tags","blobs_url":"https://api.github.com/repos/berryzplus/sakura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/berryzplus/sakura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/berryzplus/sakura/git/refs{/sha}","trees_url":"https://api.github.com/repos/berryzplus/sakura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/berryzplus/sakura/statuses/{sha}","languages_url":"https://api.github.com/repos/berryzplus/sakura/languages","stargazers_url":"https://api.github.com/repos/berryzplus/sakura/stargazers","contributors_url":"https://api.github.com/repos/berryzplus/sakura/contributors","subscribers_url":"https://api.github.com/repos/berryzplus/sakura/subscribers","subscription_url":"https://api.github.com/repos/berryzplus/sakura/subscription","commits_url":"https://api.github.com/repos/berryzplus/sakura/commits{/sha}","git_commits_url":"https://api.github.com/repos/berryzplus/sakura/git/commits{/sha}","comments_url":"https://api.github.com/repos/berryzplus/sakura/comments{/number}","issue_comment_url":"https://api.github.com/repos/berryzplus/sakura/issues/comments{/number}","contents_url":"https://api.github.com/repos/berryzplus/sakura/contents/{+path}","compare_url":"https://api.github.com/repos/berryzplus/sakura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/berryzplus/sakura/merges","archive_url":"https://api.github.com/repos/berryzplus/sakura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/berryzplus/sakura/downloads","issues_url":"https://api.github.com/repos/berryzplus/sakura/issues{/number}","pulls_url":"https://api.github.com/repos/berryzplus/sakura/pulls{/number}","milestones_url":"https://api.github.com/repos/berryzplus/sakura/milestones{/number}","notifications_url":"https://api.github.com/repos/berryzplus/sakura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/berryzplus/sakura/labels{/name}","releases_url":"https://api.github.com/repos/berryzplus/sakura/releases{/id}","deployments_url":"https://api.github.com/repos/berryzplus/sakura/deployments","created_at":"2018-05-28T13:15:07Z","updated_at":"2018-10-10T13:33:09Z","pushed_at":"2019-05-05T13:17:44Z","git_url":"git://github.com/berryzplus/sakura.git","ssh_url":"[email protected]:berryzplus/sakura.git","clone_url":"https://github.com/berryzplus/sakura.git","svn_url":"https://github.com/berryzplus/sakura","homepage":"https://sakura-editor.github.io/","size":84800,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"feature/appveyor_test"}},"base":{"label":"sakura-editor:master","ref":"master","sha":"3de3153ad15a62fda270dfff3a199bd94be89110","user":{"login":"sakura-editor","id":39432189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDMyMTg5","avatar_url":"https://avatars3.githubusercontent.com/u/39432189?v=4","gravatar_id":"","url":"https://api.github.com/users/sakura-editor","html_url":"https://github.com/sakura-editor","followers_url":"https://api.github.com/users/sakura-editor/followers","following_url":"https://api.github.com/users/sakura-editor/following{/other_user}","gists_url":"https://api.github.com/users/sakura-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/sakura-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakura-editor/subscriptions","organizations_url":"https://api.github.com/users/sakura-editor/orgs","repos_url":"https://api.github.com/users/sakura-editor/repos","events_url":"https://api.github.com/users/sakura-editor/events{/privacy}","received_events_url":"https://api.github.com/users/sakura-editor/received_events","type":"Organization","site_admin":false},"repo":{"id":134057969,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQwNTc5Njk=","name":"sakura","full_name":"sakura-editor/sakura","private":false,"owner":{"login":"sakura-editor","id":39432189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDMyMTg5","avatar_url":"https://avatars3.githubusercontent.com/u/39432189?v=4","gravatar_id":"","url":"https://api.github.com/users/sakura-editor","html_url":"https://github.com/sakura-editor","followers_url":"https://api.github.com/users/sakura-editor/followers","following_url":"https://api.github.com/users/sakura-editor/following{/other_user}","gists_url":"https://api.github.com/users/sakura-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/sakura-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakura-editor/subscriptions","organizations_url":"https://api.github.com/users/sakura-editor/orgs","repos_url":"https://api.github.com/users/sakura-editor/repos","events_url":"https://api.github.com/users/sakura-editor/events{/privacy}","received_events_url":"https://api.github.com/users/sakura-editor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sakura-editor/sakura","description":"SAKURA Editor (Japanese text editor for MS Windows)","fork":false,"url":"https://api.github.com/repos/sakura-editor/sakura","forks_url":"https://api.github.com/repos/sakura-editor/sakura/forks","keys_url":"https://api.github.com/repos/sakura-editor/sakura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sakura-editor/sakura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sakura-editor/sakura/teams","hooks_url":"https://api.github.com/repos/sakura-editor/sakura/hooks","issue_events_url":"https://api.github.com/repos/sakura-editor/sakura/issues/events{/number}","events_url":"https://api.github.com/repos/sakura-editor/sakura/events","assignees_url":"https://api.github.com/repos/sakura-editor/sakura/assignees{/user}","branches_url":"https://api.github.com/repos/sakura-editor/sakura/branches{/branch}","tags_url":"https://api.github.com/repos/sakura-editor/sakura/tags","blobs_url":"https://api.github.com/repos/sakura-editor/sakura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sakura-editor/sakura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sakura-editor/sakura/git/refs{/sha}","trees_url":"https://api.github.com/repos/sakura-editor/sakura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sakura-editor/sakura/statuses/{sha}","languages_url":"https://api.github.com/repos/sakura-editor/sakura/languages","stargazers_url":"https://api.github.com/repos/sakura-editor/sakura/stargazers","contributors_url":"https://api.github.com/repos/sakura-editor/sakura/contributors","subscribers_url":"https://api.github.com/repos/sakura-editor/sakura/subscribers","subscription_url":"https://api.github.com/repos/sakura-editor/sakura/subscription","commits_url":"https://api.github.com/repos/sakura-editor/sakura/commits{/sha}","git_commits_url":"https://api.github.com/repos/sakura-editor/sakura/git/commits{/sha}","comments_url":"https://api.github.com/repos/sakura-editor/sakura/comments{/number}","issue_comment_url":"https://api.github.com/repos/sakura-editor/sakura/issues/comments{/number}","contents_url":"https://api.github.com/repos/sakura-editor/sakura/contents/{+path}","compare_url":"https://api.github.com/repos/sakura-editor/sakura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sakura-editor/sakura/merges","archive_url":"https://api.github.com/repos/sakura-editor/sakura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sakura-editor/sakura/downloads","issues_url":"https://api.github.com/repos/sakura-editor/sakura/issues{/number}","pulls_url":"https://api.github.com/repos/sakura-editor/sakura/pulls{/number}","milestones_url":"https://api.github.com/repos/sakura-editor/sakura/milestones{/number}","notifications_url":"https://api.github.com/repos/sakura-editor/sakura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sakura-editor/sakura/labels{/name}","releases_url":"https://api.github.com/repos/sakura-editor/sakura/releases{/id}","deployments_url":"https://api.github.com/repos/sakura-editor/sakura/deployments","created_at":"2018-05-19T12:02:06Z","updated_at":"2019-05-08T13:21:24Z","pushed_at":"2019-05-09T17:29:00Z","git_url":"git://github.com/sakura-editor/sakura.git","ssh_url":"[email protected]:sakura-editor/sakura.git","clone_url":"https://github.com/sakura-editor/sakura.git","svn_url":"https://github.com/sakura-editor/sakura","homepage":"https://sakura-editor.github.io/","size":84088,"stargazers_count":356,"watchers_count":356,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":203,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":40,"open_issues":203,"watchers":356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/898"},"html":{"href":"https://github.com/sakura-editor/sakura/pull/898"},"issue":{"href":"https://api.github.com/repos/sakura-editor/sakura/issues/898"},"comments":{"href":"https://api.github.com/repos/sakura-editor/sakura/issues/898/comments"},"review_comments":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/898/comments"},"review_comment":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/898/commits"},"statuses":{"href":"https://api.github.com/repos/sakura-editor/sakura/statuses/9312d4d7b50d48b0848aad0de01084d1ed0338bb"}},"author_association":"CONTRIBUTOR"}}	{ "id": 134057969, "name": "sakura-editor/sakura", "url": "https://api.github.com/repos/sakura-editor/sakura" }	{ "id": 1131125, "login": "beru", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/1131125?", "url": "https://api.github.com/users/beru" }	{ "id": 39432189, "login": "sakura-editor", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/39432189?", "url": "https://api.github.com/orgs/sakura-editor" }	2019-05-10T23:56:14	9605398224	{"actor":{"display_login":"beru"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/Neuraxio/Neuraxle/pulls/comments/336692663","pull_request_review_id":304159090,"id":336692663,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjY5MjY2Mw==","diff_hunk":"@@ -19,185 +19,442 @@\n limitations under the License.\n \n \"\"\"\n+\n import os\n import pickle\n-from abc import abstractmethod\n+from abc import abstractmethod, ABC\n+from typing import List, Tuple, Iterable\n \n-from neuraxle.base import ResumableStepMixin, BaseStep, DataContainer, ListDataContainer, DEFAULT_CACHE_FOLDER, \\\n- ExecutionContext\n+from neuraxle.base import ResumableMixin, BaseStep, DataContainer, ListDataContainer, ExecutionContext, \\\n+ ExecutionMode\n \n \n-class BaseCheckpointStep(ResumableStepMixin, BaseStep):\n- \"\"\"\n- Base class for a checkpoint step that can persists the received data inputs, and expected_outputs\n- to eventually be able to load them using the checkpoint pipeline runner.\n+class BaseCheckpointer(ResumableMixin):\n \"\"\"\n+ Base class to implement a step checkpoint or data container checkpoint.\n \n- def __init__(self, force_checkpoint_name: str = None):\n- ResumableStepMixin.__init__(self)\n- BaseStep.__init__(self)\n- self.force_checkpoint_name = force_checkpoint_name\n-\n- def handle_fit(self, data_container: DataContainer, context: ExecutionContext) -> ('BaseStep', DataContainer):\n- data_container = self._handle_any(context, data_container)\n- return self, data_container\n+ Checkpoint step uses many BaseCheckpointer to checkpoint both data container checkpoints, and step checkpoints.\n \n- def handle_transform(self, data_container: DataContainer, context: ExecutionContext) -> DataContainer:\n- data_container = self._handle_any(context, data_container)\n- return data_container\n+ BaseCheckpointer has an execution mode so there could be different checkpoints for each execution mode (fit, fit_transform or transform).\n+ \"\"\"\n+ def __init__(\n+ self,\n+ execution_mode: ExecutionMode\n+ ):\n+ self.execution_mode = execution_mode\n \n- def handle_fit_transform(self, data_container: DataContainer, context: ExecutionContext) -> ('BaseStep', DataContainer):\n- data_container = self._handle_any(context, data_container)\n- return self, data_container\n+ def is_for_execution_mode(self, execution_mode) -> bool:\n+ \"\"\"\n+ Returns true if the checkpointer should be used with the given execution mode.\n \n- def _handle_any(self, context, data_container):\n- self.set_checkpoint_path(context.get_path())\n- data_container: DataContainer = self.save_checkpoint(data_container)\n+ :param execution_mode: execution mode (fit, fit_transform, or transform)\n+ :return: if the checkpointer should be used\n+ :rtype: bool\n+ \"\"\"\n+ if execution_mode == ExecutionMode.FIT:\n+ return self.execution_mode == ExecutionMode.FIT or \\\n+ self.execution_mode == ExecutionMode.FIT_OR_FIT_TRANSFORM\n \n- self.save_checkpoint(data_container)\n- context.save_all_unsaved()\n+ if execution_mode == ExecutionMode.FIT_TRANSFORM:\n+ return self.execution_mode == ExecutionMode.FIT_TRANSFORM or \\\n+ self.execution_mode == ExecutionMode.FIT_OR_FIT_TRANSFORM\n \n- return data_container\n+ if execution_mode == ExecutionMode.FIT:\n+ return self.execution_mode == ExecutionMode.FIT or \\\n+ self.execution_mode == ExecutionMode.FIT_OR_FIT_TRANSFORM\n \n- def fit(self, data_inputs, expected_outputs=None) -> 'BaseCheckpointStep':\n+ @abstractmethod\n+ def save_checkpoint(self, data_container: DataContainer, context: ExecutionContext) -> DataContainer:\n \"\"\"\n- Save checkpoint for data inputs and expected outputs so that it can\n- be loaded by the checkpoint pipeline runner on the next pipeline run\n+ Save the data container or fitted step checkpoint with the given data container, and context.\n+ Returns the data container checkpoint, or latest data container.\n \n- :param expected_outputs: initial expected outputs of pipeline to load checkpoint from\n- :param data_inputs: data inputs to save\n- :return: self\n+ :param data_container: data container to save data container or fitted steps\n+ :param context: context to save data container or fitted steps\n+ :return: saved data container\n+ :rtype: DataContainer\n \"\"\"\n- return self\n+ raise NotImplementedError()\n \n- def transform(self, data_inputs):\n+ @abstractmethod\n+ def read_checkpoint(self, data_container: DataContainer, context: ExecutionContext) -> DataContainer:\n \"\"\"\n- Save checkpoint for data inputs and expected outputs so that it can\n- be loaded by the checkpoint pipeline runner on the next pipeline run\n-\n- :param data_inputs: data inputs to save\n- :return: data_inputs\n+ Read the data container checkpoint with self.data_checkpointer.\n+ Returns a new data container loaded with all the data inputs,\n+ and expected outputs for each current id in the given data container.\n+\n+ :param data_container: data container containing the current_ids to read checkpoint for\n+ :param context: context to read checkpoint for\n+ :return: the data container checkpoint\n+ :rtype: DataContainer\n \"\"\"\n- return data_inputs\n+ raise NotImplementedError()\n+\n+class StepCheckpointer(BaseCheckpointer):\n+ \"\"\"\n+ StepCheckpointer is used by the Checkpoint step to save the fitted steps contained in the context of type ExecutionContext.\n+\n+ By default, StepCheckpointer saves the fitted steps when the execution mode is either FIT, or FIT_TRANSFORM :\n+ ```\n+ StepCheckpointer(ExecutionMode.FIT_OR_FIT_TRANSFORM)\n+\n+ # is equivalent to :\n+\n+ StepCheckpointer()\n+ ```\n+ \"\"\"\n+ def __init__(\n+ self,\n+ execution_mode: ExecutionMode = ExecutionMode.FIT_OR_FIT_TRANSFORM,\n+ ):\n+ BaseCheckpointer.__init__(self, execution_mode=execution_mode)\n+\n+ def save_checkpoint(\n+ self,\n+ data_container: DataContainer,\n+ context: ExecutionContext\n+ ) -> DataContainer:\n+ # TODO: save the context by execution mode AND data container ids / summary\n+ context.save_all_unsaved()\n+ return data_container\n+\n+ def should_resume(self, data_container: DataContainer, context: ExecutionContext) -> bool:\n+ # TODO: change this when we support multiple execution modes and data container ids / summary\n+ return True\n+\n+\n+class BaseDataContainerSaver(ABC):\n \n @abstractmethod\n- def set_checkpoint_path(self, path):\n+ def get_checkpoint_file_path(self, checkpoint_path: str, current_id) -> str:","path":"neuraxle/checkpoints.py","position":153,"original_position":153,"commit_id":"14ce2e65706d41b95ab248eff5c062c5a508b87c","original_commit_id":"677d2571c64e540a7f719fc44a541192f670aada","user":{"login":"alexbrillant","id":19400226,"node_id":"MDQ6VXNlcjE5NDAwMjI2","avatar_url":"https://avatars2.githubusercontent.com/u/19400226?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbrillant","html_url":"https://github.com/alexbrillant","followers_url":"https://api.github.com/users/alexbrillant/followers","following_url":"https://api.github.com/users/alexbrillant/following{/other_user}","gists_url":"https://api.github.com/users/alexbrillant/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbrillant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbrillant/subscriptions","organizations_url":"https://api.github.com/users/alexbrillant/orgs","repos_url":"https://api.github.com/users/alexbrillant/repos","events_url":"https://api.github.com/users/alexbrillant/events{/privacy}","received_events_url":"https://api.github.com/users/alexbrillant/received_events","type":"User","site_admin":false},"body":"@guillaume-chevalier ?","created_at":"2019-10-18T22:08:49Z","updated_at":"2019-10-18T22:08:50Z","html_url":"https://github.com/Neuraxio/Neuraxle/pull/116#discussion_r336692663","pull_request_url":"https://api.github.com/repos/Neuraxio/Neuraxle/pulls/116","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Neuraxio/Neuraxle/pulls/comments/336692663"},"html":{"href":"https://github.com/Neuraxio/Neuraxle/pull/116#discussion_r336692663"},"pull_request":{"href":"https://api.github.com/repos/Neuraxio/Neuraxle/pulls/116"}},"in_reply_to_id":336681199},"pull_request":{"url":"https://api.github.com/repos/Neuraxio/Neuraxle/pulls/116","id":329918911,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5OTE4OTEx","html_url":"https://github.com/Neuraxio/Neuraxle/pull/116","diff_url":"https://github.com/Neuraxio/Neuraxle/pull/116.diff","patch_url":"https://github.com/Neuraxio/Neuraxle/pull/116.patch","issue_url":"https://api.github.com/repos/Neuraxio/Neuraxle/issues/116","number":116,"state":"open","locked":false,"title":"(WIP) Implement DataContainer Checkpointers, And Fitted Steps Checkpointers For Better Checkpoints","user":{"login":"alexbrillant","id":19400226,"node_id":"MDQ6VXNlcjE5NDAwMjI2","avatar_url":"https://avatars2.githubusercontent.com/u/19400226?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbrillant","html_url":"https://github.com/alexbrillant","followers_url":"https://api.github.com/users/alexbrillant/followers","following_url":"https://api.github.com/users/alexbrillant/following{/other_user}","gists_url":"https://api.github.com/users/alexbrillant/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbrillant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbrillant/subscriptions","organizations_url":"https://api.github.com/users/alexbrillant/orgs","repos_url":"https://api.github.com/users/alexbrillant/repos","events_url":"https://api.github.com/users/alexbrillant/events{/privacy}","received_events_url":"https://api.github.com/users/alexbrillant/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-18T20:49:37Z","updated_at":"2019-10-18T22:08:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6fc7d1025938a947140b7bd679530a50eda682f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Vaunorage","id":10731763,"node_id":"MDQ6VXNlcjEwNzMxNzYz","avatar_url":"https://avatars2.githubusercontent.com/u/10731763?v=4","gravatar_id":"","url":"https://api.github.com/users/Vaunorage","html_url":"https://github.com/Vaunorage","followers_url":"https://api.github.com/users/Vaunorage/followers","following_url":"https://api.github.com/users/Vaunorage/following{/other_user}","gists_url":"https://api.github.com/users/Vaunorage/gists{/gist_id}","starred_url":"https://api.github.com/users/Vaunorage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vaunorage/subscriptions","organizations_url":"https://api.github.com/users/Vaunorage/orgs","repos_url":"https://api.github.com/users/Vaunorage/repos","events_url":"https://api.github.com/users/Vaunorage/events{/privacy}","received_events_url":"https://api.github.com/users/Vaunorage/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1291101636,"node_id":"MDU6TGFiZWwxMjkxMTAxNjM2","url":"https://api.github.com/repos/Neuraxio/Neuraxle/labels/cla-signed","name":"cla-signed","color":"ededed","default":false},{"id":1290971223,"node_id":"MDU6TGFiZWwxMjkwOTcxMjIz","url":"https://api.github.com/repos/Neuraxio/Neuraxle/labels/help%20wanted","name":"help wanted","color":"008672","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/Neuraxio/Neuraxle/pulls/116/commits","review_comments_url":"https://api.github.com/repos/Neuraxio/Neuraxle/pulls/116/comments","review_comment_url":"https://api.github.com/repos/Neuraxio/Neuraxle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Neuraxio/Neuraxle/issues/116/comments","statuses_url":"https://api.github.com/repos/Neuraxio/Neuraxle/statuses/14ce2e65706d41b95ab248eff5c062c5a508b87c","head":{"label":"alexbrillant:wip-different-checkpoints-expected-outputs","ref":"wip-different-checkpoints-expected-outputs","sha":"14ce2e65706d41b95ab248eff5c062c5a508b87c","user":{"login":"alexbrillant","id":19400226,"node_id":"MDQ6VXNlcjE5NDAwMjI2","avatar_url":"https://avatars2.githubusercontent.com/u/19400226?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbrillant","html_url":"https://github.com/alexbrillant","followers_url":"https://api.github.com/users/alexbrillant/followers","following_url":"https://api.github.com/users/alexbrillant/following{/other_user}","gists_url":"https://api.github.com/users/alexbrillant/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbrillant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbrillant/subscriptions","organizations_url":"https://api.github.com/users/alexbrillant/orgs","repos_url":"https://api.github.com/users/alexbrillant/repos","events_url":"https://api.github.com/users/alexbrillant/events{/privacy}","received_events_url":"https://api.github.com/users/alexbrillant/received_events","type":"User","site_admin":false},"repo":{"id":191046250,"node_id":"MDEwOlJlcG9zaXRvcnkxOTEwNDYyNTA=","name":"Neuraxle","full_name":"alexbrillant/Neuraxle","private":false,"owner":{"login":"alexbrillant","id":19400226,"node_id":"MDQ6VXNlcjE5NDAwMjI2","avatar_url":"https://avatars2.githubusercontent.com/u/19400226?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbrillant","html_url":"https://github.com/alexbrillant","followers_url":"https://api.github.com/users/alexbrillant/followers","following_url":"https://api.github.com/users/alexbrillant/following{/other_user}","gists_url":"https://api.github.com/users/alexbrillant/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbrillant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbrillant/subscriptions","organizations_url":"https://api.github.com/users/alexbrillant/orgs","repos_url":"https://api.github.com/users/alexbrillant/repos","events_url":"https://api.github.com/users/alexbrillant/events{/privacy}","received_events_url":"https://api.github.com/users/alexbrillant/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alexbrillant/Neuraxle","description":"Code Machine Learning Pipelines - The Right Way. ","fork":true,"url":"https://api.github.com/repos/alexbrillant/Neuraxle","forks_url":"https://api.github.com/repos/alexbrillant/Neuraxle/forks","keys_url":"https://api.github.com/repos/alexbrillant/Neuraxle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexbrillant/Neuraxle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexbrillant/Neuraxle/teams","hooks_url":"https://api.github.com/repos/alexbrillant/Neuraxle/hooks","issue_events_url":"https://api.github.com/repos/alexbrillant/Neuraxle/issues/events{/number}","events_url":"https://api.github.com/repos/alexbrillant/Neuraxle/events","assignees_url":"https://api.github.com/repos/alexbrillant/Neuraxle/assignees{/user}","branches_url":"https://api.github.com/repos/alexbrillant/Neuraxle/branches{/branch}","tags_url":"https://api.github.com/repos/alexbrillant/Neuraxle/tags","blobs_url":"https://api.github.com/repos/alexbrillant/Neuraxle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexbrillant/Neuraxle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexbrillant/Neuraxle/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexbrillant/Neuraxle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexbrillant/Neuraxle/statuses/{sha}","languages_url":"https://api.github.com/repos/alexbrillant/Neuraxle/languages","stargazers_url":"https://api.github.com/repos/alexbrillant/Neuraxle/stargazers","contributors_url":"https://api.github.com/repos/alexbrillant/Neuraxle/contributors","subscribers_url":"https://api.github.com/repos/alexbrillant/Neuraxle/subscribers","subscription_url":"https://api.github.com/repos/alexbrillant/Neuraxle/subscription","commits_url":"https://api.github.com/repos/alexbrillant/Neuraxle/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexbrillant/Neuraxle/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexbrillant/Neuraxle/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexbrillant/Neuraxle/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexbrillant/Neuraxle/contents/{+path}","compare_url":"https://api.github.com/repos/alexbrillant/Neuraxle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexbrillant/Neuraxle/merges","archive_url":"https://api.github.com/repos/alexbrillant/Neuraxle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexbrillant/Neuraxle/downloads","issues_url":"https://api.github.com/repos/alexbrillant/Neuraxle/issues{/number}","pulls_url":"https://api.github.com/repos/alexbrillant/Neuraxle/pulls{/number}","milestones_url":"https://api.github.com/repos/alexbrillant/Neuraxle/milestones{/number}","notifications_url":"https://api.github.com/repos/alexbrillant/Neuraxle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexbrillant/Neuraxle/labels{/name}","releases_url":"https://api.github.com/repos/alexbrillant/Neuraxle/releases{/id}","deployments_url":"https://api.github.com/repos/alexbrillant/Neuraxle/deployments","created_at":"2019-06-09T19:24:31Z","updated_at":"2019-09-17T20:13:34Z","pushed_at":"2019-10-18T21:45:22Z","git_url":"git://github.com/alexbrillant/Neuraxle.git","ssh_url":"[email protected]:alexbrillant/Neuraxle.git","clone_url":"https://github.com/alexbrillant/Neuraxle.git","svn_url":"https://github.com/alexbrillant/Neuraxle","homepage":"http://neuraxle.neuraxio.com","size":1353,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"Neuraxio:dev","ref":"dev","sha":"d4e8f927a99f05d8a7777c889e174783946d9b2f","user":{"login":"Neuraxio","id":39544082,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NTQ0MDgy","avatar_url":"https://avatars2.githubusercontent.com/u/39544082?v=4","gravatar_id":"","url":"https://api.github.com/users/Neuraxio","html_url":"https://github.com/Neuraxio","followers_url":"https://api.github.com/users/Neuraxio/followers","following_url":"https://api.github.com/users/Neuraxio/following{/other_user}","gists_url":"https://api.github.com/users/Neuraxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Neuraxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neuraxio/subscriptions","organizations_url":"https://api.github.com/users/Neuraxio/orgs","repos_url":"https://api.github.com/users/Neuraxio/repos","events_url":"https://api.github.com/users/Neuraxio/events{/privacy}","received_events_url":"https://api.github.com/users/Neuraxio/received_events","type":"Organization","site_admin":false},"repo":{"id":177868131,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc4NjgxMzE=","name":"Neuraxle","full_name":"Neuraxio/Neuraxle","private":false,"owner":{"login":"Neuraxio","id":39544082,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NTQ0MDgy","avatar_url":"https://avatars2.githubusercontent.com/u/39544082?v=4","gravatar_id":"","url":"https://api.github.com/users/Neuraxio","html_url":"https://github.com/Neuraxio","followers_url":"https://api.github.com/users/Neuraxio/followers","following_url":"https://api.github.com/users/Neuraxio/following{/other_user}","gists_url":"https://api.github.com/users/Neuraxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Neuraxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neuraxio/subscriptions","organizations_url":"https://api.github.com/users/Neuraxio/orgs","repos_url":"https://api.github.com/users/Neuraxio/repos","events_url":"https://api.github.com/users/Neuraxio/events{/privacy}","received_events_url":"https://api.github.com/users/Neuraxio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Neuraxio/Neuraxle","description":"Build neat pipelines with the right abstractions to do AutoML. Let your pipeline steps have hyperparameter spaces. Enable checkpoints to cut duplicate calculations. Go from research to production environment easily.","fork":false,"url":"https://api.github.com/repos/Neuraxio/Neuraxle","forks_url":"https://api.github.com/repos/Neuraxio/Neuraxle/forks","keys_url":"https://api.github.com/repos/Neuraxio/Neuraxle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Neuraxio/Neuraxle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Neuraxio/Neuraxle/teams","hooks_url":"https://api.github.com/repos/Neuraxio/Neuraxle/hooks","issue_events_url":"https://api.github.com/repos/Neuraxio/Neuraxle/issues/events{/number}","events_url":"https://api.github.com/repos/Neuraxio/Neuraxle/events","assignees_url":"https://api.github.com/repos/Neuraxio/Neuraxle/assignees{/user}","branches_url":"https://api.github.com/repos/Neuraxio/Neuraxle/branches{/branch}","tags_url":"https://api.github.com/repos/Neuraxio/Neuraxle/tags","blobs_url":"https://api.github.com/repos/Neuraxio/Neuraxle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Neuraxio/Neuraxle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Neuraxio/Neuraxle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Neuraxio/Neuraxle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Neuraxio/Neuraxle/statuses/{sha}","languages_url":"https://api.github.com/repos/Neuraxio/Neuraxle/languages","stargazers_url":"https://api.github.com/repos/Neuraxio/Neuraxle/stargazers","contributors_url":"https://api.github.com/repos/Neuraxio/Neuraxle/contributors","subscribers_url":"https://api.github.com/repos/Neuraxio/Neuraxle/subscribers","subscription_url":"https://api.github.com/repos/Neuraxio/Neuraxle/subscription","commits_url":"https://api.github.com/repos/Neuraxio/Neuraxle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Neuraxio/Neuraxle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Neuraxio/Neuraxle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Neuraxio/Neuraxle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Neuraxio/Neuraxle/contents/{+path}","compare_url":"https://api.github.com/repos/Neuraxio/Neuraxle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Neuraxio/Neuraxle/merges","archive_url":"https://api.github.com/repos/Neuraxio/Neuraxle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Neuraxio/Neuraxle/downloads","issues_url":"https://api.github.com/repos/Neuraxio/Neuraxle/issues{/number}","pulls_url":"https://api.github.com/repos/Neuraxio/Neuraxle/pulls{/number}","milestones_url":"https://api.github.com/repos/Neuraxio/Neuraxle/milestones{/number}","notifications_url":"https://api.github.com/repos/Neuraxio/Neuraxle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Neuraxio/Neuraxle/labels{/name}","releases_url":"https://api.github.com/repos/Neuraxio/Neuraxle/releases{/id}","deployments_url":"https://api.github.com/repos/Neuraxio/Neuraxle/deployments","created_at":"2019-03-26T21:01:54Z","updated_at":"2019-10-18T21:00:14Z","pushed_at":"2019-10-18T21:45:24Z","git_url":"git://github.com/Neuraxio/Neuraxle.git","ssh_url":"[email protected]:Neuraxio/Neuraxle.git","clone_url":"https://github.com/Neuraxio/Neuraxle.git","svn_url":"https://github.com/Neuraxio/Neuraxle","homepage":"https://www.neuraxle.neuraxio.com/stable/index.html","size":1288,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":38,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":38,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Neuraxio/Neuraxle/pulls/116"},"html":{"href":"https://github.com/Neuraxio/Neuraxle/pull/116"},"issue":{"href":"https://api.github.com/repos/Neuraxio/Neuraxle/issues/116"},"comments":{"href":"https://api.github.com/repos/Neuraxio/Neuraxle/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/Neuraxio/Neuraxle/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/Neuraxio/Neuraxle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Neuraxio/Neuraxle/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/Neuraxio/Neuraxle/statuses/14ce2e65706d41b95ab248eff5c062c5a508b87c"}},"author_association":"MEMBER"}}	{ "id": 177868131, "name": "Neuraxio/Neuraxle", "url": "https://api.github.com/repos/Neuraxio/Neuraxle" }	{ "id": 19400226, "login": "alexbrillant", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/19400226?", "url": "https://api.github.com/users/alexbrillant" }	{ "id": 39544082, "login": "Neuraxio", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/39544082?", "url": "https://api.github.com/orgs/Neuraxio" }	2019-10-18T22:08:49	10665587029	{"actor":{"display_login":"alexbrillant"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/iterative/dvc.org/pulls/comments/309983239","pull_request_review_id":269986258,"id":309983239,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwOTk4MzIzOQ==","diff_hunk":"@@ -65,4 +65,10 @@ $ cat .dvc/config\n ...\n ```\n \n+> Avoid using the same remote that you are using for `dvc push`, `dvc pull`,","path":"static/docs/commands-reference/cache_dir.md","position":4,"original_position":4,"commit_id":"0b5a9e276d7ea8565ac8b77716237fa740509f94","original_commit_id":"0b5a9e276d7ea8565ac8b77716237fa740509f94","user":{"login":"shcheklein","id":3659196,"node_id":"MDQ6VXNlcjM2NTkxOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3659196?v=4","gravatar_id":"","url":"https://api.github.com/users/shcheklein","html_url":"https://github.com/shcheklein","followers_url":"https://api.github.com/users/shcheklein/followers","following_url":"https://api.github.com/users/shcheklein/following{/other_user}","gists_url":"https://api.github.com/users/shcheklein/gists{/gist_id}","starred_url":"https://api.github.com/users/shcheklein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shcheklein/subscriptions","organizations_url":"https://api.github.com/users/shcheklein/orgs","repos_url":"https://api.github.com/users/shcheklein/repos","events_url":"https://api.github.com/users/shcheklein/events{/privacy}","received_events_url":"https://api.github.com/users/shcheklein/received_events","type":"User","site_admin":false},"body":"not need to put this note here, let's not complicate it","created_at":"2019-08-02T05:08:26Z","updated_at":"2019-08-02T05:08:27Z","html_url":"https://github.com/iterative/dvc.org/pull/517#discussion_r309983239","pull_request_url":"https://api.github.com/repos/iterative/dvc.org/pulls/517","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/iterative/dvc.org/pulls/comments/309983239"},"html":{"href":"https://github.com/iterative/dvc.org/pull/517#discussion_r309983239"},"pull_request":{"href":"https://api.github.com/repos/iterative/dvc.org/pulls/517"}}},"pull_request":{"url":"https://api.github.com/repos/iterative/dvc.org/pulls/517","id":303098196,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAzMDk4MTk2","html_url":"https://github.com/iterative/dvc.org/pull/517","diff_url":"https://github.com/iterative/dvc.org/pull/517.diff","patch_url":"https://github.com/iterative/dvc.org/pull/517.patch","issue_url":"https://api.github.com/repos/iterative/dvc.org/issues/517","number":517,"state":"open","locked":false,"title":"note about using the same remote as ext cache and for push/pull","user":{"login":"ryokugyu","id":16274905,"node_id":"MDQ6VXNlcjE2Mjc0OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/16274905?v=4","gravatar_id":"","url":"https://api.github.com/users/ryokugyu","html_url":"https://github.com/ryokugyu","followers_url":"https://api.github.com/users/ryokugyu/followers","following_url":"https://api.github.com/users/ryokugyu/following{/other_user}","gists_url":"https://api.github.com/users/ryokugyu/gists{/gist_id}","starred_url":"https://api.github.com/users/ryokugyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryokugyu/subscriptions","organizations_url":"https://api.github.com/users/ryokugyu/orgs","repos_url":"https://api.github.com/users/ryokugyu/repos","events_url":"https://api.github.com/users/ryokugyu/events{/privacy}","received_events_url":"https://api.github.com/users/ryokugyu/received_events","type":"User","site_admin":false},"body":"Fix #516 ","created_at":"2019-07-31T19:40:54Z","updated_at":"2019-08-02T05:08:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5eff751c801ecf6e77d3726e9609aad2db68de12","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iterative/dvc.org/pulls/517/commits","review_comments_url":"https://api.github.com/repos/iterative/dvc.org/pulls/517/comments","review_comment_url":"https://api.github.com/repos/iterative/dvc.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iterative/dvc.org/issues/517/comments","statuses_url":"https://api.github.com/repos/iterative/dvc.org/statuses/0b5a9e276d7ea8565ac8b77716237fa740509f94","head":{"label":"ryokugyu:fix#516","ref":"fix#516","sha":"0b5a9e276d7ea8565ac8b77716237fa740509f94","user":{"login":"ryokugyu","id":16274905,"node_id":"MDQ6VXNlcjE2Mjc0OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/16274905?v=4","gravatar_id":"","url":"https://api.github.com/users/ryokugyu","html_url":"https://github.com/ryokugyu","followers_url":"https://api.github.com/users/ryokugyu/followers","following_url":"https://api.github.com/users/ryokugyu/following{/other_user}","gists_url":"https://api.github.com/users/ryokugyu/gists{/gist_id}","starred_url":"https://api.github.com/users/ryokugyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryokugyu/subscriptions","organizations_url":"https://api.github.com/users/ryokugyu/orgs","repos_url":"https://api.github.com/users/ryokugyu/repos","events_url":"https://api.github.com/users/ryokugyu/events{/privacy}","received_events_url":"https://api.github.com/users/ryokugyu/received_events","type":"User","site_admin":false},"repo":{"id":193421127,"node_id":"MDEwOlJlcG9zaXRvcnkxOTM0MjExMjc=","name":"dvc.org","full_name":"ryokugyu/dvc.org","private":false,"owner":{"login":"ryokugyu","id":16274905,"node_id":"MDQ6VXNlcjE2Mjc0OTA1","avatar_url":"https://avatars1.githubusercontent.com/u/16274905?v=4","gravatar_id":"","url":"https://api.github.com/users/ryokugyu","html_url":"https://github.com/ryokugyu","followers_url":"https://api.github.com/users/ryokugyu/followers","following_url":"https://api.github.com/users/ryokugyu/following{/other_user}","gists_url":"https://api.github.com/users/ryokugyu/gists{/gist_id}","starred_url":"https://api.github.com/users/ryokugyu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryokugyu/subscriptions","organizations_url":"https://api.github.com/users/ryokugyu/orgs","repos_url":"https://api.github.com/users/ryokugyu/repos","events_url":"https://api.github.com/users/ryokugyu/events{/privacy}","received_events_url":"https://api.github.com/users/ryokugyu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ryokugyu/dvc.org","description":"🔗 DVC website and documentation","fork":true,"url":"https://api.github.com/repos/ryokugyu/dvc.org","forks_url":"https://api.github.com/repos/ryokugyu/dvc.org/forks","keys_url":"https://api.github.com/repos/ryokugyu/dvc.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ryokugyu/dvc.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ryokugyu/dvc.org/teams","hooks_url":"https://api.github.com/repos/ryokugyu/dvc.org/hooks","issue_events_url":"https://api.github.com/repos/ryokugyu/dvc.org/issues/events{/number}","events_url":"https://api.github.com/repos/ryokugyu/dvc.org/events","assignees_url":"https://api.github.com/repos/ryokugyu/dvc.org/assignees{/user}","branches_url":"https://api.github.com/repos/ryokugyu/dvc.org/branches{/branch}","tags_url":"https://api.github.com/repos/ryokugyu/dvc.org/tags","blobs_url":"https://api.github.com/repos/ryokugyu/dvc.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ryokugyu/dvc.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ryokugyu/dvc.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/ryokugyu/dvc.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ryokugyu/dvc.org/statuses/{sha}","languages_url":"https://api.github.com/repos/ryokugyu/dvc.org/languages","stargazers_url":"https://api.github.com/repos/ryokugyu/dvc.org/stargazers","contributors_url":"https://api.github.com/repos/ryokugyu/dvc.org/contributors","subscribers_url":"https://api.github.com/repos/ryokugyu/dvc.org/subscribers","subscription_url":"https://api.github.com/repos/ryokugyu/dvc.org/subscription","commits_url":"https://api.github.com/repos/ryokugyu/dvc.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/ryokugyu/dvc.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/ryokugyu/dvc.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/ryokugyu/dvc.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/ryokugyu/dvc.org/contents/{+path}","compare_url":"https://api.github.com/repos/ryokugyu/dvc.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ryokugyu/dvc.org/merges","archive_url":"https://api.github.com/repos/ryokugyu/dvc.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ryokugyu/dvc.org/downloads","issues_url":"https://api.github.com/repos/ryokugyu/dvc.org/issues{/number}","pulls_url":"https://api.github.com/repos/ryokugyu/dvc.org/pulls{/number}","milestones_url":"https://api.github.com/repos/ryokugyu/dvc.org/milestones{/number}","notifications_url":"https://api.github.com/repos/ryokugyu/dvc.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ryokugyu/dvc.org/labels{/name}","releases_url":"https://api.github.com/repos/ryokugyu/dvc.org/releases{/id}","deployments_url":"https://api.github.com/repos/ryokugyu/dvc.org/deployments","created_at":"2019-06-24T02:35:51Z","updated_at":"2019-07-30T05:08:05Z","pushed_at":"2019-08-02T04:57:11Z","git_url":"git://github.com/ryokugyu/dvc.org.git","ssh_url":"[email protected]:ryokugyu/dvc.org.git","clone_url":"https://github.com/ryokugyu/dvc.org.git","svn_url":"https://github.com/ryokugyu/dvc.org","homepage":"https://dvc.org","size":11769,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iterative:master","ref":"master","sha":"cc48cd2f246b61b3cead2a541e2a1ac5eaa86a6a","user":{"login":"iterative","id":39572954,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NTcyOTU0","avatar_url":"https://avatars1.githubusercontent.com/u/39572954?v=4","gravatar_id":"","url":"https://api.github.com/users/iterative","html_url":"https://github.com/iterative","followers_url":"https://api.github.com/users/iterative/followers","following_url":"https://api.github.com/users/iterative/following{/other_user}","gists_url":"https://api.github.com/users/iterative/gists{/gist_id}","starred_url":"https://api.github.com/users/iterative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iterative/subscriptions","organizations_url":"https://api.github.com/users/iterative/orgs","repos_url":"https://api.github.com/users/iterative/repos","events_url":"https://api.github.com/users/iterative/events{/privacy}","received_events_url":"https://api.github.com/users/iterative/received_events","type":"Organization","site_admin":false},"repo":{"id":135934107,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU5MzQxMDc=","name":"dvc.org","full_name":"iterative/dvc.org","private":false,"owner":{"login":"iterative","id":39572954,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NTcyOTU0","avatar_url":"https://avatars1.githubusercontent.com/u/39572954?v=4","gravatar_id":"","url":"https://api.github.com/users/iterative","html_url":"https://github.com/iterative","followers_url":"https://api.github.com/users/iterative/followers","following_url":"https://api.github.com/users/iterative/following{/other_user}","gists_url":"https://api.github.com/users/iterative/gists{/gist_id}","starred_url":"https://api.github.com/users/iterative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iterative/subscriptions","organizations_url":"https://api.github.com/users/iterative/orgs","repos_url":"https://api.github.com/users/iterative/repos","events_url":"https://api.github.com/users/iterative/events{/privacy}","received_events_url":"https://api.github.com/users/iterative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iterative/dvc.org","description":"🔗 DVC website and documentation","fork":false,"url":"https://api.github.com/repos/iterative/dvc.org","forks_url":"https://api.github.com/repos/iterative/dvc.org/forks","keys_url":"https://api.github.com/repos/iterative/dvc.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iterative/dvc.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iterative/dvc.org/teams","hooks_url":"https://api.github.com/repos/iterative/dvc.org/hooks","issue_events_url":"https://api.github.com/repos/iterative/dvc.org/issues/events{/number}","events_url":"https://api.github.com/repos/iterative/dvc.org/events","assignees_url":"https://api.github.com/repos/iterative/dvc.org/assignees{/user}","branches_url":"https://api.github.com/repos/iterative/dvc.org/branches{/branch}","tags_url":"https://api.github.com/repos/iterative/dvc.org/tags","blobs_url":"https://api.github.com/repos/iterative/dvc.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iterative/dvc.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iterative/dvc.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/iterative/dvc.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iterative/dvc.org/statuses/{sha}","languages_url":"https://api.github.com/repos/iterative/dvc.org/languages","stargazers_url":"https://api.github.com/repos/iterative/dvc.org/stargazers","contributors_url":"https://api.github.com/repos/iterative/dvc.org/contributors","subscribers_url":"https://api.github.com/repos/iterative/dvc.org/subscribers","subscription_url":"https://api.github.com/repos/iterative/dvc.org/subscription","commits_url":"https://api.github.com/repos/iterative/dvc.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/iterative/dvc.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/iterative/dvc.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/iterative/dvc.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/iterative/dvc.org/contents/{+path}","compare_url":"https://api.github.com/repos/iterative/dvc.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iterative/dvc.org/merges","archive_url":"https://api.github.com/repos/iterative/dvc.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iterative/dvc.org/downloads","issues_url":"https://api.github.com/repos/iterative/dvc.org/issues{/number}","pulls_url":"https://api.github.com/repos/iterative/dvc.org/pulls{/number}","milestones_url":"https://api.github.com/repos/iterative/dvc.org/milestones{/number}","notifications_url":"https://api.github.com/repos/iterative/dvc.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iterative/dvc.org/labels{/name}","releases_url":"https://api.github.com/repos/iterative/dvc.org/releases{/id}","deployments_url":"https://api.github.com/repos/iterative/dvc.org/deployments","created_at":"2018-06-03T19:30:51Z","updated_at":"2019-08-01T23:07:45Z","pushed_at":"2019-08-02T04:57:13Z","git_url":"git://github.com/iterative/dvc.org.git","ssh_url":"[email protected]:iterative/dvc.org.git","clone_url":"https://github.com/iterative/dvc.org.git","svn_url":"https://github.com/iterative/dvc.org","homepage":"https://dvc.org","size":11892,"stargazers_count":62,"watchers_count":62,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":79,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":79,"open_issues":79,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iterative/dvc.org/pulls/517"},"html":{"href":"https://github.com/iterative/dvc.org/pull/517"},"issue":{"href":"https://api.github.com/repos/iterative/dvc.org/issues/517"},"comments":{"href":"https://api.github.com/repos/iterative/dvc.org/issues/517/comments"},"review_comments":{"href":"https://api.github.com/repos/iterative/dvc.org/pulls/517/comments"},"review_comment":{"href":"https://api.github.com/repos/iterative/dvc.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iterative/dvc.org/pulls/517/commits"},"statuses":{"href":"https://api.github.com/repos/iterative/dvc.org/statuses/0b5a9e276d7ea8565ac8b77716237fa740509f94"}},"author_association":"CONTRIBUTOR"}}	{ "id": 135934107, "name": "iterative/dvc.org", "url": "https://api.github.com/repos/iterative/dvc.org" }	{ "id": 3659196, "login": "shcheklein", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/3659196?", "url": "https://api.github.com/users/shcheklein" }	{ "id": 39572954, "login": "iterative", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/39572954?", "url": "https://api.github.com/orgs/iterative" }	2019-08-02T05:08:26	10133802611	{"actor":{"display_login":"shcheklein"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/thesofproject/sof/pulls/comments/319041412","pull_request_review_id":281420578,"id":319041412,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxOTA0MTQxMg==","diff_hunk":"@@ -44,7 +44,8 @@ enum pm_runtime_context {\n \tSSP_CLK,\t\t\t/*< SSP Clock /\n \tDMIC_CLK,\t\t\t/*< DMIC Clock /\n \tDMIC_POW,\t\t\t/*< DMIC Power /\n-\tDW_DMAC_CLK\t\t\t/*< DW DMAC Clock /\n+\tDW_DMAC_CLK,\t\t\t/*< DW DMAC Clock /\n+\tCORE_MEMORY_POW\t\t\t/*< Core Memory power /\n };","path":"src/include/sof/lib/pm_runtime.h","position":7,"original_position":7,"commit_id":"aa75a345a1866bc429e7c0d3d16b249a8e77c839","original_commit_id":"aa75a345a1866bc429e7c0d3d16b249a8e77c839","user":{"login":"dbaluta","id":62316,"node_id":"MDQ6VXNlcjYyMzE2","avatar_url":"https://avatars1.githubusercontent.com/u/62316?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaluta","html_url":"https://github.com/dbaluta","followers_url":"https://api.github.com/users/dbaluta/followers","following_url":"https://api.github.com/users/dbaluta/following{/other_user}","gists_url":"https://api.github.com/users/dbaluta/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaluta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaluta/subscriptions","organizations_url":"https://api.github.com/users/dbaluta/orgs","repos_url":"https://api.github.com/users/dbaluta/repos","events_url":"https://api.github.com/users/dbaluta/events{/privacy}","received_events_url":"https://api.github.com/users/dbaluta/received_events","type":"User","site_admin":false},"body":"Add comma after last element to simplify the diff when the next element will be added. \r\n\r\n``CORE_MEMORY_POW,``","created_at":"2019-08-29T12:30:09Z","updated_at":"2019-08-29T12:30:09Z","html_url":"https://github.com/thesofproject/sof/pull/1732#discussion_r319041412","pull_request_url":"https://api.github.com/repos/thesofproject/sof/pulls/1732","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/comments/319041412"},"html":{"href":"https://github.com/thesofproject/sof/pull/1732#discussion_r319041412"},"pull_request":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/1732"}}},"pull_request":{"url":"https://api.github.com/repos/thesofproject/sof/pulls/1732","id":309123399,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5MTIzMzk5","html_url":"https://github.com/thesofproject/sof/pull/1732","diff_url":"https://github.com/thesofproject/sof/pull/1732.diff","patch_url":"https://github.com/thesofproject/sof/pull/1732.patch","issue_url":"https://api.github.com/repos/thesofproject/sof/issues/1732","number":1732,"state":"open","locked":false,"title":"Memory banks power managment","user":{"login":"dabekjakub","id":41289715,"node_id":"MDQ6VXNlcjQxMjg5NzE1","avatar_url":"https://avatars2.githubusercontent.com/u/41289715?v=4","gravatar_id":"","url":"https://api.github.com/users/dabekjakub","html_url":"https://github.com/dabekjakub","followers_url":"https://api.github.com/users/dabekjakub/followers","following_url":"https://api.github.com/users/dabekjakub/following{/other_user}","gists_url":"https://api.github.com/users/dabekjakub/gists{/gist_id}","starred_url":"https://api.github.com/users/dabekjakub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabekjakub/subscriptions","organizations_url":"https://api.github.com/users/dabekjakub/orgs","repos_url":"https://api.github.com/users/dabekjakub/repos","events_url":"https://api.github.com/users/dabekjakub/events{/privacy}","received_events_url":"https://api.github.com/users/dabekjakub/received_events","type":"User","site_admin":false},"body":"Trun off unused memory on bootup.\r\nAdd memory banks power managment api","created_at":"2019-08-20T16:02:26Z","updated_at":"2019-08-29T12:30:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57fdca01a4e5a78670a6294966cede929ccb96b7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"plbossart","id":1149035,"node_id":"MDQ6VXNlcjExNDkwMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1149035?v=4","gravatar_id":"","url":"https://api.github.com/users/plbossart","html_url":"https://github.com/plbossart","followers_url":"https://api.github.com/users/plbossart/followers","following_url":"https://api.github.com/users/plbossart/following{/other_user}","gists_url":"https://api.github.com/users/plbossart/gists{/gist_id}","starred_url":"https://api.github.com/users/plbossart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plbossart/subscriptions","organizations_url":"https://api.github.com/users/plbossart/orgs","repos_url":"https://api.github.com/users/plbossart/repos","events_url":"https://api.github.com/users/plbossart/events{/privacy}","received_events_url":"https://api.github.com/users/plbossart/received_events","type":"User","site_admin":false},{"login":"bardliao","id":8856808,"node_id":"MDQ6VXNlcjg4NTY4MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/8856808?v=4","gravatar_id":"","url":"https://api.github.com/users/bardliao","html_url":"https://github.com/bardliao","followers_url":"https://api.github.com/users/bardliao/followers","following_url":"https://api.github.com/users/bardliao/following{/other_user}","gists_url":"https://api.github.com/users/bardliao/gists{/gist_id}","starred_url":"https://api.github.com/users/bardliao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bardliao/subscriptions","organizations_url":"https://api.github.com/users/bardliao/orgs","repos_url":"https://api.github.com/users/bardliao/repos","events_url":"https://api.github.com/users/bardliao/events{/privacy}","received_events_url":"https://api.github.com/users/bardliao/received_events","type":"User","site_admin":false},{"login":"libinyang","id":10509113,"node_id":"MDQ6VXNlcjEwNTA5MTEz","avatar_url":"https://avatars1.githubusercontent.com/u/10509113?v=4","gravatar_id":"","url":"https://api.github.com/users/libinyang","html_url":"https://github.com/libinyang","followers_url":"https://api.github.com/users/libinyang/followers","following_url":"https://api.github.com/users/libinyang/following{/other_user}","gists_url":"https://api.github.com/users/libinyang/gists{/gist_id}","starred_url":"https://api.github.com/users/libinyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libinyang/subscriptions","organizations_url":"https://api.github.com/users/libinyang/orgs","repos_url":"https://api.github.com/users/libinyang/repos","events_url":"https://api.github.com/users/libinyang/events{/privacy}","received_events_url":"https://api.github.com/users/libinyang/received_events","type":"User","site_admin":false},{"login":"lgirdwood","id":12020523,"node_id":"MDQ6VXNlcjEyMDIwNTIz","avatar_url":"https://avatars0.githubusercontent.com/u/12020523?v=4","gravatar_id":"","url":"https://api.github.com/users/lgirdwood","html_url":"https://github.com/lgirdwood","followers_url":"https://api.github.com/users/lgirdwood/followers","following_url":"https://api.github.com/users/lgirdwood/following{/other_user}","gists_url":"https://api.github.com/users/lgirdwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lgirdwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgirdwood/subscriptions","organizations_url":"https://api.github.com/users/lgirdwood/orgs","repos_url":"https://api.github.com/users/lgirdwood/repos","events_url":"https://api.github.com/users/lgirdwood/events{/privacy}","received_events_url":"https://api.github.com/users/lgirdwood/received_events","type":"User","site_admin":false},{"login":"xiulipan","id":37825714,"node_id":"MDQ6VXNlcjM3ODI1NzE0","avatar_url":"https://avatars2.githubusercontent.com/u/37825714?v=4","gravatar_id":"","url":"https://api.github.com/users/xiulipan","html_url":"https://github.com/xiulipan","followers_url":"https://api.github.com/users/xiulipan/followers","following_url":"https://api.github.com/users/xiulipan/following{/other_user}","gists_url":"https://api.github.com/users/xiulipan/gists{/gist_id}","starred_url":"https://api.github.com/users/xiulipan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiulipan/subscriptions","organizations_url":"https://api.github.com/users/xiulipan/orgs","repos_url":"https://api.github.com/users/xiulipan/repos","events_url":"https://api.github.com/users/xiulipan/events{/privacy}","received_events_url":"https://api.github.com/users/xiulipan/received_events","type":"User","site_admin":false},{"login":"lbetlej","id":39951716,"node_id":"MDQ6VXNlcjM5OTUxNzE2","avatar_url":"https://avatars1.githubusercontent.com/u/39951716?v=4","gravatar_id":"","url":"https://api.github.com/users/lbetlej","html_url":"https://github.com/lbetlej","followers_url":"https://api.github.com/users/lbetlej/followers","following_url":"https://api.github.com/users/lbetlej/following{/other_user}","gists_url":"https://api.github.com/users/lbetlej/gists{/gist_id}","starred_url":"https://api.github.com/users/lbetlej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbetlej/subscriptions","organizations_url":"https://api.github.com/users/lbetlej/orgs","repos_url":"https://api.github.com/users/lbetlej/repos","events_url":"https://api.github.com/users/lbetlej/events{/privacy}","received_events_url":"https://api.github.com/users/lbetlej/received_events","type":"User","site_admin":false},{"login":"mmaka1","id":40028148,"node_id":"MDQ6VXNlcjQwMDI4MTQ4","avatar_url":"https://avatars3.githubusercontent.com/u/40028148?v=4","gravatar_id":"","url":"https://api.github.com/users/mmaka1","html_url":"https://github.com/mmaka1","followers_url":"https://api.github.com/users/mmaka1/followers","following_url":"https://api.github.com/users/mmaka1/following{/other_user}","gists_url":"https://api.github.com/users/mmaka1/gists{/gist_id}","starred_url":"https://api.github.com/users/mmaka1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmaka1/subscriptions","organizations_url":"https://api.github.com/users/mmaka1/orgs","repos_url":"https://api.github.com/users/mmaka1/repos","events_url":"https://api.github.com/users/mmaka1/events{/privacy}","received_events_url":"https://api.github.com/users/mmaka1/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thesofproject/sof/pulls/1732/commits","review_comments_url":"https://api.github.com/repos/thesofproject/sof/pulls/1732/comments","review_comment_url":"https://api.github.com/repos/thesofproject/sof/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thesofproject/sof/issues/1732/comments","statuses_url":"https://api.github.com/repos/thesofproject/sof/statuses/aa75a345a1866bc429e7c0d3d16b249a8e77c839","head":{"label":"dabekjakub:banks_pm","ref":"banks_pm","sha":"aa75a345a1866bc429e7c0d3d16b249a8e77c839","user":{"login":"dabekjakub","id":41289715,"node_id":"MDQ6VXNlcjQxMjg5NzE1","avatar_url":"https://avatars2.githubusercontent.com/u/41289715?v=4","gravatar_id":"","url":"https://api.github.com/users/dabekjakub","html_url":"https://github.com/dabekjakub","followers_url":"https://api.github.com/users/dabekjakub/followers","following_url":"https://api.github.com/users/dabekjakub/following{/other_user}","gists_url":"https://api.github.com/users/dabekjakub/gists{/gist_id}","starred_url":"https://api.github.com/users/dabekjakub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabekjakub/subscriptions","organizations_url":"https://api.github.com/users/dabekjakub/orgs","repos_url":"https://api.github.com/users/dabekjakub/repos","events_url":"https://api.github.com/users/dabekjakub/events{/privacy}","received_events_url":"https://api.github.com/users/dabekjakub/received_events","type":"User","site_admin":false},"repo":{"id":142555687,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI1NTU2ODc=","name":"sof","full_name":"dabekjakub/sof","private":false,"owner":{"login":"dabekjakub","id":41289715,"node_id":"MDQ6VXNlcjQxMjg5NzE1","avatar_url":"https://avatars2.githubusercontent.com/u/41289715?v=4","gravatar_id":"","url":"https://api.github.com/users/dabekjakub","html_url":"https://github.com/dabekjakub","followers_url":"https://api.github.com/users/dabekjakub/followers","following_url":"https://api.github.com/users/dabekjakub/following{/other_user}","gists_url":"https://api.github.com/users/dabekjakub/gists{/gist_id}","starred_url":"https://api.github.com/users/dabekjakub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dabekjakub/subscriptions","organizations_url":"https://api.github.com/users/dabekjakub/orgs","repos_url":"https://api.github.com/users/dabekjakub/repos","events_url":"https://api.github.com/users/dabekjakub/events{/privacy}","received_events_url":"https://api.github.com/users/dabekjakub/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dabekjakub/sof","description":"Sound Open Firmware","fork":true,"url":"https://api.github.com/repos/dabekjakub/sof","forks_url":"https://api.github.com/repos/dabekjakub/sof/forks","keys_url":"https://api.github.com/repos/dabekjakub/sof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dabekjakub/sof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dabekjakub/sof/teams","hooks_url":"https://api.github.com/repos/dabekjakub/sof/hooks","issue_events_url":"https://api.github.com/repos/dabekjakub/sof/issues/events{/number}","events_url":"https://api.github.com/repos/dabekjakub/sof/events","assignees_url":"https://api.github.com/repos/dabekjakub/sof/assignees{/user}","branches_url":"https://api.github.com/repos/dabekjakub/sof/branches{/branch}","tags_url":"https://api.github.com/repos/dabekjakub/sof/tags","blobs_url":"https://api.github.com/repos/dabekjakub/sof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dabekjakub/sof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dabekjakub/sof/git/refs{/sha}","trees_url":"https://api.github.com/repos/dabekjakub/sof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dabekjakub/sof/statuses/{sha}","languages_url":"https://api.github.com/repos/dabekjakub/sof/languages","stargazers_url":"https://api.github.com/repos/dabekjakub/sof/stargazers","contributors_url":"https://api.github.com/repos/dabekjakub/sof/contributors","subscribers_url":"https://api.github.com/repos/dabekjakub/sof/subscribers","subscription_url":"https://api.github.com/repos/dabekjakub/sof/subscription","commits_url":"https://api.github.com/repos/dabekjakub/sof/commits{/sha}","git_commits_url":"https://api.github.com/repos/dabekjakub/sof/git/commits{/sha}","comments_url":"https://api.github.com/repos/dabekjakub/sof/comments{/number}","issue_comment_url":"https://api.github.com/repos/dabekjakub/sof/issues/comments{/number}","contents_url":"https://api.github.com/repos/dabekjakub/sof/contents/{+path}","compare_url":"https://api.github.com/repos/dabekjakub/sof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dabekjakub/sof/merges","archive_url":"https://api.github.com/repos/dabekjakub/sof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dabekjakub/sof/downloads","issues_url":"https://api.github.com/repos/dabekjakub/sof/issues{/number}","pulls_url":"https://api.github.com/repos/dabekjakub/sof/pulls{/number}","milestones_url":"https://api.github.com/repos/dabekjakub/sof/milestones{/number}","notifications_url":"https://api.github.com/repos/dabekjakub/sof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dabekjakub/sof/labels{/name}","releases_url":"https://api.github.com/repos/dabekjakub/sof/releases{/id}","deployments_url":"https://api.github.com/repos/dabekjakub/sof/deployments","created_at":"2018-07-27T09:17:06Z","updated_at":"2018-11-27T10:16:13Z","pushed_at":"2019-08-29T10:22:14Z","git_url":"git://github.com/dabekjakub/sof.git","ssh_url":"[email protected]:dabekjakub/sof.git","clone_url":"https://github.com/dabekjakub/sof.git","svn_url":"https://github.com/dabekjakub/sof","homepage":null,"size":7996,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thesofproject:master","ref":"master","sha":"7791303c316e36cbd26a8ab9f4d03ad33f6946b5","user":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"repo":{"id":135623245,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MjMyNDU=","name":"sof","full_name":"thesofproject/sof","private":false,"owner":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/thesofproject/sof","description":"Sound Open Firmware","fork":false,"url":"https://api.github.com/repos/thesofproject/sof","forks_url":"https://api.github.com/repos/thesofproject/sof/forks","keys_url":"https://api.github.com/repos/thesofproject/sof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thesofproject/sof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thesofproject/sof/teams","hooks_url":"https://api.github.com/repos/thesofproject/sof/hooks","issue_events_url":"https://api.github.com/repos/thesofproject/sof/issues/events{/number}","events_url":"https://api.github.com/repos/thesofproject/sof/events","assignees_url":"https://api.github.com/repos/thesofproject/sof/assignees{/user}","branches_url":"https://api.github.com/repos/thesofproject/sof/branches{/branch}","tags_url":"https://api.github.com/repos/thesofproject/sof/tags","blobs_url":"https://api.github.com/repos/thesofproject/sof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thesofproject/sof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thesofproject/sof/git/refs{/sha}","trees_url":"https://api.github.com/repos/thesofproject/sof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thesofproject/sof/statuses/{sha}","languages_url":"https://api.github.com/repos/thesofproject/sof/languages","stargazers_url":"https://api.github.com/repos/thesofproject/sof/stargazers","contributors_url":"https://api.github.com/repos/thesofproject/sof/contributors","subscribers_url":"https://api.github.com/repos/thesofproject/sof/subscribers","subscription_url":"https://api.github.com/repos/thesofproject/sof/subscription","commits_url":"https://api.github.com/repos/thesofproject/sof/commits{/sha}","git_commits_url":"https://api.github.com/repos/thesofproject/sof/git/commits{/sha}","comments_url":"https://api.github.com/repos/thesofproject/sof/comments{/number}","issue_comment_url":"https://api.github.com/repos/thesofproject/sof/issues/comments{/number}","contents_url":"https://api.github.com/repos/thesofproject/sof/contents/{+path}","compare_url":"https://api.github.com/repos/thesofproject/sof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thesofproject/sof/merges","archive_url":"https://api.github.com/repos/thesofproject/sof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thesofproject/sof/downloads","issues_url":"https://api.github.com/repos/thesofproject/sof/issues{/number}","pulls_url":"https://api.github.com/repos/thesofproject/sof/pulls{/number}","milestones_url":"https://api.github.com/repos/thesofproject/sof/milestones{/number}","notifications_url":"https://api.github.com/repos/thesofproject/sof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thesofproject/sof/labels{/name}","releases_url":"https://api.github.com/repos/thesofproject/sof/releases{/id}","deployments_url":"https://api.github.com/repos/thesofproject/sof/deployments","created_at":"2018-05-31T18:51:03Z","updated_at":"2019-08-28T16:06:33Z","pushed_at":"2019-08-29T11:41:06Z","git_url":"git://github.com/thesofproject/sof.git","ssh_url":"[email protected]:thesofproject/sof.git","clone_url":"https://github.com/thesofproject/sof.git","svn_url":"https://github.com/thesofproject/sof","homepage":null,"size":8448,"stargazers_count":78,"watchers_count":78,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":117,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":84,"open_issues":117,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/1732"},"html":{"href":"https://github.com/thesofproject/sof/pull/1732"},"issue":{"href":"https://api.github.com/repos/thesofproject/sof/issues/1732"},"comments":{"href":"https://api.github.com/repos/thesofproject/sof/issues/1732/comments"},"review_comments":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/1732/comments"},"review_comment":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/1732/commits"},"statuses":{"href":"https://api.github.com/repos/thesofproject/sof/statuses/aa75a345a1866bc429e7c0d3d16b249a8e77c839"}},"author_association":"MEMBER"}}	{ "id": 135623245, "name": "thesofproject/sof", "url": "https://api.github.com/repos/thesofproject/sof" }	{ "id": 62316, "login": "dbaluta", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/62316?", "url": "https://api.github.com/users/dbaluta" }	{ "id": 39773507, "login": "thesofproject", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/39773507?", "url": "https://api.github.com/orgs/thesofproject" }	2019-08-29T15:30:09	10309062309	{"actor":{"display_login":"dbaluta"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/thesofproject/linux/pulls/comments/295005117","pull_request_review_id":251331925,"id":295005117,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NTAwNTExNw==","diff_hunk":"@@ -0,0 +1,167 @@\n+// SPDX-License-Identifier: GPL-2.0+\n+/\n+ Copyright 2018 NXP","path":"drivers/firmware/imx/imx-dsp.c","position":3,"original_position":3,"commit_id":"70dd8da47e55a015be92439f04964e118a70cd73","original_commit_id":"00a5e989c5724893664e5c2635cf7150ab039a71","user":{"login":"dbaluta","id":62316,"node_id":"MDQ6VXNlcjYyMzE2","avatar_url":"https://avatars1.githubusercontent.com/u/62316?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaluta","html_url":"https://github.com/dbaluta","followers_url":"https://api.github.com/users/dbaluta/followers","following_url":"https://api.github.com/users/dbaluta/following{/other_user}","gists_url":"https://api.github.com/users/dbaluta/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaluta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaluta/subscriptions","organizations_url":"https://api.github.com/users/dbaluta/orgs","repos_url":"https://api.github.com/users/dbaluta/repos","events_url":"https://api.github.com/users/dbaluta/events{/privacy}","received_events_url":"https://api.github.com/users/dbaluta/received_events","type":"User","site_admin":false},"body":"@plbossart Indeed. Will fix in v2.","created_at":"2019-06-18T20:08:30Z","updated_at":"2019-06-18T20:08:31Z","html_url":"https://github.com/thesofproject/linux/pull/1048#discussion_r295005117","pull_request_url":"https://api.github.com/repos/thesofproject/linux/pulls/1048","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/comments/295005117"},"html":{"href":"https://github.com/thesofproject/linux/pull/1048#discussion_r295005117"},"pull_request":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/1048"}},"in_reply_to_id":294952013},"pull_request":{"url":"https://api.github.com/repos/thesofproject/linux/pulls/1048","id":289365899,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5MzY1ODk5","html_url":"https://github.com/thesofproject/linux/pull/1048","diff_url":"https://github.com/thesofproject/linux/pull/1048.diff","patch_url":"https://github.com/thesofproject/linux/pull/1048.patch","issue_url":"https://api.github.com/repos/thesofproject/linux/issues/1048","number":1048,"state":"open","locked":false,"title":"[RFC] Add initial support for i.MX8 SOF driver","user":{"login":"dbaluta","id":62316,"node_id":"MDQ6VXNlcjYyMzE2","avatar_url":"https://avatars1.githubusercontent.com/u/62316?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaluta","html_url":"https://github.com/dbaluta","followers_url":"https://api.github.com/users/dbaluta/followers","following_url":"https://api.github.com/users/dbaluta/following{/other_user}","gists_url":"https://api.github.com/users/dbaluta/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaluta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaluta/subscriptions","organizations_url":"https://api.github.com/users/dbaluta/orgs","repos_url":"https://api.github.com/users/dbaluta/repos","events_url":"https://api.github.com/users/dbaluta/events{/privacy}","received_events_url":"https://api.github.com/users/dbaluta/received_events","type":"User","site_admin":false},"body":"This patch series add basic support for i.MX8 SOF driver. \r\n\r\nFirst 3 patches introduce DSP IPC protocol driver (review with community ongoing - https://lkml.org/lkml/2019/6/14/165)\r\n\r\n505a33c1b99f dt-bindings: arm: fsl: Add DSP IPC binding support\r\n00a5e989c572 firmware: imx: Add DSP IPC protocol driver\r\nd2a410aca9df mailbox: imx: Clear GIEn bit at shutdown\r\n\r\nNext 3 patches add DT nodes corresponding to DSP. Review will be started with community soon.\r\n\r\n15ccaaa93498 arm64: dts: imx8qxp: Add DSP DT node\r\nd4dfab80ec03 arm64: dts: imx8qxp: Add DSP MU node\r\n76760c149de5 clk: imx8qxp: Add DSP clocks\r\n\r\nNext 2 patches are small SOF cleanups that can be merged as they are:\r\n\r\n7310ddcbe6e7 ASoC: SOF: loader: Dont ignore SRAM block types\r\n23159b1d36f5 ASoC: SOF: loader: Use the BAR provided by FW\r\n\r\nLast 3 patches are the actual support for i.MX8 SOF driver. \r\n\r\n70dd8da47e55 ASoC: SOF: Add DT DSP device support\r\n5b28a5e96e9a ASoC: SOF: topology: Add dummy support for i.MX8 DAIs\r\nb79c4901f604 ASoC: SOF: imx: Add i.MX8 HW support\r\n\r\nWould like to see some review for last 5 patches. \r\n","created_at":"2019-06-18T16:44:19Z","updated_at":"2019-06-18T20:08:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f658fbce1f4f5715d58bf4b1dce0dc2f41910648","assignee":null,"assignees":[],"requested_reviewers":[{"login":"juimonen","id":1136650,"node_id":"MDQ6VXNlcjExMzY2NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1136650?v=4","gravatar_id":"","url":"https://api.github.com/users/juimonen","html_url":"https://github.com/juimonen","followers_url":"https://api.github.com/users/juimonen/followers","following_url":"https://api.github.com/users/juimonen/following{/other_user}","gists_url":"https://api.github.com/users/juimonen/gists{/gist_id}","starred_url":"https://api.github.com/users/juimonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juimonen/subscriptions","organizations_url":"https://api.github.com/users/juimonen/orgs","repos_url":"https://api.github.com/users/juimonen/repos","events_url":"https://api.github.com/users/juimonen/events{/privacy}","received_events_url":"https://api.github.com/users/juimonen/received_events","type":"User","site_admin":false},{"login":"lyakh","id":1363683,"node_id":"MDQ6VXNlcjEzNjM2ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1363683?v=4","gravatar_id":"","url":"https://api.github.com/users/lyakh","html_url":"https://github.com/lyakh","followers_url":"https://api.github.com/users/lyakh/followers","following_url":"https://api.github.com/users/lyakh/following{/other_user}","gists_url":"https://api.github.com/users/lyakh/gists{/gist_id}","starred_url":"https://api.github.com/users/lyakh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyakh/subscriptions","organizations_url":"https://api.github.com/users/lyakh/orgs","repos_url":"https://api.github.com/users/lyakh/repos","events_url":"https://api.github.com/users/lyakh/events{/privacy}","received_events_url":"https://api.github.com/users/lyakh/received_events","type":"User","site_admin":false},{"login":"bardliao","id":8856808,"node_id":"MDQ6VXNlcjg4NTY4MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/8856808?v=4","gravatar_id":"","url":"https://api.github.com/users/bardliao","html_url":"https://github.com/bardliao","followers_url":"https://api.github.com/users/bardliao/followers","following_url":"https://api.github.com/users/bardliao/following{/other_user}","gists_url":"https://api.github.com/users/bardliao/gists{/gist_id}","starred_url":"https://api.github.com/users/bardliao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bardliao/subscriptions","organizations_url":"https://api.github.com/users/bardliao/orgs","repos_url":"https://api.github.com/users/bardliao/repos","events_url":"https://api.github.com/users/bardliao/events{/privacy}","received_events_url":"https://api.github.com/users/bardliao/received_events","type":"User","site_admin":false},{"login":"keyonjie","id":10458135,"node_id":"MDQ6VXNlcjEwNDU4MTM1","avatar_url":"https://avatars1.githubusercontent.com/u/10458135?v=4","gravatar_id":"","url":"https://api.github.com/users/keyonjie","html_url":"https://github.com/keyonjie","followers_url":"https://api.github.com/users/keyonjie/followers","following_url":"https://api.github.com/users/keyonjie/following{/other_user}","gists_url":"https://api.github.com/users/keyonjie/gists{/gist_id}","starred_url":"https://api.github.com/users/keyonjie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keyonjie/subscriptions","organizations_url":"https://api.github.com/users/keyonjie/orgs","repos_url":"https://api.github.com/users/keyonjie/repos","events_url":"https://api.github.com/users/keyonjie/events{/privacy}","received_events_url":"https://api.github.com/users/keyonjie/received_events","type":"User","site_admin":false},{"login":"libinyang","id":10509113,"node_id":"MDQ6VXNlcjEwNTA5MTEz","avatar_url":"https://avatars1.githubusercontent.com/u/10509113?v=4","gravatar_id":"","url":"https://api.github.com/users/libinyang","html_url":"https://github.com/libinyang","followers_url":"https://api.github.com/users/libinyang/followers","following_url":"https://api.github.com/users/libinyang/following{/other_user}","gists_url":"https://api.github.com/users/libinyang/gists{/gist_id}","starred_url":"https://api.github.com/users/libinyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libinyang/subscriptions","organizations_url":"https://api.github.com/users/libinyang/orgs","repos_url":"https://api.github.com/users/libinyang/repos","events_url":"https://api.github.com/users/libinyang/events{/privacy}","received_events_url":"https://api.github.com/users/libinyang/received_events","type":"User","site_admin":false},{"login":"lgirdwood","id":12020523,"node_id":"MDQ6VXNlcjEyMDIwNTIz","avatar_url":"https://avatars0.githubusercontent.com/u/12020523?v=4","gravatar_id":"","url":"https://api.github.com/users/lgirdwood","html_url":"https://github.com/lgirdwood","followers_url":"https://api.github.com/users/lgirdwood/followers","following_url":"https://api.github.com/users/lgirdwood/following{/other_user}","gists_url":"https://api.github.com/users/lgirdwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lgirdwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgirdwood/subscriptions","organizations_url":"https://api.github.com/users/lgirdwood/orgs","repos_url":"https://api.github.com/users/lgirdwood/repos","events_url":"https://api.github.com/users/lgirdwood/events{/privacy}","received_events_url":"https://api.github.com/users/lgirdwood/received_events","type":"User","site_admin":false},{"login":"singalsu","id":28754793,"node_id":"MDQ6VXNlcjI4NzU0Nzkz","avatar_url":"https://avatars0.githubusercontent.com/u/28754793?v=4","gravatar_id":"","url":"https://api.github.com/users/singalsu","html_url":"https://github.com/singalsu","followers_url":"https://api.github.com/users/singalsu/followers","following_url":"https://api.github.com/users/singalsu/following{/other_user}","gists_url":"https://api.github.com/users/singalsu/gists{/gist_id}","starred_url":"https://api.github.com/users/singalsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singalsu/subscriptions","organizations_url":"https://api.github.com/users/singalsu/orgs","repos_url":"https://api.github.com/users/singalsu/repos","events_url":"https://api.github.com/users/singalsu/events{/privacy}","received_events_url":"https://api.github.com/users/singalsu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thesofproject/linux/pulls/1048/commits","review_comments_url":"https://api.github.com/repos/thesofproject/linux/pulls/1048/comments","review_comment_url":"https://api.github.com/repos/thesofproject/linux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thesofproject/linux/issues/1048/comments","statuses_url":"https://api.github.com/repos/thesofproject/linux/statuses/70dd8da47e55a015be92439f04964e118a70cd73","head":{"label":"dbaluta:sof-dev-3","ref":"sof-dev-3","sha":"70dd8da47e55a015be92439f04964e118a70cd73","user":{"login":"dbaluta","id":62316,"node_id":"MDQ6VXNlcjYyMzE2","avatar_url":"https://avatars1.githubusercontent.com/u/62316?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaluta","html_url":"https://github.com/dbaluta","followers_url":"https://api.github.com/users/dbaluta/followers","following_url":"https://api.github.com/users/dbaluta/following{/other_user}","gists_url":"https://api.github.com/users/dbaluta/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaluta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaluta/subscriptions","organizations_url":"https://api.github.com/users/dbaluta/orgs","repos_url":"https://api.github.com/users/dbaluta/repos","events_url":"https://api.github.com/users/dbaluta/events{/privacy}","received_events_url":"https://api.github.com/users/dbaluta/received_events","type":"User","site_admin":false},"repo":{"id":123491441,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM0OTE0NDE=","name":"linux","full_name":"dbaluta/linux","private":false,"owner":{"login":"dbaluta","id":62316,"node_id":"MDQ6VXNlcjYyMzE2","avatar_url":"https://avatars1.githubusercontent.com/u/62316?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaluta","html_url":"https://github.com/dbaluta","followers_url":"https://api.github.com/users/dbaluta/followers","following_url":"https://api.github.com/users/dbaluta/following{/other_user}","gists_url":"https://api.github.com/users/dbaluta/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaluta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaluta/subscriptions","organizations_url":"https://api.github.com/users/dbaluta/orgs","repos_url":"https://api.github.com/users/dbaluta/repos","events_url":"https://api.github.com/users/dbaluta/events{/privacy}","received_events_url":"https://api.github.com/users/dbaluta/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dbaluta/linux","description":"Linux kernel source tree","fork":true,"url":"https://api.github.com/repos/dbaluta/linux","forks_url":"https://api.github.com/repos/dbaluta/linux/forks","keys_url":"https://api.github.com/repos/dbaluta/linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbaluta/linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbaluta/linux/teams","hooks_url":"https://api.github.com/repos/dbaluta/linux/hooks","issue_events_url":"https://api.github.com/repos/dbaluta/linux/issues/events{/number}","events_url":"https://api.github.com/repos/dbaluta/linux/events","assignees_url":"https://api.github.com/repos/dbaluta/linux/assignees{/user}","branches_url":"https://api.github.com/repos/dbaluta/linux/branches{/branch}","tags_url":"https://api.github.com/repos/dbaluta/linux/tags","blobs_url":"https://api.github.com/repos/dbaluta/linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbaluta/linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbaluta/linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbaluta/linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbaluta/linux/statuses/{sha}","languages_url":"https://api.github.com/repos/dbaluta/linux/languages","stargazers_url":"https://api.github.com/repos/dbaluta/linux/stargazers","contributors_url":"https://api.github.com/repos/dbaluta/linux/contributors","subscribers_url":"https://api.github.com/repos/dbaluta/linux/subscribers","subscription_url":"https://api.github.com/repos/dbaluta/linux/subscription","commits_url":"https://api.github.com/repos/dbaluta/linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbaluta/linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbaluta/linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbaluta/linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbaluta/linux/contents/{+path}","compare_url":"https://api.github.com/repos/dbaluta/linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbaluta/linux/merges","archive_url":"https://api.github.com/repos/dbaluta/linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbaluta/linux/downloads","issues_url":"https://api.github.com/repos/dbaluta/linux/issues{/number}","pulls_url":"https://api.github.com/repos/dbaluta/linux/pulls{/number}","milestones_url":"https://api.github.com/repos/dbaluta/linux/milestones{/number}","notifications_url":"https://api.github.com/repos/dbaluta/linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbaluta/linux/labels{/name}","releases_url":"https://api.github.com/repos/dbaluta/linux/releases{/id}","deployments_url":"https://api.github.com/repos/dbaluta/linux/deployments","created_at":"2018-03-01T20:56:37Z","updated_at":"2018-05-20T07:05:36Z","pushed_at":"2019-06-18T16:32:57Z","git_url":"git://github.com/dbaluta/linux.git","ssh_url":"[email protected]:dbaluta/linux.git","clone_url":"https://github.com/dbaluta/linux.git","svn_url":"https://github.com/dbaluta/linux","homepage":"","size":2583244,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thesofproject:topic/sof-dev","ref":"topic/sof-dev","sha":"ab5d97b897e0e7fff938c9bb3e09bcf3773215e2","user":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"repo":{"id":135611127,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MTExMjc=","name":"linux","full_name":"thesofproject/linux","private":false,"owner":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/thesofproject/linux","description":"Linux kernel source tree","fork":true,"url":"https://api.github.com/repos/thesofproject/linux","forks_url":"https://api.github.com/repos/thesofproject/linux/forks","keys_url":"https://api.github.com/repos/thesofproject/linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thesofproject/linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thesofproject/linux/teams","hooks_url":"https://api.github.com/repos/thesofproject/linux/hooks","issue_events_url":"https://api.github.com/repos/thesofproject/linux/issues/events{/number}","events_url":"https://api.github.com/repos/thesofproject/linux/events","assignees_url":"https://api.github.com/repos/thesofproject/linux/assignees{/user}","branches_url":"https://api.github.com/repos/thesofproject/linux/branches{/branch}","tags_url":"https://api.github.com/repos/thesofproject/linux/tags","blobs_url":"https://api.github.com/repos/thesofproject/linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thesofproject/linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thesofproject/linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/thesofproject/linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thesofproject/linux/statuses/{sha}","languages_url":"https://api.github.com/repos/thesofproject/linux/languages","stargazers_url":"https://api.github.com/repos/thesofproject/linux/stargazers","contributors_url":"https://api.github.com/repos/thesofproject/linux/contributors","subscribers_url":"https://api.github.com/repos/thesofproject/linux/subscribers","subscription_url":"https://api.github.com/repos/thesofproject/linux/subscription","commits_url":"https://api.github.com/repos/thesofproject/linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/thesofproject/linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/thesofproject/linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/thesofproject/linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/thesofproject/linux/contents/{+path}","compare_url":"https://api.github.com/repos/thesofproject/linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thesofproject/linux/merges","archive_url":"https://api.github.com/repos/thesofproject/linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thesofproject/linux/downloads","issues_url":"https://api.github.com/repos/thesofproject/linux/issues{/number}","pulls_url":"https://api.github.com/repos/thesofproject/linux/pulls{/number}","milestones_url":"https://api.github.com/repos/thesofproject/linux/milestones{/number}","notifications_url":"https://api.github.com/repos/thesofproject/linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thesofproject/linux/labels{/name}","releases_url":"https://api.github.com/repos/thesofproject/linux/releases{/id}","deployments_url":"https://api.github.com/repos/thesofproject/linux/deployments","created_at":"2018-05-31T16:47:45Z","updated_at":"2019-06-18T05:35:01Z","pushed_at":"2019-06-18T16:44:20Z","git_url":"git://github.com/thesofproject/linux.git","ssh_url":"[email protected]:thesofproject/linux.git","clone_url":"https://github.com/thesofproject/linux.git","svn_url":"https://github.com/thesofproject/linux","homepage":"","size":3120781,"stargazers_count":14,"watchers_count":14,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":97,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":41,"open_issues":97,"watchers":14,"default_branch":"topic/sof-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/1048"},"html":{"href":"https://github.com/thesofproject/linux/pull/1048"},"issue":{"href":"https://api.github.com/repos/thesofproject/linux/issues/1048"},"comments":{"href":"https://api.github.com/repos/thesofproject/linux/issues/1048/comments"},"review_comments":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/1048/comments"},"review_comment":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/1048/commits"},"statuses":{"href":"https://api.github.com/repos/thesofproject/linux/statuses/70dd8da47e55a015be92439f04964e118a70cd73"}},"author_association":"NONE"}}	{ "id": 135611127, "name": "thesofproject/linux", "url": "https://api.github.com/repos/thesofproject/linux" }	{ "id": 62316, "login": "dbaluta", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/62316?", "url": "https://api.github.com/users/dbaluta" }	{ "id": 39773507, "login": "thesofproject", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/39773507?", "url": "https://api.github.com/orgs/thesofproject" }	2019-06-18T20:08:30	9847266595	{"actor":{"display_login":"dbaluta"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/thesofproject/linux/pulls/comments/363526996","pull_request_review_id":338951843,"id":363526996,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MzUyNjk5Ng==","diff_hunk":"@@ -71,6 +71,7 @@ static const struct snd_soc_dapm_route bdw_rt5677_map[] = {\n \t{\"DMIC L2\", NULL, \"Local DMICs\"},\n \t{\"DMIC R2\", NULL, \"Local DMICs\"},\n \n+#if !IS_ENABLED(CONFIG_SND_SOC_SOF_BROADWELL)","path":"sound/soc/intel/boards/bdw-rt5677.c","position":4,"original_position":4,"commit_id":"7b822a2d42846339f213a0ae4f6bcb4a05fc9f66","original_commit_id":"7b822a2d42846339f213a0ae4f6bcb4a05fc9f66","user":{"login":"ranj063","id":7766921,"node_id":"MDQ6VXNlcjc3NjY5MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/7766921?v=4","gravatar_id":"","url":"https://api.github.com/users/ranj063","html_url":"https://github.com/ranj063","followers_url":"https://api.github.com/users/ranj063/followers","following_url":"https://api.github.com/users/ranj063/following{/other_user}","gists_url":"https://api.github.com/users/ranj063/gists{/gist_id}","starred_url":"https://api.github.com/users/ranj063/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ranj063/subscriptions","organizations_url":"https://api.github.com/users/ranj063/orgs","repos_url":"https://api.github.com/users/ranj063/repos","events_url":"https://api.github.com/users/ranj063/events{/privacy}","received_events_url":"https://api.github.com/users/ranj063/received_events","type":"User","site_admin":false},"body":"@plbossart are you possibly missing the virtual widgets for the other three \"AIF1 Capture\", \"AIF1 Playback\" and \"DSP Buffer\"?","created_at":"2020-01-06T23:13:06Z","updated_at":"2020-01-06T23:13:06Z","html_url":"https://github.com/thesofproject/linux/pull/1659#discussion_r363526996","pull_request_url":"https://api.github.com/repos/thesofproject/linux/pulls/1659","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/comments/363526996"},"html":{"href":"https://github.com/thesofproject/linux/pull/1659#discussion_r363526996"},"pull_request":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/1659"}}},"pull_request":{"url":"https://api.github.com/repos/thesofproject/linux/pulls/1659","id":359174104,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU5MTc0MTA0","html_url":"https://github.com/thesofproject/linux/pull/1659","diff_url":"https://github.com/thesofproject/linux/pull/1659.diff","patch_url":"https://github.com/thesofproject/linux/pull/1659.patch","issue_url":"https://api.github.com/repos/thesofproject/linux/issues/1659","number":1659,"state":"open","locked":false,"title":"Enable SOF on Broadwell/Samus (bdw-rt5677)","user":{"login":"plbossart","id":1149035,"node_id":"MDQ6VXNlcjExNDkwMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1149035?v=4","gravatar_id":"","url":"https://api.github.com/users/plbossart","html_url":"https://github.com/plbossart","followers_url":"https://api.github.com/users/plbossart/followers","following_url":"https://api.github.com/users/plbossart/following{/other_user}","gists_url":"https://api.github.com/users/plbossart/gists{/gist_id}","starred_url":"https://api.github.com/users/plbossart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plbossart/subscriptions","organizations_url":"https://api.github.com/users/plbossart/orgs","repos_url":"https://api.github.com/users/plbossart/repos","events_url":"https://api.github.com/users/plbossart/events{/privacy}","received_events_url":"https://api.github.com/users/plbossart/received_events","type":"User","site_admin":false},"body":"before we even look at SOF support on Broadwell, the current mailine code is broken with the legacy driver (w/ legacy BIOS and Ubuntu installed with chrx)\r\n\r\nI was able to restore functionality with the patches in this PR, but there's clearly a problem registering the SPI component.\r\n\r\nWithout the last patch which essentially removes the SPI/Hotword support, I see errors such as \r\n\r\n````\r\n[ 73.454937] bdw-rt5677 bdw-rt5677: ASoC: no sink widget found for DSP Capture\r\n[ 73.454940] bdw-rt5677 bdw-rt5677: ASoC: Failed to add route DSP Buffer -> direct -> DSP Capture\r\n````\r\n\r\n````\r\n[ 21.791961] bdw-rt5677 bdw-rt5677: ASoC: CPU DAI spi-RT5677AA:00 not registered\r\n````\r\n\r\n````\r\n[ 15.467040] bdw-rt5677 bdw-rt5677: snd_soc_add_dai_link start\r\n[ 15.467042] bdw-rt5677 bdw-rt5677: ASoC: binding System PCM\r\n[ 15.467044] bdw-rt5677 bdw-rt5677: ASoC: sanity check done System PCM\r\n[ 15.467057] bdw-rt5677 bdw-rt5677: snd_soc_add_dai_link end\r\n[ 15.467058] bdw-rt5677 bdw-rt5677: snd_soc_add_dai_link start\r\n[ 15.467059] bdw-rt5677 bdw-rt5677: ASoC: binding Codec DSP\r\n[ 15.467061] bdw-rt5677 bdw-rt5677: ASoC: platform component spi-RT5677AA:00 not found for Codec DSP\r\n[ 15.467064] bdw-rt5677 bdw-rt5677: ASoC: sanity check failed Codec DSP, ret -517\r\n````\r\n\r\n@cujomalainey what is needed to probe this SPI thingy? Could this be a legacy BIOS issue?\r\n\r\n@xiulipan @fredoh9 @ranj063 FYI.\r\n\r\n","created_at":"2020-01-04T02:15:40Z","updated_at":"2020-01-06T23:13:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33d6b40b18c2bf9b385ff85816fa3246ad25247b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lgirdwood","id":12020523,"node_id":"MDQ6VXNlcjEyMDIwNTIz","avatar_url":"https://avatars0.githubusercontent.com/u/12020523?v=4","gravatar_id":"","url":"https://api.github.com/users/lgirdwood","html_url":"https://github.com/lgirdwood","followers_url":"https://api.github.com/users/lgirdwood/followers","following_url":"https://api.github.com/users/lgirdwood/following{/other_user}","gists_url":"https://api.github.com/users/lgirdwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lgirdwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgirdwood/subscriptions","organizations_url":"https://api.github.com/users/lgirdwood/orgs","repos_url":"https://api.github.com/users/lgirdwood/repos","events_url":"https://api.github.com/users/lgirdwood/events{/privacy}","received_events_url":"https://api.github.com/users/lgirdwood/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thesofproject/linux/pulls/1659/commits","review_comments_url":"https://api.github.com/repos/thesofproject/linux/pulls/1659/comments","review_comment_url":"https://api.github.com/repos/thesofproject/linux/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thesofproject/linux/issues/1659/comments","statuses_url":"https://api.github.com/repos/thesofproject/linux/statuses/7b822a2d42846339f213a0ae4f6bcb4a05fc9f66","head":{"label":"plbossart:fix/bdw-rt5677","ref":"fix/bdw-rt5677","sha":"7b822a2d42846339f213a0ae4f6bcb4a05fc9f66","user":{"login":"plbossart","id":1149035,"node_id":"MDQ6VXNlcjExNDkwMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1149035?v=4","gravatar_id":"","url":"https://api.github.com/users/plbossart","html_url":"https://github.com/plbossart","followers_url":"https://api.github.com/users/plbossart/followers","following_url":"https://api.github.com/users/plbossart/following{/other_user}","gists_url":"https://api.github.com/users/plbossart/gists{/gist_id}","starred_url":"https://api.github.com/users/plbossart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plbossart/subscriptions","organizations_url":"https://api.github.com/users/plbossart/orgs","repos_url":"https://api.github.com/users/plbossart/repos","events_url":"https://api.github.com/users/plbossart/events{/privacy}","received_events_url":"https://api.github.com/users/plbossart/received_events","type":"User","site_admin":false},"repo":{"id":2997154,"node_id":"MDEwOlJlcG9zaXRvcnkyOTk3MTU0","name":"sound","full_name":"plbossart/sound","private":false,"owner":{"login":"plbossart","id":1149035,"node_id":"MDQ6VXNlcjExNDkwMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1149035?v=4","gravatar_id":"","url":"https://api.github.com/users/plbossart","html_url":"https://github.com/plbossart","followers_url":"https://api.github.com/users/plbossart/followers","following_url":"https://api.github.com/users/plbossart/following{/other_user}","gists_url":"https://api.github.com/users/plbossart/gists{/gist_id}","starred_url":"https://api.github.com/users/plbossart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plbossart/subscriptions","organizations_url":"https://api.github.com/users/plbossart/orgs","repos_url":"https://api.github.com/users/plbossart/repos","events_url":"https://api.github.com/users/plbossart/events{/privacy}","received_events_url":"https://api.github.com/users/plbossart/received_events","type":"User","site_admin":false},"html_url":"https://github.com/plbossart/sound","description":"linux sound subsystem tree","fork":true,"url":"https://api.github.com/repos/plbossart/sound","forks_url":"https://api.github.com/repos/plbossart/sound/forks","keys_url":"https://api.github.com/repos/plbossart/sound/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plbossart/sound/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plbossart/sound/teams","hooks_url":"https://api.github.com/repos/plbossart/sound/hooks","issue_events_url":"https://api.github.com/repos/plbossart/sound/issues/events{/number}","events_url":"https://api.github.com/repos/plbossart/sound/events","assignees_url":"https://api.github.com/repos/plbossart/sound/assignees{/user}","branches_url":"https://api.github.com/repos/plbossart/sound/branches{/branch}","tags_url":"https://api.github.com/repos/plbossart/sound/tags","blobs_url":"https://api.github.com/repos/plbossart/sound/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plbossart/sound/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plbossart/sound/git/refs{/sha}","trees_url":"https://api.github.com/repos/plbossart/sound/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plbossart/sound/statuses/{sha}","languages_url":"https://api.github.com/repos/plbossart/sound/languages","stargazers_url":"https://api.github.com/repos/plbossart/sound/stargazers","contributors_url":"https://api.github.com/repos/plbossart/sound/contributors","subscribers_url":"https://api.github.com/repos/plbossart/sound/subscribers","subscription_url":"https://api.github.com/repos/plbossart/sound/subscription","commits_url":"https://api.github.com/repos/plbossart/sound/commits{/sha}","git_commits_url":"https://api.github.com/repos/plbossart/sound/git/commits{/sha}","comments_url":"https://api.github.com/repos/plbossart/sound/comments{/number}","issue_comment_url":"https://api.github.com/repos/plbossart/sound/issues/comments{/number}","contents_url":"https://api.github.com/repos/plbossart/sound/contents/{+path}","compare_url":"https://api.github.com/repos/plbossart/sound/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plbossart/sound/merges","archive_url":"https://api.github.com/repos/plbossart/sound/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plbossart/sound/downloads","issues_url":"https://api.github.com/repos/plbossart/sound/issues{/number}","pulls_url":"https://api.github.com/repos/plbossart/sound/pulls{/number}","milestones_url":"https://api.github.com/repos/plbossart/sound/milestones{/number}","notifications_url":"https://api.github.com/repos/plbossart/sound/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plbossart/sound/labels{/name}","releases_url":"https://api.github.com/repos/plbossart/sound/releases{/id}","deployments_url":"https://api.github.com/repos/plbossart/sound/deployments","created_at":"2011-12-16T19:34:51Z","updated_at":"2019-09-10T01:33:29Z","pushed_at":"2020-01-06T23:01:25Z","git_url":"git://github.com/plbossart/sound.git","ssh_url":"[email protected]:plbossart/sound.git","clone_url":"https://github.com/plbossart/sound.git","svn_url":"https://github.com/plbossart/sound","homepage":"","size":3336462,"stargazers_count":24,"watchers_count":24,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":0,"watchers":24,"default_branch":"topic/sof-v4.14"}},"base":{"label":"thesofproject:topic/sof-dev","ref":"topic/sof-dev","sha":"52ec20e276a6b49f74f77b18e04cf1b1359b75ae","user":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"repo":{"id":135611127,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MTExMjc=","name":"linux","full_name":"thesofproject/linux","private":false,"owner":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/thesofproject/linux","description":"Linux kernel source tree","fork":true,"url":"https://api.github.com/repos/thesofproject/linux","forks_url":"https://api.github.com/repos/thesofproject/linux/forks","keys_url":"https://api.github.com/repos/thesofproject/linux/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thesofproject/linux/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thesofproject/linux/teams","hooks_url":"https://api.github.com/repos/thesofproject/linux/hooks","issue_events_url":"https://api.github.com/repos/thesofproject/linux/issues/events{/number}","events_url":"https://api.github.com/repos/thesofproject/linux/events","assignees_url":"https://api.github.com/repos/thesofproject/linux/assignees{/user}","branches_url":"https://api.github.com/repos/thesofproject/linux/branches{/branch}","tags_url":"https://api.github.com/repos/thesofproject/linux/tags","blobs_url":"https://api.github.com/repos/thesofproject/linux/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thesofproject/linux/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thesofproject/linux/git/refs{/sha}","trees_url":"https://api.github.com/repos/thesofproject/linux/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thesofproject/linux/statuses/{sha}","languages_url":"https://api.github.com/repos/thesofproject/linux/languages","stargazers_url":"https://api.github.com/repos/thesofproject/linux/stargazers","contributors_url":"https://api.github.com/repos/thesofproject/linux/contributors","subscribers_url":"https://api.github.com/repos/thesofproject/linux/subscribers","subscription_url":"https://api.github.com/repos/thesofproject/linux/subscription","commits_url":"https://api.github.com/repos/thesofproject/linux/commits{/sha}","git_commits_url":"https://api.github.com/repos/thesofproject/linux/git/commits{/sha}","comments_url":"https://api.github.com/repos/thesofproject/linux/comments{/number}","issue_comment_url":"https://api.github.com/repos/thesofproject/linux/issues/comments{/number}","contents_url":"https://api.github.com/repos/thesofproject/linux/contents/{+path}","compare_url":"https://api.github.com/repos/thesofproject/linux/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thesofproject/linux/merges","archive_url":"https://api.github.com/repos/thesofproject/linux/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thesofproject/linux/downloads","issues_url":"https://api.github.com/repos/thesofproject/linux/issues{/number}","pulls_url":"https://api.github.com/repos/thesofproject/linux/pulls{/number}","milestones_url":"https://api.github.com/repos/thesofproject/linux/milestones{/number}","notifications_url":"https://api.github.com/repos/thesofproject/linux/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thesofproject/linux/labels{/name}","releases_url":"https://api.github.com/repos/thesofproject/linux/releases{/id}","deployments_url":"https://api.github.com/repos/thesofproject/linux/deployments","created_at":"2018-05-31T16:47:45Z","updated_at":"2020-01-02T19:49:41Z","pushed_at":"2020-01-06T23:01:29Z","git_url":"git://github.com/thesofproject/linux.git","ssh_url":"[email protected]:thesofproject/linux.git","clone_url":"https://github.com/thesofproject/linux.git","svn_url":"https://github.com/thesofproject/linux","homepage":"","size":3350249,"stargazers_count":22,"watchers_count":22,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":126,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":55,"open_issues":126,"watchers":22,"default_branch":"topic/sof-dev"}},"_links":{"self":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/1659"},"html":{"href":"https://github.com/thesofproject/linux/pull/1659"},"issue":{"href":"https://api.github.com/repos/thesofproject/linux/issues/1659"},"comments":{"href":"https://api.github.com/repos/thesofproject/linux/issues/1659/comments"},"review_comments":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/1659/comments"},"review_comment":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thesofproject/linux/pulls/1659/commits"},"statuses":{"href":"https://api.github.com/repos/thesofproject/linux/statuses/7b822a2d42846339f213a0ae4f6bcb4a05fc9f66"}},"author_association":"MEMBER"}}	{ "id": 135611127, "name": "thesofproject/linux", "url": "https://api.github.com/repos/thesofproject/linux" }	{ "id": 7766921, "login": "ranj063", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/7766921?", "url": "https://api.github.com/users/ranj063" }	{ "id": 39773507, "login": "thesofproject", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/39773507?", "url": "https://api.github.com/orgs/thesofproject" }	2020-01-06T23:13:06	11214665852	{"actor":{"display_login":"ranj063"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/rlworkgroup/garage/pulls/comments/280286417","pull_request_review_id":232839224,"id":280286417,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MDI4NjQxNw==","diff_hunk":"@@ -1,30 +1,43 @@\n+import numpy as np\n import tensorflow as tf\n \n-from garage.tf.regressors import StochasticRegressor\n+from garage.tf.regressors import StochasticRegressor2\n+from tests.fixtures.models import SimpleGaussianMLPModel\n \n \n-class SimpleGaussianMLPRegressor(StochasticRegressor):\n- \"\"\"Simple GaussianMLPModel for testing.\"\"\"\n+class SimpleGaussianMLPRegressor(StochasticRegressor2):\n+ \"\"\"Simple GaussianMLPRegressor for testing.\"\"\"\n \n def __init__(self, input_shape, output_dim, name, args, kwargs):\n super().__init__(input_shape, output_dim, name)\n- self.param_values = tf.get_variable('{}/params'.format(name), [100])\n- tf.get_default_session().run(\n- tf.variables_initializer([self.param_values]))\n+\n+ self.model = SimpleGaussianMLPModel(output_dim=self._output_dim)\n+\n+ self._initialize()\n+\n+ def _initialize(self):\n+ input_ph = tf.placeholder(\n+ tf.float32, shape=(None, ) + self._input_shape)\n+ with tf.variable_scope(self._name) as self._variable_scope:\n+ self.model.build(input_ph)\n self.ys = None\n \n def fit(self, xs, ys):\n self.ys = ys\n \n def predict(self, xs):\n- return self.ys\n-\n- def get_param_values(self, args, *kwargs):\n- return tf.get_default_session().run(self.param_values)\n-\n- def set_param_values(self, flattened_params, args, *kwargs):\n- tf.get_default_session().run(\n- tf.assign(self.param_values, flattened_params))\n+ if self.ys is None:\n+ mean = tf.get_default_session().run(\n+ self.model.networks['default'].mean,\n+ feed_dict={self.model.networks['default'].input: xs})\n+ return np.full((len(xs), 1), mean)\n+ else:","path":"tests/fixtures/regressors/simple_gaussian_mlp_regressor.py","position":48,"original_position":48,"commit_id":"b41736df7163fd51c923a746a28a550bf8e21a74","original_commit_id":"b41736df7163fd51c923a746a28a550bf8e21a74","user":{"login":"ahtsan","id":10270515,"node_id":"MDQ6VXNlcjEwMjcwNTE1","avatar_url":"https://avatars1.githubusercontent.com/u/10270515?v=4","gravatar_id":"","url":"https://api.github.com/users/ahtsan","html_url":"https://github.com/ahtsan","followers_url":"https://api.github.com/users/ahtsan/followers","following_url":"https://api.github.com/users/ahtsan/following{/other_user}","gists_url":"https://api.github.com/users/ahtsan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahtsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahtsan/subscriptions","organizations_url":"https://api.github.com/users/ahtsan/orgs","repos_url":"https://api.github.com/users/ahtsan/repos","events_url":"https://api.github.com/users/ahtsan/events{/privacy}","received_events_url":"https://api.github.com/users/ahtsan/received_events","type":"User","site_admin":false},"body":"got it","created_at":"2019-05-02T04:27:18Z","updated_at":"2019-05-02T04:27:18Z","html_url":"https://github.com/rlworkgroup/garage/pull/641#discussion_r280286417","pull_request_url":"https://api.github.com/repos/rlworkgroup/garage/pulls/641","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rlworkgroup/garage/pulls/comments/280286417"},"html":{"href":"https://github.com/rlworkgroup/garage/pull/641#discussion_r280286417"},"pull_request":{"href":"https://api.github.com/repos/rlworkgroup/garage/pulls/641"}},"in_reply_to_id":279474657},"pull_request":{"url":"https://api.github.com/repos/rlworkgroup/garage/pulls/641","id":274082171,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc0MDgyMTcx","html_url":"https://github.com/rlworkgroup/garage/pull/641","diff_url":"https://github.com/rlworkgroup/garage/pull/641.diff","patch_url":"https://github.com/rlworkgroup/garage/pull/641.patch","issue_url":"https://api.github.com/repos/rlworkgroup/garage/issues/641","number":641,"state":"open","locked":false,"title":"Fix GaussianMLPRegressor and baseline for pickling","user":{"login":"ahtsan","id":10270515,"node_id":"MDQ6VXNlcjEwMjcwNTE1","avatar_url":"https://avatars1.githubusercontent.com/u/10270515?v=4","gravatar_id":"","url":"https://api.github.com/users/ahtsan","html_url":"https://github.com/ahtsan","followers_url":"https://api.github.com/users/ahtsan/followers","following_url":"https://api.github.com/users/ahtsan/following{/other_user}","gists_url":"https://api.github.com/users/ahtsan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahtsan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahtsan/subscriptions","organizations_url":"https://api.github.com/users/ahtsan/orgs","repos_url":"https://api.github.com/users/ahtsan/repos","events_url":"https://api.github.com/users/ahtsan/events{/privacy}","received_events_url":"https://api.github.com/users/ahtsan/received_events","type":"User","site_admin":false},"body":" New regressor base class which has the `get_params()` and `set_params()`. In the future, regressor should inherit from `Model` class and those methods should be put into `Model` class. For now I just put it in the regressor base class.\r\n* Make `GaussianMLPRegressorWithModel` and `GaussianMLPBaselinesWithModel` pickleable, which will close #511.\r\n* Modify `SimpleGaussianMLPRegressor` for testing.","created_at":"2019-04-27T04:36:46Z","updated_at":"2019-05-02T04:27:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68d44ac05578c131b67a00ee3fcd2ca4accfe9c5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"CatherineSue","id":8605658,"node_id":"MDQ6VXNlcjg2MDU2NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/8605658?v=4","gravatar_id":"","url":"https://api.github.com/users/CatherineSue","html_url":"https://github.com/CatherineSue","followers_url":"https://api.github.com/users/CatherineSue/followers","following_url":"https://api.github.com/users/CatherineSue/following{/other_user}","gists_url":"https://api.github.com/users/CatherineSue/gists{/gist_id}","starred_url":"https://api.github.com/users/CatherineSue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CatherineSue/subscriptions","organizations_url":"https://api.github.com/users/CatherineSue/orgs","repos_url":"https://api.github.com/users/CatherineSue/repos","events_url":"https://api.github.com/users/CatherineSue/events{/privacy}","received_events_url":"https://api.github.com/users/CatherineSue/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rlworkgroup/garage/pulls/641/commits","review_comments_url":"https://api.github.com/repos/rlworkgroup/garage/pulls/641/comments","review_comment_url":"https://api.github.com/repos/rlworkgroup/garage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rlworkgroup/garage/issues/641/comments","statuses_url":"https://api.github.com/repos/rlworkgroup/garage/statuses/b41736df7163fd51c923a746a28a550bf8e21a74","head":{"label":"rlworkgroup:gaussian_mlp_regressor_pickle","ref":"gaussian_mlp_regressor_pickle","sha":"b41736df7163fd51c923a746a28a550bf8e21a74","user":{"login":"rlworkgroup","id":39808070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODA4MDcw","avatar_url":"https://avatars0.githubusercontent.com/u/39808070?v=4","gravatar_id":"","url":"https://api.github.com/users/rlworkgroup","html_url":"https://github.com/rlworkgroup","followers_url":"https://api.github.com/users/rlworkgroup/followers","following_url":"https://api.github.com/users/rlworkgroup/following{/other_user}","gists_url":"https://api.github.com/users/rlworkgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/rlworkgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlworkgroup/subscriptions","organizations_url":"https://api.github.com/users/rlworkgroup/orgs","repos_url":"https://api.github.com/users/rlworkgroup/repos","events_url":"https://api.github.com/users/rlworkgroup/events{/privacy}","received_events_url":"https://api.github.com/users/rlworkgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":136846372,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY4NDYzNzI=","name":"garage","full_name":"rlworkgroup/garage","private":false,"owner":{"login":"rlworkgroup","id":39808070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODA4MDcw","avatar_url":"https://avatars0.githubusercontent.com/u/39808070?v=4","gravatar_id":"","url":"https://api.github.com/users/rlworkgroup","html_url":"https://github.com/rlworkgroup","followers_url":"https://api.github.com/users/rlworkgroup/followers","following_url":"https://api.github.com/users/rlworkgroup/following{/other_user}","gists_url":"https://api.github.com/users/rlworkgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/rlworkgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlworkgroup/subscriptions","organizations_url":"https://api.github.com/users/rlworkgroup/orgs","repos_url":"https://api.github.com/users/rlworkgroup/repos","events_url":"https://api.github.com/users/rlworkgroup/events{/privacy}","received_events_url":"https://api.github.com/users/rlworkgroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rlworkgroup/garage","description":"A framework for reproducible reinforcement learning research","fork":false,"url":"https://api.github.com/repos/rlworkgroup/garage","forks_url":"https://api.github.com/repos/rlworkgroup/garage/forks","keys_url":"https://api.github.com/repos/rlworkgroup/garage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rlworkgroup/garage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rlworkgroup/garage/teams","hooks_url":"https://api.github.com/repos/rlworkgroup/garage/hooks","issue_events_url":"https://api.github.com/repos/rlworkgroup/garage/issues/events{/number}","events_url":"https://api.github.com/repos/rlworkgroup/garage/events","assignees_url":"https://api.github.com/repos/rlworkgroup/garage/assignees{/user}","branches_url":"https://api.github.com/repos/rlworkgroup/garage/branches{/branch}","tags_url":"https://api.github.com/repos/rlworkgroup/garage/tags","blobs_url":"https://api.github.com/repos/rlworkgroup/garage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rlworkgroup/garage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rlworkgroup/garage/git/refs{/sha}","trees_url":"https://api.github.com/repos/rlworkgroup/garage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rlworkgroup/garage/statuses/{sha}","languages_url":"https://api.github.com/repos/rlworkgroup/garage/languages","stargazers_url":"https://api.github.com/repos/rlworkgroup/garage/stargazers","contributors_url":"https://api.github.com/repos/rlworkgroup/garage/contributors","subscribers_url":"https://api.github.com/repos/rlworkgroup/garage/subscribers","subscription_url":"https://api.github.com/repos/rlworkgroup/garage/subscription","commits_url":"https://api.github.com/repos/rlworkgroup/garage/commits{/sha}","git_commits_url":"https://api.github.com/repos/rlworkgroup/garage/git/commits{/sha}","comments_url":"https://api.github.com/repos/rlworkgroup/garage/comments{/number}","issue_comment_url":"https://api.github.com/repos/rlworkgroup/garage/issues/comments{/number}","contents_url":"https://api.github.com/repos/rlworkgroup/garage/contents/{+path}","compare_url":"https://api.github.com/repos/rlworkgroup/garage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rlworkgroup/garage/merges","archive_url":"https://api.github.com/repos/rlworkgroup/garage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rlworkgroup/garage/downloads","issues_url":"https://api.github.com/repos/rlworkgroup/garage/issues{/number}","pulls_url":"https://api.github.com/repos/rlworkgroup/garage/pulls{/number}","milestones_url":"https://api.github.com/repos/rlworkgroup/garage/milestones{/number}","notifications_url":"https://api.github.com/repos/rlworkgroup/garage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rlworkgroup/garage/labels{/name}","releases_url":"https://api.github.com/repos/rlworkgroup/garage/releases{/id}","deployments_url":"https://api.github.com/repos/rlworkgroup/garage/deployments","created_at":"2018-06-10T21:31:23Z","updated_at":"2019-04-30T23:05:38Z","pushed_at":"2019-05-01T16:07:40Z","git_url":"git://github.com/rlworkgroup/garage.git","ssh_url":"[email protected]:rlworkgroup/garage.git","clone_url":"https://github.com/rlworkgroup/garage.git","svn_url":"https://github.com/rlworkgroup/garage","homepage":"","size":9865,"stargazers_count":307,"watchers_count":307,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":95,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":46,"open_issues":95,"watchers":307,"default_branch":"master"}},"base":{"label":"rlworkgroup:master","ref":"master","sha":"3a3bdf17ca08052309016bdfa481a58c70112abd","user":{"login":"rlworkgroup","id":39808070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODA4MDcw","avatar_url":"https://avatars0.githubusercontent.com/u/39808070?v=4","gravatar_id":"","url":"https://api.github.com/users/rlworkgroup","html_url":"https://github.com/rlworkgroup","followers_url":"https://api.github.com/users/rlworkgroup/followers","following_url":"https://api.github.com/users/rlworkgroup/following{/other_user}","gists_url":"https://api.github.com/users/rlworkgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/rlworkgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlworkgroup/subscriptions","organizations_url":"https://api.github.com/users/rlworkgroup/orgs","repos_url":"https://api.github.com/users/rlworkgroup/repos","events_url":"https://api.github.com/users/rlworkgroup/events{/privacy}","received_events_url":"https://api.github.com/users/rlworkgroup/received_events","type":"Organization","site_admin":false},"repo":{"id":136846372,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY4NDYzNzI=","name":"garage","full_name":"rlworkgroup/garage","private":false,"owner":{"login":"rlworkgroup","id":39808070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODA4MDcw","avatar_url":"https://avatars0.githubusercontent.com/u/39808070?v=4","gravatar_id":"","url":"https://api.github.com/users/rlworkgroup","html_url":"https://github.com/rlworkgroup","followers_url":"https://api.github.com/users/rlworkgroup/followers","following_url":"https://api.github.com/users/rlworkgroup/following{/other_user}","gists_url":"https://api.github.com/users/rlworkgroup/gists{/gist_id}","starred_url":"https://api.github.com/users/rlworkgroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rlworkgroup/subscriptions","organizations_url":"https://api.github.com/users/rlworkgroup/orgs","repos_url":"https://api.github.com/users/rlworkgroup/repos","events_url":"https://api.github.com/users/rlworkgroup/events{/privacy}","received_events_url":"https://api.github.com/users/rlworkgroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rlworkgroup/garage","description":"A framework for reproducible reinforcement learning research","fork":false,"url":"https://api.github.com/repos/rlworkgroup/garage","forks_url":"https://api.github.com/repos/rlworkgroup/garage/forks","keys_url":"https://api.github.com/repos/rlworkgroup/garage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rlworkgroup/garage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rlworkgroup/garage/teams","hooks_url":"https://api.github.com/repos/rlworkgroup/garage/hooks","issue_events_url":"https://api.github.com/repos/rlworkgroup/garage/issues/events{/number}","events_url":"https://api.github.com/repos/rlworkgroup/garage/events","assignees_url":"https://api.github.com/repos/rlworkgroup/garage/assignees{/user}","branches_url":"https://api.github.com/repos/rlworkgroup/garage/branches{/branch}","tags_url":"https://api.github.com/repos/rlworkgroup/garage/tags","blobs_url":"https://api.github.com/repos/rlworkgroup/garage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rlworkgroup/garage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rlworkgroup/garage/git/refs{/sha}","trees_url":"https://api.github.com/repos/rlworkgroup/garage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rlworkgroup/garage/statuses/{sha}","languages_url":"https://api.github.com/repos/rlworkgroup/garage/languages","stargazers_url":"https://api.github.com/repos/rlworkgroup/garage/stargazers","contributors_url":"https://api.github.com/repos/rlworkgroup/garage/contributors","subscribers_url":"https://api.github.com/repos/rlworkgroup/garage/subscribers","subscription_url":"https://api.github.com/repos/rlworkgroup/garage/subscription","commits_url":"https://api.github.com/repos/rlworkgroup/garage/commits{/sha}","git_commits_url":"https://api.github.com/repos/rlworkgroup/garage/git/commits{/sha}","comments_url":"https://api.github.com/repos/rlworkgroup/garage/comments{/number}","issue_comment_url":"https://api.github.com/repos/rlworkgroup/garage/issues/comments{/number}","contents_url":"https://api.github.com/repos/rlworkgroup/garage/contents/{+path}","compare_url":"https://api.github.com/repos/rlworkgroup/garage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rlworkgroup/garage/merges","archive_url":"https://api.github.com/repos/rlworkgroup/garage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rlworkgroup/garage/downloads","issues_url":"https://api.github.com/repos/rlworkgroup/garage/issues{/number}","pulls_url":"https://api.github.com/repos/rlworkgroup/garage/pulls{/number}","milestones_url":"https://api.github.com/repos/rlworkgroup/garage/milestones{/number}","notifications_url":"https://api.github.com/repos/rlworkgroup/garage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rlworkgroup/garage/labels{/name}","releases_url":"https://api.github.com/repos/rlworkgroup/garage/releases{/id}","deployments_url":"https://api.github.com/repos/rlworkgroup/garage/deployments","created_at":"2018-06-10T21:31:23Z","updated_at":"2019-04-30T23:05:38Z","pushed_at":"2019-05-01T16:07:40Z","git_url":"git://github.com/rlworkgroup/garage.git","ssh_url":"[email protected]:rlworkgroup/garage.git","clone_url":"https://github.com/rlworkgroup/garage.git","svn_url":"https://github.com/rlworkgroup/garage","homepage":"","size":9865,"stargazers_count":307,"watchers_count":307,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":95,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":46,"open_issues":95,"watchers":307,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rlworkgroup/garage/pulls/641"},"html":{"href":"https://github.com/rlworkgroup/garage/pull/641"},"issue":{"href":"https://api.github.com/repos/rlworkgroup/garage/issues/641"},"comments":{"href":"https://api.github.com/repos/rlworkgroup/garage/issues/641/comments"},"review_comments":{"href":"https://api.github.com/repos/rlworkgroup/garage/pulls/641/comments"},"review_comment":{"href":"https://api.github.com/repos/rlworkgroup/garage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rlworkgroup/garage/pulls/641/commits"},"statuses":{"href":"https://api.github.com/repos/rlworkgroup/garage/statuses/b41736df7163fd51c923a746a28a550bf8e21a74"}},"author_association":"CONTRIBUTOR"}}	{ "id": 136846372, "name": "rlworkgroup/garage", "url": "https://api.github.com/repos/rlworkgroup/garage" }	{ "id": 10270515, "login": "ahtsan", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/10270515?", "url": "https://api.github.com/users/ahtsan" }	{ "id": 39808070, "login": "rlworkgroup", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/39808070?", "url": "https://api.github.com/orgs/rlworkgroup" }	2019-05-02T04:27:18	9548297528	{"actor":{"display_login":"ahtsan"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/sourcelevel/guidelines/pulls/comments/312178592","pull_request_review_id":272754395,"id":312178592,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMjE3ODU5Mg==","diff_hunk":"@@ -32,13 +32,28 @@ your context to review your PR\n We already have some Pull Requests templates according to the repository, feel free to\n suggest enhancements for them.\n \n-### Metadata\n+### Labels\n+\n+Labels are a great way to organize different types of PR\n \n * Always use labels to allow filtering and better usability in listing\n-* As we're a small team, there is no need to indicate `Reviewers`, as all of us probably will\n do code review\n+* Select a label that best describes the purpose of PR\n+\n+### Reviewers\n+\n+* You can select `Sourcelevel` team/organization as `Reviewers` to notify everybody, so them anyone reviews your PR.\n+* If you want a review from a specific member, you can select him too.\n * Sure that, if you want, you can indicate `Reviewers` that has more knowledge about that\n piece of code you're changing or ask for some extra guidance on it\n+* Select as Reviewer who did'nt participated of development of the code\n+\n+### Assignees\n+\n+Assignees are persons that worked with you in your PR or specific issues.","path":"resources/pull_requests.md","position":24,"original_position":24,"commit_id":"3374bda9896edceb2c2bcd986f58d9b567d1f8db","original_commit_id":"3374bda9896edceb2c2bcd986f58d9b567d1f8db","user":{"login":"wevtimoteo","id":645452,"node_id":"MDQ6VXNlcjY0NTQ1Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/645452?v=4","gravatar_id":"","url":"https://api.github.com/users/wevtimoteo","html_url":"https://github.com/wevtimoteo","followers_url":"https://api.github.com/users/wevtimoteo/followers","following_url":"https://api.github.com/users/wevtimoteo/following{/other_user}","gists_url":"https://api.github.com/users/wevtimoteo/gists{/gist_id}","starred_url":"https://api.github.com/users/wevtimoteo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wevtimoteo/subscriptions","organizations_url":"https://api.github.com/users/wevtimoteo/orgs","repos_url":"https://api.github.com/users/wevtimoteo/repos","events_url":"https://api.github.com/users/wevtimoteo/events{/privacy}","received_events_url":"https://api.github.com/users/wevtimoteo/received_events","type":"User","site_admin":false},"body":"Fix typo `persons/people`","created_at":"2019-08-08T18:20:53Z","updated_at":"2019-08-08T18:20:53Z","html_url":"https://github.com/sourcelevel/guidelines/pull/7#discussion_r312178592","pull_request_url":"https://api.github.com/repos/sourcelevel/guidelines/pulls/7","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sourcelevel/guidelines/pulls/comments/312178592"},"html":{"href":"https://github.com/sourcelevel/guidelines/pull/7#discussion_r312178592"},"pull_request":{"href":"https://api.github.com/repos/sourcelevel/guidelines/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/sourcelevel/guidelines/pulls/7","id":305692168,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA1NjkyMTY4","html_url":"https://github.com/sourcelevel/guidelines/pull/7","diff_url":"https://github.com/sourcelevel/guidelines/pull/7.diff","patch_url":"https://github.com/sourcelevel/guidelines/pull/7.patch","issue_url":"https://api.github.com/repos/sourcelevel/guidelines/issues/7","number":7,"state":"open","locked":false,"title":"Introduce Labels, reviewers and assignees workflow","user":{"login":"garaujodev","id":6307567,"node_id":"MDQ6VXNlcjYzMDc1Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/6307567?v=4","gravatar_id":"","url":"https://api.github.com/users/garaujodev","html_url":"https://github.com/garaujodev","followers_url":"https://api.github.com/users/garaujodev/followers","following_url":"https://api.github.com/users/garaujodev/following{/other_user}","gists_url":"https://api.github.com/users/garaujodev/gists{/gist_id}","starred_url":"https://api.github.com/users/garaujodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garaujodev/subscriptions","organizations_url":"https://api.github.com/users/garaujodev/orgs","repos_url":"https://api.github.com/users/garaujodev/repos","events_url":"https://api.github.com/users/garaujodev/events{/privacy}","received_events_url":"https://api.github.com/users/garaujodev/received_events","type":"User","site_admin":false},"body":"## Motivation\r\n\r\nWe have an outdated workflow in the PR Opening Guideline, that doesn't help in how to use Reviewers, Assignees, and Labels. \r\n\r\n## Proposed Solution\r\n\r\nInsert these workflows in our Guidelines.\r\n","created_at":"2019-08-08T18:16:36Z","updated_at":"2019-08-08T18:20:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"daa14576b4da51d49dc3ae0af06cbcecab652b6a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"beatrizChagas","id":9493689,"node_id":"MDQ6VXNlcjk0OTM2ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/9493689?v=4","gravatar_id":"","url":"https://api.github.com/users/beatrizChagas","html_url":"https://github.com/beatrizChagas","followers_url":"https://api.github.com/users/beatrizChagas/followers","following_url":"https://api.github.com/users/beatrizChagas/following{/other_user}","gists_url":"https://api.github.com/users/beatrizChagas/gists{/gist_id}","starred_url":"https://api.github.com/users/beatrizChagas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beatrizChagas/subscriptions","organizations_url":"https://api.github.com/users/beatrizChagas/orgs","repos_url":"https://api.github.com/users/beatrizChagas/repos","events_url":"https://api.github.com/users/beatrizChagas/events{/privacy}","received_events_url":"https://api.github.com/users/beatrizChagas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1412230892,"node_id":"MDU6TGFiZWwxNDEyMjMwODky","url":"https://api.github.com/repos/sourcelevel/guidelines/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/sourcelevel/guidelines/pulls/7/commits","review_comments_url":"https://api.github.com/repos/sourcelevel/guidelines/pulls/7/comments","review_comment_url":"https://api.github.com/repos/sourcelevel/guidelines/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sourcelevel/guidelines/issues/7/comments","statuses_url":"https://api.github.com/repos/sourcelevel/guidelines/statuses/3374bda9896edceb2c2bcd986f58d9b567d1f8db","head":{"label":"sourcelevel:ga-add-reviewers-assignees-workflow","ref":"ga-add-reviewers-assignees-workflow","sha":"3374bda9896edceb2c2bcd986f58d9b567d1f8db","user":{"login":"sourcelevel","id":39925474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5OTI1NDc0","avatar_url":"https://avatars2.githubusercontent.com/u/39925474?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcelevel","html_url":"https://github.com/sourcelevel","followers_url":"https://api.github.com/users/sourcelevel/followers","following_url":"https://api.github.com/users/sourcelevel/following{/other_user}","gists_url":"https://api.github.com/users/sourcelevel/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcelevel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcelevel/subscriptions","organizations_url":"https://api.github.com/users/sourcelevel/orgs","repos_url":"https://api.github.com/users/sourcelevel/repos","events_url":"https://api.github.com/users/sourcelevel/events{/privacy}","received_events_url":"https://api.github.com/users/sourcelevel/received_events","type":"Organization","site_admin":false},"repo":{"id":192600535,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI2MDA1MzU=","name":"guidelines","full_name":"sourcelevel/guidelines","private":false,"owner":{"login":"sourcelevel","id":39925474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5OTI1NDc0","avatar_url":"https://avatars2.githubusercontent.com/u/39925474?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcelevel","html_url":"https://github.com/sourcelevel","followers_url":"https://api.github.com/users/sourcelevel/followers","following_url":"https://api.github.com/users/sourcelevel/following{/other_user}","gists_url":"https://api.github.com/users/sourcelevel/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcelevel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcelevel/subscriptions","organizations_url":"https://api.github.com/users/sourcelevel/orgs","repos_url":"https://api.github.com/users/sourcelevel/repos","events_url":"https://api.github.com/users/sourcelevel/events{/privacy}","received_events_url":"https://api.github.com/users/sourcelevel/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sourcelevel/guidelines","description":"How we communicate :ant:","fork":false,"url":"https://api.github.com/repos/sourcelevel/guidelines","forks_url":"https://api.github.com/repos/sourcelevel/guidelines/forks","keys_url":"https://api.github.com/repos/sourcelevel/guidelines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcelevel/guidelines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcelevel/guidelines/teams","hooks_url":"https://api.github.com/repos/sourcelevel/guidelines/hooks","issue_events_url":"https://api.github.com/repos/sourcelevel/guidelines/issues/events{/number}","events_url":"https://api.github.com/repos/sourcelevel/guidelines/events","assignees_url":"https://api.github.com/repos/sourcelevel/guidelines/assignees{/user}","branches_url":"https://api.github.com/repos/sourcelevel/guidelines/branches{/branch}","tags_url":"https://api.github.com/repos/sourcelevel/guidelines/tags","blobs_url":"https://api.github.com/repos/sourcelevel/guidelines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcelevel/guidelines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcelevel/guidelines/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcelevel/guidelines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcelevel/guidelines/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcelevel/guidelines/languages","stargazers_url":"https://api.github.com/repos/sourcelevel/guidelines/stargazers","contributors_url":"https://api.github.com/repos/sourcelevel/guidelines/contributors","subscribers_url":"https://api.github.com/repos/sourcelevel/guidelines/subscribers","subscription_url":"https://api.github.com/repos/sourcelevel/guidelines/subscription","commits_url":"https://api.github.com/repos/sourcelevel/guidelines/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcelevel/guidelines/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcelevel/guidelines/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcelevel/guidelines/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcelevel/guidelines/contents/{+path}","compare_url":"https://api.github.com/repos/sourcelevel/guidelines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcelevel/guidelines/merges","archive_url":"https://api.github.com/repos/sourcelevel/guidelines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcelevel/guidelines/downloads","issues_url":"https://api.github.com/repos/sourcelevel/guidelines/issues{/number}","pulls_url":"https://api.github.com/repos/sourcelevel/guidelines/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcelevel/guidelines/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcelevel/guidelines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcelevel/guidelines/labels{/name}","releases_url":"https://api.github.com/repos/sourcelevel/guidelines/releases{/id}","deployments_url":"https://api.github.com/repos/sourcelevel/guidelines/deployments","created_at":"2019-06-18T19:28:20Z","updated_at":"2019-07-31T17:38:59Z","pushed_at":"2019-08-08T18:16:37Z","git_url":"git://github.com/sourcelevel/guidelines.git","ssh_url":"[email protected]:sourcelevel/guidelines.git","clone_url":"https://github.com/sourcelevel/guidelines.git","svn_url":"https://github.com/sourcelevel/guidelines","homepage":null,"size":82,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"sourcelevel:master","ref":"master","sha":"5cdfacaaebf675f814686144225be98d0627c6ab","user":{"login":"sourcelevel","id":39925474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5OTI1NDc0","avatar_url":"https://avatars2.githubusercontent.com/u/39925474?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcelevel","html_url":"https://github.com/sourcelevel","followers_url":"https://api.github.com/users/sourcelevel/followers","following_url":"https://api.github.com/users/sourcelevel/following{/other_user}","gists_url":"https://api.github.com/users/sourcelevel/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcelevel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcelevel/subscriptions","organizations_url":"https://api.github.com/users/sourcelevel/orgs","repos_url":"https://api.github.com/users/sourcelevel/repos","events_url":"https://api.github.com/users/sourcelevel/events{/privacy}","received_events_url":"https://api.github.com/users/sourcelevel/received_events","type":"Organization","site_admin":false},"repo":{"id":192600535,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI2MDA1MzU=","name":"guidelines","full_name":"sourcelevel/guidelines","private":false,"owner":{"login":"sourcelevel","id":39925474,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5OTI1NDc0","avatar_url":"https://avatars2.githubusercontent.com/u/39925474?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcelevel","html_url":"https://github.com/sourcelevel","followers_url":"https://api.github.com/users/sourcelevel/followers","following_url":"https://api.github.com/users/sourcelevel/following{/other_user}","gists_url":"https://api.github.com/users/sourcelevel/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcelevel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcelevel/subscriptions","organizations_url":"https://api.github.com/users/sourcelevel/orgs","repos_url":"https://api.github.com/users/sourcelevel/repos","events_url":"https://api.github.com/users/sourcelevel/events{/privacy}","received_events_url":"https://api.github.com/users/sourcelevel/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sourcelevel/guidelines","description":"How we communicate :ant:","fork":false,"url":"https://api.github.com/repos/sourcelevel/guidelines","forks_url":"https://api.github.com/repos/sourcelevel/guidelines/forks","keys_url":"https://api.github.com/repos/sourcelevel/guidelines/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcelevel/guidelines/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcelevel/guidelines/teams","hooks_url":"https://api.github.com/repos/sourcelevel/guidelines/hooks","issue_events_url":"https://api.github.com/repos/sourcelevel/guidelines/issues/events{/number}","events_url":"https://api.github.com/repos/sourcelevel/guidelines/events","assignees_url":"https://api.github.com/repos/sourcelevel/guidelines/assignees{/user}","branches_url":"https://api.github.com/repos/sourcelevel/guidelines/branches{/branch}","tags_url":"https://api.github.com/repos/sourcelevel/guidelines/tags","blobs_url":"https://api.github.com/repos/sourcelevel/guidelines/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcelevel/guidelines/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcelevel/guidelines/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcelevel/guidelines/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcelevel/guidelines/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcelevel/guidelines/languages","stargazers_url":"https://api.github.com/repos/sourcelevel/guidelines/stargazers","contributors_url":"https://api.github.com/repos/sourcelevel/guidelines/contributors","subscribers_url":"https://api.github.com/repos/sourcelevel/guidelines/subscribers","subscription_url":"https://api.github.com/repos/sourcelevel/guidelines/subscription","commits_url":"https://api.github.com/repos/sourcelevel/guidelines/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcelevel/guidelines/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcelevel/guidelines/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcelevel/guidelines/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcelevel/guidelines/contents/{+path}","compare_url":"https://api.github.com/repos/sourcelevel/guidelines/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcelevel/guidelines/merges","archive_url":"https://api.github.com/repos/sourcelevel/guidelines/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcelevel/guidelines/downloads","issues_url":"https://api.github.com/repos/sourcelevel/guidelines/issues{/number}","pulls_url":"https://api.github.com/repos/sourcelevel/guidelines/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcelevel/guidelines/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcelevel/guidelines/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcelevel/guidelines/labels{/name}","releases_url":"https://api.github.com/repos/sourcelevel/guidelines/releases{/id}","deployments_url":"https://api.github.com/repos/sourcelevel/guidelines/deployments","created_at":"2019-06-18T19:28:20Z","updated_at":"2019-07-31T17:38:59Z","pushed_at":"2019-08-08T18:16:37Z","git_url":"git://github.com/sourcelevel/guidelines.git","ssh_url":"[email protected]:sourcelevel/guidelines.git","clone_url":"https://github.com/sourcelevel/guidelines.git","svn_url":"https://github.com/sourcelevel/guidelines","homepage":null,"size":82,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sourcelevel/guidelines/pulls/7"},"html":{"href":"https://github.com/sourcelevel/guidelines/pull/7"},"issue":{"href":"https://api.github.com/repos/sourcelevel/guidelines/issues/7"},"comments":{"href":"https://api.github.com/repos/sourcelevel/guidelines/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/sourcelevel/guidelines/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/sourcelevel/guidelines/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sourcelevel/guidelines/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/sourcelevel/guidelines/statuses/3374bda9896edceb2c2bcd986f58d9b567d1f8db"}},"author_association":"MEMBER"}}	{ "id": 192600535, "name": "sourcelevel/guidelines", "url": "https://api.github.com/repos/sourcelevel/guidelines" }	{ "id": 645452, "login": "wevtimoteo", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/645452?", "url": "https://api.github.com/users/wevtimoteo" }	{ "id": 39925474, "login": "sourcelevel", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/39925474?", "url": "https://api.github.com/orgs/sourcelevel" }	2019-08-08T18:20:53	10175854003	{"actor":{"display_login":"wevtimoteo"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/mlflow/mlflow/pulls/comments/290983385","pull_request_review_id":246317689,"id":290983385,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MDk4MzM4NQ==","diff_hunk":"@@ -16,29 +17,42 @@\n UpdateRun, LogMetric, LogParam, SetTag, ListExperiments, \\\n DeleteExperiment, RestoreExperiment, RestoreRun, DeleteRun, UpdateExperiment, LogBatch\n from mlflow.store.artifact_repository_registry import get_artifact_repository\n-from mlflow.tracking.utils import _is_database_uri, _is_local_uri\n+from mlflow.tracking.utils import TrackingStoreRegistry\n from mlflow.utils.proto_json_utils import message_to_json, parse_dict\n from mlflow.utils.search_utils import SearchFilter\n from mlflow.utils.validation import _validate_batch_log_api_req\n \n _store = None\n \n \n+def _get_file_store(store_uri, artifact_uri):\n+ from mlflow.store.file_store import FileStore\n+ return FileStore(store_uri, artifact_uri)\n+\n+\n+def _get_sqlalchemy_store(store_uri, artifact_uri):\n+ from mlflow.store.sqlalchemy_store import SqlAlchemyStore\n+ return SqlAlchemyStore(store_uri, artifact_uri)\n+\n+\n+_tracking_store_registry = TrackingStoreRegistry()\n+_tracking_store_registry.register('', _get_file_store)\n+_tracking_store_registry.register('file', _get_file_store)\n+for scheme in DATABASE_ENGINES:\n+ _tracking_store_registry.register(scheme, _get_sqlalchemy_store)\n+\n+\n def _get_store(backend_store_uri=None, default_artifact_root=None):\n from mlflow.server import BACKEND_STORE_URI_ENV_VAR, ARTIFACT_ROOT_ENV_VAR\n global _store\n if _store is None:\n- store_dir = backend_store_uri or os.environ.get(BACKEND_STORE_URI_ENV_VAR, None)\n+ store_uri = backend_store_uri or os.environ.get(BACKEND_STORE_URI_ENV_VAR, None)\n artifact_root = default_artifact_root or os.environ.get(ARTIFACT_ROOT_ENV_VAR, None)\n- if _is_database_uri(store_dir):\n- from mlflow.store.sqlalchemy_store import SqlAlchemyStore\n- _store = SqlAlchemyStore(store_dir, artifact_root)\n- elif _is_local_uri(store_dir):\n- from mlflow.store.file_store import FileStore\n- _store = FileStore(store_dir, artifact_root)\n- else:\n+ try:\n+ _store = _tracking_store_registry.get_store(store_uri, artifact_root)\n+ except MlflowException:","path":"mlflow/server/handlers.py","position":54,"original_position":54,"commit_id":"6b0204f57e00115d5abc164638a6dd324caef695","original_commit_id":"6b0204f57e00115d5abc164638a6dd324caef695","user":{"login":"sueann","id":4411489,"node_id":"MDQ6VXNlcjQ0MTE0ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/4411489?v=4","gravatar_id":"","url":"https://api.github.com/users/sueann","html_url":"https://github.com/sueann","followers_url":"https://api.github.com/users/sueann/followers","following_url":"https://api.github.com/users/sueann/following{/other_user}","gists_url":"https://api.github.com/users/sueann/gists{/gist_id}","starred_url":"https://api.github.com/users/sueann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sueann/subscriptions","organizations_url":"https://api.github.com/users/sueann/orgs","repos_url":"https://api.github.com/users/sueann/repos","events_url":"https://api.github.com/users/sueann/events{/privacy}","received_events_url":"https://api.github.com/users/sueann/received_events","type":"User","site_admin":false},"body":"This is a bit dodgy since it can mask other failures. But the `TrackingStoreRegistry` error is not user-friendly here. Would it make sense to change the error on the `TrackingStoreRegistry` to something like \"Unexpected backend store URI scheme: {}\" as a compromise? ","created_at":"2019-06-06T00:23:07Z","updated_at":"2019-06-06T00:23:58Z","html_url":"https://github.com/mlflow/mlflow/pull/1411#discussion_r290983385","pull_request_url":"https://api.github.com/repos/mlflow/mlflow/pulls/1411","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mlflow/mlflow/pulls/comments/290983385"},"html":{"href":"https://github.com/mlflow/mlflow/pull/1411#discussion_r290983385"},"pull_request":{"href":"https://api.github.com/repos/mlflow/mlflow/pulls/1411"}}},"pull_request":{"url":"https://api.github.com/repos/mlflow/mlflow/pulls/1411","id":285597878,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1NTk3ODc4","html_url":"https://github.com/mlflow/mlflow/pull/1411","diff_url":"https://github.com/mlflow/mlflow/pull/1411.diff","patch_url":"https://github.com/mlflow/mlflow/pull/1411.patch","issue_url":"https://api.github.com/repos/mlflow/mlflow/issues/1411","number":1411,"state":"open","locked":false,"title":"Fix CLI server and ui commands to work with db driver","user":{"login":"sueann","id":4411489,"node_id":"MDQ6VXNlcjQ0MTE0ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/4411489?v=4","gravatar_id":"","url":"https://api.github.com/users/sueann","html_url":"https://github.com/sueann","followers_url":"https://api.github.com/users/sueann/followers","following_url":"https://api.github.com/users/sueann/following{/other_user}","gists_url":"https://api.github.com/users/sueann/gists{/gist_id}","starred_url":"https://api.github.com/users/sueann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sueann/subscriptions","organizations_url":"https://api.github.com/users/sueann/orgs","repos_url":"https://api.github.com/users/sueann/repos","events_url":"https://api.github.com/users/sueann/events{/privacy}","received_events_url":"https://api.github.com/users/sueann/received_events","type":"User","site_admin":false},"body":"## What changes are proposed in this pull request?\r\n \r\n#1297 & #1374 added support for using non-default drivers for database URIs, but they do not work with the CLI commands `mlflow server` and `mlflow ui`. Adding support here.\r\n \r\n## How is this patch tested?\r\n \r\nManual tests:\r\n```\r\nmlflow server --backend-store-uri mysql+pymysql://root:password@localhost/mlflow --default-artifact-root /Users/sueann/mlflow-data\r\n```\r\n-> make sure you can create experiments and log metrics.\r\n \r\n## Release Notes\r\n \r\n### Is this a user-facing change? \r\n\r\n- [ ] No. You can skip the rest of this section.\r\n- [X] Yes. Give a description of this change to be included in the release notes for MLflow users.\r\n \r\nCLI commands ``mlflow server`` and ``mlflow ui`` support backend tracking URIs containing non-default database drivers for sqlalchemy.\r\n \r\n### What component(s) does this PR affect?\r\n \r\n- [X] CLI \r\n- [X] Tracking\r\n\r\n### How should the PR be classified in the release notes? Choose one:\r\n \r\n- [X] `rn/feature` - A new user-facing feature worth mentioning in the release notes\r\n","created_at":"2019-06-06T00:19:49Z","updated_at":"2019-06-06T00:23:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9079248b9d5174329599ba59e57d05c114c8d244","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mparkhe","id":6900999,"node_id":"MDQ6VXNlcjY5MDA5OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6900999?v=4","gravatar_id":"","url":"https://api.github.com/users/mparkhe","html_url":"https://github.com/mparkhe","followers_url":"https://api.github.com/users/mparkhe/followers","following_url":"https://api.github.com/users/mparkhe/following{/other_user}","gists_url":"https://api.github.com/users/mparkhe/gists{/gist_id}","starred_url":"https://api.github.com/users/mparkhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mparkhe/subscriptions","organizations_url":"https://api.github.com/users/mparkhe/orgs","repos_url":"https://api.github.com/users/mparkhe/repos","events_url":"https://api.github.com/users/mparkhe/events{/privacy}","received_events_url":"https://api.github.com/users/mparkhe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mlflow/mlflow/pulls/1411/commits","review_comments_url":"https://api.github.com/repos/mlflow/mlflow/pulls/1411/comments","review_comment_url":"https://api.github.com/repos/mlflow/mlflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mlflow/mlflow/issues/1411/comments","statuses_url":"https://api.github.com/repos/mlflow/mlflow/statuses/6b0204f57e00115d5abc164638a6dd324caef695","head":{"label":"sueann:fix_driver","ref":"fix_driver","sha":"6b0204f57e00115d5abc164638a6dd324caef695","user":{"login":"sueann","id":4411489,"node_id":"MDQ6VXNlcjQ0MTE0ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/4411489?v=4","gravatar_id":"","url":"https://api.github.com/users/sueann","html_url":"https://github.com/sueann","followers_url":"https://api.github.com/users/sueann/followers","following_url":"https://api.github.com/users/sueann/following{/other_user}","gists_url":"https://api.github.com/users/sueann/gists{/gist_id}","starred_url":"https://api.github.com/users/sueann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sueann/subscriptions","organizations_url":"https://api.github.com/users/sueann/orgs","repos_url":"https://api.github.com/users/sueann/repos","events_url":"https://api.github.com/users/sueann/events{/privacy}","received_events_url":"https://api.github.com/users/sueann/received_events","type":"User","site_admin":false},"repo":{"id":139075718,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwNzU3MTg=","name":"mlflow","full_name":"sueann/mlflow","private":false,"owner":{"login":"sueann","id":4411489,"node_id":"MDQ6VXNlcjQ0MTE0ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/4411489?v=4","gravatar_id":"","url":"https://api.github.com/users/sueann","html_url":"https://github.com/sueann","followers_url":"https://api.github.com/users/sueann/followers","following_url":"https://api.github.com/users/sueann/following{/other_user}","gists_url":"https://api.github.com/users/sueann/gists{/gist_id}","starred_url":"https://api.github.com/users/sueann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sueann/subscriptions","organizations_url":"https://api.github.com/users/sueann/orgs","repos_url":"https://api.github.com/users/sueann/repos","events_url":"https://api.github.com/users/sueann/events{/privacy}","received_events_url":"https://api.github.com/users/sueann/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sueann/mlflow","description":"Open source platform for the complete machine learning lifecycle","fork":true,"url":"https://api.github.com/repos/sueann/mlflow","forks_url":"https://api.github.com/repos/sueann/mlflow/forks","keys_url":"https://api.github.com/repos/sueann/mlflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sueann/mlflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sueann/mlflow/teams","hooks_url":"https://api.github.com/repos/sueann/mlflow/hooks","issue_events_url":"https://api.github.com/repos/sueann/mlflow/issues/events{/number}","events_url":"https://api.github.com/repos/sueann/mlflow/events","assignees_url":"https://api.github.com/repos/sueann/mlflow/assignees{/user}","branches_url":"https://api.github.com/repos/sueann/mlflow/branches{/branch}","tags_url":"https://api.github.com/repos/sueann/mlflow/tags","blobs_url":"https://api.github.com/repos/sueann/mlflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sueann/mlflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sueann/mlflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/sueann/mlflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sueann/mlflow/statuses/{sha}","languages_url":"https://api.github.com/repos/sueann/mlflow/languages","stargazers_url":"https://api.github.com/repos/sueann/mlflow/stargazers","contributors_url":"https://api.github.com/repos/sueann/mlflow/contributors","subscribers_url":"https://api.github.com/repos/sueann/mlflow/subscribers","subscription_url":"https://api.github.com/repos/sueann/mlflow/subscription","commits_url":"https://api.github.com/repos/sueann/mlflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/sueann/mlflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/sueann/mlflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/sueann/mlflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/sueann/mlflow/contents/{+path}","compare_url":"https://api.github.com/repos/sueann/mlflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sueann/mlflow/merges","archive_url":"https://api.github.com/repos/sueann/mlflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sueann/mlflow/downloads","issues_url":"https://api.github.com/repos/sueann/mlflow/issues{/number}","pulls_url":"https://api.github.com/repos/sueann/mlflow/pulls{/number}","milestones_url":"https://api.github.com/repos/sueann/mlflow/milestones{/number}","notifications_url":"https://api.github.com/repos/sueann/mlflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sueann/mlflow/labels{/name}","releases_url":"https://api.github.com/repos/sueann/mlflow/releases{/id}","deployments_url":"https://api.github.com/repos/sueann/mlflow/deployments","created_at":"2018-06-28T22:52:40Z","updated_at":"2018-07-30T20:18:55Z","pushed_at":"2019-06-05T22:55:06Z","git_url":"git://github.com/sueann/mlflow.git","ssh_url":"[email protected]:sueann/mlflow.git","clone_url":"https://github.com/sueann/mlflow.git","svn_url":"https://github.com/sueann/mlflow","homepage":"https://mlflow.org","size":9452,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"mlflow:master","ref":"master","sha":"d768b14d32630cae965bd2097ae98e7b4dd78162","user":{"login":"mlflow","id":39938107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5OTM4MTA3","avatar_url":"https://avatars3.githubusercontent.com/u/39938107?v=4","gravatar_id":"","url":"https://api.github.com/users/mlflow","html_url":"https://github.com/mlflow","followers_url":"https://api.github.com/users/mlflow/followers","following_url":"https://api.github.com/users/mlflow/following{/other_user}","gists_url":"https://api.github.com/users/mlflow/gists{/gist_id}","starred_url":"https://api.github.com/users/mlflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlflow/subscriptions","organizations_url":"https://api.github.com/users/mlflow/orgs","repos_url":"https://api.github.com/users/mlflow/repos","events_url":"https://api.github.com/users/mlflow/events{/privacy}","received_events_url":"https://api.github.com/users/mlflow/received_events","type":"Organization","site_admin":false},"repo":{"id":136202695,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYyMDI2OTU=","name":"mlflow","full_name":"mlflow/mlflow","private":false,"owner":{"login":"mlflow","id":39938107,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5OTM4MTA3","avatar_url":"https://avatars3.githubusercontent.com/u/39938107?v=4","gravatar_id":"","url":"https://api.github.com/users/mlflow","html_url":"https://github.com/mlflow","followers_url":"https://api.github.com/users/mlflow/followers","following_url":"https://api.github.com/users/mlflow/following{/other_user}","gists_url":"https://api.github.com/users/mlflow/gists{/gist_id}","starred_url":"https://api.github.com/users/mlflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlflow/subscriptions","organizations_url":"https://api.github.com/users/mlflow/orgs","repos_url":"https://api.github.com/users/mlflow/repos","events_url":"https://api.github.com/users/mlflow/events{/privacy}","received_events_url":"https://api.github.com/users/mlflow/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mlflow/mlflow","description":"Open source platform for the machine learning lifecycle","fork":false,"url":"https://api.github.com/repos/mlflow/mlflow","forks_url":"https://api.github.com/repos/mlflow/mlflow/forks","keys_url":"https://api.github.com/repos/mlflow/mlflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlflow/mlflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlflow/mlflow/teams","hooks_url":"https://api.github.com/repos/mlflow/mlflow/hooks","issue_events_url":"https://api.github.com/repos/mlflow/mlflow/issues/events{/number}","events_url":"https://api.github.com/repos/mlflow/mlflow/events","assignees_url":"https://api.github.com/repos/mlflow/mlflow/assignees{/user}","branches_url":"https://api.github.com/repos/mlflow/mlflow/branches{/branch}","tags_url":"https://api.github.com/repos/mlflow/mlflow/tags","blobs_url":"https://api.github.com/repos/mlflow/mlflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlflow/mlflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlflow/mlflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlflow/mlflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlflow/mlflow/statuses/{sha}","languages_url":"https://api.github.com/repos/mlflow/mlflow/languages","stargazers_url":"https://api.github.com/repos/mlflow/mlflow/stargazers","contributors_url":"https://api.github.com/repos/mlflow/mlflow/contributors","subscribers_url":"https://api.github.com/repos/mlflow/mlflow/subscribers","subscription_url":"https://api.github.com/repos/mlflow/mlflow/subscription","commits_url":"https://api.github.com/repos/mlflow/mlflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlflow/mlflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlflow/mlflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlflow/mlflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlflow/mlflow/contents/{+path}","compare_url":"https://api.github.com/repos/mlflow/mlflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlflow/mlflow/merges","archive_url":"https://api.github.com/repos/mlflow/mlflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlflow/mlflow/downloads","issues_url":"https://api.github.com/repos/mlflow/mlflow/issues{/number}","pulls_url":"https://api.github.com/repos/mlflow/mlflow/pulls{/number}","milestones_url":"https://api.github.com/repos/mlflow/mlflow/milestones{/number}","notifications_url":"https://api.github.com/repos/mlflow/mlflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlflow/mlflow/labels{/name}","releases_url":"https://api.github.com/repos/mlflow/mlflow/releases{/id}","deployments_url":"https://api.github.com/repos/mlflow/mlflow/deployments","created_at":"2018-06-05T16:05:58Z","updated_at":"2019-06-05T22:52:46Z","pushed_at":"2019-06-06T00:19:50Z","git_url":"git://github.com/mlflow/mlflow.git","ssh_url":"[email protected]:mlflow/mlflow.git","clone_url":"https://github.com/mlflow/mlflow.git","svn_url":"https://github.com/mlflow/mlflow","homepage":"https://mlflow.org","size":9565,"stargazers_count":3885,"watchers_count":3885,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":730,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":373,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":730,"open_issues":373,"watchers":3885,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mlflow/mlflow/pulls/1411"},"html":{"href":"https://github.com/mlflow/mlflow/pull/1411"},"issue":{"href":"https://api.github.com/repos/mlflow/mlflow/issues/1411"},"comments":{"href":"https://api.github.com/repos/mlflow/mlflow/issues/1411/comments"},"review_comments":{"href":"https://api.github.com/repos/mlflow/mlflow/pulls/1411/comments"},"review_comment":{"href":"https://api.github.com/repos/mlflow/mlflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mlflow/mlflow/pulls/1411/commits"},"statuses":{"href":"https://api.github.com/repos/mlflow/mlflow/statuses/6b0204f57e00115d5abc164638a6dd324caef695"}},"author_association":"CONTRIBUTOR"}}	{ "id": 136202695, "name": "mlflow/mlflow", "url": "https://api.github.com/repos/mlflow/mlflow" }	{ "id": 4411489, "login": "sueann", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/4411489?", "url": "https://api.github.com/users/sueann" }	{ "id": 39938107, "login": "mlflow", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/39938107?", "url": "https://api.github.com/orgs/mlflow" }	2019-06-06T00:23:07	9767494240	{"actor":{"display_login":"sueann"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/nnsuite/nnstreamer/pulls/comments/365641377","pull_request_review_id":341632183,"id":365641377,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NTY0MTM3Nw==","diff_hunk":"@@ -21,7 +23,21 @@ The submitter has the first responsibility of keeping the created PR clean and n\n * If your functions or structs/classes are going to be accessed by other modules or NNStreamer users, provide full descriptions of all entries with Doxygen.\n * Passing all the tests of TAOS-CI is a neccesary condition, but not a satisfying condition.","path":"Documentation/contributing.md","position":11,"original_position":11,"commit_id":"b2637401f41599ebc19147d87d7fd7ef3a74b18f","original_commit_id":"b2637401f41599ebc19147d87d7fd7ef3a74b18f","user":{"login":"myungjoo","id":1109011,"node_id":"MDQ6VXNlcjExMDkwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1109011?v=4","gravatar_id":"","url":"https://api.github.com/users/myungjoo","html_url":"https://github.com/myungjoo","followers_url":"https://api.github.com/users/myungjoo/followers","following_url":"https://api.github.com/users/myungjoo/following{/other_user}","gists_url":"https://api.github.com/users/myungjoo/gists{/gist_id}","starred_url":"https://api.github.com/users/myungjoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myungjoo/subscriptions","organizations_url":"https://api.github.com/users/myungjoo/orgs","repos_url":"https://api.github.com/users/myungjoo/repos","events_url":"https://api.github.com/users/myungjoo/events{/privacy}","received_events_url":"https://api.github.com/users/myungjoo/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2020-01-13T03:56:58Z","updated_at":"2020-01-13T03:56:58Z","html_url":"https://github.com/nnsuite/nnstreamer/pull/2018#discussion_r365641377","pull_request_url":"https://api.github.com/repos/nnsuite/nnstreamer/pulls/2018","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nnsuite/nnstreamer/pulls/comments/365641377"},"html":{"href":"https://github.com/nnsuite/nnstreamer/pull/2018#discussion_r365641377"},"pull_request":{"href":"https://api.github.com/repos/nnsuite/nnstreamer/pulls/2018"}},"in_reply_to_id":365100588},"pull_request":{"url":"https://api.github.com/repos/nnsuite/nnstreamer/pulls/2018","id":361273831,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYxMjczODMx","html_url":"https://github.com/nnsuite/nnstreamer/pull/2018","diff_url":"https://github.com/nnsuite/nnstreamer/pull/2018.diff","patch_url":"https://github.com/nnsuite/nnstreamer/pull/2018.patch","issue_url":"https://api.github.com/repos/nnsuite/nnstreamer/issues/2018","number":2018,"state":"open","locked":false,"title":"Documentation Update of 2020.01","user":{"login":"myungjoo","id":1109011,"node_id":"MDQ6VXNlcjExMDkwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1109011?v=4","gravatar_id":"","url":"https://api.github.com/users/myungjoo","html_url":"https://github.com/myungjoo","followers_url":"https://api.github.com/users/myungjoo/followers","following_url":"https://api.github.com/users/myungjoo/following{/other_user}","gists_url":"https://api.github.com/users/myungjoo/gists{/gist_id}","starred_url":"https://api.github.com/users/myungjoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myungjoo/subscriptions","organizations_url":"https://api.github.com/users/myungjoo/orgs","repos_url":"https://api.github.com/users/myungjoo/repos","events_url":"https://api.github.com/users/myungjoo/events{/privacy}","received_events_url":"https://api.github.com/users/myungjoo/received_events","type":"User","site_admin":false},"body":"We have been progressed a lot. Update the documentation accordingly.\r\n\r\nSigned-off-by: MyungJoo Ham <[email protected]>\r\n\r\n","created_at":"2020-01-10T04:47:33Z","updated_at":"2020-01-13T03:56:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c34f1a79387118b6d87636134e2223e3b8c9d77","assignee":null,"assignees":[],"requested_reviewers":[{"login":"leemgs","id":82404,"node_id":"MDQ6VXNlcjgyNDA0","avatar_url":"https://avatars0.githubusercontent.com/u/82404?v=4","gravatar_id":"","url":"https://api.github.com/users/leemgs","html_url":"https://github.com/leemgs","followers_url":"https://api.github.com/users/leemgs/followers","following_url":"https://api.github.com/users/leemgs/following{/other_user}","gists_url":"https://api.github.com/users/leemgs/gists{/gist_id}","starred_url":"https://api.github.com/users/leemgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leemgs/subscriptions","organizations_url":"https://api.github.com/users/leemgs/orgs","repos_url":"https://api.github.com/users/leemgs/repos","events_url":"https://api.github.com/users/leemgs/events{/privacy}","received_events_url":"https://api.github.com/users/leemgs/received_events","type":"User","site_admin":false},{"login":"again4you","id":433435,"node_id":"MDQ6VXNlcjQzMzQzNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/433435?v=4","gravatar_id":"","url":"https://api.github.com/users/again4you","html_url":"https://github.com/again4you","followers_url":"https://api.github.com/users/again4you/followers","following_url":"https://api.github.com/users/again4you/following{/other_user}","gists_url":"https://api.github.com/users/again4you/gists{/gist_id}","starred_url":"https://api.github.com/users/again4you/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/again4you/subscriptions","organizations_url":"https://api.github.com/users/again4you/orgs","repos_url":"https://api.github.com/users/again4you/repos","events_url":"https://api.github.com/users/again4you/events{/privacy}","received_events_url":"https://api.github.com/users/again4you/received_events","type":"User","site_admin":false},{"login":"wooksong","id":2772376,"node_id":"MDQ6VXNlcjI3NzIzNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/2772376?v=4","gravatar_id":"","url":"https://api.github.com/users/wooksong","html_url":"https://github.com/wooksong","followers_url":"https://api.github.com/users/wooksong/followers","following_url":"https://api.github.com/users/wooksong/following{/other_user}","gists_url":"https://api.github.com/users/wooksong/gists{/gist_id}","starred_url":"https://api.github.com/users/wooksong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wooksong/subscriptions","organizations_url":"https://api.github.com/users/wooksong/orgs","repos_url":"https://api.github.com/users/wooksong/repos","events_url":"https://api.github.com/users/wooksong/events{/privacy}","received_events_url":"https://api.github.com/users/wooksong/received_events","type":"User","site_admin":false},{"login":"anyj0527","id":5564297,"node_id":"MDQ6VXNlcjU1NjQyOTc=","avatar_url":"https://avatars0.githubusercontent.com/u/5564297?v=4","gravatar_id":"","url":"https://api.github.com/users/anyj0527","html_url":"https://github.com/anyj0527","followers_url":"https://api.github.com/users/anyj0527/followers","following_url":"https://api.github.com/users/anyj0527/following{/other_user}","gists_url":"https://api.github.com/users/anyj0527/gists{/gist_id}","starred_url":"https://api.github.com/users/anyj0527/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anyj0527/subscriptions","organizations_url":"https://api.github.com/users/anyj0527/orgs","repos_url":"https://api.github.com/users/anyj0527/repos","events_url":"https://api.github.com/users/anyj0527/events{/privacy}","received_events_url":"https://api.github.com/users/anyj0527/received_events","type":"User","site_admin":false},{"login":"kparichay","id":6565775,"node_id":"MDQ6VXNlcjY1NjU3NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/6565775?v=4","gravatar_id":"","url":"https://api.github.com/users/kparichay","html_url":"https://github.com/kparichay","followers_url":"https://api.github.com/users/kparichay/followers","following_url":"https://api.github.com/users/kparichay/following{/other_user}","gists_url":"https://api.github.com/users/kparichay/gists{/gist_id}","starred_url":"https://api.github.com/users/kparichay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kparichay/subscriptions","organizations_url":"https://api.github.com/users/kparichay/orgs","repos_url":"https://api.github.com/users/kparichay/repos","events_url":"https://api.github.com/users/kparichay/events{/privacy}","received_events_url":"https://api.github.com/users/kparichay/received_events","type":"User","site_admin":false},{"login":"jijoongmoon","id":23226860,"node_id":"MDQ6VXNlcjIzMjI2ODYw","avatar_url":"https://avatars0.githubusercontent.com/u/23226860?v=4","gravatar_id":"","url":"https://api.github.com/users/jijoongmoon","html_url":"https://github.com/jijoongmoon","followers_url":"https://api.github.com/users/jijoongmoon/followers","following_url":"https://api.github.com/users/jijoongmoon/following{/other_user}","gists_url":"https://api.github.com/users/jijoongmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/jijoongmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jijoongmoon/subscriptions","organizations_url":"https://api.github.com/users/jijoongmoon/orgs","repos_url":"https://api.github.com/users/jijoongmoon/repos","events_url":"https://api.github.com/users/jijoongmoon/events{/privacy}","received_events_url":"https://api.github.com/users/jijoongmoon/received_events","type":"User","site_admin":false},{"login":"helloahn","id":33743568,"node_id":"MDQ6VXNlcjMzNzQzNTY4","avatar_url":"https://avatars0.githubusercontent.com/u/33743568?v=4","gravatar_id":"","url":"https://api.github.com/users/helloahn","html_url":"https://github.com/helloahn","followers_url":"https://api.github.com/users/helloahn/followers","following_url":"https://api.github.com/users/helloahn/following{/other_user}","gists_url":"https://api.github.com/users/helloahn/gists{/gist_id}","starred_url":"https://api.github.com/users/helloahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helloahn/subscriptions","organizations_url":"https://api.github.com/users/helloahn/orgs","repos_url":"https://api.github.com/users/helloahn/repos","events_url":"https://api.github.com/users/helloahn/events{/privacy}","received_events_url":"https://api.github.com/users/helloahn/received_events","type":"User","site_admin":false},{"login":"gichan-jang","id":56856496,"node_id":"MDQ6VXNlcjU2ODU2NDk2","avatar_url":"https://avatars0.githubusercontent.com/u/56856496?v=4","gravatar_id":"","url":"https://api.github.com/users/gichan-jang","html_url":"https://github.com/gichan-jang","followers_url":"https://api.github.com/users/gichan-jang/followers","following_url":"https://api.github.com/users/gichan-jang/following{/other_user}","gists_url":"https://api.github.com/users/gichan-jang/gists{/gist_id}","starred_url":"https://api.github.com/users/gichan-jang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gichan-jang/subscriptions","organizations_url":"https://api.github.com/users/gichan-jang/orgs","repos_url":"https://api.github.com/users/gichan-jang/repos","events_url":"https://api.github.com/users/gichan-jang/events{/privacy}","received_events_url":"https://api.github.com/users/gichan-jang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nnsuite/nnstreamer/pulls/2018/commits","review_comments_url":"https://api.github.com/repos/nnsuite/nnstreamer/pulls/2018/comments","review_comment_url":"https://api.github.com/repos/nnsuite/nnstreamer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nnsuite/nnstreamer/issues/2018/comments","statuses_url":"https://api.github.com/repos/nnsuite/nnstreamer/statuses/b2637401f41599ebc19147d87d7fd7ef3a74b18f","head":{"label":"myungjoo:doc/update","ref":"doc/update","sha":"b2637401f41599ebc19147d87d7fd7ef3a74b18f","user":{"login":"myungjoo","id":1109011,"node_id":"MDQ6VXNlcjExMDkwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1109011?v=4","gravatar_id":"","url":"https://api.github.com/users/myungjoo","html_url":"https://github.com/myungjoo","followers_url":"https://api.github.com/users/myungjoo/followers","following_url":"https://api.github.com/users/myungjoo/following{/other_user}","gists_url":"https://api.github.com/users/myungjoo/gists{/gist_id}","starred_url":"https://api.github.com/users/myungjoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myungjoo/subscriptions","organizations_url":"https://api.github.com/users/myungjoo/orgs","repos_url":"https://api.github.com/users/myungjoo/repos","events_url":"https://api.github.com/users/myungjoo/events{/privacy}","received_events_url":"https://api.github.com/users/myungjoo/received_events","type":"User","site_admin":false},"repo":{"id":142087723,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIwODc3MjM=","name":"nnstreamer","full_name":"myungjoo/nnstreamer","private":false,"owner":{"login":"myungjoo","id":1109011,"node_id":"MDQ6VXNlcjExMDkwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1109011?v=4","gravatar_id":"","url":"https://api.github.com/users/myungjoo","html_url":"https://github.com/myungjoo","followers_url":"https://api.github.com/users/myungjoo/followers","following_url":"https://api.github.com/users/myungjoo/following{/other_user}","gists_url":"https://api.github.com/users/myungjoo/gists{/gist_id}","starred_url":"https://api.github.com/users/myungjoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/myungjoo/subscriptions","organizations_url":"https://api.github.com/users/myungjoo/orgs","repos_url":"https://api.github.com/users/myungjoo/repos","events_url":"https://api.github.com/users/myungjoo/events{/privacy}","received_events_url":"https://api.github.com/users/myungjoo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/myungjoo/nnstreamer","description":":twisted_rightwards_arrows: Neural Network (NN) Streamer for AI Projects.","fork":true,"url":"https://api.github.com/repos/myungjoo/nnstreamer","forks_url":"https://api.github.com/repos/myungjoo/nnstreamer/forks","keys_url":"https://api.github.com/repos/myungjoo/nnstreamer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/myungjoo/nnstreamer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/myungjoo/nnstreamer/teams","hooks_url":"https://api.github.com/repos/myungjoo/nnstreamer/hooks","issue_events_url":"https://api.github.com/repos/myungjoo/nnstreamer/issues/events{/number}","events_url":"https://api.github.com/repos/myungjoo/nnstreamer/events","assignees_url":"https://api.github.com/repos/myungjoo/nnstreamer/assignees{/user}","branches_url":"https://api.github.com/repos/myungjoo/nnstreamer/branches{/branch}","tags_url":"https://api.github.com/repos/myungjoo/nnstreamer/tags","blobs_url":"https://api.github.com/repos/myungjoo/nnstreamer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/myungjoo/nnstreamer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/myungjoo/nnstreamer/git/refs{/sha}","trees_url":"https://api.github.com/repos/myungjoo/nnstreamer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/myungjoo/nnstreamer/statuses/{sha}","languages_url":"https://api.github.com/repos/myungjoo/nnstreamer/languages","stargazers_url":"https://api.github.com/repos/myungjoo/nnstreamer/stargazers","contributors_url":"https://api.github.com/repos/myungjoo/nnstreamer/contributors","subscribers_url":"https://api.github.com/repos/myungjoo/nnstreamer/subscribers","subscription_url":"https://api.github.com/repos/myungjoo/nnstreamer/subscription","commits_url":"https://api.github.com/repos/myungjoo/nnstreamer/commits{/sha}","git_commits_url":"https://api.github.com/repos/myungjoo/nnstreamer/git/commits{/sha}","comments_url":"https://api.github.com/repos/myungjoo/nnstreamer/comments{/number}","issue_comment_url":"https://api.github.com/repos/myungjoo/nnstreamer/issues/comments{/number}","contents_url":"https://api.github.com/repos/myungjoo/nnstreamer/contents/{+path}","compare_url":"https://api.github.com/repos/myungjoo/nnstreamer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/myungjoo/nnstreamer/merges","archive_url":"https://api.github.com/repos/myungjoo/nnstreamer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/myungjoo/nnstreamer/downloads","issues_url":"https://api.github.com/repos/myungjoo/nnstreamer/issues{/number}","pulls_url":"https://api.github.com/repos/myungjoo/nnstreamer/pulls{/number}","milestones_url":"https://api.github.com/repos/myungjoo/nnstreamer/milestones{/number}","notifications_url":"https://api.github.com/repos/myungjoo/nnstreamer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/myungjoo/nnstreamer/labels{/name}","releases_url":"https://api.github.com/repos/myungjoo/nnstreamer/releases{/id}","deployments_url":"https://api.github.com/repos/myungjoo/nnstreamer/deployments","created_at":"2018-07-24T01:24:07Z","updated_at":"2020-01-09T06:10:42Z","pushed_at":"2020-01-10T04:58:13Z","git_url":"git://github.com/myungjoo/nnstreamer.git","ssh_url":"[email protected]:myungjoo/nnstreamer.git","clone_url":"https://github.com/myungjoo/nnstreamer.git","svn_url":"https://github.com/myungjoo/nnstreamer","homepage":null,"size":29489,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"nnsuite:master","ref":"master","sha":"88baeb462330d36200dc564e1b0eec514c264aae","user":{"login":"nnsuite","id":40420229,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDIwMjI5","avatar_url":"https://avatars0.githubusercontent.com/u/40420229?v=4","gravatar_id":"","url":"https://api.github.com/users/nnsuite","html_url":"https://github.com/nnsuite","followers_url":"https://api.github.com/users/nnsuite/followers","following_url":"https://api.github.com/users/nnsuite/following{/other_user}","gists_url":"https://api.github.com/users/nnsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/nnsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnsuite/subscriptions","organizations_url":"https://api.github.com/users/nnsuite/orgs","repos_url":"https://api.github.com/users/nnsuite/repos","events_url":"https://api.github.com/users/nnsuite/events{/privacy}","received_events_url":"https://api.github.com/users/nnsuite/received_events","type":"Organization","site_admin":false},"repo":{"id":141988388,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE5ODgzODg=","name":"nnstreamer","full_name":"nnsuite/nnstreamer","private":false,"owner":{"login":"nnsuite","id":40420229,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDIwMjI5","avatar_url":"https://avatars0.githubusercontent.com/u/40420229?v=4","gravatar_id":"","url":"https://api.github.com/users/nnsuite","html_url":"https://github.com/nnsuite","followers_url":"https://api.github.com/users/nnsuite/followers","following_url":"https://api.github.com/users/nnsuite/following{/other_user}","gists_url":"https://api.github.com/users/nnsuite/gists{/gist_id}","starred_url":"https://api.github.com/users/nnsuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnsuite/subscriptions","organizations_url":"https://api.github.com/users/nnsuite/orgs","repos_url":"https://api.github.com/users/nnsuite/repos","events_url":"https://api.github.com/users/nnsuite/events{/privacy}","received_events_url":"https://api.github.com/users/nnsuite/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nnsuite/nnstreamer","description":":twisted_rightwards_arrows: Neural Network (NN) Streamer, Stream Processing Paradigm for Neural Network Apps/Devices.","fork":false,"url":"https://api.github.com/repos/nnsuite/nnstreamer","forks_url":"https://api.github.com/repos/nnsuite/nnstreamer/forks","keys_url":"https://api.github.com/repos/nnsuite/nnstreamer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nnsuite/nnstreamer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nnsuite/nnstreamer/teams","hooks_url":"https://api.github.com/repos/nnsuite/nnstreamer/hooks","issue_events_url":"https://api.github.com/repos/nnsuite/nnstreamer/issues/events{/number}","events_url":"https://api.github.com/repos/nnsuite/nnstreamer/events","assignees_url":"https://api.github.com/repos/nnsuite/nnstreamer/assignees{/user}","branches_url":"https://api.github.com/repos/nnsuite/nnstreamer/branches{/branch}","tags_url":"https://api.github.com/repos/nnsuite/nnstreamer/tags","blobs_url":"https://api.github.com/repos/nnsuite/nnstreamer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nnsuite/nnstreamer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nnsuite/nnstreamer/git/refs{/sha}","trees_url":"https://api.github.com/repos/nnsuite/nnstreamer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nnsuite/nnstreamer/statuses/{sha}","languages_url":"https://api.github.com/repos/nnsuite/nnstreamer/languages","stargazers_url":"https://api.github.com/repos/nnsuite/nnstreamer/stargazers","contributors_url":"https://api.github.com/repos/nnsuite/nnstreamer/contributors","subscribers_url":"https://api.github.com/repos/nnsuite/nnstreamer/subscribers","subscription_url":"https://api.github.com/repos/nnsuite/nnstreamer/subscription","commits_url":"https://api.github.com/repos/nnsuite/nnstreamer/commits{/sha}","git_commits_url":"https://api.github.com/repos/nnsuite/nnstreamer/git/commits{/sha}","comments_url":"https://api.github.com/repos/nnsuite/nnstreamer/comments{/number}","issue_comment_url":"https://api.github.com/repos/nnsuite/nnstreamer/issues/comments{/number}","contents_url":"https://api.github.com/repos/nnsuite/nnstreamer/contents/{+path}","compare_url":"https://api.github.com/repos/nnsuite/nnstreamer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nnsuite/nnstreamer/merges","archive_url":"https://api.github.com/repos/nnsuite/nnstreamer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nnsuite/nnstreamer/downloads","issues_url":"https://api.github.com/repos/nnsuite/nnstreamer/issues{/number}","pulls_url":"https://api.github.com/repos/nnsuite/nnstreamer/pulls{/number}","milestones_url":"https://api.github.com/repos/nnsuite/nnstreamer/milestones{/number}","notifications_url":"https://api.github.com/repos/nnsuite/nnstreamer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nnsuite/nnstreamer/labels{/name}","releases_url":"https://api.github.com/repos/nnsuite/nnstreamer/releases{/id}","deployments_url":"https://api.github.com/repos/nnsuite/nnstreamer/deployments","created_at":"2018-07-23T08:57:11Z","updated_at":"2020-01-13T03:52:03Z","pushed_at":"2020-01-13T03:52:01Z","git_url":"git://github.com/nnsuite/nnstreamer.git","ssh_url":"[email protected]:nnsuite/nnstreamer.git","clone_url":"https://github.com/nnsuite/nnstreamer.git","svn_url":"https://github.com/nnsuite/nnstreamer","homepage":"","size":29506,"stargazers_count":167,"watchers_count":167,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":76,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":53,"open_issues":76,"watchers":167,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nnsuite/nnstreamer/pulls/2018"},"html":{"href":"https://github.com/nnsuite/nnstreamer/pull/2018"},"issue":{"href":"https://api.github.com/repos/nnsuite/nnstreamer/issues/2018"},"comments":{"href":"https://api.github.com/repos/nnsuite/nnstreamer/issues/2018/comments"},"review_comments":{"href":"https://api.github.com/repos/nnsuite/nnstreamer/pulls/2018/comments"},"review_comment":{"href":"https://api.github.com/repos/nnsuite/nnstreamer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nnsuite/nnstreamer/pulls/2018/commits"},"statuses":{"href":"https://api.github.com/repos/nnsuite/nnstreamer/statuses/b2637401f41599ebc19147d87d7fd7ef3a74b18f"}},"author_association":"MEMBER"}}	{ "id": 141988388, "name": "nnsuite/nnstreamer", "url": "https://api.github.com/repos/nnsuite/nnstreamer" }	{ "id": 1109011, "login": "myungjoo", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/1109011?", "url": "https://api.github.com/users/myungjoo" }	{ "id": 40420229, "login": "nnsuite", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/40420229?", "url": "https://api.github.com/orgs/nnsuite" }	2020-01-13T03:56:58	11258301102	{"actor":{"display_login":"myungjoo"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/dubbogo/hessian2/pulls/comments/303200954","pull_request_review_id":261536859,"id":303200954,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMzIwMDk1NA==","diff_hunk":"@@ -90,6 +90,10 @@ type Class struct {\n \tName string\n }\n \n+type Method struct {","path":"java_exception/exception.go","position":4,"original_position":4,"commit_id":"47e15fd3444bdac19d00235a0d3d17973b1e7488","original_commit_id":"47e15fd3444bdac19d00235a0d3d17973b1e7488","user":{"login":"fangyincheng","id":18375310,"node_id":"MDQ6VXNlcjE4Mzc1MzEw","avatar_url":"https://avatars0.githubusercontent.com/u/18375310?v=4","gravatar_id":"","url":"https://api.github.com/users/fangyincheng","html_url":"https://github.com/fangyincheng","followers_url":"https://api.github.com/users/fangyincheng/followers","following_url":"https://api.github.com/users/fangyincheng/following{/other_user}","gists_url":"https://api.github.com/users/fangyincheng/gists{/gist_id}","starred_url":"https://api.github.com/users/fangyincheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fangyincheng/subscriptions","organizations_url":"https://api.github.com/users/fangyincheng/orgs","repos_url":"https://api.github.com/users/fangyincheng/repos","events_url":"https://api.github.com/users/fangyincheng/events{/privacy}","received_events_url":"https://api.github.com/users/fangyincheng/received_events","type":"User","site_admin":false},"body":"`JavaClassName` of `Method`?","created_at":"2019-07-13T10:47:12Z","updated_at":"2019-07-13T10:47:15Z","html_url":"https://github.com/dubbogo/hessian2/pull/99#discussion_r303200954","pull_request_url":"https://api.github.com/repos/dubbogo/hessian2/pulls/99","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dubbogo/hessian2/pulls/comments/303200954"},"html":{"href":"https://github.com/dubbogo/hessian2/pull/99#discussion_r303200954"},"pull_request":{"href":"https://api.github.com/repos/dubbogo/hessian2/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/dubbogo/hessian2/pulls/99","id":297302588,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk3MzAyNTg4","html_url":"https://github.com/dubbogo/hessian2/pull/99","diff_url":"https://github.com/dubbogo/hessian2/pull/99.diff","patch_url":"https://github.com/dubbogo/hessian2/pull/99.patch","issue_url":"https://api.github.com/repos/dubbogo/hessian2/issues/99","number":99,"state":"open","locked":false,"title":"AnnotationTypeMismatchException and IncompleteAnnotationException implement","user":{"login":"yiduwangkai","id":16093572,"node_id":"MDQ6VXNlcjE2MDkzNTcy","avatar_url":"https://avatars3.githubusercontent.com/u/16093572?v=4","gravatar_id":"","url":"https://api.github.com/users/yiduwangkai","html_url":"https://github.com/yiduwangkai","followers_url":"https://api.github.com/users/yiduwangkai/followers","following_url":"https://api.github.com/users/yiduwangkai/following{/other_user}","gists_url":"https://api.github.com/users/yiduwangkai/gists{/gist_id}","starred_url":"https://api.github.com/users/yiduwangkai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiduwangkai/subscriptions","organizations_url":"https://api.github.com/users/yiduwangkai/orgs","repos_url":"https://api.github.com/users/yiduwangkai/repos","events_url":"https://api.github.com/users/yiduwangkai/events{/privacy}","received_events_url":"https://api.github.com/users/yiduwangkai/received_events","type":"User","site_admin":false},"body":"implement\r\n\r\n<!-- Thanks for sending a pull request! \r\n-->\r\n\r\nWhat this PR does:\r\n\r\nWhich issue(s) this PR fixes:\r\n<!--\r\nAutomatically closes linked issue when PR is merged.\r\nUsage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.\r\n_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_\r\n-->\r\nFixes #\r\n\r\nSpecial notes for your reviewer:\r\n\r\nDoes this PR introduce a user-facing change?:\r\n<!--\r\nIf no, just write \"NONE\" in the release-note block below.\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n-->\r\n```release-note\r\n\r\n```","created_at":"2019-07-13T10:25:28Z","updated_at":"2019-07-13T10:47:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29b74cadcc1adb92039632cc8ec956a9d04b6abd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dubbogo/hessian2/pulls/99/commits","review_comments_url":"https://api.github.com/repos/dubbogo/hessian2/pulls/99/comments","review_comment_url":"https://api.github.com/repos/dubbogo/hessian2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dubbogo/hessian2/issues/99/comments","statuses_url":"https://api.github.com/repos/dubbogo/hessian2/statuses/47e15fd3444bdac19d00235a0d3d17973b1e7488","head":{"label":"yiduwangkai:master","ref":"master","sha":"47e15fd3444bdac19d00235a0d3d17973b1e7488","user":{"login":"yiduwangkai","id":16093572,"node_id":"MDQ6VXNlcjE2MDkzNTcy","avatar_url":"https://avatars3.githubusercontent.com/u/16093572?v=4","gravatar_id":"","url":"https://api.github.com/users/yiduwangkai","html_url":"https://github.com/yiduwangkai","followers_url":"https://api.github.com/users/yiduwangkai/followers","following_url":"https://api.github.com/users/yiduwangkai/following{/other_user}","gists_url":"https://api.github.com/users/yiduwangkai/gists{/gist_id}","starred_url":"https://api.github.com/users/yiduwangkai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiduwangkai/subscriptions","organizations_url":"https://api.github.com/users/yiduwangkai/orgs","repos_url":"https://api.github.com/users/yiduwangkai/repos","events_url":"https://api.github.com/users/yiduwangkai/events{/privacy}","received_events_url":"https://api.github.com/users/yiduwangkai/received_events","type":"User","site_admin":false},"repo":{"id":196695834,"node_id":"MDEwOlJlcG9zaXRvcnkxOTY2OTU4MzQ=","name":"hessian2","full_name":"yiduwangkai/hessian2","private":false,"owner":{"login":"yiduwangkai","id":16093572,"node_id":"MDQ6VXNlcjE2MDkzNTcy","avatar_url":"https://avatars3.githubusercontent.com/u/16093572?v=4","gravatar_id":"","url":"https://api.github.com/users/yiduwangkai","html_url":"https://github.com/yiduwangkai","followers_url":"https://api.github.com/users/yiduwangkai/followers","following_url":"https://api.github.com/users/yiduwangkai/following{/other_user}","gists_url":"https://api.github.com/users/yiduwangkai/gists{/gist_id}","starred_url":"https://api.github.com/users/yiduwangkai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiduwangkai/subscriptions","organizations_url":"https://api.github.com/users/yiduwangkai/orgs","repos_url":"https://api.github.com/users/yiduwangkai/repos","events_url":"https://api.github.com/users/yiduwangkai/events{/privacy}","received_events_url":"https://api.github.com/users/yiduwangkai/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yiduwangkai/hessian2","description":"dubbo hessian","fork":true,"url":"https://api.github.com/repos/yiduwangkai/hessian2","forks_url":"https://api.github.com/repos/yiduwangkai/hessian2/forks","keys_url":"https://api.github.com/repos/yiduwangkai/hessian2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yiduwangkai/hessian2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yiduwangkai/hessian2/teams","hooks_url":"https://api.github.com/repos/yiduwangkai/hessian2/hooks","issue_events_url":"https://api.github.com/repos/yiduwangkai/hessian2/issues/events{/number}","events_url":"https://api.github.com/repos/yiduwangkai/hessian2/events","assignees_url":"https://api.github.com/repos/yiduwangkai/hessian2/assignees{/user}","branches_url":"https://api.github.com/repos/yiduwangkai/hessian2/branches{/branch}","tags_url":"https://api.github.com/repos/yiduwangkai/hessian2/tags","blobs_url":"https://api.github.com/repos/yiduwangkai/hessian2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yiduwangkai/hessian2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yiduwangkai/hessian2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yiduwangkai/hessian2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yiduwangkai/hessian2/statuses/{sha}","languages_url":"https://api.github.com/repos/yiduwangkai/hessian2/languages","stargazers_url":"https://api.github.com/repos/yiduwangkai/hessian2/stargazers","contributors_url":"https://api.github.com/repos/yiduwangkai/hessian2/contributors","subscribers_url":"https://api.github.com/repos/yiduwangkai/hessian2/subscribers","subscription_url":"https://api.github.com/repos/yiduwangkai/hessian2/subscription","commits_url":"https://api.github.com/repos/yiduwangkai/hessian2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yiduwangkai/hessian2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yiduwangkai/hessian2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yiduwangkai/hessian2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yiduwangkai/hessian2/contents/{+path}","compare_url":"https://api.github.com/repos/yiduwangkai/hessian2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yiduwangkai/hessian2/merges","archive_url":"https://api.github.com/repos/yiduwangkai/hessian2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yiduwangkai/hessian2/downloads","issues_url":"https://api.github.com/repos/yiduwangkai/hessian2/issues{/number}","pulls_url":"https://api.github.com/repos/yiduwangkai/hessian2/pulls{/number}","milestones_url":"https://api.github.com/repos/yiduwangkai/hessian2/milestones{/number}","notifications_url":"https://api.github.com/repos/yiduwangkai/hessian2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yiduwangkai/hessian2/labels{/name}","releases_url":"https://api.github.com/repos/yiduwangkai/hessian2/releases{/id}","deployments_url":"https://api.github.com/repos/yiduwangkai/hessian2/deployments","created_at":"2019-07-13T08:08:09Z","updated_at":"2019-07-13T10:24:10Z","pushed_at":"2019-07-13T10:24:09Z","git_url":"git://github.com/yiduwangkai/hessian2.git","ssh_url":"[email protected]:yiduwangkai/hessian2.git","clone_url":"https://github.com/yiduwangkai/hessian2.git","svn_url":"https://github.com/yiduwangkai/hessian2","homepage":"","size":502,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dubbogo:master","ref":"master","sha":"e051e547fe661d26331ad4b01a4cf70d08564808","user":{"login":"dubbogo","id":40481188,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDgxMTg4","avatar_url":"https://avatars3.githubusercontent.com/u/40481188?v=4","gravatar_id":"","url":"https://api.github.com/users/dubbogo","html_url":"https://github.com/dubbogo","followers_url":"https://api.github.com/users/dubbogo/followers","following_url":"https://api.github.com/users/dubbogo/following{/other_user}","gists_url":"https://api.github.com/users/dubbogo/gists{/gist_id}","starred_url":"https://api.github.com/users/dubbogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubbogo/subscriptions","organizations_url":"https://api.github.com/users/dubbogo/orgs","repos_url":"https://api.github.com/users/dubbogo/repos","events_url":"https://api.github.com/users/dubbogo/events{/privacy}","received_events_url":"https://api.github.com/users/dubbogo/received_events","type":"Organization","site_admin":false},"repo":{"id":161442380,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE0NDIzODA=","name":"hessian2","full_name":"dubbogo/hessian2","private":false,"owner":{"login":"dubbogo","id":40481188,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDgxMTg4","avatar_url":"https://avatars3.githubusercontent.com/u/40481188?v=4","gravatar_id":"","url":"https://api.github.com/users/dubbogo","html_url":"https://github.com/dubbogo","followers_url":"https://api.github.com/users/dubbogo/followers","following_url":"https://api.github.com/users/dubbogo/following{/other_user}","gists_url":"https://api.github.com/users/dubbogo/gists{/gist_id}","starred_url":"https://api.github.com/users/dubbogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dubbogo/subscriptions","organizations_url":"https://api.github.com/users/dubbogo/orgs","repos_url":"https://api.github.com/users/dubbogo/repos","events_url":"https://api.github.com/users/dubbogo/events{/privacy}","received_events_url":"https://api.github.com/users/dubbogo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dubbogo/hessian2","description":"dubbo hessian","fork":false,"url":"https://api.github.com/repos/dubbogo/hessian2","forks_url":"https://api.github.com/repos/dubbogo/hessian2/forks","keys_url":"https://api.github.com/repos/dubbogo/hessian2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dubbogo/hessian2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dubbogo/hessian2/teams","hooks_url":"https://api.github.com/repos/dubbogo/hessian2/hooks","issue_events_url":"https://api.github.com/repos/dubbogo/hessian2/issues/events{/number}","events_url":"https://api.github.com/repos/dubbogo/hessian2/events","assignees_url":"https://api.github.com/repos/dubbogo/hessian2/assignees{/user}","branches_url":"https://api.github.com/repos/dubbogo/hessian2/branches{/branch}","tags_url":"https://api.github.com/repos/dubbogo/hessian2/tags","blobs_url":"https://api.github.com/repos/dubbogo/hessian2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dubbogo/hessian2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dubbogo/hessian2/git/refs{/sha}","trees_url":"https://api.github.com/repos/dubbogo/hessian2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dubbogo/hessian2/statuses/{sha}","languages_url":"https://api.github.com/repos/dubbogo/hessian2/languages","stargazers_url":"https://api.github.com/repos/dubbogo/hessian2/stargazers","contributors_url":"https://api.github.com/repos/dubbogo/hessian2/contributors","subscribers_url":"https://api.github.com/repos/dubbogo/hessian2/subscribers","subscription_url":"https://api.github.com/repos/dubbogo/hessian2/subscription","commits_url":"https://api.github.com/repos/dubbogo/hessian2/commits{/sha}","git_commits_url":"https://api.github.com/repos/dubbogo/hessian2/git/commits{/sha}","comments_url":"https://api.github.com/repos/dubbogo/hessian2/comments{/number}","issue_comment_url":"https://api.github.com/repos/dubbogo/hessian2/issues/comments{/number}","contents_url":"https://api.github.com/repos/dubbogo/hessian2/contents/{+path}","compare_url":"https://api.github.com/repos/dubbogo/hessian2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dubbogo/hessian2/merges","archive_url":"https://api.github.com/repos/dubbogo/hessian2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dubbogo/hessian2/downloads","issues_url":"https://api.github.com/repos/dubbogo/hessian2/issues{/number}","pulls_url":"https://api.github.com/repos/dubbogo/hessian2/pulls{/number}","milestones_url":"https://api.github.com/repos/dubbogo/hessian2/milestones{/number}","notifications_url":"https://api.github.com/repos/dubbogo/hessian2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dubbogo/hessian2/labels{/name}","releases_url":"https://api.github.com/repos/dubbogo/hessian2/releases{/id}","deployments_url":"https://api.github.com/repos/dubbogo/hessian2/deployments","created_at":"2018-12-12T06:22:58Z","updated_at":"2019-07-11T07:18:35Z","pushed_at":"2019-07-13T10:25:29Z","git_url":"git://github.com/dubbogo/hessian2.git","ssh_url":"[email protected]:dubbogo/hessian2.git","clone_url":"https://github.com/dubbogo/hessian2.git","svn_url":"https://github.com/dubbogo/hessian2","homepage":"","size":502,"stargazers_count":41,"watchers_count":41,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":23,"open_issues":10,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dubbogo/hessian2/pulls/99"},"html":{"href":"https://github.com/dubbogo/hessian2/pull/99"},"issue":{"href":"https://api.github.com/repos/dubbogo/hessian2/issues/99"},"comments":{"href":"https://api.github.com/repos/dubbogo/hessian2/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/dubbogo/hessian2/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/dubbogo/hessian2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dubbogo/hessian2/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/dubbogo/hessian2/statuses/47e15fd3444bdac19d00235a0d3d17973b1e7488"}},"author_association":"NONE"}}	{ "id": 161442380, "name": "dubbogo/hessian2", "url": "https://api.github.com/repos/dubbogo/hessian2" }	{ "id": 18375310, "login": "fangyincheng", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/18375310?", "url": "https://api.github.com/users/fangyincheng" }	{ "id": 40481188, "login": "dubbogo", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/40481188?", "url": "https://api.github.com/orgs/dubbogo" }	2019-07-13T10:47:12	10005111005	{"actor":{"display_login":"fangyincheng"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/simpledotorg/simple-server/pulls/comments/260958008","pull_request_review_id":208782512,"id":260958008,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MDk1ODAwOA==","diff_hunk":"@@ -0,0 +1,26 @@\n+module SimpleServerEnvHelper\n+ SIMPLE_SERVER_ENV = \"SIMPLE_SERVER_ENV\".freeze","path":"app/helpers/simple_server_env_helper.rb","position":2,"original_position":2,"commit_id":"8f8d12c502d985bb46982e2fb5622d640366a898","original_commit_id":"8f8d12c502d985bb46982e2fb5622d640366a898","user":{"login":"timcheadle","id":612212,"node_id":"MDQ6VXNlcjYxMjIxMg==","avatar_url":"https://avatars2.githubusercontent.com/u/612212?v=4","gravatar_id":"","url":"https://api.github.com/users/timcheadle","html_url":"https://github.com/timcheadle","followers_url":"https://api.github.com/users/timcheadle/followers","following_url":"https://api.github.com/users/timcheadle/following{/other_user}","gists_url":"https://api.github.com/users/timcheadle/gists{/gist_id}","starred_url":"https://api.github.com/users/timcheadle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timcheadle/subscriptions","organizations_url":"https://api.github.com/users/timcheadle/orgs","repos_url":"https://api.github.com/users/timcheadle/repos","events_url":"https://api.github.com/users/timcheadle/events{/privacy}","received_events_url":"https://api.github.com/users/timcheadle/received_events","type":"User","site_admin":false},"body":"This is not really necessary; just put the string in the `ENV.fetch()` lines below. If we have to change this ever, we'll have to grep the entire codebase anyway.","created_at":"2019-02-27T21:44:30Z","updated_at":"2019-02-27T21:47:48Z","html_url":"https://github.com/simpledotorg/simple-server/pull/256#discussion_r260958008","pull_request_url":"https://api.github.com/repos/simpledotorg/simple-server/pulls/256","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/simpledotorg/simple-server/pulls/comments/260958008"},"html":{"href":"https://github.com/simpledotorg/simple-server/pull/256#discussion_r260958008"},"pull_request":{"href":"https://api.github.com/repos/simpledotorg/simple-server/pulls/256"}}},"pull_request":{"url":"https://api.github.com/repos/simpledotorg/simple-server/pulls/256","id":254296590,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0Mjk2NTkw","html_url":"https://github.com/simpledotorg/simple-server/pull/256","diff_url":"https://github.com/simpledotorg/simple-server/pull/256.diff","patch_url":"https://github.com/simpledotorg/simple-server/pull/256.patch","issue_url":"https://api.github.com/repos/simpledotorg/simple-server/issues/256","number":256,"state":"open","locked":false,"title":"Show logo and header colour as per current deployment env config","user":{"login":"timmyjose","id":2051158,"node_id":"MDQ6VXNlcjIwNTExNTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2051158?v=4","gravatar_id":"","url":"https://api.github.com/users/timmyjose","html_url":"https://github.com/timmyjose","followers_url":"https://api.github.com/users/timmyjose/followers","following_url":"https://api.github.com/users/timmyjose/following{/other_user}","gists_url":"https://api.github.com/users/timmyjose/gists{/gist_id}","starred_url":"https://api.github.com/users/timmyjose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timmyjose/subscriptions","organizations_url":"https://api.github.com/users/timmyjose/orgs","repos_url":"https://api.github.com/users/timmyjose/repos","events_url":"https://api.github.com/users/timmyjose/events{/privacy}","received_events_url":"https://api.github.com/users/timmyjose/received_events","type":"User","site_admin":false},"body":"PR for story [As an Admin, I should instantly know which environment I am on (prod, sandbox or staging)](https://www.pivotaltracker.com/n/projects/2184102/stories/163934813)\r\n\r\n","created_at":"2019-02-19T15:25:06Z","updated_at":"2019-02-27T21:47:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"671986914f5daea26b12d492aebda723cd10da34","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kitallis","id":50663,"node_id":"MDQ6VXNlcjUwNjYz","avatar_url":"https://avatars2.githubusercontent.com/u/50663?v=4","gravatar_id":"","url":"https://api.github.com/users/kitallis","html_url":"https://github.com/kitallis","followers_url":"https://api.github.com/users/kitallis/followers","following_url":"https://api.github.com/users/kitallis/following{/other_user}","gists_url":"https://api.github.com/users/kitallis/gists{/gist_id}","starred_url":"https://api.github.com/users/kitallis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitallis/subscriptions","organizations_url":"https://api.github.com/users/kitallis/orgs","repos_url":"https://api.github.com/users/kitallis/repos","events_url":"https://api.github.com/users/kitallis/events{/privacy}","received_events_url":"https://api.github.com/users/kitallis/received_events","type":"User","site_admin":false},{"login":"divs1210","id":3773773,"node_id":"MDQ6VXNlcjM3NzM3NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/3773773?v=4","gravatar_id":"","url":"https://api.github.com/users/divs1210","html_url":"https://github.com/divs1210","followers_url":"https://api.github.com/users/divs1210/followers","following_url":"https://api.github.com/users/divs1210/following{/other_user}","gists_url":"https://api.github.com/users/divs1210/gists{/gist_id}","starred_url":"https://api.github.com/users/divs1210/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/divs1210/subscriptions","organizations_url":"https://api.github.com/users/divs1210/orgs","repos_url":"https://api.github.com/users/divs1210/repos","events_url":"https://api.github.com/users/divs1210/events{/privacy}","received_events_url":"https://api.github.com/users/divs1210/received_events","type":"User","site_admin":false},{"login":"govindkrjoshi","id":3933133,"node_id":"MDQ6VXNlcjM5MzMxMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/3933133?v=4","gravatar_id":"","url":"https://api.github.com/users/govindkrjoshi","html_url":"https://github.com/govindkrjoshi","followers_url":"https://api.github.com/users/govindkrjoshi/followers","following_url":"https://api.github.com/users/govindkrjoshi/following{/other_user}","gists_url":"https://api.github.com/users/govindkrjoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/govindkrjoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/govindkrjoshi/subscriptions","organizations_url":"https://api.github.com/users/govindkrjoshi/orgs","repos_url":"https://api.github.com/users/govindkrjoshi/repos","events_url":"https://api.github.com/users/govindkrjoshi/events{/privacy}","received_events_url":"https://api.github.com/users/govindkrjoshi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/simpledotorg/simple-server/pulls/256/commits","review_comments_url":"https://api.github.com/repos/simpledotorg/simple-server/pulls/256/comments","review_comment_url":"https://api.github.com/repos/simpledotorg/simple-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/simpledotorg/simple-server/issues/256/comments","statuses_url":"https://api.github.com/repos/simpledotorg/simple-server/statuses/8f8d12c502d985bb46982e2fb5622d640366a898","head":{"label":"simpledotorg:logo-and-banner-colour-change-per-deploy-env","ref":"logo-and-banner-colour-change-per-deploy-env","sha":"8f8d12c502d985bb46982e2fb5622d640366a898","user":{"login":"simpledotorg","id":40570251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTcwMjUx","avatar_url":"https://avatars0.githubusercontent.com/u/40570251?v=4","gravatar_id":"","url":"https://api.github.com/users/simpledotorg","html_url":"https://github.com/simpledotorg","followers_url":"https://api.github.com/users/simpledotorg/followers","following_url":"https://api.github.com/users/simpledotorg/following{/other_user}","gists_url":"https://api.github.com/users/simpledotorg/gists{/gist_id}","starred_url":"https://api.github.com/users/simpledotorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simpledotorg/subscriptions","organizations_url":"https://api.github.com/users/simpledotorg/orgs","repos_url":"https://api.github.com/users/simpledotorg/repos","events_url":"https://api.github.com/users/simpledotorg/events{/privacy}","received_events_url":"https://api.github.com/users/simpledotorg/received_events","type":"Organization","site_admin":false},"repo":{"id":132516184,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI1MTYxODQ=","name":"simple-server","full_name":"simpledotorg/simple-server","private":false,"owner":{"login":"simpledotorg","id":40570251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTcwMjUx","avatar_url":"https://avatars0.githubusercontent.com/u/40570251?v=4","gravatar_id":"","url":"https://api.github.com/users/simpledotorg","html_url":"https://github.com/simpledotorg","followers_url":"https://api.github.com/users/simpledotorg/followers","following_url":"https://api.github.com/users/simpledotorg/following{/other_user}","gists_url":"https://api.github.com/users/simpledotorg/gists{/gist_id}","starred_url":"https://api.github.com/users/simpledotorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simpledotorg/subscriptions","organizations_url":"https://api.github.com/users/simpledotorg/orgs","repos_url":"https://api.github.com/users/simpledotorg/repos","events_url":"https://api.github.com/users/simpledotorg/events{/privacy}","received_events_url":"https://api.github.com/users/simpledotorg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/simpledotorg/simple-server","description":"A Rails backend to support the Simple.org mobile app","fork":false,"url":"https://api.github.com/repos/simpledotorg/simple-server","forks_url":"https://api.github.com/repos/simpledotorg/simple-server/forks","keys_url":"https://api.github.com/repos/simpledotorg/simple-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simpledotorg/simple-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simpledotorg/simple-server/teams","hooks_url":"https://api.github.com/repos/simpledotorg/simple-server/hooks","issue_events_url":"https://api.github.com/repos/simpledotorg/simple-server/issues/events{/number}","events_url":"https://api.github.com/repos/simpledotorg/simple-server/events","assignees_url":"https://api.github.com/repos/simpledotorg/simple-server/assignees{/user}","branches_url":"https://api.github.com/repos/simpledotorg/simple-server/branches{/branch}","tags_url":"https://api.github.com/repos/simpledotorg/simple-server/tags","blobs_url":"https://api.github.com/repos/simpledotorg/simple-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simpledotorg/simple-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simpledotorg/simple-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/simpledotorg/simple-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simpledotorg/simple-server/statuses/{sha}","languages_url":"https://api.github.com/repos/simpledotorg/simple-server/languages","stargazers_url":"https://api.github.com/repos/simpledotorg/simple-server/stargazers","contributors_url":"https://api.github.com/repos/simpledotorg/simple-server/contributors","subscribers_url":"https://api.github.com/repos/simpledotorg/simple-server/subscribers","subscription_url":"https://api.github.com/repos/simpledotorg/simple-server/subscription","commits_url":"https://api.github.com/repos/simpledotorg/simple-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/simpledotorg/simple-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/simpledotorg/simple-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/simpledotorg/simple-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/simpledotorg/simple-server/contents/{+path}","compare_url":"https://api.github.com/repos/simpledotorg/simple-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simpledotorg/simple-server/merges","archive_url":"https://api.github.com/repos/simpledotorg/simple-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simpledotorg/simple-server/downloads","issues_url":"https://api.github.com/repos/simpledotorg/simple-server/issues{/number}","pulls_url":"https://api.github.com/repos/simpledotorg/simple-server/pulls{/number}","milestones_url":"https://api.github.com/repos/simpledotorg/simple-server/milestones{/number}","notifications_url":"https://api.github.com/repos/simpledotorg/simple-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simpledotorg/simple-server/labels{/name}","releases_url":"https://api.github.com/repos/simpledotorg/simple-server/releases{/id}","deployments_url":"https://api.github.com/repos/simpledotorg/simple-server/deployments","created_at":"2018-05-07T21:03:09Z","updated_at":"2019-02-27T21:18:18Z","pushed_at":"2019-02-27T21:35:43Z","git_url":"git://github.com/simpledotorg/simple-server.git","ssh_url":"[email protected]:simpledotorg/simple-server.git","clone_url":"https://github.com/simpledotorg/simple-server.git","svn_url":"https://github.com/simpledotorg/simple-server","homepage":"","size":1311,"stargazers_count":13,"watchers_count":13,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":8,"watchers":13,"default_branch":"master"}},"base":{"label":"simpledotorg:master","ref":"master","sha":"9b5bd71e9996567e39082cea8302b73edceb3bda","user":{"login":"simpledotorg","id":40570251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTcwMjUx","avatar_url":"https://avatars0.githubusercontent.com/u/40570251?v=4","gravatar_id":"","url":"https://api.github.com/users/simpledotorg","html_url":"https://github.com/simpledotorg","followers_url":"https://api.github.com/users/simpledotorg/followers","following_url":"https://api.github.com/users/simpledotorg/following{/other_user}","gists_url":"https://api.github.com/users/simpledotorg/gists{/gist_id}","starred_url":"https://api.github.com/users/simpledotorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simpledotorg/subscriptions","organizations_url":"https://api.github.com/users/simpledotorg/orgs","repos_url":"https://api.github.com/users/simpledotorg/repos","events_url":"https://api.github.com/users/simpledotorg/events{/privacy}","received_events_url":"https://api.github.com/users/simpledotorg/received_events","type":"Organization","site_admin":false},"repo":{"id":132516184,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI1MTYxODQ=","name":"simple-server","full_name":"simpledotorg/simple-server","private":false,"owner":{"login":"simpledotorg","id":40570251,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNTcwMjUx","avatar_url":"https://avatars0.githubusercontent.com/u/40570251?v=4","gravatar_id":"","url":"https://api.github.com/users/simpledotorg","html_url":"https://github.com/simpledotorg","followers_url":"https://api.github.com/users/simpledotorg/followers","following_url":"https://api.github.com/users/simpledotorg/following{/other_user}","gists_url":"https://api.github.com/users/simpledotorg/gists{/gist_id}","starred_url":"https://api.github.com/users/simpledotorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simpledotorg/subscriptions","organizations_url":"https://api.github.com/users/simpledotorg/orgs","repos_url":"https://api.github.com/users/simpledotorg/repos","events_url":"https://api.github.com/users/simpledotorg/events{/privacy}","received_events_url":"https://api.github.com/users/simpledotorg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/simpledotorg/simple-server","description":"A Rails backend to support the Simple.org mobile app","fork":false,"url":"https://api.github.com/repos/simpledotorg/simple-server","forks_url":"https://api.github.com/repos/simpledotorg/simple-server/forks","keys_url":"https://api.github.com/repos/simpledotorg/simple-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simpledotorg/simple-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simpledotorg/simple-server/teams","hooks_url":"https://api.github.com/repos/simpledotorg/simple-server/hooks","issue_events_url":"https://api.github.com/repos/simpledotorg/simple-server/issues/events{/number}","events_url":"https://api.github.com/repos/simpledotorg/simple-server/events","assignees_url":"https://api.github.com/repos/simpledotorg/simple-server/assignees{/user}","branches_url":"https://api.github.com/repos/simpledotorg/simple-server/branches{/branch}","tags_url":"https://api.github.com/repos/simpledotorg/simple-server/tags","blobs_url":"https://api.github.com/repos/simpledotorg/simple-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simpledotorg/simple-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simpledotorg/simple-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/simpledotorg/simple-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simpledotorg/simple-server/statuses/{sha}","languages_url":"https://api.github.com/repos/simpledotorg/simple-server/languages","stargazers_url":"https://api.github.com/repos/simpledotorg/simple-server/stargazers","contributors_url":"https://api.github.com/repos/simpledotorg/simple-server/contributors","subscribers_url":"https://api.github.com/repos/simpledotorg/simple-server/subscribers","subscription_url":"https://api.github.com/repos/simpledotorg/simple-server/subscription","commits_url":"https://api.github.com/repos/simpledotorg/simple-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/simpledotorg/simple-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/simpledotorg/simple-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/simpledotorg/simple-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/simpledotorg/simple-server/contents/{+path}","compare_url":"https://api.github.com/repos/simpledotorg/simple-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simpledotorg/simple-server/merges","archive_url":"https://api.github.com/repos/simpledotorg/simple-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simpledotorg/simple-server/downloads","issues_url":"https://api.github.com/repos/simpledotorg/simple-server/issues{/number}","pulls_url":"https://api.github.com/repos/simpledotorg/simple-server/pulls{/number}","milestones_url":"https://api.github.com/repos/simpledotorg/simple-server/milestones{/number}","notifications_url":"https://api.github.com/repos/simpledotorg/simple-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simpledotorg/simple-server/labels{/name}","releases_url":"https://api.github.com/repos/simpledotorg/simple-server/releases{/id}","deployments_url":"https://api.github.com/repos/simpledotorg/simple-server/deployments","created_at":"2018-05-07T21:03:09Z","updated_at":"2019-02-27T21:18:18Z","pushed_at":"2019-02-27T21:35:43Z","git_url":"git://github.com/simpledotorg/simple-server.git","ssh_url":"[email protected]:simpledotorg/simple-server.git","clone_url":"https://github.com/simpledotorg/simple-server.git","svn_url":"https://github.com/simpledotorg/simple-server","homepage":"","size":1311,"stargazers_count":13,"watchers_count":13,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":8,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/simpledotorg/simple-server/pulls/256"},"html":{"href":"https://github.com/simpledotorg/simple-server/pull/256"},"issue":{"href":"https://api.github.com/repos/simpledotorg/simple-server/issues/256"},"comments":{"href":"https://api.github.com/repos/simpledotorg/simple-server/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/simpledotorg/simple-server/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/simpledotorg/simple-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/simpledotorg/simple-server/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/simpledotorg/simple-server/statuses/8f8d12c502d985bb46982e2fb5622d640366a898"}},"author_association":"NONE"}}	{ "id": 132516184, "name": "simpledotorg/simple-server", "url": "https://api.github.com/repos/simpledotorg/simple-server" }	{ "id": 612212, "login": "timcheadle", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/612212?", "url": "https://api.github.com/users/timcheadle" }	{ "id": 40570251, "login": "simpledotorg", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/40570251?", "url": "https://api.github.com/orgs/simpledotorg" }	2019-02-27T21:44:30	9150183966	{"actor":{"display_login":"timcheadle"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/pulls/comments/293208803","pull_request_review_id":249130863,"id":293208803,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MzIwODgwMw==","diff_hunk":"@@ -0,0 +1,86 @@\n+package sample.nackun.com.studyfirst\n+\n+import android.graphics.Color\n+import android.os.Bundle\n+import android.support.v7.app.AppCompatActivity\n+import android.support.v7.widget.LinearLayoutManager\n+import android.util.Log\n+import android.view.View\n+import android.widget.TextView\n+import kotlinx.android.synthetic.main.activity_main.*\n+import retrofit2.Call\n+import retrofit2.Callback\n+import retrofit2.Response\n+import retrofit2.Retrofit\n+import retrofit2.converter.gson.GsonConverterFactory\n+import sample.nackun.com.studyfirst.market.Market\n+import sample.nackun.com.studyfirst.market.Ticker\n+import sample.nackun.com.studyfirst.network.UpbitCommunicable\n+\n+class MainActivity : AppCompatActivity() {\n+\n+ override fun onCreate(savedInstanceState: Bundle?) {\n+ super.onCreate(savedInstanceState)\n+ setContentView(R.layout.activity_main)\n+\n+ setBtnClick()\n+ marketKRW.callOnClick()\n+ }\n+\n+ fun setBtnClick(){\n+ val onClickListener = object : View.OnClickListener {\n+ override fun onClick(v: View?) {\n+ marketKRW.setTextColor(Color.parseColor(\"#bebbb4\"))\n+ marketBTC.setTextColor(Color.parseColor(\"#bebbb4\"))\n+ marketETH.setTextColor(Color.parseColor(\"#bebbb4\"))\n+ marketUSDT.setTextColor(Color.parseColor(\"#bebbb4\"))\n+ var tt = findViewById<TextView>(v!!.id)","path":"NackUn/StudyFirst/app/src/main/java/sample/nackun/com/studyfirst/MainActivity.kt","position":null,"original_position":37,"commit_id":"175693a1ec8aa7df89cf5561b50597ce92f9f11b","original_commit_id":"7d1e47d98589254aa8da304769335a3de337d24b","user":{"login":"NackUn","id":47817912,"node_id":"MDQ6VXNlcjQ3ODE3OTEy","avatar_url":"https://avatars0.githubusercontent.com/u/47817912?v=4","gravatar_id":"","url":"https://api.github.com/users/NackUn","html_url":"https://github.com/NackUn","followers_url":"https://api.github.com/users/NackUn/followers","following_url":"https://api.github.com/users/NackUn/following{/other_user}","gists_url":"https://api.github.com/users/NackUn/gists{/gist_id}","starred_url":"https://api.github.com/users/NackUn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NackUn/subscriptions","organizations_url":"https://api.github.com/users/NackUn/orgs","repos_url":"https://api.github.com/users/NackUn/repos","events_url":"https://api.github.com/users/NackUn/events{/privacy}","received_events_url":"https://api.github.com/users/NackUn/received_events","type":"User","site_admin":false},"body":"0123005\r\n변경하였습니다.","created_at":"2019-06-13T05:18:54Z","updated_at":"2019-06-13T05:18:54Z","html_url":"https://github.com/StudyFork/GoogryAndroidArchitectureStudy/pull/55#discussion_r293208803","pull_request_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/pulls/55","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/pulls/comments/293208803"},"html":{"href":"https://github.com/StudyFork/GoogryAndroidArchitectureStudy/pull/55#discussion_r293208803"},"pull_request":{"href":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/pulls/55"}},"in_reply_to_id":292996363},"pull_request":{"url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/pulls/55","id":286622159,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2NjIyMTU5","html_url":"https://github.com/StudyFork/GoogryAndroidArchitectureStudy/pull/55","diff_url":"https://github.com/StudyFork/GoogryAndroidArchitectureStudy/pull/55.diff","patch_url":"https://github.com/StudyFork/GoogryAndroidArchitectureStudy/pull/55.patch","issue_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/issues/55","number":55,"state":"open","locked":false,"title":"HW-1 코인헬퍼 따라잡기","user":{"login":"NackUn","id":47817912,"node_id":"MDQ6VXNlcjQ3ODE3OTEy","avatar_url":"https://avatars0.githubusercontent.com/u/47817912?v=4","gravatar_id":"","url":"https://api.github.com/users/NackUn","html_url":"https://github.com/NackUn","followers_url":"https://api.github.com/users/NackUn/followers","following_url":"https://api.github.com/users/NackUn/following{/other_user}","gists_url":"https://api.github.com/users/NackUn/gists{/gist_id}","starred_url":"https://api.github.com/users/NackUn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NackUn/subscriptions","organizations_url":"https://api.github.com/users/NackUn/orgs","repos_url":"https://api.github.com/users/NackUn/repos","events_url":"https://api.github.com/users/NackUn/events{/privacy}","received_events_url":"https://api.github.com/users/NackUn/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-06-10T10:28:51Z","updated_at":"2019-06-13T05:18:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48bb9ac7483b38aaa1ddd31070380a94b4ee0385","assignee":{"login":"NackUn","id":47817912,"node_id":"MDQ6VXNlcjQ3ODE3OTEy","avatar_url":"https://avatars0.githubusercontent.com/u/47817912?v=4","gravatar_id":"","url":"https://api.github.com/users/NackUn","html_url":"https://github.com/NackUn","followers_url":"https://api.github.com/users/NackUn/followers","following_url":"https://api.github.com/users/NackUn/following{/other_user}","gists_url":"https://api.github.com/users/NackUn/gists{/gist_id}","starred_url":"https://api.github.com/users/NackUn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NackUn/subscriptions","organizations_url":"https://api.github.com/users/NackUn/orgs","repos_url":"https://api.github.com/users/NackUn/repos","events_url":"https://api.github.com/users/NackUn/events{/privacy}","received_events_url":"https://api.github.com/users/NackUn/received_events","type":"User","site_admin":false},"assignees":[{"login":"NackUn","id":47817912,"node_id":"MDQ6VXNlcjQ3ODE3OTEy","avatar_url":"https://avatars0.githubusercontent.com/u/47817912?v=4","gravatar_id":"","url":"https://api.github.com/users/NackUn","html_url":"https://github.com/NackUn","followers_url":"https://api.github.com/users/NackUn/followers","following_url":"https://api.github.com/users/NackUn/following{/other_user}","gists_url":"https://api.github.com/users/NackUn/gists{/gist_id}","starred_url":"https://api.github.com/users/NackUn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NackUn/subscriptions","organizations_url":"https://api.github.com/users/NackUn/orgs","repos_url":"https://api.github.com/users/NackUn/repos","events_url":"https://api.github.com/users/NackUn/events{/privacy}","received_events_url":"https://api.github.com/users/NackUn/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1338750835,"node_id":"MDU6TGFiZWwxMzM4NzUwODM1","url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/labels/Answer%20Needed","name":"Answer Needed","color":"FFB80D","default":false},{"id":1342121481,"node_id":"MDU6TGFiZWwxMzQyMTIxNDgx","url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/labels/Mentor%20Needed","name":"Mentor Needed","color":"38ea4d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/pulls/55/commits","review_comments_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/pulls/55/comments","review_comment_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/issues/55/comments","statuses_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/statuses/175693a1ec8aa7df89cf5561b50597ce92f9f11b","head":{"label":"NackUn:class02/NackUn","ref":"class02/NackUn","sha":"175693a1ec8aa7df89cf5561b50597ce92f9f11b","user":{"login":"NackUn","id":47817912,"node_id":"MDQ6VXNlcjQ3ODE3OTEy","avatar_url":"https://avatars0.githubusercontent.com/u/47817912?v=4","gravatar_id":"","url":"https://api.github.com/users/NackUn","html_url":"https://github.com/NackUn","followers_url":"https://api.github.com/users/NackUn/followers","following_url":"https://api.github.com/users/NackUn/following{/other_user}","gists_url":"https://api.github.com/users/NackUn/gists{/gist_id}","starred_url":"https://api.github.com/users/NackUn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NackUn/subscriptions","organizations_url":"https://api.github.com/users/NackUn/orgs","repos_url":"https://api.github.com/users/NackUn/repos","events_url":"https://api.github.com/users/NackUn/events{/privacy}","received_events_url":"https://api.github.com/users/NackUn/received_events","type":"User","site_admin":false},"repo":{"id":187862253,"node_id":"MDEwOlJlcG9zaXRvcnkxODc4NjIyNTM=","name":"GoogryAndroidArchitectureStudy","full_name":"NackUn/GoogryAndroidArchitectureStudy","private":false,"owner":{"login":"NackUn","id":47817912,"node_id":"MDQ6VXNlcjQ3ODE3OTEy","avatar_url":"https://avatars0.githubusercontent.com/u/47817912?v=4","gravatar_id":"","url":"https://api.github.com/users/NackUn","html_url":"https://github.com/NackUn","followers_url":"https://api.github.com/users/NackUn/followers","following_url":"https://api.github.com/users/NackUn/following{/other_user}","gists_url":"https://api.github.com/users/NackUn/gists{/gist_id}","starred_url":"https://api.github.com/users/NackUn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NackUn/subscriptions","organizations_url":"https://api.github.com/users/NackUn/orgs","repos_url":"https://api.github.com/users/NackUn/repos","events_url":"https://api.github.com/users/NackUn/events{/privacy}","received_events_url":"https://api.github.com/users/NackUn/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NackUn/GoogryAndroidArchitectureStudy","description":null,"fork":true,"url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy","forks_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/forks","keys_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/teams","hooks_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/hooks","issue_events_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/issues/events{/number}","events_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/events","assignees_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/assignees{/user}","branches_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/branches{/branch}","tags_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/tags","blobs_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/git/refs{/sha}","trees_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/statuses/{sha}","languages_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/languages","stargazers_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/stargazers","contributors_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/contributors","subscribers_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/subscribers","subscription_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/subscription","commits_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/commits{/sha}","git_commits_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/git/commits{/sha}","comments_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/comments{/number}","issue_comment_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/issues/comments{/number}","contents_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/contents/{+path}","compare_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/merges","archive_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/downloads","issues_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/issues{/number}","pulls_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/pulls{/number}","milestones_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/milestones{/number}","notifications_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/labels{/name}","releases_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/releases{/id}","deployments_url":"https://api.github.com/repos/NackUn/GoogryAndroidArchitectureStudy/deployments","created_at":"2019-05-21T15:10:17Z","updated_at":"2019-05-28T14:46:21Z","pushed_at":"2019-06-13T05:02:54Z","git_url":"git://github.com/NackUn/GoogryAndroidArchitectureStudy.git","ssh_url":"[email protected]:NackUn/GoogryAndroidArchitectureStudy.git","clone_url":"https://github.com/NackUn/GoogryAndroidArchitectureStudy.git","svn_url":"https://github.com/NackUn/GoogryAndroidArchitectureStudy","homepage":null,"size":478,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"StudyFork:class02/NackUn","ref":"class02/NackUn","sha":"95b841ff70387d46068fd4b6fe1840b07a5b1c47","user":{"login":"StudyFork","id":40631622,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjMxNjIy","avatar_url":"https://avatars2.githubusercontent.com/u/40631622?v=4","gravatar_id":"","url":"https://api.github.com/users/StudyFork","html_url":"https://github.com/StudyFork","followers_url":"https://api.github.com/users/StudyFork/followers","following_url":"https://api.github.com/users/StudyFork/following{/other_user}","gists_url":"https://api.github.com/users/StudyFork/gists{/gist_id}","starred_url":"https://api.github.com/users/StudyFork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StudyFork/subscriptions","organizations_url":"https://api.github.com/users/StudyFork/orgs","repos_url":"https://api.github.com/users/StudyFork/repos","events_url":"https://api.github.com/users/StudyFork/events{/privacy}","received_events_url":"https://api.github.com/users/StudyFork/received_events","type":"Organization","site_admin":false},"repo":{"id":180995450,"node_id":"MDEwOlJlcG9zaXRvcnkxODA5OTU0NTA=","name":"GoogryAndroidArchitectureStudy","full_name":"StudyFork/GoogryAndroidArchitectureStudy","private":false,"owner":{"login":"StudyFork","id":40631622,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjMxNjIy","avatar_url":"https://avatars2.githubusercontent.com/u/40631622?v=4","gravatar_id":"","url":"https://api.github.com/users/StudyFork","html_url":"https://github.com/StudyFork","followers_url":"https://api.github.com/users/StudyFork/followers","following_url":"https://api.github.com/users/StudyFork/following{/other_user}","gists_url":"https://api.github.com/users/StudyFork/gists{/gist_id}","starred_url":"https://api.github.com/users/StudyFork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StudyFork/subscriptions","organizations_url":"https://api.github.com/users/StudyFork/orgs","repos_url":"https://api.github.com/users/StudyFork/repos","events_url":"https://api.github.com/users/StudyFork/events{/privacy}","received_events_url":"https://api.github.com/users/StudyFork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/StudyFork/GoogryAndroidArchitectureStudy","description":null,"fork":false,"url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy","forks_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/forks","keys_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/teams","hooks_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/hooks","issue_events_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/issues/events{/number}","events_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/events","assignees_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/assignees{/user}","branches_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/branches{/branch}","tags_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/tags","blobs_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/git/refs{/sha}","trees_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/statuses/{sha}","languages_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/languages","stargazers_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/stargazers","contributors_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/contributors","subscribers_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/subscribers","subscription_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/subscription","commits_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/commits{/sha}","git_commits_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/git/commits{/sha}","comments_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/comments{/number}","issue_comment_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/issues/comments{/number}","contents_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/contents/{+path}","compare_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/merges","archive_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/downloads","issues_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/issues{/number}","pulls_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/pulls{/number}","milestones_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/milestones{/number}","notifications_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/labels{/name}","releases_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/releases{/id}","deployments_url":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/deployments","created_at":"2019-04-12T11:34:52Z","updated_at":"2019-05-30T15:31:19Z","pushed_at":"2019-06-13T05:02:56Z","git_url":"git://github.com/StudyFork/GoogryAndroidArchitectureStudy.git","ssh_url":"[email protected]:StudyFork/GoogryAndroidArchitectureStudy.git","clone_url":"https://github.com/StudyFork/GoogryAndroidArchitectureStudy.git","svn_url":"https://github.com/StudyFork/GoogryAndroidArchitectureStudy","homepage":null,"size":614,"stargazers_count":7,"watchers_count":7,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":null,"forks":14,"open_issues":9,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/pulls/55"},"html":{"href":"https://github.com/StudyFork/GoogryAndroidArchitectureStudy/pull/55"},"issue":{"href":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/issues/55"},"comments":{"href":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy/statuses/175693a1ec8aa7df89cf5561b50597ce92f9f11b"}},"author_association":"CONTRIBUTOR"}}	{ "id": 180995450, "name": "StudyFork/GoogryAndroidArchitectureStudy", "url": "https://api.github.com/repos/StudyFork/GoogryAndroidArchitectureStudy" }	{ "id": 47817912, "login": "NackUn", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/47817912?", "url": "https://api.github.com/users/NackUn" }	{ "id": 40631622, "login": "StudyFork", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/40631622?", "url": "https://api.github.com/orgs/StudyFork" }	2019-06-13T05:18:54	9812606883	{"actor":{"display_login":"NackUn"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/kyma-incubator/compass/pulls/comments/306785858","pull_request_review_id":265989126,"id":306785858,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjc4NTg1OA==","diff_hunk":"@@ -444,16 +458,10 @@ input BasicCredentialDataInput {\n password: String!\n }\n \n-# HealthCheck Input\n-\n-enum FilterOperator {\n- ALL, ANY\n-}\n-\n input LabelFilter {\n label: String!\n- values: [String!]!\n- operator: FilterOperator = ALL\n+ \"\"\"Optional SQL/JSON Path expression. If not provided, returns every object with given label regardless of its value.\"\"\"","path":"components/director/pkg/graphql/schema.graphql","position":null,"original_position":54,"commit_id":"365ed9729ef9b0ff2bf250e31c683f72b39ce9ef","original_commit_id":"0c82640b6735aef49d70d463c3885c92df3cfada","user":{"login":"pkosiec","id":7155799,"node_id":"MDQ6VXNlcjcxNTU3OTk=","avatar_url":"https://avatars2.githubusercontent.com/u/7155799?v=4","gravatar_id":"","url":"https://api.github.com/users/pkosiec","html_url":"https://github.com/pkosiec","followers_url":"https://api.github.com/users/pkosiec/followers","following_url":"https://api.github.com/users/pkosiec/following{/other_user}","gists_url":"https://api.github.com/users/pkosiec/gists{/gist_id}","starred_url":"https://api.github.com/users/pkosiec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkosiec/subscriptions","organizations_url":"https://api.github.com/users/pkosiec/orgs","repos_url":"https://api.github.com/users/pkosiec/repos","events_url":"https://api.github.com/users/pkosiec/events{/privacy}","received_events_url":"https://api.github.com/users/pkosiec/received_events","type":"User","site_admin":false},"body":"Yup, I mentioned this issue in the TODO comment: https://github.com/kyma-incubator/compass/issues/163","created_at":"2019-07-24T12:38:19Z","updated_at":"2019-07-24T12:38:19Z","html_url":"https://github.com/kyma-incubator/compass/pull/160#discussion_r306785858","pull_request_url":"https://api.github.com/repos/kyma-incubator/compass/pulls/160","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kyma-incubator/compass/pulls/comments/306785858"},"html":{"href":"https://github.com/kyma-incubator/compass/pull/160#discussion_r306785858"},"pull_request":{"href":"https://api.github.com/repos/kyma-incubator/compass/pulls/160"}},"in_reply_to_id":306757252},"pull_request":{"url":"https://api.github.com/repos/kyma-incubator/compass/pulls/160","id":300645524,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAwNjQ1NTI0","html_url":"https://github.com/kyma-incubator/compass/pull/160","diff_url":"https://github.com/kyma-incubator/compass/pull/160.diff","patch_url":"https://github.com/kyma-incubator/compass/pull/160.patch","issue_url":"https://api.github.com/repos/kyma-incubator/compass/issues/160","number":160,"state":"open","locked":false,"title":"Update GraphQL schema for labeling","user":{"login":"pkosiec","id":7155799,"node_id":"MDQ6VXNlcjcxNTU3OTk=","avatar_url":"https://avatars2.githubusercontent.com/u/7155799?v=4","gravatar_id":"","url":"https://api.github.com/users/pkosiec","html_url":"https://github.com/pkosiec","followers_url":"https://api.github.com/users/pkosiec/followers","following_url":"https://api.github.com/users/pkosiec/following{/other_user}","gists_url":"https://api.github.com/users/pkosiec/gists{/gist_id}","starred_url":"https://api.github.com/users/pkosiec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkosiec/subscriptions","organizations_url":"https://api.github.com/users/pkosiec/orgs","repos_url":"https://api.github.com/users/pkosiec/repos","events_url":"https://api.github.com/users/pkosiec/events{/privacy}","received_events_url":"https://api.github.com/users/pkosiec/received_events","type":"User","site_admin":false},"body":"Description\r\n\r\nChanges proposed in this pull request:\r\n\r\n- Update GraphQL schema for labeling\r\n\r\nRelated issue(s)\r\nResolves #122\r\n","created_at":"2019-07-24T09:50:53Z","updated_at":"2019-07-24T12:38:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2e77452235c910e5c2db08a7d010564a971eb5d","assignee":{"login":"tgorgol","id":45565988,"node_id":"MDQ6VXNlcjQ1NTY1OTg4","avatar_url":"https://avatars0.githubusercontent.com/u/45565988?v=4","gravatar_id":"","url":"https://api.github.com/users/tgorgol","html_url":"https://github.com/tgorgol","followers_url":"https://api.github.com/users/tgorgol/followers","following_url":"https://api.github.com/users/tgorgol/following{/other_user}","gists_url":"https://api.github.com/users/tgorgol/gists{/gist_id}","starred_url":"https://api.github.com/users/tgorgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgorgol/subscriptions","organizations_url":"https://api.github.com/users/tgorgol/orgs","repos_url":"https://api.github.com/users/tgorgol/repos","events_url":"https://api.github.com/users/tgorgol/events{/privacy}","received_events_url":"https://api.github.com/users/tgorgol/received_events","type":"User","site_admin":false},"assignees":[{"login":"aszecowka","id":476407,"node_id":"MDQ6VXNlcjQ3NjQwNw==","avatar_url":"https://avatars0.githubusercontent.com/u/476407?v=4","gravatar_id":"","url":"https://api.github.com/users/aszecowka","html_url":"https://github.com/aszecowka","followers_url":"https://api.github.com/users/aszecowka/followers","following_url":"https://api.github.com/users/aszecowka/following{/other_user}","gists_url":"https://api.github.com/users/aszecowka/gists{/gist_id}","starred_url":"https://api.github.com/users/aszecowka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aszecowka/subscriptions","organizations_url":"https://api.github.com/users/aszecowka/orgs","repos_url":"https://api.github.com/users/aszecowka/repos","events_url":"https://api.github.com/users/aszecowka/events{/privacy}","received_events_url":"https://api.github.com/users/aszecowka/received_events","type":"User","site_admin":false},{"login":"tgorgol","id":45565988,"node_id":"MDQ6VXNlcjQ1NTY1OTg4","avatar_url":"https://avatars0.githubusercontent.com/u/45565988?v=4","gravatar_id":"","url":"https://api.github.com/users/tgorgol","html_url":"https://github.com/tgorgol","followers_url":"https://api.github.com/users/tgorgol/followers","following_url":"https://api.github.com/users/tgorgol/following{/other_user}","gists_url":"https://api.github.com/users/tgorgol/gists{/gist_id}","starred_url":"https://api.github.com/users/tgorgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgorgol/subscriptions","organizations_url":"https://api.github.com/users/tgorgol/orgs","repos_url":"https://api.github.com/users/tgorgol/repos","events_url":"https://api.github.com/users/tgorgol/events{/privacy}","received_events_url":"https://api.github.com/users/tgorgol/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"crabtree","id":3641496,"node_id":"MDQ6VXNlcjM2NDE0OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/3641496?v=4","gravatar_id":"","url":"https://api.github.com/users/crabtree","html_url":"https://github.com/crabtree","followers_url":"https://api.github.com/users/crabtree/followers","following_url":"https://api.github.com/users/crabtree/following{/other_user}","gists_url":"https://api.github.com/users/crabtree/gists{/gist_id}","starred_url":"https://api.github.com/users/crabtree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crabtree/subscriptions","organizations_url":"https://api.github.com/users/crabtree/orgs","repos_url":"https://api.github.com/users/crabtree/repos","events_url":"https://api.github.com/users/crabtree/events{/privacy}","received_events_url":"https://api.github.com/users/crabtree/received_events","type":"User","site_admin":false},{"login":"PK85","id":9609118,"node_id":"MDQ6VXNlcjk2MDkxMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/9609118?v=4","gravatar_id":"","url":"https://api.github.com/users/PK85","html_url":"https://github.com/PK85","followers_url":"https://api.github.com/users/PK85/followers","following_url":"https://api.github.com/users/PK85/following{/other_user}","gists_url":"https://api.github.com/users/PK85/gists{/gist_id}","starred_url":"https://api.github.com/users/PK85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PK85/subscriptions","organizations_url":"https://api.github.com/users/PK85/orgs","repos_url":"https://api.github.com/users/PK85/repos","events_url":"https://api.github.com/users/PK85/events{/privacy}","received_events_url":"https://api.github.com/users/PK85/received_events","type":"User","site_admin":false},{"login":"akgalwas","id":17785583,"node_id":"MDQ6VXNlcjE3Nzg1NTgz","avatar_url":"https://avatars3.githubusercontent.com/u/17785583?v=4","gravatar_id":"","url":"https://api.github.com/users/akgalwas","html_url":"https://github.com/akgalwas","followers_url":"https://api.github.com/users/akgalwas/followers","following_url":"https://api.github.com/users/akgalwas/following{/other_user}","gists_url":"https://api.github.com/users/akgalwas/gists{/gist_id}","starred_url":"https://api.github.com/users/akgalwas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akgalwas/subscriptions","organizations_url":"https://api.github.com/users/akgalwas/orgs","repos_url":"https://api.github.com/users/akgalwas/repos","events_url":"https://api.github.com/users/akgalwas/events{/privacy}","received_events_url":"https://api.github.com/users/akgalwas/received_events","type":"User","site_admin":false},{"login":"Szymongib","id":19947566,"node_id":"MDQ6VXNlcjE5OTQ3NTY2","avatar_url":"https://avatars3.githubusercontent.com/u/19947566?v=4","gravatar_id":"","url":"https://api.github.com/users/Szymongib","html_url":"https://github.com/Szymongib","followers_url":"https://api.github.com/users/Szymongib/followers","following_url":"https://api.github.com/users/Szymongib/following{/other_user}","gists_url":"https://api.github.com/users/Szymongib/gists{/gist_id}","starred_url":"https://api.github.com/users/Szymongib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Szymongib/subscriptions","organizations_url":"https://api.github.com/users/Szymongib/orgs","repos_url":"https://api.github.com/users/Szymongib/repos","events_url":"https://api.github.com/users/Szymongib/events{/privacy}","received_events_url":"https://api.github.com/users/Szymongib/received_events","type":"User","site_admin":false},{"login":"janmedrek","id":22869996,"node_id":"MDQ6VXNlcjIyODY5OTk2","avatar_url":"https://avatars0.githubusercontent.com/u/22869996?v=4","gravatar_id":"","url":"https://api.github.com/users/janmedrek","html_url":"https://github.com/janmedrek","followers_url":"https://api.github.com/users/janmedrek/followers","following_url":"https://api.github.com/users/janmedrek/following{/other_user}","gists_url":"https://api.github.com/users/janmedrek/gists{/gist_id}","starred_url":"https://api.github.com/users/janmedrek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janmedrek/subscriptions","organizations_url":"https://api.github.com/users/janmedrek/orgs","repos_url":"https://api.github.com/users/janmedrek/repos","events_url":"https://api.github.com/users/janmedrek/events{/privacy}","received_events_url":"https://api.github.com/users/janmedrek/received_events","type":"User","site_admin":false},{"login":"kfurgol","id":32010494,"node_id":"MDQ6VXNlcjMyMDEwNDk0","avatar_url":"https://avatars1.githubusercontent.com/u/32010494?v=4","gravatar_id":"","url":"https://api.github.com/users/kfurgol","html_url":"https://github.com/kfurgol","followers_url":"https://api.github.com/users/kfurgol/followers","following_url":"https://api.github.com/users/kfurgol/following{/other_user}","gists_url":"https://api.github.com/users/kfurgol/gists{/gist_id}","starred_url":"https://api.github.com/users/kfurgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfurgol/subscriptions","organizations_url":"https://api.github.com/users/kfurgol/orgs","repos_url":"https://api.github.com/users/kfurgol/repos","events_url":"https://api.github.com/users/kfurgol/events{/privacy}","received_events_url":"https://api.github.com/users/kfurgol/received_events","type":"User","site_admin":false},{"login":"franpog859","id":32485355,"node_id":"MDQ6VXNlcjMyNDg1MzU1","avatar_url":"https://avatars1.githubusercontent.com/u/32485355?v=4","gravatar_id":"","url":"https://api.github.com/users/franpog859","html_url":"https://github.com/franpog859","followers_url":"https://api.github.com/users/franpog859/followers","following_url":"https://api.github.com/users/franpog859/following{/other_user}","gists_url":"https://api.github.com/users/franpog859/gists{/gist_id}","starred_url":"https://api.github.com/users/franpog859/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franpog859/subscriptions","organizations_url":"https://api.github.com/users/franpog859/orgs","repos_url":"https://api.github.com/users/franpog859/repos","events_url":"https://api.github.com/users/franpog859/events{/privacy}","received_events_url":"https://api.github.com/users/franpog859/received_events","type":"User","site_admin":false},{"login":"klaudiagrz","id":35192450,"node_id":"MDQ6VXNlcjM1MTkyNDUw","avatar_url":"https://avatars2.githubusercontent.com/u/35192450?v=4","gravatar_id":"","url":"https://api.github.com/users/klaudiagrz","html_url":"https://github.com/klaudiagrz","followers_url":"https://api.github.com/users/klaudiagrz/followers","following_url":"https://api.github.com/users/klaudiagrz/following{/other_user}","gists_url":"https://api.github.com/users/klaudiagrz/gists{/gist_id}","starred_url":"https://api.github.com/users/klaudiagrz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaudiagrz/subscriptions","organizations_url":"https://api.github.com/users/klaudiagrz/orgs","repos_url":"https://api.github.com/users/klaudiagrz/repos","events_url":"https://api.github.com/users/klaudiagrz/events{/privacy}","received_events_url":"https://api.github.com/users/klaudiagrz/received_events","type":"User","site_admin":false},{"login":"dbadura","id":45110612,"node_id":"MDQ6VXNlcjQ1MTEwNjEy","avatar_url":"https://avatars3.githubusercontent.com/u/45110612?v=4","gravatar_id":"","url":"https://api.github.com/users/dbadura","html_url":"https://github.com/dbadura","followers_url":"https://api.github.com/users/dbadura/followers","following_url":"https://api.github.com/users/dbadura/following{/other_user}","gists_url":"https://api.github.com/users/dbadura/gists{/gist_id}","starred_url":"https://api.github.com/users/dbadura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbadura/subscriptions","organizations_url":"https://api.github.com/users/dbadura/orgs","repos_url":"https://api.github.com/users/dbadura/repos","events_url":"https://api.github.com/users/dbadura/events{/privacy}","received_events_url":"https://api.github.com/users/dbadura/received_events","type":"User","site_admin":false},{"login":"tgorgol","id":45565988,"node_id":"MDQ6VXNlcjQ1NTY1OTg4","avatar_url":"https://avatars0.githubusercontent.com/u/45565988?v=4","gravatar_id":"","url":"https://api.github.com/users/tgorgol","html_url":"https://github.com/tgorgol","followers_url":"https://api.github.com/users/tgorgol/followers","following_url":"https://api.github.com/users/tgorgol/following{/other_user}","gists_url":"https://api.github.com/users/tgorgol/gists{/gist_id}","starred_url":"https://api.github.com/users/tgorgol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgorgol/subscriptions","organizations_url":"https://api.github.com/users/tgorgol/orgs","repos_url":"https://api.github.com/users/tgorgol/repos","events_url":"https://api.github.com/users/tgorgol/events{/privacy}","received_events_url":"https://api.github.com/users/tgorgol/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1360815251,"node_id":"MDU6TGFiZWwxMzYwODE1MjUx","url":"https://api.github.com/repos/kyma-incubator/compass/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/kyma-incubator/compass/pulls/160/commits","review_comments_url":"https://api.github.com/repos/kyma-incubator/compass/pulls/160/comments","review_comment_url":"https://api.github.com/repos/kyma-incubator/compass/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kyma-incubator/compass/issues/160/comments","statuses_url":"https://api.github.com/repos/kyma-incubator/compass/statuses/365ed9729ef9b0ff2bf250e31c683f72b39ce9ef","head":{"label":"pkosiec:label-gql-schema","ref":"label-gql-schema","sha":"365ed9729ef9b0ff2bf250e31c683f72b39ce9ef","user":{"login":"pkosiec","id":7155799,"node_id":"MDQ6VXNlcjcxNTU3OTk=","avatar_url":"https://avatars2.githubusercontent.com/u/7155799?v=4","gravatar_id":"","url":"https://api.github.com/users/pkosiec","html_url":"https://github.com/pkosiec","followers_url":"https://api.github.com/users/pkosiec/followers","following_url":"https://api.github.com/users/pkosiec/following{/other_user}","gists_url":"https://api.github.com/users/pkosiec/gists{/gist_id}","starred_url":"https://api.github.com/users/pkosiec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkosiec/subscriptions","organizations_url":"https://api.github.com/users/pkosiec/orgs","repos_url":"https://api.github.com/users/pkosiec/repos","events_url":"https://api.github.com/users/pkosiec/events{/privacy}","received_events_url":"https://api.github.com/users/pkosiec/received_events","type":"User","site_admin":false},"repo":{"id":186777173,"node_id":"MDEwOlJlcG9zaXRvcnkxODY3NzcxNzM=","name":"compass","full_name":"pkosiec/compass","private":false,"owner":{"login":"pkosiec","id":7155799,"node_id":"MDQ6VXNlcjcxNTU3OTk=","avatar_url":"https://avatars2.githubusercontent.com/u/7155799?v=4","gravatar_id":"","url":"https://api.github.com/users/pkosiec","html_url":"https://github.com/pkosiec","followers_url":"https://api.github.com/users/pkosiec/followers","following_url":"https://api.github.com/users/pkosiec/following{/other_user}","gists_url":"https://api.github.com/users/pkosiec/gists{/gist_id}","starred_url":"https://api.github.com/users/pkosiec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkosiec/subscriptions","organizations_url":"https://api.github.com/users/pkosiec/orgs","repos_url":"https://api.github.com/users/pkosiec/repos","events_url":"https://api.github.com/users/pkosiec/events{/privacy}","received_events_url":"https://api.github.com/users/pkosiec/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pkosiec/compass","description":"A flexible and easy way to register, manage and group your applications ","fork":true,"url":"https://api.github.com/repos/pkosiec/compass","forks_url":"https://api.github.com/repos/pkosiec/compass/forks","keys_url":"https://api.github.com/repos/pkosiec/compass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkosiec/compass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkosiec/compass/teams","hooks_url":"https://api.github.com/repos/pkosiec/compass/hooks","issue_events_url":"https://api.github.com/repos/pkosiec/compass/issues/events{/number}","events_url":"https://api.github.com/repos/pkosiec/compass/events","assignees_url":"https://api.github.com/repos/pkosiec/compass/assignees{/user}","branches_url":"https://api.github.com/repos/pkosiec/compass/branches{/branch}","tags_url":"https://api.github.com/repos/pkosiec/compass/tags","blobs_url":"https://api.github.com/repos/pkosiec/compass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkosiec/compass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkosiec/compass/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkosiec/compass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkosiec/compass/statuses/{sha}","languages_url":"https://api.github.com/repos/pkosiec/compass/languages","stargazers_url":"https://api.github.com/repos/pkosiec/compass/stargazers","contributors_url":"https://api.github.com/repos/pkosiec/compass/contributors","subscribers_url":"https://api.github.com/repos/pkosiec/compass/subscribers","subscription_url":"https://api.github.com/repos/pkosiec/compass/subscription","commits_url":"https://api.github.com/repos/pkosiec/compass/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkosiec/compass/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkosiec/compass/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkosiec/compass/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkosiec/compass/contents/{+path}","compare_url":"https://api.github.com/repos/pkosiec/compass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkosiec/compass/merges","archive_url":"https://api.github.com/repos/pkosiec/compass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkosiec/compass/downloads","issues_url":"https://api.github.com/repos/pkosiec/compass/issues{/number}","pulls_url":"https://api.github.com/repos/pkosiec/compass/pulls{/number}","milestones_url":"https://api.github.com/repos/pkosiec/compass/milestones{/number}","notifications_url":"https://api.github.com/repos/pkosiec/compass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkosiec/compass/labels{/name}","releases_url":"https://api.github.com/repos/pkosiec/compass/releases{/id}","deployments_url":"https://api.github.com/repos/pkosiec/compass/deployments","created_at":"2019-05-15T07:53:18Z","updated_at":"2019-05-15T07:53:21Z","pushed_at":"2019-07-24T12:36:51Z","git_url":"git://github.com/pkosiec/compass.git","ssh_url":"[email protected]:pkosiec/compass.git","clone_url":"https://github.com/pkosiec/compass.git","svn_url":"https://github.com/pkosiec/compass","homepage":null,"size":1282,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kyma-incubator:master","ref":"master","sha":"110c80d7b5e8ed3bb8a4a442c225029f0314a4a0","user":{"login":"kyma-incubator","id":40658079,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjU4MDc5","avatar_url":"https://avatars3.githubusercontent.com/u/40658079?v=4","gravatar_id":"","url":"https://api.github.com/users/kyma-incubator","html_url":"https://github.com/kyma-incubator","followers_url":"https://api.github.com/users/kyma-incubator/followers","following_url":"https://api.github.com/users/kyma-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kyma-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kyma-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyma-incubator/subscriptions","organizations_url":"https://api.github.com/users/kyma-incubator/orgs","repos_url":"https://api.github.com/users/kyma-incubator/repos","events_url":"https://api.github.com/users/kyma-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kyma-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":186589820,"node_id":"MDEwOlJlcG9zaXRvcnkxODY1ODk4MjA=","name":"compass","full_name":"kyma-incubator/compass","private":false,"owner":{"login":"kyma-incubator","id":40658079,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjU4MDc5","avatar_url":"https://avatars3.githubusercontent.com/u/40658079?v=4","gravatar_id":"","url":"https://api.github.com/users/kyma-incubator","html_url":"https://github.com/kyma-incubator","followers_url":"https://api.github.com/users/kyma-incubator/followers","following_url":"https://api.github.com/users/kyma-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kyma-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kyma-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyma-incubator/subscriptions","organizations_url":"https://api.github.com/users/kyma-incubator/orgs","repos_url":"https://api.github.com/users/kyma-incubator/repos","events_url":"https://api.github.com/users/kyma-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kyma-incubator/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kyma-incubator/compass","description":"A flexible and easy way to register, manage and group your applications ","fork":false,"url":"https://api.github.com/repos/kyma-incubator/compass","forks_url":"https://api.github.com/repos/kyma-incubator/compass/forks","keys_url":"https://api.github.com/repos/kyma-incubator/compass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyma-incubator/compass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyma-incubator/compass/teams","hooks_url":"https://api.github.com/repos/kyma-incubator/compass/hooks","issue_events_url":"https://api.github.com/repos/kyma-incubator/compass/issues/events{/number}","events_url":"https://api.github.com/repos/kyma-incubator/compass/events","assignees_url":"https://api.github.com/repos/kyma-incubator/compass/assignees{/user}","branches_url":"https://api.github.com/repos/kyma-incubator/compass/branches{/branch}","tags_url":"https://api.github.com/repos/kyma-incubator/compass/tags","blobs_url":"https://api.github.com/repos/kyma-incubator/compass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyma-incubator/compass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyma-incubator/compass/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyma-incubator/compass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyma-incubator/compass/statuses/{sha}","languages_url":"https://api.github.com/repos/kyma-incubator/compass/languages","stargazers_url":"https://api.github.com/repos/kyma-incubator/compass/stargazers","contributors_url":"https://api.github.com/repos/kyma-incubator/compass/contributors","subscribers_url":"https://api.github.com/repos/kyma-incubator/compass/subscribers","subscription_url":"https://api.github.com/repos/kyma-incubator/compass/subscription","commits_url":"https://api.github.com/repos/kyma-incubator/compass/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyma-incubator/compass/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyma-incubator/compass/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyma-incubator/compass/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyma-incubator/compass/contents/{+path}","compare_url":"https://api.github.com/repos/kyma-incubator/compass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyma-incubator/compass/merges","archive_url":"https://api.github.com/repos/kyma-incubator/compass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyma-incubator/compass/downloads","issues_url":"https://api.github.com/repos/kyma-incubator/compass/issues{/number}","pulls_url":"https://api.github.com/repos/kyma-incubator/compass/pulls{/number}","milestones_url":"https://api.github.com/repos/kyma-incubator/compass/milestones{/number}","notifications_url":"https://api.github.com/repos/kyma-incubator/compass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyma-incubator/compass/labels{/name}","releases_url":"https://api.github.com/repos/kyma-incubator/compass/releases{/id}","deployments_url":"https://api.github.com/repos/kyma-incubator/compass/deployments","created_at":"2019-05-14T09:28:13Z","updated_at":"2019-07-24T11:46:50Z","pushed_at":"2019-07-24T12:36:53Z","git_url":"git://github.com/kyma-incubator/compass.git","ssh_url":"[email protected]:kyma-incubator/compass.git","clone_url":"https://github.com/kyma-incubator/compass.git","svn_url":"https://github.com/kyma-incubator/compass","homepage":"","size":1162,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":46,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":15,"open_issues":46,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kyma-incubator/compass/pulls/160"},"html":{"href":"https://github.com/kyma-incubator/compass/pull/160"},"issue":{"href":"https://api.github.com/repos/kyma-incubator/compass/issues/160"},"comments":{"href":"https://api.github.com/repos/kyma-incubator/compass/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/kyma-incubator/compass/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/kyma-incubator/compass/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kyma-incubator/compass/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/kyma-incubator/compass/statuses/365ed9729ef9b0ff2bf250e31c683f72b39ce9ef"}},"author_association":"MEMBER"}}	{ "id": 186589820, "name": "kyma-incubator/compass", "url": "https://api.github.com/repos/kyma-incubator/compass" }	{ "id": 7155799, "login": "pkosiec", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/7155799?", "url": "https://api.github.com/users/pkosiec" }	{ "id": 40658079, "login": "kyma-incubator", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/40658079?", "url": "https://api.github.com/orgs/kyma-incubator" }	2019-07-24T12:38:19	10074657252	{"actor":{"display_login":"pkosiec"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/cienciadedatos/r4ds/pulls/comments/263211769","pull_request_review_id":211568320,"id":263211769,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MzIxMTc2OQ==","diff_hunk":"@@ -1,564 +1,534 @@\n-# Tidy data\n+# Datos ordenados\n \n-## Introduction\n+## Introducción\n \n-> \"Happy families are all alike; every unhappy family is unhappy in its\n-> own way.\" --– Leo Tolstoy\n+> \"Todas las familias felices se parecen unas a otras, pero cada familia infeliz lo es a su manera.\" --– Leo Tolstoy\n \n-> \"Tidy datasets are all alike, but every messy dataset is messy in its\n-> own way.\" --– Hadley Wickham\n+> \"Todos los datos ordenados se parecen unos a otros, pero cada dato desordenado lo es a su manera\" --- Hadley Wickham\n \n-In this chapter, you will learn a consistent way to organise your data in R, an organisation called __tidy data__. Getting your data into this format requires some upfront work, but that work pays off in the long term. Once you have tidy data and the tidy tools provided by packages in the tidyverse, you will spend much less time munging data from one representation to another, allowing you to spend more time on the analytic questions at hand.\n+En este capítulo aprenderás una metodología consistente para organizar datos en R, a esta metodología le llamaremos __tidy data__ (datos ordenados). Llevar tus datos a este formato requiere algo de trabajo previo, sin embargo dicho trabajo tiene retorno positivo en el largo plazo. Una vez que tengas tus datos ordenados y las herramientas para ordenar datos que provee el tidyverse, vas a gastar mucho menos tiempo pasando de una forma de representar datos a otra, permietiéndote destinar más tiempo a las preguntas analíticas.\n \n-This chapter will give you a practical introduction to tidy data and the accompanying tools in the __tidyr__ package. If you'd like to learn more about the underlying theory, you might enjoy the Tidy Data paper published in the Journal of Statistical Software, <http://www.jstatsoft.org/v59/i10/paper>.\n+Este capítulo te dará una introducción práctica a tidy data y las herramientas que provee el paquete __tidyr__. Si desear saber más acerca de la teoría subyacente, puede que te guste el artículo Tidy Data publicado en la revista Journal of Statistical Software, <http://www.jstatsoft.org/v59/i10/paper>.\n \n-### Prerequisites\n+### Prerequisitos\n \n-In this chapter we'll focus on tidyr, a package that provides a bunch of tools to help tidy up your messy datasets. tidyr is a member of the core tidyverse.\n+En este capítulo nos enfocaremos en tidyr, un paquete que provee un conjunto de herramientas que te ayudarán a ordenar datos desordenados. tidyr es parte del núcleo del tidyverse.\n \n ```{r setup, message = FALSE}\n library(tidyverse)\n+library(datos)\n ```\n \n-## Tidy data\n+## Datos ordenados\n \n-You can represent the same underlying data in multiple ways. The example below shows the same data organised in four different ways. Each dataset shows the same values of four variables country, year, population, and cases, but each dataset organises the values in a different way.\n+Puedes representar la misma información de múltiples formas. El ejemplo a continuación muestra los mismos datos ordenados de cuatro manera distintas. Cada dataset muestra los mismos valores de cuatro variables pais, anio, poblacion y casos, pero cada dataset organiza los valores de forma distinta.\n \n ```{r}\n-table1\n-table2\n-table3\n+tabla1\n+tabla2\n+tabla3\n \n # Spread across two tibbles\n-table4a # cases\n-table4b # population\n+tabla4a # casos\n+tabla4b # poblacion\n ```\n \n-These are all representations of the same underlying data, but they are not equally easy to use. One dataset, the tidy dataset, will be much easier to work with inside the tidyverse. \n+Todo lo anterior representa los mismos datos subyacentes, pero no es igualmente fácil de usar. Un dataset, el dataset ordenado, es mucho más fácil de trabajar en el tidyverse.\n \n-There are three interrelated rules which make a dataset tidy:\n+Existen tres reglas interrelacionadas que hacen que un dataset sea ordenado:\n \n-1. Each variable must have its own column.\n-1. Each observation must have its own row.\n-1. Each value must have its own cell.\n+1. Cada variable tiene su propia columna.\n+1. Cada observación tiene su propia fila.\n+1. Cada valor tiene su propia celda.\n \n-Figure \\@ref(fig:tidy-structure) shows the rules visually.\n+La figura \\@ref(fig:tidy-structure) muestra estas reglas visualmente.\n \n ```{r tidy-structure, echo = FALSE, out.width = \"100%\", fig.cap = \"Following three rules makes a dataset tidy: variables are in columns, observations are in rows, and values are in cells.\"}\n-knitr::include_graphics(\"images/tidy-1.png\")\n+knitr::include_graphics(\"images/tidy-1.svg\")\n ```\n \n-These three rules are interrelated because it's impossible to only satisfy two of the three. That interrelationship leads to an even simpler set of practical instructions:\n+Estas reglas están interrelacionadas ya que es imposible cumplir dos de las tres.\n+Esta interrelación lleva a un conjunto práctico de instrucciones mucho más simple:\n \n-1. Put each dataset in a tibble.\n-1. Put each variable in a column.\n+1. Coloca cada dataset en un tibble.\n+1. Coloca cada variable en una columna.\n \n-In this example, only `table1` is tidy. It's the only representation where each column is a variable.\n+En este ejemplo, solo `tabla1` está ordenado. Es la única representación en que cada columna es una variable.\n \n-Why ensure that your data is tidy? There are two main advantages:\n+¿Por qué asegurarse de que los datos están ordenados? Existen dos principales ventajas:\n \n-1. There's a general advantage to picking one consistent way of storing\n- data. If you have a consistent data structure, it's easier to learn the\n- tools that work with it because they have an underlying uniformity.\n- \n-1. There's a specific advantage to placing variables in columns because\n- it allows R's vectorised nature to shine. As you learned in\n- [mutate](#mutate-funs) and [summary functions](#summary-funs), most \n- built-in R functions work with vectors of values. That makes transforming \n- tidy data feel particularly natural.\n+1. Existe una ventaja general de elegir una forma consistente de almacenar datos. Si tienes una estructura de datos consistente, es más fácil aprender las herramientas que sirven con aquello ya que presenta una uniformidad subyacente.\n+1. Existe una ventaja específica al situar las variables en las columnas ya que permite que la naturaleza vectorizada de R brille. Como habrás aprendido en [mutate](#mutate-funs) y [summary functions](#summary-funs), muchas de las funciones que vienen con R trabajan con vectores de valores. Esto hace que transformar datos ordenados sea casi natural.\n \n-dplyr, ggplot2, and all the other packages in the tidyverse are designed to work with tidy data. Here are a couple of small examples showing how you might work with `table1`.\n+dplyr, ggplot2 y el resto de los paquetes del tidyverse están diseñados para trabajar con datos ordenados. Aquí hay algunos ejemplos de cómo se podría trabajar con `tabla1`.\n \n ```{r, out.width = \"50%\"}\n-# Compute rate per 10,000\n-table1 %>% \n- mutate(rate = cases / population * 10000)\n+# Calcular tasa por cada 10,000 habitantes\n+tabla1 %>%\n+ mutate(tasa = casos / poblacion * 10000)\n \n-# Compute cases per year\n-table1 %>% \n- count(year, wt = cases)\n+# Compute casos per anio\n+tabla1 %>%\n+ count(anio, wt = casos)\n \n-# Visualise changes over time\n+# Visualizar cambios en el tiempo\n library(ggplot2)\n-ggplot(table1, aes(year, cases)) + \n- geom_line(aes(group = country), colour = \"grey50\") + \n- geom_point(aes(colour = country))\n+ggplot(tabla1, aes(anio, casos)) +\n+ geom_line(aes(group = pais), colour = \"grey50\") +\n+ geom_point(aes(colour = pais))\n ```\n \n-### Exercises\n+### Ejercicios\n \n-1. Using prose, describe how the variables and observations are organised in\n- each of the sample tables.\n+1. Usando prosa, describe como las variables y observaciones se organizan en las tablas de ejemplo.\n \n-1. Compute the `rate` for `table2`, and `table4a` + `table4b`. \n- You will need to perform four operations:\n+1. Calcula la `tasa` en las tablas `tabla2` y `tabla4a` + `tabla4b`.\n+ Necesitarás las siguientes operaciones:\n \n- 1. Extract the number of TB cases per country per year.\n- 1. Extract the matching population per country per year.\n- 1. Divide cases by population, and multiply by 10000.\n- 1. Store back in the appropriate place.\n- \n- Which representation is easiest to work with? Which is hardest? Why?\n+ 1. Extrae el número de casos de tuberculosis por país y año.\n+ 1. Extrae la población por país y año.\n+ 1. Divide los casos por la población y multiplica por 10000.\n+ 1. Inserta los datos en el lugar adecuado.\n \n-1. Recreate the plot showing change in cases over time using `table2`\n- instead of `table1`. What do you need to do first?\n+ ¿Cuál representación es más fácil de trabajar? ¿Cuál es la más difícil? ¿Por qué?\n \n-## Spreading and gathering\n+1. Recrea el gráfico que muestra el cambio en el número de casos usando la `tabla2` en lugar de la `tabla1`. ¿Qué debes hacer en primera lugar?\n \n-The principles of tidy data seem so obvious that you might wonder if you'll ever encounter a dataset that isn't tidy. Unfortunately, however, most data that you will encounter will be untidy. There are two main reasons:\n+## Gather y Spread\n \n-1. Most people aren't familiar with the principles of tidy data, and it's hard\n- to derive them yourself unless you spend a _lot_ of time working with data.\n- \n-1. Data is often organised to facilitate some use other than analysis. For \n- example, data is often organised to make entry as easy as possible.\n- \n-This means for most real analyses, you'll need to do some tidying. The first step is always to figure out what the variables and observations are. Sometimes this is easy; other times you'll need to consult with the people who originally generated the data. \n-The second step is to resolve one of two common problems:\n+Los principios de tidy data parecen tan obvios que te preguntarás si acaso vas a encontrar un dataset que no está ordenado. Desafortunadamente, sin embargo, gran parte de los datos que vas a encontrar están desordenados. Existen dos principales razones para esto:\n \n-1. One variable might be spread across multiple columns.\n+1. La mayoría de las personas no están familirizadas con los principios de datos ordenados y es difícil derivarlos por cuenta propia a menos que pases _mucho_ tiempo trabajando con datos.\n \n-1. One observation might be scattered across multiple rows.\n+2. Los datos a menudo están organizados para facilitar tareas distintas del análisis. Por ejemplo, los datos se organizan para que su registro sea lo más sencillo posible.\n \n-Typically a dataset will only suffer from one of these problems; it'll only suffer from both if you're really unlucky! To fix these problems, you'll need the two most important functions in tidyr: `gather()` and `spread()`.\n+Esto significa que para la mayoría de los análisis, necesitarás ordenar los datos. El primer paso siempre es entender el significado de las variables y observaciones. Esto a veces es fácil, otras veces deberás consultar con quienes crearon el dataset. El segundo paso es resolver uno de los siguientes problemas frecuentes:\n \n-### Gathering\n+1. Una variable se esparce entre varias columnas\n \n-A common problem is a dataset where some of the column names are not names of variables, but _values_ of a variable. Take `table4a`: the column names `1999` and `2000` represent values of the `year` variable, and each row represents two observations, not one.\n+1. Una observación se esparce entre múltiples filas.\n+\n+Típicamente un dataset tiene uno de los problemas, ¡si contiene ambos significa que tienes muy mala suerte! Para solucionar estos problemas necesitarás las dos funciones más importantes de tidyr: `gather()` (reunir) y `spread()` (esparcir).\n+\n+### Gather\n+\n+Un problema común se tiene cuando en un dataset los nombres de las columnas no representan nombres de variables, sino que representan los _valores_ de una variable. Tomando el caso de la `tabla4a`: los nombres de las columnas `1999` y `2000` representan los valores de la variable `anio` y cada fila representa dos observaciones en lugar de una.\n \n ```{r}\n-table4a\n+tabla4a\n ```\n \n-To tidy a dataset like this, we need to __gather__ those columns into a new pair of variables. To describe that operation we need three parameters:\n+Para ordenar un dataset como este necesitamos contraer (__gather__) tales columnas en un nuevo par de variables. Para describir dicha operación necesitamos tres parámetros:\n \n-* The set of columns that represent values, not variables. In this example, \n- those are the columns `1999` and `2000`.\n+* El conjunto de columnas que representan valores y no variables. En este ejemplo son las columnas `1999` y `2000`.\n \n-* The name of the variable whose values form the column names. I call that\n- the `key`, and here it is `year`.\n+* El nombre de la variable cuyos valores forman los nombres de las columnas. Llamaremos a esto `key` (llave) y en este caso corresponde a `anio`.\n \n-* The name of the variable whose values are spread over the cells. I call \n- that `value`, and here it's the number of `cases`.\n- \n-Together those parameters generate the call to `gather()`:\n+* El nombre de la variable cuyos valores se esparcen por las celdas. Llamaremos a esto `value` (valor) y en este caso corresponde al número de `casos`.\n+\n+Juntando estos parámetros se puede realizar una llamada a `gather()`:\n \n ```{r}\n-table4a %>% \n- gather(`1999`, `2000`, key = \"year\", value = \"cases\")\n+tabla4a %>%\n+ gather(`1999`, `2000`, key = \"anio\", value = \"casos\")\n ```\n \n-The columns to gather are specified with `dplyr::select()` style notation. Here there are only two columns, so we list them individually. Note that \"1999\" and \"2000\" are non-syntactic names (because they don't start with a letter) so we have to surround them in backticks. To refresh your memory of the other ways to select columns, see [select](#select).\n+Las columnas a contraer quedan seleccionadas siguiendo el estilo de notación de `dplyr::select()`. En este caso hay dos columnas, por lo que las listamos individualmente. Nota que \"1999\" y \"2000\" son nombres no-sintáxicos (debido a que no comienzan con una letra) por lo que los escribimos con __backtick__. Para refrescar tu memoria respecto de la selección de columnas, consulta [select](#select).\n \n-```{r tidy-gather, echo = FALSE, out.width = \"100%\", fig.cap = \"Gathering `table4` into a tidy form.\"}\n-knitr::include_graphics(\"images/tidy-9.png\")\n+```{r tidy-gather, echo = FALSE, out.width = \"100%\", fig.cap = \"Gathering `tabla4` into a tidy form.\"}\n+knitr::include_graphics(\"images/tidy-9.svg\")\n ```\n \n-In the final result, the gathered columns are dropped, and we get new `key` and `value` columns. Otherwise, the relationships between the original variables are preserved. Visually, this is shown in Figure \\@ref(fig:tidy-gather). We can use `gather()` to tidy `table4b` in a similar fashion. The only difference is the variable stored in the cell values:\n+En el resultado final, las columnas reunidas se eliminan y obtenemos la nuevas variables `key` y `value`. De otro modo, la relacién entre las variables originales se mantiene. Visualmente, esto se observa en la Figura \\@ref(fig:tidy-gather). Podemos usar `gather()` para ordenar `tabla4b` de modo similar. La única diferencia es la variable almacenada en los valores de las celdas:\n \n ```{r}\n-table4b %>% \n- gather(`1999`, `2000`, key = \"year\", value = \"population\")\n+tabla4b %>%\n+ gather(`1999`, `2000`, key = \"anio\", value = \"poblacion\")\n ```\n \n-To combine the tidied versions of `table4a` and `table4b` into a single tibble, we need to use `dplyr::left_join()`, which you'll learn about in [relational data].\n+Para combinar las versiones ordenadas de `tabla4a` y `tabla4b` en un único tibble, necesitamos usar `dplyr::left_join()`, función que aprenderás en [datos relacionales].\n \n ```{r}\n-tidy4a <- table4a %>% \n- gather(`1999`, `2000`, key = \"year\", value = \"cases\")\n-tidy4b <- table4b %>% \n- gather(`1999`, `2000`, key = \"year\", value = \"population\")\n+tidy4a <- tabla4a %>%\n+ gather(`1999`, `2000`, key = \"anio\", value = \"casos\")\n+\n+tidy4b <- tabla4b %>%\n+ gather(`1999`, `2000`, key = \"anio\", value = \"poblacion\")\n+\n left_join(tidy4a, tidy4b)\n ```\n \n-### Spreading\n+### Spread\n+\n+Extender (__spread__) es lo opuesto de __gather__. Lo usas cuando una observación aparece en múltiples filas. Por ejemplo, toma la tabla `tabla2`: una observación \n \n-Spreading is the opposite of gathering. You use it when an observation is scattered across multiple rows. For example, take `table2`: an observation is a country in a year, but each observation is spread across two rows.\n+You use it when an observation is scattered across multiple rows. For example, take `tabla2`: una observación es un país en un año, pero cada observación se reparte entre dos filas.\n \n ```{r}\n-table2\n+tabla2\n ```\n \n-To tidy this up, we first analyse the representation in similar way to `gather()`. This time, however, we only need two parameters:\n+Para ordenar esto, primero analiza la representación de un modo similar a cómo se haría con `gather()`. Esta vez, sin embargo, necesitamos únicamente dos parámetros:\n \n-* The column that contains variable names, the `key` column. Here, it's \n- `type`.\n \n-* The column that contains values from multiple variables, the `value`\n- column. Here it's `count`.\n+* La columna que contiene los nombres de las variables, la columna `key`. En este caso corresponde a `tipo`.\n \n-Once we've figured that out, we can use `spread()`, as shown programmatically below, and visually in Figure \\@ref(fig:tidy-spread).\n+* La columna que contiene valores de múltiples variables, la columna `value`. En este caso corresponde a `cuenta`.\n+\n+Una vez resuelto esto, podemos usar `spread()`, como se muestra programáticamente abajo y visualmente en la Figura \\@ref(fig:tidy-spread).\n \n ```{r}\n-table2 %>%\n- spread(key = type, value = count)\n+tabla2 %>%\n+ spread(key = tipo, value = cuenta)\n ```\n \n-```{r tidy-spread, echo = FALSE, out.width = \"100%\", fig.cap = \"Spreading `table2` makes it tidy\"}\n-knitr::include_graphics(\"images/tidy-8.png\")\n+```{r tidy-spread, echo = FALSE, out.width = \"100%\", fig.cap = \"Spreading `tabla2` makes it tidy\"}\n+knitr::include_graphics(\"images/tidy-8.svg\")\n ```\n \n-As you might have guessed from the common `key` and `value` arguments, `spread()` and `gather()` are complements. `gather()` makes wide tables narrower and longer; `spread()` makes long tables shorter and wider.\n+Como te habrás dado cuenta a partir de los argumentos comunes `key` y `value`, `gather()` y `spread()` son complementarios. `gather()` genera tablas estrechas y largas, `spread()` genera tablas anchas y cortas.\n \n-### Exercises\n+### Ejercicios\n \n-1. Why are `gather()` and `spread()` not perfectly symmetrical? \n- Carefully consider the following example:\n- \n- ```{r, eval = FALSE}\n- stocks <- tibble(\n- year = c(2015, 2015, 2016, 2016),\n- half = c( 1, 2, 1, 2),\n- return = c(1.88, 0.59, 0.92, 0.17)\n- )\n- stocks %>% \n- spread(year, return) %>% \n- gather(\"year\", \"return\", `2015`:`2016`)\n- ```\n- \n- (Hint: look at the variable types and think about column _names_.)\n- \n- Both `spread()` and `gather()` have a `convert` argument. What does it \n- do?\n+1. ¿Por qué `gather()` y `spread()` no son perfectamente simétricas?\n+ Observa cuidadosamente el siguiente ejemplo:\n \n-1. Why does this code fail?\n+```{r, eval = FALSE}\n+ stocks <- tibble(\n+ anio = c(2015, 2015, 2016, 2016),\n+ semestre = c(1, 2, 1, 2),\n+ retorno = c(1.88, 0.59, 0.92, 0.17)\n+ )\n+ stocks %>%\n+ spread(anio, retorno) %>%\n+ gather(\"anio\", \"retorno\", `2015`:`2016`)\n+```\n \n- ```{r, error = TRUE}\n- table4a %>% \n- gather(1999, 2000, key = \"year\", value = \"cases\")\n- ```\n+ (Hint: observa los tipos de variables y piensa en los nombres de las columnas)\n \n-1. Why does spreading this tibble fail? How could you add a new column to fix\n- the problem?\n-\n- ```{r}\n- people <- tribble(\n- ~name, ~key, ~value,\n- #-----------------\|--------\|------\n- \"Phillip Woods\", \"age\", 45,\n- \"Phillip Woods\", \"height\", 186,\n- \"Phillip Woods\", \"age\", 50,\n- \"Jessica Cordero\", \"age\", 37,\n- \"Jessica Cordero\", \"height\", 156\n- )\n- ```\n+ Tanto `spread()` como `gather()` tienen el argumento `convert` (convertir). ¿Qué hace dich argumento?\n \n-1. Tidy the simple tibble below. Do you need to spread or gather it?\n- What are the variables?\n+1. ¿Por qué falla el siguiente código?\n \n- ```{r}\n- preg <- tribble(\n- ~pregnant, ~male, ~female,\n- \"yes\", NA, 10,\n- \"no\", 20, 12\n- )\n- ```\n+```{r, error = TRUE}\n+tabla4a %>%\n+ gather(`1999`, `2000`, key = \"anio\", value = \"casos\")\n+```\n+\n+1. ¿Por qué no se puede extender la siguiente tabla? ¿Cómo agregarias una nueva columna para resolver el problema?\n+\n+```{r}\n+personas <- tribble(\n+ ~ nombre, ~ llave, ~ valor,\n+ #-----------------\|--------\|------\n+ \"Phillip Woods\", \"age\", 45,\n+ \"Phillip Woods\", \"height\", 186,\n+ \"Phillip Woods\", \"age\", 50,\n+ \"Jessica Cordero\", \"age\", 37,\n+ \"Jessica Cordero\", \"height\", 156\n+)\n+```\n \n-## Separating and uniting\n+1. Ordena la siguiente tabla. ¿Necesitas extenderla o contraerla? ¿Cuáles son las variables?\n \n-So far you've learned how to tidy `table2` and `table4`, but not `table3`. `table3` has a different problem: we have one column (`rate`) that contains two variables (`cases` and `population`). To fix this problem, we'll need the `separate()` function. You'll also learn about the complement of `separate()`: `unite()`, which you use if a single variable is spread across multiple columns.\n+```{r}\n+embarazo <- tribble(\n+ ~ embarazo, ~ hombre, ~ mujer,\n+ \"yes\", NA, 10,\n+ \"no\", 20, 12\n+)\n+```\n+\n+## Separar y unir\n \n-### Separate\n+Hasta ahora has aprendido a ordenar las tablas `tabla2` y `tabla4`, pero no la `tabla3` que tiene un problema diferente: contiene una columna (`tasa`) la cual contiene dos variables (`casos` y `poblacion`). Para solucionar este problema, necesitamos la función `separate()` (separar), También aprenderás acerca del complemento de `separate()`: `unite()` (unir), la cual se usa en los casos en que una única variable se reparte en varias columnas.\n \n-`separate()` pulls apart one column into multiple columns, by splitting wherever a separator character appears. Take `table3`:\n+### Separar\n+\n+`separate()`divide una columna en varias columnas, dividiendo de acuerdo a la posición de un caracter separador. Tomando la `tabla3`:\n \n ```{r}\n-table3\n+tabla3\n ```\n \n-The `rate` column contains both `cases` and `population` variables, and we need to split it into two variables. `separate()` takes the name of the column to separate, and the names of the columns to separate into, as shown in Figure \\@ref(fig:tidy-separate) and the code below.\n+La columna `tasa` contiene las variables `casos` y `poblacion`,necesitamos dividir esto en dos variables. `separate()` toma el nombre de la columna a separar y el nombre de las columnas a donde irá el resultado, tal como se muestra en la Figura \\@ref(fig:tidy-separate) y el código a continuación.\n \n ```{r}\n-table3 %>% \n- separate(rate, into = c(\"cases\", \"population\"))\n+tabla3 %>%\n+ separate(tasa, into = c(\"casos\", \"poblacion\"))\n ```\n \n-```{r tidy-separate, echo = FALSE, out.width = \"75%\", fig.cap = \"Separating `table3` makes it tidy\"}\n-knitr::include_graphics(\"images/tidy-17.png\")\n+```{r tidy-separate, echo = FALSE, out.width = \"75%\", fig.cap = \"Separating `tabla3` makes it tidy\"}\n+knitr::include_graphics(\"images/tidy-17.svg\")\n ```\n \n-By default, `separate()` will split values wherever it sees a non-alphanumeric character (i.e. a character that isn't a number or letter). For example, in the code above, `separate()` split the values of `rate` at the forward slash characters. If you wish to use a specific character to separate a column, you can pass the character to the `sep` argument of `separate()`. For example, we could rewrite the code above as:\n+Por defecto, `separate()` dividirá una columna donde aparezca un caracter no no alfanumérico (i.e. un caracter que no es un número o letra). Por ejemplo, en el siguiente código, `separate()` divide los valores de `tasa` donde aparece el caracter __slash__. Si deseas usar un caracter específico para separar una columna, puedes especificarlo en el argumento `sep` de `separate()`. Por ejemplo, lo anterior se puede re-escribir del siguiente modo:\n \n ```{r eval = FALSE}\n-table3 %>% \n- separate(rate, into = c(\"cases\", \"population\"), sep = \"/\")\n+tabla3 %>%\n+ separate(tasa, into = c(\"casos\", \"poblacion\"), sep = \"/\")\n ```\n \n-(Formally, `sep` is a regular expression, which you'll learn more about in [strings].)\n+(Formalmente, `sep` es una expresión regular y aprenderás más sobre esto en [strings].)\n \n-Look carefully at the column types: you'll notice that `cases` and `population` are character columns. This is the default behaviour in `separate()`: it leaves the type of the column as is. Here, however, it's not very useful as those really are numbers. We can ask `separate()` to try and convert to better types using `convert = TRUE`:\n+Mira atentamente los tipos de columna: notarás que `casos` y `poblacion` son columnas de tipo caracter. Este es el comportamiento por defecto en `separate()`: preserva el tipo de columna. Aquí, sin embargo, no es muy útil ya que se trata de números. Podemos pedir `separate()` a separate que intente convertir a un tipo más adecuado usando `convert = TRUE`:\n \n ```{r}\n-table3 %>% \n- separate(rate, into = c(\"cases\", \"population\"), convert = TRUE)\n+tabla3 %>%\n+ separate(tasa, into = c(\"casos\", \"poblacion\"), convert = TRUE)\n ```\n \n-You can also pass a vector of integers to `sep`. `separate()` will interpret the integers as positions to split at. Positive values start at 1 on the far-left of the strings; negative value start at -1 on the far-right of the strings. When using integers to separate strings, the length of `sep` should be one less than the number of names in `into`. \n+También puedes pasar un vector de enteros a `sep`. `separate()` interpreta los enteros como las posiciones donde dividir. Los valores positivos comienzan en 1 al extremo izquierdo de las cadenas de texto; los valores negativos comienzan en -1 al extremo derecho de las cadena de texto. Cuando uses enteros para separar cadenas de textos, el largo de `sep` debe ser uno menos que el número de nombres en `into`.\n \n-You can use this arrangement to separate the last two digits of each year. This make this data less tidy, but is useful in other cases, as you'll see in a little bit.\n+Puedes usar este arreglo para separar los últimos dos dígitos de cada año. Esto deja los datos menos ordenados, pero es útil en otros casos, como se verá más adelante.\n \n ```{r}\n-table3 %>% \n- separate(year, into = c(\"century\", \"year\"), sep = 2)\n+tabla3 %>%\n+ separate(anio, into = c(\"siglo\", \"anio\"), sep = 2)\n ```\n \n-### Unite\n+### Unir\n \n-`unite()` is the inverse of `separate()`: it combines multiple columns into a single column. You'll need it much less frequently than `separate()`, but it's still a useful tool to have in your back pocket.\n+`unite()` es el inverso de `separate()`: combina múltiples columnas en una única columna. Necesitarás esta función con mucha menos frecuencia que `separate()`, pero aún así es una buena herramienta a tener en el bolsillo trasero.\n \n-```{r tidy-unite, echo = FALSE, out.width = \"75%\", fig.cap = \"Uniting `table5` makes it tidy\"}\n-knitr::include_graphics(\"images/tidy-18.png\")\n+```{r tidy-unite, echo = FALSE, out.width = \"75%\", fig.cap = \"Uniting `tabla5` makes it tidy\"}\n+knitr::include_graphics(\"images/tidy-18.svg\")\n ```\n \n-We can use `unite()` to rejoin the century and year columns that we created in the last example. That data is saved as `tidyr::table5`. `unite()` takes a data frame, the name of the new variable to create, and a set of columns to combine, again specified in `dplyr::select()` style:\n+Podemos usar `unite()` para unir las columnas siglo y anio creadas en el ejemplo anterior. Los datos están guardados en `tidyr::tabla5`. `unite()` toma un data frame, el nombre de la nueva variable a crear, y un conjunto de columnas a combinar, las que se especifican siguiendo el estilo de la función `dplyr::select()`:\n \n ```{r}\n-table5 %>% \n- unite(new, century, year)\n+tabla5 %>%\n+ unite(new, siglo, anio)","path":"tidy.Rmd","position":null,"original_position":491,"commit_id":"a1a28c4e3ceb53a7153095c9c425b51250e866da","original_commit_id":"09b060dfcb5b398e24e9af9e6533eee37b17996e","user":{"login":"mpaulacaldas","id":33395215,"node_id":"MDQ6VXNlcjMzMzk1MjE1","avatar_url":"https://avatars1.githubusercontent.com/u/33395215?v=4","gravatar_id":"","url":"https://api.github.com/users/mpaulacaldas","html_url":"https://github.com/mpaulacaldas","followers_url":"https://api.github.com/users/mpaulacaldas/followers","following_url":"https://api.github.com/users/mpaulacaldas/following{/other_user}","gists_url":"https://api.github.com/users/mpaulacaldas/gists{/gist_id}","starred_url":"https://api.github.com/users/mpaulacaldas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpaulacaldas/subscriptions","organizations_url":"https://api.github.com/users/mpaulacaldas/orgs","repos_url":"https://api.github.com/users/mpaulacaldas/repos","events_url":"https://api.github.com/users/mpaulacaldas/events{/privacy}","received_events_url":"https://api.github.com/users/mpaulacaldas/received_events","type":"User","site_admin":false},"body":"Cambiar `new` por `nueva`","created_at":"2019-03-07T01:59:45Z","updated_at":"2019-03-07T01:59:45Z","html_url":"https://github.com/cienciadedatos/r4ds/pull/70#discussion_r263211769","pull_request_url":"https://api.github.com/repos/cienciadedatos/r4ds/pulls/70","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cienciadedatos/r4ds/pulls/comments/263211769"},"html":{"href":"https://github.com/cienciadedatos/r4ds/pull/70#discussion_r263211769"},"pull_request":{"href":"https://api.github.com/repos/cienciadedatos/r4ds/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/cienciadedatos/r4ds/pulls/70","id":254826168,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0ODI2MTY4","html_url":"https://github.com/cienciadedatos/r4ds/pull/70","diff_url":"https://github.com/cienciadedatos/r4ds/pull/70.diff","patch_url":"https://github.com/cienciadedatos/r4ds/pull/70.patch","issue_url":"https://api.github.com/repos/cienciadedatos/r4ds/issues/70","number":70,"state":"open","locked":false,"title":"1er borrador tidy data","user":{"login":"pachamaltese","id":10091065,"node_id":"MDQ6VXNlcjEwMDkxMDY1","avatar_url":"https://avatars3.githubusercontent.com/u/10091065?v=4","gravatar_id":"","url":"https://api.github.com/users/pachamaltese","html_url":"https://github.com/pachamaltese","followers_url":"https://api.github.com/users/pachamaltese/followers","following_url":"https://api.github.com/users/pachamaltese/following{/other_user}","gists_url":"https://api.github.com/users/pachamaltese/gists{/gist_id}","starred_url":"https://api.github.com/users/pachamaltese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pachamaltese/subscriptions","organizations_url":"https://api.github.com/users/pachamaltese/orgs","repos_url":"https://api.github.com/users/pachamaltese/repos","events_url":"https://api.github.com/users/pachamaltese/events{/privacy}","received_events_url":"https://api.github.com/users/pachamaltese/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-02-20T22:58:22Z","updated_at":"2019-03-07T01:59:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce692ce6bb983b6b04c0f7447c64319a9eb9ef66","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rivaquiroga","id":31421616,"node_id":"MDQ6VXNlcjMxNDIxNjE2","avatar_url":"https://avatars1.githubusercontent.com/u/31421616?v=4","gravatar_id":"","url":"https://api.github.com/users/rivaquiroga","html_url":"https://github.com/rivaquiroga","followers_url":"https://api.github.com/users/rivaquiroga/followers","following_url":"https://api.github.com/users/rivaquiroga/following{/other_user}","gists_url":"https://api.github.com/users/rivaquiroga/gists{/gist_id}","starred_url":"https://api.github.com/users/rivaquiroga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rivaquiroga/subscriptions","organizations_url":"https://api.github.com/users/rivaquiroga/orgs","repos_url":"https://api.github.com/users/rivaquiroga/repos","events_url":"https://api.github.com/users/rivaquiroga/events{/privacy}","received_events_url":"https://api.github.com/users/rivaquiroga/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cienciadedatos/r4ds/pulls/70/commits","review_comments_url":"https://api.github.com/repos/cienciadedatos/r4ds/pulls/70/comments","review_comment_url":"https://api.github.com/repos/cienciadedatos/r4ds/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cienciadedatos/r4ds/issues/70/comments","statuses_url":"https://api.github.com/repos/cienciadedatos/r4ds/statuses/a1a28c4e3ceb53a7153095c9c425b51250e866da","head":{"label":"pachamaltese:traduccion","ref":"traduccion","sha":"a1a28c4e3ceb53a7153095c9c425b51250e866da","user":{"login":"pachamaltese","id":10091065,"node_id":"MDQ6VXNlcjEwMDkxMDY1","avatar_url":"https://avatars3.githubusercontent.com/u/10091065?v=4","gravatar_id":"","url":"https://api.github.com/users/pachamaltese","html_url":"https://github.com/pachamaltese","followers_url":"https://api.github.com/users/pachamaltese/followers","following_url":"https://api.github.com/users/pachamaltese/following{/other_user}","gists_url":"https://api.github.com/users/pachamaltese/gists{/gist_id}","starred_url":"https://api.github.com/users/pachamaltese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pachamaltese/subscriptions","organizations_url":"https://api.github.com/users/pachamaltese/orgs","repos_url":"https://api.github.com/users/pachamaltese/repos","events_url":"https://api.github.com/users/pachamaltese/events{/privacy}","received_events_url":"https://api.github.com/users/pachamaltese/received_events","type":"User","site_admin":false},"repo":{"id":141176348,"node_id":"MDEwOlJlcG9zaXRvcnkxNDExNzYzNDg=","name":"r4ds","full_name":"pachamaltese/r4ds","private":false,"owner":{"login":"pachamaltese","id":10091065,"node_id":"MDQ6VXNlcjEwMDkxMDY1","avatar_url":"https://avatars3.githubusercontent.com/u/10091065?v=4","gravatar_id":"","url":"https://api.github.com/users/pachamaltese","html_url":"https://github.com/pachamaltese","followers_url":"https://api.github.com/users/pachamaltese/followers","following_url":"https://api.github.com/users/pachamaltese/following{/other_user}","gists_url":"https://api.github.com/users/pachamaltese/gists{/gist_id}","starred_url":"https://api.github.com/users/pachamaltese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pachamaltese/subscriptions","organizations_url":"https://api.github.com/users/pachamaltese/orgs","repos_url":"https://api.github.com/users/pachamaltese/repos","events_url":"https://api.github.com/users/pachamaltese/events{/privacy}","received_events_url":"https://api.github.com/users/pachamaltese/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pachamaltese/r4ds","description":"R for data science","fork":true,"url":"https://api.github.com/repos/pachamaltese/r4ds","forks_url":"https://api.github.com/repos/pachamaltese/r4ds/forks","keys_url":"https://api.github.com/repos/pachamaltese/r4ds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pachamaltese/r4ds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pachamaltese/r4ds/teams","hooks_url":"https://api.github.com/repos/pachamaltese/r4ds/hooks","issue_events_url":"https://api.github.com/repos/pachamaltese/r4ds/issues/events{/number}","events_url":"https://api.github.com/repos/pachamaltese/r4ds/events","assignees_url":"https://api.github.com/repos/pachamaltese/r4ds/assignees{/user}","branches_url":"https://api.github.com/repos/pachamaltese/r4ds/branches{/branch}","tags_url":"https://api.github.com/repos/pachamaltese/r4ds/tags","blobs_url":"https://api.github.com/repos/pachamaltese/r4ds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pachamaltese/r4ds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pachamaltese/r4ds/git/refs{/sha}","trees_url":"https://api.github.com/repos/pachamaltese/r4ds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pachamaltese/r4ds/statuses/{sha}","languages_url":"https://api.github.com/repos/pachamaltese/r4ds/languages","stargazers_url":"https://api.github.com/repos/pachamaltese/r4ds/stargazers","contributors_url":"https://api.github.com/repos/pachamaltese/r4ds/contributors","subscribers_url":"https://api.github.com/repos/pachamaltese/r4ds/subscribers","subscription_url":"https://api.github.com/repos/pachamaltese/r4ds/subscription","commits_url":"https://api.github.com/repos/pachamaltese/r4ds/commits{/sha}","git_commits_url":"https://api.github.com/repos/pachamaltese/r4ds/git/commits{/sha}","comments_url":"https://api.github.com/repos/pachamaltese/r4ds/comments{/number}","issue_comment_url":"https://api.github.com/repos/pachamaltese/r4ds/issues/comments{/number}","contents_url":"https://api.github.com/repos/pachamaltese/r4ds/contents/{+path}","compare_url":"https://api.github.com/repos/pachamaltese/r4ds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pachamaltese/r4ds/merges","archive_url":"https://api.github.com/repos/pachamaltese/r4ds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pachamaltese/r4ds/downloads","issues_url":"https://api.github.com/repos/pachamaltese/r4ds/issues{/number}","pulls_url":"https://api.github.com/repos/pachamaltese/r4ds/pulls{/number}","milestones_url":"https://api.github.com/repos/pachamaltese/r4ds/milestones{/number}","notifications_url":"https://api.github.com/repos/pachamaltese/r4ds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pachamaltese/r4ds/labels{/name}","releases_url":"https://api.github.com/repos/pachamaltese/r4ds/releases{/id}","deployments_url":"https://api.github.com/repos/pachamaltese/r4ds/deployments","created_at":"2018-07-16T18:17:28Z","updated_at":"2019-03-06T22:37:00Z","pushed_at":"2019-03-06T22:36:58Z","git_url":"git://github.com/pachamaltese/r4ds.git","ssh_url":"[email protected]:pachamaltese/r4ds.git","clone_url":"https://github.com/pachamaltese/r4ds.git","svn_url":"https://github.com/pachamaltese/r4ds","homepage":"https://es.r4ds.hadley.nz/","size":143792,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"traduccion"}},"base":{"label":"cienciadedatos:traduccion","ref":"traduccion","sha":"129795b6a58cb60dfb93de18a6be06a853f79c15","user":{"login":"cienciadedatos","id":40701963,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNzAxOTYz","avatar_url":"https://avatars2.githubusercontent.com/u/40701963?v=4","gravatar_id":"","url":"https://api.github.com/users/cienciadedatos","html_url":"https://github.com/cienciadedatos","followers_url":"https://api.github.com/users/cienciadedatos/followers","following_url":"https://api.github.com/users/cienciadedatos/following{/other_user}","gists_url":"https://api.github.com/users/cienciadedatos/gists{/gist_id}","starred_url":"https://api.github.com/users/cienciadedatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cienciadedatos/subscriptions","organizations_url":"https://api.github.com/users/cienciadedatos/orgs","repos_url":"https://api.github.com/users/cienciadedatos/repos","events_url":"https://api.github.com/users/cienciadedatos/events{/privacy}","received_events_url":"https://api.github.com/users/cienciadedatos/received_events","type":"Organization","site_admin":false},"repo":{"id":141157292,"node_id":"MDEwOlJlcG9zaXRvcnkxNDExNTcyOTI=","name":"r4ds","full_name":"cienciadedatos/r4ds","private":false,"owner":{"login":"cienciadedatos","id":40701963,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNzAxOTYz","avatar_url":"https://avatars2.githubusercontent.com/u/40701963?v=4","gravatar_id":"","url":"https://api.github.com/users/cienciadedatos","html_url":"https://github.com/cienciadedatos","followers_url":"https://api.github.com/users/cienciadedatos/followers","following_url":"https://api.github.com/users/cienciadedatos/following{/other_user}","gists_url":"https://api.github.com/users/cienciadedatos/gists{/gist_id}","starred_url":"https://api.github.com/users/cienciadedatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cienciadedatos/subscriptions","organizations_url":"https://api.github.com/users/cienciadedatos/orgs","repos_url":"https://api.github.com/users/cienciadedatos/repos","events_url":"https://api.github.com/users/cienciadedatos/events{/privacy}","received_events_url":"https://api.github.com/users/cienciadedatos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cienciadedatos/r4ds","description":"Traducción del libro \"R for Data Science\"","fork":true,"url":"https://api.github.com/repos/cienciadedatos/r4ds","forks_url":"https://api.github.com/repos/cienciadedatos/r4ds/forks","keys_url":"https://api.github.com/repos/cienciadedatos/r4ds/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cienciadedatos/r4ds/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cienciadedatos/r4ds/teams","hooks_url":"https://api.github.com/repos/cienciadedatos/r4ds/hooks","issue_events_url":"https://api.github.com/repos/cienciadedatos/r4ds/issues/events{/number}","events_url":"https://api.github.com/repos/cienciadedatos/r4ds/events","assignees_url":"https://api.github.com/repos/cienciadedatos/r4ds/assignees{/user}","branches_url":"https://api.github.com/repos/cienciadedatos/r4ds/branches{/branch}","tags_url":"https://api.github.com/repos/cienciadedatos/r4ds/tags","blobs_url":"https://api.github.com/repos/cienciadedatos/r4ds/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cienciadedatos/r4ds/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cienciadedatos/r4ds/git/refs{/sha}","trees_url":"https://api.github.com/repos/cienciadedatos/r4ds/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cienciadedatos/r4ds/statuses/{sha}","languages_url":"https://api.github.com/repos/cienciadedatos/r4ds/languages","stargazers_url":"https://api.github.com/repos/cienciadedatos/r4ds/stargazers","contributors_url":"https://api.github.com/repos/cienciadedatos/r4ds/contributors","subscribers_url":"https://api.github.com/repos/cienciadedatos/r4ds/subscribers","subscription_url":"https://api.github.com/repos/cienciadedatos/r4ds/subscription","commits_url":"https://api.github.com/repos/cienciadedatos/r4ds/commits{/sha}","git_commits_url":"https://api.github.com/repos/cienciadedatos/r4ds/git/commits{/sha}","comments_url":"https://api.github.com/repos/cienciadedatos/r4ds/comments{/number}","issue_comment_url":"https://api.github.com/repos/cienciadedatos/r4ds/issues/comments{/number}","contents_url":"https://api.github.com/repos/cienciadedatos/r4ds/contents/{+path}","compare_url":"https://api.github.com/repos/cienciadedatos/r4ds/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cienciadedatos/r4ds/merges","archive_url":"https://api.github.com/repos/cienciadedatos/r4ds/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cienciadedatos/r4ds/downloads","issues_url":"https://api.github.com/repos/cienciadedatos/r4ds/issues{/number}","pulls_url":"https://api.github.com/repos/cienciadedatos/r4ds/pulls{/number}","milestones_url":"https://api.github.com/repos/cienciadedatos/r4ds/milestones{/number}","notifications_url":"https://api.github.com/repos/cienciadedatos/r4ds/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cienciadedatos/r4ds/labels{/name}","releases_url":"https://api.github.com/repos/cienciadedatos/r4ds/releases{/id}","deployments_url":"https://api.github.com/repos/cienciadedatos/r4ds/deployments","created_at":"2018-07-16T15:24:58Z","updated_at":"2019-02-22T16:03:35Z","pushed_at":"2019-03-06T22:36:59Z","git_url":"git://github.com/cienciadedatos/r4ds.git","ssh_url":"[email protected]:cienciadedatos/r4ds.git","clone_url":"https://github.com/cienciadedatos/r4ds.git","svn_url":"https://github.com/cienciadedatos/r4ds","homepage":"http://es.r4ds.hadley.nz/","size":152081,"stargazers_count":10,"watchers_count":10,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":33,"open_issues":16,"watchers":10,"default_branch":"traduccion"}},"_links":{"self":{"href":"https://api.github.com/repos/cienciadedatos/r4ds/pulls/70"},"html":{"href":"https://github.com/cienciadedatos/r4ds/pull/70"},"issue":{"href":"https://api.github.com/repos/cienciadedatos/r4ds/issues/70"},"comments":{"href":"https://api.github.com/repos/cienciadedatos/r4ds/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/cienciadedatos/r4ds/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/cienciadedatos/r4ds/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cienciadedatos/r4ds/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/cienciadedatos/r4ds/statuses/a1a28c4e3ceb53a7153095c9c425b51250e866da"}},"author_association":"NONE"}}	{ "id": 141157292, "name": "cienciadedatos/r4ds", "url": "https://api.github.com/repos/cienciadedatos/r4ds" }	{ "id": 33395215, "login": "mpaulacaldas", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/33395215?", "url": "https://api.github.com/users/mpaulacaldas" }	{ "id": 40701963, "login": "cienciadedatos", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/40701963?", "url": "https://api.github.com/orgs/cienciadedatos" }	2019-03-07T01:59:45	9195338198	{"actor":{"display_login":"mpaulacaldas"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/knowsys/vlog4j/pulls/comments/334526990","pull_request_review_id":301364762,"id":334526990,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDUyNjk5MA==","diff_hunk":"@@ -60,5 +61,54 @@\n \t\t\t\t</plugins>\r\n \t\t\t</build>\r\n \t\t</profile>\r\n+\t\t<profile>\r\n+\t\t\t<id>client</id>\r\n+\t\t\t<dependencies>\r\n+\t\t\t\t<dependency>\r\n+\t\t\t\t\t<groupId>${project.groupId}</groupId>\r\n+\t\t\t\t\t<artifactId>vlog4j-client</artifactId>\r","path":"vlog4j-core/pom.xml","position":16,"original_position":16,"commit_id":"4c7fd44e0d9c36e664e786ef535b01ecaf8299f2","original_commit_id":"4c7fd44e0d9c36e664e786ef535b01ecaf8299f2","user":{"login":"irina-dragoste","id":26414082,"node_id":"MDQ6VXNlcjI2NDE0MDgy","avatar_url":"https://avatars2.githubusercontent.com/u/26414082?v=4","gravatar_id":"","url":"https://api.github.com/users/irina-dragoste","html_url":"https://github.com/irina-dragoste","followers_url":"https://api.github.com/users/irina-dragoste/followers","following_url":"https://api.github.com/users/irina-dragoste/following{/other_user}","gists_url":"https://api.github.com/users/irina-dragoste/gists{/gist_id}","starred_url":"https://api.github.com/users/irina-dragoste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irina-dragoste/subscriptions","organizations_url":"https://api.github.com/users/irina-dragoste/orgs","repos_url":"https://api.github.com/users/irina-dragoste/repos","events_url":"https://api.github.com/users/irina-dragoste/events{/privacy}","received_events_url":"https://api.github.com/users/irina-dragoste/received_events","type":"User","site_admin":false},"body":"This does not even work with mvn install -Pclient. \r\nWhy is this profile not declared in vlog4j-client, (or in parent), but in vlog4j-core?","created_at":"2019-10-14T15:03:00Z","updated_at":"2019-10-14T15:03:07Z","html_url":"https://github.com/knowsys/vlog4j/pull/88#discussion_r334526990","pull_request_url":"https://api.github.com/repos/knowsys/vlog4j/pulls/88","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/knowsys/vlog4j/pulls/comments/334526990"},"html":{"href":"https://github.com/knowsys/vlog4j/pull/88#discussion_r334526990"},"pull_request":{"href":"https://api.github.com/repos/knowsys/vlog4j/pulls/88"}},"in_reply_to_id":333710182},"pull_request":{"url":"https://api.github.com/repos/knowsys/vlog4j/pulls/88","id":316817638,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2ODE3NjM4","html_url":"https://github.com/knowsys/vlog4j/pull/88","diff_url":"https://github.com/knowsys/vlog4j/pull/88.diff","patch_url":"https://github.com/knowsys/vlog4j/pull/88.patch","issue_url":"https://api.github.com/repos/knowsys/vlog4j/issues/88","number":88,"state":"open","locked":false,"title":"Client","user":{"login":"larryjgonzalez","id":7830952,"node_id":"MDQ6VXNlcjc4MzA5NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7830952?v=4","gravatar_id":"","url":"https://api.github.com/users/larryjgonzalez","html_url":"https://github.com/larryjgonzalez","followers_url":"https://api.github.com/users/larryjgonzalez/followers","following_url":"https://api.github.com/users/larryjgonzalez/following{/other_user}","gists_url":"https://api.github.com/users/larryjgonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/larryjgonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larryjgonzalez/subscriptions","organizations_url":"https://api.github.com/users/larryjgonzalez/orgs","repos_url":"https://api.github.com/users/larryjgonzalez/repos","events_url":"https://api.github.com/users/larryjgonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/larryjgonzalez/received_events","type":"User","site_admin":false},"body":"New module to create a stand-alone executable jar file for VLog4j","created_at":"2019-09-12T09:38:10Z","updated_at":"2019-10-14T15:03:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b3e2aa05dfa8cb97178afb1e4a84a2ded882843","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/knowsys/vlog4j/pulls/88/commits","review_comments_url":"https://api.github.com/repos/knowsys/vlog4j/pulls/88/comments","review_comment_url":"https://api.github.com/repos/knowsys/vlog4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knowsys/vlog4j/issues/88/comments","statuses_url":"https://api.github.com/repos/knowsys/vlog4j/statuses/4c7fd44e0d9c36e664e786ef535b01ecaf8299f2","head":{"label":"knowsys:client","ref":"client","sha":"4c7fd44e0d9c36e664e786ef535b01ecaf8299f2","user":{"login":"knowsys","id":40864390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0Mzkw","avatar_url":"https://avatars2.githubusercontent.com/u/40864390?v=4","gravatar_id":"","url":"https://api.github.com/users/knowsys","html_url":"https://github.com/knowsys","followers_url":"https://api.github.com/users/knowsys/followers","following_url":"https://api.github.com/users/knowsys/following{/other_user}","gists_url":"https://api.github.com/users/knowsys/gists{/gist_id}","starred_url":"https://api.github.com/users/knowsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knowsys/subscriptions","organizations_url":"https://api.github.com/users/knowsys/orgs","repos_url":"https://api.github.com/users/knowsys/repos","events_url":"https://api.github.com/users/knowsys/events{/privacy}","received_events_url":"https://api.github.com/users/knowsys/received_events","type":"Organization","site_admin":false},"repo":{"id":123681471,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM2ODE0NzE=","name":"vlog4j","full_name":"knowsys/vlog4j","private":false,"owner":{"login":"knowsys","id":40864390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0Mzkw","avatar_url":"https://avatars2.githubusercontent.com/u/40864390?v=4","gravatar_id":"","url":"https://api.github.com/users/knowsys","html_url":"https://github.com/knowsys","followers_url":"https://api.github.com/users/knowsys/followers","following_url":"https://api.github.com/users/knowsys/following{/other_user}","gists_url":"https://api.github.com/users/knowsys/gists{/gist_id}","starred_url":"https://api.github.com/users/knowsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knowsys/subscriptions","organizations_url":"https://api.github.com/users/knowsys/orgs","repos_url":"https://api.github.com/users/knowsys/repos","events_url":"https://api.github.com/users/knowsys/events{/privacy}","received_events_url":"https://api.github.com/users/knowsys/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knowsys/vlog4j","description":"Java library based on the VLog rule engine","fork":false,"url":"https://api.github.com/repos/knowsys/vlog4j","forks_url":"https://api.github.com/repos/knowsys/vlog4j/forks","keys_url":"https://api.github.com/repos/knowsys/vlog4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knowsys/vlog4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knowsys/vlog4j/teams","hooks_url":"https://api.github.com/repos/knowsys/vlog4j/hooks","issue_events_url":"https://api.github.com/repos/knowsys/vlog4j/issues/events{/number}","events_url":"https://api.github.com/repos/knowsys/vlog4j/events","assignees_url":"https://api.github.com/repos/knowsys/vlog4j/assignees{/user}","branches_url":"https://api.github.com/repos/knowsys/vlog4j/branches{/branch}","tags_url":"https://api.github.com/repos/knowsys/vlog4j/tags","blobs_url":"https://api.github.com/repos/knowsys/vlog4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knowsys/vlog4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knowsys/vlog4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/knowsys/vlog4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knowsys/vlog4j/statuses/{sha}","languages_url":"https://api.github.com/repos/knowsys/vlog4j/languages","stargazers_url":"https://api.github.com/repos/knowsys/vlog4j/stargazers","contributors_url":"https://api.github.com/repos/knowsys/vlog4j/contributors","subscribers_url":"https://api.github.com/repos/knowsys/vlog4j/subscribers","subscription_url":"https://api.github.com/repos/knowsys/vlog4j/subscription","commits_url":"https://api.github.com/repos/knowsys/vlog4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/knowsys/vlog4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/knowsys/vlog4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/knowsys/vlog4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/knowsys/vlog4j/contents/{+path}","compare_url":"https://api.github.com/repos/knowsys/vlog4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knowsys/vlog4j/merges","archive_url":"https://api.github.com/repos/knowsys/vlog4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knowsys/vlog4j/downloads","issues_url":"https://api.github.com/repos/knowsys/vlog4j/issues{/number}","pulls_url":"https://api.github.com/repos/knowsys/vlog4j/pulls{/number}","milestones_url":"https://api.github.com/repos/knowsys/vlog4j/milestones{/number}","notifications_url":"https://api.github.com/repos/knowsys/vlog4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knowsys/vlog4j/labels{/name}","releases_url":"https://api.github.com/repos/knowsys/vlog4j/releases{/id}","deployments_url":"https://api.github.com/repos/knowsys/vlog4j/deployments","created_at":"2018-03-03T10:21:45Z","updated_at":"2019-09-26T13:19:55Z","pushed_at":"2019-10-14T13:26:39Z","git_url":"git://github.com/knowsys/vlog4j.git","ssh_url":"[email protected]:knowsys/vlog4j.git","clone_url":"https://github.com/knowsys/vlog4j.git","svn_url":"https://github.com/knowsys/vlog4j","homepage":null,"size":39847,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":39,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":39,"watchers":4,"default_branch":"master"}},"base":{"label":"knowsys:master","ref":"master","sha":"37846b01384d07c0f2ce9b03a67867edb2bbcd80","user":{"login":"knowsys","id":40864390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0Mzkw","avatar_url":"https://avatars2.githubusercontent.com/u/40864390?v=4","gravatar_id":"","url":"https://api.github.com/users/knowsys","html_url":"https://github.com/knowsys","followers_url":"https://api.github.com/users/knowsys/followers","following_url":"https://api.github.com/users/knowsys/following{/other_user}","gists_url":"https://api.github.com/users/knowsys/gists{/gist_id}","starred_url":"https://api.github.com/users/knowsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knowsys/subscriptions","organizations_url":"https://api.github.com/users/knowsys/orgs","repos_url":"https://api.github.com/users/knowsys/repos","events_url":"https://api.github.com/users/knowsys/events{/privacy}","received_events_url":"https://api.github.com/users/knowsys/received_events","type":"Organization","site_admin":false},"repo":{"id":123681471,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM2ODE0NzE=","name":"vlog4j","full_name":"knowsys/vlog4j","private":false,"owner":{"login":"knowsys","id":40864390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0Mzkw","avatar_url":"https://avatars2.githubusercontent.com/u/40864390?v=4","gravatar_id":"","url":"https://api.github.com/users/knowsys","html_url":"https://github.com/knowsys","followers_url":"https://api.github.com/users/knowsys/followers","following_url":"https://api.github.com/users/knowsys/following{/other_user}","gists_url":"https://api.github.com/users/knowsys/gists{/gist_id}","starred_url":"https://api.github.com/users/knowsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knowsys/subscriptions","organizations_url":"https://api.github.com/users/knowsys/orgs","repos_url":"https://api.github.com/users/knowsys/repos","events_url":"https://api.github.com/users/knowsys/events{/privacy}","received_events_url":"https://api.github.com/users/knowsys/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knowsys/vlog4j","description":"Java library based on the VLog rule engine","fork":false,"url":"https://api.github.com/repos/knowsys/vlog4j","forks_url":"https://api.github.com/repos/knowsys/vlog4j/forks","keys_url":"https://api.github.com/repos/knowsys/vlog4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knowsys/vlog4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knowsys/vlog4j/teams","hooks_url":"https://api.github.com/repos/knowsys/vlog4j/hooks","issue_events_url":"https://api.github.com/repos/knowsys/vlog4j/issues/events{/number}","events_url":"https://api.github.com/repos/knowsys/vlog4j/events","assignees_url":"https://api.github.com/repos/knowsys/vlog4j/assignees{/user}","branches_url":"https://api.github.com/repos/knowsys/vlog4j/branches{/branch}","tags_url":"https://api.github.com/repos/knowsys/vlog4j/tags","blobs_url":"https://api.github.com/repos/knowsys/vlog4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knowsys/vlog4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knowsys/vlog4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/knowsys/vlog4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knowsys/vlog4j/statuses/{sha}","languages_url":"https://api.github.com/repos/knowsys/vlog4j/languages","stargazers_url":"https://api.github.com/repos/knowsys/vlog4j/stargazers","contributors_url":"https://api.github.com/repos/knowsys/vlog4j/contributors","subscribers_url":"https://api.github.com/repos/knowsys/vlog4j/subscribers","subscription_url":"https://api.github.com/repos/knowsys/vlog4j/subscription","commits_url":"https://api.github.com/repos/knowsys/vlog4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/knowsys/vlog4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/knowsys/vlog4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/knowsys/vlog4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/knowsys/vlog4j/contents/{+path}","compare_url":"https://api.github.com/repos/knowsys/vlog4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knowsys/vlog4j/merges","archive_url":"https://api.github.com/repos/knowsys/vlog4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knowsys/vlog4j/downloads","issues_url":"https://api.github.com/repos/knowsys/vlog4j/issues{/number}","pulls_url":"https://api.github.com/repos/knowsys/vlog4j/pulls{/number}","milestones_url":"https://api.github.com/repos/knowsys/vlog4j/milestones{/number}","notifications_url":"https://api.github.com/repos/knowsys/vlog4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knowsys/vlog4j/labels{/name}","releases_url":"https://api.github.com/repos/knowsys/vlog4j/releases{/id}","deployments_url":"https://api.github.com/repos/knowsys/vlog4j/deployments","created_at":"2018-03-03T10:21:45Z","updated_at":"2019-09-26T13:19:55Z","pushed_at":"2019-10-14T13:26:39Z","git_url":"git://github.com/knowsys/vlog4j.git","ssh_url":"[email protected]:knowsys/vlog4j.git","clone_url":"https://github.com/knowsys/vlog4j.git","svn_url":"https://github.com/knowsys/vlog4j","homepage":null,"size":39847,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":39,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":39,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knowsys/vlog4j/pulls/88"},"html":{"href":"https://github.com/knowsys/vlog4j/pull/88"},"issue":{"href":"https://api.github.com/repos/knowsys/vlog4j/issues/88"},"comments":{"href":"https://api.github.com/repos/knowsys/vlog4j/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/knowsys/vlog4j/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/knowsys/vlog4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knowsys/vlog4j/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/knowsys/vlog4j/statuses/4c7fd44e0d9c36e664e786ef535b01ecaf8299f2"}},"author_association":"CONTRIBUTOR"}}	{ "id": 123681471, "name": "knowsys/vlog4j", "url": "https://api.github.com/repos/knowsys/vlog4j" }	{ "id": 26414082, "login": "irina-dragoste", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/26414082?", "url": "https://api.github.com/users/irina-dragoste" }	{ "id": 40864390, "login": "knowsys", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/40864390?", "url": "https://api.github.com/orgs/knowsys" }	2019-10-14T15:03:00	10625734158	{"actor":{"display_login":"irina-dragoste"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/rubizza-camp/staff-planner/pulls/comments/336009119","pull_request_review_id":303262105,"id":336009119,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjAwOTExOQ==","diff_hunk":"@@ -2,9 +2,35 @@\n \n module Events\n class Update\n- def call(event, params)\n- result = Events::ValidatePeriod.new(event, params).call\n- if result.success? && result.value.update(update_params(params))\n+ attr_reader :params, :company, :current_account, :event\n+\n+ def initialize(event, current_account, params, company)\n+ @params = params\n+ @company = company\n+ @current_account = current_account\n+ @event = event\n+ @event.attributes = update_params\n+ end\n+\n+ # rubocop: disable Metrics/AbcSize\n+ def call(role)\n+ event.valid?\n+ rule = Rule.find(update_params[:rule_id])\n+ if rule.auto_confirm\n+ event.accept\n+ elsif role != 'owner' && !event.pending?","path":"app/operations/events/update.rb","position":23,"original_position":23,"commit_id":"38760fce57c9cb8003ad2380c9800d95c68a5ec2","original_commit_id":"38760fce57c9cb8003ad2380c9800d95c68a5ec2","user":{"login":"vsevolod","id":110316,"node_id":"MDQ6VXNlcjExMDMxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/110316?v=4","gravatar_id":"","url":"https://api.github.com/users/vsevolod","html_url":"https://github.com/vsevolod","followers_url":"https://api.github.com/users/vsevolod/followers","following_url":"https://api.github.com/users/vsevolod/following{/other_user}","gists_url":"https://api.github.com/users/vsevolod/gists{/gist_id}","starred_url":"https://api.github.com/users/vsevolod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsevolod/subscriptions","organizations_url":"https://api.github.com/users/vsevolod/orgs","repos_url":"https://api.github.com/users/vsevolod/repos","events_url":"https://api.github.com/users/vsevolod/events{/privacy}","received_events_url":"https://api.github.com/users/vsevolod/received_events","type":"User","site_admin":false},"body":"Вместо cancan сравнивай account у event и `current_account`","created_at":"2019-10-17T13:38:33Z","updated_at":"2019-10-17T13:38:33Z","html_url":"https://github.com/rubizza-camp/staff-planner/pull/72#discussion_r336009119","pull_request_url":"https://api.github.com/repos/rubizza-camp/staff-planner/pulls/72","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rubizza-camp/staff-planner/pulls/comments/336009119"},"html":{"href":"https://github.com/rubizza-camp/staff-planner/pull/72#discussion_r336009119"},"pull_request":{"href":"https://api.github.com/repos/rubizza-camp/staff-planner/pulls/72"}},"in_reply_to_id":336005161},"pull_request":{"url":"https://api.github.com/repos/rubizza-camp/staff-planner/pulls/72","id":329257091,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5MjU3MDkx","html_url":"https://github.com/rubizza-camp/staff-planner/pull/72","diff_url":"https://github.com/rubizza-camp/staff-planner/pull/72.diff","patch_url":"https://github.com/rubizza-camp/staff-planner/pull/72.patch","issue_url":"https://api.github.com/repos/rubizza-camp/staff-planner/issues/72","number":72,"state":"open","locked":false,"title":"edit event","user":{"login":"EvgeniyR2","id":46892346,"node_id":"MDQ6VXNlcjQ2ODkyMzQ2","avatar_url":"https://avatars1.githubusercontent.com/u/46892346?v=4","gravatar_id":"","url":"https://api.github.com/users/EvgeniyR2","html_url":"https://github.com/EvgeniyR2","followers_url":"https://api.github.com/users/EvgeniyR2/followers","following_url":"https://api.github.com/users/EvgeniyR2/following{/other_user}","gists_url":"https://api.github.com/users/EvgeniyR2/gists{/gist_id}","starred_url":"https://api.github.com/users/EvgeniyR2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EvgeniyR2/subscriptions","organizations_url":"https://api.github.com/users/EvgeniyR2/orgs","repos_url":"https://api.github.com/users/EvgeniyR2/repos","events_url":"https://api.github.com/users/EvgeniyR2/events{/privacy}","received_events_url":"https://api.github.com/users/EvgeniyR2/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-17T13:19:11Z","updated_at":"2019-10-17T13:38:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e23309003efc2489de2e478be72f9432a7d72b67","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubizza-camp/staff-planner/pulls/72/commits","review_comments_url":"https://api.github.com/repos/rubizza-camp/staff-planner/pulls/72/comments","review_comment_url":"https://api.github.com/repos/rubizza-camp/staff-planner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubizza-camp/staff-planner/issues/72/comments","statuses_url":"https://api.github.com/repos/rubizza-camp/staff-planner/statuses/38760fce57c9cb8003ad2380c9800d95c68a5ec2","head":{"label":"rubizza-camp:feature/edit_events","ref":"feature/edit_events","sha":"38760fce57c9cb8003ad2380c9800d95c68a5ec2","user":{"login":"rubizza-camp","id":40864986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/40864986?v=4","gravatar_id":"","url":"https://api.github.com/users/rubizza-camp","html_url":"https://github.com/rubizza-camp","followers_url":"https://api.github.com/users/rubizza-camp/followers","following_url":"https://api.github.com/users/rubizza-camp/following{/other_user}","gists_url":"https://api.github.com/users/rubizza-camp/gists{/gist_id}","starred_url":"https://api.github.com/users/rubizza-camp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubizza-camp/subscriptions","organizations_url":"https://api.github.com/users/rubizza-camp/orgs","repos_url":"https://api.github.com/users/rubizza-camp/repos","events_url":"https://api.github.com/users/rubizza-camp/events{/privacy}","received_events_url":"https://api.github.com/users/rubizza-camp/received_events","type":"Organization","site_admin":false},"repo":{"id":200422624,"node_id":"MDEwOlJlcG9zaXRvcnkyMDA0MjI2MjQ=","name":"staff-planner","full_name":"rubizza-camp/staff-planner","private":false,"owner":{"login":"rubizza-camp","id":40864986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/40864986?v=4","gravatar_id":"","url":"https://api.github.com/users/rubizza-camp","html_url":"https://github.com/rubizza-camp","followers_url":"https://api.github.com/users/rubizza-camp/followers","following_url":"https://api.github.com/users/rubizza-camp/following{/other_user}","gists_url":"https://api.github.com/users/rubizza-camp/gists{/gist_id}","starred_url":"https://api.github.com/users/rubizza-camp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubizza-camp/subscriptions","organizations_url":"https://api.github.com/users/rubizza-camp/orgs","repos_url":"https://api.github.com/users/rubizza-camp/repos","events_url":"https://api.github.com/users/rubizza-camp/events{/privacy}","received_events_url":"https://api.github.com/users/rubizza-camp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rubizza-camp/staff-planner","description":null,"fork":false,"url":"https://api.github.com/repos/rubizza-camp/staff-planner","forks_url":"https://api.github.com/repos/rubizza-camp/staff-planner/forks","keys_url":"https://api.github.com/repos/rubizza-camp/staff-planner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubizza-camp/staff-planner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubizza-camp/staff-planner/teams","hooks_url":"https://api.github.com/repos/rubizza-camp/staff-planner/hooks","issue_events_url":"https://api.github.com/repos/rubizza-camp/staff-planner/issues/events{/number}","events_url":"https://api.github.com/repos/rubizza-camp/staff-planner/events","assignees_url":"https://api.github.com/repos/rubizza-camp/staff-planner/assignees{/user}","branches_url":"https://api.github.com/repos/rubizza-camp/staff-planner/branches{/branch}","tags_url":"https://api.github.com/repos/rubizza-camp/staff-planner/tags","blobs_url":"https://api.github.com/repos/rubizza-camp/staff-planner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubizza-camp/staff-planner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubizza-camp/staff-planner/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubizza-camp/staff-planner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubizza-camp/staff-planner/statuses/{sha}","languages_url":"https://api.github.com/repos/rubizza-camp/staff-planner/languages","stargazers_url":"https://api.github.com/repos/rubizza-camp/staff-planner/stargazers","contributors_url":"https://api.github.com/repos/rubizza-camp/staff-planner/contributors","subscribers_url":"https://api.github.com/repos/rubizza-camp/staff-planner/subscribers","subscription_url":"https://api.github.com/repos/rubizza-camp/staff-planner/subscription","commits_url":"https://api.github.com/repos/rubizza-camp/staff-planner/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubizza-camp/staff-planner/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubizza-camp/staff-planner/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubizza-camp/staff-planner/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubizza-camp/staff-planner/contents/{+path}","compare_url":"https://api.github.com/repos/rubizza-camp/staff-planner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubizza-camp/staff-planner/merges","archive_url":"https://api.github.com/repos/rubizza-camp/staff-planner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubizza-camp/staff-planner/downloads","issues_url":"https://api.github.com/repos/rubizza-camp/staff-planner/issues{/number}","pulls_url":"https://api.github.com/repos/rubizza-camp/staff-planner/pulls{/number}","milestones_url":"https://api.github.com/repos/rubizza-camp/staff-planner/milestones{/number}","notifications_url":"https://api.github.com/repos/rubizza-camp/staff-planner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubizza-camp/staff-planner/labels{/name}","releases_url":"https://api.github.com/repos/rubizza-camp/staff-planner/releases{/id}","deployments_url":"https://api.github.com/repos/rubizza-camp/staff-planner/deployments","created_at":"2019-08-03T21:30:36Z","updated_at":"2019-10-15T09:18:13Z","pushed_at":"2019-10-17T13:19:12Z","git_url":"git://github.com/rubizza-camp/staff-planner.git","ssh_url":"[email protected]:rubizza-camp/staff-planner.git","clone_url":"https://github.com/rubizza-camp/staff-planner.git","svn_url":"https://github.com/rubizza-camp/staff-planner","homepage":null,"size":789,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"rubizza-camp:master","ref":"master","sha":"9562c697c0fba6e96da3bd15dd28f83c9dba8917","user":{"login":"rubizza-camp","id":40864986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/40864986?v=4","gravatar_id":"","url":"https://api.github.com/users/rubizza-camp","html_url":"https://github.com/rubizza-camp","followers_url":"https://api.github.com/users/rubizza-camp/followers","following_url":"https://api.github.com/users/rubizza-camp/following{/other_user}","gists_url":"https://api.github.com/users/rubizza-camp/gists{/gist_id}","starred_url":"https://api.github.com/users/rubizza-camp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubizza-camp/subscriptions","organizations_url":"https://api.github.com/users/rubizza-camp/orgs","repos_url":"https://api.github.com/users/rubizza-camp/repos","events_url":"https://api.github.com/users/rubizza-camp/events{/privacy}","received_events_url":"https://api.github.com/users/rubizza-camp/received_events","type":"Organization","site_admin":false},"repo":{"id":200422624,"node_id":"MDEwOlJlcG9zaXRvcnkyMDA0MjI2MjQ=","name":"staff-planner","full_name":"rubizza-camp/staff-planner","private":false,"owner":{"login":"rubizza-camp","id":40864986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/40864986?v=4","gravatar_id":"","url":"https://api.github.com/users/rubizza-camp","html_url":"https://github.com/rubizza-camp","followers_url":"https://api.github.com/users/rubizza-camp/followers","following_url":"https://api.github.com/users/rubizza-camp/following{/other_user}","gists_url":"https://api.github.com/users/rubizza-camp/gists{/gist_id}","starred_url":"https://api.github.com/users/rubizza-camp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubizza-camp/subscriptions","organizations_url":"https://api.github.com/users/rubizza-camp/orgs","repos_url":"https://api.github.com/users/rubizza-camp/repos","events_url":"https://api.github.com/users/rubizza-camp/events{/privacy}","received_events_url":"https://api.github.com/users/rubizza-camp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rubizza-camp/staff-planner","description":null,"fork":false,"url":"https://api.github.com/repos/rubizza-camp/staff-planner","forks_url":"https://api.github.com/repos/rubizza-camp/staff-planner/forks","keys_url":"https://api.github.com/repos/rubizza-camp/staff-planner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubizza-camp/staff-planner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubizza-camp/staff-planner/teams","hooks_url":"https://api.github.com/repos/rubizza-camp/staff-planner/hooks","issue_events_url":"https://api.github.com/repos/rubizza-camp/staff-planner/issues/events{/number}","events_url":"https://api.github.com/repos/rubizza-camp/staff-planner/events","assignees_url":"https://api.github.com/repos/rubizza-camp/staff-planner/assignees{/user}","branches_url":"https://api.github.com/repos/rubizza-camp/staff-planner/branches{/branch}","tags_url":"https://api.github.com/repos/rubizza-camp/staff-planner/tags","blobs_url":"https://api.github.com/repos/rubizza-camp/staff-planner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubizza-camp/staff-planner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubizza-camp/staff-planner/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubizza-camp/staff-planner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubizza-camp/staff-planner/statuses/{sha}","languages_url":"https://api.github.com/repos/rubizza-camp/staff-planner/languages","stargazers_url":"https://api.github.com/repos/rubizza-camp/staff-planner/stargazers","contributors_url":"https://api.github.com/repos/rubizza-camp/staff-planner/contributors","subscribers_url":"https://api.github.com/repos/rubizza-camp/staff-planner/subscribers","subscription_url":"https://api.github.com/repos/rubizza-camp/staff-planner/subscription","commits_url":"https://api.github.com/repos/rubizza-camp/staff-planner/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubizza-camp/staff-planner/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubizza-camp/staff-planner/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubizza-camp/staff-planner/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubizza-camp/staff-planner/contents/{+path}","compare_url":"https://api.github.com/repos/rubizza-camp/staff-planner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubizza-camp/staff-planner/merges","archive_url":"https://api.github.com/repos/rubizza-camp/staff-planner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubizza-camp/staff-planner/downloads","issues_url":"https://api.github.com/repos/rubizza-camp/staff-planner/issues{/number}","pulls_url":"https://api.github.com/repos/rubizza-camp/staff-planner/pulls{/number}","milestones_url":"https://api.github.com/repos/rubizza-camp/staff-planner/milestones{/number}","notifications_url":"https://api.github.com/repos/rubizza-camp/staff-planner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubizza-camp/staff-planner/labels{/name}","releases_url":"https://api.github.com/repos/rubizza-camp/staff-planner/releases{/id}","deployments_url":"https://api.github.com/repos/rubizza-camp/staff-planner/deployments","created_at":"2019-08-03T21:30:36Z","updated_at":"2019-10-15T09:18:13Z","pushed_at":"2019-10-17T13:19:12Z","git_url":"git://github.com/rubizza-camp/staff-planner.git","ssh_url":"[email protected]:rubizza-camp/staff-planner.git","clone_url":"https://github.com/rubizza-camp/staff-planner.git","svn_url":"https://github.com/rubizza-camp/staff-planner","homepage":null,"size":789,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubizza-camp/staff-planner/pulls/72"},"html":{"href":"https://github.com/rubizza-camp/staff-planner/pull/72"},"issue":{"href":"https://api.github.com/repos/rubizza-camp/staff-planner/issues/72"},"comments":{"href":"https://api.github.com/repos/rubizza-camp/staff-planner/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/rubizza-camp/staff-planner/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/rubizza-camp/staff-planner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubizza-camp/staff-planner/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/rubizza-camp/staff-planner/statuses/38760fce57c9cb8003ad2380c9800d95c68a5ec2"}},"author_association":"CONTRIBUTOR"}}	{ "id": 200422624, "name": "rubizza-camp/staff-planner", "url": "https://api.github.com/repos/rubizza-camp/staff-planner" }	{ "id": 110316, "login": "vsevolod", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/110316?", "url": "https://api.github.com/users/vsevolod" }	{ "id": 40864986, "login": "rubizza-camp", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/40864986?", "url": "https://api.github.com/orgs/rubizza-camp" }	2019-10-17T13:38:33	10652974790	{"actor":{"display_login":"vsevolod"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/rubizza-camp/summer-2019/pulls/comments/301151630","pull_request_review_id":258975183,"id":301151630,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMTE1MTYzMA==","diff_hunk":"@@ -0,0 +1,535 @@\n+# -- ruby --\n+#rubocop:disable all\n+\n+begin\n+ require 'win32console'\n+rescue LoadError\n+end\n+\n+# --------------------------------------------------------------------\n+# Support code for the Ruby Koans.\n+# --------------------------------------------------------------------\n+\n+class FillMeInError < StandardError\n+end\n+\n+def ruby_version?(version)\n+ RUBY_VERSION =~ /^#{version}/ \|\|\n+ (version == 'jruby' && defined?(JRUBY_VERSION)) \|\|\n+ (version == 'mri' && ! defined?(JRUBY_VERSION))\n+end\n+\n+def in_ruby_version(versions)\n+ yield if versions.any? { \|v\| ruby_version?(v) }\n+end\n+\n+in_ruby_version(\"1.8\") do\n+ class KeyError < StandardError\n+ end\n+end\n+\n+# Standard, generic replacement value.\n+# If value19 is given, it is used in place of value for Ruby 1.9.\n+def __(value=\"FILL ME IN\", value19=:mu)\n+ if RUBY_VERSION < \"1.9\"\n+ value\n+ else\n+ (value19 == :mu) ? value : value19\n+ end\n+end\n+\n+# Numeric replacement value.\n+def _n_(value=999999, value19=:mu)\n+ if RUBY_VERSION < \"1.9\"\n+ value\n+ else\n+ (value19 == :mu) ? value : value19\n+ end\n+end\n+\n+# Error object replacement value.\n+def ___(value=FillMeInError, value19=:mu)\n+ if RUBY_VERSION < \"1.9\"\n+ value\n+ else\n+ (value19 == :mu) ? value : value19\n+ end\n+end\n+\n+# Method name replacement.\n+class Object\n+ def ____(method=nil)\n+ if method\n+ self.send(method)\n+ end\n+ end\n+\n+ in_ruby_version(\"1.9\", \"2\") do\n+ public :method_missing\n+ end\n+end\n+\n+class String\n+ def side_padding(width)\n+ extra = width - self.size\n+ if width < 0\n+ self\n+ else\n+ left_padding = extra / 2\n+ right_padding = (extra+1)/2\n+ (\" \" left_padding) + self + (\" \" *right_padding)\n+ end\n+ end\n+end\n+\n+module Neo\n+ class << self\n+ def simple_output\n+ ENV['SIMPLE_KOAN_OUTPUT'] == 'true'\n+ end\n+ end\n+\n+ module Color\n+ #shamelessly stolen (and modified) from redgreen\n+ COLORS = {\n+ :clear => 0, :black => 30, :red => 31,\n+ :green => 32, :yellow => 33, :blue => 34,\n+ :magenta => 35, :cyan => 36,\n+ }\n+\n+ module_function\n+\n+ COLORS.each do \|color, value\|\n+ module_eval \"def #{color}(string); colorize(string, #{value}); end\"\n+ module_function color\n+ end\n+\n+ def colorize(string, color_value)\n+ if use_colors?\n+ color(color_value) + string + color(COLORS[:clear])\n+ else\n+ string\n+ end\n+ end\n+\n+ def color(color_value)\n+ \"\\e[#{color_value}m\"\n+ end\n+\n+ def use_colors?\n+ return false if ENV['NO_COLOR']\n+ if ENV['ANSI_COLOR'].nil?","path":"3493/0/neo.rb","position":121,"original_position":121,"commit_id":"4e41efdd688b5bdf34beabc2d2e5a21852cc2ae9","original_commit_id":"4e41efdd688b5bdf34beabc2d2e5a21852cc2ae9","user":{"login":"hound[bot]","id":30008653,"node_id":"MDM6Qm90MzAwMDg2NTM=","avatar_url":"https://avatars1.githubusercontent.com/in/3598?v=4","gravatar_id":"","url":"https://api.github.com/users/hound%5Bbot%5D","html_url":"https://github.com/apps/hound","followers_url":"https://api.github.com/users/hound%5Bbot%5D/followers","following_url":"https://api.github.com/users/hound%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/hound%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/hound%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hound%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/hound%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/hound%5Bbot%5D/repos","events_url":"https://api.github.com/users/hound%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/hound%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"NilCheck: Neo::Color#use_colors? performs a nil-check. [More info](https://github.com/troessner/reek/blob/v5.0.2/docs/Nil-Check.md).","created_at":"2019-07-08T15:17:02Z","updated_at":"2019-07-08T15:17:04Z","html_url":"https://github.com/rubizza-camp/summer-2019/pull/71#discussion_r301151630","pull_request_url":"https://api.github.com/repos/rubizza-camp/summer-2019/pulls/71","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/rubizza-camp/summer-2019/pulls/comments/301151630"},"html":{"href":"https://github.com/rubizza-camp/summer-2019/pull/71#discussion_r301151630"},"pull_request":{"href":"https://api.github.com/repos/rubizza-camp/summer-2019/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/rubizza-camp/summer-2019/pulls/71","id":295355653,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk1MzU1NjUz","html_url":"https://github.com/rubizza-camp/summer-2019/pull/71","diff_url":"https://github.com/rubizza-camp/summer-2019/pull/71.diff","patch_url":"https://github.com/rubizza-camp/summer-2019/pull/71.patch","issue_url":"https://api.github.com/repos/rubizza-camp/summer-2019/issues/71","number":71,"state":"open","locked":false,"title":"3493-0","user":{"login":"Maxxx911","id":28686475,"node_id":"MDQ6VXNlcjI4Njg2NDc1","avatar_url":"https://avatars1.githubusercontent.com/u/28686475?v=4","gravatar_id":"","url":"https://api.github.com/users/Maxxx911","html_url":"https://github.com/Maxxx911","followers_url":"https://api.github.com/users/Maxxx911/followers","following_url":"https://api.github.com/users/Maxxx911/following{/other_user}","gists_url":"https://api.github.com/users/Maxxx911/gists{/gist_id}","starred_url":"https://api.github.com/users/Maxxx911/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maxxx911/subscriptions","organizations_url":"https://api.github.com/users/Maxxx911/orgs","repos_url":"https://api.github.com/users/Maxxx911/repos","events_url":"https://api.github.com/users/Maxxx911/events{/privacy}","received_events_url":"https://api.github.com/users/Maxxx911/received_events","type":"User","site_admin":false},"body":"## Номер\r\n3493\r\n## Номер задания\r\n0\r\n\r\n## Ссылка на видео с демо\r\nhttps://www.youtube.com/watch?v=ydJpYPHdpII\r\n\r\n## Комментарии\r\nХотел сделать то-то, но не успел и не понимаю.\r\n","created_at":"2019-07-08T14:14:53Z","updated_at":"2019-07-08T15:17:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"139335a93e3c1e2ee7da5bf5e96ed2a9beb612ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubizza-camp/summer-2019/pulls/71/commits","review_comments_url":"https://api.github.com/repos/rubizza-camp/summer-2019/pulls/71/comments","review_comment_url":"https://api.github.com/repos/rubizza-camp/summer-2019/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubizza-camp/summer-2019/issues/71/comments","statuses_url":"https://api.github.com/repos/rubizza-camp/summer-2019/statuses/4e41efdd688b5bdf34beabc2d2e5a21852cc2ae9","head":{"label":"Maxxx911:3493-0","ref":"3493-0","sha":"4e41efdd688b5bdf34beabc2d2e5a21852cc2ae9","user":{"login":"Maxxx911","id":28686475,"node_id":"MDQ6VXNlcjI4Njg2NDc1","avatar_url":"https://avatars1.githubusercontent.com/u/28686475?v=4","gravatar_id":"","url":"https://api.github.com/users/Maxxx911","html_url":"https://github.com/Maxxx911","followers_url":"https://api.github.com/users/Maxxx911/followers","following_url":"https://api.github.com/users/Maxxx911/following{/other_user}","gists_url":"https://api.github.com/users/Maxxx911/gists{/gist_id}","starred_url":"https://api.github.com/users/Maxxx911/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maxxx911/subscriptions","organizations_url":"https://api.github.com/users/Maxxx911/orgs","repos_url":"https://api.github.com/users/Maxxx911/repos","events_url":"https://api.github.com/users/Maxxx911/events{/privacy}","received_events_url":"https://api.github.com/users/Maxxx911/received_events","type":"User","site_admin":false},"repo":{"id":195825205,"node_id":"MDEwOlJlcG9zaXRvcnkxOTU4MjUyMDU=","name":"summer-2019","full_name":"Maxxx911/summer-2019","private":false,"owner":{"login":"Maxxx911","id":28686475,"node_id":"MDQ6VXNlcjI4Njg2NDc1","avatar_url":"https://avatars1.githubusercontent.com/u/28686475?v=4","gravatar_id":"","url":"https://api.github.com/users/Maxxx911","html_url":"https://github.com/Maxxx911","followers_url":"https://api.github.com/users/Maxxx911/followers","following_url":"https://api.github.com/users/Maxxx911/following{/other_user}","gists_url":"https://api.github.com/users/Maxxx911/gists{/gist_id}","starred_url":"https://api.github.com/users/Maxxx911/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Maxxx911/subscriptions","organizations_url":"https://api.github.com/users/Maxxx911/orgs","repos_url":"https://api.github.com/users/Maxxx911/repos","events_url":"https://api.github.com/users/Maxxx911/events{/privacy}","received_events_url":"https://api.github.com/users/Maxxx911/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Maxxx911/summer-2019","description":"Rubizza 2019 Summer homeworks storage","fork":true,"url":"https://api.github.com/repos/Maxxx911/summer-2019","forks_url":"https://api.github.com/repos/Maxxx911/summer-2019/forks","keys_url":"https://api.github.com/repos/Maxxx911/summer-2019/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Maxxx911/summer-2019/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Maxxx911/summer-2019/teams","hooks_url":"https://api.github.com/repos/Maxxx911/summer-2019/hooks","issue_events_url":"https://api.github.com/repos/Maxxx911/summer-2019/issues/events{/number}","events_url":"https://api.github.com/repos/Maxxx911/summer-2019/events","assignees_url":"https://api.github.com/repos/Maxxx911/summer-2019/assignees{/user}","branches_url":"https://api.github.com/repos/Maxxx911/summer-2019/branches{/branch}","tags_url":"https://api.github.com/repos/Maxxx911/summer-2019/tags","blobs_url":"https://api.github.com/repos/Maxxx911/summer-2019/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Maxxx911/summer-2019/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Maxxx911/summer-2019/git/refs{/sha}","trees_url":"https://api.github.com/repos/Maxxx911/summer-2019/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Maxxx911/summer-2019/statuses/{sha}","languages_url":"https://api.github.com/repos/Maxxx911/summer-2019/languages","stargazers_url":"https://api.github.com/repos/Maxxx911/summer-2019/stargazers","contributors_url":"https://api.github.com/repos/Maxxx911/summer-2019/contributors","subscribers_url":"https://api.github.com/repos/Maxxx911/summer-2019/subscribers","subscription_url":"https://api.github.com/repos/Maxxx911/summer-2019/subscription","commits_url":"https://api.github.com/repos/Maxxx911/summer-2019/commits{/sha}","git_commits_url":"https://api.github.com/repos/Maxxx911/summer-2019/git/commits{/sha}","comments_url":"https://api.github.com/repos/Maxxx911/summer-2019/comments{/number}","issue_comment_url":"https://api.github.com/repos/Maxxx911/summer-2019/issues/comments{/number}","contents_url":"https://api.github.com/repos/Maxxx911/summer-2019/contents/{+path}","compare_url":"https://api.github.com/repos/Maxxx911/summer-2019/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Maxxx911/summer-2019/merges","archive_url":"https://api.github.com/repos/Maxxx911/summer-2019/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Maxxx911/summer-2019/downloads","issues_url":"https://api.github.com/repos/Maxxx911/summer-2019/issues{/number}","pulls_url":"https://api.github.com/repos/Maxxx911/summer-2019/pulls{/number}","milestones_url":"https://api.github.com/repos/Maxxx911/summer-2019/milestones{/number}","notifications_url":"https://api.github.com/repos/Maxxx911/summer-2019/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Maxxx911/summer-2019/labels{/name}","releases_url":"https://api.github.com/repos/Maxxx911/summer-2019/releases{/id}","deployments_url":"https://api.github.com/repos/Maxxx911/summer-2019/deployments","created_at":"2019-07-08T14:08:54Z","updated_at":"2019-07-08T14:08:57Z","pushed_at":"2019-07-08T15:16:42Z","git_url":"git://github.com/Maxxx911/summer-2019.git","ssh_url":"[email protected]:Maxxx911/summer-2019.git","clone_url":"https://github.com/Maxxx911/summer-2019.git","svn_url":"https://github.com/Maxxx911/summer-2019","homepage":"https://rubizza.com","size":133,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rubizza-camp:master","ref":"master","sha":"7756c489f9dac2ab280c0663229df249cdace785","user":{"login":"rubizza-camp","id":40864986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/40864986?v=4","gravatar_id":"","url":"https://api.github.com/users/rubizza-camp","html_url":"https://github.com/rubizza-camp","followers_url":"https://api.github.com/users/rubizza-camp/followers","following_url":"https://api.github.com/users/rubizza-camp/following{/other_user}","gists_url":"https://api.github.com/users/rubizza-camp/gists{/gist_id}","starred_url":"https://api.github.com/users/rubizza-camp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubizza-camp/subscriptions","organizations_url":"https://api.github.com/users/rubizza-camp/orgs","repos_url":"https://api.github.com/users/rubizza-camp/repos","events_url":"https://api.github.com/users/rubizza-camp/events{/privacy}","received_events_url":"https://api.github.com/users/rubizza-camp/received_events","type":"Organization","site_admin":false},"repo":{"id":194091304,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQwOTEzMDQ=","name":"summer-2019","full_name":"rubizza-camp/summer-2019","private":false,"owner":{"login":"rubizza-camp","id":40864986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/40864986?v=4","gravatar_id":"","url":"https://api.github.com/users/rubizza-camp","html_url":"https://github.com/rubizza-camp","followers_url":"https://api.github.com/users/rubizza-camp/followers","following_url":"https://api.github.com/users/rubizza-camp/following{/other_user}","gists_url":"https://api.github.com/users/rubizza-camp/gists{/gist_id}","starred_url":"https://api.github.com/users/rubizza-camp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubizza-camp/subscriptions","organizations_url":"https://api.github.com/users/rubizza-camp/orgs","repos_url":"https://api.github.com/users/rubizza-camp/repos","events_url":"https://api.github.com/users/rubizza-camp/events{/privacy}","received_events_url":"https://api.github.com/users/rubizza-camp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rubizza-camp/summer-2019","description":"Rubizza 2019 Summer homeworks storage","fork":false,"url":"https://api.github.com/repos/rubizza-camp/summer-2019","forks_url":"https://api.github.com/repos/rubizza-camp/summer-2019/forks","keys_url":"https://api.github.com/repos/rubizza-camp/summer-2019/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubizza-camp/summer-2019/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubizza-camp/summer-2019/teams","hooks_url":"https://api.github.com/repos/rubizza-camp/summer-2019/hooks","issue_events_url":"https://api.github.com/repos/rubizza-camp/summer-2019/issues/events{/number}","events_url":"https://api.github.com/repos/rubizza-camp/summer-2019/events","assignees_url":"https://api.github.com/repos/rubizza-camp/summer-2019/assignees{/user}","branches_url":"https://api.github.com/repos/rubizza-camp/summer-2019/branches{/branch}","tags_url":"https://api.github.com/repos/rubizza-camp/summer-2019/tags","blobs_url":"https://api.github.com/repos/rubizza-camp/summer-2019/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubizza-camp/summer-2019/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubizza-camp/summer-2019/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubizza-camp/summer-2019/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubizza-camp/summer-2019/statuses/{sha}","languages_url":"https://api.github.com/repos/rubizza-camp/summer-2019/languages","stargazers_url":"https://api.github.com/repos/rubizza-camp/summer-2019/stargazers","contributors_url":"https://api.github.com/repos/rubizza-camp/summer-2019/contributors","subscribers_url":"https://api.github.com/repos/rubizza-camp/summer-2019/subscribers","subscription_url":"https://api.github.com/repos/rubizza-camp/summer-2019/subscription","commits_url":"https://api.github.com/repos/rubizza-camp/summer-2019/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubizza-camp/summer-2019/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubizza-camp/summer-2019/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubizza-camp/summer-2019/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubizza-camp/summer-2019/contents/{+path}","compare_url":"https://api.github.com/repos/rubizza-camp/summer-2019/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubizza-camp/summer-2019/merges","archive_url":"https://api.github.com/repos/rubizza-camp/summer-2019/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubizza-camp/summer-2019/downloads","issues_url":"https://api.github.com/repos/rubizza-camp/summer-2019/issues{/number}","pulls_url":"https://api.github.com/repos/rubizza-camp/summer-2019/pulls{/number}","milestones_url":"https://api.github.com/repos/rubizza-camp/summer-2019/milestones{/number}","notifications_url":"https://api.github.com/repos/rubizza-camp/summer-2019/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubizza-camp/summer-2019/labels{/name}","releases_url":"https://api.github.com/repos/rubizza-camp/summer-2019/releases{/id}","deployments_url":"https://api.github.com/repos/rubizza-camp/summer-2019/deployments","created_at":"2019-06-27T12:29:20Z","updated_at":"2019-07-08T14:02:51Z","pushed_at":"2019-07-08T15:16:44Z","git_url":"git://github.com/rubizza-camp/summer-2019.git","ssh_url":"[email protected]:rubizza-camp/summer-2019.git","clone_url":"https://github.com/rubizza-camp/summer-2019.git","svn_url":"https://github.com/rubizza-camp/summer-2019","homepage":"https://rubizza.com","size":116,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":33,"license":null,"forks":71,"open_issues":33,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubizza-camp/summer-2019/pulls/71"},"html":{"href":"https://github.com/rubizza-camp/summer-2019/pull/71"},"issue":{"href":"https://api.github.com/repos/rubizza-camp/summer-2019/issues/71"},"comments":{"href":"https://api.github.com/repos/rubizza-camp/summer-2019/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/rubizza-camp/summer-2019/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/rubizza-camp/summer-2019/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubizza-camp/summer-2019/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/rubizza-camp/summer-2019/statuses/4e41efdd688b5bdf34beabc2d2e5a21852cc2ae9"}},"author_association":"NONE"}}	{ "id": 194091304, "name": "rubizza-camp/summer-2019", "url": "https://api.github.com/repos/rubizza-camp/summer-2019" }	{ "id": 30008653, "login": "hound[bot]", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/30008653?", "url": "https://api.github.com/users/hound[bot]" }	{ "id": 40864986, "login": "rubizza-camp", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/40864986?", "url": "https://api.github.com/orgs/rubizza-camp" }	2019-07-08T15:17:02	9968291055	{"actor":{"display_login":"hound"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/aws-amplify/community/pulls/comments/290826045","pull_request_review_id":246118514,"id":290826045,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MDgyNjA0NQ==","diff_hunk":"@@ -206,7 +206,17 @@ export default () => {\n <div className='lower'>\n <div className='copyright'>\n <Text>\n- {`The Amplify Community is supported by Amazon Web Services © ${new Date().getFullYear()}, Amazon Web Services, Inc. or its affiliates. All rights reserved.`}\n+ {`The Amplify Community is supported by Amazon Web Services © ${new Date().getFullYear()}, Amazon Web Services, Inc. or its affiliates. All rights reserved. View our `}\n+ <ExternalLink\n+ href='https://aws.amazon.com/terms/'\n+ children='terms of use'","path":"src/components/Footer.js","position":8,"original_position":8,"commit_id":"e031f91ba064553e919eb3251ebef602026496eb","original_commit_id":"e031f91ba064553e919eb3251ebef602026496eb","user":{"login":"swaminator","id":2429410,"node_id":"MDQ6VXNlcjI0Mjk0MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/2429410?v=4","gravatar_id":"","url":"https://api.github.com/users/swaminator","html_url":"https://github.com/swaminator","followers_url":"https://api.github.com/users/swaminator/followers","following_url":"https://api.github.com/users/swaminator/following{/other_user}","gists_url":"https://api.github.com/users/swaminator/gists{/gist_id}","starred_url":"https://api.github.com/users/swaminator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaminator/subscriptions","organizations_url":"https://api.github.com/users/swaminator/orgs","repos_url":"https://api.github.com/users/swaminator/repos","events_url":"https://api.github.com/users/swaminator/events{/privacy}","received_events_url":"https://api.github.com/users/swaminator/received_events","type":"User","site_admin":false},"body":"Site Terms","created_at":"2019-06-05T16:24:54Z","updated_at":"2019-06-05T16:25:37Z","html_url":"https://github.com/aws-amplify/community/pull/88#discussion_r290826045","pull_request_url":"https://api.github.com/repos/aws-amplify/community/pulls/88","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/aws-amplify/community/pulls/comments/290826045"},"html":{"href":"https://github.com/aws-amplify/community/pull/88#discussion_r290826045"},"pull_request":{"href":"https://api.github.com/repos/aws-amplify/community/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/aws-amplify/community/pulls/88","id":285183601,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1MTgzNjAx","html_url":"https://github.com/aws-amplify/community/pull/88","diff_url":"https://github.com/aws-amplify/community/pull/88.diff","patch_url":"https://github.com/aws-amplify/community/pull/88.patch","issue_url":"https://api.github.com/repos/aws-amplify/community/issues/88","number":88,"state":"open","locked":false,"title":"feat(footer component): added link to terms and privacy policy","user":{"login":"harrysolovay","id":4893548,"node_id":"MDQ6VXNlcjQ4OTM1NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/4893548?v=4","gravatar_id":"","url":"https://api.github.com/users/harrysolovay","html_url":"https://github.com/harrysolovay","followers_url":"https://api.github.com/users/harrysolovay/followers","following_url":"https://api.github.com/users/harrysolovay/following{/other_user}","gists_url":"https://api.github.com/users/harrysolovay/gists{/gist_id}","starred_url":"https://api.github.com/users/harrysolovay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harrysolovay/subscriptions","organizations_url":"https://api.github.com/users/harrysolovay/orgs","repos_url":"https://api.github.com/users/harrysolovay/repos","events_url":"https://api.github.com/users/harrysolovay/events{/privacy}","received_events_url":"https://api.github.com/users/harrysolovay/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-06-04T23:53:59Z","updated_at":"2019-06-05T16:25:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65818398a642431eea822c3688b0d91508cd897c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws-amplify/community/pulls/88/commits","review_comments_url":"https://api.github.com/repos/aws-amplify/community/pulls/88/comments","review_comment_url":"https://api.github.com/repos/aws-amplify/community/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws-amplify/community/issues/88/comments","statuses_url":"https://api.github.com/repos/aws-amplify/community/statuses/e031f91ba064553e919eb3251ebef602026496eb","head":{"label":"aws-amplify:develop","ref":"develop","sha":"e031f91ba064553e919eb3251ebef602026496eb","user":{"login":"aws-amplify","id":41077760,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDc3NzYw","avatar_url":"https://avatars0.githubusercontent.com/u/41077760?v=4","gravatar_id":"","url":"https://api.github.com/users/aws-amplify","html_url":"https://github.com/aws-amplify","followers_url":"https://api.github.com/users/aws-amplify/followers","following_url":"https://api.github.com/users/aws-amplify/following{/other_user}","gists_url":"https://api.github.com/users/aws-amplify/gists{/gist_id}","starred_url":"https://api.github.com/users/aws-amplify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws-amplify/subscriptions","organizations_url":"https://api.github.com/users/aws-amplify/orgs","repos_url":"https://api.github.com/users/aws-amplify/repos","events_url":"https://api.github.com/users/aws-amplify/events{/privacy}","received_events_url":"https://api.github.com/users/aws-amplify/received_events","type":"Organization","site_admin":false},"repo":{"id":181988412,"node_id":"MDEwOlJlcG9zaXRvcnkxODE5ODg0MTI=","name":"community","full_name":"aws-amplify/community","private":false,"owner":{"login":"aws-amplify","id":41077760,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDc3NzYw","avatar_url":"https://avatars0.githubusercontent.com/u/41077760?v=4","gravatar_id":"","url":"https://api.github.com/users/aws-amplify","html_url":"https://github.com/aws-amplify","followers_url":"https://api.github.com/users/aws-amplify/followers","following_url":"https://api.github.com/users/aws-amplify/following{/other_user}","gists_url":"https://api.github.com/users/aws-amplify/gists{/gist_id}","starred_url":"https://api.github.com/users/aws-amplify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws-amplify/subscriptions","organizations_url":"https://api.github.com/users/aws-amplify/orgs","repos_url":"https://api.github.com/users/aws-amplify/repos","events_url":"https://api.github.com/users/aws-amplify/events{/privacy}","received_events_url":"https://api.github.com/users/aws-amplify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws-amplify/community","description":"AWS Amplify Community","fork":false,"url":"https://api.github.com/repos/aws-amplify/community","forks_url":"https://api.github.com/repos/aws-amplify/community/forks","keys_url":"https://api.github.com/repos/aws-amplify/community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws-amplify/community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws-amplify/community/teams","hooks_url":"https://api.github.com/repos/aws-amplify/community/hooks","issue_events_url":"https://api.github.com/repos/aws-amplify/community/issues/events{/number}","events_url":"https://api.github.com/repos/aws-amplify/community/events","assignees_url":"https://api.github.com/repos/aws-amplify/community/assignees{/user}","branches_url":"https://api.github.com/repos/aws-amplify/community/branches{/branch}","tags_url":"https://api.github.com/repos/aws-amplify/community/tags","blobs_url":"https://api.github.com/repos/aws-amplify/community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws-amplify/community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws-amplify/community/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws-amplify/community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws-amplify/community/statuses/{sha}","languages_url":"https://api.github.com/repos/aws-amplify/community/languages","stargazers_url":"https://api.github.com/repos/aws-amplify/community/stargazers","contributors_url":"https://api.github.com/repos/aws-amplify/community/contributors","subscribers_url":"https://api.github.com/repos/aws-amplify/community/subscribers","subscription_url":"https://api.github.com/repos/aws-amplify/community/subscription","commits_url":"https://api.github.com/repos/aws-amplify/community/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws-amplify/community/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws-amplify/community/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws-amplify/community/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws-amplify/community/contents/{+path}","compare_url":"https://api.github.com/repos/aws-amplify/community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws-amplify/community/merges","archive_url":"https://api.github.com/repos/aws-amplify/community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws-amplify/community/downloads","issues_url":"https://api.github.com/repos/aws-amplify/community/issues{/number}","pulls_url":"https://api.github.com/repos/aws-amplify/community/pulls{/number}","milestones_url":"https://api.github.com/repos/aws-amplify/community/milestones{/number}","notifications_url":"https://api.github.com/repos/aws-amplify/community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws-amplify/community/labels{/name}","releases_url":"https://api.github.com/repos/aws-amplify/community/releases{/id}","deployments_url":"https://api.github.com/repos/aws-amplify/community/deployments","created_at":"2019-04-18T00:31:26Z","updated_at":"2019-06-04T17:40:12Z","pushed_at":"2019-06-04T23:53:59Z","git_url":"git://github.com/aws-amplify/community.git","ssh_url":"[email protected]:aws-amplify/community.git","clone_url":"https://github.com/aws-amplify/community.git","svn_url":"https://github.com/aws-amplify/community","homepage":"https://amplify.aws/community","size":123279,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":null,"forks":37,"open_issues":9,"watchers":53,"default_branch":"master"}},"base":{"label":"aws-amplify:master","ref":"master","sha":"5186252a744b597c0b943930f85abaccf512be0c","user":{"login":"aws-amplify","id":41077760,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDc3NzYw","avatar_url":"https://avatars0.githubusercontent.com/u/41077760?v=4","gravatar_id":"","url":"https://api.github.com/users/aws-amplify","html_url":"https://github.com/aws-amplify","followers_url":"https://api.github.com/users/aws-amplify/followers","following_url":"https://api.github.com/users/aws-amplify/following{/other_user}","gists_url":"https://api.github.com/users/aws-amplify/gists{/gist_id}","starred_url":"https://api.github.com/users/aws-amplify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws-amplify/subscriptions","organizations_url":"https://api.github.com/users/aws-amplify/orgs","repos_url":"https://api.github.com/users/aws-amplify/repos","events_url":"https://api.github.com/users/aws-amplify/events{/privacy}","received_events_url":"https://api.github.com/users/aws-amplify/received_events","type":"Organization","site_admin":false},"repo":{"id":181988412,"node_id":"MDEwOlJlcG9zaXRvcnkxODE5ODg0MTI=","name":"community","full_name":"aws-amplify/community","private":false,"owner":{"login":"aws-amplify","id":41077760,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDc3NzYw","avatar_url":"https://avatars0.githubusercontent.com/u/41077760?v=4","gravatar_id":"","url":"https://api.github.com/users/aws-amplify","html_url":"https://github.com/aws-amplify","followers_url":"https://api.github.com/users/aws-amplify/followers","following_url":"https://api.github.com/users/aws-amplify/following{/other_user}","gists_url":"https://api.github.com/users/aws-amplify/gists{/gist_id}","starred_url":"https://api.github.com/users/aws-amplify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws-amplify/subscriptions","organizations_url":"https://api.github.com/users/aws-amplify/orgs","repos_url":"https://api.github.com/users/aws-amplify/repos","events_url":"https://api.github.com/users/aws-amplify/events{/privacy}","received_events_url":"https://api.github.com/users/aws-amplify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws-amplify/community","description":"AWS Amplify Community","fork":false,"url":"https://api.github.com/repos/aws-amplify/community","forks_url":"https://api.github.com/repos/aws-amplify/community/forks","keys_url":"https://api.github.com/repos/aws-amplify/community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws-amplify/community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws-amplify/community/teams","hooks_url":"https://api.github.com/repos/aws-amplify/community/hooks","issue_events_url":"https://api.github.com/repos/aws-amplify/community/issues/events{/number}","events_url":"https://api.github.com/repos/aws-amplify/community/events","assignees_url":"https://api.github.com/repos/aws-amplify/community/assignees{/user}","branches_url":"https://api.github.com/repos/aws-amplify/community/branches{/branch}","tags_url":"https://api.github.com/repos/aws-amplify/community/tags","blobs_url":"https://api.github.com/repos/aws-amplify/community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws-amplify/community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws-amplify/community/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws-amplify/community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws-amplify/community/statuses/{sha}","languages_url":"https://api.github.com/repos/aws-amplify/community/languages","stargazers_url":"https://api.github.com/repos/aws-amplify/community/stargazers","contributors_url":"https://api.github.com/repos/aws-amplify/community/contributors","subscribers_url":"https://api.github.com/repos/aws-amplify/community/subscribers","subscription_url":"https://api.github.com/repos/aws-amplify/community/subscription","commits_url":"https://api.github.com/repos/aws-amplify/community/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws-amplify/community/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws-amplify/community/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws-amplify/community/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws-amplify/community/contents/{+path}","compare_url":"https://api.github.com/repos/aws-amplify/community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws-amplify/community/merges","archive_url":"https://api.github.com/repos/aws-amplify/community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws-amplify/community/downloads","issues_url":"https://api.github.com/repos/aws-amplify/community/issues{/number}","pulls_url":"https://api.github.com/repos/aws-amplify/community/pulls{/number}","milestones_url":"https://api.github.com/repos/aws-amplify/community/milestones{/number}","notifications_url":"https://api.github.com/repos/aws-amplify/community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws-amplify/community/labels{/name}","releases_url":"https://api.github.com/repos/aws-amplify/community/releases{/id}","deployments_url":"https://api.github.com/repos/aws-amplify/community/deployments","created_at":"2019-04-18T00:31:26Z","updated_at":"2019-06-04T17:40:12Z","pushed_at":"2019-06-04T23:53:59Z","git_url":"git://github.com/aws-amplify/community.git","ssh_url":"[email protected]:aws-amplify/community.git","clone_url":"https://github.com/aws-amplify/community.git","svn_url":"https://github.com/aws-amplify/community","homepage":"https://amplify.aws/community","size":123279,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":null,"forks":37,"open_issues":9,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws-amplify/community/pulls/88"},"html":{"href":"https://github.com/aws-amplify/community/pull/88"},"issue":{"href":"https://api.github.com/repos/aws-amplify/community/issues/88"},"comments":{"href":"https://api.github.com/repos/aws-amplify/community/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/aws-amplify/community/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/aws-amplify/community/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws-amplify/community/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/aws-amplify/community/statuses/e031f91ba064553e919eb3251ebef602026496eb"}},"author_association":"MEMBER"}}	{ "id": 181988412, "name": "aws-amplify/community", "url": "https://api.github.com/repos/aws-amplify/community" }	{ "id": 2429410, "login": "swaminator", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/2429410?", "url": "https://api.github.com/users/swaminator" }	{ "id": 41077760, "login": "aws-amplify", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/41077760?", "url": "https://api.github.com/orgs/aws-amplify" }	2019-06-05T16:24:54	9764736676	{"actor":{"display_login":"swaminator"}}
PullRequestReviewCommentEvent	true	{"action":"created","comment":{"url":"https://api.github.com/repos/cobuildlab/bazl-admin/pulls/comments/334041466","pull_request_review_id":300752678,"id":334041466,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNDA0MTQ2Ng==","diff_hunk":"@@ -181,34 +193,42 @@ export const updateCommentAction = async (data, index) => {\n });\n \n const influencerCollection = DB.collection('influencersSalesProducts');\n+ let influencerRefGet;\n let influencer;\n let idInfluencer;\n \n- await influencerCollection\n- .where('saleId', '==', ref.id)\n- .get()\n- .then((data) => {\n- data.forEach((doc) => {\n- idInfluencer = doc.id;\n- influencer = doc.data();\n- if (ref.comment) {\n- influencer.comment = ref.comment;\n- influencer.orderStatus = sale.orderStatus;\n- }\n- });\n- })\n- .catch((e) => {\n- Flux.dispatchEvent(COMMENT_ERROR, new Error(e));\n- console.log(e);\n- });\n+ try {\n+ influencerRefGet = await influencerCollection\n+ .where('saleId', '==', ref.id)\n+ .get();\n+ } catch (err) {\n+ return Flux.dispatch(COMMENT_ERROR, new Error(err));\n+ }\n+\n+ influencerRefGet.forEach((element) => {\n+ if (element.data().saleId === ref.id) {\n+ idInfluencer = element.data().id;","path":"src/modules/sales/sales-action.js","position":93,"original_position":93,"commit_id":"1c7cc47fa7b3bd3210228d88fafaa8a98427b2ac","original_commit_id":"1c7cc47fa7b3bd3210228d88fafaa8a98427b2ac","user":{"login":"alacret","id":918895,"node_id":"MDQ6VXNlcjkxODg5NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/918895?v=4","gravatar_id":"","url":"https://api.github.com/users/alacret","html_url":"https://github.com/alacret","followers_url":"https://api.github.com/users/alacret/followers","following_url":"https://api.github.com/users/alacret/following{/other_user}","gists_url":"https://api.github.com/users/alacret/gists{/gist_id}","starred_url":"https://api.github.com/users/alacret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alacret/subscriptions","organizations_url":"https://api.github.com/users/alacret/orgs","repos_url":"https://api.github.com/users/alacret/repos","events_url":"https://api.github.com/users/alacret/events{/privacy}","received_events_url":"https://api.github.com/users/alacret/received_events","type":"User","site_admin":false},"body":"cuando tu haces element.data() a veces el SDK tiene que llamar al servidor para traer la data, lo que hace que llamarlo varias veces sea ineficiente, haz una sola vez .data() y luego trabajas con el objeto","created_at":"2019-10-11T15:12:28Z","updated_at":"2019-10-11T15:13:00Z","html_url":"https://github.com/cobuildlab/bazl-admin/pull/140#discussion_r334041466","pull_request_url":"https://api.github.com/repos/cobuildlab/bazl-admin/pulls/140","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cobuildlab/bazl-admin/pulls/comments/334041466"},"html":{"href":"https://github.com/cobuildlab/bazl-admin/pull/140#discussion_r334041466"},"pull_request":{"href":"https://api.github.com/repos/cobuildlab/bazl-admin/pulls/140"}}},"pull_request":{"url":"https://api.github.com/repos/cobuildlab/bazl-admin/pulls/140","id":326995526,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI2OTk1NTI2","html_url":"https://github.com/cobuildlab/bazl-admin/pull/140","diff_url":"https://github.com/cobuildlab/bazl-admin/pull/140.diff","patch_url":"https://github.com/cobuildlab/bazl-admin/pull/140.patch","issue_url":"https://api.github.com/repos/cobuildlab/bazl-admin/issues/140","number":140,"state":"open","locked":false,"title":"Imagen storage","user":{"login":"wmata141","id":33898160,"node_id":"MDQ6VXNlcjMzODk4MTYw","avatar_url":"https://avatars2.githubusercontent.com/u/33898160?v=4","gravatar_id":"","url":"https://api.github.com/users/wmata141","html_url":"https://github.com/wmata141","followers_url":"https://api.github.com/users/wmata141/followers","following_url":"https://api.github.com/users/wmata141/following{/other_user}","gists_url":"https://api.github.com/users/wmata141/gists{/gist_id}","starred_url":"https://api.github.com/users/wmata141/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmata141/subscriptions","organizations_url":"https://api.github.com/users/wmata141/orgs","repos_url":"https://api.github.com/users/wmata141/repos","events_url":"https://api.github.com/users/wmata141/events{/privacy}","received_events_url":"https://api.github.com/users/wmata141/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-11T01:52:53Z","updated_at":"2019-10-11T15:13:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b479a1444b83d1364edb22705198c6b81080d88b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cobuildlab/bazl-admin/pulls/140/commits","review_comments_url":"https://api.github.com/repos/cobuildlab/bazl-admin/pulls/140/comments","review_comment_url":"https://api.github.com/repos/cobuildlab/bazl-admin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cobuildlab/bazl-admin/issues/140/comments","statuses_url":"https://api.github.com/repos/cobuildlab/bazl-admin/statuses/1c7cc47fa7b3bd3210228d88fafaa8a98427b2ac","head":{"label":"cobuildlab:feature/sales","ref":"feature/sales","sha":"1c7cc47fa7b3bd3210228d88fafaa8a98427b2ac","user":{"login":"cobuildlab","id":41276121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMjc2MTIx","avatar_url":"https://avatars3.githubusercontent.com/u/41276121?v=4","gravatar_id":"","url":"https://api.github.com/users/cobuildlab","html_url":"https://github.com/cobuildlab","followers_url":"https://api.github.com/users/cobuildlab/followers","following_url":"https://api.github.com/users/cobuildlab/following{/other_user}","gists_url":"https://api.github.com/users/cobuildlab/gists{/gist_id}","starred_url":"https://api.github.com/users/cobuildlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cobuildlab/subscriptions","organizations_url":"https://api.github.com/users/cobuildlab/orgs","repos_url":"https://api.github.com/users/cobuildlab/repos","events_url":"https://api.github.com/users/cobuildlab/events{/privacy}","received_events_url":"https://api.github.com/users/cobuildlab/received_events","type":"Organization","site_admin":false},"repo":{"id":186160463,"node_id":"MDEwOlJlcG9zaXRvcnkxODYxNjA0NjM=","name":"bazl-admin","full_name":"cobuildlab/bazl-admin","private":false,"owner":{"login":"cobuildlab","id":41276121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMjc2MTIx","avatar_url":"https://avatars3.githubusercontent.com/u/41276121?v=4","gravatar_id":"","url":"https://api.github.com/users/cobuildlab","html_url":"https://github.com/cobuildlab","followers_url":"https://api.github.com/users/cobuildlab/followers","following_url":"https://api.github.com/users/cobuildlab/following{/other_user}","gists_url":"https://api.github.com/users/cobuildlab/gists{/gist_id}","starred_url":"https://api.github.com/users/cobuildlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cobuildlab/subscriptions","organizations_url":"https://api.github.com/users/cobuildlab/orgs","repos_url":"https://api.github.com/users/cobuildlab/repos","events_url":"https://api.github.com/users/cobuildlab/events{/privacy}","received_events_url":"https://api.github.com/users/cobuildlab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cobuildlab/bazl-admin","description":null,"fork":false,"url":"https://api.github.com/repos/cobuildlab/bazl-admin","forks_url":"https://api.github.com/repos/cobuildlab/bazl-admin/forks","keys_url":"https://api.github.com/repos/cobuildlab/bazl-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cobuildlab/bazl-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cobuildlab/bazl-admin/teams","hooks_url":"https://api.github.com/repos/cobuildlab/bazl-admin/hooks","issue_events_url":"https://api.github.com/repos/cobuildlab/bazl-admin/issues/events{/number}","events_url":"https://api.github.com/repos/cobuildlab/bazl-admin/events","assignees_url":"https://api.github.com/repos/cobuildlab/bazl-admin/assignees{/user}","branches_url":"https://api.github.com/repos/cobuildlab/bazl-admin/branches{/branch}","tags_url":"https://api.github.com/repos/cobuildlab/bazl-admin/tags","blobs_url":"https://api.github.com/repos/cobuildlab/bazl-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cobuildlab/bazl-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cobuildlab/bazl-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/cobuildlab/bazl-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cobuildlab/bazl-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/cobuildlab/bazl-admin/languages","stargazers_url":"https://api.github.com/repos/cobuildlab/bazl-admin/stargazers","contributors_url":"https://api.github.com/repos/cobuildlab/bazl-admin/contributors","subscribers_url":"https://api.github.com/repos/cobuildlab/bazl-admin/subscribers","subscription_url":"https://api.github.com/repos/cobuildlab/bazl-admin/subscription","commits_url":"https://api.github.com/repos/cobuildlab/bazl-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/cobuildlab/bazl-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/cobuildlab/bazl-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/cobuildlab/bazl-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/cobuildlab/bazl-admin/contents/{+path}","compare_url":"https://api.github.com/repos/cobuildlab/bazl-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cobuildlab/bazl-admin/merges","archive_url":"https://api.github.com/repos/cobuildlab/bazl-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cobuildlab/bazl-admin/downloads","issues_url":"https://api.github.com/repos/cobuildlab/bazl-admin/issues{/number}","pulls_url":"https://api.github.com/repos/cobuildlab/bazl-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/cobuildlab/bazl-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/cobuildlab/bazl-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cobuildlab/bazl-admin/labels{/name}","releases_url":"https://api.github.com/repos/cobuildlab/bazl-admin/releases{/id}","deployments_url":"https://api.github.com/repos/cobuildlab/bazl-admin/deployments","created_at":"2019-05-11T17:08:41Z","updated_at":"2019-10-08T01:35:46Z","pushed_at":"2019-10-11T14:37:37Z","git_url":"git://github.com/cobuildlab/bazl-admin.git","ssh_url":"[email protected]:cobuildlab/bazl-admin.git","clone_url":"https://github.com/cobuildlab/bazl-admin.git","svn_url":"https://github.com/cobuildlab/bazl-admin","homepage":null,"size":4905,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"cobuildlab:master","ref":"master","sha":"6d029583d381ca66610a500b391d91d05f28defe","user":{"login":"cobuildlab","id":41276121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMjc2MTIx","avatar_url":"https://avatars3.githubusercontent.com/u/41276121?v=4","gravatar_id":"","url":"https://api.github.com/users/cobuildlab","html_url":"https://github.com/cobuildlab","followers_url":"https://api.github.com/users/cobuildlab/followers","following_url":"https://api.github.com/users/cobuildlab/following{/other_user}","gists_url":"https://api.github.com/users/cobuildlab/gists{/gist_id}","starred_url":"https://api.github.com/users/cobuildlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cobuildlab/subscriptions","organizations_url":"https://api.github.com/users/cobuildlab/orgs","repos_url":"https://api.github.com/users/cobuildlab/repos","events_url":"https://api.github.com/users/cobuildlab/events{/privacy}","received_events_url":"https://api.github.com/users/cobuildlab/received_events","type":"Organization","site_admin":false},"repo":{"id":186160463,"node_id":"MDEwOlJlcG9zaXRvcnkxODYxNjA0NjM=","name":"bazl-admin","full_name":"cobuildlab/bazl-admin","private":false,"owner":{"login":"cobuildlab","id":41276121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMjc2MTIx","avatar_url":"https://avatars3.githubusercontent.com/u/41276121?v=4","gravatar_id":"","url":"https://api.github.com/users/cobuildlab","html_url":"https://github.com/cobuildlab","followers_url":"https://api.github.com/users/cobuildlab/followers","following_url":"https://api.github.com/users/cobuildlab/following{/other_user}","gists_url":"https://api.github.com/users/cobuildlab/gists{/gist_id}","starred_url":"https://api.github.com/users/cobuildlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cobuildlab/subscriptions","organizations_url":"https://api.github.com/users/cobuildlab/orgs","repos_url":"https://api.github.com/users/cobuildlab/repos","events_url":"https://api.github.com/users/cobuildlab/events{/privacy}","received_events_url":"https://api.github.com/users/cobuildlab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cobuildlab/bazl-admin","description":null,"fork":false,"url":"https://api.github.com/repos/cobuildlab/bazl-admin","forks_url":"https://api.github.com/repos/cobuildlab/bazl-admin/forks","keys_url":"https://api.github.com/repos/cobuildlab/bazl-admin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cobuildlab/bazl-admin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cobuildlab/bazl-admin/teams","hooks_url":"https://api.github.com/repos/cobuildlab/bazl-admin/hooks","issue_events_url":"https://api.github.com/repos/cobuildlab/bazl-admin/issues/events{/number}","events_url":"https://api.github.com/repos/cobuildlab/bazl-admin/events","assignees_url":"https://api.github.com/repos/cobuildlab/bazl-admin/assignees{/user}","branches_url":"https://api.github.com/repos/cobuildlab/bazl-admin/branches{/branch}","tags_url":"https://api.github.com/repos/cobuildlab/bazl-admin/tags","blobs_url":"https://api.github.com/repos/cobuildlab/bazl-admin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cobuildlab/bazl-admin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cobuildlab/bazl-admin/git/refs{/sha}","trees_url":"https://api.github.com/repos/cobuildlab/bazl-admin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cobuildlab/bazl-admin/statuses/{sha}","languages_url":"https://api.github.com/repos/cobuildlab/bazl-admin/languages","stargazers_url":"https://api.github.com/repos/cobuildlab/bazl-admin/stargazers","contributors_url":"https://api.github.com/repos/cobuildlab/bazl-admin/contributors","subscribers_url":"https://api.github.com/repos/cobuildlab/bazl-admin/subscribers","subscription_url":"https://api.github.com/repos/cobuildlab/bazl-admin/subscription","commits_url":"https://api.github.com/repos/cobuildlab/bazl-admin/commits{/sha}","git_commits_url":"https://api.github.com/repos/cobuildlab/bazl-admin/git/commits{/sha}","comments_url":"https://api.github.com/repos/cobuildlab/bazl-admin/comments{/number}","issue_comment_url":"https://api.github.com/repos/cobuildlab/bazl-admin/issues/comments{/number}","contents_url":"https://api.github.com/repos/cobuildlab/bazl-admin/contents/{+path}","compare_url":"https://api.github.com/repos/cobuildlab/bazl-admin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cobuildlab/bazl-admin/merges","archive_url":"https://api.github.com/repos/cobuildlab/bazl-admin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cobuildlab/bazl-admin/downloads","issues_url":"https://api.github.com/repos/cobuildlab/bazl-admin/issues{/number}","pulls_url":"https://api.github.com/repos/cobuildlab/bazl-admin/pulls{/number}","milestones_url":"https://api.github.com/repos/cobuildlab/bazl-admin/milestones{/number}","notifications_url":"https://api.github.com/repos/cobuildlab/bazl-admin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cobuildlab/bazl-admin/labels{/name}","releases_url":"https://api.github.com/repos/cobuildlab/bazl-admin/releases{/id}","deployments_url":"https://api.github.com/repos/cobuildlab/bazl-admin/deployments","created_at":"2019-05-11T17:08:41Z","updated_at":"2019-10-08T01:35:46Z","pushed_at":"2019-10-11T14:37:37Z","git_url":"git://github.com/cobuildlab/bazl-admin.git","ssh_url":"[email protected]:cobuildlab/bazl-admin.git","clone_url":"https://github.com/cobuildlab/bazl-admin.git","svn_url":"https://github.com/cobuildlab/bazl-admin","homepage":null,"size":4905,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cobuildlab/bazl-admin/pulls/140"},"html":{"href":"https://github.com/cobuildlab/bazl-admin/pull/140"},"issue":{"href":"https://api.github.com/repos/cobuildlab/bazl-admin/issues/140"},"comments":{"href":"https://api.github.com/repos/cobuildlab/bazl-admin/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/cobuildlab/bazl-admin/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/cobuildlab/bazl-admin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cobuildlab/bazl-admin/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/cobuildlab/bazl-admin/statuses/1c7cc47fa7b3bd3210228d88fafaa8a98427b2ac"}},"author_association":"COLLABORATOR"}}	{ "id": 186160463, "name": "cobuildlab/bazl-admin", "url": "https://api.github.com/repos/cobuildlab/bazl-admin" }	{ "id": 918895, "login": "alacret", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/918895?", "url": "https://api.github.com/users/alacret" }	{ "id": 41276121, "login": "cobuildlab", "gravatar_id": "", "avatar_url": "https://avatars.githubusercontent.com/u/41276121?", "url": "https://api.github.com/orgs/cobuildlab" }	2019-10-11T15:12:28	10611861628	{"actor":{"display_login":"alacret"}}