type
stringclasses 14
values | public
bool 1
class | payload
stringlengths 2
428k
| repo
dict | actor
dict | org
dict | created_at
timestamp[us] | id
stringlengths 10
11
| other
stringlengths 31
69
|
|---|---|---|---|---|---|---|---|---|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/lahja/pulls/comments/293533391","pull_request_review_id":249547773,"id":293533391,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MzUzMzM5MQ==","diff_hunk":"@@ -366,6 +383,13 @@ def serve(cls, config: ConnectionConfig) -> AsyncContextManager[\"BaseEndpoint\"]:\n \"\"\"\n ...\n \n+ @abstractmethod\n+ async def connect_to_endpoints(self, *endpoints: ConnectionConfig) -> None:","path":"lahja/base.py","position":61,"original_position":61,"commit_id":"d7912c72a4e4f3df29186e8486e0328ae0a22c30","original_commit_id":"d7912c72a4e4f3df29186e8486e0328ae0a22c30","user":{"login":"cburgdorf","id":521109,"node_id":"MDQ6VXNlcjUyMTEwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/521109?v=4","gravatar_id":"","url":"https://api.github.com/users/cburgdorf","html_url":"https://github.com/cburgdorf","followers_url":"https://api.github.com/users/cburgdorf/followers","following_url":"https://api.github.com/users/cburgdorf/following{/other_user}","gists_url":"https://api.github.com/users/cburgdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/cburgdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburgdorf/subscriptions","organizations_url":"https://api.github.com/users/cburgdorf/orgs","repos_url":"https://api.github.com/users/cburgdorf/repos","events_url":"https://api.github.com/users/cburgdorf/events{/privacy}","received_events_url":"https://api.github.com/users/cburgdorf/received_events","type":"User","site_admin":false},"body":"https://github.com/ethereum/lahja/pull/137","created_at":"2019-06-13T19:05:04Z","updated_at":"2019-06-13T19:05:04Z","html_url":"https://github.com/ethereum/lahja/pull/131#discussion_r293533391","pull_request_url":"https://api.github.com/repos/ethereum/lahja/pulls/131","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/lahja/pulls/comments/293533391"},"html":{"href":"https://github.com/ethereum/lahja/pull/131#discussion_r293533391"},"pull_request":{"href":"https://api.github.com/repos/ethereum/lahja/pulls/131"}},"in_reply_to_id":293277877},"pull_request":{"url":"https://api.github.com/repos/ethereum/lahja/pulls/131","id":287636443,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg3NjM2NDQz","html_url":"https://github.com/ethereum/lahja/pull/131","diff_url":"https://github.com/ethereum/lahja/pull/131.diff","patch_url":"https://github.com/ethereum/lahja/pull/131.patch","issue_url":"https://api.github.com/repos/ethereum/lahja/issues/131","number":131,"state":"closed","locked":false,"title":"Use context manager api for remote endpoint running","user":{"login":"pipermerriam","id":824194,"node_id":"MDQ6VXNlcjgyNDE5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/824194?v=4","gravatar_id":"","url":"https://api.github.com/users/pipermerriam","html_url":"https://github.com/pipermerriam","followers_url":"https://api.github.com/users/pipermerriam/followers","following_url":"https://api.github.com/users/pipermerriam/following{/other_user}","gists_url":"https://api.github.com/users/pipermerriam/gists{/gist_id}","starred_url":"https://api.github.com/users/pipermerriam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipermerriam/subscriptions","organizations_url":"https://api.github.com/users/pipermerriam/orgs","repos_url":"https://api.github.com/users/pipermerriam/repos","events_url":"https://api.github.com/users/pipermerriam/events{/privacy}","received_events_url":"https://api.github.com/users/pipermerriam/received_events","type":"User","site_admin":false},"body":"Builds on #130 \r\n\r\n## What was wrong?\r\n\r\nThe mechanisms for starting a background process in `trio` vs `asyncio` are not compatible. In `trio`, our `start` methods have to be passed a nursery object in order for them to be capable of starting things up and then returning.\r\n\r\nThe `BaseEndpointAPI` defined a `start` method which results in the base implementation not being compatible with what we need for the trio implementation to fit within the model.\r\n\r\n## How was it fixed?\r\n\r\nConverted it to use the same async context manager pattern as endpoints via `remote.run()`, delegating the actual startup and shutdown logic to the actual implementation.\r\n\r\n#### Cute Animal Picture\r\n\r\n\r\n\r\n","created_at":"2019-06-12T19:03:20Z","updated_at":"2019-06-13T19:05:04Z","closed_at":"2019-06-13T16:37:49Z","merged_at":"2019-06-13T16:37:49Z","merge_commit_sha":"4f73d797b1f17322db6a456010fc71abb1f05d34","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/lahja/pulls/131/commits","review_comments_url":"https://api.github.com/repos/ethereum/lahja/pulls/131/comments","review_comment_url":"https://api.github.com/repos/ethereum/lahja/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/lahja/issues/131/comments","statuses_url":"https://api.github.com/repos/ethereum/lahja/statuses/d7912c72a4e4f3df29186e8486e0328ae0a22c30","head":{"label":"pipermerriam:piper/use-context-manager-api-for-remote-endpoint-running","ref":"piper/use-context-manager-api-for-remote-endpoint-running","sha":"d7912c72a4e4f3df29186e8486e0328ae0a22c30","user":{"login":"pipermerriam","id":824194,"node_id":"MDQ6VXNlcjgyNDE5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/824194?v=4","gravatar_id":"","url":"https://api.github.com/users/pipermerriam","html_url":"https://github.com/pipermerriam","followers_url":"https://api.github.com/users/pipermerriam/followers","following_url":"https://api.github.com/users/pipermerriam/following{/other_user}","gists_url":"https://api.github.com/users/pipermerriam/gists{/gist_id}","starred_url":"https://api.github.com/users/pipermerriam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipermerriam/subscriptions","organizations_url":"https://api.github.com/users/pipermerriam/orgs","repos_url":"https://api.github.com/users/pipermerriam/repos","events_url":"https://api.github.com/users/pipermerriam/events{/privacy}","received_events_url":"https://api.github.com/users/pipermerriam/received_events","type":"User","site_admin":false},"repo":{"id":148507524,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg1MDc1MjQ=","name":"lahja","full_name":"pipermerriam/lahja","private":false,"owner":{"login":"pipermerriam","id":824194,"node_id":"MDQ6VXNlcjgyNDE5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/824194?v=4","gravatar_id":"","url":"https://api.github.com/users/pipermerriam","html_url":"https://github.com/pipermerriam","followers_url":"https://api.github.com/users/pipermerriam/followers","following_url":"https://api.github.com/users/pipermerriam/following{/other_user}","gists_url":"https://api.github.com/users/pipermerriam/gists{/gist_id}","starred_url":"https://api.github.com/users/pipermerriam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pipermerriam/subscriptions","organizations_url":"https://api.github.com/users/pipermerriam/orgs","repos_url":"https://api.github.com/users/pipermerriam/repos","events_url":"https://api.github.com/users/pipermerriam/events{/privacy}","received_events_url":"https://api.github.com/users/pipermerriam/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pipermerriam/lahja","description":"Lahja is a generic multi process event bus implementation written in Python 3.6+ to enable lightweight inter-process communication, based on non-blocking asyncio","fork":true,"url":"https://api.github.com/repos/pipermerriam/lahja","forks_url":"https://api.github.com/repos/pipermerriam/lahja/forks","keys_url":"https://api.github.com/repos/pipermerriam/lahja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pipermerriam/lahja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pipermerriam/lahja/teams","hooks_url":"https://api.github.com/repos/pipermerriam/lahja/hooks","issue_events_url":"https://api.github.com/repos/pipermerriam/lahja/issues/events{/number}","events_url":"https://api.github.com/repos/pipermerriam/lahja/events","assignees_url":"https://api.github.com/repos/pipermerriam/lahja/assignees{/user}","branches_url":"https://api.github.com/repos/pipermerriam/lahja/branches{/branch}","tags_url":"https://api.github.com/repos/pipermerriam/lahja/tags","blobs_url":"https://api.github.com/repos/pipermerriam/lahja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pipermerriam/lahja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pipermerriam/lahja/git/refs{/sha}","trees_url":"https://api.github.com/repos/pipermerriam/lahja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pipermerriam/lahja/statuses/{sha}","languages_url":"https://api.github.com/repos/pipermerriam/lahja/languages","stargazers_url":"https://api.github.com/repos/pipermerriam/lahja/stargazers","contributors_url":"https://api.github.com/repos/pipermerriam/lahja/contributors","subscribers_url":"https://api.github.com/repos/pipermerriam/lahja/subscribers","subscription_url":"https://api.github.com/repos/pipermerriam/lahja/subscription","commits_url":"https://api.github.com/repos/pipermerriam/lahja/commits{/sha}","git_commits_url":"https://api.github.com/repos/pipermerriam/lahja/git/commits{/sha}","comments_url":"https://api.github.com/repos/pipermerriam/lahja/comments{/number}","issue_comment_url":"https://api.github.com/repos/pipermerriam/lahja/issues/comments{/number}","contents_url":"https://api.github.com/repos/pipermerriam/lahja/contents/{+path}","compare_url":"https://api.github.com/repos/pipermerriam/lahja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pipermerriam/lahja/merges","archive_url":"https://api.github.com/repos/pipermerriam/lahja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pipermerriam/lahja/downloads","issues_url":"https://api.github.com/repos/pipermerriam/lahja/issues{/number}","pulls_url":"https://api.github.com/repos/pipermerriam/lahja/pulls{/number}","milestones_url":"https://api.github.com/repos/pipermerriam/lahja/milestones{/number}","notifications_url":"https://api.github.com/repos/pipermerriam/lahja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pipermerriam/lahja/labels{/name}","releases_url":"https://api.github.com/repos/pipermerriam/lahja/releases{/id}","deployments_url":"https://api.github.com/repos/pipermerriam/lahja/deployments","created_at":"2018-09-12T16:11:48Z","updated_at":"2019-04-05T19:26:33Z","pushed_at":"2019-06-13T18:24:00Z","git_url":"git://github.com/pipermerriam/lahja.git","ssh_url":"[email protected]:pipermerriam/lahja.git","clone_url":"https://github.com/pipermerriam/lahja.git","svn_url":"https://github.com/pipermerriam/lahja","homepage":"","size":460,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"e622b166526807e4d5066c0645103c14476b9f16","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":146730940,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY3MzA5NDA=","name":"lahja","full_name":"ethereum/lahja","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/lahja","description":"Lahja is a generic multi process event bus implementation written in Python 3.6+ to enable lightweight inter-process communication, based on non-blocking asyncio","fork":false,"url":"https://api.github.com/repos/ethereum/lahja","forks_url":"https://api.github.com/repos/ethereum/lahja/forks","keys_url":"https://api.github.com/repos/ethereum/lahja/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/lahja/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/lahja/teams","hooks_url":"https://api.github.com/repos/ethereum/lahja/hooks","issue_events_url":"https://api.github.com/repos/ethereum/lahja/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/lahja/events","assignees_url":"https://api.github.com/repos/ethereum/lahja/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/lahja/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/lahja/tags","blobs_url":"https://api.github.com/repos/ethereum/lahja/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/lahja/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/lahja/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/lahja/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/lahja/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/lahja/languages","stargazers_url":"https://api.github.com/repos/ethereum/lahja/stargazers","contributors_url":"https://api.github.com/repos/ethereum/lahja/contributors","subscribers_url":"https://api.github.com/repos/ethereum/lahja/subscribers","subscription_url":"https://api.github.com/repos/ethereum/lahja/subscription","commits_url":"https://api.github.com/repos/ethereum/lahja/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/lahja/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/lahja/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/lahja/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/lahja/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/lahja/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/lahja/merges","archive_url":"https://api.github.com/repos/ethereum/lahja/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/lahja/downloads","issues_url":"https://api.github.com/repos/ethereum/lahja/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/lahja/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/lahja/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/lahja/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/lahja/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/lahja/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/lahja/deployments","created_at":"2018-08-30T10:02:06Z","updated_at":"2019-06-13T16:37:51Z","pushed_at":"2019-06-13T18:46:45Z","git_url":"git://github.com/ethereum/lahja.git","ssh_url":"[email protected]:ethereum/lahja.git","clone_url":"https://github.com/ethereum/lahja.git","svn_url":"https://github.com/ethereum/lahja","homepage":"","size":350,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":30,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/lahja/pulls/131"},"html":{"href":"https://github.com/ethereum/lahja/pull/131"},"issue":{"href":"https://api.github.com/repos/ethereum/lahja/issues/131"},"comments":{"href":"https://api.github.com/repos/ethereum/lahja/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/lahja/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/lahja/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/lahja/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/lahja/statuses/d7912c72a4e4f3df29186e8486e0328ae0a22c30"}},"author_association":"MEMBER"}}
|
{
"id": 146730940,
"name": "ethereum/lahja",
"url": "https://api.github.com/repos/ethereum/lahja"
}
|
{
"id": 521109,
"login": "cburgdorf",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/521109?",
"url": "https://api.github.com/users/cburgdorf"
}
|
{
"id": 6250754,
"login": "ethereum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6250754?",
"url": "https://api.github.com/orgs/ethereum"
}
| 2019-06-13T19:05:04 |
9818376500
|
{"actor":{"display_login":"cburgdorf"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/evmone/pulls/comments/313536991","pull_request_review_id":274460182,"id":313536991,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMzUzNjk5MQ==","diff_hunk":"@@ -0,0 +1,156 @@\n+# Efficient gas calculation algorithm for EVM\n+\n+This article describes how to efficiently calculate gas and check stack requirements\n+for Ethereum Virtual Machine (EVM) instructions.\n+\n+\n+## Instructions metadata\n+\n+Let's start by defining some basic and universal instructions' parameters.\n+\n+1. Base gas cost.\n+ \n+ This is the static gas cost of instructions. Some instructions may have \n+ additional cost depending on their operand values - these have to be\n+ handled individually during the instruction execution.\n+ \n+2. Stack height requirement.\n+\n+ This is the minimum stack height (number of items on the stack) \n+ required for the instruction execution.\n+ \n+3. Stack height change.\n+\n+ This is difference of the stack height before and after the instruction \n+ execution. Can be negative if the instruction pops more items than pushes.\n+ \n+Examples:\n+\n+| opcode | base gas cost | stack height requirement | stack height change |\n+| ------- | ------------- | ------------------------ | ------------------- |\n+| ADD | 3 | 2 | -1 |\n+| EXP | 50 | 2 | -1 |\n+| DUP4 | 3 | 4 | 1 |\n+| SWAP1 | 3 | 2 | 0 |\n+| ADDRESS | 2 | 0 | 1 |\n+| CALL | 700 | 7 | -6 |\n+\n+\n+## Basic blocks\n+\n+A _basic block_ is a sequence of instructions that are executed \"straight-line\"\n+without being interrupted by jumps. I.e. they are nodes in the _control flow graph_.\n+\n+The name \"basic block\" has been taken from LLVM. Other names are: just \"block\"","path":"docs/efficient_gas_calculation_algorithm.md","position":44,"original_position":44,"commit_id":"a27be93d3bbfb497b250efe134166bd1834422a2","original_commit_id":"64c0acdfc6c4d316b95257d8719ae01a6cbe7ee3","user":{"login":"chriseth","id":9073706,"node_id":"MDQ6VXNlcjkwNzM3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/9073706?v=4","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"body":"Not sure about the well-known-ness, but llvm certainly did not introduce it :)","created_at":"2019-08-13T18:05:17Z","updated_at":"2019-08-13T18:05:17Z","html_url":"https://github.com/ethereum/evmone/pull/123#discussion_r313536991","pull_request_url":"https://api.github.com/repos/ethereum/evmone/pulls/123","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ethereum/evmone/pulls/comments/313536991"},"html":{"href":"https://github.com/ethereum/evmone/pull/123#discussion_r313536991"},"pull_request":{"href":"https://api.github.com/repos/ethereum/evmone/pulls/123"}},"in_reply_to_id":313342892},"pull_request":{"url":"https://api.github.com/repos/ethereum/evmone/pulls/123","id":306850088,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA2ODUwMDg4","html_url":"https://github.com/ethereum/evmone/pull/123","diff_url":"https://github.com/ethereum/evmone/pull/123.diff","patch_url":"https://github.com/ethereum/evmone/pull/123.patch","issue_url":"https://api.github.com/repos/ethereum/evmone/issues/123","number":123,"state":"open","locked":false,"title":"article: Efficient gas calculation algorithm for EVM","user":{"login":"chfast","id":573380,"node_id":"MDQ6VXNlcjU3MzM4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/573380?v=4","gravatar_id":"","url":"https://api.github.com/users/chfast","html_url":"https://github.com/chfast","followers_url":"https://api.github.com/users/chfast/followers","following_url":"https://api.github.com/users/chfast/following{/other_user}","gists_url":"https://api.github.com/users/chfast/gists{/gist_id}","starred_url":"https://api.github.com/users/chfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chfast/subscriptions","organizations_url":"https://api.github.com/users/chfast/orgs","repos_url":"https://api.github.com/users/chfast/repos","events_url":"https://api.github.com/users/chfast/events{/privacy}","received_events_url":"https://api.github.com/users/chfast/received_events","type":"User","site_admin":false},"body":"TODO:\r\n- [ ] Add link to the article in README","created_at":"2019-08-13T10:47:50Z","updated_at":"2019-08-13T18:05:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b0198d3c9b5457304ab9474de6b022e79184ae8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"axic","id":20340,"node_id":"MDQ6VXNlcjIwMzQw","avatar_url":"https://avatars3.githubusercontent.com/u/20340?v=4","gravatar_id":"","url":"https://api.github.com/users/axic","html_url":"https://github.com/axic","followers_url":"https://api.github.com/users/axic/followers","following_url":"https://api.github.com/users/axic/following{/other_user}","gists_url":"https://api.github.com/users/axic/gists{/gist_id}","starred_url":"https://api.github.com/users/axic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axic/subscriptions","organizations_url":"https://api.github.com/users/axic/orgs","repos_url":"https://api.github.com/users/axic/repos","events_url":"https://api.github.com/users/axic/events{/privacy}","received_events_url":"https://api.github.com/users/axic/received_events","type":"User","site_admin":false},{"login":"holiman","id":142290,"node_id":"MDQ6VXNlcjE0MjI5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/142290?v=4","gravatar_id":"","url":"https://api.github.com/users/holiman","html_url":"https://github.com/holiman","followers_url":"https://api.github.com/users/holiman/followers","following_url":"https://api.github.com/users/holiman/following{/other_user}","gists_url":"https://api.github.com/users/holiman/gists{/gist_id}","starred_url":"https://api.github.com/users/holiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holiman/subscriptions","organizations_url":"https://api.github.com/users/holiman/orgs","repos_url":"https://api.github.com/users/holiman/repos","events_url":"https://api.github.com/users/holiman/events{/privacy}","received_events_url":"https://api.github.com/users/holiman/received_events","type":"User","site_admin":false},{"login":"cdetrio","id":997681,"node_id":"MDQ6VXNlcjk5NzY4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/997681?v=4","gravatar_id":"","url":"https://api.github.com/users/cdetrio","html_url":"https://github.com/cdetrio","followers_url":"https://api.github.com/users/cdetrio/followers","following_url":"https://api.github.com/users/cdetrio/following{/other_user}","gists_url":"https://api.github.com/users/cdetrio/gists{/gist_id}","starred_url":"https://api.github.com/users/cdetrio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdetrio/subscriptions","organizations_url":"https://api.github.com/users/cdetrio/orgs","repos_url":"https://api.github.com/users/cdetrio/repos","events_url":"https://api.github.com/users/cdetrio/events{/privacy}","received_events_url":"https://api.github.com/users/cdetrio/received_events","type":"User","site_admin":false},{"login":"gumb0","id":1863135,"node_id":"MDQ6VXNlcjE4NjMxMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1863135?v=4","gravatar_id":"","url":"https://api.github.com/users/gumb0","html_url":"https://github.com/gumb0","followers_url":"https://api.github.com/users/gumb0/followers","following_url":"https://api.github.com/users/gumb0/following{/other_user}","gists_url":"https://api.github.com/users/gumb0/gists{/gist_id}","starred_url":"https://api.github.com/users/gumb0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gumb0/subscriptions","organizations_url":"https://api.github.com/users/gumb0/orgs","repos_url":"https://api.github.com/users/gumb0/repos","events_url":"https://api.github.com/users/gumb0/events{/privacy}","received_events_url":"https://api.github.com/users/gumb0/received_events","type":"User","site_admin":false},{"login":"halfalicious","id":15605026,"node_id":"MDQ6VXNlcjE1NjA1MDI2","avatar_url":"https://avatars1.githubusercontent.com/u/15605026?v=4","gravatar_id":"","url":"https://api.github.com/users/halfalicious","html_url":"https://github.com/halfalicious","followers_url":"https://api.github.com/users/halfalicious/followers","following_url":"https://api.github.com/users/halfalicious/following{/other_user}","gists_url":"https://api.github.com/users/halfalicious/gists{/gist_id}","starred_url":"https://api.github.com/users/halfalicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfalicious/subscriptions","organizations_url":"https://api.github.com/users/halfalicious/orgs","repos_url":"https://api.github.com/users/halfalicious/repos","events_url":"https://api.github.com/users/halfalicious/events{/privacy}","received_events_url":"https://api.github.com/users/halfalicious/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/evmone/pulls/123/commits","review_comments_url":"https://api.github.com/repos/ethereum/evmone/pulls/123/comments","review_comment_url":"https://api.github.com/repos/ethereum/evmone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/evmone/issues/123/comments","statuses_url":"https://api.github.com/repos/ethereum/evmone/statuses/a27be93d3bbfb497b250efe134166bd1834422a2","head":{"label":"ethereum:docs_gas_algo","ref":"docs_gas_algo","sha":"a27be93d3bbfb497b250efe134166bd1834422a2","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":160548111,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA1NDgxMTE=","name":"evmone","full_name":"ethereum/evmone","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/evmone","description":"Fast Ethereum Virtual Machine implementation","fork":false,"url":"https://api.github.com/repos/ethereum/evmone","forks_url":"https://api.github.com/repos/ethereum/evmone/forks","keys_url":"https://api.github.com/repos/ethereum/evmone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/evmone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/evmone/teams","hooks_url":"https://api.github.com/repos/ethereum/evmone/hooks","issue_events_url":"https://api.github.com/repos/ethereum/evmone/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/evmone/events","assignees_url":"https://api.github.com/repos/ethereum/evmone/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/evmone/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/evmone/tags","blobs_url":"https://api.github.com/repos/ethereum/evmone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/evmone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/evmone/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/evmone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/evmone/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/evmone/languages","stargazers_url":"https://api.github.com/repos/ethereum/evmone/stargazers","contributors_url":"https://api.github.com/repos/ethereum/evmone/contributors","subscribers_url":"https://api.github.com/repos/ethereum/evmone/subscribers","subscription_url":"https://api.github.com/repos/ethereum/evmone/subscription","commits_url":"https://api.github.com/repos/ethereum/evmone/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/evmone/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/evmone/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/evmone/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/evmone/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/evmone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/evmone/merges","archive_url":"https://api.github.com/repos/ethereum/evmone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/evmone/downloads","issues_url":"https://api.github.com/repos/ethereum/evmone/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/evmone/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/evmone/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/evmone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/evmone/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/evmone/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/evmone/deployments","created_at":"2018-12-05T16:37:26Z","updated_at":"2019-08-12T12:50:21Z","pushed_at":"2019-08-13T17:46:31Z","git_url":"git://github.com/ethereum/evmone.git","ssh_url":"[email protected]:ethereum/evmone.git","clone_url":"https://github.com/ethereum/evmone.git","svn_url":"https://github.com/ethereum/evmone","homepage":null,"size":742,"stargazers_count":41,"watchers_count":41,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":24,"watchers":41,"default_branch":"master"}},"base":{"label":"ethereum:master","ref":"master","sha":"77ebf0abbdf24d045df5bc19d2c6e7bce680da7e","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":160548111,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA1NDgxMTE=","name":"evmone","full_name":"ethereum/evmone","private":false,"owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereum/evmone","description":"Fast Ethereum Virtual Machine implementation","fork":false,"url":"https://api.github.com/repos/ethereum/evmone","forks_url":"https://api.github.com/repos/ethereum/evmone/forks","keys_url":"https://api.github.com/repos/ethereum/evmone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/evmone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/evmone/teams","hooks_url":"https://api.github.com/repos/ethereum/evmone/hooks","issue_events_url":"https://api.github.com/repos/ethereum/evmone/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/evmone/events","assignees_url":"https://api.github.com/repos/ethereum/evmone/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/evmone/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/evmone/tags","blobs_url":"https://api.github.com/repos/ethereum/evmone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/evmone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/evmone/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/evmone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/evmone/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/evmone/languages","stargazers_url":"https://api.github.com/repos/ethereum/evmone/stargazers","contributors_url":"https://api.github.com/repos/ethereum/evmone/contributors","subscribers_url":"https://api.github.com/repos/ethereum/evmone/subscribers","subscription_url":"https://api.github.com/repos/ethereum/evmone/subscription","commits_url":"https://api.github.com/repos/ethereum/evmone/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/evmone/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/evmone/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/evmone/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/evmone/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/evmone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/evmone/merges","archive_url":"https://api.github.com/repos/ethereum/evmone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/evmone/downloads","issues_url":"https://api.github.com/repos/ethereum/evmone/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/evmone/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/evmone/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/evmone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/evmone/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/evmone/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/evmone/deployments","created_at":"2018-12-05T16:37:26Z","updated_at":"2019-08-12T12:50:21Z","pushed_at":"2019-08-13T17:46:31Z","git_url":"git://github.com/ethereum/evmone.git","ssh_url":"[email protected]:ethereum/evmone.git","clone_url":"https://github.com/ethereum/evmone.git","svn_url":"https://github.com/ethereum/evmone","homepage":null,"size":742,"stargazers_count":41,"watchers_count":41,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":24,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":24,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/evmone/pulls/123"},"html":{"href":"https://github.com/ethereum/evmone/pull/123"},"issue":{"href":"https://api.github.com/repos/ethereum/evmone/issues/123"},"comments":{"href":"https://api.github.com/repos/ethereum/evmone/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/evmone/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/evmone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/evmone/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/evmone/statuses/a27be93d3bbfb497b250efe134166bd1834422a2"}},"author_association":"COLLABORATOR"}}
|
{
"id": 160548111,
"name": "ethereum/evmone",
"url": "https://api.github.com/repos/ethereum/evmone"
}
|
{
"id": 9073706,
"login": "chriseth",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9073706?",
"url": "https://api.github.com/users/chriseth"
}
|
{
"id": 6250754,
"login": "ethereum",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6250754?",
"url": "https://api.github.com/orgs/ethereum"
}
| 2019-08-13T18:05:17 |
10203646600
|
{"actor":{"display_login":"chriseth"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/taskcluster/taskcluster/pulls/comments/270977960","pull_request_review_id":221251579,"id":270977960,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3MDk3Nzk2MA==","diff_hunk":"@@ -32,7 +32,7 @@ during the cluster build process:\n ```\n \n This is a subset of the\n-[taskcluster-lib-docs](https://github.com/taskcluster/taskcluster-lib-docs)\n+[taskcluster-lib-docs](https://github.com/taskcluster/taskcluster/tree/master/libraries/loader)","path":"libraries/references/README.md","position":14,"original_position":14,"commit_id":"5b8166c3bb975b5b53859673b18ba08a687a6912","original_commit_id":"5b8166c3bb975b5b53859673b18ba08a687a6912","user":{"login":"djmitche","id":28673,"node_id":"MDQ6VXNlcjI4Njcz","avatar_url":"https://avatars3.githubusercontent.com/u/28673?v=4","gravatar_id":"","url":"https://api.github.com/users/djmitche","html_url":"https://github.com/djmitche","followers_url":"https://api.github.com/users/djmitche/followers","following_url":"https://api.github.com/users/djmitche/following{/other_user}","gists_url":"https://api.github.com/users/djmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/djmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmitche/subscriptions","organizations_url":"https://api.github.com/users/djmitche/orgs","repos_url":"https://api.github.com/users/djmitche/repos","events_url":"https://api.github.com/users/djmitche/events{/privacy}","received_events_url":"https://api.github.com/users/djmitche/received_events","type":"User","site_admin":false},"body":"docs, not loader","created_at":"2019-04-01T17:43:19Z","updated_at":"2019-04-01T17:48:26Z","html_url":"https://github.com/taskcluster/taskcluster/pull/516#discussion_r270977960","pull_request_url":"https://api.github.com/repos/taskcluster/taskcluster/pulls/516","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster/pulls/comments/270977960"},"html":{"href":"https://github.com/taskcluster/taskcluster/pull/516#discussion_r270977960"},"pull_request":{"href":"https://api.github.com/repos/taskcluster/taskcluster/pulls/516"}}},"pull_request":{"url":"https://api.github.com/repos/taskcluster/taskcluster/pulls/516","id":265962488,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY1OTYyNDg4","html_url":"https://github.com/taskcluster/taskcluster/pull/516","diff_url":"https://github.com/taskcluster/taskcluster/pull/516.diff","patch_url":"https://github.com/taskcluster/taskcluster/pull/516.patch","issue_url":"https://api.github.com/repos/taskcluster/taskcluster/issues/516","number":516,"state":"open","locked":false,"title":"Updated the links bug #443","user":{"login":"sudipt1999","id":38929617,"node_id":"MDQ6VXNlcjM4OTI5NjE3","avatar_url":"https://avatars1.githubusercontent.com/u/38929617?v=4","gravatar_id":"","url":"https://api.github.com/users/sudipt1999","html_url":"https://github.com/sudipt1999","followers_url":"https://api.github.com/users/sudipt1999/followers","following_url":"https://api.github.com/users/sudipt1999/following{/other_user}","gists_url":"https://api.github.com/users/sudipt1999/gists{/gist_id}","starred_url":"https://api.github.com/users/sudipt1999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudipt1999/subscriptions","organizations_url":"https://api.github.com/users/sudipt1999/orgs","repos_url":"https://api.github.com/users/sudipt1999/repos","events_url":"https://api.github.com/users/sudipt1999/events{/privacy}","received_events_url":"https://api.github.com/users/sudipt1999/received_events","type":"User","site_admin":false},"body":"Almost all links are updated ! Still a second cross check would be helpful!\r\nhttps://github.com/taskcluster/taskcluster-lib-azure/releases in azure README.md\r\nhttps://github.com/taskcluster/schema-validator-publisher/blob/master/package.json in valida README.md\r\nthese links are still need to be updated ! couldn't find the updated links!","created_at":"2019-03-30T19:24:16Z","updated_at":"2019-04-01T17:48:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/taskcluster/taskcluster/pulls/516/commits","review_comments_url":"https://api.github.com/repos/taskcluster/taskcluster/pulls/516/comments","review_comment_url":"https://api.github.com/repos/taskcluster/taskcluster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster/issues/516/comments","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster/statuses/5b8166c3bb975b5b53859673b18ba08a687a6912","head":{"label":"sudipt1999:doc","ref":"doc","sha":"5b8166c3bb975b5b53859673b18ba08a687a6912","user":{"login":"sudipt1999","id":38929617,"node_id":"MDQ6VXNlcjM4OTI5NjE3","avatar_url":"https://avatars1.githubusercontent.com/u/38929617?v=4","gravatar_id":"","url":"https://api.github.com/users/sudipt1999","html_url":"https://github.com/sudipt1999","followers_url":"https://api.github.com/users/sudipt1999/followers","following_url":"https://api.github.com/users/sudipt1999/following{/other_user}","gists_url":"https://api.github.com/users/sudipt1999/gists{/gist_id}","starred_url":"https://api.github.com/users/sudipt1999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudipt1999/subscriptions","organizations_url":"https://api.github.com/users/sudipt1999/orgs","repos_url":"https://api.github.com/users/sudipt1999/repos","events_url":"https://api.github.com/users/sudipt1999/events{/privacy}","received_events_url":"https://api.github.com/users/sudipt1999/received_events","type":"User","site_admin":false},"repo":{"id":170169600,"node_id":"MDEwOlJlcG9zaXRvcnkxNzAxNjk2MDA=","name":"taskcluster","full_name":"sudipt1999/taskcluster","private":false,"owner":{"login":"sudipt1999","id":38929617,"node_id":"MDQ6VXNlcjM4OTI5NjE3","avatar_url":"https://avatars1.githubusercontent.com/u/38929617?v=4","gravatar_id":"","url":"https://api.github.com/users/sudipt1999","html_url":"https://github.com/sudipt1999","followers_url":"https://api.github.com/users/sudipt1999/followers","following_url":"https://api.github.com/users/sudipt1999/following{/other_user}","gists_url":"https://api.github.com/users/sudipt1999/gists{/gist_id}","starred_url":"https://api.github.com/users/sudipt1999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudipt1999/subscriptions","organizations_url":"https://api.github.com/users/sudipt1999/orgs","repos_url":"https://api.github.com/users/sudipt1999/repos","events_url":"https://api.github.com/users/sudipt1999/events{/privacy}","received_events_url":"https://api.github.com/users/sudipt1999/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sudipt1999/taskcluster","description":" Framework that supports Mozilla's continuous integration and release processes.","fork":true,"url":"https://api.github.com/repos/sudipt1999/taskcluster","forks_url":"https://api.github.com/repos/sudipt1999/taskcluster/forks","keys_url":"https://api.github.com/repos/sudipt1999/taskcluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sudipt1999/taskcluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sudipt1999/taskcluster/teams","hooks_url":"https://api.github.com/repos/sudipt1999/taskcluster/hooks","issue_events_url":"https://api.github.com/repos/sudipt1999/taskcluster/issues/events{/number}","events_url":"https://api.github.com/repos/sudipt1999/taskcluster/events","assignees_url":"https://api.github.com/repos/sudipt1999/taskcluster/assignees{/user}","branches_url":"https://api.github.com/repos/sudipt1999/taskcluster/branches{/branch}","tags_url":"https://api.github.com/repos/sudipt1999/taskcluster/tags","blobs_url":"https://api.github.com/repos/sudipt1999/taskcluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sudipt1999/taskcluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sudipt1999/taskcluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/sudipt1999/taskcluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sudipt1999/taskcluster/statuses/{sha}","languages_url":"https://api.github.com/repos/sudipt1999/taskcluster/languages","stargazers_url":"https://api.github.com/repos/sudipt1999/taskcluster/stargazers","contributors_url":"https://api.github.com/repos/sudipt1999/taskcluster/contributors","subscribers_url":"https://api.github.com/repos/sudipt1999/taskcluster/subscribers","subscription_url":"https://api.github.com/repos/sudipt1999/taskcluster/subscription","commits_url":"https://api.github.com/repos/sudipt1999/taskcluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/sudipt1999/taskcluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/sudipt1999/taskcluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/sudipt1999/taskcluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/sudipt1999/taskcluster/contents/{+path}","compare_url":"https://api.github.com/repos/sudipt1999/taskcluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sudipt1999/taskcluster/merges","archive_url":"https://api.github.com/repos/sudipt1999/taskcluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sudipt1999/taskcluster/downloads","issues_url":"https://api.github.com/repos/sudipt1999/taskcluster/issues{/number}","pulls_url":"https://api.github.com/repos/sudipt1999/taskcluster/pulls{/number}","milestones_url":"https://api.github.com/repos/sudipt1999/taskcluster/milestones{/number}","notifications_url":"https://api.github.com/repos/sudipt1999/taskcluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sudipt1999/taskcluster/labels{/name}","releases_url":"https://api.github.com/repos/sudipt1999/taskcluster/releases{/id}","deployments_url":"https://api.github.com/repos/sudipt1999/taskcluster/deployments","created_at":"2019-02-11T17:17:30Z","updated_at":"2019-03-21T22:25:27Z","pushed_at":"2019-03-30T19:21:11Z","git_url":"git://github.com/sudipt1999/taskcluster.git","ssh_url":"[email protected]:sudipt1999/taskcluster.git","clone_url":"https://github.com/sudipt1999/taskcluster.git","svn_url":"https://github.com/sudipt1999/taskcluster","homepage":"https://docs.taskcluster.net/docs","size":27495,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"taskcluster:master","ref":"master","sha":"0c36f07794ab4e074579eacf4ab6c13e262a852c","user":{"login":"taskcluster","id":6257436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTc0MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":161867312,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE4NjczMTI=","name":"taskcluster","full_name":"taskcluster/taskcluster","private":false,"owner":{"login":"taskcluster","id":6257436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTc0MzY=","avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/taskcluster/taskcluster","description":" Framework that supports Mozilla's continuous integration and release processes.","fork":false,"url":"https://api.github.com/repos/taskcluster/taskcluster","forks_url":"https://api.github.com/repos/taskcluster/taskcluster/forks","keys_url":"https://api.github.com/repos/taskcluster/taskcluster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/taskcluster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/taskcluster/teams","hooks_url":"https://api.github.com/repos/taskcluster/taskcluster/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/taskcluster/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/taskcluster/events","assignees_url":"https://api.github.com/repos/taskcluster/taskcluster/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/taskcluster/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/taskcluster/tags","blobs_url":"https://api.github.com/repos/taskcluster/taskcluster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/taskcluster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/taskcluster/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/taskcluster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/taskcluster/languages","stargazers_url":"https://api.github.com/repos/taskcluster/taskcluster/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/taskcluster/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/taskcluster/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/taskcluster/subscription","commits_url":"https://api.github.com/repos/taskcluster/taskcluster/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/taskcluster/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/taskcluster/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/taskcluster/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/taskcluster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/taskcluster/merges","archive_url":"https://api.github.com/repos/taskcluster/taskcluster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/taskcluster/downloads","issues_url":"https://api.github.com/repos/taskcluster/taskcluster/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/taskcluster/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/taskcluster/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/taskcluster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/taskcluster/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/taskcluster/releases{/id}","deployments_url":"https://api.github.com/repos/taskcluster/taskcluster/deployments","created_at":"2018-12-15T03:48:26Z","updated_at":"2019-04-01T17:08:05Z","pushed_at":"2019-04-01T17:46:25Z","git_url":"git://github.com/taskcluster/taskcluster.git","ssh_url":"[email protected]:taskcluster/taskcluster.git","clone_url":"https://github.com/taskcluster/taskcluster.git","svn_url":"https://github.com/taskcluster/taskcluster","homepage":"https://docs.taskcluster.net/docs","size":28046,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":37,"open_issues":64,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster/pulls/516"},"html":{"href":"https://github.com/taskcluster/taskcluster/pull/516"},"issue":{"href":"https://api.github.com/repos/taskcluster/taskcluster/issues/516"},"comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster/issues/516/comments"},"review_comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster/pulls/516/comments"},"review_comment":{"href":"https://api.github.com/repos/taskcluster/taskcluster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/taskcluster/taskcluster/pulls/516/commits"},"statuses":{"href":"https://api.github.com/repos/taskcluster/taskcluster/statuses/5b8166c3bb975b5b53859673b18ba08a687a6912"}},"author_association":"COLLABORATOR"}}
|
{
"id": 161867312,
"name": "taskcluster/taskcluster",
"url": "https://api.github.com/repos/taskcluster/taskcluster"
}
|
{
"id": 28673,
"login": "djmitche",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28673?",
"url": "https://api.github.com/users/djmitche"
}
|
{
"id": 6257436,
"login": "taskcluster",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6257436?",
"url": "https://api.github.com/orgs/taskcluster"
}
| 2019-04-01T17:43:19 |
9355821440
|
{"actor":{"display_login":"djmitche"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/storj/storj/pulls/comments/295805817","pull_request_review_id":252289897,"id":295805817,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NTgwNTgxNw==","diff_hunk":"@@ -92,6 +90,16 @@ type UpdateRequest struct {\n \tNodeID storj.NodeID\n \tAuditSuccess bool\n \tIsUp bool\n+\n+\t// n.b. these are set values from the satellite.\n+\t// They are part of the UpdateRequest struct in order to be\n+\t// more easily accessible in satellite/satellitedb/overlaycache.go.\n+\tAuditLambda float64","path":"pkg/overlay/cache.go","position":27,"original_position":27,"commit_id":"b638d2560af0ca98d004443c4fb85e5adcec2e7e","original_commit_id":"b638d2560af0ca98d004443c4fb85e5adcec2e7e","user":{"login":"navillasa","id":26885324,"node_id":"MDQ6VXNlcjI2ODg1MzI0","avatar_url":"https://avatars2.githubusercontent.com/u/26885324?v=4","gravatar_id":"","url":"https://api.github.com/users/navillasa","html_url":"https://github.com/navillasa","followers_url":"https://api.github.com/users/navillasa/followers","following_url":"https://api.github.com/users/navillasa/following{/other_user}","gists_url":"https://api.github.com/users/navillasa/gists{/gist_id}","starred_url":"https://api.github.com/users/navillasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navillasa/subscriptions","organizations_url":"https://api.github.com/users/navillasa/orgs","repos_url":"https://api.github.com/users/navillasa/repos","events_url":"https://api.github.com/users/navillasa/events{/privacy}","received_events_url":"https://api.github.com/users/navillasa/received_events","type":"User","site_admin":false},"body":"yeah the issue is that the two cache structs are different. foiled by wrapper functions once again!","created_at":"2019-06-20T13:29:27Z","updated_at":"2019-06-20T13:29:27Z","html_url":"https://github.com/storj/storj/pull/2227#discussion_r295805817","pull_request_url":"https://api.github.com/repos/storj/storj/pulls/2227","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/storj/storj/pulls/comments/295805817"},"html":{"href":"https://github.com/storj/storj/pull/2227#discussion_r295805817"},"pull_request":{"href":"https://api.github.com/repos/storj/storj/pulls/2227"}},"in_reply_to_id":295671153},"pull_request":{"url":"https://api.github.com/repos/storj/storj/pulls/2227","id":289025312,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5MDI1MzEy","html_url":"https://github.com/storj/storj/pull/2227","diff_url":"https://github.com/storj/storj/pull/2227.diff","patch_url":"https://github.com/storj/storj/pull/2227.patch","issue_url":"https://api.github.com/repos/storj/storj/issues/2227","number":2227,"state":"open","locked":false,"title":"incorporate new reputation model into overlay cache methods","user":{"login":"navillasa","id":26885324,"node_id":"MDQ6VXNlcjI2ODg1MzI0","avatar_url":"https://avatars2.githubusercontent.com/u/26885324?v=4","gravatar_id":"","url":"https://api.github.com/users/navillasa","html_url":"https://github.com/navillasa","followers_url":"https://api.github.com/users/navillasa/followers","following_url":"https://api.github.com/users/navillasa/following{/other_user}","gists_url":"https://api.github.com/users/navillasa/gists{/gist_id}","starred_url":"https://api.github.com/users/navillasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/navillasa/subscriptions","organizations_url":"https://api.github.com/users/navillasa/orgs","repos_url":"https://api.github.com/users/navillasa/repos","events_url":"https://api.github.com/users/navillasa/events{/privacy}","received_events_url":"https://api.github.com/users/navillasa/received_events","type":"User","site_admin":false},"body":"What: \r\n- This PR incorporates new node reputation calculations as well as disqualification into pkg/overlay/cache.go and satellite/satellitedb/overlaycache.go.\r\n\r\nWhy:\r\n- We want the overlay cache to use the new reputation model for node selection and not the old way.\r\n- **Note** that the way NodeSelectionConfig values are passed around (specifically alpha, beta, lambda, and weight values) is not ideal right now, but we think this is the path of least resistance in working with the existing cache methods in pkg/overlay/cache.go and satellite/satellitedb/overlaycache.go. We do think a refactor for better propagation of NodeSelectionConfig values will be due after this PR though.\r\n\r\nThanks for submitting a PR!\r\n\r\n## Code Review Checklist (to be filled out by reviewer)\r\n - [ ] Does the PR describe what changes are being made?\r\n - [ ] Does the PR describe why the changes are being made?\r\n - [ ] Does the code follow [our style guide](https://github.com/storj/docs/blob/master/code/Style.md)?\r\n - [ ] Does the code follow [our testing guide](https://github.com/storj/docs/blob/master/code/Testing.md)?\r\n - [ ] Could the PR be broken into smaller PRs?\r\n - [ ] Does the new code have enough tests? (*every* PR should have tests or justification otherwise. Bug-fix PRs especially)\r\n - [ ] Does the new code have enough documentation that answers \"how do I use it?\" and \"what does it do?\"? (both source documentation and [higher level](https://github.com/storj/docs), diagrams?)\r\n - [ ] Does any documentation need updating?\r\n","created_at":"2019-06-17T21:21:50Z","updated_at":"2019-06-20T13:29:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"174deb538495099221308210fb1b4cb205ef1863","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1077048580,"node_id":"MDU6TGFiZWwxMDc3MDQ4NTgw","url":"https://api.github.com/repos/storj/storj/labels/Request%20Code%20Review","name":"Request Code Review","color":"80edbf","default":false},{"id":982933521,"node_id":"MDU6TGFiZWw5ODI5MzM1MjE=","url":"https://api.github.com/repos/storj/storj/labels/cla-signed","name":"cla-signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/storj/storj/pulls/2227/commits","review_comments_url":"https://api.github.com/repos/storj/storj/pulls/2227/comments","review_comment_url":"https://api.github.com/repos/storj/storj/pulls/comments{/number}","comments_url":"https://api.github.com/repos/storj/storj/issues/2227/comments","statuses_url":"https://api.github.com/repos/storj/storj/statuses/b638d2560af0ca98d004443c4fb85e5adcec2e7e","head":{"label":"storj:nv/noderep","ref":"nv/noderep","sha":"b638d2560af0ca98d004443c4fb85e5adcec2e7e","user":{"login":"storj","id":6308081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMDgwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/6308081?v=4","gravatar_id":"","url":"https://api.github.com/users/storj","html_url":"https://github.com/storj","followers_url":"https://api.github.com/users/storj/followers","following_url":"https://api.github.com/users/storj/following{/other_user}","gists_url":"https://api.github.com/users/storj/gists{/gist_id}","starred_url":"https://api.github.com/users/storj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storj/subscriptions","organizations_url":"https://api.github.com/users/storj/orgs","repos_url":"https://api.github.com/users/storj/repos","events_url":"https://api.github.com/users/storj/events{/privacy}","received_events_url":"https://api.github.com/users/storj/received_events","type":"Organization","site_admin":false},"repo":{"id":128089774,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgwODk3NzQ=","name":"storj","full_name":"storj/storj","private":false,"owner":{"login":"storj","id":6308081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMDgwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/6308081?v=4","gravatar_id":"","url":"https://api.github.com/users/storj","html_url":"https://github.com/storj","followers_url":"https://api.github.com/users/storj/followers","following_url":"https://api.github.com/users/storj/following{/other_user}","gists_url":"https://api.github.com/users/storj/gists{/gist_id}","starred_url":"https://api.github.com/users/storj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storj/subscriptions","organizations_url":"https://api.github.com/users/storj/orgs","repos_url":"https://api.github.com/users/storj/repos","events_url":"https://api.github.com/users/storj/events{/privacy}","received_events_url":"https://api.github.com/users/storj/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/storj/storj","description":"Ongoing Storj v3 development. Decentralized cloud object storage that is affordable, easy to use, private, and secure.","fork":false,"url":"https://api.github.com/repos/storj/storj","forks_url":"https://api.github.com/repos/storj/storj/forks","keys_url":"https://api.github.com/repos/storj/storj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/storj/storj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/storj/storj/teams","hooks_url":"https://api.github.com/repos/storj/storj/hooks","issue_events_url":"https://api.github.com/repos/storj/storj/issues/events{/number}","events_url":"https://api.github.com/repos/storj/storj/events","assignees_url":"https://api.github.com/repos/storj/storj/assignees{/user}","branches_url":"https://api.github.com/repos/storj/storj/branches{/branch}","tags_url":"https://api.github.com/repos/storj/storj/tags","blobs_url":"https://api.github.com/repos/storj/storj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/storj/storj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/storj/storj/git/refs{/sha}","trees_url":"https://api.github.com/repos/storj/storj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/storj/storj/statuses/{sha}","languages_url":"https://api.github.com/repos/storj/storj/languages","stargazers_url":"https://api.github.com/repos/storj/storj/stargazers","contributors_url":"https://api.github.com/repos/storj/storj/contributors","subscribers_url":"https://api.github.com/repos/storj/storj/subscribers","subscription_url":"https://api.github.com/repos/storj/storj/subscription","commits_url":"https://api.github.com/repos/storj/storj/commits{/sha}","git_commits_url":"https://api.github.com/repos/storj/storj/git/commits{/sha}","comments_url":"https://api.github.com/repos/storj/storj/comments{/number}","issue_comment_url":"https://api.github.com/repos/storj/storj/issues/comments{/number}","contents_url":"https://api.github.com/repos/storj/storj/contents/{+path}","compare_url":"https://api.github.com/repos/storj/storj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/storj/storj/merges","archive_url":"https://api.github.com/repos/storj/storj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/storj/storj/downloads","issues_url":"https://api.github.com/repos/storj/storj/issues{/number}","pulls_url":"https://api.github.com/repos/storj/storj/pulls{/number}","milestones_url":"https://api.github.com/repos/storj/storj/milestones{/number}","notifications_url":"https://api.github.com/repos/storj/storj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/storj/storj/labels{/name}","releases_url":"https://api.github.com/repos/storj/storj/releases{/id}","deployments_url":"https://api.github.com/repos/storj/storj/deployments","created_at":"2018-04-04T16:27:18Z","updated_at":"2019-06-20T13:17:03Z","pushed_at":"2019-06-20T13:29:12Z","git_url":"git://github.com/storj/storj.git","ssh_url":"[email protected]:storj/storj.git","clone_url":"https://github.com/storj/storj.git","svn_url":"https://github.com/storj/storj","homepage":"https://storj.io","size":83508,"stargazers_count":692,"watchers_count":692,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":87,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":159,"open_issues":87,"watchers":692,"default_branch":"master"}},"base":{"label":"storj:master","ref":"master","sha":"d583ab707bca0d4c7d13412c4e3e829a65ac731c","user":{"login":"storj","id":6308081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMDgwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/6308081?v=4","gravatar_id":"","url":"https://api.github.com/users/storj","html_url":"https://github.com/storj","followers_url":"https://api.github.com/users/storj/followers","following_url":"https://api.github.com/users/storj/following{/other_user}","gists_url":"https://api.github.com/users/storj/gists{/gist_id}","starred_url":"https://api.github.com/users/storj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storj/subscriptions","organizations_url":"https://api.github.com/users/storj/orgs","repos_url":"https://api.github.com/users/storj/repos","events_url":"https://api.github.com/users/storj/events{/privacy}","received_events_url":"https://api.github.com/users/storj/received_events","type":"Organization","site_admin":false},"repo":{"id":128089774,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgwODk3NzQ=","name":"storj","full_name":"storj/storj","private":false,"owner":{"login":"storj","id":6308081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMDgwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/6308081?v=4","gravatar_id":"","url":"https://api.github.com/users/storj","html_url":"https://github.com/storj","followers_url":"https://api.github.com/users/storj/followers","following_url":"https://api.github.com/users/storj/following{/other_user}","gists_url":"https://api.github.com/users/storj/gists{/gist_id}","starred_url":"https://api.github.com/users/storj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storj/subscriptions","organizations_url":"https://api.github.com/users/storj/orgs","repos_url":"https://api.github.com/users/storj/repos","events_url":"https://api.github.com/users/storj/events{/privacy}","received_events_url":"https://api.github.com/users/storj/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/storj/storj","description":"Ongoing Storj v3 development. Decentralized cloud object storage that is affordable, easy to use, private, and secure.","fork":false,"url":"https://api.github.com/repos/storj/storj","forks_url":"https://api.github.com/repos/storj/storj/forks","keys_url":"https://api.github.com/repos/storj/storj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/storj/storj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/storj/storj/teams","hooks_url":"https://api.github.com/repos/storj/storj/hooks","issue_events_url":"https://api.github.com/repos/storj/storj/issues/events{/number}","events_url":"https://api.github.com/repos/storj/storj/events","assignees_url":"https://api.github.com/repos/storj/storj/assignees{/user}","branches_url":"https://api.github.com/repos/storj/storj/branches{/branch}","tags_url":"https://api.github.com/repos/storj/storj/tags","blobs_url":"https://api.github.com/repos/storj/storj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/storj/storj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/storj/storj/git/refs{/sha}","trees_url":"https://api.github.com/repos/storj/storj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/storj/storj/statuses/{sha}","languages_url":"https://api.github.com/repos/storj/storj/languages","stargazers_url":"https://api.github.com/repos/storj/storj/stargazers","contributors_url":"https://api.github.com/repos/storj/storj/contributors","subscribers_url":"https://api.github.com/repos/storj/storj/subscribers","subscription_url":"https://api.github.com/repos/storj/storj/subscription","commits_url":"https://api.github.com/repos/storj/storj/commits{/sha}","git_commits_url":"https://api.github.com/repos/storj/storj/git/commits{/sha}","comments_url":"https://api.github.com/repos/storj/storj/comments{/number}","issue_comment_url":"https://api.github.com/repos/storj/storj/issues/comments{/number}","contents_url":"https://api.github.com/repos/storj/storj/contents/{+path}","compare_url":"https://api.github.com/repos/storj/storj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/storj/storj/merges","archive_url":"https://api.github.com/repos/storj/storj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/storj/storj/downloads","issues_url":"https://api.github.com/repos/storj/storj/issues{/number}","pulls_url":"https://api.github.com/repos/storj/storj/pulls{/number}","milestones_url":"https://api.github.com/repos/storj/storj/milestones{/number}","notifications_url":"https://api.github.com/repos/storj/storj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/storj/storj/labels{/name}","releases_url":"https://api.github.com/repos/storj/storj/releases{/id}","deployments_url":"https://api.github.com/repos/storj/storj/deployments","created_at":"2018-04-04T16:27:18Z","updated_at":"2019-06-20T13:17:03Z","pushed_at":"2019-06-20T13:29:12Z","git_url":"git://github.com/storj/storj.git","ssh_url":"[email protected]:storj/storj.git","clone_url":"https://github.com/storj/storj.git","svn_url":"https://github.com/storj/storj","homepage":"https://storj.io","size":83508,"stargazers_count":692,"watchers_count":692,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":87,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":159,"open_issues":87,"watchers":692,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/storj/storj/pulls/2227"},"html":{"href":"https://github.com/storj/storj/pull/2227"},"issue":{"href":"https://api.github.com/repos/storj/storj/issues/2227"},"comments":{"href":"https://api.github.com/repos/storj/storj/issues/2227/comments"},"review_comments":{"href":"https://api.github.com/repos/storj/storj/pulls/2227/comments"},"review_comment":{"href":"https://api.github.com/repos/storj/storj/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/storj/storj/pulls/2227/commits"},"statuses":{"href":"https://api.github.com/repos/storj/storj/statuses/b638d2560af0ca98d004443c4fb85e5adcec2e7e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 128089774,
"name": "storj/storj",
"url": "https://api.github.com/repos/storj/storj"
}
|
{
"id": 26885324,
"login": "navillasa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26885324?",
"url": "https://api.github.com/users/navillasa"
}
|
{
"id": 6308081,
"login": "storj",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6308081?",
"url": "https://api.github.com/orgs/storj"
}
| 2019-06-20T13:29:27 |
9860928435
|
{"actor":{"display_login":"navillasa"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/storj/storj/pulls/comments/275272164","pull_request_review_id":226534746,"id":275272164,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTI3MjE2NA==","diff_hunk":"@@ -321,3 +323,73 @@ func (rt *RoutingTable) ConnSuccess(ctx context.Context, node *pb.Node) {\n \t\tzap.L().Debug(\"connection success error:\", zap.Error(err))\n \t}\n }\n+\n+func splitBucket(bIDs []bucketID, bitDepth int) ([]bucketID, []bucketID) {\n+\tvar b0 []bucketID\n+\tvar b1 []bucketID\n+\n+\tfor _, bID := range bIDs {\n+\t\tbyteDepth := bitDepth / 8\n+\t\tbitOffset := bitDepth % 8\n+\t\tpower := uint(7 - bitOffset)\n+\t\tbitMask := byte(1 << power)\n+\t\tb := bID[byteDepth]\n+\t\tif b&bitMask > 0 {\n+\t\t\tb1 = append(b1, bID)\n+\t\t} else {\n+\t\t\tb0 = append(b0, bID)\n+\t\t}\n+\t}\n+\treturn b0, b1\n+}\n+\n+// Prints the routing table graph as a dot graph in specified buffer","path":"pkg/kademlia/routing.go","position":35,"original_position":35,"commit_id":"4bdced6801d80daba4f2dd5cce8e06ee956cc60a","original_commit_id":"4bdced6801d80daba4f2dd5cce8e06ee956cc60a","user":{"login":"kaloyan-raev","id":468091,"node_id":"MDQ6VXNlcjQ2ODA5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/468091?v=4","gravatar_id":"","url":"https://api.github.com/users/kaloyan-raev","html_url":"https://github.com/kaloyan-raev","followers_url":"https://api.github.com/users/kaloyan-raev/followers","following_url":"https://api.github.com/users/kaloyan-raev/following{/other_user}","gists_url":"https://api.github.com/users/kaloyan-raev/gists{/gist_id}","starred_url":"https://api.github.com/users/kaloyan-raev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaloyan-raev/subscriptions","organizations_url":"https://api.github.com/users/kaloyan-raev/orgs","repos_url":"https://api.github.com/users/kaloyan-raev/repos","events_url":"https://api.github.com/users/kaloyan-raev/events{/privacy}","received_events_url":"https://api.github.com/users/kaloyan-raev/received_events","type":"User","site_admin":false},"body":"The doc comment must start with the word `BufferedGraph`. Otherwise, the linter will keep complaining.","created_at":"2019-04-15T09:18:21Z","updated_at":"2019-04-15T09:18:22Z","html_url":"https://github.com/storj/storj/pull/1732#discussion_r275272164","pull_request_url":"https://api.github.com/repos/storj/storj/pulls/1732","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/storj/storj/pulls/comments/275272164"},"html":{"href":"https://github.com/storj/storj/pull/1732#discussion_r275272164"},"pull_request":{"href":"https://api.github.com/repos/storj/storj/pulls/1732"}}},"pull_request":{"url":"https://api.github.com/repos/storj/storj/pulls/1732","id":269166550,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY5MTY2NTUw","html_url":"https://github.com/storj/storj/pull/1732","diff_url":"https://github.com/storj/storj/pull/1732.diff","patch_url":"https://github.com/storj/storj/pull/1732.patch","issue_url":"https://api.github.com/repos/storj/storj/issues/1732","number":1732,"state":"open","locked":false,"title":"Inspector draw routing table","user":{"login":"Fadila82","id":17983871,"node_id":"MDQ6VXNlcjE3OTgzODcx","avatar_url":"https://avatars2.githubusercontent.com/u/17983871?v=4","gravatar_id":"","url":"https://api.github.com/users/Fadila82","html_url":"https://github.com/Fadila82","followers_url":"https://api.github.com/users/Fadila82/followers","following_url":"https://api.github.com/users/Fadila82/following{/other_user}","gists_url":"https://api.github.com/users/Fadila82/gists{/gist_id}","starred_url":"https://api.github.com/users/Fadila82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fadila82/subscriptions","organizations_url":"https://api.github.com/users/Fadila82/orgs","repos_url":"https://api.github.com/users/Fadila82/repos","events_url":"https://api.github.com/users/Fadila82/events{/privacy}","received_events_url":"https://api.github.com/users/Fadila82/received_events","type":"User","site_admin":false},"body":"What: \r\nAdd capability to inspector to ask a local node to draw its routing table graph.\r\nWhen the command \"inspector kad routing-graph <node-id>\" is called, it saves the routing table graph as a dot file named routing-graph-<node-id>.dot\r\n\r\nhttps://storjlabs.atlassian.net/browse/V3-1078\r\n\r\nThanks for submitting a PR!\r\n\r\n\r\n\r\n## Code Review Checklist (to be filled out by reviewer)\r\n - [ ] Does the PR describe what changes are being made?\r\n - [ ] Does the PR describe why the changes are being made?\r\n - [ ] Does the code follow [our style guide](https://github.com/storj/docs/blob/master/code/Style.md)?\r\n - [ ] Does the code follow [our testing guide](https://github.com/storj/docs/blob/master/code/Testing.md)?\r\n - [ ] Could the PR be broken into smaller PRs?\r\n - [ ] Does the new code have enough tests? (*every* PR should have tests or justification otherwise. Bug-fix PRs especially)\r\n - [ ] Does the new code have enough documentation that answers \"how do I use it?\" and \"what does it do?\"? (both source documentation and [higher level](https://github.com/storj/docs), diagrams?)\r\n - [ ] Does any documentation need updating?\r\n","created_at":"2019-04-10T13:35:24Z","updated_at":"2019-04-15T09:18:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdbfbf044f00fa978e277914c999a15c029cd427","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jenlij","id":12438950,"node_id":"MDQ6VXNlcjEyNDM4OTUw","avatar_url":"https://avatars0.githubusercontent.com/u/12438950?v=4","gravatar_id":"","url":"https://api.github.com/users/jenlij","html_url":"https://github.com/jenlij","followers_url":"https://api.github.com/users/jenlij/followers","following_url":"https://api.github.com/users/jenlij/following{/other_user}","gists_url":"https://api.github.com/users/jenlij/gists{/gist_id}","starred_url":"https://api.github.com/users/jenlij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenlij/subscriptions","organizations_url":"https://api.github.com/users/jenlij/orgs","repos_url":"https://api.github.com/users/jenlij/repos","events_url":"https://api.github.com/users/jenlij/events{/privacy}","received_events_url":"https://api.github.com/users/jenlij/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":982933521,"node_id":"MDU6TGFiZWw5ODI5MzM1MjE=","url":"https://api.github.com/repos/storj/storj/labels/cla-signed","name":"cla-signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/storj/storj/pulls/1732/commits","review_comments_url":"https://api.github.com/repos/storj/storj/pulls/1732/comments","review_comment_url":"https://api.github.com/repos/storj/storj/pulls/comments{/number}","comments_url":"https://api.github.com/repos/storj/storj/issues/1732/comments","statuses_url":"https://api.github.com/repos/storj/storj/statuses/4bdced6801d80daba4f2dd5cce8e06ee956cc60a","head":{"label":"storj:inspector-draw-routing-table","ref":"inspector-draw-routing-table","sha":"4bdced6801d80daba4f2dd5cce8e06ee956cc60a","user":{"login":"storj","id":6308081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMDgwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/6308081?v=4","gravatar_id":"","url":"https://api.github.com/users/storj","html_url":"https://github.com/storj","followers_url":"https://api.github.com/users/storj/followers","following_url":"https://api.github.com/users/storj/following{/other_user}","gists_url":"https://api.github.com/users/storj/gists{/gist_id}","starred_url":"https://api.github.com/users/storj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storj/subscriptions","organizations_url":"https://api.github.com/users/storj/orgs","repos_url":"https://api.github.com/users/storj/repos","events_url":"https://api.github.com/users/storj/events{/privacy}","received_events_url":"https://api.github.com/users/storj/received_events","type":"Organization","site_admin":false},"repo":{"id":128089774,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgwODk3NzQ=","name":"storj","full_name":"storj/storj","private":false,"owner":{"login":"storj","id":6308081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMDgwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/6308081?v=4","gravatar_id":"","url":"https://api.github.com/users/storj","html_url":"https://github.com/storj","followers_url":"https://api.github.com/users/storj/followers","following_url":"https://api.github.com/users/storj/following{/other_user}","gists_url":"https://api.github.com/users/storj/gists{/gist_id}","starred_url":"https://api.github.com/users/storj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storj/subscriptions","organizations_url":"https://api.github.com/users/storj/orgs","repos_url":"https://api.github.com/users/storj/repos","events_url":"https://api.github.com/users/storj/events{/privacy}","received_events_url":"https://api.github.com/users/storj/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/storj/storj","description":"Ongoing Storj v3 development. Decentralized cloud object storage that is affordable, easy to use, private, and secure.","fork":false,"url":"https://api.github.com/repos/storj/storj","forks_url":"https://api.github.com/repos/storj/storj/forks","keys_url":"https://api.github.com/repos/storj/storj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/storj/storj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/storj/storj/teams","hooks_url":"https://api.github.com/repos/storj/storj/hooks","issue_events_url":"https://api.github.com/repos/storj/storj/issues/events{/number}","events_url":"https://api.github.com/repos/storj/storj/events","assignees_url":"https://api.github.com/repos/storj/storj/assignees{/user}","branches_url":"https://api.github.com/repos/storj/storj/branches{/branch}","tags_url":"https://api.github.com/repos/storj/storj/tags","blobs_url":"https://api.github.com/repos/storj/storj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/storj/storj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/storj/storj/git/refs{/sha}","trees_url":"https://api.github.com/repos/storj/storj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/storj/storj/statuses/{sha}","languages_url":"https://api.github.com/repos/storj/storj/languages","stargazers_url":"https://api.github.com/repos/storj/storj/stargazers","contributors_url":"https://api.github.com/repos/storj/storj/contributors","subscribers_url":"https://api.github.com/repos/storj/storj/subscribers","subscription_url":"https://api.github.com/repos/storj/storj/subscription","commits_url":"https://api.github.com/repos/storj/storj/commits{/sha}","git_commits_url":"https://api.github.com/repos/storj/storj/git/commits{/sha}","comments_url":"https://api.github.com/repos/storj/storj/comments{/number}","issue_comment_url":"https://api.github.com/repos/storj/storj/issues/comments{/number}","contents_url":"https://api.github.com/repos/storj/storj/contents/{+path}","compare_url":"https://api.github.com/repos/storj/storj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/storj/storj/merges","archive_url":"https://api.github.com/repos/storj/storj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/storj/storj/downloads","issues_url":"https://api.github.com/repos/storj/storj/issues{/number}","pulls_url":"https://api.github.com/repos/storj/storj/pulls{/number}","milestones_url":"https://api.github.com/repos/storj/storj/milestones{/number}","notifications_url":"https://api.github.com/repos/storj/storj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/storj/storj/labels{/name}","releases_url":"https://api.github.com/repos/storj/storj/releases{/id}","deployments_url":"https://api.github.com/repos/storj/storj/deployments","created_at":"2018-04-04T16:27:18Z","updated_at":"2019-04-15T05:43:12Z","pushed_at":"2019-04-15T08:15:03Z","git_url":"git://github.com/storj/storj.git","ssh_url":"[email protected]:storj/storj.git","clone_url":"https://github.com/storj/storj.git","svn_url":"https://github.com/storj/storj","homepage":"https://storj.io","size":78473,"stargazers_count":566,"watchers_count":566,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":130,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":50,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":130,"open_issues":50,"watchers":566,"default_branch":"master"}},"base":{"label":"storj:master","ref":"master","sha":"15eec28d868b55d390e23560364933c1b9d5fb6c","user":{"login":"storj","id":6308081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMDgwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/6308081?v=4","gravatar_id":"","url":"https://api.github.com/users/storj","html_url":"https://github.com/storj","followers_url":"https://api.github.com/users/storj/followers","following_url":"https://api.github.com/users/storj/following{/other_user}","gists_url":"https://api.github.com/users/storj/gists{/gist_id}","starred_url":"https://api.github.com/users/storj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storj/subscriptions","organizations_url":"https://api.github.com/users/storj/orgs","repos_url":"https://api.github.com/users/storj/repos","events_url":"https://api.github.com/users/storj/events{/privacy}","received_events_url":"https://api.github.com/users/storj/received_events","type":"Organization","site_admin":false},"repo":{"id":128089774,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgwODk3NzQ=","name":"storj","full_name":"storj/storj","private":false,"owner":{"login":"storj","id":6308081,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMDgwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/6308081?v=4","gravatar_id":"","url":"https://api.github.com/users/storj","html_url":"https://github.com/storj","followers_url":"https://api.github.com/users/storj/followers","following_url":"https://api.github.com/users/storj/following{/other_user}","gists_url":"https://api.github.com/users/storj/gists{/gist_id}","starred_url":"https://api.github.com/users/storj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storj/subscriptions","organizations_url":"https://api.github.com/users/storj/orgs","repos_url":"https://api.github.com/users/storj/repos","events_url":"https://api.github.com/users/storj/events{/privacy}","received_events_url":"https://api.github.com/users/storj/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/storj/storj","description":"Ongoing Storj v3 development. Decentralized cloud object storage that is affordable, easy to use, private, and secure.","fork":false,"url":"https://api.github.com/repos/storj/storj","forks_url":"https://api.github.com/repos/storj/storj/forks","keys_url":"https://api.github.com/repos/storj/storj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/storj/storj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/storj/storj/teams","hooks_url":"https://api.github.com/repos/storj/storj/hooks","issue_events_url":"https://api.github.com/repos/storj/storj/issues/events{/number}","events_url":"https://api.github.com/repos/storj/storj/events","assignees_url":"https://api.github.com/repos/storj/storj/assignees{/user}","branches_url":"https://api.github.com/repos/storj/storj/branches{/branch}","tags_url":"https://api.github.com/repos/storj/storj/tags","blobs_url":"https://api.github.com/repos/storj/storj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/storj/storj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/storj/storj/git/refs{/sha}","trees_url":"https://api.github.com/repos/storj/storj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/storj/storj/statuses/{sha}","languages_url":"https://api.github.com/repos/storj/storj/languages","stargazers_url":"https://api.github.com/repos/storj/storj/stargazers","contributors_url":"https://api.github.com/repos/storj/storj/contributors","subscribers_url":"https://api.github.com/repos/storj/storj/subscribers","subscription_url":"https://api.github.com/repos/storj/storj/subscription","commits_url":"https://api.github.com/repos/storj/storj/commits{/sha}","git_commits_url":"https://api.github.com/repos/storj/storj/git/commits{/sha}","comments_url":"https://api.github.com/repos/storj/storj/comments{/number}","issue_comment_url":"https://api.github.com/repos/storj/storj/issues/comments{/number}","contents_url":"https://api.github.com/repos/storj/storj/contents/{+path}","compare_url":"https://api.github.com/repos/storj/storj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/storj/storj/merges","archive_url":"https://api.github.com/repos/storj/storj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/storj/storj/downloads","issues_url":"https://api.github.com/repos/storj/storj/issues{/number}","pulls_url":"https://api.github.com/repos/storj/storj/pulls{/number}","milestones_url":"https://api.github.com/repos/storj/storj/milestones{/number}","notifications_url":"https://api.github.com/repos/storj/storj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/storj/storj/labels{/name}","releases_url":"https://api.github.com/repos/storj/storj/releases{/id}","deployments_url":"https://api.github.com/repos/storj/storj/deployments","created_at":"2018-04-04T16:27:18Z","updated_at":"2019-04-15T05:43:12Z","pushed_at":"2019-04-15T08:15:03Z","git_url":"git://github.com/storj/storj.git","ssh_url":"[email protected]:storj/storj.git","clone_url":"https://github.com/storj/storj.git","svn_url":"https://github.com/storj/storj","homepage":"https://storj.io","size":78473,"stargazers_count":566,"watchers_count":566,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":130,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":50,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":130,"open_issues":50,"watchers":566,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/storj/storj/pulls/1732"},"html":{"href":"https://github.com/storj/storj/pull/1732"},"issue":{"href":"https://api.github.com/repos/storj/storj/issues/1732"},"comments":{"href":"https://api.github.com/repos/storj/storj/issues/1732/comments"},"review_comments":{"href":"https://api.github.com/repos/storj/storj/pulls/1732/comments"},"review_comment":{"href":"https://api.github.com/repos/storj/storj/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/storj/storj/pulls/1732/commits"},"statuses":{"href":"https://api.github.com/repos/storj/storj/statuses/4bdced6801d80daba4f2dd5cce8e06ee956cc60a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 128089774,
"name": "storj/storj",
"url": "https://api.github.com/repos/storj/storj"
}
|
{
"id": 468091,
"login": "kaloyan-raev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/468091?",
"url": "https://api.github.com/users/kaloyan-raev"
}
|
{
"id": 6308081,
"login": "storj",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6308081?",
"url": "https://api.github.com/orgs/storj"
}
| 2019-04-15T09:18:21 |
9443374226
|
{"actor":{"display_login":"kaloyan-raev"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/godotengine/godot/pulls/comments/332648528","pull_request_review_id":298940258,"id":332648528,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMjY0ODUyOA==","diff_hunk":"@@ -557,28 +557,9 @@ void Basis::set_euler_yxz(const Vector3 &p_euler) {\n \t*this = ymat * xmat * zmat;\n }\n \n-bool Basis::is_equal_approx(const Basis &a, const Basis &b, real_t p_epsilon) const {","path":"core/math/basis.cpp","position":27,"original_position":27,"commit_id":"726faa29722a5e8e5ec6e606a0b2d8b83eb5cf8a","original_commit_id":"7691cea15c122703edcacf88a2091effed255844","user":{"login":"aaronfranke","id":1646875,"node_id":"MDQ6VXNlcjE2NDY4NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1646875?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronfranke","html_url":"https://github.com/aaronfranke","followers_url":"https://api.github.com/users/aaronfranke/followers","following_url":"https://api.github.com/users/aaronfranke/following{/other_user}","gists_url":"https://api.github.com/users/aaronfranke/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronfranke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronfranke/subscriptions","organizations_url":"https://api.github.com/users/aaronfranke/orgs","repos_url":"https://api.github.com/users/aaronfranke/repos","events_url":"https://api.github.com/users/aaronfranke/events{/privacy}","received_events_url":"https://api.github.com/users/aaronfranke/received_events","type":"User","site_admin":false},"body":"Should I leave a note that it would be worth renaming this method to `is_equal_approx_ratio` in 4.0? It would be strange if Basis had different behavior for `is_equal_approx`.","created_at":"2019-10-08T17:51:30Z","updated_at":"2019-10-08T17:51:31Z","html_url":"https://github.com/godotengine/godot/pull/32477#discussion_r332648528","pull_request_url":"https://api.github.com/repos/godotengine/godot/pulls/32477","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments/332648528"},"html":{"href":"https://github.com/godotengine/godot/pull/32477#discussion_r332648528"},"pull_request":{"href":"https://api.github.com/repos/godotengine/godot/pulls/32477"}},"in_reply_to_id":332547176},"pull_request":{"url":"https://api.github.com/repos/godotengine/godot/pulls/32477","id":323540748,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIzNTQwNzQ4","html_url":"https://github.com/godotengine/godot/pull/32477","diff_url":"https://github.com/godotengine/godot/pull/32477.diff","patch_url":"https://github.com/godotengine/godot/pull/32477.patch","issue_url":"https://api.github.com/repos/godotengine/godot/issues/32477","number":32477,"state":"open","locked":false,"title":"Make is_equal_approx separate and make == exact again","user":{"login":"aaronfranke","id":1646875,"node_id":"MDQ6VXNlcjE2NDY4NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1646875?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronfranke","html_url":"https://github.com/aaronfranke","followers_url":"https://api.github.com/users/aaronfranke/followers","following_url":"https://api.github.com/users/aaronfranke/following{/other_user}","gists_url":"https://api.github.com/users/aaronfranke/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronfranke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronfranke/subscriptions","organizations_url":"https://api.github.com/users/aaronfranke/orgs","repos_url":"https://api.github.com/users/aaronfranke/repos","events_url":"https://api.github.com/users/aaronfranke/events{/privacy}","received_events_url":"https://api.github.com/users/aaronfranke/received_events","type":"User","site_admin":false},"body":"This PR fixes the concerns @reduz has about #18992. \r\n\r\nMy initial reasoning is that end-user code would almost always want to have equality checks be safe, so that would make sense to have as the default behavior of `==` for vectors. One concern about this is with performance, but if that was the only concern, performance-critical code could have a separate method for checking this (and some code could also switch to integer vectors later on, too).\r\n\r\nThis PR restores the old (3.1) functionality of `==` for vectors etc, and instead introduces some `is_equal_approx` methods for comparing them. The main reason I think this is the best course of action is that, as @reduz mentioned, we don't want to hide this functionality from the user. It makes sense to require users to be aware of approximate equality and consciously choose it, instead of it just being the default choice for `==`. Aside from that, it does also have the advantage of allowing code to run as fast as before.\r\n\r\nThe first commit adds `is_equal_approx` internally (exposed in C#) to the types (so, nothing breaking). There is a pre-existing exposed `is_equal_approx` in `Basis` that should be replaced in 4.0, I've placed TODO notes in there. The second commit switches internal code that depends on approximate vector equality (such as the lines in #31395) to use the `is_equal_approx` methods (so, nothing breaking). The third commit exposes `is_equal_approx` methods and reverts `==` to check for exact equality again (same behavior as 3.1, so 3.1 projects will still work the same).\r\n\r\nOne thing I wasn't sure about is with `>` and `>=` etc. I think it's desirable to leave these as they currently are, but I could be wrong.\r\n\r\nAs a side note, this is my **100th** pull request on GitHub (and my 51st to the Godot repo). :tada: ","created_at":"2019-10-02T01:26:13Z","updated_at":"2019-10-08T17:51:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fd6552d84dbb19a590a1d3fda1bb7df9c43db11","assignee":null,"assignees":[],"requested_reviewers":[{"login":"BastiaanOlij","id":1945449,"node_id":"MDQ6VXNlcjE5NDU0NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1945449?v=4","gravatar_id":"","url":"https://api.github.com/users/BastiaanOlij","html_url":"https://github.com/BastiaanOlij","followers_url":"https://api.github.com/users/BastiaanOlij/followers","following_url":"https://api.github.com/users/BastiaanOlij/following{/other_user}","gists_url":"https://api.github.com/users/BastiaanOlij/gists{/gist_id}","starred_url":"https://api.github.com/users/BastiaanOlij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BastiaanOlij/subscriptions","organizations_url":"https://api.github.com/users/BastiaanOlij/orgs","repos_url":"https://api.github.com/users/BastiaanOlij/repos","events_url":"https://api.github.com/users/BastiaanOlij/events{/privacy}","received_events_url":"https://api.github.com/users/BastiaanOlij/received_events","type":"User","site_admin":false},{"login":"reduz","id":6265307,"node_id":"MDQ6VXNlcjYyNjUzMDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6265307?v=4","gravatar_id":"","url":"https://api.github.com/users/reduz","html_url":"https://github.com/reduz","followers_url":"https://api.github.com/users/reduz/followers","following_url":"https://api.github.com/users/reduz/following{/other_user}","gists_url":"https://api.github.com/users/reduz/gists{/gist_id}","starred_url":"https://api.github.com/users/reduz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reduz/subscriptions","organizations_url":"https://api.github.com/users/reduz/orgs","repos_url":"https://api.github.com/users/reduz/repos","events_url":"https://api.github.com/users/reduz/events{/privacy}","received_events_url":"https://api.github.com/users/reduz/received_events","type":"User","site_admin":false},{"login":"neikeq","id":7718100,"node_id":"MDQ6VXNlcjc3MTgxMDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7718100?v=4","gravatar_id":"","url":"https://api.github.com/users/neikeq","html_url":"https://github.com/neikeq","followers_url":"https://api.github.com/users/neikeq/followers","following_url":"https://api.github.com/users/neikeq/following{/other_user}","gists_url":"https://api.github.com/users/neikeq/gists{/gist_id}","starred_url":"https://api.github.com/users/neikeq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neikeq/subscriptions","organizations_url":"https://api.github.com/users/neikeq/orgs","repos_url":"https://api.github.com/users/neikeq/repos","events_url":"https://api.github.com/users/neikeq/events{/privacy}","received_events_url":"https://api.github.com/users/neikeq/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":73330066,"node_id":"MDU6TGFiZWw3MzMzMDA2Ng==","url":"https://api.github.com/repos/godotengine/godot/labels/enhancement","name":"enhancement","color":"aaccff","default":true},{"id":1349613124,"node_id":"MDU6TGFiZWwxMzQ5NjEzMTI0","url":"https://api.github.com/repos/godotengine/godot/labels/for%20pr%20meeting","name":"for pr meeting","color":"88f795","default":false},{"id":279097966,"node_id":"MDU6TGFiZWwyNzkwOTc5NjY=","url":"https://api.github.com/repos/godotengine/godot/labels/topic:core","name":"topic:core","color":"ffee88","default":false}],"milestone":{"url":"https://api.github.com/repos/godotengine/godot/milestones/8","html_url":"https://github.com/godotengine/godot/milestone/8","labels_url":"https://api.github.com/repos/godotengine/godot/milestones/8/labels","id":3401519,"node_id":"MDk6TWlsZXN0b25lMzQwMTUxOQ==","number":8,"title":"3.2","description":"","creator":{"login":"mhilbrunner","id":1654763,"node_id":"MDQ6VXNlcjE2NTQ3NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1654763?v=4","gravatar_id":"","url":"https://api.github.com/users/mhilbrunner","html_url":"https://github.com/mhilbrunner","followers_url":"https://api.github.com/users/mhilbrunner/followers","following_url":"https://api.github.com/users/mhilbrunner/following{/other_user}","gists_url":"https://api.github.com/users/mhilbrunner/gists{/gist_id}","starred_url":"https://api.github.com/users/mhilbrunner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhilbrunner/subscriptions","organizations_url":"https://api.github.com/users/mhilbrunner/orgs","repos_url":"https://api.github.com/users/mhilbrunner/repos","events_url":"https://api.github.com/users/mhilbrunner/events{/privacy}","received_events_url":"https://api.github.com/users/mhilbrunner/received_events","type":"User","site_admin":false},"open_issues":1282,"closed_issues":3512,"state":"open","created_at":"2018-06-05T09:48:59Z","updated_at":"2019-10-08T15:40:58Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/godotengine/godot/pulls/32477/commits","review_comments_url":"https://api.github.com/repos/godotengine/godot/pulls/32477/comments","review_comment_url":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/godotengine/godot/issues/32477/comments","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/726faa29722a5e8e5ec6e606a0b2d8b83eb5cf8a","head":{"label":"aaronfranke:equal-approx-separate","ref":"equal-approx-separate","sha":"726faa29722a5e8e5ec6e606a0b2d8b83eb5cf8a","user":{"login":"aaronfranke","id":1646875,"node_id":"MDQ6VXNlcjE2NDY4NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1646875?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronfranke","html_url":"https://github.com/aaronfranke","followers_url":"https://api.github.com/users/aaronfranke/followers","following_url":"https://api.github.com/users/aaronfranke/following{/other_user}","gists_url":"https://api.github.com/users/aaronfranke/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronfranke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronfranke/subscriptions","organizations_url":"https://api.github.com/users/aaronfranke/orgs","repos_url":"https://api.github.com/users/aaronfranke/repos","events_url":"https://api.github.com/users/aaronfranke/events{/privacy}","received_events_url":"https://api.github.com/users/aaronfranke/received_events","type":"User","site_admin":false},"repo":{"id":128834982,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4MzQ5ODI=","name":"godot","full_name":"aaronfranke/godot","private":false,"owner":{"login":"aaronfranke","id":1646875,"node_id":"MDQ6VXNlcjE2NDY4NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1646875?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronfranke","html_url":"https://github.com/aaronfranke","followers_url":"https://api.github.com/users/aaronfranke/followers","following_url":"https://api.github.com/users/aaronfranke/following{/other_user}","gists_url":"https://api.github.com/users/aaronfranke/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronfranke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronfranke/subscriptions","organizations_url":"https://api.github.com/users/aaronfranke/orgs","repos_url":"https://api.github.com/users/aaronfranke/repos","events_url":"https://api.github.com/users/aaronfranke/events{/privacy}","received_events_url":"https://api.github.com/users/aaronfranke/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aaronfranke/godot","description":"Godot Engine – Multi-platform 2D and 3D game engine","fork":true,"url":"https://api.github.com/repos/aaronfranke/godot","forks_url":"https://api.github.com/repos/aaronfranke/godot/forks","keys_url":"https://api.github.com/repos/aaronfranke/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaronfranke/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaronfranke/godot/teams","hooks_url":"https://api.github.com/repos/aaronfranke/godot/hooks","issue_events_url":"https://api.github.com/repos/aaronfranke/godot/issues/events{/number}","events_url":"https://api.github.com/repos/aaronfranke/godot/events","assignees_url":"https://api.github.com/repos/aaronfranke/godot/assignees{/user}","branches_url":"https://api.github.com/repos/aaronfranke/godot/branches{/branch}","tags_url":"https://api.github.com/repos/aaronfranke/godot/tags","blobs_url":"https://api.github.com/repos/aaronfranke/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaronfranke/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaronfranke/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaronfranke/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaronfranke/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/aaronfranke/godot/languages","stargazers_url":"https://api.github.com/repos/aaronfranke/godot/stargazers","contributors_url":"https://api.github.com/repos/aaronfranke/godot/contributors","subscribers_url":"https://api.github.com/repos/aaronfranke/godot/subscribers","subscription_url":"https://api.github.com/repos/aaronfranke/godot/subscription","commits_url":"https://api.github.com/repos/aaronfranke/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaronfranke/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaronfranke/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaronfranke/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaronfranke/godot/contents/{+path}","compare_url":"https://api.github.com/repos/aaronfranke/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaronfranke/godot/merges","archive_url":"https://api.github.com/repos/aaronfranke/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaronfranke/godot/downloads","issues_url":"https://api.github.com/repos/aaronfranke/godot/issues{/number}","pulls_url":"https://api.github.com/repos/aaronfranke/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/aaronfranke/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/aaronfranke/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaronfranke/godot/labels{/name}","releases_url":"https://api.github.com/repos/aaronfranke/godot/releases{/id}","deployments_url":"https://api.github.com/repos/aaronfranke/godot/deployments","created_at":"2018-04-09T21:18:14Z","updated_at":"2019-09-29T20:03:43Z","pushed_at":"2019-10-02T20:44:55Z","git_url":"git://github.com/aaronfranke/godot.git","ssh_url":"[email protected]:aaronfranke/godot.git","clone_url":"https://github.com/aaronfranke/godot.git","svn_url":"https://github.com/aaronfranke/godot","homepage":"https://godotengine.org","size":339075,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"godotengine:master","ref":"master","sha":"893ebd3080225eeeecd4b52920df99d5c53484f7","user":{"login":"godotengine","id":6318500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMTg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"repo":{"id":15634981,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYzNDk4MQ==","name":"godot","full_name":"godotengine/godot","private":false,"owner":{"login":"godotengine","id":6318500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzMTg1MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/6318500?v=4","gravatar_id":"","url":"https://api.github.com/users/godotengine","html_url":"https://github.com/godotengine","followers_url":"https://api.github.com/users/godotengine/followers","following_url":"https://api.github.com/users/godotengine/following{/other_user}","gists_url":"https://api.github.com/users/godotengine/gists{/gist_id}","starred_url":"https://api.github.com/users/godotengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/godotengine/subscriptions","organizations_url":"https://api.github.com/users/godotengine/orgs","repos_url":"https://api.github.com/users/godotengine/repos","events_url":"https://api.github.com/users/godotengine/events{/privacy}","received_events_url":"https://api.github.com/users/godotengine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/godotengine/godot","description":"Godot Engine – Multi-platform 2D and 3D game engine","fork":false,"url":"https://api.github.com/repos/godotengine/godot","forks_url":"https://api.github.com/repos/godotengine/godot/forks","keys_url":"https://api.github.com/repos/godotengine/godot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/godotengine/godot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/godotengine/godot/teams","hooks_url":"https://api.github.com/repos/godotengine/godot/hooks","issue_events_url":"https://api.github.com/repos/godotengine/godot/issues/events{/number}","events_url":"https://api.github.com/repos/godotengine/godot/events","assignees_url":"https://api.github.com/repos/godotengine/godot/assignees{/user}","branches_url":"https://api.github.com/repos/godotengine/godot/branches{/branch}","tags_url":"https://api.github.com/repos/godotengine/godot/tags","blobs_url":"https://api.github.com/repos/godotengine/godot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/godotengine/godot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/godotengine/godot/git/refs{/sha}","trees_url":"https://api.github.com/repos/godotengine/godot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/godotengine/godot/statuses/{sha}","languages_url":"https://api.github.com/repos/godotengine/godot/languages","stargazers_url":"https://api.github.com/repos/godotengine/godot/stargazers","contributors_url":"https://api.github.com/repos/godotengine/godot/contributors","subscribers_url":"https://api.github.com/repos/godotengine/godot/subscribers","subscription_url":"https://api.github.com/repos/godotengine/godot/subscription","commits_url":"https://api.github.com/repos/godotengine/godot/commits{/sha}","git_commits_url":"https://api.github.com/repos/godotengine/godot/git/commits{/sha}","comments_url":"https://api.github.com/repos/godotengine/godot/comments{/number}","issue_comment_url":"https://api.github.com/repos/godotengine/godot/issues/comments{/number}","contents_url":"https://api.github.com/repos/godotengine/godot/contents/{+path}","compare_url":"https://api.github.com/repos/godotengine/godot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/godotengine/godot/merges","archive_url":"https://api.github.com/repos/godotengine/godot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/godotengine/godot/downloads","issues_url":"https://api.github.com/repos/godotengine/godot/issues{/number}","pulls_url":"https://api.github.com/repos/godotengine/godot/pulls{/number}","milestones_url":"https://api.github.com/repos/godotengine/godot/milestones{/number}","notifications_url":"https://api.github.com/repos/godotengine/godot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/godotengine/godot/labels{/name}","releases_url":"https://api.github.com/repos/godotengine/godot/releases{/id}","deployments_url":"https://api.github.com/repos/godotengine/godot/deployments","created_at":"2014-01-04T16:05:36Z","updated_at":"2019-10-08T15:51:22Z","pushed_at":"2019-10-08T15:34:53Z","git_url":"git://github.com/godotengine/godot.git","ssh_url":"[email protected]:godotengine/godot.git","clone_url":"https://github.com/godotengine/godot.git","svn_url":"https://github.com/godotengine/godot","homepage":"https://godotengine.org","size":354005,"stargazers_count":24917,"watchers_count":24917,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4844,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5591,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4844,"open_issues":5591,"watchers":24917,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/godotengine/godot/pulls/32477"},"html":{"href":"https://github.com/godotengine/godot/pull/32477"},"issue":{"href":"https://api.github.com/repos/godotengine/godot/issues/32477"},"comments":{"href":"https://api.github.com/repos/godotengine/godot/issues/32477/comments"},"review_comments":{"href":"https://api.github.com/repos/godotengine/godot/pulls/32477/comments"},"review_comment":{"href":"https://api.github.com/repos/godotengine/godot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/godotengine/godot/pulls/32477/commits"},"statuses":{"href":"https://api.github.com/repos/godotengine/godot/statuses/726faa29722a5e8e5ec6e606a0b2d8b83eb5cf8a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 15634981,
"name": "godotengine/godot",
"url": "https://api.github.com/repos/godotengine/godot"
}
|
{
"id": 1646875,
"login": "aaronfranke",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1646875?",
"url": "https://api.github.com/users/aaronfranke"
}
|
{
"id": 6318500,
"login": "godotengine",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6318500?",
"url": "https://api.github.com/orgs/godotengine"
}
| 2019-10-08T17:51:30 |
10585594193
|
{"actor":{"display_login":"aaronfranke"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/odoo/odoo/pulls/comments/327769406","pull_request_review_id":292623213,"id":327769406,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNzc2OTQwNg==","diff_hunk":"@@ -0,0 +1,76 @@\n+odoo.define('web.ListConfirmDialog', function (require) {\n+\"use strict\";\n+\n+const core = require('web.core');\n+const Dialog = require('web.Dialog');\n+\n+const _t = core._t;\n+const qweb = core.qweb;\n+\n+/**\n+ * Multi edition confirmation modal for list views.\n+ *\n+ * Handles the display of the amount of changed records (+ valid ones) and\n+ * of the widget representing the new value.\n+ *\n+ * @class\n+ */\n+const ListConfirmDialog = Dialog.extend({\n+ /**\n+ * @constructor\n+ * @override\n+ * @param {Widget} parent\n+ * @param {Object} record edited record with updated value\n+ * @param {Object} changes changes registered by the list controller\n+ * @param {string} changes.fieldLabel label of the changed field\n+ * @param {string} changes.fieldName technical name of the changed field\n+ * @param {number} changes.nbRecords number of records (total)\n+ * @param {number} changes.nbValidRecords number of valid records\n+ * @param {Object} [options]\n+ */\n+ init: function (parent, record, changes, options) {\n+ options = options || {};\n+ Object.assign(options, {\n+ buttons: options.buttons || [\n+ {\n+ text: _t(\"Ok\"),\n+ classes: 'btn-primary',\n+ close: true,\n+ click: options.confirm_callback,\n+ },\n+ {\n+ text: _t(\"Cancel\"),\n+ close: true,\n+ click: options.cancel_callback,\n+ },\n+ ],\n+ $content: $(qweb.render('ListView.confirmModal', { changes })),\n+ size: options.size || 'medium',\n+ title: options.title || _t(\"Confirmation\"),\n+ onForceClose: options.cancel_callback,\n+ });\n+\n+ this._super(parent, options);\n+\n+ const Widget = record.fieldsInfo.list[changes.fieldName].Widget;\n+ this.fieldWidget = new Widget(this, changes.fieldName, record, {\n+ mode: 'readonly',\n+ viewType: 'list',\n+ noOpen: true,\n+ });\n+ },\n+\n+ /**\n+ * @override\n+ */\n+ willStart: function () {\n+ const prom = this.fieldWidget._widgetRenderAndInsert(() => { }).then(() => {","path":"addons/web/static/src/js/views/list/list_confirm_dialog.js","position":67,"original_position":67,"commit_id":"35dce938d973ab9f29c34dda92bb168a39c63806","original_commit_id":"c75b767f4bcf0ddd4580bb23f397c4f662b753a2","user":{"login":"aab-odoo","id":9432572,"node_id":"MDQ6VXNlcjk0MzI1NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/9432572?v=4","gravatar_id":"","url":"https://api.github.com/users/aab-odoo","html_url":"https://github.com/aab-odoo","followers_url":"https://api.github.com/users/aab-odoo/followers","following_url":"https://api.github.com/users/aab-odoo/following{/other_user}","gists_url":"https://api.github.com/users/aab-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/aab-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aab-odoo/subscriptions","organizations_url":"https://api.github.com/users/aab-odoo/orgs","repos_url":"https://api.github.com/users/aab-odoo/repos","events_url":"https://api.github.com/users/aab-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/aab-odoo/received_events","type":"User","site_admin":false},"body":"async work should be done in willStart, but I we could start the sub-widget by appending it in a fragment","created_at":"2019-09-24T18:29:07Z","updated_at":"2019-09-24T18:29:08Z","html_url":"https://github.com/odoo/odoo/pull/37113#discussion_r327769406","pull_request_url":"https://api.github.com/repos/odoo/odoo/pulls/37113","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/327769406"},"html":{"href":"https://github.com/odoo/odoo/pull/37113#discussion_r327769406"},"pull_request":{"href":"https://api.github.com/repos/odoo/odoo/pulls/37113"}},"in_reply_to_id":327590590},"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/37113","id":319156495,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE5MTU2NDk1","html_url":"https://github.com/odoo/odoo/pull/37113","diff_url":"https://github.com/odoo/odoo/pull/37113.diff","patch_url":"https://github.com/odoo/odoo/pull/37113.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/37113","number":37113,"state":"open","locked":false,"title":"Various fixes, mainly related to list column widths + editable readonly feature","user":{"login":"aab-odoo","id":9432572,"node_id":"MDQ6VXNlcjk0MzI1NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/9432572?v=4","gravatar_id":"","url":"https://api.github.com/users/aab-odoo","html_url":"https://github.com/aab-odoo","followers_url":"https://api.github.com/users/aab-odoo/followers","following_url":"https://api.github.com/users/aab-odoo/following{/other_user}","gists_url":"https://api.github.com/users/aab-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/aab-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aab-odoo/subscriptions","organizations_url":"https://api.github.com/users/aab-odoo/orgs","repos_url":"https://api.github.com/users/aab-odoo/repos","events_url":"https://api.github.com/users/aab-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/aab-odoo/received_events","type":"User","site_admin":false},"body":"ClassNames 'oe_read_only' (resp. 'oe_edit_only') can be used in\r\nx2many lists to hide columns in 'edit' (resp. 'readonly') modes.\r\n\r\nHowever, before this rev., there were two issues:\r\n 1) Having such a className on a <button> tag didn't work well as\r\n the 'display: none' rule didn't apply on the body cell (it only\r\n applied on the button). Same could be observed on <widget>\r\n nodes.\r\n 2) Having more than one invisible column (with those classNames)\r\n didn't work either, because the footer cells weren't hidden.\r\n We didn't notice it with one invisible column, because the\r\n footer contained one cell less than the header and the body.\r\n\r\nThose two issues could be observed on the mrp.bom form view.\r\n\r\nTask 2068261\r\n\r\nDescription of the issue/feature this PR addresses:\r\n\r\nCurrent behavior before PR:\r\n\r\nDesired behavior after PR is merged:\r\n\r\n\r\n\r\n\r\n--\r\nI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr\r\n","created_at":"2019-09-19T08:31:48Z","updated_at":"2019-09-24T18:29:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1e064998debdc199f75f9b702c465b549918f49","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":106173385,"node_id":"MDU6TGFiZWwxMDYxNzMzODU=","url":"https://api.github.com/repos/odoo/odoo/labels/RD","name":"RD","color":"5319e7","default":false},{"id":1044215768,"node_id":"MDU6TGFiZWwxMDQ0MjE1NzY4","url":"https://api.github.com/repos/odoo/odoo/labels/seen%20%F0%9F%99%82","name":"seen 🙂","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/37113/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/37113/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/37113/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/35dce938d973ab9f29c34dda92bb168a39c63806","head":{"label":"odoo-dev:saas-12.5-list-fixes-aab","ref":"saas-12.5-list-fixes-aab","sha":"35dce938d973ab9f29c34dda92bb168a39c63806","user":{"login":"odoo-dev","id":7466976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NjY5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7466976?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg1MzkzNA==","name":"odoo","full_name":"odoo-dev/odoo","private":false,"owner":{"login":"odoo-dev","id":7466976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NjY5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7466976?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo-dev/odoo/deployments","created_at":"2014-05-16T11:16:19Z","updated_at":"2019-09-11T23:34:28Z","pushed_at":"2019-09-24T17:45:46Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"[email protected]:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":2705953,"stargazers_count":89,"watchers_count":89,"language":null,"has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":null,"forks":45,"open_issues":4,"watchers":89,"default_branch":"master"}},"base":{"label":"odoo:saas-12.5","ref":"saas-12.5","sha":"c2ff5075ae46bca8e31154d0db5ecb19bc39f4d2","user":{"login":"odoo","id":6368483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNjg0ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc0NTAwNA==","name":"odoo","full_name":"odoo/odoo","private":false,"owner":{"login":"odoo","id":6368483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNjg0ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/odoo/odoo","description":"Odoo. Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo/odoo/deployments","created_at":"2014-05-13T15:38:58Z","updated_at":"2019-09-24T17:52:17Z","pushed_at":"2019-09-24T18:28:19Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"[email protected]:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":2668072,"stargazers_count":15102,"watchers_count":15102,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10953,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2667,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10953,"open_issues":2667,"watchers":15102,"default_branch":"12.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/37113"},"html":{"href":"https://github.com/odoo/odoo/pull/37113"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/37113"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/37113/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/37113/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/37113/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/35dce938d973ab9f29c34dda92bb168a39c63806"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 19745004,
"name": "odoo/odoo",
"url": "https://api.github.com/repos/odoo/odoo"
}
|
{
"id": 9432572,
"login": "aab-odoo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9432572?",
"url": "https://api.github.com/users/aab-odoo"
}
|
{
"id": 6368483,
"login": "odoo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6368483?",
"url": "https://api.github.com/orgs/odoo"
}
| 2019-09-24T18:29:07 |
10485776549
|
{"actor":{"display_login":"aab-odoo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/odoo/odoo/pulls/comments/311428458","pull_request_review_id":271438196,"id":311428458,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMTQyODQ1OA==","diff_hunk":"@@ -0,0 +1,33 @@\n+<?xml version=\"1.0\" encoding=\"utf-8\"?>\n+<odoo>\n+ <record id=\"account_view_move_form_inherited\" model=\"ir.ui.view\">\n+ <field name=\"name\">account.view.move.form.inherited</field>\n+ <field name=\"model\">account.move</field>\n+ <field name=\"inherit_id\" ref=\"account.view_move_form\"/>","path":"addons/stock_landed_costs/views/account_move_views.xml","position":6,"original_position":6,"commit_id":"ed543ab22064e6eb4382ccb1f116774c75e192b8","original_commit_id":"ed543ab22064e6eb4382ccb1f116774c75e192b8","user":{"login":"amoyaux","id":5512395,"node_id":"MDQ6VXNlcjU1MTIzOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5512395?v=4","gravatar_id":"","url":"https://api.github.com/users/amoyaux","html_url":"https://github.com/amoyaux","followers_url":"https://api.github.com/users/amoyaux/followers","following_url":"https://api.github.com/users/amoyaux/following{/other_user}","gists_url":"https://api.github.com/users/amoyaux/gists{/gist_id}","starred_url":"https://api.github.com/users/amoyaux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amoyaux/subscriptions","organizations_url":"https://api.github.com/users/amoyaux/orgs","repos_url":"https://api.github.com/users/amoyaux/repos","events_url":"https://api.github.com/users/amoyaux/events{/privacy}","received_events_url":"https://api.github.com/users/amoyaux/received_events","type":"User","site_admin":false},"body":"Check for customer invoice","created_at":"2019-08-07T08:28:23Z","updated_at":"2019-08-07T08:29:07Z","html_url":"https://github.com/odoo/odoo/pull/35416#discussion_r311428458","pull_request_url":"https://api.github.com/repos/odoo/odoo/pulls/35416","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/311428458"},"html":{"href":"https://github.com/odoo/odoo/pull/35416#discussion_r311428458"},"pull_request":{"href":"https://api.github.com/repos/odoo/odoo/pulls/35416"}}},"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/35416","id":303809064,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAzODA5MDY0","html_url":"https://github.com/odoo/odoo/pull/35416","diff_url":"https://github.com/odoo/odoo/pull/35416.diff","patch_url":"https://github.com/odoo/odoo/pull/35416.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/35416","number":35416,"state":"open","locked":false,"title":"Master landed costs sle","user":{"login":"sle-odoo","id":7601090,"node_id":"MDQ6VXNlcjc2MDEwOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/7601090?v=4","gravatar_id":"","url":"https://api.github.com/users/sle-odoo","html_url":"https://github.com/sle-odoo","followers_url":"https://api.github.com/users/sle-odoo/followers","following_url":"https://api.github.com/users/sle-odoo/following{/other_user}","gists_url":"https://api.github.com/users/sle-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/sle-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sle-odoo/subscriptions","organizations_url":"https://api.github.com/users/sle-odoo/orgs","repos_url":"https://api.github.com/users/sle-odoo/repos","events_url":"https://api.github.com/users/sle-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/sle-odoo/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-08-02T14:24:47Z","updated_at":"2019-08-07T08:29:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a57db7fee343a8f4bed19c92a1854797ca8c088","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1044840932,"node_id":"MDU6TGFiZWwxMDQ0ODQwOTMy","url":"https://api.github.com/repos/odoo/odoo/labels/CI%20%F0%9F%A4%96","name":"CI 🤖","color":"68d979","default":false},{"id":106173385,"node_id":"MDU6TGFiZWwxMDYxNzMzODU=","url":"https://api.github.com/repos/odoo/odoo/labels/RD","name":"RD","color":"5319e7","default":false},{"id":1044215768,"node_id":"MDU6TGFiZWwxMDQ0MjE1NzY4","url":"https://api.github.com/repos/odoo/odoo/labels/seen%20%F0%9F%99%82","name":"seen 🙂","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/35416/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/35416/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/35416/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/ed543ab22064e6eb4382ccb1f116774c75e192b8","head":{"label":"odoo-dev:master-landed-costs-sle","ref":"master-landed-costs-sle","sha":"ed543ab22064e6eb4382ccb1f116774c75e192b8","user":{"login":"odoo-dev","id":7466976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NjY5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7466976?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg1MzkzNA==","name":"odoo","full_name":"odoo-dev/odoo","private":false,"owner":{"login":"odoo-dev","id":7466976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NjY5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7466976?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo-dev/odoo/deployments","created_at":"2014-05-16T11:16:19Z","updated_at":"2019-08-06T15:22:07Z","pushed_at":"2019-08-07T08:28:13Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"[email protected]:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":2583586,"stargazers_count":87,"watchers_count":87,"language":null,"has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":43,"open_issues":6,"watchers":87,"default_branch":"master"}},"base":{"label":"odoo:master","ref":"master","sha":"857c4851754dcddf9e6dc7b39585914beaf89c88","user":{"login":"odoo","id":6368483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNjg0ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc0NTAwNA==","name":"odoo","full_name":"odoo/odoo","private":false,"owner":{"login":"odoo","id":6368483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNjg0ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/odoo/odoo","description":"Odoo. Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo/odoo/deployments","created_at":"2014-05-13T15:38:58Z","updated_at":"2019-08-07T08:24:51Z","pushed_at":"2019-08-07T08:28:19Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"[email protected]:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":2549666,"stargazers_count":14576,"watchers_count":14576,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10716,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2521,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10716,"open_issues":2521,"watchers":14576,"default_branch":"12.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/35416"},"html":{"href":"https://github.com/odoo/odoo/pull/35416"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/35416"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/35416/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/35416/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/35416/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/ed543ab22064e6eb4382ccb1f116774c75e192b8"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 19745004,
"name": "odoo/odoo",
"url": "https://api.github.com/repos/odoo/odoo"
}
|
{
"id": 5512395,
"login": "amoyaux",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5512395?",
"url": "https://api.github.com/users/amoyaux"
}
|
{
"id": 6368483,
"login": "odoo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6368483?",
"url": "https://api.github.com/orgs/odoo"
}
| 2019-08-07T08:28:23 |
10163071644
|
{"actor":{"display_login":"amoyaux"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/comments/266519591","pull_request_review_id":215691306,"id":266519591,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NjUxOTU5MQ==","diff_hunk":"@@ -117,58 +116,58 @@ class Wizard extends React.Component<WizardProps> {\n hasBodyPadding: true\n };\n \n- public container = null;\n+ public container?: HTMLDivElement = undefined;\n public titleId = `pf-wizard-title-0`;\n public descriptionId = `pf-wizard-description-0`;\n \n- constructor(props) {\n+ constructor(props: WizardProps) {\n super(props);\n- const newId = currentId++;\n+ const newId = Wizard.currentId++;\n this.titleId = `pf-wizard-title-${newId}`;\n this.descriptionId = `pf-wizard-description-${newId}`;\n }\n \n public state = {\n- currentStep: Number.isInteger(this.props.startAtStep) ? this.props.startAtStep : 1,\n+ currentStep: this.props.startAtStep && Number.isInteger(this.props.startAtStep) ? this.props.startAtStep : 1,\n isNavOpen: false\n };\n \n- private handleKeyClicks = event => {\n+ handleKeyClicks(event: KeyboardEvent): void {\n if (event.keyCode === KEY_CODES.ESCAPE_KEY) {\n if (this.state.isNavOpen) {\n this.setState({ isNavOpen: !this.state.isNavOpen })\n } else if (this.props.isOpen) {\n- this.props.onClose();\n+ this.props.onClose!();\n }\n }\n };\n \n- private toggleSiblingsFromScreenReaders = hide => {\n+ toggleSiblingsFromScreenReaders(hide: boolean): void {\n const bodyChildren = document.body.children;\n for (const child of Array.from(bodyChildren)) {\n if (child !== this.container) {\n- hide ? child.setAttribute('aria-hidden', hide) : child.removeAttribute('aria-hidden');\n+ hide ? child.setAttribute('aria-hidden', '' + hide) : child.removeAttribute('aria-hidden');\n }\n }\n };\n \n public componentDidMount() {\n- document.body.appendChild(this.container);\n+ if (this.container) {\n+ document.body.appendChild(this.container);\n+ }\n this.toggleSiblingsFromScreenReaders(true);\n document.addEventListener('keydown', this.handleKeyClicks, false);\n }\n \n public componentWillUnmount() {\n- document.body.removeChild(this.container);\n+ if (this.container) {\n+ document.body.removeChild(this.container);\n+ }\n this.toggleSiblingsFromScreenReaders(false);\n document.removeEventListener('keydown', this.handleKeyClicks, false);\n }\n \n- private onNavToggle = isNavOpen => {\n- this.setState({ isNavOpen })\n- }\n-\n- private onNext = () => {\n+ onNext(): void {","path":"packages/patternfly-4/react-core/src/components/Wizard/Wizard.tsx","position":132,"original_position":132,"commit_id":"b1d9d90358d05728274d11886378837a5dca1c99","original_commit_id":"daa5311e25c3bae262d35921354f3fc10557b884","user":{"login":"jschuler","id":869106,"node_id":"MDQ6VXNlcjg2OTEwNg==","avatar_url":"https://avatars2.githubusercontent.com/u/869106?v=4","gravatar_id":"","url":"https://api.github.com/users/jschuler","html_url":"https://github.com/jschuler","followers_url":"https://api.github.com/users/jschuler/followers","following_url":"https://api.github.com/users/jschuler/following{/other_user}","gists_url":"https://api.github.com/users/jschuler/gists{/gist_id}","starred_url":"https://api.github.com/users/jschuler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jschuler/subscriptions","organizations_url":"https://api.github.com/users/jschuler/orgs","repos_url":"https://api.github.com/users/jschuler/repos","events_url":"https://api.github.com/users/jschuler/events{/privacy}","received_events_url":"https://api.github.com/users/jschuler/received_events","type":"User","site_admin":false},"body":"arrow functions bind `this` automatically , if this is not arrow function i think we need to bind in constructor\r\n`this.onNext = this.onNext.bind(this);`","created_at":"2019-03-18T16:08:52Z","updated_at":"2019-03-18T16:13:47Z","html_url":"https://github.com/patternfly/patternfly-react/pull/1570#discussion_r266519591","pull_request_url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/1570","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/comments/266519591"},"html":{"href":"https://github.com/patternfly/patternfly-react/pull/1570#discussion_r266519591"},"pull_request":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/1570"}}},"pull_request":{"url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/1570","id":260899012,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwODk5MDEy","html_url":"https://github.com/patternfly/patternfly-react/pull/1570","diff_url":"https://github.com/patternfly/patternfly-react/pull/1570.diff","patch_url":"https://github.com/patternfly/patternfly-react/pull/1570.patch","issue_url":"https://api.github.com/repos/patternfly/patternfly-react/issues/1570","number":1570,"state":"open","locked":false,"title":"feat(core): clean tsconfigs, add defaultProps to TS-docs","user":{"login":"redallen","id":47335686,"node_id":"MDQ6VXNlcjQ3MzM1Njg2","avatar_url":"https://avatars1.githubusercontent.com/u/47335686?v=4","gravatar_id":"","url":"https://api.github.com/users/redallen","html_url":"https://github.com/redallen","followers_url":"https://api.github.com/users/redallen/followers","following_url":"https://api.github.com/users/redallen/following{/other_user}","gists_url":"https://api.github.com/users/redallen/gists{/gist_id}","starred_url":"https://api.github.com/users/redallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redallen/subscriptions","organizations_url":"https://api.github.com/users/redallen/orgs","repos_url":"https://api.github.com/users/redallen/repos","events_url":"https://api.github.com/users/redallen/events{/privacy}","received_events_url":"https://api.github.com/users/redallen/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for your interest in patternfly-react. We appreciate all issues filed and PRs submitted!\r\n\r\nPlease make sure you're familiar with and follow the instructions in the\r\ncontributing guidelines (found in the CONTRIBUTING.md file).\r\n\r\nPlease fill out the information below to expedite the review and (hopefully)\r\nmerge of your pull request!\r\n-->\r\n\r\n<!-- What changes are being made? (What issue is being addressed here?) -->\r\n\r\n**What**: \r\n\r\n- Create 3 different tsconfigs that inherit from a base. Configure .d.ts file generation, typechecking, and jest to use correct tsconfigs.\r\n- Add \"@types/react-dom\"\r\n- Enable strict typechecking mode and fix miscellaneous errors (mostly in react-core/src/helpers/util.ts)\r\n- Make gatsby use new tsconfig and import props directly from `typedoc` json using new propsHelper.js\r\n- Fix Title to be more like Avatar. Discussion is welcome surrounding default exports.\r\n\r\n<!-- Are there any upstream issues or separate issues you need to reference? -->\r\n\r\n**Additional issues**: Title is broken in the docs due to ES6 object destructuring renaming when looking for the default for `headingLevel`, I'll fix it Monday.\r\n\r\n<!-- feel free to add additional comments -->\r\n","created_at":"2019-03-13T19:00:28Z","updated_at":"2019-03-18T16:13:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f86d03ce7a28e3358251857a50eb4c349cd53bf7","assignee":{"login":"dlabaj","id":6126356,"node_id":"MDQ6VXNlcjYxMjYzNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/6126356?v=4","gravatar_id":"","url":"https://api.github.com/users/dlabaj","html_url":"https://github.com/dlabaj","followers_url":"https://api.github.com/users/dlabaj/followers","following_url":"https://api.github.com/users/dlabaj/following{/other_user}","gists_url":"https://api.github.com/users/dlabaj/gists{/gist_id}","starred_url":"https://api.github.com/users/dlabaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlabaj/subscriptions","organizations_url":"https://api.github.com/users/dlabaj/orgs","repos_url":"https://api.github.com/users/dlabaj/repos","events_url":"https://api.github.com/users/dlabaj/events{/privacy}","received_events_url":"https://api.github.com/users/dlabaj/received_events","type":"User","site_admin":false},"assignees":[{"login":"dlabaj","id":6126356,"node_id":"MDQ6VXNlcjYxMjYzNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/6126356?v=4","gravatar_id":"","url":"https://api.github.com/users/dlabaj","html_url":"https://github.com/dlabaj","followers_url":"https://api.github.com/users/dlabaj/followers","following_url":"https://api.github.com/users/dlabaj/following{/other_user}","gists_url":"https://api.github.com/users/dlabaj/gists{/gist_id}","starred_url":"https://api.github.com/users/dlabaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlabaj/subscriptions","organizations_url":"https://api.github.com/users/dlabaj/orgs","repos_url":"https://api.github.com/users/dlabaj/repos","events_url":"https://api.github.com/users/dlabaj/events{/privacy}","received_events_url":"https://api.github.com/users/dlabaj/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dlabaj","id":6126356,"node_id":"MDQ6VXNlcjYxMjYzNTY=","avatar_url":"https://avatars1.githubusercontent.com/u/6126356?v=4","gravatar_id":"","url":"https://api.github.com/users/dlabaj","html_url":"https://github.com/dlabaj","followers_url":"https://api.github.com/users/dlabaj/followers","following_url":"https://api.github.com/users/dlabaj/following{/other_user}","gists_url":"https://api.github.com/users/dlabaj/gists{/gist_id}","starred_url":"https://api.github.com/users/dlabaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlabaj/subscriptions","organizations_url":"https://api.github.com/users/dlabaj/orgs","repos_url":"https://api.github.com/users/dlabaj/repos","events_url":"https://api.github.com/users/dlabaj/events{/privacy}","received_events_url":"https://api.github.com/users/dlabaj/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":956908271,"node_id":"MDU6TGFiZWw5NTY5MDgyNzE=","url":"https://api.github.com/repos/patternfly/patternfly-react/labels/PF4","name":"PF4","color":"20457c","default":false},{"id":1161947967,"node_id":"MDU6TGFiZWwxMTYxOTQ3OTY3","url":"https://api.github.com/repos/patternfly/patternfly-react/labels/infrastructure","name":"infrastructure","color":"2553dd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/1570/commits","review_comments_url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/1570/comments","review_comment_url":"https://api.github.com/repos/patternfly/patternfly-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patternfly/patternfly-react/issues/1570/comments","statuses_url":"https://api.github.com/repos/patternfly/patternfly-react/statuses/b1d9d90358d05728274d11886378837a5dca1c99","head":{"label":"redallen:feat/aboutmodal-to-ts","ref":"feat/aboutmodal-to-ts","sha":"b1d9d90358d05728274d11886378837a5dca1c99","user":{"login":"redallen","id":47335686,"node_id":"MDQ6VXNlcjQ3MzM1Njg2","avatar_url":"https://avatars1.githubusercontent.com/u/47335686?v=4","gravatar_id":"","url":"https://api.github.com/users/redallen","html_url":"https://github.com/redallen","followers_url":"https://api.github.com/users/redallen/followers","following_url":"https://api.github.com/users/redallen/following{/other_user}","gists_url":"https://api.github.com/users/redallen/gists{/gist_id}","starred_url":"https://api.github.com/users/redallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redallen/subscriptions","organizations_url":"https://api.github.com/users/redallen/orgs","repos_url":"https://api.github.com/users/redallen/repos","events_url":"https://api.github.com/users/redallen/events{/privacy}","received_events_url":"https://api.github.com/users/redallen/received_events","type":"User","site_admin":false},"repo":{"id":169150273,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkxNTAyNzM=","name":"patternfly-react","full_name":"redallen/patternfly-react","private":false,"owner":{"login":"redallen","id":47335686,"node_id":"MDQ6VXNlcjQ3MzM1Njg2","avatar_url":"https://avatars1.githubusercontent.com/u/47335686?v=4","gravatar_id":"","url":"https://api.github.com/users/redallen","html_url":"https://github.com/redallen","followers_url":"https://api.github.com/users/redallen/followers","following_url":"https://api.github.com/users/redallen/following{/other_user}","gists_url":"https://api.github.com/users/redallen/gists{/gist_id}","starred_url":"https://api.github.com/users/redallen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redallen/subscriptions","organizations_url":"https://api.github.com/users/redallen/orgs","repos_url":"https://api.github.com/users/redallen/repos","events_url":"https://api.github.com/users/redallen/events{/privacy}","received_events_url":"https://api.github.com/users/redallen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/redallen/patternfly-react","description":"A set of React components for the PatternFly project. ","fork":true,"url":"https://api.github.com/repos/redallen/patternfly-react","forks_url":"https://api.github.com/repos/redallen/patternfly-react/forks","keys_url":"https://api.github.com/repos/redallen/patternfly-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redallen/patternfly-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redallen/patternfly-react/teams","hooks_url":"https://api.github.com/repos/redallen/patternfly-react/hooks","issue_events_url":"https://api.github.com/repos/redallen/patternfly-react/issues/events{/number}","events_url":"https://api.github.com/repos/redallen/patternfly-react/events","assignees_url":"https://api.github.com/repos/redallen/patternfly-react/assignees{/user}","branches_url":"https://api.github.com/repos/redallen/patternfly-react/branches{/branch}","tags_url":"https://api.github.com/repos/redallen/patternfly-react/tags","blobs_url":"https://api.github.com/repos/redallen/patternfly-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redallen/patternfly-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redallen/patternfly-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/redallen/patternfly-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redallen/patternfly-react/statuses/{sha}","languages_url":"https://api.github.com/repos/redallen/patternfly-react/languages","stargazers_url":"https://api.github.com/repos/redallen/patternfly-react/stargazers","contributors_url":"https://api.github.com/repos/redallen/patternfly-react/contributors","subscribers_url":"https://api.github.com/repos/redallen/patternfly-react/subscribers","subscription_url":"https://api.github.com/repos/redallen/patternfly-react/subscription","commits_url":"https://api.github.com/repos/redallen/patternfly-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/redallen/patternfly-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/redallen/patternfly-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/redallen/patternfly-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/redallen/patternfly-react/contents/{+path}","compare_url":"https://api.github.com/repos/redallen/patternfly-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redallen/patternfly-react/merges","archive_url":"https://api.github.com/repos/redallen/patternfly-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redallen/patternfly-react/downloads","issues_url":"https://api.github.com/repos/redallen/patternfly-react/issues{/number}","pulls_url":"https://api.github.com/repos/redallen/patternfly-react/pulls{/number}","milestones_url":"https://api.github.com/repos/redallen/patternfly-react/milestones{/number}","notifications_url":"https://api.github.com/repos/redallen/patternfly-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redallen/patternfly-react/labels{/name}","releases_url":"https://api.github.com/repos/redallen/patternfly-react/releases{/id}","deployments_url":"https://api.github.com/repos/redallen/patternfly-react/deployments","created_at":"2019-02-04T21:09:53Z","updated_at":"2019-02-27T16:35:12Z","pushed_at":"2019-03-18T14:54:17Z","git_url":"git://github.com/redallen/patternfly-react.git","ssh_url":"[email protected]:redallen/patternfly-react.git","clone_url":"https://github.com/redallen/patternfly-react.git","svn_url":"https://github.com/redallen/patternfly-react","homepage":"http://patternfly-react.surge.sh","size":10475,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"patternfly:master","ref":"master","sha":"5fffb9a1ce7175cfbacf22cdf17f3552df290062","user":{"login":"patternfly","id":6391110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTExMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"repo":{"id":84372347,"node_id":"MDEwOlJlcG9zaXRvcnk4NDM3MjM0Nw==","name":"patternfly-react","full_name":"patternfly/patternfly-react","private":false,"owner":{"login":"patternfly","id":6391110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTExMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/patternfly/patternfly-react","description":"A set of React components for the PatternFly project. ","fork":false,"url":"https://api.github.com/repos/patternfly/patternfly-react","forks_url":"https://api.github.com/repos/patternfly/patternfly-react/forks","keys_url":"https://api.github.com/repos/patternfly/patternfly-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patternfly/patternfly-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patternfly/patternfly-react/teams","hooks_url":"https://api.github.com/repos/patternfly/patternfly-react/hooks","issue_events_url":"https://api.github.com/repos/patternfly/patternfly-react/issues/events{/number}","events_url":"https://api.github.com/repos/patternfly/patternfly-react/events","assignees_url":"https://api.github.com/repos/patternfly/patternfly-react/assignees{/user}","branches_url":"https://api.github.com/repos/patternfly/patternfly-react/branches{/branch}","tags_url":"https://api.github.com/repos/patternfly/patternfly-react/tags","blobs_url":"https://api.github.com/repos/patternfly/patternfly-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patternfly/patternfly-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patternfly/patternfly-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/patternfly/patternfly-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patternfly/patternfly-react/statuses/{sha}","languages_url":"https://api.github.com/repos/patternfly/patternfly-react/languages","stargazers_url":"https://api.github.com/repos/patternfly/patternfly-react/stargazers","contributors_url":"https://api.github.com/repos/patternfly/patternfly-react/contributors","subscribers_url":"https://api.github.com/repos/patternfly/patternfly-react/subscribers","subscription_url":"https://api.github.com/repos/patternfly/patternfly-react/subscription","commits_url":"https://api.github.com/repos/patternfly/patternfly-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/patternfly/patternfly-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/patternfly/patternfly-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/patternfly/patternfly-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/patternfly/patternfly-react/contents/{+path}","compare_url":"https://api.github.com/repos/patternfly/patternfly-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patternfly/patternfly-react/merges","archive_url":"https://api.github.com/repos/patternfly/patternfly-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patternfly/patternfly-react/downloads","issues_url":"https://api.github.com/repos/patternfly/patternfly-react/issues{/number}","pulls_url":"https://api.github.com/repos/patternfly/patternfly-react/pulls{/number}","milestones_url":"https://api.github.com/repos/patternfly/patternfly-react/milestones{/number}","notifications_url":"https://api.github.com/repos/patternfly/patternfly-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patternfly/patternfly-react/labels{/name}","releases_url":"https://api.github.com/repos/patternfly/patternfly-react/releases{/id}","deployments_url":"https://api.github.com/repos/patternfly/patternfly-react/deployments","created_at":"2017-03-08T22:31:12Z","updated_at":"2019-03-18T15:10:19Z","pushed_at":"2019-03-18T15:24:58Z","git_url":"git://github.com/patternfly/patternfly-react.git","ssh_url":"[email protected]:patternfly/patternfly-react.git","clone_url":"https://github.com/patternfly/patternfly-react.git","svn_url":"https://github.com/patternfly/patternfly-react","homepage":"http://patternfly-react.surge.sh","size":24749,"stargazers_count":231,"watchers_count":231,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":129,"mirror_url":null,"archived":false,"open_issues_count":213,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":129,"open_issues":213,"watchers":231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/1570"},"html":{"href":"https://github.com/patternfly/patternfly-react/pull/1570"},"issue":{"href":"https://api.github.com/repos/patternfly/patternfly-react/issues/1570"},"comments":{"href":"https://api.github.com/repos/patternfly/patternfly-react/issues/1570/comments"},"review_comments":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/1570/comments"},"review_comment":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patternfly/patternfly-react/pulls/1570/commits"},"statuses":{"href":"https://api.github.com/repos/patternfly/patternfly-react/statuses/b1d9d90358d05728274d11886378837a5dca1c99"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 84372347,
"name": "patternfly/patternfly-react",
"url": "https://api.github.com/repos/patternfly/patternfly-react"
}
|
{
"id": 869106,
"login": "jschuler",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/869106?",
"url": "https://api.github.com/users/jschuler"
}
|
{
"id": 6391110,
"login": "patternfly",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6391110?",
"url": "https://api.github.com/orgs/patternfly"
}
| 2019-03-18T16:08:52 |
9264544239
|
{"actor":{"display_login":"jschuler"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/reactjs/pl.reactjs.org/pulls/comments/282258546","pull_request_review_id":235304273,"id":282258546,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MjI1ODU0Ng==","diff_hunk":"@@ -212,19 +225,19 @@ const MyComponent = () => (\n );\n ```\n \n-## Route-based code splitting {#route-based-code-splitting}\n+## Podział kodu na podstawie szlaku (Route-based) {#route-based-code-splitting}\n \n-Deciding where in your app to introduce code splitting can be a bit tricky. You\n-want to make sure you choose places that will split bundles evenly, but won't\n-disrupt the user experience.\n+Decydowanie gdzie w twojej aplikacji użyć podziału kodu może być nieco skomplikowane.\n+Chcesz mieć pewność, że wybierasz miejsca, które równomiernie podzielą twoje pakiety,","path":"content/docs/code-splitting.md","position":243,"original_position":243,"commit_id":"6dbe405243e5321b869d6c82ffe35c1abe14ade0","original_commit_id":"6dbe405243e5321b869d6c82ffe35c1abe14ade0","user":{"login":"jakubdrozdek","id":30927218,"node_id":"MDQ6VXNlcjMwOTI3MjE4","avatar_url":"https://avatars0.githubusercontent.com/u/30927218?v=4","gravatar_id":"","url":"https://api.github.com/users/jakubdrozdek","html_url":"https://github.com/jakubdrozdek","followers_url":"https://api.github.com/users/jakubdrozdek/followers","following_url":"https://api.github.com/users/jakubdrozdek/following{/other_user}","gists_url":"https://api.github.com/users/jakubdrozdek/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubdrozdek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubdrozdek/subscriptions","organizations_url":"https://api.github.com/users/jakubdrozdek/orgs","repos_url":"https://api.github.com/users/jakubdrozdek/repos","events_url":"https://api.github.com/users/jakubdrozdek/events{/privacy}","received_events_url":"https://api.github.com/users/jakubdrozdek/received_events","type":"User","site_admin":false},"body":"```suggestion\r\nZależy ci na miejscach, które równomiernie podzielą twoje pakiety,\r\n```","created_at":"2019-05-08T21:34:26Z","updated_at":"2019-05-08T21:34:27Z","html_url":"https://github.com/reactjs/pl.reactjs.org/pull/86#discussion_r282258546","pull_request_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/pulls/86","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/reactjs/pl.reactjs.org/pulls/comments/282258546"},"html":{"href":"https://github.com/reactjs/pl.reactjs.org/pull/86#discussion_r282258546"},"pull_request":{"href":"https://api.github.com/repos/reactjs/pl.reactjs.org/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/reactjs/pl.reactjs.org/pulls/86","id":276786892,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc2Nzg2ODky","html_url":"https://github.com/reactjs/pl.reactjs.org/pull/86","diff_url":"https://github.com/reactjs/pl.reactjs.org/pull/86.diff","patch_url":"https://github.com/reactjs/pl.reactjs.org/pull/86.patch","issue_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/issues/86","number":86,"state":"open","locked":false,"title":"Translate 'code-splitting' page","user":{"login":"JakeTvvv","id":39670088,"node_id":"MDQ6VXNlcjM5NjcwMDg4","avatar_url":"https://avatars3.githubusercontent.com/u/39670088?v=4","gravatar_id":"","url":"https://api.github.com/users/JakeTvvv","html_url":"https://github.com/JakeTvvv","followers_url":"https://api.github.com/users/JakeTvvv/followers","following_url":"https://api.github.com/users/JakeTvvv/following{/other_user}","gists_url":"https://api.github.com/users/JakeTvvv/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeTvvv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeTvvv/subscriptions","organizations_url":"https://api.github.com/users/JakeTvvv/orgs","repos_url":"https://api.github.com/users/JakeTvvv/repos","events_url":"https://api.github.com/users/JakeTvvv/events{/privacy}","received_events_url":"https://api.github.com/users/JakeTvvv/received_events","type":"User","site_admin":false},"body":"\r\n<!--\r\n\r\nThank you for the PR! Contributors like you keep React awesome!\r\n\r\nPlease see the Contribution Guide for guidelines:\r\n\r\nhttps://github.com/reactjs/reactjs.org/blob/master/CONTRIBUTING.md\r\n\r\nIf your PR references an existing issue, please add the issue number below\r\n\r\n-->\r\n","created_at":"2019-05-07T22:00:44Z","updated_at":"2019-05-08T21:34:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37250cde7653aaeee999e66aea335572163f1551","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/pulls/86/commits","review_comments_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/pulls/86/comments","review_comment_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/issues/86/comments","statuses_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/statuses/6dbe405243e5321b869d6c82ffe35c1abe14ade0","head":{"label":"JakeTvvv:master","ref":"master","sha":"6dbe405243e5321b869d6c82ffe35c1abe14ade0","user":{"login":"JakeTvvv","id":39670088,"node_id":"MDQ6VXNlcjM5NjcwMDg4","avatar_url":"https://avatars3.githubusercontent.com/u/39670088?v=4","gravatar_id":"","url":"https://api.github.com/users/JakeTvvv","html_url":"https://github.com/JakeTvvv","followers_url":"https://api.github.com/users/JakeTvvv/followers","following_url":"https://api.github.com/users/JakeTvvv/following{/other_user}","gists_url":"https://api.github.com/users/JakeTvvv/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeTvvv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeTvvv/subscriptions","organizations_url":"https://api.github.com/users/JakeTvvv/orgs","repos_url":"https://api.github.com/users/JakeTvvv/repos","events_url":"https://api.github.com/users/JakeTvvv/events{/privacy}","received_events_url":"https://api.github.com/users/JakeTvvv/received_events","type":"User","site_admin":false},"repo":{"id":185464755,"node_id":"MDEwOlJlcG9zaXRvcnkxODU0NjQ3NTU=","name":"pl.reactjs.org","full_name":"JakeTvvv/pl.reactjs.org","private":false,"owner":{"login":"JakeTvvv","id":39670088,"node_id":"MDQ6VXNlcjM5NjcwMDg4","avatar_url":"https://avatars3.githubusercontent.com/u/39670088?v=4","gravatar_id":"","url":"https://api.github.com/users/JakeTvvv","html_url":"https://github.com/JakeTvvv","followers_url":"https://api.github.com/users/JakeTvvv/followers","following_url":"https://api.github.com/users/JakeTvvv/following{/other_user}","gists_url":"https://api.github.com/users/JakeTvvv/gists{/gist_id}","starred_url":"https://api.github.com/users/JakeTvvv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JakeTvvv/subscriptions","organizations_url":"https://api.github.com/users/JakeTvvv/orgs","repos_url":"https://api.github.com/users/JakeTvvv/repos","events_url":"https://api.github.com/users/JakeTvvv/events{/privacy}","received_events_url":"https://api.github.com/users/JakeTvvv/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JakeTvvv/pl.reactjs.org","description":"(Work in progress) React documentation website in Polish","fork":true,"url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org","forks_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/forks","keys_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/teams","hooks_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/hooks","issue_events_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/issues/events{/number}","events_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/events","assignees_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/assignees{/user}","branches_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/branches{/branch}","tags_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/tags","blobs_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/statuses/{sha}","languages_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/languages","stargazers_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/stargazers","contributors_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/contributors","subscribers_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/subscribers","subscription_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/subscription","commits_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/contents/{+path}","compare_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/merges","archive_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/downloads","issues_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/issues{/number}","pulls_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/pulls{/number}","milestones_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/milestones{/number}","notifications_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/labels{/name}","releases_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/releases{/id}","deployments_url":"https://api.github.com/repos/JakeTvvv/pl.reactjs.org/deployments","created_at":"2019-05-07T19:22:13Z","updated_at":"2019-05-08T21:20:38Z","pushed_at":"2019-05-08T21:20:36Z","git_url":"git://github.com/JakeTvvv/pl.reactjs.org.git","ssh_url":"[email protected]:JakeTvvv/pl.reactjs.org.git","clone_url":"https://github.com/JakeTvvv/pl.reactjs.org.git","svn_url":"https://github.com/JakeTvvv/pl.reactjs.org","homepage":null,"size":71473,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactjs:master","ref":"master","sha":"b941619c61d3bcc9274b438538a41c827ed0b0b7","user":{"login":"reactjs","id":6412038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTIwMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/6412038?v=4","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":170015671,"node_id":"MDEwOlJlcG9zaXRvcnkxNzAwMTU2NzE=","name":"pl.reactjs.org","full_name":"reactjs/pl.reactjs.org","private":false,"owner":{"login":"reactjs","id":6412038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTIwMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/6412038?v=4","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reactjs/pl.reactjs.org","description":"(Work in progress) React documentation website in Polish","fork":false,"url":"https://api.github.com/repos/reactjs/pl.reactjs.org","forks_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/forks","keys_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/teams","hooks_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/hooks","issue_events_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/issues/events{/number}","events_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/events","assignees_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/assignees{/user}","branches_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/branches{/branch}","tags_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/tags","blobs_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/statuses/{sha}","languages_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/languages","stargazers_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/stargazers","contributors_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/contributors","subscribers_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/subscribers","subscription_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/subscription","commits_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/contents/{+path}","compare_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/merges","archive_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/downloads","issues_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/issues{/number}","pulls_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/pulls{/number}","milestones_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/milestones{/number}","notifications_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/labels{/name}","releases_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/releases{/id}","deployments_url":"https://api.github.com/repos/reactjs/pl.reactjs.org/deployments","created_at":"2019-02-10T19:12:45Z","updated_at":"2019-05-08T15:01:46Z","pushed_at":"2019-05-08T21:20:38Z","git_url":"git://github.com/reactjs/pl.reactjs.org.git","ssh_url":"[email protected]:reactjs/pl.reactjs.org.git","clone_url":"https://github.com/reactjs/pl.reactjs.org.git","svn_url":"https://github.com/reactjs/pl.reactjs.org","homepage":null,"size":71477,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":17,"open_issues":4,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactjs/pl.reactjs.org/pulls/86"},"html":{"href":"https://github.com/reactjs/pl.reactjs.org/pull/86"},"issue":{"href":"https://api.github.com/repos/reactjs/pl.reactjs.org/issues/86"},"comments":{"href":"https://api.github.com/repos/reactjs/pl.reactjs.org/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/reactjs/pl.reactjs.org/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/reactjs/pl.reactjs.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactjs/pl.reactjs.org/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/reactjs/pl.reactjs.org/statuses/6dbe405243e5321b869d6c82ffe35c1abe14ade0"}},"author_association":"NONE"}}
|
{
"id": 170015671,
"name": "reactjs/pl.reactjs.org",
"url": "https://api.github.com/repos/reactjs/pl.reactjs.org"
}
|
{
"id": 30927218,
"login": "jakubdrozdek",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30927218?",
"url": "https://api.github.com/users/jakubdrozdek"
}
|
{
"id": 6412038,
"login": "reactjs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6412038?",
"url": "https://api.github.com/orgs/reactjs"
}
| 2019-05-08T21:34:26 |
9589603583
|
{"actor":{"display_login":"jakubdrozdek"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/pulls/comments/264060718","pull_request_review_id":212623881,"id":264060718,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NDA2MDcxOA==","diff_hunk":"@@ -1,33 +1,34 @@\n ---\n id: support\n-title: Where To Get Support\n+title: Como obter Suporte\n layout: community\n sectionid: community\n permalink: community/support.html\n redirect_from:\n - \"support.html\"\n ---\n \n-React has a community of millions of developers.\n+O React conta com uma comunidade de milhões de desenvolvedores.\n \n-On this page we've listed some React-related communities that you can be a part of; see the other pages in this section for additional online and in-person learning materials.\n+Nesta página, mostraremos algumas comunidades relacionadas ao React que você pode fazer parte;\n+Veja as outras páginas desta seção para obter materiais de aprendizagem adicionais online e presencial.","path":"content/community/support.md","position":17,"original_position":17,"commit_id":"3e4f4f41482f8c6015f948573e7d3dca1d7cd063","original_commit_id":"3e4f4f41482f8c6015f948573e7d3dca1d7cd063","user":{"login":"jhonmike","id":2499937,"node_id":"MDQ6VXNlcjI0OTk5Mzc=","avatar_url":"https://avatars1.githubusercontent.com/u/2499937?v=4","gravatar_id":"","url":"https://api.github.com/users/jhonmike","html_url":"https://github.com/jhonmike","followers_url":"https://api.github.com/users/jhonmike/followers","following_url":"https://api.github.com/users/jhonmike/following{/other_user}","gists_url":"https://api.github.com/users/jhonmike/gists{/gist_id}","starred_url":"https://api.github.com/users/jhonmike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhonmike/subscriptions","organizations_url":"https://api.github.com/users/jhonmike/orgs","repos_url":"https://api.github.com/users/jhonmike/repos","events_url":"https://api.github.com/users/jhonmike/events{/privacy}","received_events_url":"https://api.github.com/users/jhonmike/received_events","type":"User","site_admin":false},"body":"Os itens acima estão na mesma linha na versão em inglês, se puder remover esse enter. Para evitar problemas com o bot que faz o de/para das alterações feitas na \"doc oficial\".","created_at":"2019-03-10T21:50:02Z","updated_at":"2019-03-10T21:54:39Z","html_url":"https://github.com/reactjs/pt-BR.reactjs.org/pull/152#discussion_r264060718","pull_request_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/pulls/152","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/pulls/comments/264060718"},"html":{"href":"https://github.com/reactjs/pt-BR.reactjs.org/pull/152#discussion_r264060718"},"pull_request":{"href":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/pulls/152","id":259781890,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5NzgxODkw","html_url":"https://github.com/reactjs/pt-BR.reactjs.org/pull/152","diff_url":"https://github.com/reactjs/pt-BR.reactjs.org/pull/152.diff","patch_url":"https://github.com/reactjs/pt-BR.reactjs.org/pull/152.patch","issue_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/issues/152","number":152,"state":"open","locked":false,"title":"Traduzido a página Community/Support (Comunidade/Suporte)","user":{"login":"Duduzera1997","id":35508801,"node_id":"MDQ6VXNlcjM1NTA4ODAx","avatar_url":"https://avatars0.githubusercontent.com/u/35508801?v=4","gravatar_id":"","url":"https://api.github.com/users/Duduzera1997","html_url":"https://github.com/Duduzera1997","followers_url":"https://api.github.com/users/Duduzera1997/followers","following_url":"https://api.github.com/users/Duduzera1997/following{/other_user}","gists_url":"https://api.github.com/users/Duduzera1997/gists{/gist_id}","starred_url":"https://api.github.com/users/Duduzera1997/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Duduzera1997/subscriptions","organizations_url":"https://api.github.com/users/Duduzera1997/orgs","repos_url":"https://api.github.com/users/Duduzera1997/repos","events_url":"https://api.github.com/users/Duduzera1997/events{/privacy}","received_events_url":"https://api.github.com/users/Duduzera1997/received_events","type":"User","site_admin":false},"body":"\r\n<!--\r\n\r\nThank you for the PR! Contributors like you keep React awesome!\r\n\r\nPlease see the Contribution Guide for guidelines:\r\n\r\nhttps://github.com/reactjs/reactjs.org/blob/master/CONTRIBUTING.md\r\n\r\nIf your PR references an existing issue, please add the issue number below\r\n\r\n-->\r\n","created_at":"2019-03-10T19:12:18Z","updated_at":"2019-03-10T21:54:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac4c698e683da0ecbdddc4f0a6c9156bc5981346","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1225498164,"node_id":"MDU6TGFiZWwxMjI1NDk4MTY0","url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/labels/needs%20review","name":"needs review","color":"4b1584","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/pulls/152/commits","review_comments_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/pulls/152/comments","review_comment_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/issues/152/comments","statuses_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/statuses/3e4f4f41482f8c6015f948573e7d3dca1d7cd063","head":{"label":"Duduzera1997:master","ref":"master","sha":"3e4f4f41482f8c6015f948573e7d3dca1d7cd063","user":{"login":"Duduzera1997","id":35508801,"node_id":"MDQ6VXNlcjM1NTA4ODAx","avatar_url":"https://avatars0.githubusercontent.com/u/35508801?v=4","gravatar_id":"","url":"https://api.github.com/users/Duduzera1997","html_url":"https://github.com/Duduzera1997","followers_url":"https://api.github.com/users/Duduzera1997/followers","following_url":"https://api.github.com/users/Duduzera1997/following{/other_user}","gists_url":"https://api.github.com/users/Duduzera1997/gists{/gist_id}","starred_url":"https://api.github.com/users/Duduzera1997/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Duduzera1997/subscriptions","organizations_url":"https://api.github.com/users/Duduzera1997/orgs","repos_url":"https://api.github.com/users/Duduzera1997/repos","events_url":"https://api.github.com/users/Duduzera1997/events{/privacy}","received_events_url":"https://api.github.com/users/Duduzera1997/received_events","type":"User","site_admin":false},"repo":{"id":174851235,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQ4NTEyMzU=","name":"pt-BR.reactjs.org","full_name":"Duduzera1997/pt-BR.reactjs.org","private":false,"owner":{"login":"Duduzera1997","id":35508801,"node_id":"MDQ6VXNlcjM1NTA4ODAx","avatar_url":"https://avatars0.githubusercontent.com/u/35508801?v=4","gravatar_id":"","url":"https://api.github.com/users/Duduzera1997","html_url":"https://github.com/Duduzera1997","followers_url":"https://api.github.com/users/Duduzera1997/followers","following_url":"https://api.github.com/users/Duduzera1997/following{/other_user}","gists_url":"https://api.github.com/users/Duduzera1997/gists{/gist_id}","starred_url":"https://api.github.com/users/Duduzera1997/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Duduzera1997/subscriptions","organizations_url":"https://api.github.com/users/Duduzera1997/orgs","repos_url":"https://api.github.com/users/Duduzera1997/repos","events_url":"https://api.github.com/users/Duduzera1997/events{/privacy}","received_events_url":"https://api.github.com/users/Duduzera1997/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Duduzera1997/pt-BR.reactjs.org","description":"(Work in progress) 🇧🇷React documentation website in Portuguese (Brazil)","fork":true,"url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org","forks_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/forks","keys_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/teams","hooks_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/hooks","issue_events_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/issues/events{/number}","events_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/events","assignees_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/assignees{/user}","branches_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/branches{/branch}","tags_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/tags","blobs_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/statuses/{sha}","languages_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/languages","stargazers_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/stargazers","contributors_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/contributors","subscribers_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/subscribers","subscription_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/subscription","commits_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/contents/{+path}","compare_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/merges","archive_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/downloads","issues_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/issues{/number}","pulls_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/pulls{/number}","milestones_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/milestones{/number}","notifications_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/labels{/name}","releases_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/releases{/id}","deployments_url":"https://api.github.com/repos/Duduzera1997/pt-BR.reactjs.org/deployments","created_at":"2019-03-10T16:40:21Z","updated_at":"2019-03-10T18:40:16Z","pushed_at":"2019-03-10T18:40:15Z","git_url":"git://github.com/Duduzera1997/pt-BR.reactjs.org.git","ssh_url":"[email protected]:Duduzera1997/pt-BR.reactjs.org.git","clone_url":"https://github.com/Duduzera1997/pt-BR.reactjs.org.git","svn_url":"https://github.com/Duduzera1997/pt-BR.reactjs.org","homepage":"","size":71521,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactjs:master","ref":"master","sha":"ff477814ca2a3f80e031cdf16b57ab90e99d3183","user":{"login":"reactjs","id":6412038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTIwMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/6412038?v=4","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":169668554,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk2Njg1NTQ=","name":"pt-BR.reactjs.org","full_name":"reactjs/pt-BR.reactjs.org","private":false,"owner":{"login":"reactjs","id":6412038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTIwMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/6412038?v=4","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reactjs/pt-BR.reactjs.org","description":"(Work in progress) 🇧🇷React documentation website in Portuguese (Brazil)","fork":false,"url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org","forks_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/forks","keys_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/teams","hooks_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/hooks","issue_events_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/issues/events{/number}","events_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/events","assignees_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/assignees{/user}","branches_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/branches{/branch}","tags_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/tags","blobs_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/statuses/{sha}","languages_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/languages","stargazers_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/stargazers","contributors_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/contributors","subscribers_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/subscribers","subscription_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/subscription","commits_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/contents/{+path}","compare_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/merges","archive_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/downloads","issues_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/issues{/number}","pulls_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/pulls{/number}","milestones_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/milestones{/number}","notifications_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/labels{/name}","releases_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/releases{/id}","deployments_url":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/deployments","created_at":"2019-02-08T01:15:04Z","updated_at":"2019-03-10T21:53:08Z","pushed_at":"2019-03-10T21:44:00Z","git_url":"git://github.com/reactjs/pt-BR.reactjs.org.git","ssh_url":"[email protected]:reactjs/pt-BR.reactjs.org.git","clone_url":"https://github.com/reactjs/pt-BR.reactjs.org.git","svn_url":"https://github.com/reactjs/pt-BR.reactjs.org","homepage":"","size":71512,"stargazers_count":118,"watchers_count":118,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":88,"open_issues":10,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/pulls/152"},"html":{"href":"https://github.com/reactjs/pt-BR.reactjs.org/pull/152"},"issue":{"href":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/issues/152"},"comments":{"href":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/reactjs/pt-BR.reactjs.org/statuses/3e4f4f41482f8c6015f948573e7d3dca1d7cd063"}},"author_association":"NONE"}}
|
{
"id": 169668554,
"name": "reactjs/pt-BR.reactjs.org",
"url": "https://api.github.com/repos/reactjs/pt-BR.reactjs.org"
}
|
{
"id": 2499937,
"login": "jhonmike",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2499937?",
"url": "https://api.github.com/users/jhonmike"
}
|
{
"id": 6412038,
"login": "reactjs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6412038?",
"url": "https://api.github.com/orgs/reactjs"
}
| 2019-03-10T21:50:02 |
9214699104
|
{"actor":{"display_login":"jhonmike"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/reactjs/te.reactjs.org/pulls/comments/280861381","pull_request_review_id":233578472,"id":280861381,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MDg2MTM4MQ==","diff_hunk":"@@ -13,15 +13,15 @@ class TodoApp extends React.Component {\n <TodoList items={this.state.items} />\n <form onSubmit={this.handleSubmit}>\n <label htmlFor=\"new-todo\">\n- What needs to be done?\n+ ఏమి చేయాలి?\n </label>\n <input\n id=\"new-todo\"\n onChange={this.handleChange}\n value={this.state.text}\n />\n <button>\n- Add #{this.state.items.length + 1}\n+ చేర్చు #{this.state.items.length + 1}","path":"content/home/examples/an-application.js","position":14,"original_position":14,"commit_id":"4b6fa3db5d72adcd05c5b97cb2b8bd9ce1323054","original_commit_id":"4b6fa3db5d72adcd05c5b97cb2b8bd9ce1323054","user":{"login":"ChaituKNag","id":13428505,"node_id":"MDQ6VXNlcjEzNDI4NTA1","avatar_url":"https://avatars0.githubusercontent.com/u/13428505?v=4","gravatar_id":"","url":"https://api.github.com/users/ChaituKNag","html_url":"https://github.com/ChaituKNag","followers_url":"https://api.github.com/users/ChaituKNag/followers","following_url":"https://api.github.com/users/ChaituKNag/following{/other_user}","gists_url":"https://api.github.com/users/ChaituKNag/gists{/gist_id}","starred_url":"https://api.github.com/users/ChaituKNag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChaituKNag/subscriptions","organizations_url":"https://api.github.com/users/ChaituKNag/orgs","repos_url":"https://api.github.com/users/ChaituKNag/repos","events_url":"https://api.github.com/users/ChaituKNag/events{/privacy}","received_events_url":"https://api.github.com/users/ChaituKNag/received_events","type":"User","site_admin":false},"body":"కూడించు ","created_at":"2019-05-03T17:28:10Z","updated_at":"2019-05-03T17:40:51Z","html_url":"https://github.com/reactjs/te.reactjs.org/pull/2#discussion_r280861381","pull_request_url":"https://api.github.com/repos/reactjs/te.reactjs.org/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/reactjs/te.reactjs.org/pulls/comments/280861381"},"html":{"href":"https://github.com/reactjs/te.reactjs.org/pull/2#discussion_r280861381"},"pull_request":{"href":"https://api.github.com/repos/reactjs/te.reactjs.org/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/reactjs/te.reactjs.org/pulls/2","id":259383515,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5MzgzNTE1","html_url":"https://github.com/reactjs/te.reactjs.org/pull/2","diff_url":"https://github.com/reactjs/te.reactjs.org/pull/2.diff","patch_url":"https://github.com/reactjs/te.reactjs.org/pull/2.patch","issue_url":"https://api.github.com/repos/reactjs/te.reactjs.org/issues/2","number":2,"state":"open","locked":false,"title":"Converts Home marketing pages to telugu","user":{"login":"ashr81","id":5508780,"node_id":"MDQ6VXNlcjU1MDg3ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/5508780?v=4","gravatar_id":"","url":"https://api.github.com/users/ashr81","html_url":"https://github.com/ashr81","followers_url":"https://api.github.com/users/ashr81/followers","following_url":"https://api.github.com/users/ashr81/following{/other_user}","gists_url":"https://api.github.com/users/ashr81/gists{/gist_id}","starred_url":"https://api.github.com/users/ashr81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashr81/subscriptions","organizations_url":"https://api.github.com/users/ashr81/orgs","repos_url":"https://api.github.com/users/ashr81/repos","events_url":"https://api.github.com/users/ashr81/events{/privacy}","received_events_url":"https://api.github.com/users/ashr81/received_events","type":"User","site_admin":false},"body":"\r\n<!--\r\n\r\nThank you for the PR! Contributors like you keep React awesome!\r\n\r\nPlease see the Contribution Guide for guidelines:\r\n\r\nhttps://github.com/reactjs/reactjs.org/blob/master/CONTRIBUTING.md\r\n\r\nIf your PR references an existing issue, please add the issue number below\r\n\r\n-->\r\n","created_at":"2019-03-08T07:13:24Z","updated_at":"2019-05-03T17:40:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9da7525f8948a163746cb16b3898e376293810f8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"daminisatya","id":6227784,"node_id":"MDQ6VXNlcjYyMjc3ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6227784?v=4","gravatar_id":"","url":"https://api.github.com/users/daminisatya","html_url":"https://github.com/daminisatya","followers_url":"https://api.github.com/users/daminisatya/followers","following_url":"https://api.github.com/users/daminisatya/following{/other_user}","gists_url":"https://api.github.com/users/daminisatya/gists{/gist_id}","starred_url":"https://api.github.com/users/daminisatya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daminisatya/subscriptions","organizations_url":"https://api.github.com/users/daminisatya/orgs","repos_url":"https://api.github.com/users/daminisatya/repos","events_url":"https://api.github.com/users/daminisatya/events{/privacy}","received_events_url":"https://api.github.com/users/daminisatya/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reactjs/te.reactjs.org/pulls/2/commits","review_comments_url":"https://api.github.com/repos/reactjs/te.reactjs.org/pulls/2/comments","review_comment_url":"https://api.github.com/repos/reactjs/te.reactjs.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactjs/te.reactjs.org/issues/2/comments","statuses_url":"https://api.github.com/repos/reactjs/te.reactjs.org/statuses/4b6fa3db5d72adcd05c5b97cb2b8bd9ce1323054","head":{"label":"ashr81:home-marketing-pages","ref":"home-marketing-pages","sha":"4b6fa3db5d72adcd05c5b97cb2b8bd9ce1323054","user":{"login":"ashr81","id":5508780,"node_id":"MDQ6VXNlcjU1MDg3ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/5508780?v=4","gravatar_id":"","url":"https://api.github.com/users/ashr81","html_url":"https://github.com/ashr81","followers_url":"https://api.github.com/users/ashr81/followers","following_url":"https://api.github.com/users/ashr81/following{/other_user}","gists_url":"https://api.github.com/users/ashr81/gists{/gist_id}","starred_url":"https://api.github.com/users/ashr81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashr81/subscriptions","organizations_url":"https://api.github.com/users/ashr81/orgs","repos_url":"https://api.github.com/users/ashr81/repos","events_url":"https://api.github.com/users/ashr81/events{/privacy}","received_events_url":"https://api.github.com/users/ashr81/received_events","type":"User","site_admin":false},"repo":{"id":172752531,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI3NTI1MzE=","name":"te.reactjs.org","full_name":"ashr81/te.reactjs.org","private":false,"owner":{"login":"ashr81","id":5508780,"node_id":"MDQ6VXNlcjU1MDg3ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/5508780?v=4","gravatar_id":"","url":"https://api.github.com/users/ashr81","html_url":"https://github.com/ashr81","followers_url":"https://api.github.com/users/ashr81/followers","following_url":"https://api.github.com/users/ashr81/following{/other_user}","gists_url":"https://api.github.com/users/ashr81/gists{/gist_id}","starred_url":"https://api.github.com/users/ashr81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashr81/subscriptions","organizations_url":"https://api.github.com/users/ashr81/orgs","repos_url":"https://api.github.com/users/ashr81/repos","events_url":"https://api.github.com/users/ashr81/events{/privacy}","received_events_url":"https://api.github.com/users/ashr81/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ashr81/te.reactjs.org","description":"(Work in progress) React documentation website in Telugu","fork":true,"url":"https://api.github.com/repos/ashr81/te.reactjs.org","forks_url":"https://api.github.com/repos/ashr81/te.reactjs.org/forks","keys_url":"https://api.github.com/repos/ashr81/te.reactjs.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashr81/te.reactjs.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashr81/te.reactjs.org/teams","hooks_url":"https://api.github.com/repos/ashr81/te.reactjs.org/hooks","issue_events_url":"https://api.github.com/repos/ashr81/te.reactjs.org/issues/events{/number}","events_url":"https://api.github.com/repos/ashr81/te.reactjs.org/events","assignees_url":"https://api.github.com/repos/ashr81/te.reactjs.org/assignees{/user}","branches_url":"https://api.github.com/repos/ashr81/te.reactjs.org/branches{/branch}","tags_url":"https://api.github.com/repos/ashr81/te.reactjs.org/tags","blobs_url":"https://api.github.com/repos/ashr81/te.reactjs.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashr81/te.reactjs.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashr81/te.reactjs.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashr81/te.reactjs.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashr81/te.reactjs.org/statuses/{sha}","languages_url":"https://api.github.com/repos/ashr81/te.reactjs.org/languages","stargazers_url":"https://api.github.com/repos/ashr81/te.reactjs.org/stargazers","contributors_url":"https://api.github.com/repos/ashr81/te.reactjs.org/contributors","subscribers_url":"https://api.github.com/repos/ashr81/te.reactjs.org/subscribers","subscription_url":"https://api.github.com/repos/ashr81/te.reactjs.org/subscription","commits_url":"https://api.github.com/repos/ashr81/te.reactjs.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashr81/te.reactjs.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashr81/te.reactjs.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashr81/te.reactjs.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashr81/te.reactjs.org/contents/{+path}","compare_url":"https://api.github.com/repos/ashr81/te.reactjs.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashr81/te.reactjs.org/merges","archive_url":"https://api.github.com/repos/ashr81/te.reactjs.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashr81/te.reactjs.org/downloads","issues_url":"https://api.github.com/repos/ashr81/te.reactjs.org/issues{/number}","pulls_url":"https://api.github.com/repos/ashr81/te.reactjs.org/pulls{/number}","milestones_url":"https://api.github.com/repos/ashr81/te.reactjs.org/milestones{/number}","notifications_url":"https://api.github.com/repos/ashr81/te.reactjs.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashr81/te.reactjs.org/labels{/name}","releases_url":"https://api.github.com/repos/ashr81/te.reactjs.org/releases{/id}","deployments_url":"https://api.github.com/repos/ashr81/te.reactjs.org/deployments","created_at":"2019-02-26T16:55:00Z","updated_at":"2019-02-26T16:55:04Z","pushed_at":"2019-04-01T05:35:45Z","git_url":"git://github.com/ashr81/te.reactjs.org.git","ssh_url":"[email protected]:ashr81/te.reactjs.org.git","clone_url":"https://github.com/ashr81/te.reactjs.org.git","svn_url":"https://github.com/ashr81/te.reactjs.org","homepage":null,"size":71096,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactjs:master","ref":"master","sha":"b50fe64c1e88489022eddf2cfff0995778827f84","user":{"login":"reactjs","id":6412038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTIwMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/6412038?v=4","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"repo":{"id":172580214,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI1ODAyMTQ=","name":"te.reactjs.org","full_name":"reactjs/te.reactjs.org","private":false,"owner":{"login":"reactjs","id":6412038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0MTIwMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/6412038?v=4","gravatar_id":"","url":"https://api.github.com/users/reactjs","html_url":"https://github.com/reactjs","followers_url":"https://api.github.com/users/reactjs/followers","following_url":"https://api.github.com/users/reactjs/following{/other_user}","gists_url":"https://api.github.com/users/reactjs/gists{/gist_id}","starred_url":"https://api.github.com/users/reactjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactjs/subscriptions","organizations_url":"https://api.github.com/users/reactjs/orgs","repos_url":"https://api.github.com/users/reactjs/repos","events_url":"https://api.github.com/users/reactjs/events{/privacy}","received_events_url":"https://api.github.com/users/reactjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reactjs/te.reactjs.org","description":"(Work in progress) React documentation website in Telugu","fork":false,"url":"https://api.github.com/repos/reactjs/te.reactjs.org","forks_url":"https://api.github.com/repos/reactjs/te.reactjs.org/forks","keys_url":"https://api.github.com/repos/reactjs/te.reactjs.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactjs/te.reactjs.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactjs/te.reactjs.org/teams","hooks_url":"https://api.github.com/repos/reactjs/te.reactjs.org/hooks","issue_events_url":"https://api.github.com/repos/reactjs/te.reactjs.org/issues/events{/number}","events_url":"https://api.github.com/repos/reactjs/te.reactjs.org/events","assignees_url":"https://api.github.com/repos/reactjs/te.reactjs.org/assignees{/user}","branches_url":"https://api.github.com/repos/reactjs/te.reactjs.org/branches{/branch}","tags_url":"https://api.github.com/repos/reactjs/te.reactjs.org/tags","blobs_url":"https://api.github.com/repos/reactjs/te.reactjs.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactjs/te.reactjs.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactjs/te.reactjs.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactjs/te.reactjs.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactjs/te.reactjs.org/statuses/{sha}","languages_url":"https://api.github.com/repos/reactjs/te.reactjs.org/languages","stargazers_url":"https://api.github.com/repos/reactjs/te.reactjs.org/stargazers","contributors_url":"https://api.github.com/repos/reactjs/te.reactjs.org/contributors","subscribers_url":"https://api.github.com/repos/reactjs/te.reactjs.org/subscribers","subscription_url":"https://api.github.com/repos/reactjs/te.reactjs.org/subscription","commits_url":"https://api.github.com/repos/reactjs/te.reactjs.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactjs/te.reactjs.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactjs/te.reactjs.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactjs/te.reactjs.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactjs/te.reactjs.org/contents/{+path}","compare_url":"https://api.github.com/repos/reactjs/te.reactjs.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactjs/te.reactjs.org/merges","archive_url":"https://api.github.com/repos/reactjs/te.reactjs.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactjs/te.reactjs.org/downloads","issues_url":"https://api.github.com/repos/reactjs/te.reactjs.org/issues{/number}","pulls_url":"https://api.github.com/repos/reactjs/te.reactjs.org/pulls{/number}","milestones_url":"https://api.github.com/repos/reactjs/te.reactjs.org/milestones{/number}","notifications_url":"https://api.github.com/repos/reactjs/te.reactjs.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactjs/te.reactjs.org/labels{/name}","releases_url":"https://api.github.com/repos/reactjs/te.reactjs.org/releases{/id}","deployments_url":"https://api.github.com/repos/reactjs/te.reactjs.org/deployments","created_at":"2019-02-25T20:33:16Z","updated_at":"2019-05-03T15:01:09Z","pushed_at":"2019-05-03T15:01:07Z","git_url":"git://github.com/reactjs/te.reactjs.org.git","ssh_url":"[email protected]:reactjs/te.reactjs.org.git","clone_url":"https://github.com/reactjs/te.reactjs.org.git","svn_url":"https://github.com/reactjs/te.reactjs.org","homepage":null,"size":71798,"stargazers_count":5,"watchers_count":5,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":{"key":"cc-by-4.0","name":"Creative Commons Attribution 4.0 International","spdx_id":"CC-BY-4.0","url":"https://api.github.com/licenses/cc-by-4.0","node_id":"MDc6TGljZW5zZTI1"},"forks":5,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactjs/te.reactjs.org/pulls/2"},"html":{"href":"https://github.com/reactjs/te.reactjs.org/pull/2"},"issue":{"href":"https://api.github.com/repos/reactjs/te.reactjs.org/issues/2"},"comments":{"href":"https://api.github.com/repos/reactjs/te.reactjs.org/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/reactjs/te.reactjs.org/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/reactjs/te.reactjs.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactjs/te.reactjs.org/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/reactjs/te.reactjs.org/statuses/4b6fa3db5d72adcd05c5b97cb2b8bd9ce1323054"}},"author_association":"MEMBER"}}
|
{
"id": 172580214,
"name": "reactjs/te.reactjs.org",
"url": "https://api.github.com/repos/reactjs/te.reactjs.org"
}
|
{
"id": 13428505,
"login": "ChaituKNag",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13428505?",
"url": "https://api.github.com/users/ChaituKNag"
}
|
{
"id": 6412038,
"login": "reactjs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6412038?",
"url": "https://api.github.com/orgs/reactjs"
}
| 2019-05-03T17:28:10 |
9559775449
|
{"actor":{"display_login":"ChaituKNag"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/osu-mist/pizza-api/pulls/comments/359018625","pull_request_review_id":333548578,"id":359018625,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTAxODYyNQ==","diff_hunk":"@@ -452,6 +452,211 @@ const ingredientSerializerData = {\n },\n };\n \n+const serializePizzaData = {\n+ baseInputPizza: {\n+ id: '1',\n+ name: 'sample pizza',\n+ ovenTemp: '500',\n+ bakeTime: '10',\n+ specialInstructions: null,\n+ ingredients: [\n+ {\n+ id: '1',\n+ name: 'sausage',\n+ ingredientType: 'meat',\n+ notes: null,\n+ },\n+ ],\n+ dough: {\n+ name: 'weeknight pizza dough',\n+ id: '201',\n+ gramsFlour: '500',\n+ flourType: 'All Purpose',\n+ gramsWater: '400',\n+ waterTemp: '90',\n+ gramsYeast: '5',\n+ gramsSalt: '15',\n+ bulkFermentTime: '60',\n+ proofTime: '15',\n+ gramsSugar: '0',\n+ gramsOliveOil: '0',\n+ specialInstructions: null,\n+ },\n+ },\n+ goalSerializedPizza: {\n+ data: {\n+ attributes: {\n+ name: 'sample pizza',\n+ ovenTemp: 500,\n+ bakeTime: 10,\n+ specialInstructions: '',\n+ },\n+ id: '1',\n+ type: 'string',\n+ relationships: {\n+ ingredients: {\n+ data: [\n+ {\n+ type: 'ingredient',\n+ id: '1',\n+ },\n+ ],\n+ links: {\n+ related: '/v1/pizzas/1/ingredients',\n+ self: '/v1/pizzas/1/relationships/ingredients',\n+ },\n+ },\n+ dough: {\n+ data: {\n+ type: 'dough',\n+ id: '201',\n+ },\n+ links: {\n+ related: '/v1/pizzas/1/dough',\n+ self: '/v1/pizzas/1/relationships/dough',\n+ },\n+ },\n+ },\n+ },\n+ links: {\n+ self: '/v1/pizzas/1',\n+ },\n+ included: [\n+ {\n+ type: 'dough',\n+ id: '201',\n+ attributes: {\n+ name: 'weeknight pizza dough',\n+ gramsFlour: 500,\n+ flourType: 'All Purpose',\n+ gramsWater: 400,\n+ waterTemp: 90,\n+ gramsYeast: 5,\n+ gramsSalt: 15,\n+ gramsSugar: 0,\n+ gramsOliveOil: 0,\n+ bulkFermentTime: 60,\n+ proofTime: 15,\n+ specialInstructions: '',\n+ },\n+ relationships: {},","path":"src/tests/unit/test-data.js","position":91,"original_position":91,"commit_id":"a6db94a8f3e3e4d02214a26fab8e84d56a5a6839","original_commit_id":"a6db94a8f3e3e4d02214a26fab8e84d56a5a6839","user":{"login":"Ruefa","id":16888647,"node_id":"MDQ6VXNlcjE2ODg4NjQ3","avatar_url":"https://avatars1.githubusercontent.com/u/16888647?v=4","gravatar_id":"","url":"https://api.github.com/users/Ruefa","html_url":"https://github.com/Ruefa","followers_url":"https://api.github.com/users/Ruefa/followers","following_url":"https://api.github.com/users/Ruefa/following{/other_user}","gists_url":"https://api.github.com/users/Ruefa/gists{/gist_id}","starred_url":"https://api.github.com/users/Ruefa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ruefa/subscriptions","organizations_url":"https://api.github.com/users/Ruefa/orgs","repos_url":"https://api.github.com/users/Ruefa/repos","events_url":"https://api.github.com/users/Ruefa/events{/privacy}","received_events_url":"https://api.github.com/users/Ruefa/received_events","type":"User","site_admin":false},"body":"You have to be real careful with odd bugs like this. They can create wonky edge cases that don't show up until a user finds it. At the very least you should understand why this is happening to actually determine its benignity.","created_at":"2019-12-17T20:44:37Z","updated_at":"2019-12-17T20:45:47Z","html_url":"https://github.com/osu-mist/pizza-api/pull/19#discussion_r359018625","pull_request_url":"https://api.github.com/repos/osu-mist/pizza-api/pulls/19","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/osu-mist/pizza-api/pulls/comments/359018625"},"html":{"href":"https://github.com/osu-mist/pizza-api/pull/19#discussion_r359018625"},"pull_request":{"href":"https://api.github.com/repos/osu-mist/pizza-api/pulls/19"}},"in_reply_to_id":358993681},"pull_request":{"url":"https://api.github.com/repos/osu-mist/pizza-api/pulls/19","id":354279171,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0Mjc5MTcx","html_url":"https://github.com/osu-mist/pizza-api/pull/19","diff_url":"https://github.com/osu-mist/pizza-api/pull/19.diff","patch_url":"https://github.com/osu-mist/pizza-api/pull/19.patch","issue_url":"https://api.github.com/repos/osu-mist/pizza-api/issues/19","number":19,"state":"open","locked":false,"title":"CO-1673 implement GET /pizzas/{pizzaId}","user":{"login":"jemisonf","id":28904930,"node_id":"MDQ6VXNlcjI4OTA0OTMw","avatar_url":"https://avatars3.githubusercontent.com/u/28904930?v=4","gravatar_id":"","url":"https://api.github.com/users/jemisonf","html_url":"https://github.com/jemisonf","followers_url":"https://api.github.com/users/jemisonf/followers","following_url":"https://api.github.com/users/jemisonf/following{/other_user}","gists_url":"https://api.github.com/users/jemisonf/gists{/gist_id}","starred_url":"https://api.github.com/users/jemisonf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jemisonf/subscriptions","organizations_url":"https://api.github.com/users/jemisonf/orgs","repos_url":"https://api.github.com/users/jemisonf/repos","events_url":"https://api.github.com/users/jemisonf/events{/privacy}","received_events_url":"https://api.github.com/users/jemisonf/received_events","type":"User","site_admin":false},"body":"Relationships!","created_at":"2019-12-17T19:46:21Z","updated_at":"2019-12-17T20:45:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"905845b37b3729ea4de84ec78548b984d11ca6fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/osu-mist/pizza-api/pulls/19/commits","review_comments_url":"https://api.github.com/repos/osu-mist/pizza-api/pulls/19/comments","review_comment_url":"https://api.github.com/repos/osu-mist/pizza-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osu-mist/pizza-api/issues/19/comments","statuses_url":"https://api.github.com/repos/osu-mist/pizza-api/statuses/a6db94a8f3e3e4d02214a26fab8e84d56a5a6839","head":{"label":"osu-mist:feature/CO-1673-implement-get-pizzas-by-id","ref":"feature/CO-1673-implement-get-pizzas-by-id","sha":"a6db94a8f3e3e4d02214a26fab8e84d56a5a6839","user":{"login":"osu-mist","id":6473936,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzM5MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/6473936?v=4","gravatar_id":"","url":"https://api.github.com/users/osu-mist","html_url":"https://github.com/osu-mist","followers_url":"https://api.github.com/users/osu-mist/followers","following_url":"https://api.github.com/users/osu-mist/following{/other_user}","gists_url":"https://api.github.com/users/osu-mist/gists{/gist_id}","starred_url":"https://api.github.com/users/osu-mist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osu-mist/subscriptions","organizations_url":"https://api.github.com/users/osu-mist/orgs","repos_url":"https://api.github.com/users/osu-mist/repos","events_url":"https://api.github.com/users/osu-mist/events{/privacy}","received_events_url":"https://api.github.com/users/osu-mist/received_events","type":"Organization","site_admin":false},"repo":{"id":210700970,"node_id":"MDEwOlJlcG9zaXRvcnkyMTA3MDA5NzA=","name":"pizza-api","full_name":"osu-mist/pizza-api","private":false,"owner":{"login":"osu-mist","id":6473936,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzM5MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/6473936?v=4","gravatar_id":"","url":"https://api.github.com/users/osu-mist","html_url":"https://github.com/osu-mist","followers_url":"https://api.github.com/users/osu-mist/followers","following_url":"https://api.github.com/users/osu-mist/following{/other_user}","gists_url":"https://api.github.com/users/osu-mist/gists{/gist_id}","starred_url":"https://api.github.com/users/osu-mist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osu-mist/subscriptions","organizations_url":"https://api.github.com/users/osu-mist/orgs","repos_url":"https://api.github.com/users/osu-mist/repos","events_url":"https://api.github.com/users/osu-mist/events{/privacy}","received_events_url":"https://api.github.com/users/osu-mist/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/osu-mist/pizza-api","description":null,"fork":false,"url":"https://api.github.com/repos/osu-mist/pizza-api","forks_url":"https://api.github.com/repos/osu-mist/pizza-api/forks","keys_url":"https://api.github.com/repos/osu-mist/pizza-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osu-mist/pizza-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osu-mist/pizza-api/teams","hooks_url":"https://api.github.com/repos/osu-mist/pizza-api/hooks","issue_events_url":"https://api.github.com/repos/osu-mist/pizza-api/issues/events{/number}","events_url":"https://api.github.com/repos/osu-mist/pizza-api/events","assignees_url":"https://api.github.com/repos/osu-mist/pizza-api/assignees{/user}","branches_url":"https://api.github.com/repos/osu-mist/pizza-api/branches{/branch}","tags_url":"https://api.github.com/repos/osu-mist/pizza-api/tags","blobs_url":"https://api.github.com/repos/osu-mist/pizza-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osu-mist/pizza-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osu-mist/pizza-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/osu-mist/pizza-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osu-mist/pizza-api/statuses/{sha}","languages_url":"https://api.github.com/repos/osu-mist/pizza-api/languages","stargazers_url":"https://api.github.com/repos/osu-mist/pizza-api/stargazers","contributors_url":"https://api.github.com/repos/osu-mist/pizza-api/contributors","subscribers_url":"https://api.github.com/repos/osu-mist/pizza-api/subscribers","subscription_url":"https://api.github.com/repos/osu-mist/pizza-api/subscription","commits_url":"https://api.github.com/repos/osu-mist/pizza-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/osu-mist/pizza-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/osu-mist/pizza-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/osu-mist/pizza-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/osu-mist/pizza-api/contents/{+path}","compare_url":"https://api.github.com/repos/osu-mist/pizza-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osu-mist/pizza-api/merges","archive_url":"https://api.github.com/repos/osu-mist/pizza-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osu-mist/pizza-api/downloads","issues_url":"https://api.github.com/repos/osu-mist/pizza-api/issues{/number}","pulls_url":"https://api.github.com/repos/osu-mist/pizza-api/pulls{/number}","milestones_url":"https://api.github.com/repos/osu-mist/pizza-api/milestones{/number}","notifications_url":"https://api.github.com/repos/osu-mist/pizza-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osu-mist/pizza-api/labels{/name}","releases_url":"https://api.github.com/repos/osu-mist/pizza-api/releases{/id}","deployments_url":"https://api.github.com/repos/osu-mist/pizza-api/deployments","created_at":"2019-09-24T21:30:58Z","updated_at":"2019-12-17T18:48:23Z","pushed_at":"2019-12-17T19:46:21Z","git_url":"git://github.com/osu-mist/pizza-api.git","ssh_url":"[email protected]:osu-mist/pizza-api.git","clone_url":"https://github.com/osu-mist/pizza-api.git","svn_url":"https://github.com/osu-mist/pizza-api","homepage":null,"size":1137,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"osu-mist:master","ref":"master","sha":"98f6ff95703a8315b38d14e1b78909a13ef7148f","user":{"login":"osu-mist","id":6473936,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzM5MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/6473936?v=4","gravatar_id":"","url":"https://api.github.com/users/osu-mist","html_url":"https://github.com/osu-mist","followers_url":"https://api.github.com/users/osu-mist/followers","following_url":"https://api.github.com/users/osu-mist/following{/other_user}","gists_url":"https://api.github.com/users/osu-mist/gists{/gist_id}","starred_url":"https://api.github.com/users/osu-mist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osu-mist/subscriptions","organizations_url":"https://api.github.com/users/osu-mist/orgs","repos_url":"https://api.github.com/users/osu-mist/repos","events_url":"https://api.github.com/users/osu-mist/events{/privacy}","received_events_url":"https://api.github.com/users/osu-mist/received_events","type":"Organization","site_admin":false},"repo":{"id":210700970,"node_id":"MDEwOlJlcG9zaXRvcnkyMTA3MDA5NzA=","name":"pizza-api","full_name":"osu-mist/pizza-api","private":false,"owner":{"login":"osu-mist","id":6473936,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzM5MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/6473936?v=4","gravatar_id":"","url":"https://api.github.com/users/osu-mist","html_url":"https://github.com/osu-mist","followers_url":"https://api.github.com/users/osu-mist/followers","following_url":"https://api.github.com/users/osu-mist/following{/other_user}","gists_url":"https://api.github.com/users/osu-mist/gists{/gist_id}","starred_url":"https://api.github.com/users/osu-mist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osu-mist/subscriptions","organizations_url":"https://api.github.com/users/osu-mist/orgs","repos_url":"https://api.github.com/users/osu-mist/repos","events_url":"https://api.github.com/users/osu-mist/events{/privacy}","received_events_url":"https://api.github.com/users/osu-mist/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/osu-mist/pizza-api","description":null,"fork":false,"url":"https://api.github.com/repos/osu-mist/pizza-api","forks_url":"https://api.github.com/repos/osu-mist/pizza-api/forks","keys_url":"https://api.github.com/repos/osu-mist/pizza-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osu-mist/pizza-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osu-mist/pizza-api/teams","hooks_url":"https://api.github.com/repos/osu-mist/pizza-api/hooks","issue_events_url":"https://api.github.com/repos/osu-mist/pizza-api/issues/events{/number}","events_url":"https://api.github.com/repos/osu-mist/pizza-api/events","assignees_url":"https://api.github.com/repos/osu-mist/pizza-api/assignees{/user}","branches_url":"https://api.github.com/repos/osu-mist/pizza-api/branches{/branch}","tags_url":"https://api.github.com/repos/osu-mist/pizza-api/tags","blobs_url":"https://api.github.com/repos/osu-mist/pizza-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osu-mist/pizza-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osu-mist/pizza-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/osu-mist/pizza-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osu-mist/pizza-api/statuses/{sha}","languages_url":"https://api.github.com/repos/osu-mist/pizza-api/languages","stargazers_url":"https://api.github.com/repos/osu-mist/pizza-api/stargazers","contributors_url":"https://api.github.com/repos/osu-mist/pizza-api/contributors","subscribers_url":"https://api.github.com/repos/osu-mist/pizza-api/subscribers","subscription_url":"https://api.github.com/repos/osu-mist/pizza-api/subscription","commits_url":"https://api.github.com/repos/osu-mist/pizza-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/osu-mist/pizza-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/osu-mist/pizza-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/osu-mist/pizza-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/osu-mist/pizza-api/contents/{+path}","compare_url":"https://api.github.com/repos/osu-mist/pizza-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osu-mist/pizza-api/merges","archive_url":"https://api.github.com/repos/osu-mist/pizza-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osu-mist/pizza-api/downloads","issues_url":"https://api.github.com/repos/osu-mist/pizza-api/issues{/number}","pulls_url":"https://api.github.com/repos/osu-mist/pizza-api/pulls{/number}","milestones_url":"https://api.github.com/repos/osu-mist/pizza-api/milestones{/number}","notifications_url":"https://api.github.com/repos/osu-mist/pizza-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osu-mist/pizza-api/labels{/name}","releases_url":"https://api.github.com/repos/osu-mist/pizza-api/releases{/id}","deployments_url":"https://api.github.com/repos/osu-mist/pizza-api/deployments","created_at":"2019-09-24T21:30:58Z","updated_at":"2019-12-17T18:48:23Z","pushed_at":"2019-12-17T19:46:21Z","git_url":"git://github.com/osu-mist/pizza-api.git","ssh_url":"[email protected]:osu-mist/pizza-api.git","clone_url":"https://github.com/osu-mist/pizza-api.git","svn_url":"https://github.com/osu-mist/pizza-api","homepage":null,"size":1137,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/osu-mist/pizza-api/pulls/19"},"html":{"href":"https://github.com/osu-mist/pizza-api/pull/19"},"issue":{"href":"https://api.github.com/repos/osu-mist/pizza-api/issues/19"},"comments":{"href":"https://api.github.com/repos/osu-mist/pizza-api/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/osu-mist/pizza-api/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/osu-mist/pizza-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osu-mist/pizza-api/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/osu-mist/pizza-api/statuses/a6db94a8f3e3e4d02214a26fab8e84d56a5a6839"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 210700970,
"name": "osu-mist/pizza-api",
"url": "https://api.github.com/repos/osu-mist/pizza-api"
}
|
{
"id": 16888647,
"login": "Ruefa",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16888647?",
"url": "https://api.github.com/users/Ruefa"
}
|
{
"id": 6473936,
"login": "osu-mist",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6473936?",
"url": "https://api.github.com/orgs/osu-mist"
}
| 2019-12-17T20:44:37 |
11110845190
|
{"actor":{"display_login":"Ruefa"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/comments/260830562","pull_request_review_id":208624643,"id":260830562,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MDgzMDU2Mg==","diff_hunk":"@@ -3,57 +3,17 @@\n \n using System;\n using Microsoft.AspNetCore.Components.Services;\n-using Microsoft.AspNetCore.Http;\n-using Microsoft.AspNetCore.Http.Extensions;\n \n namespace Microsoft.AspNetCore.Mvc.ViewFeatures\n {\n internal class HttpUriHelper : UriHelperBase","path":"src/Mvc/Mvc.ViewFeatures/src/Infrastructure/HttpUriHelper.cs","position":9,"original_position":9,"commit_id":"396ecd6861d6bac5c266ed8c305df41f377e832f","original_commit_id":"396ecd6861d6bac5c266ed8c305df41f377e832f","user":{"login":"SteveSandersonMS","id":1101362,"node_id":"MDQ6VXNlcjExMDEzNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1101362?v=4","gravatar_id":"","url":"https://api.github.com/users/SteveSandersonMS","html_url":"https://github.com/SteveSandersonMS","followers_url":"https://api.github.com/users/SteveSandersonMS/followers","following_url":"https://api.github.com/users/SteveSandersonMS/following{/other_user}","gists_url":"https://api.github.com/users/SteveSandersonMS/gists{/gist_id}","starred_url":"https://api.github.com/users/SteveSandersonMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SteveSandersonMS/subscriptions","organizations_url":"https://api.github.com/users/SteveSandersonMS/orgs","repos_url":"https://api.github.com/users/SteveSandersonMS/repos","events_url":"https://api.github.com/users/SteveSandersonMS/events{/privacy}","received_events_url":"https://api.github.com/users/SteveSandersonMS/received_events","type":"User","site_admin":false},"body":"Out of interest, why is it called `HttpUriHelper`? Is this specific to prerendering, and if so, could it be called `PrerenderingUriHelper` instead?","created_at":"2019-02-27T16:26:44Z","updated_at":"2019-02-27T16:26:44Z","html_url":"https://github.com/aspnet/AspNetCore/pull/7954#discussion_r260830562","pull_request_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/7954","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/comments/260830562"},"html":{"href":"https://github.com/aspnet/AspNetCore/pull/7954#discussion_r260830562"},"pull_request":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/7954"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/7954","id":256338054,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU2MzM4MDU0","html_url":"https://github.com/aspnet/AspNetCore/pull/7954","diff_url":"https://github.com/aspnet/AspNetCore/pull/7954.diff","patch_url":"https://github.com/aspnet/AspNetCore/pull/7954.patch","issue_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/7954","number":7954,"state":"open","locked":false,"title":"[Components][Mvc] Relayer integration pieces","user":{"login":"javiercn","id":6995051,"node_id":"MDQ6VXNlcjY5OTUwNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6995051?v=4","gravatar_id":"","url":"https://api.github.com/users/javiercn","html_url":"https://github.com/javiercn","followers_url":"https://api.github.com/users/javiercn/followers","following_url":"https://api.github.com/users/javiercn/following{/other_user}","gists_url":"https://api.github.com/users/javiercn/gists{/gist_id}","starred_url":"https://api.github.com/users/javiercn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiercn/subscriptions","organizations_url":"https://api.github.com/users/javiercn/orgs","repos_url":"https://api.github.com/users/javiercn/repos","events_url":"https://api.github.com/users/javiercn/events{/privacy}","received_events_url":"https://api.github.com/users/javiercn/received_events","type":"User","site_admin":false},"body":"* Introduce Microsoft.AspNetCore.Mvc.ViewFeatures.Prerendering\r\n* Separate static rendering from prerendering.\r\n* Move Prerendering interfaces to Microsoft.AspNetCore.Components.Server.\r\n* Fix exception handling during prerendering.","created_at":"2019-02-26T15:48:33Z","updated_at":"2019-02-27T16:26:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ba805939b0e4ad4fd3cf1c1bbae1fc1ffef73af1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dougbu","id":6431421,"node_id":"MDQ6VXNlcjY0MzE0MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/6431421?v=4","gravatar_id":"","url":"https://api.github.com/users/dougbu","html_url":"https://github.com/dougbu","followers_url":"https://api.github.com/users/dougbu/followers","following_url":"https://api.github.com/users/dougbu/following{/other_user}","gists_url":"https://api.github.com/users/dougbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dougbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougbu/subscriptions","organizations_url":"https://api.github.com/users/dougbu/orgs","repos_url":"https://api.github.com/users/dougbu/repos","events_url":"https://api.github.com/users/dougbu/events{/privacy}","received_events_url":"https://api.github.com/users/dougbu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1118585221,"node_id":"MDU6TGFiZWwxMTE4NTg1MjIx","url":"https://api.github.com/repos/aspnet/AspNetCore/labels/area-mvc","name":"area-mvc","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/7954/commits","review_comments_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/7954/comments","review_comment_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/7954/comments","statuses_url":"https://api.github.com/repos/aspnet/AspNetCore/statuses/396ecd6861d6bac5c266ed8c305df41f377e832f","head":{"label":"aspnet:javiercn/components-mvc-integration-relayer-alternative","ref":"javiercn/components-mvc-integration-relayer-alternative","sha":"396ecd6861d6bac5c266ed8c305df41f377e832f","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":17620347,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYyMDM0Nw==","name":"AspNetCore","full_name":"aspnet/AspNetCore","private":false,"owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aspnet/AspNetCore","description":"ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.","fork":false,"url":"https://api.github.com/repos/aspnet/AspNetCore","forks_url":"https://api.github.com/repos/aspnet/AspNetCore/forks","keys_url":"https://api.github.com/repos/aspnet/AspNetCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/AspNetCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/AspNetCore/teams","hooks_url":"https://api.github.com/repos/aspnet/AspNetCore/hooks","issue_events_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/AspNetCore/events","assignees_url":"https://api.github.com/repos/aspnet/AspNetCore/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/AspNetCore/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/AspNetCore/tags","blobs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/AspNetCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/AspNetCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/AspNetCore/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/AspNetCore/languages","stargazers_url":"https://api.github.com/repos/aspnet/AspNetCore/stargazers","contributors_url":"https://api.github.com/repos/aspnet/AspNetCore/contributors","subscribers_url":"https://api.github.com/repos/aspnet/AspNetCore/subscribers","subscription_url":"https://api.github.com/repos/aspnet/AspNetCore/subscription","commits_url":"https://api.github.com/repos/aspnet/AspNetCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/AspNetCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/AspNetCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/AspNetCore/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/AspNetCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/AspNetCore/merges","archive_url":"https://api.github.com/repos/aspnet/AspNetCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/AspNetCore/downloads","issues_url":"https://api.github.com/repos/aspnet/AspNetCore/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/AspNetCore/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/AspNetCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/AspNetCore/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/AspNetCore/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/AspNetCore/deployments","created_at":"2014-03-11T06:09:42Z","updated_at":"2019-02-27T15:38:16Z","pushed_at":"2019-02-27T16:18:09Z","git_url":"git://github.com/aspnet/AspNetCore.git","ssh_url":"[email protected]:aspnet/AspNetCore.git","clone_url":"https://github.com/aspnet/AspNetCore.git","svn_url":"https://github.com/aspnet/AspNetCore","homepage":"https://asp.net","size":201273,"stargazers_count":9798,"watchers_count":9798,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2335,"mirror_url":null,"archived":false,"open_issues_count":2037,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2335,"open_issues":2037,"watchers":9798,"default_branch":"master"}},"base":{"label":"aspnet:master","ref":"master","sha":"a2c8a34556ae29a2c415d1b66b0e68a807563f2c","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":17620347,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYyMDM0Nw==","name":"AspNetCore","full_name":"aspnet/AspNetCore","private":false,"owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aspnet/AspNetCore","description":"ASP.NET Core is a cross-platform .NET framework for building modern cloud-based web applications on Windows, Mac, or Linux.","fork":false,"url":"https://api.github.com/repos/aspnet/AspNetCore","forks_url":"https://api.github.com/repos/aspnet/AspNetCore/forks","keys_url":"https://api.github.com/repos/aspnet/AspNetCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/AspNetCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/AspNetCore/teams","hooks_url":"https://api.github.com/repos/aspnet/AspNetCore/hooks","issue_events_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/AspNetCore/events","assignees_url":"https://api.github.com/repos/aspnet/AspNetCore/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/AspNetCore/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/AspNetCore/tags","blobs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/AspNetCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/AspNetCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/AspNetCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/AspNetCore/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/AspNetCore/languages","stargazers_url":"https://api.github.com/repos/aspnet/AspNetCore/stargazers","contributors_url":"https://api.github.com/repos/aspnet/AspNetCore/contributors","subscribers_url":"https://api.github.com/repos/aspnet/AspNetCore/subscribers","subscription_url":"https://api.github.com/repos/aspnet/AspNetCore/subscription","commits_url":"https://api.github.com/repos/aspnet/AspNetCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/AspNetCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/AspNetCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/AspNetCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/AspNetCore/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/AspNetCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/AspNetCore/merges","archive_url":"https://api.github.com/repos/aspnet/AspNetCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/AspNetCore/downloads","issues_url":"https://api.github.com/repos/aspnet/AspNetCore/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/AspNetCore/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/AspNetCore/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/AspNetCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/AspNetCore/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/AspNetCore/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/AspNetCore/deployments","created_at":"2014-03-11T06:09:42Z","updated_at":"2019-02-27T15:38:16Z","pushed_at":"2019-02-27T16:18:09Z","git_url":"git://github.com/aspnet/AspNetCore.git","ssh_url":"[email protected]:aspnet/AspNetCore.git","clone_url":"https://github.com/aspnet/AspNetCore.git","svn_url":"https://github.com/aspnet/AspNetCore","homepage":"https://asp.net","size":201273,"stargazers_count":9798,"watchers_count":9798,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2335,"mirror_url":null,"archived":false,"open_issues_count":2037,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2335,"open_issues":2037,"watchers":9798,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/7954"},"html":{"href":"https://github.com/aspnet/AspNetCore/pull/7954"},"issue":{"href":"https://api.github.com/repos/aspnet/AspNetCore/issues/7954"},"comments":{"href":"https://api.github.com/repos/aspnet/AspNetCore/issues/7954/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/7954/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/AspNetCore/pulls/7954/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/AspNetCore/statuses/396ecd6861d6bac5c266ed8c305df41f377e832f"}},"author_association":"MEMBER"}}
|
{
"id": 17620347,
"name": "aspnet/AspNetCore",
"url": "https://api.github.com/repos/aspnet/AspNetCore"
}
|
{
"id": 1101362,
"login": "SteveSandersonMS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1101362?",
"url": "https://api.github.com/users/SteveSandersonMS"
}
|
{
"id": 6476660,
"login": "aspnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6476660?",
"url": "https://api.github.com/orgs/aspnet"
}
| 2019-02-27T16:26:44 |
9148079347
|
{"actor":{"display_login":"SteveSandersonMS"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/systers/mentorship-android/pulls/comments/354105117","pull_request_review_id":327301301,"id":354105117,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NDEwNTExNw==","diff_hunk":"@@ -63,7 +63,7 @@ class ProfileFragment : BaseFragment() {\n override fun onOptionsItemSelected(item: MenuItem): Boolean {\n return when (item.itemId) {\n R.id.menu_edit_profile -> {\n- EditProfileFragment.newInstance(profileViewModel.user).show(fragmentManager,\n+ EditProfileFragment.newInstance(profileViewModel.user).show(fragmentManager!!,","path":"app/src/main/java/org/systers/mentorship/view/fragments/ProfileFragment.kt","position":5,"original_position":5,"commit_id":"521fc24b3af6ebdaa623a1834d16a56a1c676918","original_commit_id":"521fc24b3af6ebdaa623a1834d16a56a1c676918","user":{"login":"Rimjhim28","id":26908195,"node_id":"MDQ6VXNlcjI2OTA4MTk1","avatar_url":"https://avatars3.githubusercontent.com/u/26908195?v=4","gravatar_id":"","url":"https://api.github.com/users/Rimjhim28","html_url":"https://github.com/Rimjhim28","followers_url":"https://api.github.com/users/Rimjhim28/followers","following_url":"https://api.github.com/users/Rimjhim28/following{/other_user}","gists_url":"https://api.github.com/users/Rimjhim28/gists{/gist_id}","starred_url":"https://api.github.com/users/Rimjhim28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rimjhim28/subscriptions","organizations_url":"https://api.github.com/users/Rimjhim28/orgs","repos_url":"https://api.github.com/users/Rimjhim28/repos","events_url":"https://api.github.com/users/Rimjhim28/events{/privacy}","received_events_url":"https://api.github.com/users/Rimjhim28/received_events","type":"User","site_admin":false},"body":"What is the use of adding '!!' here?","created_at":"2019-12-05T04:19:47Z","updated_at":"2019-12-05T04:19:47Z","html_url":"https://github.com/systers/mentorship-android/pull/283#discussion_r354105117","pull_request_url":"https://api.github.com/repos/systers/mentorship-android/pulls/283","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/systers/mentorship-android/pulls/comments/354105117"},"html":{"href":"https://github.com/systers/mentorship-android/pull/283#discussion_r354105117"},"pull_request":{"href":"https://api.github.com/repos/systers/mentorship-android/pulls/283"}}},"pull_request":{"url":"https://api.github.com/repos/systers/mentorship-android/pulls/283","id":348953838,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ4OTUzODM4","html_url":"https://github.com/systers/mentorship-android/pull/283","diff_url":"https://github.com/systers/mentorship-android/pull/283.diff","patch_url":"https://github.com/systers/mentorship-android/pull/283.patch","issue_url":"https://api.github.com/repos/systers/mentorship-android/issues/283","number":283,"state":"open","locked":false,"title":"[Program:GCI] Create warning dialog boxes to accept and reject mentorship requests (Mentorship-Android)","user":{"login":"asawesome07","id":29257061,"node_id":"MDQ6VXNlcjI5MjU3MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/29257061?v=4","gravatar_id":"","url":"https://api.github.com/users/asawesome07","html_url":"https://github.com/asawesome07","followers_url":"https://api.github.com/users/asawesome07/followers","following_url":"https://api.github.com/users/asawesome07/following{/other_user}","gists_url":"https://api.github.com/users/asawesome07/gists{/gist_id}","starred_url":"https://api.github.com/users/asawesome07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asawesome07/subscriptions","organizations_url":"https://api.github.com/users/asawesome07/orgs","repos_url":"https://api.github.com/users/asawesome07/repos","events_url":"https://api.github.com/users/asawesome07/events{/privacy}","received_events_url":"https://api.github.com/users/asawesome07/received_events","type":"User","site_admin":false},"body":"### Description\r\nAdded Accept and Reject dialog boxes that prompt user to confirm acceptance and rejection of mentorship relation.\r\n\r\nNOTE: also fixed 2 errors that popped up in files app/src/main/java/org/systers/mentorship/view/fragments/EditProfileFragment.kt and\r\napp/src/main/java/org/systers/mentorship/view/fragments/ProfileFragment.kt\r\n\r\nTASK: https://codein.withgoogle.com/tasks/4983979728437248/?sp-organization=5462163573964800&sp-is_beginner=False\r\n\r\nFixes #250 \r\n\r\n### Type of Change:\r\n- Code\r\n- User Interface\r\n\r\n**Code/Quality Assurance Only**\r\n- Bug fix (non-breaking change which fixes an issue)\r\n- New feature (non-breaking change which adds functionality pre-approved by mentors)\r\n\r\n## How Has This Been Tested?\r\nI ran the build on an emulator and on my phone. Here's a GIF\r\n\r\nNotice how the mentor's name is mentioned in the dialog box\r\n\r\n\r\n### Checklist:\r\n- [x] My PR follows the style guidelines of this project\r\n- [x] I have performed a self-review of my own code or materials\r\n- [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas\r\n- [x] I have made corresponding changes to the documentation\r\n- [x] Any dependent changes have been merged\r\n- [x] I have written Kotlin Docs whenever is applicable\r\n\r\n**Code/Quality Assurance Only**\r\n- [x] My changes generate no new warnings\r\n- [ ] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [x] New and existing unit tests pass locally with my changes\r\n- [x] Any dependent changes have been published in downstream modules","created_at":"2019-12-04T15:37:57Z","updated_at":"2019-12-05T04:19:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0ec7f6c026ae3c64e6db093035a6491c57be8ae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/systers/mentorship-android/pulls/283/commits","review_comments_url":"https://api.github.com/repos/systers/mentorship-android/pulls/283/comments","review_comment_url":"https://api.github.com/repos/systers/mentorship-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/systers/mentorship-android/issues/283/comments","statuses_url":"https://api.github.com/repos/systers/mentorship-android/statuses/521fc24b3af6ebdaa623a1834d16a56a1c676918","head":{"label":"asawesome07:acceptrejectAlertDialog","ref":"acceptrejectAlertDialog","sha":"521fc24b3af6ebdaa623a1834d16a56a1c676918","user":{"login":"asawesome07","id":29257061,"node_id":"MDQ6VXNlcjI5MjU3MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/29257061?v=4","gravatar_id":"","url":"https://api.github.com/users/asawesome07","html_url":"https://github.com/asawesome07","followers_url":"https://api.github.com/users/asawesome07/followers","following_url":"https://api.github.com/users/asawesome07/following{/other_user}","gists_url":"https://api.github.com/users/asawesome07/gists{/gist_id}","starred_url":"https://api.github.com/users/asawesome07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asawesome07/subscriptions","organizations_url":"https://api.github.com/users/asawesome07/orgs","repos_url":"https://api.github.com/users/asawesome07/repos","events_url":"https://api.github.com/users/asawesome07/events{/privacy}","received_events_url":"https://api.github.com/users/asawesome07/received_events","type":"User","site_admin":false},"repo":{"id":225678994,"node_id":"MDEwOlJlcG9zaXRvcnkyMjU2Nzg5OTQ=","name":"mentorship-android","full_name":"asawesome07/mentorship-android","private":false,"owner":{"login":"asawesome07","id":29257061,"node_id":"MDQ6VXNlcjI5MjU3MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/29257061?v=4","gravatar_id":"","url":"https://api.github.com/users/asawesome07","html_url":"https://github.com/asawesome07","followers_url":"https://api.github.com/users/asawesome07/followers","following_url":"https://api.github.com/users/asawesome07/following{/other_user}","gists_url":"https://api.github.com/users/asawesome07/gists{/gist_id}","starred_url":"https://api.github.com/users/asawesome07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asawesome07/subscriptions","organizations_url":"https://api.github.com/users/asawesome07/orgs","repos_url":"https://api.github.com/users/asawesome07/repos","events_url":"https://api.github.com/users/asawesome07/events{/privacy}","received_events_url":"https://api.github.com/users/asawesome07/received_events","type":"User","site_admin":false},"html_url":"https://github.com/asawesome07/mentorship-android","description":"Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the Android application of this project.","fork":true,"url":"https://api.github.com/repos/asawesome07/mentorship-android","forks_url":"https://api.github.com/repos/asawesome07/mentorship-android/forks","keys_url":"https://api.github.com/repos/asawesome07/mentorship-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asawesome07/mentorship-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asawesome07/mentorship-android/teams","hooks_url":"https://api.github.com/repos/asawesome07/mentorship-android/hooks","issue_events_url":"https://api.github.com/repos/asawesome07/mentorship-android/issues/events{/number}","events_url":"https://api.github.com/repos/asawesome07/mentorship-android/events","assignees_url":"https://api.github.com/repos/asawesome07/mentorship-android/assignees{/user}","branches_url":"https://api.github.com/repos/asawesome07/mentorship-android/branches{/branch}","tags_url":"https://api.github.com/repos/asawesome07/mentorship-android/tags","blobs_url":"https://api.github.com/repos/asawesome07/mentorship-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asawesome07/mentorship-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asawesome07/mentorship-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/asawesome07/mentorship-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asawesome07/mentorship-android/statuses/{sha}","languages_url":"https://api.github.com/repos/asawesome07/mentorship-android/languages","stargazers_url":"https://api.github.com/repos/asawesome07/mentorship-android/stargazers","contributors_url":"https://api.github.com/repos/asawesome07/mentorship-android/contributors","subscribers_url":"https://api.github.com/repos/asawesome07/mentorship-android/subscribers","subscription_url":"https://api.github.com/repos/asawesome07/mentorship-android/subscription","commits_url":"https://api.github.com/repos/asawesome07/mentorship-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/asawesome07/mentorship-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/asawesome07/mentorship-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/asawesome07/mentorship-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/asawesome07/mentorship-android/contents/{+path}","compare_url":"https://api.github.com/repos/asawesome07/mentorship-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asawesome07/mentorship-android/merges","archive_url":"https://api.github.com/repos/asawesome07/mentorship-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asawesome07/mentorship-android/downloads","issues_url":"https://api.github.com/repos/asawesome07/mentorship-android/issues{/number}","pulls_url":"https://api.github.com/repos/asawesome07/mentorship-android/pulls{/number}","milestones_url":"https://api.github.com/repos/asawesome07/mentorship-android/milestones{/number}","notifications_url":"https://api.github.com/repos/asawesome07/mentorship-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asawesome07/mentorship-android/labels{/name}","releases_url":"https://api.github.com/repos/asawesome07/mentorship-android/releases{/id}","deployments_url":"https://api.github.com/repos/asawesome07/mentorship-android/deployments","created_at":"2019-12-03T17:33:28Z","updated_at":"2019-12-03T17:33:29Z","pushed_at":"2019-12-04T21:55:14Z","git_url":"git://github.com/asawesome07/mentorship-android.git","ssh_url":"[email protected]:asawesome07/mentorship-android.git","clone_url":"https://github.com/asawesome07/mentorship-android.git","svn_url":"https://github.com/asawesome07/mentorship-android","homepage":"https://github.com/systers/mentorship-android/raw/apk/app-debug.apk","size":7545,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"systers:gci-dev","ref":"gci-dev","sha":"e9cfa35cf39cecb7df12cce4546c66744f793800","user":{"login":"systers","id":6520415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjA0MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6520415?v=4","gravatar_id":"","url":"https://api.github.com/users/systers","html_url":"https://github.com/systers","followers_url":"https://api.github.com/users/systers/followers","following_url":"https://api.github.com/users/systers/following{/other_user}","gists_url":"https://api.github.com/users/systers/gists{/gist_id}","starred_url":"https://api.github.com/users/systers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systers/subscriptions","organizations_url":"https://api.github.com/users/systers/orgs","repos_url":"https://api.github.com/users/systers/repos","events_url":"https://api.github.com/users/systers/events{/privacy}","received_events_url":"https://api.github.com/users/systers/received_events","type":"Organization","site_admin":false},"repo":{"id":131170910,"node_id":"MDEwOlJlcG9zaXRvcnkxMzExNzA5MTA=","name":"mentorship-android","full_name":"systers/mentorship-android","private":false,"owner":{"login":"systers","id":6520415,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MjA0MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6520415?v=4","gravatar_id":"","url":"https://api.github.com/users/systers","html_url":"https://github.com/systers","followers_url":"https://api.github.com/users/systers/followers","following_url":"https://api.github.com/users/systers/following{/other_user}","gists_url":"https://api.github.com/users/systers/gists{/gist_id}","starred_url":"https://api.github.com/users/systers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/systers/subscriptions","organizations_url":"https://api.github.com/users/systers/orgs","repos_url":"https://api.github.com/users/systers/repos","events_url":"https://api.github.com/users/systers/events{/privacy}","received_events_url":"https://api.github.com/users/systers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/systers/mentorship-android","description":"Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the Android application of this project.","fork":false,"url":"https://api.github.com/repos/systers/mentorship-android","forks_url":"https://api.github.com/repos/systers/mentorship-android/forks","keys_url":"https://api.github.com/repos/systers/mentorship-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/systers/mentorship-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/systers/mentorship-android/teams","hooks_url":"https://api.github.com/repos/systers/mentorship-android/hooks","issue_events_url":"https://api.github.com/repos/systers/mentorship-android/issues/events{/number}","events_url":"https://api.github.com/repos/systers/mentorship-android/events","assignees_url":"https://api.github.com/repos/systers/mentorship-android/assignees{/user}","branches_url":"https://api.github.com/repos/systers/mentorship-android/branches{/branch}","tags_url":"https://api.github.com/repos/systers/mentorship-android/tags","blobs_url":"https://api.github.com/repos/systers/mentorship-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/systers/mentorship-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/systers/mentorship-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/systers/mentorship-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/systers/mentorship-android/statuses/{sha}","languages_url":"https://api.github.com/repos/systers/mentorship-android/languages","stargazers_url":"https://api.github.com/repos/systers/mentorship-android/stargazers","contributors_url":"https://api.github.com/repos/systers/mentorship-android/contributors","subscribers_url":"https://api.github.com/repos/systers/mentorship-android/subscribers","subscription_url":"https://api.github.com/repos/systers/mentorship-android/subscription","commits_url":"https://api.github.com/repos/systers/mentorship-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/systers/mentorship-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/systers/mentorship-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/systers/mentorship-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/systers/mentorship-android/contents/{+path}","compare_url":"https://api.github.com/repos/systers/mentorship-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/systers/mentorship-android/merges","archive_url":"https://api.github.com/repos/systers/mentorship-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/systers/mentorship-android/downloads","issues_url":"https://api.github.com/repos/systers/mentorship-android/issues{/number}","pulls_url":"https://api.github.com/repos/systers/mentorship-android/pulls{/number}","milestones_url":"https://api.github.com/repos/systers/mentorship-android/milestones{/number}","notifications_url":"https://api.github.com/repos/systers/mentorship-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/systers/mentorship-android/labels{/name}","releases_url":"https://api.github.com/repos/systers/mentorship-android/releases{/id}","deployments_url":"https://api.github.com/repos/systers/mentorship-android/deployments","created_at":"2018-04-26T14:51:27Z","updated_at":"2019-12-03T15:14:20Z","pushed_at":"2019-12-05T03:54:33Z","git_url":"git://github.com/systers/mentorship-android.git","ssh_url":"[email protected]:systers/mentorship-android.git","clone_url":"https://github.com/systers/mentorship-android.git","svn_url":"https://github.com/systers/mentorship-android","homepage":"https://github.com/systers/mentorship-android/raw/apk/app-debug.apk","size":7527,"stargazers_count":45,"watchers_count":45,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":88,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":124,"open_issues":88,"watchers":45,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/systers/mentorship-android/pulls/283"},"html":{"href":"https://github.com/systers/mentorship-android/pull/283"},"issue":{"href":"https://api.github.com/repos/systers/mentorship-android/issues/283"},"comments":{"href":"https://api.github.com/repos/systers/mentorship-android/issues/283/comments"},"review_comments":{"href":"https://api.github.com/repos/systers/mentorship-android/pulls/283/comments"},"review_comment":{"href":"https://api.github.com/repos/systers/mentorship-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/systers/mentorship-android/pulls/283/commits"},"statuses":{"href":"https://api.github.com/repos/systers/mentorship-android/statuses/521fc24b3af6ebdaa623a1834d16a56a1c676918"}},"author_association":"NONE"}}
|
{
"id": 131170910,
"name": "systers/mentorship-android",
"url": "https://api.github.com/repos/systers/mentorship-android"
}
|
{
"id": 26908195,
"login": "Rimjhim28",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/26908195?",
"url": "https://api.github.com/users/Rimjhim28"
}
|
{
"id": 6520415,
"login": "systers",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6520415?",
"url": "https://api.github.com/orgs/systers"
}
| 2019-12-05T04:19:47 |
11016174161
|
{"actor":{"display_login":"Rimjhim28"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/pulls/comments/265258533","pull_request_review_id":214117359,"id":265258533,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NTI1ODUzMw==","diff_hunk":"@@ -0,0 +1,176 @@\n+import { WebPhoneUserAgent } from './userAgent';\r\n+import { Timers, Transport } from 'sip.js';\r\n+\r\n+\r\n+export interface WebPhoneSIPTransport extends Transport { \r\n+ computeRandomTimeout: typeof computeRandomTimeout;\r\n+ reconnect: typeof reconnect;\r\n+ isSipErrorCode: typeof isSipErrorCode;\r\n+ scheduleSwithBackMainProxy: typeof scheduleSwithBackMainProxy;\r\n+ onSipErrorCode: typeof onSipErrorCode;\r\n+}\r\n+\r\n+\r\n+export const TransportConstructorWrapper = (SipTransport: any, webPhoneOptions:any): any => {\r\n+ \r\n+ return function transportConstructor(logger: Function, options:any): WebPhoneSIPTransport {\r\n+\r\n+ let transport = new SipTransport(logger, options);\r\n+\r\n+ transport.nextReconnectInterval = 0;\r\n+ transport.sipErrorCodes = webPhoneOptions.sipErrorCodes;\r\n+ transport.switchBackInterval = webPhoneOptions.switchBackInterval;\r\n+\r\n+ transport.computeRandomTimeout = computeRandomTimeout.bind(transport);\r\n+ transport.reconnect = reconnect.bind(transport);\r\n+ transport.isSipErrorCode = isSipErrorCode.bind(transport);\r\n+ transport.scheduleSwithBackMainProxy = scheduleSwithBackMainProxy.bind(transport);\r\n+ transport.onSipErrorCode = onSipErrorCode.bind(transport);\r\n+ transport.__isCurrentMainProxy = __isCurrentMainProxy.bind(transport);\r\n+ transport.__afterWSConnected = __afterWSConnected.bind(transport);\r\n+ transport.__onConnectedToBackup = __onConnectedToBackup.bind(transport);\r\n+ transport.__onConnectedToMain = __onConnectedToMain.bind(transport);\r\n+\r\n+ transport.on('connected', transport.__afterWSConnected);\r\n+\r\n+ return transport;\r\n+ }\r\n+}\r\n+\r\n+const C = {\r\n+ // Transport status codes\r\n+ STATUS_CONNECTING: 0,\r\n+ STATUS_OPEN: 1,\r\n+ STATUS_CLOSING: 2,\r\n+ STATUS_CLOSED: 3\r\n+ };\r\n+\r\n+function computeRandomTimeout(reconnectionAttempts: number, randomMinInterval: number, randomMaxInterval: number){\r\n+ randomMinInterval = randomMinInterval < 0 ? 0 : randomMinInterval;\r\n+ randomMaxInterval = randomMaxInterval <= 0 ? 7000 : randomMaxInterval;\r\n+ reconnectionAttempts = reconnectionAttempts || 1;\r\n+\r\n+ const randomInterval = Math.floor(Math.random() * (randomMaxInterval - randomMinInterval)) + randomMinInterval;\r\n+ const retryOffset = (reconnectionAttempts - 1) * (randomMinInterval + randomMaxInterval) / 2;\r\n+\r\n+ return randomInterval + retryOffset;\r\n+};\r\n+\r\n+function reconnect(forceReconnectToMain: boolean) {\r\n+ if (this.reconnectionAttempts > 0) {\r\n+ this.logger.log('Reconnection attempt ' + this.reconnectionAttempts + ' failed');\r\n+ }\r\n+\r\n+ if (forceReconnectToMain) {\r\n+ this.logger.log('forcing connect to main WS server');\r\n+ this.server = this.getNextWsServer(true);\r\n+ this.reconnectionAttempts = 0;\r\n+ this.disconnect({ force: true })\r\n+ .then(this.connect.bind(this));\r\n+ return;\r\n+ }\r\n+\r\n+ if (this.noAvailableServers()) {\r\n+ this.logger.warn('no available ws servers left - going to closed state');\r\n+ this.status = C.STATUS_CLOSED;\r\n+ this.resetServerErrorStatus();\r\n+ return;\r\n+ }\r\n+\r\n+ if (this.isConnected()) {\r\n+ this.logger.warn('attempted to reconnect while connected - forcing disconnect');\r\n+ this.disconnect({ force: true })\r\n+ return;\r\n+ }\r\n+\r\n+ const randomMinInterval = (this.configuration.reconnectionTimeout - 2 ) * 1000;\r\n+ const randomMaxInterval = (this.configuration.reconnectionTimeout + 2 ) * 1000;\r\n+\r\n+ this.reconnectionAttempts += 1;\r\n+ this.nextReconnectInterval = this.computeRandomTimeout(this.reconnectionAttempts, randomMinInterval, randomMaxInterval); \r\n+\r\n+ if (this.reconnectionAttempts > this.configuration.maxReconnectionAttempts) {\r\n+ this.logger.warn('maximum reconnection attempts for WebSocket ' + this.server.ws_uri);\r\n+ this.logger.log('transport ' + this.server.ws_uri + ' failed | connection state set to \\'error\\'');\r\n+ this.server.isError = true;\r\n+ this.emit('transportError');\r\n+ this.server = this.getNextWsServer();\r\n+ this.reconnectionAttempts = 0;\r\n+ this.reconnect();\r\n+ } else {\r\n+ this.logger.log('trying to reconnect to WebSocket ' + this.server.ws_uri + ' (reconnection attempt ' + this.reconnectionAttempts + ')');\r\n+ this.reconnectTimer = setTimeout(() => {\r\n+ this.connect();\r\n+ this.reconnectTimer = null;\r\n+ }, this.nextReconnectInterval);\r\n+ this.logger.warn('next reconnection attempt in:' + Math.round(this.nextReconnectInterval / 1000));\r\n+ }\r\n+};\r\n+\r\n+function isSipErrorCode(message: string){ \r\n+\r\n+ const statusLine = message.substring(0, message.indexOf('\\r\\n'));\r\n+ const statusCode = statusLine.split(' ')[1];\r\n+\r\n+ return statusCode && \r\n+ this.sipErrorCodes && \r\n+ this.sipErrorCodes.length && \r\n+ this.sipErrorCodes.includes(statusCode);\r\n+};\r\n+\r\n+function scheduleSwithBackMainProxy(){\r","path":"src/sipTransportConstructor.ts","position":121,"original_position":121,"commit_id":"dbe0b80902077ed9c9c4494bb05589e80453917f","original_commit_id":"dbe0b80902077ed9c9c4494bb05589e80453917f","user":{"login":"kirill-konshin","id":1530410,"node_id":"MDQ6VXNlcjE1MzA0MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/1530410?v=4","gravatar_id":"","url":"https://api.github.com/users/kirill-konshin","html_url":"https://github.com/kirill-konshin","followers_url":"https://api.github.com/users/kirill-konshin/followers","following_url":"https://api.github.com/users/kirill-konshin/following{/other_user}","gists_url":"https://api.github.com/users/kirill-konshin/gists{/gist_id}","starred_url":"https://api.github.com/users/kirill-konshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirill-konshin/subscriptions","organizations_url":"https://api.github.com/users/kirill-konshin/orgs","repos_url":"https://api.github.com/users/kirill-konshin/repos","events_url":"https://api.github.com/users/kirill-konshin/events{/privacy}","received_events_url":"https://api.github.com/users/kirill-konshin/received_events","type":"User","site_admin":false},"body":"Declare `this` in function definition","created_at":"2019-03-13T17:57:16Z","updated_at":"2019-03-13T17:59:07Z","html_url":"https://github.com/ringcentral/ringcentral-web-phone/pull/198#discussion_r265258533","pull_request_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/pulls/198","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/pulls/comments/265258533"},"html":{"href":"https://github.com/ringcentral/ringcentral-web-phone/pull/198#discussion_r265258533"},"pull_request":{"href":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/pulls/198"}}},"pull_request":{"url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/pulls/198","id":260807122,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwODA3MTIy","html_url":"https://github.com/ringcentral/ringcentral-web-phone/pull/198","diff_url":"https://github.com/ringcentral/ringcentral-web-phone/pull/198.diff","patch_url":"https://github.com/ringcentral/ringcentral-web-phone/pull/198.patch","issue_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/issues/198","number":198,"state":"open","locked":false,"title":"Add Sip backup proxy support","user":{"login":"Alex-us","id":5812272,"node_id":"MDQ6VXNlcjU4MTIyNzI=","avatar_url":"https://avatars2.githubusercontent.com/u/5812272?v=4","gravatar_id":"","url":"https://api.github.com/users/Alex-us","html_url":"https://github.com/Alex-us","followers_url":"https://api.github.com/users/Alex-us/followers","following_url":"https://api.github.com/users/Alex-us/following{/other_user}","gists_url":"https://api.github.com/users/Alex-us/gists{/gist_id}","starred_url":"https://api.github.com/users/Alex-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alex-us/subscriptions","organizations_url":"https://api.github.com/users/Alex-us/orgs","repos_url":"https://api.github.com/users/Alex-us/repos","events_url":"https://api.github.com/users/Alex-us/events{/privacy}","received_events_url":"https://api.github.com/users/Alex-us/received_events","type":"User","site_admin":false},"body":"SIP Backup Proxy support","created_at":"2019-03-13T15:05:47Z","updated_at":"2019-03-13T17:59:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc2ae61ab882055bf0fa494cbf6436c5ece7c523","assignee":{"login":"vyshakhbabji","id":6267147,"node_id":"MDQ6VXNlcjYyNjcxNDc=","avatar_url":"https://avatars0.githubusercontent.com/u/6267147?v=4","gravatar_id":"","url":"https://api.github.com/users/vyshakhbabji","html_url":"https://github.com/vyshakhbabji","followers_url":"https://api.github.com/users/vyshakhbabji/followers","following_url":"https://api.github.com/users/vyshakhbabji/following{/other_user}","gists_url":"https://api.github.com/users/vyshakhbabji/gists{/gist_id}","starred_url":"https://api.github.com/users/vyshakhbabji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vyshakhbabji/subscriptions","organizations_url":"https://api.github.com/users/vyshakhbabji/orgs","repos_url":"https://api.github.com/users/vyshakhbabji/repos","events_url":"https://api.github.com/users/vyshakhbabji/events{/privacy}","received_events_url":"https://api.github.com/users/vyshakhbabji/received_events","type":"User","site_admin":false},"assignees":[{"login":"vyshakhbabji","id":6267147,"node_id":"MDQ6VXNlcjYyNjcxNDc=","avatar_url":"https://avatars0.githubusercontent.com/u/6267147?v=4","gravatar_id":"","url":"https://api.github.com/users/vyshakhbabji","html_url":"https://github.com/vyshakhbabji","followers_url":"https://api.github.com/users/vyshakhbabji/followers","following_url":"https://api.github.com/users/vyshakhbabji/following{/other_user}","gists_url":"https://api.github.com/users/vyshakhbabji/gists{/gist_id}","starred_url":"https://api.github.com/users/vyshakhbabji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vyshakhbabji/subscriptions","organizations_url":"https://api.github.com/users/vyshakhbabji/orgs","repos_url":"https://api.github.com/users/vyshakhbabji/repos","events_url":"https://api.github.com/users/vyshakhbabji/events{/privacy}","received_events_url":"https://api.github.com/users/vyshakhbabji/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/pulls/198/commits","review_comments_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/pulls/198/comments","review_comment_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/issues/198/comments","statuses_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/statuses/dbe0b80902077ed9c9c4494bb05589e80453917f","head":{"label":"Alex-us:typescript","ref":"typescript","sha":"dbe0b80902077ed9c9c4494bb05589e80453917f","user":{"login":"Alex-us","id":5812272,"node_id":"MDQ6VXNlcjU4MTIyNzI=","avatar_url":"https://avatars2.githubusercontent.com/u/5812272?v=4","gravatar_id":"","url":"https://api.github.com/users/Alex-us","html_url":"https://github.com/Alex-us","followers_url":"https://api.github.com/users/Alex-us/followers","following_url":"https://api.github.com/users/Alex-us/following{/other_user}","gists_url":"https://api.github.com/users/Alex-us/gists{/gist_id}","starred_url":"https://api.github.com/users/Alex-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alex-us/subscriptions","organizations_url":"https://api.github.com/users/Alex-us/orgs","repos_url":"https://api.github.com/users/Alex-us/repos","events_url":"https://api.github.com/users/Alex-us/events{/privacy}","received_events_url":"https://api.github.com/users/Alex-us/received_events","type":"User","site_admin":false},"repo":{"id":175185986,"node_id":"MDEwOlJlcG9zaXRvcnkxNzUxODU5ODY=","name":"ringcentral-web-phone","full_name":"Alex-us/ringcentral-web-phone","private":false,"owner":{"login":"Alex-us","id":5812272,"node_id":"MDQ6VXNlcjU4MTIyNzI=","avatar_url":"https://avatars2.githubusercontent.com/u/5812272?v=4","gravatar_id":"","url":"https://api.github.com/users/Alex-us","html_url":"https://github.com/Alex-us","followers_url":"https://api.github.com/users/Alex-us/followers","following_url":"https://api.github.com/users/Alex-us/following{/other_user}","gists_url":"https://api.github.com/users/Alex-us/gists{/gist_id}","starred_url":"https://api.github.com/users/Alex-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alex-us/subscriptions","organizations_url":"https://api.github.com/users/Alex-us/orgs","repos_url":"https://api.github.com/users/Alex-us/repos","events_url":"https://api.github.com/users/Alex-us/events{/privacy}","received_events_url":"https://api.github.com/users/Alex-us/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Alex-us/ringcentral-web-phone","description":"RingCentral WebPhone Library for JavaScript WebRTC","fork":true,"url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone","forks_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/forks","keys_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/teams","hooks_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/hooks","issue_events_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/issues/events{/number}","events_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/events","assignees_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/assignees{/user}","branches_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/branches{/branch}","tags_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/tags","blobs_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/statuses/{sha}","languages_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/languages","stargazers_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/stargazers","contributors_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/contributors","subscribers_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/subscribers","subscription_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/subscription","commits_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/contents/{+path}","compare_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/merges","archive_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/downloads","issues_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/issues{/number}","pulls_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/pulls{/number}","milestones_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/milestones{/number}","notifications_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/labels{/name}","releases_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/releases{/id}","deployments_url":"https://api.github.com/repos/Alex-us/ringcentral-web-phone/deployments","created_at":"2019-03-12T10:18:43Z","updated_at":"2019-03-12T10:18:45Z","pushed_at":"2019-03-13T15:04:31Z","git_url":"git://github.com/Alex-us/ringcentral-web-phone.git","ssh_url":"[email protected]:Alex-us/ringcentral-web-phone.git","clone_url":"https://github.com/Alex-us/ringcentral-web-phone.git","svn_url":"https://github.com/Alex-us/ringcentral-web-phone","homepage":"","size":4027,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ringcentral:typescript","ref":"typescript","sha":"08ac148141cc526010927882e422e5fffc171759","user":{"login":"ringcentral","id":6549285,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NDkyODU=","avatar_url":"https://avatars3.githubusercontent.com/u/6549285?v=4","gravatar_id":"","url":"https://api.github.com/users/ringcentral","html_url":"https://github.com/ringcentral","followers_url":"https://api.github.com/users/ringcentral/followers","following_url":"https://api.github.com/users/ringcentral/following{/other_user}","gists_url":"https://api.github.com/users/ringcentral/gists{/gist_id}","starred_url":"https://api.github.com/users/ringcentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ringcentral/subscriptions","organizations_url":"https://api.github.com/users/ringcentral/orgs","repos_url":"https://api.github.com/users/ringcentral/repos","events_url":"https://api.github.com/users/ringcentral/events{/privacy}","received_events_url":"https://api.github.com/users/ringcentral/received_events","type":"Organization","site_admin":false},"repo":{"id":50194284,"node_id":"MDEwOlJlcG9zaXRvcnk1MDE5NDI4NA==","name":"ringcentral-web-phone","full_name":"ringcentral/ringcentral-web-phone","private":false,"owner":{"login":"ringcentral","id":6549285,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NDkyODU=","avatar_url":"https://avatars3.githubusercontent.com/u/6549285?v=4","gravatar_id":"","url":"https://api.github.com/users/ringcentral","html_url":"https://github.com/ringcentral","followers_url":"https://api.github.com/users/ringcentral/followers","following_url":"https://api.github.com/users/ringcentral/following{/other_user}","gists_url":"https://api.github.com/users/ringcentral/gists{/gist_id}","starred_url":"https://api.github.com/users/ringcentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ringcentral/subscriptions","organizations_url":"https://api.github.com/users/ringcentral/orgs","repos_url":"https://api.github.com/users/ringcentral/repos","events_url":"https://api.github.com/users/ringcentral/events{/privacy}","received_events_url":"https://api.github.com/users/ringcentral/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ringcentral/ringcentral-web-phone","description":"RingCentral WebPhone Library for JavaScript WebRTC","fork":false,"url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone","forks_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/forks","keys_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/teams","hooks_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/hooks","issue_events_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/issues/events{/number}","events_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/events","assignees_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/assignees{/user}","branches_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/branches{/branch}","tags_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/tags","blobs_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/git/refs{/sha}","trees_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/statuses/{sha}","languages_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/languages","stargazers_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/stargazers","contributors_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/contributors","subscribers_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/subscribers","subscription_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/subscription","commits_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/commits{/sha}","git_commits_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/git/commits{/sha}","comments_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/comments{/number}","issue_comment_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/issues/comments{/number}","contents_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/contents/{+path}","compare_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/merges","archive_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/downloads","issues_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/issues{/number}","pulls_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/pulls{/number}","milestones_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/milestones{/number}","notifications_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/labels{/name}","releases_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/releases{/id}","deployments_url":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/deployments","created_at":"2016-01-22T16:47:45Z","updated_at":"2019-03-12T17:50:33Z","pushed_at":"2019-03-13T15:05:48Z","git_url":"git://github.com/ringcentral/ringcentral-web-phone.git","ssh_url":"[email protected]:ringcentral/ringcentral-web-phone.git","clone_url":"https://github.com/ringcentral/ringcentral-web-phone.git","svn_url":"https://github.com/ringcentral/ringcentral-web-phone","homepage":"http://ringcentral.github.io/ringcentral-web-phone","size":4079,"stargazers_count":49,"watchers_count":49,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":14,"license":null,"forks":41,"open_issues":14,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/pulls/198"},"html":{"href":"https://github.com/ringcentral/ringcentral-web-phone/pull/198"},"issue":{"href":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/issues/198"},"comments":{"href":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/ringcentral/ringcentral-web-phone/statuses/dbe0b80902077ed9c9c4494bb05589e80453917f"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 50194284,
"name": "ringcentral/ringcentral-web-phone",
"url": "https://api.github.com/repos/ringcentral/ringcentral-web-phone"
}
|
{
"id": 1530410,
"login": "kirill-konshin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1530410?",
"url": "https://api.github.com/users/kirill-konshin"
}
|
{
"id": 6549285,
"login": "ringcentral",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6549285?",
"url": "https://api.github.com/orgs/ringcentral"
}
| 2019-03-13T17:57:16 |
9237068407
|
{"actor":{"display_login":"kirill-konshin"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments/278224733","pull_request_review_id":230236345,"id":278224733,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3ODIyNDczMw==","diff_hunk":"@@ -0,0 +1,520 @@\n+#!/usr/bin/env node\n+const config = require('./releaseConfig')\n+const yn = require('yn')\n+const ora = require('ora')\n+const readline = require('readline')\n+const fs = require('fs')\n+const { exec, spawn } = require('child_process')\n+const util = require('util')\n+const promiseExec = util.promisify(exec)\n+const chalk = require('chalk')\n+\n+const { VERSION } = process.env\n+\n+let safeToClearWorkspace = false\n+let rcNumber = NaN\n+let versionRC = null\n+let isFirstReleaseIteration = false\n+\n+//////////////////////////////\n+// Release Helper functions //\n+/////////////////////////////\n+\n+const stepTitle = message => {\n+ console.log()\n+ console.log(chalk.magenta('~'.repeat(message.length + 4)))\n+ console.log(chalk.magenta(`| ${message} |`))\n+ console.log(chalk.magenta('~'.repeat(message.length + 4)))\n+ console.log()\n+}\n+\n+const question = query => {\n+ const rl = readline.createInterface({\n+ input: process.stdin,\n+ output: process.stdout\n+ });\n+\n+ console.log()\n+ return new Promise(resolve => rl.question(`\\n${query} (y/n) `, answer => {\n+ const answerAsBoolean = yn(answer) || false\n+ resolve(answerAsBoolean)\n+ rl.close()\n+ }))\n+}\n+\n+const getNumberInput = query => {\n+ const rl = readline.createInterface({\n+ input: process.stdin,\n+ output: process.stdout\n+ });\n+\n+ return new Promise(resolve => rl.question(`\\n${query}`, answer => {\n+ const answerAsNumber = parseInt(answer, 10)\n+ rl.close()\n+ resolve(answerAsNumber)\n+ }))\n+ .then((answerAsNumber) => {\n+ if (!answerAsNumber) {\n+ console.log(`❌ That was not a valid integer. Please type a valid integer 🙄 \\n`)\n+ return getNumberInput(query)\n+ }\n+ return answerAsNumber\n+ })\n+}\n+\n+const proceedYesNo = async query => {\n+ const ok = await question(query || 'Is this correct?')\n+ if (ok) {\n+ console.log('✅ Great!\\n')\n+ } else {\n+ console.error('❌ Things were not correct. I don\\'t know how to automate this case 🤖😞')\n+ exitRelease()\n+ }\n+}\n+\n+const spawnAssumeOkay = async (cmd, cmdArgs, verbose) => {","path":"release.js","position":75,"original_position":75,"commit_id":"6b052dea511e0ac2b04f022a67d8486e638bae69","original_commit_id":"6b052dea511e0ac2b04f022a67d8486e638bae69","user":{"login":"rfreitas","id":651348,"node_id":"MDQ6VXNlcjY1MTM0OA==","avatar_url":"https://avatars3.githubusercontent.com/u/651348?v=4","gravatar_id":"","url":"https://api.github.com/users/rfreitas","html_url":"https://github.com/rfreitas","followers_url":"https://api.github.com/users/rfreitas/followers","following_url":"https://api.github.com/users/rfreitas/following{/other_user}","gists_url":"https://api.github.com/users/rfreitas/gists{/gist_id}","starred_url":"https://api.github.com/users/rfreitas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfreitas/subscriptions","organizations_url":"https://api.github.com/users/rfreitas/orgs","repos_url":"https://api.github.com/users/rfreitas/repos","events_url":"https://api.github.com/users/rfreitas/events{/privacy}","received_events_url":"https://api.github.com/users/rfreitas/received_events","type":"User","site_admin":false},"body":"what does `spawnAssumeOkay` do? 🤔 ","created_at":"2019-04-24T16:58:08Z","updated_at":"2019-04-24T16:58:08Z","html_url":"https://github.com/onfido/onfido-sdk-ui/pull/622#discussion_r278224733","pull_request_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/622","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments/278224733"},"html":{"href":"https://github.com/onfido/onfido-sdk-ui/pull/622#discussion_r278224733"},"pull_request":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/622"}}},"pull_request":{"url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/622","id":271399984,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxMzk5OTg0","html_url":"https://github.com/onfido/onfido-sdk-ui/pull/622","diff_url":"https://github.com/onfido/onfido-sdk-ui/pull/622.diff","patch_url":"https://github.com/onfido/onfido-sdk-ui/pull/622.patch","issue_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/622","number":622,"state":"open","locked":false,"title":"Feature/release script cx 2809","user":{"login":"stefaniacardenas","id":7127427,"node_id":"MDQ6VXNlcjcxMjc0Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/7127427?v=4","gravatar_id":"","url":"https://api.github.com/users/stefaniacardenas","html_url":"https://github.com/stefaniacardenas","followers_url":"https://api.github.com/users/stefaniacardenas/followers","following_url":"https://api.github.com/users/stefaniacardenas/following{/other_user}","gists_url":"https://api.github.com/users/stefaniacardenas/gists{/gist_id}","starred_url":"https://api.github.com/users/stefaniacardenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefaniacardenas/subscriptions","organizations_url":"https://api.github.com/users/stefaniacardenas/orgs","repos_url":"https://api.github.com/users/stefaniacardenas/repos","events_url":"https://api.github.com/users/stefaniacardenas/events{/privacy}","received_events_url":"https://api.github.com/users/stefaniacardenas/received_events","type":"User","site_admin":false},"body":"# Problem\r\nCurrently our release process is manual and it's very time consuming. In this PR I partially automated the release process.\r\n\r\n# Solution\r\nWhat has been automated?\r\n- Bump release/release candidate version in package.json\r\n- JSFiddle integrated with this github repository. The code is loaded into JSFiddle automatically.\r\n This only works on `master`. Please checkout this issue\r\n https://github.com/jsfiddle/jsfiddle-issues/issues/1420\r\n- Upgrade version in JSFiddle\r\n- Bump base32 version in webpack.config.babel.js\r\n- Creating and checking out the release branch\r\n- Push commits to release branch\r\n- Run `npm install` and `npm run build`\r\n- Create and push release candidate and release tag\r\n- Publish release/rc on NPM\r\n- Upgrade version of `onfido-sdk-ui` in local demo app\r\n\r\n### What is partially automated?\r\n- Login to S3. The script will generate the command you need to login to S3 and you will need to copy-paste it in another tab\r\n- It will generate the command you need to run in order to upload to S3\r\n- It checks if you are already logged in to NPM, if you are not it will print the command you need to run and it will wait for you to login before proceeding\r\n\r\n### What has NOT been automated?\r\nPost-release\r\nThe post release work has not been automated. Specifically, the following steps will be manual\r\n1. Merge release/<release_version> PR to master\r\n2. Merge master to development\r\n3. Create a new release on GitHub, using release tag:\r\n - title should be a version number <VERSION>\r\n - as description use the entries for that version from CHANGELOG.md\r\n4. Create PR to update Sample App\r\n\r\n## Usage\r\nIn order to use it you will need to download secrets as detailed in the release guidelines.\r\nRun `VERSION=x.x.x node release.js`\r\n\r\n## Note to reviewers\r\n`release.js` is a very large file. I tried to split it into different files but I had several issues due to need of storing data in variables. It might be good to refactor it by creating a tempfile to store the data and destroy it after the release\r\n\r\n## Checklist\r\n_put `n/a` if item is not relevant to PR changes_\r\n\r\n- [x] Have the CHANGELOG, README, MIGRATION, RELEASE_GUIDELINES docs been updated?\r\n- [ ] Have new automated tests been implemented?\r\n- [ ] Have new manual tests been written down?\r\n- [ ] Have tests passed locally?\r\n- [ ] Have any new strings been translated?\r\n","created_at":"2019-04-17T17:23:38Z","updated_at":"2019-04-24T16:58:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"544606b42d5be514ff68220d4b4557b3577c7ea1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"josokinas","id":20243687,"node_id":"MDQ6VXNlcjIwMjQzNjg3","avatar_url":"https://avatars2.githubusercontent.com/u/20243687?v=4","gravatar_id":"","url":"https://api.github.com/users/josokinas","html_url":"https://github.com/josokinas","followers_url":"https://api.github.com/users/josokinas/followers","following_url":"https://api.github.com/users/josokinas/following{/other_user}","gists_url":"https://api.github.com/users/josokinas/gists{/gist_id}","starred_url":"https://api.github.com/users/josokinas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josokinas/subscriptions","organizations_url":"https://api.github.com/users/josokinas/orgs","repos_url":"https://api.github.com/users/josokinas/repos","events_url":"https://api.github.com/users/josokinas/events{/privacy}","received_events_url":"https://api.github.com/users/josokinas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/622/commits","review_comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/622/comments","review_comment_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/622/comments","statuses_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/6b052dea511e0ac2b04f022a67d8486e638bae69","head":{"label":"onfido:feature/release-script-cx-2809","ref":"feature/release-script-cx-2809","sha":"6b052dea511e0ac2b04f022a67d8486e638bae69","user":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"repo":{"id":59305266,"node_id":"MDEwOlJlcG9zaXRvcnk1OTMwNTI2Ng==","name":"onfido-sdk-ui","full_name":"onfido/onfido-sdk-ui","private":false,"owner":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/onfido/onfido-sdk-ui","description":"The Onfido SDK for Front-end JavaScript","fork":false,"url":"https://api.github.com/repos/onfido/onfido-sdk-ui","forks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/forks","keys_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/teams","hooks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/hooks","issue_events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/events{/number}","events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/events","assignees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/assignees{/user}","branches_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/branches{/branch}","tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/tags","blobs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/languages","stargazers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/stargazers","contributors_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contributors","subscribers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscribers","subscription_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscription","commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contents/{+path}","compare_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/merges","archive_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/downloads","issues_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues{/number}","pulls_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/labels{/name}","releases_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/releases{/id}","deployments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/deployments","created_at":"2016-05-20T15:25:36Z","updated_at":"2019-04-18T07:37:55Z","pushed_at":"2019-04-24T16:54:03Z","git_url":"git://github.com/onfido/onfido-sdk-ui.git","ssh_url":"[email protected]:onfido/onfido-sdk-ui.git","clone_url":"https://github.com/onfido/onfido-sdk-ui.git","svn_url":"https://github.com/onfido/onfido-sdk-ui","homepage":"","size":26068,"stargazers_count":80,"watchers_count":80,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":41,"open_issues":25,"watchers":80,"default_branch":"master"}},"base":{"label":"onfido:development","ref":"development","sha":"5b62b91e0b40b9e6ebc773fc137ef900cef08564","user":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"repo":{"id":59305266,"node_id":"MDEwOlJlcG9zaXRvcnk1OTMwNTI2Ng==","name":"onfido-sdk-ui","full_name":"onfido/onfido-sdk-ui","private":false,"owner":{"login":"onfido","id":6752448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NTI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6752448?v=4","gravatar_id":"","url":"https://api.github.com/users/onfido","html_url":"https://github.com/onfido","followers_url":"https://api.github.com/users/onfido/followers","following_url":"https://api.github.com/users/onfido/following{/other_user}","gists_url":"https://api.github.com/users/onfido/gists{/gist_id}","starred_url":"https://api.github.com/users/onfido/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onfido/subscriptions","organizations_url":"https://api.github.com/users/onfido/orgs","repos_url":"https://api.github.com/users/onfido/repos","events_url":"https://api.github.com/users/onfido/events{/privacy}","received_events_url":"https://api.github.com/users/onfido/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/onfido/onfido-sdk-ui","description":"The Onfido SDK for Front-end JavaScript","fork":false,"url":"https://api.github.com/repos/onfido/onfido-sdk-ui","forks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/forks","keys_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/teams","hooks_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/hooks","issue_events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/events{/number}","events_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/events","assignees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/assignees{/user}","branches_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/branches{/branch}","tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/tags","blobs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/languages","stargazers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/stargazers","contributors_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contributors","subscribers_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscribers","subscription_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/subscription","commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/contents/{+path}","compare_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/merges","archive_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/downloads","issues_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues{/number}","pulls_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/labels{/name}","releases_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/releases{/id}","deployments_url":"https://api.github.com/repos/onfido/onfido-sdk-ui/deployments","created_at":"2016-05-20T15:25:36Z","updated_at":"2019-04-18T07:37:55Z","pushed_at":"2019-04-24T16:54:03Z","git_url":"git://github.com/onfido/onfido-sdk-ui.git","ssh_url":"[email protected]:onfido/onfido-sdk-ui.git","clone_url":"https://github.com/onfido/onfido-sdk-ui.git","svn_url":"https://github.com/onfido/onfido-sdk-ui","homepage":"","size":26068,"stargazers_count":80,"watchers_count":80,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":41,"open_issues":25,"watchers":80,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/622"},"html":{"href":"https://github.com/onfido/onfido-sdk-ui/pull/622"},"issue":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/622"},"comments":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/issues/622/comments"},"review_comments":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/622/comments"},"review_comment":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/pulls/622/commits"},"statuses":{"href":"https://api.github.com/repos/onfido/onfido-sdk-ui/statuses/6b052dea511e0ac2b04f022a67d8486e638bae69"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 59305266,
"name": "onfido/onfido-sdk-ui",
"url": "https://api.github.com/repos/onfido/onfido-sdk-ui"
}
|
{
"id": 651348,
"login": "rfreitas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/651348?",
"url": "https://api.github.com/users/rfreitas"
}
|
{
"id": 6752448,
"login": "onfido",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6752448?",
"url": "https://api.github.com/orgs/onfido"
}
| 2019-04-24T16:58:08 |
9503982120
|
{"actor":{"display_login":"rfreitas"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/cloud-on-k8s/pulls/comments/359728823","pull_request_review_id":334459339,"id":359728823,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1OTcyODgyMw==","diff_hunk":"@@ -0,0 +1,208 @@\n+// Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one\n+// or more contributor license agreements. Licensed under the Elastic License;\n+// you may not use this file except in compliance with the Elastic License.\n+\n+package license\n+\n+import (\n+\t\"fmt\"\n+\t\"regexp\"\n+\t\"strconv\"\n+\t\"strings\"\n+\n+\tapmv1 \"github.com/elastic/cloud-on-k8s/pkg/apis/apm/v1\"\n+\tesv1 \"github.com/elastic/cloud-on-k8s/pkg/apis/elasticsearch/v1\"\n+\tkbv1 \"github.com/elastic/cloud-on-k8s/pkg/apis/kibana/v1\"\n+\t\"github.com/elastic/cloud-on-k8s/pkg/controller/apmserver\"\n+\t\"github.com/elastic/cloud-on-k8s/pkg/controller/elasticsearch/nodespec\"\n+\tessettings \"github.com/elastic/cloud-on-k8s/pkg/controller/elasticsearch/settings\"\n+\tkbconfig \"github.com/elastic/cloud-on-k8s/pkg/controller/kibana/config\"\n+\tkbpod \"github.com/elastic/cloud-on-k8s/pkg/controller/kibana/pod\"\n+\t\"github.com/elastic/cloud-on-k8s/pkg/utils/k8s\"\n+\t\"github.com/pkg/errors\"\n+\tcorev1 \"k8s.io/api/core/v1\"\n+\t\"k8s.io/apimachinery/pkg/api/resource\"\n+)\n+\n+// Aggregator aggregates the total of resources of all Elastic managed components\n+type Aggregator struct {\n+\tclient k8s.Client\n+}\n+\n+type aggregate func() (resource.Quantity, error)\n+\n+// AggregateMemory aggregates the total memory of all Elastic managed components\n+func (a Aggregator) AggregateMemory() (resource.Quantity, error) {\n+\tvar totalMemory resource.Quantity\n+\n+\tfor _, f := range []aggregate{\n+\t\ta.aggregateElasticsearchMemory,\n+\t\ta.aggregateKibanaMemory,\n+\t\ta.aggregateApmServerMemory,\n+\t} {\n+\t\tmemory, err := f()\n+\t\tif err != nil {\n+\t\t\treturn resource.Quantity{}, err\n+\t\t}\n+\t\ttotalMemory.Add(memory)\n+\t}\n+\n+\treturn totalMemory, nil\n+}\n+\n+func (a Aggregator) aggregateElasticsearchMemory() (resource.Quantity, error) {\n+\tvar esList esv1.ElasticsearchList\n+\terr := a.client.List(&esList)\n+\tif err != nil {\n+\t\treturn resource.Quantity{}, errors.Wrap(err, \"failed to aggregate Elasticsearch memory\")\n+\t}\n+\n+\tvar total resource.Quantity\n+\tfor _, es := range esList.Items {\n+\t\tfor _, nodeSet := range es.Spec.NodeSets {\n+\t\t\tmem, err := containerMemLimits(\n+\t\t\t\tnodeSet.PodTemplate.Spec.Containers,\n+\t\t\t\tesv1.ElasticsearchContainerName,\n+\t\t\t\tessettings.EnvEsJavaOpts, memFromJavaOpts,\n+\t\t\t\tmultiply(nodespec.DefaultMemoryLimits, 2),\n+\t\t\t)\n+\t\t\tif err != nil {\n+\t\t\t\treturn resource.Quantity{}, errors.Wrap(err, \"failed to aggregate Elasticsearch memory\")\n+\t\t\t}\n+\n+\t\t\ttotal.Add(multiply(mem, nodeSet.Count))\n+\t\t\tlog.V(1).Info(\"Collecting\", \"es_name\", es.Name, \"memory\", mem.String(), \"count\", nodeSet.Count)\n+\t\t}\n+\t}\n+\n+\treturn total, nil\n+}\n+\n+func (a Aggregator) aggregateKibanaMemory() (resource.Quantity, error) {\n+\tvar kbList kbv1.KibanaList\n+\terr := a.client.List(&kbList)\n+\tif err != nil {\n+\t\treturn resource.Quantity{}, errors.Wrap(err, \"failed to aggregate Kibana memory\")\n+\t}\n+\n+\tvar total resource.Quantity\n+\tfor _, kb := range kbList.Items {\n+\t\tmem, err := containerMemLimits(\n+\t\t\tkb.Spec.PodTemplate.Spec.Containers,\n+\t\t\tkbv1.KibanaContainerName,\n+\t\t\tkbconfig.EnvNodeOpts, memFromNodeOptions,\n+\t\t\tkbpod.DefaultMemoryLimits,\n+\t\t)\n+\t\tif err != nil {\n+\t\t\treturn resource.Quantity{}, errors.Wrap(err, \"failed to aggregate Kibana memory\")\n+\t\t}\n+\n+\t\ttotal.Add(multiply(mem, kb.Spec.Count))\n+\t\tlog.V(1).Info(\"Collecting\", \"kibana_name\", kb.Name, \"memory\", mem.String(), \"count\", kb.Spec.Count)\n+\t}\n+\n+\treturn total, nil\n+}\n+\n+func (a Aggregator) aggregateApmServerMemory() (resource.Quantity, error) {\n+\tvar asList apmv1.ApmServerList\n+\terr := a.client.List(&asList)\n+\tif err != nil {\n+\t\treturn resource.Quantity{}, errors.Wrap(err, \"failed to aggregate APM Server memory\")\n+\t}\n+\n+\tvar total resource.Quantity\n+\tfor _, as := range asList.Items {\n+\t\tmem, err := containerMemLimits(\n+\t\t\tas.Spec.PodTemplate.Spec.Containers,\n+\t\t\tapmv1.ApmServerContainerName,\n+\t\t\t\"\", nil, // no fallback with limits defined in an env var\n+\t\t\tapmserver.DefaultMemoryLimits,\n+\t\t)\n+\t\tif err != nil {\n+\t\t\treturn resource.Quantity{}, errors.Wrap(err, \"failed to aggregate APM Server memory\")\n+\t\t}\n+\n+\t\ttotal.Add(multiply(mem, as.Spec.Count))\n+\t\tlog.V(1).Info(\"Collecting\", \"as_name\", as.Name, \"memory\", mem.String(), \"count\", as.Spec.Count)\n+\t}\n+\n+\treturn total, nil\n+}\n+\n+// containerMemLimits reads the container memory limits from the resource specification with fallback\n+// on the environment variable and on the default limits\n+func containerMemLimits(\n+\tcontainers []corev1.Container,\n+\tcontainerName string,\n+\tenvVarName string,\n+\tenvLookup func(envVar string) (resource.Quantity, error),\n+\tdefaultLimit resource.Quantity,\n+) (resource.Quantity, error) {\n+\tvar mem resource.Quantity\n+\tfor _, container := range containers {\n+\t\tif container.Name == containerName {\n+\t\t\tmem = *container.Resources.Limits.Memory()\n+\n+\t\t\t// if not, maybe fallback to the environment variable\n+\t\t\tif envLookup != nil && mem.IsZero() {\n+\t\t\t\tfor _, envVar := range container.Env {\n+\t\t\t\t\tif envVar.Name == envVarName {\n+\t\t\t\t\t\tvar err error\n+\t\t\t\t\t\tmem, err = envLookup(envVar.Value)\n+\t\t\t\t\t\tif err != nil {\n+\t\t\t\t\t\t\treturn resource.Quantity{}, err\n+\t\t\t\t\t\t}\n+\t\t\t\t\t}\n+\t\t\t\t}\n+\t\t\t}\n+\t\t}\n+\t}\n+\n+\t// if not, fallback to the default limits\n+\tif mem.IsZero() {\n+\t\tmem = defaultLimit\n+\t}\n+\n+\treturn mem, nil\n+}\n+\n+// maxHeapSizePattern is the pattern to extract the max Java heap size (-Xmx<size>[g|G|m|M|k|K] in binary units)\n+var maxHeapSizeRe = regexp.MustCompile(`-Xmx([0-9]+)([gGmMkK]?)(?:\\s.+|$)`)\n+\n+// memFromJavaOpts extracts the maximum Java heap size from a Java options string, multiplies the value by 2\n+// and converts it to a resource.Quantity\n+func memFromJavaOpts(javaOpts string) (resource.Quantity, error) {\n+\tmatch := maxHeapSizeRe.FindStringSubmatch(javaOpts)\n+\tif len(match) != 3 {\n+\t\treturn resource.Quantity{}, fmt.Errorf(\"cannot extract max jvm heap size from %s\", javaOpts)\n+\t}\n+\tvalue, err := strconv.Atoi(match[1])\n+\tif err != nil {\n+\t\treturn resource.Quantity{}, err\n+\t}\n+\t// capitalize the suffix unless to have a surjection of [g|G|m|M|k|K] in [Gi|Mi|Ki]\n+\tsuffix := strings.ToUpper(match[2]) + \"i\"\n+\t// multiply by 2 and convert it in a quantity using the suffix","path":"pkg/license/aggregator.go","position":186,"original_position":186,"commit_id":"1f5f1c30bca021eb67e15c517ec61d2d5384a10a","original_commit_id":"073ed06491b7007e0aa3d66981e8c91c025dde54","user":{"login":"sebgl","id":1050393,"node_id":"MDQ6VXNlcjEwNTAzOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1050393?v=4","gravatar_id":"","url":"https://api.github.com/users/sebgl","html_url":"https://github.com/sebgl","followers_url":"https://api.github.com/users/sebgl/followers","following_url":"https://api.github.com/users/sebgl/following{/other_user}","gists_url":"https://api.github.com/users/sebgl/gists{/gist_id}","starred_url":"https://api.github.com/users/sebgl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebgl/subscriptions","organizations_url":"https://api.github.com/users/sebgl/orgs","repos_url":"https://api.github.com/users/sebgl/repos","events_url":"https://api.github.com/users/sebgl/events{/privacy}","received_events_url":"https://api.github.com/users/sebgl/received_events","type":"User","site_admin":false},"body":"convert it to","created_at":"2019-12-19T08:04:57Z","updated_at":"2019-12-19T08:17:29Z","html_url":"https://github.com/elastic/cloud-on-k8s/pull/2277#discussion_r359728823","pull_request_url":"https://api.github.com/repos/elastic/cloud-on-k8s/pulls/2277","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/cloud-on-k8s/pulls/comments/359728823"},"html":{"href":"https://github.com/elastic/cloud-on-k8s/pull/2277#discussion_r359728823"},"pull_request":{"href":"https://api.github.com/repos/elastic/cloud-on-k8s/pulls/2277"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/cloud-on-k8s/pulls/2277","id":354045281,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0MDQ1Mjgx","html_url":"https://github.com/elastic/cloud-on-k8s/pull/2277","diff_url":"https://github.com/elastic/cloud-on-k8s/pull/2277.diff","patch_url":"https://github.com/elastic/cloud-on-k8s/pull/2277.patch","issue_url":"https://api.github.com/repos/elastic/cloud-on-k8s/issues/2277","number":2277,"state":"open","locked":false,"title":"Report total memory under management for licensing","user":{"login":"thbkrkr","id":582883,"node_id":"MDQ6VXNlcjU4Mjg4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/582883?v=4","gravatar_id":"","url":"https://api.github.com/users/thbkrkr","html_url":"https://github.com/thbkrkr","followers_url":"https://api.github.com/users/thbkrkr/followers","following_url":"https://api.github.com/users/thbkrkr/following{/other_user}","gists_url":"https://api.github.com/users/thbkrkr/gists{/gist_id}","starred_url":"https://api.github.com/users/thbkrkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thbkrkr/subscriptions","organizations_url":"https://api.github.com/users/thbkrkr/orgs","repos_url":"https://api.github.com/users/thbkrkr/repos","events_url":"https://api.github.com/users/thbkrkr/events{/privacy}","received_events_url":"https://api.github.com/users/thbkrkr/received_events","type":"User","site_admin":false},"body":"Start a reporter in a goroutine that repeatedly (every 2 minutes) aggregates the total memory of\r\nall Elastic managed components by the operator and reports it in the form of a licensing information\r\nin a config map.\r\n\r\n```sh\r\n> kubectl get cm elastic-licensing -o json | jq .data\r\n{\r\n \"enterprise_resource_units\": \"1\",\r\n \"license_level\": \"basic\",\r\n \"memory\": \"5.37GB\",\r\n \"timestamp\": \"2019-12-17T11:42:15+01:00\"\r\n}\r\n```\r\n\r\nI left `cmd/licensing-info/main.go` to show another use:\r\n\r\n```sh\r\n> go run cmd/licensing-info/main.go | jq . \r\n{\r\n \"timestamp\": \"2019-12-17T11:56:02+01:00\",\r\n \"license_level\": \"basic\",\r\n \"memory\": \"5.37GB\",\r\n \"enterprise_resource_units\": \"1\"\r\n}\r\n```\r\n","created_at":"2019-12-17T11:04:44Z","updated_at":"2019-12-19T08:17:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c61bacda6f25837155ca9a39cce203b8a53e6ed","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pebrc","id":697790,"node_id":"MDQ6VXNlcjY5Nzc5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/697790?v=4","gravatar_id":"","url":"https://api.github.com/users/pebrc","html_url":"https://github.com/pebrc","followers_url":"https://api.github.com/users/pebrc/followers","following_url":"https://api.github.com/users/pebrc/following{/other_user}","gists_url":"https://api.github.com/users/pebrc/gists{/gist_id}","starred_url":"https://api.github.com/users/pebrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pebrc/subscriptions","organizations_url":"https://api.github.com/users/pebrc/orgs","repos_url":"https://api.github.com/users/pebrc/repos","events_url":"https://api.github.com/users/pebrc/events{/privacy}","received_events_url":"https://api.github.com/users/pebrc/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1375758911,"node_id":"MDU6TGFiZWwxMzc1NzU4OTEx","url":"https://api.github.com/repos/elastic/cloud-on-k8s/labels/%3Efeature","name":">feature","color":"47c6b3","default":false,"description":"Adds or discusses adding a feature to the product"},{"id":1619633206,"node_id":"MDU6TGFiZWwxNjE5NjMzMjA2","url":"https://api.github.com/repos/elastic/cloud-on-k8s/labels/v1.0.0","name":"v1.0.0","color":"4440f9","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/cloud-on-k8s/pulls/2277/commits","review_comments_url":"https://api.github.com/repos/elastic/cloud-on-k8s/pulls/2277/comments","review_comment_url":"https://api.github.com/repos/elastic/cloud-on-k8s/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/cloud-on-k8s/issues/2277/comments","statuses_url":"https://api.github.com/repos/elastic/cloud-on-k8s/statuses/1f5f1c30bca021eb67e15c517ec61d2d5384a10a","head":{"label":"thbkrkr:memory-accounting-for-licensing","ref":"memory-accounting-for-licensing","sha":"1f5f1c30bca021eb67e15c517ec61d2d5384a10a","user":{"login":"thbkrkr","id":582883,"node_id":"MDQ6VXNlcjU4Mjg4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/582883?v=4","gravatar_id":"","url":"https://api.github.com/users/thbkrkr","html_url":"https://github.com/thbkrkr","followers_url":"https://api.github.com/users/thbkrkr/followers","following_url":"https://api.github.com/users/thbkrkr/following{/other_user}","gists_url":"https://api.github.com/users/thbkrkr/gists{/gist_id}","starred_url":"https://api.github.com/users/thbkrkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thbkrkr/subscriptions","organizations_url":"https://api.github.com/users/thbkrkr/orgs","repos_url":"https://api.github.com/users/thbkrkr/repos","events_url":"https://api.github.com/users/thbkrkr/events{/privacy}","received_events_url":"https://api.github.com/users/thbkrkr/received_events","type":"User","site_admin":false},"repo":{"id":187668392,"node_id":"MDEwOlJlcG9zaXRvcnkxODc2NjgzOTI=","name":"cloud-on-k8s","full_name":"thbkrkr/cloud-on-k8s","private":false,"owner":{"login":"thbkrkr","id":582883,"node_id":"MDQ6VXNlcjU4Mjg4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/582883?v=4","gravatar_id":"","url":"https://api.github.com/users/thbkrkr","html_url":"https://github.com/thbkrkr","followers_url":"https://api.github.com/users/thbkrkr/followers","following_url":"https://api.github.com/users/thbkrkr/following{/other_user}","gists_url":"https://api.github.com/users/thbkrkr/gists{/gist_id}","starred_url":"https://api.github.com/users/thbkrkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thbkrkr/subscriptions","organizations_url":"https://api.github.com/users/thbkrkr/orgs","repos_url":"https://api.github.com/users/thbkrkr/repos","events_url":"https://api.github.com/users/thbkrkr/events{/privacy}","received_events_url":"https://api.github.com/users/thbkrkr/received_events","type":"User","site_admin":false},"html_url":"https://github.com/thbkrkr/cloud-on-k8s","description":"Elastic Cloud on Kubernetes","fork":true,"url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s","forks_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/forks","keys_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/teams","hooks_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/hooks","issue_events_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/issues/events{/number}","events_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/events","assignees_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/assignees{/user}","branches_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/branches{/branch}","tags_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/tags","blobs_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/git/refs{/sha}","trees_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/statuses/{sha}","languages_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/languages","stargazers_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/stargazers","contributors_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/contributors","subscribers_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/subscribers","subscription_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/subscription","commits_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/commits{/sha}","git_commits_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/git/commits{/sha}","comments_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/comments{/number}","issue_comment_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/issues/comments{/number}","contents_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/contents/{+path}","compare_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/merges","archive_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/downloads","issues_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/issues{/number}","pulls_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/pulls{/number}","milestones_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/milestones{/number}","notifications_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/labels{/name}","releases_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/releases{/id}","deployments_url":"https://api.github.com/repos/thbkrkr/cloud-on-k8s/deployments","created_at":"2019-05-20T15:33:55Z","updated_at":"2019-12-18T20:27:57Z","pushed_at":"2019-12-19T08:02:00Z","git_url":"git://github.com/thbkrkr/cloud-on-k8s.git","ssh_url":"[email protected]:thbkrkr/cloud-on-k8s.git","clone_url":"https://github.com/thbkrkr/cloud-on-k8s.git","svn_url":"https://github.com/thbkrkr/cloud-on-k8s","homepage":"","size":7570,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"63582d14f1fb94f1a417c80bf3a49eeb885f9cf4","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":155368246,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUzNjgyNDY=","name":"cloud-on-k8s","full_name":"elastic/cloud-on-k8s","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/cloud-on-k8s","description":"Elastic Cloud on Kubernetes","fork":false,"url":"https://api.github.com/repos/elastic/cloud-on-k8s","forks_url":"https://api.github.com/repos/elastic/cloud-on-k8s/forks","keys_url":"https://api.github.com/repos/elastic/cloud-on-k8s/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/cloud-on-k8s/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/cloud-on-k8s/teams","hooks_url":"https://api.github.com/repos/elastic/cloud-on-k8s/hooks","issue_events_url":"https://api.github.com/repos/elastic/cloud-on-k8s/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/cloud-on-k8s/events","assignees_url":"https://api.github.com/repos/elastic/cloud-on-k8s/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/cloud-on-k8s/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/cloud-on-k8s/tags","blobs_url":"https://api.github.com/repos/elastic/cloud-on-k8s/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/cloud-on-k8s/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/cloud-on-k8s/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/cloud-on-k8s/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/cloud-on-k8s/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/cloud-on-k8s/languages","stargazers_url":"https://api.github.com/repos/elastic/cloud-on-k8s/stargazers","contributors_url":"https://api.github.com/repos/elastic/cloud-on-k8s/contributors","subscribers_url":"https://api.github.com/repos/elastic/cloud-on-k8s/subscribers","subscription_url":"https://api.github.com/repos/elastic/cloud-on-k8s/subscription","commits_url":"https://api.github.com/repos/elastic/cloud-on-k8s/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/cloud-on-k8s/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/cloud-on-k8s/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/cloud-on-k8s/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/cloud-on-k8s/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/cloud-on-k8s/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/cloud-on-k8s/merges","archive_url":"https://api.github.com/repos/elastic/cloud-on-k8s/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/cloud-on-k8s/downloads","issues_url":"https://api.github.com/repos/elastic/cloud-on-k8s/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/cloud-on-k8s/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/cloud-on-k8s/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/cloud-on-k8s/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/cloud-on-k8s/labels{/name}","releases_url":"https://api.github.com/repos/elastic/cloud-on-k8s/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/cloud-on-k8s/deployments","created_at":"2018-10-30T10:43:58Z","updated_at":"2019-12-19T07:55:17Z","pushed_at":"2019-12-19T08:02:02Z","git_url":"git://github.com/elastic/cloud-on-k8s.git","ssh_url":"[email protected]:elastic/cloud-on-k8s.git","clone_url":"https://github.com/elastic/cloud-on-k8s.git","svn_url":"https://github.com/elastic/cloud-on-k8s","homepage":"","size":7521,"stargazers_count":675,"watchers_count":675,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":121,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":195,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":121,"open_issues":195,"watchers":675,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/cloud-on-k8s/pulls/2277"},"html":{"href":"https://github.com/elastic/cloud-on-k8s/pull/2277"},"issue":{"href":"https://api.github.com/repos/elastic/cloud-on-k8s/issues/2277"},"comments":{"href":"https://api.github.com/repos/elastic/cloud-on-k8s/issues/2277/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/cloud-on-k8s/pulls/2277/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/cloud-on-k8s/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/cloud-on-k8s/pulls/2277/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/cloud-on-k8s/statuses/1f5f1c30bca021eb67e15c517ec61d2d5384a10a"}},"author_association":"COLLABORATOR"}}
|
{
"id": 155368246,
"name": "elastic/cloud-on-k8s",
"url": "https://api.github.com/repos/elastic/cloud-on-k8s"
}
|
{
"id": 1050393,
"login": "sebgl",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1050393?",
"url": "https://api.github.com/users/sebgl"
}
|
{
"id": 6764390,
"login": "elastic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6764390?",
"url": "https://api.github.com/orgs/elastic"
}
| 2019-12-19T08:04:57 |
11123720932
|
{"actor":{"display_login":"sebgl"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/apm-agent-dotnet/pulls/comments/360310033","pull_request_review_id":335174389,"id":360310033,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MDMxMDAzMw==","diff_hunk":"@@ -0,0 +1,174 @@\n+using System;\n+using System.Collections.Concurrent;\n+using System.Collections.Generic;\n+using Elastic.Apm.Api;\n+using Elastic.Apm.DiagnosticSource;\n+using Elastic.Apm.Helpers;\n+using Elastic.Apm.Logging;\n+\n+namespace Elastic.Apm.SqlClient\n+{\n+\tinternal class SqlClientDiagnosticListener : IDiagnosticListener\n+\t{\n+\t\tprivate class PropertyFetcherSet\n+\t\t{\n+\t\t\tpublic PropertyFetcher StartCorrelationId { get; } = new PropertyFetcher(\"OperationId\");\n+\t\t\tpublic PropertyFetcher StopCorrelationId { get; } = new PropertyFetcher(\"OperationId\");\n+\t\t\tpublic PropertyFetcher ErrorCorrelationId { get; } = new PropertyFetcher(\"OperationId\");\n+\n+\t\t\tpublic PropertyFetcher Statistics { get; } = new PropertyFetcher(\"Statistics\");\n+\n+\t\t\tpublic PropertyFetcher CommandText { get; }\n+\t\t\tpublic PropertyFetcher CommandType { get; }\n+\t\t\tpublic PropertyFetcher Database { get; }\n+\n+\t\t\tpublic PropertyFetcher Exception { get; } = new PropertyFetcher(\"Exception\");\n+\n+\t\t\tpublic PropertyFetcherSet()\n+\t\t\t{\n+\t\t\t\tvar commandPropertyFetcher = new PropertyFetcher(\"Command\");\n+\t\t\t\tvar connectionPropertyFetcher = new CascadePropertyFetcher(commandPropertyFetcher, \"Connection\");\n+\n+\t\t\t\tCommandText = new CascadePropertyFetcher(commandPropertyFetcher, \"CommandText\");\n+\t\t\t\tCommandType = new CascadePropertyFetcher(commandPropertyFetcher, \"CommandType\");\n+\n+\t\t\t\tDatabase = new CascadePropertyFetcher(connectionPropertyFetcher, \"Database\");\n+\t\t\t}\n+\t\t}\n+\n+\t\tprivate readonly IApmAgent _apmAgent;\n+\t\tprivate readonly IApmLogger _logger;\n+\n+\t\tprivate readonly ConcurrentDictionary<Guid, ISpan> _processingQueries = new ConcurrentDictionary<Guid, ISpan>();\n+\n+\t\tprivate readonly PropertyFetcherSet _systemPropertyFetcherSet = new PropertyFetcherSet();\n+\t\tprivate readonly PropertyFetcherSet _microsoftPropertyFetcherSet = new PropertyFetcherSet();\n+\n+\n+\t\tpublic SqlClientDiagnosticListener(IApmAgent apmAgent)\n+\t\t{\n+\t\t\t_apmAgent = apmAgent;\n+\t\t\t_logger = _apmAgent.Logger.Scoped(nameof(SqlClientDiagnosticListener));\n+\t\t}\n+\n+\t\tpublic string Name => \"SqlClientDiagnosticListener\";\n+\n+\t\t// prefix - Microsoft.Data.SqlClient. or System.Data.SqlClient.\n+\t\tpublic void OnNext(KeyValuePair<string, object> value)\n+\t\t{\n+\t\t\tif (value.Key.StartsWith(\"Microsoft.Data.SqlClient.\") || value.Key.StartsWith(\"System.Data.SqlClient.\"))\n+\t\t\t{\n+\t\t\t\tswitch (value.Key)\n+\t\t\t\t{\n+\t\t\t\t\tcase string s when s.EndsWith(\"WriteCommandBefore\") && _apmAgent.Tracer.CurrentTransaction != null:\n+\t\t\t\t\t\tHandleStartCommand(value.Value, value.Key.StartsWith(\"System\") ? _systemPropertyFetcherSet : _microsoftPropertyFetcherSet);\n+\t\t\t\t\t\tbreak;\n+\t\t\t\t\tcase string s when s.EndsWith(\"WriteCommandAfter\"):\n+\t\t\t\t\t\tHandleStopCommand(value.Value, value.Key.StartsWith(\"System\") ? _systemPropertyFetcherSet : _microsoftPropertyFetcherSet);\n+\t\t\t\t\t\tbreak;\n+\t\t\t\t\tcase string s when s.EndsWith(\"WriteCommandError\"):\n+\t\t\t\t\t\tHandleErrorCommand(value.Value, value.Key.StartsWith(\"System\") ? _systemPropertyFetcherSet : _microsoftPropertyFetcherSet);\n+\t\t\t\t\t\tbreak;\n+\t\t\t\t}\n+\t\t\t}\n+\t\t}\n+\n+\t\tprivate void HandleStartCommand(object payloadData, PropertyFetcherSet propertyFetcherSet)\n+\t\t{\n+\t\t\ttry\n+\t\t\t{\n+\t\t\t\tvar transaction = _apmAgent.Tracer.CurrentTransaction;","path":"src/Elastic.Apm.SqlClient/SqlClientDiagnosticListener.cs","position":null,"original_position":80,"commit_id":"e56e6f4e1a3d17a3b69c40d46b498ff5c44e27d8","original_commit_id":"f6708fa62843bfbf69a144767aab27a25b19b5d6","user":{"login":"SergeyKleyman","id":7782093,"node_id":"MDQ6VXNlcjc3ODIwOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/7782093?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeyKleyman","html_url":"https://github.com/SergeyKleyman","followers_url":"https://api.github.com/users/SergeyKleyman/followers","following_url":"https://api.github.com/users/SergeyKleyman/following{/other_user}","gists_url":"https://api.github.com/users/SergeyKleyman/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyKleyman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyKleyman/subscriptions","organizations_url":"https://api.github.com/users/SergeyKleyman/orgs","repos_url":"https://api.github.com/users/SergeyKleyman/repos","events_url":"https://api.github.com/users/SergeyKleyman/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyKleyman/received_events","type":"User","site_admin":false},"body":"I think capturing whatever possible in `Start` instead of waiting for `End` might be a good idea. I even considered if this change might affect unusual use cases such as [this one](https://discuss.elastic.co/t/get-currentspan-in-net-apm-agent/211741/5) and I think it shouldn't.\r\n\r\n","created_at":"2019-12-20T10:19:18Z","updated_at":"2019-12-20T10:19:18Z","html_url":"https://github.com/elastic/apm-agent-dotnet/pull/592#discussion_r360310033","pull_request_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/pulls/592","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/apm-agent-dotnet/pulls/comments/360310033"},"html":{"href":"https://github.com/elastic/apm-agent-dotnet/pull/592#discussion_r360310033"},"pull_request":{"href":"https://api.github.com/repos/elastic/apm-agent-dotnet/pulls/592"}},"in_reply_to_id":358198766},"pull_request":{"url":"https://api.github.com/repos/elastic/apm-agent-dotnet/pulls/592","id":339182512,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM5MTgyNTEy","html_url":"https://github.com/elastic/apm-agent-dotnet/pull/592","diff_url":"https://github.com/elastic/apm-agent-dotnet/pull/592.diff","patch_url":"https://github.com/elastic/apm-agent-dotnet/pull/592.patch","issue_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/issues/592","number":592,"state":"open","locked":false,"title":"Add instrumentation for sqlclient","user":{"login":"vhatsura","id":10338692,"node_id":"MDQ6VXNlcjEwMzM4Njky","avatar_url":"https://avatars2.githubusercontent.com/u/10338692?v=4","gravatar_id":"","url":"https://api.github.com/users/vhatsura","html_url":"https://github.com/vhatsura","followers_url":"https://api.github.com/users/vhatsura/followers","following_url":"https://api.github.com/users/vhatsura/following{/other_user}","gists_url":"https://api.github.com/users/vhatsura/gists{/gist_id}","starred_url":"https://api.github.com/users/vhatsura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vhatsura/subscriptions","organizations_url":"https://api.github.com/users/vhatsura/orgs","repos_url":"https://api.github.com/users/vhatsura/repos","events_url":"https://api.github.com/users/vhatsura/events{/privacy}","received_events_url":"https://api.github.com/users/vhatsura/received_events","type":"User","site_admin":false},"body":"resolves #114 \r\n\r\n`SqlClientDiagnosticListener` allows processing events from `Microsoft.Data.SqlClient` and `System.Data.SqlClient`. As payload data spreads as anonymous objects, it needed to use reflection to access properties. [Diagnostic source users guide suggests using property fetchers](https://github.com/dotnet/corefx/blob/master/src/System.Diagnostics.DiagnosticSource/src/DiagnosticSourceUsersGuide.md#decoding-payloads) to reduce the overhead of reflection. To measure the difference in performance between reflection and property fetchers I wrote a benchmark. You can run it on your PC, but I got the following results on my machine:\r\n\r\n```\r\nBenchmarkDotNet=v0.11.4, OS=Windows 10.0.19002\r\nIntel Core i7-7700 CPU 3.60GHz (Kaby Lake), 1 CPU, 8 logical and 4 physical cores\r\n.NET Core SDK=2.1.505\r\n [Host] : .NET Core 2.1.9 (CoreCLR 4.6.27414.06, CoreFX 4.6.27415.01), 64bit RyuJIT\r\n DefaultJob : .NET Core 2.1.9 (CoreCLR 4.6.27414.06, CoreFX 4.6.27415.01), 64bit RyuJIT\r\n\r\n\r\n| Method | Mean | Error | StdDev |\r\n|------------------- |----------:|----------:|----------:|\r\n| Reflection | 348.15 ns | 8.4263 ns | 8.6532 ns |\r\n| PropertyFetcher | 15.38 ns | 0.3566 ns | 0.3503 ns |\r\n| CascadeFetcher | 16.10 ns | 0.4180 ns | 0.7953 ns |\r\n| CachedPropertyInfo | 146.53 ns | 2.9561 ns | 4.2396 ns |\r\n\r\n```\r\n\r\nDue to property fetcher needs to use specific type, we need to have two property fetcher sets: one for `System.Data.SqlClient` and another for `Microsoft.Data.SqlClient`\r\n\r\nTo test the listener I use [`TestEnvironment.Docker`](https://github.com/Deffiss/testenvironment-docker), which allows running docker images from tests. It can be an issue for your CI due to docker needs to be installed on CI machines. I know that some CI tools allow using services for running docker images during the build, however, I don't sure that it's an option in case of Jenkins. Also, it cannot be repeated on local machine without additional effort before each test run.\r\nAnother issue with `TestEnvironment.Docker` is missing a strong name.\r\n\r\nP.S.: I think that http diagnostic listeners can be rewritten to use property fetchers instead of reflection.\r\n","created_at":"2019-11-10T19:32:03Z","updated_at":"2019-12-20T10:19:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d27a4f76006e8b1fd131f8322ca93998cf76a077","assignee":{"login":"gregkalapos","id":1091853,"node_id":"MDQ6VXNlcjEwOTE4NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1091853?v=4","gravatar_id":"","url":"https://api.github.com/users/gregkalapos","html_url":"https://github.com/gregkalapos","followers_url":"https://api.github.com/users/gregkalapos/followers","following_url":"https://api.github.com/users/gregkalapos/following{/other_user}","gists_url":"https://api.github.com/users/gregkalapos/gists{/gist_id}","starred_url":"https://api.github.com/users/gregkalapos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregkalapos/subscriptions","organizations_url":"https://api.github.com/users/gregkalapos/orgs","repos_url":"https://api.github.com/users/gregkalapos/repos","events_url":"https://api.github.com/users/gregkalapos/events{/privacy}","received_events_url":"https://api.github.com/users/gregkalapos/received_events","type":"User","site_admin":false},"assignees":[{"login":"gregkalapos","id":1091853,"node_id":"MDQ6VXNlcjEwOTE4NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1091853?v=4","gravatar_id":"","url":"https://api.github.com/users/gregkalapos","html_url":"https://github.com/gregkalapos","followers_url":"https://api.github.com/users/gregkalapos/followers","following_url":"https://api.github.com/users/gregkalapos/following{/other_user}","gists_url":"https://api.github.com/users/gregkalapos/gists{/gist_id}","starred_url":"https://api.github.com/users/gregkalapos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregkalapos/subscriptions","organizations_url":"https://api.github.com/users/gregkalapos/orgs","repos_url":"https://api.github.com/users/gregkalapos/repos","events_url":"https://api.github.com/users/gregkalapos/events{/privacy}","received_events_url":"https://api.github.com/users/gregkalapos/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"SergeyKleyman","id":7782093,"node_id":"MDQ6VXNlcjc3ODIwOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/7782093?v=4","gravatar_id":"","url":"https://api.github.com/users/SergeyKleyman","html_url":"https://github.com/SergeyKleyman","followers_url":"https://api.github.com/users/SergeyKleyman/followers","following_url":"https://api.github.com/users/SergeyKleyman/following{/other_user}","gists_url":"https://api.github.com/users/SergeyKleyman/gists{/gist_id}","starred_url":"https://api.github.com/users/SergeyKleyman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergeyKleyman/subscriptions","organizations_url":"https://api.github.com/users/SergeyKleyman/orgs","repos_url":"https://api.github.com/users/SergeyKleyman/repos","events_url":"https://api.github.com/users/SergeyKleyman/events{/privacy}","received_events_url":"https://api.github.com/users/SergeyKleyman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/pulls/592/commits","review_comments_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/pulls/592/comments","review_comment_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/issues/592/comments","statuses_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/statuses/e56e6f4e1a3d17a3b69c40d46b498ff5c44e27d8","head":{"label":"vhatsura:instrumentation/sqlclient","ref":"instrumentation/sqlclient","sha":"e56e6f4e1a3d17a3b69c40d46b498ff5c44e27d8","user":{"login":"vhatsura","id":10338692,"node_id":"MDQ6VXNlcjEwMzM4Njky","avatar_url":"https://avatars2.githubusercontent.com/u/10338692?v=4","gravatar_id":"","url":"https://api.github.com/users/vhatsura","html_url":"https://github.com/vhatsura","followers_url":"https://api.github.com/users/vhatsura/followers","following_url":"https://api.github.com/users/vhatsura/following{/other_user}","gists_url":"https://api.github.com/users/vhatsura/gists{/gist_id}","starred_url":"https://api.github.com/users/vhatsura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vhatsura/subscriptions","organizations_url":"https://api.github.com/users/vhatsura/orgs","repos_url":"https://api.github.com/users/vhatsura/repos","events_url":"https://api.github.com/users/vhatsura/events{/privacy}","received_events_url":"https://api.github.com/users/vhatsura/received_events","type":"User","site_admin":false},"repo":{"id":188105458,"node_id":"MDEwOlJlcG9zaXRvcnkxODgxMDU0NTg=","name":"apm-agent-dotnet","full_name":"vhatsura/apm-agent-dotnet","private":false,"owner":{"login":"vhatsura","id":10338692,"node_id":"MDQ6VXNlcjEwMzM4Njky","avatar_url":"https://avatars2.githubusercontent.com/u/10338692?v=4","gravatar_id":"","url":"https://api.github.com/users/vhatsura","html_url":"https://github.com/vhatsura","followers_url":"https://api.github.com/users/vhatsura/followers","following_url":"https://api.github.com/users/vhatsura/following{/other_user}","gists_url":"https://api.github.com/users/vhatsura/gists{/gist_id}","starred_url":"https://api.github.com/users/vhatsura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vhatsura/subscriptions","organizations_url":"https://api.github.com/users/vhatsura/orgs","repos_url":"https://api.github.com/users/vhatsura/repos","events_url":"https://api.github.com/users/vhatsura/events{/privacy}","received_events_url":"https://api.github.com/users/vhatsura/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vhatsura/apm-agent-dotnet","description":"Elastic APM .NET Agent","fork":true,"url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet","forks_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/forks","keys_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/teams","hooks_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/hooks","issue_events_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/events","assignees_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/tags","blobs_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/languages","stargazers_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/stargazers","contributors_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/contributors","subscribers_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/subscribers","subscription_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/subscription","commits_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/merges","archive_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/downloads","issues_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/vhatsura/apm-agent-dotnet/deployments","created_at":"2019-05-22T20:00:51Z","updated_at":"2019-07-19T21:37:23Z","pushed_at":"2019-12-20T08:38:12Z","git_url":"git://github.com/vhatsura/apm-agent-dotnet.git","ssh_url":"[email protected]:vhatsura/apm-agent-dotnet.git","clone_url":"https://github.com/vhatsura/apm-agent-dotnet.git","svn_url":"https://github.com/vhatsura/apm-agent-dotnet","homepage":"","size":3376,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"135945385167323b5236b469ea1585c8f40df878","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":155592028,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU1OTIwMjg=","name":"apm-agent-dotnet","full_name":"elastic/apm-agent-dotnet","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/apm-agent-dotnet","description":"Elastic APM .NET Agent","fork":false,"url":"https://api.github.com/repos/elastic/apm-agent-dotnet","forks_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/forks","keys_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/teams","hooks_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/hooks","issue_events_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/events","assignees_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/tags","blobs_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/languages","stargazers_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/stargazers","contributors_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/contributors","subscribers_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/subscribers","subscription_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/subscription","commits_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/merges","archive_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/downloads","issues_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/apm-agent-dotnet/deployments","created_at":"2018-10-31T16:46:26Z","updated_at":"2019-12-19T23:15:52Z","pushed_at":"2019-12-20T08:38:14Z","git_url":"git://github.com/elastic/apm-agent-dotnet.git","ssh_url":"[email protected]:elastic/apm-agent-dotnet.git","clone_url":"https://github.com/elastic/apm-agent-dotnet.git","svn_url":"https://github.com/elastic/apm-agent-dotnet","homepage":"https://www.elastic.co/guide/en/apm/agent/dotnet/current/index.html","size":3386,"stargazers_count":296,"watchers_count":296,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":75,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":137,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":75,"open_issues":137,"watchers":296,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/apm-agent-dotnet/pulls/592"},"html":{"href":"https://github.com/elastic/apm-agent-dotnet/pull/592"},"issue":{"href":"https://api.github.com/repos/elastic/apm-agent-dotnet/issues/592"},"comments":{"href":"https://api.github.com/repos/elastic/apm-agent-dotnet/issues/592/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/apm-agent-dotnet/pulls/592/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/apm-agent-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/apm-agent-dotnet/pulls/592/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/apm-agent-dotnet/statuses/e56e6f4e1a3d17a3b69c40d46b498ff5c44e27d8"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 155592028,
"name": "elastic/apm-agent-dotnet",
"url": "https://api.github.com/repos/elastic/apm-agent-dotnet"
}
|
{
"id": 7782093,
"login": "SergeyKleyman",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7782093?",
"url": "https://api.github.com/users/SergeyKleyman"
}
|
{
"id": 6764390,
"login": "elastic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6764390?",
"url": "https://api.github.com/orgs/elastic"
}
| 2019-12-20T10:19:18 |
11133852221
|
{"actor":{"display_login":"SergeyKleyman"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/280581894","pull_request_review_id":233218933,"id":280581894,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MDU4MTg5NA==","diff_hunk":"@@ -0,0 +1,47 @@\n+/*\n+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one\n+ * or more contributor license agreements. Licensed under the Elastic License;\n+ * you may not use this file except in compliance with the Elastic License.\n+ */\n+\n+\n+\n+import React, { Fragment } from 'react';\n+import { PropTypes } from 'prop-types';\n+import { EuiToolTip } from '@elastic/eui';\n+\n+export function TimeRangeBar({\n+ isRunning,\n+ timerange\n+}) {\n+ const style = {\n+ width: (isRunning ? '299px' : timerange.widthPx),","path":"x-pack/plugins/ml/public/components/job_selector/timerange_bar/timerange_bar.js","position":null,"original_position":18,"commit_id":"95afddaf31bc5c97caff1d6347711aa8db1a5c05","original_commit_id":"41ba083db291184cdd01d9f27ebf17b9d2688e5f","user":{"login":"alvarezmelissa87","id":6446462,"node_id":"MDQ6VXNlcjY0NDY0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/6446462?v=4","gravatar_id":"","url":"https://api.github.com/users/alvarezmelissa87","html_url":"https://github.com/alvarezmelissa87","followers_url":"https://api.github.com/users/alvarezmelissa87/followers","following_url":"https://api.github.com/users/alvarezmelissa87/following{/other_user}","gists_url":"https://api.github.com/users/alvarezmelissa87/gists{/gist_id}","starred_url":"https://api.github.com/users/alvarezmelissa87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvarezmelissa87/subscriptions","organizations_url":"https://api.github.com/users/alvarezmelissa87/orgs","repos_url":"https://api.github.com/users/alvarezmelissa87/repos","events_url":"https://api.github.com/users/alvarezmelissa87/events{/privacy}","received_events_url":"https://api.github.com/users/alvarezmelissa87/received_events","type":"User","site_admin":false},"body":"Good point - updated in: 95afddaf31bc5c97caff1d6347711aa8db1a5c05","created_at":"2019-05-02T20:23:38Z","updated_at":"2019-05-02T20:23:38Z","html_url":"https://github.com/elastic/kibana/pull/35638#discussion_r280581894","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/35638","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/280581894"},"html":{"href":"https://github.com/elastic/kibana/pull/35638#discussion_r280581894"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/35638"}},"in_reply_to_id":280036106},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/35638","id":273742329,"node_id":"MDExOlB1bGxSZXF1ZXN0MjczNzQyMzI5","html_url":"https://github.com/elastic/kibana/pull/35638","diff_url":"https://github.com/elastic/kibana/pull/35638.diff","patch_url":"https://github.com/elastic/kibana/pull/35638.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/35638","number":35638,"state":"open","locked":false,"title":"[ML] Job Selector conversion to React","user":{"login":"alvarezmelissa87","id":6446462,"node_id":"MDQ6VXNlcjY0NDY0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/6446462?v=4","gravatar_id":"","url":"https://api.github.com/users/alvarezmelissa87","html_url":"https://github.com/alvarezmelissa87","followers_url":"https://api.github.com/users/alvarezmelissa87/followers","following_url":"https://api.github.com/users/alvarezmelissa87/following{/other_user}","gists_url":"https://api.github.com/users/alvarezmelissa87/gists{/gist_id}","starred_url":"https://api.github.com/users/alvarezmelissa87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvarezmelissa87/subscriptions","organizations_url":"https://api.github.com/users/alvarezmelissa87/orgs","repos_url":"https://api.github.com/users/alvarezmelissa87/repos","events_url":"https://api.github.com/users/alvarezmelissa87/events{/privacy}","received_events_url":"https://api.github.com/users/alvarezmelissa87/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nJob Selector rewrite to React/eui.\r\n\r\nMeta issue with details and screenshots: https://github.com/elastic/kibana/issues/34428\r\n\r\n#### Note:\r\n- I'll be adding tests but core code won't be changing so it's ready to be looked at.\r\n\r\n### Checklist\r\n\r\nUse ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.\r\n\r\n- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)\r\n- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)\r\n~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~\r\n- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios\r\n- [x] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)\r\n\r\n### For maintainers\r\n\r\n~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~\r\n~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~\r\n\r\n","created_at":"2019-04-26T02:38:28Z","updated_at":"2019-05-02T20:23:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dacf0313f7460a719972522b90f99cec7e850117","assignee":null,"assignees":[],"requested_reviewers":[{"login":"walterra","id":230104,"node_id":"MDQ6VXNlcjIzMDEwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/230104?v=4","gravatar_id":"","url":"https://api.github.com/users/walterra","html_url":"https://github.com/walterra","followers_url":"https://api.github.com/users/walterra/followers","following_url":"https://api.github.com/users/walterra/following{/other_user}","gists_url":"https://api.github.com/users/walterra/gists{/gist_id}","starred_url":"https://api.github.com/users/walterra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walterra/subscriptions","organizations_url":"https://api.github.com/users/walterra/orgs","repos_url":"https://api.github.com/users/walterra/repos","events_url":"https://api.github.com/users/walterra/events{/privacy}","received_events_url":"https://api.github.com/users/walterra/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":912943303,"node_id":"MDU6TGFiZWw5MTI5NDMzMDM=","url":"https://api.github.com/repos/elastic/kibana/labels/:ml","name":":ml","color":"0e8a16","default":false},{"id":912944483,"node_id":"MDU6TGFiZWw5MTI5NDQ0ODM=","url":"https://api.github.com/repos/elastic/kibana/labels/:ml-results","name":":ml-results","color":"0e8a16","default":false},{"id":26198236,"node_id":"MDU6TGFiZWwyNjE5ODIzNg==","url":"https://api.github.com/repos/elastic/kibana/labels/release_note:enhancement","name":"release_note:enhancement","color":"4a4ea8","default":false},{"id":1212928780,"node_id":"MDU6TGFiZWwxMjEyOTI4Nzgw","url":"https://api.github.com/repos/elastic/kibana/labels/v7.2.0","name":"v7.2.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/35638/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/35638/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/35638/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/95afddaf31bc5c97caff1d6347711aa8db1a5c05","head":{"label":"alvarezmelissa87:ml-job-selector","ref":"ml-job-selector","sha":"95afddaf31bc5c97caff1d6347711aa8db1a5c05","user":{"login":"alvarezmelissa87","id":6446462,"node_id":"MDQ6VXNlcjY0NDY0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/6446462?v=4","gravatar_id":"","url":"https://api.github.com/users/alvarezmelissa87","html_url":"https://github.com/alvarezmelissa87","followers_url":"https://api.github.com/users/alvarezmelissa87/followers","following_url":"https://api.github.com/users/alvarezmelissa87/following{/other_user}","gists_url":"https://api.github.com/users/alvarezmelissa87/gists{/gist_id}","starred_url":"https://api.github.com/users/alvarezmelissa87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvarezmelissa87/subscriptions","organizations_url":"https://api.github.com/users/alvarezmelissa87/orgs","repos_url":"https://api.github.com/users/alvarezmelissa87/repos","events_url":"https://api.github.com/users/alvarezmelissa87/events{/privacy}","received_events_url":"https://api.github.com/users/alvarezmelissa87/received_events","type":"User","site_admin":false},"repo":{"id":149459005,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk0NTkwMDU=","name":"kibana","full_name":"alvarezmelissa87/kibana","private":false,"owner":{"login":"alvarezmelissa87","id":6446462,"node_id":"MDQ6VXNlcjY0NDY0NjI=","avatar_url":"https://avatars3.githubusercontent.com/u/6446462?v=4","gravatar_id":"","url":"https://api.github.com/users/alvarezmelissa87","html_url":"https://github.com/alvarezmelissa87","followers_url":"https://api.github.com/users/alvarezmelissa87/followers","following_url":"https://api.github.com/users/alvarezmelissa87/following{/other_user}","gists_url":"https://api.github.com/users/alvarezmelissa87/gists{/gist_id}","starred_url":"https://api.github.com/users/alvarezmelissa87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvarezmelissa87/subscriptions","organizations_url":"https://api.github.com/users/alvarezmelissa87/orgs","repos_url":"https://api.github.com/users/alvarezmelissa87/repos","events_url":"https://api.github.com/users/alvarezmelissa87/events{/privacy}","received_events_url":"https://api.github.com/users/alvarezmelissa87/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alvarezmelissa87/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/alvarezmelissa87/kibana","forks_url":"https://api.github.com/repos/alvarezmelissa87/kibana/forks","keys_url":"https://api.github.com/repos/alvarezmelissa87/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alvarezmelissa87/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alvarezmelissa87/kibana/teams","hooks_url":"https://api.github.com/repos/alvarezmelissa87/kibana/hooks","issue_events_url":"https://api.github.com/repos/alvarezmelissa87/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/alvarezmelissa87/kibana/events","assignees_url":"https://api.github.com/repos/alvarezmelissa87/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/alvarezmelissa87/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/alvarezmelissa87/kibana/tags","blobs_url":"https://api.github.com/repos/alvarezmelissa87/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alvarezmelissa87/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alvarezmelissa87/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/alvarezmelissa87/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alvarezmelissa87/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/alvarezmelissa87/kibana/languages","stargazers_url":"https://api.github.com/repos/alvarezmelissa87/kibana/stargazers","contributors_url":"https://api.github.com/repos/alvarezmelissa87/kibana/contributors","subscribers_url":"https://api.github.com/repos/alvarezmelissa87/kibana/subscribers","subscription_url":"https://api.github.com/repos/alvarezmelissa87/kibana/subscription","commits_url":"https://api.github.com/repos/alvarezmelissa87/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/alvarezmelissa87/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/alvarezmelissa87/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/alvarezmelissa87/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/alvarezmelissa87/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/alvarezmelissa87/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alvarezmelissa87/kibana/merges","archive_url":"https://api.github.com/repos/alvarezmelissa87/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alvarezmelissa87/kibana/downloads","issues_url":"https://api.github.com/repos/alvarezmelissa87/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/alvarezmelissa87/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/alvarezmelissa87/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/alvarezmelissa87/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alvarezmelissa87/kibana/labels{/name}","releases_url":"https://api.github.com/repos/alvarezmelissa87/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/alvarezmelissa87/kibana/deployments","created_at":"2018-09-19T13:56:45Z","updated_at":"2018-10-18T09:16:16Z","pushed_at":"2019-05-02T20:21:38Z","git_url":"git://github.com/alvarezmelissa87/kibana.git","ssh_url":"[email protected]:alvarezmelissa87/kibana.git","clone_url":"https://github.com/alvarezmelissa87/kibana.git","svn_url":"https://github.com/alvarezmelissa87/kibana","homepage":"https://www.elastic.co/products/kibana","size":709097,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"d50c9702907f755652af2ebff3b3e9730ae49a35","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2019-05-02T19:51:04Z","pushed_at":"2019-05-02T20:21:42Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"[email protected]:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":784462,"stargazers_count":11668,"watchers_count":11668,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4567,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4420,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4567,"open_issues":4420,"watchers":11668,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/35638"},"html":{"href":"https://github.com/elastic/kibana/pull/35638"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/35638"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/35638/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/35638/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/35638/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/95afddaf31bc5c97caff1d6347711aa8db1a5c05"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 7833168,
"name": "elastic/kibana",
"url": "https://api.github.com/repos/elastic/kibana"
}
|
{
"id": 6446462,
"login": "alvarezmelissa87",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6446462?",
"url": "https://api.github.com/users/alvarezmelissa87"
}
|
{
"id": 6764390,
"login": "elastic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6764390?",
"url": "https://api.github.com/orgs/elastic"
}
| 2019-05-02T20:23:38 |
9553855582
|
{"actor":{"display_login":"alvarezmelissa87"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/353859524","pull_request_review_id":326996518,"id":353859524,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1Mzg1OTUyNA==","diff_hunk":"@@ -344,12 +350,12 @@ type RequestHandlerEnhanced<\n * @public\n */\n export type RequestHandler<\n- P extends ObjectType,\n- Q extends ObjectType,\n- B extends ObjectType | Type<Buffer> | Type<Stream>,\n+ P extends ObjectType | ValidateFunction<unknown>,","path":"src/core/server/http/router/router.ts","position":null,"original_position":116,"commit_id":"bf71f8a214b18c629dd182edf3eb87cbeef51ee6","original_commit_id":"1b3088abb77b25e8a9b088a544c48dc2978fd843","user":{"login":"restrry","id":3198181,"node_id":"MDQ6VXNlcjMxOTgxODE=","avatar_url":"https://avatars3.githubusercontent.com/u/3198181?v=4","gravatar_id":"","url":"https://api.github.com/users/restrry","html_url":"https://github.com/restrry","followers_url":"https://api.github.com/users/restrry/followers","following_url":"https://api.github.com/users/restrry/following{/other_user}","gists_url":"https://api.github.com/users/restrry/gists{/gist_id}","starred_url":"https://api.github.com/users/restrry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restrry/subscriptions","organizations_url":"https://api.github.com/users/restrry/orgs","repos_url":"https://api.github.com/users/restrry/repos","events_url":"https://api.github.com/users/restrry/events{/privacy}","received_events_url":"https://api.github.com/users/restrry/received_events","type":"User","site_admin":false},"body":"ah... I overlooked it and wrote my test instead. stupid me 🤣 ","created_at":"2019-12-04T16:48:19Z","updated_at":"2019-12-04T16:48:19Z","html_url":"https://github.com/elastic/kibana/pull/51919#discussion_r353859524","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/51919","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/353859524"},"html":{"href":"https://github.com/elastic/kibana/pull/51919#discussion_r353859524"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/51919"}},"in_reply_to_id":352549693},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/51919","id":347133907,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ3MTMzOTA3","html_url":"https://github.com/elastic/kibana/pull/51919","diff_url":"https://github.com/elastic/kibana/pull/51919.diff","patch_url":"https://github.com/elastic/kibana/pull/51919.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/51919","number":51919,"state":"open","locked":false,"title":"[NP] Allow custom validations in HTTP Routes apart from @kbn/config-schema","user":{"login":"afharo","id":5469006,"node_id":"MDQ6VXNlcjU0NjkwMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/5469006?v=4","gravatar_id":"","url":"https://api.github.com/users/afharo","html_url":"https://github.com/afharo","followers_url":"https://api.github.com/users/afharo/followers","following_url":"https://api.github.com/users/afharo/following{/other_user}","gists_url":"https://api.github.com/users/afharo/gists{/gist_id}","starred_url":"https://api.github.com/users/afharo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afharo/subscriptions","organizations_url":"https://api.github.com/users/afharo/orgs","repos_url":"https://api.github.com/users/afharo/repos","events_url":"https://api.github.com/users/afharo/events{/privacy}","received_events_url":"https://api.github.com/users/afharo/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nAllow the use of custom validation functions when defining the HTTP routes for those use cases where the use of `@kbn/config-schema` is not available (like in the browser).\r\nFixes #50179\r\n\r\n⚠️Still open to discussion if this is a valid approach we want to follow. That's why the `Documentation` box has not been checked yet.\r\n\r\n### Checklist\r\n\r\nUse ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.\r\n\r\n- ~~[ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~\r\n- ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~\r\n- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials\r\n- [X] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios\r\n- ~~[ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~\r\n\r\n### For maintainers\r\n\r\n- [X] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)\r\n- [X] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)\r\n\r\n","created_at":"2019-11-29T18:19:33Z","updated_at":"2019-12-04T16:48:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb1441ebe57cbf7b1c22a51795e2d7b5902652aa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":635458035,"node_id":"MDU6TGFiZWw2MzU0NTgwMzU=","url":"https://api.github.com/repos/elastic/kibana/labels/Feature:New%20Platform","name":"Feature:New Platform","color":"0e8a16","default":false,"description":""},{"id":470241278,"node_id":"MDU6TGFiZWw0NzAyNDEyNzg=","url":"https://api.github.com/repos/elastic/kibana/labels/Team:Platform","name":"Team:Platform","color":"fef2c0","default":false,"description":"Team label for Platform Team"},{"id":26198236,"node_id":"MDU6TGFiZWwyNjE5ODIzNg==","url":"https://api.github.com/repos/elastic/kibana/labels/release_note:enhancement","name":"release_note:enhancement","color":"4a4ea8","default":false,"description":null},{"id":1500389213,"node_id":"MDU6TGFiZWwxNTAwMzg5MjEz","url":"https://api.github.com/repos/elastic/kibana/labels/v7.7.0","name":"v7.7.0","color":"ffffff","default":false,"description":""},{"id":1124458249,"node_id":"MDU6TGFiZWwxMTI0NDU4MjQ5","url":"https://api.github.com/repos/elastic/kibana/labels/v8.0.0","name":"v8.0.0","color":"ffffff","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/51919/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/51919/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/51919/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/bf71f8a214b18c629dd182edf3eb87cbeef51ee6","head":{"label":"afharo:np-decouple-configSchema","ref":"np-decouple-configSchema","sha":"bf71f8a214b18c629dd182edf3eb87cbeef51ee6","user":{"login":"afharo","id":5469006,"node_id":"MDQ6VXNlcjU0NjkwMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/5469006?v=4","gravatar_id":"","url":"https://api.github.com/users/afharo","html_url":"https://github.com/afharo","followers_url":"https://api.github.com/users/afharo/followers","following_url":"https://api.github.com/users/afharo/following{/other_user}","gists_url":"https://api.github.com/users/afharo/gists{/gist_id}","starred_url":"https://api.github.com/users/afharo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afharo/subscriptions","organizations_url":"https://api.github.com/users/afharo/orgs","repos_url":"https://api.github.com/users/afharo/repos","events_url":"https://api.github.com/users/afharo/events{/privacy}","received_events_url":"https://api.github.com/users/afharo/received_events","type":"User","site_admin":false},"repo":{"id":220142715,"node_id":"MDEwOlJlcG9zaXRvcnkyMjAxNDI3MTU=","name":"kibana","full_name":"afharo/kibana","private":false,"owner":{"login":"afharo","id":5469006,"node_id":"MDQ6VXNlcjU0NjkwMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/5469006?v=4","gravatar_id":"","url":"https://api.github.com/users/afharo","html_url":"https://github.com/afharo","followers_url":"https://api.github.com/users/afharo/followers","following_url":"https://api.github.com/users/afharo/following{/other_user}","gists_url":"https://api.github.com/users/afharo/gists{/gist_id}","starred_url":"https://api.github.com/users/afharo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afharo/subscriptions","organizations_url":"https://api.github.com/users/afharo/orgs","repos_url":"https://api.github.com/users/afharo/repos","events_url":"https://api.github.com/users/afharo/events{/privacy}","received_events_url":"https://api.github.com/users/afharo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/afharo/kibana","description":"Your window into the Elastic Stack","fork":true,"url":"https://api.github.com/repos/afharo/kibana","forks_url":"https://api.github.com/repos/afharo/kibana/forks","keys_url":"https://api.github.com/repos/afharo/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/afharo/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/afharo/kibana/teams","hooks_url":"https://api.github.com/repos/afharo/kibana/hooks","issue_events_url":"https://api.github.com/repos/afharo/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/afharo/kibana/events","assignees_url":"https://api.github.com/repos/afharo/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/afharo/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/afharo/kibana/tags","blobs_url":"https://api.github.com/repos/afharo/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/afharo/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/afharo/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/afharo/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/afharo/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/afharo/kibana/languages","stargazers_url":"https://api.github.com/repos/afharo/kibana/stargazers","contributors_url":"https://api.github.com/repos/afharo/kibana/contributors","subscribers_url":"https://api.github.com/repos/afharo/kibana/subscribers","subscription_url":"https://api.github.com/repos/afharo/kibana/subscription","commits_url":"https://api.github.com/repos/afharo/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/afharo/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/afharo/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/afharo/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/afharo/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/afharo/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/afharo/kibana/merges","archive_url":"https://api.github.com/repos/afharo/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/afharo/kibana/downloads","issues_url":"https://api.github.com/repos/afharo/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/afharo/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/afharo/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/afharo/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/afharo/kibana/labels{/name}","releases_url":"https://api.github.com/repos/afharo/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/afharo/kibana/deployments","created_at":"2019-11-07T03:22:03Z","updated_at":"2019-12-03T10:50:12Z","pushed_at":"2019-12-04T16:39:48Z","git_url":"git://github.com/afharo/kibana.git","ssh_url":"[email protected]:afharo/kibana.git","clone_url":"https://github.com/afharo/kibana.git","svn_url":"https://github.com/afharo/kibana","homepage":"https://www.elastic.co/products/kibana","size":1401890,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"1240d02c9d72bbedbd8b24aefecf5a54772d109a","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":"Your window into the Elastic Stack","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2019-12-04T16:41:41Z","pushed_at":"2019-12-04T16:45:31Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"[email protected]:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":1446461,"stargazers_count":13374,"watchers_count":13374,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5277,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5758,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5277,"open_issues":5758,"watchers":13374,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/51919"},"html":{"href":"https://github.com/elastic/kibana/pull/51919"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/51919"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/51919/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/51919/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/51919/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/bf71f8a214b18c629dd182edf3eb87cbeef51ee6"}},"author_association":"MEMBER"}}
|
{
"id": 7833168,
"name": "elastic/kibana",
"url": "https://api.github.com/repos/elastic/kibana"
}
|
{
"id": 3198181,
"login": "restrry",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3198181?",
"url": "https://api.github.com/users/restrry"
}
|
{
"id": 6764390,
"login": "elastic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6764390?",
"url": "https://api.github.com/orgs/elastic"
}
| 2019-12-04T16:48:19 |
11011719719
|
{"actor":{"display_login":"restrry"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/299934377","pull_request_review_id":257458157,"id":299934377,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5OTkzNDM3Nw==","diff_hunk":"@@ -0,0 +1,85 @@\n+/*\n+ * Licensed to Elasticsearch B.V. under one or more contributor\n+ * license agreements. See the NOTICE file distributed with\n+ * this work for additional information regarding copyright\n+ * ownership. Elasticsearch B.V. licenses this file to you under\n+ * the Apache License, Version 2.0 (the \"License\"); you may\n+ * not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied. See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+\n+import Boom from 'boom';\n+import { get } from 'lodash';\n+\n+const code = Symbol('ElasticsearchError');\n+\n+const CODE_NOT_AUTHORIZED = 'Elasticsearch/notAuthorized';\n+\n+export interface ElasticsearchError extends Boom {\n+ [code]?: string;\n+}\n+\n+function isElasticsearchError(error: any): error is ElasticsearchError {\n+ return Boolean(error && error[code]);\n+}\n+\n+function decorate(\n+ error: Error,\n+ errorCode: string,\n+ statusCode: number,\n+ message?: string\n+): ElasticsearchError {\n+ if (isElasticsearchError(error)) {\n+ return error;\n+ }\n+\n+ const boom = Boom.boomify(error, {\n+ statusCode,\n+ message,\n+ override: false,\n+ }) as ElasticsearchError;\n+\n+ boom[code] = errorCode;\n+\n+ return boom;\n+}\n+\n+/**\n+ * Helpers provided to simplify future migration away from Boom as internal Error.\n+ * @public\n+ *\n+ * @example","path":"src/core/server/elasticsearch/errors.ts","position":60,"original_position":60,"commit_id":"0f25401fe4caaf97ff1b701d245455a0ef71ec3a","original_commit_id":"0f25401fe4caaf97ff1b701d245455a0ef71ec3a","user":{"login":"skaapgif","id":1281646,"node_id":"MDQ6VXNlcjEyODE2NDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1281646?v=4","gravatar_id":"","url":"https://api.github.com/users/skaapgif","html_url":"https://github.com/skaapgif","followers_url":"https://api.github.com/users/skaapgif/followers","following_url":"https://api.github.com/users/skaapgif/following{/other_user}","gists_url":"https://api.github.com/users/skaapgif/gists{/gist_id}","starred_url":"https://api.github.com/users/skaapgif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skaapgif/subscriptions","organizations_url":"https://api.github.com/users/skaapgif/orgs","repos_url":"https://api.github.com/users/skaapgif/repos","events_url":"https://api.github.com/users/skaapgif/events{/privacy}","received_events_url":"https://api.github.com/users/skaapgif/received_events","type":"User","site_admin":false},"body":"❤️ ","created_at":"2019-07-03T12:40:57Z","updated_at":"2019-07-03T12:57:38Z","html_url":"https://github.com/elastic/kibana/pull/40242#discussion_r299934377","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/40242","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/299934377"},"html":{"href":"https://github.com/elastic/kibana/pull/40242#discussion_r299934377"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/40242"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/40242","id":294093651,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0MDkzNjUx","html_url":"https://github.com/elastic/kibana/pull/40242","diff_url":"https://github.com/elastic/kibana/pull/40242.diff","patch_url":"https://github.com/elastic/kibana/pull/40242.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/40242","number":40242,"state":"open","locked":false,"title":"Expose elasticsearch error wrapper","user":{"login":"restrry","id":3198181,"node_id":"MDQ6VXNlcjMxOTgxODE=","avatar_url":"https://avatars3.githubusercontent.com/u/3198181?v=4","gravatar_id":"","url":"https://api.github.com/users/restrry","html_url":"https://github.com/restrry","followers_url":"https://api.github.com/users/restrry/followers","following_url":"https://api.github.com/users/restrry/following{/other_user}","gists_url":"https://api.github.com/users/restrry/gists{/gist_id}","starred_url":"https://api.github.com/users/restrry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restrry/subscriptions","organizations_url":"https://api.github.com/users/restrry/orgs","repos_url":"https://api.github.com/users/restrry/repos","events_url":"https://api.github.com/users/restrry/events{/privacy}","received_events_url":"https://api.github.com/users/restrry/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nClose: https://github.com/elastic/kibana/issues/40240\r\nCreate a wrapper similar to [SavedObjectsErrorHelpers](https://github.com/elastic/kibana/blob/master/src/core/server/saved_objects/service/lib/errors.ts#L81) to simplify format unification. \r\n\r\n### Checklist\r\n\r\nUse ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.\r\n\r\n- ~~[ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~\r\n- ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~\r\n- ~~[ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~\r\n- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios\r\n- ~~[ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)\r\n- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)\r\n\r\n","created_at":"2019-07-03T10:00:49Z","updated_at":"2019-07-03T12:57:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"faa88798ee8910b5ae1d96e281486cc3284f6569","assignee":null,"assignees":[],"requested_reviewers":[{"login":"azasypkin","id":1713708,"node_id":"MDQ6VXNlcjE3MTM3MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1713708?v=4","gravatar_id":"","url":"https://api.github.com/users/azasypkin","html_url":"https://github.com/azasypkin","followers_url":"https://api.github.com/users/azasypkin/followers","following_url":"https://api.github.com/users/azasypkin/following{/other_user}","gists_url":"https://api.github.com/users/azasypkin/gists{/gist_id}","starred_url":"https://api.github.com/users/azasypkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azasypkin/subscriptions","organizations_url":"https://api.github.com/users/azasypkin/orgs","repos_url":"https://api.github.com/users/azasypkin/repos","events_url":"https://api.github.com/users/azasypkin/events{/privacy}","received_events_url":"https://api.github.com/users/azasypkin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":635458035,"node_id":"MDU6TGFiZWw2MzU0NTgwMzU=","url":"https://api.github.com/repos/elastic/kibana/labels/Feature:New%20Platform","name":"Feature:New Platform","color":"0e8a16","default":false},{"id":470241278,"node_id":"MDU6TGFiZWw0NzAyNDEyNzg=","url":"https://api.github.com/repos/elastic/kibana/labels/Team:Platform","name":"Team:Platform","color":"fef2c0","default":false},{"id":1017555269,"node_id":"MDU6TGFiZWwxMDE3NTU1MjY5","url":"https://api.github.com/repos/elastic/kibana/labels/release_note:dev_docs","name":"release_note:dev_docs","color":"a6ce42","default":false},{"id":135307740,"node_id":"MDU6TGFiZWwxMzUzMDc3NDA=","url":"https://api.github.com/repos/elastic/kibana/labels/review","name":"review","color":"0052cc","default":false},{"id":1354572523,"node_id":"MDU6TGFiZWwxMzU0NTcyNTIz","url":"https://api.github.com/repos/elastic/kibana/labels/v7.3.0","name":"v7.3.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/40242/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/40242/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/40242/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/0f25401fe4caaf97ff1b701d245455a0ef71ec3a","head":{"label":"restrry:expose-elasticsearch-error","ref":"expose-elasticsearch-error","sha":"0f25401fe4caaf97ff1b701d245455a0ef71ec3a","user":{"login":"restrry","id":3198181,"node_id":"MDQ6VXNlcjMxOTgxODE=","avatar_url":"https://avatars3.githubusercontent.com/u/3198181?v=4","gravatar_id":"","url":"https://api.github.com/users/restrry","html_url":"https://github.com/restrry","followers_url":"https://api.github.com/users/restrry/followers","following_url":"https://api.github.com/users/restrry/following{/other_user}","gists_url":"https://api.github.com/users/restrry/gists{/gist_id}","starred_url":"https://api.github.com/users/restrry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restrry/subscriptions","organizations_url":"https://api.github.com/users/restrry/orgs","repos_url":"https://api.github.com/users/restrry/repos","events_url":"https://api.github.com/users/restrry/events{/privacy}","received_events_url":"https://api.github.com/users/restrry/received_events","type":"User","site_admin":false},"repo":{"id":161818268,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE4MTgyNjg=","name":"kibana","full_name":"restrry/kibana","private":false,"owner":{"login":"restrry","id":3198181,"node_id":"MDQ6VXNlcjMxOTgxODE=","avatar_url":"https://avatars3.githubusercontent.com/u/3198181?v=4","gravatar_id":"","url":"https://api.github.com/users/restrry","html_url":"https://github.com/restrry","followers_url":"https://api.github.com/users/restrry/followers","following_url":"https://api.github.com/users/restrry/following{/other_user}","gists_url":"https://api.github.com/users/restrry/gists{/gist_id}","starred_url":"https://api.github.com/users/restrry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/restrry/subscriptions","organizations_url":"https://api.github.com/users/restrry/orgs","repos_url":"https://api.github.com/users/restrry/repos","events_url":"https://api.github.com/users/restrry/events{/privacy}","received_events_url":"https://api.github.com/users/restrry/received_events","type":"User","site_admin":false},"html_url":"https://github.com/restrry/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/restrry/kibana","forks_url":"https://api.github.com/repos/restrry/kibana/forks","keys_url":"https://api.github.com/repos/restrry/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/restrry/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/restrry/kibana/teams","hooks_url":"https://api.github.com/repos/restrry/kibana/hooks","issue_events_url":"https://api.github.com/repos/restrry/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/restrry/kibana/events","assignees_url":"https://api.github.com/repos/restrry/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/restrry/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/restrry/kibana/tags","blobs_url":"https://api.github.com/repos/restrry/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/restrry/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/restrry/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/restrry/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/restrry/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/restrry/kibana/languages","stargazers_url":"https://api.github.com/repos/restrry/kibana/stargazers","contributors_url":"https://api.github.com/repos/restrry/kibana/contributors","subscribers_url":"https://api.github.com/repos/restrry/kibana/subscribers","subscription_url":"https://api.github.com/repos/restrry/kibana/subscription","commits_url":"https://api.github.com/repos/restrry/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/restrry/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/restrry/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/restrry/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/restrry/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/restrry/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/restrry/kibana/merges","archive_url":"https://api.github.com/repos/restrry/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/restrry/kibana/downloads","issues_url":"https://api.github.com/repos/restrry/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/restrry/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/restrry/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/restrry/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/restrry/kibana/labels{/name}","releases_url":"https://api.github.com/repos/restrry/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/restrry/kibana/deployments","created_at":"2018-12-14T17:20:27Z","updated_at":"2019-07-01T09:36:53Z","pushed_at":"2019-07-03T10:04:01Z","git_url":"git://github.com/restrry/kibana.git","ssh_url":"[email protected]:restrry/kibana.git","clone_url":"https://github.com/restrry/kibana.git","svn_url":"https://github.com/restrry/kibana","homepage":"https://www.elastic.co/products/kibana","size":815555,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"7c794279911e3114a2c526d4e5e1d6167046b304","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":"Your window into the Elastic Stack","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2019-07-03T12:57:26Z","pushed_at":"2019-07-03T12:56:22Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"[email protected]:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":869392,"stargazers_count":12359,"watchers_count":12359,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4782,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4721,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4782,"open_issues":4721,"watchers":12359,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/40242"},"html":{"href":"https://github.com/elastic/kibana/pull/40242"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/40242"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/40242/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/40242/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/40242/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/0f25401fe4caaf97ff1b701d245455a0ef71ec3a"}},"author_association":"MEMBER"}}
|
{
"id": 7833168,
"name": "elastic/kibana",
"url": "https://api.github.com/repos/elastic/kibana"
}
|
{
"id": 1281646,
"login": "skaapgif",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1281646?",
"url": "https://api.github.com/users/skaapgif"
}
|
{
"id": 6764390,
"login": "elastic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6764390?",
"url": "https://api.github.com/orgs/elastic"
}
| 2019-07-03T12:40:57 |
9941988771
|
{"actor":{"display_login":"skaapgif"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/299197277","pull_request_review_id":256536441,"id":299197277,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5OTE5NzI3Nw==","diff_hunk":"@@ -38,7 +38,7 @@ export const removeColor = createThunk('removeColor', ({ dispatch, getState }, c\n export const setWorkpad = createThunk(\n 'setWorkpad',\n ({ dispatch, type }, workpad, { loadPages = true } = {}) => {\n- dispatch(setRefreshInterval(0)); // disable refresh interval\n+ // dispatch(setRefreshInterval(0)); // disable refresh interval","path":"x-pack/legacy/plugins/canvas/public/state/actions/workpad.js","position":5,"original_position":5,"commit_id":"428c6c0ddd00ca1042266fdc56f386fe14e4e107","original_commit_id":"428c6c0ddd00ca1042266fdc56f386fe14e4e107","user":{"login":"crob611","id":515272,"node_id":"MDQ6VXNlcjUxNTI3Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/515272?v=4","gravatar_id":"","url":"https://api.github.com/users/crob611","html_url":"https://github.com/crob611","followers_url":"https://api.github.com/users/crob611/followers","following_url":"https://api.github.com/users/crob611/following{/other_user}","gists_url":"https://api.github.com/users/crob611/gists{/gist_id}","starred_url":"https://api.github.com/users/crob611/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crob611/subscriptions","organizations_url":"https://api.github.com/users/crob611/orgs","repos_url":"https://api.github.com/users/crob611/repos","events_url":"https://api.github.com/users/crob611/events{/privacy}","received_events_url":"https://api.github.com/users/crob611/received_events","type":"User","site_admin":false},"body":"Does this line need to be uncommented or just remove it?","created_at":"2019-07-01T20:07:17Z","updated_at":"2019-07-01T20:43:20Z","html_url":"https://github.com/elastic/kibana/pull/40061#discussion_r299197277","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/40061","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/299197277"},"html":{"href":"https://github.com/elastic/kibana/pull/40061#discussion_r299197277"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/40061"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/40061","id":293439977,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkzNDM5OTc3","html_url":"https://github.com/elastic/kibana/pull/40061","diff_url":"https://github.com/elastic/kibana/pull/40061.diff","patch_url":"https://github.com/elastic/kibana/pull/40061.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/40061","number":40061,"state":"open","locked":false,"title":"Enable Canvas URL Parameters","user":{"login":"clintandrewhall","id":297604,"node_id":"MDQ6VXNlcjI5NzYwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/297604?v=4","gravatar_id":"","url":"https://api.github.com/users/clintandrewhall","html_url":"https://github.com/clintandrewhall","followers_url":"https://api.github.com/users/clintandrewhall/followers","following_url":"https://api.github.com/users/clintandrewhall/following{/other_user}","gists_url":"https://api.github.com/users/clintandrewhall/gists{/gist_id}","starred_url":"https://api.github.com/users/clintandrewhall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clintandrewhall/subscriptions","organizations_url":"https://api.github.com/users/clintandrewhall/orgs","repos_url":"https://api.github.com/users/clintandrewhall/repos","events_url":"https://api.github.com/users/clintandrewhall/events{/privacy}","received_events_url":"https://api.github.com/users/clintandrewhall/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nReplaces #38938\r\nCloses #23061\r\nCloses #23144\r\nCloses #29526\r\n\r\nThis PR enables user-readable and editable URL parameters for Canvas. These URL parameters are now considered reserved for Canvas. It also opts for seconds, rather than milliseconds, for their values.\r\n\r\n- `__fullscreen=[boolean]` - enables fullscreen. If omitted, Canvas will not be fullscreen.\r\n - Pressing `esc` exits fullscreen, which is reflected in the URL.\r\n\r\n\r\n\r\n- `__autoplay=[number]` - sets the interval, in seconds, in which slides are changed while in fullscreen. If omitted, slides will not change.\r\n - Pressing `p` will activate the shortcut for autoplay, which is reflected in the URL.\r\n\r\n\r\n\r\n- `__refresh=[number]` - sets the interval, in seconds, in which content is refreshed. If omitted, content will not refresh.\r\n\r\n\r\n\r\nThis PR also updates the router to handle changes in the search parameters-- this means a user can change one of these parameters and the change will be reflected in the interface immediately, without the need to refresh.","created_at":"2019-07-01T17:56:08Z","updated_at":"2019-07-01T20:43:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c5366443d267629ad8d46b590fe0dd279adb07a9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1376005979,"node_id":"MDU6TGFiZWwxMzc2MDA1OTc5","url":"https://api.github.com/repos/elastic/kibana/labels/impact:critical","name":"impact:critical","color":"e00606","default":false},{"id":1019679346,"node_id":"MDU6TGFiZWwxMDE5Njc5MzQ2","url":"https://api.github.com/repos/elastic/kibana/labels/loe:days","name":"loe:days","color":"E6C220","default":false},{"id":26198236,"node_id":"MDU6TGFiZWwyNjE5ODIzNg==","url":"https://api.github.com/repos/elastic/kibana/labels/release_note:enhancement","name":"release_note:enhancement","color":"4a4ea8","default":false},{"id":135307740,"node_id":"MDU6TGFiZWwxMzUzMDc3NDA=","url":"https://api.github.com/repos/elastic/kibana/labels/review","name":"review","color":"0052cc","default":false},{"id":1354572523,"node_id":"MDU6TGFiZWwxMzU0NTcyNTIz","url":"https://api.github.com/repos/elastic/kibana/labels/v7.3.0","name":"v7.3.0","color":"ffffff","default":false},{"id":1124458249,"node_id":"MDU6TGFiZWwxMTI0NDU4MjQ5","url":"https://api.github.com/repos/elastic/kibana/labels/v8.0.0","name":"v8.0.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/40061/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/40061/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/40061/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/428c6c0ddd00ca1042266fdc56f386fe14e4e107","head":{"label":"clintandrewhall:kiosk","ref":"kiosk","sha":"428c6c0ddd00ca1042266fdc56f386fe14e4e107","user":{"login":"clintandrewhall","id":297604,"node_id":"MDQ6VXNlcjI5NzYwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/297604?v=4","gravatar_id":"","url":"https://api.github.com/users/clintandrewhall","html_url":"https://github.com/clintandrewhall","followers_url":"https://api.github.com/users/clintandrewhall/followers","following_url":"https://api.github.com/users/clintandrewhall/following{/other_user}","gists_url":"https://api.github.com/users/clintandrewhall/gists{/gist_id}","starred_url":"https://api.github.com/users/clintandrewhall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clintandrewhall/subscriptions","organizations_url":"https://api.github.com/users/clintandrewhall/orgs","repos_url":"https://api.github.com/users/clintandrewhall/repos","events_url":"https://api.github.com/users/clintandrewhall/events{/privacy}","received_events_url":"https://api.github.com/users/clintandrewhall/received_events","type":"User","site_admin":false},"repo":{"id":155889311,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU4ODkzMTE=","name":"kibana","full_name":"clintandrewhall/kibana","private":false,"owner":{"login":"clintandrewhall","id":297604,"node_id":"MDQ6VXNlcjI5NzYwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/297604?v=4","gravatar_id":"","url":"https://api.github.com/users/clintandrewhall","html_url":"https://github.com/clintandrewhall","followers_url":"https://api.github.com/users/clintandrewhall/followers","following_url":"https://api.github.com/users/clintandrewhall/following{/other_user}","gists_url":"https://api.github.com/users/clintandrewhall/gists{/gist_id}","starred_url":"https://api.github.com/users/clintandrewhall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clintandrewhall/subscriptions","organizations_url":"https://api.github.com/users/clintandrewhall/orgs","repos_url":"https://api.github.com/users/clintandrewhall/repos","events_url":"https://api.github.com/users/clintandrewhall/events{/privacy}","received_events_url":"https://api.github.com/users/clintandrewhall/received_events","type":"User","site_admin":false},"html_url":"https://github.com/clintandrewhall/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/clintandrewhall/kibana","forks_url":"https://api.github.com/repos/clintandrewhall/kibana/forks","keys_url":"https://api.github.com/repos/clintandrewhall/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clintandrewhall/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clintandrewhall/kibana/teams","hooks_url":"https://api.github.com/repos/clintandrewhall/kibana/hooks","issue_events_url":"https://api.github.com/repos/clintandrewhall/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/clintandrewhall/kibana/events","assignees_url":"https://api.github.com/repos/clintandrewhall/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/clintandrewhall/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/clintandrewhall/kibana/tags","blobs_url":"https://api.github.com/repos/clintandrewhall/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clintandrewhall/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clintandrewhall/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/clintandrewhall/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clintandrewhall/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/clintandrewhall/kibana/languages","stargazers_url":"https://api.github.com/repos/clintandrewhall/kibana/stargazers","contributors_url":"https://api.github.com/repos/clintandrewhall/kibana/contributors","subscribers_url":"https://api.github.com/repos/clintandrewhall/kibana/subscribers","subscription_url":"https://api.github.com/repos/clintandrewhall/kibana/subscription","commits_url":"https://api.github.com/repos/clintandrewhall/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/clintandrewhall/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/clintandrewhall/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/clintandrewhall/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/clintandrewhall/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/clintandrewhall/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clintandrewhall/kibana/merges","archive_url":"https://api.github.com/repos/clintandrewhall/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clintandrewhall/kibana/downloads","issues_url":"https://api.github.com/repos/clintandrewhall/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/clintandrewhall/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/clintandrewhall/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/clintandrewhall/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clintandrewhall/kibana/labels{/name}","releases_url":"https://api.github.com/repos/clintandrewhall/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/clintandrewhall/kibana/deployments","created_at":"2018-11-02T15:58:19Z","updated_at":"2019-06-30T21:04:26Z","pushed_at":"2019-07-01T17:43:27Z","git_url":"git://github.com/clintandrewhall/kibana.git","ssh_url":"[email protected]:clintandrewhall/kibana.git","clone_url":"https://github.com/clintandrewhall/kibana.git","svn_url":"https://github.com/clintandrewhall/kibana","homepage":"https://www.elastic.co/products/kibana","size":880436,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"53273ecff42250d326c826afa8194c2da56dfdca","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":"Your window into the Elastic Stack","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2019-07-01T20:15:13Z","pushed_at":"2019-07-01T20:33:53Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"[email protected]:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":867713,"stargazers_count":12338,"watchers_count":12338,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4774,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":4734,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4774,"open_issues":4734,"watchers":12338,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/40061"},"html":{"href":"https://github.com/elastic/kibana/pull/40061"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/40061"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/40061/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/40061/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/40061/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/428c6c0ddd00ca1042266fdc56f386fe14e4e107"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 7833168,
"name": "elastic/kibana",
"url": "https://api.github.com/repos/elastic/kibana"
}
|
{
"id": 515272,
"login": "crob611",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/515272?",
"url": "https://api.github.com/users/crob611"
}
|
{
"id": 6764390,
"login": "elastic",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6764390?",
"url": "https://api.github.com/orgs/elastic"
}
| 2019-07-01T20:07:17 |
9928856181
|
{"actor":{"display_login":"crob611"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/266065661","pull_request_review_id":215143946,"id":266065661,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NjA2NTY2MQ==","diff_hunk":"@@ -118,6 +118,8 @@ export type IModalStyleProps = Required<Pick<IModalProps, 'theme'>> &\n hasBeenOpened?: boolean;\n /** Positioning of modal on first render */\n modalRectangleTop?: number;\n+ /** Props for layer element */\n+ layerProps?: ILayerProps;","path":"packages/office-ui-fabric-react/src/components/Modal/Modal.types.ts","position":5,"original_position":5,"commit_id":"7e6cd76cfe277599624b0322464e03a9e380aa84","original_commit_id":"7e6cd76cfe277599624b0322464e03a9e380aa84","user":{"login":"natalieethell","id":14134000,"node_id":"MDQ6VXNlcjE0MTM0MDAw","avatar_url":"https://avatars0.githubusercontent.com/u/14134000?v=4","gravatar_id":"","url":"https://api.github.com/users/natalieethell","html_url":"https://github.com/natalieethell","followers_url":"https://api.github.com/users/natalieethell/followers","following_url":"https://api.github.com/users/natalieethell/following{/other_user}","gists_url":"https://api.github.com/users/natalieethell/gists{/gist_id}","starred_url":"https://api.github.com/users/natalieethell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natalieethell/subscriptions","organizations_url":"https://api.github.com/users/natalieethell/orgs","repos_url":"https://api.github.com/users/natalieethell/repos","events_url":"https://api.github.com/users/natalieethell/events{/privacy}","received_events_url":"https://api.github.com/users/natalieethell/received_events","type":"User","site_admin":false},"body":"All of the \"WARNING: Unsupported export\" warnings should go away when we upgrade to api-extractor 7 (which is still in beta, but should be officially released soon). \r\n\r\n`IModalStyleProps`, specifically, looks like this in the new api.ts file generated from api-extractor 7:\r\n\r\n```tsx\r\n// @public (undocumented)\r\ndeclare type IModalStyleProps = Required<Pick<IModalProps, 'theme'>> & Pick<IModalProps, 'className' | 'containerClassName' | 'scrollableContentClassName' | 'topOffsetFixed' | 'isModeless'> & {\r\n isOpen?: boolean;\r\n isVisible?: boolean;\r\n hasBeenOpened?: boolean;\r\n modalRectangleTop?: number;\r\n};\r\n```","created_at":"2019-03-15T16:53:18Z","updated_at":"2019-03-15T16:53:18Z","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/8273#discussion_r266065661","pull_request_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/8273","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments/266065661"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/8273#discussion_r266065661"},"pull_request":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/8273"}},"in_reply_to_id":265849094},"pull_request":{"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/8273","id":260217503,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwMjE3NTAz","html_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/8273","diff_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/8273.diff","patch_url":"https://github.com/OfficeDev/office-ui-fabric-react/pull/8273.patch","issue_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/8273","number":8273,"state":"open","locked":false,"title":"Ensure dialog class is applied only once","user":{"login":"aftab-hassan","id":8922176,"node_id":"MDQ6VXNlcjg5MjIxNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/8922176?v=4","gravatar_id":"","url":"https://api.github.com/users/aftab-hassan","html_url":"https://github.com/aftab-hassan","followers_url":"https://api.github.com/users/aftab-hassan/followers","following_url":"https://api.github.com/users/aftab-hassan/following{/other_user}","gists_url":"https://api.github.com/users/aftab-hassan/gists{/gist_id}","starred_url":"https://api.github.com/users/aftab-hassan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aftab-hassan/subscriptions","organizations_url":"https://api.github.com/users/aftab-hassan/orgs","repos_url":"https://api.github.com/users/aftab-hassan/repos","events_url":"https://api.github.com/users/aftab-hassan/events{/privacy}","received_events_url":"https://api.github.com/users/aftab-hassan/received_events","type":"User","site_admin":false},"body":"#### Pull request checklist\r\n\r\n- [x] Addresses an existing issue: Fixes #8241 \r\n- [ ] Include a change request file using `$ npm run change`\r\n\r\n#### Description of changes\r\nBehavior reported in issue is a side effect of this [PR](https://github.com/OfficeDev/office-ui-fabric-react/pull/8065)\r\nThe modal `className` was getting incorrectly applied to the layer. Now using `layerProps.ClassName` instead of `this.props.className`. Thanks @jspurlin for suggesting the fix. \r\n\r\n#### Focus areas to test\r\nAdding a `className` to a `Dialog` and ensuring that the `className` is applied only once\r\n\r\nBefore fix\r\n<img width=\"442\" alt=\"class-name-before-fix\" src=\"https://user-images.githubusercontent.com/8922176/54174938-1dcec380-4446-11e9-8f8d-36949dee61dc.PNG\">\r\n\r\nAfter fix\r\n<img width=\"444\" alt=\"class-name-after-fix\" src=\"https://user-images.githubusercontent.com/8922176/54174990-49ea4480-4446-11e9-940e-724f051ebdf0.PNG\">\r\n\r\n###### Microsoft Reviewers: [Open in CodeFlow](http://wpcp.azurewebsites.net/CodeFlowProtocolProxy2.php?pullrequest=https://github.com/OfficeDev/office-ui-fabric-react/pull/8273)","created_at":"2019-03-12T04:39:35Z","updated_at":"2019-03-15T16:53:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b22b222e9d64d6669ddc7e31e16f8b1418b07e2","assignee":{"login":"aftab-hassan","id":8922176,"node_id":"MDQ6VXNlcjg5MjIxNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/8922176?v=4","gravatar_id":"","url":"https://api.github.com/users/aftab-hassan","html_url":"https://github.com/aftab-hassan","followers_url":"https://api.github.com/users/aftab-hassan/followers","following_url":"https://api.github.com/users/aftab-hassan/following{/other_user}","gists_url":"https://api.github.com/users/aftab-hassan/gists{/gist_id}","starred_url":"https://api.github.com/users/aftab-hassan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aftab-hassan/subscriptions","organizations_url":"https://api.github.com/users/aftab-hassan/orgs","repos_url":"https://api.github.com/users/aftab-hassan/repos","events_url":"https://api.github.com/users/aftab-hassan/events{/privacy}","received_events_url":"https://api.github.com/users/aftab-hassan/received_events","type":"User","site_admin":false},"assignees":[{"login":"aftab-hassan","id":8922176,"node_id":"MDQ6VXNlcjg5MjIxNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/8922176?v=4","gravatar_id":"","url":"https://api.github.com/users/aftab-hassan","html_url":"https://github.com/aftab-hassan","followers_url":"https://api.github.com/users/aftab-hassan/followers","following_url":"https://api.github.com/users/aftab-hassan/following{/other_user}","gists_url":"https://api.github.com/users/aftab-hassan/gists{/gist_id}","starred_url":"https://api.github.com/users/aftab-hassan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aftab-hassan/subscriptions","organizations_url":"https://api.github.com/users/aftab-hassan/orgs","repos_url":"https://api.github.com/users/aftab-hassan/repos","events_url":"https://api.github.com/users/aftab-hassan/events{/privacy}","received_events_url":"https://api.github.com/users/aftab-hassan/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"kkjeer","id":6687333,"node_id":"MDQ6VXNlcjY2ODczMzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6687333?v=4","gravatar_id":"","url":"https://api.github.com/users/kkjeer","html_url":"https://github.com/kkjeer","followers_url":"https://api.github.com/users/kkjeer/followers","following_url":"https://api.github.com/users/kkjeer/following{/other_user}","gists_url":"https://api.github.com/users/kkjeer/gists{/gist_id}","starred_url":"https://api.github.com/users/kkjeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkjeer/subscriptions","organizations_url":"https://api.github.com/users/kkjeer/orgs","repos_url":"https://api.github.com/users/kkjeer/repos","events_url":"https://api.github.com/users/kkjeer/events{/privacy}","received_events_url":"https://api.github.com/users/kkjeer/received_events","type":"User","site_admin":false},{"login":"jspurlin","id":7033561,"node_id":"MDQ6VXNlcjcwMzM1NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/7033561?v=4","gravatar_id":"","url":"https://api.github.com/users/jspurlin","html_url":"https://github.com/jspurlin","followers_url":"https://api.github.com/users/jspurlin/followers","following_url":"https://api.github.com/users/jspurlin/following{/other_user}","gists_url":"https://api.github.com/users/jspurlin/gists{/gist_id}","starred_url":"https://api.github.com/users/jspurlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspurlin/subscriptions","organizations_url":"https://api.github.com/users/jspurlin/orgs","repos_url":"https://api.github.com/users/jspurlin/repos","events_url":"https://api.github.com/users/jspurlin/events{/privacy}","received_events_url":"https://api.github.com/users/jspurlin/received_events","type":"User","site_admin":false},{"login":"JasonGore","id":26070760,"node_id":"MDQ6VXNlcjI2MDcwNzYw","avatar_url":"https://avatars2.githubusercontent.com/u/26070760?v=4","gravatar_id":"","url":"https://api.github.com/users/JasonGore","html_url":"https://github.com/JasonGore","followers_url":"https://api.github.com/users/JasonGore/followers","following_url":"https://api.github.com/users/JasonGore/following{/other_user}","gists_url":"https://api.github.com/users/JasonGore/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonGore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonGore/subscriptions","organizations_url":"https://api.github.com/users/JasonGore/orgs","repos_url":"https://api.github.com/users/JasonGore/repos","events_url":"https://api.github.com/users/JasonGore/events{/privacy}","received_events_url":"https://api.github.com/users/JasonGore/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":981888131,"node_id":"MDU6TGFiZWw5ODE4ODgxMzE=","url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels/Component:%20Modal","name":"Component: Modal","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/8273/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/8273/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/8273/comments","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/7e6cd76cfe277599624b0322464e03a9e380aa84","head":{"label":"OfficeDev:fix-dialog-class-twice","ref":"fix-dialog-class-twice","sha":"7e6cd76cfe277599624b0322464e03a9e380aa84","user":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":60537144,"node_id":"MDEwOlJlcG9zaXRvcnk2MDUzNzE0NA==","name":"office-ui-fabric-react","full_name":"OfficeDev/office-ui-fabric-react","private":false,"owner":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OfficeDev/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react","forks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/deployments","created_at":"2016-06-06T15:03:44Z","updated_at":"2019-03-15T16:49:58Z","pushed_at":"2019-03-15T12:36:10Z","git_url":"git://github.com/OfficeDev/office-ui-fabric-react.git","ssh_url":"[email protected]:OfficeDev/office-ui-fabric-react.git","clone_url":"https://github.com/OfficeDev/office-ui-fabric-react.git","svn_url":"https://github.com/OfficeDev/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric/#/components","size":57107,"stargazers_count":4469,"watchers_count":4469,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":967,"mirror_url":null,"archived":false,"open_issues_count":406,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":967,"open_issues":406,"watchers":4469,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"882f4b91eddf44fca406d1d66b1081d7e72fa439","user":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":60537144,"node_id":"MDEwOlJlcG9zaXRvcnk2MDUzNzE0NA==","name":"office-ui-fabric-react","full_name":"OfficeDev/office-ui-fabric-react","private":false,"owner":{"login":"OfficeDev","id":6789362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3ODkzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6789362?v=4","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OfficeDev/office-ui-fabric-react","description":"React components for building experiences for Office and Office 365.","fork":false,"url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react","forks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/forks","keys_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/teams","hooks_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/events","assignees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/tags","blobs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/subscription","commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/merges","archive_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/downloads","issues_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/releases{/id}","deployments_url":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/deployments","created_at":"2016-06-06T15:03:44Z","updated_at":"2019-03-15T16:49:58Z","pushed_at":"2019-03-15T12:36:10Z","git_url":"git://github.com/OfficeDev/office-ui-fabric-react.git","ssh_url":"[email protected]:OfficeDev/office-ui-fabric-react.git","clone_url":"https://github.com/OfficeDev/office-ui-fabric-react.git","svn_url":"https://github.com/OfficeDev/office-ui-fabric-react","homepage":"https://developer.microsoft.com/en-us/fabric/#/components","size":57107,"stargazers_count":4469,"watchers_count":4469,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":967,"mirror_url":null,"archived":false,"open_issues_count":406,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":967,"open_issues":406,"watchers":4469,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/8273"},"html":{"href":"https://github.com/OfficeDev/office-ui-fabric-react/pull/8273"},"issue":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/8273"},"comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/issues/8273/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/8273/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/pulls/8273/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/office-ui-fabric-react/statuses/7e6cd76cfe277599624b0322464e03a9e380aa84"}},"author_association":"COLLABORATOR"}}
|
{
"id": 60537144,
"name": "OfficeDev/office-ui-fabric-react",
"url": "https://api.github.com/repos/OfficeDev/office-ui-fabric-react"
}
|
{
"id": 14134000,
"login": "natalieethell",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14134000?",
"url": "https://api.github.com/users/natalieethell"
}
|
{
"id": 6789362,
"login": "OfficeDev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6789362?",
"url": "https://api.github.com/orgs/OfficeDev"
}
| 2019-03-15T16:53:18 |
9252383601
|
{"actor":{"display_login":"natalieethell"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/cruise-automation/webviz/pulls/comments/362680667","pull_request_review_id":337919805,"id":362680667,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MjY4MDY2Nw==","diff_hunk":"@@ -86,5 +86,51 @@ storiesOf(\"Worldview/GLText\", module)\n </Container>\n );\n }\n+ return <Example />;\n+ })\n+ .add(\"highlighted text\", () => {\n+ const Example = () => {\n+ const [searchText, setSearchText] = useState(\"ello\\nW\");\n+ const markers = textMarkers({ text: \"Hello\\nWorldview\" }).map((marker) => {\n+ if (!searchText) {\n+ return marker;\n+ }\n+ const highlightedIndices = new Set();\n+ let match;\n+ let regex;\n+ try {\n+ regex = new RegExp(searchText, \"ig\");\n+ } catch (e) {\n+ return marker;\n+ }\n+ while ((match = regex.exec(marker.text)) !== null) {\n+ Array.from(Array(searchText.length).keys()).forEach((i) => {","path":"packages/regl-worldview/src/stories/GLText.stories.js","position":22,"original_position":22,"commit_id":"bb7fbcf44925d9f2946791138804ad13a2d7d57e","original_commit_id":"bb7fbcf44925d9f2946791138804ad13a2d7d57e","user":{"login":"jtbandes","id":14237,"node_id":"MDQ6VXNlcjE0MjM3","avatar_url":"https://avatars0.githubusercontent.com/u/14237?v=4","gravatar_id":"","url":"https://api.github.com/users/jtbandes","html_url":"https://github.com/jtbandes","followers_url":"https://api.github.com/users/jtbandes/followers","following_url":"https://api.github.com/users/jtbandes/following{/other_user}","gists_url":"https://api.github.com/users/jtbandes/gists{/gist_id}","starred_url":"https://api.github.com/users/jtbandes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtbandes/subscriptions","organizations_url":"https://api.github.com/users/jtbandes/orgs","repos_url":"https://api.github.com/users/jtbandes/repos","events_url":"https://api.github.com/users/jtbandes/events{/privacy}","received_events_url":"https://api.github.com/users/jtbandes/received_events","type":"User","site_admin":false},"body":"TIL about this technique for getting a range 😮 But also, feel free to just use `_.range()` :)\r\n\r\nShould probably use `match[0].length` instead though.","created_at":"2020-01-03T00:47:35Z","updated_at":"2020-01-03T00:47:36Z","html_url":"https://github.com/cruise-automation/webviz/pull/296#discussion_r362680667","pull_request_url":"https://api.github.com/repos/cruise-automation/webviz/pulls/296","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cruise-automation/webviz/pulls/comments/362680667"},"html":{"href":"https://github.com/cruise-automation/webviz/pull/296#discussion_r362680667"},"pull_request":{"href":"https://api.github.com/repos/cruise-automation/webviz/pulls/296"}}},"pull_request":{"url":"https://api.github.com/repos/cruise-automation/webviz/pulls/296","id":355890656,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU1ODkwNjU2","html_url":"https://github.com/cruise-automation/webviz/pull/296","diff_url":"https://github.com/cruise-automation/webviz/pull/296.diff","patch_url":"https://github.com/cruise-automation/webviz/pull/296.patch","issue_url":"https://api.github.com/repos/cruise-automation/webviz/issues/296","number":296,"state":"open","locked":false,"title":"<GLText /> Highlight","user":{"login":"troygibb","id":18633748,"node_id":"MDQ6VXNlcjE4NjMzNzQ4","avatar_url":"https://avatars2.githubusercontent.com/u/18633748?v=4","gravatar_id":"","url":"https://api.github.com/users/troygibb","html_url":"https://github.com/troygibb","followers_url":"https://api.github.com/users/troygibb/followers","following_url":"https://api.github.com/users/troygibb/following{/other_user}","gists_url":"https://api.github.com/users/troygibb/gists{/gist_id}","starred_url":"https://api.github.com/users/troygibb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troygibb/subscriptions","organizations_url":"https://api.github.com/users/troygibb/orgs","repos_url":"https://api.github.com/users/troygibb/repos","events_url":"https://api.github.com/users/troygibb/events{/privacy}","received_events_url":"https://api.github.com/users/troygibb/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for contributing to Webviz! To help us understand and review your PR, please fill out the following sections: -->\r\n\r\n## Summary\r\n\r\nAdds a `highlightedIndices` prop to the `<GLText />` command.\r\n\r\nAfter reviewing an original implementation of this feature with @jtbandes, where I kept the `BUFFER` value and dynamically calculated the highlight box, we agreed it might be better to just take that value out altogether, since the background highlighting feature, currently available in the `<Text />` command, is more readable than outlining.\r\n\r\nSo the main change is really just taking out this buffer value out of all the calculations, and adding a separate `vEnableHighlight` variable to the fragment shader, which takes an opinionated stance on how highlighting is done. That is, we make the font black and the background color yellow. This highlighting UI is how Chrome does it at least. \r\n\r\nI also bumped up the `CUTOFF` constant significantly since there were some weird smudges at certain zoom levels. Since this value is used in a variety of places, I don't have a good theory on why it seemed to make things better. Since we no longer have a buffer in the atlas, I figured some pixels from neighboring characters might be getting mixed into the character textures. Bumping it seemed to work though with no visible regression.\r\n\r\nOne feature I did not include is a background color for the focused highlight element, which would mimic the behavior you see on a webpage as you iterate through `ctrl + f` search results (the focused highlighted element has an orange background color). This may/may not be necessary, I just figured I'd keep it simple for now. \r\n\r\n\r\n\r\n## Test plan\r\n\r\nExisting screenshots and one new screenshot with some dynamically highlighted text markers.\r\n\r\n## Versioning impact\r\n\r\nMinor.\r\n","created_at":"2019-12-20T20:30:13Z","updated_at":"2020-01-03T00:47:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8255870095638f4c853559410a3ca65d2ff3fb87","assignee":null,"assignees":[],"requested_reviewers":[{"login":"brianc","id":50081,"node_id":"MDQ6VXNlcjUwMDgx","avatar_url":"https://avatars0.githubusercontent.com/u/50081?v=4","gravatar_id":"","url":"https://api.github.com/users/brianc","html_url":"https://github.com/brianc","followers_url":"https://api.github.com/users/brianc/followers","following_url":"https://api.github.com/users/brianc/following{/other_user}","gists_url":"https://api.github.com/users/brianc/gists{/gist_id}","starred_url":"https://api.github.com/users/brianc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianc/subscriptions","organizations_url":"https://api.github.com/users/brianc/orgs","repos_url":"https://api.github.com/users/brianc/repos","events_url":"https://api.github.com/users/brianc/events{/privacy}","received_events_url":"https://api.github.com/users/brianc/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cruise-automation/webviz/pulls/296/commits","review_comments_url":"https://api.github.com/repos/cruise-automation/webviz/pulls/296/comments","review_comment_url":"https://api.github.com/repos/cruise-automation/webviz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cruise-automation/webviz/issues/296/comments","statuses_url":"https://api.github.com/repos/cruise-automation/webviz/statuses/bb7fbcf44925d9f2946791138804ad13a2d7d57e","head":{"label":"cruise-automation:troy/gl-text-highlight","ref":"troy/gl-text-highlight","sha":"bb7fbcf44925d9f2946791138804ad13a2d7d57e","user":{"login":"cruise-automation","id":6834651,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4MzQ2NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6834651?v=4","gravatar_id":"","url":"https://api.github.com/users/cruise-automation","html_url":"https://github.com/cruise-automation","followers_url":"https://api.github.com/users/cruise-automation/followers","following_url":"https://api.github.com/users/cruise-automation/following{/other_user}","gists_url":"https://api.github.com/users/cruise-automation/gists{/gist_id}","starred_url":"https://api.github.com/users/cruise-automation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cruise-automation/subscriptions","organizations_url":"https://api.github.com/users/cruise-automation/orgs","repos_url":"https://api.github.com/users/cruise-automation/repos","events_url":"https://api.github.com/users/cruise-automation/events{/privacy}","received_events_url":"https://api.github.com/users/cruise-automation/received_events","type":"Organization","site_admin":false},"repo":{"id":160963776,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA5NjM3NzY=","name":"webviz","full_name":"cruise-automation/webviz","private":false,"owner":{"login":"cruise-automation","id":6834651,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4MzQ2NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6834651?v=4","gravatar_id":"","url":"https://api.github.com/users/cruise-automation","html_url":"https://github.com/cruise-automation","followers_url":"https://api.github.com/users/cruise-automation/followers","following_url":"https://api.github.com/users/cruise-automation/following{/other_user}","gists_url":"https://api.github.com/users/cruise-automation/gists{/gist_id}","starred_url":"https://api.github.com/users/cruise-automation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cruise-automation/subscriptions","organizations_url":"https://api.github.com/users/cruise-automation/orgs","repos_url":"https://api.github.com/users/cruise-automation/repos","events_url":"https://api.github.com/users/cruise-automation/events{/privacy}","received_events_url":"https://api.github.com/users/cruise-automation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cruise-automation/webviz","description":"web-based visualization libraries","fork":false,"url":"https://api.github.com/repos/cruise-automation/webviz","forks_url":"https://api.github.com/repos/cruise-automation/webviz/forks","keys_url":"https://api.github.com/repos/cruise-automation/webviz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cruise-automation/webviz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cruise-automation/webviz/teams","hooks_url":"https://api.github.com/repos/cruise-automation/webviz/hooks","issue_events_url":"https://api.github.com/repos/cruise-automation/webviz/issues/events{/number}","events_url":"https://api.github.com/repos/cruise-automation/webviz/events","assignees_url":"https://api.github.com/repos/cruise-automation/webviz/assignees{/user}","branches_url":"https://api.github.com/repos/cruise-automation/webviz/branches{/branch}","tags_url":"https://api.github.com/repos/cruise-automation/webviz/tags","blobs_url":"https://api.github.com/repos/cruise-automation/webviz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cruise-automation/webviz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cruise-automation/webviz/git/refs{/sha}","trees_url":"https://api.github.com/repos/cruise-automation/webviz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cruise-automation/webviz/statuses/{sha}","languages_url":"https://api.github.com/repos/cruise-automation/webviz/languages","stargazers_url":"https://api.github.com/repos/cruise-automation/webviz/stargazers","contributors_url":"https://api.github.com/repos/cruise-automation/webviz/contributors","subscribers_url":"https://api.github.com/repos/cruise-automation/webviz/subscribers","subscription_url":"https://api.github.com/repos/cruise-automation/webviz/subscription","commits_url":"https://api.github.com/repos/cruise-automation/webviz/commits{/sha}","git_commits_url":"https://api.github.com/repos/cruise-automation/webviz/git/commits{/sha}","comments_url":"https://api.github.com/repos/cruise-automation/webviz/comments{/number}","issue_comment_url":"https://api.github.com/repos/cruise-automation/webviz/issues/comments{/number}","contents_url":"https://api.github.com/repos/cruise-automation/webviz/contents/{+path}","compare_url":"https://api.github.com/repos/cruise-automation/webviz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cruise-automation/webviz/merges","archive_url":"https://api.github.com/repos/cruise-automation/webviz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cruise-automation/webviz/downloads","issues_url":"https://api.github.com/repos/cruise-automation/webviz/issues{/number}","pulls_url":"https://api.github.com/repos/cruise-automation/webviz/pulls{/number}","milestones_url":"https://api.github.com/repos/cruise-automation/webviz/milestones{/number}","notifications_url":"https://api.github.com/repos/cruise-automation/webviz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cruise-automation/webviz/labels{/name}","releases_url":"https://api.github.com/repos/cruise-automation/webviz/releases{/id}","deployments_url":"https://api.github.com/repos/cruise-automation/webviz/deployments","created_at":"2018-12-08T17:44:22Z","updated_at":"2020-01-02T19:21:51Z","pushed_at":"2020-01-02T23:17:47Z","git_url":"git://github.com/cruise-automation/webviz.git","ssh_url":"[email protected]:cruise-automation/webviz.git","clone_url":"https://github.com/cruise-automation/webviz.git","svn_url":"https://github.com/cruise-automation/webviz","homepage":"https://webviz.io/","size":69675,"stargazers_count":673,"watchers_count":673,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":117,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":117,"open_issues":29,"watchers":673,"default_branch":"master"}},"base":{"label":"cruise-automation:master","ref":"master","sha":"1d71c18a74c8afbd4b9039bc097c44a123f908f9","user":{"login":"cruise-automation","id":6834651,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4MzQ2NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6834651?v=4","gravatar_id":"","url":"https://api.github.com/users/cruise-automation","html_url":"https://github.com/cruise-automation","followers_url":"https://api.github.com/users/cruise-automation/followers","following_url":"https://api.github.com/users/cruise-automation/following{/other_user}","gists_url":"https://api.github.com/users/cruise-automation/gists{/gist_id}","starred_url":"https://api.github.com/users/cruise-automation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cruise-automation/subscriptions","organizations_url":"https://api.github.com/users/cruise-automation/orgs","repos_url":"https://api.github.com/users/cruise-automation/repos","events_url":"https://api.github.com/users/cruise-automation/events{/privacy}","received_events_url":"https://api.github.com/users/cruise-automation/received_events","type":"Organization","site_admin":false},"repo":{"id":160963776,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA5NjM3NzY=","name":"webviz","full_name":"cruise-automation/webviz","private":false,"owner":{"login":"cruise-automation","id":6834651,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4MzQ2NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6834651?v=4","gravatar_id":"","url":"https://api.github.com/users/cruise-automation","html_url":"https://github.com/cruise-automation","followers_url":"https://api.github.com/users/cruise-automation/followers","following_url":"https://api.github.com/users/cruise-automation/following{/other_user}","gists_url":"https://api.github.com/users/cruise-automation/gists{/gist_id}","starred_url":"https://api.github.com/users/cruise-automation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cruise-automation/subscriptions","organizations_url":"https://api.github.com/users/cruise-automation/orgs","repos_url":"https://api.github.com/users/cruise-automation/repos","events_url":"https://api.github.com/users/cruise-automation/events{/privacy}","received_events_url":"https://api.github.com/users/cruise-automation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cruise-automation/webviz","description":"web-based visualization libraries","fork":false,"url":"https://api.github.com/repos/cruise-automation/webviz","forks_url":"https://api.github.com/repos/cruise-automation/webviz/forks","keys_url":"https://api.github.com/repos/cruise-automation/webviz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cruise-automation/webviz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cruise-automation/webviz/teams","hooks_url":"https://api.github.com/repos/cruise-automation/webviz/hooks","issue_events_url":"https://api.github.com/repos/cruise-automation/webviz/issues/events{/number}","events_url":"https://api.github.com/repos/cruise-automation/webviz/events","assignees_url":"https://api.github.com/repos/cruise-automation/webviz/assignees{/user}","branches_url":"https://api.github.com/repos/cruise-automation/webviz/branches{/branch}","tags_url":"https://api.github.com/repos/cruise-automation/webviz/tags","blobs_url":"https://api.github.com/repos/cruise-automation/webviz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cruise-automation/webviz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cruise-automation/webviz/git/refs{/sha}","trees_url":"https://api.github.com/repos/cruise-automation/webviz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cruise-automation/webviz/statuses/{sha}","languages_url":"https://api.github.com/repos/cruise-automation/webviz/languages","stargazers_url":"https://api.github.com/repos/cruise-automation/webviz/stargazers","contributors_url":"https://api.github.com/repos/cruise-automation/webviz/contributors","subscribers_url":"https://api.github.com/repos/cruise-automation/webviz/subscribers","subscription_url":"https://api.github.com/repos/cruise-automation/webviz/subscription","commits_url":"https://api.github.com/repos/cruise-automation/webviz/commits{/sha}","git_commits_url":"https://api.github.com/repos/cruise-automation/webviz/git/commits{/sha}","comments_url":"https://api.github.com/repos/cruise-automation/webviz/comments{/number}","issue_comment_url":"https://api.github.com/repos/cruise-automation/webviz/issues/comments{/number}","contents_url":"https://api.github.com/repos/cruise-automation/webviz/contents/{+path}","compare_url":"https://api.github.com/repos/cruise-automation/webviz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cruise-automation/webviz/merges","archive_url":"https://api.github.com/repos/cruise-automation/webviz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cruise-automation/webviz/downloads","issues_url":"https://api.github.com/repos/cruise-automation/webviz/issues{/number}","pulls_url":"https://api.github.com/repos/cruise-automation/webviz/pulls{/number}","milestones_url":"https://api.github.com/repos/cruise-automation/webviz/milestones{/number}","notifications_url":"https://api.github.com/repos/cruise-automation/webviz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cruise-automation/webviz/labels{/name}","releases_url":"https://api.github.com/repos/cruise-automation/webviz/releases{/id}","deployments_url":"https://api.github.com/repos/cruise-automation/webviz/deployments","created_at":"2018-12-08T17:44:22Z","updated_at":"2020-01-02T19:21:51Z","pushed_at":"2020-01-02T23:17:47Z","git_url":"git://github.com/cruise-automation/webviz.git","ssh_url":"[email protected]:cruise-automation/webviz.git","clone_url":"https://github.com/cruise-automation/webviz.git","svn_url":"https://github.com/cruise-automation/webviz","homepage":"https://webviz.io/","size":69675,"stargazers_count":673,"watchers_count":673,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":117,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":117,"open_issues":29,"watchers":673,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cruise-automation/webviz/pulls/296"},"html":{"href":"https://github.com/cruise-automation/webviz/pull/296"},"issue":{"href":"https://api.github.com/repos/cruise-automation/webviz/issues/296"},"comments":{"href":"https://api.github.com/repos/cruise-automation/webviz/issues/296/comments"},"review_comments":{"href":"https://api.github.com/repos/cruise-automation/webviz/pulls/296/comments"},"review_comment":{"href":"https://api.github.com/repos/cruise-automation/webviz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cruise-automation/webviz/pulls/296/commits"},"statuses":{"href":"https://api.github.com/repos/cruise-automation/webviz/statuses/bb7fbcf44925d9f2946791138804ad13a2d7d57e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 160963776,
"name": "cruise-automation/webviz",
"url": "https://api.github.com/repos/cruise-automation/webviz"
}
|
{
"id": 14237,
"login": "jtbandes",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/14237?",
"url": "https://api.github.com/users/jtbandes"
}
|
{
"id": 6834651,
"login": "cruise-automation",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6834651?",
"url": "https://api.github.com/orgs/cruise-automation"
}
| 2020-01-03T00:47:35 |
11194391977
|
{"actor":{"display_login":"jtbandes"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/pulls/comments/353617031","pull_request_review_id":326677975,"id":353617031,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1MzYxNzAzMQ==","diff_hunk":"@@ -0,0 +1,200 @@\n+# gdrive_ros\n+\n+Google Drive file uploader for ROS\n+\n+## Installation\n+\n+### Setup and build workspace \n+\n+```bash\n+cd ~\n+mkdir gdrive_ws/src -p\n+cd gdrive_ws/src\n+git clone https://github.com/knorth55/gdrive_ros.git\n+rosdep install --ignore-src -from-paths . -y -r -i\n+cd ~/gdrive_ws\n+catkin build\n+```\n+\n+### Authentication for Google Drive API \n+\n+Please follow [here](https://gsuitedevs.github.io/PyDrive/docs/build/html/quickstart.html#authentication).\n+\n+### Create your settings yaml\n+\n+Please follow [here](https://gsuitedevs.github.io/PyDrive/docs/build/html/oauth.html#sample-settings-yaml).\n+\n+My settings yaml is as follows;\n+\n+```yaml\n+client_config_file: /your/client/secrets/json/path\n+save_credentials: True\n+save_credentials_backend: file\n+save_credentials_file: /your/credentials/json/path\n+get_refresh_token: True\n+oauth_scope:\n+ - https://www.googleapis.com/auth/drive.file\n+```\n+\n+## Usage\n+\n+### Run server\n+```bash\n+export GOOGLE_DRIVE_SETTINGS_YAML=/your/settings/yaml/path\n+roslaunch gdrive_ros gdrive_server.launch","path":"gdrive_ros/README.md","position":44,"original_position":44,"commit_id":"86ade64060c2f4d46e82589bf6d883f1d4fb6e7d","original_commit_id":"86ade64060c2f4d46e82589bf6d883f1d4fb6e7d","user":{"login":"YutoUchimi","id":22876283,"node_id":"MDQ6VXNlcjIyODc2Mjgz","avatar_url":"https://avatars0.githubusercontent.com/u/22876283?v=4","gravatar_id":"","url":"https://api.github.com/users/YutoUchimi","html_url":"https://github.com/YutoUchimi","followers_url":"https://api.github.com/users/YutoUchimi/followers","following_url":"https://api.github.com/users/YutoUchimi/following{/other_user}","gists_url":"https://api.github.com/users/YutoUchimi/gists{/gist_id}","starred_url":"https://api.github.com/users/YutoUchimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YutoUchimi/subscriptions","organizations_url":"https://api.github.com/users/YutoUchimi/orgs","repos_url":"https://api.github.com/users/YutoUchimi/repos","events_url":"https://api.github.com/users/YutoUchimi/events{/privacy}","received_events_url":"https://api.github.com/users/YutoUchimi/received_events","type":"User","site_admin":false},"body":"Please add description that user must login to google account via browser.","created_at":"2019-12-04T09:01:03Z","updated_at":"2019-12-04T09:45:16Z","html_url":"https://github.com/jsk-ros-pkg/jsk_3rdparty/pull/182#discussion_r353617031","pull_request_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/pulls/182","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/pulls/comments/353617031"},"html":{"href":"https://github.com/jsk-ros-pkg/jsk_3rdparty/pull/182#discussion_r353617031"},"pull_request":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/pulls/182"}}},"pull_request":{"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/pulls/182","id":346320361,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQ2MzIwMzYx","html_url":"https://github.com/jsk-ros-pkg/jsk_3rdparty/pull/182","diff_url":"https://github.com/jsk-ros-pkg/jsk_3rdparty/pull/182.diff","patch_url":"https://github.com/jsk-ros-pkg/jsk_3rdparty/pull/182.patch","issue_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/issues/182","number":182,"state":"open","locked":false,"title":"add gdrive_ros package","user":{"login":"knorth55","id":9300063,"node_id":"MDQ6VXNlcjkzMDAwNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/9300063?v=4","gravatar_id":"","url":"https://api.github.com/users/knorth55","html_url":"https://github.com/knorth55","followers_url":"https://api.github.com/users/knorth55/followers","following_url":"https://api.github.com/users/knorth55/following{/other_user}","gists_url":"https://api.github.com/users/knorth55/gists{/gist_id}","starred_url":"https://api.github.com/users/knorth55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knorth55/subscriptions","organizations_url":"https://api.github.com/users/knorth55/orgs","repos_url":"https://api.github.com/users/knorth55/repos","events_url":"https://api.github.com/users/knorth55/events{/privacy}","received_events_url":"https://api.github.com/users/knorth55/received_events","type":"User","site_admin":false},"body":"gdrive_ros is Google Drive upload ros package.\r\nthis package is used in go_to_kitchen demo in fetch. https://github.com/jsk-ros-pkg/jsk_robot/pull/1149","created_at":"2019-11-27T16:11:49Z","updated_at":"2019-12-04T09:45:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2b30cc1e0e5d96ee8746908a813fb10ae7605d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":223503837,"node_id":"MDU6TGFiZWwyMjM1MDM4Mzc=","url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/labels/enhancement","name":"enhancement","color":"84b6eb","default":true,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/pulls/182/commits","review_comments_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/pulls/182/comments","review_comment_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/issues/182/comments","statuses_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/statuses/86ade64060c2f4d46e82589bf6d883f1d4fb6e7d","head":{"label":"knorth55:add-gdrive","ref":"add-gdrive","sha":"86ade64060c2f4d46e82589bf6d883f1d4fb6e7d","user":{"login":"knorth55","id":9300063,"node_id":"MDQ6VXNlcjkzMDAwNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/9300063?v=4","gravatar_id":"","url":"https://api.github.com/users/knorth55","html_url":"https://github.com/knorth55","followers_url":"https://api.github.com/users/knorth55/followers","following_url":"https://api.github.com/users/knorth55/following{/other_user}","gists_url":"https://api.github.com/users/knorth55/gists{/gist_id}","starred_url":"https://api.github.com/users/knorth55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knorth55/subscriptions","organizations_url":"https://api.github.com/users/knorth55/orgs","repos_url":"https://api.github.com/users/knorth55/repos","events_url":"https://api.github.com/users/knorth55/events{/privacy}","received_events_url":"https://api.github.com/users/knorth55/received_events","type":"User","site_admin":false},"repo":{"id":192111875,"node_id":"MDEwOlJlcG9zaXRvcnkxOTIxMTE4NzU=","name":"jsk_3rdparty","full_name":"knorth55/jsk_3rdparty","private":false,"owner":{"login":"knorth55","id":9300063,"node_id":"MDQ6VXNlcjkzMDAwNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/9300063?v=4","gravatar_id":"","url":"https://api.github.com/users/knorth55","html_url":"https://github.com/knorth55","followers_url":"https://api.github.com/users/knorth55/followers","following_url":"https://api.github.com/users/knorth55/following{/other_user}","gists_url":"https://api.github.com/users/knorth55/gists{/gist_id}","starred_url":"https://api.github.com/users/knorth55/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knorth55/subscriptions","organizations_url":"https://api.github.com/users/knorth55/orgs","repos_url":"https://api.github.com/users/knorth55/repos","events_url":"https://api.github.com/users/knorth55/events{/privacy}","received_events_url":"https://api.github.com/users/knorth55/received_events","type":"User","site_admin":false},"html_url":"https://github.com/knorth55/jsk_3rdparty","description":null,"fork":true,"url":"https://api.github.com/repos/knorth55/jsk_3rdparty","forks_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/forks","keys_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/teams","hooks_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/hooks","issue_events_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/issues/events{/number}","events_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/events","assignees_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/assignees{/user}","branches_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/branches{/branch}","tags_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/tags","blobs_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/git/refs{/sha}","trees_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/statuses/{sha}","languages_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/languages","stargazers_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/stargazers","contributors_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/contributors","subscribers_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/subscribers","subscription_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/subscription","commits_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/commits{/sha}","git_commits_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/git/commits{/sha}","comments_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/comments{/number}","issue_comment_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/issues/comments{/number}","contents_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/contents/{+path}","compare_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/merges","archive_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/downloads","issues_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/issues{/number}","pulls_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/pulls{/number}","milestones_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/milestones{/number}","notifications_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/labels{/name}","releases_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/releases{/id}","deployments_url":"https://api.github.com/repos/knorth55/jsk_3rdparty/deployments","created_at":"2019-06-15T18:34:23Z","updated_at":"2019-11-02T10:49:10Z","pushed_at":"2019-12-03T15:46:54Z","git_url":"git://github.com/knorth55/jsk_3rdparty.git","ssh_url":"[email protected]:knorth55/jsk_3rdparty.git","clone_url":"https://github.com/knorth55/jsk_3rdparty.git","svn_url":"https://github.com/knorth55/jsk_3rdparty","homepage":null,"size":15603,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jsk-ros-pkg:master","ref":"master","sha":"1aee48d87c50e6cd7a9873adf7e2fdf89485483f","user":{"login":"jsk-ros-pkg","id":6836654,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4MzY2NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6836654?v=4","gravatar_id":"","url":"https://api.github.com/users/jsk-ros-pkg","html_url":"https://github.com/jsk-ros-pkg","followers_url":"https://api.github.com/users/jsk-ros-pkg/followers","following_url":"https://api.github.com/users/jsk-ros-pkg/following{/other_user}","gists_url":"https://api.github.com/users/jsk-ros-pkg/gists{/gist_id}","starred_url":"https://api.github.com/users/jsk-ros-pkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsk-ros-pkg/subscriptions","organizations_url":"https://api.github.com/users/jsk-ros-pkg/orgs","repos_url":"https://api.github.com/users/jsk-ros-pkg/repos","events_url":"https://api.github.com/users/jsk-ros-pkg/events{/privacy}","received_events_url":"https://api.github.com/users/jsk-ros-pkg/received_events","type":"Organization","site_admin":false},"repo":{"id":37300315,"node_id":"MDEwOlJlcG9zaXRvcnkzNzMwMDMxNQ==","name":"jsk_3rdparty","full_name":"jsk-ros-pkg/jsk_3rdparty","private":false,"owner":{"login":"jsk-ros-pkg","id":6836654,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4MzY2NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6836654?v=4","gravatar_id":"","url":"https://api.github.com/users/jsk-ros-pkg","html_url":"https://github.com/jsk-ros-pkg","followers_url":"https://api.github.com/users/jsk-ros-pkg/followers","following_url":"https://api.github.com/users/jsk-ros-pkg/following{/other_user}","gists_url":"https://api.github.com/users/jsk-ros-pkg/gists{/gist_id}","starred_url":"https://api.github.com/users/jsk-ros-pkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsk-ros-pkg/subscriptions","organizations_url":"https://api.github.com/users/jsk-ros-pkg/orgs","repos_url":"https://api.github.com/users/jsk-ros-pkg/repos","events_url":"https://api.github.com/users/jsk-ros-pkg/events{/privacy}","received_events_url":"https://api.github.com/users/jsk-ros-pkg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jsk-ros-pkg/jsk_3rdparty","description":null,"fork":false,"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty","forks_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/forks","keys_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/teams","hooks_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/hooks","issue_events_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/issues/events{/number}","events_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/events","assignees_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/assignees{/user}","branches_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/branches{/branch}","tags_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/tags","blobs_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/statuses/{sha}","languages_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/languages","stargazers_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/stargazers","contributors_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/contributors","subscribers_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/subscribers","subscription_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/subscription","commits_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/contents/{+path}","compare_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/merges","archive_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/downloads","issues_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/issues{/number}","pulls_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/pulls{/number}","milestones_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/milestones{/number}","notifications_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/labels{/name}","releases_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/releases{/id}","deployments_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/deployments","created_at":"2015-06-12T03:36:56Z","updated_at":"2019-12-03T15:39:42Z","pushed_at":"2019-12-03T15:39:39Z","git_url":"git://github.com/jsk-ros-pkg/jsk_3rdparty.git","ssh_url":"[email protected]:jsk-ros-pkg/jsk_3rdparty.git","clone_url":"https://github.com/jsk-ros-pkg/jsk_3rdparty.git","svn_url":"https://github.com/jsk-ros-pkg/jsk_3rdparty","homepage":null,"size":15598,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":13,"license":null,"forks":25,"open_issues":13,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/pulls/182"},"html":{"href":"https://github.com/jsk-ros-pkg/jsk_3rdparty/pull/182"},"issue":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/issues/182"},"comments":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/issues/182/comments"},"review_comments":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/pulls/182/comments"},"review_comment":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/pulls/182/commits"},"statuses":{"href":"https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty/statuses/86ade64060c2f4d46e82589bf6d883f1d4fb6e7d"}},"author_association":"MEMBER"}}
|
{
"id": 37300315,
"name": "jsk-ros-pkg/jsk_3rdparty",
"url": "https://api.github.com/repos/jsk-ros-pkg/jsk_3rdparty"
}
|
{
"id": 22876283,
"login": "YutoUchimi",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22876283?",
"url": "https://api.github.com/users/YutoUchimi"
}
|
{
"id": 6836654,
"login": "jsk-ros-pkg",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6836654?",
"url": "https://api.github.com/orgs/jsk-ros-pkg"
}
| 2019-12-04T09:01:03 |
11008039565
|
{"actor":{"display_login":"YutoUchimi"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/pulls/comments/344341344","pull_request_review_id":314424986,"id":344341344,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDM0MTM0NA==","diff_hunk":"@@ -0,0 +1,28 @@\n+<div class=\"form-group\" ng-class=\"{ 'has-error' : (ngModelCtrl.$invalid && ngModelCtrl.$dirty) }\">\n+\t<label class=\"control-label\" for=\"password\">\n+\t\t{{ isCreating ? 'Create ' : ''}}Password\n+\t</label>\n+\t<input id=\"password\"\n+\t type=\"password\"\n+\t class=\"form-control\"\n+\t placeholder=\"Enter Password\"\n+\t ng-model=\"ngModel\"/>\n+\n+\t<ng-messages role=\"alert\" for=\"ngModelCtrl.$error\" ng-if=\"ngModelCtrl.$invalid && ngModelCtrl.$dirty\">\n+\t\t<p ng-message=\"required\" class=\"text-danger\">Oops, don't leave this blank.</p>\n+\t\t<p ng-message=\"minlength\" class=\"text-danger\">Password needs to be {{ isCreating ? 12 : 4}} or more characters in length.</p>\n+\t</ng-messages>\n+\n+\t<div id=\"passwordMeter\" ng-if=\"isCreating && scorePercentage && ngModelCtrl.$dirty\">","path":"web/partials/components/password-input/password-input.html","position":16,"original_position":16,"commit_id":"adc65d2f4d165c145cdead1d269700932f99fcc4","original_commit_id":"adc65d2f4d165c145cdead1d269700932f99fcc4","user":{"login":"alex-deaconu","id":6218188,"node_id":"MDQ6VXNlcjYyMTgxODg=","avatar_url":"https://avatars3.githubusercontent.com/u/6218188?v=4","gravatar_id":"","url":"https://api.github.com/users/alex-deaconu","html_url":"https://github.com/alex-deaconu","followers_url":"https://api.github.com/users/alex-deaconu/followers","following_url":"https://api.github.com/users/alex-deaconu/following{/other_user}","gists_url":"https://api.github.com/users/alex-deaconu/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-deaconu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-deaconu/subscriptions","organizations_url":"https://api.github.com/users/alex-deaconu/orgs","repos_url":"https://api.github.com/users/alex-deaconu/repos","events_url":"https://api.github.com/users/alex-deaconu/events{/privacy}","received_events_url":"https://api.github.com/users/alex-deaconu/received_events","type":"User","site_admin":false},"body":"Sounds good, thanks!","created_at":"2019-11-08T19:51:58Z","updated_at":"2019-11-08T19:51:58Z","html_url":"https://github.com/Rise-Vision/rise-vision-apps/pull/1353#discussion_r344341344","pull_request_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/pulls/1353","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/pulls/comments/344341344"},"html":{"href":"https://github.com/Rise-Vision/rise-vision-apps/pull/1353#discussion_r344341344"},"pull_request":{"href":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/pulls/1353"}},"in_reply_to_id":344334569},"pull_request":{"url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/pulls/1353","id":338793646,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM4NzkzNjQ2","html_url":"https://github.com/Rise-Vision/rise-vision-apps/pull/1353","diff_url":"https://github.com/Rise-Vision/rise-vision-apps/pull/1353.diff","patch_url":"https://github.com/Rise-Vision/rise-vision-apps/pull/1353.patch","issue_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/issues/1353","number":1353,"state":"open","locked":false,"title":"Add Password Meter","user":{"login":"ezequielc","id":7738553,"node_id":"MDQ6VXNlcjc3Mzg1NTM=","avatar_url":"https://avatars1.githubusercontent.com/u/7738553?v=4","gravatar_id":"","url":"https://api.github.com/users/ezequielc","html_url":"https://github.com/ezequielc","followers_url":"https://api.github.com/users/ezequielc/followers","following_url":"https://api.github.com/users/ezequielc/following{/other_user}","gists_url":"https://api.github.com/users/ezequielc/gists{/gist_id}","starred_url":"https://api.github.com/users/ezequielc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezequielc/subscriptions","organizations_url":"https://api.github.com/users/ezequielc/orgs","repos_url":"https://api.github.com/users/ezequielc/repos","events_url":"https://api.github.com/users/ezequielc/events{/privacy}","received_events_url":"https://api.github.com/users/ezequielc/received_events","type":"User","site_admin":false},"body":"## Description\r\n- Added Password Meter as a directive for Registration, Password Reset and Password Change forms.\r\n- Used [zxcvbn](https://github.com/dropbox/zxcvbn) library for password scoring\r\n- Added [oclazyload](https://oclazyload.readme.io/) to load zxcvbn only when needed, due to its file size (~800KB).\r\n- Refactored custom sign in e2e tests, moved signup cases to registration scenario.\r\n\r\n## Motivation and Context\r\nSign Up Epic\r\n\r\n## How Has This Been Tested?\r\nManually tested locally and on https://apps-stage-1.risevision.com/createaccount/.\r\nConfirmed that zxcvbn library is only loaded on demand.\r\n\r\n## Release Plan:\r\n- As the Submitter, upon requesting review of this pull request, I confirm that the [Release Checklist](https://help.risevision.com/hc/en-us/articles/360031119991) has been completed. \r\n- As the Reviewer, upon approving the changes in this PR, I confirm I have reviewed and I agree that the [Release Checklist](https://help.risevision.com/hc/en-us/articles/360031119991) has been completed\r\n\r\n#### Release Checklist Items Skipped?\r\nIf any Release Checklist items were intentionally skipped, please provide which ones and the reasons why\r\n\r\n\r\n@alex-deaconu Please review","created_at":"2019-11-08T18:05:26Z","updated_at":"2019-11-08T19:51:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffc1568e49ce86e418ee2d83f3950c8384714d81","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/pulls/1353/commits","review_comments_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/pulls/1353/comments","review_comment_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/issues/1353/comments","statuses_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/statuses/adc65d2f4d165c145cdead1d269700932f99fcc4","head":{"label":"Rise-Vision:feature/password-meter","ref":"feature/password-meter","sha":"adc65d2f4d165c145cdead1d269700932f99fcc4","user":{"login":"Rise-Vision","id":6840223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDAyMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6840223?v=4","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"repo":{"id":38897323,"node_id":"MDEwOlJlcG9zaXRvcnkzODg5NzMyMw==","name":"rise-vision-apps","full_name":"Rise-Vision/rise-vision-apps","private":false,"owner":{"login":"Rise-Vision","id":6840223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDAyMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6840223?v=4","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Rise-Vision/rise-vision-apps","description":"A web app to hold all of our apps with sign up and in functionalities. It includes common header","fork":false,"url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps","forks_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/forks","keys_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/teams","hooks_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/hooks","issue_events_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/issues/events{/number}","events_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/events","assignees_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/assignees{/user}","branches_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/branches{/branch}","tags_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/tags","blobs_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/statuses/{sha}","languages_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/languages","stargazers_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/stargazers","contributors_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/contributors","subscribers_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/subscribers","subscription_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/subscription","commits_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/contents/{+path}","compare_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/merges","archive_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/downloads","issues_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/issues{/number}","pulls_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/pulls{/number}","milestones_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/milestones{/number}","notifications_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/labels{/name}","releases_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/releases{/id}","deployments_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/deployments","created_at":"2015-07-10T19:03:05Z","updated_at":"2019-11-07T23:54:03Z","pushed_at":"2019-11-08T18:05:27Z","git_url":"git://github.com/Rise-Vision/rise-vision-apps.git","ssh_url":"[email protected]:Rise-Vision/rise-vision-apps.git","clone_url":"https://github.com/Rise-Vision/rise-vision-apps.git","svn_url":"https://github.com/Rise-Vision/rise-vision-apps","homepage":null,"size":3977,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":5,"watchers":14,"default_branch":"master"}},"base":{"label":"Rise-Vision:master","ref":"master","sha":"3ae01cccedd5a5501c028b980f5e4f5f35a69e15","user":{"login":"Rise-Vision","id":6840223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDAyMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6840223?v=4","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"repo":{"id":38897323,"node_id":"MDEwOlJlcG9zaXRvcnkzODg5NzMyMw==","name":"rise-vision-apps","full_name":"Rise-Vision/rise-vision-apps","private":false,"owner":{"login":"Rise-Vision","id":6840223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDAyMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/6840223?v=4","gravatar_id":"","url":"https://api.github.com/users/Rise-Vision","html_url":"https://github.com/Rise-Vision","followers_url":"https://api.github.com/users/Rise-Vision/followers","following_url":"https://api.github.com/users/Rise-Vision/following{/other_user}","gists_url":"https://api.github.com/users/Rise-Vision/gists{/gist_id}","starred_url":"https://api.github.com/users/Rise-Vision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rise-Vision/subscriptions","organizations_url":"https://api.github.com/users/Rise-Vision/orgs","repos_url":"https://api.github.com/users/Rise-Vision/repos","events_url":"https://api.github.com/users/Rise-Vision/events{/privacy}","received_events_url":"https://api.github.com/users/Rise-Vision/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Rise-Vision/rise-vision-apps","description":"A web app to hold all of our apps with sign up and in functionalities. It includes common header","fork":false,"url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps","forks_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/forks","keys_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/teams","hooks_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/hooks","issue_events_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/issues/events{/number}","events_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/events","assignees_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/assignees{/user}","branches_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/branches{/branch}","tags_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/tags","blobs_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/statuses/{sha}","languages_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/languages","stargazers_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/stargazers","contributors_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/contributors","subscribers_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/subscribers","subscription_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/subscription","commits_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/contents/{+path}","compare_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/merges","archive_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/downloads","issues_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/issues{/number}","pulls_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/pulls{/number}","milestones_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/milestones{/number}","notifications_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/labels{/name}","releases_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/releases{/id}","deployments_url":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/deployments","created_at":"2015-07-10T19:03:05Z","updated_at":"2019-11-07T23:54:03Z","pushed_at":"2019-11-08T18:05:27Z","git_url":"git://github.com/Rise-Vision/rise-vision-apps.git","ssh_url":"[email protected]:Rise-Vision/rise-vision-apps.git","clone_url":"https://github.com/Rise-Vision/rise-vision-apps.git","svn_url":"https://github.com/Rise-Vision/rise-vision-apps","homepage":null,"size":3977,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":5,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/pulls/1353"},"html":{"href":"https://github.com/Rise-Vision/rise-vision-apps/pull/1353"},"issue":{"href":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/issues/1353"},"comments":{"href":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/issues/1353/comments"},"review_comments":{"href":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/pulls/1353/comments"},"review_comment":{"href":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/pulls/1353/commits"},"statuses":{"href":"https://api.github.com/repos/Rise-Vision/rise-vision-apps/statuses/adc65d2f4d165c145cdead1d269700932f99fcc4"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 38897323,
"name": "Rise-Vision/rise-vision-apps",
"url": "https://api.github.com/repos/Rise-Vision/rise-vision-apps"
}
|
{
"id": 6218188,
"login": "alex-deaconu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6218188?",
"url": "https://api.github.com/users/alex-deaconu"
}
|
{
"id": 6840223,
"login": "Rise-Vision",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6840223?",
"url": "https://api.github.com/orgs/Rise-Vision"
}
| 2019-11-08T19:51:58 |
10821914152
|
{"actor":{"display_login":"alex-deaconu"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/SONiC/pulls/comments/325445802","pull_request_review_id":289623773,"id":325445802,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNTQ0NTgwMg==","diff_hunk":"@@ -0,0 +1,1170 @@\n+## Feature Name\n+Platform Driver Development Framework (PDDF)\n+\n+## High Level Design Document\n+**Rev 0.1**\n+\n+## Table of Contents\n+ * [List of Tables](#list-of-tables)\n+ * [Revision](#revision)\n+ * [About This Manual](#about-this-manual)\n+ * [Scope](#scope)\n+ * [Definition/Abbreviation](#definitionabbreviation)\n+ * [Requirements Overview](#requirements-overview)\n+\t * [Functional Requirements](#functional-requirements)\n+\t * [Scalability Requirements](#scalability-requirements)\n+\t * [Warmboot Requirements](#warmboot-requirements)\n+\t * [Configuration and Management Requirements](#configuration-and-management-requirements)\n+ * [Functional Description](#functional-description)\n+ * [Design](#design)\n+\t * [Overview](#overview)\n+\t\t * [Generic PDDF HW Device Drivers](#generic-pddf-hw-device-drivers)\n+\t\t * [PDDF Platform API plugins](#pddf-platform-api-plugins)\n+\t * [Generic Driver Design](#generic-driver-design)\n+\t\t * [PDDF Device Driver Modules](#pddf-device-driver-modules)\n+\t\t * [PDDF Device Modules](#pddf-device-modules)\n+\t\t * [Driver Extension Framework](#driver-extension-framework)\n+\t * [Generic Plugin Design](#generic-plugin-design)\n+\t * [PDDF I2C Component Design](#pddf-i2c-component-design)\n+\t\t * [List of Supported Components](#list-of-supported-components)\n+\t\t * [I2C Topology Descriptor](#i2c-topology-descriptor)\n+\t\t * [PSU Component](#psu-component)\n+\t\t * [FAN Component](#fan-component)\n+\t\t * [LED Component](#led-component)\n+\t\t * [Sensors](#sensors)\n+\t\t * [System EEPROM Component](#system-eeprom-component)\n+\t\t * [System Status Registers](#system-status-registers)\n+\t\t * [Optics Component](#optics-component)\n+\t\t * [lm-sensors](#lm-sensors-tools)\n+ * [SAI](#sai)\n+ * [CLI](#cli)\n+ * [Serviceability and DEBUG](#serviceability-and-debug)\n+ * [Warm Boot Support](#warm-boot-support)\n+ * [Unit Test](#unit-test)\n+\n+\n+# List of Tables\n+[Table 1: Abbreviations](#table-1-abbreviations)\n+\n+# Revision\n+| Rev | Date | Author | Change Description |\n+|:---:|:-----------:|:------------------:|-----------------------------------|\n+| 0.1 | 05/27/2019 | Systems Infra Team | Initial version |\n+| 0.2 | 06/06/2019 | Systems Infra Team | Incorporated feedback |\n+\n+# About this Manual\n+Platform Driver Development Framework (PDDF) is part of SONiC Platform Development Kit (PDK) which optimizes the platform development. PDK consists of \n+ - PDDF (Platform Driver Development Framework): For optimized data-driven platform driver and SONiC plugin development\n+ - PDE (Platform Development Environment): For optimized build and test of platform and SAI code\n+\n+PDE details are covered in another document. This document describes Platform Driver Development Framework (PDDF) which can be used as an alternative to the existing manually-written SONiC platform driver framework. It enables platform vendors to rapidly develop the device specific custom drivers and SONiC user space python plugins, using a data-driven architecture, to manage platform devices like Fan, PSUs, LEDs, Optics, System EEPROM, etc., and validate a platform on SONiC. \n+\n+# Scope\n+This document describes the high level design details of PDDF and its components. The PDDF consists of generic device drivers and user space platform API plugins which use the per platform specific data in the JSON descriptor files. This document describes the interaction between all the components and the tools used to support these drivers and plugins. \n+\n+\n+# Definition/Abbreviation\n+### Table 1: Abbreviations\n+| **Term** | **Meaning** |\n+|--------------------------|-------------------------------------|\n+| ODM | Original Design Manufacturer |\n+| OEM | Original Equipment Manufacturer |\n+| PDDF | Platform Driver Development Framework |\n+| PDE | Platform Development Environment |\n+| PDK | Platform Development Kit |\n+| SAI | Switch Abstraction Interface |\n+| PSU | Power Supply Unit |\n+| I2C | Inter-integrated Circuit communication protocol |\n+| SysFS | Virtual File System provided by the Linux Kernel |\n+\n+\n+## 1 Requirements Overview\n+SONiC OS is portable across different network devices with supported ASIC via Switch Abstraction Interface (SAI). These devices primarily differ in the way various device specific hardware components are accessed, and thus require custom device drivers and python plugins. Each platform vendor implements these custom device drivers and plugins. The feature requirement is to support a SONiC platform driver development framework to enable rapid development of custom device drivers and plugins.\n+","path":"doc/platform/brcm_pdk_pddf.md","position":83,"original_position":83,"commit_id":"6d59a095d6bb9dcb3ecb18e8dacec0ce44e886ad","original_commit_id":"6d59a095d6bb9dcb3ecb18e8dacec0ce44e886ad","user":{"login":"jleveque","id":3300381,"node_id":"MDQ6VXNlcjMzMDAzODE=","avatar_url":"https://avatars1.githubusercontent.com/u/3300381?v=4","gravatar_id":"","url":"https://api.github.com/users/jleveque","html_url":"https://github.com/jleveque","followers_url":"https://api.github.com/users/jleveque/followers","following_url":"https://api.github.com/users/jleveque/following{/other_user}","gists_url":"https://api.github.com/users/jleveque/gists{/gist_id}","starred_url":"https://api.github.com/users/jleveque/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jleveque/subscriptions","organizations_url":"https://api.github.com/users/jleveque/orgs","repos_url":"https://api.github.com/users/jleveque/repos","events_url":"https://api.github.com/users/jleveque/events{/privacy}","received_events_url":"https://api.github.com/users/jleveque/received_events","type":"User","site_admin":false},"body":"@fk410167: Do you have plans to update this document to reflect the new platform API? Vendors are currently in the process of migrating over to the new API. At this point in time, this document should reflect the new API rather than the old plugins.","created_at":"2019-09-18T01:10:18Z","updated_at":"2019-09-18T01:10:18Z","html_url":"https://github.com/Azure/SONiC/pull/406#discussion_r325445802","pull_request_url":"https://api.github.com/repos/Azure/SONiC/pulls/406","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/SONiC/pulls/comments/325445802"},"html":{"href":"https://github.com/Azure/SONiC/pull/406#discussion_r325445802"},"pull_request":{"href":"https://api.github.com/repos/Azure/SONiC/pulls/406"}},"in_reply_to_id":300598476},"pull_request":{"url":"https://api.github.com/repos/Azure/SONiC/pulls/406","id":288872038,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4ODcyMDM4","html_url":"https://github.com/Azure/SONiC/pull/406","diff_url":"https://github.com/Azure/SONiC/pull/406.diff","patch_url":"https://github.com/Azure/SONiC/pull/406.patch","issue_url":"https://api.github.com/repos/Azure/SONiC/issues/406","number":406,"state":"open","locked":false,"title":"PDK PDDF HLD PR request","user":{"login":"fk410167","id":51665572,"node_id":"MDQ6VXNlcjUxNjY1NTcy","avatar_url":"https://avatars2.githubusercontent.com/u/51665572?v=4","gravatar_id":"","url":"https://api.github.com/users/fk410167","html_url":"https://github.com/fk410167","followers_url":"https://api.github.com/users/fk410167/followers","following_url":"https://api.github.com/users/fk410167/following{/other_user}","gists_url":"https://api.github.com/users/fk410167/gists{/gist_id}","starred_url":"https://api.github.com/users/fk410167/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fk410167/subscriptions","organizations_url":"https://api.github.com/users/fk410167/orgs","repos_url":"https://api.github.com/users/fk410167/repos","events_url":"https://api.github.com/users/fk410167/events{/privacy}","received_events_url":"https://api.github.com/users/fk410167/received_events","type":"User","site_admin":false},"body":"This document describes the Platform Driver Development Framework (PDDF) which optimises platform driver and SONiC plugin development using a data-driven model. ","created_at":"2019-06-17T14:25:41Z","updated_at":"2019-09-18T01:10:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e64711ad81c892755bf35a976501de42b27338e2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/SONiC/pulls/406/commits","review_comments_url":"https://api.github.com/repos/Azure/SONiC/pulls/406/comments","review_comment_url":"https://api.github.com/repos/Azure/SONiC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/SONiC/issues/406/comments","statuses_url":"https://api.github.com/repos/Azure/SONiC/statuses/6d59a095d6bb9dcb3ecb18e8dacec0ce44e886ad","head":{"label":"fk410167:pddf_doc","ref":"pddf_doc","sha":"6d59a095d6bb9dcb3ecb18e8dacec0ce44e886ad","user":{"login":"fk410167","id":51665572,"node_id":"MDQ6VXNlcjUxNjY1NTcy","avatar_url":"https://avatars2.githubusercontent.com/u/51665572?v=4","gravatar_id":"","url":"https://api.github.com/users/fk410167","html_url":"https://github.com/fk410167","followers_url":"https://api.github.com/users/fk410167/followers","following_url":"https://api.github.com/users/fk410167/following{/other_user}","gists_url":"https://api.github.com/users/fk410167/gists{/gist_id}","starred_url":"https://api.github.com/users/fk410167/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fk410167/subscriptions","organizations_url":"https://api.github.com/users/fk410167/orgs","repos_url":"https://api.github.com/users/fk410167/repos","events_url":"https://api.github.com/users/fk410167/events{/privacy}","received_events_url":"https://api.github.com/users/fk410167/received_events","type":"User","site_admin":false},"repo":{"id":191196388,"node_id":"MDEwOlJlcG9zaXRvcnkxOTExOTYzODg=","name":"SONiC","full_name":"fk410167/SONiC","private":false,"owner":{"login":"fk410167","id":51665572,"node_id":"MDQ6VXNlcjUxNjY1NTcy","avatar_url":"https://avatars2.githubusercontent.com/u/51665572?v=4","gravatar_id":"","url":"https://api.github.com/users/fk410167","html_url":"https://github.com/fk410167","followers_url":"https://api.github.com/users/fk410167/followers","following_url":"https://api.github.com/users/fk410167/following{/other_user}","gists_url":"https://api.github.com/users/fk410167/gists{/gist_id}","starred_url":"https://api.github.com/users/fk410167/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fk410167/subscriptions","organizations_url":"https://api.github.com/users/fk410167/orgs","repos_url":"https://api.github.com/users/fk410167/repos","events_url":"https://api.github.com/users/fk410167/events{/privacy}","received_events_url":"https://api.github.com/users/fk410167/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fk410167/SONiC","description":"Landing page for Software for Open Networking in the Cloud (SONiC) - http://azure.github.io/SONiC/","fork":true,"url":"https://api.github.com/repos/fk410167/SONiC","forks_url":"https://api.github.com/repos/fk410167/SONiC/forks","keys_url":"https://api.github.com/repos/fk410167/SONiC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fk410167/SONiC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fk410167/SONiC/teams","hooks_url":"https://api.github.com/repos/fk410167/SONiC/hooks","issue_events_url":"https://api.github.com/repos/fk410167/SONiC/issues/events{/number}","events_url":"https://api.github.com/repos/fk410167/SONiC/events","assignees_url":"https://api.github.com/repos/fk410167/SONiC/assignees{/user}","branches_url":"https://api.github.com/repos/fk410167/SONiC/branches{/branch}","tags_url":"https://api.github.com/repos/fk410167/SONiC/tags","blobs_url":"https://api.github.com/repos/fk410167/SONiC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fk410167/SONiC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fk410167/SONiC/git/refs{/sha}","trees_url":"https://api.github.com/repos/fk410167/SONiC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fk410167/SONiC/statuses/{sha}","languages_url":"https://api.github.com/repos/fk410167/SONiC/languages","stargazers_url":"https://api.github.com/repos/fk410167/SONiC/stargazers","contributors_url":"https://api.github.com/repos/fk410167/SONiC/contributors","subscribers_url":"https://api.github.com/repos/fk410167/SONiC/subscribers","subscription_url":"https://api.github.com/repos/fk410167/SONiC/subscription","commits_url":"https://api.github.com/repos/fk410167/SONiC/commits{/sha}","git_commits_url":"https://api.github.com/repos/fk410167/SONiC/git/commits{/sha}","comments_url":"https://api.github.com/repos/fk410167/SONiC/comments{/number}","issue_comment_url":"https://api.github.com/repos/fk410167/SONiC/issues/comments{/number}","contents_url":"https://api.github.com/repos/fk410167/SONiC/contents/{+path}","compare_url":"https://api.github.com/repos/fk410167/SONiC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fk410167/SONiC/merges","archive_url":"https://api.github.com/repos/fk410167/SONiC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fk410167/SONiC/downloads","issues_url":"https://api.github.com/repos/fk410167/SONiC/issues{/number}","pulls_url":"https://api.github.com/repos/fk410167/SONiC/pulls{/number}","milestones_url":"https://api.github.com/repos/fk410167/SONiC/milestones{/number}","notifications_url":"https://api.github.com/repos/fk410167/SONiC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fk410167/SONiC/labels{/name}","releases_url":"https://api.github.com/repos/fk410167/SONiC/releases{/id}","deployments_url":"https://api.github.com/repos/fk410167/SONiC/deployments","created_at":"2019-06-10T15:39:11Z","updated_at":"2019-09-13T09:30:32Z","pushed_at":"2019-09-13T09:57:57Z","git_url":"git://github.com/fk410167/SONiC.git","ssh_url":"[email protected]:fk410167/SONiC.git","clone_url":"https://github.com/fk410167/SONiC.git","svn_url":"https://github.com/fk410167/SONiC","homepage":"","size":71896,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"d2f47174bd6e3a461f2f0ff17161c9dde47e91ea","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":51108542,"node_id":"MDEwOlJlcG9zaXRvcnk1MTEwODU0Mg==","name":"SONiC","full_name":"Azure/SONiC","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/SONiC","description":"Landing page for Software for Open Networking in the Cloud (SONiC) - http://azure.github.io/SONiC/","fork":false,"url":"https://api.github.com/repos/Azure/SONiC","forks_url":"https://api.github.com/repos/Azure/SONiC/forks","keys_url":"https://api.github.com/repos/Azure/SONiC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/SONiC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/SONiC/teams","hooks_url":"https://api.github.com/repos/Azure/SONiC/hooks","issue_events_url":"https://api.github.com/repos/Azure/SONiC/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/SONiC/events","assignees_url":"https://api.github.com/repos/Azure/SONiC/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/SONiC/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/SONiC/tags","blobs_url":"https://api.github.com/repos/Azure/SONiC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/SONiC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/SONiC/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/SONiC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/SONiC/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/SONiC/languages","stargazers_url":"https://api.github.com/repos/Azure/SONiC/stargazers","contributors_url":"https://api.github.com/repos/Azure/SONiC/contributors","subscribers_url":"https://api.github.com/repos/Azure/SONiC/subscribers","subscription_url":"https://api.github.com/repos/Azure/SONiC/subscription","commits_url":"https://api.github.com/repos/Azure/SONiC/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/SONiC/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/SONiC/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/SONiC/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/SONiC/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/SONiC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/SONiC/merges","archive_url":"https://api.github.com/repos/Azure/SONiC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/SONiC/downloads","issues_url":"https://api.github.com/repos/Azure/SONiC/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/SONiC/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/SONiC/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/SONiC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/SONiC/labels{/name}","releases_url":"https://api.github.com/repos/Azure/SONiC/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/SONiC/deployments","created_at":"2016-02-04T21:55:32Z","updated_at":"2019-09-17T14:01:04Z","pushed_at":"2019-09-17T14:31:40Z","git_url":"git://github.com/Azure/SONiC.git","ssh_url":"[email protected]:Azure/SONiC.git","clone_url":"https://github.com/Azure/SONiC.git","svn_url":"https://github.com/Azure/SONiC","homepage":"","size":71605,"stargazers_count":660,"watchers_count":660,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":302,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":238,"license":null,"forks":302,"open_issues":238,"watchers":660,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/SONiC/pulls/406"},"html":{"href":"https://github.com/Azure/SONiC/pull/406"},"issue":{"href":"https://api.github.com/repos/Azure/SONiC/issues/406"},"comments":{"href":"https://api.github.com/repos/Azure/SONiC/issues/406/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/SONiC/pulls/406/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/SONiC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/SONiC/pulls/406/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/SONiC/statuses/6d59a095d6bb9dcb3ecb18e8dacec0ce44e886ad"}},"author_association":"NONE"}}
|
{
"id": 51108542,
"name": "Azure/SONiC",
"url": "https://api.github.com/repos/Azure/SONiC"
}
|
{
"id": 3300381,
"login": "jleveque",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3300381?",
"url": "https://api.github.com/users/jleveque"
}
|
{
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
}
| 2019-09-18T01:10:18 |
10438204990
|
{"actor":{"display_login":"jleveque"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-sdk/pulls/comments/295386386","pull_request_review_id":251768817,"id":295386386,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NTM4NjM4Ng==","diff_hunk":"@@ -0,0 +1,245 @@\n+# Code Style Guidelines\n+\n+~ Must {#python-zen}\n+adhere to the [Zen of Python](https://www.python.org/dev/peps/pep-0020/)\n+\n+ ```\n+ Beautiful is better than ugly.\n+ Explicit is better than implicit.\n+ Simple is better than complex.\n+ Complex is better than complicated.\n+ Flat is better than nested.\n+ Sparse is better than dense.\n+ Readability counts.\n+ Special cases aren't special enough to break the rules.\n+ Although practicality beats purity.\n+ Errors should never pass silently.\n+ Unless explicitly silenced.\n+ In the face of ambiguity, refuse the temptation to guess.\n+ There should be one-- and preferably only one --obvious way to do it.\n+ Although that way may not be obvious at first unless you're Dutch.\n+ Now is better than never.\n+ Although never is often better than *right* now.\n+ If the implementation is hard to explain, it's a bad idea.\n+ If the implementation is easy to explain, it may be a good idea.\n+ Namespaces are one honking great idea -- let's do more of those!\n+ ```\n+~\n+\n+~ Must {#python-guidelines}\n+follow the general guidelines in [PEP8](https://www.python.org/dev/peps/pep-0008/t) unless explicitly overridden in this document.\n+~\n+\n+~ MustNot {#python-no-borrowing}\n+\"borrow\" coding paradigms from other languages.\n+\n+ *For example, regardless of how common Reactive programming is in the Java community, it is still unfamiliar for most Python developers.*\n+~\n+\n+~ Must {#python-consistency}\n+favor consistency with other Python components over other libraries for the same service\n+\n+ *It is significantly more likely that a developer will use many different libraries using the same languages than that a developer will use the same service from many different languages*\n+~\n+\n+~ Must {#python-use-black}\n+use [Black](https://black.readthedocs.io/en/stable/) to format your code.\n+~\n+\n+## Naming conventions {#python-naming-convention}\n+\n+~ Must {#python-snake-case}\n+use snake_case for variables and method names\n+\n+ ```python\n+ # Yes:\n+ service_client = ServiceClient()\n+\n+ # No:\n+ serviceClient = ServiceClient()\n+ ```\n+~\n+\n+~ Must {#python-pascal-case}\n+use Pascal case for Types\n+\n+ ```python\n+ # Yes:\n+ class ThisIsCorrect(object):\n+ pass\n+\n+\n+ # No:\n+ class this_is_not_correct(object):\n+ pass\n+\n+\n+ # No:\n+ class camelCasedTypeName(object):\n+ pass\n+ ```\n+~\n+\n+## Method signatures\n+\n+~ MustNot\n+use static methods unless absolutely required. Prefer module level functions instead. This is rare and usually forced by other libraries.\n+~\n+\n+~ MustNot\n+use simple getter and setter functions. Use properties instead.\n+\n+```python\n+# Yes\n+class GoodThing(object):\n+\n+ @property\n+ def something(self):\n+ \"\"\" Example of a good read-only property.\"\"\"\n+ return self._something\n+\n+# No\n+class BadThing(object):\n+\n+ def get_something(self):\n+ \"\"\" Example of a bad 'getter' style method.\"\"\"\n+ return self._something\n+```\n+~\n+\n+~ ShouldNot\n+have methods that accept more than five positional parameters. Optional/flag parameters can be accepted using [keyword-only arguments](#python-keyword-args) or `**kwargs`.\n+~\n+\n+~ Must {#python-keyword-args}\n+use keyword-only arguments for optional or less-often-used arguments for modules that only need to support Python 3.\n+\n+ ```python\n+ # Yes\n+ def foo(a, b, *, c, d=None):\n+ # Note that I can even have required keyword-only arguments...\n+ ...\n+ ```\n+~\n+\n+~ Must {#python-parameter-name}\n+specify the parameter name when calling methods with more than two required positional parameters.\n+\n+ ```python\n+ def foo(a, b, c):\n+ pass\n+\n+\n+ def bar(d, e):\n+ pass\n+\n+\n+ # Yes:\n+ foo(a=1, b=2, c=3)\n+ bar(1, 2)\n+ bar(e=3, d=4)\n+\n+ # No:\n+ foo(1, 2, 3)\n+ ```\n+~\n+\n+~ Must {#python-parameter-name}\n+specify the parameter name for optional parameters when calling functions.\n+\n+ ```python\n+ def foo(a, b=1, c=None):\n+ pass\n+\n+\n+ # Yes:\n+ foo(1, b=2, c=3)\n+\n+ # No:\n+ foo(1, 2, 3)\n+ ```\n+~\n+\n+## Public vs \"private\"\n+\n+~ Must {#python-single-underscore}\n+use a single leading underscore to indicate that a name is not part of the public API and is not guaranteed stable.\n+~\n+\n+~ MustNot {#python-no-leading-underscore}\n+use leading double underscore prefixed method names unless name clashes in inheritence hierarchy are likely. This is rare. \n+~\n+\n+~ Must {#python-add-public-methods-to-all}\n+add public methods and types to the module's `__all__` attribute.\n+~\n+\n+## Types (or not)\n+\n+~ Must {#python-structural-subtyping}\n+prefer structural subtyping and protocols over explicit type checks.\n+~\n+\n+~ Must {#python-derive-appropriately}\n+derive from the abstract collections base classes `collections.abc` (or `collections` for Python 2.7) to provide custom mapping types.\n+~\n+\n+~ Must {#python-type-hints}\n+provide type hints [PEP484](https://www.python.org/dev/peps/pep-0484/) wherever you are providing class or function documentation.\n+\n+ - See the [suggested syntax for Python 2.7 and 2.7-3.x straddling code](https://www.python.org/dev/peps/pep-0484/#suggested-syntax-for-python-2-7-and-straddling-code) for guidance for Python 2.7 compatible code.\n+~\n+\n+## Threading\n+\n+~ Must {#python-thread-affinity}\n+maintain thread affinity for user-provided code unless explicitly documented to not do so.\n+~\n+\n+~ Must {#python-thread-safe-document}\n+document any code that is not thread safe as not being thread safe.","path":"docs/design/python/sections/PythonCodingGuidelines.mdk","position":200,"original_position":200,"commit_id":"ea538811e4de767d9af3ed67befa9846245d1130","original_commit_id":"ea538811e4de767d9af3ed67befa9846245d1130","user":{"login":"zooba","id":1693688,"node_id":"MDQ6VXNlcjE2OTM2ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1693688?v=4","gravatar_id":"","url":"https://api.github.com/users/zooba","html_url":"https://github.com/zooba","followers_url":"https://api.github.com/users/zooba/followers","following_url":"https://api.github.com/users/zooba/following{/other_user}","gists_url":"https://api.github.com/users/zooba/gists{/gist_id}","starred_url":"https://api.github.com/users/zooba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zooba/subscriptions","organizations_url":"https://api.github.com/users/zooba/orgs","repos_url":"https://api.github.com/users/zooba/repos","events_url":"https://api.github.com/users/zooba/events{/privacy}","received_events_url":"https://api.github.com/users/zooba/received_events","type":"User","site_admin":false},"body":"While most low-level operations in Python are thread safe (thanks to the GIL, you're not going to corrupt a dict's internal structures), basically everything else is not thread safe. Even `x[0] += 1` suffers the same races as in other languages - the GIL could be released any number of times during this operation, which means another thread could jump in and do the same thing.\r\n\r\nSo documenting code as \"not thread safe\" probably needs a clearer definition. Perhaps \"document any code that is non-obviously not thread safe. For example …\" and hopefully you have examples already (\"a LRO that tracks its state in an object owned by the user\" perhaps)","created_at":"2019-06-19T16:15:49Z","updated_at":"2019-06-19T16:42:50Z","html_url":"https://github.com/Azure/azure-sdk/pull/423#discussion_r295386386","pull_request_url":"https://api.github.com/repos/Azure/azure-sdk/pulls/423","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk/pulls/comments/295386386"},"html":{"href":"https://github.com/Azure/azure-sdk/pull/423#discussion_r295386386"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-sdk/pulls/423"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-sdk/pulls/423","id":288650591,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg4NjUwNTkx","html_url":"https://github.com/Azure/azure-sdk/pull/423","diff_url":"https://github.com/Azure/azure-sdk/pull/423.diff","patch_url":"https://github.com/Azure/azure-sdk/pull/423.patch","issue_url":"https://api.github.com/repos/Azure/azure-sdk/issues/423","number":423,"state":"open","locked":false,"title":"Update Azure Python design guidelines","user":{"login":"johanste","id":15110018,"node_id":"MDQ6VXNlcjE1MTEwMDE4","avatar_url":"https://avatars0.githubusercontent.com/u/15110018?v=4","gravatar_id":"","url":"https://api.github.com/users/johanste","html_url":"https://github.com/johanste","followers_url":"https://api.github.com/users/johanste/followers","following_url":"https://api.github.com/users/johanste/following{/other_user}","gists_url":"https://api.github.com/users/johanste/gists{/gist_id}","starred_url":"https://api.github.com/users/johanste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanste/subscriptions","organizations_url":"https://api.github.com/users/johanste/orgs","repos_url":"https://api.github.com/users/johanste/repos","events_url":"https://api.github.com/users/johanste/events{/privacy}","received_events_url":"https://api.github.com/users/johanste/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-06-16T20:41:35Z","updated_at":"2019-06-19T16:42:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00d0d43a044ba4c1ab374555f7b9a678a81e7015","assignee":null,"assignees":[],"requested_reviewers":[{"login":"annatisch","id":8689453,"node_id":"MDQ6VXNlcjg2ODk0NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/8689453?v=4","gravatar_id":"","url":"https://api.github.com/users/annatisch","html_url":"https://github.com/annatisch","followers_url":"https://api.github.com/users/annatisch/followers","following_url":"https://api.github.com/users/annatisch/following{/other_user}","gists_url":"https://api.github.com/users/annatisch/gists{/gist_id}","starred_url":"https://api.github.com/users/annatisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annatisch/subscriptions","organizations_url":"https://api.github.com/users/annatisch/orgs","repos_url":"https://api.github.com/users/annatisch/repos","events_url":"https://api.github.com/users/annatisch/events{/privacy}","received_events_url":"https://api.github.com/users/annatisch/received_events","type":"User","site_admin":false},{"login":"xiangyan99","id":14350651,"node_id":"MDQ6VXNlcjE0MzUwNjUx","avatar_url":"https://avatars0.githubusercontent.com/u/14350651?v=4","gravatar_id":"","url":"https://api.github.com/users/xiangyan99","html_url":"https://github.com/xiangyan99","followers_url":"https://api.github.com/users/xiangyan99/followers","following_url":"https://api.github.com/users/xiangyan99/following{/other_user}","gists_url":"https://api.github.com/users/xiangyan99/gists{/gist_id}","starred_url":"https://api.github.com/users/xiangyan99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiangyan99/subscriptions","organizations_url":"https://api.github.com/users/xiangyan99/orgs","repos_url":"https://api.github.com/users/xiangyan99/repos","events_url":"https://api.github.com/users/xiangyan99/events{/privacy}","received_events_url":"https://api.github.com/users/xiangyan99/received_events","type":"User","site_admin":false},{"login":"YijunXieMS","id":48257664,"node_id":"MDQ6VXNlcjQ4MjU3NjY0","avatar_url":"https://avatars2.githubusercontent.com/u/48257664?v=4","gravatar_id":"","url":"https://api.github.com/users/YijunXieMS","html_url":"https://github.com/YijunXieMS","followers_url":"https://api.github.com/users/YijunXieMS/followers","following_url":"https://api.github.com/users/YijunXieMS/following{/other_user}","gists_url":"https://api.github.com/users/YijunXieMS/gists{/gist_id}","starred_url":"https://api.github.com/users/YijunXieMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YijunXieMS/subscriptions","organizations_url":"https://api.github.com/users/YijunXieMS/orgs","repos_url":"https://api.github.com/users/YijunXieMS/repos","events_url":"https://api.github.com/users/YijunXieMS/events{/privacy}","received_events_url":"https://api.github.com/users/YijunXieMS/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-sdk/pulls/423/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-sdk/pulls/423/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-sdk/issues/423/comments","statuses_url":"https://api.github.com/repos/Azure/azure-sdk/statuses/ea538811e4de767d9af3ed67befa9846245d1130","head":{"label":"johanste:june","ref":"june","sha":"ea538811e4de767d9af3ed67befa9846245d1130","user":{"login":"johanste","id":15110018,"node_id":"MDQ6VXNlcjE1MTEwMDE4","avatar_url":"https://avatars0.githubusercontent.com/u/15110018?v=4","gravatar_id":"","url":"https://api.github.com/users/johanste","html_url":"https://github.com/johanste","followers_url":"https://api.github.com/users/johanste/followers","following_url":"https://api.github.com/users/johanste/following{/other_user}","gists_url":"https://api.github.com/users/johanste/gists{/gist_id}","starred_url":"https://api.github.com/users/johanste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanste/subscriptions","organizations_url":"https://api.github.com/users/johanste/orgs","repos_url":"https://api.github.com/users/johanste/repos","events_url":"https://api.github.com/users/johanste/events{/privacy}","received_events_url":"https://api.github.com/users/johanste/received_events","type":"User","site_admin":false},"repo":{"id":180439817,"node_id":"MDEwOlJlcG9zaXRvcnkxODA0Mzk4MTc=","name":"azure-sdk","full_name":"johanste/azure-sdk","private":false,"owner":{"login":"johanste","id":15110018,"node_id":"MDQ6VXNlcjE1MTEwMDE4","avatar_url":"https://avatars0.githubusercontent.com/u/15110018?v=4","gravatar_id":"","url":"https://api.github.com/users/johanste","html_url":"https://github.com/johanste","followers_url":"https://api.github.com/users/johanste/followers","following_url":"https://api.github.com/users/johanste/following{/other_user}","gists_url":"https://api.github.com/users/johanste/gists{/gist_id}","starred_url":"https://api.github.com/users/johanste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanste/subscriptions","organizations_url":"https://api.github.com/users/johanste/orgs","repos_url":"https://api.github.com/users/johanste/repos","events_url":"https://api.github.com/users/johanste/events{/privacy}","received_events_url":"https://api.github.com/users/johanste/received_events","type":"User","site_admin":false},"html_url":"https://github.com/johanste/azure-sdk","description":"Azure SDK","fork":true,"url":"https://api.github.com/repos/johanste/azure-sdk","forks_url":"https://api.github.com/repos/johanste/azure-sdk/forks","keys_url":"https://api.github.com/repos/johanste/azure-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johanste/azure-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johanste/azure-sdk/teams","hooks_url":"https://api.github.com/repos/johanste/azure-sdk/hooks","issue_events_url":"https://api.github.com/repos/johanste/azure-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/johanste/azure-sdk/events","assignees_url":"https://api.github.com/repos/johanste/azure-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/johanste/azure-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/johanste/azure-sdk/tags","blobs_url":"https://api.github.com/repos/johanste/azure-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johanste/azure-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johanste/azure-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/johanste/azure-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johanste/azure-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/johanste/azure-sdk/languages","stargazers_url":"https://api.github.com/repos/johanste/azure-sdk/stargazers","contributors_url":"https://api.github.com/repos/johanste/azure-sdk/contributors","subscribers_url":"https://api.github.com/repos/johanste/azure-sdk/subscribers","subscription_url":"https://api.github.com/repos/johanste/azure-sdk/subscription","commits_url":"https://api.github.com/repos/johanste/azure-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/johanste/azure-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/johanste/azure-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/johanste/azure-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/johanste/azure-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/johanste/azure-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johanste/azure-sdk/merges","archive_url":"https://api.github.com/repos/johanste/azure-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johanste/azure-sdk/downloads","issues_url":"https://api.github.com/repos/johanste/azure-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/johanste/azure-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/johanste/azure-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/johanste/azure-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johanste/azure-sdk/labels{/name}","releases_url":"https://api.github.com/repos/johanste/azure-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/johanste/azure-sdk/deployments","created_at":"2019-04-09T19:56:59Z","updated_at":"2019-06-08T23:01:58Z","pushed_at":"2019-06-19T02:17:21Z","git_url":"git://github.com/johanste/azure-sdk.git","ssh_url":"[email protected]:johanste/azure-sdk.git","clone_url":"https://github.com/johanste/azure-sdk.git","svn_url":"https://github.com/johanste/azure-sdk","homepage":null,"size":592,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"f8a71f68c7a00bb8f4620c9cbf4e98abc7858929","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":152122018,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIxMjIwMTg=","name":"azure-sdk","full_name":"Azure/azure-sdk","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-sdk","description":"Azure SDK","fork":false,"url":"https://api.github.com/repos/Azure/azure-sdk","forks_url":"https://api.github.com/repos/Azure/azure-sdk/forks","keys_url":"https://api.github.com/repos/Azure/azure-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-sdk/teams","hooks_url":"https://api.github.com/repos/Azure/azure-sdk/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-sdk/events","assignees_url":"https://api.github.com/repos/Azure/azure-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-sdk/tags","blobs_url":"https://api.github.com/repos/Azure/azure-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-sdk/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-sdk/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-sdk/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-sdk/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-sdk/subscription","commits_url":"https://api.github.com/repos/Azure/azure-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-sdk/merges","archive_url":"https://api.github.com/repos/Azure/azure-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-sdk/downloads","issues_url":"https://api.github.com/repos/Azure/azure-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-sdk/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-sdk/deployments","created_at":"2018-10-08T17:49:19Z","updated_at":"2019-06-18T15:37:10Z","pushed_at":"2019-06-19T02:17:22Z","git_url":"git://github.com/Azure/azure-sdk.git","ssh_url":"[email protected]:Azure/azure-sdk.git","clone_url":"https://github.com/Azure/azure-sdk.git","svn_url":"https://github.com/Azure/azure-sdk","homepage":null,"size":636,"stargazers_count":19,"watchers_count":19,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":117,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":31,"open_issues":117,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk/pulls/423"},"html":{"href":"https://github.com/Azure/azure-sdk/pull/423"},"issue":{"href":"https://api.github.com/repos/Azure/azure-sdk/issues/423"},"comments":{"href":"https://api.github.com/repos/Azure/azure-sdk/issues/423/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-sdk/pulls/423/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-sdk/pulls/423/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-sdk/statuses/ea538811e4de767d9af3ed67befa9846245d1130"}},"author_association":"MEMBER"}}
|
{
"id": 152122018,
"name": "Azure/azure-sdk",
"url": "https://api.github.com/repos/Azure/azure-sdk"
}
|
{
"id": 1693688,
"login": "zooba",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1693688?",
"url": "https://api.github.com/users/zooba"
}
|
{
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
}
| 2019-06-19T16:15:49 |
9854382240
|
{"actor":{"display_login":"zooba"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments/293122167","pull_request_review_id":249024018,"id":293122167,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5MzEyMjE2Nw==","diff_hunk":"@@ -82,6 +97,38 @@ void BufferOrch::initBufferReadyList(Table& table)\n }\n }\n \n+void BufferOrch::initFlexCounterGroupTable(void)\n+{\n+ string bufferPoolWmPluginName = \"watermark_bufferpool.lua\";\n+\n+ try\n+ {\n+ string bufferPoolLuaScript = swss::loadLuaScript(bufferPoolWmPluginName);\n+ string bufferPoolWmSha = swss::loadRedisScript(m_countersDb.get(), bufferPoolLuaScript);\n+\n+ vector<FieldValueTuple> fvTuples;\n+ fvTuples.emplace_back(BUFFER_POOL_PLUGIN_FIELD, bufferPoolWmSha);\n+ fvTuples.emplace_back(POLL_INTERVAL_FIELD, BUFFER_POOL_WATERMARK_FLEX_STAT_COUNTER_POLL_MSECS);\n+\n+ string statsMode = STATS_MODE_READ_AND_CLEAR;\n+ // Some platforms do not support buffer pool watermark clear operation\n+ // Need the SAI API support to query the capability\n+ // Before this capability is in place, we feed the platform info into the orchagent\n+ // daemon and check against it\n+ char *device = getenv(\"device\");\n+ if (device && (strstr(device, \"7050\") || strstr(device, \"6000\")))\n+ {\n+ statsMode = STATS_MODE_READ;\n+ }\n+ fvTuples.emplace_back(STATS_MODE_FIELD, statsMode);\n+ m_flexCounterGroupTable->set(BUFFER_POOL_WATERMARK_STAT_COUNTER_FLEX_COUNTER_GROUP, fvTuples);\n+ }\n+ catch (...)","path":"orchagent/bufferorch.cpp","position":null,"original_position":80,"commit_id":"ba9b8e5eb18d978bafd475770c7c3a122e0d9fe5","original_commit_id":"40ef377ed13abcb9c73ffe0aa34f44d7c2e50e96","user":{"login":"qiluo-msft","id":11406616,"node_id":"MDQ6VXNlcjExNDA2NjE2","avatar_url":"https://avatars1.githubusercontent.com/u/11406616?v=4","gravatar_id":"","url":"https://api.github.com/users/qiluo-msft","html_url":"https://github.com/qiluo-msft","followers_url":"https://api.github.com/users/qiluo-msft/followers","following_url":"https://api.github.com/users/qiluo-msft/following{/other_user}","gists_url":"https://api.github.com/users/qiluo-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/qiluo-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qiluo-msft/subscriptions","organizations_url":"https://api.github.com/users/qiluo-msft/orgs","repos_url":"https://api.github.com/users/qiluo-msft/repos","events_url":"https://api.github.com/users/qiluo-msft/events{/privacy}","received_events_url":"https://api.github.com/users/qiluo-msft/received_events","type":"User","site_admin":false},"body":"Still too general, could you be more specific?\r\n\r\n---\r\nIn reply to: [277914027](https://github.com/Azure/sonic-swss/pull/853#discussion_r277914027) [](ancestors = 277914027)","created_at":"2019-06-12T21:18:04Z","updated_at":"2019-06-12T21:18:05Z","html_url":"https://github.com/Azure/sonic-swss/pull/853#discussion_r293122167","pull_request_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/853","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments/293122167"},"html":{"href":"https://github.com/Azure/sonic-swss/pull/853#discussion_r293122167"},"pull_request":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/853"}},"in_reply_to_id":277914027},"pull_request":{"url":"https://api.github.com/repos/Azure/sonic-swss/pulls/853","id":272861591,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcyODYxNTkx","html_url":"https://github.com/Azure/sonic-swss/pull/853","diff_url":"https://github.com/Azure/sonic-swss/pull/853.diff","patch_url":"https://github.com/Azure/sonic-swss/pull/853.patch","issue_url":"https://api.github.com/repos/Azure/sonic-swss/issues/853","number":853,"state":"open","locked":false,"title":"Add buffer pool watermark support","user":{"login":"wendani","id":6498198,"node_id":"MDQ6VXNlcjY0OTgxOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6498198?v=4","gravatar_id":"","url":"https://api.github.com/users/wendani","html_url":"https://github.com/wendani","followers_url":"https://api.github.com/users/wendani/followers","following_url":"https://api.github.com/users/wendani/following{/other_user}","gists_url":"https://api.github.com/users/wendani/gists{/gist_id}","starred_url":"https://api.github.com/users/wendani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wendani/subscriptions","organizations_url":"https://api.github.com/users/wendani/orgs","repos_url":"https://api.github.com/users/wendani/repos","events_url":"https://api.github.com/users/wendani/events{/privacy}","received_events_url":"https://api.github.com/users/wendani/received_events","type":"User","site_admin":false},"body":"1. Write fields to FLEX_COUNTER_GROUP_TABLE at the construction of a BufferOrch object:\r\n \r\n \"POLL_INTERVAL\"\r\n \"BUFFER_POLL_PLUGIN_LIST\"\r\n \"STATS_MODE\"\r\n\r\n2. Update buffer pool name to oid mapping in COUNTERS_DB upon the set and del of its oid\r\n\r\n3. Push buffer pool watermark COUNTER_ID_LIST to FLEX_COUNTER_TABLE\r\n\r\n4. Implement user clear logic to buffer pool watermark\r\n\r\n5. Add periodic clear to buffer pool watermark\r\n\r\n6. Add lua script for watermark_bufferpool\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n<!--\r\nPlease make sure you have read and understood the contribution guildlines:\r\nhttps://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md\r\n\r\n1. Make sure your commit includes a signature generted with `git commit -s`\r\n2. Make sure your commit title follows the correct format: [component]: description\r\n3. Make sure your commit message contains enough details about the change and related tests\r\n4. Make sure your pull request adds related reviewers, asignees, labels\r\n\r\nPlease also provide the following information in this pull request:\r\n-->\r\n\r\n**What I did**\r\n\r\n**Why I did it**\r\n\r\n**How I verified it**\r\nOn brcm dut\r\n**Details if related**\r\nDepend on:\r\nhttps://github.com/Azure/sonic-swss-common/pull/272 Add schema for buffer pool watermark\r\nhttps://github.com/Azure/sonic-buildimage/pull/2818 Feed device info to orchagent process\r\n\r\nAlongside:\r\nhttps://github.com/Azure/sonic-sairedis/pull/451 Add buffer pool stat to flex counter architecture\r\n\r\nDownstream changes:\r\nhttps://github.com/Azure/sonic-utilities/pull/521 Add buffer pool watermark support in watermarkstat and counterpoll\r\n\r\nsyncd rpc support:\r\nhttps://github.com/opencomputeproject/SAI/pull/949","created_at":"2019-04-23T19:26:20Z","updated_at":"2019-06-12T21:18:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1b386e727c433fa77425368e44b812889069e59","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lguohan","id":2293967,"node_id":"MDQ6VXNlcjIyOTM5Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/2293967?v=4","gravatar_id":"","url":"https://api.github.com/users/lguohan","html_url":"https://github.com/lguohan","followers_url":"https://api.github.com/users/lguohan/followers","following_url":"https://api.github.com/users/lguohan/following{/other_user}","gists_url":"https://api.github.com/users/lguohan/gists{/gist_id}","starred_url":"https://api.github.com/users/lguohan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lguohan/subscriptions","organizations_url":"https://api.github.com/users/lguohan/orgs","repos_url":"https://api.github.com/users/lguohan/repos","events_url":"https://api.github.com/users/lguohan/events{/privacy}","received_events_url":"https://api.github.com/users/lguohan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":338891657,"node_id":"MDU6TGFiZWwzMzg4OTE2NTc=","url":"https://api.github.com/repos/Azure/sonic-swss/labels/Enhancement","name":"Enhancement","color":"84b6eb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/853/commits","review_comments_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/853/comments","review_comment_url":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/sonic-swss/issues/853/comments","statuses_url":"https://api.github.com/repos/Azure/sonic-swss/statuses/ba9b8e5eb18d978bafd475770c7c3a122e0d9fe5","head":{"label":"wendani:buf_pool_wm_master","ref":"buf_pool_wm_master","sha":"ba9b8e5eb18d978bafd475770c7c3a122e0d9fe5","user":{"login":"wendani","id":6498198,"node_id":"MDQ6VXNlcjY0OTgxOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6498198?v=4","gravatar_id":"","url":"https://api.github.com/users/wendani","html_url":"https://github.com/wendani","followers_url":"https://api.github.com/users/wendani/followers","following_url":"https://api.github.com/users/wendani/following{/other_user}","gists_url":"https://api.github.com/users/wendani/gists{/gist_id}","starred_url":"https://api.github.com/users/wendani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wendani/subscriptions","organizations_url":"https://api.github.com/users/wendani/orgs","repos_url":"https://api.github.com/users/wendani/repos","events_url":"https://api.github.com/users/wendani/events{/privacy}","received_events_url":"https://api.github.com/users/wendani/received_events","type":"User","site_admin":false},"repo":{"id":119129048,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkxMjkwNDg=","name":"sonic-swss","full_name":"wendani/sonic-swss","private":false,"owner":{"login":"wendani","id":6498198,"node_id":"MDQ6VXNlcjY0OTgxOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6498198?v=4","gravatar_id":"","url":"https://api.github.com/users/wendani","html_url":"https://github.com/wendani","followers_url":"https://api.github.com/users/wendani/followers","following_url":"https://api.github.com/users/wendani/following{/other_user}","gists_url":"https://api.github.com/users/wendani/gists{/gist_id}","starred_url":"https://api.github.com/users/wendani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wendani/subscriptions","organizations_url":"https://api.github.com/users/wendani/orgs","repos_url":"https://api.github.com/users/wendani/repos","events_url":"https://api.github.com/users/wendani/events{/privacy}","received_events_url":"https://api.github.com/users/wendani/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wendani/sonic-swss","description":"SONiC Switch State Service (SwSS)","fork":true,"url":"https://api.github.com/repos/wendani/sonic-swss","forks_url":"https://api.github.com/repos/wendani/sonic-swss/forks","keys_url":"https://api.github.com/repos/wendani/sonic-swss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wendani/sonic-swss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wendani/sonic-swss/teams","hooks_url":"https://api.github.com/repos/wendani/sonic-swss/hooks","issue_events_url":"https://api.github.com/repos/wendani/sonic-swss/issues/events{/number}","events_url":"https://api.github.com/repos/wendani/sonic-swss/events","assignees_url":"https://api.github.com/repos/wendani/sonic-swss/assignees{/user}","branches_url":"https://api.github.com/repos/wendani/sonic-swss/branches{/branch}","tags_url":"https://api.github.com/repos/wendani/sonic-swss/tags","blobs_url":"https://api.github.com/repos/wendani/sonic-swss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wendani/sonic-swss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wendani/sonic-swss/git/refs{/sha}","trees_url":"https://api.github.com/repos/wendani/sonic-swss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wendani/sonic-swss/statuses/{sha}","languages_url":"https://api.github.com/repos/wendani/sonic-swss/languages","stargazers_url":"https://api.github.com/repos/wendani/sonic-swss/stargazers","contributors_url":"https://api.github.com/repos/wendani/sonic-swss/contributors","subscribers_url":"https://api.github.com/repos/wendani/sonic-swss/subscribers","subscription_url":"https://api.github.com/repos/wendani/sonic-swss/subscription","commits_url":"https://api.github.com/repos/wendani/sonic-swss/commits{/sha}","git_commits_url":"https://api.github.com/repos/wendani/sonic-swss/git/commits{/sha}","comments_url":"https://api.github.com/repos/wendani/sonic-swss/comments{/number}","issue_comment_url":"https://api.github.com/repos/wendani/sonic-swss/issues/comments{/number}","contents_url":"https://api.github.com/repos/wendani/sonic-swss/contents/{+path}","compare_url":"https://api.github.com/repos/wendani/sonic-swss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wendani/sonic-swss/merges","archive_url":"https://api.github.com/repos/wendani/sonic-swss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wendani/sonic-swss/downloads","issues_url":"https://api.github.com/repos/wendani/sonic-swss/issues{/number}","pulls_url":"https://api.github.com/repos/wendani/sonic-swss/pulls{/number}","milestones_url":"https://api.github.com/repos/wendani/sonic-swss/milestones{/number}","notifications_url":"https://api.github.com/repos/wendani/sonic-swss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wendani/sonic-swss/labels{/name}","releases_url":"https://api.github.com/repos/wendani/sonic-swss/releases{/id}","deployments_url":"https://api.github.com/repos/wendani/sonic-swss/deployments","created_at":"2018-01-27T03:33:00Z","updated_at":"2018-03-14T16:10:09Z","pushed_at":"2019-06-04T06:32:51Z","git_url":"git://github.com/wendani/sonic-swss.git","ssh_url":"[email protected]:wendani/sonic-swss.git","clone_url":"https://github.com/wendani/sonic-swss.git","svn_url":"https://github.com/wendani/sonic-swss","homepage":"https://azure.github.io/SONiC","size":2690,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"f3d0279a19e48933dbf3c15ec8dc8b9df8cfcf4a","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":53515475,"node_id":"MDEwOlJlcG9zaXRvcnk1MzUxNTQ3NQ==","name":"sonic-swss","full_name":"Azure/sonic-swss","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/sonic-swss","description":"SONiC Switch State Service (SwSS)","fork":false,"url":"https://api.github.com/repos/Azure/sonic-swss","forks_url":"https://api.github.com/repos/Azure/sonic-swss/forks","keys_url":"https://api.github.com/repos/Azure/sonic-swss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/sonic-swss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/sonic-swss/teams","hooks_url":"https://api.github.com/repos/Azure/sonic-swss/hooks","issue_events_url":"https://api.github.com/repos/Azure/sonic-swss/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/sonic-swss/events","assignees_url":"https://api.github.com/repos/Azure/sonic-swss/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/sonic-swss/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/sonic-swss/tags","blobs_url":"https://api.github.com/repos/Azure/sonic-swss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/sonic-swss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/sonic-swss/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/sonic-swss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/sonic-swss/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/sonic-swss/languages","stargazers_url":"https://api.github.com/repos/Azure/sonic-swss/stargazers","contributors_url":"https://api.github.com/repos/Azure/sonic-swss/contributors","subscribers_url":"https://api.github.com/repos/Azure/sonic-swss/subscribers","subscription_url":"https://api.github.com/repos/Azure/sonic-swss/subscription","commits_url":"https://api.github.com/repos/Azure/sonic-swss/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/sonic-swss/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/sonic-swss/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/sonic-swss/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/sonic-swss/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/sonic-swss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/sonic-swss/merges","archive_url":"https://api.github.com/repos/Azure/sonic-swss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/sonic-swss/downloads","issues_url":"https://api.github.com/repos/Azure/sonic-swss/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/sonic-swss/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/sonic-swss/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/sonic-swss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/sonic-swss/labels{/name}","releases_url":"https://api.github.com/repos/Azure/sonic-swss/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/sonic-swss/deployments","created_at":"2016-03-09T17:01:09Z","updated_at":"2019-06-11T22:37:37Z","pushed_at":"2019-06-12T19:06:55Z","git_url":"git://github.com/Azure/sonic-swss.git","ssh_url":"[email protected]:Azure/sonic-swss.git","clone_url":"https://github.com/Azure/sonic-swss.git","svn_url":"https://github.com/Azure/sonic-swss","homepage":"https://azure.github.io/SONiC","size":2708,"stargazers_count":45,"watchers_count":45,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":129,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":130,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":129,"open_issues":130,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/853"},"html":{"href":"https://github.com/Azure/sonic-swss/pull/853"},"issue":{"href":"https://api.github.com/repos/Azure/sonic-swss/issues/853"},"comments":{"href":"https://api.github.com/repos/Azure/sonic-swss/issues/853/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/853/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/sonic-swss/pulls/853/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/sonic-swss/statuses/ba9b8e5eb18d978bafd475770c7c3a122e0d9fe5"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 53515475,
"name": "Azure/sonic-swss",
"url": "https://api.github.com/repos/Azure/sonic-swss"
}
|
{
"id": 11406616,
"login": "qiluo-msft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11406616?",
"url": "https://api.github.com/users/qiluo-msft"
}
|
{
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
}
| 2019-06-12T21:18:04 |
9810757385
|
{"actor":{"display_login":"qiluo-msft"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/pulls/comments/302268054","pull_request_review_id":260351700,"id":302268054,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMjI2ODA1NA==","diff_hunk":"@@ -0,0 +1,110 @@\n+# --------------------------------------------------------------------------\n+# Copyright (c) Microsoft Corporation. All rights reserved.\n+# Licensed under the MIT License. See License.txt in the project root for\n+# license information.\n+# --------------------------------------------------------------------------\n+from . import errors\n+from . import errors_paho\n+import paho.mqtt.client as mqtt\n+\n+# mapping of Paho conack rc codes to Error object classes\n+paho_conack_rc_to_error = {\n+ mqtt.CONNACK_REFUSED_PROTOCOL_VERSION: errors_paho.PahoConnectionRefusedProtocolVersionError,\n+ mqtt.CONNACK_REFUSED_IDENTIFIER_REJECTED: errors_paho.PahoConnectionRefusedIdentifierRejectedError,\n+ mqtt.CONNACK_REFUSED_SERVER_UNAVAILABLE: errors_paho.PahoConnectionRefusedServerUnavailableError,\n+ mqtt.CONNACK_REFUSED_BAD_USERNAME_PASSWORD: errors_paho.PahoConnectionRefusedBadUsernamePasswordError,\n+ mqtt.CONNACK_REFUSED_NOT_AUTHORIZED: errors_paho.PahoConnectionRefusedNotAuthorizedError,\n+}\n+\n+# mapping of Paho rc codes to Error object classes\n+paho_rc_to_error = {\n+ mqtt.MQTT_ERR_NOMEM: errors_paho.PahoNoMemoryError,\n+ mqtt.MQTT_ERR_PROTOCOL: errors_paho.PahoProtocolError,\n+ mqtt.MQTT_ERR_INVAL: errors_paho.PahoInvalidArgsError,\n+ mqtt.MQTT_ERR_NO_CONN: errors_paho.PahoNoConnectionError,\n+ mqtt.MQTT_ERR_CONN_REFUSED: errors_paho.PahoConnectionRefusedError,\n+ mqtt.MQTT_ERR_NOT_FOUND: errors_paho.PahoNotFoundError,\n+ mqtt.MQTT_ERR_CONN_LOST: errors_paho.PahoConnectionLostError,\n+ mqtt.MQTT_ERR_TLS: errors_paho.PahoTLSError,\n+ mqtt.MQTT_ERR_PAYLOAD_SIZE: errors_paho.PahoPayloadSizeError,\n+ mqtt.MQTT_ERR_NOT_SUPPORTED: errors_paho.PahoNotSupportedError,\n+ mqtt.MQTT_ERR_AUTH: errors_paho.PahoAuthError,\n+ mqtt.MQTT_ERR_ACL_DENIED: errors_paho.PahoACLDeniedError,\n+ mqtt.MQTT_ERR_UNKNOWN: errors_paho.PahoUnknownError,\n+ mqtt.MQTT_ERR_ERRNO: errors_paho.PahoUnknownError,\n+ mqtt.MQTT_ERR_QUEUE_SIZE: errors_paho.PahoQueueSizeError,\n+}\n+\n+# mapping of Paho-specific errors to more generic errors\n+paho_error_to_generic_error = {\n+ errors_paho.PahoConnectionRefusedProtocolVersionError: errors.TransportError,\n+ errors_paho.PahoConnectionRefusedIdentifierRejectedError: errors.TransportError,\n+ errors_paho.PahoConnectionRefusedServerUnavailableError: errors.ConnectionFailedError,\n+ errors_paho.PahoConnectionRefusedBadUsernamePasswordError: errors.UnauthorizedError,\n+ errors_paho.PahoConnectionRefusedNotAuthorizedError: errors.UnauthorizedError,\n+ errors_paho.PahoNoMemoryError: errors.TransportError,\n+ errors_paho.PahoProtocolError: errors.TransportError,\n+ errors_paho.PahoInvalidArgsError: errors.TransportError,\n+ errors_paho.PahoNoConnectionError: errors.ConnectionDroppedError,\n+ errors_paho.PahoConnectionRefusedError: errors.UnauthorizedError,\n+ errors_paho.PahoNotFoundError: errors.TransportError,\n+ errors_paho.PahoConnectionLostError: errors.ConnectionDroppedError,\n+ errors_paho.PahoTLSError: errors.UnauthorizedError,\n+ errors_paho.PahoPayloadSizeError: errors.TransportError,\n+ errors_paho.PahoNotSupportedError: errors.TransportError,\n+ errors_paho.PahoAuthError: errors.UnauthorizedError,\n+ errors_paho.PahoACLDeniedError: errors.UnauthorizedError,\n+ errors_paho.PahoUnknownError: errors.TransportError,\n+ errors_paho.PahoQueueSizeError: errors.TransportError,\n+}\n+\n+\n+def _wrap_paho_error_in_generic_error(paho_error):","path":"azure-iot-device/azure/iot/device/common/error_map_paho.py","position":62,"original_position":62,"commit_id":"6d4676fa5a8474f738aa63538ab97191dd4d9959","original_commit_id":"6d4676fa5a8474f738aa63538ab97191dd4d9959","user":{"login":"BertKleewein","id":8028738,"node_id":"MDQ6VXNlcjgwMjg3Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/8028738?v=4","gravatar_id":"","url":"https://api.github.com/users/BertKleewein","html_url":"https://github.com/BertKleewein","followers_url":"https://api.github.com/users/BertKleewein/followers","following_url":"https://api.github.com/users/BertKleewein/following{/other_user}","gists_url":"https://api.github.com/users/BertKleewein/gists{/gist_id}","starred_url":"https://api.github.com/users/BertKleewein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BertKleewein/subscriptions","organizations_url":"https://api.github.com/users/BertKleewein/orgs","repos_url":"https://api.github.com/users/BertKleewein/repos","events_url":"https://api.github.com/users/BertKleewein/events{/privacy}","received_events_url":"https://api.github.com/users/BertKleewein/received_events","type":"User","site_admin":false},"body":">_wrap_paho_error_in_generic_error [](start = 4, length = 33)\r\n\r\nopen issue: I'd like feedback on this idea. I think it makes sense. For Paho errors, I convert the paho error code into a paho-specific error object (from errors_paho.py), and then I wrap that paho error inside a more generic error (from errors.py). This way, the user gets a generic error, but they have the paho-specific details if they want them. ","created_at":"2019-07-10T20:55:42Z","updated_at":"2019-07-10T20:55:42Z","html_url":"https://github.com/Azure/azure-iot-sdk-python-preview/pull/136#discussion_r302268054","pull_request_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/pulls/136","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/pulls/comments/302268054"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-python-preview/pull/136#discussion_r302268054"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/pulls/136"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/pulls/136","id":296339636,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk2MzM5NjM2","html_url":"https://github.com/Azure/azure-iot-sdk-python-preview/pull/136","diff_url":"https://github.com/Azure/azure-iot-sdk-python-preview/pull/136.diff","patch_url":"https://github.com/Azure/azure-iot-sdk-python-preview/pull/136.patch","issue_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/issues/136","number":136,"state":"open","locked":false,"title":"return errors from paho","user":{"login":"BertKleewein","id":8028738,"node_id":"MDQ6VXNlcjgwMjg3Mzg=","avatar_url":"https://avatars0.githubusercontent.com/u/8028738?v=4","gravatar_id":"","url":"https://api.github.com/users/BertKleewein","html_url":"https://github.com/BertKleewein","followers_url":"https://api.github.com/users/BertKleewein/followers","following_url":"https://api.github.com/users/BertKleewein/following{/other_user}","gists_url":"https://api.github.com/users/BertKleewein/gists{/gist_id}","starred_url":"https://api.github.com/users/BertKleewein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BertKleewein/subscriptions","organizations_url":"https://api.github.com/users/BertKleewein/orgs","repos_url":"https://api.github.com/users/BertKleewein/repos","events_url":"https://api.github.com/users/BertKleewein/events{/privacy}","received_events_url":"https://api.github.com/users/BertKleewein/received_events","type":"User","site_admin":false},"body":"This is not done, but I wanted to get feedback on the general organization. Specific questions are added as comments. ","created_at":"2019-07-10T20:50:06Z","updated_at":"2019-07-10T20:55:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55397a2cb6e89e1691f129d5fd062cf94a32428a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cartertinney","id":3613133,"node_id":"MDQ6VXNlcjM2MTMxMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/3613133?v=4","gravatar_id":"","url":"https://api.github.com/users/cartertinney","html_url":"https://github.com/cartertinney","followers_url":"https://api.github.com/users/cartertinney/followers","following_url":"https://api.github.com/users/cartertinney/following{/other_user}","gists_url":"https://api.github.com/users/cartertinney/gists{/gist_id}","starred_url":"https://api.github.com/users/cartertinney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cartertinney/subscriptions","organizations_url":"https://api.github.com/users/cartertinney/orgs","repos_url":"https://api.github.com/users/cartertinney/repos","events_url":"https://api.github.com/users/cartertinney/events{/privacy}","received_events_url":"https://api.github.com/users/cartertinney/received_events","type":"User","site_admin":false},{"login":"olivakar","id":5783914,"node_id":"MDQ6VXNlcjU3ODM5MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5783914?v=4","gravatar_id":"","url":"https://api.github.com/users/olivakar","html_url":"https://github.com/olivakar","followers_url":"https://api.github.com/users/olivakar/followers","following_url":"https://api.github.com/users/olivakar/following{/other_user}","gists_url":"https://api.github.com/users/olivakar/gists{/gist_id}","starred_url":"https://api.github.com/users/olivakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivakar/subscriptions","organizations_url":"https://api.github.com/users/olivakar/orgs","repos_url":"https://api.github.com/users/olivakar/repos","events_url":"https://api.github.com/users/olivakar/events{/privacy}","received_events_url":"https://api.github.com/users/olivakar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/pulls/136/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/pulls/136/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/issues/136/comments","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/statuses/6d4676fa5a8474f738aa63538ab97191dd4d9959","head":{"label":"Azure:bertk-paho-errors","ref":"bertk-paho-errors","sha":"6d4676fa5a8474f738aa63538ab97191dd4d9959","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":148676866,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg2NzY4NjY=","name":"azure-iot-sdk-python-preview","full_name":"Azure/azure-iot-sdk-python-preview","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-iot-sdk-python-preview","description":"Azure IoT SDK for Python - v2.0.0 Preview","fork":false,"url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview","forks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/forks","keys_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/teams","hooks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/events","assignees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/tags","blobs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/subscription","commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/merges","archive_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/downloads","issues_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/deployments","created_at":"2018-09-13T17:57:54Z","updated_at":"2019-07-09T17:40:09Z","pushed_at":"2019-07-10T20:51:59Z","git_url":"git://github.com/Azure/azure-iot-sdk-python-preview.git","ssh_url":"[email protected]:Azure/azure-iot-sdk-python-preview.git","clone_url":"https://github.com/Azure/azure-iot-sdk-python-preview.git","svn_url":"https://github.com/Azure/azure-iot-sdk-python-preview","homepage":null,"size":1155,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":9,"watchers":14,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"63e305eb467163bb05fcc5ab6adc376e8d0f8b12","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":148676866,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg2NzY4NjY=","name":"azure-iot-sdk-python-preview","full_name":"Azure/azure-iot-sdk-python-preview","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-iot-sdk-python-preview","description":"Azure IoT SDK for Python - v2.0.0 Preview","fork":false,"url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview","forks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/forks","keys_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/teams","hooks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/events","assignees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/tags","blobs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/subscription","commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/merges","archive_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/downloads","issues_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/deployments","created_at":"2018-09-13T17:57:54Z","updated_at":"2019-07-09T17:40:09Z","pushed_at":"2019-07-10T20:51:59Z","git_url":"git://github.com/Azure/azure-iot-sdk-python-preview.git","ssh_url":"[email protected]:Azure/azure-iot-sdk-python-preview.git","clone_url":"https://github.com/Azure/azure-iot-sdk-python-preview.git","svn_url":"https://github.com/Azure/azure-iot-sdk-python-preview","homepage":null,"size":1155,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":9,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/pulls/136"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-python-preview/pull/136"},"issue":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/issues/136"},"comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-python-preview/statuses/6d4676fa5a8474f738aa63538ab97191dd4d9959"}},"author_association":"MEMBER"}}
|
{
"id": 148676866,
"name": "Azure/azure-iot-sdk-python-preview",
"url": "https://api.github.com/repos/Azure/azure-iot-sdk-python-preview"
}
|
{
"id": 8028738,
"login": "BertKleewein",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8028738?",
"url": "https://api.github.com/users/BertKleewein"
}
|
{
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
}
| 2019-07-10T20:55:42 |
9987138851
|
{"actor":{"display_login":"BertKleewein"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/pulls/comments/345504595","pull_request_review_id":315919033,"id":345504595,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NTUwNDU5NQ==","diff_hunk":"@@ -366,7 +366,7 @@ if (${use_prov_client_core})\n set(CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} -DUSE_PROV_MODULE\")\n set(CMAKE_C_FLAGS \"${CMAKE_C_FLAGS} -DUSE_PROV_MODULE\")\n \n- if (${build_provisioning_service_client} AND ${use_prov_client})\n+ if ((${build_provisioning_service_client} AND ${use_prov_client}) OR ${run_e2e_tests})","path":"CMakeLists.txt","position":5,"original_position":5,"commit_id":"c51232951b66029ccefe3a36755fc6582b7c3ed4","original_commit_id":"c51232951b66029ccefe3a36755fc6582b7c3ed4","user":{"login":"jebrando","id":8583083,"node_id":"MDQ6VXNlcjg1ODMwODM=","avatar_url":"https://avatars0.githubusercontent.com/u/8583083?v=4","gravatar_id":"","url":"https://api.github.com/users/jebrando","html_url":"https://github.com/jebrando","followers_url":"https://api.github.com/users/jebrando/followers","following_url":"https://api.github.com/users/jebrando/following{/other_user}","gists_url":"https://api.github.com/users/jebrando/gists{/gist_id}","starred_url":"https://api.github.com/users/jebrando/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jebrando/subscriptions","organizations_url":"https://api.github.com/users/jebrando/orgs","repos_url":"https://api.github.com/users/jebrando/repos","events_url":"https://api.github.com/users/jebrando/events{/privacy}","received_events_url":"https://api.github.com/users/jebrando/received_events","type":"User","site_admin":false},"body":"> OR ${run_e2e_tests} [](start = 69, length = 20)\r\n\r\nThis is interesting logic here. So if you don't have e2e test you you won't have provisioning service client. I like the idea, but I'm not sure if others will go with it. I just want to make sure you meant to have that.","created_at":"2019-11-12T23:41:58Z","updated_at":"2019-11-12T23:41:58Z","html_url":"https://github.com/Azure/azure-iot-sdk-c/pull/1307#discussion_r345504595","pull_request_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/pulls/1307","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-c/pulls/comments/345504595"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-c/pull/1307#discussion_r345504595"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-c/pulls/1307"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/pulls/1307","id":339798562,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM5Nzk4NTYy","html_url":"https://github.com/Azure/azure-iot-sdk-c/pull/1307","diff_url":"https://github.com/Azure/azure-iot-sdk-c/pull/1307.diff","patch_url":"https://github.com/Azure/azure-iot-sdk-c/pull/1307.patch","issue_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/issues/1307","number":1307,"state":"open","locked":false,"title":"Option build fix","user":{"login":"jasmineymlo","id":19498625,"node_id":"MDQ6VXNlcjE5NDk4NjI1","avatar_url":"https://avatars3.githubusercontent.com/u/19498625?v=4","gravatar_id":"","url":"https://api.github.com/users/jasmineymlo","html_url":"https://github.com/jasmineymlo","followers_url":"https://api.github.com/users/jasmineymlo/followers","following_url":"https://api.github.com/users/jasmineymlo/following{/other_user}","gists_url":"https://api.github.com/users/jasmineymlo/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmineymlo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmineymlo/subscriptions","organizations_url":"https://api.github.com/users/jasmineymlo/orgs","repos_url":"https://api.github.com/users/jasmineymlo/repos","events_url":"https://api.github.com/users/jasmineymlo/events{/privacy}","received_events_url":"https://api.github.com/users/jasmineymlo/received_events","type":"User","site_admin":false},"body":"- fix command in .sh to build with options array.\r\n- fix \"-Drun_e2e_tests=ON -Drun_sfc_tests=ON -Duse_edge_modules=ON\" build.\r\n- fix build with options for various hsm types.","created_at":"2019-11-12T09:03:56Z","updated_at":"2019-11-12T23:41:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85ef0671dcb23b3d656ac8eb9d7ea2f629ff0640","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jspaith","id":27444433,"node_id":"MDQ6VXNlcjI3NDQ0NDMz","avatar_url":"https://avatars1.githubusercontent.com/u/27444433?v=4","gravatar_id":"","url":"https://api.github.com/users/jspaith","html_url":"https://github.com/jspaith","followers_url":"https://api.github.com/users/jspaith/followers","following_url":"https://api.github.com/users/jspaith/following{/other_user}","gists_url":"https://api.github.com/users/jspaith/gists{/gist_id}","starred_url":"https://api.github.com/users/jspaith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspaith/subscriptions","organizations_url":"https://api.github.com/users/jspaith/orgs","repos_url":"https://api.github.com/users/jspaith/repos","events_url":"https://api.github.com/users/jspaith/events{/privacy}","received_events_url":"https://api.github.com/users/jspaith/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/pulls/1307/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/pulls/1307/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/issues/1307/comments","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/statuses/c51232951b66029ccefe3a36755fc6582b7c3ed4","head":{"label":"Azure:option_build_fix","ref":"option_build_fix","sha":"c51232951b66029ccefe3a36755fc6582b7c3ed4","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":70934373,"node_id":"MDEwOlJlcG9zaXRvcnk3MDkzNDM3Mw==","name":"azure-iot-sdk-c","full_name":"Azure/azure-iot-sdk-c","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-iot-sdk-c","description":"A C99 SDK for connecting devices to Microsoft Azure IoT services","fork":false,"url":"https://api.github.com/repos/Azure/azure-iot-sdk-c","forks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/forks","keys_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/teams","hooks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/events","assignees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/tags","blobs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/subscription","commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/merges","archive_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/downloads","issues_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/deployments","created_at":"2016-10-14T17:54:57Z","updated_at":"2019-11-12T17:51:29Z","pushed_at":"2019-11-12T18:08:15Z","git_url":"git://github.com/Azure/azure-iot-sdk-c.git","ssh_url":"[email protected]:Azure/azure-iot-sdk-c.git","clone_url":"https://github.com/Azure/azure-iot-sdk-c.git","svn_url":"https://github.com/Azure/azure-iot-sdk-c","homepage":null,"size":56127,"stargazers_count":310,"watchers_count":310,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":415,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":75,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":415,"open_issues":75,"watchers":310,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"241b66eb6499e2c019682f252d911ef2b28d1302","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":70934373,"node_id":"MDEwOlJlcG9zaXRvcnk3MDkzNDM3Mw==","name":"azure-iot-sdk-c","full_name":"Azure/azure-iot-sdk-c","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-iot-sdk-c","description":"A C99 SDK for connecting devices to Microsoft Azure IoT services","fork":false,"url":"https://api.github.com/repos/Azure/azure-iot-sdk-c","forks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/forks","keys_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/teams","hooks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/events","assignees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/tags","blobs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/subscription","commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/merges","archive_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/downloads","issues_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-c/deployments","created_at":"2016-10-14T17:54:57Z","updated_at":"2019-11-12T17:51:29Z","pushed_at":"2019-11-12T18:08:15Z","git_url":"git://github.com/Azure/azure-iot-sdk-c.git","ssh_url":"[email protected]:Azure/azure-iot-sdk-c.git","clone_url":"https://github.com/Azure/azure-iot-sdk-c.git","svn_url":"https://github.com/Azure/azure-iot-sdk-c","homepage":null,"size":56127,"stargazers_count":310,"watchers_count":310,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":415,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":75,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":415,"open_issues":75,"watchers":310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-c/pulls/1307"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-c/pull/1307"},"issue":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-c/issues/1307"},"comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-c/issues/1307/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-c/pulls/1307/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-c/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-c/pulls/1307/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-c/statuses/c51232951b66029ccefe3a36755fc6582b7c3ed4"}},"author_association":"COLLABORATOR"}}
|
{
"id": 70934373,
"name": "Azure/azure-iot-sdk-c",
"url": "https://api.github.com/repos/Azure/azure-iot-sdk-c"
}
|
{
"id": 8583083,
"login": "jebrando",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8583083?",
"url": "https://api.github.com/users/jebrando"
}
|
{
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
}
| 2019-11-12T23:41:58 |
10847761173
|
{"actor":{"display_login":"jebrando"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/pulls/comments/347660730","pull_request_review_id":318695203,"id":347660730,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NzY2MDczMA==","diff_hunk":"@@ -0,0 +1,692 @@\n+// Copyright (c) Microsoft. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+\n+// This will only be defined if the library has been included in the IDE\n+#include <Ethernet2.h>\n+#include <Dns.h>\n+#include <EthernetClient.h>\n+#include <errno.h>\n+\n+#include \"azure_c_shared_utility/singlylinkedlist.h\"\n+#include \"azure_c_shared_utility/gballoc.h\"\n+#include \"azure_c_shared_utility/optimize_size.h\"\n+#include \"azure_c_shared_utility/optionhandler.h\"\n+#include \"azure_c_shared_utility/shared_util_options.h\"\n+#include \"azure_c_shared_utility/xlogging.h\"\n+#include \"azure_c_shared_utility/const_defines.h\"\n+#include \"azure_c_shared_utility/xio.h\"\n+#include \"azure_c_shared_utility/socketio.h\"\n+\n+// connect timeout in seconds\n+//#define CONNECT_TIMEOUT 10\n+\n+typedef enum IO_STATE_TAG\n+{\n+ IO_STATE_CLOSED,\n+ IO_STATE_OPENING,\n+ IO_STATE_OPEN,\n+ IO_STATE_CLOSING,\n+ IO_STATE_ERROR\n+} IO_STATE;\n+\n+typedef struct PENDING_SOCKET_IO_TAG\n+{\n+ unsigned char* bytes;\n+ size_t size;\n+ ON_SEND_COMPLETE on_send_complete;\n+ void* callback_context;\n+ SINGLYLINKEDLIST_HANDLE pending_io_list;\n+} PENDING_SOCKET_IO;\n+\n+typedef struct SOCKET_IO_INSTANCE_TAG\n+{\n+ EthernetClient *socket;\n+ ON_BYTES_RECEIVED on_bytes_received;\n+ ON_IO_ERROR on_io_error;\n+ void* on_bytes_received_context;\n+ void* on_io_error_context;\n+ char* hostname;\n+ int port;\n+ char* target_mac_address;\n+ IO_STATE io_state;\n+ SINGLYLINKEDLIST_HANDLE pending_io_list;\n+ unsigned char recv_bytes[RECEIVE_BYTES_VALUE];\n+} SOCKET_IO_INSTANCE;\n+\n+typedef struct NETWORK_INTERFACE_DESCRIPTION_TAG\n+{\n+ char* name;\n+ char* mac_address;\n+ char* ip_address;\n+ struct NETWORK_INTERFACE_DESCRIPTION_TAG* next;\n+} NETWORK_INTERFACE_DESCRIPTION;\n+\n+/*this function will clone an option given by name and value*/\n+static void* socketio_CloneOption(const char* name, const void* value)\n+{\n+ void* result;\n+\n+ LogError(\"Cannot clone option %s (not supported)\", name);\n+ result = NULL;\n+\n+ return result;\n+}\n+\n+/*this function destroys an option previously created*/\n+static void socketio_DestroyOption(const char* name, const void* value)\n+{\n+}\n+\n+static OPTIONHANDLER_HANDLE socketio_retrieveoptions(CONCRETE_IO_HANDLE handle)\n+{\n+ OPTIONHANDLER_HANDLE result;\n+\n+ if (handle == NULL)\n+ {\n+ LogError(\"failed retrieving options (handle is NULL)\");\n+ result = NULL;\n+ }\n+ else\n+ {\n+ SOCKET_IO_INSTANCE* socket_io_instance = (SOCKET_IO_INSTANCE*)handle;\n+\n+ result = OptionHandler_Create(socketio_CloneOption, socketio_DestroyOption, socketio_setoption);\n+ if (result == NULL)\n+ {\n+ LogError(\"unable to OptionHandler_Create\");\n+ }\n+ else if (socket_io_instance->target_mac_address != NULL &&\n+ OptionHandler_AddOption(result, OPTION_NET_INT_MAC_ADDRESS, socket_io_instance->target_mac_address) != OPTIONHANDLER_OK)\n+ {\n+ LogError(\"failed retrieving options (failed adding net_interface_mac_address)\");\n+ OptionHandler_Destroy(result);\n+ result = NULL;\n+ }\n+ }\n+\n+ return result;\n+}\n+\n+static const IO_INTERFACE_DESCRIPTION socket_io_interface_description =\n+{\n+ socketio_retrieveoptions,\n+ socketio_create,\n+ socketio_destroy,\n+ socketio_open,\n+ socketio_close,\n+ socketio_send,\n+ socketio_dowork,\n+ socketio_setoption\n+};\n+\n+static void indicate_error(SOCKET_IO_INSTANCE* socket_io_instance)\n+{\n+ socket_io_instance->io_state = IO_STATE_ERROR;\n+ if (socket_io_instance->on_io_error != NULL)\n+ {\n+ socket_io_instance->on_io_error(socket_io_instance->on_io_error_context);\n+ }\n+}\n+\n+static int add_pending_io(SOCKET_IO_INSTANCE* socket_io_instance, const unsigned char* buffer, size_t size, ON_SEND_COMPLETE on_send_complete, void* callback_context)\n+{\n+ int result;\n+ PENDING_SOCKET_IO* pending_socket_io = (PENDING_SOCKET_IO*)malloc(sizeof(PENDING_SOCKET_IO));\n+ if (pending_socket_io == NULL)\n+ {\n+ result = __FAILURE__;\n+ }\n+ else\n+ {\n+ pending_socket_io->bytes = (unsigned char*)malloc(size);\n+ if (pending_socket_io->bytes == NULL)\n+ {\n+ LogError(\"Allocation Failure: Unable to allocate pending list.\");\n+ free(pending_socket_io);\n+ result = __FAILURE__;\n+ }\n+ else\n+ {\n+ pending_socket_io->size = size;\n+ pending_socket_io->on_send_complete = on_send_complete;\n+ pending_socket_io->callback_context = callback_context;\n+ pending_socket_io->pending_io_list = socket_io_instance->pending_io_list;\n+ (void)memcpy(pending_socket_io->bytes, buffer, size);\n+\n+ if (singlylinkedlist_add(socket_io_instance->pending_io_list, pending_socket_io) == NULL)\n+ {\n+ LogError(\"Failure: Unable to add socket to pending list.\");\n+ free(pending_socket_io->bytes);\n+ free(pending_socket_io);\n+ result = __FAILURE__;\n+ }\n+ else\n+ {\n+ result = 0;\n+ }\n+ }\n+ }\n+ return result;\n+}\n+/*\n+static int lookup_address_and_initiate_socket_connection(SOCKET_IO_INSTANCE* socket_io_instance)\n+{\n+ int result;\n+ int err;\n+\n+ struct addrinfo addrInfoHintIp;\n+ struct sockaddr_un addrInfoUn;\n+ struct sockaddr* connect_addr = NULL;\n+ socklen_t connect_addr_len;\n+ struct addrinfo* addrInfoIp = NULL;\n+\n+ if (socket_io_instance->address_type == ADDRESS_TYPE_IP)\n+ {\n+ char portString[16];\n+\n+ memset(&addrInfoHintIp, 0, sizeof(addrInfoHintIp));\n+ addrInfoHintIp.ai_family = AF_INET;\n+ addrInfoHintIp.ai_socktype = SOCK_STREAM;\n+\n+ sprintf(portString, \"%u\", socket_io_instance->port);\n+ err = getaddrinfo(socket_io_instance->hostname, portString, &addrInfoHintIp, &addrInfoIp);\n+ if (err != 0)\n+ {\n+ LogError(\"Failure: getaddrinfo failure %d.\", err);\n+ result = __FAILURE__;\n+ }\n+ else\n+ {\n+ connect_addr = addrInfoIp->ai_addr;\n+ connect_addr_len = sizeof(*addrInfoIp->ai_addr);\n+ result = 0;\n+ }\n+ }\n+ else\n+ {\n+ size_t hostname_len = strlen(socket_io_instance->hostname);\n+ if (hostname_len + 1 > sizeof(addrInfoUn.sun_path))\n+ {\n+ LogError(\"Hostname %s is too long for a unix socket (max len = %zu)\", socket_io_instance->hostname, sizeof(addrInfoUn.sun_path));\n+ result = __FAILURE__;\n+ }\n+ else\n+ {\n+ memset(&addrInfoUn, 0, sizeof(addrInfoUn));\n+ addrInfoUn.sun_family = AF_UNIX;\n+ // No need to add NULL terminator due to the above memset\n+ (void)memcpy(addrInfoUn.sun_path, socket_io_instance->hostname, hostname_len);\n+\n+ connect_addr = (struct sockaddr*)&addrInfoUn;\n+ connect_addr_len = sizeof(addrInfoUn);\n+ result = 0;\n+ }\n+ }\n+\n+ if (result == 0)\n+ {\n+ int flags;\n+\n+ if ((-1 == (flags = fcntl(socket_io_instance->socket, F_GETFL, 0))) ||\n+ (fcntl(socket_io_instance->socket, F_SETFL, flags | O_NONBLOCK) == -1))\n+ {\n+ LogError(\"Failure: fcntl failure.\");\n+ result = __FAILURE__;\n+ }\n+ else\n+ {\n+ err = connect(socket_io_instance->socket, connect_addr, connect_addr_len);\n+ if ((err != 0) && (errno != EINPROGRESS))\n+ {\n+ LogError(\"Failure: connect failure %d.\", errno);\n+ result = __FAILURE__;\n+ }\n+ }\n+ }\n+\n+ if (addrInfoIp != NULL)\n+ {\n+ freeaddrinfo(addrInfoIp);\n+ }\n+\n+ return result;\n+}\n+*/\n+/*\n+static int wait_for_connection(SOCKET_IO_INSTANCE* socket_io_instance)\n+{\n+ int result;\n+ int err;\n+ int retval;\n+ int select_errno = 0;\n+\n+ fd_set fdset;\n+ struct timeval tv;\n+\n+ FD_ZERO(&fdset);\n+ FD_SET(socket_io_instance->socket, &fdset);\n+ tv.tv_sec = CONNECT_TIMEOUT;\n+ tv.tv_usec = 0;\n+\n+ do\n+ {\n+ retval = select(socket_io_instance->socket + 1, NULL, &fdset, NULL, &tv);\n+\n+ if (retval < 0)\n+ {\n+ select_errno = errno;\n+ }\n+ } while (retval < 0 && select_errno == EINTR);\n+\n+ if (retval != 1)\n+ {\n+ LogError(\"Failure: select failure.\");\n+ result = __FAILURE__;\n+ }\n+ else\n+ {\n+ int so_error = 0;\n+ socklen_t len = sizeof(so_error);\n+ err = getsockopt(socket_io_instance->socket, SOL_SOCKET, SO_ERROR, &so_error, &len);\n+ if (err != 0)\n+ {\n+ LogError(\"Failure: getsockopt failure %d.\", errno);\n+ result = __FAILURE__;\n+ }\n+ else if (so_error != 0)\n+ {\n+ err = so_error;\n+ LogError(\"Failure: connect failure %d.\", so_error);\n+ result = __FAILURE__;\n+ }\n+ else\n+ {\n+ result = 0;\n+ }\n+ }\n+\n+ return result;\n+}\n+*/\n+CONCRETE_IO_HANDLE socketio_create(void* io_create_parameters)\n+{\n+ SOCKETIO_CONFIG* socket_io_config = (SOCKETIO_CONFIG*)io_create_parameters;\n+ SOCKET_IO_INSTANCE* result;\n+\n+ if (socket_io_config == NULL)\n+ {\n+ LogError(\"Invalid argument: socket_io_config is NULL\");\n+ result = NULL;\n+ }\n+ else\n+ {\n+ result = (SOCKET_IO_INSTANCE*)malloc(sizeof(SOCKET_IO_INSTANCE));\n+ if (result != NULL)\n+ {\n+ result->pending_io_list = singlylinkedlist_create();\n+ if (result->pending_io_list == NULL)\n+ {\n+ LogError(\"Failure: singlylinkedlist_create unable to create pending list.\");\n+ free(result);\n+ result = NULL;\n+ }\n+ else\n+ {\n+ if (socket_io_config->hostname != NULL)\n+ {\n+ result->hostname = (char*)malloc(strlen(socket_io_config->hostname) + 1);\n+ if (result->hostname != NULL)\n+ {\n+ (void)strcpy(result->hostname, socket_io_config->hostname);\n+ }\n+\n+ result->socket = NULL;\n+ }\n+ else\n+ {\n+ result->hostname = NULL;\n+ *result->socket = *((EthernetClient*)socket_io_config->accepted_socket);\n+ }\n+\n+ if ((result->hostname == NULL) && (result->socket == NULL))\n+ {\n+ LogError(\"Failure: hostname == NULL and socket is invalid.\");\n+ singlylinkedlist_destroy(result->pending_io_list);\n+ free(result);\n+ result = NULL;\n+ }\n+ else\n+ {\n+ result->port = socket_io_config->port;\n+ result->target_mac_address = NULL;\n+ result->on_bytes_received = NULL;\n+ result->on_io_error = NULL;\n+ result->on_bytes_received_context = NULL;\n+ result->on_io_error_context = NULL;\n+ result->io_state = IO_STATE_CLOSED;\n+ }\n+ }\n+ }\n+ else\n+ {\n+ LogError(\"Allocation Failure: SOCKET_IO_INSTANCE\");\n+ }\n+ }\n+\n+ return result;\n+}\n+\n+void socketio_destroy(CONCRETE_IO_HANDLE socket_io)\n+{\n+ if (socket_io != NULL)\n+ {\n+ SOCKET_IO_INSTANCE* socket_io_instance = (SOCKET_IO_INSTANCE*)socket_io;\n+ /* we cannot do much if the close fails, so just ignore the result */\n+ if (socket_io_instance->socket != NULL)\n+ {\n+ if (socket_io_instance->hostname != NULL)\n+ {\n+ // We created this socket so delete it\n+ \t\t\tdelete socket_io_instance->socket;\n+ }\n+\t\t\tsocket_io_instance->socket = NULL;\n+ }\n+\n+ /* clear all pending IOs */\n+ LIST_ITEM_HANDLE first_pending_io = singlylinkedlist_get_head_item(socket_io_instance->pending_io_list);\n+ while (first_pending_io != NULL)\n+ {\n+ PENDING_SOCKET_IO* pending_socket_io = (PENDING_SOCKET_IO*)singlylinkedlist_item_get_value(first_pending_io);\n+ if (pending_socket_io != NULL)\n+ {\n+ free(pending_socket_io->bytes);\n+ free(pending_socket_io);\n+ }\n+\n+ (void)singlylinkedlist_remove(socket_io_instance->pending_io_list, first_pending_io);\n+ first_pending_io = singlylinkedlist_get_head_item(socket_io_instance->pending_io_list);\n+ }\n+\n+ singlylinkedlist_destroy(socket_io_instance->pending_io_list);\n+ free(socket_io_instance->hostname);\n+ free(socket_io_instance->target_mac_address);\n+ free(socket_io);\n+ }\n+}\n+\n+int socketio_open(CONCRETE_IO_HANDLE socket_io, ON_IO_OPEN_COMPLETE on_io_open_complete, void* on_io_open_complete_context, ON_BYTES_RECEIVED on_bytes_received, void* on_bytes_received_context, ON_IO_ERROR on_io_error, void* on_io_error_context)\n+{\n+ int result = 0;\n+\n+ SOCKET_IO_INSTANCE* socket_io_instance = (SOCKET_IO_INSTANCE*)socket_io;\n+ if (socket_io == NULL)\n+ {\n+ LogError(\"Invalid argument: SOCKET_IO_INSTANCE is NULL\");\n+ result = __FAILURE__;\n+ }\n+ else\n+ {\n+ if (socket_io_instance->io_state != IO_STATE_CLOSED)\n+ {\n+ LogError(\"Failure: socket state is not closed.\");\n+ result = __FAILURE__;\n+ }\n+ else if (socket_io_instance->socket != NULL)\n+ {\n+ // Opening an accepted socket\n+ socket_io_instance->on_bytes_received_context = on_bytes_received_context;\n+ socket_io_instance->on_bytes_received = on_bytes_received;\n+ socket_io_instance->on_io_error = on_io_error;\n+ socket_io_instance->on_io_error_context = on_io_error_context;\n+\n+ socket_io_instance->io_state = IO_STATE_OPEN;\n+\n+ result = 0;\n+ }\n+ else\n+ {\n+\t\t\tsocket_io_instance->socket = new EthernetClient();\n+\t\t\t\n+\t\t\tif (socket_io_instance->socket == NULL)\n+\t\t\t{\n+ LogError(\"Failure: socket create failure %d.\", socket_io_instance->socket);\n+ result = __FAILURE__;\n+\t\t\t}\n+ else if (!socket_io_instance->socket->connect(socket_io_instance->hostname, socket_io_instance->port) != 0)\n+ {\n+ LogError(\"Socket connect failed\");\n+\t\t\t\tresult = __FAILURE__;\n+ }\n+\n+ if (result == 0)\n+ {\n+ socket_io_instance->on_bytes_received = on_bytes_received;\n+ socket_io_instance->on_bytes_received_context = on_bytes_received_context;\n+\n+ socket_io_instance->on_io_error = on_io_error;\n+ socket_io_instance->on_io_error_context = on_io_error_context;\n+\n+ socket_io_instance->io_state = IO_STATE_OPEN;\n+ }\n+ else\n+ {\n+\t\t\t\tif (socket_io_instance->socket != NULL)\n+\t\t\t\t{\n+\t\t\t\t\tdelete socket_io_instance->socket;\n+\t\t\t\t\tsocket_io_instance->socket == NULL;\n+\t\t\t\t}\n+ }\n+ }\n+ }\n+\n+ if (on_io_open_complete != NULL)\n+ {\n+ on_io_open_complete(on_io_open_complete_context, result == 0 ? IO_OPEN_OK : IO_OPEN_ERROR);\n+ }\n+\n+ return result;\n+}\n+\n+int socketio_close(CONCRETE_IO_HANDLE socket_io, ON_IO_CLOSE_COMPLETE on_io_close_complete, void* callback_context)\n+{\n+ int result = 0;\n+\n+ if (socket_io == NULL)\n+ {\n+ result = __FAILURE__;\n+ }\n+ else\n+ {\n+ SOCKET_IO_INSTANCE* socket_io_instance = (SOCKET_IO_INSTANCE*)socket_io;\n+\t\t\n+\t\tif ((socket_io_instance->io_state != IO_STATE_CLOSED) && (socket_io_instance->io_state != IO_STATE_CLOSING))\n+\t\t{\n+\t\t\t// Only close if the socket isn't already in the closed or closing state\n+ if (socket_io_instance->socket != NULL)\n+ {\n+ socket_io_instance->socket->stop();\n+ }\n+\n+ if (socket_io_instance->hostname != NULL)\n+ {\n+ // We created this socket so delete it\n+ \t\t\tdelete socket_io_instance->socket;\n+ }\n+\t\t\t\n+ socket_io_instance->socket = NULL;\n+\t\t\tsocket_io_instance->io_state = IO_STATE_CLOSED;\n+\t\t}\n+\n+\t\tif (on_io_close_complete != NULL)\n+\t\t{\n+\t\t\ton_io_close_complete(callback_context);\n+\t\t}\n+\n+\t\tresult = 0;\n+ }\n+\n+ return result;\n+}\n+\n+int socketio_send(CONCRETE_IO_HANDLE socket_io, const void* buffer, size_t size, ON_SEND_COMPLETE on_send_complete, void* callback_context)\n+{\n+ int result;\n+\n+ if ((socket_io == NULL) ||\n+ (buffer == NULL) ||\n+ (size == 0))\n+ {\n+ /* Invalid arguments */\n+ LogError(\"Invalid argument: send given invalid parameter\");\n+ result = __FAILURE__;\n+ }\n+ else\n+ {\n+ SOCKET_IO_INSTANCE* socket_io_instance = (SOCKET_IO_INSTANCE*)socket_io;\n+ if (socket_io_instance->io_state != IO_STATE_OPEN)\n+ {\n+ LogError(\"Failure: socket state is not opened.\");\n+ result = __FAILURE__;\n+ }\n+ else\n+ {\n+ LIST_ITEM_HANDLE first_pending_io = singlylinkedlist_get_head_item(socket_io_instance->pending_io_list);\n+ if (first_pending_io != NULL)\n+ {\n+ if (add_pending_io(socket_io_instance, (const unsigned char*)buffer, size, on_send_complete, callback_context) != 0)\n+ {\n+ LogError(\"Failure: add_pending_io failed.\");\n+ result = __FAILURE__;\n+ }\n+ else\n+ {\n+ result = 0;\n+ }\n+ }\n+ else\n+ {\n+ ssize_t send_result = socket_io_instance->socket->write((const uint8_t *)buffer, size);\n+\n+ if (send_result == 0)\n+ {\n+ LogError(\"Failure: sending socket failed. errno=%d (%s).\", errno, strerror(errno));\n+ result = __FAILURE__;\n+ }\n+\t\t\t\telse if (send_result < size)","path":"pal/AzureIoTSocket_Ethernet/socketio_esp32ethernet2.cpp","position":575,"original_position":575,"commit_id":"67b878b15011187604050d59fe1d63a623479dee","original_commit_id":"67b878b15011187604050d59fe1d63a623479dee","user":{"login":"danewalton","id":36710865,"node_id":"MDQ6VXNlcjM2NzEwODY1","avatar_url":"https://avatars3.githubusercontent.com/u/36710865?v=4","gravatar_id":"","url":"https://api.github.com/users/danewalton","html_url":"https://github.com/danewalton","followers_url":"https://api.github.com/users/danewalton/followers","following_url":"https://api.github.com/users/danewalton/following{/other_user}","gists_url":"https://api.github.com/users/danewalton/gists{/gist_id}","starred_url":"https://api.github.com/users/danewalton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danewalton/subscriptions","organizations_url":"https://api.github.com/users/danewalton/orgs","repos_url":"https://api.github.com/users/danewalton/repos","events_url":"https://api.github.com/users/danewalton/events{/privacy}","received_events_url":"https://api.github.com/users/danewalton/received_events","type":"User","site_admin":false},"body":"tabs here and elsewhere as well","created_at":"2019-11-18T23:19:19Z","updated_at":"2019-11-18T23:19:19Z","html_url":"https://github.com/Azure/azure-iot-pal-arduino/pull/7#discussion_r347660730","pull_request_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/pulls/7","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/pulls/comments/347660730"},"html":{"href":"https://github.com/Azure/azure-iot-pal-arduino/pull/7#discussion_r347660730"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/pulls/7","id":332628058,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMyNjI4MDU4","html_url":"https://github.com/Azure/azure-iot-pal-arduino/pull/7","diff_url":"https://github.com/Azure/azure-iot-pal-arduino/pull/7.diff","patch_url":"https://github.com/Azure/azure-iot-pal-arduino/pull/7.patch","issue_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/issues/7","number":7,"state":"open","locked":false,"title":"Add support for esp8266","user":{"login":"jbobotek","id":16938970,"node_id":"MDQ6VXNlcjE2OTM4OTcw","avatar_url":"https://avatars1.githubusercontent.com/u/16938970?v=4","gravatar_id":"","url":"https://api.github.com/users/jbobotek","html_url":"https://github.com/jbobotek","followers_url":"https://api.github.com/users/jbobotek/followers","following_url":"https://api.github.com/users/jbobotek/following{/other_user}","gists_url":"https://api.github.com/users/jbobotek/gists{/gist_id}","starred_url":"https://api.github.com/users/jbobotek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbobotek/subscriptions","organizations_url":"https://api.github.com/users/jbobotek/orgs","repos_url":"https://api.github.com/users/jbobotek/repos","events_url":"https://api.github.com/users/jbobotek/events{/privacy}","received_events_url":"https://api.github.com/users/jbobotek/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-25T18:31:31Z","updated_at":"2019-11-18T23:19:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d58731854271a8f771ea5e8a60a03c669815405a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ewertons","id":12401690,"node_id":"MDQ6VXNlcjEyNDAxNjkw","avatar_url":"https://avatars0.githubusercontent.com/u/12401690?v=4","gravatar_id":"","url":"https://api.github.com/users/ewertons","html_url":"https://github.com/ewertons","followers_url":"https://api.github.com/users/ewertons/followers","following_url":"https://api.github.com/users/ewertons/following{/other_user}","gists_url":"https://api.github.com/users/ewertons/gists{/gist_id}","starred_url":"https://api.github.com/users/ewertons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewertons/subscriptions","organizations_url":"https://api.github.com/users/ewertons/orgs","repos_url":"https://api.github.com/users/ewertons/repos","events_url":"https://api.github.com/users/ewertons/events{/privacy}","received_events_url":"https://api.github.com/users/ewertons/received_events","type":"User","site_admin":false},{"login":"markrad","id":12402055,"node_id":"MDQ6VXNlcjEyNDAyMDU1","avatar_url":"https://avatars2.githubusercontent.com/u/12402055?v=4","gravatar_id":"","url":"https://api.github.com/users/markrad","html_url":"https://github.com/markrad","followers_url":"https://api.github.com/users/markrad/followers","following_url":"https://api.github.com/users/markrad/following{/other_user}","gists_url":"https://api.github.com/users/markrad/gists{/gist_id}","starred_url":"https://api.github.com/users/markrad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markrad/subscriptions","organizations_url":"https://api.github.com/users/markrad/orgs","repos_url":"https://api.github.com/users/markrad/repos","events_url":"https://api.github.com/users/markrad/events{/privacy}","received_events_url":"https://api.github.com/users/markrad/received_events","type":"User","site_admin":false},{"login":"mamokarz","id":18200629,"node_id":"MDQ6VXNlcjE4MjAwNjI5","avatar_url":"https://avatars3.githubusercontent.com/u/18200629?v=4","gravatar_id":"","url":"https://api.github.com/users/mamokarz","html_url":"https://github.com/mamokarz","followers_url":"https://api.github.com/users/mamokarz/followers","following_url":"https://api.github.com/users/mamokarz/following{/other_user}","gists_url":"https://api.github.com/users/mamokarz/gists{/gist_id}","starred_url":"https://api.github.com/users/mamokarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mamokarz/subscriptions","organizations_url":"https://api.github.com/users/mamokarz/orgs","repos_url":"https://api.github.com/users/mamokarz/repos","events_url":"https://api.github.com/users/mamokarz/events{/privacy}","received_events_url":"https://api.github.com/users/mamokarz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/pulls/7/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/pulls/7/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/issues/7/comments","statuses_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/statuses/67b878b15011187604050d59fe1d63a623479dee","head":{"label":"Azure:markrad-mbed","ref":"markrad-mbed","sha":"67b878b15011187604050d59fe1d63a623479dee","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":103450420,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM0NTA0MjA=","name":"azure-iot-pal-arduino","full_name":"Azure/azure-iot-pal-arduino","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-iot-pal-arduino","description":"Adaptation layer for the Azure IoT Hub SDK for Arduino","fork":false,"url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino","forks_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/forks","keys_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/teams","hooks_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/events","assignees_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/tags","blobs_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/subscription","commits_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/merges","archive_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/downloads","issues_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/deployments","created_at":"2017-09-13T21:05:03Z","updated_at":"2019-10-23T12:54:03Z","pushed_at":"2019-11-14T01:42:49Z","git_url":"git://github.com/Azure/azure-iot-pal-arduino.git","ssh_url":"[email protected]:Azure/azure-iot-pal-arduino.git","clone_url":"https://github.com/Azure/azure-iot-pal-arduino.git","svn_url":"https://github.com/Azure/azure-iot-pal-arduino","homepage":null,"size":299,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":3,"watchers":4,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"21ccd2c99270fbfcadfb9b11d9633ddc8dceb410","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":103450420,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM0NTA0MjA=","name":"azure-iot-pal-arduino","full_name":"Azure/azure-iot-pal-arduino","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-iot-pal-arduino","description":"Adaptation layer for the Azure IoT Hub SDK for Arduino","fork":false,"url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino","forks_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/forks","keys_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/teams","hooks_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/events","assignees_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/tags","blobs_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/subscription","commits_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/merges","archive_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/downloads","issues_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/deployments","created_at":"2017-09-13T21:05:03Z","updated_at":"2019-10-23T12:54:03Z","pushed_at":"2019-11-14T01:42:49Z","git_url":"git://github.com/Azure/azure-iot-pal-arduino.git","ssh_url":"[email protected]:Azure/azure-iot-pal-arduino.git","clone_url":"https://github.com/Azure/azure-iot-pal-arduino.git","svn_url":"https://github.com/Azure/azure-iot-pal-arduino","homepage":null,"size":299,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/pulls/7"},"html":{"href":"https://github.com/Azure/azure-iot-pal-arduino/pull/7"},"issue":{"href":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/issues/7"},"comments":{"href":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-iot-pal-arduino/statuses/67b878b15011187604050d59fe1d63a623479dee"}},"author_association":"NONE"}}
|
{
"id": 103450420,
"name": "Azure/azure-iot-pal-arduino",
"url": "https://api.github.com/repos/Azure/azure-iot-pal-arduino"
}
|
{
"id": 36710865,
"login": "danewalton",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/36710865?",
"url": "https://api.github.com/users/danewalton"
}
|
{
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
}
| 2019-11-18T23:19:19 |
10891648475
|
{"actor":{"display_login":"danewalton"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments/282573319","pull_request_review_id":235704656,"id":282573319,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4MjU3MzMxOQ==","diff_hunk":"@@ -4,7 +4,7 @@\n \"autorest_options\": {\n \"csharp\": \"\",\n \"license-header\": \"MICROSOFT_MIT_NO_VERSION\",\n- \"sdkrel:csharp-sdks-folder\": \".\",\n+ \"sdkrel:csharp-sdks-folder\": \"./src/SDKs\",","path":"swagger_to_sdk_config.json","position":5,"original_position":5,"commit_id":"4d7ba3dcdd2a17f181b4d0b4c16360a85dc0ab9e","original_commit_id":"4d7ba3dcdd2a17f181b4d0b4c16360a85dc0ab9e","user":{"login":"shahabhijeet","id":20732208,"node_id":"MDQ6VXNlcjIwNzMyMjA4","avatar_url":"https://avatars2.githubusercontent.com/u/20732208?v=4","gravatar_id":"","url":"https://api.github.com/users/shahabhijeet","html_url":"https://github.com/shahabhijeet","followers_url":"https://api.github.com/users/shahabhijeet/followers","following_url":"https://api.github.com/users/shahabhijeet/following{/other_user}","gists_url":"https://api.github.com/users/shahabhijeet/gists{/gist_id}","starred_url":"https://api.github.com/users/shahabhijeet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shahabhijeet/subscriptions","organizations_url":"https://api.github.com/users/shahabhijeet/orgs","repos_url":"https://api.github.com/users/shahabhijeet/repos","events_url":"https://api.github.com/users/shahabhijeet/events{/privacy}","received_events_url":"https://api.github.com/users/shahabhijeet/received_events","type":"User","site_admin":false},"body":"@daschult this value will be changed in next couple of weeks, just FYI","created_at":"2019-05-09T16:51:45Z","updated_at":"2019-05-09T16:51:54Z","html_url":"https://github.com/Azure/azure-sdk-for-net/pull/6221#discussion_r282573319","pull_request_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/6221","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments/282573319"},"html":{"href":"https://github.com/Azure/azure-sdk-for-net/pull/6221#discussion_r282573319"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/6221"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/6221","id":277462496,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc3NDYyNDk2","html_url":"https://github.com/Azure/azure-sdk-for-net/pull/6221","diff_url":"https://github.com/Azure/azure-sdk-for-net/pull/6221.diff","patch_url":"https://github.com/Azure/azure-sdk-for-net/pull/6221.patch","issue_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/6221","number":6221,"state":"open","locked":false,"title":"Update csharp-sdks-folder property in swagger_to_sdk_config.json","user":{"login":"daschult","id":7052303,"node_id":"MDQ6VXNlcjcwNTIzMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7052303?v=4","gravatar_id":"","url":"https://api.github.com/users/daschult","html_url":"https://github.com/daschult","followers_url":"https://api.github.com/users/daschult/followers","following_url":"https://api.github.com/users/daschult/following{/other_user}","gists_url":"https://api.github.com/users/daschult/gists{/gist_id}","starred_url":"https://api.github.com/users/daschult/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschult/subscriptions","organizations_url":"https://api.github.com/users/daschult/orgs","repos_url":"https://api.github.com/users/daschult/repos","events_url":"https://api.github.com/users/daschult/events{/privacy}","received_events_url":"https://api.github.com/users/daschult/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-05-09T16:29:02Z","updated_at":"2019-05-09T16:51:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37ef9a889e0497dbefc09d2f71707e9e31ffaf26","assignee":{"login":"daschult","id":7052303,"node_id":"MDQ6VXNlcjcwNTIzMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7052303?v=4","gravatar_id":"","url":"https://api.github.com/users/daschult","html_url":"https://github.com/daschult","followers_url":"https://api.github.com/users/daschult/followers","following_url":"https://api.github.com/users/daschult/following{/other_user}","gists_url":"https://api.github.com/users/daschult/gists{/gist_id}","starred_url":"https://api.github.com/users/daschult/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschult/subscriptions","organizations_url":"https://api.github.com/users/daschult/orgs","repos_url":"https://api.github.com/users/daschult/repos","events_url":"https://api.github.com/users/daschult/events{/privacy}","received_events_url":"https://api.github.com/users/daschult/received_events","type":"User","site_admin":false},"assignees":[{"login":"daschult","id":7052303,"node_id":"MDQ6VXNlcjcwNTIzMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7052303?v=4","gravatar_id":"","url":"https://api.github.com/users/daschult","html_url":"https://github.com/daschult","followers_url":"https://api.github.com/users/daschult/followers","following_url":"https://api.github.com/users/daschult/following{/other_user}","gists_url":"https://api.github.com/users/daschult/gists{/gist_id}","starred_url":"https://api.github.com/users/daschult/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschult/subscriptions","organizations_url":"https://api.github.com/users/daschult/orgs","repos_url":"https://api.github.com/users/daschult/repos","events_url":"https://api.github.com/users/daschult/events{/privacy}","received_events_url":"https://api.github.com/users/daschult/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dsgouda","id":14796031,"node_id":"MDQ6VXNlcjE0Nzk2MDMx","avatar_url":"https://avatars2.githubusercontent.com/u/14796031?v=4","gravatar_id":"","url":"https://api.github.com/users/dsgouda","html_url":"https://github.com/dsgouda","followers_url":"https://api.github.com/users/dsgouda/followers","following_url":"https://api.github.com/users/dsgouda/following{/other_user}","gists_url":"https://api.github.com/users/dsgouda/gists{/gist_id}","starred_url":"https://api.github.com/users/dsgouda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsgouda/subscriptions","organizations_url":"https://api.github.com/users/dsgouda/orgs","repos_url":"https://api.github.com/users/dsgouda/repos","events_url":"https://api.github.com/users/dsgouda/events{/privacy}","received_events_url":"https://api.github.com/users/dsgouda/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/6221/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/6221/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/6221/comments","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/4d7ba3dcdd2a17f181b4d0b4c16360a85dc0ab9e","head":{"label":"Azure:daschult-patch-1","ref":"daschult-patch-1","sha":"4d7ba3dcdd2a17f181b4d0b4c16360a85dc0ab9e","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":2928944,"node_id":"MDEwOlJlcG9zaXRvcnkyOTI4OTQ0","name":"azure-sdk-for-net","full_name":"Azure/azure-sdk-for-net","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-sdk-for-net","description":".NET Libraries for Azure","fork":false,"url":"https://api.github.com/repos/Azure/azure-sdk-for-net","forks_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/forks","keys_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/teams","hooks_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/events","assignees_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/tags","blobs_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/subscription","commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/merges","archive_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/downloads","issues_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/deployments","created_at":"2011-12-06T23:32:47Z","updated_at":"2019-05-09T16:27:50Z","pushed_at":"2019-05-09T16:49:19Z","git_url":"git://github.com/Azure/azure-sdk-for-net.git","ssh_url":"[email protected]:Azure/azure-sdk-for-net.git","clone_url":"https://github.com/Azure/azure-sdk-for-net.git","svn_url":"https://github.com/Azure/azure-sdk-for-net","homepage":"https://docs.microsoft.com/en-us/dotnet/azure/","size":290820,"stargazers_count":1339,"watchers_count":1339,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1362,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":546,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1362,"open_issues":546,"watchers":1339,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"3a7c51ccf6e8e4a7ba7fb068bf7045525b92c62e","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":2928944,"node_id":"MDEwOlJlcG9zaXRvcnkyOTI4OTQ0","name":"azure-sdk-for-net","full_name":"Azure/azure-sdk-for-net","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-sdk-for-net","description":".NET Libraries for Azure","fork":false,"url":"https://api.github.com/repos/Azure/azure-sdk-for-net","forks_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/forks","keys_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/teams","hooks_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/events","assignees_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/tags","blobs_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/subscription","commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/merges","archive_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/downloads","issues_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-sdk-for-net/deployments","created_at":"2011-12-06T23:32:47Z","updated_at":"2019-05-09T16:27:50Z","pushed_at":"2019-05-09T16:49:19Z","git_url":"git://github.com/Azure/azure-sdk-for-net.git","ssh_url":"[email protected]:Azure/azure-sdk-for-net.git","clone_url":"https://github.com/Azure/azure-sdk-for-net.git","svn_url":"https://github.com/Azure/azure-sdk-for-net","homepage":"https://docs.microsoft.com/en-us/dotnet/azure/","size":290820,"stargazers_count":1339,"watchers_count":1339,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1362,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":546,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1362,"open_issues":546,"watchers":1339,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/6221"},"html":{"href":"https://github.com/Azure/azure-sdk-for-net/pull/6221"},"issue":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/6221"},"comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/issues/6221/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/6221/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/pulls/6221/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-sdk-for-net/statuses/4d7ba3dcdd2a17f181b4d0b4c16360a85dc0ab9e"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 2928944,
"name": "Azure/azure-sdk-for-net",
"url": "https://api.github.com/repos/Azure/azure-sdk-for-net"
}
|
{
"id": 20732208,
"login": "shahabhijeet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20732208?",
"url": "https://api.github.com/users/shahabhijeet"
}
|
{
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
}
| 2019-05-09T16:51:45 |
9595770524
|
{"actor":{"display_login":"shahabhijeet"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/acr-builder/pulls/comments/255820191","pull_request_review_id":202504308,"id":255820191,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NTgyMDE5MQ==","diff_hunk":"@@ -1,10 +1,76 @@\n-// Copyright (c) Microsoft Corporation. All rights reserved.\n-// Licensed under the MIT License.\n-\n package graph\n \n-// Secret defines a wrapper to translate Azure Key Vault secrets to environment variables.\n+import (\n+\t\"github.com/Azure/acr-builder/util\"\n+\t\"github.com/pkg/errors\"\n+)\n+\n+var (\n+\terrMissingSecretID = errors.New(\"secret is missing an ID\")\n+\terrMissingSecretProps = errors.New(\"secret is missing required akv property\")\n+\terrSecretIDContainsSpace = errors.New(\"secret ID cannot contain spaces\")\n+\terrInvalidUUID = errors.New(\"The msi client ID is not a valid guid\")\n+)\n+\n+// SecretValue represents the resolved value of the Secret.\n+type SecretValue struct {\n+\tID string\n+\tValue string\n+}\n+\n+// Secret defines a wrapper to resolve vault secrets to values.\n type Secret struct {\n-\tAkv string `yaml:\"akv,omitempty\"`\n-\tSecretEnv string `yaml:\"secretEnv,omitempty\"`\n+\tID string `yaml:\"id\"`\n+\tAkv string `yaml:\"akv,omitempty\"`\n+\tMsiClientID string `yaml:\"client-id,omitempty\"`\n+\n+\t// ResolvedChan is used to signal the callers\n+\t// that the secret has been resolved successfully to a vaule.\n+\tResolvedChan chan SecretValue\n+}\n+\n+// Validate validates the secrets and returns an error if the secret properties are invalid.\n+func (s *Secret) Validate() error {\n+\tif s == nil {\n+\t\treturn nil\n+\t}\n+\tif s.ID == \"\" {\n+\t\treturn errMissingSecretID\n+\t}\n+\tif util.ContainsSpace(s.ID) {\n+\t\treturn errSecretIDContainsSpace\n+\t}\n+\tif !s.IsAkvSecret() {\n+\t\treturn errMissingSecretProps\n+\t}\n+\tif s.MsiClientID != \"\" && !util.IsValidUUID(s.MsiClientID) {\n+\t\treturn errInvalidUUID\n+\t}\n+\n+\treturn nil\n+}\n+\n+// IsAkvSecret returns true if a Secret is of Azure Keyvault type, false otherwise.\n+func (s *Secret) IsAkvSecret() bool {\n+\tif s == nil {\n+\t\treturn false\n+\t}\n+\treturn s.Akv != \"\"\n+}\n+\n+// Equals determines whether or not two secrets are equal.\n+func (s *Secret) Equals(t *Secret) bool {\n+\tif s == nil && t == nil {\n+\t\treturn true\n+\t}\n+\tif s == nil || t == nil {\n+\t\treturn false\n+\t}\n+\tif s.ID != t.ID ||","path":"graph/secret.go","position":75,"original_position":75,"commit_id":"dd977501e4cab367b24f7c0b2e8bf5e5954ddafe","original_commit_id":"dd977501e4cab367b24f7c0b2e8bf5e5954ddafe","user":{"login":"ehotinger","id":1822836,"node_id":"MDQ6VXNlcjE4MjI4MzY=","avatar_url":"https://avatars1.githubusercontent.com/u/1822836?v=4","gravatar_id":"","url":"https://api.github.com/users/ehotinger","html_url":"https://github.com/ehotinger","followers_url":"https://api.github.com/users/ehotinger/followers","following_url":"https://api.github.com/users/ehotinger/following{/other_user}","gists_url":"https://api.github.com/users/ehotinger/gists{/gist_id}","starred_url":"https://api.github.com/users/ehotinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehotinger/subscriptions","organizations_url":"https://api.github.com/users/ehotinger/orgs","repos_url":"https://api.github.com/users/ehotinger/repos","events_url":"https://api.github.com/users/ehotinger/events{/privacy}","received_events_url":"https://api.github.com/users/ehotinger/received_events","type":"User","site_admin":false},"body":"nit: can just put return here instead of if/else","created_at":"2019-02-12T06:42:42Z","updated_at":"2019-02-12T06:42:42Z","html_url":"https://github.com/Azure/acr-builder/pull/389#discussion_r255820191","pull_request_url":"https://api.github.com/repos/Azure/acr-builder/pulls/389","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/acr-builder/pulls/comments/255820191"},"html":{"href":"https://github.com/Azure/acr-builder/pull/389#discussion_r255820191"},"pull_request":{"href":"https://api.github.com/repos/Azure/acr-builder/pulls/389"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/acr-builder/pulls/389","id":252118504,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUyMTE4NTA0","html_url":"https://github.com/Azure/acr-builder/pull/389","diff_url":"https://github.com/Azure/acr-builder/pull/389.diff","patch_url":"https://github.com/Azure/acr-builder/pull/389.patch","issue_url":"https://api.github.com/repos/Azure/acr-builder/issues/389","number":389,"state":"open","locked":false,"title":"Adds support of secrets to task template","user":{"login":"mnltejaswini","id":8011073,"node_id":"MDQ6VXNlcjgwMTEwNzM=","avatar_url":"https://avatars3.githubusercontent.com/u/8011073?v=4","gravatar_id":"","url":"https://api.github.com/users/mnltejaswini","html_url":"https://github.com/mnltejaswini","followers_url":"https://api.github.com/users/mnltejaswini/followers","following_url":"https://api.github.com/users/mnltejaswini/following{/other_user}","gists_url":"https://api.github.com/users/mnltejaswini/gists{/gist_id}","starred_url":"https://api.github.com/users/mnltejaswini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnltejaswini/subscriptions","organizations_url":"https://api.github.com/users/mnltejaswini/orgs","repos_url":"https://api.github.com/users/mnltejaswini/repos","events_url":"https://api.github.com/users/mnltejaswini/events{/privacy}","received_events_url":"https://api.github.com/users/mnltejaswini/received_events","type":"User","site_admin":false},"body":"This PR adds the support of secrets to template. Currently the secrets can be retrieved from Azure keyvault using MSI. The resolved secrets can then be used in the known templating language like {{.Secrets.mysecret}} The documentation for using the secrets is added to the repo. \r\n\r\nTests\r\n----\r\n Unit tests cases added to all new and updated modules of the repository. Existing unit tests passed. E2E test on a Azure VM using MSI is documented. ","created_at":"2019-02-12T00:16:00Z","updated_at":"2019-02-12T06:42:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66b5bf7066742d15b48f2afbebada2040ad3a6d8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sajayantony","id":1821104,"node_id":"MDQ6VXNlcjE4MjExMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1821104?v=4","gravatar_id":"","url":"https://api.github.com/users/sajayantony","html_url":"https://github.com/sajayantony","followers_url":"https://api.github.com/users/sajayantony/followers","following_url":"https://api.github.com/users/sajayantony/following{/other_user}","gists_url":"https://api.github.com/users/sajayantony/gists{/gist_id}","starred_url":"https://api.github.com/users/sajayantony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sajayantony/subscriptions","organizations_url":"https://api.github.com/users/sajayantony/orgs","repos_url":"https://api.github.com/users/sajayantony/repos","events_url":"https://api.github.com/users/sajayantony/events{/privacy}","received_events_url":"https://api.github.com/users/sajayantony/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/acr-builder/pulls/389/commits","review_comments_url":"https://api.github.com/repos/Azure/acr-builder/pulls/389/comments","review_comment_url":"https://api.github.com/repos/Azure/acr-builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/acr-builder/issues/389/comments","statuses_url":"https://api.github.com/repos/Azure/acr-builder/statuses/dd977501e4cab367b24f7c0b2e8bf5e5954ddafe","head":{"label":"Azure:naduggar/secretsyaml","ref":"naduggar/secretsyaml","sha":"dd977501e4cab367b24f7c0b2e8bf5e5954ddafe","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":98698223,"node_id":"MDEwOlJlcG9zaXRvcnk5ODY5ODIyMw==","name":"acr-builder","full_name":"Azure/acr-builder","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/acr-builder","description":"Azure Container Registry Build Runner","fork":false,"url":"https://api.github.com/repos/Azure/acr-builder","forks_url":"https://api.github.com/repos/Azure/acr-builder/forks","keys_url":"https://api.github.com/repos/Azure/acr-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/acr-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/acr-builder/teams","hooks_url":"https://api.github.com/repos/Azure/acr-builder/hooks","issue_events_url":"https://api.github.com/repos/Azure/acr-builder/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/acr-builder/events","assignees_url":"https://api.github.com/repos/Azure/acr-builder/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/acr-builder/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/acr-builder/tags","blobs_url":"https://api.github.com/repos/Azure/acr-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/acr-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/acr-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/acr-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/acr-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/acr-builder/languages","stargazers_url":"https://api.github.com/repos/Azure/acr-builder/stargazers","contributors_url":"https://api.github.com/repos/Azure/acr-builder/contributors","subscribers_url":"https://api.github.com/repos/Azure/acr-builder/subscribers","subscription_url":"https://api.github.com/repos/Azure/acr-builder/subscription","commits_url":"https://api.github.com/repos/Azure/acr-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/acr-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/acr-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/acr-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/acr-builder/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/acr-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/acr-builder/merges","archive_url":"https://api.github.com/repos/Azure/acr-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/acr-builder/downloads","issues_url":"https://api.github.com/repos/Azure/acr-builder/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/acr-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/acr-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/acr-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/acr-builder/labels{/name}","releases_url":"https://api.github.com/repos/Azure/acr-builder/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/acr-builder/deployments","created_at":"2017-07-29T00:44:12Z","updated_at":"2019-02-09T12:13:35Z","pushed_at":"2019-02-12T00:32:26Z","git_url":"git://github.com/Azure/acr-builder.git","ssh_url":"[email protected]:Azure/acr-builder.git","clone_url":"https://github.com/Azure/acr-builder.git","svn_url":"https://github.com/Azure/acr-builder","homepage":null,"size":4216,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":20,"open_issues":14,"watchers":14,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"c31b18eb1ebf855c4ebb92b970555beca91650cf","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":98698223,"node_id":"MDEwOlJlcG9zaXRvcnk5ODY5ODIyMw==","name":"acr-builder","full_name":"Azure/acr-builder","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/acr-builder","description":"Azure Container Registry Build Runner","fork":false,"url":"https://api.github.com/repos/Azure/acr-builder","forks_url":"https://api.github.com/repos/Azure/acr-builder/forks","keys_url":"https://api.github.com/repos/Azure/acr-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/acr-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/acr-builder/teams","hooks_url":"https://api.github.com/repos/Azure/acr-builder/hooks","issue_events_url":"https://api.github.com/repos/Azure/acr-builder/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/acr-builder/events","assignees_url":"https://api.github.com/repos/Azure/acr-builder/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/acr-builder/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/acr-builder/tags","blobs_url":"https://api.github.com/repos/Azure/acr-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/acr-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/acr-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/acr-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/acr-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/acr-builder/languages","stargazers_url":"https://api.github.com/repos/Azure/acr-builder/stargazers","contributors_url":"https://api.github.com/repos/Azure/acr-builder/contributors","subscribers_url":"https://api.github.com/repos/Azure/acr-builder/subscribers","subscription_url":"https://api.github.com/repos/Azure/acr-builder/subscription","commits_url":"https://api.github.com/repos/Azure/acr-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/acr-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/acr-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/acr-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/acr-builder/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/acr-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/acr-builder/merges","archive_url":"https://api.github.com/repos/Azure/acr-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/acr-builder/downloads","issues_url":"https://api.github.com/repos/Azure/acr-builder/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/acr-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/acr-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/acr-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/acr-builder/labels{/name}","releases_url":"https://api.github.com/repos/Azure/acr-builder/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/acr-builder/deployments","created_at":"2017-07-29T00:44:12Z","updated_at":"2019-02-09T12:13:35Z","pushed_at":"2019-02-12T00:32:26Z","git_url":"git://github.com/Azure/acr-builder.git","ssh_url":"[email protected]:Azure/acr-builder.git","clone_url":"https://github.com/Azure/acr-builder.git","svn_url":"https://github.com/Azure/acr-builder","homepage":null,"size":4216,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":20,"open_issues":14,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/acr-builder/pulls/389"},"html":{"href":"https://github.com/Azure/acr-builder/pull/389"},"issue":{"href":"https://api.github.com/repos/Azure/acr-builder/issues/389"},"comments":{"href":"https://api.github.com/repos/Azure/acr-builder/issues/389/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/acr-builder/pulls/389/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/acr-builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/acr-builder/pulls/389/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/acr-builder/statuses/dd977501e4cab367b24f7c0b2e8bf5e5954ddafe"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 98698223,
"name": "Azure/acr-builder",
"url": "https://api.github.com/repos/Azure/acr-builder"
}
|
{
"id": 1822836,
"login": "ehotinger",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1822836?",
"url": "https://api.github.com/users/ehotinger"
}
|
{
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
}
| 2019-02-12T06:42:42 |
9049869048
|
{"actor":{"display_login":"ehotinger"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/comments/274198479","pull_request_review_id":225259647,"id":274198479,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NDE5ODQ3OQ==","diff_hunk":"@@ -0,0 +1,74 @@\n+// Copyright (c) Microsoft. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+\n+using Microsoft.Azure.Devices.Shared;\n+using Newtonsoft.Json.Linq;\n+using System.Text;\n+\n+namespace Microsoft.Azure.Devices.Provisioning.Client.Transport\n+{\n+ /// <summary>\n+ /// Represents a Provisioning registration message.\n+ /// </summary>\n+ public class ProvisioningTransportRegisterMessage\n+ {","path":"provisioning/device/src/ProvisioningTransportRegisterMessage.cs","position":14,"original_position":14,"commit_id":"0f9b7ba4630b52ba3e41a1907cfa48b22fab6e88","original_commit_id":"0488d963f9a4f1e8a948f5dda946cf0b5649a4f2","user":{"login":"prmathur-microsoft","id":20328314,"node_id":"MDQ6VXNlcjIwMzI4MzE0","avatar_url":"https://avatars3.githubusercontent.com/u/20328314?v=4","gravatar_id":"","url":"https://api.github.com/users/prmathur-microsoft","html_url":"https://github.com/prmathur-microsoft","followers_url":"https://api.github.com/users/prmathur-microsoft/followers","following_url":"https://api.github.com/users/prmathur-microsoft/following{/other_user}","gists_url":"https://api.github.com/users/prmathur-microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/prmathur-microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prmathur-microsoft/subscriptions","organizations_url":"https://api.github.com/users/prmathur-microsoft/orgs","repos_url":"https://api.github.com/users/prmathur-microsoft/repos","events_url":"https://api.github.com/users/prmathur-microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/prmathur-microsoft/received_events","type":"User","site_admin":false},"body":"Can't Data be added to existing?","created_at":"2019-04-10T23:00:04Z","updated_at":"2019-04-10T23:00:04Z","html_url":"https://github.com/Azure/azure-iot-sdk-csharp/pull/905#discussion_r274198479","pull_request_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/905","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/comments/274198479"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-csharp/pull/905#discussion_r274198479"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/905"}},"in_reply_to_id":274198408},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/905","id":269332985,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY5MzMyOTg1","html_url":"https://github.com/Azure/azure-iot-sdk-csharp/pull/905","diff_url":"https://github.com/Azure/azure-iot-sdk-csharp/pull/905.diff","patch_url":"https://github.com/Azure/azure-iot-sdk-csharp/pull/905.patch","issue_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/issues/905","number":905,"state":"open","locked":false,"title":"Add DPS blob support ","user":{"login":"prmathur-microsoft","id":20328314,"node_id":"MDQ6VXNlcjIwMzI4MzE0","avatar_url":"https://avatars3.githubusercontent.com/u/20328314?v=4","gravatar_id":"","url":"https://api.github.com/users/prmathur-microsoft","html_url":"https://github.com/prmathur-microsoft","followers_url":"https://api.github.com/users/prmathur-microsoft/followers","following_url":"https://api.github.com/users/prmathur-microsoft/following{/other_user}","gists_url":"https://api.github.com/users/prmathur-microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/prmathur-microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prmathur-microsoft/subscriptions","organizations_url":"https://api.github.com/users/prmathur-microsoft/orgs","repos_url":"https://api.github.com/users/prmathur-microsoft/repos","events_url":"https://api.github.com/users/prmathur-microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/prmathur-microsoft/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for helping us improve the Azure IoT C# SDK!\r\n\r\nNeed support?\r\n- Have a feature request for SDKs? Please post it on [User Voice](https://feedback.azure.com/forums/321918-azure-iot) to help us prioritize.\r\n- Have a technical question? Ask on [Stack Overflow](https://stackoverflow.com/questions/tagged/azure-iot-hub) with tag “azure-iot-hub”\r\n- Need Support? Every customer with an active Azure subscription has access to support with guaranteed response time. Consider submitting a ticket and get assistance from Microsoft support team\r\n- Found a bug? Please help us fix it by thoroughly documenting it and filing an issue on GitHub (C, Java, .NET, Node.js, Python).\r\n-->\r\n\r\n## Checklist\r\n- [ ] I have read the [contribution guidelines](https://github.com/Azure/azure-iot-sdk-csharp/blob/master/.github/CONTRIBUTING.md).\r\n- [ ] I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).\r\n- [ ] This pull-request is submitted against the `master` branch.\r\n<!-- If not against master, please add the reason. -->\r\n\r\n## Description of the changes\r\n<!-- Itemized list of changes. -->\r\n\r\n## Reference/Link to the issue solved with this PR (if any)\r\n<!-- Use Fixes #nnnn to automatically close the issue. -->\r\n","created_at":"2019-04-10T21:09:47Z","updated_at":"2019-04-10T23:00:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41c7723d2ebb32317cd618bbc1c71a6858d5eda6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/905/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/905/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/issues/905/comments","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/statuses/0f9b7ba4630b52ba3e41a1907cfa48b22fab6e88","head":{"label":"prmathur-microsoft:dps_blob","ref":"dps_blob","sha":"0f9b7ba4630b52ba3e41a1907cfa48b22fab6e88","user":{"login":"prmathur-microsoft","id":20328314,"node_id":"MDQ6VXNlcjIwMzI4MzE0","avatar_url":"https://avatars3.githubusercontent.com/u/20328314?v=4","gravatar_id":"","url":"https://api.github.com/users/prmathur-microsoft","html_url":"https://github.com/prmathur-microsoft","followers_url":"https://api.github.com/users/prmathur-microsoft/followers","following_url":"https://api.github.com/users/prmathur-microsoft/following{/other_user}","gists_url":"https://api.github.com/users/prmathur-microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/prmathur-microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prmathur-microsoft/subscriptions","organizations_url":"https://api.github.com/users/prmathur-microsoft/orgs","repos_url":"https://api.github.com/users/prmathur-microsoft/repos","events_url":"https://api.github.com/users/prmathur-microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/prmathur-microsoft/received_events","type":"User","site_admin":false},"repo":{"id":151623944,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE2MjM5NDQ=","name":"azure-iot-sdk-csharp","full_name":"prmathur-microsoft/azure-iot-sdk-csharp","private":false,"owner":{"login":"prmathur-microsoft","id":20328314,"node_id":"MDQ6VXNlcjIwMzI4MzE0","avatar_url":"https://avatars3.githubusercontent.com/u/20328314?v=4","gravatar_id":"","url":"https://api.github.com/users/prmathur-microsoft","html_url":"https://github.com/prmathur-microsoft","followers_url":"https://api.github.com/users/prmathur-microsoft/followers","following_url":"https://api.github.com/users/prmathur-microsoft/following{/other_user}","gists_url":"https://api.github.com/users/prmathur-microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/prmathur-microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prmathur-microsoft/subscriptions","organizations_url":"https://api.github.com/users/prmathur-microsoft/orgs","repos_url":"https://api.github.com/users/prmathur-microsoft/repos","events_url":"https://api.github.com/users/prmathur-microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/prmathur-microsoft/received_events","type":"User","site_admin":false},"html_url":"https://github.com/prmathur-microsoft/azure-iot-sdk-csharp","description":"A C# SDK for connecting devices to Microsoft Azure IoT services","fork":true,"url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp","forks_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/forks","keys_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/teams","hooks_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/hooks","issue_events_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/issues/events{/number}","events_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/events","assignees_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/assignees{/user}","branches_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/branches{/branch}","tags_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/tags","blobs_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/statuses/{sha}","languages_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/languages","stargazers_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/stargazers","contributors_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/contributors","subscribers_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/subscribers","subscription_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/subscription","commits_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/contents/{+path}","compare_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/merges","archive_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/downloads","issues_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/issues{/number}","pulls_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/pulls{/number}","milestones_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/milestones{/number}","notifications_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/labels{/name}","releases_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/releases{/id}","deployments_url":"https://api.github.com/repos/prmathur-microsoft/azure-iot-sdk-csharp/deployments","created_at":"2018-10-04T19:18:31Z","updated_at":"2019-04-08T23:33:26Z","pushed_at":"2019-04-10T22:51:47Z","git_url":"git://github.com/prmathur-microsoft/azure-iot-sdk-csharp.git","ssh_url":"[email protected]:prmathur-microsoft/azure-iot-sdk-csharp.git","clone_url":"https://github.com/prmathur-microsoft/azure-iot-sdk-csharp.git","svn_url":"https://github.com/prmathur-microsoft/azure-iot-sdk-csharp","homepage":null,"size":44713,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"b1041109d4daded8f5dbf64a438497de1660cc16","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":70936151,"node_id":"MDEwOlJlcG9zaXRvcnk3MDkzNjE1MQ==","name":"azure-iot-sdk-csharp","full_name":"Azure/azure-iot-sdk-csharp","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-iot-sdk-csharp","description":"A C# SDK for connecting devices to Microsoft Azure IoT services","fork":false,"url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp","forks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/forks","keys_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/teams","hooks_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/events","assignees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/tags","blobs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/subscription","commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/merges","archive_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/downloads","issues_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/deployments","created_at":"2016-10-14T18:18:23Z","updated_at":"2019-04-10T12:34:36Z","pushed_at":"2019-04-10T22:51:49Z","git_url":"git://github.com/Azure/azure-iot-sdk-csharp.git","ssh_url":"[email protected]:Azure/azure-iot-sdk-csharp.git","clone_url":"https://github.com/Azure/azure-iot-sdk-csharp.git","svn_url":"https://github.com/Azure/azure-iot-sdk-csharp","homepage":null,"size":45062,"stargazers_count":238,"watchers_count":238,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":353,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":140,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":353,"open_issues":140,"watchers":238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/905"},"html":{"href":"https://github.com/Azure/azure-iot-sdk-csharp/pull/905"},"issue":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/issues/905"},"comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/issues/905/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/905/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/pulls/905/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-iot-sdk-csharp/statuses/0f9b7ba4630b52ba3e41a1907cfa48b22fab6e88"}},"author_association":"MEMBER"}}
|
{
"id": 70936151,
"name": "Azure/azure-iot-sdk-csharp",
"url": "https://api.github.com/repos/Azure/azure-iot-sdk-csharp"
}
|
{
"id": 20328314,
"login": "prmathur-microsoft",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/20328314?",
"url": "https://api.github.com/users/prmathur-microsoft"
}
|
{
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
}
| 2019-04-10T23:00:04 |
9419721994
|
{"actor":{"display_login":"prmathur-microsoft"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-functions-python-worker/pulls/comments/278824043","pull_request_review_id":230999282,"id":278824043,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3ODgyNDA0Mw==","diff_hunk":"@@ -0,0 +1,101 @@\n+import json\n+import typing\n+\n+from azure.functions import _kafka\n+\n+from . import meta\n+from .. import protos\n+\n+\n+class KafkaConverter(meta.InConverter, meta.OutConverter,\n+ binding='kafka'):\n+\n+ @classmethod\n+ def check_input_type_annotation(\n+ cls, pytype: type, datatype: protos.BindingInfo.DataType) -> bool:","path":"azure/functions_worker/bindings/kafka.py","position":15,"original_position":15,"commit_id":"781a75cea46041e9dacba6c0272df5d7372ce86f","original_commit_id":"781a75cea46041e9dacba6c0272df5d7372ce86f","user":{"login":"priyaananthasankar","id":10415876,"node_id":"MDQ6VXNlcjEwNDE1ODc2","avatar_url":"https://avatars1.githubusercontent.com/u/10415876?v=4","gravatar_id":"","url":"https://api.github.com/users/priyaananthasankar","html_url":"https://github.com/priyaananthasankar","followers_url":"https://api.github.com/users/priyaananthasankar/followers","following_url":"https://api.github.com/users/priyaananthasankar/following{/other_user}","gists_url":"https://api.github.com/users/priyaananthasankar/gists{/gist_id}","starred_url":"https://api.github.com/users/priyaananthasankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyaananthasankar/subscriptions","organizations_url":"https://api.github.com/users/priyaananthasankar/orgs","repos_url":"https://api.github.com/users/priyaananthasankar/repos","events_url":"https://api.github.com/users/priyaananthasankar/events{/privacy}","received_events_url":"https://api.github.com/users/priyaananthasankar/received_events","type":"User","site_admin":false},"body":"Added extra argument - in sync with meta.py","created_at":"2019-04-26T06:43:22Z","updated_at":"2019-04-26T06:43:22Z","html_url":"https://github.com/Azure/azure-functions-python-worker/pull/389#discussion_r278824043","pull_request_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/pulls/389","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-functions-python-worker/pulls/comments/278824043"},"html":{"href":"https://github.com/Azure/azure-functions-python-worker/pull/389#discussion_r278824043"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-functions-python-worker/pulls/389"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-functions-python-worker/pulls/389","id":272991568,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcyOTkxNTY4","html_url":"https://github.com/Azure/azure-functions-python-worker/pull/389","diff_url":"https://github.com/Azure/azure-functions-python-worker/pull/389.diff","patch_url":"https://github.com/Azure/azure-functions-python-worker/pull/389.patch","issue_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/issues/389","number":389,"state":"open","locked":false,"title":"Kafka Trigger Rich Type","user":{"login":"priyaananthasankar","id":10415876,"node_id":"MDQ6VXNlcjEwNDE1ODc2","avatar_url":"https://avatars1.githubusercontent.com/u/10415876?v=4","gravatar_id":"","url":"https://api.github.com/users/priyaananthasankar","html_url":"https://github.com/priyaananthasankar","followers_url":"https://api.github.com/users/priyaananthasankar/followers","following_url":"https://api.github.com/users/priyaananthasankar/following{/other_user}","gists_url":"https://api.github.com/users/priyaananthasankar/gists{/gist_id}","starred_url":"https://api.github.com/users/priyaananthasankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyaananthasankar/subscriptions","organizations_url":"https://api.github.com/users/priyaananthasankar/orgs","repos_url":"https://api.github.com/users/priyaananthasankar/repos","events_url":"https://api.github.com/users/priyaananthasankar/events{/privacy}","received_events_url":"https://api.github.com/users/priyaananthasankar/received_events","type":"User","site_admin":false},"body":"Supporting rich type KafkaEvent for KafkaTrigger in Python\r\nAzure/azure-functions-kafka-extension#10","created_at":"2019-04-24T06:29:44Z","updated_at":"2019-04-26T06:43:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53af9846ac542031d9cd350de5788a8338fe39c0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/pulls/389/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/pulls/389/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/issues/389/comments","statuses_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/statuses/781a75cea46041e9dacba6c0272df5d7372ce86f","head":{"label":"priyaananthasankar:kafka_trigger","ref":"kafka_trigger","sha":"781a75cea46041e9dacba6c0272df5d7372ce86f","user":{"login":"priyaananthasankar","id":10415876,"node_id":"MDQ6VXNlcjEwNDE1ODc2","avatar_url":"https://avatars1.githubusercontent.com/u/10415876?v=4","gravatar_id":"","url":"https://api.github.com/users/priyaananthasankar","html_url":"https://github.com/priyaananthasankar","followers_url":"https://api.github.com/users/priyaananthasankar/followers","following_url":"https://api.github.com/users/priyaananthasankar/following{/other_user}","gists_url":"https://api.github.com/users/priyaananthasankar/gists{/gist_id}","starred_url":"https://api.github.com/users/priyaananthasankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyaananthasankar/subscriptions","organizations_url":"https://api.github.com/users/priyaananthasankar/orgs","repos_url":"https://api.github.com/users/priyaananthasankar/repos","events_url":"https://api.github.com/users/priyaananthasankar/events{/privacy}","received_events_url":"https://api.github.com/users/priyaananthasankar/received_events","type":"User","site_admin":false},"repo":{"id":182211745,"node_id":"MDEwOlJlcG9zaXRvcnkxODIyMTE3NDU=","name":"azure-functions-python-worker","full_name":"priyaananthasankar/azure-functions-python-worker","private":false,"owner":{"login":"priyaananthasankar","id":10415876,"node_id":"MDQ6VXNlcjEwNDE1ODc2","avatar_url":"https://avatars1.githubusercontent.com/u/10415876?v=4","gravatar_id":"","url":"https://api.github.com/users/priyaananthasankar","html_url":"https://github.com/priyaananthasankar","followers_url":"https://api.github.com/users/priyaananthasankar/followers","following_url":"https://api.github.com/users/priyaananthasankar/following{/other_user}","gists_url":"https://api.github.com/users/priyaananthasankar/gists{/gist_id}","starred_url":"https://api.github.com/users/priyaananthasankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyaananthasankar/subscriptions","organizations_url":"https://api.github.com/users/priyaananthasankar/orgs","repos_url":"https://api.github.com/users/priyaananthasankar/repos","events_url":"https://api.github.com/users/priyaananthasankar/events{/privacy}","received_events_url":"https://api.github.com/users/priyaananthasankar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/priyaananthasankar/azure-functions-python-worker","description":"Python worker for Azure Functions.","fork":true,"url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker","forks_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/forks","keys_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/teams","hooks_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/hooks","issue_events_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/issues/events{/number}","events_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/events","assignees_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/assignees{/user}","branches_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/branches{/branch}","tags_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/tags","blobs_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/git/refs{/sha}","trees_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/statuses/{sha}","languages_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/languages","stargazers_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/stargazers","contributors_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/contributors","subscribers_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/subscribers","subscription_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/subscription","commits_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/commits{/sha}","git_commits_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/git/commits{/sha}","comments_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/comments{/number}","issue_comment_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/issues/comments{/number}","contents_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/contents/{+path}","compare_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/merges","archive_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/downloads","issues_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/issues{/number}","pulls_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/pulls{/number}","milestones_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/milestones{/number}","notifications_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/labels{/name}","releases_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/releases{/id}","deployments_url":"https://api.github.com/repos/priyaananthasankar/azure-functions-python-worker/deployments","created_at":"2019-04-19T06:11:52Z","updated_at":"2019-04-19T06:11:54Z","pushed_at":"2019-04-26T06:41:13Z","git_url":"git://github.com/priyaananthasankar/azure-functions-python-worker.git","ssh_url":"[email protected]:priyaananthasankar/azure-functions-python-worker.git","clone_url":"https://github.com/priyaananthasankar/azure-functions-python-worker.git","svn_url":"https://github.com/priyaananthasankar/azure-functions-python-worker","homepage":null,"size":551,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Azure:dev","ref":"dev","sha":"521d4c56e148feb4cde7210fbf7d017336baf380","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":117730503,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc3MzA1MDM=","name":"azure-functions-python-worker","full_name":"Azure/azure-functions-python-worker","private":false,"owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Azure/azure-functions-python-worker","description":"Python worker for Azure Functions.","fork":false,"url":"https://api.github.com/repos/Azure/azure-functions-python-worker","forks_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/forks","keys_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/teams","hooks_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/events","assignees_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/tags","blobs_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/subscription","commits_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/merges","archive_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/downloads","issues_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-functions-python-worker/deployments","created_at":"2018-01-16T19:23:54Z","updated_at":"2019-04-24T20:52:09Z","pushed_at":"2019-04-26T06:41:14Z","git_url":"git://github.com/Azure/azure-functions-python-worker.git","ssh_url":"[email protected]:Azure/azure-functions-python-worker.git","clone_url":"https://github.com/Azure/azure-functions-python-worker.git","svn_url":"https://github.com/Azure/azure-functions-python-worker","homepage":null,"size":556,"stargazers_count":138,"watchers_count":138,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":45,"watchers":138,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-functions-python-worker/pulls/389"},"html":{"href":"https://github.com/Azure/azure-functions-python-worker/pull/389"},"issue":{"href":"https://api.github.com/repos/Azure/azure-functions-python-worker/issues/389"},"comments":{"href":"https://api.github.com/repos/Azure/azure-functions-python-worker/issues/389/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-functions-python-worker/pulls/389/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-functions-python-worker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-functions-python-worker/pulls/389/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-functions-python-worker/statuses/781a75cea46041e9dacba6c0272df5d7372ce86f"}},"author_association":"NONE"}}
|
{
"id": 117730503,
"name": "Azure/azure-functions-python-worker",
"url": "https://api.github.com/repos/Azure/azure-functions-python-worker"
}
|
{
"id": 10415876,
"login": "priyaananthasankar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10415876?",
"url": "https://api.github.com/users/priyaananthasankar"
}
|
{
"id": 6844498,
"login": "Azure",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6844498?",
"url": "https://api.github.com/orgs/Azure"
}
| 2019-04-26T06:43:22 |
9515707491
|
{"actor":{"display_login":"priyaananthasankar"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/pulls/comments/317105014","pull_request_review_id":278964342,"id":317105014,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxNzEwNTAxNA==","diff_hunk":"@@ -21,6 +21,8 @@\n \n @Column private UUID caseId;\n \n+ @Column private String caseType;","path":"src/main/java/uk/gov/ons/census/casesvc/model/entity/Case.java","position":4,"original_position":4,"commit_id":"fba6083873f223404d18f57f08e6ad1034eb54c3","original_commit_id":"fba6083873f223404d18f57f08e6ad1034eb54c3","user":{"login":"NickGrantONS","id":41681172,"node_id":"MDQ6VXNlcjQxNjgxMTcy","avatar_url":"https://avatars2.githubusercontent.com/u/41681172?v=4","gravatar_id":"","url":"https://api.github.com/users/NickGrantONS","html_url":"https://github.com/NickGrantONS","followers_url":"https://api.github.com/users/NickGrantONS/followers","following_url":"https://api.github.com/users/NickGrantONS/following{/other_user}","gists_url":"https://api.github.com/users/NickGrantONS/gists{/gist_id}","starred_url":"https://api.github.com/users/NickGrantONS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickGrantONS/subscriptions","organizations_url":"https://api.github.com/users/NickGrantONS/orgs","repos_url":"https://api.github.com/users/NickGrantONS/repos","events_url":"https://api.github.com/users/NickGrantONS/events{/privacy}","received_events_url":"https://api.github.com/users/NickGrantONS/received_events","type":"User","site_admin":false},"body":"I guess it doesn't really matter, but any reason why this is top of the list? I would've put it after addressType, or maybe at the end","created_at":"2019-08-23T12:20:26Z","updated_at":"2019-08-23T12:20:26Z","html_url":"https://github.com/ONSdigital/census-rm-case-processor/pull/43#discussion_r317105014","pull_request_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/pulls/43","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/pulls/comments/317105014"},"html":{"href":"https://github.com/ONSdigital/census-rm-case-processor/pull/43#discussion_r317105014"},"pull_request":{"href":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/pulls/43"}}},"pull_request":{"url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/pulls/43","id":309090854,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA5MDkwODU0","html_url":"https://github.com/ONSdigital/census-rm-case-processor/pull/43","diff_url":"https://github.com/ONSdigital/census-rm-case-processor/pull/43.diff","patch_url":"https://github.com/ONSdigital/census-rm-case-processor/pull/43.patch","issue_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/issues/43","number":43,"state":"open","locked":false,"title":"Add Case Type to entity and default new case to household","user":{"login":"rjweeks","id":3774390,"node_id":"MDQ6VXNlcjM3NzQzOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/3774390?v=4","gravatar_id":"","url":"https://api.github.com/users/rjweeks","html_url":"https://github.com/rjweeks","followers_url":"https://api.github.com/users/rjweeks/followers","following_url":"https://api.github.com/users/rjweeks/following{/other_user}","gists_url":"https://api.github.com/users/rjweeks/gists{/gist_id}","starred_url":"https://api.github.com/users/rjweeks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjweeks/subscriptions","organizations_url":"https://api.github.com/users/rjweeks/orgs","repos_url":"https://api.github.com/users/rjweeks/repos","events_url":"https://api.github.com/users/rjweeks/events{/privacy}","received_events_url":"https://api.github.com/users/rjweeks/received_events","type":"User","site_admin":false},"body":"# Motivation and Context\r\nAdd new Case Type column to Case Processor and Action scheduler cases tables.\r\nThis will allow RM to differentiate a Household case from a Household individual PQ case.\r\n\r\n# What has changed\r\nEntity has a new CaseType field.\r\n\r\n# How to test?\r\nBuild new image and execute in Docker Dev and run acceptance tests.\r\n\r\n# Links\r\nhttps://trello.com/c/gUMjDkBu/1064-create-case-type-variable-to-differentiate-hh-and-hi-as-opposed-to-address-type-5\r\nONSdigital/census-rm-ddl#6\r\nhttps://github.com/ONSdigital/census-rm-action-scheduler/pull/29\r\nhttps://github.com/ONSdigital/census-rm-case-api/pull/26","created_at":"2019-08-20T14:50:58Z","updated_at":"2019-08-23T12:20:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa18acafdb0b89a5ea65e4b75feea221738f29e5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"davidmort","id":1504284,"node_id":"MDQ6VXNlcjE1MDQyODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1504284?v=4","gravatar_id":"","url":"https://api.github.com/users/davidmort","html_url":"https://github.com/davidmort","followers_url":"https://api.github.com/users/davidmort/followers","following_url":"https://api.github.com/users/davidmort/following{/other_user}","gists_url":"https://api.github.com/users/davidmort/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmort/subscriptions","organizations_url":"https://api.github.com/users/davidmort/orgs","repos_url":"https://api.github.com/users/davidmort/repos","events_url":"https://api.github.com/users/davidmort/events{/privacy}","received_events_url":"https://api.github.com/users/davidmort/received_events","type":"User","site_admin":false},{"login":"gavinleeedwards","id":26113492,"node_id":"MDQ6VXNlcjI2MTEzNDky","avatar_url":"https://avatars1.githubusercontent.com/u/26113492?v=4","gravatar_id":"","url":"https://api.github.com/users/gavinleeedwards","html_url":"https://github.com/gavinleeedwards","followers_url":"https://api.github.com/users/gavinleeedwards/followers","following_url":"https://api.github.com/users/gavinleeedwards/following{/other_user}","gists_url":"https://api.github.com/users/gavinleeedwards/gists{/gist_id}","starred_url":"https://api.github.com/users/gavinleeedwards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavinleeedwards/subscriptions","organizations_url":"https://api.github.com/users/gavinleeedwards/orgs","repos_url":"https://api.github.com/users/gavinleeedwards/repos","events_url":"https://api.github.com/users/gavinleeedwards/events{/privacy}","received_events_url":"https://api.github.com/users/gavinleeedwards/received_events","type":"User","site_admin":false},{"login":"AdamHawtin","id":35268982,"node_id":"MDQ6VXNlcjM1MjY4OTgy","avatar_url":"https://avatars2.githubusercontent.com/u/35268982?v=4","gravatar_id":"","url":"https://api.github.com/users/AdamHawtin","html_url":"https://github.com/AdamHawtin","followers_url":"https://api.github.com/users/AdamHawtin/followers","following_url":"https://api.github.com/users/AdamHawtin/following{/other_user}","gists_url":"https://api.github.com/users/AdamHawtin/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamHawtin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamHawtin/subscriptions","organizations_url":"https://api.github.com/users/AdamHawtin/orgs","repos_url":"https://api.github.com/users/AdamHawtin/repos","events_url":"https://api.github.com/users/AdamHawtin/events{/privacy}","received_events_url":"https://api.github.com/users/AdamHawtin/received_events","type":"User","site_admin":false},{"login":"ryangrundy7","id":35301276,"node_id":"MDQ6VXNlcjM1MzAxMjc2","avatar_url":"https://avatars2.githubusercontent.com/u/35301276?v=4","gravatar_id":"","url":"https://api.github.com/users/ryangrundy7","html_url":"https://github.com/ryangrundy7","followers_url":"https://api.github.com/users/ryangrundy7/followers","following_url":"https://api.github.com/users/ryangrundy7/following{/other_user}","gists_url":"https://api.github.com/users/ryangrundy7/gists{/gist_id}","starred_url":"https://api.github.com/users/ryangrundy7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryangrundy7/subscriptions","organizations_url":"https://api.github.com/users/ryangrundy7/orgs","repos_url":"https://api.github.com/users/ryangrundy7/repos","events_url":"https://api.github.com/users/ryangrundy7/events{/privacy}","received_events_url":"https://api.github.com/users/ryangrundy7/received_events","type":"User","site_admin":false},{"login":"LukeLoze1","id":44841627,"node_id":"MDQ6VXNlcjQ0ODQxNjI3","avatar_url":"https://avatars2.githubusercontent.com/u/44841627?v=4","gravatar_id":"","url":"https://api.github.com/users/LukeLoze1","html_url":"https://github.com/LukeLoze1","followers_url":"https://api.github.com/users/LukeLoze1/followers","following_url":"https://api.github.com/users/LukeLoze1/following{/other_user}","gists_url":"https://api.github.com/users/LukeLoze1/gists{/gist_id}","starred_url":"https://api.github.com/users/LukeLoze1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LukeLoze1/subscriptions","organizations_url":"https://api.github.com/users/LukeLoze1/orgs","repos_url":"https://api.github.com/users/LukeLoze1/repos","events_url":"https://api.github.com/users/LukeLoze1/events{/privacy}","received_events_url":"https://api.github.com/users/LukeLoze1/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/pulls/43/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/pulls/43/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/issues/43/comments","statuses_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/statuses/fba6083873f223404d18f57f08e6ad1034eb54c3","head":{"label":"ONSdigital:add-case-type","ref":"add-case-type","sha":"fba6083873f223404d18f57f08e6ad1034eb54c3","user":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":179069098,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkwNjkwOTg=","name":"census-rm-case-processor","full_name":"ONSdigital/census-rm-case-processor","private":false,"owner":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ONSdigital/census-rm-case-processor","description":"Case Service using latest versions of Java, Spring Integration and using DSL instead of XML for configuration.","fork":false,"url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor","forks_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/forks","keys_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/teams","hooks_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/events","assignees_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/tags","blobs_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/subscription","commits_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/merges","archive_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/downloads","issues_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/deployments","created_at":"2019-04-02T12:04:34Z","updated_at":"2019-08-22T06:49:52Z","pushed_at":"2019-08-23T12:15:01Z","git_url":"git://github.com/ONSdigital/census-rm-case-processor.git","ssh_url":"[email protected]:ONSdigital/census-rm-case-processor.git","clone_url":"https://github.com/ONSdigital/census-rm-case-processor.git","svn_url":"https://github.com/ONSdigital/census-rm-case-processor","homepage":null,"size":29928,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ONSdigital:master","ref":"master","sha":"101e89d0f7e181141815eed15f29de08d5cfa020","user":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":179069098,"node_id":"MDEwOlJlcG9zaXRvcnkxNzkwNjkwOTg=","name":"census-rm-case-processor","full_name":"ONSdigital/census-rm-case-processor","private":false,"owner":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ONSdigital/census-rm-case-processor","description":"Case Service using latest versions of Java, Spring Integration and using DSL instead of XML for configuration.","fork":false,"url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor","forks_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/forks","keys_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/teams","hooks_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/events","assignees_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/tags","blobs_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/subscription","commits_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/merges","archive_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/downloads","issues_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/deployments","created_at":"2019-04-02T12:04:34Z","updated_at":"2019-08-22T06:49:52Z","pushed_at":"2019-08-23T12:15:01Z","git_url":"git://github.com/ONSdigital/census-rm-case-processor.git","ssh_url":"[email protected]:ONSdigital/census-rm-case-processor.git","clone_url":"https://github.com/ONSdigital/census-rm-case-processor.git","svn_url":"https://github.com/ONSdigital/census-rm-case-processor","homepage":null,"size":29928,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/pulls/43"},"html":{"href":"https://github.com/ONSdigital/census-rm-case-processor/pull/43"},"issue":{"href":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/issues/43"},"comments":{"href":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/census-rm-case-processor/statuses/fba6083873f223404d18f57f08e6ad1034eb54c3"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 179069098,
"name": "ONSdigital/census-rm-case-processor",
"url": "https://api.github.com/repos/ONSdigital/census-rm-case-processor"
}
|
{
"id": 41681172,
"login": "NickGrantONS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/41681172?",
"url": "https://api.github.com/users/NickGrantONS"
}
|
{
"id": 6865137,
"login": "ONSdigital",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6865137?",
"url": "https://api.github.com/orgs/ONSdigital"
}
| 2019-08-23T12:20:26 |
10270689756
|
{"actor":{"display_login":"NickGrantONS"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ONSdigital/design-system/pulls/comments/360315638","pull_request_review_id":335165658,"id":360315638,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MDMxNTYzOA==","diff_hunk":"@@ -16,29 +16,47 @@\n {% endif %}\n \n {% set exclusiveClass = \" js-exclusive-group\" if params.mutuallyExclusive else \"\" %}\n-\n {% set input %}\n- <input\n- type=\"{{ type }}\"\n- id=\"{{ params.id }}\"\n- class=\"input input--text input-type__input {{ params.classes }}{{ exclusiveClass }}\"\n- {% if params.prefix or params.suffix %}title=\"{{ params.prefix.title if params.prefix }}{{ params.suffix.title if params.suffix }}\"{% endif %}\n- {% if params.name is defined %}name=\"{{ params.name }}\"{% endif %}\n- {% if params.accessiblePlaceholder is defined %}required{% endif %}\n- {% if params.value is defined %}value=\"{{ params.value }}\"{% endif %}\n- {% if params.accept is defined %}accept=\"{{ params.accept }}\"{% endif %}\n- {% if params.min is defined %}min=\"{{ params.min }}\"{% endif %}\n- {% if params.max is defined %}max=\"{{ params.max }}\"{% endif %}\n- {% if params.minLength is defined %}minlength=\"{{ params.minLength }}\"{% endif %}\n- {% if params.maxLength is defined %}maxlength=\"{{ params.maxLength }}\"{% endif %}\n- {% if pattern is defined %}pattern=\"{{ pattern }}\"{% endif %}\n- {% if inputmode is defined %}inputmode=\"{{ inputmode }}\"{% endif %}\n- {% if params.autocomplete is defined %}autocomplete=\"{{ params.autocomplete }}\"{% endif %}\n- {% if params.charcheck %}data-char-check-ref=\"{{ params.id }}-check-remaining\" data-char-check-num=\"{{ params.charcheck }}\"{% endif %}\n- {% if params.attributes %}{% for attribute, value in (params.attributes.items() if params.attributes is mapping and params.attributes.items else params.attributes) %}{{ attribute }}{% if value %}=\"{{ value }}\"{% endif %} {% endfor %}{% endif %}\n- />\n- {% endset %}\n+ {% if params.typeaheadData %}\n+ <div\n+ id=\"{{ params.id }}-container\"\n+ class=\"typeahead js-typeahead js-typeahead-input typeahead__input {% if params.classes %} {{ params.classes }}{% endif %}\"","path":"src/components/input/_macro.njk","position":29,"original_position":29,"commit_id":"a68d09ab503c140b2675aa35b4d6ad425c9df387","original_commit_id":"a68d09ab503c140b2675aa35b4d6ad425c9df387","user":{"login":"jrbarnes9","id":43346934,"node_id":"MDQ6VXNlcjQzMzQ2OTM0","avatar_url":"https://avatars3.githubusercontent.com/u/43346934?v=4","gravatar_id":"","url":"https://api.github.com/users/jrbarnes9","html_url":"https://github.com/jrbarnes9","followers_url":"https://api.github.com/users/jrbarnes9/followers","following_url":"https://api.github.com/users/jrbarnes9/following{/other_user}","gists_url":"https://api.github.com/users/jrbarnes9/gists{/gist_id}","starred_url":"https://api.github.com/users/jrbarnes9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrbarnes9/subscriptions","organizations_url":"https://api.github.com/users/jrbarnes9/orgs","repos_url":"https://api.github.com/users/jrbarnes9/repos","events_url":"https://api.github.com/users/jrbarnes9/events{/privacy}","received_events_url":"https://api.github.com/users/jrbarnes9/received_events","type":"User","site_admin":false},"body":"Don't think you need the repeated input classes here?","created_at":"2019-12-20T10:34:32Z","updated_at":"2019-12-20T10:45:48Z","html_url":"https://github.com/ONSdigital/design-system/pull/679#discussion_r360315638","pull_request_url":"https://api.github.com/repos/ONSdigital/design-system/pulls/679","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/design-system/pulls/comments/360315638"},"html":{"href":"https://github.com/ONSdigital/design-system/pull/679#discussion_r360315638"},"pull_request":{"href":"https://api.github.com/repos/ONSdigital/design-system/pulls/679"}}},"pull_request":{"url":"https://api.github.com/repos/ONSdigital/design-system/pulls/679","id":354041902,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU0MDQxOTAy","html_url":"https://github.com/ONSdigital/design-system/pull/679","diff_url":"https://github.com/ONSdigital/design-system/pull/679.diff","patch_url":"https://github.com/ONSdigital/design-system/pull/679.patch","issue_url":"https://api.github.com/repos/ONSdigital/design-system/issues/679","number":679,"state":"open","locked":false,"title":"Refactor typeahead","user":{"login":"rmccar","id":42928680,"node_id":"MDQ6VXNlcjQyOTI4Njgw","avatar_url":"https://avatars0.githubusercontent.com/u/42928680?v=4","gravatar_id":"","url":"https://api.github.com/users/rmccar","html_url":"https://github.com/rmccar","followers_url":"https://api.github.com/users/rmccar/followers","following_url":"https://api.github.com/users/rmccar/following{/other_user}","gists_url":"https://api.github.com/users/rmccar/gists{/gist_id}","starred_url":"https://api.github.com/users/rmccar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmccar/subscriptions","organizations_url":"https://api.github.com/users/rmccar/orgs","repos_url":"https://api.github.com/users/rmccar/repos","events_url":"https://api.github.com/users/rmccar/events{/privacy}","received_events_url":"https://api.github.com/users/rmccar/received_events","type":"User","site_admin":false},"body":"This PR is to refactor the typeahead component so that its functionality is added to the input component rather than being a separate component.","created_at":"2019-12-17T10:56:48Z","updated_at":"2019-12-20T10:45:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b44c4666e75b8597a54fdc708cceb4cae06fb788","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/design-system/pulls/679/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/design-system/pulls/679/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/design-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/design-system/issues/679/comments","statuses_url":"https://api.github.com/repos/ONSdigital/design-system/statuses/a68d09ab503c140b2675aa35b4d6ad425c9df387","head":{"label":"ONSdigital:refactor-typeahead-input","ref":"refactor-typeahead-input","sha":"a68d09ab503c140b2675aa35b4d6ad425c9df387","user":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":158716112,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg3MTYxMTI=","name":"design-system","full_name":"ONSdigital/design-system","private":false,"owner":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ONSdigital/design-system","description":"ONS Design System","fork":false,"url":"https://api.github.com/repos/ONSdigital/design-system","forks_url":"https://api.github.com/repos/ONSdigital/design-system/forks","keys_url":"https://api.github.com/repos/ONSdigital/design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/design-system/teams","hooks_url":"https://api.github.com/repos/ONSdigital/design-system/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/design-system/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/design-system/events","assignees_url":"https://api.github.com/repos/ONSdigital/design-system/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/design-system/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/design-system/tags","blobs_url":"https://api.github.com/repos/ONSdigital/design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/design-system/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/design-system/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/design-system/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/design-system/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/design-system/subscription","commits_url":"https://api.github.com/repos/ONSdigital/design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/design-system/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/design-system/merges","archive_url":"https://api.github.com/repos/ONSdigital/design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/design-system/downloads","issues_url":"https://api.github.com/repos/ONSdigital/design-system/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/design-system/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/design-system/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/design-system/deployments","created_at":"2018-11-22T15:08:37Z","updated_at":"2019-12-20T09:22:12Z","pushed_at":"2019-12-20T09:39:39Z","git_url":"git://github.com/ONSdigital/design-system.git","ssh_url":"[email protected]:ONSdigital/design-system.git","clone_url":"https://github.com/ONSdigital/design-system.git","svn_url":"https://github.com/ONSdigital/design-system","homepage":"https://ons-design-system.netlify.com","size":7985,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":84,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":84,"watchers":3,"default_branch":"master"}},"base":{"label":"ONSdigital:master","ref":"master","sha":"9b8ba7d2a591e1dd4955869898d156c21cae8072","user":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":158716112,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg3MTYxMTI=","name":"design-system","full_name":"ONSdigital/design-system","private":false,"owner":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ONSdigital/design-system","description":"ONS Design System","fork":false,"url":"https://api.github.com/repos/ONSdigital/design-system","forks_url":"https://api.github.com/repos/ONSdigital/design-system/forks","keys_url":"https://api.github.com/repos/ONSdigital/design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/design-system/teams","hooks_url":"https://api.github.com/repos/ONSdigital/design-system/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/design-system/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/design-system/events","assignees_url":"https://api.github.com/repos/ONSdigital/design-system/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/design-system/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/design-system/tags","blobs_url":"https://api.github.com/repos/ONSdigital/design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/design-system/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/design-system/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/design-system/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/design-system/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/design-system/subscription","commits_url":"https://api.github.com/repos/ONSdigital/design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/design-system/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/design-system/merges","archive_url":"https://api.github.com/repos/ONSdigital/design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/design-system/downloads","issues_url":"https://api.github.com/repos/ONSdigital/design-system/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/design-system/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/design-system/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/design-system/deployments","created_at":"2018-11-22T15:08:37Z","updated_at":"2019-12-20T09:22:12Z","pushed_at":"2019-12-20T09:39:39Z","git_url":"git://github.com/ONSdigital/design-system.git","ssh_url":"[email protected]:ONSdigital/design-system.git","clone_url":"https://github.com/ONSdigital/design-system.git","svn_url":"https://github.com/ONSdigital/design-system","homepage":"https://ons-design-system.netlify.com","size":7985,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":84,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":84,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/design-system/pulls/679"},"html":{"href":"https://github.com/ONSdigital/design-system/pull/679"},"issue":{"href":"https://api.github.com/repos/ONSdigital/design-system/issues/679"},"comments":{"href":"https://api.github.com/repos/ONSdigital/design-system/issues/679/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/design-system/pulls/679/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/design-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/design-system/pulls/679/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/design-system/statuses/a68d09ab503c140b2675aa35b4d6ad425c9df387"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 158716112,
"name": "ONSdigital/design-system",
"url": "https://api.github.com/repos/ONSdigital/design-system"
}
|
{
"id": 43346934,
"login": "jrbarnes9",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/43346934?",
"url": "https://api.github.com/users/jrbarnes9"
}
|
{
"id": 6865137,
"login": "ONSdigital",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6865137?",
"url": "https://api.github.com/orgs/ONSdigital"
}
| 2019-12-20T10:34:32 |
11134043271
|
{"actor":{"display_login":"jrbarnes9"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/363546993","pull_request_review_id":338976148,"id":363546993,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MzU0Njk5Mw==","diff_hunk":"@@ -13,66 +13,88 @@\n */\n package com.facebook.presto.cache;\n \n+import com.facebook.airlift.log.Logger;\n import org.apache.hadoop.conf.Configuration;\n+import org.apache.hadoop.fs.BlockLocation;\n+import org.apache.hadoop.fs.ContentSummary;\n+import org.apache.hadoop.fs.CreateFlag;\n import org.apache.hadoop.fs.FSDataInputStream;\n import org.apache.hadoop.fs.FSDataOutputStream;\n+import org.apache.hadoop.fs.FileAlreadyExistsException;\n+import org.apache.hadoop.fs.FileChecksum;\n import org.apache.hadoop.fs.FileStatus;\n import org.apache.hadoop.fs.FileSystem;\n+import org.apache.hadoop.fs.FsServerDefaults;\n+import org.apache.hadoop.fs.FsStatus;\n+import org.apache.hadoop.fs.Options;\n+import org.apache.hadoop.fs.ParentNotDirectoryException;\n import org.apache.hadoop.fs.Path;\n+import org.apache.hadoop.fs.RemoteIterator;\n+import org.apache.hadoop.fs.UnsupportedFileSystemException;\n+import org.apache.hadoop.fs.XAttrSetFlag;\n+import org.apache.hadoop.fs.permission.AclEntry;\n+import org.apache.hadoop.fs.permission.AclStatus;\n+import org.apache.hadoop.fs.permission.FsAction;\n import org.apache.hadoop.fs.permission.FsPermission;\n+import org.apache.hadoop.security.AccessControlException;\n+import org.apache.hadoop.security.Credentials;\n+import org.apache.hadoop.security.token.Token;\n import org.apache.hadoop.util.Progressable;\n \n+import java.io.FileNotFoundException;\n import java.io.IOException;\n import java.net.URI;\n+import java.util.EnumSet;\n+import java.util.List;\n+import java.util.Map;\n \n import static java.util.Objects.requireNonNull;\n \n public final class CachingFileSystem\n extends FileSystem\n {\n- private final URI workingDirectory;\n+ private static final Logger log = Logger.get(CachingFileSystem.class);\n+ private final URI uri;\n private final CacheManager cacheManager;\n private final FileSystem dataTier;\n private final boolean cacheValidationEnabled;\n \n public CachingFileSystem(\n- URI workingDirectory,\n+ URI uri,\n Configuration configuration,\n CacheManager cacheManager,\n FileSystem dataTier,\n boolean cacheValidationEnabled)\n {\n- requireNonNull(workingDirectory, \"uri is null\");\n requireNonNull(configuration, \"configuration is null\");\n-\n- this.workingDirectory = URI.create(workingDirectory.getScheme() + \"://\" + workingDirectory.getAuthority());\n+ this.uri = requireNonNull(uri, \"uri is null\");\n this.cacheManager = requireNonNull(cacheManager, \"cacheManager is null\");\n this.dataTier = requireNonNull(dataTier, \"dataTier is null\");\n this.cacheValidationEnabled = cacheValidationEnabled;\n \n setConf(configuration);\n \n //noinspection AssignmentToSuperclassField\n- statistics = getStatistics(workingDirectory.getScheme(), getClass());\n+ statistics = getStatistics(this.uri.getScheme(), getClass());","path":"presto-cache/src/main/java/com/facebook/presto/cache/CachingFileSystem.java","position":72,"original_position":72,"commit_id":"87c0a0cf728690d0f8d3a15ed8ab9f6eeaac00da","original_commit_id":"87c0a0cf728690d0f8d3a15ed8ab9f6eeaac00da","user":{"login":"jainxrohit","id":58183376,"node_id":"MDQ6VXNlcjU4MTgzMzc2","avatar_url":"https://avatars1.githubusercontent.com/u/58183376?v=4","gravatar_id":"","url":"https://api.github.com/users/jainxrohit","html_url":"https://github.com/jainxrohit","followers_url":"https://api.github.com/users/jainxrohit/followers","following_url":"https://api.github.com/users/jainxrohit/following{/other_user}","gists_url":"https://api.github.com/users/jainxrohit/gists{/gist_id}","starred_url":"https://api.github.com/users/jainxrohit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jainxrohit/subscriptions","organizations_url":"https://api.github.com/users/jainxrohit/orgs","repos_url":"https://api.github.com/users/jainxrohit/repos","events_url":"https://api.github.com/users/jainxrohit/events{/privacy}","received_events_url":"https://api.github.com/users/jainxrohit/received_events","type":"User","site_admin":false},"body":"This is in the constructor, and both parameter and member variable names are same. Even though both holds the same value, using this makes it clear which variable we are trying to use.","created_at":"2020-01-07T00:37:38Z","updated_at":"2020-01-07T00:37:38Z","html_url":"https://github.com/prestodb/presto/pull/13904#discussion_r363546993","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/13904","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/363546993"},"html":{"href":"https://github.com/prestodb/presto/pull/13904#discussion_r363546993"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/13904"}},"in_reply_to_id":363533235},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/13904","id":358209193,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU4MjA5MTkz","html_url":"https://github.com/prestodb/presto/pull/13904","diff_url":"https://github.com/prestodb/presto/pull/13904.diff","patch_url":"https://github.com/prestodb/presto/pull/13904.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/13904","number":13904,"state":"open","locked":false,"title":"Add caching file system to hive connector","user":{"login":"jainxrohit","id":58183376,"node_id":"MDQ6VXNlcjU4MTgzMzc2","avatar_url":"https://avatars1.githubusercontent.com/u/58183376?v=4","gravatar_id":"","url":"https://api.github.com/users/jainxrohit","html_url":"https://github.com/jainxrohit","followers_url":"https://api.github.com/users/jainxrohit/followers","following_url":"https://api.github.com/users/jainxrohit/following{/other_user}","gists_url":"https://api.github.com/users/jainxrohit/gists{/gist_id}","starred_url":"https://api.github.com/users/jainxrohit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jainxrohit/subscriptions","organizations_url":"https://api.github.com/users/jainxrohit/orgs","repos_url":"https://api.github.com/users/jainxrohit/repos","events_url":"https://api.github.com/users/jainxrohit/events{/privacy}","received_events_url":"https://api.github.com/users/jainxrohit/received_events","type":"User","site_admin":false},"body":"Add caching file system to hive connector","created_at":"2019-12-30T20:30:29Z","updated_at":"2020-01-07T00:37:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d78ffaa827d75c47dc3c587d06717828b92b27a6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shixuan-fan","id":12627919,"node_id":"MDQ6VXNlcjEyNjI3OTE5","avatar_url":"https://avatars1.githubusercontent.com/u/12627919?v=4","gravatar_id":"","url":"https://api.github.com/users/shixuan-fan","html_url":"https://github.com/shixuan-fan","followers_url":"https://api.github.com/users/shixuan-fan/followers","following_url":"https://api.github.com/users/shixuan-fan/following{/other_user}","gists_url":"https://api.github.com/users/shixuan-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/shixuan-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shixuan-fan/subscriptions","organizations_url":"https://api.github.com/users/shixuan-fan/orgs","repos_url":"https://api.github.com/users/shixuan-fan/repos","events_url":"https://api.github.com/users/shixuan-fan/events{/privacy}","received_events_url":"https://api.github.com/users/shixuan-fan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/13904/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/13904/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/13904/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/87c0a0cf728690d0f8d3a15ed8ab9f6eeaac00da","head":{"label":"jainxrohit:rj_caching_hive","ref":"rj_caching_hive","sha":"87c0a0cf728690d0f8d3a15ed8ab9f6eeaac00da","user":{"login":"jainxrohit","id":58183376,"node_id":"MDQ6VXNlcjU4MTgzMzc2","avatar_url":"https://avatars1.githubusercontent.com/u/58183376?v=4","gravatar_id":"","url":"https://api.github.com/users/jainxrohit","html_url":"https://github.com/jainxrohit","followers_url":"https://api.github.com/users/jainxrohit/followers","following_url":"https://api.github.com/users/jainxrohit/following{/other_user}","gists_url":"https://api.github.com/users/jainxrohit/gists{/gist_id}","starred_url":"https://api.github.com/users/jainxrohit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jainxrohit/subscriptions","organizations_url":"https://api.github.com/users/jainxrohit/orgs","repos_url":"https://api.github.com/users/jainxrohit/repos","events_url":"https://api.github.com/users/jainxrohit/events{/privacy}","received_events_url":"https://api.github.com/users/jainxrohit/received_events","type":"User","site_admin":false},"repo":{"id":223996232,"node_id":"MDEwOlJlcG9zaXRvcnkyMjM5OTYyMzI=","name":"presto","full_name":"jainxrohit/presto","private":false,"owner":{"login":"jainxrohit","id":58183376,"node_id":"MDQ6VXNlcjU4MTgzMzc2","avatar_url":"https://avatars1.githubusercontent.com/u/58183376?v=4","gravatar_id":"","url":"https://api.github.com/users/jainxrohit","html_url":"https://github.com/jainxrohit","followers_url":"https://api.github.com/users/jainxrohit/followers","following_url":"https://api.github.com/users/jainxrohit/following{/other_user}","gists_url":"https://api.github.com/users/jainxrohit/gists{/gist_id}","starred_url":"https://api.github.com/users/jainxrohit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jainxrohit/subscriptions","organizations_url":"https://api.github.com/users/jainxrohit/orgs","repos_url":"https://api.github.com/users/jainxrohit/repos","events_url":"https://api.github.com/users/jainxrohit/events{/privacy}","received_events_url":"https://api.github.com/users/jainxrohit/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jainxrohit/presto","description":"The official home of the Presto distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/jainxrohit/presto","forks_url":"https://api.github.com/repos/jainxrohit/presto/forks","keys_url":"https://api.github.com/repos/jainxrohit/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jainxrohit/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jainxrohit/presto/teams","hooks_url":"https://api.github.com/repos/jainxrohit/presto/hooks","issue_events_url":"https://api.github.com/repos/jainxrohit/presto/issues/events{/number}","events_url":"https://api.github.com/repos/jainxrohit/presto/events","assignees_url":"https://api.github.com/repos/jainxrohit/presto/assignees{/user}","branches_url":"https://api.github.com/repos/jainxrohit/presto/branches{/branch}","tags_url":"https://api.github.com/repos/jainxrohit/presto/tags","blobs_url":"https://api.github.com/repos/jainxrohit/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jainxrohit/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jainxrohit/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/jainxrohit/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jainxrohit/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/jainxrohit/presto/languages","stargazers_url":"https://api.github.com/repos/jainxrohit/presto/stargazers","contributors_url":"https://api.github.com/repos/jainxrohit/presto/contributors","subscribers_url":"https://api.github.com/repos/jainxrohit/presto/subscribers","subscription_url":"https://api.github.com/repos/jainxrohit/presto/subscription","commits_url":"https://api.github.com/repos/jainxrohit/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/jainxrohit/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/jainxrohit/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/jainxrohit/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/jainxrohit/presto/contents/{+path}","compare_url":"https://api.github.com/repos/jainxrohit/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jainxrohit/presto/merges","archive_url":"https://api.github.com/repos/jainxrohit/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jainxrohit/presto/downloads","issues_url":"https://api.github.com/repos/jainxrohit/presto/issues{/number}","pulls_url":"https://api.github.com/repos/jainxrohit/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/jainxrohit/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/jainxrohit/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jainxrohit/presto/labels{/name}","releases_url":"https://api.github.com/repos/jainxrohit/presto/releases{/id}","deployments_url":"https://api.github.com/repos/jainxrohit/presto/deployments","created_at":"2019-11-25T16:43:36Z","updated_at":"2020-01-06T02:06:20Z","pushed_at":"2020-01-06T23:02:45Z","git_url":"git://github.com/jainxrohit/presto.git","ssh_url":"[email protected]:jainxrohit/presto.git","clone_url":"https://github.com/jainxrohit/presto.git","svn_url":"https://github.com/jainxrohit/presto","homepage":"http://prestodb.github.io","size":123915,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"659c3ee91bbddfb0f61cce4c7bc544c4010f3633","user":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"node_id":"MDEwOlJlcG9zaXRvcnk1MzQ5NTY1","name":"presto","full_name":"prestodb/presto","private":false,"owner":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prestodb/presto","description":"The official home of the Presto distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2020-01-07T00:18:10Z","pushed_at":"2020-01-07T00:24:38Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"[email protected]:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"http://prestodb.github.io","size":124074,"stargazers_count":10042,"watchers_count":10042,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3450,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":979,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3450,"open_issues":979,"watchers":10042,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/13904"},"html":{"href":"https://github.com/prestodb/presto/pull/13904"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/13904"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/13904/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/13904/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/13904/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/87c0a0cf728690d0f8d3a15ed8ab9f6eeaac00da"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 5349565,
"name": "prestodb/presto",
"url": "https://api.github.com/repos/prestodb/presto"
}
|
{
"id": 58183376,
"login": "jainxrohit",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/58183376?",
"url": "https://api.github.com/users/jainxrohit"
}
|
{
"id": 6882181,
"login": "prestodb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6882181?",
"url": "https://api.github.com/orgs/prestodb"
}
| 2020-01-07T00:37:38 |
11215043222
|
{"actor":{"display_login":"jainxrohit"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/presto/pulls/comments/298640516","pull_request_review_id":255830731,"id":298640516,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5ODY0MDUxNg==","diff_hunk":"@@ -0,0 +1,144 @@\n+/*\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package com.facebook.presto.operator.aggregation.reservoirsample;\n+\n+import java.util.Arrays;\n+import java.util.concurrent.ThreadLocalRandom;\n+import java.util.stream.DoubleStream;\n+\n+import static com.google.common.base.Preconditions.checkArgument;\n+\n+public class UnweightedDoubleReservoirSample\n+ implements Cloneable\n+{\n+ protected int maxSamples;\n+ protected long count;\n+ double[] elements;\n+\n+ public UnweightedDoubleReservoirSample(int maxSamples)\n+ {\n+ this.maxSamples = maxSamples;\n+ checkArguments();","path":"presto-main/src/main/java/com/facebook/presto/operator/aggregation/reservoirsample/UnweightedDoubleReservoirSample.java","position":32,"original_position":32,"commit_id":"2d45ab30b1603a5f6631601e085914fb53e08c9a","original_commit_id":"2d45ab30b1603a5f6631601e085914fb53e08c9a","user":{"login":"atavory","id":7824605,"node_id":"MDQ6VXNlcjc4MjQ2MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/7824605?v=4","gravatar_id":"","url":"https://api.github.com/users/atavory","html_url":"https://github.com/atavory","followers_url":"https://api.github.com/users/atavory/followers","following_url":"https://api.github.com/users/atavory/following{/other_user}","gists_url":"https://api.github.com/users/atavory/gists{/gist_id}","starred_url":"https://api.github.com/users/atavory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atavory/subscriptions","organizations_url":"https://api.github.com/users/atavory/orgs","repos_url":"https://api.github.com/users/atavory/repos","events_url":"https://api.github.com/users/atavory/events{/privacy}","received_events_url":"https://api.github.com/users/atavory/received_events","type":"User","site_admin":false},"body":"I don't quite understand this comment. This constant is in some obscure inner class in the source code of general Presto. How do we know how much memory is running on other installations of Presto? At our installations in 5 years? \r\n\r\nThe type of constant you're suggesting doesn't seem to me to belong in the code, but rather by some tool used by someone installing and maintaining Presto. They can use cgroups for that without modifying the source code.","created_at":"2019-06-28T15:22:25Z","updated_at":"2019-06-28T15:22:25Z","html_url":"https://github.com/prestodb/presto/pull/12962#discussion_r298640516","pull_request_url":"https://api.github.com/repos/prestodb/presto/pulls/12962","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments/298640516"},"html":{"href":"https://github.com/prestodb/presto/pull/12962#discussion_r298640516"},"pull_request":{"href":"https://api.github.com/repos/prestodb/presto/pulls/12962"}},"in_reply_to_id":297743399},"pull_request":{"url":"https://api.github.com/repos/prestodb/presto/pulls/12962","id":289141436,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg5MTQxNDM2","html_url":"https://github.com/prestodb/presto/pull/12962","diff_url":"https://github.com/prestodb/presto/pull/12962.diff","patch_url":"https://github.com/prestodb/presto/pull/12962.patch","issue_url":"https://api.github.com/repos/prestodb/presto/issues/12962","number":12962,"state":"open","locked":false,"title":"[WIP] Reservoir sampling (unweighted + weighted)","user":{"login":"atavory","id":7824605,"node_id":"MDQ6VXNlcjc4MjQ2MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/7824605?v=4","gravatar_id":"","url":"https://api.github.com/users/atavory","html_url":"https://github.com/atavory","followers_url":"https://api.github.com/users/atavory/followers","following_url":"https://api.github.com/users/atavory/following{/other_user}","gists_url":"https://api.github.com/users/atavory/gists{/gist_id}","starred_url":"https://api.github.com/users/atavory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atavory/subscriptions","organizations_url":"https://api.github.com/users/atavory/orgs","repos_url":"https://api.github.com/users/atavory/repos","events_url":"https://api.github.com/users/atavory/events{/privacy}","received_events_url":"https://api.github.com/users/atavory/received_events","type":"User","site_admin":false},"body":"Data structures for reservoir sampling (unweighted + weighted).\r\n\r\nThe implementation aims to allow generic sampling across all types, but to performa as small as possible a number of boxing and unboxing. It utilizes the fact that as streams are processed, elements selected for samples become increasingly rare.","created_at":"2019-06-18T07:34:27Z","updated_at":"2019-06-28T15:22:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59ef465edae38374e532c8d6e22418e83ca2471d","assignee":{"login":"mbasmanova","id":27965151,"node_id":"MDQ6VXNlcjI3OTY1MTUx","avatar_url":"https://avatars3.githubusercontent.com/u/27965151?v=4","gravatar_id":"","url":"https://api.github.com/users/mbasmanova","html_url":"https://github.com/mbasmanova","followers_url":"https://api.github.com/users/mbasmanova/followers","following_url":"https://api.github.com/users/mbasmanova/following{/other_user}","gists_url":"https://api.github.com/users/mbasmanova/gists{/gist_id}","starred_url":"https://api.github.com/users/mbasmanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbasmanova/subscriptions","organizations_url":"https://api.github.com/users/mbasmanova/orgs","repos_url":"https://api.github.com/users/mbasmanova/repos","events_url":"https://api.github.com/users/mbasmanova/events{/privacy}","received_events_url":"https://api.github.com/users/mbasmanova/received_events","type":"User","site_admin":false},"assignees":[{"login":"mbasmanova","id":27965151,"node_id":"MDQ6VXNlcjI3OTY1MTUx","avatar_url":"https://avatars3.githubusercontent.com/u/27965151?v=4","gravatar_id":"","url":"https://api.github.com/users/mbasmanova","html_url":"https://github.com/mbasmanova","followers_url":"https://api.github.com/users/mbasmanova/followers","following_url":"https://api.github.com/users/mbasmanova/following{/other_user}","gists_url":"https://api.github.com/users/mbasmanova/gists{/gist_id}","starred_url":"https://api.github.com/users/mbasmanova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbasmanova/subscriptions","organizations_url":"https://api.github.com/users/mbasmanova/orgs","repos_url":"https://api.github.com/users/mbasmanova/repos","events_url":"https://api.github.com/users/mbasmanova/events{/privacy}","received_events_url":"https://api.github.com/users/mbasmanova/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196992743,"node_id":"MDU6TGFiZWwxOTY5OTI3NDM=","url":"https://api.github.com/repos/prestodb/presto/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/presto/pulls/12962/commits","review_comments_url":"https://api.github.com/repos/prestodb/presto/pulls/12962/comments","review_comment_url":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/presto/issues/12962/comments","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/2d45ab30b1603a5f6631601e085914fb53e08c9a","head":{"label":"atavory:reservoirs","ref":"reservoirs","sha":"2d45ab30b1603a5f6631601e085914fb53e08c9a","user":{"login":"atavory","id":7824605,"node_id":"MDQ6VXNlcjc4MjQ2MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/7824605?v=4","gravatar_id":"","url":"https://api.github.com/users/atavory","html_url":"https://github.com/atavory","followers_url":"https://api.github.com/users/atavory/followers","following_url":"https://api.github.com/users/atavory/following{/other_user}","gists_url":"https://api.github.com/users/atavory/gists{/gist_id}","starred_url":"https://api.github.com/users/atavory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atavory/subscriptions","organizations_url":"https://api.github.com/users/atavory/orgs","repos_url":"https://api.github.com/users/atavory/repos","events_url":"https://api.github.com/users/atavory/events{/privacy}","received_events_url":"https://api.github.com/users/atavory/received_events","type":"User","site_admin":false},"repo":{"id":184793881,"node_id":"MDEwOlJlcG9zaXRvcnkxODQ3OTM4ODE=","name":"presto","full_name":"atavory/presto","private":false,"owner":{"login":"atavory","id":7824605,"node_id":"MDQ6VXNlcjc4MjQ2MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/7824605?v=4","gravatar_id":"","url":"https://api.github.com/users/atavory","html_url":"https://github.com/atavory","followers_url":"https://api.github.com/users/atavory/followers","following_url":"https://api.github.com/users/atavory/following{/other_user}","gists_url":"https://api.github.com/users/atavory/gists{/gist_id}","starred_url":"https://api.github.com/users/atavory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atavory/subscriptions","organizations_url":"https://api.github.com/users/atavory/orgs","repos_url":"https://api.github.com/users/atavory/repos","events_url":"https://api.github.com/users/atavory/events{/privacy}","received_events_url":"https://api.github.com/users/atavory/received_events","type":"User","site_admin":false},"html_url":"https://github.com/atavory/presto","description":"The official home of the Presto distributed SQL query engine for big data","fork":true,"url":"https://api.github.com/repos/atavory/presto","forks_url":"https://api.github.com/repos/atavory/presto/forks","keys_url":"https://api.github.com/repos/atavory/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atavory/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atavory/presto/teams","hooks_url":"https://api.github.com/repos/atavory/presto/hooks","issue_events_url":"https://api.github.com/repos/atavory/presto/issues/events{/number}","events_url":"https://api.github.com/repos/atavory/presto/events","assignees_url":"https://api.github.com/repos/atavory/presto/assignees{/user}","branches_url":"https://api.github.com/repos/atavory/presto/branches{/branch}","tags_url":"https://api.github.com/repos/atavory/presto/tags","blobs_url":"https://api.github.com/repos/atavory/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atavory/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atavory/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/atavory/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atavory/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/atavory/presto/languages","stargazers_url":"https://api.github.com/repos/atavory/presto/stargazers","contributors_url":"https://api.github.com/repos/atavory/presto/contributors","subscribers_url":"https://api.github.com/repos/atavory/presto/subscribers","subscription_url":"https://api.github.com/repos/atavory/presto/subscription","commits_url":"https://api.github.com/repos/atavory/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/atavory/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/atavory/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/atavory/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/atavory/presto/contents/{+path}","compare_url":"https://api.github.com/repos/atavory/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atavory/presto/merges","archive_url":"https://api.github.com/repos/atavory/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atavory/presto/downloads","issues_url":"https://api.github.com/repos/atavory/presto/issues{/number}","pulls_url":"https://api.github.com/repos/atavory/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/atavory/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/atavory/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atavory/presto/labels{/name}","releases_url":"https://api.github.com/repos/atavory/presto/releases{/id}","deployments_url":"https://api.github.com/repos/atavory/presto/deployments","created_at":"2019-05-03T17:20:53Z","updated_at":"2019-05-03T17:21:15Z","pushed_at":"2019-06-28T13:26:46Z","git_url":"git://github.com/atavory/presto.git","ssh_url":"[email protected]:atavory/presto.git","clone_url":"https://github.com/atavory/presto.git","svn_url":"https://github.com/atavory/presto","homepage":"http://prestodb.github.io","size":114437,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"84b98dc03bb18afac0809a0a669c2a1de55959fa","user":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":5349565,"node_id":"MDEwOlJlcG9zaXRvcnk1MzQ5NTY1","name":"presto","full_name":"prestodb/presto","private":false,"owner":{"login":"prestodb","id":6882181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4ODIxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/6882181?v=4","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prestodb/presto","description":"The official home of the Presto distributed SQL query engine for big data","fork":false,"url":"https://api.github.com/repos/prestodb/presto","forks_url":"https://api.github.com/repos/prestodb/presto/forks","keys_url":"https://api.github.com/repos/prestodb/presto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/presto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/presto/teams","hooks_url":"https://api.github.com/repos/prestodb/presto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/presto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/presto/events","assignees_url":"https://api.github.com/repos/prestodb/presto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/presto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/presto/tags","blobs_url":"https://api.github.com/repos/prestodb/presto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/presto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/presto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/presto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/presto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/presto/languages","stargazers_url":"https://api.github.com/repos/prestodb/presto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/presto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/presto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/presto/subscription","commits_url":"https://api.github.com/repos/prestodb/presto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/presto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/presto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/presto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/presto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/presto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/presto/merges","archive_url":"https://api.github.com/repos/prestodb/presto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/presto/downloads","issues_url":"https://api.github.com/repos/prestodb/presto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/presto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/presto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/presto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/presto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/presto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/presto/deployments","created_at":"2012-08-09T01:03:37Z","updated_at":"2019-06-28T14:32:08Z","pushed_at":"2019-06-28T13:26:49Z","git_url":"git://github.com/prestodb/presto.git","ssh_url":"[email protected]:prestodb/presto.git","clone_url":"https://github.com/prestodb/presto.git","svn_url":"https://github.com/prestodb/presto","homepage":"http://prestodb.github.io","size":114603,"stargazers_count":9261,"watchers_count":9261,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3130,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":989,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3130,"open_issues":989,"watchers":9261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/presto/pulls/12962"},"html":{"href":"https://github.com/prestodb/presto/pull/12962"},"issue":{"href":"https://api.github.com/repos/prestodb/presto/issues/12962"},"comments":{"href":"https://api.github.com/repos/prestodb/presto/issues/12962/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/presto/pulls/12962/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/presto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/presto/pulls/12962/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/presto/statuses/2d45ab30b1603a5f6631601e085914fb53e08c9a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 5349565,
"name": "prestodb/presto",
"url": "https://api.github.com/repos/prestodb/presto"
}
|
{
"id": 7824605,
"login": "atavory",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7824605?",
"url": "https://api.github.com/users/atavory"
}
|
{
"id": 6882181,
"login": "prestodb",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6882181?",
"url": "https://api.github.com/orgs/prestodb"
}
| 2019-06-28T15:22:25 |
9914871542
|
{"actor":{"display_login":"atavory"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ethersphere/swarm/pulls/comments/310086825","pull_request_review_id":270116533,"id":310086825,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMDA4NjgyNQ==","diff_hunk":"@@ -0,0 +1,494 @@\n+// Copyright 2019 The Swarm Authors\n+// This file is part of the Swarm library.\n+//\n+// The Swarm library is free software: you can redistribute it and/or modify\n+// it under the terms of the GNU Lesser General Public License as published by\n+// the Free Software Foundation, either version 3 of the License, or\n+// (at your option) any later version.\n+//\n+// The Swarm library is distributed in the hope that it will be useful,\n+// but WITHOUT ANY WARRANTY; without even the implied warranty of\n+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+// GNU Lesser General Public License for more details.\n+//\n+// You should have received a copy of the GNU Lesser General Public License\n+// along with the Swarm library. If not, see <http://www.gnu.org/licenses/>.\n+\n+package pin\n+\n+import (\n+\t\"context\"\n+\t\"encoding/binary\"\n+\t\"encoding/hex\"\n+\t\"errors\"\n+\t\"sync\"\n+\n+\t\"github.com/ethersphere/swarm/api\"\n+\t\"github.com/ethersphere/swarm/chunk\"\n+\t\"github.com/ethersphere/swarm/log\"\n+\t\"github.com/ethersphere/swarm/state\"\n+\t\"github.com/ethersphere/swarm/storage\"\n+\t\"github.com/ethersphere/swarm/storage/localstore\"\n+)\n+\n+const (\n+\tVersion = \"1.0\"\n+\tWorkerChanSize = 8 // Max no of goroutines when walking the file tree\n+\tHeaderName = \"x-swarm-pin\" // Presence of this in header indicates pinning required\n+)\n+\n+var (\n+\terrInvalidChunkData = errors.New(\"invalid chunk data\")\n+)\n+\n+// FileInfo is the struct that stores the information about pinned files\n+// A map of this is stored in the state DB\n+type FileInfo struct {\n+\tisRaw bool\n+\tfileSize uint64\n+\tpinCounter uint64\n+}\n+\n+// MarshalBinary encodes the FileInfo object in to a binary form for storage\n+func (f *FileInfo) MarshalBinary() (data []byte, err error) {\n+\tdata = make([]byte, 17)\n+\tif f.isRaw {\n+\t\tdata[0] = 1\n+\t} else {\n+\t\tdata[0] = 0\n+\t}\n+\tbinary.BigEndian.PutUint64(data[1:], f.fileSize)\n+\tbinary.BigEndian.PutUint64(data[9:], f.pinCounter)\n+\treturn data, nil\n+}\n+\n+// UnmarshalBinary decodes the binary form from the state store to the FileInfo object\n+func (f *FileInfo) UnmarshalBinary(data []byte) error {","path":"storage/pin/pin.go","position":66,"original_position":66,"commit_id":"3ff9e963de159f31e6b31ed229e1b75743065d55","original_commit_id":"3ff9e963de159f31e6b31ed229e1b75743065d55","user":{"login":"janos","id":78134,"node_id":"MDQ6VXNlcjc4MTM0","avatar_url":"https://avatars0.githubusercontent.com/u/78134?v=4","gravatar_id":"","url":"https://api.github.com/users/janos","html_url":"https://github.com/janos","followers_url":"https://api.github.com/users/janos/followers","following_url":"https://api.github.com/users/janos/following{/other_user}","gists_url":"https://api.github.com/users/janos/gists{/gist_id}","starred_url":"https://api.github.com/users/janos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janos/subscriptions","organizations_url":"https://api.github.com/users/janos/orgs","repos_url":"https://api.github.com/users/janos/repos","events_url":"https://api.github.com/users/janos/events{/privacy}","received_events_url":"https://api.github.com/users/janos/received_events","type":"User","site_admin":false},"body":"It would be nice to add a check if data is at least 17 bytes long and return an error instead allowing to panic.","created_at":"2019-08-02T11:11:47Z","updated_at":"2019-08-02T11:25:04Z","html_url":"https://github.com/ethersphere/swarm/pull/1509#discussion_r310086825","pull_request_url":"https://api.github.com/repos/ethersphere/swarm/pulls/1509","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethersphere/swarm/pulls/comments/310086825"},"html":{"href":"https://github.com/ethersphere/swarm/pull/1509#discussion_r310086825"},"pull_request":{"href":"https://api.github.com/repos/ethersphere/swarm/pulls/1509"}}},"pull_request":{"url":"https://api.github.com/repos/ethersphere/swarm/pulls/1509","id":290874207,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwODc0MjA3","html_url":"https://github.com/ethersphere/swarm/pull/1509","diff_url":"https://github.com/ethersphere/swarm/pull/1509.diff","patch_url":"https://github.com/ethersphere/swarm/pull/1509.patch","issue_url":"https://api.github.com/repos/ethersphere/swarm/issues/1509","number":1509,"state":"open","locked":false,"title":"Pinning content","user":{"login":"jmozah","id":940575,"node_id":"MDQ6VXNlcjk0MDU3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/940575?v=4","gravatar_id":"","url":"https://api.github.com/users/jmozah","html_url":"https://github.com/jmozah","followers_url":"https://api.github.com/users/jmozah/followers","following_url":"https://api.github.com/users/jmozah/following{/other_user}","gists_url":"https://api.github.com/users/jmozah/gists{/gist_id}","starred_url":"https://api.github.com/users/jmozah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmozah/subscriptions","organizations_url":"https://api.github.com/users/jmozah/orgs","repos_url":"https://api.github.com/users/jmozah/repos","events_url":"https://api.github.com/users/jmozah/events{/privacy}","received_events_url":"https://api.github.com/users/jmozah/received_events","type":"User","site_admin":false},"body":"Useful Pinning Links:\r\n---------------------\r\nhttps://github.com/ethersphere/user-stories/issues/10\r\nhttps://swarmresear.ch/t/pinned-content-in-swarm/18\r\nhttps://github.com/ethersphere/swarm/issues/1274\r\n\r\n\r\n- Pin during upload \r\n - swarm up --pin <filename>)\r\n - Add a pin header in the http API\r\n - If header present, set the pin Counter to 1 for the file & the manifest in the retrievalDataIndex\r\n - Store the top level manifest/file hash in the pinIndex\r\n\r\n- Pin after upload\r\n - swarm pin <top level manifest/file hash>\r\n - Increase the pin counter for all the chunks in the merkle tree\r\n\r\n- Take care of different types of upload\r\n - Tar upload\r\n - Raw upload\r\n - Multipart upload\r\n\r\n- Unpin pinned content \r\n - swarm unpin <top level manifest/file hash>\r\n - decrement the pinCounter by 1 for the entire merkle tree\r\n\r\n- List pinned files\r\n - display all the top level hashes that are pinned\r\n - Also display their pin counters and size\r\n\r\n- During GC, don't collect pinned chunks \r\n\r\n- Display database structure for debug\r\n - show all the information in the DB. schema, fields, Index meta and Index contents.\r\n - echo '{\"jsonrpc\":\"2.0\",\"method\":\"pin_showDatabase\",\"id\":1'} | websocat ws://localhost:8546/ --origin localhost | jq \r\n\r\n\r\n--------- Not in this PR -----------\r\n- Fuse support\r\n - When adding a file to pinned mounted hash\r\n - When appending a file\r\n - When deleting a file\r\n\r\n- Pinning feeds\r\n - Creating a pinned feed\r\n - Updating a pinned feed","created_at":"2019-06-23T08:53:48Z","updated_at":"2019-08-02T11:25:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9308104e2ec9467c36fcbe6d1444680798cdc72d","assignee":{"login":"jmozah","id":940575,"node_id":"MDQ6VXNlcjk0MDU3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/940575?v=4","gravatar_id":"","url":"https://api.github.com/users/jmozah","html_url":"https://github.com/jmozah","followers_url":"https://api.github.com/users/jmozah/followers","following_url":"https://api.github.com/users/jmozah/following{/other_user}","gists_url":"https://api.github.com/users/jmozah/gists{/gist_id}","starred_url":"https://api.github.com/users/jmozah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmozah/subscriptions","organizations_url":"https://api.github.com/users/jmozah/orgs","repos_url":"https://api.github.com/users/jmozah/repos","events_url":"https://api.github.com/users/jmozah/events{/privacy}","received_events_url":"https://api.github.com/users/jmozah/received_events","type":"User","site_admin":false},"assignees":[{"login":"jmozah","id":940575,"node_id":"MDQ6VXNlcjk0MDU3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/940575?v=4","gravatar_id":"","url":"https://api.github.com/users/jmozah","html_url":"https://github.com/jmozah","followers_url":"https://api.github.com/users/jmozah/followers","following_url":"https://api.github.com/users/jmozah/following{/other_user}","gists_url":"https://api.github.com/users/jmozah/gists{/gist_id}","starred_url":"https://api.github.com/users/jmozah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmozah/subscriptions","organizations_url":"https://api.github.com/users/jmozah/orgs","repos_url":"https://api.github.com/users/jmozah/repos","events_url":"https://api.github.com/users/jmozah/events{/privacy}","received_events_url":"https://api.github.com/users/jmozah/received_events","type":"User","site_admin":false},{"login":"acud","id":12988138,"node_id":"MDQ6VXNlcjEyOTg4MTM4","avatar_url":"https://avatars2.githubusercontent.com/u/12988138?v=4","gravatar_id":"","url":"https://api.github.com/users/acud","html_url":"https://github.com/acud","followers_url":"https://api.github.com/users/acud/followers","following_url":"https://api.github.com/users/acud/following{/other_user}","gists_url":"https://api.github.com/users/acud/gists{/gist_id}","starred_url":"https://api.github.com/users/acud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acud/subscriptions","organizations_url":"https://api.github.com/users/acud/orgs","repos_url":"https://api.github.com/users/acud/repos","events_url":"https://api.github.com/users/acud/events{/privacy}","received_events_url":"https://api.github.com/users/acud/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"acud","id":12988138,"node_id":"MDQ6VXNlcjEyOTg4MTM4","avatar_url":"https://avatars2.githubusercontent.com/u/12988138?v=4","gravatar_id":"","url":"https://api.github.com/users/acud","html_url":"https://github.com/acud","followers_url":"https://api.github.com/users/acud/followers","following_url":"https://api.github.com/users/acud/following{/other_user}","gists_url":"https://api.github.com/users/acud/gists{/gist_id}","starred_url":"https://api.github.com/users/acud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acud/subscriptions","organizations_url":"https://api.github.com/users/acud/orgs","repos_url":"https://api.github.com/users/acud/repos","events_url":"https://api.github.com/users/acud/events{/privacy}","received_events_url":"https://api.github.com/users/acud/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":718019424,"node_id":"MDU6TGFiZWw3MTgwMTk0MjQ=","url":"https://api.github.com/repos/ethersphere/swarm/labels/ready%20for%20review","name":"ready for review","color":"44aa25","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ethersphere/swarm/pulls/1509/commits","review_comments_url":"https://api.github.com/repos/ethersphere/swarm/pulls/1509/comments","review_comment_url":"https://api.github.com/repos/ethersphere/swarm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethersphere/swarm/issues/1509/comments","statuses_url":"https://api.github.com/repos/ethersphere/swarm/statuses/3ff9e963de159f31e6b31ed229e1b75743065d55","head":{"label":"fairDataSociety:feat/pin","ref":"feat/pin","sha":"3ff9e963de159f31e6b31ed229e1b75743065d55","user":{"login":"fairDataSociety","id":45981195,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTgxMTk1","avatar_url":"https://avatars1.githubusercontent.com/u/45981195?v=4","gravatar_id":"","url":"https://api.github.com/users/fairDataSociety","html_url":"https://github.com/fairDataSociety","followers_url":"https://api.github.com/users/fairDataSociety/followers","following_url":"https://api.github.com/users/fairDataSociety/following{/other_user}","gists_url":"https://api.github.com/users/fairDataSociety/gists{/gist_id}","starred_url":"https://api.github.com/users/fairDataSociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fairDataSociety/subscriptions","organizations_url":"https://api.github.com/users/fairDataSociety/orgs","repos_url":"https://api.github.com/users/fairDataSociety/repos","events_url":"https://api.github.com/users/fairDataSociety/events{/privacy}","received_events_url":"https://api.github.com/users/fairDataSociety/received_events","type":"Organization","site_admin":false},"repo":{"id":192676135,"node_id":"MDEwOlJlcG9zaXRvcnkxOTI2NzYxMzU=","name":"swarm","full_name":"fairDataSociety/swarm","private":false,"owner":{"login":"fairDataSociety","id":45981195,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTgxMTk1","avatar_url":"https://avatars1.githubusercontent.com/u/45981195?v=4","gravatar_id":"","url":"https://api.github.com/users/fairDataSociety","html_url":"https://github.com/fairDataSociety","followers_url":"https://api.github.com/users/fairDataSociety/followers","following_url":"https://api.github.com/users/fairDataSociety/following{/other_user}","gists_url":"https://api.github.com/users/fairDataSociety/gists{/gist_id}","starred_url":"https://api.github.com/users/fairDataSociety/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fairDataSociety/subscriptions","organizations_url":"https://api.github.com/users/fairDataSociety/orgs","repos_url":"https://api.github.com/users/fairDataSociety/repos","events_url":"https://api.github.com/users/fairDataSociety/events{/privacy}","received_events_url":"https://api.github.com/users/fairDataSociety/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fairDataSociety/swarm","description":"Swarm: Censorship resistant storage and communication infrastructure for a truly sovereign digital society","fork":true,"url":"https://api.github.com/repos/fairDataSociety/swarm","forks_url":"https://api.github.com/repos/fairDataSociety/swarm/forks","keys_url":"https://api.github.com/repos/fairDataSociety/swarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fairDataSociety/swarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fairDataSociety/swarm/teams","hooks_url":"https://api.github.com/repos/fairDataSociety/swarm/hooks","issue_events_url":"https://api.github.com/repos/fairDataSociety/swarm/issues/events{/number}","events_url":"https://api.github.com/repos/fairDataSociety/swarm/events","assignees_url":"https://api.github.com/repos/fairDataSociety/swarm/assignees{/user}","branches_url":"https://api.github.com/repos/fairDataSociety/swarm/branches{/branch}","tags_url":"https://api.github.com/repos/fairDataSociety/swarm/tags","blobs_url":"https://api.github.com/repos/fairDataSociety/swarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fairDataSociety/swarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fairDataSociety/swarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/fairDataSociety/swarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fairDataSociety/swarm/statuses/{sha}","languages_url":"https://api.github.com/repos/fairDataSociety/swarm/languages","stargazers_url":"https://api.github.com/repos/fairDataSociety/swarm/stargazers","contributors_url":"https://api.github.com/repos/fairDataSociety/swarm/contributors","subscribers_url":"https://api.github.com/repos/fairDataSociety/swarm/subscribers","subscription_url":"https://api.github.com/repos/fairDataSociety/swarm/subscription","commits_url":"https://api.github.com/repos/fairDataSociety/swarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/fairDataSociety/swarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/fairDataSociety/swarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/fairDataSociety/swarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/fairDataSociety/swarm/contents/{+path}","compare_url":"https://api.github.com/repos/fairDataSociety/swarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fairDataSociety/swarm/merges","archive_url":"https://api.github.com/repos/fairDataSociety/swarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fairDataSociety/swarm/downloads","issues_url":"https://api.github.com/repos/fairDataSociety/swarm/issues{/number}","pulls_url":"https://api.github.com/repos/fairDataSociety/swarm/pulls{/number}","milestones_url":"https://api.github.com/repos/fairDataSociety/swarm/milestones{/number}","notifications_url":"https://api.github.com/repos/fairDataSociety/swarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fairDataSociety/swarm/labels{/name}","releases_url":"https://api.github.com/repos/fairDataSociety/swarm/releases{/id}","deployments_url":"https://api.github.com/repos/fairDataSociety/swarm/deployments","created_at":"2019-06-19T06:54:40Z","updated_at":"2019-08-02T06:17:51Z","pushed_at":"2019-08-02T06:17:49Z","git_url":"git://github.com/fairDataSociety/swarm.git","ssh_url":"[email protected]:fairDataSociety/swarm.git","clone_url":"https://github.com/fairDataSociety/swarm.git","svn_url":"https://github.com/fairDataSociety/swarm","homepage":"https://swarm.ethereum.org/","size":129011,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ethersphere:master","ref":"master","sha":"c099733cbc1935d480fa7b78931eb151f32b3bb5","user":{"login":"ethersphere","id":6946989,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NDY5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6946989?v=4","gravatar_id":"","url":"https://api.github.com/users/ethersphere","html_url":"https://github.com/ethersphere","followers_url":"https://api.github.com/users/ethersphere/followers","following_url":"https://api.github.com/users/ethersphere/following{/other_user}","gists_url":"https://api.github.com/users/ethersphere/gists{/gist_id}","starred_url":"https://api.github.com/users/ethersphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethersphere/subscriptions","organizations_url":"https://api.github.com/users/ethersphere/orgs","repos_url":"https://api.github.com/users/ethersphere/repos","events_url":"https://api.github.com/users/ethersphere/events{/privacy}","received_events_url":"https://api.github.com/users/ethersphere/received_events","type":"Organization","site_admin":false},"repo":{"id":17790136,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc5MDEzNg==","name":"swarm","full_name":"ethersphere/swarm","private":false,"owner":{"login":"ethersphere","id":6946989,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NDY5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6946989?v=4","gravatar_id":"","url":"https://api.github.com/users/ethersphere","html_url":"https://github.com/ethersphere","followers_url":"https://api.github.com/users/ethersphere/followers","following_url":"https://api.github.com/users/ethersphere/following{/other_user}","gists_url":"https://api.github.com/users/ethersphere/gists{/gist_id}","starred_url":"https://api.github.com/users/ethersphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethersphere/subscriptions","organizations_url":"https://api.github.com/users/ethersphere/orgs","repos_url":"https://api.github.com/users/ethersphere/repos","events_url":"https://api.github.com/users/ethersphere/events{/privacy}","received_events_url":"https://api.github.com/users/ethersphere/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethersphere/swarm","description":"Swarm: Censorship resistant storage and communication infrastructure for a truly sovereign digital society","fork":false,"url":"https://api.github.com/repos/ethersphere/swarm","forks_url":"https://api.github.com/repos/ethersphere/swarm/forks","keys_url":"https://api.github.com/repos/ethersphere/swarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethersphere/swarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethersphere/swarm/teams","hooks_url":"https://api.github.com/repos/ethersphere/swarm/hooks","issue_events_url":"https://api.github.com/repos/ethersphere/swarm/issues/events{/number}","events_url":"https://api.github.com/repos/ethersphere/swarm/events","assignees_url":"https://api.github.com/repos/ethersphere/swarm/assignees{/user}","branches_url":"https://api.github.com/repos/ethersphere/swarm/branches{/branch}","tags_url":"https://api.github.com/repos/ethersphere/swarm/tags","blobs_url":"https://api.github.com/repos/ethersphere/swarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethersphere/swarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethersphere/swarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethersphere/swarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethersphere/swarm/statuses/{sha}","languages_url":"https://api.github.com/repos/ethersphere/swarm/languages","stargazers_url":"https://api.github.com/repos/ethersphere/swarm/stargazers","contributors_url":"https://api.github.com/repos/ethersphere/swarm/contributors","subscribers_url":"https://api.github.com/repos/ethersphere/swarm/subscribers","subscription_url":"https://api.github.com/repos/ethersphere/swarm/subscription","commits_url":"https://api.github.com/repos/ethersphere/swarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethersphere/swarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethersphere/swarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethersphere/swarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethersphere/swarm/contents/{+path}","compare_url":"https://api.github.com/repos/ethersphere/swarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethersphere/swarm/merges","archive_url":"https://api.github.com/repos/ethersphere/swarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethersphere/swarm/downloads","issues_url":"https://api.github.com/repos/ethersphere/swarm/issues{/number}","pulls_url":"https://api.github.com/repos/ethersphere/swarm/pulls{/number}","milestones_url":"https://api.github.com/repos/ethersphere/swarm/milestones{/number}","notifications_url":"https://api.github.com/repos/ethersphere/swarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethersphere/swarm/labels{/name}","releases_url":"https://api.github.com/repos/ethersphere/swarm/releases{/id}","deployments_url":"https://api.github.com/repos/ethersphere/swarm/deployments","created_at":"2014-03-16T02:06:34Z","updated_at":"2019-08-02T02:24:58Z","pushed_at":"2019-08-02T09:57:11Z","git_url":"git://github.com/ethersphere/swarm.git","ssh_url":"[email protected]:ethersphere/swarm.git","clone_url":"https://github.com/ethersphere/swarm.git","svn_url":"https://github.com/ethersphere/swarm","homepage":"https://swarm.ethereum.org/","size":128682,"stargazers_count":185,"watchers_count":185,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":248,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":55,"open_issues":248,"watchers":185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethersphere/swarm/pulls/1509"},"html":{"href":"https://github.com/ethersphere/swarm/pull/1509"},"issue":{"href":"https://api.github.com/repos/ethersphere/swarm/issues/1509"},"comments":{"href":"https://api.github.com/repos/ethersphere/swarm/issues/1509/comments"},"review_comments":{"href":"https://api.github.com/repos/ethersphere/swarm/pulls/1509/comments"},"review_comment":{"href":"https://api.github.com/repos/ethersphere/swarm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethersphere/swarm/pulls/1509/commits"},"statuses":{"href":"https://api.github.com/repos/ethersphere/swarm/statuses/3ff9e963de159f31e6b31ed229e1b75743065d55"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 17790136,
"name": "ethersphere/swarm",
"url": "https://api.github.com/repos/ethersphere/swarm"
}
|
{
"id": 78134,
"login": "janos",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/78134?",
"url": "https://api.github.com/users/janos"
}
|
{
"id": 6946989,
"login": "ethersphere",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6946989?",
"url": "https://api.github.com/orgs/ethersphere"
}
| 2019-08-02T11:11:47 |
10135882615
|
{"actor":{"display_login":"janos"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ethersphere/swarm/pulls/comments/337051017","pull_request_review_id":304606012,"id":337051017,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNzA1MTAxNw==","diff_hunk":"@@ -1818,6 +1819,58 @@ func TestPeerGetLastSentCumulativePayout(t *testing.T) {\n \t}\n }\n \n+func TestAvailableBalance(t *testing.T) {\n+\ttestBackend := newTestBackend()\n+\tdefer testBackend.Close()\n+\tswap, clean := newTestSwap(t, ownerKey, testBackend)\n+\n+\t// deposit 100\n+\tdepositAmount := big.NewInt(100)\n+\topts := bind.NewKeyedTransactor(swap.owner.privateKey)\n+\topts.Context = context.TODO()\n+\t_, err := swap.contract.Deposit(opts, swap.backend, depositAmount)","path":"swap/swap_test.go","position":null,"original_position":30,"commit_id":"075c322389043a2c3bf3701abf6b713b00d877a9","original_commit_id":"6eb0a57eac114e61058f6f163e0e45e337571683","user":{"login":"Eknir","id":33000441,"node_id":"MDQ6VXNlcjMzMDAwNDQx","avatar_url":"https://avatars0.githubusercontent.com/u/33000441?v=4","gravatar_id":"","url":"https://api.github.com/users/Eknir","html_url":"https://github.com/Eknir","followers_url":"https://api.github.com/users/Eknir/followers","following_url":"https://api.github.com/users/Eknir/following{/other_user}","gists_url":"https://api.github.com/users/Eknir/gists{/gist_id}","starred_url":"https://api.github.com/users/Eknir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eknir/subscriptions","organizations_url":"https://api.github.com/users/Eknir/orgs","repos_url":"https://api.github.com/users/Eknir/repos","events_url":"https://api.github.com/users/Eknir/events{/privacy}","received_events_url":"https://api.github.com/users/Eknir/received_events","type":"User","site_admin":false},"body":"Added a test that verifies that the transaction did not revert.","created_at":"2019-10-21T14:30:33Z","updated_at":"2019-10-21T14:30:34Z","html_url":"https://github.com/ethersphere/swarm/pull/1892#discussion_r337051017","pull_request_url":"https://api.github.com/repos/ethersphere/swarm/pulls/1892","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethersphere/swarm/pulls/comments/337051017"},"html":{"href":"https://github.com/ethersphere/swarm/pull/1892#discussion_r337051017"},"pull_request":{"href":"https://api.github.com/repos/ethersphere/swarm/pulls/1892"}},"in_reply_to_id":336643471},"pull_request":{"url":"https://api.github.com/repos/ethersphere/swarm/pulls/1892","id":329822751,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI5ODIyNzUx","html_url":"https://github.com/ethersphere/swarm/pull/1892","diff_url":"https://github.com/ethersphere/swarm/pull/1892.diff","patch_url":"https://github.com/ethersphere/swarm/pull/1892.patch","issue_url":"https://api.github.com/repos/ethersphere/swarm/issues/1892","number":1892,"state":"open","locked":false,"title":"Swap available balance","user":{"login":"Eknir","id":33000441,"node_id":"MDQ6VXNlcjMzMDAwNDQx","avatar_url":"https://avatars0.githubusercontent.com/u/33000441?v=4","gravatar_id":"","url":"https://api.github.com/users/Eknir","html_url":"https://github.com/Eknir","followers_url":"https://api.github.com/users/Eknir/followers","following_url":"https://api.github.com/users/Eknir/following{/other_user}","gists_url":"https://api.github.com/users/Eknir/gists{/gist_id}","starred_url":"https://api.github.com/users/Eknir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eknir/subscriptions","organizations_url":"https://api.github.com/users/Eknir/orgs","repos_url":"https://api.github.com/users/Eknir/repos","events_url":"https://api.github.com/users/Eknir/events{/privacy}","received_events_url":"https://api.github.com/users/Eknir/received_events","type":"User","site_admin":false},"body":"#1884 ","created_at":"2019-10-18T16:25:40Z","updated_at":"2019-10-21T14:30:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab7eb40673ce30b0a6cd4316864fa755662cbf01","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1398400111,"node_id":"MDU6TGFiZWwxMzk4NDAwMTEx","url":"https://api.github.com/repos/ethersphere/swarm/labels/incentives","name":"incentives","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ethersphere/swarm/pulls/1892/commits","review_comments_url":"https://api.github.com/repos/ethersphere/swarm/pulls/1892/comments","review_comment_url":"https://api.github.com/repos/ethersphere/swarm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethersphere/swarm/issues/1892/comments","statuses_url":"https://api.github.com/repos/ethersphere/swarm/statuses/075c322389043a2c3bf3701abf6b713b00d877a9","head":{"label":"ethersphere:swap-available-balance","ref":"swap-available-balance","sha":"075c322389043a2c3bf3701abf6b713b00d877a9","user":{"login":"ethersphere","id":6946989,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NDY5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6946989?v=4","gravatar_id":"","url":"https://api.github.com/users/ethersphere","html_url":"https://github.com/ethersphere","followers_url":"https://api.github.com/users/ethersphere/followers","following_url":"https://api.github.com/users/ethersphere/following{/other_user}","gists_url":"https://api.github.com/users/ethersphere/gists{/gist_id}","starred_url":"https://api.github.com/users/ethersphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethersphere/subscriptions","organizations_url":"https://api.github.com/users/ethersphere/orgs","repos_url":"https://api.github.com/users/ethersphere/repos","events_url":"https://api.github.com/users/ethersphere/events{/privacy}","received_events_url":"https://api.github.com/users/ethersphere/received_events","type":"Organization","site_admin":false},"repo":{"id":17790136,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc5MDEzNg==","name":"swarm","full_name":"ethersphere/swarm","private":false,"owner":{"login":"ethersphere","id":6946989,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NDY5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6946989?v=4","gravatar_id":"","url":"https://api.github.com/users/ethersphere","html_url":"https://github.com/ethersphere","followers_url":"https://api.github.com/users/ethersphere/followers","following_url":"https://api.github.com/users/ethersphere/following{/other_user}","gists_url":"https://api.github.com/users/ethersphere/gists{/gist_id}","starred_url":"https://api.github.com/users/ethersphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethersphere/subscriptions","organizations_url":"https://api.github.com/users/ethersphere/orgs","repos_url":"https://api.github.com/users/ethersphere/repos","events_url":"https://api.github.com/users/ethersphere/events{/privacy}","received_events_url":"https://api.github.com/users/ethersphere/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethersphere/swarm","description":"Swarm: Censorship resistant storage and communication infrastructure for a truly sovereign digital society","fork":false,"url":"https://api.github.com/repos/ethersphere/swarm","forks_url":"https://api.github.com/repos/ethersphere/swarm/forks","keys_url":"https://api.github.com/repos/ethersphere/swarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethersphere/swarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethersphere/swarm/teams","hooks_url":"https://api.github.com/repos/ethersphere/swarm/hooks","issue_events_url":"https://api.github.com/repos/ethersphere/swarm/issues/events{/number}","events_url":"https://api.github.com/repos/ethersphere/swarm/events","assignees_url":"https://api.github.com/repos/ethersphere/swarm/assignees{/user}","branches_url":"https://api.github.com/repos/ethersphere/swarm/branches{/branch}","tags_url":"https://api.github.com/repos/ethersphere/swarm/tags","blobs_url":"https://api.github.com/repos/ethersphere/swarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethersphere/swarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethersphere/swarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethersphere/swarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethersphere/swarm/statuses/{sha}","languages_url":"https://api.github.com/repos/ethersphere/swarm/languages","stargazers_url":"https://api.github.com/repos/ethersphere/swarm/stargazers","contributors_url":"https://api.github.com/repos/ethersphere/swarm/contributors","subscribers_url":"https://api.github.com/repos/ethersphere/swarm/subscribers","subscription_url":"https://api.github.com/repos/ethersphere/swarm/subscription","commits_url":"https://api.github.com/repos/ethersphere/swarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethersphere/swarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethersphere/swarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethersphere/swarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethersphere/swarm/contents/{+path}","compare_url":"https://api.github.com/repos/ethersphere/swarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethersphere/swarm/merges","archive_url":"https://api.github.com/repos/ethersphere/swarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethersphere/swarm/downloads","issues_url":"https://api.github.com/repos/ethersphere/swarm/issues{/number}","pulls_url":"https://api.github.com/repos/ethersphere/swarm/pulls{/number}","milestones_url":"https://api.github.com/repos/ethersphere/swarm/milestones{/number}","notifications_url":"https://api.github.com/repos/ethersphere/swarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethersphere/swarm/labels{/name}","releases_url":"https://api.github.com/repos/ethersphere/swarm/releases{/id}","deployments_url":"https://api.github.com/repos/ethersphere/swarm/deployments","created_at":"2014-03-16T02:06:34Z","updated_at":"2019-10-21T13:30:17Z","pushed_at":"2019-10-21T14:08:31Z","git_url":"git://github.com/ethersphere/swarm.git","ssh_url":"[email protected]:ethersphere/swarm.git","clone_url":"https://github.com/ethersphere/swarm.git","svn_url":"https://github.com/ethersphere/swarm","homepage":"https://swarm.ethereum.org/","size":135909,"stargazers_count":204,"watchers_count":204,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":263,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":65,"open_issues":263,"watchers":204,"default_branch":"master"}},"base":{"label":"ethersphere:master","ref":"master","sha":"6de3928ee2a8f02bd0e26fbc76739c273e49626a","user":{"login":"ethersphere","id":6946989,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NDY5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6946989?v=4","gravatar_id":"","url":"https://api.github.com/users/ethersphere","html_url":"https://github.com/ethersphere","followers_url":"https://api.github.com/users/ethersphere/followers","following_url":"https://api.github.com/users/ethersphere/following{/other_user}","gists_url":"https://api.github.com/users/ethersphere/gists{/gist_id}","starred_url":"https://api.github.com/users/ethersphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethersphere/subscriptions","organizations_url":"https://api.github.com/users/ethersphere/orgs","repos_url":"https://api.github.com/users/ethersphere/repos","events_url":"https://api.github.com/users/ethersphere/events{/privacy}","received_events_url":"https://api.github.com/users/ethersphere/received_events","type":"Organization","site_admin":false},"repo":{"id":17790136,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc5MDEzNg==","name":"swarm","full_name":"ethersphere/swarm","private":false,"owner":{"login":"ethersphere","id":6946989,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NDY5ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/6946989?v=4","gravatar_id":"","url":"https://api.github.com/users/ethersphere","html_url":"https://github.com/ethersphere","followers_url":"https://api.github.com/users/ethersphere/followers","following_url":"https://api.github.com/users/ethersphere/following{/other_user}","gists_url":"https://api.github.com/users/ethersphere/gists{/gist_id}","starred_url":"https://api.github.com/users/ethersphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethersphere/subscriptions","organizations_url":"https://api.github.com/users/ethersphere/orgs","repos_url":"https://api.github.com/users/ethersphere/repos","events_url":"https://api.github.com/users/ethersphere/events{/privacy}","received_events_url":"https://api.github.com/users/ethersphere/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethersphere/swarm","description":"Swarm: Censorship resistant storage and communication infrastructure for a truly sovereign digital society","fork":false,"url":"https://api.github.com/repos/ethersphere/swarm","forks_url":"https://api.github.com/repos/ethersphere/swarm/forks","keys_url":"https://api.github.com/repos/ethersphere/swarm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethersphere/swarm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethersphere/swarm/teams","hooks_url":"https://api.github.com/repos/ethersphere/swarm/hooks","issue_events_url":"https://api.github.com/repos/ethersphere/swarm/issues/events{/number}","events_url":"https://api.github.com/repos/ethersphere/swarm/events","assignees_url":"https://api.github.com/repos/ethersphere/swarm/assignees{/user}","branches_url":"https://api.github.com/repos/ethersphere/swarm/branches{/branch}","tags_url":"https://api.github.com/repos/ethersphere/swarm/tags","blobs_url":"https://api.github.com/repos/ethersphere/swarm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethersphere/swarm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethersphere/swarm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethersphere/swarm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethersphere/swarm/statuses/{sha}","languages_url":"https://api.github.com/repos/ethersphere/swarm/languages","stargazers_url":"https://api.github.com/repos/ethersphere/swarm/stargazers","contributors_url":"https://api.github.com/repos/ethersphere/swarm/contributors","subscribers_url":"https://api.github.com/repos/ethersphere/swarm/subscribers","subscription_url":"https://api.github.com/repos/ethersphere/swarm/subscription","commits_url":"https://api.github.com/repos/ethersphere/swarm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethersphere/swarm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethersphere/swarm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethersphere/swarm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethersphere/swarm/contents/{+path}","compare_url":"https://api.github.com/repos/ethersphere/swarm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethersphere/swarm/merges","archive_url":"https://api.github.com/repos/ethersphere/swarm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethersphere/swarm/downloads","issues_url":"https://api.github.com/repos/ethersphere/swarm/issues{/number}","pulls_url":"https://api.github.com/repos/ethersphere/swarm/pulls{/number}","milestones_url":"https://api.github.com/repos/ethersphere/swarm/milestones{/number}","notifications_url":"https://api.github.com/repos/ethersphere/swarm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethersphere/swarm/labels{/name}","releases_url":"https://api.github.com/repos/ethersphere/swarm/releases{/id}","deployments_url":"https://api.github.com/repos/ethersphere/swarm/deployments","created_at":"2014-03-16T02:06:34Z","updated_at":"2019-10-21T13:30:17Z","pushed_at":"2019-10-21T14:08:31Z","git_url":"git://github.com/ethersphere/swarm.git","ssh_url":"[email protected]:ethersphere/swarm.git","clone_url":"https://github.com/ethersphere/swarm.git","svn_url":"https://github.com/ethersphere/swarm","homepage":"https://swarm.ethereum.org/","size":135909,"stargazers_count":204,"watchers_count":204,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":263,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":65,"open_issues":263,"watchers":204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethersphere/swarm/pulls/1892"},"html":{"href":"https://github.com/ethersphere/swarm/pull/1892"},"issue":{"href":"https://api.github.com/repos/ethersphere/swarm/issues/1892"},"comments":{"href":"https://api.github.com/repos/ethersphere/swarm/issues/1892/comments"},"review_comments":{"href":"https://api.github.com/repos/ethersphere/swarm/pulls/1892/comments"},"review_comment":{"href":"https://api.github.com/repos/ethersphere/swarm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethersphere/swarm/pulls/1892/commits"},"statuses":{"href":"https://api.github.com/repos/ethersphere/swarm/statuses/075c322389043a2c3bf3701abf6b713b00d877a9"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 17790136,
"name": "ethersphere/swarm",
"url": "https://api.github.com/repos/ethersphere/swarm"
}
|
{
"id": 33000441,
"login": "Eknir",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/33000441?",
"url": "https://api.github.com/users/Eknir"
}
|
{
"id": 6946989,
"login": "ethersphere",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6946989?",
"url": "https://api.github.com/orgs/ethersphere"
}
| 2019-10-21T14:30:33 |
10676866085
|
{"actor":{"display_login":"Eknir"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/pulls/comments/344660634","pull_request_review_id":314829812,"id":344660634,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0NDY2MDYzNA==","diff_hunk":"@@ -0,0 +1,174 @@\n+@import '../../../angular-core/styles/common/colors';","path":"projects/sbb-esta/angular-business/dialog/src/_dialog.scss","position":1,"original_position":1,"commit_id":"0243614e89463c9bc008eb890637159a3da70f79","original_commit_id":"f1028d6710d3e61cc560e2de5e1aaba7055ae202","user":{"login":"vlanz","id":17550954,"node_id":"MDQ6VXNlcjE3NTUwOTU0","avatar_url":"https://avatars3.githubusercontent.com/u/17550954?v=4","gravatar_id":"","url":"https://api.github.com/users/vlanz","html_url":"https://github.com/vlanz","followers_url":"https://api.github.com/users/vlanz/followers","following_url":"https://api.github.com/users/vlanz/following{/other_user}","gists_url":"https://api.github.com/users/vlanz/gists{/gist_id}","starred_url":"https://api.github.com/users/vlanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlanz/subscriptions","organizations_url":"https://api.github.com/users/vlanz/orgs","repos_url":"https://api.github.com/users/vlanz/repos","events_url":"https://api.github.com/users/vlanz/events{/privacy}","received_events_url":"https://api.github.com/users/vlanz/received_events","type":"User","site_admin":false},"body":"I have moved the styles to their respective components wherever possible, only one mixin and a few variables are now left in `_dialog.scss`.","created_at":"2019-11-11T11:05:32Z","updated_at":"2019-11-11T11:05:32Z","html_url":"https://github.com/SchweizerischeBundesbahnen/sbb-angular/pull/202#discussion_r344660634","pull_request_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/pulls/202","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/pulls/comments/344660634"},"html":{"href":"https://github.com/SchweizerischeBundesbahnen/sbb-angular/pull/202#discussion_r344660634"},"pull_request":{"href":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/pulls/202"}},"in_reply_to_id":344583455},"pull_request":{"url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/pulls/202","id":331861292,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMxODYxMjky","html_url":"https://github.com/SchweizerischeBundesbahnen/sbb-angular/pull/202","diff_url":"https://github.com/SchweizerischeBundesbahnen/sbb-angular/pull/202.diff","patch_url":"https://github.com/SchweizerischeBundesbahnen/sbb-angular/pull/202.patch","issue_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/issues/202","number":202,"state":"open","locked":false,"title":"Feature/business dialog","user":{"login":"vlanz","id":17550954,"node_id":"MDQ6VXNlcjE3NTUwOTU0","avatar_url":"https://avatars3.githubusercontent.com/u/17550954?v=4","gravatar_id":"","url":"https://api.github.com/users/vlanz","html_url":"https://github.com/vlanz","followers_url":"https://api.github.com/users/vlanz/followers","following_url":"https://api.github.com/users/vlanz/following{/other_user}","gists_url":"https://api.github.com/users/vlanz/gists{/gist_id}","starred_url":"https://api.github.com/users/vlanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlanz/subscriptions","organizations_url":"https://api.github.com/users/vlanz/orgs","repos_url":"https://api.github.com/users/vlanz/repos","events_url":"https://api.github.com/users/vlanz/events{/privacy}","received_events_url":"https://api.github.com/users/vlanz/received_events","type":"User","site_admin":false},"body":"feat(business): dialog\r\n\r\nAdd a dialog component for the business scope.\r\nNOTE: there are still overflow issues for the dialog body.","created_at":"2019-10-24T05:27:30Z","updated_at":"2019-11-11T11:05:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8e16a9c6a086db2a09ccc236f4b1236c37ba977","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/pulls/202/commits","review_comments_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/pulls/202/comments","review_comment_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/issues/202/comments","statuses_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/statuses/0243614e89463c9bc008eb890637159a3da70f79","head":{"label":"SchweizerischeBundesbahnen:feature/business-dialog","ref":"feature/business-dialog","sha":"0243614e89463c9bc008eb890637159a3da70f79","user":{"login":"SchweizerischeBundesbahnen","id":6974750,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NzQ3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6974750?v=4","gravatar_id":"","url":"https://api.github.com/users/SchweizerischeBundesbahnen","html_url":"https://github.com/SchweizerischeBundesbahnen","followers_url":"https://api.github.com/users/SchweizerischeBundesbahnen/followers","following_url":"https://api.github.com/users/SchweizerischeBundesbahnen/following{/other_user}","gists_url":"https://api.github.com/users/SchweizerischeBundesbahnen/gists{/gist_id}","starred_url":"https://api.github.com/users/SchweizerischeBundesbahnen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SchweizerischeBundesbahnen/subscriptions","organizations_url":"https://api.github.com/users/SchweizerischeBundesbahnen/orgs","repos_url":"https://api.github.com/users/SchweizerischeBundesbahnen/repos","events_url":"https://api.github.com/users/SchweizerischeBundesbahnen/events{/privacy}","received_events_url":"https://api.github.com/users/SchweizerischeBundesbahnen/received_events","type":"Organization","site_admin":false},"repo":{"id":181547091,"node_id":"MDEwOlJlcG9zaXRvcnkxODE1NDcwOTE=","name":"sbb-angular","full_name":"SchweizerischeBundesbahnen/sbb-angular","private":false,"owner":{"login":"SchweizerischeBundesbahnen","id":6974750,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NzQ3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6974750?v=4","gravatar_id":"","url":"https://api.github.com/users/SchweizerischeBundesbahnen","html_url":"https://github.com/SchweizerischeBundesbahnen","followers_url":"https://api.github.com/users/SchweizerischeBundesbahnen/followers","following_url":"https://api.github.com/users/SchweizerischeBundesbahnen/following{/other_user}","gists_url":"https://api.github.com/users/SchweizerischeBundesbahnen/gists{/gist_id}","starred_url":"https://api.github.com/users/SchweizerischeBundesbahnen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SchweizerischeBundesbahnen/subscriptions","organizations_url":"https://api.github.com/users/SchweizerischeBundesbahnen/orgs","repos_url":"https://api.github.com/users/SchweizerischeBundesbahnen/repos","events_url":"https://api.github.com/users/SchweizerischeBundesbahnen/events{/privacy}","received_events_url":"https://api.github.com/users/SchweizerischeBundesbahnen/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SchweizerischeBundesbahnen/sbb-angular","description":"Angular Library for SBB","fork":false,"url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular","forks_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/forks","keys_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/teams","hooks_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/hooks","issue_events_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/issues/events{/number}","events_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/events","assignees_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/assignees{/user}","branches_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/branches{/branch}","tags_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/tags","blobs_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/statuses/{sha}","languages_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/languages","stargazers_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/stargazers","contributors_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/contributors","subscribers_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/subscribers","subscription_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/subscription","commits_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/contents/{+path}","compare_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/merges","archive_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/downloads","issues_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/issues{/number}","pulls_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/pulls{/number}","milestones_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/milestones{/number}","notifications_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/labels{/name}","releases_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/releases{/id}","deployments_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/deployments","created_at":"2019-04-15T18:50:19Z","updated_at":"2019-11-08T11:02:54Z","pushed_at":"2019-11-11T11:04:20Z","git_url":"git://github.com/SchweizerischeBundesbahnen/sbb-angular.git","ssh_url":"[email protected]:SchweizerischeBundesbahnen/sbb-angular.git","clone_url":"https://github.com/SchweizerischeBundesbahnen/sbb-angular.git","svn_url":"https://github.com/SchweizerischeBundesbahnen/sbb-angular","homepage":"https://angular.app.sbb.ch","size":12832,"stargazers_count":15,"watchers_count":15,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":62,"watchers":15,"default_branch":"master"}},"base":{"label":"SchweizerischeBundesbahnen:master","ref":"master","sha":"8102a258bf599edc4925286495bbf299441c5cd3","user":{"login":"SchweizerischeBundesbahnen","id":6974750,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NzQ3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6974750?v=4","gravatar_id":"","url":"https://api.github.com/users/SchweizerischeBundesbahnen","html_url":"https://github.com/SchweizerischeBundesbahnen","followers_url":"https://api.github.com/users/SchweizerischeBundesbahnen/followers","following_url":"https://api.github.com/users/SchweizerischeBundesbahnen/following{/other_user}","gists_url":"https://api.github.com/users/SchweizerischeBundesbahnen/gists{/gist_id}","starred_url":"https://api.github.com/users/SchweizerischeBundesbahnen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SchweizerischeBundesbahnen/subscriptions","organizations_url":"https://api.github.com/users/SchweizerischeBundesbahnen/orgs","repos_url":"https://api.github.com/users/SchweizerischeBundesbahnen/repos","events_url":"https://api.github.com/users/SchweizerischeBundesbahnen/events{/privacy}","received_events_url":"https://api.github.com/users/SchweizerischeBundesbahnen/received_events","type":"Organization","site_admin":false},"repo":{"id":181547091,"node_id":"MDEwOlJlcG9zaXRvcnkxODE1NDcwOTE=","name":"sbb-angular","full_name":"SchweizerischeBundesbahnen/sbb-angular","private":false,"owner":{"login":"SchweizerischeBundesbahnen","id":6974750,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NzQ3NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6974750?v=4","gravatar_id":"","url":"https://api.github.com/users/SchweizerischeBundesbahnen","html_url":"https://github.com/SchweizerischeBundesbahnen","followers_url":"https://api.github.com/users/SchweizerischeBundesbahnen/followers","following_url":"https://api.github.com/users/SchweizerischeBundesbahnen/following{/other_user}","gists_url":"https://api.github.com/users/SchweizerischeBundesbahnen/gists{/gist_id}","starred_url":"https://api.github.com/users/SchweizerischeBundesbahnen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SchweizerischeBundesbahnen/subscriptions","organizations_url":"https://api.github.com/users/SchweizerischeBundesbahnen/orgs","repos_url":"https://api.github.com/users/SchweizerischeBundesbahnen/repos","events_url":"https://api.github.com/users/SchweizerischeBundesbahnen/events{/privacy}","received_events_url":"https://api.github.com/users/SchweizerischeBundesbahnen/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SchweizerischeBundesbahnen/sbb-angular","description":"Angular Library for SBB","fork":false,"url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular","forks_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/forks","keys_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/teams","hooks_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/hooks","issue_events_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/issues/events{/number}","events_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/events","assignees_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/assignees{/user}","branches_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/branches{/branch}","tags_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/tags","blobs_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/statuses/{sha}","languages_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/languages","stargazers_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/stargazers","contributors_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/contributors","subscribers_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/subscribers","subscription_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/subscription","commits_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/contents/{+path}","compare_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/merges","archive_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/downloads","issues_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/issues{/number}","pulls_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/pulls{/number}","milestones_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/milestones{/number}","notifications_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/labels{/name}","releases_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/releases{/id}","deployments_url":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/deployments","created_at":"2019-04-15T18:50:19Z","updated_at":"2019-11-08T11:02:54Z","pushed_at":"2019-11-11T11:04:20Z","git_url":"git://github.com/SchweizerischeBundesbahnen/sbb-angular.git","ssh_url":"[email protected]:SchweizerischeBundesbahnen/sbb-angular.git","clone_url":"https://github.com/SchweizerischeBundesbahnen/sbb-angular.git","svn_url":"https://github.com/SchweizerischeBundesbahnen/sbb-angular","homepage":"https://angular.app.sbb.ch","size":12832,"stargazers_count":15,"watchers_count":15,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":62,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/pulls/202"},"html":{"href":"https://github.com/SchweizerischeBundesbahnen/sbb-angular/pull/202"},"issue":{"href":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/issues/202"},"comments":{"href":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/issues/202/comments"},"review_comments":{"href":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/pulls/202/comments"},"review_comment":{"href":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/pulls/202/commits"},"statuses":{"href":"https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular/statuses/0243614e89463c9bc008eb890637159a3da70f79"}},"author_association":"COLLABORATOR"}}
|
{
"id": 181547091,
"name": "SchweizerischeBundesbahnen/sbb-angular",
"url": "https://api.github.com/repos/SchweizerischeBundesbahnen/sbb-angular"
}
|
{
"id": 17550954,
"login": "vlanz",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/17550954?",
"url": "https://api.github.com/users/vlanz"
}
|
{
"id": 6974750,
"login": "SchweizerischeBundesbahnen",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6974750?",
"url": "https://api.github.com/orgs/SchweizerischeBundesbahnen"
}
| 2019-11-11T11:05:32 |
10832650872
|
{"actor":{"display_login":"vlanz"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/WOVNio/wovnjava/pulls/comments/296544135","pull_request_review_id":253189226,"id":296544135,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NjU0NDEzNQ==","diff_hunk":"@@ -268,12 +258,25 @@ String getUrlWithoutLanguageCode() {\n \n String removeLang(String uri, String lang) {\n if (lang == null || lang.length() == 0) {\n- lang = this.getPathLang();\n+ lang = this.requestLang;\n }\n return this.patternHandler.removeLang(uri, lang);\n }\n \n boolean isValidPath() {\n return this.pathName.startsWith(this.settings.sitePrefixPath);\n }\n+\n+ private String calculateRequestLang() {","path":"src/main/java/com/github/wovnio/wovnjava/Headers.java","position":64,"original_position":64,"commit_id":"119296573ccc1e3b66a7ff0cbf49496186f7ff79","original_commit_id":"119296573ccc1e3b66a7ff0cbf49496186f7ff79","user":{"login":"a-bougouin","id":16997667,"node_id":"MDQ6VXNlcjE2OTk3NjY3","avatar_url":"https://avatars3.githubusercontent.com/u/16997667?v=4","gravatar_id":"","url":"https://api.github.com/users/a-bougouin","html_url":"https://github.com/a-bougouin","followers_url":"https://api.github.com/users/a-bougouin/followers","following_url":"https://api.github.com/users/a-bougouin/following{/other_user}","gists_url":"https://api.github.com/users/a-bougouin/gists{/gist_id}","starred_url":"https://api.github.com/users/a-bougouin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-bougouin/subscriptions","organizations_url":"https://api.github.com/users/a-bougouin/orgs","repos_url":"https://api.github.com/users/a-bougouin/repos","events_url":"https://api.github.com/users/a-bougouin/events{/privacy}","received_events_url":"https://api.github.com/users/a-bougouin/received_events","type":"User","site_admin":false},"body":"I would use \"compute\" over \"calculate\", but that's nitpicking...","created_at":"2019-06-24T03:46:14Z","updated_at":"2019-06-24T03:46:14Z","html_url":"https://github.com/WOVNio/wovnjava/pull/106#discussion_r296544135","pull_request_url":"https://api.github.com/repos/WOVNio/wovnjava/pulls/106","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/WOVNio/wovnjava/pulls/comments/296544135"},"html":{"href":"https://github.com/WOVNio/wovnjava/pull/106#discussion_r296544135"},"pull_request":{"href":"https://api.github.com/repos/WOVNio/wovnjava/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/WOVNio/wovnjava/pulls/106","id":290484174,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkwNDg0MTc0","html_url":"https://github.com/WOVNio/wovnjava/pull/106","diff_url":"https://github.com/WOVNio/wovnjava/pull/106.diff","patch_url":"https://github.com/WOVNio/wovnjava/pull/106.patch","issue_url":"https://api.github.com/repos/WOVNio/wovnjava/issues/106","number":106,"state":"open","locked":false,"title":"[Refactor] Calculate requestLang at Headers initialization","user":{"login":"torkelbe","id":3740817,"node_id":"MDQ6VXNlcjM3NDA4MTc=","avatar_url":"https://avatars1.githubusercontent.com/u/3740817?v=4","gravatar_id":"","url":"https://api.github.com/users/torkelbe","html_url":"https://github.com/torkelbe","followers_url":"https://api.github.com/users/torkelbe/followers","following_url":"https://api.github.com/users/torkelbe/following{/other_user}","gists_url":"https://api.github.com/users/torkelbe/gists{/gist_id}","starred_url":"https://api.github.com/users/torkelbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torkelbe/subscriptions","organizations_url":"https://api.github.com/users/torkelbe/orgs","repos_url":"https://api.github.com/users/torkelbe/repos","events_url":"https://api.github.com/users/torkelbe/events{/privacy}","received_events_url":"https://api.github.com/users/torkelbe/received_events","type":"User","site_admin":false},"body":"### Changes\r\n* Rename `pathLang` to `requestLang`.\r\n* Calculate `requestLang` only once, when Headers is instantiated. Change the getter to simply return the value.\r\n\r\nLogic for calculating the value remains unchanged.","created_at":"2019-06-21T06:49:04Z","updated_at":"2019-06-24T03:46:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95357e38427d1b81ffcc4504441c74993d3820db","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WOVNio/wovnjava/pulls/106/commits","review_comments_url":"https://api.github.com/repos/WOVNio/wovnjava/pulls/106/comments","review_comment_url":"https://api.github.com/repos/WOVNio/wovnjava/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WOVNio/wovnjava/issues/106/comments","statuses_url":"https://api.github.com/repos/WOVNio/wovnjava/statuses/119296573ccc1e3b66a7ff0cbf49496186f7ff79","head":{"label":"WOVNio:misc/calculate_pathlang","ref":"misc/calculate_pathlang","sha":"119296573ccc1e3b66a7ff0cbf49496186f7ff79","user":{"login":"WOVNio","id":7219843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyMTk4NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/7219843?v=4","gravatar_id":"","url":"https://api.github.com/users/WOVNio","html_url":"https://github.com/WOVNio","followers_url":"https://api.github.com/users/WOVNio/followers","following_url":"https://api.github.com/users/WOVNio/following{/other_user}","gists_url":"https://api.github.com/users/WOVNio/gists{/gist_id}","starred_url":"https://api.github.com/users/WOVNio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WOVNio/subscriptions","organizations_url":"https://api.github.com/users/WOVNio/orgs","repos_url":"https://api.github.com/users/WOVNio/repos","events_url":"https://api.github.com/users/WOVNio/events{/privacy}","received_events_url":"https://api.github.com/users/WOVNio/received_events","type":"Organization","site_admin":false},"repo":{"id":54623652,"node_id":"MDEwOlJlcG9zaXRvcnk1NDYyMzY1Mg==","name":"wovnjava","full_name":"WOVNio/wovnjava","private":false,"owner":{"login":"WOVNio","id":7219843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyMTk4NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/7219843?v=4","gravatar_id":"","url":"https://api.github.com/users/WOVNio","html_url":"https://github.com/WOVNio","followers_url":"https://api.github.com/users/WOVNio/followers","following_url":"https://api.github.com/users/WOVNio/following{/other_user}","gists_url":"https://api.github.com/users/WOVNio/gists{/gist_id}","starred_url":"https://api.github.com/users/WOVNio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WOVNio/subscriptions","organizations_url":"https://api.github.com/users/WOVNio/orgs","repos_url":"https://api.github.com/users/WOVNio/repos","events_url":"https://api.github.com/users/WOVNio/events{/privacy}","received_events_url":"https://api.github.com/users/WOVNio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WOVNio/wovnjava","description":"WOVN backend for Java","fork":false,"url":"https://api.github.com/repos/WOVNio/wovnjava","forks_url":"https://api.github.com/repos/WOVNio/wovnjava/forks","keys_url":"https://api.github.com/repos/WOVNio/wovnjava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WOVNio/wovnjava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WOVNio/wovnjava/teams","hooks_url":"https://api.github.com/repos/WOVNio/wovnjava/hooks","issue_events_url":"https://api.github.com/repos/WOVNio/wovnjava/issues/events{/number}","events_url":"https://api.github.com/repos/WOVNio/wovnjava/events","assignees_url":"https://api.github.com/repos/WOVNio/wovnjava/assignees{/user}","branches_url":"https://api.github.com/repos/WOVNio/wovnjava/branches{/branch}","tags_url":"https://api.github.com/repos/WOVNio/wovnjava/tags","blobs_url":"https://api.github.com/repos/WOVNio/wovnjava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WOVNio/wovnjava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WOVNio/wovnjava/git/refs{/sha}","trees_url":"https://api.github.com/repos/WOVNio/wovnjava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WOVNio/wovnjava/statuses/{sha}","languages_url":"https://api.github.com/repos/WOVNio/wovnjava/languages","stargazers_url":"https://api.github.com/repos/WOVNio/wovnjava/stargazers","contributors_url":"https://api.github.com/repos/WOVNio/wovnjava/contributors","subscribers_url":"https://api.github.com/repos/WOVNio/wovnjava/subscribers","subscription_url":"https://api.github.com/repos/WOVNio/wovnjava/subscription","commits_url":"https://api.github.com/repos/WOVNio/wovnjava/commits{/sha}","git_commits_url":"https://api.github.com/repos/WOVNio/wovnjava/git/commits{/sha}","comments_url":"https://api.github.com/repos/WOVNio/wovnjava/comments{/number}","issue_comment_url":"https://api.github.com/repos/WOVNio/wovnjava/issues/comments{/number}","contents_url":"https://api.github.com/repos/WOVNio/wovnjava/contents/{+path}","compare_url":"https://api.github.com/repos/WOVNio/wovnjava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WOVNio/wovnjava/merges","archive_url":"https://api.github.com/repos/WOVNio/wovnjava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WOVNio/wovnjava/downloads","issues_url":"https://api.github.com/repos/WOVNio/wovnjava/issues{/number}","pulls_url":"https://api.github.com/repos/WOVNio/wovnjava/pulls{/number}","milestones_url":"https://api.github.com/repos/WOVNio/wovnjava/milestones{/number}","notifications_url":"https://api.github.com/repos/WOVNio/wovnjava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WOVNio/wovnjava/labels{/name}","releases_url":"https://api.github.com/repos/WOVNio/wovnjava/releases{/id}","deployments_url":"https://api.github.com/repos/WOVNio/wovnjava/deployments","created_at":"2016-03-24T07:40:34Z","updated_at":"2019-06-21T03:29:16Z","pushed_at":"2019-06-24T03:46:12Z","git_url":"git://github.com/WOVNio/wovnjava.git","ssh_url":"[email protected]:WOVNio/wovnjava.git","clone_url":"https://github.com/WOVNio/wovnjava.git","svn_url":"https://github.com/WOVNio/wovnjava","homepage":"","size":389,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":13,"watchers":0,"default_branch":"master"}},"base":{"label":"WOVNio:refactor/remove_lang","ref":"refactor/remove_lang","sha":"4154227bac6d1419f055f114862dd6090fe2a652","user":{"login":"WOVNio","id":7219843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyMTk4NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/7219843?v=4","gravatar_id":"","url":"https://api.github.com/users/WOVNio","html_url":"https://github.com/WOVNio","followers_url":"https://api.github.com/users/WOVNio/followers","following_url":"https://api.github.com/users/WOVNio/following{/other_user}","gists_url":"https://api.github.com/users/WOVNio/gists{/gist_id}","starred_url":"https://api.github.com/users/WOVNio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WOVNio/subscriptions","organizations_url":"https://api.github.com/users/WOVNio/orgs","repos_url":"https://api.github.com/users/WOVNio/repos","events_url":"https://api.github.com/users/WOVNio/events{/privacy}","received_events_url":"https://api.github.com/users/WOVNio/received_events","type":"Organization","site_admin":false},"repo":{"id":54623652,"node_id":"MDEwOlJlcG9zaXRvcnk1NDYyMzY1Mg==","name":"wovnjava","full_name":"WOVNio/wovnjava","private":false,"owner":{"login":"WOVNio","id":7219843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyMTk4NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/7219843?v=4","gravatar_id":"","url":"https://api.github.com/users/WOVNio","html_url":"https://github.com/WOVNio","followers_url":"https://api.github.com/users/WOVNio/followers","following_url":"https://api.github.com/users/WOVNio/following{/other_user}","gists_url":"https://api.github.com/users/WOVNio/gists{/gist_id}","starred_url":"https://api.github.com/users/WOVNio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WOVNio/subscriptions","organizations_url":"https://api.github.com/users/WOVNio/orgs","repos_url":"https://api.github.com/users/WOVNio/repos","events_url":"https://api.github.com/users/WOVNio/events{/privacy}","received_events_url":"https://api.github.com/users/WOVNio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WOVNio/wovnjava","description":"WOVN backend for Java","fork":false,"url":"https://api.github.com/repos/WOVNio/wovnjava","forks_url":"https://api.github.com/repos/WOVNio/wovnjava/forks","keys_url":"https://api.github.com/repos/WOVNio/wovnjava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WOVNio/wovnjava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WOVNio/wovnjava/teams","hooks_url":"https://api.github.com/repos/WOVNio/wovnjava/hooks","issue_events_url":"https://api.github.com/repos/WOVNio/wovnjava/issues/events{/number}","events_url":"https://api.github.com/repos/WOVNio/wovnjava/events","assignees_url":"https://api.github.com/repos/WOVNio/wovnjava/assignees{/user}","branches_url":"https://api.github.com/repos/WOVNio/wovnjava/branches{/branch}","tags_url":"https://api.github.com/repos/WOVNio/wovnjava/tags","blobs_url":"https://api.github.com/repos/WOVNio/wovnjava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WOVNio/wovnjava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WOVNio/wovnjava/git/refs{/sha}","trees_url":"https://api.github.com/repos/WOVNio/wovnjava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WOVNio/wovnjava/statuses/{sha}","languages_url":"https://api.github.com/repos/WOVNio/wovnjava/languages","stargazers_url":"https://api.github.com/repos/WOVNio/wovnjava/stargazers","contributors_url":"https://api.github.com/repos/WOVNio/wovnjava/contributors","subscribers_url":"https://api.github.com/repos/WOVNio/wovnjava/subscribers","subscription_url":"https://api.github.com/repos/WOVNio/wovnjava/subscription","commits_url":"https://api.github.com/repos/WOVNio/wovnjava/commits{/sha}","git_commits_url":"https://api.github.com/repos/WOVNio/wovnjava/git/commits{/sha}","comments_url":"https://api.github.com/repos/WOVNio/wovnjava/comments{/number}","issue_comment_url":"https://api.github.com/repos/WOVNio/wovnjava/issues/comments{/number}","contents_url":"https://api.github.com/repos/WOVNio/wovnjava/contents/{+path}","compare_url":"https://api.github.com/repos/WOVNio/wovnjava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WOVNio/wovnjava/merges","archive_url":"https://api.github.com/repos/WOVNio/wovnjava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WOVNio/wovnjava/downloads","issues_url":"https://api.github.com/repos/WOVNio/wovnjava/issues{/number}","pulls_url":"https://api.github.com/repos/WOVNio/wovnjava/pulls{/number}","milestones_url":"https://api.github.com/repos/WOVNio/wovnjava/milestones{/number}","notifications_url":"https://api.github.com/repos/WOVNio/wovnjava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WOVNio/wovnjava/labels{/name}","releases_url":"https://api.github.com/repos/WOVNio/wovnjava/releases{/id}","deployments_url":"https://api.github.com/repos/WOVNio/wovnjava/deployments","created_at":"2016-03-24T07:40:34Z","updated_at":"2019-06-21T03:29:16Z","pushed_at":"2019-06-24T03:46:12Z","git_url":"git://github.com/WOVNio/wovnjava.git","ssh_url":"[email protected]:WOVNio/wovnjava.git","clone_url":"https://github.com/WOVNio/wovnjava.git","svn_url":"https://github.com/WOVNio/wovnjava","homepage":"","size":389,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":13,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":13,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WOVNio/wovnjava/pulls/106"},"html":{"href":"https://github.com/WOVNio/wovnjava/pull/106"},"issue":{"href":"https://api.github.com/repos/WOVNio/wovnjava/issues/106"},"comments":{"href":"https://api.github.com/repos/WOVNio/wovnjava/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/WOVNio/wovnjava/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/WOVNio/wovnjava/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WOVNio/wovnjava/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/WOVNio/wovnjava/statuses/119296573ccc1e3b66a7ff0cbf49496186f7ff79"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 54623652,
"name": "WOVNio/wovnjava",
"url": "https://api.github.com/repos/WOVNio/wovnjava"
}
|
{
"id": 16997667,
"login": "a-bougouin",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/16997667?",
"url": "https://api.github.com/users/a-bougouin"
}
|
{
"id": 7219843,
"login": "WOVNio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7219843?",
"url": "https://api.github.com/orgs/WOVNio"
}
| 2019-06-24T03:46:14 |
9877478569
|
{"actor":{"display_login":"a-bougouin"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/platformsh/platformsh-docs/pulls/comments/338068831","pull_request_review_id":305917951,"id":338068831,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzODA2ODgzMQ==","diff_hunk":"@@ -157,3 +157,10 @@ Once you are done, please disable logging with:\n \n * `platform variable:delete php:blackfire.log_file`\n * `platform variable:delete php:blackfire.log_level`\n+\n+\n+## Notes\n+\n+### Memory usage\n+\n+This extension adds extra memory overhead to your application and each request will require more memory. So, depending on how aggressive your `sizing_hints` are, you may need to adjust them or upgrade your plan.","path":"src/administration/integrations/blackfire.md","position":10,"original_position":10,"commit_id":"9df7aa42c33f5e4dc30fe58e2d03ba785993e6c0","original_commit_id":"9df7aa42c33f5e4dc30fe58e2d03ba785993e6c0","user":{"login":"romainneutron","id":137574,"node_id":"MDQ6VXNlcjEzNzU3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/137574?v=4","gravatar_id":"","url":"https://api.github.com/users/romainneutron","html_url":"https://github.com/romainneutron","followers_url":"https://api.github.com/users/romainneutron/followers","following_url":"https://api.github.com/users/romainneutron/following{/other_user}","gists_url":"https://api.github.com/users/romainneutron/gists{/gist_id}","starred_url":"https://api.github.com/users/romainneutron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romainneutron/subscriptions","organizations_url":"https://api.github.com/users/romainneutron/orgs","repos_url":"https://api.github.com/users/romainneutron/repos","events_url":"https://api.github.com/users/romainneutron/events{/privacy}","received_events_url":"https://api.github.com/users/romainneutron/received_events","type":"User","site_admin":false},"body":"What do you mean by overhead? CPU usage? Please detail this please","created_at":"2019-10-23T14:05:28Z","updated_at":"2019-10-23T14:05:28Z","html_url":"https://github.com/platformsh/platformsh-docs/pull/1252#discussion_r338068831","pull_request_url":"https://api.github.com/repos/platformsh/platformsh-docs/pulls/1252","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/platformsh/platformsh-docs/pulls/comments/338068831"},"html":{"href":"https://github.com/platformsh/platformsh-docs/pull/1252#discussion_r338068831"},"pull_request":{"href":"https://api.github.com/repos/platformsh/platformsh-docs/pulls/1252"}},"in_reply_to_id":337400725},"pull_request":{"url":"https://api.github.com/repos/platformsh/platformsh-docs/pulls/1252","id":330872618,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMwODcyNjE4","html_url":"https://github.com/platformsh/platformsh-docs/pull/1252","diff_url":"https://github.com/platformsh/platformsh-docs/pull/1252.diff","patch_url":"https://github.com/platformsh/platformsh-docs/pull/1252.patch","issue_url":"https://api.github.com/repos/platformsh/platformsh-docs/issues/1252","number":1252,"state":"open","locked":false,"title":"Adding a note about memory consumption of PHP profilers","user":{"login":"xaviemirmon","id":5609840,"node_id":"MDQ6VXNlcjU2MDk4NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/5609840?v=4","gravatar_id":"","url":"https://api.github.com/users/xaviemirmon","html_url":"https://github.com/xaviemirmon","followers_url":"https://api.github.com/users/xaviemirmon/followers","following_url":"https://api.github.com/users/xaviemirmon/following{/other_user}","gists_url":"https://api.github.com/users/xaviemirmon/gists{/gist_id}","starred_url":"https://api.github.com/users/xaviemirmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xaviemirmon/subscriptions","organizations_url":"https://api.github.com/users/xaviemirmon/orgs","repos_url":"https://api.github.com/users/xaviemirmon/repos","events_url":"https://api.github.com/users/xaviemirmon/events{/privacy}","received_events_url":"https://api.github.com/users/xaviemirmon/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-22T08:44:03Z","updated_at":"2019-10-23T14:05:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53f0085cb3c4becac06bb338ad20f7331dfb5285","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/platformsh/platformsh-docs/pulls/1252/commits","review_comments_url":"https://api.github.com/repos/platformsh/platformsh-docs/pulls/1252/comments","review_comment_url":"https://api.github.com/repos/platformsh/platformsh-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/platformsh/platformsh-docs/issues/1252/comments","statuses_url":"https://api.github.com/repos/platformsh/platformsh-docs/statuses/9df7aa42c33f5e4dc30fe58e2d03ba785993e6c0","head":{"label":"xaviemirmon:master","ref":"master","sha":"9df7aa42c33f5e4dc30fe58e2d03ba785993e6c0","user":{"login":"xaviemirmon","id":5609840,"node_id":"MDQ6VXNlcjU2MDk4NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/5609840?v=4","gravatar_id":"","url":"https://api.github.com/users/xaviemirmon","html_url":"https://github.com/xaviemirmon","followers_url":"https://api.github.com/users/xaviemirmon/followers","following_url":"https://api.github.com/users/xaviemirmon/following{/other_user}","gists_url":"https://api.github.com/users/xaviemirmon/gists{/gist_id}","starred_url":"https://api.github.com/users/xaviemirmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xaviemirmon/subscriptions","organizations_url":"https://api.github.com/users/xaviemirmon/orgs","repos_url":"https://api.github.com/users/xaviemirmon/repos","events_url":"https://api.github.com/users/xaviemirmon/events{/privacy}","received_events_url":"https://api.github.com/users/xaviemirmon/received_events","type":"User","site_admin":false},"repo":{"id":216759912,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY3NTk5MTI=","name":"platformsh-docs","full_name":"xaviemirmon/platformsh-docs","private":false,"owner":{"login":"xaviemirmon","id":5609840,"node_id":"MDQ6VXNlcjU2MDk4NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/5609840?v=4","gravatar_id":"","url":"https://api.github.com/users/xaviemirmon","html_url":"https://github.com/xaviemirmon","followers_url":"https://api.github.com/users/xaviemirmon/followers","following_url":"https://api.github.com/users/xaviemirmon/following{/other_user}","gists_url":"https://api.github.com/users/xaviemirmon/gists{/gist_id}","starred_url":"https://api.github.com/users/xaviemirmon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xaviemirmon/subscriptions","organizations_url":"https://api.github.com/users/xaviemirmon/orgs","repos_url":"https://api.github.com/users/xaviemirmon/repos","events_url":"https://api.github.com/users/xaviemirmon/events{/privacy}","received_events_url":"https://api.github.com/users/xaviemirmon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xaviemirmon/platformsh-docs","description":"Platform.sh documentation. Templates live on https://github.com/platformsh-templates/","fork":true,"url":"https://api.github.com/repos/xaviemirmon/platformsh-docs","forks_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/forks","keys_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/teams","hooks_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/hooks","issue_events_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/issues/events{/number}","events_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/events","assignees_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/assignees{/user}","branches_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/branches{/branch}","tags_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/tags","blobs_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/languages","stargazers_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/stargazers","contributors_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/contributors","subscribers_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/subscribers","subscription_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/subscription","commits_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/contents/{+path}","compare_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/merges","archive_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/downloads","issues_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/issues{/number}","pulls_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/labels{/name}","releases_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/releases{/id}","deployments_url":"https://api.github.com/repos/xaviemirmon/platformsh-docs/deployments","created_at":"2019-10-22T08:16:57Z","updated_at":"2019-10-22T08:35:44Z","pushed_at":"2019-10-22T08:46:07Z","git_url":"git://github.com/xaviemirmon/platformsh-docs.git","ssh_url":"[email protected]:xaviemirmon/platformsh-docs.git","clone_url":"https://github.com/xaviemirmon/platformsh-docs.git","svn_url":"https://github.com/xaviemirmon/platformsh-docs","homepage":"https://docs.platform.sh/","size":36990,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"cc-by-sa-4.0","name":"Creative Commons Attribution Share Alike 4.0 International","spdx_id":"CC-BY-SA-4.0","url":"https://api.github.com/licenses/cc-by-sa-4.0","node_id":"MDc6TGljZW5zZTI2"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"platformsh:master","ref":"master","sha":"bfd3e6de7c18e622939b337553d11b0fcb600d94","user":{"login":"platformsh","id":7248334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDgzMzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7248334?v=4","gravatar_id":"","url":"https://api.github.com/users/platformsh","html_url":"https://github.com/platformsh","followers_url":"https://api.github.com/users/platformsh/followers","following_url":"https://api.github.com/users/platformsh/following{/other_user}","gists_url":"https://api.github.com/users/platformsh/gists{/gist_id}","starred_url":"https://api.github.com/users/platformsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platformsh/subscriptions","organizations_url":"https://api.github.com/users/platformsh/orgs","repos_url":"https://api.github.com/users/platformsh/repos","events_url":"https://api.github.com/users/platformsh/events{/privacy}","received_events_url":"https://api.github.com/users/platformsh/received_events","type":"Organization","site_admin":false},"repo":{"id":21975579,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk3NTU3OQ==","name":"platformsh-docs","full_name":"platformsh/platformsh-docs","private":false,"owner":{"login":"platformsh","id":7248334,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNDgzMzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7248334?v=4","gravatar_id":"","url":"https://api.github.com/users/platformsh","html_url":"https://github.com/platformsh","followers_url":"https://api.github.com/users/platformsh/followers","following_url":"https://api.github.com/users/platformsh/following{/other_user}","gists_url":"https://api.github.com/users/platformsh/gists{/gist_id}","starred_url":"https://api.github.com/users/platformsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platformsh/subscriptions","organizations_url":"https://api.github.com/users/platformsh/orgs","repos_url":"https://api.github.com/users/platformsh/repos","events_url":"https://api.github.com/users/platformsh/events{/privacy}","received_events_url":"https://api.github.com/users/platformsh/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/platformsh/platformsh-docs","description":"Platform.sh documentation. Templates live on https://github.com/platformsh-templates/","fork":false,"url":"https://api.github.com/repos/platformsh/platformsh-docs","forks_url":"https://api.github.com/repos/platformsh/platformsh-docs/forks","keys_url":"https://api.github.com/repos/platformsh/platformsh-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/platformsh/platformsh-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/platformsh/platformsh-docs/teams","hooks_url":"https://api.github.com/repos/platformsh/platformsh-docs/hooks","issue_events_url":"https://api.github.com/repos/platformsh/platformsh-docs/issues/events{/number}","events_url":"https://api.github.com/repos/platformsh/platformsh-docs/events","assignees_url":"https://api.github.com/repos/platformsh/platformsh-docs/assignees{/user}","branches_url":"https://api.github.com/repos/platformsh/platformsh-docs/branches{/branch}","tags_url":"https://api.github.com/repos/platformsh/platformsh-docs/tags","blobs_url":"https://api.github.com/repos/platformsh/platformsh-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/platformsh/platformsh-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/platformsh/platformsh-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/platformsh/platformsh-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/platformsh/platformsh-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/platformsh/platformsh-docs/languages","stargazers_url":"https://api.github.com/repos/platformsh/platformsh-docs/stargazers","contributors_url":"https://api.github.com/repos/platformsh/platformsh-docs/contributors","subscribers_url":"https://api.github.com/repos/platformsh/platformsh-docs/subscribers","subscription_url":"https://api.github.com/repos/platformsh/platformsh-docs/subscription","commits_url":"https://api.github.com/repos/platformsh/platformsh-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/platformsh/platformsh-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/platformsh/platformsh-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/platformsh/platformsh-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/platformsh/platformsh-docs/contents/{+path}","compare_url":"https://api.github.com/repos/platformsh/platformsh-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/platformsh/platformsh-docs/merges","archive_url":"https://api.github.com/repos/platformsh/platformsh-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/platformsh/platformsh-docs/downloads","issues_url":"https://api.github.com/repos/platformsh/platformsh-docs/issues{/number}","pulls_url":"https://api.github.com/repos/platformsh/platformsh-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/platformsh/platformsh-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/platformsh/platformsh-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/platformsh/platformsh-docs/labels{/name}","releases_url":"https://api.github.com/repos/platformsh/platformsh-docs/releases{/id}","deployments_url":"https://api.github.com/repos/platformsh/platformsh-docs/deployments","created_at":"2014-07-18T09:46:29Z","updated_at":"2019-10-22T11:09:32Z","pushed_at":"2019-10-22T15:05:02Z","git_url":"git://github.com/platformsh/platformsh-docs.git","ssh_url":"[email protected]:platformsh/platformsh-docs.git","clone_url":"https://github.com/platformsh/platformsh-docs.git","svn_url":"https://github.com/platformsh/platformsh-docs","homepage":"https://docs.platform.sh/","size":36976,"stargazers_count":52,"watchers_count":52,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":168,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":22,"license":{"key":"cc-by-sa-4.0","name":"Creative Commons Attribution Share Alike 4.0 International","spdx_id":"CC-BY-SA-4.0","url":"https://api.github.com/licenses/cc-by-sa-4.0","node_id":"MDc6TGljZW5zZTI2"},"forks":168,"open_issues":22,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/platformsh/platformsh-docs/pulls/1252"},"html":{"href":"https://github.com/platformsh/platformsh-docs/pull/1252"},"issue":{"href":"https://api.github.com/repos/platformsh/platformsh-docs/issues/1252"},"comments":{"href":"https://api.github.com/repos/platformsh/platformsh-docs/issues/1252/comments"},"review_comments":{"href":"https://api.github.com/repos/platformsh/platformsh-docs/pulls/1252/comments"},"review_comment":{"href":"https://api.github.com/repos/platformsh/platformsh-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/platformsh/platformsh-docs/pulls/1252/commits"},"statuses":{"href":"https://api.github.com/repos/platformsh/platformsh-docs/statuses/9df7aa42c33f5e4dc30fe58e2d03ba785993e6c0"}},"author_association":"NONE"}}
|
{
"id": 21975579,
"name": "platformsh/platformsh-docs",
"url": "https://api.github.com/repos/platformsh/platformsh-docs"
}
|
{
"id": 137574,
"login": "romainneutron",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/137574?",
"url": "https://api.github.com/users/romainneutron"
}
|
{
"id": 7248334,
"login": "platformsh",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7248334?",
"url": "https://api.github.com/orgs/platformsh"
}
| 2019-10-23T14:05:28 |
10696046999
|
{"actor":{"display_login":"romainneutron"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/pulls/comments/329940499","pull_request_review_id":295448427,"id":329940499,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyOTk0MDQ5OQ==","diff_hunk":"@@ -0,0 +1,254 @@\n+/**\n+ *\tCopyright 2019 SmartThings\n+ *\n+ *\tLicensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except\n+ *\tin compliance with the License. You may obtain a copy of the License at:\n+ *\n+ *\t\thttp://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ *\tUnless required by applicable law or agreed to in writing, software distributed under the License is distributed\n+\n+ *\ton an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License\n+ *\tfor the specific language governing permissions and limitations under the License.\n+ *\n+ */\n+metadata {\n+\tdefinition (name: \"Z-Wave Radiator Thermostat\", namespace: \"smartthings\", author: \"SmartThings\", ocfDeviceType: \"oic.d.thermostat\") {\n+\t\tcapability \"Thermostat Mode\"\n+\t\tcapability \"Refresh\"\n+\t\tcapability \"Battery\"\n+\t\tcapability \"Thermostat Heating Setpoint\"\n+\t\tcapability \"Health Check\"\n+\t\tcapability \"Thermostat\"\n+\t\tcapability \"Temperature Measurement\"\n+\n+\t\tfingerprint mfr: \"0060\", prod: \"0015\", model: \"0001\", deviceJoinName: \"Everspring Thermostatic Radiator Valve\", mnmn: \"SmartThings\", vid: \"generic-radiator-thermostat\"\n+\t}\n+\n+\ttiles(scale: 2) {\n+\t\tmultiAttributeTile(name:\"thermostat\", type:\"general\", width:6, height:4, canChangeIcon: false) {\n+\t\t\ttileAttribute(\"device.thermostatMode\", key: \"PRIMARY_CONTROL\") {\n+\t\t\t\tattributeState(\"off\", action:\"switchMode\", nextState:\"...\", icon: \"st.thermostat.heating-cooling-off\")\n+\t\t\t\tattributeState(\"heat\", action:\"switchMode\", nextState:\"...\", icon: \"st.thermostat.heat\")\n+\t\t\t\tattributeState(\"emergency heat\", action:\"switchMode\", nextState:\"...\", icon: \"st.thermostat.emergency-heat\")\n+\t\t\t}\n+\t\t\ttileAttribute(\"device.temperature\", key: \"SECONDARY_CONTROL\") {\n+\t\t\t\tattributeState(\"temperature\", label:'${currentValue}°', icon: \"st.alarm.temperature.normal\",\n+\t\t\t\t\t\tbackgroundColors:[\n+\t\t\t\t\t\t\t\t// Celsius\n+\t\t\t\t\t\t\t\t[value: 0, color: \"#153591\"],\n+\t\t\t\t\t\t\t\t[value: 7, color: \"#1e9cbb\"],\n+\t\t\t\t\t\t\t\t[value: 15, color: \"#90d2a7\"],\n+\t\t\t\t\t\t\t\t[value: 23, color: \"#44b621\"],\n+\t\t\t\t\t\t\t\t[value: 28, color: \"#f1d801\"],\n+\t\t\t\t\t\t\t\t[value: 35, color: \"#d04e00\"],\n+\t\t\t\t\t\t\t\t[value: 37, color: \"#bc2323\"],\n+\t\t\t\t\t\t\t\t// Fahrenheit\n+\t\t\t\t\t\t\t\t[value: 40, color: \"#153591\"],\n+\t\t\t\t\t\t\t\t[value: 44, color: \"#1e9cbb\"],\n+\t\t\t\t\t\t\t\t[value: 59, color: \"#90d2a7\"],\n+\t\t\t\t\t\t\t\t[value: 74, color: \"#44b621\"],\n+\t\t\t\t\t\t\t\t[value: 84, color: \"#f1d801\"],\n+\t\t\t\t\t\t\t\t[value: 95, color: \"#d04e00\"],\n+\t\t\t\t\t\t\t\t[value: 96, color: \"#bc2323\"]\n+\t\t\t\t\t\t]\n+\t\t\t\t)\n+\t\t\t}\n+\t\t\ttileAttribute(\"device.heatingSetpoint\", key: \"HEATING_SETPOINT\") {\n+\t\t\t\tattributeState(\"default\", label: '${currentValue}', unit: \"°\", defaultState: true)\n+\t\t\t}\n+\t\t}\n+\t\tcontrolTile(\"thermostatMode\", \"device.thermostatMode\", \"enum\", width: 2 , height: 2, supportedStates: \"device.supportedThermostatModes\") {\n+\t\t\tstate(\"off\", action: \"setThermostatMode\", label: 'Off', icon: \"st.thermostat.heating-cooling-off\")\n+\t\t\tstate(\"heat\", action: \"setThermostatMode\", label: 'Heat', icon: \"st.thermostat.heat\")\n+\t\t\tstate(\"emergency heat\", action:\"setThermostatMode\", label: 'Emergency heat', icon: \"st.thermostat.emergency-heat\")\n+\t\t}\n+\t\tcontrolTile(\"heatingSetpoint\", \"device.heatingSetpoint\", \"slider\",\n+\t\t\t\tsliderType: \"HEATING\",\n+\t\t\t\tdebouncePeriod: 750,\n+\t\t\t\trange: \"device.heatingSetpointRange\",\n+\t\t\t\twidth: 2, height: 2) {\n+\t\t\tstate \"default\", action:\"setHeatingSetpoint\", label:'${currentValue}', backgroundColor: \"#E86D13\"\n+\t\t}\n+\t\tvalueTile(\"battery\", \"device.battery\", inactiveLabel: false, decoration: \"flat\", width: 2, height: 2) {\n+\t\t\tstate \"battery\", label: 'Battery:\\n${currentValue}%', unit: \"%\"\n+\t\t}\n+\t\tstandardTile(\"refresh\", \"command.refresh\", inactiveLabel: false, decoration: \"flat\", width: 2, height: 2) {\n+\t\t\tstate \"refresh\", label: 'refresh', action: \"refresh.refresh\", icon: \"st.secondary.refresh-icon\"\n+\t\t}\n+\t\tmain \"thermostat\"\n+\t\tdetails([\"thermostat\", \"thermostatMode\", \"heatingSetpoint\", \"battery\", \"refresh\"])\n+\t}\n+}\n+\n+def initialize() {\n+\tsendEvent(name: \"checkInterval\", value: 4 * 60 * 60 + 24 * 60 , displayed: false, data: [protocol: \"zwave\", hubHardwareId: device.hub.hardwareID, offlinePingable: \"1\"])\n+\tsendEvent(name: \"supportedThermostatModes\", value: thermostatSupportedModes, displayed: false)\n+\tsendEvent(name: \"heatingSetpointRange\", value: [minHeatingSetpointTemperature, maxHeatingSetpointTemperature], displayed: false)\n+\tresponse(refresh())\n+}\n+\n+def installed() {\n+\tinitialize()\n+}\n+\n+def updated() {\n+\tinitialize()\n+}\n+\n+def parse(String description) {\n+\tdef result = null\n+\tdef cmd = zwave.parse(description)\n+\tif (cmd) {\n+\t\tresult = zwaveEvent(cmd)\n+\t} else {\n+\t\tlog.warn \"${device.displayName} - no-parsed event: ${description}\"\n+\t}\n+\tlog.debug \"Parse returned: ${result}\"\n+\treturn result\n+}\n+\n+def zwaveEvent(physicalgraph.zwave.commands.securityv1.SecurityMessageEncapsulation cmd) {\n+\tdef encapsulatedCommand = cmd.encapsulatedCommand()\n+\tif (encapsulatedCommand) {\n+\t\tlog.debug \"SecurityMessageEncapsulation into: ${encapsulatedCommand}\"\n+\t\tzwaveEvent(encapsulatedCommand)\n+\t} else {\n+\t\tlog.warn \"unable to extract secure command from $cmd\"\n+\t\tcreateEvent(descriptionText: cmd.toString())\n+\t}\n+}\n+\n+def zwaveEvent(physicalgraph.zwave.commands.batteryv1.BatteryReport cmd) {\n+\tdef value = cmd.batteryLevel == 255 ? 1 : cmd.batteryLevel\n+\tdef map = [name: \"battery\", value: value, unit: \"%\"]\n+\tcreateEvent(map)\n+}\n+\n+def zwaveEvent(physicalgraph.zwave.commands.thermostatmodev2.ThermostatModeReport cmd) {\n+\tdef map = [name: \"thermostatMode\", data:[supportedThermostatModes: thermostatSupportedModes]]\n+\tswitch (cmd.mode) {\n+\t\tcase 1:\n+\t\t\tmap.value = \"heat\"\n+\t\t\tbreak\n+\t\tcase 11:\n+\t\t\tmap.value = \"emergency heat\"\n+\t\t\tbreak\n+\t\tcase 0:\n+\t\t\tmap.value = \"off\"\n+\t\t\tbreak\n+\t}\n+\tcreateEvent(map)\n+}\n+\n+def zwaveEvent(physicalgraph.zwave.commands.thermostatsetpointv2.ThermostatSetpointReport cmd) {\n+\tcreateEvent(name: \"heatingSetpoint\", value: convertTemperatureIfNeeded(cmd.scaledValue, 'C', cmd.precision), unit: temperatureScale)\n+}\n+\n+def zwaveEvent(physicalgraph.zwave.commands.sensormultilevelv5.SensorMultilevelReport cmd) {\n+\tdef map = [name: \"temperature\", value: convertTemperatureIfNeeded(cmd.scaledSensorValue, 'C', cmd.precision), unit: temperatureScale]\n+\tcreateEvent(map)\n+}\n+\n+def zwaveEvent(physicalgraph.zwave.Command cmd) {\n+\tlog.warn \"Unhandled command: ${cmd}\"\n+\t[:]\n+}\n+\n+def setThermostatMode(String mode) {\n+\tdef modeValue = 0\n+\tif (thermostatSupportedModes.contains(mode)) {\n+\t\tswitch (mode) {\n+\t\t\tcase \"heat\":\n+\t\t\t\tmodeValue = 1\n+\t\t\t\tbreak\n+\t\t\tcase \"emergency heat\":\n+\t\t\t\tmodeValue = 11\n+\t\t\t\tbreak\n+\t\t\tcase \"off\":\n+\t\t\t\tmodeValue = 0\n+\t\t\t\tbreak\n+\t\t}\n+\t} else {\n+\t\tlog.debug \"Unsupported mode ${mode}\"\n+\t}\n+\n+\t[\n+\t\t\tsecure(zwave.thermostatModeV2.thermostatModeSet(mode: modeValue)),\n+\t\t\t\"delay 2000\",\n+\t\t\tsecure(zwave.thermostatModeV2.thermostatModeGet())\n+\t]\n+}\n+\n+def heat() {\n+\tsetThermostatMode(\"heat\")\n+}\n+\n+def emergencyHeat() {\n+\tsetThermostatMode(\"emergency heat\")\n+}\n+\n+def off() {\n+\tsetThermostatMode(\"off\")\n+}\n+\n+def setHeatingSetpoint(setpoint) {\n+\tsetpoint = temperatureScale == 'C' ? setpoint : fahrenheitToCelsius(setpoint)\n+\tsetpoint = Math.max(Math.min(setpoint, maxHeatingSetpointTemperature), minHeatingSetpointTemperature)\n+\t[\n+\t\t\tsecure(zwave.thermostatSetpointV2.thermostatSetpointSet([precision: 1, scale: 0, scaledValue: setpoint, setpointType: 1, size: 2])),","path":"devicetypes/smartthings/zwave-radiator-thermostat.src/zwave-radiator-thermostat.groovy","position":199,"original_position":199,"commit_id":"1d44659fbb7e1ec8815f4634cabfbddf589ae9df","original_commit_id":"1d44659fbb7e1ec8815f4634cabfbddf589ae9df","user":{"login":"PKacprowiczS","id":41617389,"node_id":"MDQ6VXNlcjQxNjE3Mzg5","avatar_url":"https://avatars3.githubusercontent.com/u/41617389?v=4","gravatar_id":"","url":"https://api.github.com/users/PKacprowiczS","html_url":"https://github.com/PKacprowiczS","followers_url":"https://api.github.com/users/PKacprowiczS/followers","following_url":"https://api.github.com/users/PKacprowiczS/following{/other_user}","gists_url":"https://api.github.com/users/PKacprowiczS/gists{/gist_id}","starred_url":"https://api.github.com/users/PKacprowiczS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PKacprowiczS/subscriptions","organizations_url":"https://api.github.com/users/PKacprowiczS/orgs","repos_url":"https://api.github.com/users/PKacprowiczS/repos","events_url":"https://api.github.com/users/PKacprowiczS/events{/privacy}","received_events_url":"https://api.github.com/users/PKacprowiczS/received_events","type":"User","site_admin":false},"body":"@greens I've added a note, but I'm not sure if it is what you've though about","created_at":"2019-10-01T08:42:08Z","updated_at":"2019-10-01T08:42:08Z","html_url":"https://github.com/SmartThingsCommunity/SmartThingsPublic/pull/11285#discussion_r329940499","pull_request_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/pulls/11285","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/pulls/comments/329940499"},"html":{"href":"https://github.com/SmartThingsCommunity/SmartThingsPublic/pull/11285#discussion_r329940499"},"pull_request":{"href":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/pulls/11285"}},"in_reply_to_id":329797860},"pull_request":{"url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/pulls/11285","id":316816166,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE2ODE2MTY2","html_url":"https://github.com/SmartThingsCommunity/SmartThingsPublic/pull/11285","diff_url":"https://github.com/SmartThingsCommunity/SmartThingsPublic/pull/11285.diff","patch_url":"https://github.com/SmartThingsCommunity/SmartThingsPublic/pull/11285.patch","issue_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/issues/11285","number":11285,"state":"open","locked":false,"title":"[WWST-5165] Everspring Radiator Thermostat integration","user":{"login":"PKacprowiczS","id":41617389,"node_id":"MDQ6VXNlcjQxNjE3Mzg5","avatar_url":"https://avatars3.githubusercontent.com/u/41617389?v=4","gravatar_id":"","url":"https://api.github.com/users/PKacprowiczS","html_url":"https://github.com/PKacprowiczS","followers_url":"https://api.github.com/users/PKacprowiczS/followers","following_url":"https://api.github.com/users/PKacprowiczS/following{/other_user}","gists_url":"https://api.github.com/users/PKacprowiczS/gists{/gist_id}","starred_url":"https://api.github.com/users/PKacprowiczS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PKacprowiczS/subscriptions","organizations_url":"https://api.github.com/users/PKacprowiczS/orgs","repos_url":"https://api.github.com/users/PKacprowiczS/repos","events_url":"https://api.github.com/users/PKacprowiczS/events{/privacy}","received_events_url":"https://api.github.com/users/PKacprowiczS/received_events","type":"User","site_admin":false},"body":"@greens @dkirker @kianooshST @MAblewiczS @KKlimczukS @MGoralczykS @ZWozniakS \r\nmetadata for this device is at WWST-5519\r\nplease share your thoughts","created_at":"2019-09-12T09:34:44Z","updated_at":"2019-10-01T08:42:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35ec4400a244f23685dd8ae26f49155b7ba3cd8d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kianooshST","id":25484456,"node_id":"MDQ6VXNlcjI1NDg0NDU2","avatar_url":"https://avatars1.githubusercontent.com/u/25484456?v=4","gravatar_id":"","url":"https://api.github.com/users/kianooshST","html_url":"https://github.com/kianooshST","followers_url":"https://api.github.com/users/kianooshST/followers","following_url":"https://api.github.com/users/kianooshST/following{/other_user}","gists_url":"https://api.github.com/users/kianooshST/gists{/gist_id}","starred_url":"https://api.github.com/users/kianooshST/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kianooshST/subscriptions","organizations_url":"https://api.github.com/users/kianooshST/orgs","repos_url":"https://api.github.com/users/kianooshST/repos","events_url":"https://api.github.com/users/kianooshST/events{/privacy}","received_events_url":"https://api.github.com/users/kianooshST/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/pulls/11285/commits","review_comments_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/pulls/11285/comments","review_comment_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/issues/11285/comments","statuses_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/statuses/1d44659fbb7e1ec8815f4634cabfbddf589ae9df","head":{"label":"PKacprowiczS:WWST-5165","ref":"WWST-5165","sha":"1d44659fbb7e1ec8815f4634cabfbddf589ae9df","user":{"login":"PKacprowiczS","id":41617389,"node_id":"MDQ6VXNlcjQxNjE3Mzg5","avatar_url":"https://avatars3.githubusercontent.com/u/41617389?v=4","gravatar_id":"","url":"https://api.github.com/users/PKacprowiczS","html_url":"https://github.com/PKacprowiczS","followers_url":"https://api.github.com/users/PKacprowiczS/followers","following_url":"https://api.github.com/users/PKacprowiczS/following{/other_user}","gists_url":"https://api.github.com/users/PKacprowiczS/gists{/gist_id}","starred_url":"https://api.github.com/users/PKacprowiczS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PKacprowiczS/subscriptions","organizations_url":"https://api.github.com/users/PKacprowiczS/orgs","repos_url":"https://api.github.com/users/PKacprowiczS/repos","events_url":"https://api.github.com/users/PKacprowiczS/events{/privacy}","received_events_url":"https://api.github.com/users/PKacprowiczS/received_events","type":"User","site_admin":false},"repo":{"id":142155245,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIxNTUyNDU=","name":"SmartThingsPublic","full_name":"PKacprowiczS/SmartThingsPublic","private":false,"owner":{"login":"PKacprowiczS","id":41617389,"node_id":"MDQ6VXNlcjQxNjE3Mzg5","avatar_url":"https://avatars3.githubusercontent.com/u/41617389?v=4","gravatar_id":"","url":"https://api.github.com/users/PKacprowiczS","html_url":"https://github.com/PKacprowiczS","followers_url":"https://api.github.com/users/PKacprowiczS/followers","following_url":"https://api.github.com/users/PKacprowiczS/following{/other_user}","gists_url":"https://api.github.com/users/PKacprowiczS/gists{/gist_id}","starred_url":"https://api.github.com/users/PKacprowiczS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PKacprowiczS/subscriptions","organizations_url":"https://api.github.com/users/PKacprowiczS/orgs","repos_url":"https://api.github.com/users/PKacprowiczS/repos","events_url":"https://api.github.com/users/PKacprowiczS/events{/privacy}","received_events_url":"https://api.github.com/users/PKacprowiczS/received_events","type":"User","site_admin":false},"html_url":"https://github.com/PKacprowiczS/SmartThingsPublic","description":"SmartThings open-source DeviceTypeHandlers and SmartApps code","fork":true,"url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic","forks_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/forks","keys_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/teams","hooks_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/hooks","issue_events_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/issues/events{/number}","events_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/events","assignees_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/assignees{/user}","branches_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/branches{/branch}","tags_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/tags","blobs_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/git/refs{/sha}","trees_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/statuses/{sha}","languages_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/languages","stargazers_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/stargazers","contributors_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/contributors","subscribers_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/subscribers","subscription_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/subscription","commits_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/commits{/sha}","git_commits_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/git/commits{/sha}","comments_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/comments{/number}","issue_comment_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/issues/comments{/number}","contents_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/contents/{+path}","compare_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/merges","archive_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/downloads","issues_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/issues{/number}","pulls_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/pulls{/number}","milestones_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/milestones{/number}","notifications_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/labels{/name}","releases_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/releases{/id}","deployments_url":"https://api.github.com/repos/PKacprowiczS/SmartThingsPublic/deployments","created_at":"2018-07-24T12:27:03Z","updated_at":"2019-09-11T12:39:28Z","pushed_at":"2019-10-01T08:41:48Z","git_url":"git://github.com/PKacprowiczS/SmartThingsPublic.git","ssh_url":"[email protected]:PKacprowiczS/SmartThingsPublic.git","clone_url":"https://github.com/PKacprowiczS/SmartThingsPublic.git","svn_url":"https://github.com/PKacprowiczS/SmartThingsPublic","homepage":"http://developer.smartthings.com/","size":13906,"stargazers_count":1,"watchers_count":1,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"SmartThingsCommunity:master","ref":"master","sha":"a174479b1d68b79e096027b8bcf4be49997980b1","user":{"login":"SmartThingsCommunity","id":7317431,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMTc0MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/7317431?v=4","gravatar_id":"","url":"https://api.github.com/users/SmartThingsCommunity","html_url":"https://github.com/SmartThingsCommunity","followers_url":"https://api.github.com/users/SmartThingsCommunity/followers","following_url":"https://api.github.com/users/SmartThingsCommunity/following{/other_user}","gists_url":"https://api.github.com/users/SmartThingsCommunity/gists{/gist_id}","starred_url":"https://api.github.com/users/SmartThingsCommunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmartThingsCommunity/subscriptions","organizations_url":"https://api.github.com/users/SmartThingsCommunity/orgs","repos_url":"https://api.github.com/users/SmartThingsCommunity/repos","events_url":"https://api.github.com/users/SmartThingsCommunity/events{/privacy}","received_events_url":"https://api.github.com/users/SmartThingsCommunity/received_events","type":"Organization","site_admin":false},"repo":{"id":40212802,"node_id":"MDEwOlJlcG9zaXRvcnk0MDIxMjgwMg==","name":"SmartThingsPublic","full_name":"SmartThingsCommunity/SmartThingsPublic","private":false,"owner":{"login":"SmartThingsCommunity","id":7317431,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczMTc0MzE=","avatar_url":"https://avatars0.githubusercontent.com/u/7317431?v=4","gravatar_id":"","url":"https://api.github.com/users/SmartThingsCommunity","html_url":"https://github.com/SmartThingsCommunity","followers_url":"https://api.github.com/users/SmartThingsCommunity/followers","following_url":"https://api.github.com/users/SmartThingsCommunity/following{/other_user}","gists_url":"https://api.github.com/users/SmartThingsCommunity/gists{/gist_id}","starred_url":"https://api.github.com/users/SmartThingsCommunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmartThingsCommunity/subscriptions","organizations_url":"https://api.github.com/users/SmartThingsCommunity/orgs","repos_url":"https://api.github.com/users/SmartThingsCommunity/repos","events_url":"https://api.github.com/users/SmartThingsCommunity/events{/privacy}","received_events_url":"https://api.github.com/users/SmartThingsCommunity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SmartThingsCommunity/SmartThingsPublic","description":"SmartThings open-source DeviceTypeHandlers and SmartApps code","fork":false,"url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic","forks_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/forks","keys_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/teams","hooks_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/hooks","issue_events_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/issues/events{/number}","events_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/events","assignees_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/assignees{/user}","branches_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/branches{/branch}","tags_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/tags","blobs_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/statuses/{sha}","languages_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/languages","stargazers_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/stargazers","contributors_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/contributors","subscribers_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/subscribers","subscription_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/subscription","commits_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/contents/{+path}","compare_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/merges","archive_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/downloads","issues_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/issues{/number}","pulls_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/pulls{/number}","milestones_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/milestones{/number}","notifications_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/labels{/name}","releases_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/releases{/id}","deployments_url":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/deployments","created_at":"2015-08-04T22:48:02Z","updated_at":"2019-09-30T17:18:05Z","pushed_at":"2019-10-01T00:05:37Z","git_url":"git://github.com/SmartThingsCommunity/SmartThingsPublic.git","ssh_url":"[email protected]:SmartThingsCommunity/SmartThingsPublic.git","clone_url":"https://github.com/SmartThingsCommunity/SmartThingsPublic.git","svn_url":"https://github.com/SmartThingsCommunity/SmartThingsPublic","homepage":"https://docs.smartthings.com/en/latest/","size":14721,"stargazers_count":1381,"watchers_count":1381,"language":"Groovy","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60042,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1327,"license":null,"forks":60042,"open_issues":1327,"watchers":1381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/pulls/11285"},"html":{"href":"https://github.com/SmartThingsCommunity/SmartThingsPublic/pull/11285"},"issue":{"href":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/issues/11285"},"comments":{"href":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/issues/11285/comments"},"review_comments":{"href":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/pulls/11285/comments"},"review_comment":{"href":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/pulls/11285/commits"},"statuses":{"href":"https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic/statuses/1d44659fbb7e1ec8815f4634cabfbddf589ae9df"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 40212802,
"name": "SmartThingsCommunity/SmartThingsPublic",
"url": "https://api.github.com/repos/SmartThingsCommunity/SmartThingsPublic"
}
|
{
"id": 41617389,
"login": "PKacprowiczS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/41617389?",
"url": "https://api.github.com/users/PKacprowiczS"
}
|
{
"id": 7317431,
"login": "SmartThingsCommunity",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7317431?",
"url": "https://api.github.com/orgs/SmartThingsCommunity"
}
| 2019-10-01T08:42:08 |
10531513080
|
{"actor":{"display_login":"PKacprowiczS"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dbs-leipzig/gradoop/pulls/comments/339304185","pull_request_review_id":307530627,"id":339304185,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzOTMwNDE4NQ==","diff_hunk":"@@ -0,0 +1,182 @@\n+/*\n+ * Copyright © 2014 - 2019 Leipzig University (Database Research Group)\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.gradoop.flink.model.impl.operators.layouting;\n+\n+import org.apache.flink.api.java.DataSet;\n+import org.apache.flink.api.java.operators.IterativeDataSet;\n+import org.gradoop.common.model.impl.pojo.EPGMEdge;\n+import org.gradoop.common.model.impl.pojo.EPGMVertex;\n+import org.gradoop.flink.model.impl.epgm.LogicalGraph;\n+import org.gradoop.flink.model.impl.functions.epgm.Id;\n+import org.gradoop.flink.model.impl.operators.layouting.functions.AverageVertexPositionsFunction;\n+import org.gradoop.flink.model.impl.operators.layouting.util.Centroid;\n+import org.gradoop.flink.model.impl.operators.layouting.functions.CentroidRepulsionForceMapper;\n+import org.gradoop.flink.model.impl.operators.layouting.functions.CentroidUpdater;\n+import org.gradoop.flink.model.impl.operators.layouting.functions.FRRepulsionFunction;\n+import org.gradoop.flink.model.impl.operators.layouting.functions.LVertexEPGMVertexJoinFunction;\n+import org.gradoop.flink.model.impl.operators.layouting.util.Force;\n+import org.gradoop.flink.model.impl.operators.layouting.util.GraphElement;\n+import org.gradoop.flink.model.impl.operators.layouting.util.LEdge;\n+import org.gradoop.flink.model.impl.operators.layouting.util.LGraph;\n+import org.gradoop.flink.model.impl.operators.layouting.util.LVertex;\n+import org.gradoop.flink.model.impl.operators.layouting.util.Vector;\n+\n+/**\n+ * Layout a graph using approximate repulsive forces calculated using centroids as described\n+ * <a href=\"https://www.researchgate.net/publication/281348264_Distributed_Graph_Layout_with_Spark\">\n+ * here</a>\n+ * Very fast, even for large inputs.\n+ */\n+public class CentroidFRLayouter extends FRLayouter {","path":"gradoop-flink/src/main/java/org/gradoop/flink/model/impl/operators/layouting/CentroidFRLayouter.java","position":43,"original_position":43,"commit_id":"60ddcbcbed96b1b8c73f6cca06256c635657e9ba","original_commit_id":"60ddcbcbed96b1b8c73f6cca06256c635657e9ba","user":{"login":"Rascat","id":25148142,"node_id":"MDQ6VXNlcjI1MTQ4MTQy","avatar_url":"https://avatars0.githubusercontent.com/u/25148142?v=4","gravatar_id":"","url":"https://api.github.com/users/Rascat","html_url":"https://github.com/Rascat","followers_url":"https://api.github.com/users/Rascat/followers","following_url":"https://api.github.com/users/Rascat/following{/other_user}","gists_url":"https://api.github.com/users/Rascat/gists{/gist_id}","starred_url":"https://api.github.com/users/Rascat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rascat/subscriptions","organizations_url":"https://api.github.com/users/Rascat/orgs","repos_url":"https://api.github.com/users/Rascat/repos","events_url":"https://api.github.com/users/Rascat/events{/privacy}","received_events_url":"https://api.github.com/users/Rascat/received_events","type":"User","site_admin":false},"body":"Thanks thats very helpful! Given the fact that the centroids are a way to compute repulsive forces on distributed system in heuristic fashion, one could argue that the algorithm really does not need to be applied to such small graphs which can easily be processed by a single machine.\r\n\r\nI'm definitely going to check the matrix collection out :+1:","created_at":"2019-10-26T15:27:09Z","updated_at":"2019-10-26T15:27:09Z","html_url":"https://github.com/dbs-leipzig/gradoop/pull/1401#discussion_r339304185","pull_request_url":"https://api.github.com/repos/dbs-leipzig/gradoop/pulls/1401","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dbs-leipzig/gradoop/pulls/comments/339304185"},"html":{"href":"https://github.com/dbs-leipzig/gradoop/pull/1401#discussion_r339304185"},"pull_request":{"href":"https://api.github.com/repos/dbs-leipzig/gradoop/pulls/1401"}},"in_reply_to_id":337500266},"pull_request":{"url":"https://api.github.com/repos/dbs-leipzig/gradoop/pulls/1401","id":319196043,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE5MTk2MDQz","html_url":"https://github.com/dbs-leipzig/gradoop/pull/1401","diff_url":"https://github.com/dbs-leipzig/gradoop/pull/1401.diff","patch_url":"https://github.com/dbs-leipzig/gradoop/pull/1401.patch","issue_url":"https://api.github.com/repos/dbs-leipzig/gradoop/issues/1401","number":1401,"state":"open","locked":false,"title":"[#1274] Implemented distributed layouting","user":{"login":"dbaumgarten","id":8211271,"node_id":"MDQ6VXNlcjgyMTEyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/8211271?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaumgarten","html_url":"https://github.com/dbaumgarten","followers_url":"https://api.github.com/users/dbaumgarten/followers","following_url":"https://api.github.com/users/dbaumgarten/following{/other_user}","gists_url":"https://api.github.com/users/dbaumgarten/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaumgarten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaumgarten/subscriptions","organizations_url":"https://api.github.com/users/dbaumgarten/orgs","repos_url":"https://api.github.com/users/dbaumgarten/repos","events_url":"https://api.github.com/users/dbaumgarten/events{/privacy}","received_events_url":"https://api.github.com/users/dbaumgarten/received_events","type":"User","site_admin":false},"body":"- Implemented different layouting algorithms\r\n- Implemented statistics for graph layouts\r\n- Implemented plotter for layouted graphs\r\n- Implemented benchmark class for graph layouting algorithms","created_at":"2019-09-19T10:04:27Z","updated_at":"2019-10-26T15:27:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d164bdf30dc14b9930645c5ea843474cdddb4b7c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dbs-leipzig/gradoop/pulls/1401/commits","review_comments_url":"https://api.github.com/repos/dbs-leipzig/gradoop/pulls/1401/comments","review_comment_url":"https://api.github.com/repos/dbs-leipzig/gradoop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dbs-leipzig/gradoop/issues/1401/comments","statuses_url":"https://api.github.com/repos/dbs-leipzig/gradoop/statuses/60ddcbcbed96b1b8c73f6cca06256c635657e9ba","head":{"label":"dbaumgarten:1274-distributed-layouting","ref":"1274-distributed-layouting","sha":"60ddcbcbed96b1b8c73f6cca06256c635657e9ba","user":{"login":"dbaumgarten","id":8211271,"node_id":"MDQ6VXNlcjgyMTEyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/8211271?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaumgarten","html_url":"https://github.com/dbaumgarten","followers_url":"https://api.github.com/users/dbaumgarten/followers","following_url":"https://api.github.com/users/dbaumgarten/following{/other_user}","gists_url":"https://api.github.com/users/dbaumgarten/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaumgarten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaumgarten/subscriptions","organizations_url":"https://api.github.com/users/dbaumgarten/orgs","repos_url":"https://api.github.com/users/dbaumgarten/repos","events_url":"https://api.github.com/users/dbaumgarten/events{/privacy}","received_events_url":"https://api.github.com/users/dbaumgarten/received_events","type":"User","site_admin":false},"repo":{"id":187798423,"node_id":"MDEwOlJlcG9zaXRvcnkxODc3OTg0MjM=","name":"gradoop","full_name":"dbaumgarten/gradoop","private":false,"owner":{"login":"dbaumgarten","id":8211271,"node_id":"MDQ6VXNlcjgyMTEyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/8211271?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaumgarten","html_url":"https://github.com/dbaumgarten","followers_url":"https://api.github.com/users/dbaumgarten/followers","following_url":"https://api.github.com/users/dbaumgarten/following{/other_user}","gists_url":"https://api.github.com/users/dbaumgarten/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaumgarten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaumgarten/subscriptions","organizations_url":"https://api.github.com/users/dbaumgarten/orgs","repos_url":"https://api.github.com/users/dbaumgarten/repos","events_url":"https://api.github.com/users/dbaumgarten/events{/privacy}","received_events_url":"https://api.github.com/users/dbaumgarten/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dbaumgarten/gradoop","description":"Distributed Graph Analytics with Apache Flink","fork":true,"url":"https://api.github.com/repos/dbaumgarten/gradoop","forks_url":"https://api.github.com/repos/dbaumgarten/gradoop/forks","keys_url":"https://api.github.com/repos/dbaumgarten/gradoop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbaumgarten/gradoop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbaumgarten/gradoop/teams","hooks_url":"https://api.github.com/repos/dbaumgarten/gradoop/hooks","issue_events_url":"https://api.github.com/repos/dbaumgarten/gradoop/issues/events{/number}","events_url":"https://api.github.com/repos/dbaumgarten/gradoop/events","assignees_url":"https://api.github.com/repos/dbaumgarten/gradoop/assignees{/user}","branches_url":"https://api.github.com/repos/dbaumgarten/gradoop/branches{/branch}","tags_url":"https://api.github.com/repos/dbaumgarten/gradoop/tags","blobs_url":"https://api.github.com/repos/dbaumgarten/gradoop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbaumgarten/gradoop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbaumgarten/gradoop/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbaumgarten/gradoop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbaumgarten/gradoop/statuses/{sha}","languages_url":"https://api.github.com/repos/dbaumgarten/gradoop/languages","stargazers_url":"https://api.github.com/repos/dbaumgarten/gradoop/stargazers","contributors_url":"https://api.github.com/repos/dbaumgarten/gradoop/contributors","subscribers_url":"https://api.github.com/repos/dbaumgarten/gradoop/subscribers","subscription_url":"https://api.github.com/repos/dbaumgarten/gradoop/subscription","commits_url":"https://api.github.com/repos/dbaumgarten/gradoop/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbaumgarten/gradoop/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbaumgarten/gradoop/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbaumgarten/gradoop/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbaumgarten/gradoop/contents/{+path}","compare_url":"https://api.github.com/repos/dbaumgarten/gradoop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbaumgarten/gradoop/merges","archive_url":"https://api.github.com/repos/dbaumgarten/gradoop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbaumgarten/gradoop/downloads","issues_url":"https://api.github.com/repos/dbaumgarten/gradoop/issues{/number}","pulls_url":"https://api.github.com/repos/dbaumgarten/gradoop/pulls{/number}","milestones_url":"https://api.github.com/repos/dbaumgarten/gradoop/milestones{/number}","notifications_url":"https://api.github.com/repos/dbaumgarten/gradoop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbaumgarten/gradoop/labels{/name}","releases_url":"https://api.github.com/repos/dbaumgarten/gradoop/releases{/id}","deployments_url":"https://api.github.com/repos/dbaumgarten/gradoop/deployments","created_at":"2019-05-21T08:48:47Z","updated_at":"2019-09-18T14:46:13Z","pushed_at":"2019-10-20T22:24:34Z","git_url":"git://github.com/dbaumgarten/gradoop.git","ssh_url":"[email protected]:dbaumgarten/gradoop.git","clone_url":"https://github.com/dbaumgarten/gradoop.git","svn_url":"https://github.com/dbaumgarten/gradoop","homepage":"http://www.gradoop.org","size":89826,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"dbs-leipzig:develop","ref":"develop","sha":"afbbe0c88c9fadf075e3887774d268bbf9b75bf1","user":{"login":"dbs-leipzig","id":7394964,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczOTQ5NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7394964?v=4","gravatar_id":"","url":"https://api.github.com/users/dbs-leipzig","html_url":"https://github.com/dbs-leipzig","followers_url":"https://api.github.com/users/dbs-leipzig/followers","following_url":"https://api.github.com/users/dbs-leipzig/following{/other_user}","gists_url":"https://api.github.com/users/dbs-leipzig/gists{/gist_id}","starred_url":"https://api.github.com/users/dbs-leipzig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbs-leipzig/subscriptions","organizations_url":"https://api.github.com/users/dbs-leipzig/orgs","repos_url":"https://api.github.com/users/dbs-leipzig/repos","events_url":"https://api.github.com/users/dbs-leipzig/events{/privacy}","received_events_url":"https://api.github.com/users/dbs-leipzig/received_events","type":"Organization","site_admin":false},"repo":{"id":26323526,"node_id":"MDEwOlJlcG9zaXRvcnkyNjMyMzUyNg==","name":"gradoop","full_name":"dbs-leipzig/gradoop","private":false,"owner":{"login":"dbs-leipzig","id":7394964,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczOTQ5NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7394964?v=4","gravatar_id":"","url":"https://api.github.com/users/dbs-leipzig","html_url":"https://github.com/dbs-leipzig","followers_url":"https://api.github.com/users/dbs-leipzig/followers","following_url":"https://api.github.com/users/dbs-leipzig/following{/other_user}","gists_url":"https://api.github.com/users/dbs-leipzig/gists{/gist_id}","starred_url":"https://api.github.com/users/dbs-leipzig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbs-leipzig/subscriptions","organizations_url":"https://api.github.com/users/dbs-leipzig/orgs","repos_url":"https://api.github.com/users/dbs-leipzig/repos","events_url":"https://api.github.com/users/dbs-leipzig/events{/privacy}","received_events_url":"https://api.github.com/users/dbs-leipzig/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dbs-leipzig/gradoop","description":"Distributed Graph Analytics with Apache Flink","fork":false,"url":"https://api.github.com/repos/dbs-leipzig/gradoop","forks_url":"https://api.github.com/repos/dbs-leipzig/gradoop/forks","keys_url":"https://api.github.com/repos/dbs-leipzig/gradoop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbs-leipzig/gradoop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbs-leipzig/gradoop/teams","hooks_url":"https://api.github.com/repos/dbs-leipzig/gradoop/hooks","issue_events_url":"https://api.github.com/repos/dbs-leipzig/gradoop/issues/events{/number}","events_url":"https://api.github.com/repos/dbs-leipzig/gradoop/events","assignees_url":"https://api.github.com/repos/dbs-leipzig/gradoop/assignees{/user}","branches_url":"https://api.github.com/repos/dbs-leipzig/gradoop/branches{/branch}","tags_url":"https://api.github.com/repos/dbs-leipzig/gradoop/tags","blobs_url":"https://api.github.com/repos/dbs-leipzig/gradoop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbs-leipzig/gradoop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbs-leipzig/gradoop/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbs-leipzig/gradoop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbs-leipzig/gradoop/statuses/{sha}","languages_url":"https://api.github.com/repos/dbs-leipzig/gradoop/languages","stargazers_url":"https://api.github.com/repos/dbs-leipzig/gradoop/stargazers","contributors_url":"https://api.github.com/repos/dbs-leipzig/gradoop/contributors","subscribers_url":"https://api.github.com/repos/dbs-leipzig/gradoop/subscribers","subscription_url":"https://api.github.com/repos/dbs-leipzig/gradoop/subscription","commits_url":"https://api.github.com/repos/dbs-leipzig/gradoop/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbs-leipzig/gradoop/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbs-leipzig/gradoop/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbs-leipzig/gradoop/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbs-leipzig/gradoop/contents/{+path}","compare_url":"https://api.github.com/repos/dbs-leipzig/gradoop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbs-leipzig/gradoop/merges","archive_url":"https://api.github.com/repos/dbs-leipzig/gradoop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbs-leipzig/gradoop/downloads","issues_url":"https://api.github.com/repos/dbs-leipzig/gradoop/issues{/number}","pulls_url":"https://api.github.com/repos/dbs-leipzig/gradoop/pulls{/number}","milestones_url":"https://api.github.com/repos/dbs-leipzig/gradoop/milestones{/number}","notifications_url":"https://api.github.com/repos/dbs-leipzig/gradoop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbs-leipzig/gradoop/labels{/name}","releases_url":"https://api.github.com/repos/dbs-leipzig/gradoop/releases{/id}","deployments_url":"https://api.github.com/repos/dbs-leipzig/gradoop/deployments","created_at":"2014-11-07T14:42:45Z","updated_at":"2019-10-19T08:23:30Z","pushed_at":"2019-10-25T14:34:46Z","git_url":"git://github.com/dbs-leipzig/gradoop.git","ssh_url":"[email protected]:dbs-leipzig/gradoop.git","clone_url":"https://github.com/dbs-leipzig/gradoop.git","svn_url":"https://github.com/dbs-leipzig/gradoop","homepage":"http://www.gradoop.org","size":160864,"stargazers_count":157,"watchers_count":157,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":71,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":85,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":71,"open_issues":85,"watchers":157,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/dbs-leipzig/gradoop/pulls/1401"},"html":{"href":"https://github.com/dbs-leipzig/gradoop/pull/1401"},"issue":{"href":"https://api.github.com/repos/dbs-leipzig/gradoop/issues/1401"},"comments":{"href":"https://api.github.com/repos/dbs-leipzig/gradoop/issues/1401/comments"},"review_comments":{"href":"https://api.github.com/repos/dbs-leipzig/gradoop/pulls/1401/comments"},"review_comment":{"href":"https://api.github.com/repos/dbs-leipzig/gradoop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dbs-leipzig/gradoop/pulls/1401/commits"},"statuses":{"href":"https://api.github.com/repos/dbs-leipzig/gradoop/statuses/60ddcbcbed96b1b8c73f6cca06256c635657e9ba"}},"author_association":"NONE"}}
|
{
"id": 26323526,
"name": "dbs-leipzig/gradoop",
"url": "https://api.github.com/repos/dbs-leipzig/gradoop"
}
|
{
"id": 25148142,
"login": "Rascat",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/25148142?",
"url": "https://api.github.com/users/Rascat"
}
|
{
"id": 7394964,
"login": "dbs-leipzig",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7394964?",
"url": "https://api.github.com/orgs/dbs-leipzig"
}
| 2019-10-26T15:27:09 |
10720123412
|
{"actor":{"display_login":"Rascat"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/comments/275618383","pull_request_review_id":226970704,"id":275618383,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTYxODM4Mw==","diff_hunk":"@@ -0,0 +1,57 @@\n+const _ = require('lodash');\n+const browserslist = require('browserslist');\n+\n+function getTemplate() {\n+ return _.mapValues(browserslist.data, (info) => {\n+ const versionMap = {};\n+ info.versions.forEach((version) => {\n+ versionMap[version] = 0;\n+ });\n+ return versionMap;\n+ });\n+}\n+\n+function getVersionMapping(browserCode, versionString) {\n+ const versions = _.get(browserslist, ['data', browserCode, 'versions']);\n+ if (!versions) {\n+ return undefined;\n+ }\n+\n+ let version;\n+ if (browserCode === 'edge') {\n+ version = versionString.split('.')[0];","path":"packages/browserslist-config-nusmods/scripts/helpers.js","position":22,"original_position":22,"commit_id":"b702f0858f96edacdcf4ff58c64af5d993a904ce","original_commit_id":"b702f0858f96edacdcf4ff58c64af5d993a904ce","user":{"login":"ZhangYiJiang","id":445650,"node_id":"MDQ6VXNlcjQ0NTY1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/445650?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhangYiJiang","html_url":"https://github.com/ZhangYiJiang","followers_url":"https://api.github.com/users/ZhangYiJiang/followers","following_url":"https://api.github.com/users/ZhangYiJiang/following{/other_user}","gists_url":"https://api.github.com/users/ZhangYiJiang/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhangYiJiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhangYiJiang/subscriptions","organizations_url":"https://api.github.com/users/ZhangYiJiang/orgs","repos_url":"https://api.github.com/users/ZhangYiJiang/repos","events_url":"https://api.github.com/users/ZhangYiJiang/events{/privacy}","received_events_url":"https://api.github.com/users/ZhangYiJiang/received_events","type":"User","site_admin":false},"body":"Do we want to do this for all browsers, splitting into major, minor and patch and parse int to normalize them","created_at":"2019-04-16T03:31:44Z","updated_at":"2019-04-16T03:31:44Z","html_url":"https://github.com/nusmodifications/nusmods/pull/1697#discussion_r275618383","pull_request_url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/1697","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/comments/275618383"},"html":{"href":"https://github.com/nusmodifications/nusmods/pull/1697#discussion_r275618383"},"pull_request":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/1697"}}},"pull_request":{"url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/1697","id":270611424,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcwNjExNDI0","html_url":"https://github.com/nusmodifications/nusmods/pull/1697","diff_url":"https://github.com/nusmodifications/nusmods/pull/1697.diff","patch_url":"https://github.com/nusmodifications/nusmods/pull/1697.patch","issue_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/1697","number":1697,"state":"open","locked":false,"title":"Improve browser support","user":{"login":"li-kai","id":14850387,"node_id":"MDQ6VXNlcjE0ODUwMzg3","avatar_url":"https://avatars2.githubusercontent.com/u/14850387?v=4","gravatar_id":"","url":"https://api.github.com/users/li-kai","html_url":"https://github.com/li-kai","followers_url":"https://api.github.com/users/li-kai/followers","following_url":"https://api.github.com/users/li-kai/following{/other_user}","gists_url":"https://api.github.com/users/li-kai/gists{/gist_id}","starred_url":"https://api.github.com/users/li-kai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/li-kai/subscriptions","organizations_url":"https://api.github.com/users/li-kai/orgs","repos_url":"https://api.github.com/users/li-kai/repos","events_url":"https://api.github.com/users/li-kai/events{/privacy}","received_events_url":"https://api.github.com/users/li-kai/received_events","type":"User","site_admin":false},"body":"I'll admit I've sort of dug a hole with this one, but I think its worth it.\r\n\r\nThis script scrapes our analytics and outputs a support matrix that provides 98% coverage of the student body. It's slightly naive, and takes shortcuts in places, but I think this is accurate enough.\r\n\r\nAs a result of this new coverage (and usage), our bundlesize has gone up by ~17kb. This is a worthy trade off to support older devices and might help prevent weird bugs from happening.","created_at":"2019-04-15T17:42:17Z","updated_at":"2019-04-16T03:31:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02bc8dba96151effcc70b3c22fc2760a485d6f10","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/1697/commits","review_comments_url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/1697/comments","review_comment_url":"https://api.github.com/repos/nusmodifications/nusmods/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/1697/comments","statuses_url":"https://api.github.com/repos/nusmodifications/nusmods/statuses/b702f0858f96edacdcf4ff58c64af5d993a904ce","head":{"label":"nusmodifications:improve-browser-support","ref":"improve-browser-support","sha":"b702f0858f96edacdcf4ff58c64af5d993a904ce","user":{"login":"nusmodifications","id":7428865,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mjg4NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/7428865?v=4","gravatar_id":"","url":"https://api.github.com/users/nusmodifications","html_url":"https://github.com/nusmodifications","followers_url":"https://api.github.com/users/nusmodifications/followers","following_url":"https://api.github.com/users/nusmodifications/following{/other_user}","gists_url":"https://api.github.com/users/nusmodifications/gists{/gist_id}","starred_url":"https://api.github.com/users/nusmodifications/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nusmodifications/subscriptions","organizations_url":"https://api.github.com/users/nusmodifications/orgs","repos_url":"https://api.github.com/users/nusmodifications/repos","events_url":"https://api.github.com/users/nusmodifications/events{/privacy}","received_events_url":"https://api.github.com/users/nusmodifications/received_events","type":"Organization","site_admin":false},"repo":{"id":5481861,"node_id":"MDEwOlJlcG9zaXRvcnk1NDgxODYx","name":"nusmods","full_name":"nusmodifications/nusmods","private":false,"owner":{"login":"nusmodifications","id":7428865,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mjg4NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/7428865?v=4","gravatar_id":"","url":"https://api.github.com/users/nusmodifications","html_url":"https://github.com/nusmodifications","followers_url":"https://api.github.com/users/nusmodifications/followers","following_url":"https://api.github.com/users/nusmodifications/following{/other_user}","gists_url":"https://api.github.com/users/nusmodifications/gists{/gist_id}","starred_url":"https://api.github.com/users/nusmodifications/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nusmodifications/subscriptions","organizations_url":"https://api.github.com/users/nusmodifications/orgs","repos_url":"https://api.github.com/users/nusmodifications/repos","events_url":"https://api.github.com/users/nusmodifications/events{/privacy}","received_events_url":"https://api.github.com/users/nusmodifications/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nusmodifications/nusmods","description":"🏫 Official course planning platform for National University of Singapore.","fork":false,"url":"https://api.github.com/repos/nusmodifications/nusmods","forks_url":"https://api.github.com/repos/nusmodifications/nusmods/forks","keys_url":"https://api.github.com/repos/nusmodifications/nusmods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nusmodifications/nusmods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nusmodifications/nusmods/teams","hooks_url":"https://api.github.com/repos/nusmodifications/nusmods/hooks","issue_events_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/events{/number}","events_url":"https://api.github.com/repos/nusmodifications/nusmods/events","assignees_url":"https://api.github.com/repos/nusmodifications/nusmods/assignees{/user}","branches_url":"https://api.github.com/repos/nusmodifications/nusmods/branches{/branch}","tags_url":"https://api.github.com/repos/nusmodifications/nusmods/tags","blobs_url":"https://api.github.com/repos/nusmodifications/nusmods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nusmodifications/nusmods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nusmodifications/nusmods/git/refs{/sha}","trees_url":"https://api.github.com/repos/nusmodifications/nusmods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nusmodifications/nusmods/statuses/{sha}","languages_url":"https://api.github.com/repos/nusmodifications/nusmods/languages","stargazers_url":"https://api.github.com/repos/nusmodifications/nusmods/stargazers","contributors_url":"https://api.github.com/repos/nusmodifications/nusmods/contributors","subscribers_url":"https://api.github.com/repos/nusmodifications/nusmods/subscribers","subscription_url":"https://api.github.com/repos/nusmodifications/nusmods/subscription","commits_url":"https://api.github.com/repos/nusmodifications/nusmods/commits{/sha}","git_commits_url":"https://api.github.com/repos/nusmodifications/nusmods/git/commits{/sha}","comments_url":"https://api.github.com/repos/nusmodifications/nusmods/comments{/number}","issue_comment_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/comments{/number}","contents_url":"https://api.github.com/repos/nusmodifications/nusmods/contents/{+path}","compare_url":"https://api.github.com/repos/nusmodifications/nusmods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nusmodifications/nusmods/merges","archive_url":"https://api.github.com/repos/nusmodifications/nusmods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nusmodifications/nusmods/downloads","issues_url":"https://api.github.com/repos/nusmodifications/nusmods/issues{/number}","pulls_url":"https://api.github.com/repos/nusmodifications/nusmods/pulls{/number}","milestones_url":"https://api.github.com/repos/nusmodifications/nusmods/milestones{/number}","notifications_url":"https://api.github.com/repos/nusmodifications/nusmods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nusmodifications/nusmods/labels{/name}","releases_url":"https://api.github.com/repos/nusmodifications/nusmods/releases{/id}","deployments_url":"https://api.github.com/repos/nusmodifications/nusmods/deployments","created_at":"2012-08-20T13:58:35Z","updated_at":"2019-04-16T02:40:37Z","pushed_at":"2019-04-15T19:39:17Z","git_url":"git://github.com/nusmodifications/nusmods.git","ssh_url":"[email protected]:nusmodifications/nusmods.git","clone_url":"https://github.com/nusmodifications/nusmods.git","svn_url":"https://github.com/nusmodifications/nusmods","homepage":"https://nusmods.com","size":19119,"stargazers_count":248,"watchers_count":248,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":141,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":86,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":141,"open_issues":86,"watchers":248,"default_branch":"master"}},"base":{"label":"nusmodifications:master","ref":"master","sha":"2f367fb3bbdf0753e09e3bfcce020c5cbe9a5e9b","user":{"login":"nusmodifications","id":7428865,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mjg4NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/7428865?v=4","gravatar_id":"","url":"https://api.github.com/users/nusmodifications","html_url":"https://github.com/nusmodifications","followers_url":"https://api.github.com/users/nusmodifications/followers","following_url":"https://api.github.com/users/nusmodifications/following{/other_user}","gists_url":"https://api.github.com/users/nusmodifications/gists{/gist_id}","starred_url":"https://api.github.com/users/nusmodifications/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nusmodifications/subscriptions","organizations_url":"https://api.github.com/users/nusmodifications/orgs","repos_url":"https://api.github.com/users/nusmodifications/repos","events_url":"https://api.github.com/users/nusmodifications/events{/privacy}","received_events_url":"https://api.github.com/users/nusmodifications/received_events","type":"Organization","site_admin":false},"repo":{"id":5481861,"node_id":"MDEwOlJlcG9zaXRvcnk1NDgxODYx","name":"nusmods","full_name":"nusmodifications/nusmods","private":false,"owner":{"login":"nusmodifications","id":7428865,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mjg4NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/7428865?v=4","gravatar_id":"","url":"https://api.github.com/users/nusmodifications","html_url":"https://github.com/nusmodifications","followers_url":"https://api.github.com/users/nusmodifications/followers","following_url":"https://api.github.com/users/nusmodifications/following{/other_user}","gists_url":"https://api.github.com/users/nusmodifications/gists{/gist_id}","starred_url":"https://api.github.com/users/nusmodifications/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nusmodifications/subscriptions","organizations_url":"https://api.github.com/users/nusmodifications/orgs","repos_url":"https://api.github.com/users/nusmodifications/repos","events_url":"https://api.github.com/users/nusmodifications/events{/privacy}","received_events_url":"https://api.github.com/users/nusmodifications/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nusmodifications/nusmods","description":"🏫 Official course planning platform for National University of Singapore.","fork":false,"url":"https://api.github.com/repos/nusmodifications/nusmods","forks_url":"https://api.github.com/repos/nusmodifications/nusmods/forks","keys_url":"https://api.github.com/repos/nusmodifications/nusmods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nusmodifications/nusmods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nusmodifications/nusmods/teams","hooks_url":"https://api.github.com/repos/nusmodifications/nusmods/hooks","issue_events_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/events{/number}","events_url":"https://api.github.com/repos/nusmodifications/nusmods/events","assignees_url":"https://api.github.com/repos/nusmodifications/nusmods/assignees{/user}","branches_url":"https://api.github.com/repos/nusmodifications/nusmods/branches{/branch}","tags_url":"https://api.github.com/repos/nusmodifications/nusmods/tags","blobs_url":"https://api.github.com/repos/nusmodifications/nusmods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nusmodifications/nusmods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nusmodifications/nusmods/git/refs{/sha}","trees_url":"https://api.github.com/repos/nusmodifications/nusmods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nusmodifications/nusmods/statuses/{sha}","languages_url":"https://api.github.com/repos/nusmodifications/nusmods/languages","stargazers_url":"https://api.github.com/repos/nusmodifications/nusmods/stargazers","contributors_url":"https://api.github.com/repos/nusmodifications/nusmods/contributors","subscribers_url":"https://api.github.com/repos/nusmodifications/nusmods/subscribers","subscription_url":"https://api.github.com/repos/nusmodifications/nusmods/subscription","commits_url":"https://api.github.com/repos/nusmodifications/nusmods/commits{/sha}","git_commits_url":"https://api.github.com/repos/nusmodifications/nusmods/git/commits{/sha}","comments_url":"https://api.github.com/repos/nusmodifications/nusmods/comments{/number}","issue_comment_url":"https://api.github.com/repos/nusmodifications/nusmods/issues/comments{/number}","contents_url":"https://api.github.com/repos/nusmodifications/nusmods/contents/{+path}","compare_url":"https://api.github.com/repos/nusmodifications/nusmods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nusmodifications/nusmods/merges","archive_url":"https://api.github.com/repos/nusmodifications/nusmods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nusmodifications/nusmods/downloads","issues_url":"https://api.github.com/repos/nusmodifications/nusmods/issues{/number}","pulls_url":"https://api.github.com/repos/nusmodifications/nusmods/pulls{/number}","milestones_url":"https://api.github.com/repos/nusmodifications/nusmods/milestones{/number}","notifications_url":"https://api.github.com/repos/nusmodifications/nusmods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nusmodifications/nusmods/labels{/name}","releases_url":"https://api.github.com/repos/nusmodifications/nusmods/releases{/id}","deployments_url":"https://api.github.com/repos/nusmodifications/nusmods/deployments","created_at":"2012-08-20T13:58:35Z","updated_at":"2019-04-16T02:40:37Z","pushed_at":"2019-04-15T19:39:17Z","git_url":"git://github.com/nusmodifications/nusmods.git","ssh_url":"[email protected]:nusmodifications/nusmods.git","clone_url":"https://github.com/nusmodifications/nusmods.git","svn_url":"https://github.com/nusmodifications/nusmods","homepage":"https://nusmods.com","size":19119,"stargazers_count":248,"watchers_count":248,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":141,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":86,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":141,"open_issues":86,"watchers":248,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/1697"},"html":{"href":"https://github.com/nusmodifications/nusmods/pull/1697"},"issue":{"href":"https://api.github.com/repos/nusmodifications/nusmods/issues/1697"},"comments":{"href":"https://api.github.com/repos/nusmodifications/nusmods/issues/1697/comments"},"review_comments":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/1697/comments"},"review_comment":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nusmodifications/nusmods/pulls/1697/commits"},"statuses":{"href":"https://api.github.com/repos/nusmodifications/nusmods/statuses/b702f0858f96edacdcf4ff58c64af5d993a904ce"}},"author_association":"MEMBER"}}
|
{
"id": 5481861,
"name": "nusmodifications/nusmods",
"url": "https://api.github.com/repos/nusmodifications/nusmods"
}
|
{
"id": 445650,
"login": "ZhangYiJiang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/445650?",
"url": "https://api.github.com/users/ZhangYiJiang"
}
|
{
"id": 7428865,
"login": "nusmodifications",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7428865?",
"url": "https://api.github.com/orgs/nusmodifications"
}
| 2019-04-16T03:31:44 |
9449794144
|
{"actor":{"display_login":"ZhangYiJiang"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/comments/288699067","pull_request_review_id":243426880,"id":288699067,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4ODY5OTA2Nw==","diff_hunk":"@@ -0,0 +1,176 @@\n+# Copyright 2019 Google Inc. All Rights Reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+# http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+\"\"\"Splits the BGZF file.\"\"\"\n+\n+import struct\n+from collections import namedtuple\n+from typing import Iterable, List, Tuple # pylint: disable=unused-import\n+\n+from apache_beam.io import filesystem\n+from apache_beam.io import filesystems\n+\n+# `Block` provides real file offset of the start and end of a gzip block. Given\n+# it, one can directly seek to the start of the gzip block and decompress it.\n+Block = namedtuple('Block', ['start', 'end'])\n+\n+_INDEX_FILE_APPENDIX = '.tbi'\n+\n+# `MAX_BLOCK_SIZE` defines the maximum amount of data included in one `Block`.\n+MAX_BLOCK_SIZE = 1 * 1024 * 1024\n+# It beyonds the normal bin range (1-37449), and contains other meta data rather\n+# than file offsets of GZIP blocks.\n+_RESERVED_BIN_ID = 37450\n+\n+\n+def split_bgzf(file_path):\n+ # type: (str) -> Iterable[Tuple[str, Block]]\n+ \"\"\"Splits BGZF to multiple blocks.\n+\n+ It reads the `Block` (GZIP block offsets) from the corresponding index file.\n+ Given (`file_path`, `Block`), one is able to decompress the data within\n+ `Block`. It further:\n+ - Removes invalid Blocks.\n+ - Fills in the gap (by inserting a new Block) if there are gaps between two\n+ adjacent Blocks to make sure it has full coverage of the variant data.\n+ - Merges Blocks. It eliminates overlapping Blocks, and merges adjacent Blocks","path":"gcp_variant_transforms/beam_io/bgzf_io.py","position":47,"original_position":47,"commit_id":"91fa2495f224dc7a37d9cd3985014195b4803a2f","original_commit_id":"91fa2495f224dc7a37d9cd3985014195b4803a2f","user":{"login":"kemp-google","id":28713279,"node_id":"MDQ6VXNlcjI4NzEzMjc5","avatar_url":"https://avatars3.githubusercontent.com/u/28713279?v=4","gravatar_id":"","url":"https://api.github.com/users/kemp-google","html_url":"https://github.com/kemp-google","followers_url":"https://api.github.com/users/kemp-google/followers","following_url":"https://api.github.com/users/kemp-google/following{/other_user}","gists_url":"https://api.github.com/users/kemp-google/gists{/gist_id}","starred_url":"https://api.github.com/users/kemp-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kemp-google/subscriptions","organizations_url":"https://api.github.com/users/kemp-google/orgs","repos_url":"https://api.github.com/users/kemp-google/repos","events_url":"https://api.github.com/users/kemp-google/events{/privacy}","received_events_url":"https://api.github.com/users/kemp-google/received_events","type":"User","site_admin":false},"body":"What circumstances lead to any of these conditions? Invalid blocks and gaps seem unlikely? Merging makes sense.\r\n\r\nWhat am I missing for the invalid and gap cases?","created_at":"2019-05-29T18:04:41Z","updated_at":"2019-05-29T18:16:01Z","html_url":"https://github.com/googlegenomics/gcp-variant-transforms/pull/484#discussion_r288699067","pull_request_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/484","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/comments/288699067"},"html":{"href":"https://github.com/googlegenomics/gcp-variant-transforms/pull/484#discussion_r288699067"},"pull_request":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/484"}}},"pull_request":{"url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/484","id":282143914,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgyMTQzOTE0","html_url":"https://github.com/googlegenomics/gcp-variant-transforms/pull/484","diff_url":"https://github.com/googlegenomics/gcp-variant-transforms/pull/484.diff","patch_url":"https://github.com/googlegenomics/gcp-variant-transforms/pull/484.patch","issue_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/484","number":484,"state":"open","locked":false,"title":"Add support for bgzf.","user":{"login":"allieychen","id":36679499,"node_id":"MDQ6VXNlcjM2Njc5NDk5","avatar_url":"https://avatars0.githubusercontent.com/u/36679499?v=4","gravatar_id":"","url":"https://api.github.com/users/allieychen","html_url":"https://github.com/allieychen","followers_url":"https://api.github.com/users/allieychen/followers","following_url":"https://api.github.com/users/allieychen/following{/other_user}","gists_url":"https://api.github.com/users/allieychen/gists{/gist_id}","starred_url":"https://api.github.com/users/allieychen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allieychen/subscriptions","organizations_url":"https://api.github.com/users/allieychen/orgs","repos_url":"https://api.github.com/users/allieychen/repos","events_url":"https://api.github.com/users/allieychen/events{/privacy}","received_events_url":"https://api.github.com/users/allieychen/received_events","type":"User","site_admin":false},"body":"If the index file is not present, use fusion break to speed up the pipeline.\r\nOtherwise, parse the index file and read the bgzf in parallel.\r\nThe BGZF can end with .gz or .bgz, and must be in GCS.\r\nThe index file is required to be in the same path as bgzf ending with .tbi.\r\nOnly PyVCF Parser is supported.","created_at":"2019-05-24T20:06:10Z","updated_at":"2019-05-29T18:16:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"968adaac2cae5856559602a697c90b47eee2ac42","assignee":{"login":"kemp-google","id":28713279,"node_id":"MDQ6VXNlcjI4NzEzMjc5","avatar_url":"https://avatars3.githubusercontent.com/u/28713279?v=4","gravatar_id":"","url":"https://api.github.com/users/kemp-google","html_url":"https://github.com/kemp-google","followers_url":"https://api.github.com/users/kemp-google/followers","following_url":"https://api.github.com/users/kemp-google/following{/other_user}","gists_url":"https://api.github.com/users/kemp-google/gists{/gist_id}","starred_url":"https://api.github.com/users/kemp-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kemp-google/subscriptions","organizations_url":"https://api.github.com/users/kemp-google/orgs","repos_url":"https://api.github.com/users/kemp-google/repos","events_url":"https://api.github.com/users/kemp-google/events{/privacy}","received_events_url":"https://api.github.com/users/kemp-google/received_events","type":"User","site_admin":false},"assignees":[{"login":"kemp-google","id":28713279,"node_id":"MDQ6VXNlcjI4NzEzMjc5","avatar_url":"https://avatars3.githubusercontent.com/u/28713279?v=4","gravatar_id":"","url":"https://api.github.com/users/kemp-google","html_url":"https://github.com/kemp-google","followers_url":"https://api.github.com/users/kemp-google/followers","following_url":"https://api.github.com/users/kemp-google/following{/other_user}","gists_url":"https://api.github.com/users/kemp-google/gists{/gist_id}","starred_url":"https://api.github.com/users/kemp-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kemp-google/subscriptions","organizations_url":"https://api.github.com/users/kemp-google/orgs","repos_url":"https://api.github.com/users/kemp-google/repos","events_url":"https://api.github.com/users/kemp-google/events{/privacy}","received_events_url":"https://api.github.com/users/kemp-google/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/484/commits","review_comments_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/484/comments","review_comment_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/484/comments","statuses_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/statuses/91fa2495f224dc7a37d9cd3985014195b4803a2f","head":{"label":"allieychen:bq2","ref":"bq2","sha":"91fa2495f224dc7a37d9cd3985014195b4803a2f","user":{"login":"allieychen","id":36679499,"node_id":"MDQ6VXNlcjM2Njc5NDk5","avatar_url":"https://avatars0.githubusercontent.com/u/36679499?v=4","gravatar_id":"","url":"https://api.github.com/users/allieychen","html_url":"https://github.com/allieychen","followers_url":"https://api.github.com/users/allieychen/followers","following_url":"https://api.github.com/users/allieychen/following{/other_user}","gists_url":"https://api.github.com/users/allieychen/gists{/gist_id}","starred_url":"https://api.github.com/users/allieychen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allieychen/subscriptions","organizations_url":"https://api.github.com/users/allieychen/orgs","repos_url":"https://api.github.com/users/allieychen/repos","events_url":"https://api.github.com/users/allieychen/events{/privacy}","received_events_url":"https://api.github.com/users/allieychen/received_events","type":"User","site_admin":false},"repo":{"id":122504365,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI1MDQzNjU=","name":"gcp-variant-transforms","full_name":"allieychen/gcp-variant-transforms","private":false,"owner":{"login":"allieychen","id":36679499,"node_id":"MDQ6VXNlcjM2Njc5NDk5","avatar_url":"https://avatars0.githubusercontent.com/u/36679499?v=4","gravatar_id":"","url":"https://api.github.com/users/allieychen","html_url":"https://github.com/allieychen","followers_url":"https://api.github.com/users/allieychen/followers","following_url":"https://api.github.com/users/allieychen/following{/other_user}","gists_url":"https://api.github.com/users/allieychen/gists{/gist_id}","starred_url":"https://api.github.com/users/allieychen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allieychen/subscriptions","organizations_url":"https://api.github.com/users/allieychen/orgs","repos_url":"https://api.github.com/users/allieychen/repos","events_url":"https://api.github.com/users/allieychen/events{/privacy}","received_events_url":"https://api.github.com/users/allieychen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/allieychen/gcp-variant-transforms","description":"GCP Variant Transforms","fork":true,"url":"https://api.github.com/repos/allieychen/gcp-variant-transforms","forks_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/forks","keys_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/teams","hooks_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/hooks","issue_events_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/issues/events{/number}","events_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/events","assignees_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/assignees{/user}","branches_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/branches{/branch}","tags_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/tags","blobs_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/statuses/{sha}","languages_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/languages","stargazers_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/stargazers","contributors_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/contributors","subscribers_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/subscribers","subscription_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/subscription","commits_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/contents/{+path}","compare_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/merges","archive_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/downloads","issues_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/issues{/number}","pulls_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/pulls{/number}","milestones_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/milestones{/number}","notifications_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/labels{/name}","releases_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/releases{/id}","deployments_url":"https://api.github.com/repos/allieychen/gcp-variant-transforms/deployments","created_at":"2018-02-22T16:28:54Z","updated_at":"2019-05-10T14:15:23Z","pushed_at":"2019-05-29T15:31:44Z","git_url":"git://github.com/allieychen/gcp-variant-transforms.git","ssh_url":"[email protected]:allieychen/gcp-variant-transforms.git","clone_url":"https://github.com/allieychen/gcp-variant-transforms.git","svn_url":"https://github.com/allieychen/gcp-variant-transforms","homepage":null,"size":2008,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlegenomics:master","ref":"master","sha":"cfe6fe49e9e21591b3baee0e57ed4a0e76710a39","user":{"login":"googlegenomics","id":7434120,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzQxMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/7434120?v=4","gravatar_id":"","url":"https://api.github.com/users/googlegenomics","html_url":"https://github.com/googlegenomics","followers_url":"https://api.github.com/users/googlegenomics/followers","following_url":"https://api.github.com/users/googlegenomics/following{/other_user}","gists_url":"https://api.github.com/users/googlegenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/googlegenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlegenomics/subscriptions","organizations_url":"https://api.github.com/users/googlegenomics/orgs","repos_url":"https://api.github.com/users/googlegenomics/repos","events_url":"https://api.github.com/users/googlegenomics/events{/privacy}","received_events_url":"https://api.github.com/users/googlegenomics/received_events","type":"Organization","site_admin":false},"repo":{"id":110025283,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAwMjUyODM=","name":"gcp-variant-transforms","full_name":"googlegenomics/gcp-variant-transforms","private":false,"owner":{"login":"googlegenomics","id":7434120,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MzQxMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/7434120?v=4","gravatar_id":"","url":"https://api.github.com/users/googlegenomics","html_url":"https://github.com/googlegenomics","followers_url":"https://api.github.com/users/googlegenomics/followers","following_url":"https://api.github.com/users/googlegenomics/following{/other_user}","gists_url":"https://api.github.com/users/googlegenomics/gists{/gist_id}","starred_url":"https://api.github.com/users/googlegenomics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlegenomics/subscriptions","organizations_url":"https://api.github.com/users/googlegenomics/orgs","repos_url":"https://api.github.com/users/googlegenomics/repos","events_url":"https://api.github.com/users/googlegenomics/events{/privacy}","received_events_url":"https://api.github.com/users/googlegenomics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/googlegenomics/gcp-variant-transforms","description":"GCP Variant Transforms","fork":false,"url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms","forks_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/forks","keys_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/teams","hooks_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/hooks","issue_events_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/events{/number}","events_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/events","assignees_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/assignees{/user}","branches_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/branches{/branch}","tags_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/tags","blobs_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/statuses/{sha}","languages_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/languages","stargazers_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/stargazers","contributors_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/contributors","subscribers_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/subscribers","subscription_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/subscription","commits_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/contents/{+path}","compare_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/merges","archive_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/downloads","issues_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues{/number}","pulls_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls{/number}","milestones_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/milestones{/number}","notifications_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/labels{/name}","releases_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/releases{/id}","deployments_url":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/deployments","created_at":"2017-11-08T20:12:08Z","updated_at":"2019-05-21T08:46:39Z","pushed_at":"2019-05-29T15:31:46Z","git_url":"git://github.com/googlegenomics/gcp-variant-transforms.git","ssh_url":"[email protected]:googlegenomics/gcp-variant-transforms.git","clone_url":"https://github.com/googlegenomics/gcp-variant-transforms.git","svn_url":"https://github.com/googlegenomics/gcp-variant-transforms","homepage":null,"size":1990,"stargazers_count":56,"watchers_count":56,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":76,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":28,"open_issues":76,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/484"},"html":{"href":"https://github.com/googlegenomics/gcp-variant-transforms/pull/484"},"issue":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/484"},"comments":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/issues/484/comments"},"review_comments":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/484/comments"},"review_comment":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/pulls/484/commits"},"statuses":{"href":"https://api.github.com/repos/googlegenomics/gcp-variant-transforms/statuses/91fa2495f224dc7a37d9cd3985014195b4803a2f"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 110025283,
"name": "googlegenomics/gcp-variant-transforms",
"url": "https://api.github.com/repos/googlegenomics/gcp-variant-transforms"
}
|
{
"id": 28713279,
"login": "kemp-google",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/28713279?",
"url": "https://api.github.com/users/kemp-google"
}
|
{
"id": 7434120,
"login": "googlegenomics",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7434120?",
"url": "https://api.github.com/orgs/googlegenomics"
}
| 2019-05-29T18:04:41 |
9721515512
|
{"actor":{"display_login":"kemp-google"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/pulls/comments/336371886","pull_request_review_id":303732611,"id":336371886,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNjM3MTg4Ng==","diff_hunk":"@@ -0,0 +1,313 @@\n+package WebService::Async::CustomerIO;\n+\n+use strict;\n+use warnings;\n+\n+our $VERSION = '0.001';\n+\n+=head1 NAME\n+\n+WebService::Async::CustomerIO - unofficial support for the Customer.io service\n+\n+=head1 SYNOPSIS\n+\n+=head1 DESCRIPTION\n+\n+=cut\n+\n+use parent qw(IO::Async::Notifier);\n+\n+use mro;\n+use Syntax::Keyword::Try;\n+use Future;\n+use Net::Async::HTTP;\n+use Carp qw();\n+use JSON::MaybeUTF8 qw(:v1);\n+\n+use WebService::Async::CustomerIO::Customer;\n+use WebService::Async::CustomerIO::RateLimiter;\n+use WebService::Async::CustomerIO::Trigger;\n+\n+use constant {\n+ TRACKING_END_POINT => 'https://track.customer.io/api/v1',\n+ API_END_POINT => 'https://api.customer.io/v1/api',\n+ RPS_LIMIT_TRACKING => 30,\n+ RPS_LIMIT_API => 10,\n+};\n+\n+=head2 new\n+\n+Creates a new api client object\n+\n+Usage: C<< new(%params) -> obj >>\n+\n+Parameters:\n+\n+=over 4\n+\n+=item * C<site_id>\n+\n+=item * C<api_key>\n+\n+=back\n+\n+=cut\n+\n+sub configure {\n+ my ($self, %args) = @_;\n+ for my $k (qw(site_id api_key)) {\n+ Carp::croak \"Missing requeread argument: $k\" unless exists $args{$k};\n+ $self->{$k} = delete $args{$k} if exists $args{$k};\n+ }\n+\n+ $self->{tracking_ratelimiter} ||= do {\n+ my $rl =WebService::Async::CustomerIO::RateLimiter->new(\n+ limit => RPS_LIMIT_TRACKING,\n+ interval => 1,\n+ );\n+ $self->add_child($rl);\n+\n+ $rl;\n+ };\n+ $self->{api_ratelimiter} ||= do {\n+ my $rl = WebService::Async::CustomerIO::RateLimiter->new(\n+ limit => RPS_LIMIT_API,\n+ interval => 1,\n+ );\n+ $self->add_child($rl);\n+\n+ $rl;\n+ };\n+\n+ $self->next::method(%args);\n+}\n+\n+=head2 site_id\n+\n+=cut\n+\n+sub site_id {shift->{site_id}}\n+\n+=head2 api_key\n+\n+=cut\n+\n+sub api_key {shift->{api_key}}\n+\n+=head2 API endpoints:\n+\n+There is 2 stable API for Customer.io, if you need to add a new method check \n+the L<documentation for API|https://customer.io/docs/api/> which endpoint \n+you need to use:\n+\n+=over 4\n+\n+=item * C<Tracking API> - Behavioral Tracking API is used to identify and track\n+customer data with Customer.io.\n+\n+=item * C<Regular API> - Currently, this endpoint is only used for sending\n+L<API triggered broadcasts|https://customer.io/docs/api-triggered-broadcast-setup>.\n+\n+=back\n+\n+=head2 tracking_request\n+\n+Sending request to Tracking API end point.\n+\n+Usage: C<< tracking_request($method, $uri, $data) -> future($data) >>\n+\n+=cut\n+\n+sub tracking_request {\n+ my ($self, $method, $uri, $data) = @_;\n+ return $self->tracking_ratelimiter->acquire->then(sub {\n+ $self->_request($method, join(q{/} => (TRACKING_END_POINT, $uri)), $data);\n+ });\n+}\n+\n+=head2 api_request\n+\n+Sending request to Regular API end point.\n+\n+Usage: C<< api_request($method, $uri, $data) -> future($data) >>\n+\n+=cut\n+\n+sub api_request {\n+ my ($self, $method, $uri, $data) = @_;\n+\n+ return $self->api_ratelimiter->acquire->then(sub {\n+ $self->_request($method, join(q{/} => (API_END_POINT, $uri)), $data);\n+ });\n+}\n+\n+=head2 api_ratelimiter\n+\n+Getter returns RateLimmiter for regular API endpoint.\n+\n+=cut\n+\n+sub api_ratelimiter {shift->{api_ratelimiter}}\n+\n+=head2 tracking_ratelimiter\n+\n+Getter returns RateLimmiter for tracking API endpoint.\n+\n+=cut\n+\n+sub tracking_ratelimiter {shift->{tracking_ratelimiter}}\n+\n+sub _request {\n+ my ($self, $method, $uri, $data) = @_;\n+\n+ my $body = $data ? encode_json_utf8($data)\n+ : $method eq 'POST' ? q{}\n+ : undef;\n+\n+ return $self->_ua->do_request(\n+ method => $method,\n+ uri => $uri,\n+ user => $self->site_id,\n+ pass => $self->api_key,\n+ !defined $body ? () : (\n+ content => $body,\n+ content_type => 'application/json',\n+ ),\n+ )->catch(sub {\n+ my ($code_msg, $err_type, $response) = @_;\n+ return Future->fail(@_) unless $err_type && $err_type eq 'http';\n+\n+ my $code = $response->code;\n+ my $request_data = {method => $method, uri => $uri, data => $data};\n+\n+ return Future->fail('RESOURCE_NOT_FOUND', 'customerio', $request_data) if $code == 404;","path":"lib/WebService/Async/CustomerIO.pm","position":183,"original_position":183,"commit_id":"31cb07a740a3a26a92d660ce23eecb5bfca025b1","original_commit_id":"31cb07a740a3a26a92d660ce23eecb5bfca025b1","user":{"login":"raunakkathuria","id":2534747,"node_id":"MDQ6VXNlcjI1MzQ3NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/2534747?v=4","gravatar_id":"","url":"https://api.github.com/users/raunakkathuria","html_url":"https://github.com/raunakkathuria","followers_url":"https://api.github.com/users/raunakkathuria/followers","following_url":"https://api.github.com/users/raunakkathuria/following{/other_user}","gists_url":"https://api.github.com/users/raunakkathuria/gists{/gist_id}","starred_url":"https://api.github.com/users/raunakkathuria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raunakkathuria/subscriptions","organizations_url":"https://api.github.com/users/raunakkathuria/orgs","repos_url":"https://api.github.com/users/raunakkathuria/repos","events_url":"https://api.github.com/users/raunakkathuria/events{/privacy}","received_events_url":"https://api.github.com/users/raunakkathuria/received_events","type":"User","site_admin":false},"body":"Would it make sense to create mapping of `error_code => error` like\r\n```\r\nmy $error_mapping = { 404 => 'RESOURCE_NOT_FOUND', 400 => 'INVALID_REQUEST', ...};\r\n\r\n$error_mapping->{$code} ? return Future->fail($error_mapping->{$code}, 'customerio', $request_data) : return Future->fail('UNEXPECTED_HTTP_CODE: ' . $code_msg, 'customerio', $response)\r\n```","created_at":"2019-10-18T08:22:48Z","updated_at":"2019-10-18T08:23:04Z","html_url":"https://github.com/binary-com/perl-WebService-Async-CustomerIO/pull/1#discussion_r336371886","pull_request_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/pulls/comments/336371886"},"html":{"href":"https://github.com/binary-com/perl-WebService-Async-CustomerIO/pull/1#discussion_r336371886"},"pull_request":{"href":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/pulls/1","id":328676627,"node_id":"MDExOlB1bGxSZXF1ZXN0MzI4Njc2NjI3","html_url":"https://github.com/binary-com/perl-WebService-Async-CustomerIO/pull/1","diff_url":"https://github.com/binary-com/perl-WebService-Async-CustomerIO/pull/1.diff","patch_url":"https://github.com/binary-com/perl-WebService-Async-CustomerIO/pull/1.patch","issue_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/issues/1","number":1,"state":"open","locked":false,"title":"kirill/customer_io_api_wrapper","user":{"login":"kirill-binary","id":55120154,"node_id":"MDQ6VXNlcjU1MTIwMTU0","avatar_url":"https://avatars1.githubusercontent.com/u/55120154?v=4","gravatar_id":"","url":"https://api.github.com/users/kirill-binary","html_url":"https://github.com/kirill-binary","followers_url":"https://api.github.com/users/kirill-binary/followers","following_url":"https://api.github.com/users/kirill-binary/following{/other_user}","gists_url":"https://api.github.com/users/kirill-binary/gists{/gist_id}","starred_url":"https://api.github.com/users/kirill-binary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirill-binary/subscriptions","organizations_url":"https://api.github.com/users/kirill-binary/orgs","repos_url":"https://api.github.com/users/kirill-binary/repos","events_url":"https://api.github.com/users/kirill-binary/events{/privacy}","received_events_url":"https://api.github.com/users/kirill-binary/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-16T10:06:48Z","updated_at":"2019-10-18T08:23:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d839c50798b7c9a5c8346dbad8f0a64c8bc0886","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/pulls/1/commits","review_comments_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/pulls/1/comments","review_comment_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/pulls/comments{/number}","comments_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/issues/1/comments","statuses_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/statuses/31cb07a740a3a26a92d660ce23eecb5bfca025b1","head":{"label":"kirill-binary:kirill/customer_io_api_wrapper","ref":"kirill/customer_io_api_wrapper","sha":"31cb07a740a3a26a92d660ce23eecb5bfca025b1","user":{"login":"kirill-binary","id":55120154,"node_id":"MDQ6VXNlcjU1MTIwMTU0","avatar_url":"https://avatars1.githubusercontent.com/u/55120154?v=4","gravatar_id":"","url":"https://api.github.com/users/kirill-binary","html_url":"https://github.com/kirill-binary","followers_url":"https://api.github.com/users/kirill-binary/followers","following_url":"https://api.github.com/users/kirill-binary/following{/other_user}","gists_url":"https://api.github.com/users/kirill-binary/gists{/gist_id}","starred_url":"https://api.github.com/users/kirill-binary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirill-binary/subscriptions","organizations_url":"https://api.github.com/users/kirill-binary/orgs","repos_url":"https://api.github.com/users/kirill-binary/repos","events_url":"https://api.github.com/users/kirill-binary/events{/privacy}","received_events_url":"https://api.github.com/users/kirill-binary/received_events","type":"User","site_admin":false},"repo":{"id":215511189,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU1MTExODk=","name":"perl-WebService-Async-CustomerIO","full_name":"kirill-binary/perl-WebService-Async-CustomerIO","private":false,"owner":{"login":"kirill-binary","id":55120154,"node_id":"MDQ6VXNlcjU1MTIwMTU0","avatar_url":"https://avatars1.githubusercontent.com/u/55120154?v=4","gravatar_id":"","url":"https://api.github.com/users/kirill-binary","html_url":"https://github.com/kirill-binary","followers_url":"https://api.github.com/users/kirill-binary/followers","following_url":"https://api.github.com/users/kirill-binary/following{/other_user}","gists_url":"https://api.github.com/users/kirill-binary/gists{/gist_id}","starred_url":"https://api.github.com/users/kirill-binary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirill-binary/subscriptions","organizations_url":"https://api.github.com/users/kirill-binary/orgs","repos_url":"https://api.github.com/users/kirill-binary/repos","events_url":"https://api.github.com/users/kirill-binary/events{/privacy}","received_events_url":"https://api.github.com/users/kirill-binary/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kirill-binary/perl-WebService-Async-CustomerIO","description":"Unofficial support for the customer.io API","fork":true,"url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO","forks_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/forks","keys_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/teams","hooks_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/hooks","issue_events_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/issues/events{/number}","events_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/events","assignees_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/assignees{/user}","branches_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/branches{/branch}","tags_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/tags","blobs_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/git/refs{/sha}","trees_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/statuses/{sha}","languages_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/languages","stargazers_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/stargazers","contributors_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/contributors","subscribers_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/subscribers","subscription_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/subscription","commits_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/commits{/sha}","git_commits_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/git/commits{/sha}","comments_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/comments{/number}","issue_comment_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/issues/comments{/number}","contents_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/contents/{+path}","compare_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/merges","archive_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/downloads","issues_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/issues{/number}","pulls_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/pulls{/number}","milestones_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/milestones{/number}","notifications_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/labels{/name}","releases_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/releases{/id}","deployments_url":"https://api.github.com/repos/kirill-binary/perl-WebService-Async-CustomerIO/deployments","created_at":"2019-10-16T09:38:36Z","updated_at":"2019-10-16T09:38:38Z","pushed_at":"2019-10-18T06:14:40Z","git_url":"git://github.com/kirill-binary/perl-WebService-Async-CustomerIO.git","ssh_url":"[email protected]:kirill-binary/perl-WebService-Async-CustomerIO.git","clone_url":"https://github.com/kirill-binary/perl-WebService-Async-CustomerIO.git","svn_url":"https://github.com/kirill-binary/perl-WebService-Async-CustomerIO","homepage":null,"size":50,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"binary-com:master","ref":"master","sha":"a2aa00a6423a8c3049d16aba339a5d5f13022970","user":{"login":"binary-com","id":7437559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mzc1NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7437559?v=4","gravatar_id":"","url":"https://api.github.com/users/binary-com","html_url":"https://github.com/binary-com","followers_url":"https://api.github.com/users/binary-com/followers","following_url":"https://api.github.com/users/binary-com/following{/other_user}","gists_url":"https://api.github.com/users/binary-com/gists{/gist_id}","starred_url":"https://api.github.com/users/binary-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary-com/subscriptions","organizations_url":"https://api.github.com/users/binary-com/orgs","repos_url":"https://api.github.com/users/binary-com/repos","events_url":"https://api.github.com/users/binary-com/events{/privacy}","received_events_url":"https://api.github.com/users/binary-com/received_events","type":"Organization","site_admin":false},"repo":{"id":215436042,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU0MzYwNDI=","name":"perl-WebService-Async-CustomerIO","full_name":"binary-com/perl-WebService-Async-CustomerIO","private":false,"owner":{"login":"binary-com","id":7437559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0Mzc1NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/7437559?v=4","gravatar_id":"","url":"https://api.github.com/users/binary-com","html_url":"https://github.com/binary-com","followers_url":"https://api.github.com/users/binary-com/followers","following_url":"https://api.github.com/users/binary-com/following{/other_user}","gists_url":"https://api.github.com/users/binary-com/gists{/gist_id}","starred_url":"https://api.github.com/users/binary-com/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/binary-com/subscriptions","organizations_url":"https://api.github.com/users/binary-com/orgs","repos_url":"https://api.github.com/users/binary-com/repos","events_url":"https://api.github.com/users/binary-com/events{/privacy}","received_events_url":"https://api.github.com/users/binary-com/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/binary-com/perl-WebService-Async-CustomerIO","description":"Unofficial support for the customer.io API","fork":false,"url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO","forks_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/forks","keys_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/keys{/key_id}","collaborators_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/teams","hooks_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/hooks","issue_events_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/issues/events{/number}","events_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/events","assignees_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/assignees{/user}","branches_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/branches{/branch}","tags_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/tags","blobs_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/git/refs{/sha}","trees_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/git/trees{/sha}","statuses_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/statuses/{sha}","languages_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/languages","stargazers_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/stargazers","contributors_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/contributors","subscribers_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/subscribers","subscription_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/subscription","commits_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/commits{/sha}","git_commits_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/git/commits{/sha}","comments_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/comments{/number}","issue_comment_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/issues/comments{/number}","contents_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/contents/{+path}","compare_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/compare/{base}...{head}","merges_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/merges","archive_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/downloads","issues_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/issues{/number}","pulls_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/pulls{/number}","milestones_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/milestones{/number}","notifications_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/labels{/name}","releases_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/releases{/id}","deployments_url":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/deployments","created_at":"2019-10-16T02:10:24Z","updated_at":"2019-10-16T02:10:27Z","pushed_at":"2019-10-18T06:14:41Z","git_url":"git://github.com/binary-com/perl-WebService-Async-CustomerIO.git","ssh_url":"[email protected]:binary-com/perl-WebService-Async-CustomerIO.git","clone_url":"https://github.com/binary-com/perl-WebService-Async-CustomerIO.git","svn_url":"https://github.com/binary-com/perl-WebService-Async-CustomerIO","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/pulls/1"},"html":{"href":"https://github.com/binary-com/perl-WebService-Async-CustomerIO/pull/1"},"issue":{"href":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/issues/1"},"comments":{"href":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO/statuses/31cb07a740a3a26a92d660ce23eecb5bfca025b1"}},"author_association":"NONE"}}
|
{
"id": 215436042,
"name": "binary-com/perl-WebService-Async-CustomerIO",
"url": "https://api.github.com/repos/binary-com/perl-WebService-Async-CustomerIO"
}
|
{
"id": 2534747,
"login": "raunakkathuria",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2534747?",
"url": "https://api.github.com/users/raunakkathuria"
}
|
{
"id": 7437559,
"login": "binary-com",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7437559?",
"url": "https://api.github.com/orgs/binary-com"
}
| 2019-10-18T08:22:48 |
10659724178
|
{"actor":{"display_login":"raunakkathuria"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/foam-framework/foam2/pulls/comments/364260062","pull_request_review_id":339902122,"id":364260062,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NDI2MDA2Mg==","diff_hunk":"@@ -197,9 +201,6 @@ foam.RELATIONSHIP({\n cardinality: '*:*',\n forwardName: 'capabilities',\n inverseName: 'users',\n- sourceProperty: {\n- section: 'administrative'","path":"src/foam/nanos/crunch/Capability.js","position":16,"original_position":16,"commit_id":"201ed6ce739db45cd80cc2677a6a47cbb62b09be","original_commit_id":"201ed6ce739db45cd80cc2677a6a47cbb62b09be","user":{"login":"TW80000","id":4259165,"node_id":"MDQ6VXNlcjQyNTkxNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/4259165?v=4","gravatar_id":"","url":"https://api.github.com/users/TW80000","html_url":"https://github.com/TW80000","followers_url":"https://api.github.com/users/TW80000/followers","following_url":"https://api.github.com/users/TW80000/following{/other_user}","gists_url":"https://api.github.com/users/TW80000/gists{/gist_id}","starred_url":"https://api.github.com/users/TW80000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TW80000/subscriptions","organizations_url":"https://api.github.com/users/TW80000/orgs","repos_url":"https://api.github.com/users/TW80000/repos","events_url":"https://api.github.com/users/TW80000/events{/privacy}","received_events_url":"https://api.github.com/users/TW80000/received_events","type":"User","site_admin":false},"body":"This was a section on `User`, not `Capability`. Please revert.","created_at":"2020-01-08T14:33:33Z","updated_at":"2020-01-08T14:33:34Z","html_url":"https://github.com/foam-framework/foam2/pull/2942#discussion_r364260062","pull_request_url":"https://api.github.com/repos/foam-framework/foam2/pulls/2942","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/comments/364260062"},"html":{"href":"https://github.com/foam-framework/foam2/pull/2942#discussion_r364260062"},"pull_request":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/2942"}}},"pull_request":{"url":"https://api.github.com/repos/foam-framework/foam2/pulls/2942","id":360275786,"node_id":"MDExOlB1bGxSZXF1ZXN0MzYwMjc1Nzg2","html_url":"https://github.com/foam-framework/foam2/pull/2942","diff_url":"https://github.com/foam-framework/foam2/pull/2942.diff","patch_url":"https://github.com/foam-framework/foam2/pull/2942.patch","issue_url":"https://api.github.com/repos/foam-framework/foam2/issues/2942","number":2942,"state":"closed","locked":false,"title":"Capability Sectioning Touches","user":{"login":"tharmaman","id":26717171,"node_id":"MDQ6VXNlcjI2NzE3MTcx","avatar_url":"https://avatars3.githubusercontent.com/u/26717171?v=4","gravatar_id":"","url":"https://api.github.com/users/tharmaman","html_url":"https://github.com/tharmaman","followers_url":"https://api.github.com/users/tharmaman/followers","following_url":"https://api.github.com/users/tharmaman/following{/other_user}","gists_url":"https://api.github.com/users/tharmaman/gists{/gist_id}","starred_url":"https://api.github.com/users/tharmaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tharmaman/subscriptions","organizations_url":"https://api.github.com/users/tharmaman/orgs","repos_url":"https://api.github.com/users/tharmaman/repos","events_url":"https://api.github.com/users/tharmaman/events{/privacy}","received_events_url":"https://api.github.com/users/tharmaman/received_events","type":"User","site_admin":false},"body":"Removed administrative section because it does not exist and added a capabilityRelationships section @kgrgreer @noodlemoodle @TW80000 @jlhughes ","created_at":"2020-01-08T04:25:15Z","updated_at":"2020-01-08T14:33:34Z","closed_at":"2020-01-08T14:15:55Z","merged_at":"2020-01-08T14:15:55Z","merge_commit_sha":"207b65ccbdfb6077e62a5002d1ebcc8b701ee601","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1019586488,"node_id":"MDU6TGFiZWwxMDE5NTg2NDg4","url":"https://api.github.com/repos/foam-framework/foam2/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false,"description":null}],"milestone":null,"commits_url":"https://api.github.com/repos/foam-framework/foam2/pulls/2942/commits","review_comments_url":"https://api.github.com/repos/foam-framework/foam2/pulls/2942/comments","review_comment_url":"https://api.github.com/repos/foam-framework/foam2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/foam-framework/foam2/issues/2942/comments","statuses_url":"https://api.github.com/repos/foam-framework/foam2/statuses/201ed6ce739db45cd80cc2677a6a47cbb62b09be","head":{"label":"tharmaman:capabilitySectioning","ref":"capabilitySectioning","sha":"201ed6ce739db45cd80cc2677a6a47cbb62b09be","user":{"login":"tharmaman","id":26717171,"node_id":"MDQ6VXNlcjI2NzE3MTcx","avatar_url":"https://avatars3.githubusercontent.com/u/26717171?v=4","gravatar_id":"","url":"https://api.github.com/users/tharmaman","html_url":"https://github.com/tharmaman","followers_url":"https://api.github.com/users/tharmaman/followers","following_url":"https://api.github.com/users/tharmaman/following{/other_user}","gists_url":"https://api.github.com/users/tharmaman/gists{/gist_id}","starred_url":"https://api.github.com/users/tharmaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tharmaman/subscriptions","organizations_url":"https://api.github.com/users/tharmaman/orgs","repos_url":"https://api.github.com/users/tharmaman/repos","events_url":"https://api.github.com/users/tharmaman/events{/privacy}","received_events_url":"https://api.github.com/users/tharmaman/received_events","type":"User","site_admin":false},"repo":{"id":177822146,"node_id":"MDEwOlJlcG9zaXRvcnkxNzc4MjIxNDY=","name":"foam2","full_name":"tharmaman/foam2","private":false,"owner":{"login":"tharmaman","id":26717171,"node_id":"MDQ6VXNlcjI2NzE3MTcx","avatar_url":"https://avatars3.githubusercontent.com/u/26717171?v=4","gravatar_id":"","url":"https://api.github.com/users/tharmaman","html_url":"https://github.com/tharmaman","followers_url":"https://api.github.com/users/tharmaman/followers","following_url":"https://api.github.com/users/tharmaman/following{/other_user}","gists_url":"https://api.github.com/users/tharmaman/gists{/gist_id}","starred_url":"https://api.github.com/users/tharmaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tharmaman/subscriptions","organizations_url":"https://api.github.com/users/tharmaman/orgs","repos_url":"https://api.github.com/users/tharmaman/repos","events_url":"https://api.github.com/users/tharmaman/events{/privacy}","received_events_url":"https://api.github.com/users/tharmaman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tharmaman/foam2","description":"FOAM: Feature-Oriented Active Modeller, Version 2","fork":true,"url":"https://api.github.com/repos/tharmaman/foam2","forks_url":"https://api.github.com/repos/tharmaman/foam2/forks","keys_url":"https://api.github.com/repos/tharmaman/foam2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tharmaman/foam2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tharmaman/foam2/teams","hooks_url":"https://api.github.com/repos/tharmaman/foam2/hooks","issue_events_url":"https://api.github.com/repos/tharmaman/foam2/issues/events{/number}","events_url":"https://api.github.com/repos/tharmaman/foam2/events","assignees_url":"https://api.github.com/repos/tharmaman/foam2/assignees{/user}","branches_url":"https://api.github.com/repos/tharmaman/foam2/branches{/branch}","tags_url":"https://api.github.com/repos/tharmaman/foam2/tags","blobs_url":"https://api.github.com/repos/tharmaman/foam2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tharmaman/foam2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tharmaman/foam2/git/refs{/sha}","trees_url":"https://api.github.com/repos/tharmaman/foam2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tharmaman/foam2/statuses/{sha}","languages_url":"https://api.github.com/repos/tharmaman/foam2/languages","stargazers_url":"https://api.github.com/repos/tharmaman/foam2/stargazers","contributors_url":"https://api.github.com/repos/tharmaman/foam2/contributors","subscribers_url":"https://api.github.com/repos/tharmaman/foam2/subscribers","subscription_url":"https://api.github.com/repos/tharmaman/foam2/subscription","commits_url":"https://api.github.com/repos/tharmaman/foam2/commits{/sha}","git_commits_url":"https://api.github.com/repos/tharmaman/foam2/git/commits{/sha}","comments_url":"https://api.github.com/repos/tharmaman/foam2/comments{/number}","issue_comment_url":"https://api.github.com/repos/tharmaman/foam2/issues/comments{/number}","contents_url":"https://api.github.com/repos/tharmaman/foam2/contents/{+path}","compare_url":"https://api.github.com/repos/tharmaman/foam2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tharmaman/foam2/merges","archive_url":"https://api.github.com/repos/tharmaman/foam2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tharmaman/foam2/downloads","issues_url":"https://api.github.com/repos/tharmaman/foam2/issues{/number}","pulls_url":"https://api.github.com/repos/tharmaman/foam2/pulls{/number}","milestones_url":"https://api.github.com/repos/tharmaman/foam2/milestones{/number}","notifications_url":"https://api.github.com/repos/tharmaman/foam2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tharmaman/foam2/labels{/name}","releases_url":"https://api.github.com/repos/tharmaman/foam2/releases{/id}","deployments_url":"https://api.github.com/repos/tharmaman/foam2/deployments","created_at":"2019-03-26T15:56:20Z","updated_at":"2020-01-05T23:33:13Z","pushed_at":"2020-01-08T05:19:13Z","git_url":"git://github.com/tharmaman/foam2.git","ssh_url":"[email protected]:tharmaman/foam2.git","clone_url":"https://github.com/tharmaman/foam2.git","svn_url":"https://github.com/tharmaman/foam2","homepage":"","size":35599,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"foam-framework:master","ref":"master","sha":"debf8af360968d381d5b76dc98f5431ec89803f5","user":{"login":"foam-framework","id":7460756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NjA3NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7460756?v=4","gravatar_id":"","url":"https://api.github.com/users/foam-framework","html_url":"https://github.com/foam-framework","followers_url":"https://api.github.com/users/foam-framework/followers","following_url":"https://api.github.com/users/foam-framework/following{/other_user}","gists_url":"https://api.github.com/users/foam-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/foam-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foam-framework/subscriptions","organizations_url":"https://api.github.com/users/foam-framework/orgs","repos_url":"https://api.github.com/users/foam-framework/repos","events_url":"https://api.github.com/users/foam-framework/events{/privacy}","received_events_url":"https://api.github.com/users/foam-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":50441060,"node_id":"MDEwOlJlcG9zaXRvcnk1MDQ0MTA2MA==","name":"foam2","full_name":"foam-framework/foam2","private":false,"owner":{"login":"foam-framework","id":7460756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NjA3NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/7460756?v=4","gravatar_id":"","url":"https://api.github.com/users/foam-framework","html_url":"https://github.com/foam-framework","followers_url":"https://api.github.com/users/foam-framework/followers","following_url":"https://api.github.com/users/foam-framework/following{/other_user}","gists_url":"https://api.github.com/users/foam-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/foam-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foam-framework/subscriptions","organizations_url":"https://api.github.com/users/foam-framework/orgs","repos_url":"https://api.github.com/users/foam-framework/repos","events_url":"https://api.github.com/users/foam-framework/events{/privacy}","received_events_url":"https://api.github.com/users/foam-framework/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/foam-framework/foam2","description":"FOAM: Feature-Oriented Active Modeller, Version 2","fork":false,"url":"https://api.github.com/repos/foam-framework/foam2","forks_url":"https://api.github.com/repos/foam-framework/foam2/forks","keys_url":"https://api.github.com/repos/foam-framework/foam2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/foam-framework/foam2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/foam-framework/foam2/teams","hooks_url":"https://api.github.com/repos/foam-framework/foam2/hooks","issue_events_url":"https://api.github.com/repos/foam-framework/foam2/issues/events{/number}","events_url":"https://api.github.com/repos/foam-framework/foam2/events","assignees_url":"https://api.github.com/repos/foam-framework/foam2/assignees{/user}","branches_url":"https://api.github.com/repos/foam-framework/foam2/branches{/branch}","tags_url":"https://api.github.com/repos/foam-framework/foam2/tags","blobs_url":"https://api.github.com/repos/foam-framework/foam2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/foam-framework/foam2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/foam-framework/foam2/git/refs{/sha}","trees_url":"https://api.github.com/repos/foam-framework/foam2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/foam-framework/foam2/statuses/{sha}","languages_url":"https://api.github.com/repos/foam-framework/foam2/languages","stargazers_url":"https://api.github.com/repos/foam-framework/foam2/stargazers","contributors_url":"https://api.github.com/repos/foam-framework/foam2/contributors","subscribers_url":"https://api.github.com/repos/foam-framework/foam2/subscribers","subscription_url":"https://api.github.com/repos/foam-framework/foam2/subscription","commits_url":"https://api.github.com/repos/foam-framework/foam2/commits{/sha}","git_commits_url":"https://api.github.com/repos/foam-framework/foam2/git/commits{/sha}","comments_url":"https://api.github.com/repos/foam-framework/foam2/comments{/number}","issue_comment_url":"https://api.github.com/repos/foam-framework/foam2/issues/comments{/number}","contents_url":"https://api.github.com/repos/foam-framework/foam2/contents/{+path}","compare_url":"https://api.github.com/repos/foam-framework/foam2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/foam-framework/foam2/merges","archive_url":"https://api.github.com/repos/foam-framework/foam2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/foam-framework/foam2/downloads","issues_url":"https://api.github.com/repos/foam-framework/foam2/issues{/number}","pulls_url":"https://api.github.com/repos/foam-framework/foam2/pulls{/number}","milestones_url":"https://api.github.com/repos/foam-framework/foam2/milestones{/number}","notifications_url":"https://api.github.com/repos/foam-framework/foam2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/foam-framework/foam2/labels{/name}","releases_url":"https://api.github.com/repos/foam-framework/foam2/releases{/id}","deployments_url":"https://api.github.com/repos/foam-framework/foam2/deployments","created_at":"2016-01-26T16:13:38Z","updated_at":"2020-01-08T14:15:59Z","pushed_at":"2020-01-08T14:15:56Z","git_url":"git://github.com/foam-framework/foam2.git","ssh_url":"[email protected]:foam-framework/foam2.git","clone_url":"https://github.com/foam-framework/foam2.git","svn_url":"https://github.com/foam-framework/foam2","homepage":"","size":35664,"stargazers_count":48,"watchers_count":48,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":67,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":237,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":67,"open_issues":237,"watchers":48,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/2942"},"html":{"href":"https://github.com/foam-framework/foam2/pull/2942"},"issue":{"href":"https://api.github.com/repos/foam-framework/foam2/issues/2942"},"comments":{"href":"https://api.github.com/repos/foam-framework/foam2/issues/2942/comments"},"review_comments":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/2942/comments"},"review_comment":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/foam-framework/foam2/pulls/2942/commits"},"statuses":{"href":"https://api.github.com/repos/foam-framework/foam2/statuses/201ed6ce739db45cd80cc2677a6a47cbb62b09be"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 50441060,
"name": "foam-framework/foam2",
"url": "https://api.github.com/repos/foam-framework/foam2"
}
|
{
"id": 4259165,
"login": "TW80000",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4259165?",
"url": "https://api.github.com/users/TW80000"
}
|
{
"id": 7460756,
"login": "foam-framework",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7460756?",
"url": "https://api.github.com/orgs/foam-framework"
}
| 2020-01-08T14:33:33 |
11228892830
|
{"actor":{"display_login":"TW80000"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/odoo-dev/odoo/pulls/comments/310973950","pull_request_review_id":271231198,"id":310973950,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMDk3Mzk1MA==","diff_hunk":"@@ -807,12 +809,36 @@ const actions = {\n if (authorPartnerId === currentPartner.id) {\n return;\n }\n+\n const threadLocalId = `mail.channel_${channelId}`;\n const thread = state.threads[threadLocalId];\n+ if (!env.call('bus_service', 'isOdooFocused')){\n+ dispatch('_handleNotificationOutOfFocusMessage', message);\n+ }\n commit('updateThread', threadLocalId, {\n message_unread_counter: thread.message_unread_counter + 1,\n });\n },\n+ /**\n+ * @private\n+ * @param {Object} param0\n+ * @param {Object} param0.env\n+ * @param {Object} param0.state\n+ * @param {function} param0.commit\n+ * @param {Object} message\n+ */\n+ async _handleNotificationOutOfFocusMessage({env, state, commit}, message) {\n+ const {author_id, body} = message;\n+ const notification_title = author_id ? _.escape(author_id[1]) : _t('New message');\n+ const notification_content = mailUtils\n+ .parseAndTransform(body, mailUtils.addLink)\n+ .substr(0, state.PREVIEW_MSG_MAX_SIZE)\n+ ;\n+ env.call('bus_service', 'sendNotification', notification_title, notification_content);\n+ commit('updateOutOfFocusUnreadMessageCounter', {newValue: state.outOfFocusUnreadMessageCounter + 1});\n+ const title = _.str.sprintf(_t(\"%d Messages\"), state.outOfFocusUnreadMessageCounter);\n+ env.trigger_up('set_title_part', {part: '_chat', title})","path":"addons/mail/static/src/js/owl/store/messaging_actions.js","position":50,"original_position":50,"commit_id":"2a49627a58a8f6daaad01f581a7fb4d81799a6ff","original_commit_id":"2a49627a58a8f6daaad01f581a7fb4d81799a6ff","user":{"login":"xdu-odoo","id":48204996,"node_id":"MDQ6VXNlcjQ4MjA0OTk2","avatar_url":"https://avatars2.githubusercontent.com/u/48204996?v=4","gravatar_id":"","url":"https://api.github.com/users/xdu-odoo","html_url":"https://github.com/xdu-odoo","followers_url":"https://api.github.com/users/xdu-odoo/followers","following_url":"https://api.github.com/users/xdu-odoo/following{/other_user}","gists_url":"https://api.github.com/users/xdu-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/xdu-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xdu-odoo/subscriptions","organizations_url":"https://api.github.com/users/xdu-odoo/orgs","repos_url":"https://api.github.com/users/xdu-odoo/repos","events_url":"https://api.github.com/users/xdu-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/xdu-odoo/received_events","type":"User","site_admin":false},"body":"use multiline notation for {} when two or more keys","created_at":"2019-08-06T09:43:05Z","updated_at":"2019-08-06T09:43:05Z","html_url":"https://github.com/odoo-dev/odoo/pull/139#discussion_r310973950","pull_request_url":"https://api.github.com/repos/odoo-dev/odoo/pulls/139","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/odoo-dev/odoo/pulls/comments/310973950"},"html":{"href":"https://github.com/odoo-dev/odoo/pull/139#discussion_r310973950"},"pull_request":{"href":"https://api.github.com/repos/odoo-dev/odoo/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/odoo-dev/odoo/pulls/139","id":304613735,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA0NjEzNzM1","html_url":"https://github.com/odoo-dev/odoo/pull/139","diff_url":"https://github.com/odoo-dev/odoo/pull/139.diff","patch_url":"https://github.com/odoo-dev/odoo/pull/139.patch","issue_url":"https://api.github.com/repos/odoo-dev/odoo/issues/139","number":139,"state":"open","locked":false,"title":"Master mail xdu","user":{"login":"xdu-odoo","id":48204996,"node_id":"MDQ6VXNlcjQ4MjA0OTk2","avatar_url":"https://avatars2.githubusercontent.com/u/48204996?v=4","gravatar_id":"","url":"https://api.github.com/users/xdu-odoo","html_url":"https://github.com/xdu-odoo","followers_url":"https://api.github.com/users/xdu-odoo/followers","following_url":"https://api.github.com/users/xdu-odoo/following{/other_user}","gists_url":"https://api.github.com/users/xdu-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/xdu-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xdu-odoo/subscriptions","organizations_url":"https://api.github.com/users/xdu-odoo/orgs","repos_url":"https://api.github.com/users/xdu-odoo/repos","events_url":"https://api.github.com/users/xdu-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/xdu-odoo/received_events","type":"User","site_admin":false},"body":"Out of odoo focus unread message counter is now back to life with owl","created_at":"2019-08-06T08:54:49Z","updated_at":"2019-08-06T09:43:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e2f44876b7465cea274e9406329b3af5b955f77","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/odoo-dev/odoo/pulls/139/commits","review_comments_url":"https://api.github.com/repos/odoo-dev/odoo/pulls/139/comments","review_comment_url":"https://api.github.com/repos/odoo-dev/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/issues/139/comments","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/2a49627a58a8f6daaad01f581a7fb4d81799a6ff","head":{"label":"odoo-dev:master-mail-xdu","ref":"master-mail-xdu","sha":"2a49627a58a8f6daaad01f581a7fb4d81799a6ff","user":{"login":"odoo-dev","id":7466976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NjY5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7466976?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg1MzkzNA==","name":"odoo","full_name":"odoo-dev/odoo","private":false,"owner":{"login":"odoo-dev","id":7466976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NjY5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7466976?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo-dev/odoo/deployments","created_at":"2014-05-16T11:16:19Z","updated_at":"2019-06-30T06:46:36Z","pushed_at":"2019-08-06T09:42:20Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"[email protected]:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":2583034,"stargazers_count":86,"watchers_count":86,"language":null,"has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":43,"open_issues":6,"watchers":86,"default_branch":"master"}},"base":{"label":"odoo-dev:master-mail-aku","ref":"master-mail-aku","sha":"3e3f0a93cf1baa6e324b13ceb9a4d99ed4d3d105","user":{"login":"odoo-dev","id":7466976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NjY5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7466976?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg1MzkzNA==","name":"odoo","full_name":"odoo-dev/odoo","private":false,"owner":{"login":"odoo-dev","id":7466976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NjY5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7466976?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo-dev/odoo/deployments","created_at":"2014-05-16T11:16:19Z","updated_at":"2019-06-30T06:46:36Z","pushed_at":"2019-08-06T09:42:20Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"[email protected]:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":2583034,"stargazers_count":86,"watchers_count":86,"language":null,"has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":43,"open_issues":6,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo-dev/odoo/pulls/139"},"html":{"href":"https://github.com/odoo-dev/odoo/pull/139"},"issue":{"href":"https://api.github.com/repos/odoo-dev/odoo/issues/139"},"comments":{"href":"https://api.github.com/repos/odoo-dev/odoo/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo-dev/odoo/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo-dev/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo-dev/odoo/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/odoo-dev/odoo/statuses/2a49627a58a8f6daaad01f581a7fb4d81799a6ff"}},"author_association":"NONE"}}
|
{
"id": 19853934,
"name": "odoo-dev/odoo",
"url": "https://api.github.com/repos/odoo-dev/odoo"
}
|
{
"id": 48204996,
"login": "xdu-odoo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/48204996?",
"url": "https://api.github.com/users/xdu-odoo"
}
|
{
"id": 7466976,
"login": "odoo-dev",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7466976?",
"url": "https://api.github.com/orgs/odoo-dev"
}
| 2019-08-06T09:43:05 |
10155179368
|
{"actor":{"display_login":"xdu-odoo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dealii/dealii/pulls/comments/264264486","pull_request_review_id":212876114,"id":264264486,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NDI2NDQ4Ng==","diff_hunk":"@@ -0,0 +1,3 @@\n+If present, we will detect the LLD linker ld.lld at configuration time.","path":"doc/news/changes/minor/20190411TimoHeister","position":1,"original_position":1,"commit_id":"341d60f624f1e696612a58633a1072ee8d7028af","original_commit_id":"341d60f624f1e696612a58633a1072ee8d7028af","user":{"login":"masterleinad","id":2423533,"node_id":"MDQ6VXNlcjI0MjM1MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/2423533?v=4","gravatar_id":"","url":"https://api.github.com/users/masterleinad","html_url":"https://github.com/masterleinad","followers_url":"https://api.github.com/users/masterleinad/followers","following_url":"https://api.github.com/users/masterleinad/following{/other_user}","gists_url":"https://api.github.com/users/masterleinad/gists{/gist_id}","starred_url":"https://api.github.com/users/masterleinad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masterleinad/subscriptions","organizations_url":"https://api.github.com/users/masterleinad/orgs","repos_url":"https://api.github.com/users/masterleinad/repos","events_url":"https://api.github.com/users/masterleinad/events{/privacy}","received_events_url":"https://api.github.com/users/masterleinad/received_events","type":"User","site_admin":false},"body":"Would you mind prefixing the first sentence with something like `New:` like we usually do?","created_at":"2019-03-11T14:42:02Z","updated_at":"2019-03-11T14:42:09Z","html_url":"https://github.com/dealii/dealii/pull/7795#discussion_r264264486","pull_request_url":"https://api.github.com/repos/dealii/dealii/pulls/7795","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments/264264486"},"html":{"href":"https://github.com/dealii/dealii/pull/7795#discussion_r264264486"},"pull_request":{"href":"https://api.github.com/repos/dealii/dealii/pulls/7795"}}},"pull_request":{"url":"https://api.github.com/repos/dealii/dealii/pulls/7795","id":259979638,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5OTc5NjM4","html_url":"https://github.com/dealii/dealii/pull/7795","diff_url":"https://github.com/dealii/dealii/pull/7795.diff","patch_url":"https://github.com/dealii/dealii/pull/7795.patch","issue_url":"https://api.github.com/repos/dealii/dealii/issues/7795","number":7795,"state":"open","locked":false,"title":"enable lld linker if available","user":{"login":"tjhei","id":1531285,"node_id":"MDQ6VXNlcjE1MzEyODU=","avatar_url":"https://avatars0.githubusercontent.com/u/1531285?v=4","gravatar_id":"","url":"https://api.github.com/users/tjhei","html_url":"https://github.com/tjhei","followers_url":"https://api.github.com/users/tjhei/followers","following_url":"https://api.github.com/users/tjhei/following{/other_user}","gists_url":"https://api.github.com/users/tjhei/gists{/gist_id}","starred_url":"https://api.github.com/users/tjhei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjhei/subscriptions","organizations_url":"https://api.github.com/users/tjhei/orgs","repos_url":"https://api.github.com/users/tjhei/repos","events_url":"https://api.github.com/users/tjhei/events{/privacy}","received_events_url":"https://api.github.com/users/tjhei/received_events","type":"User","site_admin":false},"body":"LLD is quite fast:\r\n```\r\n$ time . link-lld \r\n\r\nreal 0m6.037s\r\nuser 0m10.980s\r\nsys 0m18.485s\r\n\r\n$ time . link-gold\r\n\r\nreal 0m21.372s\r\nuser 0m19.791s\r\nsys 0m1.578s\r\n\r\n$ time . link-bfd\r\n\r\nreal 1m4.265s\r\nuser 0m56.971s\r\nsys 0m7.288s\r\n```","created_at":"2019-03-11T14:01:15Z","updated_at":"2019-03-11T14:42:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c0e97cb4c5f749409af94bbc68c8a259d0505a5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1049482938,"node_id":"MDU6TGFiZWwxMDQ5NDgyOTM4","url":"https://api.github.com/repos/dealii/dealii/labels/ready%20to%20test","name":"ready to test","color":"24f287","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dealii/dealii/pulls/7795/commits","review_comments_url":"https://api.github.com/repos/dealii/dealii/pulls/7795/comments","review_comment_url":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/7795/comments","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/341d60f624f1e696612a58633a1072ee8d7028af","head":{"label":"tjhei:use_lld","ref":"use_lld","sha":"341d60f624f1e696612a58633a1072ee8d7028af","user":{"login":"tjhei","id":1531285,"node_id":"MDQ6VXNlcjE1MzEyODU=","avatar_url":"https://avatars0.githubusercontent.com/u/1531285?v=4","gravatar_id":"","url":"https://api.github.com/users/tjhei","html_url":"https://github.com/tjhei","followers_url":"https://api.github.com/users/tjhei/followers","following_url":"https://api.github.com/users/tjhei/following{/other_user}","gists_url":"https://api.github.com/users/tjhei/gists{/gist_id}","starred_url":"https://api.github.com/users/tjhei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjhei/subscriptions","organizations_url":"https://api.github.com/users/tjhei/orgs","repos_url":"https://api.github.com/users/tjhei/repos","events_url":"https://api.github.com/users/tjhei/events{/privacy}","received_events_url":"https://api.github.com/users/tjhei/received_events","type":"User","site_admin":false},"repo":{"id":22073053,"node_id":"MDEwOlJlcG9zaXRvcnkyMjA3MzA1Mw==","name":"dealii","full_name":"tjhei/dealii","private":false,"owner":{"login":"tjhei","id":1531285,"node_id":"MDQ6VXNlcjE1MzEyODU=","avatar_url":"https://avatars0.githubusercontent.com/u/1531285?v=4","gravatar_id":"","url":"https://api.github.com/users/tjhei","html_url":"https://github.com/tjhei","followers_url":"https://api.github.com/users/tjhei/followers","following_url":"https://api.github.com/users/tjhei/following{/other_user}","gists_url":"https://api.github.com/users/tjhei/gists{/gist_id}","starred_url":"https://api.github.com/users/tjhei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjhei/subscriptions","organizations_url":"https://api.github.com/users/tjhei/orgs","repos_url":"https://api.github.com/users/tjhei/repos","events_url":"https://api.github.com/users/tjhei/events{/privacy}","received_events_url":"https://api.github.com/users/tjhei/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tjhei/dealii","description":null,"fork":true,"url":"https://api.github.com/repos/tjhei/dealii","forks_url":"https://api.github.com/repos/tjhei/dealii/forks","keys_url":"https://api.github.com/repos/tjhei/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tjhei/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tjhei/dealii/teams","hooks_url":"https://api.github.com/repos/tjhei/dealii/hooks","issue_events_url":"https://api.github.com/repos/tjhei/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/tjhei/dealii/events","assignees_url":"https://api.github.com/repos/tjhei/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/tjhei/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/tjhei/dealii/tags","blobs_url":"https://api.github.com/repos/tjhei/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tjhei/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tjhei/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/tjhei/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tjhei/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/tjhei/dealii/languages","stargazers_url":"https://api.github.com/repos/tjhei/dealii/stargazers","contributors_url":"https://api.github.com/repos/tjhei/dealii/contributors","subscribers_url":"https://api.github.com/repos/tjhei/dealii/subscribers","subscription_url":"https://api.github.com/repos/tjhei/dealii/subscription","commits_url":"https://api.github.com/repos/tjhei/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/tjhei/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/tjhei/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/tjhei/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/tjhei/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/tjhei/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tjhei/dealii/merges","archive_url":"https://api.github.com/repos/tjhei/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tjhei/dealii/downloads","issues_url":"https://api.github.com/repos/tjhei/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/tjhei/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/tjhei/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/tjhei/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tjhei/dealii/labels{/name}","releases_url":"https://api.github.com/repos/tjhei/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/tjhei/dealii/deployments","created_at":"2014-07-21T17:16:17Z","updated_at":"2016-02-07T14:42:30Z","pushed_at":"2019-03-11T13:59:39Z","git_url":"git://github.com/tjhei/dealii.git","ssh_url":"[email protected]:tjhei/dealii.git","clone_url":"https://github.com/tjhei/dealii.git","svn_url":"https://github.com/tjhei/dealii","homepage":null,"size":212873,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dealii:master","ref":"master","sha":"4435a6b952c180dfa7c124f95b11001d27d71cef","user":{"login":"dealii","id":7506070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MDYwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/7506070?v=4","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"repo":{"id":21943980,"node_id":"MDEwOlJlcG9zaXRvcnkyMTk0Mzk4MA==","name":"dealii","full_name":"dealii/dealii","private":false,"owner":{"login":"dealii","id":7506070,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MDYwNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/7506070?v=4","gravatar_id":"","url":"https://api.github.com/users/dealii","html_url":"https://github.com/dealii","followers_url":"https://api.github.com/users/dealii/followers","following_url":"https://api.github.com/users/dealii/following{/other_user}","gists_url":"https://api.github.com/users/dealii/gists{/gist_id}","starred_url":"https://api.github.com/users/dealii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dealii/subscriptions","organizations_url":"https://api.github.com/users/dealii/orgs","repos_url":"https://api.github.com/users/dealii/repos","events_url":"https://api.github.com/users/dealii/events{/privacy}","received_events_url":"https://api.github.com/users/dealii/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dealii/dealii","description":"The development repository for the deal.II finite element library.","fork":false,"url":"https://api.github.com/repos/dealii/dealii","forks_url":"https://api.github.com/repos/dealii/dealii/forks","keys_url":"https://api.github.com/repos/dealii/dealii/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dealii/dealii/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dealii/dealii/teams","hooks_url":"https://api.github.com/repos/dealii/dealii/hooks","issue_events_url":"https://api.github.com/repos/dealii/dealii/issues/events{/number}","events_url":"https://api.github.com/repos/dealii/dealii/events","assignees_url":"https://api.github.com/repos/dealii/dealii/assignees{/user}","branches_url":"https://api.github.com/repos/dealii/dealii/branches{/branch}","tags_url":"https://api.github.com/repos/dealii/dealii/tags","blobs_url":"https://api.github.com/repos/dealii/dealii/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dealii/dealii/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dealii/dealii/git/refs{/sha}","trees_url":"https://api.github.com/repos/dealii/dealii/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dealii/dealii/statuses/{sha}","languages_url":"https://api.github.com/repos/dealii/dealii/languages","stargazers_url":"https://api.github.com/repos/dealii/dealii/stargazers","contributors_url":"https://api.github.com/repos/dealii/dealii/contributors","subscribers_url":"https://api.github.com/repos/dealii/dealii/subscribers","subscription_url":"https://api.github.com/repos/dealii/dealii/subscription","commits_url":"https://api.github.com/repos/dealii/dealii/commits{/sha}","git_commits_url":"https://api.github.com/repos/dealii/dealii/git/commits{/sha}","comments_url":"https://api.github.com/repos/dealii/dealii/comments{/number}","issue_comment_url":"https://api.github.com/repos/dealii/dealii/issues/comments{/number}","contents_url":"https://api.github.com/repos/dealii/dealii/contents/{+path}","compare_url":"https://api.github.com/repos/dealii/dealii/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dealii/dealii/merges","archive_url":"https://api.github.com/repos/dealii/dealii/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dealii/dealii/downloads","issues_url":"https://api.github.com/repos/dealii/dealii/issues{/number}","pulls_url":"https://api.github.com/repos/dealii/dealii/pulls{/number}","milestones_url":"https://api.github.com/repos/dealii/dealii/milestones{/number}","notifications_url":"https://api.github.com/repos/dealii/dealii/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dealii/dealii/labels{/name}","releases_url":"https://api.github.com/repos/dealii/dealii/releases{/id}","deployments_url":"https://api.github.com/repos/dealii/dealii/deployments","created_at":"2014-07-17T14:00:26Z","updated_at":"2019-03-09T00:41:44Z","pushed_at":"2019-03-11T14:01:15Z","git_url":"git://github.com/dealii/dealii.git","ssh_url":"[email protected]:dealii/dealii.git","clone_url":"https://github.com/dealii/dealii.git","svn_url":"https://github.com/dealii/dealii","homepage":"https://www.dealii.org/","size":212589,"stargazers_count":432,"watchers_count":432,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":343,"mirror_url":null,"archived":false,"open_issues_count":341,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":343,"open_issues":341,"watchers":432,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dealii/dealii/pulls/7795"},"html":{"href":"https://github.com/dealii/dealii/pull/7795"},"issue":{"href":"https://api.github.com/repos/dealii/dealii/issues/7795"},"comments":{"href":"https://api.github.com/repos/dealii/dealii/issues/7795/comments"},"review_comments":{"href":"https://api.github.com/repos/dealii/dealii/pulls/7795/comments"},"review_comment":{"href":"https://api.github.com/repos/dealii/dealii/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dealii/dealii/pulls/7795/commits"},"statuses":{"href":"https://api.github.com/repos/dealii/dealii/statuses/341d60f624f1e696612a58633a1072ee8d7028af"}},"author_association":"MEMBER"}}
|
{
"id": 21943980,
"name": "dealii/dealii",
"url": "https://api.github.com/repos/dealii/dealii"
}
|
{
"id": 2423533,
"login": "masterleinad",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2423533?",
"url": "https://api.github.com/users/masterleinad"
}
|
{
"id": 7506070,
"login": "dealii",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7506070?",
"url": "https://api.github.com/orgs/dealii"
}
| 2019-03-11T14:42:02 |
9219059711
|
{"actor":{"display_login":"masterleinad"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/privacyidea/privacyidea/pulls/comments/261984509","pull_request_review_id":210049379,"id":261984509,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MTk4NDUwOQ==","diff_hunk":"@@ -1 +1 @@\n-95c74e8a65bf9575370c07f175c9a88e:776ca294b312cb3f44b94481b3b010759912b34e2485e9f457d160b21760f7d50109fcfb4a9c0783464410a5894299e59bbf3a7ae44019bed54420a9c4ba18da5cc78dbc19bec42884831d7c3fad86695f3c629ffc41b3d7da22c53f23cf1f4b76a178ebb9636c4eb4bc454ad1e3cd47becbfd923f479b85642c93a5aa8ea2e85595fca2f45c1e0361d92748e8ccc8590f57f3d9849d7ac022183ade71263974b051574c54a636080a9bbf5bce0a09745812056ea8945666916a9019faf48ee89e5f0f8a2520ac044254524335ac3155\n+95c74e8a65bf9575370c07f175c9a88e:776ca294b312cb3f44b94481b3b010759912b34e2485e9f457d160b21760f7d50109fcfb4a9c0783464410a5894299e59bbf3a7ae44019bed54420a9c4ba18da5cc78dbc19bec42884831d7c3fad86695f3c629ffc41b3d7da22c53f23cf1f4b76a178ebb9636c4eb4bc454ad1e3cd47becbfd923f479b85642c93a5aa8ea2e85595fca2f45c1e0361d92748e8ccc8590f57f3d9849d7ac022183ade71263974b051574c54a636080a9bbf5bce0a09745812056ea8945666916a9019faf48ee8fe859253e15be6404094e4f32f3db9b4","path":"tests/testdata/enckey.enc","position":2,"original_position":2,"commit_id":"ccad77c9131d355419a16309b98e36292d3f3281","original_commit_id":"ccad77c9131d355419a16309b98e36292d3f3281","user":{"login":"plettich","id":37443810,"node_id":"MDQ6VXNlcjM3NDQzODEw","avatar_url":"https://avatars0.githubusercontent.com/u/37443810?v=4","gravatar_id":"","url":"https://api.github.com/users/plettich","html_url":"https://github.com/plettich","followers_url":"https://api.github.com/users/plettich/followers","following_url":"https://api.github.com/users/plettich/following{/other_user}","gists_url":"https://api.github.com/users/plettich/gists{/gist_id}","starred_url":"https://api.github.com/users/plettich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plettich/subscriptions","organizations_url":"https://api.github.com/users/plettich/orgs","repos_url":"https://api.github.com/users/plettich/repos","events_url":"https://api.github.com/users/plettich/events{/privacy}","received_events_url":"https://api.github.com/users/plettich/received_events","type":"User","site_admin":false},"body":"When i am finished with the versioning of the encryption, this should be fixed.","created_at":"2019-03-04T09:46:48Z","updated_at":"2019-03-04T09:46:49Z","html_url":"https://github.com/privacyidea/privacyidea/pull/1467#discussion_r261984509","pull_request_url":"https://api.github.com/repos/privacyidea/privacyidea/pulls/1467","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/privacyidea/privacyidea/pulls/comments/261984509"},"html":{"href":"https://github.com/privacyidea/privacyidea/pull/1467#discussion_r261984509"},"pull_request":{"href":"https://api.github.com/repos/privacyidea/privacyidea/pulls/1467"}},"in_reply_to_id":261768061},"pull_request":{"url":"https://api.github.com/repos/privacyidea/privacyidea/pulls/1467","id":255955670,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1OTU1Njcw","html_url":"https://github.com/privacyidea/privacyidea/pull/1467","diff_url":"https://github.com/privacyidea/privacyidea/pull/1467.diff","patch_url":"https://github.com/privacyidea/privacyidea/pull/1467.patch","issue_url":"https://api.github.com/repos/privacyidea/privacyidea/issues/1467","number":1467,"state":"open","locked":false,"title":"Switch to cryptography - Part 1: AES","user":{"login":"plettich","id":37443810,"node_id":"MDQ6VXNlcjM3NDQzODEw","avatar_url":"https://avatars0.githubusercontent.com/u/37443810?v=4","gravatar_id":"","url":"https://api.github.com/users/plettich","html_url":"https://github.com/plettich","followers_url":"https://api.github.com/users/plettich/followers","following_url":"https://api.github.com/users/plettich/following{/other_user}","gists_url":"https://api.github.com/users/plettich/gists{/gist_id}","starred_url":"https://api.github.com/users/plettich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plettich/subscriptions","organizations_url":"https://api.github.com/users/plettich/orgs","repos_url":"https://api.github.com/users/plettich/repos","events_url":"https://api.github.com/users/plettich/events{/privacy}","received_events_url":"https://api.github.com/users/plettich/received_events","type":"User","site_admin":false},"body":"- The standard AES mode is now CBC (it wasn't used otherwise anyway)\r\n- There is only one AES encryption/decryption method in `lib/crypto.py`\r\n except for Yubikeys which use AES in ECB mode\r\n- The cryptography module is used as described in\r\n https://cryptography.io/en/latest/hazmat/primitives/symmetric-encryption/#\r\n- Using the hashlib sha256 implementation which is a builtin module\r\n- The `enckey.enc` in `tests/testdata/` wasn't padded correctly so\r\n decrypting it now lead to an error while unpadding it.\r\n\r\nWorking on #337","created_at":"2019-02-25T16:23:20Z","updated_at":"2019-03-04T09:46:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"016140563b2b4c6b87cc52232a81594e5ebf1b7e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/privacyidea/privacyidea/pulls/1467/commits","review_comments_url":"https://api.github.com/repos/privacyidea/privacyidea/pulls/1467/comments","review_comment_url":"https://api.github.com/repos/privacyidea/privacyidea/pulls/comments{/number}","comments_url":"https://api.github.com/repos/privacyidea/privacyidea/issues/1467/comments","statuses_url":"https://api.github.com/repos/privacyidea/privacyidea/statuses/ccad77c9131d355419a16309b98e36292d3f3281","head":{"label":"privacyidea:337/switch_to_cryptography","ref":"337/switch_to_cryptography","sha":"ccad77c9131d355419a16309b98e36292d3f3281","user":{"login":"privacyidea","id":7519615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MTk2MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/7519615?v=4","gravatar_id":"","url":"https://api.github.com/users/privacyidea","html_url":"https://github.com/privacyidea","followers_url":"https://api.github.com/users/privacyidea/followers","following_url":"https://api.github.com/users/privacyidea/following{/other_user}","gists_url":"https://api.github.com/users/privacyidea/gists{/gist_id}","starred_url":"https://api.github.com/users/privacyidea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/privacyidea/subscriptions","organizations_url":"https://api.github.com/users/privacyidea/orgs","repos_url":"https://api.github.com/users/privacyidea/repos","events_url":"https://api.github.com/users/privacyidea/events{/privacy}","received_events_url":"https://api.github.com/users/privacyidea/received_events","type":"Organization","site_admin":false},"repo":{"id":20446681,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ0NjY4MQ==","name":"privacyidea","full_name":"privacyidea/privacyidea","private":false,"owner":{"login":"privacyidea","id":7519615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MTk2MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/7519615?v=4","gravatar_id":"","url":"https://api.github.com/users/privacyidea","html_url":"https://github.com/privacyidea","followers_url":"https://api.github.com/users/privacyidea/followers","following_url":"https://api.github.com/users/privacyidea/following{/other_user}","gists_url":"https://api.github.com/users/privacyidea/gists{/gist_id}","starred_url":"https://api.github.com/users/privacyidea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/privacyidea/subscriptions","organizations_url":"https://api.github.com/users/privacyidea/orgs","repos_url":"https://api.github.com/users/privacyidea/repos","events_url":"https://api.github.com/users/privacyidea/events{/privacy}","received_events_url":"https://api.github.com/users/privacyidea/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/privacyidea/privacyidea","description":":closed_lock_with_key: multi factor authentication system (2FA, MFA, OTP Server)","fork":false,"url":"https://api.github.com/repos/privacyidea/privacyidea","forks_url":"https://api.github.com/repos/privacyidea/privacyidea/forks","keys_url":"https://api.github.com/repos/privacyidea/privacyidea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/privacyidea/privacyidea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/privacyidea/privacyidea/teams","hooks_url":"https://api.github.com/repos/privacyidea/privacyidea/hooks","issue_events_url":"https://api.github.com/repos/privacyidea/privacyidea/issues/events{/number}","events_url":"https://api.github.com/repos/privacyidea/privacyidea/events","assignees_url":"https://api.github.com/repos/privacyidea/privacyidea/assignees{/user}","branches_url":"https://api.github.com/repos/privacyidea/privacyidea/branches{/branch}","tags_url":"https://api.github.com/repos/privacyidea/privacyidea/tags","blobs_url":"https://api.github.com/repos/privacyidea/privacyidea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/privacyidea/privacyidea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/privacyidea/privacyidea/git/refs{/sha}","trees_url":"https://api.github.com/repos/privacyidea/privacyidea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/privacyidea/privacyidea/statuses/{sha}","languages_url":"https://api.github.com/repos/privacyidea/privacyidea/languages","stargazers_url":"https://api.github.com/repos/privacyidea/privacyidea/stargazers","contributors_url":"https://api.github.com/repos/privacyidea/privacyidea/contributors","subscribers_url":"https://api.github.com/repos/privacyidea/privacyidea/subscribers","subscription_url":"https://api.github.com/repos/privacyidea/privacyidea/subscription","commits_url":"https://api.github.com/repos/privacyidea/privacyidea/commits{/sha}","git_commits_url":"https://api.github.com/repos/privacyidea/privacyidea/git/commits{/sha}","comments_url":"https://api.github.com/repos/privacyidea/privacyidea/comments{/number}","issue_comment_url":"https://api.github.com/repos/privacyidea/privacyidea/issues/comments{/number}","contents_url":"https://api.github.com/repos/privacyidea/privacyidea/contents/{+path}","compare_url":"https://api.github.com/repos/privacyidea/privacyidea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/privacyidea/privacyidea/merges","archive_url":"https://api.github.com/repos/privacyidea/privacyidea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/privacyidea/privacyidea/downloads","issues_url":"https://api.github.com/repos/privacyidea/privacyidea/issues{/number}","pulls_url":"https://api.github.com/repos/privacyidea/privacyidea/pulls{/number}","milestones_url":"https://api.github.com/repos/privacyidea/privacyidea/milestones{/number}","notifications_url":"https://api.github.com/repos/privacyidea/privacyidea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/privacyidea/privacyidea/labels{/name}","releases_url":"https://api.github.com/repos/privacyidea/privacyidea/releases{/id}","deployments_url":"https://api.github.com/repos/privacyidea/privacyidea/deployments","created_at":"2014-06-03T14:47:02Z","updated_at":"2019-03-04T07:48:57Z","pushed_at":"2019-03-01T17:03:36Z","git_url":"git://github.com/privacyidea/privacyidea.git","ssh_url":"[email protected]:privacyidea/privacyidea.git","clone_url":"https://github.com/privacyidea/privacyidea.git","svn_url":"https://github.com/privacyidea/privacyidea","homepage":"http://www.privacyidea.org","size":29418,"stargazers_count":593,"watchers_count":593,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"archived":false,"open_issues_count":133,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":144,"open_issues":133,"watchers":593,"default_branch":"master"}},"base":{"label":"privacyidea:master","ref":"master","sha":"43434a4fe1c32181760acd2691232476affdacd6","user":{"login":"privacyidea","id":7519615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MTk2MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/7519615?v=4","gravatar_id":"","url":"https://api.github.com/users/privacyidea","html_url":"https://github.com/privacyidea","followers_url":"https://api.github.com/users/privacyidea/followers","following_url":"https://api.github.com/users/privacyidea/following{/other_user}","gists_url":"https://api.github.com/users/privacyidea/gists{/gist_id}","starred_url":"https://api.github.com/users/privacyidea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/privacyidea/subscriptions","organizations_url":"https://api.github.com/users/privacyidea/orgs","repos_url":"https://api.github.com/users/privacyidea/repos","events_url":"https://api.github.com/users/privacyidea/events{/privacy}","received_events_url":"https://api.github.com/users/privacyidea/received_events","type":"Organization","site_admin":false},"repo":{"id":20446681,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ0NjY4MQ==","name":"privacyidea","full_name":"privacyidea/privacyidea","private":false,"owner":{"login":"privacyidea","id":7519615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MTk2MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/7519615?v=4","gravatar_id":"","url":"https://api.github.com/users/privacyidea","html_url":"https://github.com/privacyidea","followers_url":"https://api.github.com/users/privacyidea/followers","following_url":"https://api.github.com/users/privacyidea/following{/other_user}","gists_url":"https://api.github.com/users/privacyidea/gists{/gist_id}","starred_url":"https://api.github.com/users/privacyidea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/privacyidea/subscriptions","organizations_url":"https://api.github.com/users/privacyidea/orgs","repos_url":"https://api.github.com/users/privacyidea/repos","events_url":"https://api.github.com/users/privacyidea/events{/privacy}","received_events_url":"https://api.github.com/users/privacyidea/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/privacyidea/privacyidea","description":":closed_lock_with_key: multi factor authentication system (2FA, MFA, OTP Server)","fork":false,"url":"https://api.github.com/repos/privacyidea/privacyidea","forks_url":"https://api.github.com/repos/privacyidea/privacyidea/forks","keys_url":"https://api.github.com/repos/privacyidea/privacyidea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/privacyidea/privacyidea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/privacyidea/privacyidea/teams","hooks_url":"https://api.github.com/repos/privacyidea/privacyidea/hooks","issue_events_url":"https://api.github.com/repos/privacyidea/privacyidea/issues/events{/number}","events_url":"https://api.github.com/repos/privacyidea/privacyidea/events","assignees_url":"https://api.github.com/repos/privacyidea/privacyidea/assignees{/user}","branches_url":"https://api.github.com/repos/privacyidea/privacyidea/branches{/branch}","tags_url":"https://api.github.com/repos/privacyidea/privacyidea/tags","blobs_url":"https://api.github.com/repos/privacyidea/privacyidea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/privacyidea/privacyidea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/privacyidea/privacyidea/git/refs{/sha}","trees_url":"https://api.github.com/repos/privacyidea/privacyidea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/privacyidea/privacyidea/statuses/{sha}","languages_url":"https://api.github.com/repos/privacyidea/privacyidea/languages","stargazers_url":"https://api.github.com/repos/privacyidea/privacyidea/stargazers","contributors_url":"https://api.github.com/repos/privacyidea/privacyidea/contributors","subscribers_url":"https://api.github.com/repos/privacyidea/privacyidea/subscribers","subscription_url":"https://api.github.com/repos/privacyidea/privacyidea/subscription","commits_url":"https://api.github.com/repos/privacyidea/privacyidea/commits{/sha}","git_commits_url":"https://api.github.com/repos/privacyidea/privacyidea/git/commits{/sha}","comments_url":"https://api.github.com/repos/privacyidea/privacyidea/comments{/number}","issue_comment_url":"https://api.github.com/repos/privacyidea/privacyidea/issues/comments{/number}","contents_url":"https://api.github.com/repos/privacyidea/privacyidea/contents/{+path}","compare_url":"https://api.github.com/repos/privacyidea/privacyidea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/privacyidea/privacyidea/merges","archive_url":"https://api.github.com/repos/privacyidea/privacyidea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/privacyidea/privacyidea/downloads","issues_url":"https://api.github.com/repos/privacyidea/privacyidea/issues{/number}","pulls_url":"https://api.github.com/repos/privacyidea/privacyidea/pulls{/number}","milestones_url":"https://api.github.com/repos/privacyidea/privacyidea/milestones{/number}","notifications_url":"https://api.github.com/repos/privacyidea/privacyidea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/privacyidea/privacyidea/labels{/name}","releases_url":"https://api.github.com/repos/privacyidea/privacyidea/releases{/id}","deployments_url":"https://api.github.com/repos/privacyidea/privacyidea/deployments","created_at":"2014-06-03T14:47:02Z","updated_at":"2019-03-04T07:48:57Z","pushed_at":"2019-03-01T17:03:36Z","git_url":"git://github.com/privacyidea/privacyidea.git","ssh_url":"[email protected]:privacyidea/privacyidea.git","clone_url":"https://github.com/privacyidea/privacyidea.git","svn_url":"https://github.com/privacyidea/privacyidea","homepage":"http://www.privacyidea.org","size":29418,"stargazers_count":593,"watchers_count":593,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":144,"mirror_url":null,"archived":false,"open_issues_count":133,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":144,"open_issues":133,"watchers":593,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/privacyidea/privacyidea/pulls/1467"},"html":{"href":"https://github.com/privacyidea/privacyidea/pull/1467"},"issue":{"href":"https://api.github.com/repos/privacyidea/privacyidea/issues/1467"},"comments":{"href":"https://api.github.com/repos/privacyidea/privacyidea/issues/1467/comments"},"review_comments":{"href":"https://api.github.com/repos/privacyidea/privacyidea/pulls/1467/comments"},"review_comment":{"href":"https://api.github.com/repos/privacyidea/privacyidea/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/privacyidea/privacyidea/pulls/1467/commits"},"statuses":{"href":"https://api.github.com/repos/privacyidea/privacyidea/statuses/ccad77c9131d355419a16309b98e36292d3f3281"}},"author_association":"MEMBER"}}
|
{
"id": 20446681,
"name": "privacyidea/privacyidea",
"url": "https://api.github.com/repos/privacyidea/privacyidea"
}
|
{
"id": 37443810,
"login": "plettich",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/37443810?",
"url": "https://api.github.com/users/plettich"
}
|
{
"id": 7519615,
"login": "privacyidea",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7519615?",
"url": "https://api.github.com/orgs/privacyidea"
}
| 2019-03-04T09:46:48 |
9173298031
|
{"actor":{"display_login":"plettich"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/comments/330510889","pull_request_review_id":296188890,"id":330510889,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMDUxMDg4OQ==","diff_hunk":"@@ -150,6 +150,10 @@ protected static function getRelatedModelAttributeValue(Model $model, string $at\n \n [$relatedModelName, $relatedAttribute] = explode('.', $attribute);\n \n+ if (Str::contains($relatedModelName, '_')) {","path":"src/Traits/DetectsChanges.php","position":null,"original_position":4,"commit_id":"24bcf069b4b39dee4532375e10916ff70c7db47d","original_commit_id":"6b24e24669408c831d29a1b449b330e50d482e58","user":{"login":"Jhnbrn90","id":24190396,"node_id":"MDQ6VXNlcjI0MTkwMzk2","avatar_url":"https://avatars1.githubusercontent.com/u/24190396?v=4","gravatar_id":"","url":"https://api.github.com/users/Jhnbrn90","html_url":"https://github.com/Jhnbrn90","followers_url":"https://api.github.com/users/Jhnbrn90/followers","following_url":"https://api.github.com/users/Jhnbrn90/following{/other_user}","gists_url":"https://api.github.com/users/Jhnbrn90/gists{/gist_id}","starred_url":"https://api.github.com/users/Jhnbrn90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jhnbrn90/subscriptions","organizations_url":"https://api.github.com/users/Jhnbrn90/orgs","repos_url":"https://api.github.com/users/Jhnbrn90/repos","events_url":"https://api.github.com/users/Jhnbrn90/events{/privacy}","received_events_url":"https://api.github.com/users/Jhnbrn90/received_events","type":"User","site_admin":false},"body":"You're right, we can just camelize every time 😄 ","created_at":"2019-10-02T12:05:18Z","updated_at":"2019-10-02T12:05:18Z","html_url":"https://github.com/spatie/laravel-activitylog/pull/602#discussion_r330510889","pull_request_url":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/602","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/comments/330510889"},"html":{"href":"https://github.com/spatie/laravel-activitylog/pull/602#discussion_r330510889"},"pull_request":{"href":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/602"}},"in_reply_to_id":330474385},"pull_request":{"url":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/602","id":323678385,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIzNjc4Mzg1","html_url":"https://github.com/spatie/laravel-activitylog/pull/602","diff_url":"https://github.com/spatie/laravel-activitylog/pull/602.diff","patch_url":"https://github.com/spatie/laravel-activitylog/pull/602.patch","issue_url":"https://api.github.com/repos/spatie/laravel-activitylog/issues/602","number":602,"state":"open","locked":false,"title":"Feature/snake case relationships","user":{"login":"Jhnbrn90","id":24190396,"node_id":"MDQ6VXNlcjI0MTkwMzk2","avatar_url":"https://avatars1.githubusercontent.com/u/24190396?v=4","gravatar_id":"","url":"https://api.github.com/users/Jhnbrn90","html_url":"https://github.com/Jhnbrn90","followers_url":"https://api.github.com/users/Jhnbrn90/followers","following_url":"https://api.github.com/users/Jhnbrn90/following{/other_user}","gists_url":"https://api.github.com/users/Jhnbrn90/gists{/gist_id}","starred_url":"https://api.github.com/users/Jhnbrn90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jhnbrn90/subscriptions","organizations_url":"https://api.github.com/users/Jhnbrn90/orgs","repos_url":"https://api.github.com/users/Jhnbrn90/repos","events_url":"https://api.github.com/users/Jhnbrn90/events{/privacy}","received_events_url":"https://api.github.com/users/Jhnbrn90/received_events","type":"User","site_admin":false},"body":"Addressing issue #499 \r\n\r\nsnake_cased relationship definitions within `$logAttributes` are now handled correctly.","created_at":"2019-10-02T10:09:05Z","updated_at":"2019-10-02T12:05:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"013b136a52c4ee7a118fa55af692ef2980813b2f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/602/commits","review_comments_url":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/602/comments","review_comment_url":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spatie/laravel-activitylog/issues/602/comments","statuses_url":"https://api.github.com/repos/spatie/laravel-activitylog/statuses/24bcf069b4b39dee4532375e10916ff70c7db47d","head":{"label":"Jhnbrn90:feature/snake-case-relationships","ref":"feature/snake-case-relationships","sha":"24bcf069b4b39dee4532375e10916ff70c7db47d","user":{"login":"Jhnbrn90","id":24190396,"node_id":"MDQ6VXNlcjI0MTkwMzk2","avatar_url":"https://avatars1.githubusercontent.com/u/24190396?v=4","gravatar_id":"","url":"https://api.github.com/users/Jhnbrn90","html_url":"https://github.com/Jhnbrn90","followers_url":"https://api.github.com/users/Jhnbrn90/followers","following_url":"https://api.github.com/users/Jhnbrn90/following{/other_user}","gists_url":"https://api.github.com/users/Jhnbrn90/gists{/gist_id}","starred_url":"https://api.github.com/users/Jhnbrn90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jhnbrn90/subscriptions","organizations_url":"https://api.github.com/users/Jhnbrn90/orgs","repos_url":"https://api.github.com/users/Jhnbrn90/repos","events_url":"https://api.github.com/users/Jhnbrn90/events{/privacy}","received_events_url":"https://api.github.com/users/Jhnbrn90/received_events","type":"User","site_admin":false},"repo":{"id":212300110,"node_id":"MDEwOlJlcG9zaXRvcnkyMTIzMDAxMTA=","name":"laravel-activitylog","full_name":"Jhnbrn90/laravel-activitylog","private":false,"owner":{"login":"Jhnbrn90","id":24190396,"node_id":"MDQ6VXNlcjI0MTkwMzk2","avatar_url":"https://avatars1.githubusercontent.com/u/24190396?v=4","gravatar_id":"","url":"https://api.github.com/users/Jhnbrn90","html_url":"https://github.com/Jhnbrn90","followers_url":"https://api.github.com/users/Jhnbrn90/followers","following_url":"https://api.github.com/users/Jhnbrn90/following{/other_user}","gists_url":"https://api.github.com/users/Jhnbrn90/gists{/gist_id}","starred_url":"https://api.github.com/users/Jhnbrn90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jhnbrn90/subscriptions","organizations_url":"https://api.github.com/users/Jhnbrn90/orgs","repos_url":"https://api.github.com/users/Jhnbrn90/repos","events_url":"https://api.github.com/users/Jhnbrn90/events{/privacy}","received_events_url":"https://api.github.com/users/Jhnbrn90/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Jhnbrn90/laravel-activitylog","description":"Log activity inside your Laravel app","fork":true,"url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog","forks_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/forks","keys_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/teams","hooks_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/hooks","issue_events_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/issues/events{/number}","events_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/events","assignees_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/assignees{/user}","branches_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/branches{/branch}","tags_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/tags","blobs_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/statuses/{sha}","languages_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/languages","stargazers_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/stargazers","contributors_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/contributors","subscribers_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/subscribers","subscription_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/subscription","commits_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/contents/{+path}","compare_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/merges","archive_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/downloads","issues_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/issues{/number}","pulls_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/pulls{/number}","milestones_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/milestones{/number}","notifications_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/labels{/name}","releases_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/releases{/id}","deployments_url":"https://api.github.com/repos/Jhnbrn90/laravel-activitylog/deployments","created_at":"2019-10-02T09:23:24Z","updated_at":"2019-10-02T09:23:26Z","pushed_at":"2019-10-02T12:04:57Z","git_url":"git://github.com/Jhnbrn90/laravel-activitylog.git","ssh_url":"[email protected]:Jhnbrn90/laravel-activitylog.git","clone_url":"https://github.com/Jhnbrn90/laravel-activitylog.git","svn_url":"https://github.com/Jhnbrn90/laravel-activitylog","homepage":"https://docs.spatie.be/laravel-activitylog","size":977,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spatie:master","ref":"master","sha":"89bbdbea8f085d72ba7513af989e2e54366f5794","user":{"login":"spatie","id":7535935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MzU5MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/7535935?v=4","gravatar_id":"","url":"https://api.github.com/users/spatie","html_url":"https://github.com/spatie","followers_url":"https://api.github.com/users/spatie/followers","following_url":"https://api.github.com/users/spatie/following{/other_user}","gists_url":"https://api.github.com/users/spatie/gists{/gist_id}","starred_url":"https://api.github.com/users/spatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatie/subscriptions","organizations_url":"https://api.github.com/users/spatie/orgs","repos_url":"https://api.github.com/users/spatie/repos","events_url":"https://api.github.com/users/spatie/events{/privacy}","received_events_url":"https://api.github.com/users/spatie/received_events","type":"Organization","site_admin":false},"repo":{"id":61802818,"node_id":"MDEwOlJlcG9zaXRvcnk2MTgwMjgxOA==","name":"laravel-activitylog","full_name":"spatie/laravel-activitylog","private":false,"owner":{"login":"spatie","id":7535935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1MzU5MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/7535935?v=4","gravatar_id":"","url":"https://api.github.com/users/spatie","html_url":"https://github.com/spatie","followers_url":"https://api.github.com/users/spatie/followers","following_url":"https://api.github.com/users/spatie/following{/other_user}","gists_url":"https://api.github.com/users/spatie/gists{/gist_id}","starred_url":"https://api.github.com/users/spatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spatie/subscriptions","organizations_url":"https://api.github.com/users/spatie/orgs","repos_url":"https://api.github.com/users/spatie/repos","events_url":"https://api.github.com/users/spatie/events{/privacy}","received_events_url":"https://api.github.com/users/spatie/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spatie/laravel-activitylog","description":"Log activity inside your Laravel app","fork":false,"url":"https://api.github.com/repos/spatie/laravel-activitylog","forks_url":"https://api.github.com/repos/spatie/laravel-activitylog/forks","keys_url":"https://api.github.com/repos/spatie/laravel-activitylog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spatie/laravel-activitylog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spatie/laravel-activitylog/teams","hooks_url":"https://api.github.com/repos/spatie/laravel-activitylog/hooks","issue_events_url":"https://api.github.com/repos/spatie/laravel-activitylog/issues/events{/number}","events_url":"https://api.github.com/repos/spatie/laravel-activitylog/events","assignees_url":"https://api.github.com/repos/spatie/laravel-activitylog/assignees{/user}","branches_url":"https://api.github.com/repos/spatie/laravel-activitylog/branches{/branch}","tags_url":"https://api.github.com/repos/spatie/laravel-activitylog/tags","blobs_url":"https://api.github.com/repos/spatie/laravel-activitylog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spatie/laravel-activitylog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spatie/laravel-activitylog/git/refs{/sha}","trees_url":"https://api.github.com/repos/spatie/laravel-activitylog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spatie/laravel-activitylog/statuses/{sha}","languages_url":"https://api.github.com/repos/spatie/laravel-activitylog/languages","stargazers_url":"https://api.github.com/repos/spatie/laravel-activitylog/stargazers","contributors_url":"https://api.github.com/repos/spatie/laravel-activitylog/contributors","subscribers_url":"https://api.github.com/repos/spatie/laravel-activitylog/subscribers","subscription_url":"https://api.github.com/repos/spatie/laravel-activitylog/subscription","commits_url":"https://api.github.com/repos/spatie/laravel-activitylog/commits{/sha}","git_commits_url":"https://api.github.com/repos/spatie/laravel-activitylog/git/commits{/sha}","comments_url":"https://api.github.com/repos/spatie/laravel-activitylog/comments{/number}","issue_comment_url":"https://api.github.com/repos/spatie/laravel-activitylog/issues/comments{/number}","contents_url":"https://api.github.com/repos/spatie/laravel-activitylog/contents/{+path}","compare_url":"https://api.github.com/repos/spatie/laravel-activitylog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spatie/laravel-activitylog/merges","archive_url":"https://api.github.com/repos/spatie/laravel-activitylog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spatie/laravel-activitylog/downloads","issues_url":"https://api.github.com/repos/spatie/laravel-activitylog/issues{/number}","pulls_url":"https://api.github.com/repos/spatie/laravel-activitylog/pulls{/number}","milestones_url":"https://api.github.com/repos/spatie/laravel-activitylog/milestones{/number}","notifications_url":"https://api.github.com/repos/spatie/laravel-activitylog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spatie/laravel-activitylog/labels{/name}","releases_url":"https://api.github.com/repos/spatie/laravel-activitylog/releases{/id}","deployments_url":"https://api.github.com/repos/spatie/laravel-activitylog/deployments","created_at":"2016-06-23T12:17:12Z","updated_at":"2019-10-01T11:27:48Z","pushed_at":"2019-10-02T12:04:59Z","git_url":"git://github.com/spatie/laravel-activitylog.git","ssh_url":"[email protected]:spatie/laravel-activitylog.git","clone_url":"https://github.com/spatie/laravel-activitylog.git","svn_url":"https://github.com/spatie/laravel-activitylog","homepage":"https://docs.spatie.be/laravel-activitylog","size":980,"stargazers_count":2665,"watchers_count":2665,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":362,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":362,"open_issues":27,"watchers":2665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/602"},"html":{"href":"https://github.com/spatie/laravel-activitylog/pull/602"},"issue":{"href":"https://api.github.com/repos/spatie/laravel-activitylog/issues/602"},"comments":{"href":"https://api.github.com/repos/spatie/laravel-activitylog/issues/602/comments"},"review_comments":{"href":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/602/comments"},"review_comment":{"href":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spatie/laravel-activitylog/pulls/602/commits"},"statuses":{"href":"https://api.github.com/repos/spatie/laravel-activitylog/statuses/24bcf069b4b39dee4532375e10916ff70c7db47d"}},"author_association":"NONE"}}
|
{
"id": 61802818,
"name": "spatie/laravel-activitylog",
"url": "https://api.github.com/repos/spatie/laravel-activitylog"
}
|
{
"id": 24190396,
"login": "Jhnbrn90",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24190396?",
"url": "https://api.github.com/users/Jhnbrn90"
}
|
{
"id": 7535935,
"login": "spatie",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7535935?",
"url": "https://api.github.com/orgs/spatie"
}
| 2019-10-02T12:05:18 |
10541942032
|
{"actor":{"display_login":"Jhnbrn90"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/pulls/comments/342256031","pull_request_review_id":311339897,"id":342256031,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MjI1NjAzMQ==","diff_hunk":"@@ -5,11 +5,4 @@ export SCRIPTROOT=$( cd \"$( dirname \"${BASH_SOURCE[0]}\" )\" && cd .. && pwd )\n export CIME_MACHINE=cori-knl\n source $SCRIPTROOT/util/setup_common.sh\n \n-# Unload python module from:\n-# $SCRIPTROOT/util/setup_common.sh --> $SCRIPTROOT/util/${CIME_MACHINE}_setup.sh\n-module unload python/2.7-anaconda-5.2\n-\n-# Get e3sm_simple conda env\n-source /global/project/projectdirs/acme/software/anaconda_envs/load_latest_e3sm_simple.sh","path":"jenkins/cori_atmnbfb.sh","position":9,"original_position":9,"commit_id":"f73b232d96868fb8249aea6875cc5a93ad0a98e8","original_commit_id":"f73b232d96868fb8249aea6875cc5a93ad0a98e8","user":{"login":"jhkennedy","id":7882693,"node_id":"MDQ6VXNlcjc4ODI2OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/7882693?v=4","gravatar_id":"","url":"https://api.github.com/users/jhkennedy","html_url":"https://github.com/jhkennedy","followers_url":"https://api.github.com/users/jhkennedy/followers","following_url":"https://api.github.com/users/jhkennedy/following{/other_user}","gists_url":"https://api.github.com/users/jhkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/jhkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhkennedy/subscriptions","organizations_url":"https://api.github.com/users/jhkennedy/orgs","repos_url":"https://api.github.com/users/jhkennedy/repos","events_url":"https://api.github.com/users/jhkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/jhkennedy/received_events","type":"User","site_admin":false},"body":"This is specific to the `atmnbfb` job on cori, which is how we were previously sourcing it. Now, the `cori-knl_setup.sh` script loads the `cime_env` for all cori test jobs (haswell just links to the knl script) instead of the python module -- that is, we're loading it upstream now. ","created_at":"2019-11-04T20:32:30Z","updated_at":"2019-11-04T20:32:31Z","html_url":"https://github.com/E3SM-Project/E3SM_test_scripts/pull/13#discussion_r342256031","pull_request_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/pulls/13","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/pulls/comments/342256031"},"html":{"href":"https://github.com/E3SM-Project/E3SM_test_scripts/pull/13#discussion_r342256031"},"pull_request":{"href":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/pulls/13"}},"in_reply_to_id":342251225},"pull_request":{"url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/pulls/13","id":336402937,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM2NDAyOTM3","html_url":"https://github.com/E3SM-Project/E3SM_test_scripts/pull/13","diff_url":"https://github.com/E3SM-Project/E3SM_test_scripts/pull/13.diff","patch_url":"https://github.com/E3SM-Project/E3SM_test_scripts/pull/13.patch","issue_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/issues/13","number":13,"state":"open","locked":false,"title":"Use `cime_env` where avaiable","user":{"login":"jhkennedy","id":7882693,"node_id":"MDQ6VXNlcjc4ODI2OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/7882693?v=4","gravatar_id":"","url":"https://api.github.com/users/jhkennedy","html_url":"https://github.com/jhkennedy","followers_url":"https://api.github.com/users/jhkennedy/followers","following_url":"https://api.github.com/users/jhkennedy/following{/other_user}","gists_url":"https://api.github.com/users/jhkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/jhkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhkennedy/subscriptions","organizations_url":"https://api.github.com/users/jhkennedy/orgs","repos_url":"https://api.github.com/users/jhkennedy/repos","events_url":"https://api.github.com/users/jhkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/jhkennedy/received_events","type":"User","site_admin":false},"body":"This updates the machine configuration for:\r\n\r\n* Anvil \r\n* Bebop*\r\n* Compy\r\n* Cori\r\n* Theta* \r\n\r\n\r\n*Please look at Bobop and Theta closely as I'm not 100% sure `cime_env` is available for them.*\r\n\r\nto use the latest `cime_env` as the python environment for E3SM/CIME testing. Right now, this is needed for the external python dependencies required by the `e3sm_atm_nbfb_*` tests (currently only run on `cori-knl`) but will likely be used in the future by other CIME tests as the ability to use external python dependencies in CIME has been request broadly.\r\n\r\nThis covers all the machines in the `E3SM_Machine_Coverage` section on [CDASH](https://my.cdash.org/index.php?project=ACME_Climate), and all but `sandiatoss3` and `melvin` in the `E3SM_Baselines` section because `cime_env` isn't deployed to them (Jim, I think you'd have to deploy `cime_env` there...).\r\n\r\n----\r\n\r\n@xylar , once this is merged and the `e3sm_atm_nbfb_*` have run successfully, you can remove the `e3sm_simple` env. off of Cori. \r\n\r\ncc @mkstratos: this is how the python environment needed for EVV is deployed. ","created_at":"2019-11-04T17:51:45Z","updated_at":"2019-11-04T20:32:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"832d6bbb291042cc8046e1614672cd36154ccfc1","assignee":{"login":"jgfouca","id":7292036,"node_id":"MDQ6VXNlcjcyOTIwMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/7292036?v=4","gravatar_id":"","url":"https://api.github.com/users/jgfouca","html_url":"https://github.com/jgfouca","followers_url":"https://api.github.com/users/jgfouca/followers","following_url":"https://api.github.com/users/jgfouca/following{/other_user}","gists_url":"https://api.github.com/users/jgfouca/gists{/gist_id}","starred_url":"https://api.github.com/users/jgfouca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgfouca/subscriptions","organizations_url":"https://api.github.com/users/jgfouca/orgs","repos_url":"https://api.github.com/users/jgfouca/repos","events_url":"https://api.github.com/users/jgfouca/events{/privacy}","received_events_url":"https://api.github.com/users/jgfouca/received_events","type":"User","site_admin":false},"assignees":[{"login":"jgfouca","id":7292036,"node_id":"MDQ6VXNlcjcyOTIwMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/7292036?v=4","gravatar_id":"","url":"https://api.github.com/users/jgfouca","html_url":"https://github.com/jgfouca","followers_url":"https://api.github.com/users/jgfouca/followers","following_url":"https://api.github.com/users/jgfouca/following{/other_user}","gists_url":"https://api.github.com/users/jgfouca/gists{/gist_id}","starred_url":"https://api.github.com/users/jgfouca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgfouca/subscriptions","organizations_url":"https://api.github.com/users/jgfouca/orgs","repos_url":"https://api.github.com/users/jgfouca/repos","events_url":"https://api.github.com/users/jgfouca/events{/privacy}","received_events_url":"https://api.github.com/users/jgfouca/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/pulls/13/commits","review_comments_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/pulls/13/comments","review_comment_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/issues/13/comments","statuses_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/statuses/f73b232d96868fb8249aea6875cc5a93ad0a98e8","head":{"label":"jhkennedy:cime-env","ref":"cime-env","sha":"f73b232d96868fb8249aea6875cc5a93ad0a98e8","user":{"login":"jhkennedy","id":7882693,"node_id":"MDQ6VXNlcjc4ODI2OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/7882693?v=4","gravatar_id":"","url":"https://api.github.com/users/jhkennedy","html_url":"https://github.com/jhkennedy","followers_url":"https://api.github.com/users/jhkennedy/followers","following_url":"https://api.github.com/users/jhkennedy/following{/other_user}","gists_url":"https://api.github.com/users/jhkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/jhkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhkennedy/subscriptions","organizations_url":"https://api.github.com/users/jhkennedy/orgs","repos_url":"https://api.github.com/users/jhkennedy/repos","events_url":"https://api.github.com/users/jhkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/jhkennedy/received_events","type":"User","site_admin":false},"repo":{"id":200495842,"node_id":"MDEwOlJlcG9zaXRvcnkyMDA0OTU4NDI=","name":"E3SM_test_scripts","full_name":"jhkennedy/E3SM_test_scripts","private":false,"owner":{"login":"jhkennedy","id":7882693,"node_id":"MDQ6VXNlcjc4ODI2OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/7882693?v=4","gravatar_id":"","url":"https://api.github.com/users/jhkennedy","html_url":"https://github.com/jhkennedy","followers_url":"https://api.github.com/users/jhkennedy/followers","following_url":"https://api.github.com/users/jhkennedy/following{/other_user}","gists_url":"https://api.github.com/users/jhkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/jhkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhkennedy/subscriptions","organizations_url":"https://api.github.com/users/jhkennedy/orgs","repos_url":"https://api.github.com/users/jhkennedy/repos","events_url":"https://api.github.com/users/jhkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/jhkennedy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jhkennedy/E3SM_test_scripts","description":"Test scripts for cron and jenkins jobs","fork":true,"url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts","forks_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/forks","keys_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/teams","hooks_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/hooks","issue_events_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/issues/events{/number}","events_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/events","assignees_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/assignees{/user}","branches_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/branches{/branch}","tags_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/tags","blobs_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/languages","stargazers_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/stargazers","contributors_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/contributors","subscribers_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/subscribers","subscription_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/subscription","commits_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/contents/{+path}","compare_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/merges","archive_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/downloads","issues_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/issues{/number}","pulls_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/labels{/name}","releases_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/releases{/id}","deployments_url":"https://api.github.com/repos/jhkennedy/E3SM_test_scripts/deployments","created_at":"2019-08-04T13:25:10Z","updated_at":"2019-11-04T17:09:40Z","pushed_at":"2019-11-04T17:46:25Z","git_url":"git://github.com/jhkennedy/E3SM_test_scripts.git","ssh_url":"[email protected]:jhkennedy/E3SM_test_scripts.git","clone_url":"https://github.com/jhkennedy/E3SM_test_scripts.git","svn_url":"https://github.com/jhkennedy/E3SM_test_scripts","homepage":null,"size":63,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"E3SM-Project:master","ref":"master","sha":"21b155b186df4f70e8a626f49a49c3eabe20c5dd","user":{"login":"E3SM-Project","id":7558558,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTg1NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7558558?v=4","gravatar_id":"","url":"https://api.github.com/users/E3SM-Project","html_url":"https://github.com/E3SM-Project","followers_url":"https://api.github.com/users/E3SM-Project/followers","following_url":"https://api.github.com/users/E3SM-Project/following{/other_user}","gists_url":"https://api.github.com/users/E3SM-Project/gists{/gist_id}","starred_url":"https://api.github.com/users/E3SM-Project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/E3SM-Project/subscriptions","organizations_url":"https://api.github.com/users/E3SM-Project/orgs","repos_url":"https://api.github.com/users/E3SM-Project/repos","events_url":"https://api.github.com/users/E3SM-Project/events{/privacy}","received_events_url":"https://api.github.com/users/E3SM-Project/received_events","type":"Organization","site_admin":false},"repo":{"id":125123181,"node_id":"MDEwOlJlcG9zaXRvcnkxMjUxMjMxODE=","name":"E3SM_test_scripts","full_name":"E3SM-Project/E3SM_test_scripts","private":false,"owner":{"login":"E3SM-Project","id":7558558,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NTg1NTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7558558?v=4","gravatar_id":"","url":"https://api.github.com/users/E3SM-Project","html_url":"https://github.com/E3SM-Project","followers_url":"https://api.github.com/users/E3SM-Project/followers","following_url":"https://api.github.com/users/E3SM-Project/following{/other_user}","gists_url":"https://api.github.com/users/E3SM-Project/gists{/gist_id}","starred_url":"https://api.github.com/users/E3SM-Project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/E3SM-Project/subscriptions","organizations_url":"https://api.github.com/users/E3SM-Project/orgs","repos_url":"https://api.github.com/users/E3SM-Project/repos","events_url":"https://api.github.com/users/E3SM-Project/events{/privacy}","received_events_url":"https://api.github.com/users/E3SM-Project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/E3SM-Project/E3SM_test_scripts","description":"Test scripts for cron and jenkins jobs","fork":false,"url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts","forks_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/forks","keys_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/teams","hooks_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/hooks","issue_events_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/issues/events{/number}","events_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/events","assignees_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/assignees{/user}","branches_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/branches{/branch}","tags_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/tags","blobs_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/languages","stargazers_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/stargazers","contributors_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/contributors","subscribers_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/subscribers","subscription_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/subscription","commits_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/contents/{+path}","compare_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/merges","archive_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/downloads","issues_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/issues{/number}","pulls_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/labels{/name}","releases_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/releases{/id}","deployments_url":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/deployments","created_at":"2018-03-13T22:34:30Z","updated_at":"2019-10-09T21:07:45Z","pushed_at":"2019-11-04T17:51:46Z","git_url":"git://github.com/E3SM-Project/E3SM_test_scripts.git","ssh_url":"[email protected]:E3SM-Project/E3SM_test_scripts.git","clone_url":"https://github.com/E3SM-Project/E3SM_test_scripts.git","svn_url":"https://github.com/E3SM-Project/E3SM_test_scripts","homepage":null,"size":59,"stargazers_count":4,"watchers_count":4,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/pulls/13"},"html":{"href":"https://github.com/E3SM-Project/E3SM_test_scripts/pull/13"},"issue":{"href":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/issues/13"},"comments":{"href":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/E3SM-Project/E3SM_test_scripts/statuses/f73b232d96868fb8249aea6875cc5a93ad0a98e8"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 125123181,
"name": "E3SM-Project/E3SM_test_scripts",
"url": "https://api.github.com/repos/E3SM-Project/E3SM_test_scripts"
}
|
{
"id": 7882693,
"login": "jhkennedy",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7882693?",
"url": "https://api.github.com/users/jhkennedy"
}
|
{
"id": 7558558,
"login": "E3SM-Project",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7558558?",
"url": "https://api.github.com/orgs/E3SM-Project"
}
| 2019-11-04T20:32:30 |
10784219029
|
{"actor":{"display_login":"jhkennedy"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mdn/browser-compat-data/pulls/comments/318954082","pull_request_review_id":281306762,"id":318954082,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxODk1NDA4Mg==","diff_hunk":"@@ -1,4 +1,4 @@\n-{\n+ {","path":"css/selectors/is.json","position":2,"original_position":2,"commit_id":"82de1aa6684a902715c0b84c86bf6823c69764c5","original_commit_id":"82de1aa6684a902715c0b84c86bf6823c69764c5","user":{"login":"ddbeck","id":64103,"node_id":"MDQ6VXNlcjY0MTAz","avatar_url":"https://avatars2.githubusercontent.com/u/64103?v=4","gravatar_id":"","url":"https://api.github.com/users/ddbeck","html_url":"https://github.com/ddbeck","followers_url":"https://api.github.com/users/ddbeck/followers","following_url":"https://api.github.com/users/ddbeck/following{/other_user}","gists_url":"https://api.github.com/users/ddbeck/gists{/gist_id}","starred_url":"https://api.github.com/users/ddbeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddbeck/subscriptions","organizations_url":"https://api.github.com/users/ddbeck/orgs","repos_url":"https://api.github.com/users/ddbeck/repos","events_url":"https://api.github.com/users/ddbeck/events{/privacy}","received_events_url":"https://api.github.com/users/ddbeck/received_events","type":"User","site_admin":false},"body":"Spurious change?\r\n\r\n(If you really want to add some random characters here, I'm especially fond of `:wq`.)","created_at":"2019-08-29T08:46:49Z","updated_at":"2019-08-29T08:47:08Z","html_url":"https://github.com/mdn/browser-compat-data/pull/4713#discussion_r318954082","pull_request_url":"https://api.github.com/repos/mdn/browser-compat-data/pulls/4713","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mdn/browser-compat-data/pulls/comments/318954082"},"html":{"href":"https://github.com/mdn/browser-compat-data/pull/4713#discussion_r318954082"},"pull_request":{"href":"https://api.github.com/repos/mdn/browser-compat-data/pulls/4713"}}},"pull_request":{"url":"https://api.github.com/repos/mdn/browser-compat-data/pulls/4713","id":312147773,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEyMTQ3Nzcz","html_url":"https://github.com/mdn/browser-compat-data/pull/4713","diff_url":"https://github.com/mdn/browser-compat-data/pull/4713.diff","patch_url":"https://github.com/mdn/browser-compat-data/pull/4713.patch","issue_url":"https://api.github.com/repos/mdn/browser-compat-data/issues/4713","number":4713,"state":"open","locked":false,"title":"Chrome supports :is() selector since M68","user":{"login":"vinyldarkscratch","id":5179191,"node_id":"MDQ6VXNlcjUxNzkxOTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5179191?v=4","gravatar_id":"","url":"https://api.github.com/users/vinyldarkscratch","html_url":"https://github.com/vinyldarkscratch","followers_url":"https://api.github.com/users/vinyldarkscratch/followers","following_url":"https://api.github.com/users/vinyldarkscratch/following{/other_user}","gists_url":"https://api.github.com/users/vinyldarkscratch/gists{/gist_id}","starred_url":"https://api.github.com/users/vinyldarkscratch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinyldarkscratch/subscriptions","organizations_url":"https://api.github.com/users/vinyldarkscratch/orgs","repos_url":"https://api.github.com/users/vinyldarkscratch/repos","events_url":"https://api.github.com/users/vinyldarkscratch/events{/privacy}","received_events_url":"https://api.github.com/users/vinyldarkscratch/received_events","type":"User","site_admin":false},"body":"After some manual testing and playing around in various versions of Chrome upon the report from #4670, I found that Chrome implemented support for the `:is()` selector, and removed its older name a few versions later. This PR fixes #4670.","created_at":"2019-08-29T05:36:51Z","updated_at":"2019-08-29T08:47:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6f28d4cd2c696865b119c27b6164bfa0604eedd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":597839539,"node_id":"MDU6TGFiZWw1OTc4Mzk1Mzk=","url":"https://api.github.com/repos/mdn/browser-compat-data/labels/data:css%20:art:","name":"data:css :art:","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mdn/browser-compat-data/pulls/4713/commits","review_comments_url":"https://api.github.com/repos/mdn/browser-compat-data/pulls/4713/comments","review_comment_url":"https://api.github.com/repos/mdn/browser-compat-data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mdn/browser-compat-data/issues/4713/comments","statuses_url":"https://api.github.com/repos/mdn/browser-compat-data/statuses/82de1aa6684a902715c0b84c86bf6823c69764c5","head":{"label":"vinyldarkscratch:css/is-selector","ref":"css/is-selector","sha":"82de1aa6684a902715c0b84c86bf6823c69764c5","user":{"login":"vinyldarkscratch","id":5179191,"node_id":"MDQ6VXNlcjUxNzkxOTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5179191?v=4","gravatar_id":"","url":"https://api.github.com/users/vinyldarkscratch","html_url":"https://github.com/vinyldarkscratch","followers_url":"https://api.github.com/users/vinyldarkscratch/followers","following_url":"https://api.github.com/users/vinyldarkscratch/following{/other_user}","gists_url":"https://api.github.com/users/vinyldarkscratch/gists{/gist_id}","starred_url":"https://api.github.com/users/vinyldarkscratch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinyldarkscratch/subscriptions","organizations_url":"https://api.github.com/users/vinyldarkscratch/orgs","repos_url":"https://api.github.com/users/vinyldarkscratch/repos","events_url":"https://api.github.com/users/vinyldarkscratch/events{/privacy}","received_events_url":"https://api.github.com/users/vinyldarkscratch/received_events","type":"User","site_admin":false},"repo":{"id":148739061,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg3MzkwNjE=","name":"browser-compat-data","full_name":"vinyldarkscratch/browser-compat-data","private":false,"owner":{"login":"vinyldarkscratch","id":5179191,"node_id":"MDQ6VXNlcjUxNzkxOTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5179191?v=4","gravatar_id":"","url":"https://api.github.com/users/vinyldarkscratch","html_url":"https://github.com/vinyldarkscratch","followers_url":"https://api.github.com/users/vinyldarkscratch/followers","following_url":"https://api.github.com/users/vinyldarkscratch/following{/other_user}","gists_url":"https://api.github.com/users/vinyldarkscratch/gists{/gist_id}","starred_url":"https://api.github.com/users/vinyldarkscratch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinyldarkscratch/subscriptions","organizations_url":"https://api.github.com/users/vinyldarkscratch/orgs","repos_url":"https://api.github.com/users/vinyldarkscratch/repos","events_url":"https://api.github.com/users/vinyldarkscratch/events{/privacy}","received_events_url":"https://api.github.com/users/vinyldarkscratch/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vinyldarkscratch/browser-compat-data","description":"This repository contains compatibility data for Web technologies as displayed on MDN","fork":true,"url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data","forks_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/forks","keys_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/teams","hooks_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/hooks","issue_events_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/issues/events{/number}","events_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/events","assignees_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/assignees{/user}","branches_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/branches{/branch}","tags_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/tags","blobs_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/statuses/{sha}","languages_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/languages","stargazers_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/stargazers","contributors_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/contributors","subscribers_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/subscribers","subscription_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/subscription","commits_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/contents/{+path}","compare_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/merges","archive_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/downloads","issues_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/issues{/number}","pulls_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/pulls{/number}","milestones_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/milestones{/number}","notifications_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/labels{/name}","releases_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/releases{/id}","deployments_url":"https://api.github.com/repos/vinyldarkscratch/browser-compat-data/deployments","created_at":"2018-09-14T05:16:44Z","updated_at":"2019-08-29T07:25:35Z","pushed_at":"2019-08-29T07:25:33Z","git_url":"git://github.com/vinyldarkscratch/browser-compat-data.git","ssh_url":"[email protected]:vinyldarkscratch/browser-compat-data.git","clone_url":"https://github.com/vinyldarkscratch/browser-compat-data.git","svn_url":"https://github.com/vinyldarkscratch/browser-compat-data","homepage":"https://developer.mozilla.org","size":13875,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0","node_id":"MDc6TGljZW5zZTY="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mdn:master","ref":"master","sha":"fbc7d000b699fb8a786a03d53ddf838ac0bc6738","user":{"login":"mdn","id":7565578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NjU1Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7565578?v=4","gravatar_id":"","url":"https://api.github.com/users/mdn","html_url":"https://github.com/mdn","followers_url":"https://api.github.com/users/mdn/followers","following_url":"https://api.github.com/users/mdn/following{/other_user}","gists_url":"https://api.github.com/users/mdn/gists{/gist_id}","starred_url":"https://api.github.com/users/mdn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdn/subscriptions","organizations_url":"https://api.github.com/users/mdn/orgs","repos_url":"https://api.github.com/users/mdn/repos","events_url":"https://api.github.com/users/mdn/events{/privacy}","received_events_url":"https://api.github.com/users/mdn/received_events","type":"Organization","site_admin":false},"repo":{"id":55001853,"node_id":"MDEwOlJlcG9zaXRvcnk1NTAwMTg1Mw==","name":"browser-compat-data","full_name":"mdn/browser-compat-data","private":false,"owner":{"login":"mdn","id":7565578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NjU1Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7565578?v=4","gravatar_id":"","url":"https://api.github.com/users/mdn","html_url":"https://github.com/mdn","followers_url":"https://api.github.com/users/mdn/followers","following_url":"https://api.github.com/users/mdn/following{/other_user}","gists_url":"https://api.github.com/users/mdn/gists{/gist_id}","starred_url":"https://api.github.com/users/mdn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdn/subscriptions","organizations_url":"https://api.github.com/users/mdn/orgs","repos_url":"https://api.github.com/users/mdn/repos","events_url":"https://api.github.com/users/mdn/events{/privacy}","received_events_url":"https://api.github.com/users/mdn/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mdn/browser-compat-data","description":"This repository contains compatibility data for Web technologies as displayed on MDN","fork":false,"url":"https://api.github.com/repos/mdn/browser-compat-data","forks_url":"https://api.github.com/repos/mdn/browser-compat-data/forks","keys_url":"https://api.github.com/repos/mdn/browser-compat-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdn/browser-compat-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdn/browser-compat-data/teams","hooks_url":"https://api.github.com/repos/mdn/browser-compat-data/hooks","issue_events_url":"https://api.github.com/repos/mdn/browser-compat-data/issues/events{/number}","events_url":"https://api.github.com/repos/mdn/browser-compat-data/events","assignees_url":"https://api.github.com/repos/mdn/browser-compat-data/assignees{/user}","branches_url":"https://api.github.com/repos/mdn/browser-compat-data/branches{/branch}","tags_url":"https://api.github.com/repos/mdn/browser-compat-data/tags","blobs_url":"https://api.github.com/repos/mdn/browser-compat-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdn/browser-compat-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdn/browser-compat-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdn/browser-compat-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdn/browser-compat-data/statuses/{sha}","languages_url":"https://api.github.com/repos/mdn/browser-compat-data/languages","stargazers_url":"https://api.github.com/repos/mdn/browser-compat-data/stargazers","contributors_url":"https://api.github.com/repos/mdn/browser-compat-data/contributors","subscribers_url":"https://api.github.com/repos/mdn/browser-compat-data/subscribers","subscription_url":"https://api.github.com/repos/mdn/browser-compat-data/subscription","commits_url":"https://api.github.com/repos/mdn/browser-compat-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdn/browser-compat-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdn/browser-compat-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdn/browser-compat-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdn/browser-compat-data/contents/{+path}","compare_url":"https://api.github.com/repos/mdn/browser-compat-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdn/browser-compat-data/merges","archive_url":"https://api.github.com/repos/mdn/browser-compat-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdn/browser-compat-data/downloads","issues_url":"https://api.github.com/repos/mdn/browser-compat-data/issues{/number}","pulls_url":"https://api.github.com/repos/mdn/browser-compat-data/pulls{/number}","milestones_url":"https://api.github.com/repos/mdn/browser-compat-data/milestones{/number}","notifications_url":"https://api.github.com/repos/mdn/browser-compat-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdn/browser-compat-data/labels{/name}","releases_url":"https://api.github.com/repos/mdn/browser-compat-data/releases{/id}","deployments_url":"https://api.github.com/repos/mdn/browser-compat-data/deployments","created_at":"2016-03-29T18:50:07Z","updated_at":"2019-08-29T08:19:14Z","pushed_at":"2019-08-29T08:19:12Z","git_url":"git://github.com/mdn/browser-compat-data.git","ssh_url":"[email protected]:mdn/browser-compat-data.git","clone_url":"https://github.com/mdn/browser-compat-data.git","svn_url":"https://github.com/mdn/browser-compat-data","homepage":"https://developer.mozilla.org","size":12214,"stargazers_count":2113,"watchers_count":2113,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":892,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":144,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0","node_id":"MDc6TGljZW5zZTY="},"forks":892,"open_issues":144,"watchers":2113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mdn/browser-compat-data/pulls/4713"},"html":{"href":"https://github.com/mdn/browser-compat-data/pull/4713"},"issue":{"href":"https://api.github.com/repos/mdn/browser-compat-data/issues/4713"},"comments":{"href":"https://api.github.com/repos/mdn/browser-compat-data/issues/4713/comments"},"review_comments":{"href":"https://api.github.com/repos/mdn/browser-compat-data/pulls/4713/comments"},"review_comment":{"href":"https://api.github.com/repos/mdn/browser-compat-data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mdn/browser-compat-data/pulls/4713/commits"},"statuses":{"href":"https://api.github.com/repos/mdn/browser-compat-data/statuses/82de1aa6684a902715c0b84c86bf6823c69764c5"}},"author_association":"COLLABORATOR"}}
|
{
"id": 55001853,
"name": "mdn/browser-compat-data",
"url": "https://api.github.com/repos/mdn/browser-compat-data"
}
|
{
"id": 64103,
"login": "ddbeck",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/64103?",
"url": "https://api.github.com/users/ddbeck"
}
|
{
"id": 7565578,
"login": "mdn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7565578?",
"url": "https://api.github.com/orgs/mdn"
}
| 2019-08-29T09:46:49 |
10307468655
|
{"actor":{"display_login":"ddbeck"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/301348791","pull_request_review_id":259213411,"id":301348791,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMTM0ODc5MQ==","diff_hunk":"@@ -0,0 +1,263 @@\n+/*\n+ * Copyright 2004-2019 Cray Inc.\n+ * Other additional copyright holders may be indicated within.\n+ *\n+ * The entirety of this work is licensed under the Apache License,\n+ * Version 2.0 (the \"License\"); you may not use this file except\n+ * in compliance with the License.\n+ *\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+\n+use MasonUtils;\n+use Spawn;\n+use FileSystem;\n+use TOML;\n+use MasonEnv;\n+use MasonNew;\n+use MasonModify;\n+use Random;\n+\n+/* Top Level procedure that gets called from mason.chpl that takes in arguments from command line\n+Returns the help output in '-h' or '--help' exits in the arguments.\n+If --dry-run is passed then it checks to see if the package is able to be published.\n+Takes in the username of the package owner as an argument*/\n+proc masonPublish(args: [] string) throws {\n+ try! {\n+ if args.size == 4 {\n+ masonPublishHelp();\n+ exit(0);\n+ }\n+ var dry = false;\n+ var username = getUsername();\n+ if username == '' {\n+ throw new owned MasonError('Must have remote origin set up in repository to publish');\n+ }\n+ else if args.size == 3 || args.size == 2 {\n+ for arg in args[1..] {\n+ if arg == '-h' || arg == '--help' {\n+ masonPublishHelp();\n+ exit(0);\n+ }\n+ else if arg == \"--dry-run\" {\n+ dry = true;\n+ }\n+ }\n+ if doesGitOriginExist() {\n+ if dry && args.size == 3 {\n+ dryRun(username);\n+ }\n+ else if !dry && args.size == 3 {\n+ const badSyntaxMessage = 'does not meet the \"mason publish [options]\" syntax';\n+ writeln('\"' + args[0]+ ' ' + args[1] + ' ' + args[2] + badSyntaxMessage);\n+ writeln('See \"mason publish -h\" for more details');\n+ exit(0);\n+ }\n+ else if args.size == 2 {\n+ var checkResult = usernameCheck(username);\n+ if checkResult.exit_status == 0 {\n+ publishPackage(username);\n+ }\n+ else {\n+ const badUsernameError = ' is not a valid GitHub username or mason-registry is not forked \\n';\n+ const badForkError = 'Make sure you are connected to the internet before publishing.'; \n+ throw new owned MasonError(username + badUsernameError + badForkError);\n+ }\n+ }\n+ else if args.size == 4 && dry {\n+ throw new owned MasonError('Must pass your username with --dry-run');\n+ }\n+ }\n+ else {\n+ throw new owned MasonError('Must have remote origin set up in repository in order to publish.');\n+ }\n+ }\n+ else throw new owned MasonError('Usage must meet the form \"mason publish [options]\"');\n+ }\n+ catch e: MasonError {\n+ writeln(e.message());\n+ exit(1);\n+ }\n+}\n+\n+/* Main Script that goes through the act of publishing the package to the mason registry.\n+ Takes the package owners GitHub username as input will throw errors through command\n+line git commands if any of the git calls fails.*/\n+proc publishPackage(username: string) throws {\n+ const packageLocation = here.cwd();\n+ var stream = makeRandomStream(int);\n+ var uniqueDir = stream.getNext(): string;\n+ const name = getPackageName();\n+ const safeDir = (name + '-' + uniqueDir);\n+ try! {\n+ here.chdir(MASON_HOME);\n+ if !exists('tmp') then mkdir('tmp');\n+ here.chdir(MASON_HOME + '/tmp');\n+ mkdir(safeDir);\n+ here.chdir(safeDir);\n+ cloneMasonReg(username);\n+ here.chdir(packageLocation);\n+ branchMasonReg(username, name, safeDir);\n+ const package = addPackageToBricks(packageLocation, safeDir);\n+ here.chdir(MASON_HOME + \"/tmp/\" + safeDir + \"/mason-registry\");\n+ runCommand(\"git add .\");\n+ runCommand(\"git commit -m '\" + package + \"'\");\n+ runCommand('git push --set-upstream origin ' + package, true);\n+ here.chdir(MASON_HOME + '/tmp');\n+ rmTree(safeDir);\n+ writeln('--------------------------------------------------------------------');\n+ writeln('Go to the above link to open up a Pull Request to the mason-registry');\n+ }\n+ catch {\n+ here.chdir(MASON_HOME + '/tmp');\n+ rmTree(safeDir);\n+ writeln('Error publishing your package to the mason-registry');\n+ }\n+}\n+\n+/* If --dry-run is passed then it takes the username and checks to see if the mason-registry is forked\n+ and the package has a git remote origin. If both exist then the package can be published. */\n+private proc dryRun(username: string) throws {\n+ var fork = false;\n+ var remoteCheck = checkIfForkExists(username: string);\n+ if remoteCheck.exit_status == 0 {\n+ fork = true;\n+ }\n+ var git = false;\n+ if doesGitOriginExist() {\n+ git = true;\n+ }\n+ if git && fork {\n+ writeln('Package can be published to the mason-registry');\n+ writeln('Commands that will be run:');\n+ writeln('> git clone git:github.com:[username]/mason-registry mason-registry');\n+ writeln('> git checkout -b [package name]');\n+ writeln('Package Name will be added to the Bricks in the mason-registry');\n+ writeln('> git add .');\n+ writeln('> git commit -m [package name]');\n+ writeln('> git push --set-upstream origin [package name]');\n+ }\n+ else {\n+ if fork == false {\n+ throw new owned MasonError('mason-registry is not forked on your GitHub');\n+ }\n+ else {\n+ throw new owned MasonError('Package does not gave a git origin');\n+ }\n+ }\n+}\n+\n+/* Opens Spawn call to get username for the mason registry fork */\n+private proc usernameCheck(username: string) {\n+ const gitRemote = 'git ls-remote https://github/com';\n+ var usernameCheck = (gitRemote + username + '/mason-registry').split();\n+ var p = spawn(usernameCheck);\n+ p.wait();\n+ return p;\n+}\n+/* Runs Commands to see if Fork of mason-registry exists under the username */\n+private proc checkIfForkExists(username: string) {\n+ var getFork= ('git ls-remote https://github.com/' + username + '/mason-registry').split();\n+ var p = spawn(getFork, stdout=PIPE);\n+ p.wait();\n+ return p;\n+}\n+\n+/*Gets the GitHub username of the user, by parsing from the remote orgigin url. */\n+private proc getUsername() {\n+ var usernameurl = gitUrl();\n+ var tail = usernameurl.find(\"/\")-1: int;\n+ var head = usernameurl.find(\":\")+1: int;\n+ var username = usernameurl(head..tail);\n+ return username;\n+}\n+\n+/* Clones the mason registery fork from the users repo. Takes username as input. */\n+proc cloneMasonReg(username: string) throws {\n+ try! {\n+ const gitClone = 'git clone [email protected]:';\n+ var ret = runCommand(gitClone + username + \"/mason-registry mason-registry\", true);\n+ return ret;\n+ }\n+ catch {\n+ writeln('Error cloning the fork of mason-registry');\n+ writeln('Make sure you have forked the mason-registry on GitHub');\n+ exit(1);\n+ }\n+}\n+\n+/* Checks to see if 'git config --get remote.origin.url' exists */\n+proc doesGitOriginExist() {\n+ var urlExists = runCommand(\"git config --get remote.origin.url\", true);\n+ return !urlExists.isEmpty();\n+}\n+\n+/*Procedure that reutns the url of the git remote origin */\n+private proc gitUrl() {\n+ var url = runCommand(\"git config --get remote.origin.url\", true);\n+ return url;\n+}\n+\n+/* Takes the git username and creates a new branch of the mason registry users fork,\n+ name or branch is taken from the Mason.toml of the mason package.*/\n+proc branchMasonReg(username: string, name: string, safeDir: string) throws {\n+ try! {\n+ const masonReg = \"/mason-registry/\";\n+ const branchCommand = \"git checkout -b \"+ name: string;\n+ var ret = gitC(MASON_HOME + '/tmp/' + safeDir + '/mason-registry', branchCommand, true);\n+ return ret;\n+ }\n+ catch {\n+ here.chdir(MASON_HOME);\n+ rmTree(safeDir);\n+ writeln('Error branching mason-registry');\n+ exit(1);\n+ }\n+}\n+\n+/* Gets name from the Mason.toml */\n+private proc getPackageName() throws {\n+ try! {\n+ const cwd = getEnv(\"PWD\");\n+ const projectHome = getProjectHome(cwd);\n+ const toParse = open(projectHome + \"/Mason.toml\", iomode.r);\n+ var tomlFile = new owned(parseToml(toParse));\n+ const name = tomlFile['brick']['name'].s;\n+ return name;\n+ }\n+ catch {\n+ here.chdir(MASON_HOME);\n+ rmTree('/tmp');\n+ writeln('Error getting the name of your package, ensure your package is a mason project');\n+ exit(1);\n+ }\n+}\n+\n+/* Adds package to the Bricks of the mason-registry branch and then vrares the version.toml\n+ with the source url of the package's GitHub repo.*/\n+private proc addPackageToBricks(projectLocal: string, safeDir: string) : string {\n+ const toParse = open(projectLocal+ \"/Mason.toml\", iomode.r);\n+ const url = gitUrl();\n+ var tomlFile = new owned(parseToml(toParse));\n+ const packageName = tomlFile['brick']['name'].s;","path":"tools/mason/MasonPublish.chpl","position":251,"original_position":251,"commit_id":"092f847caf9da1880b4b09cfd78c0b8d146a7149","original_commit_id":"092f847caf9da1880b4b09cfd78c0b8d146a7149","user":{"login":"Spartee","id":13009163,"node_id":"MDQ6VXNlcjEzMDA5MTYz","avatar_url":"https://avatars0.githubusercontent.com/u/13009163?v=4","gravatar_id":"","url":"https://api.github.com/users/Spartee","html_url":"https://github.com/Spartee","followers_url":"https://api.github.com/users/Spartee/followers","following_url":"https://api.github.com/users/Spartee/following{/other_user}","gists_url":"https://api.github.com/users/Spartee/gists{/gist_id}","starred_url":"https://api.github.com/users/Spartee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spartee/subscriptions","organizations_url":"https://api.github.com/users/Spartee/orgs","repos_url":"https://api.github.com/users/Spartee/repos","events_url":"https://api.github.com/users/Spartee/events{/privacy}","received_events_url":"https://api.github.com/users/Spartee/received_events","type":"User","site_admin":false},"body":"getPackageName()?","created_at":"2019-07-09T00:04:36Z","updated_at":"2019-07-09T00:08:41Z","html_url":"https://github.com/chapel-lang/chapel/pull/13198#discussion_r301348791","pull_request_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/13198","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/301348791"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/13198#discussion_r301348791"},"pull_request":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/13198"}}},"pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/13198","id":285888120,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg1ODg4MTIw","html_url":"https://github.com/chapel-lang/chapel/pull/13198","diff_url":"https://github.com/chapel-lang/chapel/pull/13198.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/13198.patch","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/13198","number":13198,"state":"open","locked":false,"title":"Mason Publish Draft PR","user":{"login":"oplambeck","id":33457704,"node_id":"MDQ6VXNlcjMzNDU3NzA0","avatar_url":"https://avatars3.githubusercontent.com/u/33457704?v=4","gravatar_id":"","url":"https://api.github.com/users/oplambeck","html_url":"https://github.com/oplambeck","followers_url":"https://api.github.com/users/oplambeck/followers","following_url":"https://api.github.com/users/oplambeck/following{/other_user}","gists_url":"https://api.github.com/users/oplambeck/gists{/gist_id}","starred_url":"https://api.github.com/users/oplambeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oplambeck/subscriptions","organizations_url":"https://api.github.com/users/oplambeck/orgs","repos_url":"https://api.github.com/users/oplambeck/repos","events_url":"https://api.github.com/users/oplambeck/events{/privacy}","received_events_url":"https://api.github.com/users/oplambeck/received_events","type":"User","site_admin":false},"body":"`mason publish` early version ready for review. \r\n\r\n","created_at":"2019-06-06T16:52:15Z","updated_at":"2019-07-09T00:08:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74c46b0764c74e4c3a583b427344abbc4e436546","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/13198/commits","review_comments_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/13198/comments","review_comment_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/13198/comments","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/092f847caf9da1880b4b09cfd78c0b8d146a7149","head":{"label":"oplambeck:masonPublish","ref":"masonPublish","sha":"092f847caf9da1880b4b09cfd78c0b8d146a7149","user":{"login":"oplambeck","id":33457704,"node_id":"MDQ6VXNlcjMzNDU3NzA0","avatar_url":"https://avatars3.githubusercontent.com/u/33457704?v=4","gravatar_id":"","url":"https://api.github.com/users/oplambeck","html_url":"https://github.com/oplambeck","followers_url":"https://api.github.com/users/oplambeck/followers","following_url":"https://api.github.com/users/oplambeck/following{/other_user}","gists_url":"https://api.github.com/users/oplambeck/gists{/gist_id}","starred_url":"https://api.github.com/users/oplambeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oplambeck/subscriptions","organizations_url":"https://api.github.com/users/oplambeck/orgs","repos_url":"https://api.github.com/users/oplambeck/repos","events_url":"https://api.github.com/users/oplambeck/events{/privacy}","received_events_url":"https://api.github.com/users/oplambeck/received_events","type":"User","site_admin":false},"repo":{"id":186672653,"node_id":"MDEwOlJlcG9zaXRvcnkxODY2NzI2NTM=","name":"chapel","full_name":"oplambeck/chapel","private":false,"owner":{"login":"oplambeck","id":33457704,"node_id":"MDQ6VXNlcjMzNDU3NzA0","avatar_url":"https://avatars3.githubusercontent.com/u/33457704?v=4","gravatar_id":"","url":"https://api.github.com/users/oplambeck","html_url":"https://github.com/oplambeck","followers_url":"https://api.github.com/users/oplambeck/followers","following_url":"https://api.github.com/users/oplambeck/following{/other_user}","gists_url":"https://api.github.com/users/oplambeck/gists{/gist_id}","starred_url":"https://api.github.com/users/oplambeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oplambeck/subscriptions","organizations_url":"https://api.github.com/users/oplambeck/orgs","repos_url":"https://api.github.com/users/oplambeck/repos","events_url":"https://api.github.com/users/oplambeck/events{/privacy}","received_events_url":"https://api.github.com/users/oplambeck/received_events","type":"User","site_admin":false},"html_url":"https://github.com/oplambeck/chapel","description":"a Productive Parallel Programming Language","fork":true,"url":"https://api.github.com/repos/oplambeck/chapel","forks_url":"https://api.github.com/repos/oplambeck/chapel/forks","keys_url":"https://api.github.com/repos/oplambeck/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oplambeck/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oplambeck/chapel/teams","hooks_url":"https://api.github.com/repos/oplambeck/chapel/hooks","issue_events_url":"https://api.github.com/repos/oplambeck/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/oplambeck/chapel/events","assignees_url":"https://api.github.com/repos/oplambeck/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/oplambeck/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/oplambeck/chapel/tags","blobs_url":"https://api.github.com/repos/oplambeck/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oplambeck/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oplambeck/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/oplambeck/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oplambeck/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/oplambeck/chapel/languages","stargazers_url":"https://api.github.com/repos/oplambeck/chapel/stargazers","contributors_url":"https://api.github.com/repos/oplambeck/chapel/contributors","subscribers_url":"https://api.github.com/repos/oplambeck/chapel/subscribers","subscription_url":"https://api.github.com/repos/oplambeck/chapel/subscription","commits_url":"https://api.github.com/repos/oplambeck/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/oplambeck/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/oplambeck/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/oplambeck/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/oplambeck/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/oplambeck/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oplambeck/chapel/merges","archive_url":"https://api.github.com/repos/oplambeck/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oplambeck/chapel/downloads","issues_url":"https://api.github.com/repos/oplambeck/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/oplambeck/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/oplambeck/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/oplambeck/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oplambeck/chapel/labels{/name}","releases_url":"https://api.github.com/repos/oplambeck/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/oplambeck/chapel/deployments","created_at":"2019-05-14T17:50:34Z","updated_at":"2019-06-27T21:08:43Z","pushed_at":"2019-07-03T21:40:38Z","git_url":"git://github.com/oplambeck/chapel.git","ssh_url":"[email protected]:oplambeck/chapel.git","clone_url":"https://github.com/oplambeck/chapel.git","svn_url":"https://github.com/oplambeck/chapel","homepage":"https://chapel-lang.org","size":603566,"stargazers_count":0,"watchers_count":0,"language":"Chapel","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chapel-lang:master","ref":"master","sha":"2471cdc24e4de738c6352556139927bf4296663e","user":{"login":"chapel-lang","id":7597261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1OTcyNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/7597261?v=4","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":21663285,"node_id":"MDEwOlJlcG9zaXRvcnkyMTY2MzI4NQ==","name":"chapel","full_name":"chapel-lang/chapel","private":false,"owner":{"login":"chapel-lang","id":7597261,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1OTcyNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/7597261?v=4","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chapel-lang/chapel","description":"a Productive Parallel Programming Language","fork":false,"url":"https://api.github.com/repos/chapel-lang/chapel","forks_url":"https://api.github.com/repos/chapel-lang/chapel/forks","keys_url":"https://api.github.com/repos/chapel-lang/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapel-lang/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapel-lang/chapel/teams","hooks_url":"https://api.github.com/repos/chapel-lang/chapel/hooks","issue_events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/chapel-lang/chapel/events","assignees_url":"https://api.github.com/repos/chapel-lang/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/chapel-lang/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/chapel-lang/chapel/tags","blobs_url":"https://api.github.com/repos/chapel-lang/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapel-lang/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapel-lang/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapel-lang/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/chapel-lang/chapel/languages","stargazers_url":"https://api.github.com/repos/chapel-lang/chapel/stargazers","contributors_url":"https://api.github.com/repos/chapel-lang/chapel/contributors","subscribers_url":"https://api.github.com/repos/chapel-lang/chapel/subscribers","subscription_url":"https://api.github.com/repos/chapel-lang/chapel/subscription","commits_url":"https://api.github.com/repos/chapel-lang/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapel-lang/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapel-lang/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/chapel-lang/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapel-lang/chapel/merges","archive_url":"https://api.github.com/repos/chapel-lang/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapel-lang/chapel/downloads","issues_url":"https://api.github.com/repos/chapel-lang/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/chapel-lang/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/chapel-lang/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/chapel-lang/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapel-lang/chapel/labels{/name}","releases_url":"https://api.github.com/repos/chapel-lang/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/chapel-lang/chapel/deployments","created_at":"2014-07-09T18:15:54Z","updated_at":"2019-07-08T23:10:59Z","pushed_at":"2019-07-08T23:24:00Z","git_url":"git://github.com/chapel-lang/chapel.git","ssh_url":"[email protected]:chapel-lang/chapel.git","clone_url":"https://github.com/chapel-lang/chapel.git","svn_url":"https://github.com/chapel-lang/chapel","homepage":"https://chapel-lang.org","size":615232,"stargazers_count":874,"watchers_count":874,"language":"Chapel","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":228,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1520,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":228,"open_issues":1520,"watchers":874,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/13198"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/13198"},"issue":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/13198"},"comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/13198/comments"},"review_comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/13198/comments"},"review_comment":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/13198/commits"},"statuses":{"href":"https://api.github.com/repos/chapel-lang/chapel/statuses/092f847caf9da1880b4b09cfd78c0b8d146a7149"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 21663285,
"name": "chapel-lang/chapel",
"url": "https://api.github.com/repos/chapel-lang/chapel"
}
|
{
"id": 13009163,
"login": "Spartee",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13009163?",
"url": "https://api.github.com/users/Spartee"
}
|
{
"id": 7597261,
"login": "chapel-lang",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7597261?",
"url": "https://api.github.com/orgs/chapel-lang"
}
| 2019-07-09T00:04:36 |
9971375399
|
{"actor":{"display_login":"Spartee"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/massgov/mayflower/pulls/comments/267526042","pull_request_review_id":216956931,"id":267526042,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NzUyNjA0Mg==","diff_hunk":"@@ -0,0 +1,79 @@\n+import React from 'react';\n+import PropTypes from 'prop-types';\n+import is from 'is';\n+import deepEqual from 'fast-deep-equal';\n+import { FormContext } from '../Input/context';\n+\n+class InputSync extends React.Component {\n+ constructor(props) {\n+ super(props);\n+ this.state = {\n+ value: {},\n+ syncContent: this.syncContent,\n+ children: this.props.children,\n+ formIds: this.props.formIds\n+ };\n+ }\n+ componentDidMount() {\n+ this.checkFormContext();\n+ }\n+ checkFormContext = () => {\n+ if (this.context && this.context.isActive) {\n+ if (is.array(this.state.formIds) && !is.array.empty(this.state.formIds)) {\n+ this.state.formIds.forEach((id) => {\n+ this.linkToForm(id);\n+ });\n+ }\n+ }\n+ };\n+ linkToForm = (id) => {\n+ if (!Object.prototype.hasOwnProperty.call(this.context.value[id], 'syncContent')) {\n+ const { value } = this.context;\n+ value[id].syncContent = [];\n+ value[id].syncContent.push(this.syncContent);\n+ this.context.updateState({ value });","path":"react/src/components/atoms/forms/InputSync/index.js","position":34,"original_position":34,"commit_id":"bde5cb46ac7190e22a57cd2d07df05f2bfde6379","original_commit_id":"bde5cb46ac7190e22a57cd2d07df05f2bfde6379","user":{"login":"clairesunstudio","id":5789411,"node_id":"MDQ6VXNlcjU3ODk0MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/5789411?v=4","gravatar_id":"","url":"https://api.github.com/users/clairesunstudio","html_url":"https://github.com/clairesunstudio","followers_url":"https://api.github.com/users/clairesunstudio/followers","following_url":"https://api.github.com/users/clairesunstudio/following{/other_user}","gists_url":"https://api.github.com/users/clairesunstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/clairesunstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clairesunstudio/subscriptions","organizations_url":"https://api.github.com/users/clairesunstudio/orgs","repos_url":"https://api.github.com/users/clairesunstudio/repos","events_url":"https://api.github.com/users/clairesunstudio/events{/privacy}","received_events_url":"https://api.github.com/users/clairesunstudio/received_events","type":"User","site_admin":false},"body":"ok got it this is pushing the syncContent function array to value in formContext so that if can be used to update its own state","created_at":"2019-03-20T20:13:39Z","updated_at":"2019-03-20T20:13:39Z","html_url":"https://github.com/massgov/mayflower/pull/510#discussion_r267526042","pull_request_url":"https://api.github.com/repos/massgov/mayflower/pulls/510","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/massgov/mayflower/pulls/comments/267526042"},"html":{"href":"https://github.com/massgov/mayflower/pull/510#discussion_r267526042"},"pull_request":{"href":"https://api.github.com/repos/massgov/mayflower/pulls/510"}},"in_reply_to_id":267413608},"pull_request":{"url":"https://api.github.com/repos/massgov/mayflower/pulls/510","id":260928775,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwOTI4Nzc1","html_url":"https://github.com/massgov/mayflower/pull/510","diff_url":"https://github.com/massgov/mayflower/pull/510.diff","patch_url":"https://github.com/massgov/mayflower/pull/510.patch","issue_url":"https://api.github.com/repos/massgov/mayflower/issues/510","number":510,"state":"open","locked":false,"title":"React/dp 12935 empty divs","user":{"login":"smurrayatwork","id":5257660,"node_id":"MDQ6VXNlcjUyNTc2NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/5257660?v=4","gravatar_id":"","url":"https://api.github.com/users/smurrayatwork","html_url":"https://github.com/smurrayatwork","followers_url":"https://api.github.com/users/smurrayatwork/followers","following_url":"https://api.github.com/users/smurrayatwork/following{/other_user}","gists_url":"https://api.github.com/users/smurrayatwork/gists{/gist_id}","starred_url":"https://api.github.com/users/smurrayatwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smurrayatwork/subscriptions","organizations_url":"https://api.github.com/users/smurrayatwork/orgs","repos_url":"https://api.github.com/users/smurrayatwork/repos","events_url":"https://api.github.com/users/smurrayatwork/events{/privacy}","received_events_url":"https://api.github.com/users/smurrayatwork/received_events","type":"User","site_admin":false},"body":"<!-- Please use TICKET Description of ticket as PR title (i.e. DP-1234 Add back-to link on Announcement template) -->\r\nAny PRs being created needs a changelog.txt file before being merged into dev. See: [Change Log Instructions](https://github.com/massgov/mayflower/blob/dev/docs/change-log-instructions.md)\r\n\r\n\r\n## Description\r\n<!-- A few sentences describing the overall goals of the pull request's commits.-->\r\n\r\n## Related Issue / Ticket\r\n\r\n- [JIRA issue]()\r\n- [Github issue]()\r\n\r\n## Steps to Test\r\n<!-- Outline the steps to test or reproduce the PR here. Whenever possible deploy your branch to your fork Github Pages so UAT can be done without rebuilding. See: https://github.com/massgov/mayflower/blob/master/docs/deploy.md -->\r\n\r\n1. \r\n\r\n## Screenshots\r\nUse something like [licecap](http://www.cockos.com/licecap/) to capture gifs to demonstrate behaviors.\r\n\r\n\r\n## Additional Notes:\r\n\r\nAnything else to add?\r\n\r\n#### Impacted Areas in Application\r\n<!-- List general components of the application that this PR will affect: -->\r\n\r\n* \r\n\r\n#### @TODO\r\n<!-- List any known remaining work for this ticket / issue. -->\r\n\r\n*\r\n\r\n#### Today I learned...\r\n<!-- Did you learn anything valuable in your work for this PR that you could share with the team? You could list any relevant blogs, docs, or stack overflow posts that helped you with this work. -->\r\n","created_at":"2019-03-13T20:34:20Z","updated_at":"2019-03-20T20:13:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc876f038a5daf4fd63afc310326058997cbe208","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1037003002,"node_id":"MDU6TGFiZWwxMDM3MDAzMDAy","url":"https://api.github.com/repos/massgov/mayflower/labels/React","name":"React","color":"111f7a","default":false},{"id":988697164,"node_id":"MDU6TGFiZWw5ODg2OTcxNjQ=","url":"https://api.github.com/repos/massgov/mayflower/labels/internal%20review","name":"internal review","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/massgov/mayflower/pulls/510/commits","review_comments_url":"https://api.github.com/repos/massgov/mayflower/pulls/510/comments","review_comment_url":"https://api.github.com/repos/massgov/mayflower/pulls/comments{/number}","comments_url":"https://api.github.com/repos/massgov/mayflower/issues/510/comments","statuses_url":"https://api.github.com/repos/massgov/mayflower/statuses/bde5cb46ac7190e22a57cd2d07df05f2bfde6379","head":{"label":"massgov:react/DP-12935--empty-divs","ref":"react/DP-12935--empty-divs","sha":"bde5cb46ac7190e22a57cd2d07df05f2bfde6379","user":{"login":"massgov","id":7770800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3NzA4MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7770800?v=4","gravatar_id":"","url":"https://api.github.com/users/massgov","html_url":"https://github.com/massgov","followers_url":"https://api.github.com/users/massgov/followers","following_url":"https://api.github.com/users/massgov/following{/other_user}","gists_url":"https://api.github.com/users/massgov/gists{/gist_id}","starred_url":"https://api.github.com/users/massgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massgov/subscriptions","organizations_url":"https://api.github.com/users/massgov/orgs","repos_url":"https://api.github.com/users/massgov/repos","events_url":"https://api.github.com/users/massgov/events{/privacy}","received_events_url":"https://api.github.com/users/massgov/received_events","type":"Organization","site_admin":false},"repo":{"id":137521197,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1MjExOTc=","name":"mayflower","full_name":"massgov/mayflower","private":false,"owner":{"login":"massgov","id":7770800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3NzA4MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7770800?v=4","gravatar_id":"","url":"https://api.github.com/users/massgov","html_url":"https://github.com/massgov","followers_url":"https://api.github.com/users/massgov/followers","following_url":"https://api.github.com/users/massgov/following{/other_user}","gists_url":"https://api.github.com/users/massgov/gists{/gist_id}","starred_url":"https://api.github.com/users/massgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massgov/subscriptions","organizations_url":"https://api.github.com/users/massgov/orgs","repos_url":"https://api.github.com/users/massgov/repos","events_url":"https://api.github.com/users/massgov/events{/privacy}","received_events_url":"https://api.github.com/users/massgov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/massgov/mayflower","description":"Mayflower Mono Repo (react and pattern lab and documentation)","fork":false,"url":"https://api.github.com/repos/massgov/mayflower","forks_url":"https://api.github.com/repos/massgov/mayflower/forks","keys_url":"https://api.github.com/repos/massgov/mayflower/keys{/key_id}","collaborators_url":"https://api.github.com/repos/massgov/mayflower/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/massgov/mayflower/teams","hooks_url":"https://api.github.com/repos/massgov/mayflower/hooks","issue_events_url":"https://api.github.com/repos/massgov/mayflower/issues/events{/number}","events_url":"https://api.github.com/repos/massgov/mayflower/events","assignees_url":"https://api.github.com/repos/massgov/mayflower/assignees{/user}","branches_url":"https://api.github.com/repos/massgov/mayflower/branches{/branch}","tags_url":"https://api.github.com/repos/massgov/mayflower/tags","blobs_url":"https://api.github.com/repos/massgov/mayflower/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/massgov/mayflower/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/massgov/mayflower/git/refs{/sha}","trees_url":"https://api.github.com/repos/massgov/mayflower/git/trees{/sha}","statuses_url":"https://api.github.com/repos/massgov/mayflower/statuses/{sha}","languages_url":"https://api.github.com/repos/massgov/mayflower/languages","stargazers_url":"https://api.github.com/repos/massgov/mayflower/stargazers","contributors_url":"https://api.github.com/repos/massgov/mayflower/contributors","subscribers_url":"https://api.github.com/repos/massgov/mayflower/subscribers","subscription_url":"https://api.github.com/repos/massgov/mayflower/subscription","commits_url":"https://api.github.com/repos/massgov/mayflower/commits{/sha}","git_commits_url":"https://api.github.com/repos/massgov/mayflower/git/commits{/sha}","comments_url":"https://api.github.com/repos/massgov/mayflower/comments{/number}","issue_comment_url":"https://api.github.com/repos/massgov/mayflower/issues/comments{/number}","contents_url":"https://api.github.com/repos/massgov/mayflower/contents/{+path}","compare_url":"https://api.github.com/repos/massgov/mayflower/compare/{base}...{head}","merges_url":"https://api.github.com/repos/massgov/mayflower/merges","archive_url":"https://api.github.com/repos/massgov/mayflower/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/massgov/mayflower/downloads","issues_url":"https://api.github.com/repos/massgov/mayflower/issues{/number}","pulls_url":"https://api.github.com/repos/massgov/mayflower/pulls{/number}","milestones_url":"https://api.github.com/repos/massgov/mayflower/milestones{/number}","notifications_url":"https://api.github.com/repos/massgov/mayflower/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/massgov/mayflower/labels{/name}","releases_url":"https://api.github.com/repos/massgov/mayflower/releases{/id}","deployments_url":"https://api.github.com/repos/massgov/mayflower/deployments","created_at":"2018-06-15T18:43:35Z","updated_at":"2019-03-20T14:25:27Z","pushed_at":"2019-03-20T18:59:11Z","git_url":"git://github.com/massgov/mayflower.git","ssh_url":"[email protected]:massgov/mayflower.git","clone_url":"https://github.com/massgov/mayflower.git","svn_url":"https://github.com/massgov/mayflower","homepage":"","size":789111,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":7,"open_issues":59,"watchers":8,"default_branch":"develop"}},"base":{"label":"massgov:develop","ref":"develop","sha":"d639062cf46002242a04304ec0987800abfc8bb2","user":{"login":"massgov","id":7770800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3NzA4MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7770800?v=4","gravatar_id":"","url":"https://api.github.com/users/massgov","html_url":"https://github.com/massgov","followers_url":"https://api.github.com/users/massgov/followers","following_url":"https://api.github.com/users/massgov/following{/other_user}","gists_url":"https://api.github.com/users/massgov/gists{/gist_id}","starred_url":"https://api.github.com/users/massgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massgov/subscriptions","organizations_url":"https://api.github.com/users/massgov/orgs","repos_url":"https://api.github.com/users/massgov/repos","events_url":"https://api.github.com/users/massgov/events{/privacy}","received_events_url":"https://api.github.com/users/massgov/received_events","type":"Organization","site_admin":false},"repo":{"id":137521197,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1MjExOTc=","name":"mayflower","full_name":"massgov/mayflower","private":false,"owner":{"login":"massgov","id":7770800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3NzA4MDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7770800?v=4","gravatar_id":"","url":"https://api.github.com/users/massgov","html_url":"https://github.com/massgov","followers_url":"https://api.github.com/users/massgov/followers","following_url":"https://api.github.com/users/massgov/following{/other_user}","gists_url":"https://api.github.com/users/massgov/gists{/gist_id}","starred_url":"https://api.github.com/users/massgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/massgov/subscriptions","organizations_url":"https://api.github.com/users/massgov/orgs","repos_url":"https://api.github.com/users/massgov/repos","events_url":"https://api.github.com/users/massgov/events{/privacy}","received_events_url":"https://api.github.com/users/massgov/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/massgov/mayflower","description":"Mayflower Mono Repo (react and pattern lab and documentation)","fork":false,"url":"https://api.github.com/repos/massgov/mayflower","forks_url":"https://api.github.com/repos/massgov/mayflower/forks","keys_url":"https://api.github.com/repos/massgov/mayflower/keys{/key_id}","collaborators_url":"https://api.github.com/repos/massgov/mayflower/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/massgov/mayflower/teams","hooks_url":"https://api.github.com/repos/massgov/mayflower/hooks","issue_events_url":"https://api.github.com/repos/massgov/mayflower/issues/events{/number}","events_url":"https://api.github.com/repos/massgov/mayflower/events","assignees_url":"https://api.github.com/repos/massgov/mayflower/assignees{/user}","branches_url":"https://api.github.com/repos/massgov/mayflower/branches{/branch}","tags_url":"https://api.github.com/repos/massgov/mayflower/tags","blobs_url":"https://api.github.com/repos/massgov/mayflower/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/massgov/mayflower/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/massgov/mayflower/git/refs{/sha}","trees_url":"https://api.github.com/repos/massgov/mayflower/git/trees{/sha}","statuses_url":"https://api.github.com/repos/massgov/mayflower/statuses/{sha}","languages_url":"https://api.github.com/repos/massgov/mayflower/languages","stargazers_url":"https://api.github.com/repos/massgov/mayflower/stargazers","contributors_url":"https://api.github.com/repos/massgov/mayflower/contributors","subscribers_url":"https://api.github.com/repos/massgov/mayflower/subscribers","subscription_url":"https://api.github.com/repos/massgov/mayflower/subscription","commits_url":"https://api.github.com/repos/massgov/mayflower/commits{/sha}","git_commits_url":"https://api.github.com/repos/massgov/mayflower/git/commits{/sha}","comments_url":"https://api.github.com/repos/massgov/mayflower/comments{/number}","issue_comment_url":"https://api.github.com/repos/massgov/mayflower/issues/comments{/number}","contents_url":"https://api.github.com/repos/massgov/mayflower/contents/{+path}","compare_url":"https://api.github.com/repos/massgov/mayflower/compare/{base}...{head}","merges_url":"https://api.github.com/repos/massgov/mayflower/merges","archive_url":"https://api.github.com/repos/massgov/mayflower/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/massgov/mayflower/downloads","issues_url":"https://api.github.com/repos/massgov/mayflower/issues{/number}","pulls_url":"https://api.github.com/repos/massgov/mayflower/pulls{/number}","milestones_url":"https://api.github.com/repos/massgov/mayflower/milestones{/number}","notifications_url":"https://api.github.com/repos/massgov/mayflower/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/massgov/mayflower/labels{/name}","releases_url":"https://api.github.com/repos/massgov/mayflower/releases{/id}","deployments_url":"https://api.github.com/repos/massgov/mayflower/deployments","created_at":"2018-06-15T18:43:35Z","updated_at":"2019-03-20T14:25:27Z","pushed_at":"2019-03-20T18:59:11Z","git_url":"git://github.com/massgov/mayflower.git","ssh_url":"[email protected]:massgov/mayflower.git","clone_url":"https://github.com/massgov/mayflower.git","svn_url":"https://github.com/massgov/mayflower","homepage":"","size":789111,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":7,"open_issues":59,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/massgov/mayflower/pulls/510"},"html":{"href":"https://github.com/massgov/mayflower/pull/510"},"issue":{"href":"https://api.github.com/repos/massgov/mayflower/issues/510"},"comments":{"href":"https://api.github.com/repos/massgov/mayflower/issues/510/comments"},"review_comments":{"href":"https://api.github.com/repos/massgov/mayflower/pulls/510/comments"},"review_comment":{"href":"https://api.github.com/repos/massgov/mayflower/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/massgov/mayflower/pulls/510/commits"},"statuses":{"href":"https://api.github.com/repos/massgov/mayflower/statuses/bde5cb46ac7190e22a57cd2d07df05f2bfde6379"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 137521197,
"name": "massgov/mayflower",
"url": "https://api.github.com/repos/massgov/mayflower"
}
|
{
"id": 5789411,
"login": "clairesunstudio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/5789411?",
"url": "https://api.github.com/users/clairesunstudio"
}
|
{
"id": 7770800,
"login": "massgov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7770800?",
"url": "https://api.github.com/orgs/massgov"
}
| 2019-03-20T20:13:39 |
9282923910
|
{"actor":{"display_login":"clairesunstudio"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/proposal/pulls/comments/297809834","pull_request_review_id":254799257,"id":297809834,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5NzgwOTgzNA==","diff_hunk":"@@ -55,9 +55,13 @@ determine which choice will be selected by a given client:\n // \"python\", etc). Each string is case insensitive.\n \"clientLanguage\": [string],\n // Percentage: integer from 0 to 100 indicating the percentage of\n- // clients that should use this choice. If present, the number must\n- // match the regular expression `^0|[0-9]|[1-9][0-9]|100$`\n- // All other numbers are considered invalid.\n+ // clients that should use this choice. Each client's resolver should","path":"A2-service-configs-in-dns.md","position":7,"original_position":7,"commit_id":"faae1ae75028ed26f909ce7349d110b382af9a25","original_commit_id":"faae1ae75028ed26f909ce7349d110b382af9a25","user":{"login":"carl-mastrangelo","id":8943572,"node_id":"MDQ6VXNlcjg5NDM1NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/8943572?v=4","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"body":"Just to be clear: If the channel goes into idle mode, shuts down the resolver, and then comes back out of idle, it is allowed to re-roll, since it could be a new name resolver instance?","created_at":"2019-06-26T18:33:18Z","updated_at":"2019-06-26T18:33:29Z","html_url":"https://github.com/grpc/proposal/pull/152#discussion_r297809834","pull_request_url":"https://api.github.com/repos/grpc/proposal/pulls/152","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/grpc/proposal/pulls/comments/297809834"},"html":{"href":"https://github.com/grpc/proposal/pull/152#discussion_r297809834"},"pull_request":{"href":"https://api.github.com/repos/grpc/proposal/pulls/152"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/proposal/pulls/152","id":291669044,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxNjY5MDQ0","html_url":"https://github.com/grpc/proposal/pull/152","diff_url":"https://github.com/grpc/proposal/pull/152.diff","patch_url":"https://github.com/grpc/proposal/pull/152.patch","issue_url":"https://api.github.com/repos/grpc/proposal/issues/152","number":152,"state":"open","locked":false,"title":"Clarify specification of percentage selector in service configs in DNS.","user":{"login":"markdroth","id":18664614,"node_id":"MDQ6VXNlcjE4NjY0NjE0","avatar_url":"https://avatars2.githubusercontent.com/u/18664614?v=4","gravatar_id":"","url":"https://api.github.com/users/markdroth","html_url":"https://github.com/markdroth","followers_url":"https://api.github.com/users/markdroth/followers","following_url":"https://api.github.com/users/markdroth/following{/other_user}","gists_url":"https://api.github.com/users/markdroth/gists{/gist_id}","starred_url":"https://api.github.com/users/markdroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdroth/subscriptions","organizations_url":"https://api.github.com/users/markdroth/orgs","repos_url":"https://api.github.com/users/markdroth/repos","events_url":"https://api.github.com/users/markdroth/events{/privacy}","received_events_url":"https://api.github.com/users/markdroth/received_events","type":"User","site_admin":false},"body":"It looks like our current implementations are all doing the wrong thing with the percentage selector: we are actually recomputing the client's random percentage for each choice we evaluate when parsing the service config choices, which means (a) we may not have a consistent value when there are multiple choices with different percentage values and (b) even worse, we will recompute the percentage every time the resolver re-resolves, which means we will wind up switching configs whenever (e.g.) a subchannel becomes disconnected.\r\n\r\nI am proposing that the client compute its percentage at resolver startup and retain it for the lifetime of the resolver. This means that if a client starts up and computes a low percentage for itself, it will wind up being an early canary, but I think that's okay.\r\n\r\nThe alternative would be to have the resolver check whether the service config has changed since the last resolution and recompute the client's percentage only if it has changed. However, this would actually make it harder to understand what's happening when the service owner is canarying changes, because it would be much harder to identify which clients are getting the canary config.","created_at":"2019-06-25T17:59:04Z","updated_at":"2019-06-26T18:33:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9f43441bfcde15412dfbb644e65e0c0af547955","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lyuxuan","id":426013,"node_id":"MDQ6VXNlcjQyNjAxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/426013?v=4","gravatar_id":"","url":"https://api.github.com/users/lyuxuan","html_url":"https://github.com/lyuxuan","followers_url":"https://api.github.com/users/lyuxuan/followers","following_url":"https://api.github.com/users/lyuxuan/following{/other_user}","gists_url":"https://api.github.com/users/lyuxuan/gists{/gist_id}","starred_url":"https://api.github.com/users/lyuxuan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyuxuan/subscriptions","organizations_url":"https://api.github.com/users/lyuxuan/orgs","repos_url":"https://api.github.com/users/lyuxuan/repos","events_url":"https://api.github.com/users/lyuxuan/events{/privacy}","received_events_url":"https://api.github.com/users/lyuxuan/received_events","type":"User","site_admin":false},{"login":"ejona86","id":2811396,"node_id":"MDQ6VXNlcjI4MTEzOTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2811396?v=4","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false},{"login":"apolcyn","id":9566254,"node_id":"MDQ6VXNlcjk1NjYyNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9566254?v=4","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/proposal/pulls/152/commits","review_comments_url":"https://api.github.com/repos/grpc/proposal/pulls/152/comments","review_comment_url":"https://api.github.com/repos/grpc/proposal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/proposal/issues/152/comments","statuses_url":"https://api.github.com/repos/grpc/proposal/statuses/faae1ae75028ed26f909ce7349d110b382af9a25","head":{"label":"markdroth:service_config_in_dns_percentage_update","ref":"service_config_in_dns_percentage_update","sha":"faae1ae75028ed26f909ce7349d110b382af9a25","user":{"login":"markdroth","id":18664614,"node_id":"MDQ6VXNlcjE4NjY0NjE0","avatar_url":"https://avatars2.githubusercontent.com/u/18664614?v=4","gravatar_id":"","url":"https://api.github.com/users/markdroth","html_url":"https://github.com/markdroth","followers_url":"https://api.github.com/users/markdroth/followers","following_url":"https://api.github.com/users/markdroth/following{/other_user}","gists_url":"https://api.github.com/users/markdroth/gists{/gist_id}","starred_url":"https://api.github.com/users/markdroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdroth/subscriptions","organizations_url":"https://api.github.com/users/markdroth/orgs","repos_url":"https://api.github.com/users/markdroth/repos","events_url":"https://api.github.com/users/markdroth/events{/privacy}","received_events_url":"https://api.github.com/users/markdroth/received_events","type":"User","site_admin":false},"repo":{"id":79382943,"node_id":"MDEwOlJlcG9zaXRvcnk3OTM4Mjk0Mw==","name":"proposal","full_name":"markdroth/proposal","private":false,"owner":{"login":"markdroth","id":18664614,"node_id":"MDQ6VXNlcjE4NjY0NjE0","avatar_url":"https://avatars2.githubusercontent.com/u/18664614?v=4","gravatar_id":"","url":"https://api.github.com/users/markdroth","html_url":"https://github.com/markdroth","followers_url":"https://api.github.com/users/markdroth/followers","following_url":"https://api.github.com/users/markdroth/following{/other_user}","gists_url":"https://api.github.com/users/markdroth/gists{/gist_id}","starred_url":"https://api.github.com/users/markdroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdroth/subscriptions","organizations_url":"https://api.github.com/users/markdroth/orgs","repos_url":"https://api.github.com/users/markdroth/repos","events_url":"https://api.github.com/users/markdroth/events{/privacy}","received_events_url":"https://api.github.com/users/markdroth/received_events","type":"User","site_admin":false},"html_url":"https://github.com/markdroth/proposal","description":"A repository for gRFCs ","fork":true,"url":"https://api.github.com/repos/markdroth/proposal","forks_url":"https://api.github.com/repos/markdroth/proposal/forks","keys_url":"https://api.github.com/repos/markdroth/proposal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/markdroth/proposal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/markdroth/proposal/teams","hooks_url":"https://api.github.com/repos/markdroth/proposal/hooks","issue_events_url":"https://api.github.com/repos/markdroth/proposal/issues/events{/number}","events_url":"https://api.github.com/repos/markdroth/proposal/events","assignees_url":"https://api.github.com/repos/markdroth/proposal/assignees{/user}","branches_url":"https://api.github.com/repos/markdroth/proposal/branches{/branch}","tags_url":"https://api.github.com/repos/markdroth/proposal/tags","blobs_url":"https://api.github.com/repos/markdroth/proposal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/markdroth/proposal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/markdroth/proposal/git/refs{/sha}","trees_url":"https://api.github.com/repos/markdroth/proposal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/markdroth/proposal/statuses/{sha}","languages_url":"https://api.github.com/repos/markdroth/proposal/languages","stargazers_url":"https://api.github.com/repos/markdroth/proposal/stargazers","contributors_url":"https://api.github.com/repos/markdroth/proposal/contributors","subscribers_url":"https://api.github.com/repos/markdroth/proposal/subscribers","subscription_url":"https://api.github.com/repos/markdroth/proposal/subscription","commits_url":"https://api.github.com/repos/markdroth/proposal/commits{/sha}","git_commits_url":"https://api.github.com/repos/markdroth/proposal/git/commits{/sha}","comments_url":"https://api.github.com/repos/markdroth/proposal/comments{/number}","issue_comment_url":"https://api.github.com/repos/markdroth/proposal/issues/comments{/number}","contents_url":"https://api.github.com/repos/markdroth/proposal/contents/{+path}","compare_url":"https://api.github.com/repos/markdroth/proposal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/markdroth/proposal/merges","archive_url":"https://api.github.com/repos/markdroth/proposal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/markdroth/proposal/downloads","issues_url":"https://api.github.com/repos/markdroth/proposal/issues{/number}","pulls_url":"https://api.github.com/repos/markdroth/proposal/pulls{/number}","milestones_url":"https://api.github.com/repos/markdroth/proposal/milestones{/number}","notifications_url":"https://api.github.com/repos/markdroth/proposal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/markdroth/proposal/labels{/name}","releases_url":"https://api.github.com/repos/markdroth/proposal/releases{/id}","deployments_url":"https://api.github.com/repos/markdroth/proposal/deployments","created_at":"2017-01-18T20:50:08Z","updated_at":"2017-01-15T10:50:14Z","pushed_at":"2019-06-26T16:59:57Z","git_url":"git://github.com/markdroth/proposal.git","ssh_url":"[email protected]:markdroth/proposal.git","clone_url":"https://github.com/markdroth/proposal.git","svn_url":"https://github.com/markdroth/proposal","homepage":null,"size":1013,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"0e652e60e97aecd3f9a2e764771157e37bd2c962","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":78234185,"node_id":"MDEwOlJlcG9zaXRvcnk3ODIzNDE4NQ==","name":"proposal","full_name":"grpc/proposal","private":false,"owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/grpc/proposal","description":"A repository for gRFCs ","fork":false,"url":"https://api.github.com/repos/grpc/proposal","forks_url":"https://api.github.com/repos/grpc/proposal/forks","keys_url":"https://api.github.com/repos/grpc/proposal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/proposal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/proposal/teams","hooks_url":"https://api.github.com/repos/grpc/proposal/hooks","issue_events_url":"https://api.github.com/repos/grpc/proposal/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/proposal/events","assignees_url":"https://api.github.com/repos/grpc/proposal/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/proposal/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/proposal/tags","blobs_url":"https://api.github.com/repos/grpc/proposal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/proposal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/proposal/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/proposal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/proposal/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/proposal/languages","stargazers_url":"https://api.github.com/repos/grpc/proposal/stargazers","contributors_url":"https://api.github.com/repos/grpc/proposal/contributors","subscribers_url":"https://api.github.com/repos/grpc/proposal/subscribers","subscription_url":"https://api.github.com/repos/grpc/proposal/subscription","commits_url":"https://api.github.com/repos/grpc/proposal/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/proposal/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/proposal/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/proposal/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/proposal/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/proposal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/proposal/merges","archive_url":"https://api.github.com/repos/grpc/proposal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/proposal/downloads","issues_url":"https://api.github.com/repos/grpc/proposal/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/proposal/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/proposal/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/proposal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/proposal/labels{/name}","releases_url":"https://api.github.com/repos/grpc/proposal/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/proposal/deployments","created_at":"2017-01-06T19:51:09Z","updated_at":"2019-06-25T09:47:50Z","pushed_at":"2019-06-26T16:59:58Z","git_url":"git://github.com/grpc/proposal.git","ssh_url":"[email protected]:grpc/proposal.git","clone_url":"https://github.com/grpc/proposal.git","svn_url":"https://github.com/grpc/proposal","homepage":null,"size":1064,"stargazers_count":177,"watchers_count":177,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":67,"open_issues":21,"watchers":177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/proposal/pulls/152"},"html":{"href":"https://github.com/grpc/proposal/pull/152"},"issue":{"href":"https://api.github.com/repos/grpc/proposal/issues/152"},"comments":{"href":"https://api.github.com/repos/grpc/proposal/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/proposal/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/proposal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/proposal/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/proposal/statuses/faae1ae75028ed26f909ce7349d110b382af9a25"}},"author_association":"MEMBER"}}
|
{
"id": 78234185,
"name": "grpc/proposal",
"url": "https://api.github.com/repos/grpc/proposal"
}
|
{
"id": 8943572,
"login": "carl-mastrangelo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8943572?",
"url": "https://api.github.com/users/carl-mastrangelo"
}
|
{
"id": 7802525,
"login": "grpc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7802525?",
"url": "https://api.github.com/orgs/grpc"
}
| 2019-06-26T18:33:18 |
9900213509
|
{"actor":{"display_login":"carl-mastrangelo"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc/pulls/comments/307947494","pull_request_review_id":267449281,"id":307947494,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNzk0NzQ5NA==","diff_hunk":"@@ -0,0 +1,387 @@\n+/*\n+ *\n+ * Copyright 2019 gRPC authors.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ *\n+ */\n+\n+#include <benchmark/benchmark.h>\n+#include <grpc/grpc.h>\n+\n+#include <condition_variable>\n+#include <mutex>\n+\n+#include \"src/core/lib/iomgr/executor/threadpool.h\"\n+#include \"test/cpp/microbenchmarks/helpers.h\"\n+#include \"test/cpp/util/test_config.h\"\n+\n+namespace grpc {\n+namespace testing {\n+\n+// This helper class allows a thread to block for a pre-specified number of\n+// actions. BlockingCounter has an initial non-negative count on initialization.\n+// Each call to DecrementCount will decrease the count by 1. When making a call\n+// to Wait, if the count is greater than 0, the thread will be blocked, until\n+// the count reaches 0.\n+class BlockingCounter {\n+ public:\n+ BlockingCounter(int count) : count_(count) {}\n+ void DecrementCount() {\n+ std::lock_guard<std::mutex> l(mu_);\n+ count_--;\n+ if (count_ == 0) cv_.notify_all();\n+ }\n+\n+ void Wait() {\n+ std::unique_lock<std::mutex> l(mu_);\n+ while (count_ > 0) {\n+ cv_.wait(l);\n+ }\n+ }\n+\n+ private:\n+ int count_;\n+ std::mutex mu_;\n+ std::condition_variable cv_;\n+};\n+\n+// This is a functor/closure class for threadpool microbenchmark.\n+// This functor (closure) class will add another functor into pool if the\n+// number passed in (num_add) is greater than 0. Otherwise, it will decrement\n+// the counter to indicate that task is finished. This functor will suicide at\n+// the end, therefore, no need for caller to do clean-ups.\n+class AddAnotherFunctor : public grpc_experimental_completion_queue_functor {\n+ public:\n+ AddAnotherFunctor(grpc_core::ThreadPool* pool, BlockingCounter* counter,\n+ int num_add)\n+ : pool_(pool), counter_(counter), num_add_(num_add) {\n+ functor_run = &AddAnotherFunctor::Run;\n+ internal_next = this;\n+ internal_success = 0;\n+ }\n+ // When the functor gets to run in thread pool, it will take itself as first\n+ // argument and internal_success as second one.\n+ static void Run(grpc_experimental_completion_queue_functor* cb, int ok) {\n+ auto* callback = static_cast<AddAnotherFunctor*>(cb);\n+ if (--callback->num_add_ > 0) {\n+ callback->pool_->Add(new AddAnotherFunctor(\n+ callback->pool_, callback->counter_, callback->num_add_));\n+ } else {\n+ callback->counter_->DecrementCount();\n+ }\n+ // Suicides.\n+ delete callback;\n+ }\n+\n+ private:\n+ grpc_core::ThreadPool* pool_;\n+ BlockingCounter* counter_;\n+ int num_add_;\n+};\n+\n+void ThreadPoolAddAnotherHelper(benchmark::State& state,\n+ int concurrent_functor) {\n+ const int num_iterations = state.range(0);\n+ const int num_threads = state.range(1);\n+ // Number of adds done by each closure.\n+ const int num_add = num_iterations / concurrent_functor;\n+ grpc_core::ThreadPool pool(num_threads);\n+ while (state.KeepRunningBatch(num_iterations)) {\n+ BlockingCounter counter(concurrent_functor);\n+ for (int i = 0; i < concurrent_functor; ++i) {\n+ pool.Add(new AddAnotherFunctor(&pool, &counter, num_add));\n+ }\n+ counter.Wait();\n+ }\n+ state.SetItemsProcessed(state.iterations());\n+}\n+\n+static void BM_ThreadPool1AddAnother(benchmark::State& state) {","path":"test/cpp/microbenchmarks/bm_threadpool.cc","position":110,"original_position":110,"commit_id":"d87b5285cab2959c65e8dc0ec6df120f3be3b1c3","original_commit_id":"d87b5285cab2959c65e8dc0ec6df120f3be3b1c3","user":{"login":"dklempner","id":10135909,"node_id":"MDQ6VXNlcjEwMTM1OTA5","avatar_url":"https://avatars2.githubusercontent.com/u/10135909?v=4","gravatar_id":"","url":"https://api.github.com/users/dklempner","html_url":"https://github.com/dklempner","followers_url":"https://api.github.com/users/dklempner/followers","following_url":"https://api.github.com/users/dklempner/following{/other_user}","gists_url":"https://api.github.com/users/dklempner/gists{/gist_id}","starred_url":"https://api.github.com/users/dklempner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dklempner/subscriptions","organizations_url":"https://api.github.com/users/dklempner/orgs","repos_url":"https://api.github.com/users/dklempner/repos","events_url":"https://api.github.com/users/dklempner/events{/privacy}","received_events_url":"https://api.github.com/users/dklempner/received_events","type":"User","site_admin":false},"body":"Does the BENCHMARK macro work with templates? This would be a natural usecase for them.","created_at":"2019-07-27T01:19:17Z","updated_at":"2019-07-27T01:22:54Z","html_url":"https://github.com/grpc/grpc/pull/19695#discussion_r307947494","pull_request_url":"https://api.github.com/repos/grpc/grpc/pulls/19695","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments/307947494"},"html":{"href":"https://github.com/grpc/grpc/pull/19695#discussion_r307947494"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc/pulls/19695"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/19695","id":299418309,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk5NDE4MzA5","html_url":"https://github.com/grpc/grpc/pull/19695","diff_url":"https://github.com/grpc/grpc/pull/19695.diff","patch_url":"https://github.com/grpc/grpc/pull/19695.patch","issue_url":"https://api.github.com/repos/grpc/grpc/issues/19695","number":19695,"state":"open","locked":false,"title":"Add threadpool benchmark and build files","user":{"login":"yunjiaw26","id":50971092,"node_id":"MDQ6VXNlcjUwOTcxMDky","avatar_url":"https://avatars1.githubusercontent.com/u/50971092?v=4","gravatar_id":"","url":"https://api.github.com/users/yunjiaw26","html_url":"https://github.com/yunjiaw26","followers_url":"https://api.github.com/users/yunjiaw26/followers","following_url":"https://api.github.com/users/yunjiaw26/following{/other_user}","gists_url":"https://api.github.com/users/yunjiaw26/gists{/gist_id}","starred_url":"https://api.github.com/users/yunjiaw26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunjiaw26/subscriptions","organizations_url":"https://api.github.com/users/yunjiaw26/orgs","repos_url":"https://api.github.com/users/yunjiaw26/repos","events_url":"https://api.github.com/users/yunjiaw26/events{/privacy}","received_events_url":"https://api.github.com/users/yunjiaw26/received_events","type":"User","site_admin":false},"body":"Add ThreadPool microbenchmark and build files.","created_at":"2019-07-19T17:24:45Z","updated_at":"2019-07-27T01:22:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85bf27b244d6be71bcf65f03b18e8e840d2c0ef0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":218696181,"node_id":"MDU6TGFiZWwyMTg2OTYxODE=","url":"https://api.github.com/repos/grpc/grpc/labels/lang/core","name":"lang/core","color":"fad8c7","default":false},{"id":961832073,"node_id":"MDU6TGFiZWw5NjE4MzIwNzM=","url":"https://api.github.com/repos/grpc/grpc/labels/release%20notes:%20no","name":"release notes: no","color":"0f5f75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc/pulls/19695/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc/pulls/19695/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/19695/comments","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/d87b5285cab2959c65e8dc0ec6df120f3be3b1c3","head":{"label":"yunjiaw26:bm_threadpool","ref":"bm_threadpool","sha":"d87b5285cab2959c65e8dc0ec6df120f3be3b1c3","user":{"login":"yunjiaw26","id":50971092,"node_id":"MDQ6VXNlcjUwOTcxMDky","avatar_url":"https://avatars1.githubusercontent.com/u/50971092?v=4","gravatar_id":"","url":"https://api.github.com/users/yunjiaw26","html_url":"https://github.com/yunjiaw26","followers_url":"https://api.github.com/users/yunjiaw26/followers","following_url":"https://api.github.com/users/yunjiaw26/following{/other_user}","gists_url":"https://api.github.com/users/yunjiaw26/gists{/gist_id}","starred_url":"https://api.github.com/users/yunjiaw26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunjiaw26/subscriptions","organizations_url":"https://api.github.com/users/yunjiaw26/orgs","repos_url":"https://api.github.com/users/yunjiaw26/repos","events_url":"https://api.github.com/users/yunjiaw26/events{/privacy}","received_events_url":"https://api.github.com/users/yunjiaw26/received_events","type":"User","site_admin":false},"repo":{"id":191651294,"node_id":"MDEwOlJlcG9zaXRvcnkxOTE2NTEyOTQ=","name":"grpc","full_name":"yunjiaw26/grpc","private":false,"owner":{"login":"yunjiaw26","id":50971092,"node_id":"MDQ6VXNlcjUwOTcxMDky","avatar_url":"https://avatars1.githubusercontent.com/u/50971092?v=4","gravatar_id":"","url":"https://api.github.com/users/yunjiaw26","html_url":"https://github.com/yunjiaw26","followers_url":"https://api.github.com/users/yunjiaw26/followers","following_url":"https://api.github.com/users/yunjiaw26/following{/other_user}","gists_url":"https://api.github.com/users/yunjiaw26/gists{/gist_id}","starred_url":"https://api.github.com/users/yunjiaw26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunjiaw26/subscriptions","organizations_url":"https://api.github.com/users/yunjiaw26/orgs","repos_url":"https://api.github.com/users/yunjiaw26/repos","events_url":"https://api.github.com/users/yunjiaw26/events{/privacy}","received_events_url":"https://api.github.com/users/yunjiaw26/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yunjiaw26/grpc","description":"The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#)","fork":true,"url":"https://api.github.com/repos/yunjiaw26/grpc","forks_url":"https://api.github.com/repos/yunjiaw26/grpc/forks","keys_url":"https://api.github.com/repos/yunjiaw26/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yunjiaw26/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yunjiaw26/grpc/teams","hooks_url":"https://api.github.com/repos/yunjiaw26/grpc/hooks","issue_events_url":"https://api.github.com/repos/yunjiaw26/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/yunjiaw26/grpc/events","assignees_url":"https://api.github.com/repos/yunjiaw26/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/yunjiaw26/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/yunjiaw26/grpc/tags","blobs_url":"https://api.github.com/repos/yunjiaw26/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yunjiaw26/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yunjiaw26/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/yunjiaw26/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yunjiaw26/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/yunjiaw26/grpc/languages","stargazers_url":"https://api.github.com/repos/yunjiaw26/grpc/stargazers","contributors_url":"https://api.github.com/repos/yunjiaw26/grpc/contributors","subscribers_url":"https://api.github.com/repos/yunjiaw26/grpc/subscribers","subscription_url":"https://api.github.com/repos/yunjiaw26/grpc/subscription","commits_url":"https://api.github.com/repos/yunjiaw26/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/yunjiaw26/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/yunjiaw26/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/yunjiaw26/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/yunjiaw26/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/yunjiaw26/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yunjiaw26/grpc/merges","archive_url":"https://api.github.com/repos/yunjiaw26/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yunjiaw26/grpc/downloads","issues_url":"https://api.github.com/repos/yunjiaw26/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/yunjiaw26/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/yunjiaw26/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/yunjiaw26/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yunjiaw26/grpc/labels{/name}","releases_url":"https://api.github.com/repos/yunjiaw26/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/yunjiaw26/grpc/deployments","created_at":"2019-06-12T22:08:21Z","updated_at":"2019-06-28T18:19:18Z","pushed_at":"2019-07-25T22:31:43Z","git_url":"git://github.com/yunjiaw26/grpc.git","ssh_url":"[email protected]:yunjiaw26/grpc.git","clone_url":"https://github.com/yunjiaw26/grpc.git","svn_url":"https://github.com/yunjiaw26/grpc","homepage":"https://grpc.io","size":212997,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"f1fc64274a3245f8043abd6f910c0af6d4a636de","user":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729880,"node_id":"MDEwOlJlcG9zaXRvcnkyNzcyOTg4MA==","name":"grpc","full_name":"grpc/grpc","private":false,"owner":{"login":"grpc","id":7802525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4MDI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/grpc/grpc","description":"The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#)","fork":false,"url":"https://api.github.com/repos/grpc/grpc","forks_url":"https://api.github.com/repos/grpc/grpc/forks","keys_url":"https://api.github.com/repos/grpc/grpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc/teams","hooks_url":"https://api.github.com/repos/grpc/grpc/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc/events","assignees_url":"https://api.github.com/repos/grpc/grpc/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc/tags","blobs_url":"https://api.github.com/repos/grpc/grpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc/subscription","commits_url":"https://api.github.com/repos/grpc/grpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc/merges","archive_url":"https://api.github.com/repos/grpc/grpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc/downloads","issues_url":"https://api.github.com/repos/grpc/grpc/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc/deployments","created_at":"2014-12-08T18:58:53Z","updated_at":"2019-07-27T00:36:03Z","pushed_at":"2019-07-27T01:13:14Z","git_url":"git://github.com/grpc/grpc.git","ssh_url":"[email protected]:grpc/grpc.git","clone_url":"https://github.com/grpc/grpc.git","svn_url":"https://github.com/grpc/grpc","homepage":"https://grpc.io","size":229733,"stargazers_count":22300,"watchers_count":22300,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":5207,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1465,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5207,"open_issues":1465,"watchers":22300,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc/pulls/19695"},"html":{"href":"https://github.com/grpc/grpc/pull/19695"},"issue":{"href":"https://api.github.com/repos/grpc/grpc/issues/19695"},"comments":{"href":"https://api.github.com/repos/grpc/grpc/issues/19695/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc/pulls/19695/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc/pulls/19695/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc/statuses/d87b5285cab2959c65e8dc0ec6df120f3be3b1c3"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 27729880,
"name": "grpc/grpc",
"url": "https://api.github.com/repos/grpc/grpc"
}
|
{
"id": 10135909,
"login": "dklempner",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10135909?",
"url": "https://api.github.com/users/dklempner"
}
|
{
"id": 7802525,
"login": "grpc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7802525?",
"url": "https://api.github.com/orgs/grpc"
}
| 2019-07-27T01:19:17 |
10094724375
|
{"actor":{"display_login":"dklempner"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/cb-geo/mpm/pulls/comments/337273125","pull_request_review_id":304893338,"id":337273125,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzNzI3MzEyNQ==","diff_hunk":"@@ -719,3 +724,20 @@ void mpm::Particle<Tdim, Tnphases>::apply_particle_velocity_constraints() {\n this->velocity_(direction, phase) = constraint.second;\n }\n }\n+\n+//! Apply particle velocity constraints","path":"include/particle.tcc","position":38,"original_position":38,"commit_id":"c5f777e044cf36a0a1a88ae81d70072989b529cc","original_commit_id":"c5f777e044cf36a0a1a88ae81d70072989b529cc","user":{"login":"ezrayst","id":22064721,"node_id":"MDQ6VXNlcjIyMDY0NzIx","avatar_url":"https://avatars3.githubusercontent.com/u/22064721?v=4","gravatar_id":"","url":"https://api.github.com/users/ezrayst","html_url":"https://github.com/ezrayst","followers_url":"https://api.github.com/users/ezrayst/followers","following_url":"https://api.github.com/users/ezrayst/following{/other_user}","gists_url":"https://api.github.com/users/ezrayst/gists{/gist_id}","starred_url":"https://api.github.com/users/ezrayst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezrayst/subscriptions","organizations_url":"https://api.github.com/users/ezrayst/orgs","repos_url":"https://api.github.com/users/ezrayst/repos","events_url":"https://api.github.com/users/ezrayst/events{/privacy}","received_events_url":"https://api.github.com/users/ezrayst/received_events","type":"User","site_admin":false},"body":"This comment does not fit the function","created_at":"2019-10-21T22:46:22Z","updated_at":"2019-10-21T22:46:22Z","html_url":"https://github.com/cb-geo/mpm/pull/476#discussion_r337273125","pull_request_url":"https://api.github.com/repos/cb-geo/mpm/pulls/476","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cb-geo/mpm/pulls/comments/337273125"},"html":{"href":"https://github.com/cb-geo/mpm/pull/476#discussion_r337273125"},"pull_request":{"href":"https://api.github.com/repos/cb-geo/mpm/pulls/476"}}},"pull_request":{"url":"https://api.github.com/repos/cb-geo/mpm/pulls/476","id":330728566,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMwNzI4NTY2","html_url":"https://github.com/cb-geo/mpm/pull/476","diff_url":"https://github.com/cb-geo/mpm/pull/476.diff","patch_url":"https://github.com/cb-geo/mpm/pull/476.patch","issue_url":"https://api.github.com/repos/cb-geo/mpm/issues/476","number":476,"state":"open","locked":false,"title":":computer: :art: Output vector data of particles for viz","user":{"login":"kks32","id":3963513,"node_id":"MDQ6VXNlcjM5NjM1MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3963513?v=4","gravatar_id":"","url":"https://api.github.com/users/kks32","html_url":"https://github.com/kks32","followers_url":"https://api.github.com/users/kks32/followers","following_url":"https://api.github.com/users/kks32/following{/other_user}","gists_url":"https://api.github.com/users/kks32/gists{/gist_id}","starred_url":"https://api.github.com/users/kks32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kks32/subscriptions","organizations_url":"https://api.github.com/users/kks32/orgs","repos_url":"https://api.github.com/users/kks32/repos","events_url":"https://api.github.com/users/kks32/events{/privacy}","received_events_url":"https://api.github.com/users/kks32/received_events","type":"User","site_admin":false},"body":"This should define displacements as a new particle vector field, overrides #472 ","created_at":"2019-10-21T22:39:23Z","updated_at":"2019-10-21T22:46:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"782c714af4b91d0973d497ca85e0da649abc74e4","assignee":{"login":"kks32","id":3963513,"node_id":"MDQ6VXNlcjM5NjM1MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3963513?v=4","gravatar_id":"","url":"https://api.github.com/users/kks32","html_url":"https://github.com/kks32","followers_url":"https://api.github.com/users/kks32/followers","following_url":"https://api.github.com/users/kks32/following{/other_user}","gists_url":"https://api.github.com/users/kks32/gists{/gist_id}","starred_url":"https://api.github.com/users/kks32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kks32/subscriptions","organizations_url":"https://api.github.com/users/kks32/orgs","repos_url":"https://api.github.com/users/kks32/repos","events_url":"https://api.github.com/users/kks32/events{/privacy}","received_events_url":"https://api.github.com/users/kks32/received_events","type":"User","site_admin":false},"assignees":[{"login":"kks32","id":3963513,"node_id":"MDQ6VXNlcjM5NjM1MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3963513?v=4","gravatar_id":"","url":"https://api.github.com/users/kks32","html_url":"https://github.com/kks32","followers_url":"https://api.github.com/users/kks32/followers","following_url":"https://api.github.com/users/kks32/following{/other_user}","gists_url":"https://api.github.com/users/kks32/gists{/gist_id}","starred_url":"https://api.github.com/users/kks32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kks32/subscriptions","organizations_url":"https://api.github.com/users/kks32/orgs","repos_url":"https://api.github.com/users/kks32/repos","events_url":"https://api.github.com/users/kks32/events{/privacy}","received_events_url":"https://api.github.com/users/kks32/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"cbgeo","id":7850918,"node_id":"MDQ6VXNlcjc4NTA5MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/7850918?v=4","gravatar_id":"","url":"https://api.github.com/users/cbgeo","html_url":"https://github.com/cbgeo","followers_url":"https://api.github.com/users/cbgeo/followers","following_url":"https://api.github.com/users/cbgeo/following{/other_user}","gists_url":"https://api.github.com/users/cbgeo/gists{/gist_id}","starred_url":"https://api.github.com/users/cbgeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbgeo/subscriptions","organizations_url":"https://api.github.com/users/cbgeo/orgs","repos_url":"https://api.github.com/users/cbgeo/repos","events_url":"https://api.github.com/users/cbgeo/events{/privacy}","received_events_url":"https://api.github.com/users/cbgeo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":679946687,"node_id":"MDU6TGFiZWw2Nzk5NDY2ODc=","url":"https://api.github.com/repos/cb-geo/mpm/labels/Priority:%20Low","name":"Priority: Low","color":"009800","default":false},{"id":679946704,"node_id":"MDU6TGFiZWw2Nzk5NDY3MDQ=","url":"https://api.github.com/repos/cb-geo/mpm/labels/Status:%20Completed","name":"Status: Completed","color":"006b75","default":false},{"id":679946719,"node_id":"MDU6TGFiZWw2Nzk5NDY3MTk=","url":"https://api.github.com/repos/cb-geo/mpm/labels/Type:%20Refactor","name":"Type: Refactor","color":"ff1493","default":false},{"id":1065012570,"node_id":"MDU6TGFiZWwxMDY1MDEyNTcw","url":"https://api.github.com/repos/cb-geo/mpm/labels/Type:%20Viz","name":"Type: Viz","color":"74f29c","default":false}],"milestone":{"url":"https://api.github.com/repos/cb-geo/mpm/milestones/20","html_url":"https://github.com/cb-geo/mpm/milestone/20","labels_url":"https://api.github.com/repos/cb-geo/mpm/milestones/20/labels","id":4375397,"node_id":"MDk6TWlsZXN0b25lNDM3NTM5Nw==","number":20,"title":"I/O and Visualization","description":"Visualization","creator":{"login":"kks32","id":3963513,"node_id":"MDQ6VXNlcjM5NjM1MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/3963513?v=4","gravatar_id":"","url":"https://api.github.com/users/kks32","html_url":"https://github.com/kks32","followers_url":"https://api.github.com/users/kks32/followers","following_url":"https://api.github.com/users/kks32/following{/other_user}","gists_url":"https://api.github.com/users/kks32/gists{/gist_id}","starred_url":"https://api.github.com/users/kks32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kks32/subscriptions","organizations_url":"https://api.github.com/users/kks32/orgs","repos_url":"https://api.github.com/users/kks32/repos","events_url":"https://api.github.com/users/kks32/events{/privacy}","received_events_url":"https://api.github.com/users/kks32/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":3,"state":"open","created_at":"2019-06-04T16:55:11Z","updated_at":"2019-10-21T22:39:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cb-geo/mpm/pulls/476/commits","review_comments_url":"https://api.github.com/repos/cb-geo/mpm/pulls/476/comments","review_comment_url":"https://api.github.com/repos/cb-geo/mpm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cb-geo/mpm/issues/476/comments","statuses_url":"https://api.github.com/repos/cb-geo/mpm/statuses/c5f777e044cf36a0a1a88ae81d70072989b529cc","head":{"label":"cb-geo:viz/vector_data","ref":"viz/vector_data","sha":"c5f777e044cf36a0a1a88ae81d70072989b529cc","user":{"login":"cb-geo","id":7850930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NTA5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/7850930?v=4","gravatar_id":"","url":"https://api.github.com/users/cb-geo","html_url":"https://github.com/cb-geo","followers_url":"https://api.github.com/users/cb-geo/followers","following_url":"https://api.github.com/users/cb-geo/following{/other_user}","gists_url":"https://api.github.com/users/cb-geo/gists{/gist_id}","starred_url":"https://api.github.com/users/cb-geo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cb-geo/subscriptions","organizations_url":"https://api.github.com/users/cb-geo/orgs","repos_url":"https://api.github.com/users/cb-geo/repos","events_url":"https://api.github.com/users/cb-geo/events{/privacy}","received_events_url":"https://api.github.com/users/cb-geo/received_events","type":"Organization","site_admin":false},"repo":{"id":101450464,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0NTA0NjQ=","name":"mpm","full_name":"cb-geo/mpm","private":false,"owner":{"login":"cb-geo","id":7850930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NTA5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/7850930?v=4","gravatar_id":"","url":"https://api.github.com/users/cb-geo","html_url":"https://github.com/cb-geo","followers_url":"https://api.github.com/users/cb-geo/followers","following_url":"https://api.github.com/users/cb-geo/following{/other_user}","gists_url":"https://api.github.com/users/cb-geo/gists{/gist_id}","starred_url":"https://api.github.com/users/cb-geo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cb-geo/subscriptions","organizations_url":"https://api.github.com/users/cb-geo/orgs","repos_url":"https://api.github.com/users/cb-geo/repos","events_url":"https://api.github.com/users/cb-geo/events{/privacy}","received_events_url":"https://api.github.com/users/cb-geo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cb-geo/mpm","description":"CB-Geo High-Performance Material Point Method","fork":false,"url":"https://api.github.com/repos/cb-geo/mpm","forks_url":"https://api.github.com/repos/cb-geo/mpm/forks","keys_url":"https://api.github.com/repos/cb-geo/mpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cb-geo/mpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cb-geo/mpm/teams","hooks_url":"https://api.github.com/repos/cb-geo/mpm/hooks","issue_events_url":"https://api.github.com/repos/cb-geo/mpm/issues/events{/number}","events_url":"https://api.github.com/repos/cb-geo/mpm/events","assignees_url":"https://api.github.com/repos/cb-geo/mpm/assignees{/user}","branches_url":"https://api.github.com/repos/cb-geo/mpm/branches{/branch}","tags_url":"https://api.github.com/repos/cb-geo/mpm/tags","blobs_url":"https://api.github.com/repos/cb-geo/mpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cb-geo/mpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cb-geo/mpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/cb-geo/mpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cb-geo/mpm/statuses/{sha}","languages_url":"https://api.github.com/repos/cb-geo/mpm/languages","stargazers_url":"https://api.github.com/repos/cb-geo/mpm/stargazers","contributors_url":"https://api.github.com/repos/cb-geo/mpm/contributors","subscribers_url":"https://api.github.com/repos/cb-geo/mpm/subscribers","subscription_url":"https://api.github.com/repos/cb-geo/mpm/subscription","commits_url":"https://api.github.com/repos/cb-geo/mpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/cb-geo/mpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/cb-geo/mpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/cb-geo/mpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/cb-geo/mpm/contents/{+path}","compare_url":"https://api.github.com/repos/cb-geo/mpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cb-geo/mpm/merges","archive_url":"https://api.github.com/repos/cb-geo/mpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cb-geo/mpm/downloads","issues_url":"https://api.github.com/repos/cb-geo/mpm/issues{/number}","pulls_url":"https://api.github.com/repos/cb-geo/mpm/pulls{/number}","milestones_url":"https://api.github.com/repos/cb-geo/mpm/milestones{/number}","notifications_url":"https://api.github.com/repos/cb-geo/mpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cb-geo/mpm/labels{/name}","releases_url":"https://api.github.com/repos/cb-geo/mpm/releases{/id}","deployments_url":"https://api.github.com/repos/cb-geo/mpm/deployments","created_at":"2017-08-25T23:53:55Z","updated_at":"2019-10-18T15:37:58Z","pushed_at":"2019-10-21T22:40:05Z","git_url":"git://github.com/cb-geo/mpm.git","ssh_url":"[email protected]:cb-geo/mpm.git","clone_url":"https://github.com/cb-geo/mpm.git","svn_url":"https://github.com/cb-geo/mpm","homepage":"https://www.cb-geo.com/research/mpm","size":4663,"stargazers_count":39,"watchers_count":39,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":30,"open_issues":32,"watchers":39,"default_branch":"develop"}},"base":{"label":"cb-geo:develop","ref":"develop","sha":"6dd4c98ec81aaa83926b6f4f0206a4d6c9198933","user":{"login":"cb-geo","id":7850930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NTA5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/7850930?v=4","gravatar_id":"","url":"https://api.github.com/users/cb-geo","html_url":"https://github.com/cb-geo","followers_url":"https://api.github.com/users/cb-geo/followers","following_url":"https://api.github.com/users/cb-geo/following{/other_user}","gists_url":"https://api.github.com/users/cb-geo/gists{/gist_id}","starred_url":"https://api.github.com/users/cb-geo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cb-geo/subscriptions","organizations_url":"https://api.github.com/users/cb-geo/orgs","repos_url":"https://api.github.com/users/cb-geo/repos","events_url":"https://api.github.com/users/cb-geo/events{/privacy}","received_events_url":"https://api.github.com/users/cb-geo/received_events","type":"Organization","site_admin":false},"repo":{"id":101450464,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0NTA0NjQ=","name":"mpm","full_name":"cb-geo/mpm","private":false,"owner":{"login":"cb-geo","id":7850930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NTA5MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/7850930?v=4","gravatar_id":"","url":"https://api.github.com/users/cb-geo","html_url":"https://github.com/cb-geo","followers_url":"https://api.github.com/users/cb-geo/followers","following_url":"https://api.github.com/users/cb-geo/following{/other_user}","gists_url":"https://api.github.com/users/cb-geo/gists{/gist_id}","starred_url":"https://api.github.com/users/cb-geo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cb-geo/subscriptions","organizations_url":"https://api.github.com/users/cb-geo/orgs","repos_url":"https://api.github.com/users/cb-geo/repos","events_url":"https://api.github.com/users/cb-geo/events{/privacy}","received_events_url":"https://api.github.com/users/cb-geo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cb-geo/mpm","description":"CB-Geo High-Performance Material Point Method","fork":false,"url":"https://api.github.com/repos/cb-geo/mpm","forks_url":"https://api.github.com/repos/cb-geo/mpm/forks","keys_url":"https://api.github.com/repos/cb-geo/mpm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cb-geo/mpm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cb-geo/mpm/teams","hooks_url":"https://api.github.com/repos/cb-geo/mpm/hooks","issue_events_url":"https://api.github.com/repos/cb-geo/mpm/issues/events{/number}","events_url":"https://api.github.com/repos/cb-geo/mpm/events","assignees_url":"https://api.github.com/repos/cb-geo/mpm/assignees{/user}","branches_url":"https://api.github.com/repos/cb-geo/mpm/branches{/branch}","tags_url":"https://api.github.com/repos/cb-geo/mpm/tags","blobs_url":"https://api.github.com/repos/cb-geo/mpm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cb-geo/mpm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cb-geo/mpm/git/refs{/sha}","trees_url":"https://api.github.com/repos/cb-geo/mpm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cb-geo/mpm/statuses/{sha}","languages_url":"https://api.github.com/repos/cb-geo/mpm/languages","stargazers_url":"https://api.github.com/repos/cb-geo/mpm/stargazers","contributors_url":"https://api.github.com/repos/cb-geo/mpm/contributors","subscribers_url":"https://api.github.com/repos/cb-geo/mpm/subscribers","subscription_url":"https://api.github.com/repos/cb-geo/mpm/subscription","commits_url":"https://api.github.com/repos/cb-geo/mpm/commits{/sha}","git_commits_url":"https://api.github.com/repos/cb-geo/mpm/git/commits{/sha}","comments_url":"https://api.github.com/repos/cb-geo/mpm/comments{/number}","issue_comment_url":"https://api.github.com/repos/cb-geo/mpm/issues/comments{/number}","contents_url":"https://api.github.com/repos/cb-geo/mpm/contents/{+path}","compare_url":"https://api.github.com/repos/cb-geo/mpm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cb-geo/mpm/merges","archive_url":"https://api.github.com/repos/cb-geo/mpm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cb-geo/mpm/downloads","issues_url":"https://api.github.com/repos/cb-geo/mpm/issues{/number}","pulls_url":"https://api.github.com/repos/cb-geo/mpm/pulls{/number}","milestones_url":"https://api.github.com/repos/cb-geo/mpm/milestones{/number}","notifications_url":"https://api.github.com/repos/cb-geo/mpm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cb-geo/mpm/labels{/name}","releases_url":"https://api.github.com/repos/cb-geo/mpm/releases{/id}","deployments_url":"https://api.github.com/repos/cb-geo/mpm/deployments","created_at":"2017-08-25T23:53:55Z","updated_at":"2019-10-18T15:37:58Z","pushed_at":"2019-10-21T22:40:05Z","git_url":"git://github.com/cb-geo/mpm.git","ssh_url":"[email protected]:cb-geo/mpm.git","clone_url":"https://github.com/cb-geo/mpm.git","svn_url":"https://github.com/cb-geo/mpm","homepage":"https://www.cb-geo.com/research/mpm","size":4663,"stargazers_count":39,"watchers_count":39,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":30,"open_issues":32,"watchers":39,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cb-geo/mpm/pulls/476"},"html":{"href":"https://github.com/cb-geo/mpm/pull/476"},"issue":{"href":"https://api.github.com/repos/cb-geo/mpm/issues/476"},"comments":{"href":"https://api.github.com/repos/cb-geo/mpm/issues/476/comments"},"review_comments":{"href":"https://api.github.com/repos/cb-geo/mpm/pulls/476/comments"},"review_comment":{"href":"https://api.github.com/repos/cb-geo/mpm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cb-geo/mpm/pulls/476/commits"},"statuses":{"href":"https://api.github.com/repos/cb-geo/mpm/statuses/c5f777e044cf36a0a1a88ae81d70072989b529cc"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 101450464,
"name": "cb-geo/mpm",
"url": "https://api.github.com/repos/cb-geo/mpm"
}
|
{
"id": 22064721,
"login": "ezrayst",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22064721?",
"url": "https://api.github.com/users/ezrayst"
}
|
{
"id": 7850930,
"login": "cb-geo",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7850930?",
"url": "https://api.github.com/orgs/cb-geo"
}
| 2019-10-21T22:46:22 |
10680918294
|
{"actor":{"display_login":"ezrayst"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/pulls/comments/269927949","pull_request_review_id":219923797,"id":269927949,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2OTkyNzk0OQ==","diff_hunk":"@@ -1,18 +1,16 @@\n import { show, hide, delegate } from '@utils';\n \n-delegate('change', '#contact-form #type', event => {\n- const type = event.target.value;\n- const answer = document.querySelector(`[data-answer=\"${type}\"]`);\n- const card = document.querySelector('.support.card');\n+function updateContactElementsVisibility() {\n+ const contactSelect = document.querySelector('#contact-form #type');\n+ if (contactSelect) {\n+ const type = contactSelect.value;\n+ const visibleElements = `[data-contact-type-only=\"${type}\"]`;\n+ const hiddenElements = `[data-contact-type-only]:not([data-contact-type-only=\"${type}\"])`;\n \n- for (let element of document.querySelectorAll('.card-content')) {\n- hide(element);\n+ document.querySelectorAll(visibleElements).forEach(show);\n+ document.querySelectorAll(hiddenElements).forEach(hide);\n }\n+}\n \n- if (answer) {\n- show(card);\n- show(answer);\n- } else {\n- hide(card);\n- }\n-});\n+addEventListener('turbolinks:load', updateContactElementsVisibility);","path":"app/javascript/new_design/support.js","position":28,"original_position":28,"commit_id":"1cd8b206e0f46df229d95c04b3cb6ef7e50ac8ec","original_commit_id":"1cd8b206e0f46df229d95c04b3cb6ef7e50ac8ec","user":{"login":"kemenaran","id":179923,"node_id":"MDQ6VXNlcjE3OTkyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/179923?v=4","gravatar_id":"","url":"https://api.github.com/users/kemenaran","html_url":"https://github.com/kemenaran","followers_url":"https://api.github.com/users/kemenaran/followers","following_url":"https://api.github.com/users/kemenaran/following{/other_user}","gists_url":"https://api.github.com/users/kemenaran/gists{/gist_id}","starred_url":"https://api.github.com/users/kemenaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kemenaran/subscriptions","organizations_url":"https://api.github.com/users/kemenaran/orgs","repos_url":"https://api.github.com/users/kemenaran/repos","events_url":"https://api.github.com/users/kemenaran/events{/privacy}","received_events_url":"https://api.github.com/users/kemenaran/received_events","type":"User","site_admin":false},"body":"En fait c'est pour quand on recharge la page : les navigateurs ont tendance à restaurer la valeur du select, mais du coup il faut que nous on restaure la valeur du champ en question :)","created_at":"2019-03-28T10:00:48Z","updated_at":"2019-03-28T10:00:48Z","html_url":"https://github.com/betagouv/demarches-simplifiees.fr/pull/3583#discussion_r269927949","pull_request_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/pulls/3583","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/pulls/comments/269927949"},"html":{"href":"https://github.com/betagouv/demarches-simplifiees.fr/pull/3583#discussion_r269927949"},"pull_request":{"href":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/pulls/3583"}},"in_reply_to_id":269904391},"pull_request":{"url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/pulls/3583","id":259914912,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5OTE0OTEy","html_url":"https://github.com/betagouv/demarches-simplifiees.fr/pull/3583","diff_url":"https://github.com/betagouv/demarches-simplifiees.fr/pull/3583.diff","patch_url":"https://github.com/betagouv/demarches-simplifiees.fr/pull/3583.patch","issue_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/issues/3583","number":3583,"state":"open","locked":false,"title":"Propose à l'usager d'envoyer une capture d'écran","user":{"login":"philemon95","id":40801449,"node_id":"MDQ6VXNlcjQwODAxNDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/40801449?v=4","gravatar_id":"","url":"https://api.github.com/users/philemon95","html_url":"https://github.com/philemon95","followers_url":"https://api.github.com/users/philemon95/followers","following_url":"https://api.github.com/users/philemon95/following{/other_user}","gists_url":"https://api.github.com/users/philemon95/gists{/gist_id}","starred_url":"https://api.github.com/users/philemon95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philemon95/subscriptions","organizations_url":"https://api.github.com/users/philemon95/orgs","repos_url":"https://api.github.com/users/philemon95/repos","events_url":"https://api.github.com/users/philemon95/events{/privacy}","received_events_url":"https://api.github.com/users/philemon95/received_events","type":"User","site_admin":false},"body":"rajout d'un incentive pour que l'usager nous envoie directement une copie d'écran (permet d'éviter de nombreux mails d'interaction en support)","created_at":"2019-03-11T10:43:10Z","updated_at":"2019-03-28T10:00:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efb45324a7c1782fc360a000394ce73a933f2fca","assignee":{"login":"kemenaran","id":179923,"node_id":"MDQ6VXNlcjE3OTkyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/179923?v=4","gravatar_id":"","url":"https://api.github.com/users/kemenaran","html_url":"https://github.com/kemenaran","followers_url":"https://api.github.com/users/kemenaran/followers","following_url":"https://api.github.com/users/kemenaran/following{/other_user}","gists_url":"https://api.github.com/users/kemenaran/gists{/gist_id}","starred_url":"https://api.github.com/users/kemenaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kemenaran/subscriptions","organizations_url":"https://api.github.com/users/kemenaran/orgs","repos_url":"https://api.github.com/users/kemenaran/repos","events_url":"https://api.github.com/users/kemenaran/events{/privacy}","received_events_url":"https://api.github.com/users/kemenaran/received_events","type":"User","site_admin":false},"assignees":[{"login":"kemenaran","id":179923,"node_id":"MDQ6VXNlcjE3OTkyMw==","avatar_url":"https://avatars3.githubusercontent.com/u/179923?v=4","gravatar_id":"","url":"https://api.github.com/users/kemenaran","html_url":"https://github.com/kemenaran","followers_url":"https://api.github.com/users/kemenaran/followers","following_url":"https://api.github.com/users/kemenaran/following{/other_user}","gists_url":"https://api.github.com/users/kemenaran/gists{/gist_id}","starred_url":"https://api.github.com/users/kemenaran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kemenaran/subscriptions","organizations_url":"https://api.github.com/users/kemenaran/orgs","repos_url":"https://api.github.com/users/kemenaran/repos","events_url":"https://api.github.com/users/kemenaran/events{/privacy}","received_events_url":"https://api.github.com/users/kemenaran/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tchak","id":12428,"node_id":"MDQ6VXNlcjEyNDI4","avatar_url":"https://avatars1.githubusercontent.com/u/12428?v=4","gravatar_id":"","url":"https://api.github.com/users/tchak","html_url":"https://github.com/tchak","followers_url":"https://api.github.com/users/tchak/followers","following_url":"https://api.github.com/users/tchak/following{/other_user}","gists_url":"https://api.github.com/users/tchak/gists{/gist_id}","starred_url":"https://api.github.com/users/tchak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchak/subscriptions","organizations_url":"https://api.github.com/users/tchak/orgs","repos_url":"https://api.github.com/users/tchak/repos","events_url":"https://api.github.com/users/tchak/events{/privacy}","received_events_url":"https://api.github.com/users/tchak/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/pulls/3583/commits","review_comments_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/pulls/3583/comments","review_comment_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/issues/3583/comments","statuses_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/statuses/1cd8b206e0f46df229d95c04b3cb6ef7e50ac8ec","head":{"label":"betagouv:philemon95-patch-3","ref":"philemon95-patch-3","sha":"1cd8b206e0f46df229d95c04b3cb6ef7e50ac8ec","user":{"login":"betagouv","id":7874148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NzQxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7874148?v=4","gravatar_id":"","url":"https://api.github.com/users/betagouv","html_url":"https://github.com/betagouv","followers_url":"https://api.github.com/users/betagouv/followers","following_url":"https://api.github.com/users/betagouv/following{/other_user}","gists_url":"https://api.github.com/users/betagouv/gists{/gist_id}","starred_url":"https://api.github.com/users/betagouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betagouv/subscriptions","organizations_url":"https://api.github.com/users/betagouv/orgs","repos_url":"https://api.github.com/users/betagouv/repos","events_url":"https://api.github.com/users/betagouv/events{/privacy}","received_events_url":"https://api.github.com/users/betagouv/received_events","type":"Organization","site_admin":false},"repo":{"id":44167674,"node_id":"MDEwOlJlcG9zaXRvcnk0NDE2NzY3NA==","name":"demarches-simplifiees.fr","full_name":"betagouv/demarches-simplifiees.fr","private":false,"owner":{"login":"betagouv","id":7874148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NzQxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7874148?v=4","gravatar_id":"","url":"https://api.github.com/users/betagouv","html_url":"https://github.com/betagouv","followers_url":"https://api.github.com/users/betagouv/followers","following_url":"https://api.github.com/users/betagouv/following{/other_user}","gists_url":"https://api.github.com/users/betagouv/gists{/gist_id}","starred_url":"https://api.github.com/users/betagouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betagouv/subscriptions","organizations_url":"https://api.github.com/users/betagouv/orgs","repos_url":"https://api.github.com/users/betagouv/repos","events_url":"https://api.github.com/users/betagouv/events{/privacy}","received_events_url":"https://api.github.com/users/betagouv/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/betagouv/demarches-simplifiees.fr","description":"Dématérialiser et simplifier les démarches administratives ","fork":false,"url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr","forks_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/forks","keys_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/teams","hooks_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/hooks","issue_events_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/issues/events{/number}","events_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/events","assignees_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/assignees{/user}","branches_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/branches{/branch}","tags_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/tags","blobs_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/git/refs{/sha}","trees_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/statuses/{sha}","languages_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/languages","stargazers_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/stargazers","contributors_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/contributors","subscribers_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/subscribers","subscription_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/subscription","commits_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/commits{/sha}","git_commits_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/git/commits{/sha}","comments_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/comments{/number}","issue_comment_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/issues/comments{/number}","contents_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/contents/{+path}","compare_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/merges","archive_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/downloads","issues_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/issues{/number}","pulls_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/pulls{/number}","milestones_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/milestones{/number}","notifications_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/labels{/name}","releases_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/releases{/id}","deployments_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/deployments","created_at":"2015-10-13T10:01:34Z","updated_at":"2019-03-27T17:49:18Z","pushed_at":"2019-03-27T17:56:31Z","git_url":"git://github.com/betagouv/demarches-simplifiees.fr.git","ssh_url":"[email protected]:betagouv/demarches-simplifiees.fr.git","clone_url":"https://github.com/betagouv/demarches-simplifiees.fr.git","svn_url":"https://github.com/betagouv/demarches-simplifiees.fr","homepage":"https://www.demarches-simplifiees.fr","size":25762,"stargazers_count":33,"watchers_count":33,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":788,"license":null,"forks":24,"open_issues":788,"watchers":33,"default_branch":"dev"}},"base":{"label":"betagouv:dev","ref":"dev","sha":"45297360924376afc557811588a6a32dfa2fb82e","user":{"login":"betagouv","id":7874148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NzQxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7874148?v=4","gravatar_id":"","url":"https://api.github.com/users/betagouv","html_url":"https://github.com/betagouv","followers_url":"https://api.github.com/users/betagouv/followers","following_url":"https://api.github.com/users/betagouv/following{/other_user}","gists_url":"https://api.github.com/users/betagouv/gists{/gist_id}","starred_url":"https://api.github.com/users/betagouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betagouv/subscriptions","organizations_url":"https://api.github.com/users/betagouv/orgs","repos_url":"https://api.github.com/users/betagouv/repos","events_url":"https://api.github.com/users/betagouv/events{/privacy}","received_events_url":"https://api.github.com/users/betagouv/received_events","type":"Organization","site_admin":false},"repo":{"id":44167674,"node_id":"MDEwOlJlcG9zaXRvcnk0NDE2NzY3NA==","name":"demarches-simplifiees.fr","full_name":"betagouv/demarches-simplifiees.fr","private":false,"owner":{"login":"betagouv","id":7874148,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc4NzQxNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7874148?v=4","gravatar_id":"","url":"https://api.github.com/users/betagouv","html_url":"https://github.com/betagouv","followers_url":"https://api.github.com/users/betagouv/followers","following_url":"https://api.github.com/users/betagouv/following{/other_user}","gists_url":"https://api.github.com/users/betagouv/gists{/gist_id}","starred_url":"https://api.github.com/users/betagouv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/betagouv/subscriptions","organizations_url":"https://api.github.com/users/betagouv/orgs","repos_url":"https://api.github.com/users/betagouv/repos","events_url":"https://api.github.com/users/betagouv/events{/privacy}","received_events_url":"https://api.github.com/users/betagouv/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/betagouv/demarches-simplifiees.fr","description":"Dématérialiser et simplifier les démarches administratives ","fork":false,"url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr","forks_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/forks","keys_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/teams","hooks_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/hooks","issue_events_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/issues/events{/number}","events_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/events","assignees_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/assignees{/user}","branches_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/branches{/branch}","tags_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/tags","blobs_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/git/refs{/sha}","trees_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/statuses/{sha}","languages_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/languages","stargazers_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/stargazers","contributors_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/contributors","subscribers_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/subscribers","subscription_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/subscription","commits_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/commits{/sha}","git_commits_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/git/commits{/sha}","comments_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/comments{/number}","issue_comment_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/issues/comments{/number}","contents_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/contents/{+path}","compare_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/merges","archive_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/downloads","issues_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/issues{/number}","pulls_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/pulls{/number}","milestones_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/milestones{/number}","notifications_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/labels{/name}","releases_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/releases{/id}","deployments_url":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/deployments","created_at":"2015-10-13T10:01:34Z","updated_at":"2019-03-27T17:49:18Z","pushed_at":"2019-03-27T17:56:31Z","git_url":"git://github.com/betagouv/demarches-simplifiees.fr.git","ssh_url":"[email protected]:betagouv/demarches-simplifiees.fr.git","clone_url":"https://github.com/betagouv/demarches-simplifiees.fr.git","svn_url":"https://github.com/betagouv/demarches-simplifiees.fr","homepage":"https://www.demarches-simplifiees.fr","size":25762,"stargazers_count":33,"watchers_count":33,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":788,"license":null,"forks":24,"open_issues":788,"watchers":33,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/pulls/3583"},"html":{"href":"https://github.com/betagouv/demarches-simplifiees.fr/pull/3583"},"issue":{"href":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/issues/3583"},"comments":{"href":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/issues/3583/comments"},"review_comments":{"href":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/pulls/3583/comments"},"review_comment":{"href":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/pulls/3583/commits"},"statuses":{"href":"https://api.github.com/repos/betagouv/demarches-simplifiees.fr/statuses/1cd8b206e0f46df229d95c04b3cb6ef7e50ac8ec"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 44167674,
"name": "betagouv/demarches-simplifiees.fr",
"url": "https://api.github.com/repos/betagouv/demarches-simplifiees.fr"
}
|
{
"id": 179923,
"login": "kemenaran",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/179923?",
"url": "https://api.github.com/users/kemenaran"
}
|
{
"id": 7874148,
"login": "betagouv",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7874148?",
"url": "https://api.github.com/orgs/betagouv"
}
| 2019-03-28T10:00:48 |
9331551138
|
{"actor":{"display_login":"kemenaran"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/pulls/comments/320188271","pull_request_review_id":282885831,"id":320188271,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMDE4ODI3MQ==","diff_hunk":"@@ -184,6 +184,14 @@ public PMBoundary CreateBoundary(Spline spline)\n return newBoundary;\n }\n \n+ /// <summary>\n+ /// Undraw all boundarys\n+ /// </summary> \n+ public void UndrawAll()\n+ {\n+ _powerMILL.DoCommand(\"UNDRAW BOUNDARY ALL\");","path":"Delcam.ProductInterface.PowerMILL/Classes/PMBoundariesCollection.cs","position":9,"original_position":9,"commit_id":"335885a91d8894e2ea44fc52b046f4e6b8974f36","original_commit_id":"335885a91d8894e2ea44fc52b046f4e6b8974f36","user":{"login":"lukeedw","id":35567035,"node_id":"MDQ6VXNlcjM1NTY3MDM1","avatar_url":"https://avatars3.githubusercontent.com/u/35567035?v=4","gravatar_id":"","url":"https://api.github.com/users/lukeedw","html_url":"https://github.com/lukeedw","followers_url":"https://api.github.com/users/lukeedw/followers","following_url":"https://api.github.com/users/lukeedw/following{/other_user}","gists_url":"https://api.github.com/users/lukeedw/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeedw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeedw/subscriptions","organizations_url":"https://api.github.com/users/lukeedw/orgs","repos_url":"https://api.github.com/users/lukeedw/repos","events_url":"https://api.github.com/users/lukeedw/events{/privacy}","received_events_url":"https://api.github.com/users/lukeedw/received_events","type":"User","site_admin":false},"body":"Hmmm, apparently that's not allowed:\r\nhttps://stackoverflow.com/questions/196661/calling-a-static-method-on-a-generic-type-parameter\r\nThere is some discussion in the above post that you could either use reflection or else use:\r\n`new T().Identifer`","created_at":"2019-09-03T09:55:31Z","updated_at":"2019-09-03T09:55:31Z","html_url":"https://github.com/Autodesk/PowerShapeAndPowerMillAPI/pull/29#discussion_r320188271","pull_request_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/pulls/29","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/pulls/comments/320188271"},"html":{"href":"https://github.com/Autodesk/PowerShapeAndPowerMillAPI/pull/29#discussion_r320188271"},"pull_request":{"href":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/pulls/29"}},"in_reply_to_id":305804066},"pull_request":{"url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/pulls/29","id":298814376,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk4ODE0Mzc2","html_url":"https://github.com/Autodesk/PowerShapeAndPowerMillAPI/pull/29","diff_url":"https://github.com/Autodesk/PowerShapeAndPowerMillAPI/pull/29.diff","patch_url":"https://github.com/Autodesk/PowerShapeAndPowerMillAPI/pull/29.patch","issue_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/issues/29","number":29,"state":"open","locked":false,"title":"Added functions to undraw all specific entities","user":{"login":"Feuerbowle","id":49747065,"node_id":"MDQ6VXNlcjQ5NzQ3MDY1","avatar_url":"https://avatars3.githubusercontent.com/u/49747065?v=4","gravatar_id":"","url":"https://api.github.com/users/Feuerbowle","html_url":"https://github.com/Feuerbowle","followers_url":"https://api.github.com/users/Feuerbowle/followers","following_url":"https://api.github.com/users/Feuerbowle/following{/other_user}","gists_url":"https://api.github.com/users/Feuerbowle/gists{/gist_id}","starred_url":"https://api.github.com/users/Feuerbowle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Feuerbowle/subscriptions","organizations_url":"https://api.github.com/users/Feuerbowle/orgs","repos_url":"https://api.github.com/users/Feuerbowle/repos","events_url":"https://api.github.com/users/Feuerbowle/events{/privacy}","received_events_url":"https://api.github.com/users/Feuerbowle/received_events","type":"User","site_admin":false},"body":"New functions to undraw all:\r\n- Toolpaths\r\n- Tools\r\n- Boundaries\r\n- Patterns\r\n- Feature Groups\r\n- Feature Sets\r\n- Workplanes\r\n- Levels and Sets\r\n- Stockmodels\r\n\r\nalso added test classes for:\r\n- Feature Groups\r\n- Feature Sets\r\n- Workplanes\r\n- Levels and Sets\r\n- Stockmodels","created_at":"2019-07-18T08:51:47Z","updated_at":"2019-09-03T09:55:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50f07408c2ba0b2bf7f3a15c1b5942a1947a408c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/pulls/29/commits","review_comments_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/pulls/29/comments","review_comment_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/issues/29/comments","statuses_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/statuses/335885a91d8894e2ea44fc52b046f4e6b8974f36","head":{"label":"Feuerbowle:master","ref":"master","sha":"335885a91d8894e2ea44fc52b046f4e6b8974f36","user":{"login":"Feuerbowle","id":49747065,"node_id":"MDQ6VXNlcjQ5NzQ3MDY1","avatar_url":"https://avatars3.githubusercontent.com/u/49747065?v=4","gravatar_id":"","url":"https://api.github.com/users/Feuerbowle","html_url":"https://github.com/Feuerbowle","followers_url":"https://api.github.com/users/Feuerbowle/followers","following_url":"https://api.github.com/users/Feuerbowle/following{/other_user}","gists_url":"https://api.github.com/users/Feuerbowle/gists{/gist_id}","starred_url":"https://api.github.com/users/Feuerbowle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Feuerbowle/subscriptions","organizations_url":"https://api.github.com/users/Feuerbowle/orgs","repos_url":"https://api.github.com/users/Feuerbowle/repos","events_url":"https://api.github.com/users/Feuerbowle/events{/privacy}","received_events_url":"https://api.github.com/users/Feuerbowle/received_events","type":"User","site_admin":false},"repo":{"id":197543404,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc1NDM0MDQ=","name":"PowerShapeAndPowerMillAPI","full_name":"Feuerbowle/PowerShapeAndPowerMillAPI","private":false,"owner":{"login":"Feuerbowle","id":49747065,"node_id":"MDQ6VXNlcjQ5NzQ3MDY1","avatar_url":"https://avatars3.githubusercontent.com/u/49747065?v=4","gravatar_id":"","url":"https://api.github.com/users/Feuerbowle","html_url":"https://github.com/Feuerbowle","followers_url":"https://api.github.com/users/Feuerbowle/followers","following_url":"https://api.github.com/users/Feuerbowle/following{/other_user}","gists_url":"https://api.github.com/users/Feuerbowle/gists{/gist_id}","starred_url":"https://api.github.com/users/Feuerbowle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Feuerbowle/subscriptions","organizations_url":"https://api.github.com/users/Feuerbowle/orgs","repos_url":"https://api.github.com/users/Feuerbowle/repos","events_url":"https://api.github.com/users/Feuerbowle/events{/privacy}","received_events_url":"https://api.github.com/users/Feuerbowle/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Feuerbowle/PowerShapeAndPowerMillAPI","description":"An API for Autodesk PowerShape and PowerMill","fork":true,"url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI","forks_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/forks","keys_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/teams","hooks_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/hooks","issue_events_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/issues/events{/number}","events_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/events","assignees_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/assignees{/user}","branches_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/branches{/branch}","tags_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/tags","blobs_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/languages","stargazers_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/stargazers","contributors_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/contributors","subscribers_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/subscribers","subscription_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/subscription","commits_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/contents/{+path}","compare_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/merges","archive_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/downloads","issues_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/issues{/number}","pulls_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/labels{/name}","releases_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/releases{/id}","deployments_url":"https://api.github.com/repos/Feuerbowle/PowerShapeAndPowerMillAPI/deployments","created_at":"2019-07-18T08:15:51Z","updated_at":"2019-07-18T08:49:43Z","pushed_at":"2019-07-18T08:49:41Z","git_url":"git://github.com/Feuerbowle/PowerShapeAndPowerMillAPI.git","ssh_url":"[email protected]:Feuerbowle/PowerShapeAndPowerMillAPI.git","clone_url":"https://github.com/Feuerbowle/PowerShapeAndPowerMillAPI.git","svn_url":"https://github.com/Feuerbowle/PowerShapeAndPowerMillAPI","homepage":null,"size":8298,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Autodesk:master","ref":"master","sha":"c3062f18641445b1cfbcfce207f4e90219c27d30","user":{"login":"Autodesk","id":7914533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTQ1MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/7914533?v=4","gravatar_id":"","url":"https://api.github.com/users/Autodesk","html_url":"https://github.com/Autodesk","followers_url":"https://api.github.com/users/Autodesk/followers","following_url":"https://api.github.com/users/Autodesk/following{/other_user}","gists_url":"https://api.github.com/users/Autodesk/gists{/gist_id}","starred_url":"https://api.github.com/users/Autodesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Autodesk/subscriptions","organizations_url":"https://api.github.com/users/Autodesk/orgs","repos_url":"https://api.github.com/users/Autodesk/repos","events_url":"https://api.github.com/users/Autodesk/events{/privacy}","received_events_url":"https://api.github.com/users/Autodesk/received_events","type":"Organization","site_admin":false},"repo":{"id":118043970,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgwNDM5NzA=","name":"PowerShapeAndPowerMillAPI","full_name":"Autodesk/PowerShapeAndPowerMillAPI","private":false,"owner":{"login":"Autodesk","id":7914533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTQ1MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/7914533?v=4","gravatar_id":"","url":"https://api.github.com/users/Autodesk","html_url":"https://github.com/Autodesk","followers_url":"https://api.github.com/users/Autodesk/followers","following_url":"https://api.github.com/users/Autodesk/following{/other_user}","gists_url":"https://api.github.com/users/Autodesk/gists{/gist_id}","starred_url":"https://api.github.com/users/Autodesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Autodesk/subscriptions","organizations_url":"https://api.github.com/users/Autodesk/orgs","repos_url":"https://api.github.com/users/Autodesk/repos","events_url":"https://api.github.com/users/Autodesk/events{/privacy}","received_events_url":"https://api.github.com/users/Autodesk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Autodesk/PowerShapeAndPowerMillAPI","description":"An API for Autodesk PowerShape and PowerMill","fork":false,"url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI","forks_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/forks","keys_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/teams","hooks_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/hooks","issue_events_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/issues/events{/number}","events_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/events","assignees_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/assignees{/user}","branches_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/branches{/branch}","tags_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/tags","blobs_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/languages","stargazers_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/stargazers","contributors_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/contributors","subscribers_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/subscribers","subscription_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/subscription","commits_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/contents/{+path}","compare_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/merges","archive_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/downloads","issues_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/issues{/number}","pulls_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/labels{/name}","releases_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/releases{/id}","deployments_url":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/deployments","created_at":"2018-01-18T22:06:12Z","updated_at":"2019-08-13T13:38:34Z","pushed_at":"2019-07-18T08:51:48Z","git_url":"git://github.com/Autodesk/PowerShapeAndPowerMillAPI.git","ssh_url":"[email protected]:Autodesk/PowerShapeAndPowerMillAPI.git","clone_url":"https://github.com/Autodesk/PowerShapeAndPowerMillAPI.git","svn_url":"https://github.com/Autodesk/PowerShapeAndPowerMillAPI","homepage":null,"size":8289,"stargazers_count":9,"watchers_count":9,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":15,"open_issues":1,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/pulls/29"},"html":{"href":"https://github.com/Autodesk/PowerShapeAndPowerMillAPI/pull/29"},"issue":{"href":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/issues/29"},"comments":{"href":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI/statuses/335885a91d8894e2ea44fc52b046f4e6b8974f36"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 118043970,
"name": "Autodesk/PowerShapeAndPowerMillAPI",
"url": "https://api.github.com/repos/Autodesk/PowerShapeAndPowerMillAPI"
}
|
{
"id": 35567035,
"login": "lukeedw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/35567035?",
"url": "https://api.github.com/users/lukeedw"
}
|
{
"id": 7914533,
"login": "Autodesk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/7914533?",
"url": "https://api.github.com/orgs/Autodesk"
}
| 2019-09-03T09:55:31 |
10335157905
|
{"actor":{"display_login":"lukeedw"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/MozillaReality/FirefoxReality/pulls/comments/346783783","pull_request_review_id":317563846,"id":346783783,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0Njc4Mzc4Mw==","diff_hunk":"@@ -23,3 +23,100 @@ distribution:\n notification_emails:\n - [email protected]\n expires: \"2020-05-01\"\n+url:\n+ domains:\n+ type: counter\n+ lifetime: ping","path":"app/metrics.yaml","position":7,"original_position":7,"commit_id":"c03f9639d0075705ded557ba06e21099441afd9c","original_commit_id":"c03f9639d0075705ded557ba06e21099441afd9c","user":{"login":"Dexterp37","id":883721,"node_id":"MDQ6VXNlcjg4MzcyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/883721?v=4","gravatar_id":"","url":"https://api.github.com/users/Dexterp37","html_url":"https://github.com/Dexterp37","followers_url":"https://api.github.com/users/Dexterp37/followers","following_url":"https://api.github.com/users/Dexterp37/following{/other_user}","gists_url":"https://api.github.com/users/Dexterp37/gists{/gist_id}","starred_url":"https://api.github.com/users/Dexterp37/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dexterp37/subscriptions","organizations_url":"https://api.github.com/users/Dexterp37/orgs","repos_url":"https://api.github.com/users/Dexterp37/repos","events_url":"https://api.github.com/users/Dexterp37/events{/privacy}","received_events_url":"https://api.github.com/users/Dexterp37/received_events","type":"User","site_admin":false},"body":"Note: `lifetime: ping` is redundant and can be removed here and elsewhere below. It's the default lifetime.","created_at":"2019-11-15T11:37:59Z","updated_at":"2019-11-15T11:41:44Z","html_url":"https://github.com/MozillaReality/FirefoxReality/pull/2241#discussion_r346783783","pull_request_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/pulls/2241","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/MozillaReality/FirefoxReality/pulls/comments/346783783"},"html":{"href":"https://github.com/MozillaReality/FirefoxReality/pull/2241#discussion_r346783783"},"pull_request":{"href":"https://api.github.com/repos/MozillaReality/FirefoxReality/pulls/2241"}}},"pull_request":{"url":"https://api.github.com/repos/MozillaReality/FirefoxReality/pulls/2241","id":340168090,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQwMTY4MDkw","html_url":"https://github.com/MozillaReality/FirefoxReality/pull/2241","diff_url":"https://github.com/MozillaReality/FirefoxReality/pull/2241.diff","patch_url":"https://github.com/MozillaReality/FirefoxReality/pull/2241.patch","issue_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/2241","number":2241,"state":"open","locked":false,"title":"Migrate telemetry pings to Glean (Stage 2).","user":{"login":"daoshengmu","id":1263177,"node_id":"MDQ6VXNlcjEyNjMxNzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1263177?v=4","gravatar_id":"","url":"https://api.github.com/users/daoshengmu","html_url":"https://github.com/daoshengmu","followers_url":"https://api.github.com/users/daoshengmu/followers","following_url":"https://api.github.com/users/daoshengmu/following{/other_user}","gists_url":"https://api.github.com/users/daoshengmu/gists{/gist_id}","starred_url":"https://api.github.com/users/daoshengmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daoshengmu/subscriptions","organizations_url":"https://api.github.com/users/daoshengmu/orgs","repos_url":"https://api.github.com/users/daoshengmu/repos","events_url":"https://api.github.com/users/daoshengmu/events{/privacy}","received_events_url":"https://api.github.com/users/daoshengmu/received_events","type":"User","site_admin":false},"body":"Fixes #2230 . Migrating the telemetry for\r\n\r\n- [ ] Measure how much time we spend for a web page loading.\r\n\r\n- [x] Counting how many domains and URL are visited in a session.\r\n\r\n- [x] How many times do users use url insert in the URL bar?\r\n\r\n- [x] How many times do users use url insert, search query, and voice query in the URL bar?\r\n\r\n- [x] How many times do users do voice query in the URL bar?\r\n\r\n- [ ] Measure how long users stay at the immersive mode.\r\n\r\n- [ ] Measure how many times users open new windows.\r\n\r\n- [ ] Measure how many times users long press this context menu.\r\n\r\n- [ ] How long is a Window opened?\r\n\r\n- [ ] To recognize how many users using the curved mode.\r\n\r\n- [x] How many searches are queried in a specific search engine>\r\n","created_at":"2019-11-12T23:52:21Z","updated_at":"2019-11-15T11:41:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"885d1fba25a84ac73c38a86c733a42f43ba58fc7","assignee":{"login":"daoshengmu","id":1263177,"node_id":"MDQ6VXNlcjEyNjMxNzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1263177?v=4","gravatar_id":"","url":"https://api.github.com/users/daoshengmu","html_url":"https://github.com/daoshengmu","followers_url":"https://api.github.com/users/daoshengmu/followers","following_url":"https://api.github.com/users/daoshengmu/following{/other_user}","gists_url":"https://api.github.com/users/daoshengmu/gists{/gist_id}","starred_url":"https://api.github.com/users/daoshengmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daoshengmu/subscriptions","organizations_url":"https://api.github.com/users/daoshengmu/orgs","repos_url":"https://api.github.com/users/daoshengmu/repos","events_url":"https://api.github.com/users/daoshengmu/events{/privacy}","received_events_url":"https://api.github.com/users/daoshengmu/received_events","type":"User","site_admin":false},"assignees":[{"login":"daoshengmu","id":1263177,"node_id":"MDQ6VXNlcjEyNjMxNzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1263177?v=4","gravatar_id":"","url":"https://api.github.com/users/daoshengmu","html_url":"https://github.com/daoshengmu","followers_url":"https://api.github.com/users/daoshengmu/followers","following_url":"https://api.github.com/users/daoshengmu/following{/other_user}","gists_url":"https://api.github.com/users/daoshengmu/gists{/gist_id}","starred_url":"https://api.github.com/users/daoshengmu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daoshengmu/subscriptions","organizations_url":"https://api.github.com/users/daoshengmu/orgs","repos_url":"https://api.github.com/users/daoshengmu/repos","events_url":"https://api.github.com/users/daoshengmu/events{/privacy}","received_events_url":"https://api.github.com/users/daoshengmu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1487594935,"node_id":"MDU6TGFiZWwxNDg3NTk0OTM1","url":"https://api.github.com/repos/MozillaReality/FirefoxReality/labels/telemetry","name":"telemetry","color":"d60872","default":false}],"milestone":{"url":"https://api.github.com/repos/MozillaReality/FirefoxReality/milestones/16","html_url":"https://github.com/MozillaReality/FirefoxReality/milestone/16","labels_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/milestones/16/labels","id":4714411,"node_id":"MDk6TWlsZXN0b25lNDcxNDQxMQ==","number":16,"title":"#7 polish","description":"Freeze 12/3 for release 12/10","creator":{"login":"jvonitter","id":48839872,"node_id":"MDQ6VXNlcjQ4ODM5ODcy","avatar_url":"https://avatars3.githubusercontent.com/u/48839872?v=4","gravatar_id":"","url":"https://api.github.com/users/jvonitter","html_url":"https://github.com/jvonitter","followers_url":"https://api.github.com/users/jvonitter/followers","following_url":"https://api.github.com/users/jvonitter/following{/other_user}","gists_url":"https://api.github.com/users/jvonitter/gists{/gist_id}","starred_url":"https://api.github.com/users/jvonitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvonitter/subscriptions","organizations_url":"https://api.github.com/users/jvonitter/orgs","repos_url":"https://api.github.com/users/jvonitter/repos","events_url":"https://api.github.com/users/jvonitter/events{/privacy}","received_events_url":"https://api.github.com/users/jvonitter/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":16,"state":"open","created_at":"2019-10-02T17:09:52Z","updated_at":"2019-11-14T23:06:19Z","due_on":"2019-12-03T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/pulls/2241/commits","review_comments_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/pulls/2241/comments","review_comment_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/2241/comments","statuses_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/statuses/c03f9639d0075705ded557ba06e21099441afd9c","head":{"label":"MozillaReality:migrateToGleanStage2","ref":"migrateToGleanStage2","sha":"c03f9639d0075705ded557ba06e21099441afd9c","user":{"login":"MozillaReality","id":8397321,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzOTczMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/8397321?v=4","gravatar_id":"","url":"https://api.github.com/users/MozillaReality","html_url":"https://github.com/MozillaReality","followers_url":"https://api.github.com/users/MozillaReality/followers","following_url":"https://api.github.com/users/MozillaReality/following{/other_user}","gists_url":"https://api.github.com/users/MozillaReality/gists{/gist_id}","starred_url":"https://api.github.com/users/MozillaReality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MozillaReality/subscriptions","organizations_url":"https://api.github.com/users/MozillaReality/orgs","repos_url":"https://api.github.com/users/MozillaReality/repos","events_url":"https://api.github.com/users/MozillaReality/events{/privacy}","received_events_url":"https://api.github.com/users/MozillaReality/received_events","type":"Organization","site_admin":false},"repo":{"id":117884741,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc4ODQ3NDE=","name":"FirefoxReality","full_name":"MozillaReality/FirefoxReality","private":false,"owner":{"login":"MozillaReality","id":8397321,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzOTczMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/8397321?v=4","gravatar_id":"","url":"https://api.github.com/users/MozillaReality","html_url":"https://github.com/MozillaReality","followers_url":"https://api.github.com/users/MozillaReality/followers","following_url":"https://api.github.com/users/MozillaReality/following{/other_user}","gists_url":"https://api.github.com/users/MozillaReality/gists{/gist_id}","starred_url":"https://api.github.com/users/MozillaReality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MozillaReality/subscriptions","organizations_url":"https://api.github.com/users/MozillaReality/orgs","repos_url":"https://api.github.com/users/MozillaReality/repos","events_url":"https://api.github.com/users/MozillaReality/events{/privacy}","received_events_url":"https://api.github.com/users/MozillaReality/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MozillaReality/FirefoxReality","description":"A fast and secure browser for standalone virtual-reality and augmented-reality headsets.","fork":false,"url":"https://api.github.com/repos/MozillaReality/FirefoxReality","forks_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/forks","keys_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/teams","hooks_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/hooks","issue_events_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/events{/number}","events_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/events","assignees_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/assignees{/user}","branches_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/branches{/branch}","tags_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/tags","blobs_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/git/refs{/sha}","trees_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/statuses/{sha}","languages_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/languages","stargazers_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/stargazers","contributors_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/contributors","subscribers_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/subscribers","subscription_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/subscription","commits_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/commits{/sha}","git_commits_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/git/commits{/sha}","comments_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/comments{/number}","issue_comment_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/comments{/number}","contents_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/contents/{+path}","compare_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/merges","archive_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/downloads","issues_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues{/number}","pulls_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/pulls{/number}","milestones_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/milestones{/number}","notifications_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/labels{/name}","releases_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/releases{/id}","deployments_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/deployments","created_at":"2018-01-17T19:47:04Z","updated_at":"2019-11-14T23:08:03Z","pushed_at":"2019-11-15T10:06:13Z","git_url":"git://github.com/MozillaReality/FirefoxReality.git","ssh_url":"[email protected]:MozillaReality/FirefoxReality.git","clone_url":"https://github.com/MozillaReality/FirefoxReality.git","svn_url":"https://github.com/MozillaReality/FirefoxReality","homepage":"https://mzl.la/reality","size":74684,"stargazers_count":434,"watchers_count":434,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":258,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":79,"open_issues":258,"watchers":434,"default_branch":"master"}},"base":{"label":"MozillaReality:master","ref":"master","sha":"b772e6d791d2a99091b2ac018e8a73a81efb84f0","user":{"login":"MozillaReality","id":8397321,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzOTczMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/8397321?v=4","gravatar_id":"","url":"https://api.github.com/users/MozillaReality","html_url":"https://github.com/MozillaReality","followers_url":"https://api.github.com/users/MozillaReality/followers","following_url":"https://api.github.com/users/MozillaReality/following{/other_user}","gists_url":"https://api.github.com/users/MozillaReality/gists{/gist_id}","starred_url":"https://api.github.com/users/MozillaReality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MozillaReality/subscriptions","organizations_url":"https://api.github.com/users/MozillaReality/orgs","repos_url":"https://api.github.com/users/MozillaReality/repos","events_url":"https://api.github.com/users/MozillaReality/events{/privacy}","received_events_url":"https://api.github.com/users/MozillaReality/received_events","type":"Organization","site_admin":false},"repo":{"id":117884741,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc4ODQ3NDE=","name":"FirefoxReality","full_name":"MozillaReality/FirefoxReality","private":false,"owner":{"login":"MozillaReality","id":8397321,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzOTczMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/8397321?v=4","gravatar_id":"","url":"https://api.github.com/users/MozillaReality","html_url":"https://github.com/MozillaReality","followers_url":"https://api.github.com/users/MozillaReality/followers","following_url":"https://api.github.com/users/MozillaReality/following{/other_user}","gists_url":"https://api.github.com/users/MozillaReality/gists{/gist_id}","starred_url":"https://api.github.com/users/MozillaReality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MozillaReality/subscriptions","organizations_url":"https://api.github.com/users/MozillaReality/orgs","repos_url":"https://api.github.com/users/MozillaReality/repos","events_url":"https://api.github.com/users/MozillaReality/events{/privacy}","received_events_url":"https://api.github.com/users/MozillaReality/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MozillaReality/FirefoxReality","description":"A fast and secure browser for standalone virtual-reality and augmented-reality headsets.","fork":false,"url":"https://api.github.com/repos/MozillaReality/FirefoxReality","forks_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/forks","keys_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/teams","hooks_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/hooks","issue_events_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/events{/number}","events_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/events","assignees_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/assignees{/user}","branches_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/branches{/branch}","tags_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/tags","blobs_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/git/refs{/sha}","trees_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/statuses/{sha}","languages_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/languages","stargazers_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/stargazers","contributors_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/contributors","subscribers_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/subscribers","subscription_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/subscription","commits_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/commits{/sha}","git_commits_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/git/commits{/sha}","comments_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/comments{/number}","issue_comment_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/comments{/number}","contents_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/contents/{+path}","compare_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/merges","archive_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/downloads","issues_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues{/number}","pulls_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/pulls{/number}","milestones_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/milestones{/number}","notifications_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/labels{/name}","releases_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/releases{/id}","deployments_url":"https://api.github.com/repos/MozillaReality/FirefoxReality/deployments","created_at":"2018-01-17T19:47:04Z","updated_at":"2019-11-14T23:08:03Z","pushed_at":"2019-11-15T10:06:13Z","git_url":"git://github.com/MozillaReality/FirefoxReality.git","ssh_url":"[email protected]:MozillaReality/FirefoxReality.git","clone_url":"https://github.com/MozillaReality/FirefoxReality.git","svn_url":"https://github.com/MozillaReality/FirefoxReality","homepage":"https://mzl.la/reality","size":74684,"stargazers_count":434,"watchers_count":434,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":258,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":79,"open_issues":258,"watchers":434,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MozillaReality/FirefoxReality/pulls/2241"},"html":{"href":"https://github.com/MozillaReality/FirefoxReality/pull/2241"},"issue":{"href":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/2241"},"comments":{"href":"https://api.github.com/repos/MozillaReality/FirefoxReality/issues/2241/comments"},"review_comments":{"href":"https://api.github.com/repos/MozillaReality/FirefoxReality/pulls/2241/comments"},"review_comment":{"href":"https://api.github.com/repos/MozillaReality/FirefoxReality/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MozillaReality/FirefoxReality/pulls/2241/commits"},"statuses":{"href":"https://api.github.com/repos/MozillaReality/FirefoxReality/statuses/c03f9639d0075705ded557ba06e21099441afd9c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 117884741,
"name": "MozillaReality/FirefoxReality",
"url": "https://api.github.com/repos/MozillaReality/FirefoxReality"
}
|
{
"id": 883721,
"login": "Dexterp37",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/883721?",
"url": "https://api.github.com/users/Dexterp37"
}
|
{
"id": 8397321,
"login": "MozillaReality",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8397321?",
"url": "https://api.github.com/orgs/MozillaReality"
}
| 2019-11-15T11:37:59 |
10871198335
|
{"actor":{"display_login":"Dexterp37"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/comments/300303771","pull_request_review_id":257921865,"id":300303771,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMDMwMzc3MQ==","diff_hunk":"@@ -1034,11 +1034,22 @@ bool TessBaseAPI::ProcessPagesMultipageTiff(const l_uint8 *data,\n int page = (tessedit_page_number >= 0) ? tessedit_page_number : 0;\n size_t offset = 0;\n for (; ; ++page) {\n- if (tessedit_page_number >= 0)\n+ if (tessedit_page_number >= 0) {\n page = tessedit_page_number;\n- pix = (data) ? pixReadMemFromMultipageTiff(data, size, &offset)\n- : pixReadFromMultipageTiff(filename, &offset);\n- if (pix == nullptr) break;\n+ int pages_read = 0;\n+ do {\n+ pix = (data) ? pixReadMemFromMultipageTiff(data, size, &offset)\n+ : pixReadFromMultipageTiff(filename, &offset);\t\t\t \n+ pages_read++;\n+ } while (pix != nullptr && pages_read < (page + 1));\n+ }\n+ else {","path":"src/api/baseapi.cpp","position":17,"original_position":17,"commit_id":"75d230a7acc74a656b9d610d40fdd0649f55de36","original_commit_id":"75d230a7acc74a656b9d610d40fdd0649f55de36","user":{"login":"stweil","id":6734573,"node_id":"MDQ6VXNlcjY3MzQ1NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6734573?v=4","gravatar_id":"","url":"https://api.github.com/users/stweil","html_url":"https://github.com/stweil","followers_url":"https://api.github.com/users/stweil/followers","following_url":"https://api.github.com/users/stweil/following{/other_user}","gists_url":"https://api.github.com/users/stweil/gists{/gist_id}","starred_url":"https://api.github.com/users/stweil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stweil/subscriptions","organizations_url":"https://api.github.com/users/stweil/orgs","repos_url":"https://api.github.com/users/stweil/repos","events_url":"https://api.github.com/users/stweil/events{/privacy}","received_events_url":"https://api.github.com/users/stweil/received_events","type":"User","site_admin":false},"body":"This is not the Tesseract coding style.","created_at":"2019-07-04T09:08:06Z","updated_at":"2019-07-04T09:08:06Z","html_url":"https://github.com/tesseract-ocr/tesseract/pull/2538#discussion_r300303771","pull_request_url":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/2538","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/comments/300303771"},"html":{"href":"https://github.com/tesseract-ocr/tesseract/pull/2538#discussion_r300303771"},"pull_request":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/2538"}}},"pull_request":{"url":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/2538","id":294412362,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0NDEyMzYy","html_url":"https://github.com/tesseract-ocr/tesseract/pull/2538","diff_url":"https://github.com/tesseract-ocr/tesseract/pull/2538.diff","patch_url":"https://github.com/tesseract-ocr/tesseract/pull/2538.patch","issue_url":"https://api.github.com/repos/tesseract-ocr/tesseract/issues/2538","number":2538,"state":"closed","locked":false,"title":"fix read wrong tiff page.","user":{"login":"zhuangzhuang","id":521058,"node_id":"MDQ6VXNlcjUyMTA1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/521058?v=4","gravatar_id":"","url":"https://api.github.com/users/zhuangzhuang","html_url":"https://github.com/zhuangzhuang","followers_url":"https://api.github.com/users/zhuangzhuang/followers","following_url":"https://api.github.com/users/zhuangzhuang/following{/other_user}","gists_url":"https://api.github.com/users/zhuangzhuang/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuangzhuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuangzhuang/subscriptions","organizations_url":"https://api.github.com/users/zhuangzhuang/orgs","repos_url":"https://api.github.com/users/zhuangzhuang/repos","events_url":"https://api.github.com/users/zhuangzhuang/events{/privacy}","received_events_url":"https://api.github.com/users/zhuangzhuang/received_events","type":"User","site_admin":false},"body":"fix #2537 ","created_at":"2019-07-04T04:33:23Z","updated_at":"2019-07-04T09:08:06Z","closed_at":"2019-07-04T08:48:42Z","merged_at":"2019-07-04T08:48:42Z","merge_commit_sha":"c11110992b2cdb875fa7c2b7ab53cdf6ee1cbb61","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/2538/commits","review_comments_url":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/2538/comments","review_comment_url":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tesseract-ocr/tesseract/issues/2538/comments","statuses_url":"https://api.github.com/repos/tesseract-ocr/tesseract/statuses/75d230a7acc74a656b9d610d40fdd0649f55de36","head":{"label":"zhuangzhuang:fix_tessedit_page_number_error","ref":"fix_tessedit_page_number_error","sha":"75d230a7acc74a656b9d610d40fdd0649f55de36","user":{"login":"zhuangzhuang","id":521058,"node_id":"MDQ6VXNlcjUyMTA1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/521058?v=4","gravatar_id":"","url":"https://api.github.com/users/zhuangzhuang","html_url":"https://github.com/zhuangzhuang","followers_url":"https://api.github.com/users/zhuangzhuang/followers","following_url":"https://api.github.com/users/zhuangzhuang/following{/other_user}","gists_url":"https://api.github.com/users/zhuangzhuang/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuangzhuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuangzhuang/subscriptions","organizations_url":"https://api.github.com/users/zhuangzhuang/orgs","repos_url":"https://api.github.com/users/zhuangzhuang/repos","events_url":"https://api.github.com/users/zhuangzhuang/events{/privacy}","received_events_url":"https://api.github.com/users/zhuangzhuang/received_events","type":"User","site_admin":false},"repo":{"id":194588895,"node_id":"MDEwOlJlcG9zaXRvcnkxOTQ1ODg4OTU=","name":"tesseract","full_name":"zhuangzhuang/tesseract","private":false,"owner":{"login":"zhuangzhuang","id":521058,"node_id":"MDQ6VXNlcjUyMTA1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/521058?v=4","gravatar_id":"","url":"https://api.github.com/users/zhuangzhuang","html_url":"https://github.com/zhuangzhuang","followers_url":"https://api.github.com/users/zhuangzhuang/followers","following_url":"https://api.github.com/users/zhuangzhuang/following{/other_user}","gists_url":"https://api.github.com/users/zhuangzhuang/gists{/gist_id}","starred_url":"https://api.github.com/users/zhuangzhuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhuangzhuang/subscriptions","organizations_url":"https://api.github.com/users/zhuangzhuang/orgs","repos_url":"https://api.github.com/users/zhuangzhuang/repos","events_url":"https://api.github.com/users/zhuangzhuang/events{/privacy}","received_events_url":"https://api.github.com/users/zhuangzhuang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zhuangzhuang/tesseract","description":"Tesseract Open Source OCR Engine (main repository)","fork":true,"url":"https://api.github.com/repos/zhuangzhuang/tesseract","forks_url":"https://api.github.com/repos/zhuangzhuang/tesseract/forks","keys_url":"https://api.github.com/repos/zhuangzhuang/tesseract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zhuangzhuang/tesseract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zhuangzhuang/tesseract/teams","hooks_url":"https://api.github.com/repos/zhuangzhuang/tesseract/hooks","issue_events_url":"https://api.github.com/repos/zhuangzhuang/tesseract/issues/events{/number}","events_url":"https://api.github.com/repos/zhuangzhuang/tesseract/events","assignees_url":"https://api.github.com/repos/zhuangzhuang/tesseract/assignees{/user}","branches_url":"https://api.github.com/repos/zhuangzhuang/tesseract/branches{/branch}","tags_url":"https://api.github.com/repos/zhuangzhuang/tesseract/tags","blobs_url":"https://api.github.com/repos/zhuangzhuang/tesseract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zhuangzhuang/tesseract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zhuangzhuang/tesseract/git/refs{/sha}","trees_url":"https://api.github.com/repos/zhuangzhuang/tesseract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zhuangzhuang/tesseract/statuses/{sha}","languages_url":"https://api.github.com/repos/zhuangzhuang/tesseract/languages","stargazers_url":"https://api.github.com/repos/zhuangzhuang/tesseract/stargazers","contributors_url":"https://api.github.com/repos/zhuangzhuang/tesseract/contributors","subscribers_url":"https://api.github.com/repos/zhuangzhuang/tesseract/subscribers","subscription_url":"https://api.github.com/repos/zhuangzhuang/tesseract/subscription","commits_url":"https://api.github.com/repos/zhuangzhuang/tesseract/commits{/sha}","git_commits_url":"https://api.github.com/repos/zhuangzhuang/tesseract/git/commits{/sha}","comments_url":"https://api.github.com/repos/zhuangzhuang/tesseract/comments{/number}","issue_comment_url":"https://api.github.com/repos/zhuangzhuang/tesseract/issues/comments{/number}","contents_url":"https://api.github.com/repos/zhuangzhuang/tesseract/contents/{+path}","compare_url":"https://api.github.com/repos/zhuangzhuang/tesseract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zhuangzhuang/tesseract/merges","archive_url":"https://api.github.com/repos/zhuangzhuang/tesseract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zhuangzhuang/tesseract/downloads","issues_url":"https://api.github.com/repos/zhuangzhuang/tesseract/issues{/number}","pulls_url":"https://api.github.com/repos/zhuangzhuang/tesseract/pulls{/number}","milestones_url":"https://api.github.com/repos/zhuangzhuang/tesseract/milestones{/number}","notifications_url":"https://api.github.com/repos/zhuangzhuang/tesseract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zhuangzhuang/tesseract/labels{/name}","releases_url":"https://api.github.com/repos/zhuangzhuang/tesseract/releases{/id}","deployments_url":"https://api.github.com/repos/zhuangzhuang/tesseract/deployments","created_at":"2019-07-01T02:49:22Z","updated_at":"2019-07-04T04:19:06Z","pushed_at":"2019-07-04T08:50:12Z","git_url":"git://github.com/zhuangzhuang/tesseract.git","ssh_url":"[email protected]:zhuangzhuang/tesseract.git","clone_url":"https://github.com/zhuangzhuang/tesseract.git","svn_url":"https://github.com/zhuangzhuang/tesseract","homepage":"","size":44280,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tesseract-ocr:master","ref":"master","sha":"4c8b7d5e3539bae18eb8337d5ebc1fccf56c1f93","user":{"login":"tesseract-ocr","id":8401422,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MDE0MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/8401422?v=4","gravatar_id":"","url":"https://api.github.com/users/tesseract-ocr","html_url":"https://github.com/tesseract-ocr","followers_url":"https://api.github.com/users/tesseract-ocr/followers","following_url":"https://api.github.com/users/tesseract-ocr/following{/other_user}","gists_url":"https://api.github.com/users/tesseract-ocr/gists{/gist_id}","starred_url":"https://api.github.com/users/tesseract-ocr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tesseract-ocr/subscriptions","organizations_url":"https://api.github.com/users/tesseract-ocr/orgs","repos_url":"https://api.github.com/users/tesseract-ocr/repos","events_url":"https://api.github.com/users/tesseract-ocr/events{/privacy}","received_events_url":"https://api.github.com/users/tesseract-ocr/received_events","type":"Organization","site_admin":false},"repo":{"id":22887094,"node_id":"MDEwOlJlcG9zaXRvcnkyMjg4NzA5NA==","name":"tesseract","full_name":"tesseract-ocr/tesseract","private":false,"owner":{"login":"tesseract-ocr","id":8401422,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MDE0MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/8401422?v=4","gravatar_id":"","url":"https://api.github.com/users/tesseract-ocr","html_url":"https://github.com/tesseract-ocr","followers_url":"https://api.github.com/users/tesseract-ocr/followers","following_url":"https://api.github.com/users/tesseract-ocr/following{/other_user}","gists_url":"https://api.github.com/users/tesseract-ocr/gists{/gist_id}","starred_url":"https://api.github.com/users/tesseract-ocr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tesseract-ocr/subscriptions","organizations_url":"https://api.github.com/users/tesseract-ocr/orgs","repos_url":"https://api.github.com/users/tesseract-ocr/repos","events_url":"https://api.github.com/users/tesseract-ocr/events{/privacy}","received_events_url":"https://api.github.com/users/tesseract-ocr/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tesseract-ocr/tesseract","description":"Tesseract Open Source OCR Engine (main repository)","fork":false,"url":"https://api.github.com/repos/tesseract-ocr/tesseract","forks_url":"https://api.github.com/repos/tesseract-ocr/tesseract/forks","keys_url":"https://api.github.com/repos/tesseract-ocr/tesseract/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tesseract-ocr/tesseract/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tesseract-ocr/tesseract/teams","hooks_url":"https://api.github.com/repos/tesseract-ocr/tesseract/hooks","issue_events_url":"https://api.github.com/repos/tesseract-ocr/tesseract/issues/events{/number}","events_url":"https://api.github.com/repos/tesseract-ocr/tesseract/events","assignees_url":"https://api.github.com/repos/tesseract-ocr/tesseract/assignees{/user}","branches_url":"https://api.github.com/repos/tesseract-ocr/tesseract/branches{/branch}","tags_url":"https://api.github.com/repos/tesseract-ocr/tesseract/tags","blobs_url":"https://api.github.com/repos/tesseract-ocr/tesseract/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tesseract-ocr/tesseract/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tesseract-ocr/tesseract/git/refs{/sha}","trees_url":"https://api.github.com/repos/tesseract-ocr/tesseract/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tesseract-ocr/tesseract/statuses/{sha}","languages_url":"https://api.github.com/repos/tesseract-ocr/tesseract/languages","stargazers_url":"https://api.github.com/repos/tesseract-ocr/tesseract/stargazers","contributors_url":"https://api.github.com/repos/tesseract-ocr/tesseract/contributors","subscribers_url":"https://api.github.com/repos/tesseract-ocr/tesseract/subscribers","subscription_url":"https://api.github.com/repos/tesseract-ocr/tesseract/subscription","commits_url":"https://api.github.com/repos/tesseract-ocr/tesseract/commits{/sha}","git_commits_url":"https://api.github.com/repos/tesseract-ocr/tesseract/git/commits{/sha}","comments_url":"https://api.github.com/repos/tesseract-ocr/tesseract/comments{/number}","issue_comment_url":"https://api.github.com/repos/tesseract-ocr/tesseract/issues/comments{/number}","contents_url":"https://api.github.com/repos/tesseract-ocr/tesseract/contents/{+path}","compare_url":"https://api.github.com/repos/tesseract-ocr/tesseract/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tesseract-ocr/tesseract/merges","archive_url":"https://api.github.com/repos/tesseract-ocr/tesseract/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tesseract-ocr/tesseract/downloads","issues_url":"https://api.github.com/repos/tesseract-ocr/tesseract/issues{/number}","pulls_url":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls{/number}","milestones_url":"https://api.github.com/repos/tesseract-ocr/tesseract/milestones{/number}","notifications_url":"https://api.github.com/repos/tesseract-ocr/tesseract/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tesseract-ocr/tesseract/labels{/name}","releases_url":"https://api.github.com/repos/tesseract-ocr/tesseract/releases{/id}","deployments_url":"https://api.github.com/repos/tesseract-ocr/tesseract/deployments","created_at":"2014-08-12T18:04:59Z","updated_at":"2019-07-04T09:00:08Z","pushed_at":"2019-07-04T08:48:43Z","git_url":"git://github.com/tesseract-ocr/tesseract.git","ssh_url":"[email protected]:tesseract-ocr/tesseract.git","clone_url":"https://github.com/tesseract-ocr/tesseract.git","svn_url":"https://github.com/tesseract-ocr/tesseract","homepage":"","size":44284,"stargazers_count":28064,"watchers_count":28064,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5366,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":226,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5366,"open_issues":226,"watchers":28064,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/2538"},"html":{"href":"https://github.com/tesseract-ocr/tesseract/pull/2538"},"issue":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/issues/2538"},"comments":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/issues/2538/comments"},"review_comments":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/2538/comments"},"review_comment":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/pulls/2538/commits"},"statuses":{"href":"https://api.github.com/repos/tesseract-ocr/tesseract/statuses/75d230a7acc74a656b9d610d40fdd0649f55de36"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 22887094,
"name": "tesseract-ocr/tesseract",
"url": "https://api.github.com/repos/tesseract-ocr/tesseract"
}
|
{
"id": 6734573,
"login": "stweil",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6734573?",
"url": "https://api.github.com/users/stweil"
}
|
{
"id": 8401422,
"login": "tesseract-ocr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8401422?",
"url": "https://api.github.com/orgs/tesseract-ocr"
}
| 2019-07-04T09:08:06 |
9948526939
|
{"actor":{"display_login":"stweil"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/matrix-org/synapse/pulls/comments/327231272","pull_request_review_id":291928600,"id":327231272,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNzIzMTI3Mg==","diff_hunk":"@@ -12,11 +13,29 @@\n # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n # See the License for the specific language governing permissions and\n # limitations under the License.\n+\n from synapse.python_dependencies import DependencyException, check_requirements\n+from synapse.util.module_loader import load_python_module\n \n from ._base import Config, ConfigError\n \n \n+def _dict_merge(merge_dict, into_dct):","path":"synapse/config/saml2_config.py","position":18,"original_position":18,"commit_id":"284e1cb027c2c5e8376a5b83d21d626e18dcbc33","original_commit_id":"284e1cb027c2c5e8376a5b83d21d626e18dcbc33","user":{"login":"erikjohnston","id":8428120,"node_id":"MDQ6VXNlcjg0MjgxMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/8428120?v=4","gravatar_id":"","url":"https://api.github.com/users/erikjohnston","html_url":"https://github.com/erikjohnston","followers_url":"https://api.github.com/users/erikjohnston/followers","following_url":"https://api.github.com/users/erikjohnston/following{/other_user}","gists_url":"https://api.github.com/users/erikjohnston/gists{/gist_id}","starred_url":"https://api.github.com/users/erikjohnston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikjohnston/subscriptions","organizations_url":"https://api.github.com/users/erikjohnston/orgs","repos_url":"https://api.github.com/users/erikjohnston/repos","events_url":"https://api.github.com/users/erikjohnston/events{/privacy}","received_events_url":"https://api.github.com/users/erikjohnston/received_events","type":"User","site_admin":false},"body":"Docstrings please. This looks to be attempting a deep merge? Is that what we want?","created_at":"2019-09-23T17:14:07Z","updated_at":"2019-09-23T17:16:07Z","html_url":"https://github.com/matrix-org/synapse/pull/6069#discussion_r327231272","pull_request_url":"https://api.github.com/repos/matrix-org/synapse/pulls/6069","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/comments/327231272"},"html":{"href":"https://github.com/matrix-org/synapse/pull/6069#discussion_r327231272"},"pull_request":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/6069"}}},"pull_request":{"url":"https://api.github.com/repos/matrix-org/synapse/pulls/6069","id":319429975,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE5NDI5OTc1","html_url":"https://github.com/matrix-org/synapse/pull/6069","diff_url":"https://github.com/matrix-org/synapse/pull/6069.diff","patch_url":"https://github.com/matrix-org/synapse/pull/6069.patch","issue_url":"https://api.github.com/repos/matrix-org/synapse/issues/6069","number":6069,"state":"open","locked":false,"title":"Fix a bug with saml attribute maps.","user":{"login":"richvdh","id":1389908,"node_id":"MDQ6VXNlcjEzODk5MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1389908?v=4","gravatar_id":"","url":"https://api.github.com/users/richvdh","html_url":"https://github.com/richvdh","followers_url":"https://api.github.com/users/richvdh/followers","following_url":"https://api.github.com/users/richvdh/following{/other_user}","gists_url":"https://api.github.com/users/richvdh/gists{/gist_id}","starred_url":"https://api.github.com/users/richvdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richvdh/subscriptions","organizations_url":"https://api.github.com/users/richvdh/orgs","repos_url":"https://api.github.com/users/richvdh/repos","events_url":"https://api.github.com/users/richvdh/events{/privacy}","received_events_url":"https://api.github.com/users/richvdh/received_events","type":"User","site_admin":false},"body":"Fixes a bug where the default attribute maps were prioritised over\nuser-specified ones, resulting in incorrect mappings.\n\nThe problem is that if you call SPConfig.load() multiple times, it adds new\nattribute mappers to a list. So by calling it with the default config first,\nand then the user-specified config, we would always get the default mappers\nbefore the user-specified mappers.\n\nTo solve this, let's merge the config dicts first, and then pass them to\nSPConfig.","created_at":"2019-09-19T19:31:35Z","updated_at":"2019-09-23T17:16:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ba2d8b2005c4edb71ccf55cc779a9f97200dad7","assignee":{"login":"richvdh","id":1389908,"node_id":"MDQ6VXNlcjEzODk5MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1389908?v=4","gravatar_id":"","url":"https://api.github.com/users/richvdh","html_url":"https://github.com/richvdh","followers_url":"https://api.github.com/users/richvdh/followers","following_url":"https://api.github.com/users/richvdh/following{/other_user}","gists_url":"https://api.github.com/users/richvdh/gists{/gist_id}","starred_url":"https://api.github.com/users/richvdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richvdh/subscriptions","organizations_url":"https://api.github.com/users/richvdh/orgs","repos_url":"https://api.github.com/users/richvdh/repos","events_url":"https://api.github.com/users/richvdh/events{/privacy}","received_events_url":"https://api.github.com/users/richvdh/received_events","type":"User","site_admin":false},"assignees":[{"login":"richvdh","id":1389908,"node_id":"MDQ6VXNlcjEzODk5MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/1389908?v=4","gravatar_id":"","url":"https://api.github.com/users/richvdh","html_url":"https://github.com/richvdh","followers_url":"https://api.github.com/users/richvdh/followers","following_url":"https://api.github.com/users/richvdh/following{/other_user}","gists_url":"https://api.github.com/users/richvdh/gists{/gist_id}","starred_url":"https://api.github.com/users/richvdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richvdh/subscriptions","organizations_url":"https://api.github.com/users/richvdh/orgs","repos_url":"https://api.github.com/users/richvdh/repos","events_url":"https://api.github.com/users/richvdh/events{/privacy}","received_events_url":"https://api.github.com/users/richvdh/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/matrix-org/synapse/pulls/6069/commits","review_comments_url":"https://api.github.com/repos/matrix-org/synapse/pulls/6069/comments","review_comment_url":"https://api.github.com/repos/matrix-org/synapse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matrix-org/synapse/issues/6069/comments","statuses_url":"https://api.github.com/repos/matrix-org/synapse/statuses/284e1cb027c2c5e8376a5b83d21d626e18dcbc33","head":{"label":"matrix-org:rav/fix_attribute_mapping","ref":"rav/fix_attribute_mapping","sha":"284e1cb027c2c5e8376a5b83d21d626e18dcbc33","user":{"login":"matrix-org","id":8418310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MTgzMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":22844864,"node_id":"MDEwOlJlcG9zaXRvcnkyMjg0NDg2NA==","name":"synapse","full_name":"matrix-org/synapse","private":false,"owner":{"login":"matrix-org","id":8418310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MTgzMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/matrix-org/synapse","description":"Synapse: Matrix reference homeserver","fork":false,"url":"https://api.github.com/repos/matrix-org/synapse","forks_url":"https://api.github.com/repos/matrix-org/synapse/forks","keys_url":"https://api.github.com/repos/matrix-org/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/synapse/teams","hooks_url":"https://api.github.com/repos/matrix-org/synapse/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/synapse/events","assignees_url":"https://api.github.com/repos/matrix-org/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/synapse/tags","blobs_url":"https://api.github.com/repos/matrix-org/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/synapse/languages","stargazers_url":"https://api.github.com/repos/matrix-org/synapse/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/synapse/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/synapse/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/synapse/subscription","commits_url":"https://api.github.com/repos/matrix-org/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/synapse/merges","archive_url":"https://api.github.com/repos/matrix-org/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/synapse/downloads","issues_url":"https://api.github.com/repos/matrix-org/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/synapse/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/synapse/deployments","created_at":"2014-08-11T15:51:42Z","updated_at":"2019-09-23T12:47:07Z","pushed_at":"2019-09-23T17:12:41Z","git_url":"git://github.com/matrix-org/synapse.git","ssh_url":"[email protected]:matrix-org/synapse.git","clone_url":"https://github.com/matrix-org/synapse.git","svn_url":"https://github.com/matrix-org/synapse","homepage":"http://matrix.org","size":53883,"stargazers_count":4621,"watchers_count":4621,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":752,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1105,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":752,"open_issues":1105,"watchers":4621,"default_branch":"master"}},"base":{"label":"matrix-org:develop","ref":"develop","sha":"fe349b497e4b22bb409eb199b77479c5895af525","user":{"login":"matrix-org","id":8418310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MTgzMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"repo":{"id":22844864,"node_id":"MDEwOlJlcG9zaXRvcnkyMjg0NDg2NA==","name":"synapse","full_name":"matrix-org/synapse","private":false,"owner":{"login":"matrix-org","id":8418310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MTgzMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/8418310?v=4","gravatar_id":"","url":"https://api.github.com/users/matrix-org","html_url":"https://github.com/matrix-org","followers_url":"https://api.github.com/users/matrix-org/followers","following_url":"https://api.github.com/users/matrix-org/following{/other_user}","gists_url":"https://api.github.com/users/matrix-org/gists{/gist_id}","starred_url":"https://api.github.com/users/matrix-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matrix-org/subscriptions","organizations_url":"https://api.github.com/users/matrix-org/orgs","repos_url":"https://api.github.com/users/matrix-org/repos","events_url":"https://api.github.com/users/matrix-org/events{/privacy}","received_events_url":"https://api.github.com/users/matrix-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/matrix-org/synapse","description":"Synapse: Matrix reference homeserver","fork":false,"url":"https://api.github.com/repos/matrix-org/synapse","forks_url":"https://api.github.com/repos/matrix-org/synapse/forks","keys_url":"https://api.github.com/repos/matrix-org/synapse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matrix-org/synapse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matrix-org/synapse/teams","hooks_url":"https://api.github.com/repos/matrix-org/synapse/hooks","issue_events_url":"https://api.github.com/repos/matrix-org/synapse/issues/events{/number}","events_url":"https://api.github.com/repos/matrix-org/synapse/events","assignees_url":"https://api.github.com/repos/matrix-org/synapse/assignees{/user}","branches_url":"https://api.github.com/repos/matrix-org/synapse/branches{/branch}","tags_url":"https://api.github.com/repos/matrix-org/synapse/tags","blobs_url":"https://api.github.com/repos/matrix-org/synapse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matrix-org/synapse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matrix-org/synapse/git/refs{/sha}","trees_url":"https://api.github.com/repos/matrix-org/synapse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matrix-org/synapse/statuses/{sha}","languages_url":"https://api.github.com/repos/matrix-org/synapse/languages","stargazers_url":"https://api.github.com/repos/matrix-org/synapse/stargazers","contributors_url":"https://api.github.com/repos/matrix-org/synapse/contributors","subscribers_url":"https://api.github.com/repos/matrix-org/synapse/subscribers","subscription_url":"https://api.github.com/repos/matrix-org/synapse/subscription","commits_url":"https://api.github.com/repos/matrix-org/synapse/commits{/sha}","git_commits_url":"https://api.github.com/repos/matrix-org/synapse/git/commits{/sha}","comments_url":"https://api.github.com/repos/matrix-org/synapse/comments{/number}","issue_comment_url":"https://api.github.com/repos/matrix-org/synapse/issues/comments{/number}","contents_url":"https://api.github.com/repos/matrix-org/synapse/contents/{+path}","compare_url":"https://api.github.com/repos/matrix-org/synapse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matrix-org/synapse/merges","archive_url":"https://api.github.com/repos/matrix-org/synapse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matrix-org/synapse/downloads","issues_url":"https://api.github.com/repos/matrix-org/synapse/issues{/number}","pulls_url":"https://api.github.com/repos/matrix-org/synapse/pulls{/number}","milestones_url":"https://api.github.com/repos/matrix-org/synapse/milestones{/number}","notifications_url":"https://api.github.com/repos/matrix-org/synapse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matrix-org/synapse/labels{/name}","releases_url":"https://api.github.com/repos/matrix-org/synapse/releases{/id}","deployments_url":"https://api.github.com/repos/matrix-org/synapse/deployments","created_at":"2014-08-11T15:51:42Z","updated_at":"2019-09-23T12:47:07Z","pushed_at":"2019-09-23T17:12:41Z","git_url":"git://github.com/matrix-org/synapse.git","ssh_url":"[email protected]:matrix-org/synapse.git","clone_url":"https://github.com/matrix-org/synapse.git","svn_url":"https://github.com/matrix-org/synapse","homepage":"http://matrix.org","size":53883,"stargazers_count":4621,"watchers_count":4621,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":752,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1105,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":752,"open_issues":1105,"watchers":4621,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/6069"},"html":{"href":"https://github.com/matrix-org/synapse/pull/6069"},"issue":{"href":"https://api.github.com/repos/matrix-org/synapse/issues/6069"},"comments":{"href":"https://api.github.com/repos/matrix-org/synapse/issues/6069/comments"},"review_comments":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/6069/comments"},"review_comment":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matrix-org/synapse/pulls/6069/commits"},"statuses":{"href":"https://api.github.com/repos/matrix-org/synapse/statuses/284e1cb027c2c5e8376a5b83d21d626e18dcbc33"}},"author_association":"MEMBER"}}
|
{
"id": 22844864,
"name": "matrix-org/synapse",
"url": "https://api.github.com/repos/matrix-org/synapse"
}
|
{
"id": 8428120,
"login": "erikjohnston",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8428120?",
"url": "https://api.github.com/users/erikjohnston"
}
|
{
"id": 8418310,
"login": "matrix-org",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8418310?",
"url": "https://api.github.com/orgs/matrix-org"
}
| 2019-09-23T17:14:07 |
10475856454
|
{"actor":{"display_login":"erikjohnston"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/pixelcollective/ndncollective.org/pulls/comments/274034242","pull_request_review_id":225063623,"id":274034242,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NDAzNDI0Mg==","diff_hunk":"@@ -0,0 +1,60 @@\n+.wp-block-tiny-pixel-video-bg-heading {\n+ background: black;\n+\n+ section.interlude {","path":"ndncollective.org/web/app/plugins/ndn-blocks/resources/styles/blocks/_video-bg-splash.scss","position":4,"original_position":4,"commit_id":"329211d88d9c5c9a1d82044c4c42dc43f8c5f63f","original_commit_id":"329211d88d9c5c9a1d82044c4c42dc43f8c5f63f","user":{"login":"hound[bot]","id":30008653,"node_id":"MDM6Qm90MzAwMDg2NTM=","avatar_url":"https://avatars1.githubusercontent.com/in/3598?v=4","gravatar_id":"","url":"https://api.github.com/users/hound%5Bbot%5D","html_url":"https://github.com/apps/hound","followers_url":"https://api.github.com/users/hound%5Bbot%5D/followers","following_url":"https://api.github.com/users/hound%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/hound%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/hound%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hound%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/hound%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/hound%5Bbot%5D/repos","events_url":"https://api.github.com/users/hound%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/hound%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Avoid qualifying class selectors with an element.","created_at":"2019-04-10T15:52:53Z","updated_at":"2019-04-10T15:52:55Z","html_url":"https://github.com/pixelcollective/ndncollective.org/pull/83#discussion_r274034242","pull_request_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/pulls/83","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/pixelcollective/ndncollective.org/pulls/comments/274034242"},"html":{"href":"https://github.com/pixelcollective/ndncollective.org/pull/83#discussion_r274034242"},"pull_request":{"href":"https://api.github.com/repos/pixelcollective/ndncollective.org/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/pixelcollective/ndncollective.org/pulls/83","id":267965918,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY3OTY1OTE4","html_url":"https://github.com/pixelcollective/ndncollective.org/pull/83","diff_url":"https://github.com/pixelcollective/ndncollective.org/pull/83.diff","patch_url":"https://github.com/pixelcollective/ndncollective.org/pull/83.patch","issue_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/issues/83","number":83,"state":"open","locked":false,"title":"Content Flexibility Update","user":{"login":"kellymears","id":397606,"node_id":"MDQ6VXNlcjM5NzYwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/397606?v=4","gravatar_id":"","url":"https://api.github.com/users/kellymears","html_url":"https://github.com/kellymears","followers_url":"https://api.github.com/users/kellymears/followers","following_url":"https://api.github.com/users/kellymears/following{/other_user}","gists_url":"https://api.github.com/users/kellymears/gists{/gist_id}","starred_url":"https://api.github.com/users/kellymears/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellymears/subscriptions","organizations_url":"https://api.github.com/users/kellymears/orgs","repos_url":"https://api.github.com/users/kellymears/repos","events_url":"https://api.github.com/users/kellymears/events{/privacy}","received_events_url":"https://api.github.com/users/kellymears/received_events","type":"User","site_admin":false},"body":"This PR will serve as a base for all updates related to this week's upcoming overhaul of the editor, content fields, and site templating.","created_at":"2019-04-05T21:08:59Z","updated_at":"2019-04-10T15:52:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbcd8b4a04a0bff063e6b353c0b71f2bfb4d6009","assignee":{"login":"kellymears","id":397606,"node_id":"MDQ6VXNlcjM5NzYwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/397606?v=4","gravatar_id":"","url":"https://api.github.com/users/kellymears","html_url":"https://github.com/kellymears","followers_url":"https://api.github.com/users/kellymears/followers","following_url":"https://api.github.com/users/kellymears/following{/other_user}","gists_url":"https://api.github.com/users/kellymears/gists{/gist_id}","starred_url":"https://api.github.com/users/kellymears/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellymears/subscriptions","organizations_url":"https://api.github.com/users/kellymears/orgs","repos_url":"https://api.github.com/users/kellymears/repos","events_url":"https://api.github.com/users/kellymears/events{/privacy}","received_events_url":"https://api.github.com/users/kellymears/received_events","type":"User","site_admin":false},"assignees":[{"login":"kellymears","id":397606,"node_id":"MDQ6VXNlcjM5NzYwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/397606?v=4","gravatar_id":"","url":"https://api.github.com/users/kellymears","html_url":"https://github.com/kellymears","followers_url":"https://api.github.com/users/kellymears/followers","following_url":"https://api.github.com/users/kellymears/following{/other_user}","gists_url":"https://api.github.com/users/kellymears/gists{/gist_id}","starred_url":"https://api.github.com/users/kellymears/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellymears/subscriptions","organizations_url":"https://api.github.com/users/kellymears/orgs","repos_url":"https://api.github.com/users/kellymears/repos","events_url":"https://api.github.com/users/kellymears/events{/privacy}","received_events_url":"https://api.github.com/users/kellymears/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/pulls/83/commits","review_comments_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/pulls/83/comments","review_comment_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/issues/83/comments","statuses_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/statuses/329211d88d9c5c9a1d82044c4c42dc43f8c5f63f","head":{"label":"pixelcollective:development","ref":"development","sha":"329211d88d9c5c9a1d82044c4c42dc43f8c5f63f","user":{"login":"pixelcollective","id":8436103,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MzYxMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/8436103?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelcollective","html_url":"https://github.com/pixelcollective","followers_url":"https://api.github.com/users/pixelcollective/followers","following_url":"https://api.github.com/users/pixelcollective/following{/other_user}","gists_url":"https://api.github.com/users/pixelcollective/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelcollective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelcollective/subscriptions","organizations_url":"https://api.github.com/users/pixelcollective/orgs","repos_url":"https://api.github.com/users/pixelcollective/repos","events_url":"https://api.github.com/users/pixelcollective/events{/privacy}","received_events_url":"https://api.github.com/users/pixelcollective/received_events","type":"Organization","site_admin":false},"repo":{"id":139897966,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4OTc5NjY=","name":"ndncollective.org","full_name":"pixelcollective/ndncollective.org","private":false,"owner":{"login":"pixelcollective","id":8436103,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MzYxMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/8436103?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelcollective","html_url":"https://github.com/pixelcollective","followers_url":"https://api.github.com/users/pixelcollective/followers","following_url":"https://api.github.com/users/pixelcollective/following{/other_user}","gists_url":"https://api.github.com/users/pixelcollective/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelcollective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelcollective/subscriptions","organizations_url":"https://api.github.com/users/pixelcollective/orgs","repos_url":"https://api.github.com/users/pixelcollective/repos","events_url":"https://api.github.com/users/pixelcollective/events{/privacy}","received_events_url":"https://api.github.com/users/pixelcollective/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pixelcollective/ndncollective.org","description":"NDN Collective","fork":false,"url":"https://api.github.com/repos/pixelcollective/ndncollective.org","forks_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/forks","keys_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/teams","hooks_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/hooks","issue_events_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/issues/events{/number}","events_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/events","assignees_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/assignees{/user}","branches_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/branches{/branch}","tags_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/tags","blobs_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/statuses/{sha}","languages_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/languages","stargazers_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/stargazers","contributors_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/contributors","subscribers_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/subscribers","subscription_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/subscription","commits_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/contents/{+path}","compare_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/merges","archive_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/downloads","issues_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/issues{/number}","pulls_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/pulls{/number}","milestones_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/milestones{/number}","notifications_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/labels{/name}","releases_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/releases{/id}","deployments_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/deployments","created_at":"2018-07-05T20:39:08Z","updated_at":"2019-04-03T14:03:19Z","pushed_at":"2019-04-10T15:50:00Z","git_url":"git://github.com/pixelcollective/ndncollective.org.git","ssh_url":"[email protected]:pixelcollective/ndncollective.org.git","clone_url":"https://github.com/pixelcollective/ndncollective.org.git","svn_url":"https://github.com/pixelcollective/ndncollective.org","homepage":"https://ndncollective.org","size":187410,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"pixelcollective:master","ref":"master","sha":"189a7978c43b000c76ded79154801b3b5e62bb35","user":{"login":"pixelcollective","id":8436103,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MzYxMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/8436103?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelcollective","html_url":"https://github.com/pixelcollective","followers_url":"https://api.github.com/users/pixelcollective/followers","following_url":"https://api.github.com/users/pixelcollective/following{/other_user}","gists_url":"https://api.github.com/users/pixelcollective/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelcollective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelcollective/subscriptions","organizations_url":"https://api.github.com/users/pixelcollective/orgs","repos_url":"https://api.github.com/users/pixelcollective/repos","events_url":"https://api.github.com/users/pixelcollective/events{/privacy}","received_events_url":"https://api.github.com/users/pixelcollective/received_events","type":"Organization","site_admin":false},"repo":{"id":139897966,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4OTc5NjY=","name":"ndncollective.org","full_name":"pixelcollective/ndncollective.org","private":false,"owner":{"login":"pixelcollective","id":8436103,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg0MzYxMDM=","avatar_url":"https://avatars2.githubusercontent.com/u/8436103?v=4","gravatar_id":"","url":"https://api.github.com/users/pixelcollective","html_url":"https://github.com/pixelcollective","followers_url":"https://api.github.com/users/pixelcollective/followers","following_url":"https://api.github.com/users/pixelcollective/following{/other_user}","gists_url":"https://api.github.com/users/pixelcollective/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelcollective/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelcollective/subscriptions","organizations_url":"https://api.github.com/users/pixelcollective/orgs","repos_url":"https://api.github.com/users/pixelcollective/repos","events_url":"https://api.github.com/users/pixelcollective/events{/privacy}","received_events_url":"https://api.github.com/users/pixelcollective/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pixelcollective/ndncollective.org","description":"NDN Collective","fork":false,"url":"https://api.github.com/repos/pixelcollective/ndncollective.org","forks_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/forks","keys_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/teams","hooks_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/hooks","issue_events_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/issues/events{/number}","events_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/events","assignees_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/assignees{/user}","branches_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/branches{/branch}","tags_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/tags","blobs_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/statuses/{sha}","languages_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/languages","stargazers_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/stargazers","contributors_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/contributors","subscribers_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/subscribers","subscription_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/subscription","commits_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/contents/{+path}","compare_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/merges","archive_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/downloads","issues_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/issues{/number}","pulls_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/pulls{/number}","milestones_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/milestones{/number}","notifications_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/labels{/name}","releases_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/releases{/id}","deployments_url":"https://api.github.com/repos/pixelcollective/ndncollective.org/deployments","created_at":"2018-07-05T20:39:08Z","updated_at":"2019-04-03T14:03:19Z","pushed_at":"2019-04-10T15:50:00Z","git_url":"git://github.com/pixelcollective/ndncollective.org.git","ssh_url":"[email protected]:pixelcollective/ndncollective.org.git","clone_url":"https://github.com/pixelcollective/ndncollective.org.git","svn_url":"https://github.com/pixelcollective/ndncollective.org","homepage":"https://ndncollective.org","size":187410,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pixelcollective/ndncollective.org/pulls/83"},"html":{"href":"https://github.com/pixelcollective/ndncollective.org/pull/83"},"issue":{"href":"https://api.github.com/repos/pixelcollective/ndncollective.org/issues/83"},"comments":{"href":"https://api.github.com/repos/pixelcollective/ndncollective.org/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/pixelcollective/ndncollective.org/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/pixelcollective/ndncollective.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pixelcollective/ndncollective.org/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/pixelcollective/ndncollective.org/statuses/329211d88d9c5c9a1d82044c4c42dc43f8c5f63f"}},"author_association":"MEMBER"}}
|
{
"id": 139897966,
"name": "pixelcollective/ndncollective.org",
"url": "https://api.github.com/repos/pixelcollective/ndncollective.org"
}
|
{
"id": 30008653,
"login": "hound[bot]",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/30008653?",
"url": "https://api.github.com/users/hound[bot]"
}
|
{
"id": 8436103,
"login": "pixelcollective",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8436103?",
"url": "https://api.github.com/orgs/pixelcollective"
}
| 2019-04-10T15:52:53 |
9417054590
|
{"actor":{"display_login":"hound"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/appbaseio/react-searchbox/pulls/comments/332014504","pull_request_review_id":298118632,"id":332014504,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzMjAxNDUwNA==","diff_hunk":"@@ -175,8 +175,9 @@ class SearchBox extends Component {\n \n setValue = ({ value, isOpen = true, ...rest }) => {\n if (this.props.value) {\n- if (this.props.onChange)\n+ if (this.props.onChange) {","path":"src/components/SearchBox.js","position":50,"original_position":50,"commit_id":"b0c9f666296a34567d15b2fdc0d981cd9c5d273f","original_commit_id":"b0c9f666296a34567d15b2fdc0d981cd9c5d273f","user":{"login":"jyash97","id":22376783,"node_id":"MDQ6VXNlcjIyMzc2Nzgz","avatar_url":"https://avatars0.githubusercontent.com/u/22376783?v=4","gravatar_id":"","url":"https://api.github.com/users/jyash97","html_url":"https://github.com/jyash97","followers_url":"https://api.github.com/users/jyash97/followers","following_url":"https://api.github.com/users/jyash97/following{/other_user}","gists_url":"https://api.github.com/users/jyash97/gists{/gist_id}","starred_url":"https://api.github.com/users/jyash97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jyash97/subscriptions","organizations_url":"https://api.github.com/users/jyash97/orgs","repos_url":"https://api.github.com/users/jyash97/repos","events_url":"https://api.github.com/users/jyash97/events{/privacy}","received_events_url":"https://api.github.com/users/jyash97/received_events","type":"User","site_admin":false},"body":"Destructure the value first from `this.props`","created_at":"2019-10-07T13:23:02Z","updated_at":"2019-10-07T13:33:06Z","html_url":"https://github.com/appbaseio/react-searchbox/pull/2#discussion_r332014504","pull_request_url":"https://api.github.com/repos/appbaseio/react-searchbox/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/appbaseio/react-searchbox/pulls/comments/332014504"},"html":{"href":"https://github.com/appbaseio/react-searchbox/pull/2#discussion_r332014504"},"pull_request":{"href":"https://api.github.com/repos/appbaseio/react-searchbox/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/appbaseio/react-searchbox/pulls/2","id":322895333,"node_id":"MDExOlB1bGxSZXF1ZXN0MzIyODk1MzMz","html_url":"https://github.com/appbaseio/react-searchbox/pull/2","diff_url":"https://github.com/appbaseio/react-searchbox/pull/2.diff","patch_url":"https://github.com/appbaseio/react-searchbox/pull/2.patch","issue_url":"https://api.github.com/repos/appbaseio/react-searchbox/issues/2","number":2,"state":"open","locked":false,"title":"voice integration, rollup config, readme and storybook [voice testing remaining]","user":{"login":"ShahAnuj2610","id":10362927,"node_id":"MDQ6VXNlcjEwMzYyOTI3","avatar_url":"https://avatars3.githubusercontent.com/u/10362927?v=4","gravatar_id":"","url":"https://api.github.com/users/ShahAnuj2610","html_url":"https://github.com/ShahAnuj2610","followers_url":"https://api.github.com/users/ShahAnuj2610/followers","following_url":"https://api.github.com/users/ShahAnuj2610/following{/other_user}","gists_url":"https://api.github.com/users/ShahAnuj2610/gists{/gist_id}","starred_url":"https://api.github.com/users/ShahAnuj2610/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShahAnuj2610/subscriptions","organizations_url":"https://api.github.com/users/ShahAnuj2610/orgs","repos_url":"https://api.github.com/users/ShahAnuj2610/repos","events_url":"https://api.github.com/users/ShahAnuj2610/events{/privacy}","received_events_url":"https://api.github.com/users/ShahAnuj2610/received_events","type":"User","site_admin":false},"body":"voice testing dependent on this => https://github.com/appbaseio/searchbase/commit/6d4679543471de625eea33f56bf724d566141239, will lyk once this is published\r\n@bietkul do lmk once the latest `master` branch for `SearchBase` is deployed","created_at":"2019-09-30T17:38:05Z","updated_at":"2019-10-07T13:33:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f3b8a2ff5913e30b9d9435bd580fd807775112e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/appbaseio/react-searchbox/pulls/2/commits","review_comments_url":"https://api.github.com/repos/appbaseio/react-searchbox/pulls/2/comments","review_comment_url":"https://api.github.com/repos/appbaseio/react-searchbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appbaseio/react-searchbox/issues/2/comments","statuses_url":"https://api.github.com/repos/appbaseio/react-searchbox/statuses/b0c9f666296a34567d15b2fdc0d981cd9c5d273f","head":{"label":"ShahAnuj2610:feat/storybook","ref":"feat/storybook","sha":"b0c9f666296a34567d15b2fdc0d981cd9c5d273f","user":{"login":"ShahAnuj2610","id":10362927,"node_id":"MDQ6VXNlcjEwMzYyOTI3","avatar_url":"https://avatars3.githubusercontent.com/u/10362927?v=4","gravatar_id":"","url":"https://api.github.com/users/ShahAnuj2610","html_url":"https://github.com/ShahAnuj2610","followers_url":"https://api.github.com/users/ShahAnuj2610/followers","following_url":"https://api.github.com/users/ShahAnuj2610/following{/other_user}","gists_url":"https://api.github.com/users/ShahAnuj2610/gists{/gist_id}","starred_url":"https://api.github.com/users/ShahAnuj2610/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShahAnuj2610/subscriptions","organizations_url":"https://api.github.com/users/ShahAnuj2610/orgs","repos_url":"https://api.github.com/users/ShahAnuj2610/repos","events_url":"https://api.github.com/users/ShahAnuj2610/events{/privacy}","received_events_url":"https://api.github.com/users/ShahAnuj2610/received_events","type":"User","site_admin":false},"repo":{"id":210523311,"node_id":"MDEwOlJlcG9zaXRvcnkyMTA1MjMzMTE=","name":"react-searchbox","full_name":"ShahAnuj2610/react-searchbox","private":false,"owner":{"login":"ShahAnuj2610","id":10362927,"node_id":"MDQ6VXNlcjEwMzYyOTI3","avatar_url":"https://avatars3.githubusercontent.com/u/10362927?v=4","gravatar_id":"","url":"https://api.github.com/users/ShahAnuj2610","html_url":"https://github.com/ShahAnuj2610","followers_url":"https://api.github.com/users/ShahAnuj2610/followers","following_url":"https://api.github.com/users/ShahAnuj2610/following{/other_user}","gists_url":"https://api.github.com/users/ShahAnuj2610/gists{/gist_id}","starred_url":"https://api.github.com/users/ShahAnuj2610/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShahAnuj2610/subscriptions","organizations_url":"https://api.github.com/users/ShahAnuj2610/orgs","repos_url":"https://api.github.com/users/ShahAnuj2610/repos","events_url":"https://api.github.com/users/ShahAnuj2610/events{/privacy}","received_events_url":"https://api.github.com/users/ShahAnuj2610/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ShahAnuj2610/react-searchbox","description":null,"fork":true,"url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox","forks_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/forks","keys_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/teams","hooks_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/hooks","issue_events_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/issues/events{/number}","events_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/events","assignees_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/assignees{/user}","branches_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/branches{/branch}","tags_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/tags","blobs_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/statuses/{sha}","languages_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/languages","stargazers_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/stargazers","contributors_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/contributors","subscribers_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/subscribers","subscription_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/subscription","commits_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/contents/{+path}","compare_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/merges","archive_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/downloads","issues_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/issues{/number}","pulls_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/pulls{/number}","milestones_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/milestones{/number}","notifications_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/labels{/name}","releases_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/releases{/id}","deployments_url":"https://api.github.com/repos/ShahAnuj2610/react-searchbox/deployments","created_at":"2019-09-24T06:00:05Z","updated_at":"2019-09-30T07:01:12Z","pushed_at":"2019-10-05T09:45:33Z","git_url":"git://github.com/ShahAnuj2610/react-searchbox.git","ssh_url":"[email protected]:ShahAnuj2610/react-searchbox.git","clone_url":"https://github.com/ShahAnuj2610/react-searchbox.git","svn_url":"https://github.com/ShahAnuj2610/react-searchbox","homepage":null,"size":1618,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appbaseio:master","ref":"master","sha":"662cb64d4725fff883e7a402407125bdf2900903","user":{"login":"appbaseio","id":8524145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MjQxNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8524145?v=4","gravatar_id":"","url":"https://api.github.com/users/appbaseio","html_url":"https://github.com/appbaseio","followers_url":"https://api.github.com/users/appbaseio/followers","following_url":"https://api.github.com/users/appbaseio/following{/other_user}","gists_url":"https://api.github.com/users/appbaseio/gists{/gist_id}","starred_url":"https://api.github.com/users/appbaseio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appbaseio/subscriptions","organizations_url":"https://api.github.com/users/appbaseio/orgs","repos_url":"https://api.github.com/users/appbaseio/repos","events_url":"https://api.github.com/users/appbaseio/events{/privacy}","received_events_url":"https://api.github.com/users/appbaseio/received_events","type":"Organization","site_admin":false},"repo":{"id":210517030,"node_id":"MDEwOlJlcG9zaXRvcnkyMTA1MTcwMzA=","name":"react-searchbox","full_name":"appbaseio/react-searchbox","private":false,"owner":{"login":"appbaseio","id":8524145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1MjQxNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8524145?v=4","gravatar_id":"","url":"https://api.github.com/users/appbaseio","html_url":"https://github.com/appbaseio","followers_url":"https://api.github.com/users/appbaseio/followers","following_url":"https://api.github.com/users/appbaseio/following{/other_user}","gists_url":"https://api.github.com/users/appbaseio/gists{/gist_id}","starred_url":"https://api.github.com/users/appbaseio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appbaseio/subscriptions","organizations_url":"https://api.github.com/users/appbaseio/orgs","repos_url":"https://api.github.com/users/appbaseio/repos","events_url":"https://api.github.com/users/appbaseio/events{/privacy}","received_events_url":"https://api.github.com/users/appbaseio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/appbaseio/react-searchbox","description":"Lightweight searchbox component.","fork":false,"url":"https://api.github.com/repos/appbaseio/react-searchbox","forks_url":"https://api.github.com/repos/appbaseio/react-searchbox/forks","keys_url":"https://api.github.com/repos/appbaseio/react-searchbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appbaseio/react-searchbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appbaseio/react-searchbox/teams","hooks_url":"https://api.github.com/repos/appbaseio/react-searchbox/hooks","issue_events_url":"https://api.github.com/repos/appbaseio/react-searchbox/issues/events{/number}","events_url":"https://api.github.com/repos/appbaseio/react-searchbox/events","assignees_url":"https://api.github.com/repos/appbaseio/react-searchbox/assignees{/user}","branches_url":"https://api.github.com/repos/appbaseio/react-searchbox/branches{/branch}","tags_url":"https://api.github.com/repos/appbaseio/react-searchbox/tags","blobs_url":"https://api.github.com/repos/appbaseio/react-searchbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appbaseio/react-searchbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appbaseio/react-searchbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/appbaseio/react-searchbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appbaseio/react-searchbox/statuses/{sha}","languages_url":"https://api.github.com/repos/appbaseio/react-searchbox/languages","stargazers_url":"https://api.github.com/repos/appbaseio/react-searchbox/stargazers","contributors_url":"https://api.github.com/repos/appbaseio/react-searchbox/contributors","subscribers_url":"https://api.github.com/repos/appbaseio/react-searchbox/subscribers","subscription_url":"https://api.github.com/repos/appbaseio/react-searchbox/subscription","commits_url":"https://api.github.com/repos/appbaseio/react-searchbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/appbaseio/react-searchbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/appbaseio/react-searchbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/appbaseio/react-searchbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/appbaseio/react-searchbox/contents/{+path}","compare_url":"https://api.github.com/repos/appbaseio/react-searchbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appbaseio/react-searchbox/merges","archive_url":"https://api.github.com/repos/appbaseio/react-searchbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appbaseio/react-searchbox/downloads","issues_url":"https://api.github.com/repos/appbaseio/react-searchbox/issues{/number}","pulls_url":"https://api.github.com/repos/appbaseio/react-searchbox/pulls{/number}","milestones_url":"https://api.github.com/repos/appbaseio/react-searchbox/milestones{/number}","notifications_url":"https://api.github.com/repos/appbaseio/react-searchbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appbaseio/react-searchbox/labels{/name}","releases_url":"https://api.github.com/repos/appbaseio/react-searchbox/releases{/id}","deployments_url":"https://api.github.com/repos/appbaseio/react-searchbox/deployments","created_at":"2019-09-24T05:12:57Z","updated_at":"2019-10-02T05:13:07Z","pushed_at":"2019-10-05T09:46:41Z","git_url":"git://github.com/appbaseio/react-searchbox.git","ssh_url":"[email protected]:appbaseio/react-searchbox.git","clone_url":"https://github.com/appbaseio/react-searchbox.git","svn_url":"https://github.com/appbaseio/react-searchbox","homepage":"","size":433,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appbaseio/react-searchbox/pulls/2"},"html":{"href":"https://github.com/appbaseio/react-searchbox/pull/2"},"issue":{"href":"https://api.github.com/repos/appbaseio/react-searchbox/issues/2"},"comments":{"href":"https://api.github.com/repos/appbaseio/react-searchbox/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/appbaseio/react-searchbox/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/appbaseio/react-searchbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appbaseio/react-searchbox/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/appbaseio/react-searchbox/statuses/b0c9f666296a34567d15b2fdc0d981cd9c5d273f"}},"author_association":"MEMBER"}}
|
{
"id": 210517030,
"name": "appbaseio/react-searchbox",
"url": "https://api.github.com/repos/appbaseio/react-searchbox"
}
|
{
"id": 22376783,
"login": "jyash97",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/22376783?",
"url": "https://api.github.com/users/jyash97"
}
|
{
"id": 8524145,
"login": "appbaseio",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8524145?",
"url": "https://api.github.com/orgs/appbaseio"
}
| 2019-10-07T13:23:02 |
10574181583
|
{"actor":{"display_login":"jyash97"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/connected-io/UnIt/pulls/comments/311249360","pull_request_review_id":271582444,"id":311249360,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMTI0OTM2MA==","diff_hunk":"@@ -5,17 +5,120 @@ import UnIt\n \n class UIViewInspectingSpec: QuickSpec {\n override func spec() {\n- var loadedVc: ActionViewController!\n+ var view: UIView!\n \n- describe(\"ViewController with user inputs\") {\n+ describe(\"This view\") {\n beforeEach() {\n- loadedVc = UIViewController.loadAndSetupViewControllerFromNib(\"ActionViewController\", ActionViewController.self, Device.iPhone7Plus)\n+ view = nil\n }\n \n- it(\"should have 3 hidden buttons\") {\n- expect(loadedVc.firstHiddenButton.isTrulyVisible).to(beFalse())\n- expect(loadedVc.secondHiddenButton.isTrulyVisible).to(beFalse())\n- expect(loadedVc.buttonInHiddenView.isTrulyVisible).to(beFalse())\n+ it(\"should be truly visible\") {\n+ view = UIView(frame: CGRect(x: 43.542, y: 12, width: 343.34, height: 534.32))\n+ expect(view.isTrulyVisible).to(beTruthy())\n+ }\n+ \n+ it(\"should not be truly visible given that its superview is not truly visible, even though it itself is\") {\n+ view = UIView(frame: CGRect(x: 43.542, y: 12, width: 343.34, height: 534.32))\n+ expect(view.isTrulyVisible).to(beTruthy())\n+\n+ let superview = UIView(frame: CGRect(x: 43.542, y: 12, width: 0, height: 777))\n+ superview.addSubview(view)\n+ expect(view.isTrulyVisible).to(beFalsy())\n+ }\n+ \n+ it(\"should not be truly visible if it is hidden\") {\n+ view = UIView(frame: CGRect(x: 43.542, y: 12, width: 343.34, height: 534.32))\n+ view.isHidden = true\n+ expect(view.isTrulyVisible).to(beFalsy())\n+ }\n+ \n+ it(\"should not be truly visible if its alpha is 0\") {\n+ view = UIView(frame: CGRect(x: 43.542, y: 12, width: 343.34, height: 534.32))\n+ view.alpha = 0\n+ expect(view.isTrulyVisible).to(beFalsy())\n+ }\n+ \n+ it(\"should not be truly visible if its width is 0\") {\n+ view = UIView(frame: CGRect(x: 43.542, y: 12, width: 0, height: 534.32))\n+ expect(view.isTrulyVisible).to(beFalsy())\n+ }\n+ \n+ it(\"should not be truly visible if its height is 0\") {\n+ view = UIView(frame: CGRect(x: 43.542, y: 12, width: 343.34, height: 0))\n+ expect(view.isTrulyVisible).to(beFalsy())\n+ }\n+ \n+ it(\"should not be truly visible if its height is 0\") {\n+ view = UIView(frame: CGRect(x: 43.542, y: 12, width: 0, height: 0))\n+ expect(view.isTrulyVisible).to(beFalsy())\n+ }\n+ }\n+ \n+ describe(\"Comparing this view to other view\") {\n+ var view: UIView!\n+ var otherView: UIView!\n+ \n+ beforeEach {\n+ view = nil\n+ otherView = nil\n+ }\n+ \n+ it(\"should return true if other view is the same width and height\") {\n+ view = UIView(frame: CGRect(x: 43.542, y: 12, width: 343.34, height: 534.32))\n+ otherView = UIView(frame: CGRect(x: 43.542, y: 12, width: 343.34, height: 534.32))\n+ expect(view.isSizeRoughlyEqualTo(otherView: otherView)).to(beTruthy())","path":"UnIt_SampleApp/UnIt_SampleAppTests/UIView+InspectingSpec.swift","position":72,"original_position":72,"commit_id":"244824eb34b9741f643bd333c3a325830948c5cc","original_commit_id":"244824eb34b9741f643bd333c3a325830948c5cc","user":{"login":"connected-swu","id":24231785,"node_id":"MDQ6VXNlcjI0MjMxNzg1","avatar_url":"https://avatars0.githubusercontent.com/u/24231785?v=4","gravatar_id":"","url":"https://api.github.com/users/connected-swu","html_url":"https://github.com/connected-swu","followers_url":"https://api.github.com/users/connected-swu/followers","following_url":"https://api.github.com/users/connected-swu/following{/other_user}","gists_url":"https://api.github.com/users/connected-swu/gists{/gist_id}","starred_url":"https://api.github.com/users/connected-swu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connected-swu/subscriptions","organizations_url":"https://api.github.com/users/connected-swu/orgs","repos_url":"https://api.github.com/users/connected-swu/repos","events_url":"https://api.github.com/users/connected-swu/events{/privacy}","received_events_url":"https://api.github.com/users/connected-swu/received_events","type":"User","site_admin":false},"body":"hmmm, thoughts about keeping or ditching the `otherView` parameter label?","created_at":"2019-08-06T20:02:53Z","updated_at":"2019-08-06T20:02:54Z","html_url":"https://github.com/connected-io/UnIt/pull/35#discussion_r311249360","pull_request_url":"https://api.github.com/repos/connected-io/UnIt/pulls/35","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/connected-io/UnIt/pulls/comments/311249360"},"html":{"href":"https://github.com/connected-io/UnIt/pull/35#discussion_r311249360"},"pull_request":{"href":"https://api.github.com/repos/connected-io/UnIt/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/connected-io/UnIt/pulls/35","id":303788564,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAzNzg4NTY0","html_url":"https://github.com/connected-io/UnIt/pull/35","diff_url":"https://github.com/connected-io/UnIt/pull/35.diff","patch_url":"https://github.com/connected-io/UnIt/pull/35.patch","issue_url":"https://api.github.com/repos/connected-io/UnIt/issues/35","number":35,"state":"open","locked":false,"title":"Add unit tests for `UIView+Inspecting` #25","user":{"login":"connected-akhan","id":45395977,"node_id":"MDQ6VXNlcjQ1Mzk1OTc3","avatar_url":"https://avatars2.githubusercontent.com/u/45395977?v=4","gravatar_id":"","url":"https://api.github.com/users/connected-akhan","html_url":"https://github.com/connected-akhan","followers_url":"https://api.github.com/users/connected-akhan/followers","following_url":"https://api.github.com/users/connected-akhan/following{/other_user}","gists_url":"https://api.github.com/users/connected-akhan/gists{/gist_id}","starred_url":"https://api.github.com/users/connected-akhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connected-akhan/subscriptions","organizations_url":"https://api.github.com/users/connected-akhan/orgs","repos_url":"https://api.github.com/users/connected-akhan/repos","events_url":"https://api.github.com/users/connected-akhan/events{/privacy}","received_events_url":"https://api.github.com/users/connected-akhan/received_events","type":"User","site_admin":false},"body":"uiview-inspecting branch is a sub-branch off of device-CGFloat-CGSize-tests. This was a mistake. It should have been off of master. So, the diff will include changes made in device-CGFloat-CGSize-tests thus far as well. The last commit `\r\nAdd tests for UIView+Inspecting.` is where most of the `UIView+Inspecting` work lies, so please focus on that.","created_at":"2019-08-02T13:30:55Z","updated_at":"2019-08-06T20:02:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a425cb701316b083bdc710742e88a190cf9f3ce8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/connected-io/UnIt/pulls/35/commits","review_comments_url":"https://api.github.com/repos/connected-io/UnIt/pulls/35/comments","review_comment_url":"https://api.github.com/repos/connected-io/UnIt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/connected-io/UnIt/issues/35/comments","statuses_url":"https://api.github.com/repos/connected-io/UnIt/statuses/244824eb34b9741f643bd333c3a325830948c5cc","head":{"label":"connected-io:uiview-inspecting","ref":"uiview-inspecting","sha":"244824eb34b9741f643bd333c3a325830948c5cc","user":{"login":"connected-io","id":8545830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NDU4MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/8545830?v=4","gravatar_id":"","url":"https://api.github.com/users/connected-io","html_url":"https://github.com/connected-io","followers_url":"https://api.github.com/users/connected-io/followers","following_url":"https://api.github.com/users/connected-io/following{/other_user}","gists_url":"https://api.github.com/users/connected-io/gists{/gist_id}","starred_url":"https://api.github.com/users/connected-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connected-io/subscriptions","organizations_url":"https://api.github.com/users/connected-io/orgs","repos_url":"https://api.github.com/users/connected-io/repos","events_url":"https://api.github.com/users/connected-io/events{/privacy}","received_events_url":"https://api.github.com/users/connected-io/received_events","type":"Organization","site_admin":false},"repo":{"id":164027165,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQwMjcxNjU=","name":"UnIt","full_name":"connected-io/UnIt","private":false,"owner":{"login":"connected-io","id":8545830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NDU4MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/8545830?v=4","gravatar_id":"","url":"https://api.github.com/users/connected-io","html_url":"https://github.com/connected-io","followers_url":"https://api.github.com/users/connected-io/followers","following_url":"https://api.github.com/users/connected-io/following{/other_user}","gists_url":"https://api.github.com/users/connected-io/gists{/gist_id}","starred_url":"https://api.github.com/users/connected-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connected-io/subscriptions","organizations_url":"https://api.github.com/users/connected-io/orgs","repos_url":"https://api.github.com/users/connected-io/repos","events_url":"https://api.github.com/users/connected-io/events{/privacy}","received_events_url":"https://api.github.com/users/connected-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/connected-io/UnIt","description":"An iOS Swift framework that helps bridge the gap between UI and Unit Testing.","fork":false,"url":"https://api.github.com/repos/connected-io/UnIt","forks_url":"https://api.github.com/repos/connected-io/UnIt/forks","keys_url":"https://api.github.com/repos/connected-io/UnIt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/connected-io/UnIt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/connected-io/UnIt/teams","hooks_url":"https://api.github.com/repos/connected-io/UnIt/hooks","issue_events_url":"https://api.github.com/repos/connected-io/UnIt/issues/events{/number}","events_url":"https://api.github.com/repos/connected-io/UnIt/events","assignees_url":"https://api.github.com/repos/connected-io/UnIt/assignees{/user}","branches_url":"https://api.github.com/repos/connected-io/UnIt/branches{/branch}","tags_url":"https://api.github.com/repos/connected-io/UnIt/tags","blobs_url":"https://api.github.com/repos/connected-io/UnIt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/connected-io/UnIt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/connected-io/UnIt/git/refs{/sha}","trees_url":"https://api.github.com/repos/connected-io/UnIt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/connected-io/UnIt/statuses/{sha}","languages_url":"https://api.github.com/repos/connected-io/UnIt/languages","stargazers_url":"https://api.github.com/repos/connected-io/UnIt/stargazers","contributors_url":"https://api.github.com/repos/connected-io/UnIt/contributors","subscribers_url":"https://api.github.com/repos/connected-io/UnIt/subscribers","subscription_url":"https://api.github.com/repos/connected-io/UnIt/subscription","commits_url":"https://api.github.com/repos/connected-io/UnIt/commits{/sha}","git_commits_url":"https://api.github.com/repos/connected-io/UnIt/git/commits{/sha}","comments_url":"https://api.github.com/repos/connected-io/UnIt/comments{/number}","issue_comment_url":"https://api.github.com/repos/connected-io/UnIt/issues/comments{/number}","contents_url":"https://api.github.com/repos/connected-io/UnIt/contents/{+path}","compare_url":"https://api.github.com/repos/connected-io/UnIt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/connected-io/UnIt/merges","archive_url":"https://api.github.com/repos/connected-io/UnIt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/connected-io/UnIt/downloads","issues_url":"https://api.github.com/repos/connected-io/UnIt/issues{/number}","pulls_url":"https://api.github.com/repos/connected-io/UnIt/pulls{/number}","milestones_url":"https://api.github.com/repos/connected-io/UnIt/milestones{/number}","notifications_url":"https://api.github.com/repos/connected-io/UnIt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/connected-io/UnIt/labels{/name}","releases_url":"https://api.github.com/repos/connected-io/UnIt/releases{/id}","deployments_url":"https://api.github.com/repos/connected-io/UnIt/deployments","created_at":"2019-01-03T21:58:44Z","updated_at":"2019-08-02T13:33:47Z","pushed_at":"2019-08-06T17:41:20Z","git_url":"git://github.com/connected-io/UnIt.git","ssh_url":"[email protected]:connected-io/UnIt.git","clone_url":"https://github.com/connected-io/UnIt.git","svn_url":"https://github.com/connected-io/UnIt","homepage":"","size":1423,"stargazers_count":13,"watchers_count":13,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":18,"watchers":13,"default_branch":"master"}},"base":{"label":"connected-io:master","ref":"master","sha":"e995a8e016627bc656d58d9f8db8780e8269e8f1","user":{"login":"connected-io","id":8545830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NDU4MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/8545830?v=4","gravatar_id":"","url":"https://api.github.com/users/connected-io","html_url":"https://github.com/connected-io","followers_url":"https://api.github.com/users/connected-io/followers","following_url":"https://api.github.com/users/connected-io/following{/other_user}","gists_url":"https://api.github.com/users/connected-io/gists{/gist_id}","starred_url":"https://api.github.com/users/connected-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connected-io/subscriptions","organizations_url":"https://api.github.com/users/connected-io/orgs","repos_url":"https://api.github.com/users/connected-io/repos","events_url":"https://api.github.com/users/connected-io/events{/privacy}","received_events_url":"https://api.github.com/users/connected-io/received_events","type":"Organization","site_admin":false},"repo":{"id":164027165,"node_id":"MDEwOlJlcG9zaXRvcnkxNjQwMjcxNjU=","name":"UnIt","full_name":"connected-io/UnIt","private":false,"owner":{"login":"connected-io","id":8545830,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1NDU4MzA=","avatar_url":"https://avatars3.githubusercontent.com/u/8545830?v=4","gravatar_id":"","url":"https://api.github.com/users/connected-io","html_url":"https://github.com/connected-io","followers_url":"https://api.github.com/users/connected-io/followers","following_url":"https://api.github.com/users/connected-io/following{/other_user}","gists_url":"https://api.github.com/users/connected-io/gists{/gist_id}","starred_url":"https://api.github.com/users/connected-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connected-io/subscriptions","organizations_url":"https://api.github.com/users/connected-io/orgs","repos_url":"https://api.github.com/users/connected-io/repos","events_url":"https://api.github.com/users/connected-io/events{/privacy}","received_events_url":"https://api.github.com/users/connected-io/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/connected-io/UnIt","description":"An iOS Swift framework that helps bridge the gap between UI and Unit Testing.","fork":false,"url":"https://api.github.com/repos/connected-io/UnIt","forks_url":"https://api.github.com/repos/connected-io/UnIt/forks","keys_url":"https://api.github.com/repos/connected-io/UnIt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/connected-io/UnIt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/connected-io/UnIt/teams","hooks_url":"https://api.github.com/repos/connected-io/UnIt/hooks","issue_events_url":"https://api.github.com/repos/connected-io/UnIt/issues/events{/number}","events_url":"https://api.github.com/repos/connected-io/UnIt/events","assignees_url":"https://api.github.com/repos/connected-io/UnIt/assignees{/user}","branches_url":"https://api.github.com/repos/connected-io/UnIt/branches{/branch}","tags_url":"https://api.github.com/repos/connected-io/UnIt/tags","blobs_url":"https://api.github.com/repos/connected-io/UnIt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/connected-io/UnIt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/connected-io/UnIt/git/refs{/sha}","trees_url":"https://api.github.com/repos/connected-io/UnIt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/connected-io/UnIt/statuses/{sha}","languages_url":"https://api.github.com/repos/connected-io/UnIt/languages","stargazers_url":"https://api.github.com/repos/connected-io/UnIt/stargazers","contributors_url":"https://api.github.com/repos/connected-io/UnIt/contributors","subscribers_url":"https://api.github.com/repos/connected-io/UnIt/subscribers","subscription_url":"https://api.github.com/repos/connected-io/UnIt/subscription","commits_url":"https://api.github.com/repos/connected-io/UnIt/commits{/sha}","git_commits_url":"https://api.github.com/repos/connected-io/UnIt/git/commits{/sha}","comments_url":"https://api.github.com/repos/connected-io/UnIt/comments{/number}","issue_comment_url":"https://api.github.com/repos/connected-io/UnIt/issues/comments{/number}","contents_url":"https://api.github.com/repos/connected-io/UnIt/contents/{+path}","compare_url":"https://api.github.com/repos/connected-io/UnIt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/connected-io/UnIt/merges","archive_url":"https://api.github.com/repos/connected-io/UnIt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/connected-io/UnIt/downloads","issues_url":"https://api.github.com/repos/connected-io/UnIt/issues{/number}","pulls_url":"https://api.github.com/repos/connected-io/UnIt/pulls{/number}","milestones_url":"https://api.github.com/repos/connected-io/UnIt/milestones{/number}","notifications_url":"https://api.github.com/repos/connected-io/UnIt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/connected-io/UnIt/labels{/name}","releases_url":"https://api.github.com/repos/connected-io/UnIt/releases{/id}","deployments_url":"https://api.github.com/repos/connected-io/UnIt/deployments","created_at":"2019-01-03T21:58:44Z","updated_at":"2019-08-02T13:33:47Z","pushed_at":"2019-08-06T17:41:20Z","git_url":"git://github.com/connected-io/UnIt.git","ssh_url":"[email protected]:connected-io/UnIt.git","clone_url":"https://github.com/connected-io/UnIt.git","svn_url":"https://github.com/connected-io/UnIt","homepage":"","size":1423,"stargazers_count":13,"watchers_count":13,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":18,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":18,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/connected-io/UnIt/pulls/35"},"html":{"href":"https://github.com/connected-io/UnIt/pull/35"},"issue":{"href":"https://api.github.com/repos/connected-io/UnIt/issues/35"},"comments":{"href":"https://api.github.com/repos/connected-io/UnIt/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/connected-io/UnIt/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/connected-io/UnIt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/connected-io/UnIt/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/connected-io/UnIt/statuses/244824eb34b9741f643bd333c3a325830948c5cc"}},"author_association":"COLLABORATOR"}}
|
{
"id": 164027165,
"name": "connected-io/UnIt",
"url": "https://api.github.com/repos/connected-io/UnIt"
}
|
{
"id": 24231785,
"login": "connected-swu",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/24231785?",
"url": "https://api.github.com/users/connected-swu"
}
|
{
"id": 8545830,
"login": "connected-io",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8545830?",
"url": "https://api.github.com/orgs/connected-io"
}
| 2019-08-06T20:02:53 |
10159689337
|
{"actor":{"display_login":"connected-swu"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/gemini-hlsw/basic-case/pulls/comments/254661558","pull_request_review_id":201060700,"id":254661558,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NDY2MTU1OA==","diff_hunk":"@@ -0,0 +1,66 @@\n+// Copyright (c) 2019 Association of Universities for Research in Astronomy, Inc. (AURA)\n+// For license information see LICENSE or https://opensource.org/licenses/BSD-3-Clause\n+\n+package basic.syntax\n+\n+import gem.enum.GmosNorthDisperser\n+import gem.enum.GmosNorthDisperser._\n+\n+/**\n+ * Syntax extensions for missing properties. These need to be folded back into the Gem enumerations.\n+ */\n+final class GmosNorthDisperserOps(val self: GmosNorthDisperser) extends AnyVal {\n+\n+ /**\n+ * Reference wavelength (nm) and resolution for 0.5\" slit.\n+ * @see http://www.gemini.edu/sciops/instruments/gmos/spectroscopy-overview/gratings\n+ */\n+ private def reference: (Int, Int) =\n+ self match {\n+ case B1200_G5301 => (463, 3744)\n+ case R831_G5302 => (757, 4396)\n+ case B600_G5303 => (461, 1688) // obsolete\n+ case B600_G5307 => (461, 1688)\n+ case R600_G5304 => (926, 3744)\n+ case R400_G5305 => (764, 1918)\n+ case R150_G5306 => (717, 631) // obsolete\n+ case R150_G5308 => (717, 631)\n+ }\n+\n+ /**\n+ * Δλ for 0.5\" slit.\n+ * @see http://hyperphysics.phy-astr.gsu.edu/hbase/phyopt/gratres.html\n+ */\n+ private def Δλ: Double = {\n+ val (λ, r) = reference\n+ λ.toDouble / r.toDouble // r = λ / Δλ\n+ }\n+\n+ /** Resolution at λ (nm) with the specified slit width (arcsec). */\n+ def resolution(λ: Int, slitWidth: Double): Int =\n+ ((λ / Δλ) * (0.5 / slitWidth)).toInt\n+\n+ /**\n+ * Simultaneous coverage (nm) with Hamamatsu detectors.\n+ * @see http://www.gemini.edu/sciops/instruments/gmos/spectroscopy-overview/gratings\n+ */\n+ def simultaneousCoverage: Int =","path":"src/main/scala/syntax/GmosNorthDisperser.scala","position":47,"original_position":47,"commit_id":"3e196364721db8e4b8207882f410d669c6c5e2f9","original_commit_id":"3e196364721db8e4b8207882f410d669c6c5e2f9","user":{"login":"swalker2m","id":4906023,"node_id":"MDQ6VXNlcjQ5MDYwMjM=","avatar_url":"https://avatars3.githubusercontent.com/u/4906023?v=4","gravatar_id":"","url":"https://api.github.com/users/swalker2m","html_url":"https://github.com/swalker2m","followers_url":"https://api.github.com/users/swalker2m/followers","following_url":"https://api.github.com/users/swalker2m/following{/other_user}","gists_url":"https://api.github.com/users/swalker2m/gists{/gist_id}","starred_url":"https://api.github.com/users/swalker2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swalker2m/subscriptions","organizations_url":"https://api.github.com/users/swalker2m/orgs","repos_url":"https://api.github.com/users/swalker2m/repos","events_url":"https://api.github.com/users/swalker2m/events{/privacy}","received_events_url":"https://api.github.com/users/swalker2m/received_events","type":"User","site_admin":false},"body":"What is `simultaneousCoverage` and how does it fit in with the basic use case?","created_at":"2019-02-07T12:29:49Z","updated_at":"2019-02-07T12:29:49Z","html_url":"https://github.com/gemini-hlsw/basic-case/pull/4#discussion_r254661558","pull_request_url":"https://api.github.com/repos/gemini-hlsw/basic-case/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/gemini-hlsw/basic-case/pulls/comments/254661558"},"html":{"href":"https://github.com/gemini-hlsw/basic-case/pull/4#discussion_r254661558"},"pull_request":{"href":"https://api.github.com/repos/gemini-hlsw/basic-case/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/gemini-hlsw/basic-case/pulls/4","id":250968097,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUwOTY4MDk3","html_url":"https://github.com/gemini-hlsw/basic-case/pull/4","diff_url":"https://github.com/gemini-hlsw/basic-case/pull/4.diff","patch_url":"https://github.com/gemini-hlsw/basic-case/pull/4.patch","issue_url":"https://api.github.com/repos/gemini-hlsw/basic-case/issues/4","number":4,"state":"open","locked":false,"title":"WIP: physical characteristics","user":{"login":"tpolecat","id":1200131,"node_id":"MDQ6VXNlcjEyMDAxMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1200131?v=4","gravatar_id":"","url":"https://api.github.com/users/tpolecat","html_url":"https://github.com/tpolecat","followers_url":"https://api.github.com/users/tpolecat/followers","following_url":"https://api.github.com/users/tpolecat/following{/other_user}","gists_url":"https://api.github.com/users/tpolecat/gists{/gist_id}","starred_url":"https://api.github.com/users/tpolecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpolecat/subscriptions","organizations_url":"https://api.github.com/users/tpolecat/orgs","repos_url":"https://api.github.com/users/tpolecat/repos","events_url":"https://api.github.com/users/tpolecat/events{/privacy}","received_events_url":"https://api.github.com/users/tpolecat/received_events","type":"User","site_admin":false},"body":"This adds (via syntax) resolution calculations and wavelength coverage. So this gives us R and Δλ from the basic use case document.\r\n\r\nTodo:\r\n- [ ] other instruments\r\n- [ ] slit width for all FPUs .. it's 0.31\" for the IFUs\r\n- [ ] replace integer ns with `Wavelength`\r\n- [ ] replace double slit width with `Angle`","created_at":"2019-02-07T01:41:11Z","updated_at":"2019-02-07T12:29:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fea33a893e818cb88f2ba86ba9b98589cef28ee0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gemini-hlsw/basic-case/pulls/4/commits","review_comments_url":"https://api.github.com/repos/gemini-hlsw/basic-case/pulls/4/comments","review_comment_url":"https://api.github.com/repos/gemini-hlsw/basic-case/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gemini-hlsw/basic-case/issues/4/comments","statuses_url":"https://api.github.com/repos/gemini-hlsw/basic-case/statuses/3e196364721db8e4b8207882f410d669c6c5e2f9","head":{"label":"tpolecat:resolution","ref":"resolution","sha":"3e196364721db8e4b8207882f410d669c6c5e2f9","user":{"login":"tpolecat","id":1200131,"node_id":"MDQ6VXNlcjEyMDAxMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1200131?v=4","gravatar_id":"","url":"https://api.github.com/users/tpolecat","html_url":"https://github.com/tpolecat","followers_url":"https://api.github.com/users/tpolecat/followers","following_url":"https://api.github.com/users/tpolecat/following{/other_user}","gists_url":"https://api.github.com/users/tpolecat/gists{/gist_id}","starred_url":"https://api.github.com/users/tpolecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpolecat/subscriptions","organizations_url":"https://api.github.com/users/tpolecat/orgs","repos_url":"https://api.github.com/users/tpolecat/repos","events_url":"https://api.github.com/users/tpolecat/events{/privacy}","received_events_url":"https://api.github.com/users/tpolecat/received_events","type":"User","site_admin":false},"repo":{"id":169316028,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkzMTYwMjg=","name":"basic-case","full_name":"tpolecat/basic-case","private":false,"owner":{"login":"tpolecat","id":1200131,"node_id":"MDQ6VXNlcjEyMDAxMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1200131?v=4","gravatar_id":"","url":"https://api.github.com/users/tpolecat","html_url":"https://github.com/tpolecat","followers_url":"https://api.github.com/users/tpolecat/followers","following_url":"https://api.github.com/users/tpolecat/following{/other_user}","gists_url":"https://api.github.com/users/tpolecat/gists{/gist_id}","starred_url":"https://api.github.com/users/tpolecat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpolecat/subscriptions","organizations_url":"https://api.github.com/users/tpolecat/orgs","repos_url":"https://api.github.com/users/tpolecat/repos","events_url":"https://api.github.com/users/tpolecat/events{/privacy}","received_events_url":"https://api.github.com/users/tpolecat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tpolecat/basic-case","description":"Prototype API for the OCS3 basic science case.","fork":true,"url":"https://api.github.com/repos/tpolecat/basic-case","forks_url":"https://api.github.com/repos/tpolecat/basic-case/forks","keys_url":"https://api.github.com/repos/tpolecat/basic-case/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tpolecat/basic-case/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tpolecat/basic-case/teams","hooks_url":"https://api.github.com/repos/tpolecat/basic-case/hooks","issue_events_url":"https://api.github.com/repos/tpolecat/basic-case/issues/events{/number}","events_url":"https://api.github.com/repos/tpolecat/basic-case/events","assignees_url":"https://api.github.com/repos/tpolecat/basic-case/assignees{/user}","branches_url":"https://api.github.com/repos/tpolecat/basic-case/branches{/branch}","tags_url":"https://api.github.com/repos/tpolecat/basic-case/tags","blobs_url":"https://api.github.com/repos/tpolecat/basic-case/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tpolecat/basic-case/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tpolecat/basic-case/git/refs{/sha}","trees_url":"https://api.github.com/repos/tpolecat/basic-case/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tpolecat/basic-case/statuses/{sha}","languages_url":"https://api.github.com/repos/tpolecat/basic-case/languages","stargazers_url":"https://api.github.com/repos/tpolecat/basic-case/stargazers","contributors_url":"https://api.github.com/repos/tpolecat/basic-case/contributors","subscribers_url":"https://api.github.com/repos/tpolecat/basic-case/subscribers","subscription_url":"https://api.github.com/repos/tpolecat/basic-case/subscription","commits_url":"https://api.github.com/repos/tpolecat/basic-case/commits{/sha}","git_commits_url":"https://api.github.com/repos/tpolecat/basic-case/git/commits{/sha}","comments_url":"https://api.github.com/repos/tpolecat/basic-case/comments{/number}","issue_comment_url":"https://api.github.com/repos/tpolecat/basic-case/issues/comments{/number}","contents_url":"https://api.github.com/repos/tpolecat/basic-case/contents/{+path}","compare_url":"https://api.github.com/repos/tpolecat/basic-case/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tpolecat/basic-case/merges","archive_url":"https://api.github.com/repos/tpolecat/basic-case/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tpolecat/basic-case/downloads","issues_url":"https://api.github.com/repos/tpolecat/basic-case/issues{/number}","pulls_url":"https://api.github.com/repos/tpolecat/basic-case/pulls{/number}","milestones_url":"https://api.github.com/repos/tpolecat/basic-case/milestones{/number}","notifications_url":"https://api.github.com/repos/tpolecat/basic-case/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tpolecat/basic-case/labels{/name}","releases_url":"https://api.github.com/repos/tpolecat/basic-case/releases{/id}","deployments_url":"https://api.github.com/repos/tpolecat/basic-case/deployments","created_at":"2019-02-05T21:30:20Z","updated_at":"2019-02-06T23:43:12Z","pushed_at":"2019-02-07T01:34:34Z","git_url":"git://github.com/tpolecat/basic-case.git","ssh_url":"[email protected]:tpolecat/basic-case.git","clone_url":"https://github.com/tpolecat/basic-case.git","svn_url":"https://github.com/tpolecat/basic-case","homepage":null,"size":3099,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gemini-hlsw:master","ref":"master","sha":"52db4a90630cbf7bb7594fcbe141c5f02965f7ea","user":{"login":"gemini-hlsw","id":8593735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1OTM3MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/8593735?v=4","gravatar_id":"","url":"https://api.github.com/users/gemini-hlsw","html_url":"https://github.com/gemini-hlsw","followers_url":"https://api.github.com/users/gemini-hlsw/followers","following_url":"https://api.github.com/users/gemini-hlsw/following{/other_user}","gists_url":"https://api.github.com/users/gemini-hlsw/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-hlsw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-hlsw/subscriptions","organizations_url":"https://api.github.com/users/gemini-hlsw/orgs","repos_url":"https://api.github.com/users/gemini-hlsw/repos","events_url":"https://api.github.com/users/gemini-hlsw/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-hlsw/received_events","type":"Organization","site_admin":false},"repo":{"id":169315880,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkzMTU4ODA=","name":"basic-case","full_name":"gemini-hlsw/basic-case","private":false,"owner":{"login":"gemini-hlsw","id":8593735,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg1OTM3MzU=","avatar_url":"https://avatars2.githubusercontent.com/u/8593735?v=4","gravatar_id":"","url":"https://api.github.com/users/gemini-hlsw","html_url":"https://github.com/gemini-hlsw","followers_url":"https://api.github.com/users/gemini-hlsw/followers","following_url":"https://api.github.com/users/gemini-hlsw/following{/other_user}","gists_url":"https://api.github.com/users/gemini-hlsw/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-hlsw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-hlsw/subscriptions","organizations_url":"https://api.github.com/users/gemini-hlsw/orgs","repos_url":"https://api.github.com/users/gemini-hlsw/repos","events_url":"https://api.github.com/users/gemini-hlsw/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-hlsw/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gemini-hlsw/basic-case","description":"Prototype API for the OCS3 basic science case.","fork":false,"url":"https://api.github.com/repos/gemini-hlsw/basic-case","forks_url":"https://api.github.com/repos/gemini-hlsw/basic-case/forks","keys_url":"https://api.github.com/repos/gemini-hlsw/basic-case/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-hlsw/basic-case/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-hlsw/basic-case/teams","hooks_url":"https://api.github.com/repos/gemini-hlsw/basic-case/hooks","issue_events_url":"https://api.github.com/repos/gemini-hlsw/basic-case/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-hlsw/basic-case/events","assignees_url":"https://api.github.com/repos/gemini-hlsw/basic-case/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-hlsw/basic-case/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-hlsw/basic-case/tags","blobs_url":"https://api.github.com/repos/gemini-hlsw/basic-case/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-hlsw/basic-case/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-hlsw/basic-case/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-hlsw/basic-case/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-hlsw/basic-case/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-hlsw/basic-case/languages","stargazers_url":"https://api.github.com/repos/gemini-hlsw/basic-case/stargazers","contributors_url":"https://api.github.com/repos/gemini-hlsw/basic-case/contributors","subscribers_url":"https://api.github.com/repos/gemini-hlsw/basic-case/subscribers","subscription_url":"https://api.github.com/repos/gemini-hlsw/basic-case/subscription","commits_url":"https://api.github.com/repos/gemini-hlsw/basic-case/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-hlsw/basic-case/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-hlsw/basic-case/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-hlsw/basic-case/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemini-hlsw/basic-case/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-hlsw/basic-case/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-hlsw/basic-case/merges","archive_url":"https://api.github.com/repos/gemini-hlsw/basic-case/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-hlsw/basic-case/downloads","issues_url":"https://api.github.com/repos/gemini-hlsw/basic-case/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-hlsw/basic-case/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-hlsw/basic-case/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-hlsw/basic-case/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-hlsw/basic-case/labels{/name}","releases_url":"https://api.github.com/repos/gemini-hlsw/basic-case/releases{/id}","deployments_url":"https://api.github.com/repos/gemini-hlsw/basic-case/deployments","created_at":"2019-02-05T21:29:07Z","updated_at":"2019-02-06T23:41:59Z","pushed_at":"2019-02-07T01:41:11Z","git_url":"git://github.com/gemini-hlsw/basic-case.git","ssh_url":"[email protected]:gemini-hlsw/basic-case.git","clone_url":"https://github.com/gemini-hlsw/basic-case.git","svn_url":"https://github.com/gemini-hlsw/basic-case","homepage":null,"size":3098,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gemini-hlsw/basic-case/pulls/4"},"html":{"href":"https://github.com/gemini-hlsw/basic-case/pull/4"},"issue":{"href":"https://api.github.com/repos/gemini-hlsw/basic-case/issues/4"},"comments":{"href":"https://api.github.com/repos/gemini-hlsw/basic-case/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/gemini-hlsw/basic-case/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/gemini-hlsw/basic-case/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gemini-hlsw/basic-case/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/gemini-hlsw/basic-case/statuses/3e196364721db8e4b8207882f410d669c6c5e2f9"}},"author_association":"MEMBER"}}
|
{
"id": 169315880,
"name": "gemini-hlsw/basic-case",
"url": "https://api.github.com/repos/gemini-hlsw/basic-case"
}
|
{
"id": 4906023,
"login": "swalker2m",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/4906023?",
"url": "https://api.github.com/users/swalker2m"
}
|
{
"id": 8593735,
"login": "gemini-hlsw",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8593735?",
"url": "https://api.github.com/orgs/gemini-hlsw"
}
| 2019-02-07T12:29:49 |
9025096700
|
{"actor":{"display_login":"swalker2m"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/comments/262258954","pull_request_review_id":210386149,"id":262258954,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MjI1ODk1NA==","diff_hunk":"@@ -0,0 +1,26 @@\n+//\n+// SDLRPCResponseOperation.h\n+// SmartDeviceLink\n+//\n+// Created by Nicole on 2/20/19.\n+// Copyright © 2019 smartdevicelink. All rights reserved.\n+//\n+\n+#import <UIKit/UIKit.h>\n+\n+#import \"SDLAsynchronousOperation.h\"\n+#import \"SDLLifecycleManager.h\"\n+\n+@protocol SDLConnectionManagerType;\n+\n+NS_ASSUME_NONNULL_BEGIN\n+\n+@interface SDLRPCResponseOperation : SDLAsynchronousOperation\n+\n+@property (copy, nonatomic) __kindof SDLRPCMessage *rpc;\n+\n+- (instancetype)initWithConnectionManager:(id<SDLConnectionManagerType>)connectionManager rpc:(__kindof SDLRPCMessage *)rpc;","path":"SmartDeviceLink/SDLRPCResponseOperation.h","position":null,"original_position":22,"commit_id":"c94e4052cb780aa2c367a6e2b14d9a4099052578","original_commit_id":"e3adc5850b96c80beeee94b3d5c653ae46bc6cbe","user":{"login":"NicoleYarroch","id":19915981,"node_id":"MDQ6VXNlcjE5OTE1OTgx","avatar_url":"https://avatars1.githubusercontent.com/u/19915981?v=4","gravatar_id":"","url":"https://api.github.com/users/NicoleYarroch","html_url":"https://github.com/NicoleYarroch","followers_url":"https://api.github.com/users/NicoleYarroch/followers","following_url":"https://api.github.com/users/NicoleYarroch/following{/other_user}","gists_url":"https://api.github.com/users/NicoleYarroch/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoleYarroch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoleYarroch/subscriptions","organizations_url":"https://api.github.com/users/NicoleYarroch/orgs","repos_url":"https://api.github.com/users/NicoleYarroch/repos","events_url":"https://api.github.com/users/NicoleYarroch/events{/privacy}","received_events_url":"https://api.github.com/users/NicoleYarroch/received_events","type":"User","site_admin":false},"body":"I generalized to `rpc`","created_at":"2019-03-04T21:50:38Z","updated_at":"2019-03-04T21:50:39Z","html_url":"https://github.com/smartdevicelink/sdl_ios/pull/1165#discussion_r262258954","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/1165","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/comments/262258954"},"html":{"href":"https://github.com/smartdevicelink/sdl_ios/pull/1165#discussion_r262258954"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/1165"}},"in_reply_to_id":261624464},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/1165","id":255406340,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1NDA2MzQw","html_url":"https://github.com/smartdevicelink/sdl_ios/pull/1165","diff_url":"https://github.com/smartdevicelink/sdl_ios/pull/1165.diff","patch_url":"https://github.com/smartdevicelink/sdl_ios/pull/1165.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/1165","number":1165,"state":"open","locked":false,"title":"Weather, Media, and Navigation App Services","user":{"login":"NicoleYarroch","id":19915981,"node_id":"MDQ6VXNlcjE5OTE1OTgx","avatar_url":"https://avatars1.githubusercontent.com/u/19915981?v=4","gravatar_id":"","url":"https://api.github.com/users/NicoleYarroch","html_url":"https://github.com/NicoleYarroch","followers_url":"https://api.github.com/users/NicoleYarroch/followers","following_url":"https://api.github.com/users/NicoleYarroch/following{/other_user}","gists_url":"https://api.github.com/users/NicoleYarroch/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoleYarroch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoleYarroch/subscriptions","organizations_url":"https://api.github.com/users/NicoleYarroch/orgs","repos_url":"https://api.github.com/users/NicoleYarroch/repos","events_url":"https://api.github.com/users/NicoleYarroch/events{/privacy}","received_events_url":"https://api.github.com/users/NicoleYarroch/received_events","type":"User","site_admin":false},"body":"Fixes #1147, #1148, #1162 \r\n\r\nThis PR is **ready** for review.\r\n\r\n### Risk\r\nThis PR makes **minor** API changes.\r\n\r\n### Testing Plan\r\n* Test cases added for all new enums, structs, and RPCs. \r\n* Test cases also added for changes to the `SDLLifecycleManager`\r\n\r\n### Summary\r\n* Added new RPCs, structs and enums for the media, weather, and navigation app services.\r\n\r\n### Changelog\r\n##### Breaking Changes\r\n* none\r\n\r\n##### Enhancements\r\n* Added new RPCs, structs and enums for the media, weather, and navigation app services.\r\n\r\n### Tasks Remaining:\r\n- [x] Make sure all relevant headers are public and have been added to the *podspec* files\r\n\r\n### CLA\r\n- [x] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform)","created_at":"2019-02-22T14:06:25Z","updated_at":"2019-03-04T21:50:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f45d3a420dd6ef5fee393caffceb9a081b8db35","assignee":{"login":"NicoleYarroch","id":19915981,"node_id":"MDQ6VXNlcjE5OTE1OTgx","avatar_url":"https://avatars1.githubusercontent.com/u/19915981?v=4","gravatar_id":"","url":"https://api.github.com/users/NicoleYarroch","html_url":"https://github.com/NicoleYarroch","followers_url":"https://api.github.com/users/NicoleYarroch/followers","following_url":"https://api.github.com/users/NicoleYarroch/following{/other_user}","gists_url":"https://api.github.com/users/NicoleYarroch/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoleYarroch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoleYarroch/subscriptions","organizations_url":"https://api.github.com/users/NicoleYarroch/orgs","repos_url":"https://api.github.com/users/NicoleYarroch/repos","events_url":"https://api.github.com/users/NicoleYarroch/events{/privacy}","received_events_url":"https://api.github.com/users/NicoleYarroch/received_events","type":"User","site_admin":false},"assignees":[{"login":"NicoleYarroch","id":19915981,"node_id":"MDQ6VXNlcjE5OTE1OTgx","avatar_url":"https://avatars1.githubusercontent.com/u/19915981?v=4","gravatar_id":"","url":"https://api.github.com/users/NicoleYarroch","html_url":"https://github.com/NicoleYarroch","followers_url":"https://api.github.com/users/NicoleYarroch/followers","following_url":"https://api.github.com/users/NicoleYarroch/following{/other_user}","gists_url":"https://api.github.com/users/NicoleYarroch/gists{/gist_id}","starred_url":"https://api.github.com/users/NicoleYarroch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicoleYarroch/subscriptions","organizations_url":"https://api.github.com/users/NicoleYarroch/orgs","repos_url":"https://api.github.com/users/NicoleYarroch/repos","events_url":"https://api.github.com/users/NicoleYarroch/events{/privacy}","received_events_url":"https://api.github.com/users/NicoleYarroch/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":135859170,"node_id":"MDU6TGFiZWwxMzU4NTkxNzA=","url":"https://api.github.com/repos/smartdevicelink/sdl_ios/labels/enhancement","name":"enhancement","color":"5677fc","default":true}],"milestone":{"url":"https://api.github.com/repos/smartdevicelink/sdl_ios/milestones/22","html_url":"https://github.com/smartdevicelink/sdl_ios/milestone/22","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/milestones/22/labels","id":3743941,"node_id":"MDk6TWlsZXN0b25lMzc0Mzk0MQ==","number":22,"title":"6.2.0","description":null,"creator":{"login":"joeljfischer","id":1767063,"node_id":"MDQ6VXNlcjE3NjcwNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/1767063?v=4","gravatar_id":"","url":"https://api.github.com/users/joeljfischer","html_url":"https://github.com/joeljfischer","followers_url":"https://api.github.com/users/joeljfischer/followers","following_url":"https://api.github.com/users/joeljfischer/following{/other_user}","gists_url":"https://api.github.com/users/joeljfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/joeljfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeljfischer/subscriptions","organizations_url":"https://api.github.com/users/joeljfischer/orgs","repos_url":"https://api.github.com/users/joeljfischer/repos","events_url":"https://api.github.com/users/joeljfischer/events{/privacy}","received_events_url":"https://api.github.com/users/joeljfischer/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":21,"state":"open","created_at":"2018-10-16T18:11:10Z","updated_at":"2019-03-04T13:33:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/1165/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/1165/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/1165/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/statuses/c94e4052cb780aa2c367a6e2b14d9a4099052578","head":{"label":"smartdevicelink:feature/issues_1147_1148_1162_app_services_weather_media_navigation","ref":"feature/issues_1147_1148_1162_app_services_weather_media_navigation","sha":"c94e4052cb780aa2c367a6e2b14d9a4099052578","user":{"login":"smartdevicelink","id":8671397,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2NzEzOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24940582,"node_id":"MDEwOlJlcG9zaXRvcnkyNDk0MDU4Mg==","name":"sdl_ios","full_name":"smartdevicelink/sdl_ios","private":false,"owner":{"login":"smartdevicelink","id":8671397,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2NzEzOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/smartdevicelink/sdl_ios","description":"Get your app connected to the 🚙, make your users feel like a 🌟","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_ios","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/deployments","created_at":"2014-10-08T12:57:22Z","updated_at":"2019-03-04T13:14:10Z","pushed_at":"2019-03-04T21:43:26Z","git_url":"git://github.com/smartdevicelink/sdl_ios.git","ssh_url":"[email protected]:smartdevicelink/sdl_ios.git","clone_url":"https://github.com/smartdevicelink/sdl_ios.git","svn_url":"https://github.com/smartdevicelink/sdl_ios","homepage":"www.smartdevicelink.com","size":32615,"stargazers_count":121,"watchers_count":121,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":81,"open_issues":76,"watchers":121,"default_branch":"master"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"6920985a50b8eebb4d919a2589d47250964daa37","user":{"login":"smartdevicelink","id":8671397,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2NzEzOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24940582,"node_id":"MDEwOlJlcG9zaXRvcnkyNDk0MDU4Mg==","name":"sdl_ios","full_name":"smartdevicelink/sdl_ios","private":false,"owner":{"login":"smartdevicelink","id":8671397,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2NzEzOTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8671397?v=4","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/smartdevicelink/sdl_ios","description":"Get your app connected to the 🚙, make your users feel like a 🌟","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_ios","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_ios/deployments","created_at":"2014-10-08T12:57:22Z","updated_at":"2019-03-04T13:14:10Z","pushed_at":"2019-03-04T21:43:26Z","git_url":"git://github.com/smartdevicelink/sdl_ios.git","ssh_url":"[email protected]:smartdevicelink/sdl_ios.git","clone_url":"https://github.com/smartdevicelink/sdl_ios.git","svn_url":"https://github.com/smartdevicelink/sdl_ios","homepage":"www.smartdevicelink.com","size":32615,"stargazers_count":121,"watchers_count":121,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":81,"open_issues":76,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/1165"},"html":{"href":"https://github.com/smartdevicelink/sdl_ios/pull/1165"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/1165"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/issues/1165/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/1165/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/pulls/1165/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_ios/statuses/c94e4052cb780aa2c367a6e2b14d9a4099052578"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 24940582,
"name": "smartdevicelink/sdl_ios",
"url": "https://api.github.com/repos/smartdevicelink/sdl_ios"
}
|
{
"id": 19915981,
"login": "NicoleYarroch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/19915981?",
"url": "https://api.github.com/users/NicoleYarroch"
}
|
{
"id": 8671397,
"login": "smartdevicelink",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8671397?",
"url": "https://api.github.com/orgs/smartdevicelink"
}
| 2019-03-04T21:50:38 |
9178024438
|
{"actor":{"display_login":"NicoleYarroch"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/comments/285359304","pull_request_review_id":239216174,"id":285359304,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NTM1OTMwNA==","diff_hunk":"@@ -0,0 +1,185 @@\n+/*\n+ * This file is part of SpongeAPI, licensed under the MIT License (MIT).\n+ *\n+ * Copyright (c) SpongePowered <https://www.spongepowered.org>\n+ * Copyright (c) contributors\n+ *\n+ * Permission is hereby granted, free of charge, to any person obtaining a copy\n+ * of this software and associated documentation files (the \"Software\"), to deal\n+ * in the Software without restriction, including without limitation the rights\n+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+ * copies of the Software, and to permit persons to whom the Software is\n+ * furnished to do so, subject to the following conditions:\n+ *\n+ * The above copyright notice and this permission notice shall be included in\n+ * all copies or substantial portions of the Software.\n+ *\n+ * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+ * THE SOFTWARE.\n+ */\n+package org.spongepowered.api.network.message;\n+\n+import org.spongepowered.api.entity.living.player.Player;\n+import org.spongepowered.api.network.ChannelBinding;\n+import org.spongepowered.api.network.ClientConnection;\n+import org.spongepowered.api.network.NoResponseMessageException;\n+\n+import java.util.Optional;\n+import java.util.concurrent.CompletableFuture;\n+\n+/**\n+ * Represents a channel binding that sends and receives messages.\n+ */\n+public interface MessageChannel extends ChannelBinding {","path":"src/main/java/org/spongepowered/api/network/message/MessageChannel.java","position":38,"original_position":38,"commit_id":"fd5e03d8da389f555808a8692a763d280510c4d1","original_commit_id":"fd5e03d8da389f555808a8692a763d280510c4d1","user":{"login":"Cybermaxke","id":1364375,"node_id":"MDQ6VXNlcjEzNjQzNzU=","avatar_url":"https://avatars1.githubusercontent.com/u/1364375?v=4","gravatar_id":"","url":"https://api.github.com/users/Cybermaxke","html_url":"https://github.com/Cybermaxke","followers_url":"https://api.github.com/users/Cybermaxke/followers","following_url":"https://api.github.com/users/Cybermaxke/following{/other_user}","gists_url":"https://api.github.com/users/Cybermaxke/gists{/gist_id}","starred_url":"https://api.github.com/users/Cybermaxke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cybermaxke/subscriptions","organizations_url":"https://api.github.com/users/Cybermaxke/orgs","repos_url":"https://api.github.com/users/Cybermaxke/repos","events_url":"https://api.github.com/users/Cybermaxke/events{/privacy}","received_events_url":"https://api.github.com/users/Cybermaxke/received_events","type":"User","site_admin":false},"body":"Ah yes, I will change it to `NetworkMessageChannel`, and maybe rename `Message`, etc. as well?","created_at":"2019-05-18T23:36:05Z","updated_at":"2019-05-18T23:36:05Z","html_url":"https://github.com/SpongePowered/SpongeAPI/pull/2008#discussion_r285359304","pull_request_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/2008","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/comments/285359304"},"html":{"href":"https://github.com/SpongePowered/SpongeAPI/pull/2008#discussion_r285359304"},"pull_request":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/2008"}},"in_reply_to_id":285358790},"pull_request":{"url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/2008","id":280123461,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgwMTIzNDYx","html_url":"https://github.com/SpongePowered/SpongeAPI/pull/2008","diff_url":"https://github.com/SpongePowered/SpongeAPI/pull/2008.diff","patch_url":"https://github.com/SpongePowered/SpongeAPI/pull/2008.patch","issue_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/2008","number":2008,"state":"open","locked":false,"title":"Channel API Improvements + Client login phase","user":{"login":"Cybermaxke","id":1364375,"node_id":"MDQ6VXNlcjEzNjQzNzU=","avatar_url":"https://avatars1.githubusercontent.com/u/1364375?v=4","gravatar_id":"","url":"https://api.github.com/users/Cybermaxke","html_url":"https://github.com/Cybermaxke","followers_url":"https://api.github.com/users/Cybermaxke/followers","following_url":"https://api.github.com/users/Cybermaxke/following{/other_user}","gists_url":"https://api.github.com/users/Cybermaxke/gists{/gist_id}","starred_url":"https://api.github.com/users/Cybermaxke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cybermaxke/subscriptions","organizations_url":"https://api.github.com/users/Cybermaxke/orgs","repos_url":"https://api.github.com/users/Cybermaxke/repos","events_url":"https://api.github.com/users/Cybermaxke/events{/privacy}","received_events_url":"https://api.github.com/users/Cybermaxke/received_events","type":"User","site_admin":false},"body":"A few major additions are in this PR, plugin channel support for the login phase and request/response based message registration. The request/response system was originally added for the login phase but will be expanded to the normal ones as well. \r\n\r\n- `RawDataChannel` - Only during play phase.\r\n- `RawLoginDataChannel` - Only during login phase.\r\n- `MessageChannel` - Both login and play phases.`sendToServer` is limited to the play phase.\r\n\r\nHandlers are now attached to the `MessageBinding` which is returned by the register method. The reduces the amount of method parameters that were used previously.","created_at":"2019-05-18T20:05:43Z","updated_at":"2019-05-18T23:36:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e280ccd4c8eed87980424f15aec461e3dbb41ed4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/2008/commits","review_comments_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/2008/comments","review_comment_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/2008/comments","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/statuses/fd5e03d8da389f555808a8692a763d280510c4d1","head":{"label":"SpongePowered:plugin-client-login-phase","ref":"plugin-client-login-phase","sha":"fd5e03d8da389f555808a8692a763d280510c4d1","user":{"login":"SpongePowered","id":8683473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODM0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":23770421,"node_id":"MDEwOlJlcG9zaXRvcnkyMzc3MDQyMQ==","name":"SpongeAPI","full_name":"SpongePowered/SpongeAPI","private":false,"owner":{"login":"SpongePowered","id":8683473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODM0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SpongePowered/SpongeAPI","description":"A Minecraft plugin API","fork":false,"url":"https://api.github.com/repos/SpongePowered/SpongeAPI","forks_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/forks","keys_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/teams","hooks_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/events","assignees_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/tags","blobs_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/subscription","commits_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/merges","archive_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/downloads","issues_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/releases{/id}","deployments_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/deployments","created_at":"2014-09-07T20:39:25Z","updated_at":"2019-05-17T13:56:51Z","pushed_at":"2019-05-18T20:50:54Z","git_url":"git://github.com/SpongePowered/SpongeAPI.git","ssh_url":"[email protected]:SpongePowered/SpongeAPI.git","clone_url":"https://github.com/SpongePowered/SpongeAPI.git","svn_url":"https://github.com/SpongePowered/SpongeAPI","homepage":"http://www.spongepowered.org/","size":13365,"stargazers_count":967,"watchers_count":967,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":341,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":229,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":341,"open_issues":229,"watchers":967,"default_branch":"stable-7"}},"base":{"label":"SpongePowered:api-8","ref":"api-8","sha":"7b99dcb1e3855d5a3d677e55b54c42b2530236bb","user":{"login":"SpongePowered","id":8683473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODM0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":23770421,"node_id":"MDEwOlJlcG9zaXRvcnkyMzc3MDQyMQ==","name":"SpongeAPI","full_name":"SpongePowered/SpongeAPI","private":false,"owner":{"login":"SpongePowered","id":8683473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODM0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SpongePowered/SpongeAPI","description":"A Minecraft plugin API","fork":false,"url":"https://api.github.com/repos/SpongePowered/SpongeAPI","forks_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/forks","keys_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/teams","hooks_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/events","assignees_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/tags","blobs_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/subscription","commits_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/merges","archive_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/downloads","issues_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/releases{/id}","deployments_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/deployments","created_at":"2014-09-07T20:39:25Z","updated_at":"2019-05-17T13:56:51Z","pushed_at":"2019-05-18T20:50:54Z","git_url":"git://github.com/SpongePowered/SpongeAPI.git","ssh_url":"[email protected]:SpongePowered/SpongeAPI.git","clone_url":"https://github.com/SpongePowered/SpongeAPI.git","svn_url":"https://github.com/SpongePowered/SpongeAPI","homepage":"http://www.spongepowered.org/","size":13365,"stargazers_count":967,"watchers_count":967,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":341,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":229,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":341,"open_issues":229,"watchers":967,"default_branch":"stable-7"}},"_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/2008"},"html":{"href":"https://github.com/SpongePowered/SpongeAPI/pull/2008"},"issue":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/2008"},"comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/2008/comments"},"review_comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/2008/comments"},"review_comment":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/2008/commits"},"statuses":{"href":"https://api.github.com/repos/SpongePowered/SpongeAPI/statuses/fd5e03d8da389f555808a8692a763d280510c4d1"}},"author_association":"MEMBER"}}
|
{
"id": 23770421,
"name": "SpongePowered/SpongeAPI",
"url": "https://api.github.com/repos/SpongePowered/SpongeAPI"
}
|
{
"id": 1364375,
"login": "Cybermaxke",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1364375?",
"url": "https://api.github.com/users/Cybermaxke"
}
|
{
"id": 8683473,
"login": "SpongePowered",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8683473?",
"url": "https://api.github.com/orgs/SpongePowered"
}
| 2019-05-18T23:36:05 |
9653069638
|
{"actor":{"display_login":"Cybermaxke"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/pulls/comments/326172232","pull_request_review_id":290563677,"id":326172232,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNjE3MjIzMg==","diff_hunk":"@@ -377,6 +377,39 @@ keepalived::lvs::real_server { 'example2.example.com':\n }\n ```\n \n+or hiera:\n+\n+```yaml\n+---\n+keepalived::lvs_virtual_server:\n+ www.example.com:\n+ ip_address: '1.2.3.4'\n+ port: 80\n+ delay_loop: 7\n+ lb_algo: 'wlc'\n+ lb_kind: 'DR'\n+ persistence_timeout: 86400\n+ virtualhost: 'www.example.com'\n+ protocol: 'TCP'\n+\n+keepalived::lvs_real_server:\n+ example1.example.com:\n+ virtual_server: 'www.example.com'\n+ ip_address: '1.2.3.8'\n+ port: 80\n+ options:\n+ weight: '1000'\n+ TCP_CHECK:\n+ connection_timeout: 3","path":"README.md","position":27,"original_position":27,"commit_id":"67bb8ffc211a239619ed96bedfc906e8971eed71","original_commit_id":"67bb8ffc211a239619ed96bedfc906e8971eed71","user":{"login":"rubenk","id":47338,"node_id":"MDQ6VXNlcjQ3MzM4","avatar_url":"https://avatars1.githubusercontent.com/u/47338?v=4","gravatar_id":"","url":"https://api.github.com/users/rubenk","html_url":"https://github.com/rubenk","followers_url":"https://api.github.com/users/rubenk/followers","following_url":"https://api.github.com/users/rubenk/following{/other_user}","gists_url":"https://api.github.com/users/rubenk/gists{/gist_id}","starred_url":"https://api.github.com/users/rubenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubenk/subscriptions","organizations_url":"https://api.github.com/users/rubenk/orgs","repos_url":"https://api.github.com/users/rubenk/repos","events_url":"https://api.github.com/users/rubenk/events{/privacy}","received_events_url":"https://api.github.com/users/rubenk/received_events","type":"User","site_admin":false},"body":"it is connect_timeout, not connection_timeout","created_at":"2019-09-19T13:25:52Z","updated_at":"2019-09-19T13:25:53Z","html_url":"https://github.com/voxpupuli/puppet-keepalived/pull/190#discussion_r326172232","pull_request_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/pulls/190","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-keepalived/pulls/comments/326172232"},"html":{"href":"https://github.com/voxpupuli/puppet-keepalived/pull/190#discussion_r326172232"},"pull_request":{"href":"https://api.github.com/repos/voxpupuli/puppet-keepalived/pulls/190"}}},"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/pulls/190","id":305908507,"node_id":"MDExOlB1bGxSZXF1ZXN0MzA1OTA4NTA3","html_url":"https://github.com/voxpupuli/puppet-keepalived/pull/190","diff_url":"https://github.com/voxpupuli/puppet-keepalived/pull/190.diff","patch_url":"https://github.com/voxpupuli/puppet-keepalived/pull/190.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/issues/190","number":190,"state":"open","locked":false,"title":"LVS hiera support","user":{"login":"7matd7","id":53464592,"node_id":"MDQ6VXNlcjUzNDY0NTky","avatar_url":"https://avatars0.githubusercontent.com/u/53464592?v=4","gravatar_id":"","url":"https://api.github.com/users/7matd7","html_url":"https://github.com/7matd7","followers_url":"https://api.github.com/users/7matd7/followers","following_url":"https://api.github.com/users/7matd7/following{/other_user}","gists_url":"https://api.github.com/users/7matd7/gists{/gist_id}","starred_url":"https://api.github.com/users/7matd7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7matd7/subscriptions","organizations_url":"https://api.github.com/users/7matd7/orgs","repos_url":"https://api.github.com/users/7matd7/repos","events_url":"https://api.github.com/users/7matd7/events{/privacy}","received_events_url":"https://api.github.com/users/7matd7/received_events","type":"User","site_admin":false},"body":"#### Pull Request (PR) description\r\nAdds option to configure LVS real and virtual servers from hiera level\r\n\r\n#### This Pull Request (PR) fixes the following issues\r\nFixes #116 ?","created_at":"2019-08-09T09:20:49Z","updated_at":"2019-09-19T13:25:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c624facd7c8288780256d116a58efb49e3367182","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":20339754,"node_id":"MDU6TGFiZWwyMDMzOTc1NA==","url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/labels/enhancement","name":"enhancement","color":"0052cc","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/pulls/190/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/pulls/190/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/issues/190/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/statuses/67bb8ffc211a239619ed96bedfc906e8971eed71","head":{"label":"7matd7:lvs_hiera_support","ref":"lvs_hiera_support","sha":"67bb8ffc211a239619ed96bedfc906e8971eed71","user":{"login":"7matd7","id":53464592,"node_id":"MDQ6VXNlcjUzNDY0NTky","avatar_url":"https://avatars0.githubusercontent.com/u/53464592?v=4","gravatar_id":"","url":"https://api.github.com/users/7matd7","html_url":"https://github.com/7matd7","followers_url":"https://api.github.com/users/7matd7/followers","following_url":"https://api.github.com/users/7matd7/following{/other_user}","gists_url":"https://api.github.com/users/7matd7/gists{/gist_id}","starred_url":"https://api.github.com/users/7matd7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7matd7/subscriptions","organizations_url":"https://api.github.com/users/7matd7/orgs","repos_url":"https://api.github.com/users/7matd7/repos","events_url":"https://api.github.com/users/7matd7/events{/privacy}","received_events_url":"https://api.github.com/users/7matd7/received_events","type":"User","site_admin":false},"repo":{"id":199590250,"node_id":"MDEwOlJlcG9zaXRvcnkxOTk1OTAyNTA=","name":"puppet-keepalived","full_name":"7matd7/puppet-keepalived","private":false,"owner":{"login":"7matd7","id":53464592,"node_id":"MDQ6VXNlcjUzNDY0NTky","avatar_url":"https://avatars0.githubusercontent.com/u/53464592?v=4","gravatar_id":"","url":"https://api.github.com/users/7matd7","html_url":"https://github.com/7matd7","followers_url":"https://api.github.com/users/7matd7/followers","following_url":"https://api.github.com/users/7matd7/following{/other_user}","gists_url":"https://api.github.com/users/7matd7/gists{/gist_id}","starred_url":"https://api.github.com/users/7matd7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/7matd7/subscriptions","organizations_url":"https://api.github.com/users/7matd7/orgs","repos_url":"https://api.github.com/users/7matd7/repos","events_url":"https://api.github.com/users/7matd7/events{/privacy}","received_events_url":"https://api.github.com/users/7matd7/received_events","type":"User","site_admin":false},"html_url":"https://github.com/7matd7/puppet-keepalived","description":"Puppet Module to manage Keepalived","fork":true,"url":"https://api.github.com/repos/7matd7/puppet-keepalived","forks_url":"https://api.github.com/repos/7matd7/puppet-keepalived/forks","keys_url":"https://api.github.com/repos/7matd7/puppet-keepalived/keys{/key_id}","collaborators_url":"https://api.github.com/repos/7matd7/puppet-keepalived/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/7matd7/puppet-keepalived/teams","hooks_url":"https://api.github.com/repos/7matd7/puppet-keepalived/hooks","issue_events_url":"https://api.github.com/repos/7matd7/puppet-keepalived/issues/events{/number}","events_url":"https://api.github.com/repos/7matd7/puppet-keepalived/events","assignees_url":"https://api.github.com/repos/7matd7/puppet-keepalived/assignees{/user}","branches_url":"https://api.github.com/repos/7matd7/puppet-keepalived/branches{/branch}","tags_url":"https://api.github.com/repos/7matd7/puppet-keepalived/tags","blobs_url":"https://api.github.com/repos/7matd7/puppet-keepalived/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/7matd7/puppet-keepalived/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/7matd7/puppet-keepalived/git/refs{/sha}","trees_url":"https://api.github.com/repos/7matd7/puppet-keepalived/git/trees{/sha}","statuses_url":"https://api.github.com/repos/7matd7/puppet-keepalived/statuses/{sha}","languages_url":"https://api.github.com/repos/7matd7/puppet-keepalived/languages","stargazers_url":"https://api.github.com/repos/7matd7/puppet-keepalived/stargazers","contributors_url":"https://api.github.com/repos/7matd7/puppet-keepalived/contributors","subscribers_url":"https://api.github.com/repos/7matd7/puppet-keepalived/subscribers","subscription_url":"https://api.github.com/repos/7matd7/puppet-keepalived/subscription","commits_url":"https://api.github.com/repos/7matd7/puppet-keepalived/commits{/sha}","git_commits_url":"https://api.github.com/repos/7matd7/puppet-keepalived/git/commits{/sha}","comments_url":"https://api.github.com/repos/7matd7/puppet-keepalived/comments{/number}","issue_comment_url":"https://api.github.com/repos/7matd7/puppet-keepalived/issues/comments{/number}","contents_url":"https://api.github.com/repos/7matd7/puppet-keepalived/contents/{+path}","compare_url":"https://api.github.com/repos/7matd7/puppet-keepalived/compare/{base}...{head}","merges_url":"https://api.github.com/repos/7matd7/puppet-keepalived/merges","archive_url":"https://api.github.com/repos/7matd7/puppet-keepalived/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/7matd7/puppet-keepalived/downloads","issues_url":"https://api.github.com/repos/7matd7/puppet-keepalived/issues{/number}","pulls_url":"https://api.github.com/repos/7matd7/puppet-keepalived/pulls{/number}","milestones_url":"https://api.github.com/repos/7matd7/puppet-keepalived/milestones{/number}","notifications_url":"https://api.github.com/repos/7matd7/puppet-keepalived/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/7matd7/puppet-keepalived/labels{/name}","releases_url":"https://api.github.com/repos/7matd7/puppet-keepalived/releases{/id}","deployments_url":"https://api.github.com/repos/7matd7/puppet-keepalived/deployments","created_at":"2019-07-30T06:36:02Z","updated_at":"2019-07-30T06:36:04Z","pushed_at":"2019-08-09T09:17:07Z","git_url":"git://github.com/7matd7/puppet-keepalived.git","ssh_url":"[email protected]:7matd7/puppet-keepalived.git","clone_url":"https://github.com/7matd7/puppet-keepalived.git","svn_url":"https://github.com/7matd7/puppet-keepalived","homepage":"https://forge.puppet.com/puppet/keepalived","size":366,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"f833bc50d7f129bf02f0ecc682a8a36453ad8c58","user":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":6863314,"node_id":"MDEwOlJlcG9zaXRvcnk2ODYzMzE0","name":"puppet-keepalived","full_name":"voxpupuli/puppet-keepalived","private":false,"owner":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/voxpupuli/puppet-keepalived","description":"Puppet Module to manage Keepalived","fork":false,"url":"https://api.github.com/repos/voxpupuli/puppet-keepalived","forks_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-keepalived/deployments","created_at":"2012-11-26T10:22:35Z","updated_at":"2019-07-27T14:36:09Z","pushed_at":"2019-09-05T19:29:48Z","git_url":"git://github.com/voxpupuli/puppet-keepalived.git","ssh_url":"[email protected]:voxpupuli/puppet-keepalived.git","clone_url":"https://github.com/voxpupuli/puppet-keepalived.git","svn_url":"https://github.com/voxpupuli/puppet-keepalived","homepage":"https://forge.puppet.com/puppet/keepalived","size":364,"stargazers_count":41,"watchers_count":41,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":126,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":126,"open_issues":22,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-keepalived/pulls/190"},"html":{"href":"https://github.com/voxpupuli/puppet-keepalived/pull/190"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-keepalived/issues/190"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-keepalived/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-keepalived/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-keepalived/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-keepalived/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-keepalived/statuses/67bb8ffc211a239619ed96bedfc906e8971eed71"}},"author_association":"NONE"}}
|
{
"id": 6863314,
"name": "voxpupuli/puppet-keepalived",
"url": "https://api.github.com/repos/voxpupuli/puppet-keepalived"
}
|
{
"id": 47338,
"login": "rubenk",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/47338?",
"url": "https://api.github.com/users/rubenk"
}
|
{
"id": 8693967,
"login": "voxpupuli",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8693967?",
"url": "https://api.github.com/orgs/voxpupuli"
}
| 2019-09-19T13:25:52 |
10451729344
|
{"actor":{"display_login":"rubenk"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-collectd/pulls/comments/267115244","pull_request_review_id":216441931,"id":267115244,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2NzExNTI0NA==","diff_hunk":"@@ -57,7 +57,7 @@\n # Run it twice and test for idempotency\n apply_manifest(pp, catch_failures: true)\n apply_manifest(pp, catch_changes: true)\n- shell('sleep 10')\n+ shell('sleep 30')","path":"spec/acceptance/class_plugin_python_spec.rb","position":5,"original_position":5,"commit_id":"23b13ccffef4d45d2f148d94aee5908d5cd11ce5","original_commit_id":"23b13ccffef4d45d2f148d94aee5908d5cd11ce5","user":{"login":"zoojar","id":1691082,"node_id":"MDQ6VXNlcjE2OTEwODI=","avatar_url":"https://avatars0.githubusercontent.com/u/1691082?v=4","gravatar_id":"","url":"https://api.github.com/users/zoojar","html_url":"https://github.com/zoojar","followers_url":"https://api.github.com/users/zoojar/followers","following_url":"https://api.github.com/users/zoojar/following{/other_user}","gists_url":"https://api.github.com/users/zoojar/gists{/gist_id}","starred_url":"https://api.github.com/users/zoojar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoojar/subscriptions","organizations_url":"https://api.github.com/users/zoojar/orgs","repos_url":"https://api.github.com/users/zoojar/repos","events_url":"https://api.github.com/users/zoojar/events{/privacy}","received_events_url":"https://api.github.com/users/zoojar/received_events","type":"User","site_admin":false},"body":"To try to get the tests to pass. Wondered if it was some kind of race\r\ncondition","created_at":"2019-03-19T21:59:31Z","updated_at":"2019-03-19T21:59:32Z","html_url":"https://github.com/voxpupuli/puppet-collectd/pull/871#discussion_r267115244","pull_request_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/pulls/871","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-collectd/pulls/comments/267115244"},"html":{"href":"https://github.com/voxpupuli/puppet-collectd/pull/871#discussion_r267115244"},"pull_request":{"href":"https://api.github.com/repos/voxpupuli/puppet-collectd/pulls/871"}},"in_reply_to_id":267113577},"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-collectd/pulls/871","id":260730225,"node_id":"MDExOlB1bGxSZXF1ZXN0MjYwNzMwMjI1","html_url":"https://github.com/voxpupuli/puppet-collectd/pull/871","diff_url":"https://github.com/voxpupuli/puppet-collectd/pull/871.diff","patch_url":"https://github.com/voxpupuli/puppet-collectd/pull/871.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/issues/871","number":871,"state":"open","locked":false,"title":"add FlushInterval param to loadplugin config","user":{"login":"zoojar","id":1691082,"node_id":"MDQ6VXNlcjE2OTEwODI=","avatar_url":"https://avatars0.githubusercontent.com/u/1691082?v=4","gravatar_id":"","url":"https://api.github.com/users/zoojar","html_url":"https://github.com/zoojar","followers_url":"https://api.github.com/users/zoojar/followers","following_url":"https://api.github.com/users/zoojar/following{/other_user}","gists_url":"https://api.github.com/users/zoojar/gists{/gist_id}","starred_url":"https://api.github.com/users/zoojar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoojar/subscriptions","organizations_url":"https://api.github.com/users/zoojar/orgs","repos_url":"https://api.github.com/users/zoojar/repos","events_url":"https://api.github.com/users/zoojar/events{/privacy}","received_events_url":"https://api.github.com/users/zoojar/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to this project!\r\n\r\n- This project has a Contributor Code of Conduct: https://voxpupuli.org/coc/\r\n- Please check that here is no existing issue or PR that addresses your problem.\r\n- Our vulnerabilities reporting process is at https://voxpupuli.org/security/\r\n\r\n-->\r\n#### Pull Request (PR) description\r\n<!--\r\n Add FlushInterval param to loadplugin config\r\n-->\r\n\r\n#### This Pull Request (PR) fixes the following issues\r\n<!--\r\n feature: add FlushInterval param to loadplugin config\r\n-->\r\n","created_at":"2019-03-13T11:40:54Z","updated_at":"2019-03-19T21:59:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c25f87f53b6e57b0bb1bb45acf547463658a55a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":27591039,"node_id":"MDU6TGFiZWwyNzU5MTAzOQ==","url":"https://api.github.com/repos/voxpupuli/puppet-collectd/labels/enhancement","name":"enhancement","color":"0052cc","default":true},{"id":391451974,"node_id":"MDU6TGFiZWwzOTE0NTE5NzQ=","url":"https://api.github.com/repos/voxpupuli/puppet-collectd/labels/needs-work","name":"needs-work","color":"fbca04","default":false},{"id":391451975,"node_id":"MDU6TGFiZWwzOTE0NTE5NzU=","url":"https://api.github.com/repos/voxpupuli/puppet-collectd/labels/tests-fail","name":"tests-fail","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/pulls/871/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/pulls/871/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/issues/871/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/statuses/23b13ccffef4d45d2f148d94aee5908d5cd11ce5","head":{"label":"SplunkCloud:flushinterval","ref":"flushinterval","sha":"23b13ccffef4d45d2f148d94aee5908d5cd11ce5","user":{"login":"SplunkCloud","id":32337355,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMzM3MzU1","avatar_url":"https://avatars0.githubusercontent.com/u/32337355?v=4","gravatar_id":"","url":"https://api.github.com/users/SplunkCloud","html_url":"https://github.com/SplunkCloud","followers_url":"https://api.github.com/users/SplunkCloud/followers","following_url":"https://api.github.com/users/SplunkCloud/following{/other_user}","gists_url":"https://api.github.com/users/SplunkCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/SplunkCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SplunkCloud/subscriptions","organizations_url":"https://api.github.com/users/SplunkCloud/orgs","repos_url":"https://api.github.com/users/SplunkCloud/repos","events_url":"https://api.github.com/users/SplunkCloud/events{/privacy}","received_events_url":"https://api.github.com/users/SplunkCloud/received_events","type":"Organization","site_admin":false},"repo":{"id":175407076,"node_id":"MDEwOlJlcG9zaXRvcnkxNzU0MDcwNzY=","name":"puppet-collectd","full_name":"SplunkCloud/puppet-collectd","private":false,"owner":{"login":"SplunkCloud","id":32337355,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMzM3MzU1","avatar_url":"https://avatars0.githubusercontent.com/u/32337355?v=4","gravatar_id":"","url":"https://api.github.com/users/SplunkCloud","html_url":"https://github.com/SplunkCloud","followers_url":"https://api.github.com/users/SplunkCloud/followers","following_url":"https://api.github.com/users/SplunkCloud/following{/other_user}","gists_url":"https://api.github.com/users/SplunkCloud/gists{/gist_id}","starred_url":"https://api.github.com/users/SplunkCloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SplunkCloud/subscriptions","organizations_url":"https://api.github.com/users/SplunkCloud/orgs","repos_url":"https://api.github.com/users/SplunkCloud/repos","events_url":"https://api.github.com/users/SplunkCloud/events{/privacy}","received_events_url":"https://api.github.com/users/SplunkCloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SplunkCloud/puppet-collectd","description":"Collectd module for Puppet","fork":true,"url":"https://api.github.com/repos/SplunkCloud/puppet-collectd","forks_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/forks","keys_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/teams","hooks_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/hooks","issue_events_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/issues/events{/number}","events_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/events","assignees_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/assignees{/user}","branches_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/branches{/branch}","tags_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/tags","blobs_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/languages","stargazers_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/stargazers","contributors_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/contributors","subscribers_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/subscribers","subscription_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/subscription","commits_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/contents/{+path}","compare_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/merges","archive_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/downloads","issues_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/issues{/number}","pulls_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/labels{/name}","releases_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/releases{/id}","deployments_url":"https://api.github.com/repos/SplunkCloud/puppet-collectd/deployments","created_at":"2019-03-13T11:27:04Z","updated_at":"2019-03-13T11:34:36Z","pushed_at":"2019-03-19T15:21:43Z","git_url":"git://github.com/SplunkCloud/puppet-collectd.git","ssh_url":"[email protected]:SplunkCloud/puppet-collectd.git","clone_url":"https://github.com/SplunkCloud/puppet-collectd.git","svn_url":"https://github.com/SplunkCloud/puppet-collectd","homepage":"https://forge.puppet.com/puppet/collectd","size":2118,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"d7b6b8c493e808534bdd4b1e500065ce46e40434","user":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":8063324,"node_id":"MDEwOlJlcG9zaXRvcnk4MDYzMzI0","name":"puppet-collectd","full_name":"voxpupuli/puppet-collectd","private":false,"owner":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/voxpupuli/puppet-collectd","description":"Collectd module for Puppet","fork":false,"url":"https://api.github.com/repos/voxpupuli/puppet-collectd","forks_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-collectd/deployments","created_at":"2013-02-07T00:21:39Z","updated_at":"2019-03-16T13:40:34Z","pushed_at":"2019-03-19T15:21:44Z","git_url":"git://github.com/voxpupuli/puppet-collectd.git","ssh_url":"[email protected]:voxpupuli/puppet-collectd.git","clone_url":"https://github.com/voxpupuli/puppet-collectd.git","svn_url":"https://github.com/voxpupuli/puppet-collectd","homepage":"https://forge.puppet.com/puppet/collectd","size":2125,"stargazers_count":69,"watchers_count":69,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":265,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":265,"open_issues":54,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-collectd/pulls/871"},"html":{"href":"https://github.com/voxpupuli/puppet-collectd/pull/871"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-collectd/issues/871"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-collectd/issues/871/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-collectd/pulls/871/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-collectd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-collectd/pulls/871/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-collectd/statuses/23b13ccffef4d45d2f148d94aee5908d5cd11ce5"}},"author_association":"NONE"}}
|
{
"id": 8063324,
"name": "voxpupuli/puppet-collectd",
"url": "https://api.github.com/repos/voxpupuli/puppet-collectd"
}
|
{
"id": 1691082,
"login": "zoojar",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1691082?",
"url": "https://api.github.com/users/zoojar"
}
|
{
"id": 8693967,
"login": "voxpupuli",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8693967?",
"url": "https://api.github.com/orgs/voxpupuli"
}
| 2019-03-19T21:59:31 |
9275250446
|
{"actor":{"display_login":"zoojar"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/oceanobservatories/stream_engine/pulls/comments/276740964","pull_request_review_id":228386886,"id":276740964,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3Njc0MDk2NA==","diff_hunk":"@@ -119,6 +120,15 @@ def get_local_dir(input_data):\n return os.path.join(base_dir, request_dir)\n \n \n+def get_final_dir(input_data):\n+ base_dir = app.config['FINAL_ASYNC_DIR']","path":"engine/routes.py","position":13,"original_position":13,"commit_id":"bd9d60841eb512d04dc3c6e32e73d37b6883b1dd","original_commit_id":"bd9d60841eb512d04dc3c6e32e73d37b6883b1dd","user":{"login":"danmergens","id":6914984,"node_id":"MDQ6VXNlcjY5MTQ5ODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6914984?v=4","gravatar_id":"","url":"https://api.github.com/users/danmergens","html_url":"https://github.com/danmergens","followers_url":"https://api.github.com/users/danmergens/followers","following_url":"https://api.github.com/users/danmergens/following{/other_user}","gists_url":"https://api.github.com/users/danmergens/gists{/gist_id}","starred_url":"https://api.github.com/users/danmergens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmergens/subscriptions","organizations_url":"https://api.github.com/users/danmergens/orgs","repos_url":"https://api.github.com/users/danmergens/repos","events_url":"https://api.github.com/users/danmergens/events{/privacy}","received_events_url":"https://api.github.com/users/danmergens/received_events","type":"User","site_admin":false},"body":"is the intent to allow the configuration to be updated without restarting stream engine? I would expect this is a once and done thing, so `base_dir` should be set outside this function as a \"const\" variable. \r\n\r\nSetting the value once has the benefit of not reading from disk every time this function is called.","created_at":"2019-04-18T16:32:36Z","updated_at":"2019-04-18T16:46:00Z","html_url":"https://github.com/oceanobservatories/stream_engine/pull/68#discussion_r276740964","pull_request_url":"https://api.github.com/repos/oceanobservatories/stream_engine/pulls/68","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oceanobservatories/stream_engine/pulls/comments/276740964"},"html":{"href":"https://github.com/oceanobservatories/stream_engine/pull/68#discussion_r276740964"},"pull_request":{"href":"https://api.github.com/repos/oceanobservatories/stream_engine/pulls/68"}}},"pull_request":{"url":"https://api.github.com/repos/oceanobservatories/stream_engine/pulls/68","id":271730343,"node_id":"MDExOlB1bGxSZXF1ZXN0MjcxNzMwMzQz","html_url":"https://github.com/oceanobservatories/stream_engine/pull/68","diff_url":"https://github.com/oceanobservatories/stream_engine/pull/68.diff","patch_url":"https://github.com/oceanobservatories/stream_engine/pull/68.patch","issue_url":"https://api.github.com/repos/oceanobservatories/stream_engine/issues/68","number":68,"state":"open","locked":false,"title":"Issue #14159 - Add stats endpoint to query download size and time","user":{"login":"sgfoote","id":18015208,"node_id":"MDQ6VXNlcjE4MDE1MjA4","avatar_url":"https://avatars1.githubusercontent.com/u/18015208?v=4","gravatar_id":"","url":"https://api.github.com/users/sgfoote","html_url":"https://github.com/sgfoote","followers_url":"https://api.github.com/users/sgfoote/followers","following_url":"https://api.github.com/users/sgfoote/following{/other_user}","gists_url":"https://api.github.com/users/sgfoote/gists{/gist_id}","starred_url":"https://api.github.com/users/sgfoote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgfoote/subscriptions","organizations_url":"https://api.github.com/users/sgfoote/orgs","repos_url":"https://api.github.com/users/sgfoote/repos","events_url":"https://api.github.com/users/sgfoote/events{/privacy}","received_events_url":"https://api.github.com/users/sgfoote/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-04-18T15:15:14Z","updated_at":"2019-04-18T16:46:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5e74acd390def8ddd0fc6c16d7cbe116a14ceb3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"oceanzus","id":1877122,"node_id":"MDQ6VXNlcjE4NzcxMjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1877122?v=4","gravatar_id":"","url":"https://api.github.com/users/oceanzus","html_url":"https://github.com/oceanzus","followers_url":"https://api.github.com/users/oceanzus/followers","following_url":"https://api.github.com/users/oceanzus/following{/other_user}","gists_url":"https://api.github.com/users/oceanzus/gists{/gist_id}","starred_url":"https://api.github.com/users/oceanzus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oceanzus/subscriptions","organizations_url":"https://api.github.com/users/oceanzus/orgs","repos_url":"https://api.github.com/users/oceanzus/repos","events_url":"https://api.github.com/users/oceanzus/events{/privacy}","received_events_url":"https://api.github.com/users/oceanzus/received_events","type":"User","site_admin":false},{"login":"tlfish3638","id":31706152,"node_id":"MDQ6VXNlcjMxNzA2MTUy","avatar_url":"https://avatars1.githubusercontent.com/u/31706152?v=4","gravatar_id":"","url":"https://api.github.com/users/tlfish3638","html_url":"https://github.com/tlfish3638","followers_url":"https://api.github.com/users/tlfish3638/followers","following_url":"https://api.github.com/users/tlfish3638/following{/other_user}","gists_url":"https://api.github.com/users/tlfish3638/gists{/gist_id}","starred_url":"https://api.github.com/users/tlfish3638/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlfish3638/subscriptions","organizations_url":"https://api.github.com/users/tlfish3638/orgs","repos_url":"https://api.github.com/users/tlfish3638/repos","events_url":"https://api.github.com/users/tlfish3638/events{/privacy}","received_events_url":"https://api.github.com/users/tlfish3638/received_events","type":"User","site_admin":false},{"login":"steinermg","id":45241575,"node_id":"MDQ6VXNlcjQ1MjQxNTc1","avatar_url":"https://avatars1.githubusercontent.com/u/45241575?v=4","gravatar_id":"","url":"https://api.github.com/users/steinermg","html_url":"https://github.com/steinermg","followers_url":"https://api.github.com/users/steinermg/followers","following_url":"https://api.github.com/users/steinermg/following{/other_user}","gists_url":"https://api.github.com/users/steinermg/gists{/gist_id}","starred_url":"https://api.github.com/users/steinermg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steinermg/subscriptions","organizations_url":"https://api.github.com/users/steinermg/orgs","repos_url":"https://api.github.com/users/steinermg/repos","events_url":"https://api.github.com/users/steinermg/events{/privacy}","received_events_url":"https://api.github.com/users/steinermg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oceanobservatories/stream_engine/pulls/68/commits","review_comments_url":"https://api.github.com/repos/oceanobservatories/stream_engine/pulls/68/comments","review_comment_url":"https://api.github.com/repos/oceanobservatories/stream_engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oceanobservatories/stream_engine/issues/68/comments","statuses_url":"https://api.github.com/repos/oceanobservatories/stream_engine/statuses/bd9d60841eb512d04dc3c6e32e73d37b6883b1dd","head":{"label":"sgfoote:master","ref":"master","sha":"bd9d60841eb512d04dc3c6e32e73d37b6883b1dd","user":{"login":"sgfoote","id":18015208,"node_id":"MDQ6VXNlcjE4MDE1MjA4","avatar_url":"https://avatars1.githubusercontent.com/u/18015208?v=4","gravatar_id":"","url":"https://api.github.com/users/sgfoote","html_url":"https://github.com/sgfoote","followers_url":"https://api.github.com/users/sgfoote/followers","following_url":"https://api.github.com/users/sgfoote/following{/other_user}","gists_url":"https://api.github.com/users/sgfoote/gists{/gist_id}","starred_url":"https://api.github.com/users/sgfoote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgfoote/subscriptions","organizations_url":"https://api.github.com/users/sgfoote/orgs","repos_url":"https://api.github.com/users/sgfoote/repos","events_url":"https://api.github.com/users/sgfoote/events{/privacy}","received_events_url":"https://api.github.com/users/sgfoote/received_events","type":"User","site_admin":false},"repo":{"id":102885438,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI4ODU0Mzg=","name":"stream_engine","full_name":"sgfoote/stream_engine","private":false,"owner":{"login":"sgfoote","id":18015208,"node_id":"MDQ6VXNlcjE4MDE1MjA4","avatar_url":"https://avatars1.githubusercontent.com/u/18015208?v=4","gravatar_id":"","url":"https://api.github.com/users/sgfoote","html_url":"https://github.com/sgfoote","followers_url":"https://api.github.com/users/sgfoote/followers","following_url":"https://api.github.com/users/sgfoote/following{/other_user}","gists_url":"https://api.github.com/users/sgfoote/gists{/gist_id}","starred_url":"https://api.github.com/users/sgfoote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgfoote/subscriptions","organizations_url":"https://api.github.com/users/sgfoote/orgs","repos_url":"https://api.github.com/users/sgfoote/repos","events_url":"https://api.github.com/users/sgfoote/events{/privacy}","received_events_url":"https://api.github.com/users/sgfoote/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sgfoote/stream_engine","description":null,"fork":true,"url":"https://api.github.com/repos/sgfoote/stream_engine","forks_url":"https://api.github.com/repos/sgfoote/stream_engine/forks","keys_url":"https://api.github.com/repos/sgfoote/stream_engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgfoote/stream_engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgfoote/stream_engine/teams","hooks_url":"https://api.github.com/repos/sgfoote/stream_engine/hooks","issue_events_url":"https://api.github.com/repos/sgfoote/stream_engine/issues/events{/number}","events_url":"https://api.github.com/repos/sgfoote/stream_engine/events","assignees_url":"https://api.github.com/repos/sgfoote/stream_engine/assignees{/user}","branches_url":"https://api.github.com/repos/sgfoote/stream_engine/branches{/branch}","tags_url":"https://api.github.com/repos/sgfoote/stream_engine/tags","blobs_url":"https://api.github.com/repos/sgfoote/stream_engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgfoote/stream_engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgfoote/stream_engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgfoote/stream_engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgfoote/stream_engine/statuses/{sha}","languages_url":"https://api.github.com/repos/sgfoote/stream_engine/languages","stargazers_url":"https://api.github.com/repos/sgfoote/stream_engine/stargazers","contributors_url":"https://api.github.com/repos/sgfoote/stream_engine/contributors","subscribers_url":"https://api.github.com/repos/sgfoote/stream_engine/subscribers","subscription_url":"https://api.github.com/repos/sgfoote/stream_engine/subscription","commits_url":"https://api.github.com/repos/sgfoote/stream_engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgfoote/stream_engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgfoote/stream_engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgfoote/stream_engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgfoote/stream_engine/contents/{+path}","compare_url":"https://api.github.com/repos/sgfoote/stream_engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgfoote/stream_engine/merges","archive_url":"https://api.github.com/repos/sgfoote/stream_engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgfoote/stream_engine/downloads","issues_url":"https://api.github.com/repos/sgfoote/stream_engine/issues{/number}","pulls_url":"https://api.github.com/repos/sgfoote/stream_engine/pulls{/number}","milestones_url":"https://api.github.com/repos/sgfoote/stream_engine/milestones{/number}","notifications_url":"https://api.github.com/repos/sgfoote/stream_engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgfoote/stream_engine/labels{/name}","releases_url":"https://api.github.com/repos/sgfoote/stream_engine/releases{/id}","deployments_url":"https://api.github.com/repos/sgfoote/stream_engine/deployments","created_at":"2017-09-08T17:07:01Z","updated_at":"2019-04-18T15:11:58Z","pushed_at":"2019-04-18T15:11:56Z","git_url":"git://github.com/sgfoote/stream_engine.git","ssh_url":"[email protected]:sgfoote/stream_engine.git","clone_url":"https://github.com/sgfoote/stream_engine.git","svn_url":"https://github.com/sgfoote/stream_engine","homepage":"https://ooinet.oceanobservatories.org/","size":13628,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oceanobservatories:master","ref":"master","sha":"16c6be615f05ac2f7101e52837f8fd1d22b09364","user":{"login":"oceanobservatories","id":8750280,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3NTAyODA=","avatar_url":"https://avatars0.githubusercontent.com/u/8750280?v=4","gravatar_id":"","url":"https://api.github.com/users/oceanobservatories","html_url":"https://github.com/oceanobservatories","followers_url":"https://api.github.com/users/oceanobservatories/followers","following_url":"https://api.github.com/users/oceanobservatories/following{/other_user}","gists_url":"https://api.github.com/users/oceanobservatories/gists{/gist_id}","starred_url":"https://api.github.com/users/oceanobservatories/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oceanobservatories/subscriptions","organizations_url":"https://api.github.com/users/oceanobservatories/orgs","repos_url":"https://api.github.com/users/oceanobservatories/repos","events_url":"https://api.github.com/users/oceanobservatories/events{/privacy}","received_events_url":"https://api.github.com/users/oceanobservatories/received_events","type":"Organization","site_admin":false},"repo":{"id":31618559,"node_id":"MDEwOlJlcG9zaXRvcnkzMTYxODU1OQ==","name":"stream_engine","full_name":"oceanobservatories/stream_engine","private":false,"owner":{"login":"oceanobservatories","id":8750280,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3NTAyODA=","avatar_url":"https://avatars0.githubusercontent.com/u/8750280?v=4","gravatar_id":"","url":"https://api.github.com/users/oceanobservatories","html_url":"https://github.com/oceanobservatories","followers_url":"https://api.github.com/users/oceanobservatories/followers","following_url":"https://api.github.com/users/oceanobservatories/following{/other_user}","gists_url":"https://api.github.com/users/oceanobservatories/gists{/gist_id}","starred_url":"https://api.github.com/users/oceanobservatories/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oceanobservatories/subscriptions","organizations_url":"https://api.github.com/users/oceanobservatories/orgs","repos_url":"https://api.github.com/users/oceanobservatories/repos","events_url":"https://api.github.com/users/oceanobservatories/events{/privacy}","received_events_url":"https://api.github.com/users/oceanobservatories/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/oceanobservatories/stream_engine","description":null,"fork":false,"url":"https://api.github.com/repos/oceanobservatories/stream_engine","forks_url":"https://api.github.com/repos/oceanobservatories/stream_engine/forks","keys_url":"https://api.github.com/repos/oceanobservatories/stream_engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oceanobservatories/stream_engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oceanobservatories/stream_engine/teams","hooks_url":"https://api.github.com/repos/oceanobservatories/stream_engine/hooks","issue_events_url":"https://api.github.com/repos/oceanobservatories/stream_engine/issues/events{/number}","events_url":"https://api.github.com/repos/oceanobservatories/stream_engine/events","assignees_url":"https://api.github.com/repos/oceanobservatories/stream_engine/assignees{/user}","branches_url":"https://api.github.com/repos/oceanobservatories/stream_engine/branches{/branch}","tags_url":"https://api.github.com/repos/oceanobservatories/stream_engine/tags","blobs_url":"https://api.github.com/repos/oceanobservatories/stream_engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oceanobservatories/stream_engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oceanobservatories/stream_engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/oceanobservatories/stream_engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oceanobservatories/stream_engine/statuses/{sha}","languages_url":"https://api.github.com/repos/oceanobservatories/stream_engine/languages","stargazers_url":"https://api.github.com/repos/oceanobservatories/stream_engine/stargazers","contributors_url":"https://api.github.com/repos/oceanobservatories/stream_engine/contributors","subscribers_url":"https://api.github.com/repos/oceanobservatories/stream_engine/subscribers","subscription_url":"https://api.github.com/repos/oceanobservatories/stream_engine/subscription","commits_url":"https://api.github.com/repos/oceanobservatories/stream_engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/oceanobservatories/stream_engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/oceanobservatories/stream_engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/oceanobservatories/stream_engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/oceanobservatories/stream_engine/contents/{+path}","compare_url":"https://api.github.com/repos/oceanobservatories/stream_engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oceanobservatories/stream_engine/merges","archive_url":"https://api.github.com/repos/oceanobservatories/stream_engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oceanobservatories/stream_engine/downloads","issues_url":"https://api.github.com/repos/oceanobservatories/stream_engine/issues{/number}","pulls_url":"https://api.github.com/repos/oceanobservatories/stream_engine/pulls{/number}","milestones_url":"https://api.github.com/repos/oceanobservatories/stream_engine/milestones{/number}","notifications_url":"https://api.github.com/repos/oceanobservatories/stream_engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oceanobservatories/stream_engine/labels{/name}","releases_url":"https://api.github.com/repos/oceanobservatories/stream_engine/releases{/id}","deployments_url":"https://api.github.com/repos/oceanobservatories/stream_engine/deployments","created_at":"2015-03-03T20:04:39Z","updated_at":"2019-01-09T21:26:51Z","pushed_at":"2019-04-18T15:15:15Z","git_url":"git://github.com/oceanobservatories/stream_engine.git","ssh_url":"[email protected]:oceanobservatories/stream_engine.git","clone_url":"https://github.com/oceanobservatories/stream_engine.git","svn_url":"https://github.com/oceanobservatories/stream_engine","homepage":"https://ooinet.oceanobservatories.org/","size":14726,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":5,"license":null,"forks":14,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oceanobservatories/stream_engine/pulls/68"},"html":{"href":"https://github.com/oceanobservatories/stream_engine/pull/68"},"issue":{"href":"https://api.github.com/repos/oceanobservatories/stream_engine/issues/68"},"comments":{"href":"https://api.github.com/repos/oceanobservatories/stream_engine/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/oceanobservatories/stream_engine/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/oceanobservatories/stream_engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oceanobservatories/stream_engine/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/oceanobservatories/stream_engine/statuses/bd9d60841eb512d04dc3c6e32e73d37b6883b1dd"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 31618559,
"name": "oceanobservatories/stream_engine",
"url": "https://api.github.com/repos/oceanobservatories/stream_engine"
}
|
{
"id": 6914984,
"login": "danmergens",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6914984?",
"url": "https://api.github.com/users/danmergens"
}
|
{
"id": 8750280,
"login": "oceanobservatories",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8750280?",
"url": "https://api.github.com/orgs/oceanobservatories"
}
| 2019-04-18T16:32:36 |
9470849482
|
{"actor":{"display_login":"danmergens"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pulls/comments/278845001","pull_request_review_id":231025952,"id":278845001,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3ODg0NTAwMQ==","diff_hunk":"@@ -2,7 +2,7 @@\n \n {% block content %}\n \n- <section class=\"d-none d-sm-block\">\n+ <section class=\"d-none d-sm-block\" xmlns=\"http://www.w3.org/1999/html\">","path":"src/View/Home/index.html.twig","position":5,"original_position":5,"commit_id":"2045171fd8dc8cc9cf9f480c85335fc7ec413588","original_commit_id":"2045171fd8dc8cc9cf9f480c85335fc7ec413588","user":{"login":"sblondeau","id":6573541,"node_id":"MDQ6VXNlcjY1NzM1NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/6573541?v=4","gravatar_id":"","url":"https://api.github.com/users/sblondeau","html_url":"https://github.com/sblondeau","followers_url":"https://api.github.com/users/sblondeau/followers","following_url":"https://api.github.com/users/sblondeau/following{/other_user}","gists_url":"https://api.github.com/users/sblondeau/gists{/gist_id}","starred_url":"https://api.github.com/users/sblondeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sblondeau/subscriptions","organizations_url":"https://api.github.com/users/sblondeau/orgs","repos_url":"https://api.github.com/users/sblondeau/repos","events_url":"https://api.github.com/users/sblondeau/events{/privacy}","received_events_url":"https://api.github.com/users/sblondeau/received_events","type":"User","site_admin":false},"body":"???","created_at":"2019-04-26T08:04:12Z","updated_at":"2019-04-26T08:06:36Z","html_url":"https://github.com/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pull/87#discussion_r278845001","pull_request_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pulls/87","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pulls/comments/278845001"},"html":{"href":"https://github.com/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pull/87#discussion_r278845001"},"pull_request":{"href":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pulls/87","id":273796088,"node_id":"MDExOlB1bGxSZXF1ZXN0MjczNzk2MDg4","html_url":"https://github.com/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pull/87","diff_url":"https://github.com/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pull/87.diff","patch_url":"https://github.com/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pull/87.patch","issue_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/issues/87","number":87,"state":"open","locked":false,"title":"Sprint02 us7 fonctionnementdepotvente","user":{"login":"foforato","id":47902396,"node_id":"MDQ6VXNlcjQ3OTAyMzk2","avatar_url":"https://avatars2.githubusercontent.com/u/47902396?v=4","gravatar_id":"","url":"https://api.github.com/users/foforato","html_url":"https://github.com/foforato","followers_url":"https://api.github.com/users/foforato/followers","following_url":"https://api.github.com/users/foforato/following{/other_user}","gists_url":"https://api.github.com/users/foforato/gists{/gist_id}","starred_url":"https://api.github.com/users/foforato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foforato/subscriptions","organizations_url":"https://api.github.com/users/foforato/orgs","repos_url":"https://api.github.com/users/foforato/repos","events_url":"https://api.github.com/users/foforato/events{/privacy}","received_events_url":"https://api.github.com/users/foforato/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-04-26T07:50:21Z","updated_at":"2019-04-26T08:06:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c19e6ba56e76cb4bd4b22228dd4a0d8619818a45","assignee":{"login":"foforato","id":47902396,"node_id":"MDQ6VXNlcjQ3OTAyMzk2","avatar_url":"https://avatars2.githubusercontent.com/u/47902396?v=4","gravatar_id":"","url":"https://api.github.com/users/foforato","html_url":"https://github.com/foforato","followers_url":"https://api.github.com/users/foforato/followers","following_url":"https://api.github.com/users/foforato/following{/other_user}","gists_url":"https://api.github.com/users/foforato/gists{/gist_id}","starred_url":"https://api.github.com/users/foforato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foforato/subscriptions","organizations_url":"https://api.github.com/users/foforato/orgs","repos_url":"https://api.github.com/users/foforato/repos","events_url":"https://api.github.com/users/foforato/events{/privacy}","received_events_url":"https://api.github.com/users/foforato/received_events","type":"User","site_admin":false},"assignees":[{"login":"foforato","id":47902396,"node_id":"MDQ6VXNlcjQ3OTAyMzk2","avatar_url":"https://avatars2.githubusercontent.com/u/47902396?v=4","gravatar_id":"","url":"https://api.github.com/users/foforato","html_url":"https://github.com/foforato","followers_url":"https://api.github.com/users/foforato/followers","following_url":"https://api.github.com/users/foforato/following{/other_user}","gists_url":"https://api.github.com/users/foforato/gists{/gist_id}","starred_url":"https://api.github.com/users/foforato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foforato/subscriptions","organizations_url":"https://api.github.com/users/foforato/orgs","repos_url":"https://api.github.com/users/foforato/repos","events_url":"https://api.github.com/users/foforato/events{/privacy}","received_events_url":"https://api.github.com/users/foforato/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1312847889,"node_id":"MDU6TGFiZWwxMzEyODQ3ODg5","url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/labels/Reviewed%20by%20PO","name":"Reviewed by PO","color":"0008ff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pulls/87/commits","review_comments_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pulls/87/comments","review_comment_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/issues/87/comments","statuses_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/statuses/2045171fd8dc8cc9cf9f480c85335fc7ec413588","head":{"label":"WildCodeSchool:Sprint02_US7_Fonctionnementdepotvente","ref":"Sprint02_US7_Fonctionnementdepotvente","sha":"2045171fd8dc8cc9cf9f480c85335fc7ec413588","user":{"login":"WildCodeSchool","id":8874047,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NzQwNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/8874047?v=4","gravatar_id":"","url":"https://api.github.com/users/WildCodeSchool","html_url":"https://github.com/WildCodeSchool","followers_url":"https://api.github.com/users/WildCodeSchool/followers","following_url":"https://api.github.com/users/WildCodeSchool/following{/other_user}","gists_url":"https://api.github.com/users/WildCodeSchool/gists{/gist_id}","starred_url":"https://api.github.com/users/WildCodeSchool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WildCodeSchool/subscriptions","organizations_url":"https://api.github.com/users/WildCodeSchool/orgs","repos_url":"https://api.github.com/users/WildCodeSchool/repos","events_url":"https://api.github.com/users/WildCodeSchool/events{/privacy}","received_events_url":"https://api.github.com/users/WildCodeSchool/received_events","type":"Organization","site_admin":false},"repo":{"id":180362247,"node_id":"MDEwOlJlcG9zaXRvcnkxODAzNjIyNDc=","name":"orleans-0219-php-depot-vente-bannier","full_name":"WildCodeSchool/orleans-0219-php-depot-vente-bannier","private":false,"owner":{"login":"WildCodeSchool","id":8874047,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NzQwNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/8874047?v=4","gravatar_id":"","url":"https://api.github.com/users/WildCodeSchool","html_url":"https://github.com/WildCodeSchool","followers_url":"https://api.github.com/users/WildCodeSchool/followers","following_url":"https://api.github.com/users/WildCodeSchool/following{/other_user}","gists_url":"https://api.github.com/users/WildCodeSchool/gists{/gist_id}","starred_url":"https://api.github.com/users/WildCodeSchool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WildCodeSchool/subscriptions","organizations_url":"https://api.github.com/users/WildCodeSchool/orgs","repos_url":"https://api.github.com/users/WildCodeSchool/repos","events_url":"https://api.github.com/users/WildCodeSchool/events{/privacy}","received_events_url":"https://api.github.com/users/WildCodeSchool/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WildCodeSchool/orleans-0219-php-depot-vente-bannier","description":null,"fork":false,"url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier","forks_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/forks","keys_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/teams","hooks_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/hooks","issue_events_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/issues/events{/number}","events_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/events","assignees_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/assignees{/user}","branches_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/branches{/branch}","tags_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/tags","blobs_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/git/refs{/sha}","trees_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/statuses/{sha}","languages_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/languages","stargazers_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/stargazers","contributors_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/contributors","subscribers_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/subscribers","subscription_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/subscription","commits_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/commits{/sha}","git_commits_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/git/commits{/sha}","comments_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/comments{/number}","issue_comment_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/issues/comments{/number}","contents_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/contents/{+path}","compare_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/merges","archive_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/downloads","issues_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/issues{/number}","pulls_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pulls{/number}","milestones_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/milestones{/number}","notifications_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/labels{/name}","releases_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/releases{/id}","deployments_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/deployments","created_at":"2019-04-09T12:30:55Z","updated_at":"2019-04-10T07:42:54Z","pushed_at":"2019-04-26T07:53:36Z","git_url":"git://github.com/WildCodeSchool/orleans-0219-php-depot-vente-bannier.git","ssh_url":"[email protected]:WildCodeSchool/orleans-0219-php-depot-vente-bannier.git","clone_url":"https://github.com/WildCodeSchool/orleans-0219-php-depot-vente-bannier.git","svn_url":"https://github.com/WildCodeSchool/orleans-0219-php-depot-vente-bannier","homepage":null,"size":1096,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":62,"license":null,"forks":0,"open_issues":62,"watchers":0,"default_branch":"master"}},"base":{"label":"WildCodeSchool:dev","ref":"dev","sha":"01883b7ae869933c6e5e1f34d099ac4ccc80e3e4","user":{"login":"WildCodeSchool","id":8874047,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NzQwNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/8874047?v=4","gravatar_id":"","url":"https://api.github.com/users/WildCodeSchool","html_url":"https://github.com/WildCodeSchool","followers_url":"https://api.github.com/users/WildCodeSchool/followers","following_url":"https://api.github.com/users/WildCodeSchool/following{/other_user}","gists_url":"https://api.github.com/users/WildCodeSchool/gists{/gist_id}","starred_url":"https://api.github.com/users/WildCodeSchool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WildCodeSchool/subscriptions","organizations_url":"https://api.github.com/users/WildCodeSchool/orgs","repos_url":"https://api.github.com/users/WildCodeSchool/repos","events_url":"https://api.github.com/users/WildCodeSchool/events{/privacy}","received_events_url":"https://api.github.com/users/WildCodeSchool/received_events","type":"Organization","site_admin":false},"repo":{"id":180362247,"node_id":"MDEwOlJlcG9zaXRvcnkxODAzNjIyNDc=","name":"orleans-0219-php-depot-vente-bannier","full_name":"WildCodeSchool/orleans-0219-php-depot-vente-bannier","private":false,"owner":{"login":"WildCodeSchool","id":8874047,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NzQwNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/8874047?v=4","gravatar_id":"","url":"https://api.github.com/users/WildCodeSchool","html_url":"https://github.com/WildCodeSchool","followers_url":"https://api.github.com/users/WildCodeSchool/followers","following_url":"https://api.github.com/users/WildCodeSchool/following{/other_user}","gists_url":"https://api.github.com/users/WildCodeSchool/gists{/gist_id}","starred_url":"https://api.github.com/users/WildCodeSchool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WildCodeSchool/subscriptions","organizations_url":"https://api.github.com/users/WildCodeSchool/orgs","repos_url":"https://api.github.com/users/WildCodeSchool/repos","events_url":"https://api.github.com/users/WildCodeSchool/events{/privacy}","received_events_url":"https://api.github.com/users/WildCodeSchool/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/WildCodeSchool/orleans-0219-php-depot-vente-bannier","description":null,"fork":false,"url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier","forks_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/forks","keys_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/teams","hooks_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/hooks","issue_events_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/issues/events{/number}","events_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/events","assignees_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/assignees{/user}","branches_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/branches{/branch}","tags_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/tags","blobs_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/git/refs{/sha}","trees_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/statuses/{sha}","languages_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/languages","stargazers_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/stargazers","contributors_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/contributors","subscribers_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/subscribers","subscription_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/subscription","commits_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/commits{/sha}","git_commits_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/git/commits{/sha}","comments_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/comments{/number}","issue_comment_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/issues/comments{/number}","contents_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/contents/{+path}","compare_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/merges","archive_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/downloads","issues_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/issues{/number}","pulls_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pulls{/number}","milestones_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/milestones{/number}","notifications_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/labels{/name}","releases_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/releases{/id}","deployments_url":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/deployments","created_at":"2019-04-09T12:30:55Z","updated_at":"2019-04-10T07:42:54Z","pushed_at":"2019-04-26T07:53:36Z","git_url":"git://github.com/WildCodeSchool/orleans-0219-php-depot-vente-bannier.git","ssh_url":"[email protected]:WildCodeSchool/orleans-0219-php-depot-vente-bannier.git","clone_url":"https://github.com/WildCodeSchool/orleans-0219-php-depot-vente-bannier.git","svn_url":"https://github.com/WildCodeSchool/orleans-0219-php-depot-vente-bannier","homepage":null,"size":1096,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":62,"license":null,"forks":0,"open_issues":62,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pulls/87"},"html":{"href":"https://github.com/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pull/87"},"issue":{"href":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/issues/87"},"comments":{"href":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier/statuses/2045171fd8dc8cc9cf9f480c85335fc7ec413588"}},"author_association":"NONE"}}
|
{
"id": 180362247,
"name": "WildCodeSchool/orleans-0219-php-depot-vente-bannier",
"url": "https://api.github.com/repos/WildCodeSchool/orleans-0219-php-depot-vente-bannier"
}
|
{
"id": 6573541,
"login": "sblondeau",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6573541?",
"url": "https://api.github.com/users/sblondeau"
}
|
{
"id": 8874047,
"login": "WildCodeSchool",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8874047?",
"url": "https://api.github.com/orgs/WildCodeSchool"
}
| 2019-04-26T08:04:12 |
9516152098
|
{"actor":{"display_login":"sblondeau"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-crypto/pulls/comments/341276837","pull_request_review_id":310063684,"id":341276837,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MTI3NjgzNw==","diff_hunk":"@@ -180,6 +181,20 @@ int mbedtls_asn1_get_int( unsigned char **p,\n return( 0 );\n }\n \n+int mbedtls_asn1_get_int( unsigned char **p,\n+ const unsigned char *end,\n+ int *val )\n+{\n+ return asn1_get_tagged_int (p, end, MBEDTLS_ASN1_INTEGER, val);","path":"library/asn1parse.c","position":null,"original_position":32,"commit_id":"6af7bf91f20ac487c93991933862b83a86aa9766","original_commit_id":"acab185063ce2b711ca871e13f727132cd927c39","user":{"login":"msopiha-linaro","id":53080625,"node_id":"MDQ6VXNlcjUzMDgwNjI1","avatar_url":"https://avatars0.githubusercontent.com/u/53080625?v=4","gravatar_id":"","url":"https://api.github.com/users/msopiha-linaro","html_url":"https://github.com/msopiha-linaro","followers_url":"https://api.github.com/users/msopiha-linaro/followers","following_url":"https://api.github.com/users/msopiha-linaro/following{/other_user}","gists_url":"https://api.github.com/users/msopiha-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/msopiha-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msopiha-linaro/subscriptions","organizations_url":"https://api.github.com/users/msopiha-linaro/orgs","repos_url":"https://api.github.com/users/msopiha-linaro/repos","events_url":"https://api.github.com/users/msopiha-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/msopiha-linaro/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2019-10-31T17:38:44Z","updated_at":"2019-10-31T17:38:44Z","html_url":"https://github.com/ARMmbed/mbed-crypto/pull/307#discussion_r341276837","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/pulls/307","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-crypto/pulls/comments/341276837"},"html":{"href":"https://github.com/ARMmbed/mbed-crypto/pull/307#discussion_r341276837"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-crypto/pulls/307"}},"in_reply_to_id":341244445},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-crypto/pulls/307","id":333655773,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMzNjU1Nzcz","html_url":"https://github.com/ARMmbed/mbed-crypto/pull/307","diff_url":"https://github.com/ARMmbed/mbed-crypto/pull/307.diff","patch_url":"https://github.com/ARMmbed/mbed-crypto/pull/307.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/issues/307","number":307,"state":"open","locked":false,"title":"Add ASN.1 ENUMERATED tag support","user":{"login":"msopiha-linaro","id":53080625,"node_id":"MDQ6VXNlcjUzMDgwNjI1","avatar_url":"https://avatars0.githubusercontent.com/u/53080625?v=4","gravatar_id":"","url":"https://api.github.com/users/msopiha-linaro","html_url":"https://github.com/msopiha-linaro","followers_url":"https://api.github.com/users/msopiha-linaro/followers","following_url":"https://api.github.com/users/msopiha-linaro/following{/other_user}","gists_url":"https://api.github.com/users/msopiha-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/msopiha-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msopiha-linaro/subscriptions","organizations_url":"https://api.github.com/users/msopiha-linaro/orgs","repos_url":"https://api.github.com/users/msopiha-linaro/repos","events_url":"https://api.github.com/users/msopiha-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/msopiha-linaro/received_events","type":"User","site_admin":false},"body":"Add support for ASN.1 ENUMERATED tag.\r\n","created_at":"2019-10-29T14:34:20Z","updated_at":"2019-10-31T17:38:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4db60bc5df6a2122d136a328d04c6d4e337e8fe4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":971143150,"node_id":"MDU6TGFiZWw5NzExNDMxNTA=","url":"https://api.github.com/repos/ARMmbed/mbed-crypto/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":1165346315,"node_id":"MDU6TGFiZWwxMTY1MzQ2MzE1","url":"https://api.github.com/repos/ARMmbed/mbed-crypto/labels/needs:%20work","name":"needs: work","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/pulls/307/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/pulls/307/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/issues/307/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/statuses/6af7bf91f20ac487c93991933862b83a86aa9766","head":{"label":"msopiha-linaro:development","ref":"development","sha":"6af7bf91f20ac487c93991933862b83a86aa9766","user":{"login":"msopiha-linaro","id":53080625,"node_id":"MDQ6VXNlcjUzMDgwNjI1","avatar_url":"https://avatars0.githubusercontent.com/u/53080625?v=4","gravatar_id":"","url":"https://api.github.com/users/msopiha-linaro","html_url":"https://github.com/msopiha-linaro","followers_url":"https://api.github.com/users/msopiha-linaro/followers","following_url":"https://api.github.com/users/msopiha-linaro/following{/other_user}","gists_url":"https://api.github.com/users/msopiha-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/msopiha-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msopiha-linaro/subscriptions","organizations_url":"https://api.github.com/users/msopiha-linaro/orgs","repos_url":"https://api.github.com/users/msopiha-linaro/repos","events_url":"https://api.github.com/users/msopiha-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/msopiha-linaro/received_events","type":"User","site_admin":false},"repo":{"id":218298133,"node_id":"MDEwOlJlcG9zaXRvcnkyMTgyOTgxMzM=","name":"mbed-crypto","full_name":"msopiha-linaro/mbed-crypto","private":false,"owner":{"login":"msopiha-linaro","id":53080625,"node_id":"MDQ6VXNlcjUzMDgwNjI1","avatar_url":"https://avatars0.githubusercontent.com/u/53080625?v=4","gravatar_id":"","url":"https://api.github.com/users/msopiha-linaro","html_url":"https://github.com/msopiha-linaro","followers_url":"https://api.github.com/users/msopiha-linaro/followers","following_url":"https://api.github.com/users/msopiha-linaro/following{/other_user}","gists_url":"https://api.github.com/users/msopiha-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/msopiha-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msopiha-linaro/subscriptions","organizations_url":"https://api.github.com/users/msopiha-linaro/orgs","repos_url":"https://api.github.com/users/msopiha-linaro/repos","events_url":"https://api.github.com/users/msopiha-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/msopiha-linaro/received_events","type":"User","site_admin":false},"html_url":"https://github.com/msopiha-linaro/mbed-crypto","description":"Mbed Crypto is a reference implementation of the Arm PSA Crypto API","fork":true,"url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto","forks_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/forks","keys_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/teams","hooks_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/hooks","issue_events_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/issues/events{/number}","events_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/events","assignees_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/assignees{/user}","branches_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/branches{/branch}","tags_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/tags","blobs_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/git/refs{/sha}","trees_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/statuses/{sha}","languages_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/languages","stargazers_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/stargazers","contributors_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/contributors","subscribers_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/subscribers","subscription_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/subscription","commits_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/commits{/sha}","git_commits_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/git/commits{/sha}","comments_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/comments{/number}","issue_comment_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/issues/comments{/number}","contents_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/contents/{+path}","compare_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/merges","archive_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/downloads","issues_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/issues{/number}","pulls_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/pulls{/number}","milestones_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/milestones{/number}","notifications_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/labels{/name}","releases_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/releases{/id}","deployments_url":"https://api.github.com/repos/msopiha-linaro/mbed-crypto/deployments","created_at":"2019-10-29T13:48:57Z","updated_at":"2019-10-31T17:17:58Z","pushed_at":"2019-10-31T17:17:56Z","git_url":"git://github.com/msopiha-linaro/mbed-crypto.git","ssh_url":"[email protected]:msopiha-linaro/mbed-crypto.git","clone_url":"https://github.com/msopiha-linaro/mbed-crypto.git","svn_url":"https://github.com/msopiha-linaro/mbed-crypto","homepage":"","size":22718,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"ARMmbed:development","ref":"development","sha":"08c674dfe3e57932fe21e3feb3aebed680759c37","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":138151558,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxNTE1NTg=","name":"mbed-crypto","full_name":"ARMmbed/mbed-crypto","private":false,"owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARMmbed/mbed-crypto","description":"Mbed Crypto is a reference implementation of the Arm PSA Crypto API","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-crypto","forks_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-crypto/deployments","created_at":"2018-06-21T09:48:28Z","updated_at":"2019-10-31T16:03:32Z","pushed_at":"2019-10-31T17:17:57Z","git_url":"git://github.com/ARMmbed/mbed-crypto.git","ssh_url":"[email protected]:ARMmbed/mbed-crypto.git","clone_url":"https://github.com/ARMmbed/mbed-crypto.git","svn_url":"https://github.com/ARMmbed/mbed-crypto","homepage":"","size":22725,"stargazers_count":57,"watchers_count":57,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":50,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":79,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":50,"open_issues":79,"watchers":57,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-crypto/pulls/307"},"html":{"href":"https://github.com/ARMmbed/mbed-crypto/pull/307"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-crypto/issues/307"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-crypto/issues/307/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-crypto/pulls/307/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-crypto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-crypto/pulls/307/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-crypto/statuses/6af7bf91f20ac487c93991933862b83a86aa9766"}},"author_association":"NONE"}}
|
{
"id": 138151558,
"name": "ARMmbed/mbed-crypto",
"url": "https://api.github.com/repos/ARMmbed/mbed-crypto"
}
|
{
"id": 53080625,
"login": "msopiha-linaro",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/53080625?",
"url": "https://api.github.com/users/msopiha-linaro"
}
|
{
"id": 8916057,
"login": "ARMmbed",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8916057?",
"url": "https://api.github.com/orgs/ARMmbed"
}
| 2019-10-31T17:38:44 |
10759969316
|
{"actor":{"display_login":"msopiha-linaro"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/esp8266/Arduino/pulls/comments/361712576","pull_request_review_id":336831029,"id":361712576,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2MTcxMjU3Ng==","diff_hunk":"@@ -112,7 +112,7 @@ class Twi\n bool _slaveEnabled = false;\n \n // Internal use functions\n- void ICACHE_RAM_ATTR busywait(unsigned char v);\n+ void ICACHE_RAM_ATTR busywait(unsigned int v);","path":"cores/esp8266/core_esp8266_si2c.cpp","position":36,"original_position":36,"commit_id":"14aed48dee2fa2d68ba9e6b1fb10e66dd4025c54","original_commit_id":"14aed48dee2fa2d68ba9e6b1fb10e66dd4025c54","user":{"login":"Tech-TX","id":53401742,"node_id":"MDQ6VXNlcjUzNDAxNzQy","avatar_url":"https://avatars1.githubusercontent.com/u/53401742?v=4","gravatar_id":"","url":"https://api.github.com/users/Tech-TX","html_url":"https://github.com/Tech-TX","followers_url":"https://api.github.com/users/Tech-TX/followers","following_url":"https://api.github.com/users/Tech-TX/following{/other_user}","gists_url":"https://api.github.com/users/Tech-TX/gists{/gist_id}","starred_url":"https://api.github.com/users/Tech-TX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tech-TX/subscriptions","organizations_url":"https://api.github.com/users/Tech-TX/orgs","repos_url":"https://api.github.com/users/Tech-TX/repos","events_url":"https://api.github.com/users/Tech-TX/events{/privacy}","received_events_url":"https://api.github.com/users/Tech-TX/received_events","type":"User","site_admin":false},"body":"busywait() is a private function, so it shouldn't change the signature ","created_at":"2019-12-27T17:40:49Z","updated_at":"2019-12-27T17:40:49Z","html_url":"https://github.com/esp8266/Arduino/pull/6934#discussion_r361712576","pull_request_url":"https://api.github.com/repos/esp8266/Arduino/pulls/6934","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/comments/361712576"},"html":{"href":"https://github.com/esp8266/Arduino/pull/6934#discussion_r361712576"},"pull_request":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/6934"}},"in_reply_to_id":361590637},"pull_request":{"url":"https://api.github.com/repos/esp8266/Arduino/pulls/6934","id":356044524,"node_id":"MDExOlB1bGxSZXF1ZXN0MzU2MDQ0NTI0","html_url":"https://github.com/esp8266/Arduino/pull/6934","diff_url":"https://github.com/esp8266/Arduino/pull/6934.diff","patch_url":"https://github.com/esp8266/Arduino/pull/6934.patch","issue_url":"https://api.github.com/repos/esp8266/Arduino/issues/6934","number":6934,"state":"open","locked":false,"title":"Issue2524 allow clocks below 100KHz","user":{"login":"Tech-TX","id":53401742,"node_id":"MDQ6VXNlcjUzNDAxNzQy","avatar_url":"https://avatars1.githubusercontent.com/u/53401742?v=4","gravatar_id":"","url":"https://api.github.com/users/Tech-TX","html_url":"https://github.com/Tech-TX","followers_url":"https://api.github.com/users/Tech-TX/followers","following_url":"https://api.github.com/users/Tech-TX/following{/other_user}","gists_url":"https://api.github.com/users/Tech-TX/gists{/gist_id}","starred_url":"https://api.github.com/users/Tech-TX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tech-TX/subscriptions","organizations_url":"https://api.github.com/users/Tech-TX/orgs","repos_url":"https://api.github.com/users/Tech-TX/repos","events_url":"https://api.github.com/users/Tech-TX/events{/privacy}","received_events_url":"https://api.github.com/users/Tech-TX/received_events","type":"User","site_admin":false},"body":"Corrects the fixed I2C bus clock selections and allows slower bus clocks down to ridiculously low bus speeds if you need that. Originally prompted by Earle's comment in https://github.com/esp8266/Arduino/issues/2524 about computing the bus clock timing.\r\n\r\nAdditionally, the dead Twi::stop was removed. The compiler was removing it in slave compiles anyways, as it wasn't called by any of the functions except for one oversight in the slave state machine. Slaves can't issue STOP commands. Although the Twi::stop was listed as an exposed function, it wasn't linked from Wire.h, so it was optimized out.","created_at":"2019-12-22T01:13:00Z","updated_at":"2019-12-27T17:40:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4568a6f43489a9b48195f4001671c3faa82a4d43","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/esp8266/Arduino/pulls/6934/commits","review_comments_url":"https://api.github.com/repos/esp8266/Arduino/pulls/6934/comments","review_comment_url":"https://api.github.com/repos/esp8266/Arduino/pulls/comments{/number}","comments_url":"https://api.github.com/repos/esp8266/Arduino/issues/6934/comments","statuses_url":"https://api.github.com/repos/esp8266/Arduino/statuses/14aed48dee2fa2d68ba9e6b1fb10e66dd4025c54","head":{"label":"Tech-TX:issue2524","ref":"issue2524","sha":"14aed48dee2fa2d68ba9e6b1fb10e66dd4025c54","user":{"login":"Tech-TX","id":53401742,"node_id":"MDQ6VXNlcjUzNDAxNzQy","avatar_url":"https://avatars1.githubusercontent.com/u/53401742?v=4","gravatar_id":"","url":"https://api.github.com/users/Tech-TX","html_url":"https://github.com/Tech-TX","followers_url":"https://api.github.com/users/Tech-TX/followers","following_url":"https://api.github.com/users/Tech-TX/following{/other_user}","gists_url":"https://api.github.com/users/Tech-TX/gists{/gist_id}","starred_url":"https://api.github.com/users/Tech-TX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tech-TX/subscriptions","organizations_url":"https://api.github.com/users/Tech-TX/orgs","repos_url":"https://api.github.com/users/Tech-TX/repos","events_url":"https://api.github.com/users/Tech-TX/events{/privacy}","received_events_url":"https://api.github.com/users/Tech-TX/received_events","type":"User","site_admin":false},"repo":{"id":216342939,"node_id":"MDEwOlJlcG9zaXRvcnkyMTYzNDI5Mzk=","name":"Arduino","full_name":"Tech-TX/Arduino","private":false,"owner":{"login":"Tech-TX","id":53401742,"node_id":"MDQ6VXNlcjUzNDAxNzQy","avatar_url":"https://avatars1.githubusercontent.com/u/53401742?v=4","gravatar_id":"","url":"https://api.github.com/users/Tech-TX","html_url":"https://github.com/Tech-TX","followers_url":"https://api.github.com/users/Tech-TX/followers","following_url":"https://api.github.com/users/Tech-TX/following{/other_user}","gists_url":"https://api.github.com/users/Tech-TX/gists{/gist_id}","starred_url":"https://api.github.com/users/Tech-TX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tech-TX/subscriptions","organizations_url":"https://api.github.com/users/Tech-TX/orgs","repos_url":"https://api.github.com/users/Tech-TX/repos","events_url":"https://api.github.com/users/Tech-TX/events{/privacy}","received_events_url":"https://api.github.com/users/Tech-TX/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Tech-TX/Arduino","description":"ESP8266 core for Arduino","fork":true,"url":"https://api.github.com/repos/Tech-TX/Arduino","forks_url":"https://api.github.com/repos/Tech-TX/Arduino/forks","keys_url":"https://api.github.com/repos/Tech-TX/Arduino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tech-TX/Arduino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tech-TX/Arduino/teams","hooks_url":"https://api.github.com/repos/Tech-TX/Arduino/hooks","issue_events_url":"https://api.github.com/repos/Tech-TX/Arduino/issues/events{/number}","events_url":"https://api.github.com/repos/Tech-TX/Arduino/events","assignees_url":"https://api.github.com/repos/Tech-TX/Arduino/assignees{/user}","branches_url":"https://api.github.com/repos/Tech-TX/Arduino/branches{/branch}","tags_url":"https://api.github.com/repos/Tech-TX/Arduino/tags","blobs_url":"https://api.github.com/repos/Tech-TX/Arduino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tech-TX/Arduino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tech-TX/Arduino/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tech-TX/Arduino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tech-TX/Arduino/statuses/{sha}","languages_url":"https://api.github.com/repos/Tech-TX/Arduino/languages","stargazers_url":"https://api.github.com/repos/Tech-TX/Arduino/stargazers","contributors_url":"https://api.github.com/repos/Tech-TX/Arduino/contributors","subscribers_url":"https://api.github.com/repos/Tech-TX/Arduino/subscribers","subscription_url":"https://api.github.com/repos/Tech-TX/Arduino/subscription","commits_url":"https://api.github.com/repos/Tech-TX/Arduino/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tech-TX/Arduino/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tech-TX/Arduino/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tech-TX/Arduino/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tech-TX/Arduino/contents/{+path}","compare_url":"https://api.github.com/repos/Tech-TX/Arduino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tech-TX/Arduino/merges","archive_url":"https://api.github.com/repos/Tech-TX/Arduino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tech-TX/Arduino/downloads","issues_url":"https://api.github.com/repos/Tech-TX/Arduino/issues{/number}","pulls_url":"https://api.github.com/repos/Tech-TX/Arduino/pulls{/number}","milestones_url":"https://api.github.com/repos/Tech-TX/Arduino/milestones{/number}","notifications_url":"https://api.github.com/repos/Tech-TX/Arduino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tech-TX/Arduino/labels{/name}","releases_url":"https://api.github.com/repos/Tech-TX/Arduino/releases{/id}","deployments_url":"https://api.github.com/repos/Tech-TX/Arduino/deployments","created_at":"2019-10-20T10:19:43Z","updated_at":"2019-12-21T02:53:16Z","pushed_at":"2019-12-24T19:51:04Z","git_url":"git://github.com/Tech-TX/Arduino.git","ssh_url":"[email protected]:Tech-TX/Arduino.git","clone_url":"https://github.com/Tech-TX/Arduino.git","svn_url":"https://github.com/Tech-TX/Arduino","homepage":"","size":86277,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"esp8266:master","ref":"master","sha":"6c2ab2508734e88b06e0a7633445998044fd151c","user":{"login":"esp8266","id":8943775,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5NDM3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8943775?v=4","gravatar_id":"","url":"https://api.github.com/users/esp8266","html_url":"https://github.com/esp8266","followers_url":"https://api.github.com/users/esp8266/followers","following_url":"https://api.github.com/users/esp8266/following{/other_user}","gists_url":"https://api.github.com/users/esp8266/gists{/gist_id}","starred_url":"https://api.github.com/users/esp8266/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esp8266/subscriptions","organizations_url":"https://api.github.com/users/esp8266/orgs","repos_url":"https://api.github.com/users/esp8266/repos","events_url":"https://api.github.com/users/esp8266/events{/privacy}","received_events_url":"https://api.github.com/users/esp8266/received_events","type":"Organization","site_admin":false},"repo":{"id":32969220,"node_id":"MDEwOlJlcG9zaXRvcnkzMjk2OTIyMA==","name":"Arduino","full_name":"esp8266/Arduino","private":false,"owner":{"login":"esp8266","id":8943775,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5NDM3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/8943775?v=4","gravatar_id":"","url":"https://api.github.com/users/esp8266","html_url":"https://github.com/esp8266","followers_url":"https://api.github.com/users/esp8266/followers","following_url":"https://api.github.com/users/esp8266/following{/other_user}","gists_url":"https://api.github.com/users/esp8266/gists{/gist_id}","starred_url":"https://api.github.com/users/esp8266/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esp8266/subscriptions","organizations_url":"https://api.github.com/users/esp8266/orgs","repos_url":"https://api.github.com/users/esp8266/repos","events_url":"https://api.github.com/users/esp8266/events{/privacy}","received_events_url":"https://api.github.com/users/esp8266/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/esp8266/Arduino","description":"ESP8266 core for Arduino","fork":false,"url":"https://api.github.com/repos/esp8266/Arduino","forks_url":"https://api.github.com/repos/esp8266/Arduino/forks","keys_url":"https://api.github.com/repos/esp8266/Arduino/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esp8266/Arduino/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esp8266/Arduino/teams","hooks_url":"https://api.github.com/repos/esp8266/Arduino/hooks","issue_events_url":"https://api.github.com/repos/esp8266/Arduino/issues/events{/number}","events_url":"https://api.github.com/repos/esp8266/Arduino/events","assignees_url":"https://api.github.com/repos/esp8266/Arduino/assignees{/user}","branches_url":"https://api.github.com/repos/esp8266/Arduino/branches{/branch}","tags_url":"https://api.github.com/repos/esp8266/Arduino/tags","blobs_url":"https://api.github.com/repos/esp8266/Arduino/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esp8266/Arduino/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esp8266/Arduino/git/refs{/sha}","trees_url":"https://api.github.com/repos/esp8266/Arduino/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esp8266/Arduino/statuses/{sha}","languages_url":"https://api.github.com/repos/esp8266/Arduino/languages","stargazers_url":"https://api.github.com/repos/esp8266/Arduino/stargazers","contributors_url":"https://api.github.com/repos/esp8266/Arduino/contributors","subscribers_url":"https://api.github.com/repos/esp8266/Arduino/subscribers","subscription_url":"https://api.github.com/repos/esp8266/Arduino/subscription","commits_url":"https://api.github.com/repos/esp8266/Arduino/commits{/sha}","git_commits_url":"https://api.github.com/repos/esp8266/Arduino/git/commits{/sha}","comments_url":"https://api.github.com/repos/esp8266/Arduino/comments{/number}","issue_comment_url":"https://api.github.com/repos/esp8266/Arduino/issues/comments{/number}","contents_url":"https://api.github.com/repos/esp8266/Arduino/contents/{+path}","compare_url":"https://api.github.com/repos/esp8266/Arduino/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esp8266/Arduino/merges","archive_url":"https://api.github.com/repos/esp8266/Arduino/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esp8266/Arduino/downloads","issues_url":"https://api.github.com/repos/esp8266/Arduino/issues{/number}","pulls_url":"https://api.github.com/repos/esp8266/Arduino/pulls{/number}","milestones_url":"https://api.github.com/repos/esp8266/Arduino/milestones{/number}","notifications_url":"https://api.github.com/repos/esp8266/Arduino/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esp8266/Arduino/labels{/name}","releases_url":"https://api.github.com/repos/esp8266/Arduino/releases{/id}","deployments_url":"https://api.github.com/repos/esp8266/Arduino/deployments","created_at":"2015-03-27T05:22:06Z","updated_at":"2019-12-27T16:02:48Z","pushed_at":"2019-12-27T15:53:51Z","git_url":"git://github.com/esp8266/Arduino.git","ssh_url":"[email protected]:esp8266/Arduino.git","clone_url":"https://github.com/esp8266/Arduino.git","svn_url":"https://github.com/esp8266/Arduino","homepage":"","size":85915,"stargazers_count":10550,"watchers_count":10550,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8605,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":349,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":8605,"open_issues":349,"watchers":10550,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/6934"},"html":{"href":"https://github.com/esp8266/Arduino/pull/6934"},"issue":{"href":"https://api.github.com/repos/esp8266/Arduino/issues/6934"},"comments":{"href":"https://api.github.com/repos/esp8266/Arduino/issues/6934/comments"},"review_comments":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/6934/comments"},"review_comment":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/esp8266/Arduino/pulls/6934/commits"},"statuses":{"href":"https://api.github.com/repos/esp8266/Arduino/statuses/14aed48dee2fa2d68ba9e6b1fb10e66dd4025c54"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 32969220,
"name": "esp8266/Arduino",
"url": "https://api.github.com/repos/esp8266/Arduino"
}
|
{
"id": 53401742,
"login": "Tech-TX",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/53401742?",
"url": "https://api.github.com/users/Tech-TX"
}
|
{
"id": 8943775,
"login": "esp8266",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8943775?",
"url": "https://api.github.com/orgs/esp8266"
}
| 2019-12-27T17:40:49 |
11167564095
|
{"actor":{"display_login":"Tech-TX"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/DynamoRIO/dynamorio/pulls/comments/286651594","pull_request_review_id":240834415,"id":286651594,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI4NjY1MTU5NA==","diff_hunk":"@@ -6785,6 +6785,10 @@ const instr_info_t evex_W_extensions[][2] = {\n {OP_vpxord, 0x660fef10, \"vpxord\", Ve, xx, KEw, He, We, mrm|evex, x, END_LIST},\n {OP_vpxorq, 0x660fef50, \"vpxorq\", Ve, xx, KEb, He, We, mrm|evex, x, END_LIST},\n },\n+ { /* evex_W_ext 45 */\n+ {OP_vpmulld, 0x66384018, \"vpmulld\", Ve, xx, KEw,He,We, mrm|evex|reqp, x, END_LIST},\n+ {OP_vpmullq, 0x66384058, \"vpmullq\", Ve, xx, KEb,He,We, mrm|evex|reqp, x, END_LIST},","path":"core/arch/x86/decode_table.c","position":130,"original_position":130,"commit_id":"d6cbf53401c9b0b41ec85b0cfd295960c355c033","original_commit_id":"d6cbf53401c9b0b41ec85b0cfd295960c355c033","user":{"login":"hgreving2304","id":43382901,"node_id":"MDQ6VXNlcjQzMzgyOTAx","avatar_url":"https://avatars3.githubusercontent.com/u/43382901?v=4","gravatar_id":"","url":"https://api.github.com/users/hgreving2304","html_url":"https://github.com/hgreving2304","followers_url":"https://api.github.com/users/hgreving2304/followers","following_url":"https://api.github.com/users/hgreving2304/following{/other_user}","gists_url":"https://api.github.com/users/hgreving2304/gists{/gist_id}","starred_url":"https://api.github.com/users/hgreving2304/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgreving2304/subscriptions","organizations_url":"https://api.github.com/users/hgreving2304/orgs","repos_url":"https://api.github.com/users/hgreving2304/repos","events_url":"https://api.github.com/users/hgreving2304/events{/privacy}","received_events_url":"https://api.github.com/users/hgreving2304/received_events","type":"User","site_admin":false},"body":"This is the only thing I know of. But I haven't tested the broadcast or rounding bits yet.","created_at":"2019-05-22T19:33:55Z","updated_at":"2019-05-22T19:33:55Z","html_url":"https://github.com/DynamoRIO/dynamorio/pull/3634#discussion_r286651594","pull_request_url":"https://api.github.com/repos/DynamoRIO/dynamorio/pulls/3634","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DynamoRIO/dynamorio/pulls/comments/286651594"},"html":{"href":"https://github.com/DynamoRIO/dynamorio/pull/3634#discussion_r286651594"},"pull_request":{"href":"https://api.github.com/repos/DynamoRIO/dynamorio/pulls/3634"}},"in_reply_to_id":286632085},"pull_request":{"url":"https://api.github.com/repos/DynamoRIO/dynamorio/pulls/3634","id":281292333,"node_id":"MDExOlB1bGxSZXF1ZXN0MjgxMjkyMzMz","html_url":"https://github.com/DynamoRIO/dynamorio/pull/3634","diff_url":"https://github.com/DynamoRIO/dynamorio/pull/3634.diff","patch_url":"https://github.com/DynamoRIO/dynamorio/pull/3634.patch","issue_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/3634","number":3634,"state":"open","locked":false,"title":"i#1312 AVX-512 support: Add evex-encoded v(p)mul* opcodes.","user":{"login":"hgreving2304","id":43382901,"node_id":"MDQ6VXNlcjQzMzgyOTAx","avatar_url":"https://avatars3.githubusercontent.com/u/43382901?v=4","gravatar_id":"","url":"https://api.github.com/users/hgreving2304","html_url":"https://github.com/hgreving2304","followers_url":"https://api.github.com/users/hgreving2304/followers","following_url":"https://api.github.com/users/hgreving2304/following{/other_user}","gists_url":"https://api.github.com/users/hgreving2304/gists{/gist_id}","starred_url":"https://api.github.com/users/hgreving2304/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hgreving2304/subscriptions","organizations_url":"https://api.github.com/users/hgreving2304/orgs","repos_url":"https://api.github.com/users/hgreving2304/repos","events_url":"https://api.github.com/users/hgreving2304/events{/privacy}","received_events_url":"https://api.github.com/users/hgreving2304/received_events","type":"User","site_admin":false},"body":"Adds the opcodes vmulps, vmulpd, vmulss, vmulsd, vpmullw, vpmulld, vpmullq, vpmuldq,\r\nvpmulhw, vpmulhuw, vpmuludq, vpmulhrsw.\r\n\r\nThe opcode vpmullq is new in AVX-512.\r\n\r\nNote that this fixes a bug where the evex rows were missing from prefix extension 25\r\nin the decode tables. The remaining prefix extensions have been inspected and found\r\nto be ok.\r\n\r\nAdds tests for above.\r\n\r\nIssue: #1312","created_at":"2019-05-22T17:32:42Z","updated_at":"2019-05-22T19:33:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9fbe3dabf0d3d53333bb4f845d5113c490adbc0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DynamoRIO/dynamorio/pulls/3634/commits","review_comments_url":"https://api.github.com/repos/DynamoRIO/dynamorio/pulls/3634/comments","review_comment_url":"https://api.github.com/repos/DynamoRIO/dynamorio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/3634/comments","statuses_url":"https://api.github.com/repos/DynamoRIO/dynamorio/statuses/d6cbf53401c9b0b41ec85b0cfd295960c355c033","head":{"label":"DynamoRIO:i1312-add-evex-decoder-incremental-8","ref":"i1312-add-evex-decoder-incremental-8","sha":"d6cbf53401c9b0b41ec85b0cfd295960c355c033","user":{"login":"DynamoRIO","id":9010155,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwMTAxNTU=","avatar_url":"https://avatars2.githubusercontent.com/u/9010155?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoRIO","html_url":"https://github.com/DynamoRIO","followers_url":"https://api.github.com/users/DynamoRIO/followers","following_url":"https://api.github.com/users/DynamoRIO/following{/other_user}","gists_url":"https://api.github.com/users/DynamoRIO/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoRIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoRIO/subscriptions","organizations_url":"https://api.github.com/users/DynamoRIO/orgs","repos_url":"https://api.github.com/users/DynamoRIO/repos","events_url":"https://api.github.com/users/DynamoRIO/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoRIO/received_events","type":"Organization","site_admin":false},"repo":{"id":27242935,"node_id":"MDEwOlJlcG9zaXRvcnkyNzI0MjkzNQ==","name":"dynamorio","full_name":"DynamoRIO/dynamorio","private":false,"owner":{"login":"DynamoRIO","id":9010155,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwMTAxNTU=","avatar_url":"https://avatars2.githubusercontent.com/u/9010155?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoRIO","html_url":"https://github.com/DynamoRIO","followers_url":"https://api.github.com/users/DynamoRIO/followers","following_url":"https://api.github.com/users/DynamoRIO/following{/other_user}","gists_url":"https://api.github.com/users/DynamoRIO/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoRIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoRIO/subscriptions","organizations_url":"https://api.github.com/users/DynamoRIO/orgs","repos_url":"https://api.github.com/users/DynamoRIO/repos","events_url":"https://api.github.com/users/DynamoRIO/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoRIO/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DynamoRIO/dynamorio","description":"Dynamic Instrumentation Tool Platform","fork":false,"url":"https://api.github.com/repos/DynamoRIO/dynamorio","forks_url":"https://api.github.com/repos/DynamoRIO/dynamorio/forks","keys_url":"https://api.github.com/repos/DynamoRIO/dynamorio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoRIO/dynamorio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoRIO/dynamorio/teams","hooks_url":"https://api.github.com/repos/DynamoRIO/dynamorio/hooks","issue_events_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoRIO/dynamorio/events","assignees_url":"https://api.github.com/repos/DynamoRIO/dynamorio/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoRIO/dynamorio/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoRIO/dynamorio/tags","blobs_url":"https://api.github.com/repos/DynamoRIO/dynamorio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoRIO/dynamorio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoRIO/dynamorio/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoRIO/dynamorio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoRIO/dynamorio/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoRIO/dynamorio/languages","stargazers_url":"https://api.github.com/repos/DynamoRIO/dynamorio/stargazers","contributors_url":"https://api.github.com/repos/DynamoRIO/dynamorio/contributors","subscribers_url":"https://api.github.com/repos/DynamoRIO/dynamorio/subscribers","subscription_url":"https://api.github.com/repos/DynamoRIO/dynamorio/subscription","commits_url":"https://api.github.com/repos/DynamoRIO/dynamorio/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoRIO/dynamorio/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoRIO/dynamorio/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoRIO/dynamorio/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoRIO/dynamorio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoRIO/dynamorio/merges","archive_url":"https://api.github.com/repos/DynamoRIO/dynamorio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoRIO/dynamorio/downloads","issues_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoRIO/dynamorio/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoRIO/dynamorio/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoRIO/dynamorio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoRIO/dynamorio/labels{/name}","releases_url":"https://api.github.com/repos/DynamoRIO/dynamorio/releases{/id}","deployments_url":"https://api.github.com/repos/DynamoRIO/dynamorio/deployments","created_at":"2014-11-27T22:08:34Z","updated_at":"2019-05-22T17:58:15Z","pushed_at":"2019-05-22T17:32:43Z","git_url":"git://github.com/DynamoRIO/dynamorio.git","ssh_url":"[email protected]:DynamoRIO/dynamorio.git","clone_url":"https://github.com/DynamoRIO/dynamorio.git","svn_url":"https://github.com/DynamoRIO/dynamorio","homepage":null,"size":54357,"stargazers_count":1001,"watchers_count":1001,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":254,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1155,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":254,"open_issues":1155,"watchers":1001,"default_branch":"master"}},"base":{"label":"DynamoRIO:master","ref":"master","sha":"86a479f873b87e1a8413f98dd1c07f92c3e6c168","user":{"login":"DynamoRIO","id":9010155,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwMTAxNTU=","avatar_url":"https://avatars2.githubusercontent.com/u/9010155?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoRIO","html_url":"https://github.com/DynamoRIO","followers_url":"https://api.github.com/users/DynamoRIO/followers","following_url":"https://api.github.com/users/DynamoRIO/following{/other_user}","gists_url":"https://api.github.com/users/DynamoRIO/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoRIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoRIO/subscriptions","organizations_url":"https://api.github.com/users/DynamoRIO/orgs","repos_url":"https://api.github.com/users/DynamoRIO/repos","events_url":"https://api.github.com/users/DynamoRIO/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoRIO/received_events","type":"Organization","site_admin":false},"repo":{"id":27242935,"node_id":"MDEwOlJlcG9zaXRvcnkyNzI0MjkzNQ==","name":"dynamorio","full_name":"DynamoRIO/dynamorio","private":false,"owner":{"login":"DynamoRIO","id":9010155,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwMTAxNTU=","avatar_url":"https://avatars2.githubusercontent.com/u/9010155?v=4","gravatar_id":"","url":"https://api.github.com/users/DynamoRIO","html_url":"https://github.com/DynamoRIO","followers_url":"https://api.github.com/users/DynamoRIO/followers","following_url":"https://api.github.com/users/DynamoRIO/following{/other_user}","gists_url":"https://api.github.com/users/DynamoRIO/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoRIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoRIO/subscriptions","organizations_url":"https://api.github.com/users/DynamoRIO/orgs","repos_url":"https://api.github.com/users/DynamoRIO/repos","events_url":"https://api.github.com/users/DynamoRIO/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoRIO/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DynamoRIO/dynamorio","description":"Dynamic Instrumentation Tool Platform","fork":false,"url":"https://api.github.com/repos/DynamoRIO/dynamorio","forks_url":"https://api.github.com/repos/DynamoRIO/dynamorio/forks","keys_url":"https://api.github.com/repos/DynamoRIO/dynamorio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoRIO/dynamorio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoRIO/dynamorio/teams","hooks_url":"https://api.github.com/repos/DynamoRIO/dynamorio/hooks","issue_events_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoRIO/dynamorio/events","assignees_url":"https://api.github.com/repos/DynamoRIO/dynamorio/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoRIO/dynamorio/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoRIO/dynamorio/tags","blobs_url":"https://api.github.com/repos/DynamoRIO/dynamorio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoRIO/dynamorio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoRIO/dynamorio/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoRIO/dynamorio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoRIO/dynamorio/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoRIO/dynamorio/languages","stargazers_url":"https://api.github.com/repos/DynamoRIO/dynamorio/stargazers","contributors_url":"https://api.github.com/repos/DynamoRIO/dynamorio/contributors","subscribers_url":"https://api.github.com/repos/DynamoRIO/dynamorio/subscribers","subscription_url":"https://api.github.com/repos/DynamoRIO/dynamorio/subscription","commits_url":"https://api.github.com/repos/DynamoRIO/dynamorio/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoRIO/dynamorio/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoRIO/dynamorio/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoRIO/dynamorio/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoRIO/dynamorio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoRIO/dynamorio/merges","archive_url":"https://api.github.com/repos/DynamoRIO/dynamorio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoRIO/dynamorio/downloads","issues_url":"https://api.github.com/repos/DynamoRIO/dynamorio/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoRIO/dynamorio/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoRIO/dynamorio/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoRIO/dynamorio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoRIO/dynamorio/labels{/name}","releases_url":"https://api.github.com/repos/DynamoRIO/dynamorio/releases{/id}","deployments_url":"https://api.github.com/repos/DynamoRIO/dynamorio/deployments","created_at":"2014-11-27T22:08:34Z","updated_at":"2019-05-22T17:58:15Z","pushed_at":"2019-05-22T17:32:43Z","git_url":"git://github.com/DynamoRIO/dynamorio.git","ssh_url":"[email protected]:DynamoRIO/dynamorio.git","clone_url":"https://github.com/DynamoRIO/dynamorio.git","svn_url":"https://github.com/DynamoRIO/dynamorio","homepage":null,"size":54357,"stargazers_count":1001,"watchers_count":1001,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":254,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1155,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":254,"open_issues":1155,"watchers":1001,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoRIO/dynamorio/pulls/3634"},"html":{"href":"https://github.com/DynamoRIO/dynamorio/pull/3634"},"issue":{"href":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/3634"},"comments":{"href":"https://api.github.com/repos/DynamoRIO/dynamorio/issues/3634/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoRIO/dynamorio/pulls/3634/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoRIO/dynamorio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoRIO/dynamorio/pulls/3634/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoRIO/dynamorio/statuses/d6cbf53401c9b0b41ec85b0cfd295960c355c033"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 27242935,
"name": "DynamoRIO/dynamorio",
"url": "https://api.github.com/repos/DynamoRIO/dynamorio"
}
|
{
"id": 43382901,
"login": "hgreving2304",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/43382901?",
"url": "https://api.github.com/users/hgreving2304"
}
|
{
"id": 9010155,
"login": "DynamoRIO",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9010155?",
"url": "https://api.github.com/orgs/DynamoRIO"
}
| 2019-05-22T19:33:55 |
9678652293
|
{"actor":{"display_login":"hgreving2304"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/docs/pulls/comments/348142647","pull_request_review_id":319318720,"id":348142647,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0ODE0MjY0Nw==","diff_hunk":"@@ -0,0 +1,103 @@\n+### YamlMime:Landing\n+\n+title: \"C# programming language documentation\"\n+summary: \"Learn how to write all kinds of applications using the C# programming language on the .NET platform.\"\n+\n+metadata:\n+ title: \"C# programming language documentation - get started, tutorials, reference.\"\n+ description: \"Learn C# programming - for beginning developers, developers new to C#, and experienced C# / .NET developers\"\n+ ms.topic: landing-page # Required\n+ author: billwagner\n+ ms.author: wiwagn\n+ ms.date: 11/19/2019\n+\n+# linkListType: | concept | get-started | how-to-guide | overview | reference | tutorial | video | whats-new\n+\n+landingContent:\n+ - title: \"Learn to program in C#\"\n+ linkLists:\n+ - linkListType: get-started\n+ links:\n+ - text: Online, interactive Hello world\n+ url: tutorials/intro-to-csharp/hello-world.yml\n+ - text: \"Math and numbers in C#\"\n+ url: tutorials/intro-to-csharp/numbers-in-csharp.yml\n+ - text: Introductory tutorials\n+ url: tutorials/intro-to-csharp/index.md\n+ - linkListType: video\n+ links:\n+ - text: \"What is C#?\"\n+ url: https://channel9.msdn.com/Series/CSharp-101/What-is-C/player\n+ - text: \"C# 101 video series\"\n+ url: https://aka.ms/dotnet3-csharp\n+\n+ - title: \"C# language fundamentals\"\n+ linkLists:\n+ - linkListType: overview\n+ links:\n+ - text: \"A tour of C#\"\n+ url: tour-of-csharp/index.md\n+ - text: \"Inside a C# program\"\n+ url: programming-guide/inside-a-program/index.md\n+ - text: Main() and command-line Arguments\n+ url: programming-guide/main-and-command-args/index.md\n+ - linkListType: concept\n+ links:\n+ - text: \"The C# and .NET type system\"\n+ url: programming-guide/types/index.md\n+ - text: Language Integrated Query (LINQ)\n+ url: linq/index.md\n+ - text: async and await\n+ url: programming-guide/concepts/async/index.md\n+ - linkListType: tutorial\n+ links:\n+ - text: Object oriented inheritance\n+ url: tutorials/inheritance.md\n+ - text: Use LINQ to query data\n+ url: tutorials/working-with-linq.md\n+ - text: Format strings using interpolation\n+ url: tutorials/string-interpolation.md\n+ - text: Fundamental language tutorials\n+ url: tutorials/index.md\n+ \n+ - title: \"What's new in C#\"\n+ linkLists:\n+ - linkListType: whats-new\n+ links:\n+ - text: \"What's new in C# 8.0\"\n+ url: whats-new/csharp-8.md\n+ - linkListType: overview\n+ links:\n+ - text: Pattern matching\n+ url: pattern-matching.md\n+ - text: Nullable reference types\n+ url: nullable-references.md\n+ - text: Annotating your APIs for nullability\n+ url: nullable-attributes.md\n+ - text: Specify language version\n+ url: language-reference/configure-language-version.md\n+ - linkListType: tutorial\n+ links:\n+ - text: Consume and generate async streams\n+ url: tutorials/generate-consume-asynchronous-stream.md\n+ - text: Develop with nullable reference types\n+ url: tutorials/nullable-reference-types.md\n+ - text: Upgrade existing code to use nullable nullable-references","path":"docs/csharp/index.yml","position":85,"original_position":85,"commit_id":"1a3b8feed2e4eb7d2d0801ab25b092235606277e","original_commit_id":"1a3b8feed2e4eb7d2d0801ab25b092235606277e","user":{"login":"pkulikov","id":15279990,"node_id":"MDQ6VXNlcjE1Mjc5OTkw","avatar_url":"https://avatars1.githubusercontent.com/u/15279990?v=4","gravatar_id":"","url":"https://api.github.com/users/pkulikov","html_url":"https://github.com/pkulikov","followers_url":"https://api.github.com/users/pkulikov/followers","following_url":"https://api.github.com/users/pkulikov/following{/other_user}","gists_url":"https://api.github.com/users/pkulikov/gists{/gist_id}","starred_url":"https://api.github.com/users/pkulikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkulikov/subscriptions","organizations_url":"https://api.github.com/users/pkulikov/orgs","repos_url":"https://api.github.com/users/pkulikov/repos","events_url":"https://api.github.com/users/pkulikov/events{/privacy}","received_events_url":"https://api.github.com/users/pkulikov/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n - text: Upgrade existing code to use nullable reference types\r\n```","created_at":"2019-11-19T20:10:20Z","updated_at":"2019-11-19T20:11:41Z","html_url":"https://github.com/dotnet/docs/pull/15895#discussion_r348142647","pull_request_url":"https://api.github.com/repos/dotnet/docs/pulls/15895","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/docs/pulls/comments/348142647"},"html":{"href":"https://github.com/dotnet/docs/pull/15895#discussion_r348142647"},"pull_request":{"href":"https://api.github.com/repos/dotnet/docs/pulls/15895"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/docs/pulls/15895","id":342852248,"node_id":"MDExOlB1bGxSZXF1ZXN0MzQyODUyMjQ4","html_url":"https://github.com/dotnet/docs/pull/15895","diff_url":"https://github.com/dotnet/docs/pull/15895.diff","patch_url":"https://github.com/dotnet/docs/pull/15895.patch","issue_url":"https://api.github.com/repos/dotnet/docs/issues/15895","number":15895,"state":"open","locked":false,"title":"[WIP] New csharp landing page","user":{"login":"BillWagner","id":493969,"node_id":"MDQ6VXNlcjQ5Mzk2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/493969?v=4","gravatar_id":"","url":"https://api.github.com/users/BillWagner","html_url":"https://github.com/BillWagner","followers_url":"https://api.github.com/users/BillWagner/followers","following_url":"https://api.github.com/users/BillWagner/following{/other_user}","gists_url":"https://api.github.com/users/BillWagner/gists{/gist_id}","starred_url":"https://api.github.com/users/BillWagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillWagner/subscriptions","organizations_url":"https://api.github.com/users/BillWagner/orgs","repos_url":"https://api.github.com/users/BillWagner/repos","events_url":"https://api.github.com/users/BillWagner/events{/privacy}","received_events_url":"https://api.github.com/users/BillWagner/received_events","type":"User","site_admin":false},"body":"Update to the new standard.\r\n\r\nAs part of that work, highlight the articles where we want to drive traffic.","created_at":"2019-11-19T19:34:08Z","updated_at":"2019-11-19T20:11:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fb5016d40d99e8cad63de2cb87613cb6b248a15","assignee":null,"assignees":[],"requested_reviewers":[{"login":"KathleenDollard","id":5844318,"node_id":"MDQ6VXNlcjU4NDQzMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/5844318?v=4","gravatar_id":"","url":"https://api.github.com/users/KathleenDollard","html_url":"https://github.com/KathleenDollard","followers_url":"https://api.github.com/users/KathleenDollard/followers","following_url":"https://api.github.com/users/KathleenDollard/following{/other_user}","gists_url":"https://api.github.com/users/KathleenDollard/gists{/gist_id}","starred_url":"https://api.github.com/users/KathleenDollard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KathleenDollard/subscriptions","organizations_url":"https://api.github.com/users/KathleenDollard/orgs","repos_url":"https://api.github.com/users/KathleenDollard/repos","events_url":"https://api.github.com/users/KathleenDollard/events{/privacy}","received_events_url":"https://api.github.com/users/KathleenDollard/received_events","type":"User","site_admin":false},{"login":"mairaw","id":12971179,"node_id":"MDQ6VXNlcjEyOTcxMTc5","avatar_url":"https://avatars2.githubusercontent.com/u/12971179?v=4","gravatar_id":"","url":"https://api.github.com/users/mairaw","html_url":"https://github.com/mairaw","followers_url":"https://api.github.com/users/mairaw/followers","following_url":"https://api.github.com/users/mairaw/following{/other_user}","gists_url":"https://api.github.com/users/mairaw/gists{/gist_id}","starred_url":"https://api.github.com/users/mairaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mairaw/subscriptions","organizations_url":"https://api.github.com/users/mairaw/orgs","repos_url":"https://api.github.com/users/mairaw/repos","events_url":"https://api.github.com/users/mairaw/events{/privacy}","received_events_url":"https://api.github.com/users/mairaw/received_events","type":"User","site_admin":false},{"login":"gewarren","id":24882762,"node_id":"MDQ6VXNlcjI0ODgyNzYy","avatar_url":"https://avatars3.githubusercontent.com/u/24882762?v=4","gravatar_id":"","url":"https://api.github.com/users/gewarren","html_url":"https://github.com/gewarren","followers_url":"https://api.github.com/users/gewarren/followers","following_url":"https://api.github.com/users/gewarren/following{/other_user}","gists_url":"https://api.github.com/users/gewarren/gists{/gist_id}","starred_url":"https://api.github.com/users/gewarren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gewarren/subscriptions","organizations_url":"https://api.github.com/users/gewarren/orgs","repos_url":"https://api.github.com/users/gewarren/repos","events_url":"https://api.github.com/users/gewarren/events{/privacy}","received_events_url":"https://api.github.com/users/gewarren/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":429768030,"node_id":"MDU6TGFiZWw0Mjk3NjgwMzA=","url":"https://api.github.com/repos/dotnet/docs/labels/:books:%20Area%20-%20C%23%20Guide","name":":books: Area - C# Guide","color":"3d5c8e","default":false,"description":"C# language content"}],"milestone":{"url":"https://api.github.com/repos/dotnet/docs/milestones/65","html_url":"https://github.com/dotnet/docs/milestone/65","labels_url":"https://api.github.com/repos/dotnet/docs/milestones/65/labels","id":4626304,"node_id":"MDk6TWlsZXN0b25lNDYyNjMwNA==","number":65,"title":"November 2019","description":"","creator":{"login":"BillWagner","id":493969,"node_id":"MDQ6VXNlcjQ5Mzk2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/493969?v=4","gravatar_id":"","url":"https://api.github.com/users/BillWagner","html_url":"https://github.com/BillWagner","followers_url":"https://api.github.com/users/BillWagner/followers","following_url":"https://api.github.com/users/BillWagner/following{/other_user}","gists_url":"https://api.github.com/users/BillWagner/gists{/gist_id}","starred_url":"https://api.github.com/users/BillWagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillWagner/subscriptions","organizations_url":"https://api.github.com/users/BillWagner/orgs","repos_url":"https://api.github.com/users/BillWagner/repos","events_url":"https://api.github.com/users/BillWagner/events{/privacy}","received_events_url":"https://api.github.com/users/BillWagner/received_events","type":"User","site_admin":false},"open_issues":78,"closed_issues":307,"state":"open","created_at":"2019-09-03T21:06:20Z","updated_at":"2019-11-19T19:46:45Z","due_on":"2019-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/docs/pulls/15895/commits","review_comments_url":"https://api.github.com/repos/dotnet/docs/pulls/15895/comments","review_comment_url":"https://api.github.com/repos/dotnet/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/docs/issues/15895/comments","statuses_url":"https://api.github.com/repos/dotnet/docs/statuses/1a3b8feed2e4eb7d2d0801ab25b092235606277e","head":{"label":"BillWagner:new-csharp-landing-page","ref":"new-csharp-landing-page","sha":"1a3b8feed2e4eb7d2d0801ab25b092235606277e","user":{"login":"BillWagner","id":493969,"node_id":"MDQ6VXNlcjQ5Mzk2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/493969?v=4","gravatar_id":"","url":"https://api.github.com/users/BillWagner","html_url":"https://github.com/BillWagner","followers_url":"https://api.github.com/users/BillWagner/followers","following_url":"https://api.github.com/users/BillWagner/following{/other_user}","gists_url":"https://api.github.com/users/BillWagner/gists{/gist_id}","starred_url":"https://api.github.com/users/BillWagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillWagner/subscriptions","organizations_url":"https://api.github.com/users/BillWagner/orgs","repos_url":"https://api.github.com/users/BillWagner/repos","events_url":"https://api.github.com/users/BillWagner/events{/privacy}","received_events_url":"https://api.github.com/users/BillWagner/received_events","type":"User","site_admin":false},"repo":{"id":127573416,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc1NzM0MTY=","name":"docs","full_name":"BillWagner/docs","private":false,"owner":{"login":"BillWagner","id":493969,"node_id":"MDQ6VXNlcjQ5Mzk2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/493969?v=4","gravatar_id":"","url":"https://api.github.com/users/BillWagner","html_url":"https://github.com/BillWagner","followers_url":"https://api.github.com/users/BillWagner/followers","following_url":"https://api.github.com/users/BillWagner/following{/other_user}","gists_url":"https://api.github.com/users/BillWagner/gists{/gist_id}","starred_url":"https://api.github.com/users/BillWagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillWagner/subscriptions","organizations_url":"https://api.github.com/users/BillWagner/orgs","repos_url":"https://api.github.com/users/BillWagner/repos","events_url":"https://api.github.com/users/BillWagner/events{/privacy}","received_events_url":"https://api.github.com/users/BillWagner/received_events","type":"User","site_admin":false},"html_url":"https://github.com/BillWagner/docs","description":"This repository contains .NET Documentation.","fork":true,"url":"https://api.github.com/repos/BillWagner/docs","forks_url":"https://api.github.com/repos/BillWagner/docs/forks","keys_url":"https://api.github.com/repos/BillWagner/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BillWagner/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BillWagner/docs/teams","hooks_url":"https://api.github.com/repos/BillWagner/docs/hooks","issue_events_url":"https://api.github.com/repos/BillWagner/docs/issues/events{/number}","events_url":"https://api.github.com/repos/BillWagner/docs/events","assignees_url":"https://api.github.com/repos/BillWagner/docs/assignees{/user}","branches_url":"https://api.github.com/repos/BillWagner/docs/branches{/branch}","tags_url":"https://api.github.com/repos/BillWagner/docs/tags","blobs_url":"https://api.github.com/repos/BillWagner/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BillWagner/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BillWagner/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/BillWagner/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BillWagner/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/BillWagner/docs/languages","stargazers_url":"https://api.github.com/repos/BillWagner/docs/stargazers","contributors_url":"https://api.github.com/repos/BillWagner/docs/contributors","subscribers_url":"https://api.github.com/repos/BillWagner/docs/subscribers","subscription_url":"https://api.github.com/repos/BillWagner/docs/subscription","commits_url":"https://api.github.com/repos/BillWagner/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/BillWagner/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/BillWagner/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/BillWagner/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/BillWagner/docs/contents/{+path}","compare_url":"https://api.github.com/repos/BillWagner/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BillWagner/docs/merges","archive_url":"https://api.github.com/repos/BillWagner/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BillWagner/docs/downloads","issues_url":"https://api.github.com/repos/BillWagner/docs/issues{/number}","pulls_url":"https://api.github.com/repos/BillWagner/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/BillWagner/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/BillWagner/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BillWagner/docs/labels{/name}","releases_url":"https://api.github.com/repos/BillWagner/docs/releases{/id}","deployments_url":"https://api.github.com/repos/BillWagner/docs/deployments","created_at":"2018-03-31T21:38:54Z","updated_at":"2019-11-18T16:27:41Z","pushed_at":"2019-11-19T19:53:52Z","git_url":"git://github.com/BillWagner/docs.git","ssh_url":"[email protected]:BillWagner/docs.git","clone_url":"https://github.com/BillWagner/docs.git","svn_url":"https://github.com/BillWagner/docs","homepage":"https://docs.microsoft.com/dotnet","size":383464,"stargazers_count":1,"watchers_count":1,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"bb6819b983bd2965ea3c28b15deb79e1869ad692","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35890081,"node_id":"MDEwOlJlcG9zaXRvcnkzNTg5MDA4MQ==","name":"docs","full_name":"dotnet/docs","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/docs","description":"This repository contains .NET Documentation.","fork":false,"url":"https://api.github.com/repos/dotnet/docs","forks_url":"https://api.github.com/repos/dotnet/docs/forks","keys_url":"https://api.github.com/repos/dotnet/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/docs/teams","hooks_url":"https://api.github.com/repos/dotnet/docs/hooks","issue_events_url":"https://api.github.com/repos/dotnet/docs/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/docs/events","assignees_url":"https://api.github.com/repos/dotnet/docs/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/docs/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/docs/tags","blobs_url":"https://api.github.com/repos/dotnet/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/docs/languages","stargazers_url":"https://api.github.com/repos/dotnet/docs/stargazers","contributors_url":"https://api.github.com/repos/dotnet/docs/contributors","subscribers_url":"https://api.github.com/repos/dotnet/docs/subscribers","subscription_url":"https://api.github.com/repos/dotnet/docs/subscription","commits_url":"https://api.github.com/repos/dotnet/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/docs/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/docs/merges","archive_url":"https://api.github.com/repos/dotnet/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/docs/downloads","issues_url":"https://api.github.com/repos/dotnet/docs/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/docs/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/docs/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/docs/deployments","created_at":"2015-05-19T15:13:32Z","updated_at":"2019-11-19T18:38:21Z","pushed_at":"2019-11-19T19:54:43Z","git_url":"git://github.com/dotnet/docs.git","ssh_url":"[email protected]:dotnet/docs.git","clone_url":"https://github.com/dotnet/docs.git","svn_url":"https://github.com/dotnet/docs","homepage":"https://docs.microsoft.com/dotnet","size":650607,"stargazers_count":2085,"watchers_count":2085,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3628,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1376,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3628,"open_issues":1376,"watchers":2085,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/docs/pulls/15895"},"html":{"href":"https://github.com/dotnet/docs/pull/15895"},"issue":{"href":"https://api.github.com/repos/dotnet/docs/issues/15895"},"comments":{"href":"https://api.github.com/repos/dotnet/docs/issues/15895/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/docs/pulls/15895/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/docs/pulls/15895/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/docs/statuses/1a3b8feed2e4eb7d2d0801ab25b092235606277e"}},"author_association":"MEMBER"}}
|
{
"id": 35890081,
"name": "dotnet/docs",
"url": "https://api.github.com/repos/dotnet/docs"
}
|
{
"id": 15279990,
"login": "pkulikov",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/15279990?",
"url": "https://api.github.com/users/pkulikov"
}
|
{
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
}
| 2019-11-19T20:10:20 |
10900378564
|
{"actor":{"display_login":"pkulikov"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/docs/pulls/comments/305027925","pull_request_review_id":263745786,"id":305027925,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNTAyNzkyNQ==","diff_hunk":"@@ -0,0 +1,1124 @@\n+---\n+title: 'Tutorial: Detect objects using deep learning with ONNX and ML.NET'\n+description: This tutorial illustrates how to use a pre-trained ONNX deep learning model in ML.NET to detect objects in images.\n+author: luisquintanilla\n+ms.author: luquinta\n+ms.date: 07/10/2019\n+ms.topic: tutorial\n+ms.custom: mvc\n+#Customer intent: As a developer, I want to use ML.NET so that I can use a pre-trained model in an object detection scenario to detect objects in images using ONNX.\n+---\n+\n+# Tutorial: Detect objects using ONNX in ML.NET\n+\n+Learn how to use a pre-trained ONNX model in ML.NET to detect objects. The pre-trained model was trained to find and classify objects in an image.\n+\n+Training an object detection model from scratch requires setting millions of parameters, a large amount of labeled training data and a vast amount of compute resources (hundreds of GPU hours). Using a pre-trained model allows you to shortcut the training process.\n+\n+In this tutorial, you learn how to:\n+> [!div class=\"checklist\"]\n+> * Understand the problem\n+> * Reuse the pre-trained model\n+> * Detect objects with a loaded model\n+\n+## Pre-requisites\n+\n+- [Visual Studio 2017 15.6 or later](https://visualstudio.microsoft.com/downloads/?utm_medium=microsoft&utm_source=docs.microsoft.com&utm_campaign=inline+link&utm_content=download+vs2017) with the \".NET Core cross-platform development\" workload installed.\n+- [Microsoft.ML NuGet Package](https://www.nuget.org/packages/Microsoft.ML/)\n+- [Microsoft.ML.ImageAnalytics NuGet Package](https://www.nuget.org/packages/Microsoft.ML.ImageAnalytics/)\n+- [Microsoft.ML.OnnxTransformer NuGet Package](https://www.nuget.org/packages/Microsoft.ML.OnnxTransformer/)\n+- [Tiny YOLOv2 pre-trained model](https://github.com/onnx/models/tree/master/tiny_yolov2)\n+- [Netron](https://github.com/lutzroeder/netron) (optional)\n+\n+## ONNX object detection sample overview\n+\n+This sample creates a .NET core console application that detects objects within an image using a pre-trained deep learning ONNX model. The code for this sample can be found on the [dotnet/machinelearning-samples repository](https://github.com/dotnet/machinelearning-samples/tree/master/samples/csharp/getting-started/DeepLearning_ObjectDetection_Onnx) on GitHub.\n+\n+## What is object detection\n+\n+Object detection is a computer vision problem. While closely related to image classification, object detection performs image classification at a more granular scale. When an image is processed, there is first a check on whether there is an object present or not. If so, the detected object is classified and using object localization, the location of that object is returned along with the class. Typically, you want to use this approach on images where there are multiple objects of different types so that each is individually recognized. \n+\n+\n+\n+Some use cases for object detection include:\n+\n+- Self-Driving Cars\n+- Robotics\n+- Face Detection\n+- Workplace Safety\n+- Object Counting\n+- Activity Recognition\n+\n+## Select the appropriate machine learning task \n+\n+Deep learning is a subset of machine learning. To train deep learning models, large quantities of data are required. Patterns in the data are represented by a series of layers. The relationships in the data are encoded as connections between the layers contanining weights. The higher the weight, the stronger the relationship. Collectively, this series of layers and connections are known as artificial neural networks. The more layers in a network, the \"deeper\" it is, making it a deep neural network. \n+\n+There are different types of neural networks, each more suitable than the other for certain tasks. The most common types of neural networks are Multi-Layered Perceptron (MLP), Convolutional Neural Network (CNN) and Recurrent Neural Network (RNN). The most basic is the MLP which maps a set of inputs to a set of outputs. This neural network is good when the data does not have a spatial or time component. The CNN as implied by the name makes use of convolutional layers which take into account spatial information contained in the data. A good use case for CNNs is image processing when trying to detect the presence of a particular feature in a region of an image (i.e. is there a nose in the center of an image?). Finally, RNNs allow for the persistence of state or memory to be used as input therefore making it a good candidates for time-series analysis where the sequential ordering and context of events is important. \n+\n+Object detection is an image processing task. Therefore, most deep learning models trained to solve this problem are CNNs. The model used in this tutorial is the Tiny YOLOv2 model, a more compact version of the YOLOv2 model described in the paper: [\"YOLO9000: Better, Faster, Stronger\" by Redmon and Fadhari](https://arxiv.org/pdf/1612.08242.pdf). Tiny YOLOv2 is trained on the Pascal VOC dataset and is made up of 15 layers that can predict 20 different classes of objects. Because Tiny YOLOv2 is a condensed version of the original YOLOv2 model, a tradeoff is made between speed and accuracy. \n+\n+The model is stored in ONNX format. The Open Neural Network Exchange (ONNX) is an open source format for AI models. ONNX supports interoperability between frameworks. This means you can train a model in one of the many popular machine learning frameworks like PyTorch, convert it into ONNX format and consume the ONNX model in a different framework like ML.NET. To learn more, visit the [ONNX website](https://onnx.ai/). \n+\n+\n+\n+## Create console application","path":"docs/machine-learning/tutorials/object-detection-onnx.md","position":64,"original_position":64,"commit_id":"5a41a28be1cbe5f272779db0517062ad2dd3e673","original_commit_id":"5966b6d593c3ac07af51ce1e90f01a36b3255d7b","user":{"login":"natke","id":3302433,"node_id":"MDQ6VXNlcjMzMDI0MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/3302433?v=4","gravatar_id":"","url":"https://api.github.com/users/natke","html_url":"https://github.com/natke","followers_url":"https://api.github.com/users/natke/followers","following_url":"https://api.github.com/users/natke/following{/other_user}","gists_url":"https://api.github.com/users/natke/gists{/gist_id}","starred_url":"https://api.github.com/users/natke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natke/subscriptions","organizations_url":"https://api.github.com/users/natke/orgs","repos_url":"https://api.github.com/users/natke/repos","events_url":"https://api.github.com/users/natke/events{/privacy}","received_events_url":"https://api.github.com/users/natke/received_events","type":"User","site_admin":false},"body":"Is this the best title for this section? Can we make it more specific?","created_at":"2019-07-18T17:16:06Z","updated_at":"2019-07-18T17:18:40Z","html_url":"https://github.com/dotnet/docs/pull/12755#discussion_r305027925","pull_request_url":"https://api.github.com/repos/dotnet/docs/pulls/12755","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/docs/pulls/comments/305027925"},"html":{"href":"https://github.com/dotnet/docs/pull/12755#discussion_r305027925"},"pull_request":{"href":"https://api.github.com/repos/dotnet/docs/pulls/12755"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/docs/pulls/12755","id":286726388,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjg2NzI2Mzg4","html_url":"https://github.com/dotnet/docs/pull/12755","diff_url":"https://github.com/dotnet/docs/pull/12755.diff","patch_url":"https://github.com/dotnet/docs/pull/12755.patch","issue_url":"https://api.github.com/repos/dotnet/docs/issues/12755","number":12755,"state":"open","locked":false,"title":"ONNX Object Detection Tutorial","user":{"login":"luisquintanilla","id":46974588,"node_id":"MDQ6VXNlcjQ2OTc0NTg4","avatar_url":"https://avatars2.githubusercontent.com/u/46974588?v=4","gravatar_id":"","url":"https://api.github.com/users/luisquintanilla","html_url":"https://github.com/luisquintanilla","followers_url":"https://api.github.com/users/luisquintanilla/followers","following_url":"https://api.github.com/users/luisquintanilla/following{/other_user}","gists_url":"https://api.github.com/users/luisquintanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/luisquintanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisquintanilla/subscriptions","organizations_url":"https://api.github.com/users/luisquintanilla/orgs","repos_url":"https://api.github.com/users/luisquintanilla/repos","events_url":"https://api.github.com/users/luisquintanilla/events{/privacy}","received_events_url":"https://api.github.com/users/luisquintanilla/received_events","type":"User","site_admin":false},"body":"Object Detection Tutorial using ONNX\r\n\r\n[AB#1450817](https://dev.azure.com/mseng/677da0fb-b067-4f77-b89b-f32c12bb8617/_workitems/edit/1450817)\r\n\r\n[AB#1566043](https://dev.azure.com/mseng/677da0fb-b067-4f77-b89b-f32c12bb8617/_workitems/edit/1566043)\r\n\r\n[Internal Review Link](https://review.docs.microsoft.com/en-us/dotnet/machine-learning/tutorials/object-detection-onnx?branch=pr-en-us-12755)\r\n\r\nTo-Do:\r\n\r\n- [x] Add inspecting with Netron section\r\n- [x] Add conceptual information (DNN, YOLO, ONNX)\r\n- [x] Improve sections / headers\r\n- [x] Add xrefs\r\n- [ ] Replace Hard-Coded Code Snippets with Machine Learning Samples","created_at":"2019-06-10T15:35:09Z","updated_at":"2019-07-18T17:18:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b29c83fe511d8ee8e9482ce41a084e63eb837b8","assignee":{"login":"luisquintanilla","id":46974588,"node_id":"MDQ6VXNlcjQ2OTc0NTg4","avatar_url":"https://avatars2.githubusercontent.com/u/46974588?v=4","gravatar_id":"","url":"https://api.github.com/users/luisquintanilla","html_url":"https://github.com/luisquintanilla","followers_url":"https://api.github.com/users/luisquintanilla/followers","following_url":"https://api.github.com/users/luisquintanilla/following{/other_user}","gists_url":"https://api.github.com/users/luisquintanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/luisquintanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisquintanilla/subscriptions","organizations_url":"https://api.github.com/users/luisquintanilla/orgs","repos_url":"https://api.github.com/users/luisquintanilla/repos","events_url":"https://api.github.com/users/luisquintanilla/events{/privacy}","received_events_url":"https://api.github.com/users/luisquintanilla/received_events","type":"User","site_admin":false},"assignees":[{"login":"luisquintanilla","id":46974588,"node_id":"MDQ6VXNlcjQ2OTc0NTg4","avatar_url":"https://avatars2.githubusercontent.com/u/46974588?v=4","gravatar_id":"","url":"https://api.github.com/users/luisquintanilla","html_url":"https://github.com/luisquintanilla","followers_url":"https://api.github.com/users/luisquintanilla/followers","following_url":"https://api.github.com/users/luisquintanilla/following{/other_user}","gists_url":"https://api.github.com/users/luisquintanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/luisquintanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisquintanilla/subscriptions","organizations_url":"https://api.github.com/users/luisquintanilla/orgs","repos_url":"https://api.github.com/users/luisquintanilla/repos","events_url":"https://api.github.com/users/luisquintanilla/events{/privacy}","received_events_url":"https://api.github.com/users/luisquintanilla/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":925523939,"node_id":"MDU6TGFiZWw5MjU1MjM5Mzk=","url":"https://api.github.com/repos/dotnet/docs/labels/:books:%20Area%20-%20ML.NET%20Guide","name":":books: Area - ML.NET Guide","color":"3d5c8e","default":false},{"id":332575224,"node_id":"MDU6TGFiZWwzMzI1NzUyMjQ=","url":"https://api.github.com/repos/dotnet/docs/labels/new-content","name":"new-content","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/docs/milestones/61","html_url":"https://github.com/dotnet/docs/milestone/61","labels_url":"https://api.github.com/repos/dotnet/docs/milestones/61/labels","id":4365340,"node_id":"MDk6TWlsZXN0b25lNDM2NTM0MA==","number":61,"title":"July 2019","description":"","creator":{"login":"BillWagner","id":493969,"node_id":"MDQ6VXNlcjQ5Mzk2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/493969?v=4","gravatar_id":"","url":"https://api.github.com/users/BillWagner","html_url":"https://github.com/BillWagner","followers_url":"https://api.github.com/users/BillWagner/followers","following_url":"https://api.github.com/users/BillWagner/following{/other_user}","gists_url":"https://api.github.com/users/BillWagner/gists{/gist_id}","starred_url":"https://api.github.com/users/BillWagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BillWagner/subscriptions","organizations_url":"https://api.github.com/users/BillWagner/orgs","repos_url":"https://api.github.com/users/BillWagner/repos","events_url":"https://api.github.com/users/BillWagner/events{/privacy}","received_events_url":"https://api.github.com/users/BillWagner/received_events","type":"User","site_admin":false},"open_issues":47,"closed_issues":103,"state":"open","created_at":"2019-05-31T15:32:24Z","updated_at":"2019-07-18T17:17:16Z","due_on":"2019-07-26T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/docs/pulls/12755/commits","review_comments_url":"https://api.github.com/repos/dotnet/docs/pulls/12755/comments","review_comment_url":"https://api.github.com/repos/dotnet/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/docs/issues/12755/comments","statuses_url":"https://api.github.com/repos/dotnet/docs/statuses/5a41a28be1cbe5f272779db0517062ad2dd3e673","head":{"label":"luisquintanilla:mlnet-onnx-object-detection","ref":"mlnet-onnx-object-detection","sha":"5a41a28be1cbe5f272779db0517062ad2dd3e673","user":{"login":"luisquintanilla","id":46974588,"node_id":"MDQ6VXNlcjQ2OTc0NTg4","avatar_url":"https://avatars2.githubusercontent.com/u/46974588?v=4","gravatar_id":"","url":"https://api.github.com/users/luisquintanilla","html_url":"https://github.com/luisquintanilla","followers_url":"https://api.github.com/users/luisquintanilla/followers","following_url":"https://api.github.com/users/luisquintanilla/following{/other_user}","gists_url":"https://api.github.com/users/luisquintanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/luisquintanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisquintanilla/subscriptions","organizations_url":"https://api.github.com/users/luisquintanilla/orgs","repos_url":"https://api.github.com/users/luisquintanilla/repos","events_url":"https://api.github.com/users/luisquintanilla/events{/privacy}","received_events_url":"https://api.github.com/users/luisquintanilla/received_events","type":"User","site_admin":false},"repo":{"id":167407004,"node_id":"MDEwOlJlcG9zaXRvcnkxNjc0MDcwMDQ=","name":"docs","full_name":"luisquintanilla/docs","private":false,"owner":{"login":"luisquintanilla","id":46974588,"node_id":"MDQ6VXNlcjQ2OTc0NTg4","avatar_url":"https://avatars2.githubusercontent.com/u/46974588?v=4","gravatar_id":"","url":"https://api.github.com/users/luisquintanilla","html_url":"https://github.com/luisquintanilla","followers_url":"https://api.github.com/users/luisquintanilla/followers","following_url":"https://api.github.com/users/luisquintanilla/following{/other_user}","gists_url":"https://api.github.com/users/luisquintanilla/gists{/gist_id}","starred_url":"https://api.github.com/users/luisquintanilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luisquintanilla/subscriptions","organizations_url":"https://api.github.com/users/luisquintanilla/orgs","repos_url":"https://api.github.com/users/luisquintanilla/repos","events_url":"https://api.github.com/users/luisquintanilla/events{/privacy}","received_events_url":"https://api.github.com/users/luisquintanilla/received_events","type":"User","site_admin":false},"html_url":"https://github.com/luisquintanilla/docs","description":"This repository contains .NET Documentation.","fork":true,"url":"https://api.github.com/repos/luisquintanilla/docs","forks_url":"https://api.github.com/repos/luisquintanilla/docs/forks","keys_url":"https://api.github.com/repos/luisquintanilla/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luisquintanilla/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luisquintanilla/docs/teams","hooks_url":"https://api.github.com/repos/luisquintanilla/docs/hooks","issue_events_url":"https://api.github.com/repos/luisquintanilla/docs/issues/events{/number}","events_url":"https://api.github.com/repos/luisquintanilla/docs/events","assignees_url":"https://api.github.com/repos/luisquintanilla/docs/assignees{/user}","branches_url":"https://api.github.com/repos/luisquintanilla/docs/branches{/branch}","tags_url":"https://api.github.com/repos/luisquintanilla/docs/tags","blobs_url":"https://api.github.com/repos/luisquintanilla/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luisquintanilla/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luisquintanilla/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/luisquintanilla/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luisquintanilla/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/luisquintanilla/docs/languages","stargazers_url":"https://api.github.com/repos/luisquintanilla/docs/stargazers","contributors_url":"https://api.github.com/repos/luisquintanilla/docs/contributors","subscribers_url":"https://api.github.com/repos/luisquintanilla/docs/subscribers","subscription_url":"https://api.github.com/repos/luisquintanilla/docs/subscription","commits_url":"https://api.github.com/repos/luisquintanilla/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/luisquintanilla/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/luisquintanilla/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/luisquintanilla/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/luisquintanilla/docs/contents/{+path}","compare_url":"https://api.github.com/repos/luisquintanilla/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luisquintanilla/docs/merges","archive_url":"https://api.github.com/repos/luisquintanilla/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luisquintanilla/docs/downloads","issues_url":"https://api.github.com/repos/luisquintanilla/docs/issues{/number}","pulls_url":"https://api.github.com/repos/luisquintanilla/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/luisquintanilla/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/luisquintanilla/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luisquintanilla/docs/labels{/name}","releases_url":"https://api.github.com/repos/luisquintanilla/docs/releases{/id}","deployments_url":"https://api.github.com/repos/luisquintanilla/docs/deployments","created_at":"2019-01-24T17:21:23Z","updated_at":"2019-04-29T18:45:24Z","pushed_at":"2019-07-18T16:56:20Z","git_url":"git://github.com/luisquintanilla/docs.git","ssh_url":"[email protected]:luisquintanilla/docs.git","clone_url":"https://github.com/luisquintanilla/docs.git","svn_url":"https://github.com/luisquintanilla/docs","homepage":"https://docs.microsoft.com/dotnet","size":599228,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"7c8259bac1e0514eccde41402262c183fcad37cf","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":35890081,"node_id":"MDEwOlJlcG9zaXRvcnkzNTg5MDA4MQ==","name":"docs","full_name":"dotnet/docs","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/docs","description":"This repository contains .NET Documentation.","fork":false,"url":"https://api.github.com/repos/dotnet/docs","forks_url":"https://api.github.com/repos/dotnet/docs/forks","keys_url":"https://api.github.com/repos/dotnet/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/docs/teams","hooks_url":"https://api.github.com/repos/dotnet/docs/hooks","issue_events_url":"https://api.github.com/repos/dotnet/docs/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/docs/events","assignees_url":"https://api.github.com/repos/dotnet/docs/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/docs/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/docs/tags","blobs_url":"https://api.github.com/repos/dotnet/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/docs/languages","stargazers_url":"https://api.github.com/repos/dotnet/docs/stargazers","contributors_url":"https://api.github.com/repos/dotnet/docs/contributors","subscribers_url":"https://api.github.com/repos/dotnet/docs/subscribers","subscription_url":"https://api.github.com/repos/dotnet/docs/subscription","commits_url":"https://api.github.com/repos/dotnet/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/docs/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/docs/merges","archive_url":"https://api.github.com/repos/dotnet/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/docs/downloads","issues_url":"https://api.github.com/repos/dotnet/docs/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/docs/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/docs/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/docs/deployments","created_at":"2015-05-19T15:13:32Z","updated_at":"2019-07-18T16:35:18Z","pushed_at":"2019-07-18T16:56:26Z","git_url":"git://github.com/dotnet/docs.git","ssh_url":"[email protected]:dotnet/docs.git","clone_url":"https://github.com/dotnet/docs.git","svn_url":"https://github.com/dotnet/docs","homepage":"https://docs.microsoft.com/dotnet","size":615776,"stargazers_count":1883,"watchers_count":1883,"language":"PowerShell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3422,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":1375,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3422,"open_issues":1375,"watchers":1883,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/docs/pulls/12755"},"html":{"href":"https://github.com/dotnet/docs/pull/12755"},"issue":{"href":"https://api.github.com/repos/dotnet/docs/issues/12755"},"comments":{"href":"https://api.github.com/repos/dotnet/docs/issues/12755/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/docs/pulls/12755/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/docs/pulls/12755/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/docs/statuses/5a41a28be1cbe5f272779db0517062ad2dd3e673"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 35890081,
"name": "dotnet/docs",
"url": "https://api.github.com/repos/dotnet/docs"
}
|
{
"id": 3302433,
"login": "natke",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3302433?",
"url": "https://api.github.com/users/natke"
}
|
{
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
}
| 2019-07-18T17:16:06 |
10039413193
|
{"actor":{"display_login":"natke"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/dotnet-api-docs/pulls/comments/310294015","pull_request_review_id":270390350,"id":310294015,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMxMDI5NDAxNQ==","diff_hunk":"@@ -37,11 +37,11 @@\n <Parameter Name=\"typeToConvert\" Type=\"System.Type\" />\n </Parameters>\n <Docs>\n- <param name=\"typeToConvert\">To be added.</param>\n- <summary>To be added.</summary>\n- <returns>To be added.</returns>\n+ <param name=\"typeToConvert\">The type to compare against.</param>","path":"xml/System.Text.Json.Serialization/JsonConverter.xml","position":16,"original_position":16,"commit_id":"9ecb192eb4e6a0d37dee62dd739a83adc4878e5c","original_commit_id":"9ecb192eb4e6a0d37dee62dd739a83adc4878e5c","user":{"login":"ahsonkhan","id":6527137,"node_id":"MDQ6VXNlcjY1MjcxMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6527137?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false},"body":"nit:\r\n```suggestion\r\n <param name=\"typeToConvert\">The type of the object to check whether it can be converted by this converter instance.</param>\r\n```","created_at":"2019-08-02T20:51:51Z","updated_at":"2019-08-02T20:51:57Z","html_url":"https://github.com/dotnet/dotnet-api-docs/pull/2889#discussion_r310294015","pull_request_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/pulls/2889","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/dotnet-api-docs/pulls/comments/310294015"},"html":{"href":"https://github.com/dotnet/dotnet-api-docs/pull/2889#discussion_r310294015"},"pull_request":{"href":"https://api.github.com/repos/dotnet/dotnet-api-docs/pulls/2889"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/dotnet-api-docs/pulls/2889","id":302742916,"node_id":"MDExOlB1bGxSZXF1ZXN0MzAyNzQyOTE2","html_url":"https://github.com/dotnet/dotnet-api-docs/pull/2889","diff_url":"https://github.com/dotnet/dotnet-api-docs/pull/2889.diff","patch_url":"https://github.com/dotnet/dotnet-api-docs/pull/2889.patch","issue_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/issues/2889","number":2889,"state":"open","locked":false,"title":"Automatically port System.Text.Json.Serialization.JsonConverter","user":{"login":"carlossanlop","id":1175054,"node_id":"MDQ6VXNlcjExNzUwNTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1175054?v=4","gravatar_id":"","url":"https://api.github.com/users/carlossanlop","html_url":"https://github.com/carlossanlop","followers_url":"https://api.github.com/users/carlossanlop/followers","following_url":"https://api.github.com/users/carlossanlop/following{/other_user}","gists_url":"https://api.github.com/users/carlossanlop/gists{/gist_id}","starred_url":"https://api.github.com/users/carlossanlop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlossanlop/subscriptions","organizations_url":"https://api.github.com/users/carlossanlop/orgs","repos_url":"https://api.github.com/users/carlossanlop/repos","events_url":"https://api.github.com/users/carlossanlop/events{/privacy}","received_events_url":"https://api.github.com/users/carlossanlop/received_events","type":"User","site_admin":false},"body":"New batch.","created_at":"2019-07-31T00:23:49Z","updated_at":"2019-08-02T20:51:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ae091c618a30c97e26a1146b7cf66c0dd313318","assignee":{"login":"carlossanlop","id":1175054,"node_id":"MDQ6VXNlcjExNzUwNTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1175054?v=4","gravatar_id":"","url":"https://api.github.com/users/carlossanlop","html_url":"https://github.com/carlossanlop","followers_url":"https://api.github.com/users/carlossanlop/followers","following_url":"https://api.github.com/users/carlossanlop/following{/other_user}","gists_url":"https://api.github.com/users/carlossanlop/gists{/gist_id}","starred_url":"https://api.github.com/users/carlossanlop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlossanlop/subscriptions","organizations_url":"https://api.github.com/users/carlossanlop/orgs","repos_url":"https://api.github.com/users/carlossanlop/repos","events_url":"https://api.github.com/users/carlossanlop/events{/privacy}","received_events_url":"https://api.github.com/users/carlossanlop/received_events","type":"User","site_admin":false},"assignees":[{"login":"carlossanlop","id":1175054,"node_id":"MDQ6VXNlcjExNzUwNTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1175054?v=4","gravatar_id":"","url":"https://api.github.com/users/carlossanlop","html_url":"https://github.com/carlossanlop","followers_url":"https://api.github.com/users/carlossanlop/followers","following_url":"https://api.github.com/users/carlossanlop/following{/other_user}","gists_url":"https://api.github.com/users/carlossanlop/gists{/gist_id}","starred_url":"https://api.github.com/users/carlossanlop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlossanlop/subscriptions","organizations_url":"https://api.github.com/users/carlossanlop/orgs","repos_url":"https://api.github.com/users/carlossanlop/repos","events_url":"https://api.github.com/users/carlossanlop/events{/privacy}","received_events_url":"https://api.github.com/users/carlossanlop/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"steveharter","id":6986755,"node_id":"MDQ6VXNlcjY5ODY3NTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6986755?v=4","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},{"login":"rpetrusha","id":10886961,"node_id":"MDQ6VXNlcjEwODg2OTYx","avatar_url":"https://avatars2.githubusercontent.com/u/10886961?v=4","gravatar_id":"","url":"https://api.github.com/users/rpetrusha","html_url":"https://github.com/rpetrusha","followers_url":"https://api.github.com/users/rpetrusha/followers","following_url":"https://api.github.com/users/rpetrusha/following{/other_user}","gists_url":"https://api.github.com/users/rpetrusha/gists{/gist_id}","starred_url":"https://api.github.com/users/rpetrusha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpetrusha/subscriptions","organizations_url":"https://api.github.com/users/rpetrusha/orgs","repos_url":"https://api.github.com/users/rpetrusha/repos","events_url":"https://api.github.com/users/rpetrusha/events{/privacy}","received_events_url":"https://api.github.com/users/rpetrusha/received_events","type":"User","site_admin":false},{"login":"mairaw","id":12971179,"node_id":"MDQ6VXNlcjEyOTcxMTc5","avatar_url":"https://avatars2.githubusercontent.com/u/12971179?v=4","gravatar_id":"","url":"https://api.github.com/users/mairaw","html_url":"https://github.com/mairaw","followers_url":"https://api.github.com/users/mairaw/followers","following_url":"https://api.github.com/users/mairaw/following{/other_user}","gists_url":"https://api.github.com/users/mairaw/gists{/gist_id}","starred_url":"https://api.github.com/users/mairaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mairaw/subscriptions","organizations_url":"https://api.github.com/users/mairaw/orgs","repos_url":"https://api.github.com/users/mairaw/repos","events_url":"https://api.github.com/users/mairaw/events{/privacy}","received_events_url":"https://api.github.com/users/mairaw/received_events","type":"User","site_admin":false},{"login":"Jozkee","id":16040868,"node_id":"MDQ6VXNlcjE2MDQwODY4","avatar_url":"https://avatars3.githubusercontent.com/u/16040868?v=4","gravatar_id":"","url":"https://api.github.com/users/Jozkee","html_url":"https://github.com/Jozkee","followers_url":"https://api.github.com/users/Jozkee/followers","following_url":"https://api.github.com/users/Jozkee/following{/other_user}","gists_url":"https://api.github.com/users/Jozkee/gists{/gist_id}","starred_url":"https://api.github.com/users/Jozkee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jozkee/subscriptions","organizations_url":"https://api.github.com/users/Jozkee/orgs","repos_url":"https://api.github.com/users/Jozkee/repos","events_url":"https://api.github.com/users/Jozkee/events{/privacy}","received_events_url":"https://api.github.com/users/Jozkee/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1141035603,"node_id":"MDU6TGFiZWwxMTQxMDM1NjAz","url":"https://api.github.com/repos/dotnet/dotnet-api-docs/labels/:checkered_flag:%20Release:%20.NET%20Core%203.0","name":":checkered_flag: Release: .NET Core 3.0","color":"f4b744","default":false},{"id":890227004,"node_id":"MDU6TGFiZWw4OTAyMjcwMDQ=","url":"https://api.github.com/repos/dotnet/dotnet-api-docs/labels/changes-addressed","name":"changes-addressed","color":"f9d0c4","default":false},{"id":890229862,"node_id":"MDU6TGFiZWw4OTAyMjk4NjI=","url":"https://api.github.com/repos/dotnet/dotnet-api-docs/labels/new-content","name":"new-content","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/dotnet-api-docs/milestones/24","html_url":"https://github.com/dotnet/dotnet-api-docs/milestone/24","labels_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/milestones/24/labels","id":4475283,"node_id":"MDk6TWlsZXN0b25lNDQ3NTI4Mw==","number":24,"title":"August 2019","description":"","creator":{"login":"mairaw","id":12971179,"node_id":"MDQ6VXNlcjEyOTcxMTc5","avatar_url":"https://avatars2.githubusercontent.com/u/12971179?v=4","gravatar_id":"","url":"https://api.github.com/users/mairaw","html_url":"https://github.com/mairaw","followers_url":"https://api.github.com/users/mairaw/followers","following_url":"https://api.github.com/users/mairaw/following{/other_user}","gists_url":"https://api.github.com/users/mairaw/gists{/gist_id}","starred_url":"https://api.github.com/users/mairaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mairaw/subscriptions","organizations_url":"https://api.github.com/users/mairaw/orgs","repos_url":"https://api.github.com/users/mairaw/repos","events_url":"https://api.github.com/users/mairaw/events{/privacy}","received_events_url":"https://api.github.com/users/mairaw/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":34,"state":"open","created_at":"2019-07-08T20:14:41Z","updated_at":"2019-08-02T20:10:42Z","due_on":"2019-09-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/pulls/2889/commits","review_comments_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/pulls/2889/comments","review_comment_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/issues/2889/comments","statuses_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/statuses/9ecb192eb4e6a0d37dee62dd739a83adc4878e5c","head":{"label":"carlossanlop:JsonConverter","ref":"JsonConverter","sha":"9ecb192eb4e6a0d37dee62dd739a83adc4878e5c","user":{"login":"carlossanlop","id":1175054,"node_id":"MDQ6VXNlcjExNzUwNTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1175054?v=4","gravatar_id":"","url":"https://api.github.com/users/carlossanlop","html_url":"https://github.com/carlossanlop","followers_url":"https://api.github.com/users/carlossanlop/followers","following_url":"https://api.github.com/users/carlossanlop/following{/other_user}","gists_url":"https://api.github.com/users/carlossanlop/gists{/gist_id}","starred_url":"https://api.github.com/users/carlossanlop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlossanlop/subscriptions","organizations_url":"https://api.github.com/users/carlossanlop/orgs","repos_url":"https://api.github.com/users/carlossanlop/repos","events_url":"https://api.github.com/users/carlossanlop/events{/privacy}","received_events_url":"https://api.github.com/users/carlossanlop/received_events","type":"User","site_admin":false},"repo":{"id":174235912,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQyMzU5MTI=","name":"dotnet-api-docs","full_name":"carlossanlop/dotnet-api-docs","private":false,"owner":{"login":"carlossanlop","id":1175054,"node_id":"MDQ6VXNlcjExNzUwNTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1175054?v=4","gravatar_id":"","url":"https://api.github.com/users/carlossanlop","html_url":"https://github.com/carlossanlop","followers_url":"https://api.github.com/users/carlossanlop/followers","following_url":"https://api.github.com/users/carlossanlop/following{/other_user}","gists_url":"https://api.github.com/users/carlossanlop/gists{/gist_id}","starred_url":"https://api.github.com/users/carlossanlop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlossanlop/subscriptions","organizations_url":"https://api.github.com/users/carlossanlop/orgs","repos_url":"https://api.github.com/users/carlossanlop/repos","events_url":"https://api.github.com/users/carlossanlop/events{/privacy}","received_events_url":"https://api.github.com/users/carlossanlop/received_events","type":"User","site_admin":false},"html_url":"https://github.com/carlossanlop/dotnet-api-docs","description":".NET API reference documentation (.NET Framework, .NET Core, .NET Standard and Xamarin)","fork":true,"url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs","forks_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/forks","keys_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/teams","hooks_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/hooks","issue_events_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/issues/events{/number}","events_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/events","assignees_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/assignees{/user}","branches_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/branches{/branch}","tags_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/tags","blobs_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/languages","stargazers_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/stargazers","contributors_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/contributors","subscribers_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/subscribers","subscription_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/subscription","commits_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/contents/{+path}","compare_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/merges","archive_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/downloads","issues_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/issues{/number}","pulls_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/labels{/name}","releases_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/releases{/id}","deployments_url":"https://api.github.com/repos/carlossanlop/dotnet-api-docs/deployments","created_at":"2019-03-06T23:19:40Z","updated_at":"2019-08-01T20:27:07Z","pushed_at":"2019-08-02T20:44:48Z","git_url":"git://github.com/carlossanlop/dotnet-api-docs.git","ssh_url":"[email protected]:carlossanlop/dotnet-api-docs.git","clone_url":"https://github.com/carlossanlop/dotnet-api-docs.git","svn_url":"https://github.com/carlossanlop/dotnet-api-docs","homepage":"https://docs.microsoft.com/dotnet/api/","size":443507,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5ed24c80b1426322b8ed5c4075cc8c699ecf5550","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":111510915,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE1MTA5MTU=","name":"dotnet-api-docs","full_name":"dotnet/dotnet-api-docs","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/dotnet-api-docs","description":".NET API reference documentation (.NET Framework, .NET Core, .NET Standard and Xamarin)","fork":false,"url":"https://api.github.com/repos/dotnet/dotnet-api-docs","forks_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/forks","keys_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/teams","hooks_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/hooks","issue_events_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/events","assignees_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/tags","blobs_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/languages","stargazers_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/stargazers","contributors_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/contributors","subscribers_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/subscribers","subscription_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/subscription","commits_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/merges","archive_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/downloads","issues_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/dotnet-api-docs/deployments","created_at":"2017-11-21T06:52:13Z","updated_at":"2019-08-02T15:25:36Z","pushed_at":"2019-08-02T20:44:50Z","git_url":"git://github.com/dotnet/dotnet-api-docs.git","ssh_url":"[email protected]:dotnet/dotnet-api-docs.git","clone_url":"https://github.com/dotnet/dotnet-api-docs.git","svn_url":"https://github.com/dotnet/dotnet-api-docs","homepage":"https://docs.microsoft.com/dotnet/api/","size":439518,"stargazers_count":98,"watchers_count":98,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":499,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":806,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":499,"open_issues":806,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/dotnet-api-docs/pulls/2889"},"html":{"href":"https://github.com/dotnet/dotnet-api-docs/pull/2889"},"issue":{"href":"https://api.github.com/repos/dotnet/dotnet-api-docs/issues/2889"},"comments":{"href":"https://api.github.com/repos/dotnet/dotnet-api-docs/issues/2889/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/dotnet-api-docs/pulls/2889/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/dotnet-api-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/dotnet-api-docs/pulls/2889/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/dotnet-api-docs/statuses/9ecb192eb4e6a0d37dee62dd739a83adc4878e5c"}},"author_association":"MEMBER"}}
|
{
"id": 111510915,
"name": "dotnet/dotnet-api-docs",
"url": "https://api.github.com/repos/dotnet/dotnet-api-docs"
}
|
{
"id": 6527137,
"login": "ahsonkhan",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6527137?",
"url": "https://api.github.com/users/ahsonkhan"
}
|
{
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
}
| 2019-08-02T20:51:51 |
10139385115
|
{"actor":{"display_login":"ahsonkhan"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/341744340","pull_request_review_id":310686911,"id":341744340,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM0MTc0NDM0MA==","diff_hunk":"@@ -60,7 +62,7 @@ public static void Example()\n IDataView testDataset = trainTestData.TestSet;\n \n var pipeline = mlContext.MulticlassClassification.Trainers\n- .ImageClassification(featureColumnName:\"Image\", validationSet:testDataset)\n+ .ImageClassification(featureColumnName:\"Image\", validationSet:null)","path":"docs/samples/Microsoft.ML.Samples/Dynamic/Trainers/MulticlassClassification/ImageClassification/ImageClassificationDefault.cs","position":21,"original_position":21,"commit_id":"9c2a9868cccb34da2dd3f39c51a34f603989cbbc","original_commit_id":"9c2a9868cccb34da2dd3f39c51a34f603989cbbc","user":{"login":"codemzs","id":1211949,"node_id":"MDQ6VXNlcjEyMTE5NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1211949?v=4","gravatar_id":"","url":"https://api.github.com/users/codemzs","html_url":"https://github.com/codemzs","followers_url":"https://api.github.com/users/codemzs/followers","following_url":"https://api.github.com/users/codemzs/following{/other_user}","gists_url":"https://api.github.com/users/codemzs/gists{/gist_id}","starred_url":"https://api.github.com/users/codemzs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codemzs/subscriptions","organizations_url":"https://api.github.com/users/codemzs/orgs","repos_url":"https://api.github.com/users/codemzs/repos","events_url":"https://api.github.com/users/codemzs/events{/privacy}","received_events_url":"https://api.github.com/users/codemzs/received_events","type":"User","site_admin":false},"body":">, validationSet:null [](start = 70, length = 20)\r\n\r\nno need, default is null.","created_at":"2019-11-01T20:44:14Z","updated_at":"2019-11-01T20:44:14Z","html_url":"https://github.com/dotnet/machinelearning/pull/4415#discussion_r341744340","pull_request_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/4415","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/341744340"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/4415#discussion_r341744340"},"pull_request":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/4415"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/4415","id":334421571,"node_id":"MDExOlB1bGxSZXF1ZXN0MzM0NDIxNTcx","html_url":"https://github.com/dotnet/machinelearning/pull/4415","diff_url":"https://github.com/dotnet/machinelearning/pull/4415.diff","patch_url":"https://github.com/dotnet/machinelearning/pull/4415.patch","issue_url":"https://api.github.com/repos/dotnet/machinelearning/issues/4415","number":4415,"state":"open","locked":false,"title":"Defaults for ImageClassification API","user":{"login":"harshithapv","id":54084812,"node_id":"MDQ6VXNlcjU0MDg0ODEy","avatar_url":"https://avatars2.githubusercontent.com/u/54084812?v=4","gravatar_id":"","url":"https://api.github.com/users/harshithapv","html_url":"https://github.com/harshithapv","followers_url":"https://api.github.com/users/harshithapv/followers","following_url":"https://api.github.com/users/harshithapv/following{/other_user}","gists_url":"https://api.github.com/users/harshithapv/gists{/gist_id}","starred_url":"https://api.github.com/users/harshithapv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshithapv/subscriptions","organizations_url":"https://api.github.com/users/harshithapv/orgs","repos_url":"https://api.github.com/users/harshithapv/repos","events_url":"https://api.github.com/users/harshithapv/events{/privacy}","received_events_url":"https://api.github.com/users/harshithapv/received_events","type":"User","site_admin":false},"body":"Changed EarlyStopping to run by default with ExponentialLR Decay for learning rate scheduling.\r\nThis combination seems to give most optimal results with a trade-off balance between the accuracy and training time.\r\n","created_at":"2019-10-30T17:52:54Z","updated_at":"2019-11-01T20:44:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13d8c3e31d90759d94e057eea67b4b2d738d99d2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/4415/commits","review_comments_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/4415/comments","review_comment_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/issues/4415/comments","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/9c2a9868cccb34da2dd3f39c51a34f603989cbbc","head":{"label":"harshithapv:ImageClassificationDefaults","ref":"ImageClassificationDefaults","sha":"9c2a9868cccb34da2dd3f39c51a34f603989cbbc","user":{"login":"harshithapv","id":54084812,"node_id":"MDQ6VXNlcjU0MDg0ODEy","avatar_url":"https://avatars2.githubusercontent.com/u/54084812?v=4","gravatar_id":"","url":"https://api.github.com/users/harshithapv","html_url":"https://github.com/harshithapv","followers_url":"https://api.github.com/users/harshithapv/followers","following_url":"https://api.github.com/users/harshithapv/following{/other_user}","gists_url":"https://api.github.com/users/harshithapv/gists{/gist_id}","starred_url":"https://api.github.com/users/harshithapv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshithapv/subscriptions","organizations_url":"https://api.github.com/users/harshithapv/orgs","repos_url":"https://api.github.com/users/harshithapv/repos","events_url":"https://api.github.com/users/harshithapv/events{/privacy}","received_events_url":"https://api.github.com/users/harshithapv/received_events","type":"User","site_admin":false},"repo":{"id":203855062,"node_id":"MDEwOlJlcG9zaXRvcnkyMDM4NTUwNjI=","name":"machinelearning","full_name":"harshithapv/machinelearning","private":false,"owner":{"login":"harshithapv","id":54084812,"node_id":"MDQ6VXNlcjU0MDg0ODEy","avatar_url":"https://avatars2.githubusercontent.com/u/54084812?v=4","gravatar_id":"","url":"https://api.github.com/users/harshithapv","html_url":"https://github.com/harshithapv","followers_url":"https://api.github.com/users/harshithapv/followers","following_url":"https://api.github.com/users/harshithapv/following{/other_user}","gists_url":"https://api.github.com/users/harshithapv/gists{/gist_id}","starred_url":"https://api.github.com/users/harshithapv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harshithapv/subscriptions","organizations_url":"https://api.github.com/users/harshithapv/orgs","repos_url":"https://api.github.com/users/harshithapv/repos","events_url":"https://api.github.com/users/harshithapv/events{/privacy}","received_events_url":"https://api.github.com/users/harshithapv/received_events","type":"User","site_admin":false},"html_url":"https://github.com/harshithapv/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":true,"url":"https://api.github.com/repos/harshithapv/machinelearning","forks_url":"https://api.github.com/repos/harshithapv/machinelearning/forks","keys_url":"https://api.github.com/repos/harshithapv/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harshithapv/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harshithapv/machinelearning/teams","hooks_url":"https://api.github.com/repos/harshithapv/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/harshithapv/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/harshithapv/machinelearning/events","assignees_url":"https://api.github.com/repos/harshithapv/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/harshithapv/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/harshithapv/machinelearning/tags","blobs_url":"https://api.github.com/repos/harshithapv/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harshithapv/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harshithapv/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/harshithapv/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harshithapv/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/harshithapv/machinelearning/languages","stargazers_url":"https://api.github.com/repos/harshithapv/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/harshithapv/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/harshithapv/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/harshithapv/machinelearning/subscription","commits_url":"https://api.github.com/repos/harshithapv/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/harshithapv/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/harshithapv/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/harshithapv/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/harshithapv/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/harshithapv/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harshithapv/machinelearning/merges","archive_url":"https://api.github.com/repos/harshithapv/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harshithapv/machinelearning/downloads","issues_url":"https://api.github.com/repos/harshithapv/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/harshithapv/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/harshithapv/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/harshithapv/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harshithapv/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/harshithapv/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/harshithapv/machinelearning/deployments","created_at":"2019-08-22T18:55:53Z","updated_at":"2019-11-01T19:03:53Z","pushed_at":"2019-11-01T20:25:13Z","git_url":"git://github.com/harshithapv/machinelearning.git","ssh_url":"[email protected]:harshithapv/machinelearning.git","clone_url":"https://github.com/harshithapv/machinelearning.git","svn_url":"https://github.com/harshithapv/machinelearning","homepage":"https://dot.net/ml","size":49867,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"f341ca337699708c87b25e8e987ab09be88a19e6","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":132021166,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMjExNjY=","name":"machinelearning","full_name":"dotnet/machinelearning","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":false,"url":"https://api.github.com/repos/dotnet/machinelearning","forks_url":"https://api.github.com/repos/dotnet/machinelearning/forks","keys_url":"https://api.github.com/repos/dotnet/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/machinelearning/teams","hooks_url":"https://api.github.com/repos/dotnet/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/dotnet/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/machinelearning/events","assignees_url":"https://api.github.com/repos/dotnet/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/machinelearning/tags","blobs_url":"https://api.github.com/repos/dotnet/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/machinelearning/languages","stargazers_url":"https://api.github.com/repos/dotnet/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/dotnet/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/dotnet/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/dotnet/machinelearning/subscription","commits_url":"https://api.github.com/repos/dotnet/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/machinelearning/merges","archive_url":"https://api.github.com/repos/dotnet/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/machinelearning/downloads","issues_url":"https://api.github.com/repos/dotnet/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/machinelearning/deployments","created_at":"2018-05-03T16:20:42Z","updated_at":"2019-11-01T20:36:59Z","pushed_at":"2019-11-01T20:25:15Z","git_url":"git://github.com/dotnet/machinelearning.git","ssh_url":"[email protected]:dotnet/machinelearning.git","clone_url":"https://github.com/dotnet/machinelearning.git","svn_url":"https://github.com/dotnet/machinelearning","homepage":"https://dot.net/ml","size":49924,"stargazers_count":6531,"watchers_count":6531,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1377,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":531,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1377,"open_issues":531,"watchers":6531,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/4415"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/4415"},"issue":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/4415"},"comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/4415/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/4415/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/4415/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/machinelearning/statuses/9c2a9868cccb34da2dd3f39c51a34f603989cbbc"}},"author_association":"MEMBER"}}
|
{
"id": 132021166,
"name": "dotnet/machinelearning",
"url": "https://api.github.com/repos/dotnet/machinelearning"
}
|
{
"id": 1211949,
"login": "codemzs",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1211949?",
"url": "https://api.github.com/users/codemzs"
}
|
{
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
}
| 2019-11-01T20:44:14 |
10769453153
|
{"actor":{"display_login":"codemzs"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/iot/pulls/comments/258283115","pull_request_review_id":205517143,"id":258283115,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1ODI4MzExNQ==","diff_hunk":"@@ -0,0 +1,14 @@\n+// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+// See the LICENSE file in the project root for more information.\n+\n+namespace Iot.Device","path":"src/devices/things/ITemperatureSensor.cs","position":5,"original_position":5,"commit_id":"d2ae1ca88ffa83307d49c07754374d9cee9fef8d","original_commit_id":"d2ae1ca88ffa83307d49c07754374d9cee9fef8d","user":{"login":"krwq","id":660048,"node_id":"MDQ6VXNlcjY2MDA0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/660048?v=4","gravatar_id":"","url":"https://api.github.com/users/krwq","html_url":"https://github.com/krwq","followers_url":"https://api.github.com/users/krwq/followers","following_url":"https://api.github.com/users/krwq/following{/other_user}","gists_url":"https://api.github.com/users/krwq/gists{/gist_id}","starred_url":"https://api.github.com/users/krwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krwq/subscriptions","organizations_url":"https://api.github.com/users/krwq/orgs","repos_url":"https://api.github.com/users/krwq/repos","events_url":"https://api.github.com/users/krwq/events{/privacy}","received_events_url":"https://api.github.com/users/krwq/received_events","type":"User","site_admin":false},"body":"https://github.com/dotnet/iot/issues/258","created_at":"2019-02-20T00:02:25Z","updated_at":"2019-02-20T00:02:25Z","html_url":"https://github.com/dotnet/iot/pull/256#discussion_r258283115","pull_request_url":"https://api.github.com/repos/dotnet/iot/pulls/256","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/iot/pulls/comments/258283115"},"html":{"href":"https://github.com/dotnet/iot/pull/256#discussion_r258283115"},"pull_request":{"href":"https://api.github.com/repos/dotnet/iot/pulls/256"}},"in_reply_to_id":257935439},"pull_request":{"url":"https://api.github.com/repos/dotnet/iot/pulls/256","id":254159884,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0MTU5ODg0","html_url":"https://github.com/dotnet/iot/pull/256","diff_url":"https://github.com/dotnet/iot/pull/256.diff","patch_url":"https://github.com/dotnet/iot/pull/256.patch","issue_url":"https://api.github.com/repos/dotnet/iot/issues/256","number":256,"state":"open","locked":false,"title":"T - things","user":{"login":"krwq","id":660048,"node_id":"MDQ6VXNlcjY2MDA0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/660048?v=4","gravatar_id":"","url":"https://api.github.com/users/krwq","html_url":"https://github.com/krwq","followers_url":"https://api.github.com/users/krwq/followers","following_url":"https://api.github.com/users/krwq/following{/other_user}","gists_url":"https://api.github.com/users/krwq/gists{/gist_id}","starred_url":"https://api.github.com/users/krwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krwq/subscriptions","organizations_url":"https://api.github.com/users/krwq/orgs","repos_url":"https://api.github.com/users/krwq/repos","events_url":"https://api.github.com/users/krwq/events{/privacy}","received_events_url":"https://api.github.com/users/krwq/received_events","type":"User","site_admin":false},"body":"I've created a stub for repo with abstraction for sensors. I wanted to start to standardize naming and conventions through this interfaces\r\n\r\nRight now only added temperature - please let me know if I should go further with this or if this is a bad idea.\r\n\r\nFeels like it is better to discuss on the interface rather than in the issue.\r\n\r\n@joperezr @JeremyKuhne @shaggygi @ZhangGaoxing @Ellerbach ","created_at":"2019-02-19T08:37:13Z","updated_at":"2019-02-20T00:02:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd9f69f2bfc31c36a84f20ea7c5c45e5ba75f5a8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/iot/pulls/256/commits","review_comments_url":"https://api.github.com/repos/dotnet/iot/pulls/256/comments","review_comment_url":"https://api.github.com/repos/dotnet/iot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/iot/issues/256/comments","statuses_url":"https://api.github.com/repos/dotnet/iot/statuses/d2ae1ca88ffa83307d49c07754374d9cee9fef8d","head":{"label":"krwq:device-abstraction","ref":"device-abstraction","sha":"d2ae1ca88ffa83307d49c07754374d9cee9fef8d","user":{"login":"krwq","id":660048,"node_id":"MDQ6VXNlcjY2MDA0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/660048?v=4","gravatar_id":"","url":"https://api.github.com/users/krwq","html_url":"https://github.com/krwq","followers_url":"https://api.github.com/users/krwq/followers","following_url":"https://api.github.com/users/krwq/following{/other_user}","gists_url":"https://api.github.com/users/krwq/gists{/gist_id}","starred_url":"https://api.github.com/users/krwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krwq/subscriptions","organizations_url":"https://api.github.com/users/krwq/orgs","repos_url":"https://api.github.com/users/krwq/repos","events_url":"https://api.github.com/users/krwq/events{/privacy}","received_events_url":"https://api.github.com/users/krwq/received_events","type":"User","site_admin":false},"repo":{"id":160408786,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA0MDg3ODY=","name":"iot","full_name":"krwq/iot","private":false,"owner":{"login":"krwq","id":660048,"node_id":"MDQ6VXNlcjY2MDA0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/660048?v=4","gravatar_id":"","url":"https://api.github.com/users/krwq","html_url":"https://github.com/krwq","followers_url":"https://api.github.com/users/krwq/followers","following_url":"https://api.github.com/users/krwq/following{/other_user}","gists_url":"https://api.github.com/users/krwq/gists{/gist_id}","starred_url":"https://api.github.com/users/krwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krwq/subscriptions","organizations_url":"https://api.github.com/users/krwq/orgs","repos_url":"https://api.github.com/users/krwq/repos","events_url":"https://api.github.com/users/krwq/events{/privacy}","received_events_url":"https://api.github.com/users/krwq/received_events","type":"User","site_admin":false},"html_url":"https://github.com/krwq/iot","description":"This repo includes .NET Core implementations for various IoT boards, chips, displays and PCBs.","fork":true,"url":"https://api.github.com/repos/krwq/iot","forks_url":"https://api.github.com/repos/krwq/iot/forks","keys_url":"https://api.github.com/repos/krwq/iot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krwq/iot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krwq/iot/teams","hooks_url":"https://api.github.com/repos/krwq/iot/hooks","issue_events_url":"https://api.github.com/repos/krwq/iot/issues/events{/number}","events_url":"https://api.github.com/repos/krwq/iot/events","assignees_url":"https://api.github.com/repos/krwq/iot/assignees{/user}","branches_url":"https://api.github.com/repos/krwq/iot/branches{/branch}","tags_url":"https://api.github.com/repos/krwq/iot/tags","blobs_url":"https://api.github.com/repos/krwq/iot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krwq/iot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krwq/iot/git/refs{/sha}","trees_url":"https://api.github.com/repos/krwq/iot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krwq/iot/statuses/{sha}","languages_url":"https://api.github.com/repos/krwq/iot/languages","stargazers_url":"https://api.github.com/repos/krwq/iot/stargazers","contributors_url":"https://api.github.com/repos/krwq/iot/contributors","subscribers_url":"https://api.github.com/repos/krwq/iot/subscribers","subscription_url":"https://api.github.com/repos/krwq/iot/subscription","commits_url":"https://api.github.com/repos/krwq/iot/commits{/sha}","git_commits_url":"https://api.github.com/repos/krwq/iot/git/commits{/sha}","comments_url":"https://api.github.com/repos/krwq/iot/comments{/number}","issue_comment_url":"https://api.github.com/repos/krwq/iot/issues/comments{/number}","contents_url":"https://api.github.com/repos/krwq/iot/contents/{+path}","compare_url":"https://api.github.com/repos/krwq/iot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krwq/iot/merges","archive_url":"https://api.github.com/repos/krwq/iot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krwq/iot/downloads","issues_url":"https://api.github.com/repos/krwq/iot/issues{/number}","pulls_url":"https://api.github.com/repos/krwq/iot/pulls{/number}","milestones_url":"https://api.github.com/repos/krwq/iot/milestones{/number}","notifications_url":"https://api.github.com/repos/krwq/iot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krwq/iot/labels{/name}","releases_url":"https://api.github.com/repos/krwq/iot/releases{/id}","deployments_url":"https://api.github.com/repos/krwq/iot/deployments","created_at":"2018-12-04T19:33:29Z","updated_at":"2018-12-04T19:33:31Z","pushed_at":"2019-02-19T08:35:31Z","git_url":"git://github.com/krwq/iot.git","ssh_url":"[email protected]:krwq/iot.git","clone_url":"https://github.com/krwq/iot.git","svn_url":"https://github.com/krwq/iot","homepage":"","size":25666,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"5dd33505de645e61fb23bebce9472afd2502c60e","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":151623607,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE2MjM2MDc=","name":"iot","full_name":"dotnet/iot","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/iot","description":"This repo includes .NET Core implementations for various IoT boards, chips, displays and PCBs.","fork":false,"url":"https://api.github.com/repos/dotnet/iot","forks_url":"https://api.github.com/repos/dotnet/iot/forks","keys_url":"https://api.github.com/repos/dotnet/iot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/iot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/iot/teams","hooks_url":"https://api.github.com/repos/dotnet/iot/hooks","issue_events_url":"https://api.github.com/repos/dotnet/iot/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/iot/events","assignees_url":"https://api.github.com/repos/dotnet/iot/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/iot/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/iot/tags","blobs_url":"https://api.github.com/repos/dotnet/iot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/iot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/iot/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/iot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/iot/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/iot/languages","stargazers_url":"https://api.github.com/repos/dotnet/iot/stargazers","contributors_url":"https://api.github.com/repos/dotnet/iot/contributors","subscribers_url":"https://api.github.com/repos/dotnet/iot/subscribers","subscription_url":"https://api.github.com/repos/dotnet/iot/subscription","commits_url":"https://api.github.com/repos/dotnet/iot/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/iot/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/iot/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/iot/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/iot/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/iot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/iot/merges","archive_url":"https://api.github.com/repos/dotnet/iot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/iot/downloads","issues_url":"https://api.github.com/repos/dotnet/iot/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/iot/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/iot/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/iot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/iot/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/iot/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/iot/deployments","created_at":"2018-10-04T19:15:33Z","updated_at":"2019-02-19T23:23:56Z","pushed_at":"2019-02-19T23:23:53Z","git_url":"git://github.com/dotnet/iot.git","ssh_url":"[email protected]:dotnet/iot.git","clone_url":"https://github.com/dotnet/iot.git","svn_url":"https://github.com/dotnet/iot","homepage":"","size":29016,"stargazers_count":266,"watchers_count":266,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":46,"open_issues":88,"watchers":266,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/iot/pulls/256"},"html":{"href":"https://github.com/dotnet/iot/pull/256"},"issue":{"href":"https://api.github.com/repos/dotnet/iot/issues/256"},"comments":{"href":"https://api.github.com/repos/dotnet/iot/issues/256/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/iot/pulls/256/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/iot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/iot/pulls/256/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/iot/statuses/d2ae1ca88ffa83307d49c07754374d9cee9fef8d"}},"author_association":"MEMBER"}}
|
{
"id": 151623607,
"name": "dotnet/iot",
"url": "https://api.github.com/repos/dotnet/iot"
}
|
{
"id": 660048,
"login": "krwq",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/660048?",
"url": "https://api.github.com/users/krwq"
}
|
{
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
}
| 2019-02-20T00:02:25 |
9098459380
|
{"actor":{"display_login":"krwq"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/296944433","pull_request_review_id":253693933,"id":296944433,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI5Njk0NDQzMw==","diff_hunk":"@@ -64,7 +64,22 @@ public static Workspace GetWorkspace(this ITextBuffer buffer)\n /// updated to contain the same text as the snapshot if necessary. There may be multiple <see cref=\"Document\"/>s associated with the buffer\n /// if the file is linked into multiple projects or is part of a Shared Project.\n /// </summary>\n+ [Obsolete(\"Use GetDocuments instead\")]","path":"src/EditorFeatures/Text/Extensions.cs","position":4,"original_position":4,"commit_id":"884b6bbcc1dc7d00abae358f648a5672163d2c6a","original_commit_id":"884b6bbcc1dc7d00abae358f648a5672163d2c6a","user":{"login":"jasonmalinowski","id":201340,"node_id":"MDQ6VXNlcjIwMTM0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/201340?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonmalinowski","html_url":"https://github.com/jasonmalinowski","followers_url":"https://api.github.com/users/jasonmalinowski/followers","following_url":"https://api.github.com/users/jasonmalinowski/following{/other_user}","gists_url":"https://api.github.com/users/jasonmalinowski/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonmalinowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonmalinowski/subscriptions","organizations_url":"https://api.github.com/users/jasonmalinowski/orgs","repos_url":"https://api.github.com/users/jasonmalinowski/repos","events_url":"https://api.github.com/users/jasonmalinowski/events{/privacy}","received_events_url":"https://api.github.com/users/jasonmalinowski/received_events","type":"User","site_admin":false},"body":"Why would you not obsolete this one?","created_at":"2019-06-24T22:42:21Z","updated_at":"2019-06-24T22:43:08Z","html_url":"https://github.com/dotnet/roslyn/pull/36711#discussion_r296944433","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/36711","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/296944433"},"html":{"href":"https://github.com/dotnet/roslyn/pull/36711#discussion_r296944433"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/36711"}},"in_reply_to_id":296889042},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/36711","id":291273300,"node_id":"MDExOlB1bGxSZXF1ZXN0MjkxMjczMzAw","html_url":"https://github.com/dotnet/roslyn/pull/36711","diff_url":"https://github.com/dotnet/roslyn/pull/36711.diff","patch_url":"https://github.com/dotnet/roslyn/pull/36711.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/36711","number":36711,"state":"open","locked":false,"title":"Expose better named extension points to go from ITextSnapshot->Document","user":{"login":"CyrusNajmabadi","id":4564579,"node_id":"MDQ6VXNlcjQ1NjQ1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4564579?v=4","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"body":"I thought i created this PR already, but i couldn't actually find it.\r\n\r\nThis PR adds to nicer named extensions for mapping from an ITextSnapshot to a Document or Documents. Instead of:\r\n\r\n`GetOpenDocumentInCurrentContextWithChanges` and\r\n`GetRelatedDocumentsWithChanges` there is now simply:\r\n\r\n1. `GetDocument`\r\n2. `GetDocuments`\r\n\r\nReasons for the change: the above members were wordy in a way that wasn't really helpful. First, `WithChanges` is rather meaningless and pointless in the Roslyn world. There isn't a way to get documents 'without changes', and in our immutable world, why would there ever be an expectation that you would ever be getting a Document that didn't match exactly the text of the snapshot you were asking about? Second 'current context' is also meaningless. 'context' is not a roslyn concept and isn't really clear at all about what it would mean. What is the \"current context\" what would it mean to get a document not in that context? It's also a word (like \"provider\" or \"service\") that doesn't really add anything.\r\n\r\nThere are really only two scenarios here. One is simple, and is the majority case for customers, and one is slightly advanced, but necessary for some people. Specifically, almost all customers simply want to get from their ITextSnapshot the user is editing to a Document. That is now simply done as `GetDocument`. Some customers need to handle the very advanced case of this being a linked/shared doc, in which case they can call `GetDocuments`. Both methods explain their purpose and link to each other, stating why you'd want one over the other.\r\n\r\n","created_at":"2019-06-24T19:54:53Z","updated_at":"2019-06-24T22:43:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3a258b1ba8ef6767a609dbf21a272e55d6835fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/36711/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/36711/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/36711/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/884b6bbcc1dc7d00abae358f648a5672163d2c6a","head":{"label":"CyrusNajmabadi:getDocument","ref":"getDocument","sha":"884b6bbcc1dc7d00abae358f648a5672163d2c6a","user":{"login":"CyrusNajmabadi","id":4564579,"node_id":"MDQ6VXNlcjQ1NjQ1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4564579?v=4","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"repo":{"id":30565155,"node_id":"MDEwOlJlcG9zaXRvcnkzMDU2NTE1NQ==","name":"roslyn","full_name":"CyrusNajmabadi/roslyn","private":false,"owner":{"login":"CyrusNajmabadi","id":4564579,"node_id":"MDQ6VXNlcjQ1NjQ1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4564579?v=4","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/CyrusNajmabadi/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/CyrusNajmabadi/roslyn","forks_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/forks","keys_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/teams","hooks_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/hooks","issue_events_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/events","assignees_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/tags","blobs_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/languages","stargazers_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/stargazers","contributors_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/contributors","subscribers_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/subscribers","subscription_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/subscription","commits_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/merges","archive_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/downloads","issues_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/CyrusNajmabadi/roslyn/deployments","created_at":"2015-02-09T23:45:22Z","updated_at":"2019-01-02T19:19:10Z","pushed_at":"2019-06-24T20:09:13Z","git_url":"git://github.com/CyrusNajmabadi/roslyn.git","ssh_url":"[email protected]:CyrusNajmabadi/roslyn.git","clone_url":"https://github.com/CyrusNajmabadi/roslyn.git","svn_url":"https://github.com/CyrusNajmabadi/roslyn","homepage":"","size":642884,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"53435a8b7bbfd0e0f9589b69b54fddb555d7bcdd","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3ODk5Nw==","name":"roslyn","full_name":"dotnet/roslyn","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/roslyn","description":"The Roslyn .NET compiler provides C# and Visual Basic languages with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2019-06-24T22:15:02Z","pushed_at":"2019-06-24T22:42:11Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"[email protected]:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/","size":662854,"stargazers_count":11505,"watchers_count":11505,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2675,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6151,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2675,"open_issues":6151,"watchers":11505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/36711"},"html":{"href":"https://github.com/dotnet/roslyn/pull/36711"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/36711"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/36711/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/36711/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/36711/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/884b6bbcc1dc7d00abae358f648a5672163d2c6a"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 29078997,
"name": "dotnet/roslyn",
"url": "https://api.github.com/repos/dotnet/roslyn"
}
|
{
"id": 201340,
"login": "jasonmalinowski",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/201340?",
"url": "https://api.github.com/users/jasonmalinowski"
}
|
{
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
}
| 2019-06-24T22:42:21 |
9884592080
|
{"actor":{"display_login":"jasonmalinowski"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/iot/pulls/comments/253204647","pull_request_review_id":199273499,"id":253204647,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1MzIwNDY0Nw==","diff_hunk":"@@ -0,0 +1,156 @@\n+// Licensed to the .NET Foundation under one or more agreements.\n+// The .NET Foundation licenses this file to you under the MIT license.\n+// See the LICENSE file in the project root for more information.\n+\n+using System;\n+using System.Device.Gpio;\n+using System.Device.I2c;","path":"src/devices/Fsr408/Fsr408.cs","position":7,"original_position":7,"commit_id":"f67a588945c5982dc2e4e8101e46d4305876e939","original_commit_id":"f67a588945c5982dc2e4e8101e46d4305876e939","user":{"login":"krwq","id":660048,"node_id":"MDQ6VXNlcjY2MDA0OA==","avatar_url":"https://avatars1.githubusercontent.com/u/660048?v=4","gravatar_id":"","url":"https://api.github.com/users/krwq","html_url":"https://github.com/krwq","followers_url":"https://api.github.com/users/krwq/followers","following_url":"https://api.github.com/users/krwq/following{/other_user}","gists_url":"https://api.github.com/users/krwq/gists{/gist_id}","starred_url":"https://api.github.com/users/krwq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krwq/subscriptions","organizations_url":"https://api.github.com/users/krwq/orgs","repos_url":"https://api.github.com/users/krwq/repos","events_url":"https://api.github.com/users/krwq/events{/privacy}","received_events_url":"https://api.github.com/users/krwq/received_events","type":"User","site_admin":false},"body":"I think you can remove I2c/Spi stuff from the usings","created_at":"2019-02-01T21:23:03Z","updated_at":"2019-02-01T21:23:03Z","html_url":"https://github.com/dotnet/iot/pull/198#discussion_r253204647","pull_request_url":"https://api.github.com/repos/dotnet/iot/pulls/198","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/iot/pulls/comments/253204647"},"html":{"href":"https://github.com/dotnet/iot/pull/198#discussion_r253204647"},"pull_request":{"href":"https://api.github.com/repos/dotnet/iot/pulls/198"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/iot/pulls/198","id":249722125,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQ5NzIyMTI1","html_url":"https://github.com/dotnet/iot/pull/198","diff_url":"https://github.com/dotnet/iot/pull/198.diff","patch_url":"https://github.com/dotnet/iot/pull/198.patch","issue_url":"https://api.github.com/repos/dotnet/iot/issues/198","number":198,"state":"open","locked":false,"title":"FSR binding initial version for review #169","user":{"login":"buyaa-n","id":45579687,"node_id":"MDQ6VXNlcjQ1NTc5Njg3","avatar_url":"https://avatars0.githubusercontent.com/u/45579687?v=4","gravatar_id":"","url":"https://api.github.com/users/buyaa-n","html_url":"https://github.com/buyaa-n","followers_url":"https://api.github.com/users/buyaa-n/followers","following_url":"https://api.github.com/users/buyaa-n/following{/other_user}","gists_url":"https://api.github.com/users/buyaa-n/gists{/gist_id}","starred_url":"https://api.github.com/users/buyaa-n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buyaa-n/subscriptions","organizations_url":"https://api.github.com/users/buyaa-n/orgs","repos_url":"https://api.github.com/users/buyaa-n/repos","events_url":"https://api.github.com/users/buyaa-n/events{/privacy}","received_events_url":"https://api.github.com/users/buyaa-n/received_events","type":"User","site_admin":false},"body":"There were nothing much to bind as it has pretty simple functionality. It produces analog signal and just using controller with analog input or using ADC controller for reading that signal is enough. So added some methods for calculating output voltage, resistance, force from read value. Maybe this binding more about demonstrating sample usage. Documentation is not complete, wanted to get some suggestion/review before finalizing doc","created_at":"2019-02-01T20:11:20Z","updated_at":"2019-02-01T21:23:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"598f0dba800014e2fc77ec1d9476a82564a49c13","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1151698609,"node_id":"MDU6TGFiZWwxMTUxNjk4NjA5","url":"https://api.github.com/repos/dotnet/iot/labels/*%20NO%20MERGE%20*","name":"* NO MERGE *","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/iot/pulls/198/commits","review_comments_url":"https://api.github.com/repos/dotnet/iot/pulls/198/comments","review_comment_url":"https://api.github.com/repos/dotnet/iot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/iot/issues/198/comments","statuses_url":"https://api.github.com/repos/dotnet/iot/statuses/f67a588945c5982dc2e4e8101e46d4305876e939","head":{"label":"buyaa-n:FSR_408_binding","ref":"FSR_408_binding","sha":"f67a588945c5982dc2e4e8101e46d4305876e939","user":{"login":"buyaa-n","id":45579687,"node_id":"MDQ6VXNlcjQ1NTc5Njg3","avatar_url":"https://avatars0.githubusercontent.com/u/45579687?v=4","gravatar_id":"","url":"https://api.github.com/users/buyaa-n","html_url":"https://github.com/buyaa-n","followers_url":"https://api.github.com/users/buyaa-n/followers","following_url":"https://api.github.com/users/buyaa-n/following{/other_user}","gists_url":"https://api.github.com/users/buyaa-n/gists{/gist_id}","starred_url":"https://api.github.com/users/buyaa-n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buyaa-n/subscriptions","organizations_url":"https://api.github.com/users/buyaa-n/orgs","repos_url":"https://api.github.com/users/buyaa-n/repos","events_url":"https://api.github.com/users/buyaa-n/events{/privacy}","received_events_url":"https://api.github.com/users/buyaa-n/received_events","type":"User","site_admin":false},"repo":{"id":160405001,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA0MDUwMDE=","name":"iot","full_name":"buyaa-n/iot","private":false,"owner":{"login":"buyaa-n","id":45579687,"node_id":"MDQ6VXNlcjQ1NTc5Njg3","avatar_url":"https://avatars0.githubusercontent.com/u/45579687?v=4","gravatar_id":"","url":"https://api.github.com/users/buyaa-n","html_url":"https://github.com/buyaa-n","followers_url":"https://api.github.com/users/buyaa-n/followers","following_url":"https://api.github.com/users/buyaa-n/following{/other_user}","gists_url":"https://api.github.com/users/buyaa-n/gists{/gist_id}","starred_url":"https://api.github.com/users/buyaa-n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buyaa-n/subscriptions","organizations_url":"https://api.github.com/users/buyaa-n/orgs","repos_url":"https://api.github.com/users/buyaa-n/repos","events_url":"https://api.github.com/users/buyaa-n/events{/privacy}","received_events_url":"https://api.github.com/users/buyaa-n/received_events","type":"User","site_admin":false},"html_url":"https://github.com/buyaa-n/iot","description":"This repo includes .NET Core implementations for various IoT boards, chips, displays and PCBs.","fork":true,"url":"https://api.github.com/repos/buyaa-n/iot","forks_url":"https://api.github.com/repos/buyaa-n/iot/forks","keys_url":"https://api.github.com/repos/buyaa-n/iot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buyaa-n/iot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buyaa-n/iot/teams","hooks_url":"https://api.github.com/repos/buyaa-n/iot/hooks","issue_events_url":"https://api.github.com/repos/buyaa-n/iot/issues/events{/number}","events_url":"https://api.github.com/repos/buyaa-n/iot/events","assignees_url":"https://api.github.com/repos/buyaa-n/iot/assignees{/user}","branches_url":"https://api.github.com/repos/buyaa-n/iot/branches{/branch}","tags_url":"https://api.github.com/repos/buyaa-n/iot/tags","blobs_url":"https://api.github.com/repos/buyaa-n/iot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buyaa-n/iot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buyaa-n/iot/git/refs{/sha}","trees_url":"https://api.github.com/repos/buyaa-n/iot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buyaa-n/iot/statuses/{sha}","languages_url":"https://api.github.com/repos/buyaa-n/iot/languages","stargazers_url":"https://api.github.com/repos/buyaa-n/iot/stargazers","contributors_url":"https://api.github.com/repos/buyaa-n/iot/contributors","subscribers_url":"https://api.github.com/repos/buyaa-n/iot/subscribers","subscription_url":"https://api.github.com/repos/buyaa-n/iot/subscription","commits_url":"https://api.github.com/repos/buyaa-n/iot/commits{/sha}","git_commits_url":"https://api.github.com/repos/buyaa-n/iot/git/commits{/sha}","comments_url":"https://api.github.com/repos/buyaa-n/iot/comments{/number}","issue_comment_url":"https://api.github.com/repos/buyaa-n/iot/issues/comments{/number}","contents_url":"https://api.github.com/repos/buyaa-n/iot/contents/{+path}","compare_url":"https://api.github.com/repos/buyaa-n/iot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buyaa-n/iot/merges","archive_url":"https://api.github.com/repos/buyaa-n/iot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buyaa-n/iot/downloads","issues_url":"https://api.github.com/repos/buyaa-n/iot/issues{/number}","pulls_url":"https://api.github.com/repos/buyaa-n/iot/pulls{/number}","milestones_url":"https://api.github.com/repos/buyaa-n/iot/milestones{/number}","notifications_url":"https://api.github.com/repos/buyaa-n/iot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buyaa-n/iot/labels{/name}","releases_url":"https://api.github.com/repos/buyaa-n/iot/releases{/id}","deployments_url":"https://api.github.com/repos/buyaa-n/iot/deployments","created_at":"2018-12-04T18:59:31Z","updated_at":"2018-12-04T18:59:33Z","pushed_at":"2019-02-01T19:48:28Z","git_url":"git://github.com/buyaa-n/iot.git","ssh_url":"[email protected]:buyaa-n/iot.git","clone_url":"https://github.com/buyaa-n/iot.git","svn_url":"https://github.com/buyaa-n/iot","homepage":"","size":7474,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"ac4a5c0368530be51e8a2d326426c3044003647a","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":151623607,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE2MjM2MDc=","name":"iot","full_name":"dotnet/iot","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/iot","description":"This repo includes .NET Core implementations for various IoT boards, chips, displays and PCBs.","fork":false,"url":"https://api.github.com/repos/dotnet/iot","forks_url":"https://api.github.com/repos/dotnet/iot/forks","keys_url":"https://api.github.com/repos/dotnet/iot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/iot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/iot/teams","hooks_url":"https://api.github.com/repos/dotnet/iot/hooks","issue_events_url":"https://api.github.com/repos/dotnet/iot/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/iot/events","assignees_url":"https://api.github.com/repos/dotnet/iot/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/iot/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/iot/tags","blobs_url":"https://api.github.com/repos/dotnet/iot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/iot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/iot/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/iot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/iot/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/iot/languages","stargazers_url":"https://api.github.com/repos/dotnet/iot/stargazers","contributors_url":"https://api.github.com/repos/dotnet/iot/contributors","subscribers_url":"https://api.github.com/repos/dotnet/iot/subscribers","subscription_url":"https://api.github.com/repos/dotnet/iot/subscription","commits_url":"https://api.github.com/repos/dotnet/iot/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/iot/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/iot/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/iot/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/iot/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/iot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/iot/merges","archive_url":"https://api.github.com/repos/dotnet/iot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/iot/downloads","issues_url":"https://api.github.com/repos/dotnet/iot/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/iot/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/iot/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/iot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/iot/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/iot/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/iot/deployments","created_at":"2018-10-04T19:15:33Z","updated_at":"2019-02-01T18:23:01Z","pushed_at":"2019-02-01T20:11:20Z","git_url":"git://github.com/dotnet/iot.git","ssh_url":"[email protected]:dotnet/iot.git","clone_url":"https://github.com/dotnet/iot.git","svn_url":"https://github.com/dotnet/iot","homepage":"","size":7435,"stargazers_count":237,"watchers_count":237,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":35,"open_issues":75,"watchers":237,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/iot/pulls/198"},"html":{"href":"https://github.com/dotnet/iot/pull/198"},"issue":{"href":"https://api.github.com/repos/dotnet/iot/issues/198"},"comments":{"href":"https://api.github.com/repos/dotnet/iot/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/iot/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/iot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/iot/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/iot/statuses/f67a588945c5982dc2e4e8101e46d4305876e939"}},"author_association":"MEMBER"}}
|
{
"id": 151623607,
"name": "dotnet/iot",
"url": "https://api.github.com/repos/dotnet/iot"
}
|
{
"id": 660048,
"login": "krwq",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/660048?",
"url": "https://api.github.com/users/krwq"
}
|
{
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
}
| 2019-02-01T21:23:03 |
8995547116
|
{"actor":{"display_login":"krwq"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/runtime/pulls/comments/365435912","pull_request_review_id":341429794,"id":365435912,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM2NTQzNTkxMg==","diff_hunk":"@@ -126,5 +147,112 @@ public static partial class JsonSerializer\n \n // We don't add the value to the dictionary here because we need to support the read-ahead functionality for Streams.\n }\n+\n+ private static MetadataPropertyName GetMetadataProperty(ReadOnlySpan<byte> propertyName, ref ReadStack state, ref Utf8JsonReader reader)\n+ {\n+ if (state.Current.ShouldHandleReference)\n+ {\n+ ThrowHelper.ThrowJsonException_MetadataReferenceObjectCannotContainOtherProperties();\n+ }\n+\n+ MetadataPropertyName metadata = GetMetadataPropertyName(propertyName, ref state, ref reader);\n+ state.Current.MetadataProperty = metadata;\n+ return metadata;\n+ }\n+\n+ private static void ResolveMetadataOnDictionary(MetadataPropertyName metadata, ref ReadStack state)\n+ {\n+ bool isPreserved = state.Current.IsProcessingProperty(ClassType.Dictionary) ?\n+ state.Current.DictionaryPropertyIsPreserved : state.Current.IsPreserved;\n+\n+ if (metadata == MetadataPropertyName.Id)\n+ {\n+ // Check we are not parsing into immutable.\n+ if (state.Current.TempDictionaryValues != null)\n+ {\n+ ThrowHelper.ThrowJsonException_MetadataCannotParsePreservedObjectIntoImmutable(state.Current.JsonPropertyInfo!.DeclaredPropertyType);\n+ }\n+\n+ if (state.Current.KeyName != null || isPreserved)\n+ {\n+ state.Current.KeyName = null;\n+ ThrowHelper.ThrowJsonException_MetadataIdIsNotFirstProperty();\n+ }\n+\n+ MarkAsPreserved(ref state.Current);\n+ state.Current.ReadMetadataValue = true;\n+ }\n+ else if (metadata == MetadataPropertyName.Ref)\n+ {\n+ if (state.Current.KeyName != null || isPreserved)\n+ {\n+ state.Current.KeyName = null;\n+ ThrowHelper.ThrowJsonException_MetadataReferenceObjectCannotContainOtherProperties();\n+ }\n+\n+ state.Current.ShouldHandleReference = true;\n+ state.Current.ReadMetadataValue = true;\n+ }\n+ }\n+\n+ private static void ResolveMetadataOnObject(ReadOnlySpan<byte> propertyName, MetadataPropertyName meta, ref ReadStack state, ref Utf8JsonReader reader, JsonSerializerOptions options)\n+ {\n+ if (meta == MetadataPropertyName.NoMetadata)\n+ {\n+ if (state.Current.IsPreservedArray)\n+ {\n+ ThrowHelper.ThrowJsonException_MetadataPreservedArrayInvalidProperty(state.Current.JsonClassInfo!.PropertyCache![\"Values\"].DeclaredPropertyType);\n+ }\n+ // Regular property, call main logic for HandlePropertyName.\n+ HandlePropertyNameDefault(propertyName, ref state, ref reader, options);\n+ }\n+ else if (meta == MetadataPropertyName.Id)\n+ {\n+ if (state.Current.PropertyIndex > 0 || state.Current.IsPreserved)\n+ {\n+ ThrowHelper.ThrowJsonException_MetadataIdIsNotFirstProperty();\n+ }\n+\n+ JsonPropertyInfo info = JsonPropertyInfo.s_metadataProperty;\n+ info.JsonPropertyName = propertyName.ToArray();\n+ state.Current.JsonPropertyInfo = info;\n+\n+ state.Current.ReadMetadataValue = true;\n+ MarkAsPreserved(ref state.Current);\n+ }\n+ else if (meta == MetadataPropertyName.Values)\n+ {\n+ // Preserved JSON arrays are wrapped into JsonPreservedReference<T> where T is the original type of the enumerable\n+ // and Values is the actual enumerable instance being preserved.\n+ JsonPropertyInfo info = state.Current.JsonClassInfo!.PropertyCache![\"Values\"];\n+ info.JsonPropertyName = propertyName.ToArray();","path":"src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.HandlePropertyName.cs","position":214,"original_position":214,"commit_id":"c965e2cb60093c32139ef6543b8be6c6068a87df","original_commit_id":"c965e2cb60093c32139ef6543b8be6c6068a87df","user":{"login":"steveharter","id":6986755,"node_id":"MDQ6VXNlcjY5ODY3NTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6986755?v=4","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"body":"Anything pulled from this cache can't be changed since it is shared across every serialization (e.g. multiple threads may access this)","created_at":"2020-01-10T21:24:17Z","updated_at":"2020-01-10T21:24:17Z","html_url":"https://github.com/dotnet/runtime/pull/655#discussion_r365435912","pull_request_url":"https://api.github.com/repos/dotnet/runtime/pulls/655","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/runtime/pulls/comments/365435912"},"html":{"href":"https://github.com/dotnet/runtime/pull/655#discussion_r365435912"},"pull_request":{"href":"https://api.github.com/repos/dotnet/runtime/pulls/655"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/runtime/pulls/655","id":350264652,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUwMjY0NjUy","html_url":"https://github.com/dotnet/runtime/pull/655","diff_url":"https://github.com/dotnet/runtime/pull/655.diff","patch_url":"https://github.com/dotnet/runtime/pull/655.patch","issue_url":"https://api.github.com/repos/dotnet/runtime/issues/655","number":655,"state":"open","locked":false,"title":"Add support for preserve references on JSON","user":{"login":"Jozkee","id":16040868,"node_id":"MDQ6VXNlcjE2MDQwODY4","avatar_url":"https://avatars3.githubusercontent.com/u/16040868?v=4","gravatar_id":"","url":"https://api.github.com/users/Jozkee","html_url":"https://github.com/Jozkee","followers_url":"https://api.github.com/users/Jozkee/followers","following_url":"https://api.github.com/users/Jozkee/following{/other_user}","gists_url":"https://api.github.com/users/Jozkee/gists{/gist_id}","starred_url":"https://api.github.com/users/Jozkee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jozkee/subscriptions","organizations_url":"https://api.github.com/users/Jozkee/orgs","repos_url":"https://api.github.com/users/Jozkee/repos","events_url":"https://api.github.com/users/Jozkee/events{/privacy}","received_events_url":"https://api.github.com/users/Jozkee/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-12-07T02:00:33Z","updated_at":"2020-01-10T21:24:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6059595073e4ae85563568034753eeaf9b6501c6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ahsonkhan","id":6527137,"node_id":"MDQ6VXNlcjY1MjcxMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6527137?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsonkhan","html_url":"https://github.com/ahsonkhan","followers_url":"https://api.github.com/users/ahsonkhan/followers","following_url":"https://api.github.com/users/ahsonkhan/following{/other_user}","gists_url":"https://api.github.com/users/ahsonkhan/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsonkhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsonkhan/subscriptions","organizations_url":"https://api.github.com/users/ahsonkhan/orgs","repos_url":"https://api.github.com/users/ahsonkhan/repos","events_url":"https://api.github.com/users/ahsonkhan/events{/privacy}","received_events_url":"https://api.github.com/users/ahsonkhan/received_events","type":"User","site_admin":false},{"login":"layomia","id":9868994,"node_id":"MDQ6VXNlcjk4Njg5OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9868994?v=4","gravatar_id":"","url":"https://api.github.com/users/layomia","html_url":"https://github.com/layomia","followers_url":"https://api.github.com/users/layomia/followers","following_url":"https://api.github.com/users/layomia/following{/other_user}","gists_url":"https://api.github.com/users/layomia/gists{/gist_id}","starred_url":"https://api.github.com/users/layomia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/layomia/subscriptions","organizations_url":"https://api.github.com/users/layomia/orgs","repos_url":"https://api.github.com/users/layomia/repos","events_url":"https://api.github.com/users/layomia/events{/privacy}","received_events_url":"https://api.github.com/users/layomia/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1675385895,"node_id":"MDU6TGFiZWwxNjc1Mzg1ODk1","url":"https://api.github.com/repos/dotnet/runtime/labels/area-System.Text.Json","name":"area-System.Text.Json","color":"d4c5f9","default":false,"description":""}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/runtime/pulls/655/commits","review_comments_url":"https://api.github.com/repos/dotnet/runtime/pulls/655/comments","review_comment_url":"https://api.github.com/repos/dotnet/runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/runtime/issues/655/comments","statuses_url":"https://api.github.com/repos/dotnet/runtime/statuses/c965e2cb60093c32139ef6543b8be6c6068a87df","head":{"label":"Jozkee:ReferenceHandling","ref":"ReferenceHandling","sha":"c965e2cb60093c32139ef6543b8be6c6068a87df","user":{"login":"Jozkee","id":16040868,"node_id":"MDQ6VXNlcjE2MDQwODY4","avatar_url":"https://avatars3.githubusercontent.com/u/16040868?v=4","gravatar_id":"","url":"https://api.github.com/users/Jozkee","html_url":"https://github.com/Jozkee","followers_url":"https://api.github.com/users/Jozkee/followers","following_url":"https://api.github.com/users/Jozkee/following{/other_user}","gists_url":"https://api.github.com/users/Jozkee/gists{/gist_id}","starred_url":"https://api.github.com/users/Jozkee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jozkee/subscriptions","organizations_url":"https://api.github.com/users/Jozkee/orgs","repos_url":"https://api.github.com/users/Jozkee/repos","events_url":"https://api.github.com/users/Jozkee/events{/privacy}","received_events_url":"https://api.github.com/users/Jozkee/received_events","type":"User","site_admin":false},"repo":{"id":224508126,"node_id":"MDEwOlJlcG9zaXRvcnkyMjQ1MDgxMjY=","name":"runtime","full_name":"Jozkee/runtime","private":false,"owner":{"login":"Jozkee","id":16040868,"node_id":"MDQ6VXNlcjE2MDQwODY4","avatar_url":"https://avatars3.githubusercontent.com/u/16040868?v=4","gravatar_id":"","url":"https://api.github.com/users/Jozkee","html_url":"https://github.com/Jozkee","followers_url":"https://api.github.com/users/Jozkee/followers","following_url":"https://api.github.com/users/Jozkee/following{/other_user}","gists_url":"https://api.github.com/users/Jozkee/gists{/gist_id}","starred_url":"https://api.github.com/users/Jozkee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jozkee/subscriptions","organizations_url":"https://api.github.com/users/Jozkee/orgs","repos_url":"https://api.github.com/users/Jozkee/repos","events_url":"https://api.github.com/users/Jozkee/events{/privacy}","received_events_url":"https://api.github.com/users/Jozkee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Jozkee/runtime","description":".NET is a cross-platform runtime and libraries, for cloud, IoT and desktop apps. It includes a garbage collector, JIT compiler, primitive data types and class libraries.","fork":true,"url":"https://api.github.com/repos/Jozkee/runtime","forks_url":"https://api.github.com/repos/Jozkee/runtime/forks","keys_url":"https://api.github.com/repos/Jozkee/runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jozkee/runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jozkee/runtime/teams","hooks_url":"https://api.github.com/repos/Jozkee/runtime/hooks","issue_events_url":"https://api.github.com/repos/Jozkee/runtime/issues/events{/number}","events_url":"https://api.github.com/repos/Jozkee/runtime/events","assignees_url":"https://api.github.com/repos/Jozkee/runtime/assignees{/user}","branches_url":"https://api.github.com/repos/Jozkee/runtime/branches{/branch}","tags_url":"https://api.github.com/repos/Jozkee/runtime/tags","blobs_url":"https://api.github.com/repos/Jozkee/runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jozkee/runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jozkee/runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jozkee/runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jozkee/runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/Jozkee/runtime/languages","stargazers_url":"https://api.github.com/repos/Jozkee/runtime/stargazers","contributors_url":"https://api.github.com/repos/Jozkee/runtime/contributors","subscribers_url":"https://api.github.com/repos/Jozkee/runtime/subscribers","subscription_url":"https://api.github.com/repos/Jozkee/runtime/subscription","commits_url":"https://api.github.com/repos/Jozkee/runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jozkee/runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jozkee/runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jozkee/runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jozkee/runtime/contents/{+path}","compare_url":"https://api.github.com/repos/Jozkee/runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jozkee/runtime/merges","archive_url":"https://api.github.com/repos/Jozkee/runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jozkee/runtime/downloads","issues_url":"https://api.github.com/repos/Jozkee/runtime/issues{/number}","pulls_url":"https://api.github.com/repos/Jozkee/runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/Jozkee/runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/Jozkee/runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jozkee/runtime/labels{/name}","releases_url":"https://api.github.com/repos/Jozkee/runtime/releases{/id}","deployments_url":"https://api.github.com/repos/Jozkee/runtime/deployments","created_at":"2019-11-27T20:02:53Z","updated_at":"2019-11-27T20:02:54Z","pushed_at":"2020-01-10T06:22:27Z","git_url":"git://github.com/Jozkee/runtime.git","ssh_url":"[email protected]:Jozkee/runtime.git","clone_url":"https://github.com/Jozkee/runtime.git","svn_url":"https://github.com/Jozkee/runtime","homepage":"https://docs.microsoft.com/dotnet/core/","size":226581,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"8c6b1314c95857b9e2f5c222a10f2f089ee02dfe","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":210716005,"node_id":"MDEwOlJlcG9zaXRvcnkyMTA3MTYwMDU=","name":"runtime","full_name":"dotnet/runtime","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/runtime","description":".NET is a cross-platform runtime for cloud, IoT, and desktop apps.","fork":false,"url":"https://api.github.com/repos/dotnet/runtime","forks_url":"https://api.github.com/repos/dotnet/runtime/forks","keys_url":"https://api.github.com/repos/dotnet/runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/runtime/teams","hooks_url":"https://api.github.com/repos/dotnet/runtime/hooks","issue_events_url":"https://api.github.com/repos/dotnet/runtime/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/runtime/events","assignees_url":"https://api.github.com/repos/dotnet/runtime/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/runtime/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/runtime/tags","blobs_url":"https://api.github.com/repos/dotnet/runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/runtime/languages","stargazers_url":"https://api.github.com/repos/dotnet/runtime/stargazers","contributors_url":"https://api.github.com/repos/dotnet/runtime/contributors","subscribers_url":"https://api.github.com/repos/dotnet/runtime/subscribers","subscription_url":"https://api.github.com/repos/dotnet/runtime/subscription","commits_url":"https://api.github.com/repos/dotnet/runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/runtime/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/runtime/merges","archive_url":"https://api.github.com/repos/dotnet/runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/runtime/downloads","issues_url":"https://api.github.com/repos/dotnet/runtime/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/runtime/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/runtime/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/runtime/deployments","created_at":"2019-09-24T23:36:39Z","updated_at":"2020-01-10T19:11:33Z","pushed_at":"2020-01-10T20:09:47Z","git_url":"git://github.com/dotnet/runtime.git","ssh_url":"[email protected]:dotnet/runtime.git","clone_url":"https://github.com/dotnet/runtime.git","svn_url":"https://github.com/dotnet/runtime","homepage":"https://docs.microsoft.com/dotnet/core/","size":226950,"stargazers_count":1114,"watchers_count":1114,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":298,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":730,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":298,"open_issues":730,"watchers":1114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/runtime/pulls/655"},"html":{"href":"https://github.com/dotnet/runtime/pull/655"},"issue":{"href":"https://api.github.com/repos/dotnet/runtime/issues/655"},"comments":{"href":"https://api.github.com/repos/dotnet/runtime/issues/655/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/runtime/pulls/655/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/runtime/pulls/655/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/runtime/statuses/c965e2cb60093c32139ef6543b8be6c6068a87df"}},"author_association":"MEMBER"}}
|
{
"id": 210716005,
"name": "dotnet/runtime",
"url": "https://api.github.com/repos/dotnet/runtime"
}
|
{
"id": 6986755,
"login": "steveharter",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/6986755?",
"url": "https://api.github.com/users/steveharter"
}
|
{
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
}
| 2020-01-10T21:24:17 |
11250568594
|
{"actor":{"display_login":"steveharter"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/325828888","pull_request_review_id":290118245,"id":325828888,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyNTgyODg4OA==","diff_hunk":"@@ -1209,6 +1212,99 @@ class emitter\n }\n }; // End of struct instrDesc\n \n+#if defined(_TARGET_XARCH_)\n+ insFormat emitter::getMemoryOperation(instrDesc* id);\n+#elif defined(_TARGET_ARM64_)\n+ void emitter::getMemoryOperation(instrDesc* id, unsigned* pMemAccessKind, bool* pIsLocalAccess);\n+#endif\n+\n+#if defined(DEBUG) || defined(LATE_DISASM)\n+\n+#define PERFSCORE_THROUGHPUT_ILLEGAL -1024.0f\n+\n+#define PERFSCORE_THROUGHPUT_4X 0.25f // Fastest - Quad issue\n+#define PERFSCORE_THROUGHPUT_3X (1.0f / 3.0f) // Faster - Three issue\n+#define PERFSCORE_THROUGHPUT_2X 0.5f // Faster - Dual issue\n+\n+#define PERFSCORE_THROUGHPUT_1C 1.0f // Single Issue\n+\n+#define PERFSCORE_THROUGHPUT_2C 2.0f // slower - 2 cycles\n+#define PERFSCORE_THROUGHPUT_3C 3.0f // slower - 3 cycles\n+#define PERFSCORE_THROUGHPUT_4C 4.0f // slower - 4 cycles\n+#define PERFSCORE_THROUGHPUT_5C 5.0f // slower - 5 cycles\n+#define PERFSCORE_THROUGHPUT_6C 6.0f // slower - 6 cycles\n+#define PERFSCORE_THROUGHPUT_10C 10.0f // slower - 10 cycles\n+#define PERFSCORE_THROUGHPUT_13C 13.0f // slower - 13 cycles\n+#define PERFSCORE_THROUGHPUT_25C 25.0f // slower - 26 cycles","path":"src/jit/emit.h","position":null,"original_position":37,"commit_id":"0ef6c7494a0c56d7b4fbf1dd3a3038de83dccfff","original_commit_id":"d3cd6ffbe378ffd5e4230c56a6c09eb5de499b01","user":{"login":"briansull","id":11621884,"node_id":"MDQ6VXNlcjExNjIxODg0","avatar_url":"https://avatars2.githubusercontent.com/u/11621884?v=4","gravatar_id":"","url":"https://api.github.com/users/briansull","html_url":"https://github.com/briansull","followers_url":"https://api.github.com/users/briansull/followers","following_url":"https://api.github.com/users/briansull/following{/other_user}","gists_url":"https://api.github.com/users/briansull/gists{/gist_id}","starred_url":"https://api.github.com/users/briansull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansull/subscriptions","organizations_url":"https://api.github.com/users/briansull/orgs","repos_url":"https://api.github.com/users/briansull/repos","events_url":"https://api.github.com/users/briansull/events{/privacy}","received_events_url":"https://api.github.com/users/briansull/received_events","type":"User","site_admin":false},"body":"The idea here was that that in the future these could become enum values. \r\nAnd that we could then pack the insExecutionCharacteristics struct to be a 32 or 64 bits.","created_at":"2019-09-18T18:30:07Z","updated_at":"2019-09-18T18:30:08Z","html_url":"https://github.com/dotnet/coreclr/pull/26456#discussion_r325828888","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/26456","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/325828888"},"html":{"href":"https://github.com/dotnet/coreclr/pull/26456#discussion_r325828888"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/26456"}},"in_reply_to_id":325371079},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/26456","id":312907659,"node_id":"MDExOlB1bGxSZXF1ZXN0MzEyOTA3NjU5","html_url":"https://github.com/dotnet/coreclr/pull/26456","diff_url":"https://github.com/dotnet/coreclr/pull/26456.diff","patch_url":"https://github.com/dotnet/coreclr/pull/26456.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/26456","number":26456,"state":"closed","locked":false,"title":"Implement PerfScore","user":{"login":"briansull","id":11621884,"node_id":"MDQ6VXNlcjExNjIxODg0","avatar_url":"https://avatars2.githubusercontent.com/u/11621884?v=4","gravatar_id":"","url":"https://api.github.com/users/briansull","html_url":"https://github.com/briansull","followers_url":"https://api.github.com/users/briansull/followers","following_url":"https://api.github.com/users/briansull/following{/other_user}","gists_url":"https://api.github.com/users/briansull/gists{/gist_id}","starred_url":"https://api.github.com/users/briansull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansull/subscriptions","organizations_url":"https://api.github.com/users/briansull/orgs","repos_url":"https://api.github.com/users/briansull/repos","events_url":"https://api.github.com/users/briansull/events{/privacy}","received_events_url":"https://api.github.com/users/briansull/received_events","type":"User","site_admin":false},"body":" - PerfScore represents an estimate of the dynamic execution cost for the method\r\n emitter::insExecutionCharacteristics emitter::getInsExecutionCharacteristics(instrDesc* id)\r\n - We track the BasicBlock weight for each instruction group\r\n - PerfScore also uses the codesize as a minor factor, both the hot code size and the cold code size\r\n - Provides an x64 implementation of getInsExecutionCharacteristics.","created_at":"2019-08-30T23:14:40Z","updated_at":"2019-09-18T18:30:08Z","closed_at":"2019-09-18T17:59:21Z","merged_at":"2019-09-18T17:59:21Z","merge_commit_sha":"e7f95bdfa1964e888ad9f6b78bd92d528d650227","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/26456/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/26456/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/26456/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/0ef6c7494a0c56d7b4fbf1dd3a3038de83dccfff","head":{"label":"briansull:PerfScore2","ref":"PerfScore2","sha":"0ef6c7494a0c56d7b4fbf1dd3a3038de83dccfff","user":{"login":"briansull","id":11621884,"node_id":"MDQ6VXNlcjExNjIxODg0","avatar_url":"https://avatars2.githubusercontent.com/u/11621884?v=4","gravatar_id":"","url":"https://api.github.com/users/briansull","html_url":"https://github.com/briansull","followers_url":"https://api.github.com/users/briansull/followers","following_url":"https://api.github.com/users/briansull/following{/other_user}","gists_url":"https://api.github.com/users/briansull/gists{/gist_id}","starred_url":"https://api.github.com/users/briansull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansull/subscriptions","organizations_url":"https://api.github.com/users/briansull/orgs","repos_url":"https://api.github.com/users/briansull/repos","events_url":"https://api.github.com/users/briansull/events{/privacy}","received_events_url":"https://api.github.com/users/briansull/received_events","type":"User","site_admin":false},"repo":{"id":32836344,"node_id":"MDEwOlJlcG9zaXRvcnkzMjgzNjM0NA==","name":"coreclr","full_name":"briansull/coreclr","private":false,"owner":{"login":"briansull","id":11621884,"node_id":"MDQ6VXNlcjExNjIxODg0","avatar_url":"https://avatars2.githubusercontent.com/u/11621884?v=4","gravatar_id":"","url":"https://api.github.com/users/briansull","html_url":"https://github.com/briansull","followers_url":"https://api.github.com/users/briansull/followers","following_url":"https://api.github.com/users/briansull/following{/other_user}","gists_url":"https://api.github.com/users/briansull/gists{/gist_id}","starred_url":"https://api.github.com/users/briansull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/briansull/subscriptions","organizations_url":"https://api.github.com/users/briansull/orgs","repos_url":"https://api.github.com/users/briansull/repos","events_url":"https://api.github.com/users/briansull/events{/privacy}","received_events_url":"https://api.github.com/users/briansull/received_events","type":"User","site_admin":false},"html_url":"https://github.com/briansull/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/briansull/coreclr","forks_url":"https://api.github.com/repos/briansull/coreclr/forks","keys_url":"https://api.github.com/repos/briansull/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/briansull/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/briansull/coreclr/teams","hooks_url":"https://api.github.com/repos/briansull/coreclr/hooks","issue_events_url":"https://api.github.com/repos/briansull/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/briansull/coreclr/events","assignees_url":"https://api.github.com/repos/briansull/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/briansull/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/briansull/coreclr/tags","blobs_url":"https://api.github.com/repos/briansull/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/briansull/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/briansull/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/briansull/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/briansull/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/briansull/coreclr/languages","stargazers_url":"https://api.github.com/repos/briansull/coreclr/stargazers","contributors_url":"https://api.github.com/repos/briansull/coreclr/contributors","subscribers_url":"https://api.github.com/repos/briansull/coreclr/subscribers","subscription_url":"https://api.github.com/repos/briansull/coreclr/subscription","commits_url":"https://api.github.com/repos/briansull/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/briansull/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/briansull/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/briansull/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/briansull/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/briansull/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/briansull/coreclr/merges","archive_url":"https://api.github.com/repos/briansull/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/briansull/coreclr/downloads","issues_url":"https://api.github.com/repos/briansull/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/briansull/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/briansull/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/briansull/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/briansull/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/briansull/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/briansull/coreclr/deployments","created_at":"2015-03-25T01:52:49Z","updated_at":"2019-09-18T18:03:29Z","pushed_at":"2019-09-18T18:26:33Z","git_url":"git://github.com/briansull/coreclr.git","ssh_url":"[email protected]:briansull/coreclr.git","clone_url":"https://github.com/briansull/coreclr.git","svn_url":"https://github.com/briansull/coreclr","homepage":"","size":305965,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"cb84762fd8f92959f964b6458ef2dc41092d5c2c","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA5Mjg5Mw==","name":"coreclr","full_name":"dotnet/coreclr","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/coreclr","description":"CoreCLR is the runtime for .NET Core. It includes the garbage collector, JIT compiler, primitive data types and low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2019-09-18T18:07:29Z","pushed_at":"2019-09-18T18:27:26Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"[email protected]:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/core/","size":308559,"stargazers_count":12042,"watchers_count":12042,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2832,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":2155,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2832,"open_issues":2155,"watchers":12042,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/26456"},"html":{"href":"https://github.com/dotnet/coreclr/pull/26456"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/26456"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/26456/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/26456/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/26456/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/0ef6c7494a0c56d7b4fbf1dd3a3038de83dccfff"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 30092893,
"name": "dotnet/coreclr",
"url": "https://api.github.com/repos/dotnet/coreclr"
}
|
{
"id": 11621884,
"login": "briansull",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/11621884?",
"url": "https://api.github.com/users/briansull"
}
|
{
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
}
| 2019-09-18T18:30:07 |
10445195303
|
{"actor":{"display_login":"briansull"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/254126599","pull_request_review_id":200399978,"id":254126599,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1NDEyNjU5OQ==","diff_hunk":"@@ -270,7 +270,7 @@ private ValueTask<HttpConnection> GetOrReserveHttp11ConnectionAsync(Cancellation\n }\n \n HttpConnection conn = cachedConnection._connection;\n- if (cachedConnection.IsUsable(now, pooledConnectionLifetime, pooledConnectionIdleTimeout) &&\n+ if (cachedConnection.IsUsable(now, pooledConnectionLifetime, Timeout.InfiniteTimeSpan) &&","path":"src/System.Net.Http/src/System/Net/Http/SocketsHttpHandler/HttpConnectionPool.cs","position":5,"original_position":5,"commit_id":"8b9b9880d588f30050a709e4e15ab585cda43f88","original_commit_id":"8b9b9880d588f30050a709e4e15ab585cda43f88","user":{"login":"geoffkizer","id":12518809,"node_id":"MDQ6VXNlcjEyNTE4ODA5","avatar_url":"https://avatars2.githubusercontent.com/u/12518809?v=4","gravatar_id":"","url":"https://api.github.com/users/geoffkizer","html_url":"https://github.com/geoffkizer","followers_url":"https://api.github.com/users/geoffkizer/followers","following_url":"https://api.github.com/users/geoffkizer/following{/other_user}","gists_url":"https://api.github.com/users/geoffkizer/gists{/gist_id}","starred_url":"https://api.github.com/users/geoffkizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoffkizer/subscriptions","organizations_url":"https://api.github.com/users/geoffkizer/orgs","repos_url":"https://api.github.com/users/geoffkizer/repos","events_url":"https://api.github.com/users/geoffkizer/events{/privacy}","received_events_url":"https://api.github.com/users/geoffkizer/received_events","type":"User","site_admin":false},"body":"Actually it's in ReturnConnection, not ReturnConnectionToPool.","created_at":"2019-02-06T03:14:17Z","updated_at":"2019-02-06T03:14:17Z","html_url":"https://github.com/dotnet/corefx/pull/35087#discussion_r254126599","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/35087","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/254126599"},"html":{"href":"https://github.com/dotnet/corefx/pull/35087#discussion_r254126599"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/35087"}},"in_reply_to_id":254126282},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/35087","id":250231556,"node_id":"MDExOlB1bGxSZXF1ZXN0MjUwMjMxNTU2","html_url":"https://github.com/dotnet/corefx/pull/35087","diff_url":"https://github.com/dotnet/corefx/pull/35087.diff","patch_url":"https://github.com/dotnet/corefx/pull/35087.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/35087","number":35087,"state":"open","locked":false,"title":"basic support for PooledConnectionLifetime for HTTP2","user":{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"body":"related to #31294 \r\n\r\nI'm not sure if we need to track expired connections. \r\nI originally started on that path and used HashSet to track them. But disposing Http2Conection seems to do exactly what I wanted e.g. close it when there is no pending request. \r\n\r\nI verified this in my setup with real HTTP2 server. \r\nI look at existing tests and it seems like it is not worth of fixing until #34345 lands. (or something similar)\r\n\r\n ","created_at":"2019-02-04T23:11:32Z","updated_at":"2019-02-06T03:14:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89bce05e95466161f71d6d5c279a4e51c5aba747","assignee":{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"assignees":[{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":809472144,"node_id":"MDU6TGFiZWw4MDk0NzIxNDQ=","url":"https://api.github.com/repos/dotnet/corefx/labels/area-System.Net.Http.SocketsHttpHandler","name":"area-System.Net.Http.SocketsHttpHandler","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corefx/milestones/21","html_url":"https://github.com/dotnet/corefx/milestone/21","labels_url":"https://api.github.com/repos/dotnet/corefx/milestones/21/labels","id":3242632,"node_id":"MDk6TWlsZXN0b25lMzI0MjYzMg==","number":21,"title":"3.0","description":".NET Core 3.0, next major release after 2.1. See [official release dates](https://github.com/dotnet/core/blob/master/roadmap.md) for details.\r\n\r\nWe will move important issues from Future to 3.0 as the priorities and dates for next release become more clear.","creator":{"login":"karelz","id":5776068,"node_id":"MDQ6VXNlcjU3NzYwNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/5776068?v=4","gravatar_id":"","url":"https://api.github.com/users/karelz","html_url":"https://github.com/karelz","followers_url":"https://api.github.com/users/karelz/followers","following_url":"https://api.github.com/users/karelz/following{/other_user}","gists_url":"https://api.github.com/users/karelz/gists{/gist_id}","starred_url":"https://api.github.com/users/karelz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karelz/subscriptions","organizations_url":"https://api.github.com/users/karelz/orgs","repos_url":"https://api.github.com/users/karelz/repos","events_url":"https://api.github.com/users/karelz/events{/privacy}","received_events_url":"https://api.github.com/users/karelz/received_events","type":"User","site_admin":false},"open_issues":363,"closed_issues":4262,"state":"open","created_at":"2018-04-04T16:40:10Z","updated_at":"2019-02-05T23:23:10Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/35087/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/35087/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/35087/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/8b9b9880d588f30050a709e4e15ab585cda43f88","head":{"label":"wfurt:h2_lifetime_31294","ref":"h2_lifetime_31294","sha":"8b9b9880d588f30050a709e4e15ab585cda43f88","user":{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"repo":{"id":91738855,"node_id":"MDEwOlJlcG9zaXRvcnk5MTczODg1NQ==","name":"corefx","full_name":"wfurt/corefx","private":false,"owner":{"login":"wfurt","id":14356188,"node_id":"MDQ6VXNlcjE0MzU2MTg4","avatar_url":"https://avatars2.githubusercontent.com/u/14356188?v=4","gravatar_id":"","url":"https://api.github.com/users/wfurt","html_url":"https://github.com/wfurt","followers_url":"https://api.github.com/users/wfurt/followers","following_url":"https://api.github.com/users/wfurt/following{/other_user}","gists_url":"https://api.github.com/users/wfurt/gists{/gist_id}","starred_url":"https://api.github.com/users/wfurt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wfurt/subscriptions","organizations_url":"https://api.github.com/users/wfurt/orgs","repos_url":"https://api.github.com/users/wfurt/repos","events_url":"https://api.github.com/users/wfurt/events{/privacy}","received_events_url":"https://api.github.com/users/wfurt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wfurt/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/wfurt/corefx","forks_url":"https://api.github.com/repos/wfurt/corefx/forks","keys_url":"https://api.github.com/repos/wfurt/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wfurt/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wfurt/corefx/teams","hooks_url":"https://api.github.com/repos/wfurt/corefx/hooks","issue_events_url":"https://api.github.com/repos/wfurt/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/wfurt/corefx/events","assignees_url":"https://api.github.com/repos/wfurt/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/wfurt/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/wfurt/corefx/tags","blobs_url":"https://api.github.com/repos/wfurt/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wfurt/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wfurt/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/wfurt/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wfurt/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/wfurt/corefx/languages","stargazers_url":"https://api.github.com/repos/wfurt/corefx/stargazers","contributors_url":"https://api.github.com/repos/wfurt/corefx/contributors","subscribers_url":"https://api.github.com/repos/wfurt/corefx/subscribers","subscription_url":"https://api.github.com/repos/wfurt/corefx/subscription","commits_url":"https://api.github.com/repos/wfurt/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/wfurt/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/wfurt/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/wfurt/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/wfurt/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/wfurt/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wfurt/corefx/merges","archive_url":"https://api.github.com/repos/wfurt/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wfurt/corefx/downloads","issues_url":"https://api.github.com/repos/wfurt/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/wfurt/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/wfurt/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/wfurt/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wfurt/corefx/labels{/name}","releases_url":"https://api.github.com/repos/wfurt/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/wfurt/corefx/deployments","created_at":"2017-05-18T21:24:08Z","updated_at":"2019-01-25T19:06:40Z","pushed_at":"2019-02-06T03:00:37Z","git_url":"git://github.com/wfurt/corefx.git","ssh_url":"[email protected]:wfurt/corefx.git","clone_url":"https://github.com/wfurt/corefx.git","svn_url":"https://github.com/wfurt/corefx","homepage":"https://github.com/dotnet/core","size":196300,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c5b8191a09da2296635a5a4d360109dc7a0e47de","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/corefx","description":"CoreFX is the foundational class libraries for .NET Core. It includes types for collections, file systems, console, JSON, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2019-02-06T01:25:10Z","pushed_at":"2019-02-06T03:12:58Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"[email protected]:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/core/","size":198227,"stargazers_count":15683,"watchers_count":15683,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4653,"mirror_url":null,"archived":false,"open_issues_count":2847,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4653,"open_issues":2847,"watchers":15683,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/35087"},"html":{"href":"https://github.com/dotnet/corefx/pull/35087"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/35087"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/35087/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/35087/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/35087/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/8b9b9880d588f30050a709e4e15ab585cda43f88"}},"author_association":"MEMBER"}}
|
{
"id": 26295345,
"name": "dotnet/corefx",
"url": "https://api.github.com/repos/dotnet/corefx"
}
|
{
"id": 12518809,
"login": "geoffkizer",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12518809?",
"url": "https://api.github.com/users/geoffkizer"
}
|
{
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
}
| 2019-02-06T03:14:17 |
9015498326
|
{"actor":{"display_login":"geoffkizer"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/arcade/pulls/comments/260068025","pull_request_review_id":207693977,"id":260068025,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2MDA2ODAyNQ==","diff_hunk":"@@ -148,12 +148,15 @@ public async Task<ISentJob> SendAsync(Action<string> log = null)\n IBlobContainer storageContainer = await storage.GetContainerAsync(TargetContainerName);\n var jobList = new List<JobListEntry>();\n \n- IBlobHelper resultsStorage = null;\n- IBlobContainer resultsStorageContainer = null;\n- if (!string.IsNullOrEmpty(ResultsStorageAccountConnectionString))\n+ IBlobContainer resultsStorageContainer;\n+ if (string.IsNullOrEmpty(ResultsStorageAccountConnectionString))\n {\n- resultsStorage = new ConnectionStringBlobHelper(ResultsStorageAccountConnectionString);\n- resultsStorageContainer = await resultsStorage.GetContainerAsync(TargetContainerName);\n+ resultsStorageContainer = await storage.GetContainerAsync(TargetResultsContainerName);","path":"src/Microsoft.DotNet.Helix/JobSender/JobDefinition.cs","position":12,"original_position":12,"commit_id":"2e31c0b0f7cbb061dc4a0f78bcd2a8cf8a1c74fa","original_commit_id":"2e31c0b0f7cbb061dc4a0f78bcd2a8cf8a1c74fa","user":{"login":"jonfortescue","id":13228069,"node_id":"MDQ6VXNlcjEzMjI4MDY5","avatar_url":"https://avatars0.githubusercontent.com/u/13228069?v=4","gravatar_id":"","url":"https://api.github.com/users/jonfortescue","html_url":"https://github.com/jonfortescue","followers_url":"https://api.github.com/users/jonfortescue/followers","following_url":"https://api.github.com/users/jonfortescue/following{/other_user}","gists_url":"https://api.github.com/users/jonfortescue/gists{/gist_id}","starred_url":"https://api.github.com/users/jonfortescue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonfortescue/subscriptions","organizations_url":"https://api.github.com/users/jonfortescue/orgs","repos_url":"https://api.github.com/users/jonfortescue/repos","events_url":"https://api.github.com/users/jonfortescue/events{/privacy}","received_events_url":"https://api.github.com/users/jonfortescue/received_events","type":"User","site_admin":false},"body":"Okay, filed an issue for this work at https://github.com/dotnet/core-eng/issues/5324; triaging it to GA for now","created_at":"2019-02-25T23:42:08Z","updated_at":"2019-02-25T23:42:08Z","html_url":"https://github.com/dotnet/arcade/pull/2103#discussion_r260068025","pull_request_url":"https://api.github.com/repos/dotnet/arcade/pulls/2103","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/comments/260068025"},"html":{"href":"https://github.com/dotnet/arcade/pull/2103#discussion_r260068025"},"pull_request":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/2103"}},"in_reply_to_id":259980814},"pull_request":{"url":"https://api.github.com/repos/dotnet/arcade/pulls/2103","id":255676484,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU1Njc2NDg0","html_url":"https://github.com/dotnet/arcade/pull/2103","diff_url":"https://github.com/dotnet/arcade/pull/2103.diff","patch_url":"https://github.com/dotnet/arcade/pull/2103.patch","issue_url":"https://api.github.com/repos/dotnet/arcade/issues/2103","number":2103,"state":"open","locked":false,"title":"Add task to download files from helix results container","user":{"login":"safern","id":22899328,"node_id":"MDQ6VXNlcjIyODk5MzI4","avatar_url":"https://avatars1.githubusercontent.com/u/22899328?v=4","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false},"body":"Contributes to: #2076 \r\n\r\nThis pr adds a Task for helix jobs to be able to download a file from the results container after a helix run, i.e testResults.xml or coverage.xml. \r\n\r\n1. Every `HelixWorkItem` should include a metadata entry to specify which files it needs to download:\r\n```xml\r\n<HelixWorkItem Include=\"WorkItem\">\r\n <DownloadFilesFromResults>testResults.xml</DownloadFilesFromResults>\r\n</HelixWorkItem>\r\n```\r\n2. A destination directory in the host machine can be specified through an MSBuild property -- `$(ResultsDestinationPath)`.\r\n - If this property is not set and `BUILD_SOURCESDIRECTORY` property is available (predefined variable in Azure DevOps), it defaults to `$(BUILD_SOURCESDIRECTORY)/artifacts/helixresults`.\r\n - If `BUILD_SOURCESDIRECTORY` is empty, it defaults to, `$(MSBuildStartupDirectory)/helixresults`\r\n3. A directory under this destination folder will be created per each Job created => each `HelixTargetQueue` for the same payload. This folder will be named with the JobId.\r\n4. Under this Job directory, there will be a `metadata.txt` file, that will contain the following information:\r\n```\r\nHelixQueue=%(SentJob.HelixTargetQueue)\r\nConfiguration=$(HelixConfiguration)\r\nArchitecture=$(HelixArchitecture)\r\n```\r\nMore metadata can be specified to be written into this file, through and ItemGroup => `DownloadResultsMetadata`\r\n5. Under the Job directory, there will be a directory for every `HelixWorkItem` that specified the `DownloadFilesFromResults` metadata, and under that folder it will contain the files that where available for download.\r\n6. If a file is not found within the container, a Warning will be logged through MSBuild.\r\n\r\nThe structure of the directory will look as follows:\r\n```\r\n- ResultsDestinationPath \\\r\n - JobId \\\r\n - metadata.txt\r\n - HelixWorkItemName \\\r\n - downloaded files.\r\n```\r\n\r\ncc: @ViktorHofer @danmosemsft @markwilkie @Chrisboh \r\n","created_at":"2019-02-24T11:08:07Z","updated_at":"2019-02-25T23:42:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e26a3cdad284a4d9691b5b525dbd83b39b297f7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/arcade/pulls/2103/commits","review_comments_url":"https://api.github.com/repos/dotnet/arcade/pulls/2103/comments","review_comment_url":"https://api.github.com/repos/dotnet/arcade/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/arcade/issues/2103/comments","statuses_url":"https://api.github.com/repos/dotnet/arcade/statuses/2e31c0b0f7cbb061dc4a0f78bcd2a8cf8a1c74fa","head":{"label":"safern:DownloadResultsContainer","ref":"DownloadResultsContainer","sha":"2e31c0b0f7cbb061dc4a0f78bcd2a8cf8a1c74fa","user":{"login":"safern","id":22899328,"node_id":"MDQ6VXNlcjIyODk5MzI4","avatar_url":"https://avatars1.githubusercontent.com/u/22899328?v=4","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false},"repo":{"id":152164593,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIxNjQ1OTM=","name":"arcade","full_name":"safern/arcade","private":false,"owner":{"login":"safern","id":22899328,"node_id":"MDQ6VXNlcjIyODk5MzI4","avatar_url":"https://avatars1.githubusercontent.com/u/22899328?v=4","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false},"html_url":"https://github.com/safern/arcade","description":"Tools that provide common build infrastructure for multiple .NET Foundation projects.","fork":true,"url":"https://api.github.com/repos/safern/arcade","forks_url":"https://api.github.com/repos/safern/arcade/forks","keys_url":"https://api.github.com/repos/safern/arcade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/safern/arcade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/safern/arcade/teams","hooks_url":"https://api.github.com/repos/safern/arcade/hooks","issue_events_url":"https://api.github.com/repos/safern/arcade/issues/events{/number}","events_url":"https://api.github.com/repos/safern/arcade/events","assignees_url":"https://api.github.com/repos/safern/arcade/assignees{/user}","branches_url":"https://api.github.com/repos/safern/arcade/branches{/branch}","tags_url":"https://api.github.com/repos/safern/arcade/tags","blobs_url":"https://api.github.com/repos/safern/arcade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/safern/arcade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/safern/arcade/git/refs{/sha}","trees_url":"https://api.github.com/repos/safern/arcade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/safern/arcade/statuses/{sha}","languages_url":"https://api.github.com/repos/safern/arcade/languages","stargazers_url":"https://api.github.com/repos/safern/arcade/stargazers","contributors_url":"https://api.github.com/repos/safern/arcade/contributors","subscribers_url":"https://api.github.com/repos/safern/arcade/subscribers","subscription_url":"https://api.github.com/repos/safern/arcade/subscription","commits_url":"https://api.github.com/repos/safern/arcade/commits{/sha}","git_commits_url":"https://api.github.com/repos/safern/arcade/git/commits{/sha}","comments_url":"https://api.github.com/repos/safern/arcade/comments{/number}","issue_comment_url":"https://api.github.com/repos/safern/arcade/issues/comments{/number}","contents_url":"https://api.github.com/repos/safern/arcade/contents/{+path}","compare_url":"https://api.github.com/repos/safern/arcade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/safern/arcade/merges","archive_url":"https://api.github.com/repos/safern/arcade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/safern/arcade/downloads","issues_url":"https://api.github.com/repos/safern/arcade/issues{/number}","pulls_url":"https://api.github.com/repos/safern/arcade/pulls{/number}","milestones_url":"https://api.github.com/repos/safern/arcade/milestones{/number}","notifications_url":"https://api.github.com/repos/safern/arcade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/safern/arcade/labels{/name}","releases_url":"https://api.github.com/repos/safern/arcade/releases{/id}","deployments_url":"https://api.github.com/repos/safern/arcade/deployments","created_at":"2018-10-09T00:36:13Z","updated_at":"2018-10-09T00:36:16Z","pushed_at":"2019-02-24T10:51:40Z","git_url":"git://github.com/safern/arcade.git","ssh_url":"[email protected]:safern/arcade.git","clone_url":"https://github.com/safern/arcade.git","svn_url":"https://github.com/safern/arcade","homepage":"","size":10845,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"0cdc39a26b67f1aa01c0833861500c9ce25b862e","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":121444325,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0NDQzMjU=","name":"arcade","full_name":"dotnet/arcade","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/arcade","description":"Tools that provide common build infrastructure for multiple .NET Foundation projects.","fork":false,"url":"https://api.github.com/repos/dotnet/arcade","forks_url":"https://api.github.com/repos/dotnet/arcade/forks","keys_url":"https://api.github.com/repos/dotnet/arcade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/arcade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/arcade/teams","hooks_url":"https://api.github.com/repos/dotnet/arcade/hooks","issue_events_url":"https://api.github.com/repos/dotnet/arcade/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/arcade/events","assignees_url":"https://api.github.com/repos/dotnet/arcade/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/arcade/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/arcade/tags","blobs_url":"https://api.github.com/repos/dotnet/arcade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/arcade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/arcade/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/arcade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/arcade/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/arcade/languages","stargazers_url":"https://api.github.com/repos/dotnet/arcade/stargazers","contributors_url":"https://api.github.com/repos/dotnet/arcade/contributors","subscribers_url":"https://api.github.com/repos/dotnet/arcade/subscribers","subscription_url":"https://api.github.com/repos/dotnet/arcade/subscription","commits_url":"https://api.github.com/repos/dotnet/arcade/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/arcade/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/arcade/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/arcade/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/arcade/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/arcade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/arcade/merges","archive_url":"https://api.github.com/repos/dotnet/arcade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/arcade/downloads","issues_url":"https://api.github.com/repos/dotnet/arcade/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/arcade/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/arcade/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/arcade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/arcade/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/arcade/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/arcade/deployments","created_at":"2018-02-13T22:29:54Z","updated_at":"2019-02-25T23:07:02Z","pushed_at":"2019-02-25T23:06:58Z","git_url":"git://github.com/dotnet/arcade.git","ssh_url":"[email protected]:dotnet/arcade.git","clone_url":"https://github.com/dotnet/arcade.git","svn_url":"https://github.com/dotnet/arcade","homepage":"","size":10881,"stargazers_count":88,"watchers_count":88,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":74,"mirror_url":null,"archived":false,"open_issues_count":297,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":74,"open_issues":297,"watchers":88,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/2103"},"html":{"href":"https://github.com/dotnet/arcade/pull/2103"},"issue":{"href":"https://api.github.com/repos/dotnet/arcade/issues/2103"},"comments":{"href":"https://api.github.com/repos/dotnet/arcade/issues/2103/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/2103/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/2103/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/arcade/statuses/2e31c0b0f7cbb061dc4a0f78bcd2a8cf8a1c74fa"}},"author_association":"MEMBER"}}
|
{
"id": 121444325,
"name": "dotnet/arcade",
"url": "https://api.github.com/repos/dotnet/arcade"
}
|
{
"id": 13228069,
"login": "jonfortescue",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/13228069?",
"url": "https://api.github.com/users/jonfortescue"
}
|
{
"id": 9141961,
"login": "dotnet",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9141961?",
"url": "https://api.github.com/orgs/dotnet"
}
| 2019-02-25T23:42:08 |
9134389549
|
{"actor":{"display_login":"jonfortescue"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/pulls/comments/269143782","pull_request_review_id":218944328,"id":269143782,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI2OTE0Mzc4Mg==","diff_hunk":"@@ -2163,3 +2197,19 @@ Customer's personal document\n + `DRIVING_LICENSE_FRONT` - Driving license (front side)\n + `DRIVING_LICENSE_BACK` - Driving license (back side)\n + `file` (PersonalDocumentFile, required) - Attached file\n+\n+## Notification (object)\n++ `id`: 45688987 (number) - Notification ID\n++ `createdDate` : `2017-01-18T10:34:44+01:00` (string) - Date and time of notification creation\n++ `title`: `Order has been cancelled` (string) - Title of the notification\n++ `text`: `Your order no.4566221 has been cancelled` (string, optional) - Text of the notification\n++ `triggerActionUrl`: `http://someurl.com/` (string, optional) - URL user should be redirected to, when he triggers the notification (i.e. when he clicks/taps it).\n++ `isRead`: `True` (boolean) - Flag indicating that user has seen the notification.\n++ `isTriggered`: `True` (boolean) - Flag indicating that user has interacted with the notification (e.g. clicked/tapped on it)\n++ `slug`: `order-cancelled` (string, optional) - Notification template slug.\n++ `relatedObjects`: (array[NotificationRelatedObject], optional) - A mapping of related objects, where key is name of the object and value is the object.\n+\n+## NotificationRelatedObject (object)\n++ `type` (enum, required) - Type of related object.\n+ + `APPLICATION` - Related application\n++ `data`: (object, required) - Data of related object (depends on `type`), currently only Application object.","path":"apiary.apib","position":60,"original_position":60,"commit_id":"81c5c8777bca47f09a55451073915df3de9694db","original_commit_id":"81c5c8777bca47f09a55451073915df3de9694db","user":{"login":"ZwickTheGreat","id":2446500,"node_id":"MDQ6VXNlcjI0NDY1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/2446500?v=4","gravatar_id":"","url":"https://api.github.com/users/ZwickTheGreat","html_url":"https://github.com/ZwickTheGreat","followers_url":"https://api.github.com/users/ZwickTheGreat/followers","following_url":"https://api.github.com/users/ZwickTheGreat/following{/other_user}","gists_url":"https://api.github.com/users/ZwickTheGreat/gists{/gist_id}","starred_url":"https://api.github.com/users/ZwickTheGreat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZwickTheGreat/subscriptions","organizations_url":"https://api.github.com/users/ZwickTheGreat/orgs","repos_url":"https://api.github.com/users/ZwickTheGreat/repos","events_url":"https://api.github.com/users/ZwickTheGreat/events{/privacy}","received_events_url":"https://api.github.com/users/ZwickTheGreat/received_events","type":"User","site_admin":false},"body":"Udělejme to prosím stejně jako zde https://github.com/usertech/mallpay-selfcare-API/pull/30#discussion_r269016032.","created_at":"2019-03-26T14:50:30Z","updated_at":"2019-03-26T14:50:37Z","html_url":"https://github.com/usertech/mallpay-selfcare-API/pull/22#discussion_r269143782","pull_request_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/pulls/22","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/usertech/mallpay-selfcare-API/pulls/comments/269143782"},"html":{"href":"https://github.com/usertech/mallpay-selfcare-API/pull/22#discussion_r269143782"},"pull_request":{"href":"https://api.github.com/repos/usertech/mallpay-selfcare-API/pulls/22"}},"in_reply_to_id":268782327},"pull_request":{"url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/pulls/22","id":259112121,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU5MTEyMTIx","html_url":"https://github.com/usertech/mallpay-selfcare-API/pull/22","diff_url":"https://github.com/usertech/mallpay-selfcare-API/pull/22.diff","patch_url":"https://github.com/usertech/mallpay-selfcare-API/pull/22.patch","issue_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/issues/22","number":22,"state":"open","locked":false,"title":"Add notification endpoints","user":{"login":"rubickcz","id":3601440,"node_id":"MDQ6VXNlcjM2MDE0NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3601440?v=4","gravatar_id":"","url":"https://api.github.com/users/rubickcz","html_url":"https://github.com/rubickcz","followers_url":"https://api.github.com/users/rubickcz/followers","following_url":"https://api.github.com/users/rubickcz/following{/other_user}","gists_url":"https://api.github.com/users/rubickcz/gists{/gist_id}","starred_url":"https://api.github.com/users/rubickcz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubickcz/subscriptions","organizations_url":"https://api.github.com/users/rubickcz/orgs","repos_url":"https://api.github.com/users/rubickcz/repos","events_url":"https://api.github.com/users/rubickcz/events{/privacy}","received_events_url":"https://api.github.com/users/rubickcz/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-03-07T13:27:46Z","updated_at":"2019-03-26T14:50:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"273af3862f501a913323194a88e643f5af5f85a3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/pulls/22/commits","review_comments_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/pulls/22/comments","review_comment_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/pulls/comments{/number}","comments_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/issues/22/comments","statuses_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/statuses/81c5c8777bca47f09a55451073915df3de9694db","head":{"label":"rubickcz:add_notification_endpoints","ref":"add_notification_endpoints","sha":"81c5c8777bca47f09a55451073915df3de9694db","user":{"login":"rubickcz","id":3601440,"node_id":"MDQ6VXNlcjM2MDE0NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3601440?v=4","gravatar_id":"","url":"https://api.github.com/users/rubickcz","html_url":"https://github.com/rubickcz","followers_url":"https://api.github.com/users/rubickcz/followers","following_url":"https://api.github.com/users/rubickcz/following{/other_user}","gists_url":"https://api.github.com/users/rubickcz/gists{/gist_id}","starred_url":"https://api.github.com/users/rubickcz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubickcz/subscriptions","organizations_url":"https://api.github.com/users/rubickcz/orgs","repos_url":"https://api.github.com/users/rubickcz/repos","events_url":"https://api.github.com/users/rubickcz/events{/privacy}","received_events_url":"https://api.github.com/users/rubickcz/received_events","type":"User","site_admin":false},"repo":{"id":174348124,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQzNDgxMjQ=","name":"mallpay-selfcare-API","full_name":"rubickcz/mallpay-selfcare-API","private":false,"owner":{"login":"rubickcz","id":3601440,"node_id":"MDQ6VXNlcjM2MDE0NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3601440?v=4","gravatar_id":"","url":"https://api.github.com/users/rubickcz","html_url":"https://github.com/rubickcz","followers_url":"https://api.github.com/users/rubickcz/followers","following_url":"https://api.github.com/users/rubickcz/following{/other_user}","gists_url":"https://api.github.com/users/rubickcz/gists{/gist_id}","starred_url":"https://api.github.com/users/rubickcz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubickcz/subscriptions","organizations_url":"https://api.github.com/users/rubickcz/orgs","repos_url":"https://api.github.com/users/rubickcz/repos","events_url":"https://api.github.com/users/rubickcz/events{/privacy}","received_events_url":"https://api.github.com/users/rubickcz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rubickcz/mallpay-selfcare-API","description":"API description for MALL Pay self-care https://app.apiary.io/mallpayselfcareapi/","fork":true,"url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API","forks_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/forks","keys_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/teams","hooks_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/hooks","issue_events_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/issues/events{/number}","events_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/events","assignees_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/assignees{/user}","branches_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/branches{/branch}","tags_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/tags","blobs_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/statuses/{sha}","languages_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/languages","stargazers_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/stargazers","contributors_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/contributors","subscribers_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/subscribers","subscription_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/subscription","commits_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/contents/{+path}","compare_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/merges","archive_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/downloads","issues_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/issues{/number}","pulls_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/pulls{/number}","milestones_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/milestones{/number}","notifications_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/labels{/name}","releases_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/releases{/id}","deployments_url":"https://api.github.com/repos/rubickcz/mallpay-selfcare-API/deployments","created_at":"2019-03-07T13:23:03Z","updated_at":"2019-03-07T13:23:05Z","pushed_at":"2019-03-21T13:45:29Z","git_url":"git://github.com/rubickcz/mallpay-selfcare-API.git","ssh_url":"[email protected]:rubickcz/mallpay-selfcare-API.git","clone_url":"https://github.com/rubickcz/mallpay-selfcare-API.git","svn_url":"https://github.com/rubickcz/mallpay-selfcare-API","homepage":"https://mallpay.cz","size":108,"stargazers_count":0,"watchers_count":0,"language":"API Blueprint","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"usertech:master","ref":"master","sha":"83ff8ec0d35b3ac51c37bd1fe369362061c58bfd","user":{"login":"usertech","id":9248940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNDg5NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/9248940?v=4","gravatar_id":"","url":"https://api.github.com/users/usertech","html_url":"https://github.com/usertech","followers_url":"https://api.github.com/users/usertech/followers","following_url":"https://api.github.com/users/usertech/following{/other_user}","gists_url":"https://api.github.com/users/usertech/gists{/gist_id}","starred_url":"https://api.github.com/users/usertech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usertech/subscriptions","organizations_url":"https://api.github.com/users/usertech/orgs","repos_url":"https://api.github.com/users/usertech/repos","events_url":"https://api.github.com/users/usertech/events{/privacy}","received_events_url":"https://api.github.com/users/usertech/received_events","type":"Organization","site_admin":false},"repo":{"id":138702174,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3MDIxNzQ=","name":"mallpay-selfcare-API","full_name":"usertech/mallpay-selfcare-API","private":false,"owner":{"login":"usertech","id":9248940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNDg5NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/9248940?v=4","gravatar_id":"","url":"https://api.github.com/users/usertech","html_url":"https://github.com/usertech","followers_url":"https://api.github.com/users/usertech/followers","following_url":"https://api.github.com/users/usertech/following{/other_user}","gists_url":"https://api.github.com/users/usertech/gists{/gist_id}","starred_url":"https://api.github.com/users/usertech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/usertech/subscriptions","organizations_url":"https://api.github.com/users/usertech/orgs","repos_url":"https://api.github.com/users/usertech/repos","events_url":"https://api.github.com/users/usertech/events{/privacy}","received_events_url":"https://api.github.com/users/usertech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/usertech/mallpay-selfcare-API","description":"API description for MALL Pay self-care https://app.apiary.io/mallpayselfcareapi/","fork":true,"url":"https://api.github.com/repos/usertech/mallpay-selfcare-API","forks_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/forks","keys_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/keys{/key_id}","collaborators_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/teams","hooks_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/hooks","issue_events_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/issues/events{/number}","events_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/events","assignees_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/assignees{/user}","branches_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/branches{/branch}","tags_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/tags","blobs_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/git/refs{/sha}","trees_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/git/trees{/sha}","statuses_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/statuses/{sha}","languages_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/languages","stargazers_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/stargazers","contributors_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/contributors","subscribers_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/subscribers","subscription_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/subscription","commits_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/commits{/sha}","git_commits_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/git/commits{/sha}","comments_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/comments{/number}","issue_comment_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/issues/comments{/number}","contents_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/contents/{+path}","compare_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/compare/{base}...{head}","merges_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/merges","archive_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/downloads","issues_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/issues{/number}","pulls_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/pulls{/number}","milestones_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/milestones{/number}","notifications_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/labels{/name}","releases_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/releases{/id}","deployments_url":"https://api.github.com/repos/usertech/mallpay-selfcare-API/deployments","created_at":"2018-06-26T07:39:11Z","updated_at":"2019-03-26T14:46:30Z","pushed_at":"2019-03-26T14:46:28Z","git_url":"git://github.com/usertech/mallpay-selfcare-API.git","ssh_url":"[email protected]:usertech/mallpay-selfcare-API.git","clone_url":"https://github.com/usertech/mallpay-selfcare-API.git","svn_url":"https://github.com/usertech/mallpay-selfcare-API","homepage":"https://mallpay.cz","size":141,"stargazers_count":0,"watchers_count":0,"language":"API Blueprint","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":7,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/usertech/mallpay-selfcare-API/pulls/22"},"html":{"href":"https://github.com/usertech/mallpay-selfcare-API/pull/22"},"issue":{"href":"https://api.github.com/repos/usertech/mallpay-selfcare-API/issues/22"},"comments":{"href":"https://api.github.com/repos/usertech/mallpay-selfcare-API/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/usertech/mallpay-selfcare-API/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/usertech/mallpay-selfcare-API/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/usertech/mallpay-selfcare-API/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/usertech/mallpay-selfcare-API/statuses/81c5c8777bca47f09a55451073915df3de9694db"}},"author_association":"NONE"}}
|
{
"id": 138702174,
"name": "usertech/mallpay-selfcare-API",
"url": "https://api.github.com/repos/usertech/mallpay-selfcare-API"
}
|
{
"id": 2446500,
"login": "ZwickTheGreat",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/2446500?",
"url": "https://api.github.com/users/ZwickTheGreat"
}
|
{
"id": 9248940,
"login": "usertech",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9248940?",
"url": "https://api.github.com/orgs/usertech"
}
| 2019-03-26T14:50:30 |
9316879555
|
{"actor":{"display_login":"ZwickTheGreat"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/FreshRSS/FreshRSS/pulls/comments/275743792","pull_request_review_id":227125616,"id":275743792,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI3NTc0Mzc5Mg==","diff_hunk":"@@ -294,8 +348,41 @@ private static function magicQuotesOff() {\n \t\t}\n \t}\n \n+\t/**\n+\t * @return array\n+\t */\n+\tprivate static function getHeaders() {","path":"lib/Minz/Request.php","position":243,"original_position":243,"commit_id":"c25636d5f44f5a15fb41857585e762ecb31ed7c0","original_commit_id":"c25636d5f44f5a15fb41857585e762ecb31ed7c0","user":{"login":"Alkarex","id":1008324,"node_id":"MDQ6VXNlcjEwMDgzMjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1008324?v=4","gravatar_id":"","url":"https://api.github.com/users/Alkarex","html_url":"https://github.com/Alkarex","followers_url":"https://api.github.com/users/Alkarex/followers","following_url":"https://api.github.com/users/Alkarex/following{/other_user}","gists_url":"https://api.github.com/users/Alkarex/gists{/gist_id}","starred_url":"https://api.github.com/users/Alkarex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alkarex/subscriptions","organizations_url":"https://api.github.com/users/Alkarex/orgs","repos_url":"https://api.github.com/users/Alkarex/repos","events_url":"https://api.github.com/users/Alkarex/events{/privacy}","received_events_url":"https://api.github.com/users/Alkarex/received_events","type":"User","site_admin":false},"body":"What is the purpose of this function? Is seems to just make a manual copy of `$_SERVER`","created_at":"2019-04-16T11:06:54Z","updated_at":"2019-04-16T11:06:54Z","html_url":"https://github.com/FreshRSS/FreshRSS/pull/2373#discussion_r275743792","pull_request_url":"https://api.github.com/repos/FreshRSS/FreshRSS/pulls/2373","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/FreshRSS/FreshRSS/pulls/comments/275743792"},"html":{"href":"https://github.com/FreshRSS/FreshRSS/pull/2373#discussion_r275743792"},"pull_request":{"href":"https://api.github.com/repos/FreshRSS/FreshRSS/pulls/2373"}}},"pull_request":{"url":"https://api.github.com/repos/FreshRSS/FreshRSS/pulls/2373","id":269016331,"node_id":"MDExOlB1bGxSZXF1ZXN0MjY5MDE2MzMx","html_url":"https://github.com/FreshRSS/FreshRSS/pull/2373","diff_url":"https://github.com/FreshRSS/FreshRSS/pull/2373.diff","patch_url":"https://github.com/FreshRSS/FreshRSS/pull/2373.patch","issue_url":"https://api.github.com/repos/FreshRSS/FreshRSS/issues/2373","number":2373,"state":"open","locked":false,"title":"Refacto request class","user":{"login":"aledeg","id":3056148,"node_id":"MDQ6VXNlcjMwNTYxNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3056148?v=4","gravatar_id":"","url":"https://api.github.com/users/aledeg","html_url":"https://github.com/aledeg","followers_url":"https://api.github.com/users/aledeg/followers","following_url":"https://api.github.com/users/aledeg/following{/other_user}","gists_url":"https://api.github.com/users/aledeg/gists{/gist_id}","starred_url":"https://api.github.com/users/aledeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledeg/subscriptions","organizations_url":"https://api.github.com/users/aledeg/orgs","repos_url":"https://api.github.com/users/aledeg/repos","events_url":"https://api.github.com/users/aledeg/events{/privacy}","received_events_url":"https://api.github.com/users/aledeg/received_events","type":"User","site_admin":false},"body":"I split the code into more manageable chunks to make it more readable.\r\nIt's now easier to get a grasp on it. In the process, I tried to use\r\nthe yoda style notation to avoid unintentional variable assignement.\r\nI also tried to exit early to avoid many \"if\" levels.\r\n\r\nI have also added a better way to handle headers and a way to extract\r\nlanguages from the request. It will be easier to choose which language\r\nto use for i18n.","created_at":"2019-04-10T05:51:13Z","updated_at":"2019-04-16T11:06:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00f2e5937bbcfc281dc19595235ace0c2f737c67","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/FreshRSS/FreshRSS/milestones/35","html_url":"https://github.com/FreshRSS/FreshRSS/milestone/35","labels_url":"https://api.github.com/repos/FreshRSS/FreshRSS/milestones/35/labels","id":3926605,"node_id":"MDk6TWlsZXN0b25lMzkyNjYwNQ==","number":35,"title":"1.15.0","description":"","creator":{"login":"Alkarex","id":1008324,"node_id":"MDQ6VXNlcjEwMDgzMjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1008324?v=4","gravatar_id":"","url":"https://api.github.com/users/Alkarex","html_url":"https://github.com/Alkarex","followers_url":"https://api.github.com/users/Alkarex/followers","following_url":"https://api.github.com/users/Alkarex/following{/other_user}","gists_url":"https://api.github.com/users/Alkarex/gists{/gist_id}","starred_url":"https://api.github.com/users/Alkarex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alkarex/subscriptions","organizations_url":"https://api.github.com/users/Alkarex/orgs","repos_url":"https://api.github.com/users/Alkarex/repos","events_url":"https://api.github.com/users/Alkarex/events{/privacy}","received_events_url":"https://api.github.com/users/Alkarex/received_events","type":"User","site_admin":false},"open_issues":53,"closed_issues":3,"state":"open","created_at":"2018-12-27T22:04:45Z","updated_at":"2019-04-16T10:49:08Z","due_on":"2019-06-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/FreshRSS/FreshRSS/pulls/2373/commits","review_comments_url":"https://api.github.com/repos/FreshRSS/FreshRSS/pulls/2373/comments","review_comment_url":"https://api.github.com/repos/FreshRSS/FreshRSS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreshRSS/FreshRSS/issues/2373/comments","statuses_url":"https://api.github.com/repos/FreshRSS/FreshRSS/statuses/c25636d5f44f5a15fb41857585e762ecb31ed7c0","head":{"label":"aledeg:feature/update-request","ref":"feature/update-request","sha":"c25636d5f44f5a15fb41857585e762ecb31ed7c0","user":{"login":"aledeg","id":3056148,"node_id":"MDQ6VXNlcjMwNTYxNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3056148?v=4","gravatar_id":"","url":"https://api.github.com/users/aledeg","html_url":"https://github.com/aledeg","followers_url":"https://api.github.com/users/aledeg/followers","following_url":"https://api.github.com/users/aledeg/following{/other_user}","gists_url":"https://api.github.com/users/aledeg/gists{/gist_id}","starred_url":"https://api.github.com/users/aledeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledeg/subscriptions","organizations_url":"https://api.github.com/users/aledeg/orgs","repos_url":"https://api.github.com/users/aledeg/repos","events_url":"https://api.github.com/users/aledeg/events{/privacy}","received_events_url":"https://api.github.com/users/aledeg/received_events","type":"User","site_admin":false},"repo":{"id":14469014,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2OTAxNA==","name":"FreshRSS","full_name":"aledeg/FreshRSS","private":false,"owner":{"login":"aledeg","id":3056148,"node_id":"MDQ6VXNlcjMwNTYxNDg=","avatar_url":"https://avatars1.githubusercontent.com/u/3056148?v=4","gravatar_id":"","url":"https://api.github.com/users/aledeg","html_url":"https://github.com/aledeg","followers_url":"https://api.github.com/users/aledeg/followers","following_url":"https://api.github.com/users/aledeg/following{/other_user}","gists_url":"https://api.github.com/users/aledeg/gists{/gist_id}","starred_url":"https://api.github.com/users/aledeg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledeg/subscriptions","organizations_url":"https://api.github.com/users/aledeg/orgs","repos_url":"https://api.github.com/users/aledeg/repos","events_url":"https://api.github.com/users/aledeg/events{/privacy}","received_events_url":"https://api.github.com/users/aledeg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aledeg/FreshRSS","description":"Un agrégateur de flux RSS à auto-héberger","fork":true,"url":"https://api.github.com/repos/aledeg/FreshRSS","forks_url":"https://api.github.com/repos/aledeg/FreshRSS/forks","keys_url":"https://api.github.com/repos/aledeg/FreshRSS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aledeg/FreshRSS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aledeg/FreshRSS/teams","hooks_url":"https://api.github.com/repos/aledeg/FreshRSS/hooks","issue_events_url":"https://api.github.com/repos/aledeg/FreshRSS/issues/events{/number}","events_url":"https://api.github.com/repos/aledeg/FreshRSS/events","assignees_url":"https://api.github.com/repos/aledeg/FreshRSS/assignees{/user}","branches_url":"https://api.github.com/repos/aledeg/FreshRSS/branches{/branch}","tags_url":"https://api.github.com/repos/aledeg/FreshRSS/tags","blobs_url":"https://api.github.com/repos/aledeg/FreshRSS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aledeg/FreshRSS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aledeg/FreshRSS/git/refs{/sha}","trees_url":"https://api.github.com/repos/aledeg/FreshRSS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aledeg/FreshRSS/statuses/{sha}","languages_url":"https://api.github.com/repos/aledeg/FreshRSS/languages","stargazers_url":"https://api.github.com/repos/aledeg/FreshRSS/stargazers","contributors_url":"https://api.github.com/repos/aledeg/FreshRSS/contributors","subscribers_url":"https://api.github.com/repos/aledeg/FreshRSS/subscribers","subscription_url":"https://api.github.com/repos/aledeg/FreshRSS/subscription","commits_url":"https://api.github.com/repos/aledeg/FreshRSS/commits{/sha}","git_commits_url":"https://api.github.com/repos/aledeg/FreshRSS/git/commits{/sha}","comments_url":"https://api.github.com/repos/aledeg/FreshRSS/comments{/number}","issue_comment_url":"https://api.github.com/repos/aledeg/FreshRSS/issues/comments{/number}","contents_url":"https://api.github.com/repos/aledeg/FreshRSS/contents/{+path}","compare_url":"https://api.github.com/repos/aledeg/FreshRSS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aledeg/FreshRSS/merges","archive_url":"https://api.github.com/repos/aledeg/FreshRSS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aledeg/FreshRSS/downloads","issues_url":"https://api.github.com/repos/aledeg/FreshRSS/issues{/number}","pulls_url":"https://api.github.com/repos/aledeg/FreshRSS/pulls{/number}","milestones_url":"https://api.github.com/repos/aledeg/FreshRSS/milestones{/number}","notifications_url":"https://api.github.com/repos/aledeg/FreshRSS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aledeg/FreshRSS/labels{/name}","releases_url":"https://api.github.com/repos/aledeg/FreshRSS/releases{/id}","deployments_url":"https://api.github.com/repos/aledeg/FreshRSS/deployments","created_at":"2013-11-17T15:20:47Z","updated_at":"2014-08-28T15:12:29Z","pushed_at":"2019-04-16T06:31:41Z","git_url":"git://github.com/aledeg/FreshRSS.git","ssh_url":"[email protected]:aledeg/FreshRSS.git","clone_url":"https://github.com/aledeg/FreshRSS.git","svn_url":"https://github.com/aledeg/FreshRSS","homepage":"http://marienfressinaud.github.io/FreshRSS/","size":11488,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"beta"}},"base":{"label":"FreshRSS:dev","ref":"dev","sha":"1d933dfe1303a34a7d23ba4721a5eaa9d2b641ce","user":{"login":"FreshRSS","id":9414285,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0MTQyODU=","avatar_url":"https://avatars1.githubusercontent.com/u/9414285?v=4","gravatar_id":"","url":"https://api.github.com/users/FreshRSS","html_url":"https://github.com/FreshRSS","followers_url":"https://api.github.com/users/FreshRSS/followers","following_url":"https://api.github.com/users/FreshRSS/following{/other_user}","gists_url":"https://api.github.com/users/FreshRSS/gists{/gist_id}","starred_url":"https://api.github.com/users/FreshRSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreshRSS/subscriptions","organizations_url":"https://api.github.com/users/FreshRSS/orgs","repos_url":"https://api.github.com/users/FreshRSS/repos","events_url":"https://api.github.com/users/FreshRSS/events{/privacy}","received_events_url":"https://api.github.com/users/FreshRSS/received_events","type":"Organization","site_admin":false},"repo":{"id":6322699,"node_id":"MDEwOlJlcG9zaXRvcnk2MzIyNjk5","name":"FreshRSS","full_name":"FreshRSS/FreshRSS","private":false,"owner":{"login":"FreshRSS","id":9414285,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0MTQyODU=","avatar_url":"https://avatars1.githubusercontent.com/u/9414285?v=4","gravatar_id":"","url":"https://api.github.com/users/FreshRSS","html_url":"https://github.com/FreshRSS","followers_url":"https://api.github.com/users/FreshRSS/followers","following_url":"https://api.github.com/users/FreshRSS/following{/other_user}","gists_url":"https://api.github.com/users/FreshRSS/gists{/gist_id}","starred_url":"https://api.github.com/users/FreshRSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreshRSS/subscriptions","organizations_url":"https://api.github.com/users/FreshRSS/orgs","repos_url":"https://api.github.com/users/FreshRSS/repos","events_url":"https://api.github.com/users/FreshRSS/events{/privacy}","received_events_url":"https://api.github.com/users/FreshRSS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FreshRSS/FreshRSS","description":"A free, self-hostable aggregator…","fork":false,"url":"https://api.github.com/repos/FreshRSS/FreshRSS","forks_url":"https://api.github.com/repos/FreshRSS/FreshRSS/forks","keys_url":"https://api.github.com/repos/FreshRSS/FreshRSS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreshRSS/FreshRSS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreshRSS/FreshRSS/teams","hooks_url":"https://api.github.com/repos/FreshRSS/FreshRSS/hooks","issue_events_url":"https://api.github.com/repos/FreshRSS/FreshRSS/issues/events{/number}","events_url":"https://api.github.com/repos/FreshRSS/FreshRSS/events","assignees_url":"https://api.github.com/repos/FreshRSS/FreshRSS/assignees{/user}","branches_url":"https://api.github.com/repos/FreshRSS/FreshRSS/branches{/branch}","tags_url":"https://api.github.com/repos/FreshRSS/FreshRSS/tags","blobs_url":"https://api.github.com/repos/FreshRSS/FreshRSS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreshRSS/FreshRSS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreshRSS/FreshRSS/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreshRSS/FreshRSS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreshRSS/FreshRSS/statuses/{sha}","languages_url":"https://api.github.com/repos/FreshRSS/FreshRSS/languages","stargazers_url":"https://api.github.com/repos/FreshRSS/FreshRSS/stargazers","contributors_url":"https://api.github.com/repos/FreshRSS/FreshRSS/contributors","subscribers_url":"https://api.github.com/repos/FreshRSS/FreshRSS/subscribers","subscription_url":"https://api.github.com/repos/FreshRSS/FreshRSS/subscription","commits_url":"https://api.github.com/repos/FreshRSS/FreshRSS/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreshRSS/FreshRSS/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreshRSS/FreshRSS/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreshRSS/FreshRSS/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreshRSS/FreshRSS/contents/{+path}","compare_url":"https://api.github.com/repos/FreshRSS/FreshRSS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreshRSS/FreshRSS/merges","archive_url":"https://api.github.com/repos/FreshRSS/FreshRSS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreshRSS/FreshRSS/downloads","issues_url":"https://api.github.com/repos/FreshRSS/FreshRSS/issues{/number}","pulls_url":"https://api.github.com/repos/FreshRSS/FreshRSS/pulls{/number}","milestones_url":"https://api.github.com/repos/FreshRSS/FreshRSS/milestones{/number}","notifications_url":"https://api.github.com/repos/FreshRSS/FreshRSS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreshRSS/FreshRSS/labels{/name}","releases_url":"https://api.github.com/repos/FreshRSS/FreshRSS/releases{/id}","deployments_url":"https://api.github.com/repos/FreshRSS/FreshRSS/deployments","created_at":"2012-10-21T16:48:50Z","updated_at":"2019-04-14T21:42:05Z","pushed_at":"2019-04-16T10:15:19Z","git_url":"git://github.com/FreshRSS/FreshRSS.git","ssh_url":"[email protected]:FreshRSS/FreshRSS.git","clone_url":"https://github.com/FreshRSS/FreshRSS.git","svn_url":"https://github.com/FreshRSS/FreshRSS","homepage":"http://freshrss.org","size":11445,"stargazers_count":1457,"watchers_count":1457,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":204,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":241,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":204,"open_issues":241,"watchers":1457,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreshRSS/FreshRSS/pulls/2373"},"html":{"href":"https://github.com/FreshRSS/FreshRSS/pull/2373"},"issue":{"href":"https://api.github.com/repos/FreshRSS/FreshRSS/issues/2373"},"comments":{"href":"https://api.github.com/repos/FreshRSS/FreshRSS/issues/2373/comments"},"review_comments":{"href":"https://api.github.com/repos/FreshRSS/FreshRSS/pulls/2373/comments"},"review_comment":{"href":"https://api.github.com/repos/FreshRSS/FreshRSS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreshRSS/FreshRSS/pulls/2373/commits"},"statuses":{"href":"https://api.github.com/repos/FreshRSS/FreshRSS/statuses/c25636d5f44f5a15fb41857585e762ecb31ed7c0"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 6322699,
"name": "FreshRSS/FreshRSS",
"url": "https://api.github.com/repos/FreshRSS/FreshRSS"
}
|
{
"id": 1008324,
"login": "Alkarex",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/1008324?",
"url": "https://api.github.com/users/Alkarex"
}
|
{
"id": 9414285,
"login": "FreshRSS",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9414285?",
"url": "https://api.github.com/orgs/FreshRSS"
}
| 2019-04-16T11:06:54 |
9452249478
|
{"actor":{"display_login":"Alkarex"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/306391877","pull_request_review_id":265501354,"id":306391877,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwNjM5MTg3Nw==","diff_hunk":"@@ -0,0 +1,256 @@\n+/*\n+ * Copyright 2019 Confluent Inc.\n+ *\n+ * Licensed under the Confluent Community License (the \"License\"; you may not use\n+ * this file except in compliance with the License. You may obtain a copy of the\n+ * License at\n+ *\n+ * http://www.confluent.io/confluent-community-license\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OF ANY KIND, either express or implied. See the License for the\n+ * specific language governing permissions and limitations under the License.\n+ */\n+\n+package io.confluent.ksql.function;\n+\n+import com.google.common.collect.ImmutableMap;\n+import com.google.common.collect.ImmutableSet;\n+import com.google.common.collect.Sets;\n+import io.confluent.ksql.util.KsqlException;\n+import io.confluent.ksql.util.KsqlPreconditions;\n+import java.util.ArrayList;\n+import java.util.Collection;\n+import java.util.HashMap;\n+import java.util.List;\n+import java.util.Map;\n+import java.util.Map.Entry;\n+import java.util.Set;\n+import java.util.regex.Matcher;\n+import java.util.regex.Pattern;\n+import java.util.stream.Collectors;\n+import org.apache.kafka.connect.data.Field;\n+import org.apache.kafka.connect.data.Schema;\n+import org.apache.kafka.connect.data.SchemaBuilder;\n+\n+public final class GenericsUtil {\n+\n+ private static final String PREFIX = \"<\";\n+ private static final String SUFFIX = \">\";\n+ private static final Pattern GENERIC_PATTERN = Pattern.compile(\"<(?<name>.*)>\");\n+\n+ private GenericsUtil() { }\n+\n+ /**\n+ * @param typeName the generic type name (e.g. {@code T})\n+ * @return a {@link SchemaBuilder} for a generic type with that name\n+ */\n+ public static SchemaBuilder generic(final String typeName) {\n+ return SchemaBuilder.bytes().optional().name(PREFIX + typeName + SUFFIX);\n+ }\n+\n+ /**\n+ * @param typeName the generic type name (e.g. {@code T})\n+ * @return a {@link SchemaBuilder} for a generic array with generic element type\n+ */\n+ public static SchemaBuilder array(final String typeName) {\n+ return SchemaBuilder.array(generic(typeName).build()).optional();\n+ }\n+\n+ /**\n+ * @param keyType the type for the map key\n+ * @param valueTypeName the generic type name (e.g. {@code T}) for the map value\n+ * @return a {@link SchemaBuilder} for a map with {@code keyType} keys and generic value type\n+ */\n+ public static SchemaBuilder map(final Schema keyType, final String valueTypeName) {\n+ return SchemaBuilder.map(keyType, generic(valueTypeName).build()).optional();\n+ }\n+\n+ /**\n+ * @param type the type\n+ * @return whether or not {@code type} is a generic type\n+ * @apiNote container generics (e.g. {@code ARRAY<T>}) will return {@code false},\n+ * use {@link #constituentGenerics(Schema)}\n+ */\n+ public static boolean isGeneric(final Schema type) {\n+ return type.name() != null\n+ && type.name().startsWith(PREFIX)\n+ && type.name().endsWith(SUFFIX);\n+ }\n+\n+ /**\n+ * @param type the type\n+ * @return all generics contained within the type, for example: {@code Map<K, V>} would return\n+ * a set containing {@code {<K>, <V>}}\n+ */\n+ public static Set<Schema> constituentGenerics(final Schema type) {\n+ switch (type.type()) {\n+ case ARRAY:\n+ return constituentGenerics(type.valueSchema());\n+ case MAP:\n+ return Sets.union(\n+ constituentGenerics(type.keySchema()),\n+ constituentGenerics(type.valueSchema()));\n+ case STRUCT:\n+ return type.fields().stream()\n+ .map(Field::schema)\n+ .map(GenericsUtil::constituentGenerics)\n+ .flatMap(Collection::stream)\n+ .collect(Collectors.toSet());\n+ case BYTES:\n+ if (isGeneric(type)) {\n+ return ImmutableSet.of(type);\n+ }\n+ return ImmutableSet.of();\n+ default:\n+ return ImmutableSet.of();\n+ }\n+ }\n+\n+ /**\n+ * Replaces all generics in a schema with concrete schemas defined in {@code mapping}\n+ *\n+ * @param schema the schema which may contain generics\n+ * @param mapping the mapping from generics to resolved types\n+ * @return a schema with the same structure as {@code schema} but with no generics\n+ *\n+ * @throws KsqlException if there is a generic in {@code schema} that is not present\n+ * in {@code mapping}\n+ */\n+ public static Schema resolve(final Schema schema, final Map<Schema, Schema> mapping) {\n+ switch (schema.type()) {\n+ case ARRAY:\n+ return SchemaBuilder\n+ .array(resolve(schema.valueSchema(), mapping))\n+ .optional()\n+ .build();\n+ case MAP:\n+ return SchemaBuilder\n+ .map(resolve(schema.keySchema(), mapping), resolve(schema.valueSchema(), mapping))\n+ .optional()\n+ .build();\n+ case BYTES:\n+ if (!isGeneric(schema)) {\n+ return schema;\n+ }\n+\n+ final Schema resolved = mapping.get(schema);\n+ if (resolved == null) {\n+ throw new KsqlException(\"Could not find mapping for generic type: \" + schema);\n+ }\n+ return resolved;\n+ default:\n+ return schema;\n+ }\n+ }\n+\n+ /**\n+ * Identifies a mapping from generic type to concrete type based on a {@code schema} and\n+ * an {@code instance}, where the {@code instance} schema is expected to have no generic\n+ * types and have the same nested structure as {@code schema}.\n+ *\n+ * @param schema the schema that may contain generics\n+ * @param instance a schema with the same structure as {@code schema} but with no generics\n+ *\n+ * @return a mapping from generic type to resolved type\n+ */\n+ public static Map<Schema, Schema> identifyGenerics(\n+ final Schema schema,\n+ final Schema instance\n+ ) {\n+ final List<Entry<Schema, Schema>> genericMapping = new ArrayList<>();\n+ final boolean success = identifyGenerics(genericMapping, schema, instance);\n+ if (!success) {\n+ throw new KsqlException(\n+ String.format(\"Cannot infer generics for %s from %s because \"\n+ + \"they do not have the same schema structure.\",\n+ schema,\n+ instance));\n+ }\n+\n+ final Map<Schema, Schema> mapping = new HashMap<>();\n+ for (final Entry<Schema, Schema> entry : genericMapping) {\n+ final Schema old = mapping.putIfAbsent(entry.getKey(), entry.getValue());\n+ if (old != null && !old.equals(entry.getValue())) {\n+ throw new KsqlException(String.format(\n+ \"Found invalid instance of generic schema. Cannot map %s to both %s and %s\",\n+ schema.name(),\n+ old,\n+ instance));\n+ }\n+ }\n+\n+ return ImmutableMap.copyOf(mapping);\n+ }\n+\n+ private static boolean identifyGenerics(\n+ final List<Entry<Schema, Schema>> mapping,\n+ final Schema schema,\n+ final Schema instance\n+ ) {\n+ if (!isGeneric(schema) && instance.type() != schema.type()) {\n+ // cannot identify from type mismatch\n+ return false;\n+ } else if (constituentGenerics(schema).isEmpty()) {\n+ // nothing left to identify\n+ return true;\n+ }\n+\n+ KsqlPreconditions.checkArgument(\n+ isGeneric(schema) || (instance.type() == schema.type()),\n+ \"Cannot resolve generics if the schema and instance have differing types: \"\n+ + schema + \" vs. \" + instance);\n+ switch (schema.type()) {\n+ case BYTES:\n+ mapping.add(new HashMap.SimpleEntry<>(schema, instance));\n+ return true;\n+ case ARRAY:\n+ return identifyGenerics(mapping, schema.valueSchema(), instance.valueSchema());\n+ case MAP:\n+ return identifyGenerics(mapping, schema.keySchema(), instance.keySchema())\n+ && identifyGenerics(mapping, schema.valueSchema(), instance.valueSchema());\n+ case STRUCT:\n+ throw new KsqlException(\"Generic STRUCT is not yet supported\");\n+ default:\n+ return true;\n+ }\n+ }\n+\n+ /**\n+ * @param schema the schema with generics\n+ * @param instance a schema without generics\n+ * @return whether {@code instance} conforms to the structure of {@code schema}\n+ */\n+ public static boolean instanceOf(final Schema schema, final Schema instance) {\n+ final List<Entry<Schema, Schema>> mappings = new ArrayList<>();\n+\n+ if (!identifyGenerics(mappings, schema, instance)) {\n+ return false;\n+ }\n+\n+ final Map<Schema, Schema> asMap = new HashMap<>();\n+ for (final Entry<Schema, Schema> entry : mappings) {\n+ final Schema old = asMap.putIfAbsent(entry.getKey(), entry.getValue());\n+ if (old != null && !old.equals(entry.getValue())) {\n+ return false;\n+ }\n+ }\n+\n+ return Sets.difference(constituentGenerics(schema), asMap.keySet()).isEmpty();","path":"ksql-common/src/main/java/io/confluent/ksql/function/GenericsUtil.java","position":240,"original_position":240,"commit_id":"255354f9855711581eb8b3436438646aad315e6c","original_commit_id":"255354f9855711581eb8b3436438646aad315e6c","user":{"login":"agavra","id":3172405,"node_id":"MDQ6VXNlcjMxNzI0MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3172405?v=4","gravatar_id":"","url":"https://api.github.com/users/agavra","html_url":"https://github.com/agavra","followers_url":"https://api.github.com/users/agavra/followers","following_url":"https://api.github.com/users/agavra/following{/other_user}","gists_url":"https://api.github.com/users/agavra/gists{/gist_id}","starred_url":"https://api.github.com/users/agavra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agavra/subscriptions","organizations_url":"https://api.github.com/users/agavra/orgs","repos_url":"https://api.github.com/users/agavra/repos","events_url":"https://api.github.com/users/agavra/events{/privacy}","received_events_url":"https://api.github.com/users/agavra/received_events","type":"User","site_admin":false},"body":"`asMap` represents the \"resolved\" generics. if every one of the constituent generics exists in the mapping of resolved generics, then this would be true (e.g. `constituents(Map<K,V>) ~ {K:String, V:Integer}` would be `true` because `K` and `V` are both represented)\r\n\r\nif you meant to ask when this would ever be `false`, then you're right - I'm not actually sure it'll ever be `false`","created_at":"2019-07-23T15:40:33Z","updated_at":"2019-07-23T15:40:33Z","html_url":"https://github.com/confluentinc/ksql/pull/3054#discussion_r306391877","pull_request_url":"https://api.github.com/repos/confluentinc/ksql/pulls/3054","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/306391877"},"html":{"href":"https://github.com/confluentinc/ksql/pull/3054#discussion_r306391877"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/3054"}},"in_reply_to_id":306086957},"pull_request":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/3054","id":294336734,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjk0MzM2NzM0","html_url":"https://github.com/confluentinc/ksql/pull/3054","diff_url":"https://github.com/confluentinc/ksql/pull/3054.diff","patch_url":"https://github.com/confluentinc/ksql/pull/3054.patch","issue_url":"https://api.github.com/repos/confluentinc/ksql/issues/3054","number":3054,"state":"open","locked":false,"title":"feat(udfs): generic support for lists/maps in UDFs","user":{"login":"agavra","id":3172405,"node_id":"MDQ6VXNlcjMxNzI0MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3172405?v=4","gravatar_id":"","url":"https://api.github.com/users/agavra","html_url":"https://github.com/agavra","followers_url":"https://api.github.com/users/agavra/followers","following_url":"https://api.github.com/users/agavra/following{/other_user}","gists_url":"https://api.github.com/users/agavra/gists{/gist_id}","starred_url":"https://api.github.com/users/agavra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agavra/subscriptions","organizations_url":"https://api.github.com/users/agavra/orgs","repos_url":"https://api.github.com/users/agavra/repos","events_url":"https://api.github.com/users/agavra/events{/privacy}","received_events_url":"https://api.github.com/users/agavra/received_events","type":"User","site_admin":false},"body":"### Description \r\n\r\n**NOTE:** _This PR looks large, but the entire non-test, non-description functionality is under 500 lines and contained to a few files (see description below)._\r\n\r\nThis change adds support for a single generic in UDFs so that container types are more accessible in our UDF framework. For example, the following UDF can now be used to create a map from two lists, the second of which has a generic type (see the QTT test for this UDF for an example):\r\n```java\r\n @Udf\r\n public final <T> Map<String, T> asMap(\r\n @UdfParameter final List<String> keys,\r\n @UdfParameter final List<T> values) {\r\n final Map<String, T> map = new HashMap<>();\r\n for (int i = 0; i < keys.size(); i++) {\r\n map.putIfAbsent(keys.get(i), values.get(i));\r\n }\r\n return map;\r\n }\r\n```\r\n\r\nTo do this, the following changes were made:\r\n- when resolving the return type from a method, `KsqlFunction` will apply some logic to resolve any generics in the return type based on the actual argument types being passed in\r\n- `UdfIndex` will index generic types, and will traverse the trie for any input\r\n- Generics are represented as BYTES with schema name `GENERIC:<name>`. If we ever move to our own type system (i.e. not connect) this can have first class support\r\n- `GenericsUtil` and `JavaToConnect` have all of the magic, take a look there\r\n- some UDFs to showcase this feature were added: `SUBLIST`, `AS_LIST` and `AS_MAP`\r\n- Some `SchemaUtil` methods were moved to `JavaToConnect` (and corresponding tests were moved as well)\r\n\r\n### Missing\r\n\r\n- [ ] DESCRIBE functionality\r\n\r\n### Testing done \r\n\r\n- unit tets\r\n- QTTs with some sample UDFs\r\n\r\n### Reviewer checklist\r\n- [ ] Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).\r\n- [ ] Ensure relevant issues are linked (description should include text like \"Fixes #<issue number>\")\r\n\r\n","created_at":"2019-07-03T21:27:53Z","updated_at":"2019-07-23T15:40:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d6057177ededbf34ff392af8d1c100440c4798e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"blueedgenick","id":4551840,"node_id":"MDQ6VXNlcjQ1NTE4NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/4551840?v=4","gravatar_id":"","url":"https://api.github.com/users/blueedgenick","html_url":"https://github.com/blueedgenick","followers_url":"https://api.github.com/users/blueedgenick/followers","following_url":"https://api.github.com/users/blueedgenick/following{/other_user}","gists_url":"https://api.github.com/users/blueedgenick/gists{/gist_id}","starred_url":"https://api.github.com/users/blueedgenick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueedgenick/subscriptions","organizations_url":"https://api.github.com/users/blueedgenick/orgs","repos_url":"https://api.github.com/users/blueedgenick/repos","events_url":"https://api.github.com/users/blueedgenick/events{/privacy}","received_events_url":"https://api.github.com/users/blueedgenick/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/ksql/pulls/3054/commits","review_comments_url":"https://api.github.com/repos/confluentinc/ksql/pulls/3054/comments","review_comment_url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/ksql/issues/3054/comments","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/255354f9855711581eb8b3436438646aad315e6c","head":{"label":"agavra:generics_udf","ref":"generics_udf","sha":"255354f9855711581eb8b3436438646aad315e6c","user":{"login":"agavra","id":3172405,"node_id":"MDQ6VXNlcjMxNzI0MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3172405?v=4","gravatar_id":"","url":"https://api.github.com/users/agavra","html_url":"https://github.com/agavra","followers_url":"https://api.github.com/users/agavra/followers","following_url":"https://api.github.com/users/agavra/following{/other_user}","gists_url":"https://api.github.com/users/agavra/gists{/gist_id}","starred_url":"https://api.github.com/users/agavra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agavra/subscriptions","organizations_url":"https://api.github.com/users/agavra/orgs","repos_url":"https://api.github.com/users/agavra/repos","events_url":"https://api.github.com/users/agavra/events{/privacy}","received_events_url":"https://api.github.com/users/agavra/received_events","type":"User","site_admin":false},"repo":{"id":165937295,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU5MzcyOTU=","name":"ksql","full_name":"agavra/ksql","private":false,"owner":{"login":"agavra","id":3172405,"node_id":"MDQ6VXNlcjMxNzI0MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3172405?v=4","gravatar_id":"","url":"https://api.github.com/users/agavra","html_url":"https://github.com/agavra","followers_url":"https://api.github.com/users/agavra/followers","following_url":"https://api.github.com/users/agavra/following{/other_user}","gists_url":"https://api.github.com/users/agavra/gists{/gist_id}","starred_url":"https://api.github.com/users/agavra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agavra/subscriptions","organizations_url":"https://api.github.com/users/agavra/orgs","repos_url":"https://api.github.com/users/agavra/repos","events_url":"https://api.github.com/users/agavra/events{/privacy}","received_events_url":"https://api.github.com/users/agavra/received_events","type":"User","site_admin":false},"html_url":"https://github.com/agavra/ksql","description":"KSQL - the Streaming SQL Engine for Apache Kafka ","fork":true,"url":"https://api.github.com/repos/agavra/ksql","forks_url":"https://api.github.com/repos/agavra/ksql/forks","keys_url":"https://api.github.com/repos/agavra/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agavra/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agavra/ksql/teams","hooks_url":"https://api.github.com/repos/agavra/ksql/hooks","issue_events_url":"https://api.github.com/repos/agavra/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/agavra/ksql/events","assignees_url":"https://api.github.com/repos/agavra/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/agavra/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/agavra/ksql/tags","blobs_url":"https://api.github.com/repos/agavra/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agavra/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agavra/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/agavra/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agavra/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/agavra/ksql/languages","stargazers_url":"https://api.github.com/repos/agavra/ksql/stargazers","contributors_url":"https://api.github.com/repos/agavra/ksql/contributors","subscribers_url":"https://api.github.com/repos/agavra/ksql/subscribers","subscription_url":"https://api.github.com/repos/agavra/ksql/subscription","commits_url":"https://api.github.com/repos/agavra/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/agavra/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/agavra/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/agavra/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/agavra/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/agavra/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agavra/ksql/merges","archive_url":"https://api.github.com/repos/agavra/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agavra/ksql/downloads","issues_url":"https://api.github.com/repos/agavra/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/agavra/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/agavra/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/agavra/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agavra/ksql/labels{/name}","releases_url":"https://api.github.com/repos/agavra/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/agavra/ksql/deployments","created_at":"2019-01-15T23:06:24Z","updated_at":"2019-06-29T00:14:31Z","pushed_at":"2019-07-22T20:35:32Z","git_url":"git://github.com/agavra/ksql.git","ssh_url":"[email protected]:agavra/ksql.git","clone_url":"https://github.com/agavra/ksql.git","svn_url":"https://github.com/agavra/ksql","homepage":"","size":28229,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"confluentinc:master","ref":"master","sha":"2c4fa37bc35d643029d6d159d499cf33d5a4e61a","user":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":69400326,"node_id":"MDEwOlJlcG9zaXRvcnk2OTQwMDMyNg==","name":"ksql","full_name":"confluentinc/ksql","private":false,"owner":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/confluentinc/ksql","description":"KSQL - the Streaming SQL Engine for Apache Kafka ","fork":false,"url":"https://api.github.com/repos/confluentinc/ksql","forks_url":"https://api.github.com/repos/confluentinc/ksql/forks","keys_url":"https://api.github.com/repos/confluentinc/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/ksql/teams","hooks_url":"https://api.github.com/repos/confluentinc/ksql/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/ksql/events","assignees_url":"https://api.github.com/repos/confluentinc/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/ksql/tags","blobs_url":"https://api.github.com/repos/confluentinc/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/ksql/languages","stargazers_url":"https://api.github.com/repos/confluentinc/ksql/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/ksql/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/ksql/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/ksql/subscription","commits_url":"https://api.github.com/repos/confluentinc/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/ksql/merges","archive_url":"https://api.github.com/repos/confluentinc/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/ksql/downloads","issues_url":"https://api.github.com/repos/confluentinc/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/ksql/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/ksql/deployments","created_at":"2016-09-27T21:30:15Z","updated_at":"2019-07-23T10:21:39Z","pushed_at":"2019-07-23T14:37:51Z","git_url":"git://github.com/confluentinc/ksql.git","ssh_url":"[email protected]:confluentinc/ksql.git","clone_url":"https://github.com/confluentinc/ksql.git","svn_url":"https://github.com/confluentinc/ksql","homepage":"","size":28632,"stargazers_count":2352,"watchers_count":2352,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":489,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":554,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":489,"open_issues":554,"watchers":2352,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/3054"},"html":{"href":"https://github.com/confluentinc/ksql/pull/3054"},"issue":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/3054"},"comments":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/3054/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/3054/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/3054/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/ksql/statuses/255354f9855711581eb8b3436438646aad315e6c"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 69400326,
"name": "confluentinc/ksql",
"url": "https://api.github.com/repos/confluentinc/ksql"
}
|
{
"id": 3172405,
"login": "agavra",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3172405?",
"url": "https://api.github.com/users/agavra"
}
|
{
"id": 9439498,
"login": "confluentinc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9439498?",
"url": "https://api.github.com/orgs/confluentinc"
}
| 2019-07-23T15:40:33 |
10067691804
|
{"actor":{"display_login":"agavra"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/pulls/comments/339892219","pull_request_review_id":308273025,"id":339892219,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMzOTg5MjIxOQ==","diff_hunk":"@@ -136,10 +134,11 @@ public void shouldAllowStateStoreAccessFromDSL() {\n streamsConfiguration.put(StreamsConfig.STATE_DIR_CONFIG, TestUtils.tempDirectory().getAbsolutePath());\n \n // Create a state store manually.\n- final StoreBuilder<KeyValueStore<String, Long>> wordCountsStore = Stores.keyValueStoreBuilder(\n- Stores.persistentKeyValueStore(\"WordCountsStore\"),\n- Serdes.String(),\n- Serdes.Long())\n+ final StoreBuilder<KeyValueStore<String, Long>> wordCountsStore = Stores\n+ .keyValueStoreBuilder(\n+ Stores.persistentKeyValueStore(\"WordCountsStore\"),\n+ Serdes.String(),\n+ Serdes.Long())","path":"src/test/java/io/confluent/examples/streams/StateStoresInTheDSLIntegrationTest.java","position":28,"original_position":28,"commit_id":"a4467df974ddfd7ac1044065558f157ae10622b3","original_commit_id":"a4467df974ddfd7ac1044065558f157ae10622b3","user":{"login":"mjsax","id":8959638,"node_id":"MDQ6VXNlcjg5NTk2Mzg=","avatar_url":"https://avatars1.githubusercontent.com/u/8959638?v=4","gravatar_id":"","url":"https://api.github.com/users/mjsax","html_url":"https://github.com/mjsax","followers_url":"https://api.github.com/users/mjsax/followers","following_url":"https://api.github.com/users/mjsax/following{/other_user}","gists_url":"https://api.github.com/users/mjsax/gists{/gist_id}","starred_url":"https://api.github.com/users/mjsax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjsax/subscriptions","organizations_url":"https://api.github.com/users/mjsax/orgs","repos_url":"https://api.github.com/users/mjsax/repos","events_url":"https://api.github.com/users/mjsax/events{/privacy}","received_events_url":"https://api.github.com/users/mjsax/received_events","type":"User","site_admin":false},"body":"fix indentation only","created_at":"2019-10-29T04:43:34Z","updated_at":"2019-10-29T04:43:34Z","html_url":"https://github.com/confluentinc/kafka-streams-examples/pull/301#discussion_r339892219","pull_request_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/pulls/301","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/kafka-streams-examples/pulls/comments/339892219"},"html":{"href":"https://github.com/confluentinc/kafka-streams-examples/pull/301#discussion_r339892219"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/kafka-streams-examples/pulls/301"}}},"pull_request":{"url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/pulls/301","id":333429888,"node_id":"MDExOlB1bGxSZXF1ZXN0MzMzNDI5ODg4","html_url":"https://github.com/confluentinc/kafka-streams-examples/pull/301","diff_url":"https://github.com/confluentinc/kafka-streams-examples/pull/301.diff","patch_url":"https://github.com/confluentinc/kafka-streams-examples/pull/301.patch","issue_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/issues/301","number":301,"state":"open","locked":false,"title":"Rewrite tests to use new KIP-470 API","user":{"login":"mjsax","id":8959638,"node_id":"MDQ6VXNlcjg5NTk2Mzg=","avatar_url":"https://avatars1.githubusercontent.com/u/8959638?v=4","gravatar_id":"","url":"https://api.github.com/users/mjsax","html_url":"https://github.com/mjsax","followers_url":"https://api.github.com/users/mjsax/followers","following_url":"https://api.github.com/users/mjsax/following{/other_user}","gists_url":"https://api.github.com/users/mjsax/gists{/gist_id}","starred_url":"https://api.github.com/users/mjsax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjsax/subscriptions","organizations_url":"https://api.github.com/users/mjsax/orgs","repos_url":"https://api.github.com/users/mjsax/repos","events_url":"https://api.github.com/users/mjsax/events{/privacy}","received_events_url":"https://api.github.com/users/mjsax/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-10-29T04:38:42Z","updated_at":"2019-10-29T04:43:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fedbf2c78ca22345e4d76cefc2a6abec02cbd595","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"streams","id":2063464,"node_id":"MDQ6VGVhbTIwNjM0NjQ=","slug":"streams","description":"Kafka Streams","privacy":"closed","url":"https://api.github.com/teams/2063464","html_url":"https://github.com/orgs/confluentinc/teams/streams","members_url":"https://api.github.com/teams/2063464/members{/member}","repositories_url":"https://api.github.com/teams/2063464/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/pulls/301/commits","review_comments_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/pulls/301/comments","review_comment_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/issues/301/comments","statuses_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/statuses/a4467df974ddfd7ac1044065558f157ae10622b3","head":{"label":"confluentinc:kip-470-rewrites","ref":"kip-470-rewrites","sha":"a4467df974ddfd7ac1044065558f157ae10622b3","user":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":100753606,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA3NTM2MDY=","name":"kafka-streams-examples","full_name":"confluentinc/kafka-streams-examples","private":false,"owner":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/confluentinc/kafka-streams-examples","description":"Demo applications and code examples for Apache Kafka's Streams API.","fork":false,"url":"https://api.github.com/repos/confluentinc/kafka-streams-examples","forks_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/forks","keys_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/teams","hooks_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/events","assignees_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/tags","blobs_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/languages","stargazers_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/subscription","commits_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/merges","archive_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/downloads","issues_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/deployments","created_at":"2017-08-18T22:07:36Z","updated_at":"2019-10-29T02:03:25Z","pushed_at":"2019-10-29T04:38:43Z","git_url":"git://github.com/confluentinc/kafka-streams-examples.git","ssh_url":"[email protected]:confluentinc/kafka-streams-examples.git","clone_url":"https://github.com/confluentinc/kafka-streams-examples.git","svn_url":"https://github.com/confluentinc/kafka-streams-examples","homepage":"","size":4128,"stargazers_count":1037,"watchers_count":1037,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":527,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":527,"open_issues":29,"watchers":1037,"default_branch":"5.3.1-post"}},"base":{"label":"confluentinc:master","ref":"master","sha":"a948ca30b42856b27dd0a667a084a3066e74e6b8","user":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":100753606,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA3NTM2MDY=","name":"kafka-streams-examples","full_name":"confluentinc/kafka-streams-examples","private":false,"owner":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/confluentinc/kafka-streams-examples","description":"Demo applications and code examples for Apache Kafka's Streams API.","fork":false,"url":"https://api.github.com/repos/confluentinc/kafka-streams-examples","forks_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/forks","keys_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/teams","hooks_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/events","assignees_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/tags","blobs_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/languages","stargazers_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/subscription","commits_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/merges","archive_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/downloads","issues_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/kafka-streams-examples/deployments","created_at":"2017-08-18T22:07:36Z","updated_at":"2019-10-29T02:03:25Z","pushed_at":"2019-10-29T04:38:43Z","git_url":"git://github.com/confluentinc/kafka-streams-examples.git","ssh_url":"[email protected]:confluentinc/kafka-streams-examples.git","clone_url":"https://github.com/confluentinc/kafka-streams-examples.git","svn_url":"https://github.com/confluentinc/kafka-streams-examples","homepage":"","size":4128,"stargazers_count":1037,"watchers_count":1037,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":527,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":527,"open_issues":29,"watchers":1037,"default_branch":"5.3.1-post"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/kafka-streams-examples/pulls/301"},"html":{"href":"https://github.com/confluentinc/kafka-streams-examples/pull/301"},"issue":{"href":"https://api.github.com/repos/confluentinc/kafka-streams-examples/issues/301"},"comments":{"href":"https://api.github.com/repos/confluentinc/kafka-streams-examples/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/kafka-streams-examples/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/kafka-streams-examples/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/kafka-streams-examples/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/kafka-streams-examples/statuses/a4467df974ddfd7ac1044065558f157ae10622b3"}},"author_association":"MEMBER"}}
|
{
"id": 100753606,
"name": "confluentinc/kafka-streams-examples",
"url": "https://api.github.com/repos/confluentinc/kafka-streams-examples"
}
|
{
"id": 8959638,
"login": "mjsax",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/8959638?",
"url": "https://api.github.com/users/mjsax"
}
|
{
"id": 9439498,
"login": "confluentinc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9439498?",
"url": "https://api.github.com/orgs/confluentinc"
}
| 2019-10-29T04:43:34 |
10734240251
|
{"actor":{"display_login":"mjsax"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/258546933","pull_request_review_id":205839325,"id":258546933,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI1ODU0NjkzMw==","diff_hunk":"@@ -1214,6 +1214,14 @@ Scalar functions\n +------------------------+---------------------------------------------------------------------------+---------------------------------------------------+\n | CONCAT | ``CONCAT(col1, '_hello')`` | Concatenate two strings. |\n +------------------------+---------------------------------------------------------------------------+---------------------------------------------------+\n+| CURRENTDATE | ``CURRENTDATE()`` | Gets an integer representing days since epoch. |\n++------------------------+---------------------------------------------------------------------------+---------------------------------------------------+\n+| CURRENTTIMESTAMP | ``CURRENTTIMESTAMP([TIMEZONE])`` | Gets the current timestamp represented in |\n+| | | millisecond as BIGINT. |\n+| | | TIMEZONE is an optional parameter and it is a |\n+| | | java.util.TimeZone ID format, for example: \"UTC\", |\n+| | | \"America/Los_Angeles\", \"PDT\", \"Europe/London\" |","path":"docs/developer-guide/syntax-reference.rst","position":10,"original_position":10,"commit_id":"671bb3cb0717f727b0cae1fd2a8c698a0e7ad6b6","original_commit_id":"671bb3cb0717f727b0cae1fd2a8c698a0e7ad6b6","user":{"login":"JimGalasyn","id":12521043,"node_id":"MDQ6VXNlcjEyNTIxMDQz","avatar_url":"https://avatars0.githubusercontent.com/u/12521043?v=4","gravatar_id":"","url":"https://api.github.com/users/JimGalasyn","html_url":"https://github.com/JimGalasyn","followers_url":"https://api.github.com/users/JimGalasyn/followers","following_url":"https://api.github.com/users/JimGalasyn/following{/other_user}","gists_url":"https://api.github.com/users/JimGalasyn/gists{/gist_id}","starred_url":"https://api.github.com/users/JimGalasyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimGalasyn/subscriptions","organizations_url":"https://api.github.com/users/JimGalasyn/orgs","repos_url":"https://api.github.com/users/JimGalasyn/repos","events_url":"https://api.github.com/users/JimGalasyn/events{/privacy}","received_events_url":"https://api.github.com/users/JimGalasyn/received_events","type":"User","site_admin":false},"body":"End punctuation: add a period.","created_at":"2019-02-20T15:52:23Z","updated_at":"2019-02-20T15:52:24Z","html_url":"https://github.com/confluentinc/ksql/pull/2459#discussion_r258546933","pull_request_url":"https://api.github.com/repos/confluentinc/ksql/pulls/2459","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments/258546933"},"html":{"href":"https://github.com/confluentinc/ksql/pull/2459#discussion_r258546933"},"pull_request":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/2459"}}},"pull_request":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/2459","id":254511878,"node_id":"MDExOlB1bGxSZXF1ZXN0MjU0NTExODc4","html_url":"https://github.com/confluentinc/ksql/pull/2459","diff_url":"https://github.com/confluentinc/ksql/pull/2459.diff","patch_url":"https://github.com/confluentinc/ksql/pull/2459.patch","issue_url":"https://api.github.com/repos/confluentinc/ksql/issues/2459","number":2459,"state":"open","locked":false,"title":"New CURRENTIMESTAMP and CURRENTDATE datetime functions","user":{"login":"mmolimar","id":901653,"node_id":"MDQ6VXNlcjkwMTY1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/901653?v=4","gravatar_id":"","url":"https://api.github.com/users/mmolimar","html_url":"https://github.com/mmolimar","followers_url":"https://api.github.com/users/mmolimar/followers","following_url":"https://api.github.com/users/mmolimar/following{/other_user}","gists_url":"https://api.github.com/users/mmolimar/gists{/gist_id}","starred_url":"https://api.github.com/users/mmolimar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmolimar/subscriptions","organizations_url":"https://api.github.com/users/mmolimar/orgs","repos_url":"https://api.github.com/users/mmolimar/repos","events_url":"https://api.github.com/users/mmolimar/events{/privacy}","received_events_url":"https://api.github.com/users/mmolimar/received_events","type":"User","site_admin":false},"body":"### Description \r\nThis PR adds two new datetime functions: CURRENTTIMESTAMP and CURRENTDATE.\r\nThe issue related with this is #2412 by @rmoff.\r\n\r\n### Testing done \r\nAdded new unit tests\r\n\r\n### Reviewer checklist\r\n- [ ] Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).\r\n- [ ] Ensure relevant issues are linked (description should include text like \"Fixes #<issue number>\")\r\n\r\n","created_at":"2019-02-20T06:09:13Z","updated_at":"2019-02-20T15:52:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75f6bcec0ea1c1fcb5ca846f57ab603a1ce7675b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"ksql","id":2484983,"node_id":"MDQ6VGVhbTI0ODQ5ODM=","slug":"ksql","description":"KSQL","privacy":"closed","url":"https://api.github.com/teams/2484983","html_url":"https://github.com/orgs/confluentinc/teams/ksql","members_url":"https://api.github.com/teams/2484983/members{/member}","repositories_url":"https://api.github.com/teams/2484983/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/ksql/pulls/2459/commits","review_comments_url":"https://api.github.com/repos/confluentinc/ksql/pulls/2459/comments","review_comment_url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/ksql/issues/2459/comments","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/671bb3cb0717f727b0cae1fd2a8c698a0e7ad6b6","head":{"label":"mmolimar:feature-datetimefn","ref":"feature-datetimefn","sha":"671bb3cb0717f727b0cae1fd2a8c698a0e7ad6b6","user":{"login":"mmolimar","id":901653,"node_id":"MDQ6VXNlcjkwMTY1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/901653?v=4","gravatar_id":"","url":"https://api.github.com/users/mmolimar","html_url":"https://github.com/mmolimar","followers_url":"https://api.github.com/users/mmolimar/followers","following_url":"https://api.github.com/users/mmolimar/following{/other_user}","gists_url":"https://api.github.com/users/mmolimar/gists{/gist_id}","starred_url":"https://api.github.com/users/mmolimar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmolimar/subscriptions","organizations_url":"https://api.github.com/users/mmolimar/orgs","repos_url":"https://api.github.com/users/mmolimar/repos","events_url":"https://api.github.com/users/mmolimar/events{/privacy}","received_events_url":"https://api.github.com/users/mmolimar/received_events","type":"User","site_admin":false},"repo":{"id":171608726,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2MDg3MjY=","name":"ksql","full_name":"mmolimar/ksql","private":false,"owner":{"login":"mmolimar","id":901653,"node_id":"MDQ6VXNlcjkwMTY1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/901653?v=4","gravatar_id":"","url":"https://api.github.com/users/mmolimar","html_url":"https://github.com/mmolimar","followers_url":"https://api.github.com/users/mmolimar/followers","following_url":"https://api.github.com/users/mmolimar/following{/other_user}","gists_url":"https://api.github.com/users/mmolimar/gists{/gist_id}","starred_url":"https://api.github.com/users/mmolimar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmolimar/subscriptions","organizations_url":"https://api.github.com/users/mmolimar/orgs","repos_url":"https://api.github.com/users/mmolimar/repos","events_url":"https://api.github.com/users/mmolimar/events{/privacy}","received_events_url":"https://api.github.com/users/mmolimar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mmolimar/ksql","description":"KSQL - the Streaming SQL Engine for Apache Kafka ","fork":true,"url":"https://api.github.com/repos/mmolimar/ksql","forks_url":"https://api.github.com/repos/mmolimar/ksql/forks","keys_url":"https://api.github.com/repos/mmolimar/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmolimar/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmolimar/ksql/teams","hooks_url":"https://api.github.com/repos/mmolimar/ksql/hooks","issue_events_url":"https://api.github.com/repos/mmolimar/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/mmolimar/ksql/events","assignees_url":"https://api.github.com/repos/mmolimar/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/mmolimar/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/mmolimar/ksql/tags","blobs_url":"https://api.github.com/repos/mmolimar/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmolimar/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmolimar/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmolimar/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmolimar/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/mmolimar/ksql/languages","stargazers_url":"https://api.github.com/repos/mmolimar/ksql/stargazers","contributors_url":"https://api.github.com/repos/mmolimar/ksql/contributors","subscribers_url":"https://api.github.com/repos/mmolimar/ksql/subscribers","subscription_url":"https://api.github.com/repos/mmolimar/ksql/subscription","commits_url":"https://api.github.com/repos/mmolimar/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmolimar/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmolimar/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmolimar/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmolimar/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/mmolimar/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmolimar/ksql/merges","archive_url":"https://api.github.com/repos/mmolimar/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmolimar/ksql/downloads","issues_url":"https://api.github.com/repos/mmolimar/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/mmolimar/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/mmolimar/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/mmolimar/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmolimar/ksql/labels{/name}","releases_url":"https://api.github.com/repos/mmolimar/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/mmolimar/ksql/deployments","created_at":"2019-02-20T05:44:30Z","updated_at":"2019-02-20T05:44:35Z","pushed_at":"2019-02-20T06:09:00Z","git_url":"git://github.com/mmolimar/ksql.git","ssh_url":"[email protected]:mmolimar/ksql.git","clone_url":"https://github.com/mmolimar/ksql.git","svn_url":"https://github.com/mmolimar/ksql","homepage":"","size":18580,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"confluentinc:master","ref":"master","sha":"1843b9bee33c142f4219cc397039167a935ab842","user":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":69400326,"node_id":"MDEwOlJlcG9zaXRvcnk2OTQwMDMyNg==","name":"ksql","full_name":"confluentinc/ksql","private":false,"owner":{"login":"confluentinc","id":9439498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Mzk0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/confluentinc/ksql","description":"KSQL - the Streaming SQL Engine for Apache Kafka ","fork":false,"url":"https://api.github.com/repos/confluentinc/ksql","forks_url":"https://api.github.com/repos/confluentinc/ksql/forks","keys_url":"https://api.github.com/repos/confluentinc/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/ksql/teams","hooks_url":"https://api.github.com/repos/confluentinc/ksql/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/ksql/events","assignees_url":"https://api.github.com/repos/confluentinc/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/ksql/tags","blobs_url":"https://api.github.com/repos/confluentinc/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/ksql/languages","stargazers_url":"https://api.github.com/repos/confluentinc/ksql/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/ksql/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/ksql/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/ksql/subscription","commits_url":"https://api.github.com/repos/confluentinc/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/ksql/merges","archive_url":"https://api.github.com/repos/confluentinc/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/ksql/downloads","issues_url":"https://api.github.com/repos/confluentinc/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/ksql/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/ksql/deployments","created_at":"2016-09-27T21:30:15Z","updated_at":"2019-02-20T12:52:17Z","pushed_at":"2019-02-20T12:52:12Z","git_url":"git://github.com/confluentinc/ksql.git","ssh_url":"[email protected]:confluentinc/ksql.git","clone_url":"https://github.com/confluentinc/ksql.git","svn_url":"https://github.com/confluentinc/ksql","homepage":"","size":18599,"stargazers_count":2154,"watchers_count":2154,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":427,"mirror_url":null,"archived":false,"open_issues_count":463,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":427,"open_issues":463,"watchers":2154,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/2459"},"html":{"href":"https://github.com/confluentinc/ksql/pull/2459"},"issue":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/2459"},"comments":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/2459/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/2459/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/2459/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/ksql/statuses/671bb3cb0717f727b0cae1fd2a8c698a0e7ad6b6"}},"author_association":"NONE"}}
|
{
"id": 69400326,
"name": "confluentinc/ksql",
"url": "https://api.github.com/repos/confluentinc/ksql"
}
|
{
"id": 12521043,
"login": "JimGalasyn",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/12521043?",
"url": "https://api.github.com/users/JimGalasyn"
}
|
{
"id": 9439498,
"login": "confluentinc",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9439498?",
"url": "https://api.github.com/orgs/confluentinc"
}
| 2019-02-20T15:52:23 |
9103424397
|
{"actor":{"display_login":"JimGalasyn"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/GlobalFishingWatch/map-components/pulls/comments/303525956","pull_request_review_id":261936588,"id":303525956,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMwMzUyNTk1Ng==","diff_hunk":"@@ -208,6 +217,7 @@ Map.propTypes = {\n transitionEnd: PropTypes.func,\n cursor: PropTypes.string,\n hasHeatmapLayers: PropTypes.bool.isRequired,\n+ markers: PropTypes.array,","path":"src/map/glmap/Map.js","position":null,"original_position":64,"commit_id":"6d64577650294bfd172ed42e386d12a3b11ada82","original_commit_id":"bf29d47ea845c67ea2940a26e33ea1951a149aa8","user":{"login":"j8seangel","id":10500650,"node_id":"MDQ6VXNlcjEwNTAwNjUw","avatar_url":"https://avatars2.githubusercontent.com/u/10500650?v=4","gravatar_id":"","url":"https://api.github.com/users/j8seangel","html_url":"https://github.com/j8seangel","followers_url":"https://api.github.com/users/j8seangel/followers","following_url":"https://api.github.com/users/j8seangel/following{/other_user}","gists_url":"https://api.github.com/users/j8seangel/gists{/gist_id}","starred_url":"https://api.github.com/users/j8seangel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j8seangel/subscriptions","organizations_url":"https://api.github.com/users/j8seangel/orgs","repos_url":"https://api.github.com/users/j8seangel/repos","events_url":"https://api.github.com/users/j8seangel/events{/privacy}","received_events_url":"https://api.github.com/users/j8seangel/received_events","type":"User","site_admin":false},"body":"added the fix and we can discuss how to manage ts and proptypes definitions later","created_at":"2019-07-15T16:30:29Z","updated_at":"2019-07-15T16:30:29Z","html_url":"https://github.com/GlobalFishingWatch/map-components/pull/53#discussion_r303525956","pull_request_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/pulls/53","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/GlobalFishingWatch/map-components/pulls/comments/303525956"},"html":{"href":"https://github.com/GlobalFishingWatch/map-components/pull/53#discussion_r303525956"},"pull_request":{"href":"https://api.github.com/repos/GlobalFishingWatch/map-components/pulls/53"}},"in_reply_to_id":302928102},"pull_request":{"url":"https://api.github.com/repos/GlobalFishingWatch/map-components/pulls/53","id":277039996,"node_id":"MDExOlB1bGxSZXF1ZXN0Mjc3MDM5OTk2","html_url":"https://github.com/GlobalFishingWatch/map-components/pull/53","diff_url":"https://github.com/GlobalFishingWatch/map-components/pull/53.diff","patch_url":"https://github.com/GlobalFishingWatch/map-components/pull/53.patch","issue_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/issues/53","number":53,"state":"open","locked":false,"title":"Carrier portal features","user":{"login":"j8seangel","id":10500650,"node_id":"MDQ6VXNlcjEwNTAwNjUw","avatar_url":"https://avatars2.githubusercontent.com/u/10500650?v=4","gravatar_id":"","url":"https://api.github.com/users/j8seangel","html_url":"https://github.com/j8seangel","followers_url":"https://api.github.com/users/j8seangel/followers","following_url":"https://api.github.com/users/j8seangel/following{/other_user}","gists_url":"https://api.github.com/users/j8seangel/gists{/gist_id}","starred_url":"https://api.github.com/users/j8seangel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j8seangel/subscriptions","organizations_url":"https://api.github.com/users/j8seangel/orgs","repos_url":"https://api.github.com/users/j8seangel/repos","events_url":"https://api.github.com/users/j8seangel/events{/privacy}","received_events_url":"https://api.github.com/users/j8seangel/received_events","type":"User","site_admin":false},"body":"This PR includes\r\n- New array prop called `markers` to render the desired content on top of the map at lat and long.\r\n- Fix custom gl layers, so now we are able to render any layer following the mapbox spec\r\n- Typescript definition types for the exported components.\r\nHowever, it still doesn't work for code splitting imports\r\n\r\n\r\nSo you have to include the following code on the project you want to use them:\r\n```\r\ndeclare module '@globalfishingwatch/map-components/components/countryflag' {\r\n import { CountryFlag } from '@globalfishingwatch/map-components'\r\n export = CountryFlag\r\n}\r\n```","created_at":"2019-05-08T15:14:04Z","updated_at":"2019-07-15T16:30:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10a0a115b735453cb166249df92f7195cd50fb36","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/pulls/53/commits","review_comments_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/pulls/53/comments","review_comment_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/issues/53/comments","statuses_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/statuses/6d64577650294bfd172ed42e386d12a3b11ada82","head":{"label":"GlobalFishingWatch:definition-types","ref":"definition-types","sha":"6d64577650294bfd172ed42e386d12a3b11ada82","user":{"login":"GlobalFishingWatch","id":9467707,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Njc3MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/9467707?v=4","gravatar_id":"","url":"https://api.github.com/users/GlobalFishingWatch","html_url":"https://github.com/GlobalFishingWatch","followers_url":"https://api.github.com/users/GlobalFishingWatch/followers","following_url":"https://api.github.com/users/GlobalFishingWatch/following{/other_user}","gists_url":"https://api.github.com/users/GlobalFishingWatch/gists{/gist_id}","starred_url":"https://api.github.com/users/GlobalFishingWatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlobalFishingWatch/subscriptions","organizations_url":"https://api.github.com/users/GlobalFishingWatch/orgs","repos_url":"https://api.github.com/users/GlobalFishingWatch/repos","events_url":"https://api.github.com/users/GlobalFishingWatch/events{/privacy}","received_events_url":"https://api.github.com/users/GlobalFishingWatch/received_events","type":"Organization","site_admin":false},"repo":{"id":168718727,"node_id":"MDEwOlJlcG9zaXRvcnkxNjg3MTg3Mjc=","name":"map-components","full_name":"GlobalFishingWatch/map-components","private":false,"owner":{"login":"GlobalFishingWatch","id":9467707,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Njc3MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/9467707?v=4","gravatar_id":"","url":"https://api.github.com/users/GlobalFishingWatch","html_url":"https://github.com/GlobalFishingWatch","followers_url":"https://api.github.com/users/GlobalFishingWatch/followers","following_url":"https://api.github.com/users/GlobalFishingWatch/following{/other_user}","gists_url":"https://api.github.com/users/GlobalFishingWatch/gists{/gist_id}","starred_url":"https://api.github.com/users/GlobalFishingWatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlobalFishingWatch/subscriptions","organizations_url":"https://api.github.com/users/GlobalFishingWatch/orgs","repos_url":"https://api.github.com/users/GlobalFishingWatch/repos","events_url":"https://api.github.com/users/GlobalFishingWatch/events{/privacy}","received_events_url":"https://api.github.com/users/GlobalFishingWatch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GlobalFishingWatch/map-components","description":"Global fishing watch ui components","fork":false,"url":"https://api.github.com/repos/GlobalFishingWatch/map-components","forks_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/forks","keys_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/teams","hooks_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/hooks","issue_events_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/issues/events{/number}","events_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/events","assignees_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/assignees{/user}","branches_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/branches{/branch}","tags_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/tags","blobs_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/statuses/{sha}","languages_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/languages","stargazers_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/stargazers","contributors_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/contributors","subscribers_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/subscribers","subscription_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/subscription","commits_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/contents/{+path}","compare_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/merges","archive_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/downloads","issues_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/issues{/number}","pulls_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/pulls{/number}","milestones_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/milestones{/number}","notifications_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/labels{/name}","releases_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/releases{/id}","deployments_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/deployments","created_at":"2019-02-01T15:33:30Z","updated_at":"2019-07-11T16:37:21Z","pushed_at":"2019-07-15T16:29:37Z","git_url":"git://github.com/GlobalFishingWatch/map-components.git","ssh_url":"[email protected]:GlobalFishingWatch/map-components.git","clone_url":"https://github.com/GlobalFishingWatch/map-components.git","svn_url":"https://github.com/GlobalFishingWatch/map-components","homepage":"http://globalfishingwatch.io/map-components/#/","size":20357,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":null,"forks":0,"open_issues":10,"watchers":2,"default_branch":"master"}},"base":{"label":"GlobalFishingWatch:master","ref":"master","sha":"8510f9e596293369c75bf3c373361ef00c0b6565","user":{"login":"GlobalFishingWatch","id":9467707,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Njc3MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/9467707?v=4","gravatar_id":"","url":"https://api.github.com/users/GlobalFishingWatch","html_url":"https://github.com/GlobalFishingWatch","followers_url":"https://api.github.com/users/GlobalFishingWatch/followers","following_url":"https://api.github.com/users/GlobalFishingWatch/following{/other_user}","gists_url":"https://api.github.com/users/GlobalFishingWatch/gists{/gist_id}","starred_url":"https://api.github.com/users/GlobalFishingWatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlobalFishingWatch/subscriptions","organizations_url":"https://api.github.com/users/GlobalFishingWatch/orgs","repos_url":"https://api.github.com/users/GlobalFishingWatch/repos","events_url":"https://api.github.com/users/GlobalFishingWatch/events{/privacy}","received_events_url":"https://api.github.com/users/GlobalFishingWatch/received_events","type":"Organization","site_admin":false},"repo":{"id":168718727,"node_id":"MDEwOlJlcG9zaXRvcnkxNjg3MTg3Mjc=","name":"map-components","full_name":"GlobalFishingWatch/map-components","private":false,"owner":{"login":"GlobalFishingWatch","id":9467707,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk0Njc3MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/9467707?v=4","gravatar_id":"","url":"https://api.github.com/users/GlobalFishingWatch","html_url":"https://github.com/GlobalFishingWatch","followers_url":"https://api.github.com/users/GlobalFishingWatch/followers","following_url":"https://api.github.com/users/GlobalFishingWatch/following{/other_user}","gists_url":"https://api.github.com/users/GlobalFishingWatch/gists{/gist_id}","starred_url":"https://api.github.com/users/GlobalFishingWatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GlobalFishingWatch/subscriptions","organizations_url":"https://api.github.com/users/GlobalFishingWatch/orgs","repos_url":"https://api.github.com/users/GlobalFishingWatch/repos","events_url":"https://api.github.com/users/GlobalFishingWatch/events{/privacy}","received_events_url":"https://api.github.com/users/GlobalFishingWatch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/GlobalFishingWatch/map-components","description":"Global fishing watch ui components","fork":false,"url":"https://api.github.com/repos/GlobalFishingWatch/map-components","forks_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/forks","keys_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/teams","hooks_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/hooks","issue_events_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/issues/events{/number}","events_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/events","assignees_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/assignees{/user}","branches_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/branches{/branch}","tags_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/tags","blobs_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/statuses/{sha}","languages_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/languages","stargazers_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/stargazers","contributors_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/contributors","subscribers_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/subscribers","subscription_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/subscription","commits_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/contents/{+path}","compare_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/merges","archive_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/downloads","issues_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/issues{/number}","pulls_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/pulls{/number}","milestones_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/milestones{/number}","notifications_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/labels{/name}","releases_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/releases{/id}","deployments_url":"https://api.github.com/repos/GlobalFishingWatch/map-components/deployments","created_at":"2019-02-01T15:33:30Z","updated_at":"2019-07-11T16:37:21Z","pushed_at":"2019-07-15T16:29:37Z","git_url":"git://github.com/GlobalFishingWatch/map-components.git","ssh_url":"[email protected]:GlobalFishingWatch/map-components.git","clone_url":"https://github.com/GlobalFishingWatch/map-components.git","svn_url":"https://github.com/GlobalFishingWatch/map-components","homepage":"http://globalfishingwatch.io/map-components/#/","size":20357,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":10,"license":null,"forks":0,"open_issues":10,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GlobalFishingWatch/map-components/pulls/53"},"html":{"href":"https://github.com/GlobalFishingWatch/map-components/pull/53"},"issue":{"href":"https://api.github.com/repos/GlobalFishingWatch/map-components/issues/53"},"comments":{"href":"https://api.github.com/repos/GlobalFishingWatch/map-components/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/GlobalFishingWatch/map-components/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/GlobalFishingWatch/map-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GlobalFishingWatch/map-components/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/GlobalFishingWatch/map-components/statuses/6d64577650294bfd172ed42e386d12a3b11ada82"}},"author_association":"COLLABORATOR"}}
|
{
"id": 168718727,
"name": "GlobalFishingWatch/map-components",
"url": "https://api.github.com/repos/GlobalFishingWatch/map-components"
}
|
{
"id": 10500650,
"login": "j8seangel",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/10500650?",
"url": "https://api.github.com/users/j8seangel"
}
|
{
"id": 9467707,
"login": "GlobalFishingWatch",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9467707?",
"url": "https://api.github.com/orgs/GlobalFishingWatch"
}
| 2019-07-15T16:30:29 |
10014039342
|
{"actor":{"display_login":"j8seangel"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/fossas/spectrometer/pulls/comments/357391399","pull_request_review_id":331551491,"id":357391399,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDM1NzM5MTM5OQ==","diff_hunk":"@@ -71,6 +74,14 @@ readContentsJson file = do\n Left err -> throw (FileParseError (toFilePath file) (T.pack err))\n Right a -> pure a\n \n+-- | Read JSON from a file","path":"src/Effect/ReadFS.hs","position":24,"original_position":24,"commit_id":"40c363b38a2dad9eb0a8056ff06c157c73ed1125","original_commit_id":"40c363b38a2dad9eb0a8056ff06c157c73ed1125","user":{"login":"cnr","id":3586257,"node_id":"MDQ6VXNlcjM1ODYyNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3586257?v=4","gravatar_id":"","url":"https://api.github.com/users/cnr","html_url":"https://github.com/cnr","followers_url":"https://api.github.com/users/cnr/followers","following_url":"https://api.github.com/users/cnr/following{/other_user}","gists_url":"https://api.github.com/users/cnr/gists{/gist_id}","starred_url":"https://api.github.com/users/cnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnr/subscriptions","organizations_url":"https://api.github.com/users/cnr/orgs","repos_url":"https://api.github.com/users/cnr/repos","events_url":"https://api.github.com/users/cnr/events{/privacy}","received_events_url":"https://api.github.com/users/cnr/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n-- | Read YAML from a file\r\n```","created_at":"2019-12-12T21:56:08Z","updated_at":"2019-12-12T21:56:33Z","html_url":"https://github.com/fossas/spectrometer/pull/15#discussion_r357391399","pull_request_url":"https://api.github.com/repos/fossas/spectrometer/pulls/15","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/fossas/spectrometer/pulls/comments/357391399"},"html":{"href":"https://github.com/fossas/spectrometer/pull/15#discussion_r357391399"},"pull_request":{"href":"https://api.github.com/repos/fossas/spectrometer/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/fossas/spectrometer/pulls/15","id":352607156,"node_id":"MDExOlB1bGxSZXF1ZXN0MzUyNjA3MTU2","html_url":"https://github.com/fossas/spectrometer/pull/15","diff_url":"https://github.com/fossas/spectrometer/pull/15.diff","patch_url":"https://github.com/fossas/spectrometer/pull/15.patch","issue_url":"https://api.github.com/repos/fossas/spectrometer/issues/15","number":15,"state":"open","locked":false,"title":"Glide lockfile parsing support","user":{"login":"zlav","id":31230447,"node_id":"MDQ6VXNlcjMxMjMwNDQ3","avatar_url":"https://avatars1.githubusercontent.com/u/31230447?v=4","gravatar_id":"","url":"https://api.github.com/users/zlav","html_url":"https://github.com/zlav","followers_url":"https://api.github.com/users/zlav/followers","following_url":"https://api.github.com/users/zlav/following{/other_user}","gists_url":"https://api.github.com/users/zlav/gists{/gist_id}","starred_url":"https://api.github.com/users/zlav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zlav/subscriptions","organizations_url":"https://api.github.com/users/zlav/orgs","repos_url":"https://api.github.com/users/zlav/repos","events_url":"https://api.github.com/users/zlav/events{/privacy}","received_events_url":"https://api.github.com/users/zlav/received_events","type":"User","site_admin":false},"body":"This PR adds support for parsing `glide.lock` files. The file is yaml formatted and as a result this PR added supporting functions to parse yaml files into Aeson data. Fortunately the `Data.yaml` package supports this out of the box.","created_at":"2019-12-12T20:56:45Z","updated_at":"2019-12-12T21:56:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6f432fcf9f2d23f7cf04eb8441e0d96badcbf81","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fossas/spectrometer/pulls/15/commits","review_comments_url":"https://api.github.com/repos/fossas/spectrometer/pulls/15/comments","review_comment_url":"https://api.github.com/repos/fossas/spectrometer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fossas/spectrometer/issues/15/comments","statuses_url":"https://api.github.com/repos/fossas/spectrometer/statuses/40c363b38a2dad9eb0a8056ff06c157c73ed1125","head":{"label":"fossas:feat/glide-support","ref":"feat/glide-support","sha":"40c363b38a2dad9eb0a8056ff06c157c73ed1125","user":{"login":"fossas","id":9543448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1NDM0NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/9543448?v=4","gravatar_id":"","url":"https://api.github.com/users/fossas","html_url":"https://github.com/fossas","followers_url":"https://api.github.com/users/fossas/followers","following_url":"https://api.github.com/users/fossas/following{/other_user}","gists_url":"https://api.github.com/users/fossas/gists{/gist_id}","starred_url":"https://api.github.com/users/fossas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossas/subscriptions","organizations_url":"https://api.github.com/users/fossas/orgs","repos_url":"https://api.github.com/users/fossas/repos","events_url":"https://api.github.com/users/fossas/events{/privacy}","received_events_url":"https://api.github.com/users/fossas/received_events","type":"Organization","site_admin":false},"repo":{"id":215656203,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU2NTYyMDM=","name":"spectrometer","full_name":"fossas/spectrometer","private":false,"owner":{"login":"fossas","id":9543448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1NDM0NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/9543448?v=4","gravatar_id":"","url":"https://api.github.com/users/fossas","html_url":"https://github.com/fossas","followers_url":"https://api.github.com/users/fossas/followers","following_url":"https://api.github.com/users/fossas/following{/other_user}","gists_url":"https://api.github.com/users/fossas/gists{/gist_id}","starred_url":"https://api.github.com/users/fossas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossas/subscriptions","organizations_url":"https://api.github.com/users/fossas/orgs","repos_url":"https://api.github.com/users/fossas/repos","events_url":"https://api.github.com/users/fossas/events{/privacy}","received_events_url":"https://api.github.com/users/fossas/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fossas/spectrometer","description":"Flexible, robust, and performant dependency analysis.","fork":false,"url":"https://api.github.com/repos/fossas/spectrometer","forks_url":"https://api.github.com/repos/fossas/spectrometer/forks","keys_url":"https://api.github.com/repos/fossas/spectrometer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fossas/spectrometer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fossas/spectrometer/teams","hooks_url":"https://api.github.com/repos/fossas/spectrometer/hooks","issue_events_url":"https://api.github.com/repos/fossas/spectrometer/issues/events{/number}","events_url":"https://api.github.com/repos/fossas/spectrometer/events","assignees_url":"https://api.github.com/repos/fossas/spectrometer/assignees{/user}","branches_url":"https://api.github.com/repos/fossas/spectrometer/branches{/branch}","tags_url":"https://api.github.com/repos/fossas/spectrometer/tags","blobs_url":"https://api.github.com/repos/fossas/spectrometer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fossas/spectrometer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fossas/spectrometer/git/refs{/sha}","trees_url":"https://api.github.com/repos/fossas/spectrometer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fossas/spectrometer/statuses/{sha}","languages_url":"https://api.github.com/repos/fossas/spectrometer/languages","stargazers_url":"https://api.github.com/repos/fossas/spectrometer/stargazers","contributors_url":"https://api.github.com/repos/fossas/spectrometer/contributors","subscribers_url":"https://api.github.com/repos/fossas/spectrometer/subscribers","subscription_url":"https://api.github.com/repos/fossas/spectrometer/subscription","commits_url":"https://api.github.com/repos/fossas/spectrometer/commits{/sha}","git_commits_url":"https://api.github.com/repos/fossas/spectrometer/git/commits{/sha}","comments_url":"https://api.github.com/repos/fossas/spectrometer/comments{/number}","issue_comment_url":"https://api.github.com/repos/fossas/spectrometer/issues/comments{/number}","contents_url":"https://api.github.com/repos/fossas/spectrometer/contents/{+path}","compare_url":"https://api.github.com/repos/fossas/spectrometer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fossas/spectrometer/merges","archive_url":"https://api.github.com/repos/fossas/spectrometer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fossas/spectrometer/downloads","issues_url":"https://api.github.com/repos/fossas/spectrometer/issues{/number}","pulls_url":"https://api.github.com/repos/fossas/spectrometer/pulls{/number}","milestones_url":"https://api.github.com/repos/fossas/spectrometer/milestones{/number}","notifications_url":"https://api.github.com/repos/fossas/spectrometer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fossas/spectrometer/labels{/name}","releases_url":"https://api.github.com/repos/fossas/spectrometer/releases{/id}","deployments_url":"https://api.github.com/repos/fossas/spectrometer/deployments","created_at":"2019-10-16T22:32:42Z","updated_at":"2019-12-06T21:18:27Z","pushed_at":"2019-12-12T20:56:46Z","git_url":"git://github.com/fossas/spectrometer.git","ssh_url":"[email protected]:fossas/spectrometer.git","clone_url":"https://github.com/fossas/spectrometer.git","svn_url":"https://github.com/fossas/spectrometer","homepage":"","size":335,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"fossas:master","ref":"master","sha":"6817ba6d49a60c92046147a590593ac78cf80faf","user":{"login":"fossas","id":9543448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1NDM0NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/9543448?v=4","gravatar_id":"","url":"https://api.github.com/users/fossas","html_url":"https://github.com/fossas","followers_url":"https://api.github.com/users/fossas/followers","following_url":"https://api.github.com/users/fossas/following{/other_user}","gists_url":"https://api.github.com/users/fossas/gists{/gist_id}","starred_url":"https://api.github.com/users/fossas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossas/subscriptions","organizations_url":"https://api.github.com/users/fossas/orgs","repos_url":"https://api.github.com/users/fossas/repos","events_url":"https://api.github.com/users/fossas/events{/privacy}","received_events_url":"https://api.github.com/users/fossas/received_events","type":"Organization","site_admin":false},"repo":{"id":215656203,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU2NTYyMDM=","name":"spectrometer","full_name":"fossas/spectrometer","private":false,"owner":{"login":"fossas","id":9543448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1NDM0NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/9543448?v=4","gravatar_id":"","url":"https://api.github.com/users/fossas","html_url":"https://github.com/fossas","followers_url":"https://api.github.com/users/fossas/followers","following_url":"https://api.github.com/users/fossas/following{/other_user}","gists_url":"https://api.github.com/users/fossas/gists{/gist_id}","starred_url":"https://api.github.com/users/fossas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossas/subscriptions","organizations_url":"https://api.github.com/users/fossas/orgs","repos_url":"https://api.github.com/users/fossas/repos","events_url":"https://api.github.com/users/fossas/events{/privacy}","received_events_url":"https://api.github.com/users/fossas/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fossas/spectrometer","description":"Flexible, robust, and performant dependency analysis.","fork":false,"url":"https://api.github.com/repos/fossas/spectrometer","forks_url":"https://api.github.com/repos/fossas/spectrometer/forks","keys_url":"https://api.github.com/repos/fossas/spectrometer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fossas/spectrometer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fossas/spectrometer/teams","hooks_url":"https://api.github.com/repos/fossas/spectrometer/hooks","issue_events_url":"https://api.github.com/repos/fossas/spectrometer/issues/events{/number}","events_url":"https://api.github.com/repos/fossas/spectrometer/events","assignees_url":"https://api.github.com/repos/fossas/spectrometer/assignees{/user}","branches_url":"https://api.github.com/repos/fossas/spectrometer/branches{/branch}","tags_url":"https://api.github.com/repos/fossas/spectrometer/tags","blobs_url":"https://api.github.com/repos/fossas/spectrometer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fossas/spectrometer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fossas/spectrometer/git/refs{/sha}","trees_url":"https://api.github.com/repos/fossas/spectrometer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fossas/spectrometer/statuses/{sha}","languages_url":"https://api.github.com/repos/fossas/spectrometer/languages","stargazers_url":"https://api.github.com/repos/fossas/spectrometer/stargazers","contributors_url":"https://api.github.com/repos/fossas/spectrometer/contributors","subscribers_url":"https://api.github.com/repos/fossas/spectrometer/subscribers","subscription_url":"https://api.github.com/repos/fossas/spectrometer/subscription","commits_url":"https://api.github.com/repos/fossas/spectrometer/commits{/sha}","git_commits_url":"https://api.github.com/repos/fossas/spectrometer/git/commits{/sha}","comments_url":"https://api.github.com/repos/fossas/spectrometer/comments{/number}","issue_comment_url":"https://api.github.com/repos/fossas/spectrometer/issues/comments{/number}","contents_url":"https://api.github.com/repos/fossas/spectrometer/contents/{+path}","compare_url":"https://api.github.com/repos/fossas/spectrometer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fossas/spectrometer/merges","archive_url":"https://api.github.com/repos/fossas/spectrometer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fossas/spectrometer/downloads","issues_url":"https://api.github.com/repos/fossas/spectrometer/issues{/number}","pulls_url":"https://api.github.com/repos/fossas/spectrometer/pulls{/number}","milestones_url":"https://api.github.com/repos/fossas/spectrometer/milestones{/number}","notifications_url":"https://api.github.com/repos/fossas/spectrometer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fossas/spectrometer/labels{/name}","releases_url":"https://api.github.com/repos/fossas/spectrometer/releases{/id}","deployments_url":"https://api.github.com/repos/fossas/spectrometer/deployments","created_at":"2019-10-16T22:32:42Z","updated_at":"2019-12-06T21:18:27Z","pushed_at":"2019-12-12T20:56:46Z","git_url":"git://github.com/fossas/spectrometer.git","ssh_url":"[email protected]:fossas/spectrometer.git","clone_url":"https://github.com/fossas/spectrometer.git","svn_url":"https://github.com/fossas/spectrometer","homepage":"","size":335,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fossas/spectrometer/pulls/15"},"html":{"href":"https://github.com/fossas/spectrometer/pull/15"},"issue":{"href":"https://api.github.com/repos/fossas/spectrometer/issues/15"},"comments":{"href":"https://api.github.com/repos/fossas/spectrometer/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/fossas/spectrometer/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/fossas/spectrometer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fossas/spectrometer/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/fossas/spectrometer/statuses/40c363b38a2dad9eb0a8056ff06c157c73ed1125"}},"author_association":"COLLABORATOR"}}
|
{
"id": 215656203,
"name": "fossas/spectrometer",
"url": "https://api.github.com/repos/fossas/spectrometer"
}
|
{
"id": 3586257,
"login": "cnr",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/3586257?",
"url": "https://api.github.com/users/cnr"
}
|
{
"id": 9543448,
"login": "fossas",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9543448?",
"url": "https://api.github.com/orgs/fossas"
}
| 2019-12-12T21:56:08 |
11077999877
|
{"actor":{"display_login":"cnr"}}
|
PullRequestReviewCommentEvent
| true |
{"action":"created","comment":{"url":"https://api.github.com/repos/mattermost/mattermost-server/pulls/comments/322351482","pull_request_review_id":285649555,"id":322351482,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDMyMjM1MTQ4Mg==","diff_hunk":"@@ -159,7 +159,7 @@ func NewSqlSupplier(settings model.SqlSettings, metrics einterfaces.MetricsInter\n \n \terr := supplier.GetMaster().CreateTablesIfNotExists()\n \tif err != nil {\n-\t\tmlog.Critical(fmt.Sprintf(\"Error creating database tables: %v\", err))\n+\t\tmlog.Critical(\"Error creating database tables:\", mlog.Err(err))","path":"store/sqlstore/supplier.go","position":5,"original_position":5,"commit_id":"8b6e59d2df25183b8bbfac49cb55c30ba6aa4499","original_commit_id":"8b6e59d2df25183b8bbfac49cb55c30ba6aa4499","user":{"login":"jespino","id":290303,"node_id":"MDQ6VXNlcjI5MDMwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/290303?v=4","gravatar_id":"","url":"https://api.github.com/users/jespino","html_url":"https://github.com/jespino","followers_url":"https://api.github.com/users/jespino/followers","following_url":"https://api.github.com/users/jespino/following{/other_user}","gists_url":"https://api.github.com/users/jespino/gists{/gist_id}","starred_url":"https://api.github.com/users/jespino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jespino/subscriptions","organizations_url":"https://api.github.com/users/jespino/orgs","repos_url":"https://api.github.com/users/jespino/repos","events_url":"https://api.github.com/users/jespino/events{/privacy}","received_events_url":"https://api.github.com/users/jespino/received_events","type":"User","site_admin":false},"body":"I would remove the exta `:` and would replace it with `.` for all the cases in the PR.","created_at":"2019-09-09T17:01:29Z","updated_at":"2019-09-09T17:01:29Z","html_url":"https://github.com/mattermost/mattermost-server/pull/12089#discussion_r322351482","pull_request_url":"https://api.github.com/repos/mattermost/mattermost-server/pulls/12089","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-server/pulls/comments/322351482"},"html":{"href":"https://github.com/mattermost/mattermost-server/pull/12089#discussion_r322351482"},"pull_request":{"href":"https://api.github.com/repos/mattermost/mattermost-server/pulls/12089"}}},"pull_request":{"url":"https://api.github.com/repos/mattermost/mattermost-server/pulls/12089","id":315297887,"node_id":"MDExOlB1bGxSZXF1ZXN0MzE1Mjk3ODg3","html_url":"https://github.com/mattermost/mattermost-server/pull/12089","diff_url":"https://github.com/mattermost/mattermost-server/pull/12089.diff","patch_url":"https://github.com/mattermost/mattermost-server/pull/12089.patch","issue_url":"https://api.github.com/repos/mattermost/mattermost-server/issues/12089","number":12089,"state":"open","locked":false,"title":"Converting to structured logging the file store/sqlstore/supplier.go","user":{"login":"niklabh","id":874046,"node_id":"MDQ6VXNlcjg3NDA0Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/874046?v=4","gravatar_id":"","url":"https://api.github.com/users/niklabh","html_url":"https://github.com/niklabh","followers_url":"https://api.github.com/users/niklabh/followers","following_url":"https://api.github.com/users/niklabh/following{/other_user}","gists_url":"https://api.github.com/users/niklabh/gists{/gist_id}","starred_url":"https://api.github.com/users/niklabh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklabh/subscriptions","organizations_url":"https://api.github.com/users/niklabh/orgs","repos_url":"https://api.github.com/users/niklabh/repos","events_url":"https://api.github.com/users/niklabh/events{/privacy}","received_events_url":"https://api.github.com/users/niklabh/received_events","type":"User","site_admin":false},"body":"<!-- Thank you for contributing a pull request! Here are a few tips to help you:\r\n\r\n1. If this is your first contribution, make sure you've read the Contribution Checklist https://developers.mattermost.com/contribute/getting-started/contribution-checklist/\r\n2. Read our blog post about \"Submitting Great PRs\" https://developers.mattermost.com/blog/2019-01-24-submitting-great-prs\r\n3. Take a look at other repository specific documentation at https://developers.mattermost.com/contribute\r\n-->\r\n\r\n#### Summary\r\n<!--\r\nA description of what this pull request does.\r\n-->\r\nConverting to structured logging the file store/sqlstore/supplier.go\r\n#### Ticket Link\r\n<!--\r\nIf this pull request addresses a Help Wanted ticket, please link the relevant GitHub issue, e.g.\r\n\r\n Fixes https://github.com/mattermost/mattermost-server/issues/XXXXX\r\n\r\nOtherwise, link the JIRA ticket.\r\n-->\r\nFixes https://github.com/mattermost/mattermost-server/issues/12051","created_at":"2019-09-08T18:48:45Z","updated_at":"2019-09-09T17:01:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f46a31069a9a29da4e556e2d8d4bc16ce4f136c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mattermost/mattermost-server/pulls/12089/commits","review_comments_url":"https://api.github.com/repos/mattermost/mattermost-server/pulls/12089/comments","review_comment_url":"https://api.github.com/repos/mattermost/mattermost-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattermost/mattermost-server/issues/12089/comments","statuses_url":"https://api.github.com/repos/mattermost/mattermost-server/statuses/8b6e59d2df25183b8bbfac49cb55c30ba6aa4499","head":{"label":"niklabh:sqlstore-supplier-mlog","ref":"sqlstore-supplier-mlog","sha":"8b6e59d2df25183b8bbfac49cb55c30ba6aa4499","user":{"login":"niklabh","id":874046,"node_id":"MDQ6VXNlcjg3NDA0Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/874046?v=4","gravatar_id":"","url":"https://api.github.com/users/niklabh","html_url":"https://github.com/niklabh","followers_url":"https://api.github.com/users/niklabh/followers","following_url":"https://api.github.com/users/niklabh/following{/other_user}","gists_url":"https://api.github.com/users/niklabh/gists{/gist_id}","starred_url":"https://api.github.com/users/niklabh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklabh/subscriptions","organizations_url":"https://api.github.com/users/niklabh/orgs","repos_url":"https://api.github.com/users/niklabh/repos","events_url":"https://api.github.com/users/niklabh/events{/privacy}","received_events_url":"https://api.github.com/users/niklabh/received_events","type":"User","site_admin":false},"repo":{"id":204202864,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQyMDI4NjQ=","name":"mattermost-server","full_name":"niklabh/mattermost-server","private":false,"owner":{"login":"niklabh","id":874046,"node_id":"MDQ6VXNlcjg3NDA0Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/874046?v=4","gravatar_id":"","url":"https://api.github.com/users/niklabh","html_url":"https://github.com/niklabh","followers_url":"https://api.github.com/users/niklabh/followers","following_url":"https://api.github.com/users/niklabh/following{/other_user}","gists_url":"https://api.github.com/users/niklabh/gists{/gist_id}","starred_url":"https://api.github.com/users/niklabh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklabh/subscriptions","organizations_url":"https://api.github.com/users/niklabh/orgs","repos_url":"https://api.github.com/users/niklabh/repos","events_url":"https://api.github.com/users/niklabh/events{/privacy}","received_events_url":"https://api.github.com/users/niklabh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/niklabh/mattermost-server","description":"Open source Slack-alternative in Golang and React - Mattermost","fork":true,"url":"https://api.github.com/repos/niklabh/mattermost-server","forks_url":"https://api.github.com/repos/niklabh/mattermost-server/forks","keys_url":"https://api.github.com/repos/niklabh/mattermost-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/niklabh/mattermost-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/niklabh/mattermost-server/teams","hooks_url":"https://api.github.com/repos/niklabh/mattermost-server/hooks","issue_events_url":"https://api.github.com/repos/niklabh/mattermost-server/issues/events{/number}","events_url":"https://api.github.com/repos/niklabh/mattermost-server/events","assignees_url":"https://api.github.com/repos/niklabh/mattermost-server/assignees{/user}","branches_url":"https://api.github.com/repos/niklabh/mattermost-server/branches{/branch}","tags_url":"https://api.github.com/repos/niklabh/mattermost-server/tags","blobs_url":"https://api.github.com/repos/niklabh/mattermost-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/niklabh/mattermost-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/niklabh/mattermost-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/niklabh/mattermost-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/niklabh/mattermost-server/statuses/{sha}","languages_url":"https://api.github.com/repos/niklabh/mattermost-server/languages","stargazers_url":"https://api.github.com/repos/niklabh/mattermost-server/stargazers","contributors_url":"https://api.github.com/repos/niklabh/mattermost-server/contributors","subscribers_url":"https://api.github.com/repos/niklabh/mattermost-server/subscribers","subscription_url":"https://api.github.com/repos/niklabh/mattermost-server/subscription","commits_url":"https://api.github.com/repos/niklabh/mattermost-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/niklabh/mattermost-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/niklabh/mattermost-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/niklabh/mattermost-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/niklabh/mattermost-server/contents/{+path}","compare_url":"https://api.github.com/repos/niklabh/mattermost-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/niklabh/mattermost-server/merges","archive_url":"https://api.github.com/repos/niklabh/mattermost-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/niklabh/mattermost-server/downloads","issues_url":"https://api.github.com/repos/niklabh/mattermost-server/issues{/number}","pulls_url":"https://api.github.com/repos/niklabh/mattermost-server/pulls{/number}","milestones_url":"https://api.github.com/repos/niklabh/mattermost-server/milestones{/number}","notifications_url":"https://api.github.com/repos/niklabh/mattermost-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/niklabh/mattermost-server/labels{/name}","releases_url":"https://api.github.com/repos/niklabh/mattermost-server/releases{/id}","deployments_url":"https://api.github.com/repos/niklabh/mattermost-server/deployments","created_at":"2019-08-24T19:27:03Z","updated_at":"2019-09-09T12:38:47Z","pushed_at":"2019-09-09T15:40:29Z","git_url":"git://github.com/niklabh/mattermost-server.git","ssh_url":"[email protected]:niklabh/mattermost-server.git","clone_url":"https://github.com/niklabh/mattermost-server.git","svn_url":"https://github.com/niklabh/mattermost-server","homepage":"https://mattermost.com","size":339745,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mattermost:master","ref":"master","sha":"98f7bdcb430a28644e20c83d798c0b714f604c2e","user":{"login":"mattermost","id":9828093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MjgwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":37448451,"node_id":"MDEwOlJlcG9zaXRvcnkzNzQ0ODQ1MQ==","name":"mattermost-server","full_name":"mattermost/mattermost-server","private":false,"owner":{"login":"mattermost","id":9828093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MjgwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mattermost/mattermost-server","description":"Open source Slack-alternative in Golang and React - Mattermost","fork":false,"url":"https://api.github.com/repos/mattermost/mattermost-server","forks_url":"https://api.github.com/repos/mattermost/mattermost-server/forks","keys_url":"https://api.github.com/repos/mattermost/mattermost-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/mattermost-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/mattermost-server/teams","hooks_url":"https://api.github.com/repos/mattermost/mattermost-server/hooks","issue_events_url":"https://api.github.com/repos/mattermost/mattermost-server/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/mattermost-server/events","assignees_url":"https://api.github.com/repos/mattermost/mattermost-server/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/mattermost-server/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/mattermost-server/tags","blobs_url":"https://api.github.com/repos/mattermost/mattermost-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/mattermost-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/mattermost-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/mattermost-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/mattermost-server/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/mattermost-server/languages","stargazers_url":"https://api.github.com/repos/mattermost/mattermost-server/stargazers","contributors_url":"https://api.github.com/repos/mattermost/mattermost-server/contributors","subscribers_url":"https://api.github.com/repos/mattermost/mattermost-server/subscribers","subscription_url":"https://api.github.com/repos/mattermost/mattermost-server/subscription","commits_url":"https://api.github.com/repos/mattermost/mattermost-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/mattermost-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/mattermost-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/mattermost-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/mattermost-server/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/mattermost-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/mattermost-server/merges","archive_url":"https://api.github.com/repos/mattermost/mattermost-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/mattermost-server/downloads","issues_url":"https://api.github.com/repos/mattermost/mattermost-server/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/mattermost-server/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/mattermost-server/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/mattermost-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/mattermost-server/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/mattermost-server/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/mattermost-server/deployments","created_at":"2015-06-15T06:50:02Z","updated_at":"2019-09-09T16:53:40Z","pushed_at":"2019-09-09T16:56:55Z","git_url":"git://github.com/mattermost/mattermost-server.git","ssh_url":"[email protected]:mattermost/mattermost-server.git","clone_url":"https://github.com/mattermost/mattermost-server.git","svn_url":"https://github.com/mattermost/mattermost-server","homepage":"https://mattermost.com","size":366134,"stargazers_count":16134,"watchers_count":16134,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3314,"mirror_url":null,"archived":false,"disabled":false,"open_issues_count":350,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3314,"open_issues":350,"watchers":16134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-server/pulls/12089"},"html":{"href":"https://github.com/mattermost/mattermost-server/pull/12089"},"issue":{"href":"https://api.github.com/repos/mattermost/mattermost-server/issues/12089"},"comments":{"href":"https://api.github.com/repos/mattermost/mattermost-server/issues/12089/comments"},"review_comments":{"href":"https://api.github.com/repos/mattermost/mattermost-server/pulls/12089/comments"},"review_comment":{"href":"https://api.github.com/repos/mattermost/mattermost-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattermost/mattermost-server/pulls/12089/commits"},"statuses":{"href":"https://api.github.com/repos/mattermost/mattermost-server/statuses/8b6e59d2df25183b8bbfac49cb55c30ba6aa4499"}},"author_association":"CONTRIBUTOR"}}
|
{
"id": 37448451,
"name": "mattermost/mattermost-server",
"url": "https://api.github.com/repos/mattermost/mattermost-server"
}
|
{
"id": 290303,
"login": "jespino",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/290303?",
"url": "https://api.github.com/users/jespino"
}
|
{
"id": 9828093,
"login": "mattermost",
"gravatar_id": "",
"avatar_url": "https://avatars.githubusercontent.com/u/9828093?",
"url": "https://api.github.com/orgs/mattermost"
}
| 2019-09-09T17:01:29 |
10377960044
|
{"actor":{"display_login":"jespino"}}
|