Datasets:

abhishek-shrm

/

github-issues

like 0

{ "login": "hugoabonizio", "id": 1206395, "node_id": "MDQ6VXNlcjEyMDYzOTU=", "avatar_url": "https://avatars.githubusercontent.com/u/1206395?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hugoabonizio", "html_url": "https://github.com/hugoabonizio", "followers_url": "https://api.github.com/users/hugoabonizio/followers", "following_url": "https://api.github.com/users/hugoabonizio/following{/other_user}", "gists_url": "https://api.github.com/users/hugoabonizio/gists{/gist_id}", "starred_url": "https://api.github.com/users/hugoabonizio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hugoabonizio/subscriptions", "organizations_url": "https://api.github.com/users/hugoabonizio/orgs", "repos_url": "https://api.github.com/users/hugoabonizio/repos", "events_url": "https://api.github.com/users/hugoabonizio/events{/privacy}", "received_events_url": "https://api.github.com/users/hugoabonizio/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq done! The failing testes don't seem to be related, it seems to be a connection issue, if I understand it correctly.", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1387/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1387", "html_url": "https://github.com/huggingface/datasets/pull/1387", "diff_url": "https://github.com/huggingface/datasets/pull/1387.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1387.patch", "merged_at": 1607963039000 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq yes. I asked the authors for direct link but unfortunately we need to fill a form (captcha)" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1386/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1386", "html_url": "https://github.com/huggingface/datasets/pull/1386", "diff_url": "https://github.com/huggingface/datasets/pull/1386.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1386.patch", "merged_at": 1607619501000 }

{ "login": "cstorm125", "id": 15519308, "node_id": "MDQ6VXNlcjE1NTE5MzA4", "avatar_url": "https://avatars.githubusercontent.com/u/15519308?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cstorm125", "html_url": "https://github.com/cstorm125", "followers_url": "https://api.github.com/users/cstorm125/followers", "following_url": "https://api.github.com/users/cstorm125/following{/other_user}", "gists_url": "https://api.github.com/users/cstorm125/gists{/gist_id}", "starred_url": "https://api.github.com/users/cstorm125/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cstorm125/subscriptions", "organizations_url": "https://api.github.com/users/cstorm125/orgs", "repos_url": "https://api.github.com/users/cstorm125/repos", "events_url": "https://api.github.com/users/cstorm125/events{/privacy}", "received_events_url": "https://api.github.com/users/cstorm125/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1385/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1385", "html_url": "https://github.com/huggingface/datasets/pull/1385", "diff_url": "https://github.com/huggingface/datasets/pull/1385.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1385.patch", "merged_at": 1607943548000 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1384/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1384", "html_url": "https://github.com/huggingface/datasets/pull/1384", "diff_url": "https://github.com/huggingface/datasets/pull/1384.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1384.patch", "merged_at": 1607619247000 }

{ "login": "rkc007", "id": 22396042, "node_id": "MDQ6VXNlcjIyMzk2MDQy", "avatar_url": "https://avatars.githubusercontent.com/u/22396042?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rkc007", "html_url": "https://github.com/rkc007", "followers_url": "https://api.github.com/users/rkc007/followers", "following_url": "https://api.github.com/users/rkc007/following{/other_user}", "gists_url": "https://api.github.com/users/rkc007/gists{/gist_id}", "starred_url": "https://api.github.com/users/rkc007/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rkc007/subscriptions", "organizations_url": "https://api.github.com/users/rkc007/orgs", "repos_url": "https://api.github.com/users/rkc007/repos", "events_url": "https://api.github.com/users/rkc007/events{/privacy}", "received_events_url": "https://api.github.com/users/rkc007/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq Thank you for the suggestions. I added the changes to the branch and seems after rebasing it to master, all the commits previous commits got added. Should I create a new PR or should I keep this one only ? ", "closing this one in favor of #1527 " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1383/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1383", "html_url": "https://github.com/huggingface/datasets/pull/1383", "diff_url": "https://github.com/huggingface/datasets/pull/1383.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1383.patch", "merged_at": null }

{ "login": "patil-suraj", "id": 27137566, "node_id": "MDQ6VXNlcjI3MTM3NTY2", "avatar_url": "https://avatars.githubusercontent.com/u/27137566?v=4", "gravatar_id": "", "url": "https://api.github.com/users/patil-suraj", "html_url": "https://github.com/patil-suraj", "followers_url": "https://api.github.com/users/patil-suraj/followers", "following_url": "https://api.github.com/users/patil-suraj/following{/other_user}", "gists_url": "https://api.github.com/users/patil-suraj/gists{/gist_id}", "starred_url": "https://api.github.com/users/patil-suraj/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/patil-suraj/subscriptions", "organizations_url": "https://api.github.com/users/patil-suraj/orgs", "repos_url": "https://api.github.com/users/patil-suraj/repos", "events_url": "https://api.github.com/users/patil-suraj/events{/privacy}", "received_events_url": "https://api.github.com/users/patil-suraj/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI just had a connection error" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1382/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1382", "html_url": "https://github.com/huggingface/datasets/pull/1382", "diff_url": "https://github.com/huggingface/datasets/pull/1382.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1382.patch", "merged_at": 1607536386000 }

{ "login": "dadelani", "id": 23586676, "node_id": "MDQ6VXNlcjIzNTg2Njc2", "avatar_url": "https://avatars.githubusercontent.com/u/23586676?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dadelani", "html_url": "https://github.com/dadelani", "followers_url": "https://api.github.com/users/dadelani/followers", "following_url": "https://api.github.com/users/dadelani/following{/other_user}", "gists_url": "https://api.github.com/users/dadelani/gists{/gist_id}", "starred_url": "https://api.github.com/users/dadelani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dadelani/subscriptions", "organizations_url": "https://api.github.com/users/dadelani/orgs", "repos_url": "https://api.github.com/users/dadelani/repos", "events_url": "https://api.github.com/users/dadelani/events{/privacy}", "received_events_url": "https://api.github.com/users/dadelani/received_events", "type": "User", "site_admin": false }

[]

[]

[ "looks like this PR includes changes about other datasets\r\n\r\nCan you only include the changes related to twi text c3 please ?", "Hi @lhoestq , I have removed the unnecessary files. Can you please confirm?", "You might need to either find a way to go back to the commit before it changes 389 files or create a new branch.", "okay, I have created another branch, see the latest pull https://github.com/huggingface/datasets/pull/1518 @cstorm125 ", "Hii please follow me", "Closing this one in favor of #1518" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1381/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1381", "html_url": "https://github.com/huggingface/datasets/pull/1381", "diff_url": "https://github.com/huggingface/datasets/pull/1381.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1381.patch", "merged_at": null }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1380/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1380", "html_url": "https://github.com/huggingface/datasets/pull/1380", "diff_url": "https://github.com/huggingface/datasets/pull/1380.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1380.patch", "merged_at": 1607619267000 }

{ "login": "dadelani", "id": 23586676, "node_id": "MDQ6VXNlcjIzNTg2Njc2", "avatar_url": "https://avatars.githubusercontent.com/u/23586676?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dadelani", "html_url": "https://github.com/dadelani", "followers_url": "https://api.github.com/users/dadelani/followers", "following_url": "https://api.github.com/users/dadelani/following{/other_user}", "gists_url": "https://api.github.com/users/dadelani/gists{/gist_id}", "starred_url": "https://api.github.com/users/dadelani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dadelani/subscriptions", "organizations_url": "https://api.github.com/users/dadelani/orgs", "repos_url": "https://api.github.com/users/dadelani/repos", "events_url": "https://api.github.com/users/dadelani/events{/privacy}", "received_events_url": "https://api.github.com/users/dadelani/received_events", "type": "User", "site_admin": false }

[]

[]

[ "looks like this PR includes changes about other datasets\r\n", "Thanks for the review. I'm a bit confused how to remove the files. Every time I add a new branch name using the following commands:\r\n\r\ngit fetch upstream\r\ngit rebase upstream/master\r\ngit checkout -b a-descriptive-name-for-my-changes\r\n\r\nand push to the origin, this issue occurs", "Can you try to create the branch from the master branch of your fork ?\r\n\r\nfirst update your master branch:\r\n```\r\ngit checkout master\r\ngit fetch upstream\r\ngit rebase upstream/master\r\ngit push\r\n```\r\n\r\nthen create a new one:\r\n```\r\ngit checkout -b my-new-branch\r\n```", "I think you were still having the files because you were creating the new branch from a branch in which you've committed the files, instead of creating the new branch from the master branch", "Got it, will correct that. Thanks", "@lhoestq , I have removed the unnecessary files. Looks like I still have one error. How do I resolve this?", "> @lhoestq , I have removed the unnecessary files. Looks like I still have one error. How do I resolve this?\r\n\r\nI think it's connection error on piqa dataset. Can you try triggering the test again? I usually resolve similar issues with:\r\n```\r\ngit fetch upstream\r\ngit rebase upstream/master\r\ngit push -u -f origin your_branch_name\r\n```", "thank you @cstorm125 ", "I have created another pull request for this https://github.com/huggingface/datasets/pull/1515 @cstorm125 @lhoestq ", "Hii please follow me", "merging since the CI is fixed on master", "Great, thanks a lot" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1379/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1379", "html_url": "https://github.com/huggingface/datasets/pull/1379", "diff_url": "https://github.com/huggingface/datasets/pull/1379.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1379.patch", "merged_at": 1607884652000 }

{ "login": "hugoabonizio", "id": 1206395, "node_id": "MDQ6VXNlcjEyMDYzOTU=", "avatar_url": "https://avatars.githubusercontent.com/u/1206395?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hugoabonizio", "html_url": "https://github.com/hugoabonizio", "followers_url": "https://api.github.com/users/hugoabonizio/followers", "following_url": "https://api.github.com/users/hugoabonizio/following{/other_user}", "gists_url": "https://api.github.com/users/hugoabonizio/gists{/gist_id}", "starred_url": "https://api.github.com/users/hugoabonizio/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hugoabonizio/subscriptions", "organizations_url": "https://api.github.com/users/hugoabonizio/orgs", "repos_url": "https://api.github.com/users/hugoabonizio/repos", "events_url": "https://api.github.com/users/hugoabonizio/events{/privacy}", "received_events_url": "https://api.github.com/users/hugoabonizio/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq done!", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1378/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1378", "html_url": "https://github.com/huggingface/datasets/pull/1378", "diff_url": "https://github.com/huggingface/datasets/pull/1378.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1378.patch", "merged_at": 1608046451000 }

{ "login": "ekdnam", "id": 40426312, "node_id": "MDQ6VXNlcjQwNDI2MzEy", "avatar_url": "https://avatars.githubusercontent.com/u/40426312?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekdnam", "html_url": "https://github.com/ekdnam", "followers_url": "https://api.github.com/users/ekdnam/followers", "following_url": "https://api.github.com/users/ekdnam/following{/other_user}", "gists_url": "https://api.github.com/users/ekdnam/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekdnam/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekdnam/subscriptions", "organizations_url": "https://api.github.com/users/ekdnam/orgs", "repos_url": "https://api.github.com/users/ekdnam/repos", "events_url": "https://api.github.com/users/ekdnam/events{/privacy}", "received_events_url": "https://api.github.com/users/ekdnam/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Can you make it a draft PR until you've added the dataset please ? @ekdnam ", "Done" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1377/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1377", "html_url": "https://github.com/huggingface/datasets/pull/1377", "diff_url": "https://github.com/huggingface/datasets/pull/1377.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1377.patch", "merged_at": null }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1376/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1376", "html_url": "https://github.com/huggingface/datasets/pull/1376", "diff_url": "https://github.com/huggingface/datasets/pull/1376.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1376.patch", "merged_at": 1607616716000 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1375/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1375", "html_url": "https://github.com/huggingface/datasets/pull/1375", "diff_url": "https://github.com/huggingface/datasets/pull/1375.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1375.patch", "merged_at": 1607616668000 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1374/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1374", "html_url": "https://github.com/huggingface/datasets/pull/1374", "diff_url": "https://github.com/huggingface/datasets/pull/1374.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1374.patch", "merged_at": 1607616688000 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1373/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1373", "html_url": "https://github.com/huggingface/datasets/pull/1373", "diff_url": "https://github.com/huggingface/datasets/pull/1373.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1373.patch", "merged_at": 1607613954000 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq done" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1372/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1372", "html_url": "https://github.com/huggingface/datasets/pull/1372", "diff_url": "https://github.com/huggingface/datasets/pull/1372.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1372.patch", "merged_at": 1607939787000 }

{ "login": "patil-suraj", "id": 27137566, "node_id": "MDQ6VXNlcjI3MTM3NTY2", "avatar_url": "https://avatars.githubusercontent.com/u/27137566?v=4", "gravatar_id": "", "url": "https://api.github.com/users/patil-suraj", "html_url": "https://github.com/patil-suraj", "followers_url": "https://api.github.com/users/patil-suraj/followers", "following_url": "https://api.github.com/users/patil-suraj/following{/other_user}", "gists_url": "https://api.github.com/users/patil-suraj/gists{/gist_id}", "starred_url": "https://api.github.com/users/patil-suraj/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/patil-suraj/subscriptions", "organizations_url": "https://api.github.com/users/patil-suraj/orgs", "repos_url": "https://api.github.com/users/patil-suraj/repos", "events_url": "https://api.github.com/users/patil-suraj/events{/privacy}", "received_events_url": "https://api.github.com/users/patil-suraj/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1371/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1371", "html_url": "https://github.com/huggingface/datasets/pull/1371", "diff_url": "https://github.com/huggingface/datasets/pull/1371.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1371.patch", "merged_at": 1607536417000 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1370/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1370", "html_url": "https://github.com/huggingface/datasets/pull/1370", "diff_url": "https://github.com/huggingface/datasets/pull/1370.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1370.patch", "merged_at": 1607614644000 }

{ "login": "albertvillanova", "id": 8515462, "node_id": "MDQ6VXNlcjg1MTU0NjI=", "avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4", "gravatar_id": "", "url": "https://api.github.com/users/albertvillanova", "html_url": "https://github.com/albertvillanova", "followers_url": "https://api.github.com/users/albertvillanova/followers", "following_url": "https://api.github.com/users/albertvillanova/following{/other_user}", "gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}", "starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions", "organizations_url": "https://api.github.com/users/albertvillanova/orgs", "repos_url": "https://api.github.com/users/albertvillanova/repos", "events_url": "https://api.github.com/users/albertvillanova/events{/privacy}", "received_events_url": "https://api.github.com/users/albertvillanova/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I have a question: why not using a tmp dir instead, like the DummyDataGeneratorDownloadManager does?", "Hi @lhoestq, I am trying to understand better the logic...\r\n\r\nWhy do we have a `dynamic_module_path` besides the modules cache path?\r\n```python\r\nDYNAMIC_MODULES_PATH = os.path.join(HF_MODULES_CACHE, \"datasets_modules\")\r\n```\r\nMoreover, 2 subdirectories (for datasets and for metrics) were created inside it:\r\n```python\r\nDATASETS_PATH = os.path.join(DYNAMIC_MODULES_PATH, \"datasets\")\r\nMETRICS_PATH = os.path.join(DYNAMIC_MODULES_PATH, \"metrics\")\r\n```", "Hi :) \r\nThe modules cache path is the path added to `sys.path`.\r\nTherefore inside we need to have a folder that is going to be a package: `datasets_modules`.\r\nThis package will contain dynamic modules, i.e. datasets and metrics modules added on-the-fly.\r\nThen we have two sub-modules `datasets_modules.datasets` and `datasets_modules.metrics`.\r\n\r\nMaybe we can make things more explicit in the code with some comments explaining the structure, and maybe better variable naming as well..\r\n\r\nAlso I wanted to say that I started to work on offline loading of modules in #1726 and actually it lead to do similar changes to what you did to control the path where modules are stored.", "Hi @lhoestq, I see...\r\n\r\nIndeed I was also creating a draft for test_load, to clarify the expected behavior... ;)\r\n\r\nSo, for the command line:\r\n```sh\r\npython datasets-cli test datasets/<my-dataset-folder> --save_infos --all_configs --cache_dir <my-cache-dir>\r\n```\r\nthe `cache_dir` argument refers to dataset cache dir. We do not have control over the modules cache dir, but we would like to have. And if I understand well, you suggest adding another argument `dynamic_module_path`. Am I right?", "> So, for the command line:\r\n> \r\n> ```shell\r\n> python datasets-cli test datasets/<my-dataset-folder> --save_infos --all_configs --cache_dir <my-cache-dir>\r\n> ```\r\n> \r\n> the `cache_dir` argument refers to dataset cache dir. We do not have control over the modules cache dir, but we would like to have. And if I understand well, you suggest adding another argument `dynamic_module_path`. Am I right?\r\n\r\nYes the cache_dir is used to download files and also so save the dataset arrow files.\r\nThis is indeed different from the path for dynamic modules.\r\n\r\nI suggested to have `dynamic_module_path` as a parameter but actually this is the parent directory `hf_modules_cache` that we would need (it's the one that is passed to `init_dynamic_modules ` that we need to add to `sys.path`).\r\n\r\nCurrently it's already possible to override it using the env variable `HF_MODULES_CACHE` but we can imagine having it as a parameter as well.\r\n\r\nThis way the user controls both the `cache_dir` and the `hf_modules_cache` which are the two places used by the library to read/write stuff.\r\n\r\n", "I think #1726 is going to be merged pretty soon. Maybe can work on this as soon as it's merged to avoid doing the same things twice and to avoid conflicts ?", "I agree. Indeed I took some of your code in one of my last commit, to try to implement the logic you described." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1369/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1369", "html_url": "https://github.com/huggingface/datasets/pull/1369", "diff_url": "https://github.com/huggingface/datasets/pull/1369.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1369.patch", "merged_at": null }

{ "login": "ghomasHudson", "id": 13795113, "node_id": "MDQ6VXNlcjEzNzk1MTEz", "avatar_url": "https://avatars.githubusercontent.com/u/13795113?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ghomasHudson", "html_url": "https://github.com/ghomasHudson", "followers_url": "https://api.github.com/users/ghomasHudson/followers", "following_url": "https://api.github.com/users/ghomasHudson/following{/other_user}", "gists_url": "https://api.github.com/users/ghomasHudson/gists{/gist_id}", "starred_url": "https://api.github.com/users/ghomasHudson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ghomasHudson/subscriptions", "organizations_url": "https://api.github.com/users/ghomasHudson/orgs", "repos_url": "https://api.github.com/users/ghomasHudson/repos", "events_url": "https://api.github.com/users/ghomasHudson/events{/privacy}", "received_events_url": "https://api.github.com/users/ghomasHudson/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq I think I've fixed the dummy data - it finally passes! I'll add the model card now.", "@lhoestq - pretty happy with it now", "> Awesome thank you !\r\n> \r\n> Could you try to reduce the size of the dummy_data.zip file before we merge ? (it's 300KB right now)\r\n> \r\n> To do so feel free to take a look inside it and remove all the unnecessary files and chunks of text, to only keep a few examples. The idea is to have a zip file that is only a few KB\r\n\r\nAh, it only contains 1 example for each split. I think the problem is that I include an entire story (like in the full dataset). We can probably get away with a summarised version.", "> Nice thank you, can you make it even lighter if possible ? Something round 10KB would be awesone\r\n> We try to keep the repo light so that it doesn't take ages to clone. So we have to make sure the dummy data are as small as possible for every single dataset.\r\n\r\nHave trimmed a little more out of each example now." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1368/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1368", "html_url": "https://github.com/huggingface/datasets/pull/1368", "diff_url": "https://github.com/huggingface/datasets/pull/1368.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1368.patch", "merged_at": null }

{ "login": "forest1988", "id": 2755894, "node_id": "MDQ6VXNlcjI3NTU4OTQ=", "avatar_url": "https://avatars.githubusercontent.com/u/2755894?v=4", "gravatar_id": "", "url": "https://api.github.com/users/forest1988", "html_url": "https://github.com/forest1988", "followers_url": "https://api.github.com/users/forest1988/followers", "following_url": "https://api.github.com/users/forest1988/following{/other_user}", "gists_url": "https://api.github.com/users/forest1988/gists{/gist_id}", "starred_url": "https://api.github.com/users/forest1988/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/forest1988/subscriptions", "organizations_url": "https://api.github.com/users/forest1988/orgs", "repos_url": "https://api.github.com/users/forest1988/repos", "events_url": "https://api.github.com/users/forest1988/events{/privacy}", "received_events_url": "https://api.github.com/users/forest1988/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I think it's because the file you download uncompresses into a file and not a folder so `--autogenerate` couldn't create dummy data for you. See in your dummy_data.zip if there is a file there. If not, manually create your dummy data and compress them to dummy_data.zip.", "@cstorm125 Thank you for the comment! \r\nAs you point out, it seems my code has something wrong about downloading and uncompressing the file.\r\nHowever, my manually created dummy data seems to contain a file of the required format.\r\n\r\nOn Colaboratory,\r\n`!unzip /content/datasets/datasets/covid_tweets_japanese/dummy/1.1.0/dummy_data.zip`\r\nreturns:\r\n\r\n```\r\nArchive: /content/datasets/datasets/covid_tweets_japanese/dummy/1.1.0/dummy_data.zip\r\n creating: content/datasets/datasets/covid_tweets_japanese/dummy/1.1.0/dummy_data/\r\n extracting: content/datasets/datasets/covid_tweets_japanese/dummy/1.1.0/dummy_data/data.csv.bz2 \r\n```\r\n\r\nThe original data is `data.csv.bz2`, and I had a very hard time dealing with uncompressing bzip2.\r\nI think I could handle it, but there may be problems remain." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1367/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1367", "html_url": "https://github.com/huggingface/datasets/pull/1367", "diff_url": "https://github.com/huggingface/datasets/pull/1367.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1367.patch", "merged_at": null }

{ "login": "jamespaultg", "id": 7421838, "node_id": "MDQ6VXNlcjc0MjE4Mzg=", "avatar_url": "https://avatars.githubusercontent.com/u/7421838?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jamespaultg", "html_url": "https://github.com/jamespaultg", "followers_url": "https://api.github.com/users/jamespaultg/followers", "following_url": "https://api.github.com/users/jamespaultg/following{/other_user}", "gists_url": "https://api.github.com/users/jamespaultg/gists{/gist_id}", "starred_url": "https://api.github.com/users/jamespaultg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jamespaultg/subscriptions", "organizations_url": "https://api.github.com/users/jamespaultg/orgs", "repos_url": "https://api.github.com/users/jamespaultg/repos", "events_url": "https://api.github.com/users/jamespaultg/events{/privacy}", "received_events_url": "https://api.github.com/users/jamespaultg/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq Have addressed your comments. Please review. Thanks." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1366/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1366", "html_url": "https://github.com/huggingface/datasets/pull/1366", "diff_url": "https://github.com/huggingface/datasets/pull/1366.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1366.patch", "merged_at": 1607956077000 }

{ "login": "cceyda", "id": 15624271, "node_id": "MDQ6VXNlcjE1NjI0Mjcx", "avatar_url": "https://avatars.githubusercontent.com/u/15624271?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cceyda", "html_url": "https://github.com/cceyda", "followers_url": "https://api.github.com/users/cceyda/followers", "following_url": "https://api.github.com/users/cceyda/following{/other_user}", "gists_url": "https://api.github.com/users/cceyda/gists{/gist_id}", "starred_url": "https://api.github.com/users/cceyda/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cceyda/subscriptions", "organizations_url": "https://api.github.com/users/cceyda/orgs", "repos_url": "https://api.github.com/users/cceyda/repos", "events_url": "https://api.github.com/users/cceyda/events{/privacy}", "received_events_url": "https://api.github.com/users/cceyda/received_events", "type": "User", "site_admin": false }

[]

[]

[ "the `RemoteDatasetTest ` error pf the CI is fixed on master so it's fine", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1365/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1365", "html_url": "https://github.com/huggingface/datasets/pull/1365", "diff_url": "https://github.com/huggingface/datasets/pull/1365.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1365.patch", "merged_at": 1607614676000 }

{ "login": "rsanjaykamath", "id": 18527321, "node_id": "MDQ6VXNlcjE4NTI3MzIx", "avatar_url": "https://avatars.githubusercontent.com/u/18527321?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rsanjaykamath", "html_url": "https://github.com/rsanjaykamath", "followers_url": "https://api.github.com/users/rsanjaykamath/followers", "following_url": "https://api.github.com/users/rsanjaykamath/following{/other_user}", "gists_url": "https://api.github.com/users/rsanjaykamath/gists{/gist_id}", "starred_url": "https://api.github.com/users/rsanjaykamath/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rsanjaykamath/subscriptions", "organizations_url": "https://api.github.com/users/rsanjaykamath/orgs", "repos_url": "https://api.github.com/users/rsanjaykamath/repos", "events_url": "https://api.github.com/users/rsanjaykamath/events{/privacy}", "received_events_url": "https://api.github.com/users/rsanjaykamath/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Hi ! Maybe we can rename it `narrativeqa_manual` to make it explicit that this one requires manual download contrary to `narrativeqa` ?\r\nIt's important to have this one as well, in case the `narrativeqa` one suffers from download issues (checksums or dead links for example).\r\n\r\nYou can also copy the dataset card from `narrativeqa` and add the dummy data as well", "Thanks @lhoestq will do all this and submit a request in the coming days. 😊 ", "Closing this as another pull request is already done. " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1364/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1364", "html_url": "https://github.com/huggingface/datasets/pull/1364", "diff_url": "https://github.com/huggingface/datasets/pull/1364.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1364.patch", "merged_at": null }

{ "login": "patil-suraj", "id": 27137566, "node_id": "MDQ6VXNlcjI3MTM3NTY2", "avatar_url": "https://avatars.githubusercontent.com/u/27137566?v=4", "gravatar_id": "", "url": "https://api.github.com/users/patil-suraj", "html_url": "https://github.com/patil-suraj", "followers_url": "https://api.github.com/users/patil-suraj/followers", "following_url": "https://api.github.com/users/patil-suraj/following{/other_user}", "gists_url": "https://api.github.com/users/patil-suraj/gists{/gist_id}", "starred_url": "https://api.github.com/users/patil-suraj/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/patil-suraj/subscriptions", "organizations_url": "https://api.github.com/users/patil-suraj/orgs", "repos_url": "https://api.github.com/users/patil-suraj/repos", "events_url": "https://api.github.com/users/patil-suraj/events{/privacy}", "received_events_url": "https://api.github.com/users/patil-suraj/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1363/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1363", "html_url": "https://github.com/huggingface/datasets/pull/1363", "diff_url": "https://github.com/huggingface/datasets/pull/1363.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1363.patch", "merged_at": 1607536459000 }

{ "login": "patil-suraj", "id": 27137566, "node_id": "MDQ6VXNlcjI3MTM3NTY2", "avatar_url": "https://avatars.githubusercontent.com/u/27137566?v=4", "gravatar_id": "", "url": "https://api.github.com/users/patil-suraj", "html_url": "https://github.com/patil-suraj", "followers_url": "https://api.github.com/users/patil-suraj/followers", "following_url": "https://api.github.com/users/patil-suraj/following{/other_user}", "gists_url": "https://api.github.com/users/patil-suraj/gists{/gist_id}", "starred_url": "https://api.github.com/users/patil-suraj/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/patil-suraj/subscriptions", "organizations_url": "https://api.github.com/users/patil-suraj/orgs", "repos_url": "https://api.github.com/users/patil-suraj/repos", "events_url": "https://api.github.com/users/patil-suraj/events{/privacy}", "received_events_url": "https://api.github.com/users/patil-suraj/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thanks Quentin !" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1362/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1362", "html_url": "https://github.com/huggingface/datasets/pull/1362", "diff_url": "https://github.com/huggingface/datasets/pull/1362.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1362.patch", "merged_at": 1607537628000 }

{ "login": "kldarek", "id": 15803781, "node_id": "MDQ6VXNlcjE1ODAzNzgx", "avatar_url": "https://avatars.githubusercontent.com/u/15803781?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kldarek", "html_url": "https://github.com/kldarek", "followers_url": "https://api.github.com/users/kldarek/followers", "following_url": "https://api.github.com/users/kldarek/following{/other_user}", "gists_url": "https://api.github.com/users/kldarek/gists{/gist_id}", "starred_url": "https://api.github.com/users/kldarek/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kldarek/subscriptions", "organizations_url": "https://api.github.com/users/kldarek/orgs", "repos_url": "https://api.github.com/users/kldarek/repos", "events_url": "https://api.github.com/users/kldarek/events{/privacy}", "received_events_url": "https://api.github.com/users/kldarek/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq I think this is ready for review, I assume the errors (connection) are unrelated to the PR :) ", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1361/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1361", "html_url": "https://github.com/huggingface/datasets/pull/1361", "diff_url": "https://github.com/huggingface/datasets/pull/1361.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1361.patch", "merged_at": 1608138284000 }

{ "login": "cstorm125", "id": 15519308, "node_id": "MDQ6VXNlcjE1NTE5MzA4", "avatar_url": "https://avatars.githubusercontent.com/u/15519308?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cstorm125", "html_url": "https://github.com/cstorm125", "followers_url": "https://api.github.com/users/cstorm125/followers", "following_url": "https://api.github.com/users/cstorm125/following{/other_user}", "gists_url": "https://api.github.com/users/cstorm125/gists{/gist_id}", "starred_url": "https://api.github.com/users/cstorm125/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cstorm125/subscriptions", "organizations_url": "https://api.github.com/users/cstorm125/orgs", "repos_url": "https://api.github.com/users/cstorm125/repos", "events_url": "https://api.github.com/users/cstorm125/events{/privacy}", "received_events_url": "https://api.github.com/users/cstorm125/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1360/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1360", "html_url": "https://github.com/huggingface/datasets/pull/1360", "diff_url": "https://github.com/huggingface/datasets/pull/1360.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1360.patch", "merged_at": 1607610521000 }

{ "login": "edugp", "id": 17855740, "node_id": "MDQ6VXNlcjE3ODU1NzQw", "avatar_url": "https://avatars.githubusercontent.com/u/17855740?v=4", "gravatar_id": "", "url": "https://api.github.com/users/edugp", "html_url": "https://github.com/edugp", "followers_url": "https://api.github.com/users/edugp/followers", "following_url": "https://api.github.com/users/edugp/following{/other_user}", "gists_url": "https://api.github.com/users/edugp/gists{/gist_id}", "starred_url": "https://api.github.com/users/edugp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/edugp/subscriptions", "organizations_url": "https://api.github.com/users/edugp/orgs", "repos_url": "https://api.github.com/users/edugp/repos", "events_url": "https://api.github.com/users/edugp/events{/privacy}", "received_events_url": "https://api.github.com/users/edugp/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1359/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1359", "html_url": "https://github.com/huggingface/datasets/pull/1359", "diff_url": "https://github.com/huggingface/datasets/pull/1359.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1359.patch", "merged_at": 1607610276000 }

{ "login": "olinguyen", "id": 4341867, "node_id": "MDQ6VXNlcjQzNDE4Njc=", "avatar_url": "https://avatars.githubusercontent.com/u/4341867?v=4", "gravatar_id": "", "url": "https://api.github.com/users/olinguyen", "html_url": "https://github.com/olinguyen", "followers_url": "https://api.github.com/users/olinguyen/followers", "following_url": "https://api.github.com/users/olinguyen/following{/other_user}", "gists_url": "https://api.github.com/users/olinguyen/gists{/gist_id}", "starred_url": "https://api.github.com/users/olinguyen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/olinguyen/subscriptions", "organizations_url": "https://api.github.com/users/olinguyen/orgs", "repos_url": "https://api.github.com/users/olinguyen/repos", "events_url": "https://api.github.com/users/olinguyen/events{/privacy}", "received_events_url": "https://api.github.com/users/olinguyen/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1358/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1358", "html_url": "https://github.com/huggingface/datasets/pull/1358", "diff_url": "https://github.com/huggingface/datasets/pull/1358.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1358.patch", "merged_at": 1607613151000 }

{ "login": "2dot71mily", "id": 21292059, "node_id": "MDQ6VXNlcjIxMjkyMDU5", "avatar_url": "https://avatars.githubusercontent.com/u/21292059?v=4", "gravatar_id": "", "url": "https://api.github.com/users/2dot71mily", "html_url": "https://github.com/2dot71mily", "followers_url": "https://api.github.com/users/2dot71mily/followers", "following_url": "https://api.github.com/users/2dot71mily/following{/other_user}", "gists_url": "https://api.github.com/users/2dot71mily/gists{/gist_id}", "starred_url": "https://api.github.com/users/2dot71mily/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/2dot71mily/subscriptions", "organizations_url": "https://api.github.com/users/2dot71mily/orgs", "repos_url": "https://api.github.com/users/2dot71mily/repos", "events_url": "https://api.github.com/users/2dot71mily/events{/privacy}", "received_events_url": "https://api.github.com/users/2dot71mily/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Sorry about forgetting flake8.\r\nRather than use up the circleci resources on a new push with only formatting changes, I will wait to push until the results from all tests finish and/or any feedback comes in... probably tomorrow for me.", "\r\nSo... my normal work is with mercurial and seem to have clearly forked this up using git... :(\r\n\r\nWhat I did is after calling:\r\n```\r\ngit fetch upstream\r\ngit rebase upstream/master\r\n```\r\n\r\nI then I attempt to pull in my most recent changes UI commit changes based on @lhoestq's feedback with:\r\n```\r\ngit pull\r\n``` \r\n... which I now suspect undid the above fetch and rebase. Will look into fixing later today when I have more time. Sorry!\r\n", "My dummy data seems quite large as a single row is composed of tokens/labels for an entire youtube video, with at least one row required for each file, which in this case 1 file per 13 youtube channels.\r\n\r\nTo make it smaller I passed `--n_lines 1` to reduce about 5x.\r\n\r\nI then manually reduced size of the particularly long youtube lectures to get the size to about 30KB. However, after recompressing into a zip, and running dummy data test I got the following error:\r\n`FAILED tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_youtube_caption_corrections - OSError: Cannot find data file. `, despite file being there, which I haven't had a chance yet to debug.", "I wrote a small script to generate a smaller json file for the dummy_data, with the hope that I could resolve the pytest error noted above (in case related to a manual typo I could have introduce), however the test contains to fail locally... here's to hoping it can pass on remote!", "Sorry for delayed comments here. Last commit made two changes:\r\n- Increased the valency of the labels from just True/False to more categories to describe the various types of diffs encountered. This required some rewrite of the README\r\n- Reduced the number of remote files to be downloaded from 13 to 4, by combining all 13 of the channel-specific files together, and the splitting them up in a way to meet Github file size requirements. This also reduces size of the dummy-data.", "@lhoestq, thank you for the great feedback, especially given how busy you guys are now! \r\n\r\nI checked out GitHub release tags and looks cool. I have added the version tag to the url, instead of the commit sha as originally suggested, with the hope that it serves the same purpose of pinning the content to this url. Please let me know if I have misunderstood.\r\n\r\nIn regard to dynamically changing the number of files downloaded by first downloading a JSON listing the files, I love that idea. But I am a little confused, as I was thinking that any changes to the dataset itself would require a new PR with an updated `dataset_infos.json`, e.g. `num_examples` would increase. \r\n\r\nIf the purpose of this is not to permit dynamic (without a PR needed) growth of the number of files, but instead to provide stability to the consumers of the dataset, maybe I continued use the release tags, maintaining access to old releases could serve this purpose? I am still learning about these release tags... ", "For dynamic datasets, i.e. datasets that evolve over time, we support custom configurations: they are configurations that are not part of the BUILDER_CONFIGS or in the dataset_infos.json\r\n\r\nFor example for wikipedia, you can use the latest wiki dump by specifying `date=` inside `load_dataset()`. A configuration is created on the fly for this date and is used to build the dataset using the latest data.\r\n\r\nTherefore we don't need to have PRs to update the script for each wikipedia release.\r\n\r\nOne downside though is that we don't have metadata in advance such as the size of the dataset.\r\n\r\nI think this could be a nice addition for the youtube caption dataset in the future to be have a system of releases and be able to load the version we want easily. What do you think ?", "\r\n\r\n\r\n\r\n> For dynamic datasets, i.e. datasets that evolve over time, we support custom configurations: they are configurations that are not part of the BUILDER_CONFIGS or in the dataset_infos.json\r\n> \r\n \r\n> I think this could be a nice addition for the youtube caption dataset in the future to be have a system of releases and be able to load the version we want easily. What do you think ?\r\n\r\nThank you for the suggestion! This sounds great! I will take a look at the some datasets that do this, and would love to give it a try in the future, if I continue to grow the captions dataset in a meaningful way. \r\n\r\nAppreciate all the help on this. It has been a really great experience for me. :)", "Excited to merge! And sorry to be such a github n00b, but from what I've quickly read, I don't 'Close pull request', but rather the next steps are action taken on your end... Please let me know if there is some action to be taken at my end first. :/", "Alright merging this one then :) " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1357/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1357", "html_url": "https://github.com/huggingface/datasets/pull/1357", "diff_url": "https://github.com/huggingface/datasets/pull/1357.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1357.patch", "merged_at": 1608055976000 }

{ "login": "ncoop57", "id": 7613470, "node_id": "MDQ6VXNlcjc2MTM0NzA=", "avatar_url": "https://avatars.githubusercontent.com/u/7613470?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ncoop57", "html_url": "https://github.com/ncoop57", "followers_url": "https://api.github.com/users/ncoop57/followers", "following_url": "https://api.github.com/users/ncoop57/following{/other_user}", "gists_url": "https://api.github.com/users/ncoop57/gists{/gist_id}", "starred_url": "https://api.github.com/users/ncoop57/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ncoop57/subscriptions", "organizations_url": "https://api.github.com/users/ncoop57/orgs", "repos_url": "https://api.github.com/users/ncoop57/repos", "events_url": "https://api.github.com/users/ncoop57/events{/privacy}", "received_events_url": "https://api.github.com/users/ncoop57/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq Thanks for the review and suggestions! I've added your comments and pushed the changes. I'm having issues with the dummy data still. When I run the dummy data test\r\n\r\n```bash\r\nRUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_so_stacksample\r\n```\r\nI get this error: \r\n\r\n```\r\n___________________________________________ LocalDatasetTest.test_load_dataset_all_configs_so_stacksample ____________________________________________\r\n\r\nself = <tests.test_dataset_common.LocalDatasetTest testMethod=test_load_dataset_all_configs_so_stacksample>, dataset_name = 'so_stacksample'\r\n\r\n @slow\r\n def test_load_dataset_all_configs(self, dataset_name):\r\n configs = self.dataset_tester.load_all_configs(dataset_name, is_local=True)\r\n> self.dataset_tester.check_load_dataset(dataset_name, configs, is_local=True)\r\n\r\ntests/test_dataset_common.py:237: \r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ \r\ntests/test_dataset_common.py:198: in check_load_dataset\r\n self.parent.assertTrue(len(dataset[split]) > 0)\r\nE AssertionError: False is not true\r\n\r\nFAILED tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_so_stacksample - AssertionError: False is not true\r\n```\r\n\r\nI tried formatting the data similar to other datasets, but I think I don't have my csv's in the zip folder with the proper name. I also ran the command that's supposed to outline the exact steps I need to perform to get them into the correct format, but I followed them and they don't seem to be working still :/. Any help would be greatly appreciated!\r\n", "Ok I found the issue with the dummy data.\r\nIt's currently failing because it's not generating a single example using the dummy csv file.\r\nThat's because there's only only line in the dummy csv file, and this line is skipped using the `next()` call used to ignore the headers of the csv.\r\n\r\nTo fix the dummy data you must add headers to the dummy csv files.", "Also can you make sure that all the original CSV files have headers ? i.e. check that their first line is just the column names", "> Ok I found the issue with the dummy data.\r\n> It's currently failing because it's not generating a single example using the dummy csv file.\r\n> That's because there's only only line in the dummy csv file, and this line is skipped using the `next()` call used to ignore the headers of the csv.\r\n> \r\n> To fix the dummy data you must add headers to the dummy csv files.\r\n\r\nOh man, I bamboozled myself! Thank you @lhoestq for catching that! I've updated the dummy csv's to include headers and also confirmed that they all have headers, so I am not throwing away any information with that `next()` call. When I run the test locally for the dummy data it passes, so hopefully it is good to go :D", "merging since the Ci is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1356/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1356", "html_url": "https://github.com/huggingface/datasets/pull/1356", "diff_url": "https://github.com/huggingface/datasets/pull/1356.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1356.patch", "merged_at": 1608562101000 }

{ "login": "reshinthadithyan", "id": 36307201, "node_id": "MDQ6VXNlcjM2MzA3MjAx", "avatar_url": "https://avatars.githubusercontent.com/u/36307201?v=4", "gravatar_id": "", "url": "https://api.github.com/users/reshinthadithyan", "html_url": "https://github.com/reshinthadithyan", "followers_url": "https://api.github.com/users/reshinthadithyan/followers", "following_url": "https://api.github.com/users/reshinthadithyan/following{/other_user}", "gists_url": "https://api.github.com/users/reshinthadithyan/gists{/gist_id}", "starred_url": "https://api.github.com/users/reshinthadithyan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/reshinthadithyan/subscriptions", "organizations_url": "https://api.github.com/users/reshinthadithyan/orgs", "repos_url": "https://api.github.com/users/reshinthadithyan/repos", "events_url": "https://api.github.com/users/reshinthadithyan/events{/privacy}", "received_events_url": "https://api.github.com/users/reshinthadithyan/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1355/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1355", "html_url": "https://github.com/huggingface/datasets/pull/1355", "diff_url": "https://github.com/huggingface/datasets/pull/1355.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1355.patch", "merged_at": 1607530788000 }

{ "login": "anaerobeth", "id": 3663322, "node_id": "MDQ6VXNlcjM2NjMzMjI=", "avatar_url": "https://avatars.githubusercontent.com/u/3663322?v=4", "gravatar_id": "", "url": "https://api.github.com/users/anaerobeth", "html_url": "https://github.com/anaerobeth", "followers_url": "https://api.github.com/users/anaerobeth/followers", "following_url": "https://api.github.com/users/anaerobeth/following{/other_user}", "gists_url": "https://api.github.com/users/anaerobeth/gists{/gist_id}", "starred_url": "https://api.github.com/users/anaerobeth/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/anaerobeth/subscriptions", "organizations_url": "https://api.github.com/users/anaerobeth/orgs", "repos_url": "https://api.github.com/users/anaerobeth/repos", "events_url": "https://api.github.com/users/anaerobeth/events{/privacy}", "received_events_url": "https://api.github.com/users/anaerobeth/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1354/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1354", "html_url": "https://github.com/huggingface/datasets/pull/1354", "diff_url": "https://github.com/huggingface/datasets/pull/1354.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1354.patch", "merged_at": 1607613030000 }

{ "login": "ncoop57", "id": 7613470, "node_id": "MDQ6VXNlcjc2MTM0NzA=", "avatar_url": "https://avatars.githubusercontent.com/u/7613470?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ncoop57", "html_url": "https://github.com/ncoop57", "followers_url": "https://api.github.com/users/ncoop57/followers", "following_url": "https://api.github.com/users/ncoop57/following{/other_user}", "gists_url": "https://api.github.com/users/ncoop57/gists{/gist_id}", "starred_url": "https://api.github.com/users/ncoop57/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ncoop57/subscriptions", "organizations_url": "https://api.github.com/users/ncoop57/orgs", "repos_url": "https://api.github.com/users/ncoop57/repos", "events_url": "https://api.github.com/users/ncoop57/events{/privacy}", "received_events_url": "https://api.github.com/users/ncoop57/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1353/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1353", "html_url": "https://github.com/huggingface/datasets/pull/1353", "diff_url": "https://github.com/huggingface/datasets/pull/1353.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1353.patch", "merged_at": 1607607915000 }

{ "login": "cstorm125", "id": 15519308, "node_id": "MDQ6VXNlcjE1NTE5MzA4", "avatar_url": "https://avatars.githubusercontent.com/u/15519308?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cstorm125", "html_url": "https://github.com/cstorm125", "followers_url": "https://api.github.com/users/cstorm125/followers", "following_url": "https://api.github.com/users/cstorm125/following{/other_user}", "gists_url": "https://api.github.com/users/cstorm125/gists{/gist_id}", "starred_url": "https://api.github.com/users/cstorm125/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cstorm125/subscriptions", "organizations_url": "https://api.github.com/users/cstorm125/orgs", "repos_url": "https://api.github.com/users/cstorm125/repos", "events_url": "https://api.github.com/users/cstorm125/events{/privacy}", "received_events_url": "https://api.github.com/users/cstorm125/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1352/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1352", "html_url": "https://github.com/huggingface/datasets/pull/1352", "diff_url": "https://github.com/huggingface/datasets/pull/1352.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1352.patch", "merged_at": 1607607737000 }

{ "login": "ZacharySBrown", "id": 7950786, "node_id": "MDQ6VXNlcjc5NTA3ODY=", "avatar_url": "https://avatars.githubusercontent.com/u/7950786?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ZacharySBrown", "html_url": "https://github.com/ZacharySBrown", "followers_url": "https://api.github.com/users/ZacharySBrown/followers", "following_url": "https://api.github.com/users/ZacharySBrown/following{/other_user}", "gists_url": "https://api.github.com/users/ZacharySBrown/gists{/gist_id}", "starred_url": "https://api.github.com/users/ZacharySBrown/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ZacharySBrown/subscriptions", "organizations_url": "https://api.github.com/users/ZacharySBrown/orgs", "repos_url": "https://api.github.com/users/ZacharySBrown/repos", "events_url": "https://api.github.com/users/ZacharySBrown/events{/privacy}", "received_events_url": "https://api.github.com/users/ZacharySBrown/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1351/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1351", "html_url": "https://github.com/huggingface/datasets/pull/1351", "diff_url": "https://github.com/huggingface/datasets/pull/1351.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1351.patch", "merged_at": 1607609674000 }

{ "login": "jonatasgrosman", "id": 5097052, "node_id": "MDQ6VXNlcjUwOTcwNTI=", "avatar_url": "https://avatars.githubusercontent.com/u/5097052?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jonatasgrosman", "html_url": "https://github.com/jonatasgrosman", "followers_url": "https://api.github.com/users/jonatasgrosman/followers", "following_url": "https://api.github.com/users/jonatasgrosman/following{/other_user}", "gists_url": "https://api.github.com/users/jonatasgrosman/gists{/gist_id}", "starred_url": "https://api.github.com/users/jonatasgrosman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jonatasgrosman/subscriptions", "organizations_url": "https://api.github.com/users/jonatasgrosman/orgs", "repos_url": "https://api.github.com/users/jonatasgrosman/repos", "events_url": "https://api.github.com/users/jonatasgrosman/events{/privacy}", "received_events_url": "https://api.github.com/users/jonatasgrosman/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I don't know what happened, my first commit passed on all checks, but after just a README.md update one of the scripts failed, is it normal? 😕 ", "Looks like a flaky connection error, I've launched a re-run, it should be fine :)", "The RemoteDatasetTest error in the CI is just a connection error, we can ignore it", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1350/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1350", "html_url": "https://github.com/huggingface/datasets/pull/1350", "diff_url": "https://github.com/huggingface/datasets/pull/1350.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1350.patch", "merged_at": 1607609493000 }

{ "login": "Karthik-Bhaskar", "id": 13200370, "node_id": "MDQ6VXNlcjEzMjAwMzcw", "avatar_url": "https://avatars.githubusercontent.com/u/13200370?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Karthik-Bhaskar", "html_url": "https://github.com/Karthik-Bhaskar", "followers_url": "https://api.github.com/users/Karthik-Bhaskar/followers", "following_url": "https://api.github.com/users/Karthik-Bhaskar/following{/other_user}", "gists_url": "https://api.github.com/users/Karthik-Bhaskar/gists{/gist_id}", "starred_url": "https://api.github.com/users/Karthik-Bhaskar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Karthik-Bhaskar/subscriptions", "organizations_url": "https://api.github.com/users/Karthik-Bhaskar/orgs", "repos_url": "https://api.github.com/users/Karthik-Bhaskar/repos", "events_url": "https://api.github.com/users/Karthik-Bhaskar/events{/privacy}", "received_events_url": "https://api.github.com/users/Karthik-Bhaskar/received_events", "type": "User", "site_admin": false }

[]

[]

[ "looks like this dataset includes changes about many other files than the ones for multi_re_qa\r\n\r\nCan you create another branch and another PR please ?", "> looks like this dataset includes changes about many other files than the ones for multi_re_qa\r\n> \r\n> Can you create another branch and another PR please ?\r\n\r\nSure I will do that. Thank you." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1349/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1349", "html_url": "https://github.com/huggingface/datasets/pull/1349", "diff_url": "https://github.com/huggingface/datasets/pull/1349.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1349.patch", "merged_at": null }

{ "login": "dadelani", "id": 23586676, "node_id": "MDQ6VXNlcjIzNTg2Njc2", "avatar_url": "https://avatars.githubusercontent.com/u/23586676?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dadelani", "html_url": "https://github.com/dadelani", "followers_url": "https://api.github.com/users/dadelani/followers", "following_url": "https://api.github.com/users/dadelani/following{/other_user}", "gists_url": "https://api.github.com/users/dadelani/gists{/gist_id}", "starred_url": "https://api.github.com/users/dadelani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dadelani/subscriptions", "organizations_url": "https://api.github.com/users/dadelani/orgs", "repos_url": "https://api.github.com/users/dadelani/repos", "events_url": "https://api.github.com/users/dadelani/events{/privacy}", "received_events_url": "https://api.github.com/users/dadelani/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thank you. Okay, other pull requests only have one dataset", "The `RemoteDatasetTest` error in the CI is just a connection error, we can ignore it", "merging since the CI is fixed on master", "Thank you very much" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1348/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1348", "html_url": "https://github.com/huggingface/datasets/pull/1348", "diff_url": "https://github.com/huggingface/datasets/pull/1348.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1348.patch", "merged_at": 1607609383000 }

{ "login": "mariagrandury", "id": 57645283, "node_id": "MDQ6VXNlcjU3NjQ1Mjgz", "avatar_url": "https://avatars.githubusercontent.com/u/57645283?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mariagrandury", "html_url": "https://github.com/mariagrandury", "followers_url": "https://api.github.com/users/mariagrandury/followers", "following_url": "https://api.github.com/users/mariagrandury/following{/other_user}", "gists_url": "https://api.github.com/users/mariagrandury/gists{/gist_id}", "starred_url": "https://api.github.com/users/mariagrandury/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mariagrandury/subscriptions", "organizations_url": "https://api.github.com/users/mariagrandury/orgs", "repos_url": "https://api.github.com/users/mariagrandury/repos", "events_url": "https://api.github.com/users/mariagrandury/events{/privacy}", "received_events_url": "https://api.github.com/users/mariagrandury/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Thank you for your feedback! I've reduced the dummy data size to 2KB.\r\n\r\nI had to rebase to fix `RemoteDatasetTest` fails, sorry about the 80 commits. \r\nI could create a new clean PR if you prefer.", "I have seen that in similar cases you have suggested to other contributors to create another branch and another PR, so I will do that.", "Yes thank you !", "The new PR is #1476 :)" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1347/reactions", "total_count": 2, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 2, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1347", "html_url": "https://github.com/huggingface/datasets/pull/1347", "diff_url": "https://github.com/huggingface/datasets/pull/1347.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1347.patch", "merged_at": null }

{ "login": "albertvillanova", "id": 8515462, "node_id": "MDQ6VXNlcjg1MTU0NjI=", "avatar_url": "https://avatars.githubusercontent.com/u/8515462?v=4", "gravatar_id": "", "url": "https://api.github.com/users/albertvillanova", "html_url": "https://github.com/albertvillanova", "followers_url": "https://api.github.com/users/albertvillanova/followers", "following_url": "https://api.github.com/users/albertvillanova/following{/other_user}", "gists_url": "https://api.github.com/users/albertvillanova/gists{/gist_id}", "starred_url": "https://api.github.com/users/albertvillanova/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/albertvillanova/subscriptions", "organizations_url": "https://api.github.com/users/albertvillanova/orgs", "repos_url": "https://api.github.com/users/albertvillanova/repos", "events_url": "https://api.github.com/users/albertvillanova/events{/privacy}", "received_events_url": "https://api.github.com/users/albertvillanova/received_events", "type": "User", "site_admin": false }

[]

[]

[ "There' still an issue with the dummy data, let me take a look" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1346/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1346", "html_url": "https://github.com/huggingface/datasets/pull/1346", "diff_url": "https://github.com/huggingface/datasets/pull/1346.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1346.patch", "merged_at": 1608051728000 }

{ "login": "rsanjaykamath", "id": 18527321, "node_id": "MDQ6VXNlcjE4NTI3MzIx", "avatar_url": "https://avatars.githubusercontent.com/u/18527321?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rsanjaykamath", "html_url": "https://github.com/rsanjaykamath", "followers_url": "https://api.github.com/users/rsanjaykamath/followers", "following_url": "https://api.github.com/users/rsanjaykamath/following{/other_user}", "gists_url": "https://api.github.com/users/rsanjaykamath/gists{/gist_id}", "starred_url": "https://api.github.com/users/rsanjaykamath/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rsanjaykamath/subscriptions", "organizations_url": "https://api.github.com/users/rsanjaykamath/orgs", "repos_url": "https://api.github.com/users/rsanjaykamath/repos", "events_url": "https://api.github.com/users/rsanjaykamath/events{/privacy}", "received_events_url": "https://api.github.com/users/rsanjaykamath/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1345/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1345", "html_url": "https://github.com/huggingface/datasets/pull/1345", "diff_url": "https://github.com/huggingface/datasets/pull/1345.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1345.patch", "merged_at": null }

{ "login": "dadelani", "id": 23586676, "node_id": "MDQ6VXNlcjIzNTg2Njc2", "avatar_url": "https://avatars.githubusercontent.com/u/23586676?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dadelani", "html_url": "https://github.com/dadelani", "followers_url": "https://api.github.com/users/dadelani/followers", "following_url": "https://api.github.com/users/dadelani/following{/other_user}", "gists_url": "https://api.github.com/users/dadelani/gists{/gist_id}", "starred_url": "https://api.github.com/users/dadelani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dadelani/subscriptions", "organizations_url": "https://api.github.com/users/dadelani/orgs", "repos_url": "https://api.github.com/users/dadelani/repos", "events_url": "https://api.github.com/users/dadelani/events{/privacy}", "received_events_url": "https://api.github.com/users/dadelani/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1344/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1344", "html_url": "https://github.com/huggingface/datasets/pull/1344", "diff_url": "https://github.com/huggingface/datasets/pull/1344.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1344.patch", "merged_at": null }

{ "login": "j-chim", "id": 22435209, "node_id": "MDQ6VXNlcjIyNDM1MjA5", "avatar_url": "https://avatars.githubusercontent.com/u/22435209?v=4", "gravatar_id": "", "url": "https://api.github.com/users/j-chim", "html_url": "https://github.com/j-chim", "followers_url": "https://api.github.com/users/j-chim/followers", "following_url": "https://api.github.com/users/j-chim/following{/other_user}", "gists_url": "https://api.github.com/users/j-chim/gists{/gist_id}", "starred_url": "https://api.github.com/users/j-chim/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/j-chim/subscriptions", "organizations_url": "https://api.github.com/users/j-chim/orgs", "repos_url": "https://api.github.com/users/j-chim/repos", "events_url": "https://api.github.com/users/j-chim/events{/privacy}", "received_events_url": "https://api.github.com/users/j-chim/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1343/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1343", "html_url": "https://github.com/huggingface/datasets/pull/1343", "diff_url": "https://github.com/huggingface/datasets/pull/1343.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1343.patch", "merged_at": 1607938828000 }

{ "login": "julien-c", "id": 326577, "node_id": "MDQ6VXNlcjMyNjU3Nw==", "avatar_url": "https://avatars.githubusercontent.com/u/326577?v=4", "gravatar_id": "", "url": "https://api.github.com/users/julien-c", "html_url": "https://github.com/julien-c", "followers_url": "https://api.github.com/users/julien-c/followers", "following_url": "https://api.github.com/users/julien-c/following{/other_user}", "gists_url": "https://api.github.com/users/julien-c/gists{/gist_id}", "starred_url": "https://api.github.com/users/julien-c/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/julien-c/subscriptions", "organizations_url": "https://api.github.com/users/julien-c/orgs", "repos_url": "https://api.github.com/users/julien-c/repos", "events_url": "https://api.github.com/users/julien-c/events{/privacy}", "received_events_url": "https://api.github.com/users/julien-c/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1342/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1342", "html_url": "https://github.com/huggingface/datasets/pull/1342", "diff_url": "https://github.com/huggingface/datasets/pull/1342.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1342.patch", "merged_at": 1607528246000 }

{ "login": "yjernite", "id": 10469459, "node_id": "MDQ6VXNlcjEwNDY5NDU5", "avatar_url": "https://avatars.githubusercontent.com/u/10469459?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yjernite", "html_url": "https://github.com/yjernite", "followers_url": "https://api.github.com/users/yjernite/followers", "following_url": "https://api.github.com/users/yjernite/following{/other_user}", "gists_url": "https://api.github.com/users/yjernite/gists{/gist_id}", "starred_url": "https://api.github.com/users/yjernite/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yjernite/subscriptions", "organizations_url": "https://api.github.com/users/yjernite/orgs", "repos_url": "https://api.github.com/users/yjernite/repos", "events_url": "https://api.github.com/users/yjernite/events{/privacy}", "received_events_url": "https://api.github.com/users/yjernite/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1341/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1341", "html_url": "https://github.com/huggingface/datasets/pull/1341", "diff_url": "https://github.com/huggingface/datasets/pull/1341.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1341.patch", "merged_at": 1607463371000 }

{ "login": "lewtun", "id": 26859204, "node_id": "MDQ6VXNlcjI2ODU5MjA0", "avatar_url": "https://avatars.githubusercontent.com/u/26859204?v=4", "gravatar_id": "", "url": "https://api.github.com/users/lewtun", "html_url": "https://github.com/lewtun", "followers_url": "https://api.github.com/users/lewtun/followers", "following_url": "https://api.github.com/users/lewtun/following{/other_user}", "gists_url": "https://api.github.com/users/lewtun/gists{/gist_id}", "starred_url": "https://api.github.com/users/lewtun/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/lewtun/subscriptions", "organizations_url": "https://api.github.com/users/lewtun/orgs", "repos_url": "https://api.github.com/users/lewtun/repos", "events_url": "https://api.github.com/users/lewtun/events{/privacy}", "received_events_url": "https://api.github.com/users/lewtun/received_events", "type": "User", "site_admin": false }

[]

[]

[ "I've added the changes / fixes - ready for a second pass :)" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1340/reactions", "total_count": 8, "+1": 0, "-1": 0, "laugh": 4, "hooray": 3, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1340", "html_url": "https://github.com/huggingface/datasets/pull/1340", "diff_url": "https://github.com/huggingface/datasets/pull/1340.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1340.patch", "merged_at": 1607942161000 }

{ "login": "czabo", "id": 75574105, "node_id": "MDQ6VXNlcjc1NTc0MTA1", "avatar_url": "https://avatars.githubusercontent.com/u/75574105?v=4", "gravatar_id": "", "url": "https://api.github.com/users/czabo", "html_url": "https://github.com/czabo", "followers_url": "https://api.github.com/users/czabo/followers", "following_url": "https://api.github.com/users/czabo/following{/other_user}", "gists_url": "https://api.github.com/users/czabo/gists{/gist_id}", "starred_url": "https://api.github.com/users/czabo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/czabo/subscriptions", "organizations_url": "https://api.github.com/users/czabo/orgs", "repos_url": "https://api.github.com/users/czabo/repos", "events_url": "https://api.github.com/users/czabo/events{/privacy}", "received_events_url": "https://api.github.com/users/czabo/received_events", "type": "User", "site_admin": false }

[]

[]

[ "> Nice thanks !\r\n> \r\n> Can you rename the dataset folder and the dataset script name `hate_speech18` instead of `hate_speech_18` to follow the snake case convention we're using ?\r\n> \r\n> Also it looks like the dummy_data.zip file is quite big (almost 4MB).\r\n> Can you try to reduce its size ?\r\n> \r\n> To do so feel free to take a look inside it and remove all the unnecessary files or chunks of texts. The idea is to only keep a few examples\r\n\r\nDone, thanks! ", "Re-opened in https://github.com/huggingface/datasets/pull/1486" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1339/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1339", "html_url": "https://github.com/huggingface/datasets/pull/1339", "diff_url": "https://github.com/huggingface/datasets/pull/1339.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1339.patch", "merged_at": null }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq fixed" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1338/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1338", "html_url": "https://github.com/huggingface/datasets/pull/1338", "diff_url": "https://github.com/huggingface/datasets/pull/1338.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1338.patch", "merged_at": 1607940226000 }

{ "login": "mariagrandury", "id": 57645283, "node_id": "MDQ6VXNlcjU3NjQ1Mjgz", "avatar_url": "https://avatars.githubusercontent.com/u/57645283?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mariagrandury", "html_url": "https://github.com/mariagrandury", "followers_url": "https://api.github.com/users/mariagrandury/followers", "following_url": "https://api.github.com/users/mariagrandury/following{/other_user}", "gists_url": "https://api.github.com/users/mariagrandury/gists{/gist_id}", "starred_url": "https://api.github.com/users/mariagrandury/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mariagrandury/subscriptions", "organizations_url": "https://api.github.com/users/mariagrandury/orgs", "repos_url": "https://api.github.com/users/mariagrandury/repos", "events_url": "https://api.github.com/users/mariagrandury/events{/privacy}", "received_events_url": "https://api.github.com/users/mariagrandury/received_events", "type": "User", "site_admin": false }

[]

[]

[ "The tests failed because of ```RemoteDatasetTest``` so I tried ```git rebase``` and messed everything up. I've made a new clean PR (#1347)." ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1337/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1337", "html_url": "https://github.com/huggingface/datasets/pull/1337", "diff_url": "https://github.com/huggingface/datasets/pull/1337.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1337.patch", "merged_at": null }

{ "login": "michael-aloys", "id": 1858628, "node_id": "MDQ6VXNlcjE4NTg2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/1858628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/michael-aloys", "html_url": "https://github.com/michael-aloys", "followers_url": "https://api.github.com/users/michael-aloys/followers", "following_url": "https://api.github.com/users/michael-aloys/following{/other_user}", "gists_url": "https://api.github.com/users/michael-aloys/gists{/gist_id}", "starred_url": "https://api.github.com/users/michael-aloys/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/michael-aloys/subscriptions", "organizations_url": "https://api.github.com/users/michael-aloys/orgs", "repos_url": "https://api.github.com/users/michael-aloys/repos", "events_url": "https://api.github.com/users/michael-aloys/events{/privacy}", "received_events_url": "https://api.github.com/users/michael-aloys/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1336/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1336", "html_url": "https://github.com/huggingface/datasets/pull/1336", "diff_url": "https://github.com/huggingface/datasets/pull/1336.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1336.patch", "merged_at": 1607599661000 }

{ "login": "param087", "id": 26374564, "node_id": "MDQ6VXNlcjI2Mzc0NTY0", "avatar_url": "https://avatars.githubusercontent.com/u/26374564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/param087", "html_url": "https://github.com/param087", "followers_url": "https://api.github.com/users/param087/followers", "following_url": "https://api.github.com/users/param087/following{/other_user}", "gists_url": "https://api.github.com/users/param087/gists{/gist_id}", "starred_url": "https://api.github.com/users/param087/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/param087/subscriptions", "organizations_url": "https://api.github.com/users/param087/orgs", "repos_url": "https://api.github.com/users/param087/repos", "events_url": "https://api.github.com/users/param087/events{/privacy}", "received_events_url": "https://api.github.com/users/param087/received_events", "type": "User", "site_admin": false }

[]

[]

[ "merging since the Ci is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1335/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1335", "html_url": "https://github.com/huggingface/datasets/pull/1335", "diff_url": "https://github.com/huggingface/datasets/pull/1335.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1335.patch", "merged_at": 1607940055000 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1334/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1334", "html_url": "https://github.com/huggingface/datasets/pull/1334", "diff_url": "https://github.com/huggingface/datasets/pull/1334.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1334.patch", "merged_at": 1607598957000 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1333/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1333", "html_url": "https://github.com/huggingface/datasets/pull/1333", "diff_url": "https://github.com/huggingface/datasets/pull/1333.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1333.patch", "merged_at": 1607598883000 }

{ "login": "abhishekkrthakur", "id": 1183441, "node_id": "MDQ6VXNlcjExODM0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/1183441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/abhishekkrthakur", "html_url": "https://github.com/abhishekkrthakur", "followers_url": "https://api.github.com/users/abhishekkrthakur/followers", "following_url": "https://api.github.com/users/abhishekkrthakur/following{/other_user}", "gists_url": "https://api.github.com/users/abhishekkrthakur/gists{/gist_id}", "starred_url": "https://api.github.com/users/abhishekkrthakur/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/abhishekkrthakur/subscriptions", "organizations_url": "https://api.github.com/users/abhishekkrthakur/orgs", "repos_url": "https://api.github.com/users/abhishekkrthakur/repos", "events_url": "https://api.github.com/users/abhishekkrthakur/events{/privacy}", "received_events_url": "https://api.github.com/users/abhishekkrthakur/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1332/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1332", "html_url": "https://github.com/huggingface/datasets/pull/1332", "diff_url": "https://github.com/huggingface/datasets/pull/1332.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1332.patch", "merged_at": 1607598798000 }

{ "login": "michael-aloys", "id": 1858628, "node_id": "MDQ6VXNlcjE4NTg2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/1858628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/michael-aloys", "html_url": "https://github.com/michael-aloys", "followers_url": "https://api.github.com/users/michael-aloys/followers", "following_url": "https://api.github.com/users/michael-aloys/following{/other_user}", "gists_url": "https://api.github.com/users/michael-aloys/gists{/gist_id}", "starred_url": "https://api.github.com/users/michael-aloys/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/michael-aloys/subscriptions", "organizations_url": "https://api.github.com/users/michael-aloys/orgs", "repos_url": "https://api.github.com/users/michael-aloys/repos", "events_url": "https://api.github.com/users/michael-aloys/events{/privacy}", "received_events_url": "https://api.github.com/users/michael-aloys/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1331/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1331", "html_url": "https://github.com/huggingface/datasets/pull/1331", "diff_url": "https://github.com/huggingface/datasets/pull/1331.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1331.patch", "merged_at": 1607598593000 }

{ "login": "param087", "id": 26374564, "node_id": "MDQ6VXNlcjI2Mzc0NTY0", "avatar_url": "https://avatars.githubusercontent.com/u/26374564?v=4", "gravatar_id": "", "url": "https://api.github.com/users/param087", "html_url": "https://github.com/param087", "followers_url": "https://api.github.com/users/param087/followers", "following_url": "https://api.github.com/users/param087/following{/other_user}", "gists_url": "https://api.github.com/users/param087/gists{/gist_id}", "starred_url": "https://api.github.com/users/param087/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/param087/subscriptions", "organizations_url": "https://api.github.com/users/param087/orgs", "repos_url": "https://api.github.com/users/param087/repos", "events_url": "https://api.github.com/users/param087/events{/privacy}", "received_events_url": "https://api.github.com/users/param087/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Looks like this PR includes changes about many other files than the ones for un_ga\r\n\r\nCan you create another branch an another PR please ?", "@lhoestq, Thank you for suggestions. I have made the changes and raised the new PR https://github.com/huggingface/datasets/pull/1569. " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1330/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1330", "html_url": "https://github.com/huggingface/datasets/pull/1330", "diff_url": "https://github.com/huggingface/datasets/pull/1330.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1330.patch", "merged_at": null }

{ "login": "dadelani", "id": 23586676, "node_id": "MDQ6VXNlcjIzNTg2Njc2", "avatar_url": "https://avatars.githubusercontent.com/u/23586676?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dadelani", "html_url": "https://github.com/dadelani", "followers_url": "https://api.github.com/users/dadelani/followers", "following_url": "https://api.github.com/users/dadelani/following{/other_user}", "gists_url": "https://api.github.com/users/dadelani/gists{/gist_id}", "starred_url": "https://api.github.com/users/dadelani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dadelani/subscriptions", "organizations_url": "https://api.github.com/users/dadelani/orgs", "repos_url": "https://api.github.com/users/dadelani/repos", "events_url": "https://api.github.com/users/dadelani/events{/privacy}", "received_events_url": "https://api.github.com/users/dadelani/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1329/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1329", "html_url": "https://github.com/huggingface/datasets/pull/1329", "diff_url": "https://github.com/huggingface/datasets/pull/1329.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1329.patch", "merged_at": null }

{ "login": "jcblaisecruz02", "id": 24757547, "node_id": "MDQ6VXNlcjI0NzU3NTQ3", "avatar_url": "https://avatars.githubusercontent.com/u/24757547?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jcblaisecruz02", "html_url": "https://github.com/jcblaisecruz02", "followers_url": "https://api.github.com/users/jcblaisecruz02/followers", "following_url": "https://api.github.com/users/jcblaisecruz02/following{/other_user}", "gists_url": "https://api.github.com/users/jcblaisecruz02/gists{/gist_id}", "starred_url": "https://api.github.com/users/jcblaisecruz02/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jcblaisecruz02/subscriptions", "organizations_url": "https://api.github.com/users/jcblaisecruz02/orgs", "repos_url": "https://api.github.com/users/jcblaisecruz02/repos", "events_url": "https://api.github.com/users/jcblaisecruz02/events{/privacy}", "received_events_url": "https://api.github.com/users/jcblaisecruz02/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1328/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1328", "html_url": "https://github.com/huggingface/datasets/pull/1328", "diff_url": "https://github.com/huggingface/datasets/pull/1328.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1328.patch", "merged_at": 1607598274000 }

{ "login": "manandey", "id": 6687858, "node_id": "MDQ6VXNlcjY2ODc4NTg=", "avatar_url": "https://avatars.githubusercontent.com/u/6687858?v=4", "gravatar_id": "", "url": "https://api.github.com/users/manandey", "html_url": "https://github.com/manandey", "followers_url": "https://api.github.com/users/manandey/followers", "following_url": "https://api.github.com/users/manandey/following{/other_user}", "gists_url": "https://api.github.com/users/manandey/gists{/gist_id}", "starred_url": "https://api.github.com/users/manandey/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/manandey/subscriptions", "organizations_url": "https://api.github.com/users/manandey/orgs", "repos_url": "https://api.github.com/users/manandey/repos", "events_url": "https://api.github.com/users/manandey/events{/privacy}", "received_events_url": "https://api.github.com/users/manandey/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1327/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1327", "html_url": "https://github.com/huggingface/datasets/pull/1327", "diff_url": "https://github.com/huggingface/datasets/pull/1327.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1327.patch", "merged_at": 1607451486000 }

{ "login": "spatil6", "id": 6419011, "node_id": "MDQ6VXNlcjY0MTkwMTE=", "avatar_url": "https://avatars.githubusercontent.com/u/6419011?v=4", "gravatar_id": "", "url": "https://api.github.com/users/spatil6", "html_url": "https://github.com/spatil6", "followers_url": "https://api.github.com/users/spatil6/followers", "following_url": "https://api.github.com/users/spatil6/following{/other_user}", "gists_url": "https://api.github.com/users/spatil6/gists{/gist_id}", "starred_url": "https://api.github.com/users/spatil6/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/spatil6/subscriptions", "organizations_url": "https://api.github.com/users/spatil6/orgs", "repos_url": "https://api.github.com/users/spatil6/repos", "events_url": "https://api.github.com/users/spatil6/events{/privacy}", "received_events_url": "https://api.github.com/users/spatil6/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1326/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1326", "html_url": "https://github.com/huggingface/datasets/pull/1326", "diff_url": "https://github.com/huggingface/datasets/pull/1326.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1326.patch", "merged_at": 1607599517000 }

{ "login": "saradhix", "id": 1351362, "node_id": "MDQ6VXNlcjEzNTEzNjI=", "avatar_url": "https://avatars.githubusercontent.com/u/1351362?v=4", "gravatar_id": "", "url": "https://api.github.com/users/saradhix", "html_url": "https://github.com/saradhix", "followers_url": "https://api.github.com/users/saradhix/followers", "following_url": "https://api.github.com/users/saradhix/following{/other_user}", "gists_url": "https://api.github.com/users/saradhix/gists{/gist_id}", "starred_url": "https://api.github.com/users/saradhix/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/saradhix/subscriptions", "organizations_url": "https://api.github.com/users/saradhix/orgs", "repos_url": "https://api.github.com/users/saradhix/repos", "events_url": "https://api.github.com/users/saradhix/events{/privacy}", "received_events_url": "https://api.github.com/users/saradhix/received_events", "type": "User", "site_admin": false }

[]

[]

[ "Updated the commit with the generated yaml tags", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1325/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1325", "html_url": "https://github.com/huggingface/datasets/pull/1325", "diff_url": "https://github.com/huggingface/datasets/pull/1325.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1325.patch", "merged_at": 1608227949000 }

{ "login": "pietrolesci", "id": 61748653, "node_id": "MDQ6VXNlcjYxNzQ4NjUz", "avatar_url": "https://avatars.githubusercontent.com/u/61748653?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pietrolesci", "html_url": "https://github.com/pietrolesci", "followers_url": "https://api.github.com/users/pietrolesci/followers", "following_url": "https://api.github.com/users/pietrolesci/following{/other_user}", "gists_url": "https://api.github.com/users/pietrolesci/gists{/gist_id}", "starred_url": "https://api.github.com/users/pietrolesci/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pietrolesci/subscriptions", "organizations_url": "https://api.github.com/users/pietrolesci/orgs", "repos_url": "https://api.github.com/users/pietrolesci/repos", "events_url": "https://api.github.com/users/pietrolesci/events{/privacy}", "received_events_url": "https://api.github.com/users/pietrolesci/received_events", "type": "User", "site_admin": false }

[ { "id": 2067376369, "node_id": "MDU6TGFiZWwyMDY3Mzc2MzY5", "url": "https://api.github.com/repos/huggingface/datasets/labels/dataset%20request", "name": "dataset request", "color": "e99695", "default": false, "description": "Requesting to add a new dataset" } ]

[]

[ "Hello @pietrolesci , I am not sure to understand what you are trying to do here.\r\n\r\nIf you're looking for ways to save a dataset on disk, you can you the `save_to_disk` method:\r\n```python\r\n>>> import datasets\r\n>>> loaded_dataset = datasets.load(\"dataset_name\")\r\n>>> loaded_dataset.save_to_disk(\"/path/on/your/disk\")\r\n```\r\n\r\nThe saved dataset can later be retrieved using:\r\n```python\r\n>>> loaded_dataset = datasets.Dataset.load_from_disk(\"/path/on/your/disk\")\r\n```\r\n\r\nAlso, I'd recommend posting your question directly in the issue section of the [elasticsearch repo](https://github.com/elastic/elasticsearch)", "Hi @SBrandeis,\n\nThanks a lot for picking up my request. \n\nMaybe I can clarify my use-case with a bit of context. Say I have the IMDb dataset. I create an ES index on it. Now I can save and reload the dataset from disk normally. Once I reload the dataset, it is easy to retrieve the ES index on my machine. I was wondering: is there a way I can share the (now) indexed version of the IMDb dataset with my colleagues without requiring them to re-index it?\n\nThanks a lot in advance for your consideration.\n\nBest,\n\nPietro", "Thanks for the clarification.\r\n\r\nI am not familiar with ElasticSearch, but if I understand well you're trying to migrate your data along with the ES index.\r\nMy advice would be to check out ES documentation, for instance, this might help you: https://www.elastic.co/guide/en/cloud/current/ec-migrate-data.html\r\n\r\nLet me know if it helps" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1324/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "login": "vblagoje", "id": 458335, "node_id": "MDQ6VXNlcjQ1ODMzNQ==", "avatar_url": "https://avatars.githubusercontent.com/u/458335?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vblagoje", "html_url": "https://github.com/vblagoje", "followers_url": "https://api.github.com/users/vblagoje/followers", "following_url": "https://api.github.com/users/vblagoje/following{/other_user}", "gists_url": "https://api.github.com/users/vblagoje/gists{/gist_id}", "starred_url": "https://api.github.com/users/vblagoje/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vblagoje/subscriptions", "organizations_url": "https://api.github.com/users/vblagoje/orgs", "repos_url": "https://api.github.com/users/vblagoje/repos", "events_url": "https://api.github.com/users/vblagoje/events{/privacy}", "received_events_url": "https://api.github.com/users/vblagoje/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@vblagoje nice work, please add the README.md file and it would be ready", "@lhoestq @tanmoyio @yjernite please have a look at the dataset card. Don't forget that the dataset is still hosted on my private gs bucket and should eventually be moved to the HF bucket", "I will move the files soon and ping you when it's done and with the new URLs :) ", "Hi !\r\n\r\nI just moved the file to a HF bucket. It's available at https://storage.googleapis.com/huggingface-nlp/datasets/cc_news/cc_news.tar.gz\r\n\r\nSorry for the delay ^^'", "@lhoestq no worries, updated PR with the new URL and rebased to master\r\n" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1323/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1323", "html_url": "https://github.com/huggingface/datasets/pull/1323", "diff_url": "https://github.com/huggingface/datasets/pull/1323.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1323.patch", "merged_at": 1612198549000 }

{ "login": "yasirabd", "id": 6518504, "node_id": "MDQ6VXNlcjY1MTg1MDQ=", "avatar_url": "https://avatars.githubusercontent.com/u/6518504?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yasirabd", "html_url": "https://github.com/yasirabd", "followers_url": "https://api.github.com/users/yasirabd/followers", "following_url": "https://api.github.com/users/yasirabd/following{/other_user}", "gists_url": "https://api.github.com/users/yasirabd/gists{/gist_id}", "starred_url": "https://api.github.com/users/yasirabd/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yasirabd/subscriptions", "organizations_url": "https://api.github.com/users/yasirabd/orgs", "repos_url": "https://api.github.com/users/yasirabd/repos", "events_url": "https://api.github.com/users/yasirabd/events{/privacy}", "received_events_url": "https://api.github.com/users/yasirabd/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1322/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1322", "html_url": "https://github.com/huggingface/datasets/pull/1322", "diff_url": "https://github.com/huggingface/datasets/pull/1322.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1322.patch", "merged_at": null }

{ "login": "skyprince999", "id": 9033954, "node_id": "MDQ6VXNlcjkwMzM5NTQ=", "avatar_url": "https://avatars.githubusercontent.com/u/9033954?v=4", "gravatar_id": "", "url": "https://api.github.com/users/skyprince999", "html_url": "https://github.com/skyprince999", "followers_url": "https://api.github.com/users/skyprince999/followers", "following_url": "https://api.github.com/users/skyprince999/following{/other_user}", "gists_url": "https://api.github.com/users/skyprince999/gists{/gist_id}", "starred_url": "https://api.github.com/users/skyprince999/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/skyprince999/subscriptions", "organizations_url": "https://api.github.com/users/skyprince999/orgs", "repos_url": "https://api.github.com/users/skyprince999/repos", "events_url": "https://api.github.com/users/skyprince999/events{/privacy}", "received_events_url": "https://api.github.com/users/skyprince999/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq \r\nUpdated the `dummy_data.zip `(<10kb)I had to reduce it to just a few samples. \r\nTrain-Test-Dev (20-5-5 samples) \r\n\r\nBut the push also added changes from other PRs (probably because of a rebase!) So the files changed tab shows 466 files were changed! \r\n", "Thanks ! The dummy data are all good now :) \r\n\r\nLooks like this PR includes changes to many other files than the ones for dutch_social now.\r\n\r\nCan you create another branch and another PR please ?", "> \r\n> Can you create another branch and another PR please ?\r\n@lhoestq \r\n\r\nI did a rebase. Now it doesn't include the other files. Does that help? \r\n\r\n", "Yes thanks !" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1321/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1321", "html_url": "https://github.com/huggingface/datasets/pull/1321", "diff_url": "https://github.com/huggingface/datasets/pull/1321.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1321.patch", "merged_at": 1608113657000 }

{ "login": "jcblaisecruz02", "id": 24757547, "node_id": "MDQ6VXNlcjI0NzU3NTQ3", "avatar_url": "https://avatars.githubusercontent.com/u/24757547?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jcblaisecruz02", "html_url": "https://github.com/jcblaisecruz02", "followers_url": "https://api.github.com/users/jcblaisecruz02/followers", "following_url": "https://api.github.com/users/jcblaisecruz02/following{/other_user}", "gists_url": "https://api.github.com/users/jcblaisecruz02/gists{/gist_id}", "starred_url": "https://api.github.com/users/jcblaisecruz02/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jcblaisecruz02/subscriptions", "organizations_url": "https://api.github.com/users/jcblaisecruz02/orgs", "repos_url": "https://api.github.com/users/jcblaisecruz02/repos", "events_url": "https://api.github.com/users/jcblaisecruz02/events{/privacy}", "received_events_url": "https://api.github.com/users/jcblaisecruz02/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1320/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1320", "html_url": "https://github.com/huggingface/datasets/pull/1320", "diff_url": "https://github.com/huggingface/datasets/pull/1320.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1320.patch", "merged_at": 1607599492000 }

{ "login": "Shubhambindal2017", "id": 31540058, "node_id": "MDQ6VXNlcjMxNTQwMDU4", "avatar_url": "https://avatars.githubusercontent.com/u/31540058?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Shubhambindal2017", "html_url": "https://github.com/Shubhambindal2017", "followers_url": "https://api.github.com/users/Shubhambindal2017/followers", "following_url": "https://api.github.com/users/Shubhambindal2017/following{/other_user}", "gists_url": "https://api.github.com/users/Shubhambindal2017/gists{/gist_id}", "starred_url": "https://api.github.com/users/Shubhambindal2017/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Shubhambindal2017/subscriptions", "organizations_url": "https://api.github.com/users/Shubhambindal2017/orgs", "repos_url": "https://api.github.com/users/Shubhambindal2017/repos", "events_url": "https://api.github.com/users/Shubhambindal2017/events{/privacy}", "received_events_url": "https://api.github.com/users/Shubhambindal2017/received_events", "type": "User", "site_admin": false }

[]

[]

[ "@lhoestq Not sure what happened, I just changed the py file but it is showing some TensorFlow error now.", "You can ignore it.\r\nIt's caused by the Tensorflow update that happened 30min ago. They added breaking changes.\r\nI'm working on a fix on the master branch right now\r\n", "oh okay, btw I have made the required change for reading the CSV, I think it should be fine now, please take a look at it when you have some time.", "merging since the CI is fixed on master" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1319/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1319", "html_url": "https://github.com/huggingface/datasets/pull/1319", "diff_url": "https://github.com/huggingface/datasets/pull/1319.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1319.patch", "merged_at": 1607980832000 }

{ "login": "iamollas", "id": 22838900, "node_id": "MDQ6VXNlcjIyODM4OTAw", "avatar_url": "https://avatars.githubusercontent.com/u/22838900?v=4", "gravatar_id": "", "url": "https://api.github.com/users/iamollas", "html_url": "https://github.com/iamollas", "followers_url": "https://api.github.com/users/iamollas/followers", "following_url": "https://api.github.com/users/iamollas/following{/other_user}", "gists_url": "https://api.github.com/users/iamollas/gists{/gist_id}", "starred_url": "https://api.github.com/users/iamollas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/iamollas/subscriptions", "organizations_url": "https://api.github.com/users/iamollas/orgs", "repos_url": "https://api.github.com/users/iamollas/repos", "events_url": "https://api.github.com/users/iamollas/events{/privacy}", "received_events_url": "https://api.github.com/users/iamollas/received_events", "type": "User", "site_admin": false }

[]

[]

[ "> Nice thanks !\r\n> \r\n> I left a few comments\r\n> \r\n> Also it looks like this PR includes changes about other files than the ones for ethos\r\n> \r\n> Can you create another branch and another PR please ?\r\n\r\n@lhoestq Should I close this PR? The new one is the: #1453", "You can create another PR and close this one if you don't mind", "> You can create another PR and close this one if you don't mind\r\n\r\nPerfect! You should see the #1453 PR for the fixed version! Thanks" ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1318/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1318", "html_url": "https://github.com/huggingface/datasets/pull/1318", "diff_url": "https://github.com/huggingface/datasets/pull/1318.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1318.patch", "merged_at": null }

{ "login": "stevhliu", "id": 59462357, "node_id": "MDQ6VXNlcjU5NDYyMzU3", "avatar_url": "https://avatars.githubusercontent.com/u/59462357?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stevhliu", "html_url": "https://github.com/stevhliu", "followers_url": "https://api.github.com/users/stevhliu/followers", "following_url": "https://api.github.com/users/stevhliu/following{/other_user}", "gists_url": "https://api.github.com/users/stevhliu/gists{/gist_id}", "starred_url": "https://api.github.com/users/stevhliu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stevhliu/subscriptions", "organizations_url": "https://api.github.com/users/stevhliu/orgs", "repos_url": "https://api.github.com/users/stevhliu/repos", "events_url": "https://api.github.com/users/stevhliu/events{/privacy}", "received_events_url": "https://api.github.com/users/stevhliu/received_events", "type": "User", "site_admin": false }

[]

[]

[ "You can just create another branch from master on your fork and create another PR:\r\n\r\nfirst update your master branch\r\n```\r\ngit checkout master\r\ngit fetch upstream\r\ngit rebase upstream/master\r\ngit push\r\n```\r\n\r\nthen create a new branch\r\n```\r\ngit checkout -b my-new-branch-name\r\n```\r\n\r\nThen you can add, commit and push the gnad10 files and open a new PR", "closing in favor of #1572 " ]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1317/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1317", "html_url": "https://github.com/huggingface/datasets/pull/1317", "diff_url": "https://github.com/huggingface/datasets/pull/1317.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1317.patch", "merged_at": null }

{ "login": "benjaminvdb", "id": 8875786, "node_id": "MDQ6VXNlcjg4NzU3ODY=", "avatar_url": "https://avatars.githubusercontent.com/u/8875786?v=4", "gravatar_id": "", "url": "https://api.github.com/users/benjaminvdb", "html_url": "https://github.com/benjaminvdb", "followers_url": "https://api.github.com/users/benjaminvdb/followers", "following_url": "https://api.github.com/users/benjaminvdb/following{/other_user}", "gists_url": "https://api.github.com/users/benjaminvdb/gists{/gist_id}", "starred_url": "https://api.github.com/users/benjaminvdb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/benjaminvdb/subscriptions", "organizations_url": "https://api.github.com/users/benjaminvdb/orgs", "repos_url": "https://api.github.com/users/benjaminvdb/repos", "events_url": "https://api.github.com/users/benjaminvdb/events{/privacy}", "received_events_url": "https://api.github.com/users/benjaminvdb/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1316/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1316", "html_url": "https://github.com/huggingface/datasets/pull/1316", "diff_url": "https://github.com/huggingface/datasets/pull/1316.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1316.patch", "merged_at": 1607595120000 }

{ "login": "hfawaz", "id": 29229602, "node_id": "MDQ6VXNlcjI5MjI5NjAy", "avatar_url": "https://avatars.githubusercontent.com/u/29229602?v=4", "gravatar_id": "", "url": "https://api.github.com/users/hfawaz", "html_url": "https://github.com/hfawaz", "followers_url": "https://api.github.com/users/hfawaz/followers", "following_url": "https://api.github.com/users/hfawaz/following{/other_user}", "gists_url": "https://api.github.com/users/hfawaz/gists{/gist_id}", "starred_url": "https://api.github.com/users/hfawaz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hfawaz/subscriptions", "organizations_url": "https://api.github.com/users/hfawaz/orgs", "repos_url": "https://api.github.com/users/hfawaz/repos", "events_url": "https://api.github.com/users/hfawaz/events{/privacy}", "received_events_url": "https://api.github.com/users/hfawaz/received_events", "type": "User", "site_admin": false }

[]

[]

[]

{ "url": "https://api.github.com/repos/huggingface/datasets/issues/1315/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }

{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/1315", "html_url": "https://github.com/huggingface/datasets/pull/1315", "diff_url": "https://github.com/huggingface/datasets/pull/1315.diff", "patch_url": "https://github.com/huggingface/datasets/pull/1315.patch", "merged_at": 1607529348000 }

{ "login": "bduvenhage", "id": 8405335, "node_id": "MDQ6VXNlcjg0MDUzMzU=", "avatar_url": "https://avatars.githubusercontent.com/u/8405335?v=4", "gravatar_id": "", "url": "https://api.github.com/users/bduvenhage", "html_url": "https://github.com/bduvenhage", "followers_url": "https://api.github.com/users/bduvenhage/followers", "following_url": "https://api.github.com/users/bduvenhage/following{/other_user}", "gists_url": "https://api.github.com/users/bduvenhage/gists{/gist_id}", "starred_url": "https://api.github.com/users/bduvenhage/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/bduvenhage/subscriptions", "organizations_url": "https://api.github.com/users/bduvenhage/orgs", "repos_url": "https://api.github.com/users/bduvenhage/repos", "events_url": "https://api.github.com/users/bduvenhage/events{/privacy}", "received_events_url": "https://api.github.com/users/bduvenhage/received_events", "type": "User", "site_admin": false }

[]

[]

[ "It is not clear how to automatically add the dummy data if the source data is a more complex json format. Should I manually take a fraction of the source data and include it as dummy data?\r\n", "Added a fraction of the real data as dummy data.", "merging since the CI is fixed on master" ]