submission formatting and error catching

src/submission/submit.py

@@ -51,25 +51,32 @@ def get_demo_example_submissions(competition_type: str) -> list[str]:
     return [f"umdclip/{os.path.basename(f).removesuffix('.yaml')}" for f in glob.glob(f"{examples_dir}/*.yaml")]
 
 
-def get_user_submissions_today(username: str, competition_type: str) -> list[Submission]:
+def get_user_submissions_by_date(
+    username: str, competition_type: str, year: int, month: int, day: int
+) -> dict[str, list[Submission]]:
     """Get all submissions for a user for a given competition type."""
-    today = datetime.now(timezone.utc).strftime("%Y%m%d")
-    if username is None:
-        raise gr.Error("Authentication required. Please log in to view your submissions.")
+    date_str = datetime(year, month, day).strftime("%Y%m%d")
     out_dir = f"{EVAL_REQUESTS_PATH}/{username}"
-    submissions = []
     if not os.path.exists(out_dir):
-        return submissions
+        return {}
+    submissions = []
     for file in os.listdir(out_dir):
-        if not file.startswith(f"{competition_type}_"):
-            continue
-        with open(os.path.join(out_dir, file), "r") as f:
-            submission = Submission.from_dict(json.load(f))
-            if submission.created_at.startswith(today):
+        if file.startswith(f"{competition_type}_") and date_str in file:
+            try:
+                submission = Submission.from_dict(json.load(open(os.path.join(out_dir, file))))
                 submissions.append(submission)
+            except Exception as e:
+                logger.exception(e)
+                logger.warning(f"Error loading submission {file}: {e}")
     return submissions
 
 
+def get_user_submissions_today(username: str, competition_type: str) -> list[Submission]:
+    """Get all submissions for a user for a given competition type."""
+    today = datetime.now(timezone.utc)
+    return get_user_submissions_by_date(username, competition_type, today.year, today.month, today.day)
+
+
 def get_time_until_next_submission(tz: timezone = timezone.utc) -> str:
     next_day_00 = datetime.now(tz) + timedelta(days=1)
     next_day_00 = next_day_00.replace(hour=0, minute=0, second=0, microsecond=0)
@@ -149,9 +156,7 @@ def submit_model(
         )
 
     if f"{username}/{model_name}" in get_user_submission_names(competition_type, profile):
-        return styled_error(
-            f"Submission {model_name} already exists. Please use a different name for your submission."
-        )
+        return styled_error(f"'{model_name}' already exists. Please use a different name for your submission.")
 
     try:
         submission = create_submission(
@@ -178,9 +183,8 @@ def submit_model(
         )
 
         return styled_message(
-            f"Successfully submitted tossup model!\n"
-            f"Submission ID: {submission.id}\n"
-            f"Name: {username}/{model_name}\n"
+            f"Successfully submitted tossup model!<br>"
+            f"Submission name: {username}/{model_name}<br>"
             f"Please wait for up to an hour for the model to show in the PENDING list."
         )