Fix for dup sub

src/submission/submit.py

@@ -17,15 +17,14 @@ from shared.workflows.structs import TossupWorkflow, Workflow
 from submission.structs import CompetitionType, Submission, SubmissionStatus, SubmissionType
 
 
-def make_unique_submission_key(submission: dict) -> str:
-    stype = submission["submission_type"]
+def make_unique_submission_key(submission: Submission) -> str:
+    stype = submission.submission_type
     if stype == "simple_workflow":
-        workflow = submission["workflow"]
-        workflow["steps"].sort(key=lambda x: x["id"])
-        wstr = json.dumps(workflow, sort_keys=True, ensure_ascii=False)
+        workflow = submission.workflow
+        wstr = json.dumps(workflow.model_dump(), sort_keys=True, ensure_ascii=False)
         return f"workflow:{wstr}"
     elif stype == "hf_pipeline":
-        return f"hf:{submission['model_name']}"
+        return f"hf:{submission.model_name}"
     else:
         raise ValueError(f"Unsupported submission type {stype}")
 
@@ -213,17 +212,17 @@ def submit_agent(
     if len(get_user_submissions_today(username, competition_type)) >= DAILY_SUBMISSION_LIMIT_PER_USER:
         time_str = get_time_until_next_submission()
         return styled_error(
-            f"Daily submission limit of {DAILY_SUBMISSION_LIMIT_PER_USER} reached. Please try again in \n {time_str}."
+            f"‼️ Daily submission limit of {DAILY_SUBMISSION_LIMIT_PER_USER} reached. <br>⏳ Please try again in \n {time_str}."
         )
 
     if f"{username}/{model_name}" in get_user_submission_names(competition_type, profile):
         return styled_error(
-            f"Submission Error!<br>'{model_name}' already exists. Please use a different name for your submission."
+            f"⚠️ Submission Error!<br>Name '{username}/{model_name}' already exists. Please use a different name for your submission."
         )
 
     is_valid, error_msg = validate_model_name(model_name)
     if not is_valid:
-        return styled_error(f"Submission Error! Invalid model name '{model_name}'.<br>{error_msg}")
+        return styled_error(f"🙅🏻‍♂️ Submission Error! Invalid model name '{model_name}'.<br>{error_msg}")
 
     try:
         if submission_type == "simple_workflow":
@@ -247,13 +246,14 @@ def submit_agent(
         # Convert to dictionary format
         submission_dict = submission.to_dict()
 
-        user_submissions = [s.model_dump() for s in get_user_submissions(username, competition_type)]
-        unq_keys = {make_unique_submission_key(s): s["model_name"] for s in user_submissions}
-        submission_key = make_unique_submission_key(submission_dict)
+        user_submissions = get_user_submissions(username, competition_type)
+        unq_keys = {make_unique_submission_key(s): s for s in user_submissions}
+        submission_key = make_unique_submission_key(submission)
         if submission_key in unq_keys:
-            similar_model = unq_keys[submission_key]
+            sim_submission = unq_keys[submission_key]
             return styled_error(
-                f"Duplicate submission!<br> You submission is equivalent to your previous submission '{similar_model}'."
+                f"⚠️ Duplicate submission!<br> You submission is equivalent to your previous submission "
+                f"'{sim_submission.model_name}'."
             )
 
         # Create output directory path
@@ -275,7 +275,7 @@ def submit_agent(
         )
 
         return styled_message(
-            f"Successfully submitted {competition_type} {submission_type} model!<br>"
+            f"✅ Successfully submitted {competition_type} {submission_type} model!<br>"
             f"Submission name: {username}/{model_name}<br>"
             f"Please wait for up to one day for the model to show up on the leaderboard."
         )