Upload folder using huggingface_hub

improvisation_lab/application/app_factory.py

@@ -23,20 +23,20 @@ class PracticeAppFactory:
         """
         if app_type == "web":
             if practice_type == "piece":
-                service = PiecePracticeService(config)
-                return WebPiecePracticeApp(service, config)
+                piece_service = PiecePracticeService(config)
+                return WebPiecePracticeApp(piece_service, config)
             elif practice_type == "interval":
-                service = IntervalPracticeService(config)
-                return WebIntervalPracticeApp(service, config)
+                interval_service = IntervalPracticeService(config)
+                return WebIntervalPracticeApp(interval_service, config)
             else:
                 raise ValueError(f"Unknown practice type: {practice_type}")
         elif app_type == "console":
             if practice_type == "piece":
-                service = PiecePracticeService(config)
-                return ConsolePiecePracticeApp(service, config)
+                piece_service = PiecePracticeService(config)
+                return ConsolePiecePracticeApp(piece_service, config)
             elif practice_type == "interval":
-                service = IntervalPracticeService(config)
-                return ConsoleIntervalPracticeApp(service, config)
+                interval_service = IntervalPracticeService(config)
+                return ConsoleIntervalPracticeApp(interval_service, config)
             else:
                 raise ValueError(f"Unknown practice type: {practice_type}")
         else:

improvisation_lab/application/base_app.py

@@ -1,12 +1,11 @@
 """Base class for melody practice applications."""
 
 from abc import ABC, abstractmethod
-from typing import List, Optional
+from typing import Any, Optional
 
 import numpy as np
 
 from improvisation_lab.config import Config
-from improvisation_lab.domain.composition import PhraseData
 from improvisation_lab.service.base_practice_service import BasePracticeService
 
 
@@ -22,7 +21,7 @@ class BasePracticeApp(ABC):
         """
         self.service = service
         self.config = config
-        self.phrases: Optional[List[PhraseData]] = None
+        self.phrases: Optional[Any] = None
         self.current_phrase_idx: int = 0
         self.current_note_idx: int = 0
         self.is_running: bool = False

improvisation_lab/application/interval_practice/__init__.py

@@ -1,3 +1,5 @@
+"""Application layer for interval practice."""
+
 from improvisation_lab.application.interval_practice.console_interval_app import \
     ConsoleIntervalPracticeApp
 from improvisation_lab.application.interval_practice.web_interval_app import \

improvisation_lab/application/interval_practice/console_interval_app.py

@@ -31,10 +31,14 @@ class ConsoleIntervalPracticeApp(ConsoleBasePracticeApp):
         Returns:
             The current note to be processed.
         """
+        if self.phrases is None:
+            raise ValueError("Phrases are not initialized.")
         return self.phrases[self.current_phrase_idx][self.current_note_idx].value
 
     def _get_current_phrase(self) -> List[Notes]:
         """Return the current phrase to be processed."""
+        if self.phrases is None:
+            raise ValueError("Phrases are not initialized.")
         return self.phrases[self.current_phrase_idx]
 
     def _generate_melody(self) -> List[List[Notes]]:

improvisation_lab/presentation/interval_practice/__init__.py

@@ -1,3 +1,9 @@
+"""Presentation layer for interval practice.
+
+This package contains modules for handling the user interface
+and text management for interval practice applications.
+"""
+
 from improvisation_lab.presentation.interval_practice.console_interval_view import \
     ConsoleIntervalPracticeView
 from improvisation_lab.presentation.interval_practice.interval_view_text_manager import \

improvisation_lab/presentation/interval_practice/web_interval_view.py

@@ -1,3 +1,9 @@
+"""Web-based interval practice view.
+
+This module provides a web interface using Gradio for visualizing
+and interacting with interval practice sessions.
+"""
+
 from typing import Callable, Tuple
 
 import gradio as gr
@@ -15,7 +21,7 @@ class WebIntervalPracticeView(WebPracticeView):
         self,
         on_generate_melody: Callable[[str, str, int], Tuple[str, str, str]],
         on_end_practice: Callable[[], Tuple[str, str, str]],
-        on_audio_input: Callable[[int, np.ndarray], Tuple[str, str, str]],
+        on_audio_input: Callable[[Tuple[int, np.ndarray]], Tuple[str, str, str]],
         config: Config,
     ):
         """Initialize the UI with callback functions.

improvisation_lab/presentation/piece_practice/__init__.py

@@ -1,7 +1,7 @@
-"""Presentation layer for melody practice.
+"""Presentation layer for piece practice.
 
 This package contains modules for handling the user interface
-and text management for melody practice applications.
+and text management for piece practice applications.
 """
 
 from improvisation_lab.presentation.piece_practice.console_piece_view import \

improvisation_lab/presentation/piece_practice/web_piece_view.py

@@ -19,7 +19,7 @@ class WebPiecePracticeView(WebPracticeView):
         self,
         on_generate_melody: Callable[[], Tuple[str, str]],
         on_end_practice: Callable[[], Tuple[str, str]],
-        on_audio_input: Callable[[int, np.ndarray], Tuple[str, str]],
+        on_audio_input: Callable[[Tuple[int, np.ndarray]], Tuple[str, str]],
         song_name: str,
     ):
         """Initialize the UI with callback functions.

improvisation_lab/presentation/web_view.py

@@ -18,7 +18,7 @@ class WebPracticeView(ABC):
         self,
         on_generate_melody: Callable[..., Tuple[Any, ...]],
         on_end_practice: Callable[[], Tuple[Any, ...]],
-        on_audio_input: Callable[[int, np.ndarray], Tuple[Any, ...]],
+        on_audio_input: Callable[[Tuple[int, np.ndarray]], Tuple[Any, ...]],
     ):
         """Initialize the UI with callback functions.