alfraser commited on
Commit
53697b7
·
1 Parent(s): e64e48c

Added ability to include comments on the saved trace

Browse files
Files changed (1) hide show
  1. src/architectures.py +5 -3
src/architectures.py CHANGED
@@ -262,7 +262,7 @@ class Architecture:
262
  Architecture.save_repo.push_to_hub()
263
 
264
  def attempt_request_and_trace_save(self, request: ArchitectureRequest, trace: ArchitectureTrace,
265
- trace_tags: List[str] = None) -> None:
266
  """
267
  Attempt to save a request and trace pair to a json store on huggingface datasets
268
  Catch any errors and simply print as non-fatal to functional flow
@@ -270,6 +270,8 @@ class Architecture:
270
  try:
271
  if trace_tags is None:
272
  trace_tags = []
 
 
273
  save_dict = {
274
  'architecture': self.name,
275
  'request': request.as_dict(),
@@ -294,7 +296,7 @@ class Architecture:
294
  self.exception_text = exception_text
295
  self.no_response_text = no_response_text
296
 
297
- def __call__(self, request: ArchitectureRequest, trace_tags: List[str] = None) -> ArchitectureTrace:
298
  """
299
  The main entry point to call the pipeline. Passes the request through each pipeline step
300
  in sequence, allowing them to amend the request or early exit the processing. Also captures
@@ -319,7 +321,7 @@ class Architecture:
319
  trace.steps[-1].exception = err
320
  traceback.print_exc()
321
  break
322
- self.attempt_request_and_trace_save(request, trace, trace_tags)
323
  return trace
324
 
325
 
 
262
  Architecture.save_repo.push_to_hub()
263
 
264
  def attempt_request_and_trace_save(self, request: ArchitectureRequest, trace: ArchitectureTrace,
265
+ trace_tags: List[str] = None, trace_comment: str = None) -> None:
266
  """
267
  Attempt to save a request and trace pair to a json store on huggingface datasets
268
  Catch any errors and simply print as non-fatal to functional flow
 
270
  try:
271
  if trace_tags is None:
272
  trace_tags = []
273
+ if trace_comment is None:
274
+ trace_comment = ""
275
  save_dict = {
276
  'architecture': self.name,
277
  'request': request.as_dict(),
 
296
  self.exception_text = exception_text
297
  self.no_response_text = no_response_text
298
 
299
+ def __call__(self, request: ArchitectureRequest, trace_tags: List[str] = None, trace_comment: str = None) -> ArchitectureTrace:
300
  """
301
  The main entry point to call the pipeline. Passes the request through each pipeline step
302
  in sequence, allowing them to amend the request or early exit the processing. Also captures
 
321
  trace.steps[-1].exception = err
322
  traceback.print_exc()
323
  break
324
+ self.attempt_request_and_trace_save(request, trace, trace_tags, trace_comment)
325
  return trace
326
 
327