Pull Request Number: 4264
Title: fix: missing react-types package added
Base Branch: canary
Head Branch: fix/react-types-system
Author: jrgarciadev
URL: https://github.com/nextui-org/nextui/pull/4264
State: MERGED
Created At: 2024-12-07T13:31:39Z
Merged At: 2024-12-08T12:20:17Z
Participants: jrgarciadev, AnYiEE, wingkwong
Description:
Closes #
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
Bug Fixes
Resolved a missing dependency issue by adding react-types to enhance functionality and type safety.
New Features
Updated the dependency @react-types/shared to version 3.26.0 across multiple packages, improving overall functionality and compatibility.
Commits:
- fix: missing react-types package added\n- Merge branch 'canary' of github.com:nextui-org/nextui into fix/react-types-system\n- chore: react types version increased\n
Labels:
Comments:
- changeset-bot: ### 🦋 Changeset detected
Latest commit: ff63a16d648c2e86b1fee6dfdf2b661f73cab166
**The changes in this PR will be included in the next version bump.**
This PR includes changesets to release 27 packages
| Name | Type |
| ------------------------ | ----- |
| @nextui-org/system | Patch |
| @nextui-org/accordion | Patch |
| @nextui-org/autocomplete | Patch |
| @nextui-org/calendar | Patch |
| @nextui-org/checkbox | Patch |
| @nextui-org/date-input | Patch |
| @nextui-org/date-picker | Patch |
| @nextui-org/drawer | Patch |
| @nextui-org/dropdown | Patch |
| @nextui-org/form | Patch |
| @nextui-org/input-otp | Patch |
| @nextui-org/input | Patch |
| @nextui-org/listbox | Patch |
| @nextui-org/menu | Patch |
| @nextui-org/modal | Patch |
| @nextui-org/navbar | Patch |
| @nextui-org/popover | Patch |
| @nextui-org/radio | Patch |
| @nextui-org/select | Patch |
| @nextui-org/slider | Patch |
| @nextui-org/snippet | Patch |
| @nextui-org/table | Patch |
| @nextui-org/tabs | Patch |
| @nextui-org/tooltip | Patch |
| @nextui-org/react | Patch |
| @nextui-org/aria-utils | Patch |
| @nextui-org/framer-utils | Patch |
❤️ Share
- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)
- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)
- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)
- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips
### Chat
There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai):
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- `I pushed a fix in commit , please review it.`
- `Generate unit testing code for this file.`
- `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
- `@coderabbitai generate unit testing code for this file.`
- `@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.`
- `@coderabbitai read src/utils.ts and generate unit testing code.`
- `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`
- `@coderabbitai help me debug CodeRabbit configuration file.`
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
### CodeRabbit Commands (Invoked using PR comments)
- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai full review` to do a full review from scratch and review all the files again.
- `@coderabbitai summary` to regenerate the summary of the PR.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository.
- `@coderabbitai help` to get help.
### Other keywords and placeholders
- Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.
- Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description.
- Add `@coderabbitai` anywhere in the PR title to generate the title automatically.
### Documentation and Community
- Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
\n- jrgarciadev: @AnYiEE fixed, thanks for the suggestions, just checked it out and everything works as expected with the `v3.26.0` \n
Files Changed:
- .changeset/gorgeous-mice-think.md (added, 5 changes)\n Patch: @@ -0,0 +1,5 @@
+---
+"@nextui-org/system": patch
+---
+
+Fix, mising react-types package added to the system package\n- apps/docs/package.json (modified, 2 changes)\n Patch: @@ -106,7 +106,7 @@
"@next/env": "14.3.0-canary.43",
"@react-types/calendar": "3.4.10",
"@react-types/datepicker": "3.8.3",
- "@react-types/shared": "3.25.0",
+ "@react-types/shared": "3.26.0",
"@tailwindcss/typography": "^0.5.9",
"@types/canvas-confetti": "^1.4.2",
"@types/marked": "^5.0.0",\n- package.json (modified, 2 changes)\n Patch: @@ -71,7 +71,7 @@
"@commitlint/config-conventional": "^17.2.0",
"@react-bootstrap/babel-preset": "^2.1.0",
"@react-types/link": "3.5.7",
- "@react-types/shared": "3.25.0",
+ "@react-types/shared": "3.26.0",
"@storybook/react": "^8.4.5",
"@swc/core": "^1.3.35",
"@swc/jest": "^0.2.24",\n- packages/components/accordion/package.json (modified, 2 changes)\n Patch: @@ -61,7 +61,7 @@
"@react-stately/tree": "3.8.5",
"@react-aria/button": "3.10.1",
"@react-types/accordion": "3.0.0-alpha.24",
- "@react-types/shared": "3.25.0"
+ "@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/theme": "workspace:*",\n- packages/components/autocomplete/package.json (modified, 2 changes)\n Patch: @@ -62,7 +62,7 @@
"@react-aria/visually-hidden": "3.8.17",
"@react-stately/combobox": "3.10.0",
"@react-types/combobox": "3.13.0",
- "@react-types/shared": "3.25.0"
+ "@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/avatar": "workspace:*",\n- packages/components/breadcrumbs/package.json (modified, 2 changes)\n Patch: @@ -47,7 +47,7 @@
"@react-aria/breadcrumbs": "3.5.18",
"@react-aria/utils": "3.26.0",
"@react-types/breadcrumbs": "3.7.8",
- "@react-types/shared": "3.25.0"
+ "@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/theme": "workspace:*",\n- packages/components/button/package.json (modified, 2 changes)\n Patch: @@ -50,7 +50,7 @@
"@react-aria/interactions": "3.22.4",
"@react-aria/utils": "3.26.0",
"@react-aria/focus": "3.18.4",
- "@react-types/shared": "3.25.0",
+ "@react-types/shared": "3.26.0",
"@react-types/button": "3.10.0"
},
"devDependencies": {\n- packages/components/calendar/package.json (modified, 2 changes)\n Patch: @@ -59,7 +59,7 @@
"@react-stately/utils": "3.10.4",
"@react-types/calendar": "3.4.10",
"@react-aria/interactions": "3.22.4",
- "@react-types/shared": "3.25.0",
+ "@react-types/shared": "3.26.0",
"scroll-into-view-if-needed": "3.0.10",
"@types/lodash.debounce": "^4.0.7"
},\n- packages/components/card/package.json (modified, 2 changes)\n Patch: @@ -49,7 +49,7 @@
"@react-aria/utils": "3.26.0",
"@react-aria/interactions": "3.22.4",
"@react-aria/button": "3.10.1",
- "@react-types/shared": "3.25.0"
+ "@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/theme": "workspace:*",\n- packages/components/checkbox/package.json (modified, 2 changes)\n Patch: @@ -53,7 +53,7 @@
"@react-stately/checkbox": "3.6.9",
"@react-stately/toggle": "3.7.8",
"@react-types/checkbox": "3.8.4",
- "@react-types/shared": "3.25.0"
+ "@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/chip": "workspace:*",\n- packages/components/date-input/package.json (modified, 2 changes)\n Patch: @@ -48,7 +48,7 @@
"@react-aria/i18n": "3.12.3",
"@react-stately/datepicker": "3.10.3",
"@react-types/datepicker": "3.8.3",
- "@react-types/shared": "3.25.0",
+ "@react-types/shared": "3.26.0",
"@react-aria/utils": "3.26.0"
},
"devDependencies": {\n- packages/components/date-picker/package.json (modified, 2 changes)\n Patch: @@ -58,7 +58,7 @@
"@react-stately/overlays": "3.6.11",
"@react-stately/utils": "3.10.4",
"@react-types/datepicker": "3.8.3",
- "@react-types/shared": "3.25.0"
+ "@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/radio": "workspace:*",\n- packages/components/divider/package.json (modified, 2 changes)\n Patch: @@ -42,7 +42,7 @@
"@nextui-org/shared-utils": "workspace:*",
"@nextui-org/react-rsc-utils": "workspace:*",
"@nextui-org/system-rsc": "workspace:*",
- "@react-types/shared": "3.25.0"
+ "@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/theme": "workspace:*",\n- packages/components/dropdown/src/use-dropdown.ts (modified, 2 changes)\n Patch: @@ -51,7 +51,7 @@ const getMenuItem = (props: Partial> | undefined,
if (mergedChildren && mergedChildren.length) {
const item = ((mergedChildren as CollectionElement[]).find((item) => {
- if (item.key === key) {
+ if (item && item.key === key) {
return item;
}
}) || {}) as {props: MenuProps};\n- packages/components/form/package.json (modified, 2 changes)\n Patch: @@ -45,7 +45,7 @@
"@nextui-org/system": "workspace:*",
"@nextui-org/theme": "workspace:*",
"@react-aria/utils": "3.26.0",
- "@react-types/shared": "3.25.0",
+ "@react-types/shared": "3.26.0",
"@react-stately/form": "3.0.6",
"@react-types/form": "^3.7.8"
},\n- packages/components/input/package.json (modified, 2 changes)\n Patch: @@ -50,7 +50,7 @@
"@react-aria/textfield": "3.14.10",
"@react-aria/utils": "3.26.0",
"@react-stately/utils": "3.10.4",
- "@react-types/shared": "3.25.0",
+ "@react-types/shared": "3.26.0",
"@react-types/textfield": "3.9.7",
"react-textarea-autosize": "^8.5.3"
},\n- packages/components/listbox/package.json (modified, 2 changes)\n Patch: @@ -52,7 +52,7 @@
"@react-aria/focus": "3.18.4",
"@react-aria/interactions": "3.22.4",
"@react-types/menu": "3.9.12",
- "@react-types/shared": "3.25.0"
+ "@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/avatar": "workspace:*",\n- packages/components/menu/package.json (modified, 2 changes)\n Patch: @@ -53,7 +53,7 @@
"@react-stately/menu": "3.8.3",
"@react-stately/tree": "3.8.5",
"@react-types/menu": "3.9.12",
- "@react-types/shared": "3.25.0"
+ "@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/theme": "workspace:*",\n- packages/components/radio/package.json (modified, 2 changes)\n Patch: @@ -50,7 +50,7 @@
"@react-aria/visually-hidden": "3.8.17",
"@react-stately/radio": "3.10.8",
"@react-types/radio": "3.8.4",
- "@react-types/shared": "3.25.0"
+ "@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/theme": "workspace:*",\n- packages/components/select/package.json (modified, 2 changes)\n Patch: @@ -58,7 +58,7 @@
"@react-aria/interactions": "3.22.4",
"@react-aria/utils": "3.26.0",
"@react-aria/visually-hidden": "3.8.17",
- "@react-types/shared": "3.25.0",
+ "@react-types/shared": "3.26.0",
"@tanstack/react-virtual": "3.10.9"
},
"devDependencies": {\n- packages/components/switch/package.json (modified, 2 changes)\n Patch: @@ -49,7 +49,7 @@
"@react-aria/utils": "3.26.0",
"@react-aria/visually-hidden": "3.8.17",
"@react-stately/toggle": "3.7.8",
- "@react-types/shared": "3.25.0"
+ "@react-types/shared": "3.26.0"
},
"devDependencies": {
"@nextui-org/theme": "workspace:*",\n- packages/components/tabs/package.json (modified, 2 changes)\n Patch: @@ -52,7 +52,7 @@
"@react-aria/tabs": "3.9.7",
"@react-aria/utils": "3.26.0",
"@react-stately/tabs": "3.6.10",
- "@react-types/shared": "3.25.0",
+ "@react-types/shared": "3.26.0",
"@react-types/tabs": "3.3.10",
"scroll-into-view-if-needed": "3.0.10"
},\n- packages/core/system-rsc/package.json (modified, 2 changes)\n Patch: @@ -46,7 +46,7 @@
"clean-package": "2.2.0"
},
"dependencies": {
- "@react-types/shared": "3.25.0",
+ "@react-types/shared": "3.26.0",
"clsx": "^1.2.1"
},
"clean-package": "../../../clean-package.config.json",\n- packages/core/system/package.json (modified, 3 changes)\n Patch: @@ -61,6 +61,7 @@
"@react-aria/overlays": "3.23.4",
"@react-aria/utils": "3.26.0",
"@react-stately/utils": "3.10.4",
- "@react-types/datepicker": "3.8.3"
+ "@react-types/datepicker": "3.8.3",
+ "@react-types/shared": "3.26.0"
}
}\n- packages/hooks/use-aria-accordion-item/package.json (modified, 2 changes)\n Patch: @@ -37,7 +37,7 @@
"@react-aria/button": "3.10.1",
"@react-aria/focus": "3.18.4",
"@react-stately/tree": "3.8.5",
- "@react-types/shared": "3.25.0"
+ "@react-types/shared": "3.26.0"
},
"peerDependencies": {
"react": ">=18 || >=19.0.0-rc.0"\n- packages/hooks/use-aria-accordion/package.json (modified, 2 changes)\n Patch: @@ -40,7 +40,7 @@
"@react-aria/utils": "3.26.0",
"@react-stately/tree": "3.8.5",
"@react-types/accordion": "3.0.0-alpha.24",
- "@react-types/shared": "3.25.0"
+ "@react-types/shared": "3.26.0"
},
"peerDependencies": {
"react": ">=18 || >=19.0.0-rc.0"\n- packages/hooks/use-aria-button/package.json (modified, 2 changes)\n Patch: @@ -41,7 +41,7 @@
"@react-aria/interactions": "3.22.4",
"@react-aria/utils": "3.26.0",
"@react-types/button": "3.10.0",
- "@react-types/shared": "3.25.0"
+ "@react-types/shared": "3.26.0"
},
"devDependencies": {
"clean-package": "2.2.0",\n- packages/hooks/use-aria-link/package.json (modified, 2 changes)\n Patch: @@ -41,7 +41,7 @@
"@react-aria/interactions": "3.22.4",
"@react-aria/utils": "3.26.0",
"@react-types/link": "3.5.8",
- "@react-types/shared": "3.25.0"
+ "@react-types/shared": "3.26.0"
},
"devDependencies": {
"clean-package": "2.2.0",\n- packages/hooks/use-aria-menu/package.json (modified, 2 changes)\n Patch: @@ -39,7 +39,7 @@
},
"dependencies": {
"@react-aria/utils": "3.26.0",
- "@react-types/shared": "3.25.0",
+ "@react-types/shared": "3.26.0",
"@react-aria/menu": "3.15.5",
"@react-aria/interactions": "3.22.4",
"@react-stately/tree": "3.8.5",\n- packages/hooks/use-aria-modal-overlay/package.json (modified, 2 changes)\n Patch: @@ -37,7 +37,7 @@
"@react-aria/overlays": "3.23.4",
"@react-aria/utils": "3.26.0",
"@react-stately/overlays": "3.6.11",
- "@react-types/shared": "3.25.0"
+ "@react-types/shared": "3.26.0"
},
"peerDependencies": {
"react": ">=18 || >=19.0.0-rc.0",\n