Refactor position requirement functions in Streamlit app to simplify calculations for QB, RB, WR, and TE. Updated base position requirements to use fixed values and improved handling of league settings for accurate index calculations.

src/streamlit_app.py

@@ -273,10 +273,10 @@ def designate_custom_position_reqs(league_settings: dict, flex_percentiles: dict
     wr_base = league_settings['WR'] * league_settings['TEAMS']
     te_base = league_settings['TE'] * league_settings['TEAMS']
 
-    qb_rv_index = math.ceil((qb_base) * flex_multipliers[league_settings['TYPE']]['QB'])
-    rb_rv_index = math.ceil((rb_base + ((league_settings['TEAMS'] * league_settings['FLEX']) * flex_percentiles[league_settings['TYPE']]['RB'])) * flex_multipliers[league_settings['TYPE']]['RB'])
-    wr_rv_index = math.ceil((wr_base + ((league_settings['TEAMS'] * league_settings['FLEX']) * flex_percentiles[league_settings['TYPE']]['WR'])) * flex_multipliers[league_settings['TYPE']]['WR'])
-    te_rv_index = math.ceil((te_base + ((league_settings['TEAMS'] * league_settings['FLEX']) * flex_percentiles[league_settings['TYPE']]['TE'])) * flex_multipliers[league_settings['TYPE']]['TE'])
+    qb_rv_index = math.ceil((qb_base) * flex_multipliers['QB'])
+    rb_rv_index = math.ceil((rb_base + ((league_settings['TEAMS'] * league_settings['FLEX']) * flex_percentiles['RB'])) * flex_multipliers['RB'])
+    wr_rv_index = math.ceil((wr_base + ((league_settings['TEAMS'] * league_settings['FLEX']) * flex_percentiles['WR'])) * flex_multipliers['WR'])
+    te_rv_index = math.ceil((te_base + ((league_settings['TEAMS'] * league_settings['FLEX']) * flex_percentiles['TE'])) * flex_multipliers['TE'])
     
     print(f"Need {qb_rv_index} for QB in {league_settings['TEAMS']} teams with type {league_settings['TYPE']}")
     print(f"Need {rb_rv_index} for RB in {league_settings['TEAMS']} teams with type {league_settings['TYPE']}")
@@ -292,21 +292,21 @@ def designate_custom_position_reqs(league_settings: dict, flex_percentiles: dict
     
     return pos_reqs
 
-def designate_base_position_reqs(league_settings: dict, flex_percentiles: dict, flex_multipliers: dict) -> dict:
-    qb_base = league_settings['QB'] * league_settings['TEAMS']
-    rb_base = league_settings['RB'] * league_settings['TEAMS']
-    wr_base = league_settings['WR'] * league_settings['TEAMS']
-    te_base = league_settings['TE'] * league_settings['TEAMS']
+def designate_base_position_reqs() -> dict:
+    qb_base = 1 * 12
+    rb_base = 2 * 12
+    wr_base = 3 * 12
+    te_base = 1 * 12
 
-    qb_rv_index = math.ceil(qb_base * flex_multipliers[league_settings['TYPE']]['QB'])
-    rb_rv_index = math.ceil((rb_base + ((league_settings['TEAMS'] * league_settings['FLEX']) * flex_percentiles[league_settings['TYPE']]['RB'])) * flex_multipliers[league_settings['TYPE']]['RB'])
-    wr_rv_index = math.ceil((wr_base + ((league_settings['TEAMS'] * league_settings['FLEX']) * flex_percentiles[league_settings['TYPE']]['WR'])) * flex_multipliers[league_settings['TYPE']]['WR'])
-    te_rv_index = math.ceil((te_base + ((league_settings['TEAMS'] * league_settings['FLEX']) * flex_percentiles[league_settings['TYPE']]['TE'])) * flex_multipliers[league_settings['TYPE']]['TE'])
+    qb_rv_index = math.ceil(qb_base * 2)
+    rb_rv_index = math.ceil((rb_base + ((12 * 1) * .75)) * 2)
+    wr_rv_index = math.ceil((wr_base + ((12 * 1) * .75)) * 2)
+    te_rv_index = math.ceil((te_base + ((12 * 1) * .5)) * 2)
     
-    print(f"Need {qb_rv_index} for QB in {league_settings['TEAMS']} teams with type {league_settings['TYPE']}")
-    print(f"Need {rb_rv_index} for RB in {league_settings['TEAMS']} teams with type {league_settings['TYPE']}")
-    print(f"Need {wr_rv_index} for WR in {league_settings['TEAMS']} teams with type {league_settings['TYPE']}")
-    print(f"Need {te_rv_index} for TE in {league_settings['TEAMS']} teams with type {league_settings['TYPE']}")
+    print(f"Need {qb_rv_index} for QB in {12} teams with type {league_settings['TYPE']}")
+    print(f"Need {rb_rv_index} for RB in {12} teams with type {league_settings['TYPE']}")
+    print(f"Need {wr_rv_index} for WR in {12} teams with type {league_settings['TYPE']}")
+    print(f"Need {te_rv_index} for TE in {12} teams with type {league_settings['TYPE']}")
 
     pos_reqs = {
         'QB': qb_rv_index,
@@ -396,11 +396,12 @@ def main():
     position_df = create_position_frames(projections_df, ranks_dict)
     
     # Calculate position requirements
-    pos_reqs = designate_custom_position_reqs(user_league_settings, user_flex_percentiles, user_flex_multipliers)
+    base_pos_reqs = designate_base_position_reqs(base_settings, user_flex_percentiles, user_flex_multipliers)
+    custom_pos_reqs = designate_custom_position_reqs(user_league_settings, user_flex_percentiles, user_flex_multipliers)
     
     # Calculate replacement values
-    halfPpr_rv = create_halfPpr_rv(position_df, pos_reqs)
-    custom_rv = create_custom_rv(position_df, pos_reqs, user_league_settings)
+    halfPpr_rv = create_halfPpr_rv(position_df, base_pos_reqs)
+    custom_rv = create_custom_rv(position_df, custom_pos_reqs, user_league_settings)
     
     # Calculate VORP and rankings
     final_df = assign_vorp(position_df, halfPpr_rv, custom_rv, user_league_settings, user_pos_vorp_limiters)