Added a column with the token interval of the matches for each spec sentence

odinsynth_dataset.py

@@ -16,28 +16,7 @@ class OdinsynthDatasetBuilder(datasets.GeneratorBasedBuilder):
 
     VERSION = datasets.Version("1.0.0")
 
-    # This is an example of a dataset with multiple configurations.
-    # If you don't want/need to define several sub-sets in your dataset,
-    # just remove the BUILDER_CONFIG_CLASS and the BUILDER_CONFIGS attributes.
-
-    # If you need to make complex sub-parts in the datasets with configurable options
-    # You can create your own builder configuration class to store attribute, inheriting from datasets.BuilderConfig
-    # BUILDER_CONFIG_CLASS = MyBuilderConfig
-
-    # You will be able to load one or the other configurations in the following list with
-    # data = datasets.load_dataset('my_dataset', 'first_domain')
-    # data = datasets.load_dataset('my_dataset', 'second_domain')
-    # BUILDER_CONFIGS = [
-    #     datasets.BuilderConfig(name="first_domain", version=VERSION, description="This part of my dataset covers a first domain"),
-    #     datasets.BuilderConfig(name="second_domain", version=VERSION, description="This part of my dataset covers a second domain"),
-    # ]
-    #
-    # DEFAULT_CONFIG_NAME = "first_domain"  # It's not mandatory to have a default configuration. Just use one if it make sense.
-
-
-
     def _info(self):
-        # TODO: This method specifies the datasets.DatasetInfo object which contains informations and typings for the dataset
 
         features = datasets.Features(
             {
@@ -46,6 +25,7 @@ class OdinsynthDatasetBuilder(datasets.GeneratorBasedBuilder):
                 "child": datasets.Value("string"),
                 "negative_child": datasets.Value("string"),
                 "spec": datasets.Sequence(datasets.Value("string")),
+                "matches": datasets.Sequence(datasets.Sequence(datasets.Value("int16"))),
                 "step": datasets.Value("int8"),
                 "length": datasets.Value("int8")
             }
@@ -69,21 +49,25 @@ class OdinsynthDatasetBuilder(datasets.GeneratorBasedBuilder):
 
     def _build_specs(self, path:str):
         id_to_rule = {}
-        specs = defaultdict(set)
+        specs = defaultdict(list)
+        matches = defaultdict(list)
         with open(path) as f:
             for l in tqdm(f, desc="Pre-computing specs"):
                 try:
                     instance = json.loads(l)
-                    rule_id = int(instance['id'])
-                    rule = instance['question']
-                    sent  = instance['context']
-                    specs[rule].add(sent)
-                    id_to_rule[rule_id] = rule
+                    if instance['match']:
+                        rule_id = int(instance['id'])
+                        rule = instance['question']
+                        sent  = instance['context']
+                        if sent not in specs[rule]:
+                            specs[rule].append(sent)
+                            matches[rule].append([instance['match_start'], instance['match_end']])
+                            id_to_rule[rule_id] = rule
                 except:
                     # TODO log
                     pass
 
-        return {rule_id:specs[rule] for rule_id, rule in id_to_rule.items()}
+        return {rule_id:(specs[rule], matches[rule]) for rule_id, rule in id_to_rule.items()}
 
 
 
@@ -138,12 +122,16 @@ class OdinsynthDatasetBuilder(datasets.GeneratorBasedBuilder):
                 for row in reader:
                     rule_id = int(row[0])
                     if rule_id in specs:
+                        spec, matches = specs[rule_id]
+                        assert len(spec) == len(matches), f"Rule id {id} has different number of sentences and matches"
+
                         yield key, {
                             "rule_id": rule_id,
                             "parent": row[1],
                             "child": row[2],
                             "negative_child": row[3],
-                            "spec": specs[rule_id],
+                            "spec": spec,
+                            "matches": matches,
                             "step": int(row[4]),
                             "length": int(row[5]),
                         }